Re: Review Request 126291: initial implementation of a platform plugin for OS X (WIP)

2016-02-24 Thread Martin Gräßlin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126291/#review92753
---



I don't like the introduction of the SCRAPBOOK. The repository is not the place 
for dead and old code. That's what git already supports with keeping the whole 
history.

We have some autotests for kwindowsystem. Could you try whether the tests work 
also on OSX?


src/kwindowsystem.cpp (lines 465 - 467)


I would prefer to not introduce new platform specific code in the shared 
part.

The idea you have here is right, but it's not OSX specific, the same 
applies for e.g. Wayland



src/platforms/osx/plugin.h (line 2)


I'm not the author of this file



src/platforms/osx/plugin.cpp (line 2)


I'm not the author of this file


- Martin Gräßlin


On Feb. 23, 2016, 10:54 p.m., René J.V. Bertin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126291/
> ---
> 
> (Updated Feb. 23, 2016, 10:54 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and KDE Frameworks.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> ---
> 
> KWindowSystem has been lacking a platform plugin for OS X. This RR presents a 
> "backport" of the modified KDE4 KWindowSystem implementation that has been 
> used in the MacPorts kdelibs4 port for the last 2 or 3 (or more) years.
> 
> I have made some initial steps to remove deprecated Carbon API calls, but 
> this is clearly a work in progress.
> 
> Open questions include
> - is there any justification to run an event handler (or Cocoa observer) to 
> keep track of running applications, possibly even listing all their open 
> windows?
> - is there any use for the Qt event listener framework (cf. the 
> NETEventFilter in the X11 plugin)? I haven't yet had time to try to figure 
> out what this "could be good for", and am very open to suggestions in this 
> departments.
> - one application for such an event filter would be a listener that catches 
> the opening and closing of all windows by the running process, and keeps 
> track of their `WId`s. A new method could then be added (to `KWindowInfo`?) 
> to distinguish `WId`s created by the running application from "foreign" ones 
> (useful also on Wayland and MS Windows).
> 
> `KWindowSystem::setMainWindow` should become a front for payload provided by 
> the plugins. I'll leave that to the regular/official maintainer(s) of this 
> framework.
> 
> This code could probably do with *lots* of comments; I'll try to add them as 
> questions about this or that bit of code arise.
> 
> 
> Diffs
> -
> 
>   src/debug_p.h 5ef8996 
>   src/debug_p.cpp 72abfb7 
>   src/kwindowsystem.cpp 407a67d 
>   src/platforms/osx/CMakeLists.txt 4fc3347 
>   src/platforms/osx/SCRAPBOOK PRE-CREATION 
>   src/platforms/osx/cocoa.json PRE-CREATION 
>   src/platforms/osx/kkeyserver.cpp 3ddb921 
>   src/platforms/osx/kwindowinfo.cpp e8555bb 
>   src/platforms/osx/kwindowinfo.mm PRE-CREATION 
>   src/platforms/osx/kwindowinfo_mac_p.h c8f307e 
>   src/platforms/osx/kwindowinfo_p_cocoa.h PRE-CREATION 
>   src/platforms/osx/kwindowsystem.cpp 1758829 
>   src/platforms/osx/kwindowsystem_mac_p.h PRE-CREATION 
>   src/platforms/osx/kwindowsystem_macobjc.mm PRE-CREATION 
>   src/platforms/osx/kwindowsystem_p_cocoa.h PRE-CREATION 
>   src/platforms/osx/plugin.h PRE-CREATION 
>   src/platforms/osx/plugin.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126291/diff/
> 
> 
> Testing
> ---
> 
> On OS X 10.9.5 with Qt 5.5.1 and frameworks 5.16.0 .
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127031: Add function to get runtime frameworks version information

2016-02-24 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127031/
---

(Updated Feb. 25, 2016, 1:02 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit 8e7c156b8c812cbeac499829c9874dfcf7e09a85 by David 
Edmundson to branch master.


Repository: kcoreaddons


Description
---

Adds a method similar to qVersion() that returns a string of the
frameworks version being run. This differs from the header file which
can only provide the version this app is compiled against.

The intended usage is in drkonqi system information.


Diffs
-

  src/lib/CMakeLists.txt a36eed26a281baf9ef1064dfb9aed3c394c52604 
  src/lib/kcoreaddons.h PRE-CREATION 
  src/lib/kcoreaddons.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/127031/diff/


Testing
---

See https://git.reviewboard.kde.org/r/127032/


Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127169: By default, make KDE_INSTALL_USE_QT_SYS_PATHS share the same directory scheme as Qt if they share the prefix

2016-02-24 Thread Nicolás Alvarez 


> On Feb. 24, 2016, 4:06 p.m., Stephen Kelly wrote:
> > Hi Aleix,
> > 
> > I'm not familiar with the 'tiny mess'. Can you say what it is? I would 
> > expect the libs go in the same place, but maybe the plugins are affected by 
> > this? Can you be more specific?
> > 
> > Thanks,
> 
> Aleix Pol Gonzalez wrote:
> Well, Qt might be installing things in `$prefix/lib` and cmake in 
> `$prefix/lib64`. In fact, Qt by default installs plugins in `$prefix/plugins` 
> (which looks really odd, I agree).
> In any case, if it's meant to go to the same place, let's just ask Qt 
> where to go.
> 
> As you can see, all of the distros are already specifying this: (and they 
> don't need to in fact, because it's the same prefix)
> 
> https://projects.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/kcoreaddons
> 
> http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/wily/pkg-kde-tools/wily/view/head:/datalib/kf5_flags
> https://pkgs.fedoraproject.org/cgit/rpms/kf5.git/tree/macros.kf5

I don't think "all distros set it" is a valid argument for changing a default, 
otherwise we would be setting `CMAKE_INSTALL_PREFIX=/usr` by default too.


- Nicolás


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127169/#review92739
---


On Feb. 24, 2016, 2:09 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127169/
> ---
> 
> (Updated Feb. 24, 2016, 2:09 p.m.)
> 
> 
> Review request for Extra Cmake Modules, KDE Frameworks and Albert Vaca 
> Cintora.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> ---
> 
> Make Qt and ECM-based projects use the same directory sctructure (i.e. where 
> plugins are, libs, etc.) by default. Otherwise it creates a tiny mess that 
> might be controlled but usually won't.
> 
> In the end, otherwise, people need to keep adapting their systems with 
> environment variables anyway. All distros end up setting always this setting 
> as ON, as well as brave developers who don't have separate prefixes for Qt 
> and KDE.
> 
> 
> Diffs
> -
> 
>   kde-modules/KDEInstallDirs.cmake ebd48fa 
> 
> Diff: https://git.reviewboard.kde.org/r/127169/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127090: Clean KWalletQuery cmake file

2016-02-24 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127090/
---

(Updated Feb. 25, 2016, 12:34 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Valentin Rusu.


Changes
---

Submitted with commit 94c5348663e7457a3741af2e5e355c6923c71140 by Aleix Pol to 
branch master.


Repository: kwallet


Description
---

I saw it didn't build because I needed a build with KDocTools, ended up 
cleaning a bit more.


Diffs
-

  src/runtime/kwallet-query/CMakeLists.txt 42b4687 
  src/runtime/kwallet-query/src/main.cpp c19cb29 

Diff: https://git.reviewboard.kde.org/r/127090/diff/


Testing
---

Built with and without KDocTools.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127169: By default, make KDE_INSTALL_USE_QT_SYS_PATHS share the same directory scheme as Qt if they share the prefix

2016-02-24 Thread Aleix Pol Gonzalez 


> On Feb. 24, 2016, 8:06 p.m., Stephen Kelly wrote:
> > Hi Aleix,
> > 
> > I'm not familiar with the 'tiny mess'. Can you say what it is? I would 
> > expect the libs go in the same place, but maybe the plugins are affected by 
> > this? Can you be more specific?
> > 
> > Thanks,

Well, Qt might be installing things in `$prefix/lib` and cmake in 
`$prefix/lib64`. In fact, Qt by default installs plugins in `$prefix/plugins` 
(which looks really odd, I agree).
In any case, if it's meant to go to the same place, let's just ask Qt where to 
go.

As you can see, all of the distros are already specifying this: (and they don't 
need to in fact, because it's the same prefix)
https://projects.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/kcoreaddons
http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/wily/pkg-kde-tools/wily/view/head:/datalib/kf5_flags
https://pkgs.fedoraproject.org/cgit/rpms/kf5.git/tree/macros.kf5


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127169/#review92739
---


On Feb. 24, 2016, 6:09 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127169/
> ---
> 
> (Updated Feb. 24, 2016, 6:09 p.m.)
> 
> 
> Review request for Extra Cmake Modules, KDE Frameworks and Albert Vaca 
> Cintora.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> ---
> 
> Make Qt and ECM-based projects use the same directory sctructure (i.e. where 
> plugins are, libs, etc.) by default. Otherwise it creates a tiny mess that 
> might be controlled but usually won't.
> 
> In the end, otherwise, people need to keep adapting their systems with 
> environment variables anyway. All distros end up setting always this setting 
> as ON, as well as brave developers who don't have separate prefixes for Qt 
> and KDE.
> 
> 
> Diffs
> -
> 
>   kde-modules/KDEInstallDirs.cmake ebd48fa 
> 
> Diff: https://git.reviewboard.kde.org/r/127169/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127090: Clean KWalletQuery cmake file

2016-02-24 Thread Sebastian Kügler 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127090/#review92744
---


Ship it!




Ship It!

- Sebastian Kügler


On Feb. 16, 2016, 3:19 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127090/
> ---
> 
> (Updated Feb. 16, 2016, 3:19 p.m.)
> 
> 
> Review request for KDE Frameworks and Valentin Rusu.
> 
> 
> Repository: kwallet
> 
> 
> Description
> ---
> 
> I saw it didn't build because I needed a build with KDocTools, ended up 
> cleaning a bit more.
> 
> 
> Diffs
> -
> 
>   src/runtime/kwallet-query/CMakeLists.txt 42b4687 
>   src/runtime/kwallet-query/src/main.cpp c19cb29 
> 
> Diff: https://git.reviewboard.kde.org/r/127090/diff/
> 
> 
> Testing
> ---
> 
> Built with and without KDocTools.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125987: KFontSettingsData autotest: dbus connect happens with QueuedConnection, wait for it.

2016-02-24 Thread David Faure 


> On Feb. 24, 2016, 8:29 a.m., Martin Gräßlin wrote:
> > should we also add this change to plasma-integration?
> 
> David Faure wrote:
> Indeed, I have the same unittest failure there.
> 
> -asterix- dfaure 9:55 
> /s/kde/build/5/kde/workspace/plasma-integration/autotests>./kfontsettingsdata_unittest
>  
> * Start testing of KFontSettingsData_UnitTest *
> Config: Using QtTest library 5.6.0, Qt 5.6.0 (x86_64-little_endian-lp64 
> shared (dynamic) debug build; by GCC 4.8.3 20140627 [gcc-4_8-branch revision 
> 212064])
> PASS   : KFontSettingsData_UnitTest::initTestCase()
> PASS   : KFontSettingsData_UnitTest::_q_showIfNotHidden()
> PASS   : KFontSettingsData_UnitTest::testFonts()
> QWARN  : KFontSettingsData_UnitTest::testFontsChanged() 
> kfontsettingsdata_unittest(11964)/default KIconTheme::KIconTheme: Icon theme 
> "non-existent-icon-theme" not found.
> FAIL!  : KFontSettingsData_UnitTest::testFontsChanged() Compared values 
> are not the same
>Actual   (m_fonts->font(KFontSettingsData::GeneralFont)->family()): 
> "OxyFontTest"
>Expected (QStringLiteral("ChangedFontTest"))  : 
> "ChangedFontTest"
>Loc: 
> [/d/kde/src/5/kde/workspace/plasma-integration/autotests/kfontsettingsdata_unittest.cpp(107)]
> PASS   : KFontSettingsData_UnitTest::cleanupTestCase()
> Totals: 4 passed, 1 failed, 0 skipped, 0 blacklisted
> * Finished testing of KFontSettingsData_UnitTest *
> 
> Can you forwardport? (otherwise I'll do it tonight)

Done now. 
http://commits.kde.org/plasma-integration/36bc1c1ee0ef09adaff31dc95d998f7a04544ceb


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125987/#review92709
---


On Feb. 24, 2016, 8:05 a.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125987/
> ---
> 
> (Updated Feb. 24, 2016, 8:05 a.m.)
> 
> 
> Review request for KDE Frameworks and Àlex Fiestas.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> KFontSettingsData autotest: dbus connect happens with QueuedConnection, wait 
> for it.
> 
> 
> Diffs
> -
> 
>   autotests/kfontsettingsdata_unittest.cpp 
> 56ba9458625e2f39622251467ee39b388fc6508d 
> 
> Diff: https://git.reviewboard.kde.org/r/125987/diff/
> 
> 
> Testing
> ---
> 
> This fixes ./kfontsettingsdata_unittest on my machine. I'm not sure how it 
> passes on CI at all...
> 
> 
> Thanks,
> 
> David Faure
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127158: Adds writer and external (extractor and writer) plugin support

2016-02-24 Thread Varun Joshi 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127158/
---

(Updated Feb. 24, 2016, 8:34 p.m.)


Status
--

This change has been discarded.


Review request for Baloo, KDE Frameworks and Vishesh Handa.


Repository: kfilemetadata


Description
---

Builds upon Boudhyan Gupta's work on external extractors, creating a process 
that runs a script that extracts/writes data, accepting input and producing an 
output (JSON-formatted) via stdin/stdout.

Adds Writer, WriterData, WriterPlugin and WriterCollection classes, analogous 
to the Extractor classes. The only notable difference is that consumer 
applications will be able to use WriteData (analogous to ExtractionResult) 
without subclassing it.

Adds ExternalWriter and ExternalExtractor classes. These handle input/output 
and communication with the external plugins.


Diffs
-

  README.md 19b1a26a241e6a35c636aaf8162afe762018f073 
  autotests/CMakeLists.txt 9d308367838680f1081cfa3b583d3401412c21c1 
  autotests/taglibwritertest.h PRE-CREATION 
  autotests/taglibwritertest.cpp PRE-CREATION 
  src/CMakeLists.txt a5490856a51aa2f59389ee963f3430c1ce5c60d5 
  src/config-kfilemetadata.h.in PRE-CREATION 
  src/externalextractor.h PRE-CREATION 
  src/externalextractor.cpp PRE-CREATION 
  src/externalwriter.h PRE-CREATION 
  src/externalwriter.cpp PRE-CREATION 
  src/extractorcollection.h 8542aed576102be2b0c86bbdf3d65d756d468c6e 
  src/extractorcollection.cpp a1bde65bf57e493918cd3e85ccdb23c4cd623401 
  src/extractorplugin.h 65abad3b2397628ba42a40d9ef2970e02114e250 
  src/extractors/CMakeLists.txt 5dd223e1cf6864a943e848664ad5fae0d0603e77 
  src/extractors/externalextractors/CMakeLists.txt PRE-CREATION 
  src/extractors/externalextractors/exampleextractor/main.py PRE-CREATION 
  src/extractors/externalextractors/exampleextractor/manifest.json PRE-CREATION 
  src/extractors/externalextractors/pdfextractor/main.py PRE-CREATION 
  src/extractors/externalextractors/pdfextractor/manifest.json PRE-CREATION 
  src/writedata.h PRE-CREATION 
  src/writedata.cpp PRE-CREATION 
  src/writer.h PRE-CREATION 
  src/writer.cpp PRE-CREATION 
  src/writer_p.h PRE-CREATION 
  src/writercollection.h PRE-CREATION 
  src/writercollection.cpp PRE-CREATION 
  src/writerplugin.h PRE-CREATION 
  src/writerplugin.cpp PRE-CREATION 
  src/writers/CMakeLists.txt PRE-CREATION 
  src/writers/externalwriters/CMakeLists.txt PRE-CREATION 
  src/writers/externalwriters/pdfwriter/main.py PRE-CREATION 
  src/writers/externalwriters/pdfwriter/manifest.json PRE-CREATION 
  src/writers/taglibwriter.h PRE-CREATION 
  src/writers/taglibwriter.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/127158/diff/


Testing
---

Created a sample PDF reader and extractor in Python, both of which work 
successfully.


Thanks,

Varun Joshi

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127033: Add /../share/hunspell/ to dictionary search path

2016-02-24 Thread Kåre Särs 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127033/
---

(Updated Feb. 24, 2016, 8:25 p.m.)


Review request for KDE Frameworks, Laurent Montel and Martin Tobias Holmedahl 
Sandsmark.


Changes
---

Use QFile::encodeName() and add '/' in composeDictName()


Repository: sonnet


Description
---

The default search path for hunspell dictionaries is /usr/share/hunspell/, but 
that is not a very common directory on windows ;)

For Windows and Mac there are some extra search paths defined in side #ifdefs, 
but they are hardcoded to the LibreOffice dictionary directories. Unfortunately 
the extra Windows path points to a 32bit LibreOffice 5 on a 64 bit Windows 
directory. This patch adds /../share/hunspell/ to the search path in 
case the default is not found. 

If wanted I can add a CMake define for specifying the path relative to the 
application directory.


Diffs (updated)
-

  src/core/guesslanguage.cpp e8deb90 
  src/plugins/hunspell/CMakeLists.txt 144515b 
  src/plugins/hunspell/hunspellclient.cpp 3da7219 
  src/plugins/hunspell/hunspelldict.h b825d7d 
  src/plugins/hunspell/hunspelldict.cpp bc5c314 

Diff: https://git.reviewboard.kde.org/r/127033/diff/


Testing
---

Compiled Sonnet and Kate on Windows and got spelling to work :)

It is now possible to add dictionaries to a relocatable /../share/hunspell/ and get spelling to work without depending on 
LibreOffice installation on Windows.


Thanks,

Kåre Särs

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127033: Add /../share/hunspell/ to dictionary search path

2016-02-24 Thread Kåre Särs 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127033/
---

(Updated Feb. 24, 2016, 8:25 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Laurent Montel and Martin Tobias Holmedahl 
Sandsmark.


Changes
---

Submitted with commit af4c6011d545fec7bf5a1a0a548ae68aa96e2fc8 by Kåre Särs to 
branch master.


Repository: sonnet


Description
---

The default search path for hunspell dictionaries is /usr/share/hunspell/, but 
that is not a very common directory on windows ;)

For Windows and Mac there are some extra search paths defined in side #ifdefs, 
but they are hardcoded to the LibreOffice dictionary directories. Unfortunately 
the extra Windows path points to a 32bit LibreOffice 5 on a 64 bit Windows 
directory. This patch adds /../share/hunspell/ to the search path in 
case the default is not found. 

If wanted I can add a CMake define for specifying the path relative to the 
application directory.


Diffs
-

  src/core/guesslanguage.cpp e8deb90 
  src/plugins/hunspell/CMakeLists.txt 144515b 
  src/plugins/hunspell/hunspellclient.cpp 3da7219 
  src/plugins/hunspell/hunspelldict.h b825d7d 
  src/plugins/hunspell/hunspelldict.cpp bc5c314 

Diff: https://git.reviewboard.kde.org/r/127033/diff/


Testing
---

Compiled Sonnet and Kate on Windows and got spelling to work :)

It is now possible to add dictionaries to a relocatable /../share/hunspell/ and get spelling to work without depending on 
LibreOffice installation on Windows.


Thanks,

Kåre Särs

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127169: By default, make KDE_INSTALL_USE_QT_SYS_PATHS share the same directory scheme as Qt if they share the prefix

2016-02-24 Thread Stephen Kelly 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127169/#review92739
---



Hi Aleix,

I'm not familiar with the 'tiny mess'. Can you say what it is? I would expect 
the libs go in the same place, but maybe the plugins are affected by this? Can 
you be more specific?

Thanks,

- Stephen Kelly


On Feb. 24, 2016, 5:09 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127169/
> ---
> 
> (Updated Feb. 24, 2016, 5:09 p.m.)
> 
> 
> Review request for Extra Cmake Modules, KDE Frameworks and Albert Vaca 
> Cintora.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> ---
> 
> Make Qt and ECM-based projects use the same directory sctructure (i.e. where 
> plugins are, libs, etc.) by default. Otherwise it creates a tiny mess that 
> might be controlled but usually won't.
> 
> In the end, otherwise, people need to keep adapting their systems with 
> environment variables anyway. All distros end up setting always this setting 
> as ON, as well as brave developers who don't have separate prefixes for Qt 
> and KDE.
> 
> 
> Diffs
> -
> 
>   kde-modules/KDEInstallDirs.cmake ebd48fa 
> 
> Diff: https://git.reviewboard.kde.org/r/127169/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127159: Make the KPeople qml example slightly more usable

2016-02-24 Thread Martin Klapetek 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127159/
---

(Updated Feb. 24, 2016, 6:08 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, KDEPIM and Plasma.


Changes
---

Submitted with commit 6ef69a8a17985926ad89543ba932f835d455cec8 by Martin 
Klapetek to branch master.


Repository: kpeople


Description
---

I've done this quite some time ago but noticed only just now that I still have 
it locally
* makes it less aggressive removing the red color
* removes the other two colorful rectangles serving seemingly no purpose
* moves the selected contact photo above the data
* makes the contact grid delegates nicer
* makes the default window size bigger


Diffs
-

  examples/qml/Main.qml 8d3a100 

Diff: https://git.reviewboard.kde.org/r/127159/diff/


Testing
---

Functionality is kept, for looks see screenshots


File Attachments


Before
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/02/23/cfcc2a9e-bc54-4031-85a6-9368f70f8056__snapshot96.png
After
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/02/23/e87bd7e0-9420-4ac4-919a-8a78cd7abc26__snapshot95.png


Thanks,

Martin Klapetek

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127117: Reverse the filtering logic

2016-02-24 Thread Martin Klapetek 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127117/
---

(Updated Feb. 24, 2016, 6:08 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and KDEPIM.


Changes
---

Submitted with commit bdff68dea3cbe5e59d7c65c7961667ddab0849dc by Martin 
Klapetek to branch master.


Repository: kpeople


Description
---

For filtering multiple properties the logic needs to be OR
rather than AND.

For example in Plasma Mobile, one can start a conversation
either with a phonenumber contact or IM contact, so both
properties need to be requested. But with AND matching it
won't return anything (or only those contacts that have both
and user merged them).


Diffs
-

  autotests/fakecontactsource.cpp b227723 
  autotests/personsproxymodeltest.cpp 1143e5f 
  src/personssortfilterproxymodel.cpp b011cbd 

Diff: https://git.reviewboard.kde.org/r/127117/diff/


Testing
---

I get both phonenumber and IM contacts in Plasma Mobile


Thanks,

Martin Klapetek

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127164: Add actionType to the declarative plugin

2016-02-24 Thread Martin Klapetek 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127164/
---

(Updated Feb. 24, 2016, 6:08 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and KDEPIM.


Changes
---

Submitted with commit 28843fa2d256dd213ee636eaa552bf892586576e by Martin 
Klapetek to branch master.


Repository: kpeople


Description
---

The KPeople::ActionType is just a namespaced enum, so here's a wrapper
that makes it usable from QML


Diffs
-

  src/declarative/peopleqmlplugin.cpp 1e0516a 

Diff: https://git.reviewboard.kde.org/r/127164/diff/


Testing
---

Works all good.


Thanks,

Martin Klapetek

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127163: Add actionType to the PersonActionsModel

2016-02-24 Thread Martin Klapetek 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127163/
---

(Updated Feb. 24, 2016, 6:08 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and KDEPIM.


Changes
---

Submitted with commit cc09522974fe48a58ffc711f8f79023c59f4dfbe by Martin 
Klapetek to branch master.


Repository: kpeople


Description
---

This allows filtering for only specific action types


Diffs
-

  src/declarative/personactionsmodel.cpp ccdc6e6 
  src/declarative/personactionsmodel_p.h 8032ab9 

Diff: https://git.reviewboard.kde.org/r/127163/diff/


Testing
---


Thanks,

Martin Klapetek

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127158: Adds writer and external (extractor and writer) plugin support

2016-02-24 Thread Boudhayan Gupta 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127158/#review92735
---



I think the very first thing you should do is divide the whole thing into 
multiple patches, and thus 3 review requests. Discard this one and file 3 new 
ones.

The three should be - one that adds all the write functionality, one that adds 
the external reader, and one that adds the external writer. In any case, as 
they're three different major features, you'll have to commit them in three 
different commits anyway.

- Boudhayan Gupta


On Feb. 24, 2016, 3:33 a.m., Varun Joshi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127158/
> ---
> 
> (Updated Feb. 24, 2016, 3:33 a.m.)
> 
> 
> Review request for Baloo, KDE Frameworks and Vishesh Handa.
> 
> 
> Repository: kfilemetadata
> 
> 
> Description
> ---
> 
> Builds upon Boudhyan Gupta's work on external extractors, creating a process 
> that runs a script that extracts/writes data, accepting input and producing 
> an output (JSON-formatted) via stdin/stdout.
> 
> Adds Writer, WriterData, WriterPlugin and WriterCollection classes, analogous 
> to the Extractor classes. The only notable difference is that consumer 
> applications will be able to use WriteData (analogous to ExtractionResult) 
> without subclassing it.
> 
> Adds ExternalWriter and ExternalExtractor classes. These handle input/output 
> and communication with the external plugins.
> 
> 
> Diffs
> -
> 
>   README.md 19b1a26a241e6a35c636aaf8162afe762018f073 
>   autotests/CMakeLists.txt 9d308367838680f1081cfa3b583d3401412c21c1 
>   autotests/taglibwritertest.h PRE-CREATION 
>   autotests/taglibwritertest.cpp PRE-CREATION 
>   src/CMakeLists.txt a5490856a51aa2f59389ee963f3430c1ce5c60d5 
>   src/config-kfilemetadata.h.in PRE-CREATION 
>   src/externalextractor.h PRE-CREATION 
>   src/externalextractor.cpp PRE-CREATION 
>   src/externalwriter.h PRE-CREATION 
>   src/externalwriter.cpp PRE-CREATION 
>   src/extractorcollection.h 8542aed576102be2b0c86bbdf3d65d756d468c6e 
>   src/extractorcollection.cpp a1bde65bf57e493918cd3e85ccdb23c4cd623401 
>   src/extractorplugin.h 65abad3b2397628ba42a40d9ef2970e02114e250 
>   src/extractors/CMakeLists.txt 5dd223e1cf6864a943e848664ad5fae0d0603e77 
>   src/extractors/externalextractors/CMakeLists.txt PRE-CREATION 
>   src/extractors/externalextractors/exampleextractor/main.py PRE-CREATION 
>   src/extractors/externalextractors/exampleextractor/manifest.json 
> PRE-CREATION 
>   src/extractors/externalextractors/pdfextractor/main.py PRE-CREATION 
>   src/extractors/externalextractors/pdfextractor/manifest.json PRE-CREATION 
>   src/writedata.h PRE-CREATION 
>   src/writedata.cpp PRE-CREATION 
>   src/writer.h PRE-CREATION 
>   src/writer.cpp PRE-CREATION 
>   src/writer_p.h PRE-CREATION 
>   src/writercollection.h PRE-CREATION 
>   src/writercollection.cpp PRE-CREATION 
>   src/writerplugin.h PRE-CREATION 
>   src/writerplugin.cpp PRE-CREATION 
>   src/writers/CMakeLists.txt PRE-CREATION 
>   src/writers/externalwriters/CMakeLists.txt PRE-CREATION 
>   src/writers/externalwriters/pdfwriter/main.py PRE-CREATION 
>   src/writers/externalwriters/pdfwriter/manifest.json PRE-CREATION 
>   src/writers/taglibwriter.h PRE-CREATION 
>   src/writers/taglibwriter.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127158/diff/
> 
> 
> Testing
> ---
> 
> Created a sample PDF reader and extractor in Python, both of which work 
> successfully.
> 
> 
> Thanks,
> 
> Varun Joshi
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126740: Add a script for optimizing svgs

2016-02-24 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126740/
---

(Updated Feb. 24, 2016, 5:23 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit 8a31ac8ac1056a9065d50845b71336fff74e317c by Aleix Pol to 
branch master.


Repository: breeze-icons


Description
---

Dirk's review (https://git.reviewboard.kde.org/r/126738/) gave me the idea that 
right now we're serving right away the svg's from inkscape and there's room for 
improvement, potentially.

This patch just introduces a script that optimizes the svg's using `svgo`.

More could be done, like using gzip files, we can look into that if anyone's 
interested. In fact, we used to use svgz for the icons, I wonder why that 
changed. 

This will change the files in-place rather than as a build step, which is what 
I considered first. The process to run svgo on every file was about 30 minutes 
to 1h on my system, so I doubt it's really desirable.

A reduced file size is important because it will greatly reduce disk IO, which 
is a bottle-neck we have.


Diffs
-

  optimize.svg.sh PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126740/diff/


Testing
---

```
kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/
32M icons
32M icons-dark/

#run the script

kde-devel@oliver:~/frameworks/breeze-icons (master)$ du -sh icons icons-dark/
17M icons
17M icons-dark/
```


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127169: By default, make KDE_INSTALL_USE_QT_SYS_PATHS share the same directory scheme as Qt if they share the prefix

2016-02-24 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127169/
---

Review request for Extra Cmake Modules and KDE Frameworks.


Repository: extra-cmake-modules


Description
---

Make Qt and ECM-based projects use the same directory sctructure (i.e. where 
plugins are, libs, etc.) by default. Otherwise it creates a tiny mess that 
might be controlled but usually won't.

In the end, otherwise, people need to keep adapting their systems with 
environment variables anyway. All distros end up setting always this setting as 
ON, as well as brave developers who don't have separate prefixes for Qt and KDE.


Diffs
-

  kde-modules/KDEInstallDirs.cmake ebd48fa 

Diff: https://git.reviewboard.kde.org/r/127169/diff/


Testing
---


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127166: Fix xcb port of klauncher and clean up the code.

2016-02-24 Thread Xuetian Weng 


> On Feb. 24, 2016, 7:19 a.m., Martin Gräßlin wrote:
> > src/klauncher/klauncher.h, line 274
> > 
> >
> > const QByteArray &

Well, I assign to it in the function.


- Xuetian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127166/#review92707
---


On Feb. 24, 2016, 5:19 a.m., Xuetian Weng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127166/
> ---
> 
> (Updated Feb. 24, 2016, 5:19 a.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Martin Gräßlin.
> 
> 
> Repository: kinit
> 
> 
> Description
> ---
> 
> The ported klauncher at least has two bugs:
> 1. IMHO, it should compare the cached display string with == instead of != 
> (though != has been there since the old kdelibs, but it just doesn't look 
> correct to me, what's the point of assign dpy = mCached_dpy when dpy_str != 
> XDisplayString(dpy)? And what's the point use == in one place and != in other 
> two places? ).
> 2. it might free the cached connection without setting mCached.conn back to 
> nullptr, which could lead to double free or freeze when system logout.
> 
> This patch refactor the code a little bit with a helper function to update 
> the cached connection instead of duplicate the same logic everywhere. 
> getXCBConnection() will make sure the returned connection is error-free, 
> reuse the cached connection if possible, and update the cached connection if 
> needed.
> 
> 
> Diffs
> -
> 
>   src/klauncher/klauncher.h 31bfaaa 
>   src/klauncher/klauncher.cpp 7ea9da9 
> 
> Diff: https://git.reviewboard.kde.org/r/127166/diff/
> 
> 
> Testing
> ---
> 
> Compiles, startup notify works.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127145: KLinkItemSelectionModel: Don't store model locally

2016-02-24 Thread Stephen Kelly 


> On Feb. 24, 2016, 12:36 a.m., Aleix Pol Gonzalez wrote:
> > Ship It!
> 
> Aleix Pol Gonzalez wrote:
> Eh.. wait, we still support Qt 5.3, will that be a problem?

Hi Aleix,

Good catch! It's not a problem in this commit, but following commits would not 
compile with Qt 5.3 because of a connect() to a method that doesn't exist yet, 
and because of unit tests calling setModel on the QItemSelectionModel.

I wrapped those things in ifdefs and tested successfully with Qt 5.3. I pushed 
the result to my branch again on github.

Thanks,


- Stephen


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127145/#review92693
---


On Feb. 22, 2016, 4:30 p.m., Stephen  Kelly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127145/
> ---
> 
> (Updated Feb. 22, 2016, 4:30 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kitemmodels
> 
> 
> Description
> ---
> 
> The model can be changed after the constructor is run as of Qt 5.5.
> 
> At this point, the KLinkItemSelectionModel would still break if that is
> attempted, so a unit test comes later.
> 
> 
> Diffs
> -
> 
>   src/klinkitemselectionmodel.cpp 1b676e87128d83586b62f94f9652b25111e766a5 
> 
> Diff: https://git.reviewboard.kde.org/r/127145/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Stephen  Kelly
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125987: KFontSettingsData autotest: dbus connect happens with QueuedConnection, wait for it.

2016-02-24 Thread David Faure 


> On Feb. 24, 2016, 8:29 a.m., Martin Gräßlin wrote:
> > should we also add this change to plasma-integration?

Indeed, I have the same unittest failure there.

-asterix- dfaure 9:55 
/s/kde/build/5/kde/workspace/plasma-integration/autotests>./kfontsettingsdata_unittest
 
* Start testing of KFontSettingsData_UnitTest *
Config: Using QtTest library 5.6.0, Qt 5.6.0 (x86_64-little_endian-lp64 shared 
(dynamic) debug build; by GCC 4.8.3 20140627 [gcc-4_8-branch revision 212064])
PASS   : KFontSettingsData_UnitTest::initTestCase()
PASS   : KFontSettingsData_UnitTest::_q_showIfNotHidden()
PASS   : KFontSettingsData_UnitTest::testFonts()
QWARN  : KFontSettingsData_UnitTest::testFontsChanged() 
kfontsettingsdata_unittest(11964)/default KIconTheme::KIconTheme: Icon theme 
"non-existent-icon-theme" not found.
FAIL!  : KFontSettingsData_UnitTest::testFontsChanged() Compared values are not 
the same
   Actual   (m_fonts->font(KFontSettingsData::GeneralFont)->family()): 
"OxyFontTest"
   Expected (QStringLiteral("ChangedFontTest"))  : 
"ChangedFontTest"
   Loc: 
[/d/kde/src/5/kde/workspace/plasma-integration/autotests/kfontsettingsdata_unittest.cpp(107)]
PASS   : KFontSettingsData_UnitTest::cleanupTestCase()
Totals: 4 passed, 1 failed, 0 skipped, 0 blacklisted
* Finished testing of KFontSettingsData_UnitTest *

Can you forwardport? (otherwise I'll do it tonight)


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125987/#review92709
---


On Feb. 24, 2016, 8:05 a.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125987/
> ---
> 
> (Updated Feb. 24, 2016, 8:05 a.m.)
> 
> 
> Review request for KDE Frameworks and Àlex Fiestas.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> KFontSettingsData autotest: dbus connect happens with QueuedConnection, wait 
> for it.
> 
> 
> Diffs
> -
> 
>   autotests/kfontsettingsdata_unittest.cpp 
> 56ba9458625e2f39622251467ee39b388fc6508d 
> 
> Diff: https://git.reviewboard.kde.org/r/125987/diff/
> 
> 
> Testing
> ---
> 
> This fixes ./kfontsettingsdata_unittest on my machine. I'm not sure how it 
> passes on CI at all...
> 
> 
> Thanks,
> 
> David Faure
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125987: KFontSettingsData autotest: dbus connect happens with QueuedConnection, wait for it.

2016-02-24 Thread Martin Gräßlin 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125987/#review92709
---



should we also add this change to plasma-integration?

- Martin Gräßlin


On Feb. 24, 2016, 9:05 a.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125987/
> ---
> 
> (Updated Feb. 24, 2016, 9:05 a.m.)
> 
> 
> Review request for KDE Frameworks and Àlex Fiestas.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> KFontSettingsData autotest: dbus connect happens with QueuedConnection, wait 
> for it.
> 
> 
> Diffs
> -
> 
>   autotests/kfontsettingsdata_unittest.cpp 
> 56ba9458625e2f39622251467ee39b388fc6508d 
> 
> Diff: https://git.reviewboard.kde.org/r/125987/diff/
> 
> 
> Testing
> ---
> 
> This fixes ./kfontsettingsdata_unittest on my machine. I'm not sure how it 
> passes on CI at all...
> 
> 
> Thanks,
> 
> David Faure
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 238 - Fixed!

2016-02-24 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/238/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 24 Feb 2016 08:00:43 +
Build duration: 6 min 19 sec

CHANGE SET
Revision cedafa80d23bcc4d9a9ea4f180c7f7cb8df4e59a by David Faure: 
(KOpenWithDialog: show mimetype name and comment in Remember 
checkbox)
  change: edit src/widgets/kopenwithdialog.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 
49 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 260/338 (77%)CLASSES 260/338 (77%)LINE 26977/50844 
(53%)CONDITIONAL 14710/22821 (64%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7446/7740 
(96%)CONDITIONAL 4056/7454 (54%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 538/540 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 182/199 (91%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7842/14138 
(55%)CONDITIONAL 4104/5684 (72%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2281/7591 
(30%)CONDITIONAL 911/1403 (65%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 108/114 (95%)CONDITIONAL 
46/68 (68%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 430/843 (51%)CONDITIONAL 
313/459 (68%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1836/3823 
(48%)CONDITIONAL 1315/1948 (68%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 642/804 (80%)CONDITIONAL 
602/758 (79%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 684/1182 (58%)CONDITIONAL 
358/495 (72%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 690/768 (90%)CONDITIONAL 
433/820 (53%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/26 (54%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/126 (81%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 384/600 (64%)CONDITIONAL 
280/408 (69%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 280/285 (98%)CONDITIONAL 
144/254 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 32/35 (91%)CONDITIONAL 
42/52 (81%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 248/743 (33%)CONDITIONAL 
147/194 (76%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 20/27 (74%)CONDITIONAL 
14/18 (78%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 229/259 (88%)CONDITIONAL 
295/360 (82%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2697/10649 
(25%)CONDITIONAL 1280/1878 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125987: KFontSettingsData autotest: dbus connect happens with QueuedConnection, wait for it.

2016-02-24 Thread David Faure 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125987/
---

(Updated Feb. 24, 2016, 12:05 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Àlex Fiestas.


Changes
---

Submitted with commit fd43f44cc6975c199e2792cda971a36f538da2e0 by David Faure 
to branch master.


Repository: frameworkintegration


Description
---

KFontSettingsData autotest: dbus connect happens with QueuedConnection, wait 
for it.


Diffs
-

  autotests/kfontsettingsdata_unittest.cpp 
56ba9458625e2f39622251467ee39b388fc6508d 

Diff: https://git.reviewboard.kde.org/r/125987/diff/


Testing
---

This fixes ./kfontsettingsdata_unittest on my machine. I'm not sure how it 
passes on CI at all...


Thanks,

David Faure

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126694: KHTML java applet viewer: repair broken DBus call to kpasswdserver

2016-02-24 Thread David Faure 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126694/
---

(Updated Feb. 24, 2016, 9:03 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.


Changes
---

Submitted with commit ad9fc512540010343fc34de8a6326367ff683047 by David Faure 
to branch master.


Repository: khtml


Description
---

KHTML java applet viewer: repair broken DBus call to kpasswdserver


Diffs
-

  src/java/kjavaappletviewer.cpp 5a7d4a1113899b60bfa9ac968f93ddb7295e5a11 

Diff: https://git.reviewboard.kde.org/r/126694/diff/


Testing
---

None. I have no idea how to trigger this code.


Thanks,

David Faure

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127127: KOpenWithDialog: show mimetype name and comment in "Remember" checkbox text

2016-02-24 Thread David Faure 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127127/
---

(Updated Feb. 24, 2016, 8 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and KDE Usability.


Changes
---

Submitted with commit cedafa80d23bcc4d9a9ea4f180c7f7cb8df4e59a by David Faure 
to branch master.


Bugs: 110146
https://bugs.kde.org/show_bug.cgi?id=110146


Repository: kio


Description
---

BUG: 110146


Diffs
-

  src/widgets/kopenwithdialog.cpp 808af73ff332834e013bd3727fee54183eee538b 

Diff: https://git.reviewboard.kde.org/r/127127/diff/


Testing
---

kio/tests/kopenwithtest


File Attachments


screenshot
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/02/20/b3a0babf-43b5-4921-ab7a-899c011c115c__kopenwith-mime.png


Thanks,

David Faure

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel