Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 303 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/303/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Sat, 05 Mar 2016 00:37:36 +
Build duration: 2 min 39 sec

CHANGE SET
Revision da340aaefa9cb82820743b62879f61bcb709d882 by nowrep: 
(ContainmentInterface: Fix use of QRect right() and bottom())
  change: edit src/scriptengines/qml/plasmoid/containmentinterface.cpp
Revision 978b8b3b87671ac6b3a365b6b5b3dbe42b2a017b by nowrep: (IconItem: 
Dont overwrite source when using QIcon::name())
  change: edit src/declarativeimports/core/iconitem.h
  change: edit autotests/iconitemtest.h
  change: edit autotests/iconitemtest.cpp
  change: edit src/declarativeimports/core/iconitem.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 
12 test(s)Failed: TestSuite.plasma-iconitemtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 67/107 (63%)CLASSES 67/107 (63%)LINE 4392/10348 
(42%)CONDITIONAL 2281/3513 (65%)

By packages
  
autotests
FILES 22/22 (100%)CLASSES 22/22 (100%)LINE 732/761 
(96%)CONDITIONAL 463/812 (57%)
src.declarativeimports.core
FILES 10/20 (50%)CLASSES 10/20 (50%)LINE 624/2059 
(30%)CONDITIONAL 278/410 (68%)
src.plasma
FILES 14/21 (67%)CLASSES 14/21 (67%)LINE 1662/3665 
(45%)CONDITIONAL 908/1322 (69%)
src.plasma.private
FILES 16/26 (62%)CLASSES 16/26 (62%)LINE 896/1752 
(51%)CONDITIONAL 372/555 (67%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/192 (0%)CONDITIONAL 0/0 
(100%)
src.plasmaquick
FILES 5/12 (42%)CLASSES 5/12 (42%)LINE 478/1806 
(26%)CONDITIONAL 260/414 (63%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 303 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/303/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Sat, 05 Mar 2016 00:37:36 +
Build duration: 2 min 57 sec

CHANGE SET
Revision da340aaefa9cb82820743b62879f61bcb709d882 by nowrep: 
(ContainmentInterface: Fix use of QRect right() and bottom())
  change: edit src/scriptengines/qml/plasmoid/containmentinterface.cpp
Revision 978b8b3b87671ac6b3a365b6b5b3dbe42b2a017b by nowrep: (IconItem: 
Dont overwrite source when using QIcon::name())
  change: edit autotests/iconitemtest.h
  change: edit src/declarativeimports/core/iconitem.cpp
  change: edit autotests/iconitemtest.cpp
  change: edit src/declarativeimports/core/iconitem.h


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.plasma-iconitemtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 64/103 (62%)CLASSES 64/103 (62%)LINE 3960/9880 
(40%)CONDITIONAL 1995/3102 (64%)

By packages
  
autotests
FILES 20/20 (100%)CLASSES 20/20 (100%)LINE 685/714 
(96%)CONDITIONAL 447/780 (57%)
src.declarativeimports.core
FILES 10/20 (50%)CLASSES 10/20 (50%)LINE 534/1836 
(29%)CONDITIONAL 192/286 (67%)
src.plasma
FILES 14/21 (67%)CLASSES 14/21 (67%)LINE 1660/3665 
(45%)CONDITIONAL 902/1322 (68%)
src.plasma.private
FILES 15/24 (63%)CLASSES 15/24 (63%)LINE 850/1678 
(51%)CONDITIONAL 353/525 (67%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/192 (0%)CONDITIONAL 0/0 
(100%)
src.plasmaquick
FILES 5/12 (42%)CLASSES 5/12 (42%)LINE 231/1682 
(14%)CONDITIONAL 101/189 (53%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 296 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/296/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Sat, 05 Mar 2016 00:32:20 +
Build duration: 2 min 12 sec

CHANGE SET
Revision da340aaefa9cb82820743b62879f61bcb709d882 by nowrep: 
(ContainmentInterface: Fix use of QRect right() and bottom())
  change: edit src/scriptengines/qml/plasmoid/containmentinterface.cpp
Revision 978b8b3b87671ac6b3a365b6b5b3dbe42b2a017b by nowrep: (IconItem: 
Dont overwrite source when using QIcon::name())
  change: edit autotests/iconitemtest.h
  change: edit src/declarativeimports/core/iconitem.h
  change: edit autotests/iconitemtest.cpp
  change: edit src/declarativeimports/core/iconitem.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.plasma-iconitemtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 64/103 (62%)CLASSES 64/103 (62%)LINE 3950/9839 
(40%)CONDITIONAL 1995/3102 (64%)

By packages
  
autotests
FILES 20/20 (100%)CLASSES 20/20 (100%)LINE 681/710 
(96%)CONDITIONAL 447/780 (57%)
src.declarativeimports.core
FILES 10/20 (50%)CLASSES 10/20 (50%)LINE 533/1835 
(29%)CONDITIONAL 192/286 (67%)
src.plasma
FILES 14/21 (67%)CLASSES 14/21 (67%)LINE 1657/3660 
(45%)CONDITIONAL 902/1322 (68%)
src.plasma.private
FILES 15/24 (63%)CLASSES 15/24 (63%)LINE 849/1671 
(51%)CONDITIONAL 353/525 (67%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/182 (0%)CONDITIONAL 0/0 
(100%)
src.plasmaquick
FILES 5/12 (42%)CLASSES 5/12 (42%)LINE 230/1668 
(14%)CONDITIONAL 101/189 (53%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 296 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/296/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Sat, 05 Mar 2016 00:32:20 +
Build duration: 3 min 26 sec

CHANGE SET
Revision da340aaefa9cb82820743b62879f61bcb709d882 by nowrep: 
(ContainmentInterface: Fix use of QRect right() and bottom())
  change: edit src/scriptengines/qml/plasmoid/containmentinterface.cpp
Revision 978b8b3b87671ac6b3a365b6b5b3dbe42b2a017b by nowrep: (IconItem: 
Dont overwrite source when using QIcon::name())
  change: edit autotests/iconitemtest.h
  change: edit autotests/iconitemtest.cpp
  change: edit src/declarativeimports/core/iconitem.h
  change: edit src/declarativeimports/core/iconitem.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 
12 test(s)Failed: TestSuite.plasma-iconitemtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 67/107 (63%)CLASSES 67/107 (63%)LINE 4381/10307 
(43%)CONDITIONAL 2280/3513 (65%)

By packages
  
autotests
FILES 22/22 (100%)CLASSES 22/22 (100%)LINE 727/757 
(96%)CONDITIONAL 462/812 (57%)
src.declarativeimports.core
FILES 10/20 (50%)CLASSES 10/20 (50%)LINE 623/2058 
(30%)CONDITIONAL 278/410 (68%)
src.plasma
FILES 14/21 (67%)CLASSES 14/21 (67%)LINE 1659/3660 
(45%)CONDITIONAL 908/1322 (69%)
src.plasma.private
FILES 16/26 (62%)CLASSES 16/26 (62%)LINE 895/1745 
(51%)CONDITIONAL 372/555 (67%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/182 (0%)CONDITIONAL 0/0 
(100%)
src.plasmaquick
FILES 5/12 (42%)CLASSES 5/12 (42%)LINE 477/1792 
(27%)CONDITIONAL 260/414 (63%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: gcode.xml got into KF5::KTextEditor without review

[Luigi Toscano]

Alexander Potashev ha scritto:
> Hi everyone, (Sven),
> 
> As I understand, KF5 does not have feature freezes because all changes
> are unit-tested and reviewed [1].
> 
> [2] is clearly a feature, but it was not submitted to reviewboard
> before pushing to ktexteditor.git:master. This change also introduced
> a new string for translators: "G-Code", thus it breaks the actual
> 2-week string freeze [1].

I agree that it breakes the string freeze just two days before the release,
but review does not mean going to reviewboard. In fact it was written by a
different person than the committer (who reviewed it).
PS. Sven, you may want to set the author of the patch to the real author
instead before committing, instead of Written by; git can distinguish between
committer and author.

Ciao
-- 
Luigi

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 61 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/61/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Fri, 04 Mar 2016 22:25:45 +
Build duration: 1.9 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kwallet master stable-kf5-qt5 » Linux,gcc - Build # 62 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kwallet%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/62/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 04 Mar 2016 22:25:15 +
Build duration: 0.9 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kunitconversion master kf5-qt5 » Linux,gcc - Build # 28 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kunitconversion%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/28/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 04 Mar 2016 22:24:55 +
Build duration: 0.98 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kwidgetsaddons master kf5-qt5 » Linux,gcc - Build # 61 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kwidgetsaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/61/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 04 Mar 2016 22:25:30 +
Build duration: 1 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kunitconversion master stable-kf5-qt5 » Linux,gcc - Build # 29 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kunitconversion%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/29/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 04 Mar 2016 22:24:55 +
Build duration: 0.86 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 191 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/191/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 04 Mar 2016 22:24:20 +
Build duration: 0.92 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: ktextwidgets master kf5-qt5 » Linux,gcc - Build # 38 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/ktextwidgets%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/38/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 04 Mar 2016 22:24:40 +
Build duration: 0.97 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kwallet master kf5-qt5 » Linux,gcc - Build # 64 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kwallet%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/64/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 04 Mar 2016 22:25:15 +
Build duration: 1 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,NoX11,gcc - Build # 64 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/64/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Fri, 04 Mar 2016 22:25:45 +
Build duration: 1 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kwidgetsaddons master stable-kf5-qt5 » Linux,gcc - Build # 58 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kwidgetsaddons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/58/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 04 Mar 2016 22:25:30 +
Build duration: 0.91 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 196 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/196/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 04 Mar 2016 22:24:20 +
Build duration: 0.96 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kross master stable-kf5-qt5 » Linux,gcc - Build # 34 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kross%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/34/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 04 Mar 2016 22:23:25 +
Build duration: 0.93 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 125 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/125/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 04 Mar 2016 22:24:00 +
Build duration: 0.92 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kplotting master kf5-qt5 » Linux,gcc - Build # 30 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kplotting%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/30/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 04 Mar 2016 22:22:50 +
Build duration: 1.3 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kplotting master stable-kf5-qt5 » Linux,gcc - Build # 30 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kplotting%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/30/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 04 Mar 2016 22:22:50 +
Build duration: 0.94 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: krunner master kf5-qt5 » Linux,gcc - Build # 39 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/krunner%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/39/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 04 Mar 2016 22:23:40 +
Build duration: 0.86 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 121 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/121/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 04 Mar 2016 22:24:00 +
Build duration: 0.85 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kpty master kf5-qt5 » Linux,gcc - Build # 27 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kpty%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/27/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 04 Mar 2016 22:23:05 +
Build duration: 0.94 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: ktextwidgets master stable-kf5-qt5 » Linux,gcc - Build # 39 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/ktextwidgets%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/39/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 04 Mar 2016 22:24:40 +
Build duration: 0.82 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kross master kf5-qt5 » Linux,gcc - Build # 33 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kross%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/33/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 04 Mar 2016 22:23:25 +
Build duration: 2.1 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: krunner master stable-kf5-qt5 » Linux,gcc - Build # 42 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/krunner%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/42/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 04 Mar 2016 22:23:40 +
Build duration: 0.95 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

gcode.xml got into KF5::KTextEditor without review

[Alexander Potashev]

Hi everyone, (Sven),

As I understand, KF5 does not have feature freezes because all changes
are unit-tested and reviewed [1].

[2] is clearly a feature, but it was not submitted to reviewboard
before pushing to ktexteditor.git:master. This change also introduced
a new string for translators: "G-Code", thus it breaks the actual
2-week string freeze [1].

Please consider reverting and starting a new review request at
http://git.reviewboard.kde.org/


P.S.  Yes, I am nitpicking. Someone has to do it.

[1] https://techbase.kde.org/Schedules/Frameworks
[2] http://commits.kde.org/ktexteditor/c65cdf81660eca01ab3d0792944a2e96a365bbca

-- 
Alexander Potashev
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kpty master stable-kf5-qt5 » Linux,gcc - Build # 28 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kpty%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/28/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 04 Mar 2016 22:23:05 +
Build duration: 1 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kparts master stable-kf5-qt5 » Linux,gcc - Build # 35 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kparts%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/35/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 04 Mar 2016 22:22:09 +
Build duration: 1.8 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: knotifications master stable-kf5-qt5 » Linux,gcc - Build # 60 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/knotifications%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/60/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 04 Mar 2016 22:21:14 +
Build duration: 0.92 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: knotifications master kf5-qt5 » Linux,gcc - Build # 61 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/knotifications%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/61/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 04 Mar 2016 22:21:14 +
Build duration: 1.1 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: knewstuff master stable-kf5-qt5 » Linux,gcc - Build # 102 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/knewstuff%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/102/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 04 Mar 2016 22:20:54 +
Build duration: 1.1 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: knewstuff master kf5-qt5 » Linux,gcc - Build # 101 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/knewstuff%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/101/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 04 Mar 2016 22:20:54 +
Build duration: 4.7 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kjs master stable-kf5-qt5 » Linux,gcc - Build # 33 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kjs%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/33/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 04 Mar 2016 22:20:04 +
Build duration: 1.4 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kjsembed master stable-kf5-qt5 » Linux,gcc - Build # 30 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kjsembed%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/30/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 04 Mar 2016 22:20:19 +
Build duration: 1.1 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kjsembed master kf5-qt5 » Linux,gcc - Build # 32 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kjsembed%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/32/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 04 Mar 2016 22:20:19 +
Build duration: 0.96 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kjs master kf5-qt5 » Linux,gcc - Build # 32 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kjs%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/32/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 04 Mar 2016 22:20:04 +
Build duration: 2.5 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kjobwidgets master stable-kf5-qt5 » Linux,gcc - Build # 30 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kjobwidgets%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/30/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 04 Mar 2016 22:19:44 +
Build duration: 1.3 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kitemmodels master kf5-qt5 » Linux,gcc - Build # 43 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kitemmodels%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/43/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 04 Mar 2016 22:19:14 +
Build duration: 1 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kinit master kf5-qt5 » Linux,gcc - Build # 44 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kinit%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/44/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 04 Mar 2016 22:18:34 +
Build duration: 2.3 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kitemviews master kf5-qt5 » Linux,gcc - Build # 30 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kitemviews%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/30/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 04 Mar 2016 22:19:29 +
Build duration: 1.2 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 243 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/243/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 04 Mar 2016 22:18:54 +
Build duration: 1 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kitemmodels master stable-kf5-qt5 » Linux,gcc - Build # 40 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kitemmodels%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/40/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 04 Mar 2016 22:19:14 +
Build duration: 1.2 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 253 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/253/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 04 Mar 2016 22:18:54 +
Build duration: 6.2 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kinit master stable-kf5-qt5 » Linux,gcc - Build # 43 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kinit%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/43/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 04 Mar 2016 22:18:34 +
Build duration: 2.2 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kidletime master stable-kf5-qt5 » Linux,gcc - Build # 29 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kidletime%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/29/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 04 Mar 2016 22:17:59 +
Build duration: 1.5 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kidletime master kf5-qt5 » Linux,gcc - Build # 30 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kidletime%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/30/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 04 Mar 2016 22:17:59 +
Build duration: 1.5 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kimageformats master kf5-qt5 » Linux,gcc - Build # 27 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kimageformats%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/27/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 04 Mar 2016 22:18:14 +
Build duration: 1.8 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127166: Fix xcb port of klauncher and clean up the code.

[Xuetian Weng]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127166/
---

(Updated March 4, 2016, 10:51 p.m.)


Review request for KDE Frameworks, David Faure and Martin Gräßlin.


Repository: kinit


Description
---

The ported klauncher at least has two bugs:
1. IMHO, it should compare the cached display string with == instead of != 
(though != has been there since the old kdelibs, but it just doesn't look 
correct to me, what's the point of assign dpy = mCached_dpy when dpy_str != 
XDisplayString(dpy)? And what's the point use == in one place and != in other 
two places? ).
2. it might free the cached connection without setting mCached.conn back to 
nullptr, which could lead to double free or freeze when system logout.

This patch refactor the code a little bit with a helper function to update the 
cached connection instead of duplicate the same logic everywhere. 
getXCBConnection() will make sure the returned connection is error-free, reuse 
the cached connection if possible, and update the cached connection if needed.


Diffs (updated)
-

  src/klauncher/klauncher.h 31bfaaa 
  src/klauncher/klauncher.cpp 7ea9da9 

Diff: https://git.reviewboard.kde.org/r/127166/diff/


Testing
---

Compiles, startup notify works.


Thanks,

Xuetian Weng

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127281: [kio-extras] Audio (id3) thumbnailer

[Kai Uwe Broulik]

> On März 4, 2016, 10:18 nachm., Dāvis Mosāns wrote:
> > do you know about https://github.com/eplightning/audiothumbs-frameworks ? 
> > it works fine with Qt5/KF5 and I've been using to for months. I wonder if 
> > there would be some better way with either merging it all in here or 
> > something without duplicating code. Currently it supports more formats than 
> > this RR gives.

I was not aware of that; indeed perhaps we could upstream this?


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127281/#review93176
---


On März 4, 2016, 9:43 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127281/
> ---
> 
> (Updated März 4, 2016, 9:43 nachm.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> ---
> 
> This is basically a port and cleanup of the Audio Thumbnailer to KF5, I find 
> it useful to ship this by default. Minus the FLAC part as I don't have any 
> FLAC stuff :)
> 
> 
> Diffs
> -
> 
>   thumbnail/CMakeLists.txt 4addb26 
>   thumbnail/audiocreator.h PRE-CREATION 
>   thumbnail/audiocreator.cpp PRE-CREATION 
>   thumbnail/audiothumbnail.desktop PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127281/diff/
> 
> 
> Testing
> ---
> 
> Works
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/04/b099ec03-7fa7-4ed3-91c4-bc55c62c72ca__Screenshot_20160304_224228.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127281: [kio-extras] Audio (id3) thumbnailer

[Dāvis Mosāns]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127281/#review93176
---



do you know about https://github.com/eplightning/audiothumbs-frameworks ? it 
works fine with Qt5/KF5 and I've been using to for months. I wonder if there 
would be some better way with either merging it all in here or something 
without duplicating code. Currently it supports more formats than this RR gives.

- Dāvis Mosāns


On marts 4, 2016, 11:43 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127281/
> ---
> 
> (Updated marts 4, 2016, 11:43 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> ---
> 
> This is basically a port and cleanup of the Audio Thumbnailer to KF5, I find 
> it useful to ship this by default. Minus the FLAC part as I don't have any 
> FLAC stuff :)
> 
> 
> Diffs
> -
> 
>   thumbnail/CMakeLists.txt 4addb26 
>   thumbnail/audiocreator.h PRE-CREATION 
>   thumbnail/audiocreator.cpp PRE-CREATION 
>   thumbnail/audiothumbnail.desktop PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127281/diff/
> 
> 
> Testing
> ---
> 
> Works
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/04/b099ec03-7fa7-4ed3-91c4-bc55c62c72ca__Screenshot_20160304_224228.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127281: [kio-extras] Audio (id3) thumbnailer

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127281/
---

Review request for KDE Frameworks.


Repository: kio-extras


Description
---

This is basically a port and cleanup of the Audio Thumbnailer to KF5, I find it 
useful to ship this by default. Minus the FLAC part as I don't have any FLAC 
stuff :)


Diffs
-

  thumbnail/CMakeLists.txt 4addb26 
  thumbnail/audiocreator.h PRE-CREATION 
  thumbnail/audiocreator.cpp PRE-CREATION 
  thumbnail/audiothumbnail.desktop PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/127281/diff/


Testing
---

Works


File Attachments


Screenshot
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/03/04/b099ec03-7fa7-4ed3-91c4-bc55c62c72ca__Screenshot_20160304_224228.png


Thanks,

Kai Uwe Broulik

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127280: Fix memory leak in icon item test

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127280/
---

(Updated March 4, 2016, 8:52 p.m.)


Status
--

This change has been discarded.


Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

Not a big problem as it's only a test, but it will allow us to valgrind
it in future.


Diffs
-

  autotests/iconitemtest.cpp 8d3f494a1ff6a09e7b4c4738aa69588c371678c8 

Diff: https://git.reviewboard.kde.org/r/127280/diff/


Testing
---


Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127280: Fix memory leak in icon item test

[David Rosca]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127280/#review93175
---



There is a cleanup that deletes all children, I don't think this is needed.

- David Rosca


On March 4, 2016, 8:37 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127280/
> ---
> 
> (Updated March 4, 2016, 8:37 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Not a big problem as it's only a test, but it will allow us to valgrind
> it in future.
> 
> 
> Diffs
> -
> 
>   autotests/iconitemtest.cpp 8d3f494a1ff6a09e7b4c4738aa69588c371678c8 
> 
> Diff: https://git.reviewboard.kde.org/r/127280/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127280: Fix memory leak in icon item test

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127280/
---

Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

Not a big problem as it's only a test, but it will allow us to valgrind
it in future.


Diffs
-

  autotests/iconitemtest.cpp 8d3f494a1ff6a09e7b4c4738aa69588c371678c8 

Diff: https://git.reviewboard.kde.org/r/127280/diff/


Testing
---


Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126291: initial implementation of a platform plugin for OS X (WIP)

[René J . V . Bertin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126291/
---

(Updated March 4, 2016, 8:19 p.m.)


Review request for KDE Software on Mac OS X and KDE Frameworks.


Changes
---

This revision has a more complete (as complete as possible?) internal WId 
registry feature. WIds on OS X are tricky in that they do not usually 
correspond to `NSWindow` instances but instead to an `NSView` instance. As such 
there is no guarantee to receive any kind of notification when the NSView is 
created, which (I think) means that one has to take stock of an application's 
windows and views at certain times like during appropriate calls to 
KWindowSystem.

With these latest modifications, the `kwindowsystem_threadtest` autotest 
completes successfully, but only when doing an explicit action after 
`m_widget->show()` that causes the widget to be displayed (basically, the 
equivalent of a call to `XSync()`).


Repository: kwindowsystem


Description
---

KWindowSystem has been lacking a platform plugin for OS X. This RR presents a 
"backport" of the modified KDE4 KWindowSystem implementation that has been used 
in the MacPorts kdelibs4 port for the last 2 or 3 (or more) years.

I have made some initial steps to remove deprecated Carbon API calls, but this 
is clearly a work in progress.

Open questions include
- is there any justification to run an event handler (or Cocoa observer) to 
keep track of running applications, possibly even listing all their open 
windows?
- is there any use for the Qt event listener framework (cf. the NETEventFilter 
in the X11 plugin)? I haven't yet had time to try to figure out what this 
"could be good for", and am very open to suggestions in this departments.
- one application for such an event filter would be a listener that catches the 
opening and closing of all windows by the running process, and keeps track of 
their `WId`s. A new method could then be added (to `KWindowInfo`?) to 
distinguish `WId`s created by the running application from "foreign" ones 
(useful also on Wayland and MS Windows).

`KWindowSystem::setMainWindow` should become a front for payload provided by 
the plugins. I'll leave that to the regular/official maintainer(s) of this 
framework.

This code could probably do with *lots* of comments; I'll try to add them as 
questions about this or that bit of code arise.


Diffs (updated)
-

  autotests/CMakeLists.txt 65ed8d4 
  autotests/kwindowsystem_threadtest.cpp a142bae 
  src/debug_p.h 5ef8996 
  src/debug_p.cpp 72abfb7 
  src/kwindowsystem.cpp 407a67d 
  src/platforms/osx/CMakeLists.txt 4fc3347 
  src/platforms/osx/cocoa.json PRE-CREATION 
  src/platforms/osx/kkeyserver.cpp 3ddb921 
  src/platforms/osx/kwindowinfo.cpp e8555bb 
  src/platforms/osx/kwindowinfo.mm PRE-CREATION 
  src/platforms/osx/kwindowinfo_mac_p.h c8f307e 
  src/platforms/osx/kwindowinfo_p_cocoa.h PRE-CREATION 
  src/platforms/osx/kwindowsystem.cpp 1758829 
  src/platforms/osx/kwindowsystem_mac_p.h PRE-CREATION 
  src/platforms/osx/kwindowsystem_macobjc.mm PRE-CREATION 
  src/platforms/osx/kwindowsystem_p_cocoa.h PRE-CREATION 
  src/platforms/osx/plugin.h PRE-CREATION 
  src/platforms/osx/plugin.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126291/diff/


Testing
---

On OS X 10.9.5 with Qt 5.5.1 and frameworks 5.16.0 .


Thanks,

René J.V. Bertin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127240: [Applet] Don't crash on remove panel

[Anthony Fieroni]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127240/
---

(Updated March 4, 2016, 11:07 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, David Edmundson, David Rosca, and Marco 
Martin.


Changes
---

Submitted with commit 6bb02c88ebece5c732bbacd861002bd00999d3bc by Anthony 
Fieroni to branch master.


Bugs: 345723
http://bugs.kde.org/show_bug.cgi?id=345723


Repository: plasma-framework


Description
---

Stop timer is any case, if you don't want *this* to be nullptr


Diffs
-

  src/plasma/private/applet_p.cpp 38d486a 

Diff: https://git.reviewboard.kde.org/r/127240/diff/


Testing
---

Still not tested, but look good for me.


Thanks,

Anthony Fieroni

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127240: [Applet] Don't crash on remove panel

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127240/#review93173
---


Ship it!




it should be "q" instead of "this", that was my mistake.
(as it's AppletPrivate not Applet which is the qobject)

Re-add that and you can ship it.

- David Edmundson


On March 3, 2016, 9:52 p.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127240/
> ---
> 
> (Updated March 3, 2016, 9:52 p.m.)
> 
> 
> Review request for KDE Frameworks, David Edmundson, David Rosca, and Marco 
> Martin.
> 
> 
> Bugs: 345723
> http://bugs.kde.org/show_bug.cgi?id=345723
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> Stop timer is any case, if you don't want *this* to be nullptr
> 
> 
> Diffs
> -
> 
>   src/plasma/private/applet_p.cpp 38d486a 
> 
> Diff: https://git.reviewboard.kde.org/r/127240/diff/
> 
> 
> Testing
> ---
> 
> Still not tested, but look good for me.
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126991: Try multiple authentication methods in case of failures

[Krzysztof Nowicki]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126991/
---

(Updated March 4, 2016, 5:42 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Dawit Alemayehu.


Changes
---

Submitted with commit f665dd30fcf71493b93fb979a47986aca1faf95f by Krzysztof 
Nowicki to branch master.


Repository: kio


Description
---

When authenticating agains a server offering multiple authentication methods 
make sure to attempt other methods in case the best one fails.

This also fixes a connection close issue in the middle of an NTLM 
authentication dialog due to clearing the password.


Diffs
-

  src/ioslaves/http/http.h 621b2c7a957b9bc9cc14ff13ed3c3a72dec38190 
  src/ioslaves/http/http.cpp a84129f1403cbf8b0f86f9fd0354bec90ac5fd39 

Diff: https://git.reviewboard.kde.org/r/126991/diff/


Testing
---

I have performed testing on an IIS 7.5 server which offered 3 authentication 
options: Negotiate, NTLM and Basic. Since I have Kerberos configured the 
original code would only try Negotiate and because it failed it would retry it 
endlessly. With this patch authentication correctly falls back to NTLM or Basic 
(if NTLM fails too).


Thanks,

Krzysztof Nowicki

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

[Anthony Fieroni]

> On Март 4, 2016, 12:16 преди обяд, Thomas Lübking wrote:
> > src/kstatusnotifieritem.cpp, line 934
> > 
> >
> > append
> > associatedWidget->setAttribute(Qt::WA_Moved);
> > 
> > 
> > 
> > This should tell Qt to demand an explicit position and skip placement 
> > by the WM (yes, this generally works in KWin ;-)
> > 
> > However, this flag should be implicitly set by ::move() unless the 
> > point is invalid, so you might want to "qDebug() << associatedWidgetPos;" 
> > to check whether it's invalid for the failing clients.
> 
> Anthony Fieroni wrote:
> Fun facts :) void KStatusNotifierItemPrivate::minimizeRestore(bool) is 
> called only when you click on tray icon i.e. if i close app with big red X 
> it's not called => i can't store position :)
> 
> Anthony Fieroni wrote:
> More fun facts :) 
> associatedWidget->setGeometry(associatedWidget->frameGeometry()); works in 
> any case ! I will add path if you want, but you will not be happy to set 
> geometry by myself :)
> 
> Anthony Fieroni wrote:
> ^ No, extend geometry with decoration size :)
> 
> Thomas Lübking wrote:
> meehhh...
> 
> That means one will have to filter QEvent::Close of associatedWidget and 
> store the position from there.

It's strange, about me, associatedWidget has correct frameGeometry even it's 
hide.
QObject::connect(KWindowSystem::self(), ::windowRemoved, q, 
[this](WId winId) {
if (associatedWidget && associatedWidget->winId() == winId) {
associatedWidgetPos = associatedWidget->frameGeometry().topLeft();
}
});
Position is correct, but again not work event with Qt::WA_Moved.


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127216/#review93143
---


On Фев. 29, 2016, 7:18 преди обяд, Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127216/
> ---
> 
> (Updated Фев. 29, 2016, 7:18 преди обяд)
> 
> 
> Review request for KDE Frameworks, Martin Gräßlin, Thomas Lübking, and Martin 
> Klapetek.
> 
> 
> Bugs: 356523
> https://bugs.kde.org/show_bug.cgi?id=356523
> 
> 
> Repository: knotifications
> 
> 
> Description
> ---
> 
> Store position of widget before hide it
> 
> 
> Diffs
> -
> 
>   src/kstatusnotifieritem.cpp cf3e7b5 
>   src/kstatusnotifieritemprivate_p.h 8fdfd4c 
> 
> Diff: https://git.reviewboard.kde.org/r/127216/diff/
> 
> 
> Testing
> ---
> 
> Tested on pixel ration = 1
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 293 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/293/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Fri, 04 Mar 2016 15:50:41 +
Build duration: 2 min 27 sec

CHANGE SET
Revision 929d1fe008c84c921d123190fa978a44c6bb4c06 by David Edmundson: (Add 
missing file for iconitem test)
  change: add autotests/data/test_image.png


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 
11 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 64/103 (62%)CLASSES 64/103 (62%)LINE 3934/9816 
(40%)CONDITIONAL 1990/3092 (64%)

By packages
  
autotests
FILES 20/20 (100%)CLASSES 20/20 (100%)LINE 669/690 
(97%)CONDITIONAL 440/766 (57%)
src.declarativeimports.core
FILES 10/20 (50%)CLASSES 10/20 (50%)LINE 529/1836 
(29%)CONDITIONAL 194/290 (67%)
src.plasma
FILES 14/21 (67%)CLASSES 14/21 (67%)LINE 1657/3660 
(45%)CONDITIONAL 902/1322 (68%)
src.plasma.private
FILES 15/24 (63%)CLASSES 15/24 (63%)LINE 849/1667 
(51%)CONDITIONAL 353/525 (67%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/182 (0%)CONDITIONAL 0/0 
(100%)
src.plasmaquick
FILES 5/12 (42%)CLASSES 5/12 (42%)LINE 230/1668 
(14%)CONDITIONAL 101/189 (53%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 293 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/293/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Fri, 04 Mar 2016 15:50:41 +
Build duration: 2 min 27 sec

CHANGE SET
Revision 929d1fe008c84c921d123190fa978a44c6bb4c06 by David Edmundson: (Add 
missing file for iconitem test)
  change: add autotests/data/test_image.png


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 
11 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 64/103 (62%)CLASSES 64/103 (62%)LINE 3934/9816 
(40%)CONDITIONAL 1990/3092 (64%)

By packages
  
autotests
FILES 20/20 (100%)CLASSES 20/20 (100%)LINE 669/690 
(97%)CONDITIONAL 440/766 (57%)
src.declarativeimports.core
FILES 10/20 (50%)CLASSES 10/20 (50%)LINE 529/1836 
(29%)CONDITIONAL 194/290 (67%)
src.plasma
FILES 14/21 (67%)CLASSES 14/21 (67%)LINE 1657/3660 
(45%)CONDITIONAL 902/1322 (68%)
src.plasma.private
FILES 15/24 (63%)CLASSES 15/24 (63%)LINE 849/1667 
(51%)CONDITIONAL 353/525 (67%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/182 (0%)CONDITIONAL 0/0 
(100%)
src.plasmaquick
FILES 5/12 (42%)CLASSES 5/12 (42%)LINE 230/1668 
(14%)CONDITIONAL 101/189 (53%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 293 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/293/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Fri, 04 Mar 2016 15:50:41 +
Build duration: 3 min 27 sec

CHANGE SET
Revision 929d1fe008c84c921d123190fa978a44c6bb4c06 by David Edmundson: (Add 
missing file for iconitem test)
  change: add autotests/data/test_image.png


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 
12 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 67/107 (63%)CLASSES 67/107 (63%)LINE 4364/10284 
(42%)CONDITIONAL 2275/3503 (65%)

By packages
  
autotests
FILES 22/22 (100%)CLASSES 22/22 (100%)LINE 714/737 
(97%)CONDITIONAL 456/798 (57%)
src.declarativeimports.core
FILES 10/20 (50%)CLASSES 10/20 (50%)LINE 619/2059 
(30%)CONDITIONAL 280/414 (68%)
src.plasma
FILES 14/21 (67%)CLASSES 14/21 (67%)LINE 1659/3660 
(45%)CONDITIONAL 908/1322 (69%)
src.plasma.private
FILES 16/26 (62%)CLASSES 16/26 (62%)LINE 895/1741 
(51%)CONDITIONAL 371/555 (67%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/182 (0%)CONDITIONAL 0/0 
(100%)
src.plasmaquick
FILES 5/12 (42%)CLASSES 5/12 (42%)LINE 477/1792 
(27%)CONDITIONAL 260/414 (63%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 293 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/293/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Fri, 04 Mar 2016 15:50:41 +
Build duration: 3 min 27 sec

CHANGE SET
Revision 929d1fe008c84c921d123190fa978a44c6bb4c06 by David Edmundson: (Add 
missing file for iconitem test)
  change: add autotests/data/test_image.png


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 
12 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 67/107 (63%)CLASSES 67/107 (63%)LINE 4364/10284 
(42%)CONDITIONAL 2275/3503 (65%)

By packages
  
autotests
FILES 22/22 (100%)CLASSES 22/22 (100%)LINE 714/737 
(97%)CONDITIONAL 456/798 (57%)
src.declarativeimports.core
FILES 10/20 (50%)CLASSES 10/20 (50%)LINE 619/2059 
(30%)CONDITIONAL 280/414 (68%)
src.plasma
FILES 14/21 (67%)CLASSES 14/21 (67%)LINE 1659/3660 
(45%)CONDITIONAL 908/1322 (69%)
src.plasma.private
FILES 16/26 (62%)CLASSES 16/26 (62%)LINE 895/1741 
(51%)CONDITIONAL 371/555 (67%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/182 (0%)CONDITIONAL 0/0 
(100%)
src.plasmaquick
FILES 5/12 (42%)CLASSES 5/12 (42%)LINE 477/1792 
(27%)CONDITIONAL 260/414 (63%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 300 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/300/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Fri, 04 Mar 2016 15:50:41 +
Build duration: 2 min 16 sec

CHANGE SET
Revision 929d1fe008c84c921d123190fa978a44c6bb4c06 by David Edmundson: (Add 
missing file for iconitem test)
  change: add autotests/data/test_image.png


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 
12 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 67/107 (63%)CLASSES 67/107 (63%)LINE 4375/10325 
(42%)CONDITIONAL 2275/3503 (65%)

By packages
  
autotests
FILES 22/22 (100%)CLASSES 22/22 (100%)LINE 719/741 
(97%)CONDITIONAL 455/798 (57%)
src.declarativeimports.core
FILES 10/20 (50%)CLASSES 10/20 (50%)LINE 620/2060 
(30%)CONDITIONAL 280/414 (68%)
src.plasma
FILES 14/21 (67%)CLASSES 14/21 (67%)LINE 1662/3665 
(45%)CONDITIONAL 908/1322 (69%)
src.plasma.private
FILES 16/26 (62%)CLASSES 16/26 (62%)LINE 896/1748 
(51%)CONDITIONAL 372/555 (67%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/192 (0%)CONDITIONAL 0/0 
(100%)
src.plasmaquick
FILES 5/12 (42%)CLASSES 5/12 (42%)LINE 478/1806 
(26%)CONDITIONAL 260/414 (63%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 300 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/300/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Fri, 04 Mar 2016 15:50:41 +
Build duration: 2 min 16 sec

CHANGE SET
Revision 929d1fe008c84c921d123190fa978a44c6bb4c06 by David Edmundson: (Add 
missing file for iconitem test)
  change: add autotests/data/test_image.png


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 
12 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 67/107 (63%)CLASSES 67/107 (63%)LINE 4375/10325 
(42%)CONDITIONAL 2275/3503 (65%)

By packages
  
autotests
FILES 22/22 (100%)CLASSES 22/22 (100%)LINE 719/741 
(97%)CONDITIONAL 455/798 (57%)
src.declarativeimports.core
FILES 10/20 (50%)CLASSES 10/20 (50%)LINE 620/2060 
(30%)CONDITIONAL 280/414 (68%)
src.plasma
FILES 14/21 (67%)CLASSES 14/21 (67%)LINE 1662/3665 
(45%)CONDITIONAL 908/1322 (69%)
src.plasma.private
FILES 16/26 (62%)CLASSES 16/26 (62%)LINE 896/1748 
(51%)CONDITIONAL 372/555 (67%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/192 (0%)CONDITIONAL 0/0 
(100%)
src.plasmaquick
FILES 5/12 (42%)CLASSES 5/12 (42%)LINE 478/1806 
(26%)CONDITIONAL 260/414 (63%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 300 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/300/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Fri, 04 Mar 2016 15:50:41 +
Build duration: 2 min 8 sec

CHANGE SET
Revision 929d1fe008c84c921d123190fa978a44c6bb4c06 by David Edmundson: (Add 
missing file for iconitem test)
  change: add autotests/data/test_image.png


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 
11 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 64/103 (62%)CLASSES 64/103 (62%)LINE 3946/9857 
(40%)CONDITIONAL 1991/3094 (64%)

By packages
  
autotests
FILES 20/20 (100%)CLASSES 20/20 (100%)LINE 671/694 
(97%)CONDITIONAL 440/766 (57%)
src.declarativeimports.core
FILES 10/20 (50%)CLASSES 10/20 (50%)LINE 530/1837 
(29%)CONDITIONAL 194/290 (67%)
src.plasma
FILES 14/21 (67%)CLASSES 14/21 (67%)LINE 1660/3665 
(45%)CONDITIONAL 902/1322 (68%)
src.plasma.private
FILES 15/24 (63%)CLASSES 15/24 (63%)LINE 854/1674 
(51%)CONDITIONAL 354/527 (67%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/192 (0%)CONDITIONAL 0/0 
(100%)
src.plasmaquick
FILES 5/12 (42%)CLASSES 5/12 (42%)LINE 231/1682 
(14%)CONDITIONAL 101/189 (53%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

[Thomas Lübking]

> On March 3, 2016, 10:16 p.m., Thomas Lübking wrote:
> > src/kstatusnotifieritem.cpp, line 934
> > 
> >
> > append
> > associatedWidget->setAttribute(Qt::WA_Moved);
> > 
> > 
> > 
> > This should tell Qt to demand an explicit position and skip placement 
> > by the WM (yes, this generally works in KWin ;-)
> > 
> > However, this flag should be implicitly set by ::move() unless the 
> > point is invalid, so you might want to "qDebug() << associatedWidgetPos;" 
> > to check whether it's invalid for the failing clients.
> 
> Anthony Fieroni wrote:
> Fun facts :) void KStatusNotifierItemPrivate::minimizeRestore(bool) is 
> called only when you click on tray icon i.e. if i close app with big red X 
> it's not called => i can't store position :)
> 
> Anthony Fieroni wrote:
> More fun facts :) 
> associatedWidget->setGeometry(associatedWidget->frameGeometry()); works in 
> any case ! I will add path if you want, but you will not be happy to set 
> geometry by myself :)
> 
> Anthony Fieroni wrote:
> ^ No, extend geometry with decoration size :)

meehhh...

That means one will have to filter QEvent::Close of associatedWidget and store 
the position from there.


- Thomas


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127216/#review93143
---


On Feb. 29, 2016, 5:18 a.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127216/
> ---
> 
> (Updated Feb. 29, 2016, 5:18 a.m.)
> 
> 
> Review request for KDE Frameworks, Martin Gräßlin, Thomas Lübking, and Martin 
> Klapetek.
> 
> 
> Bugs: 356523
> https://bugs.kde.org/show_bug.cgi?id=356523
> 
> 
> Repository: knotifications
> 
> 
> Description
> ---
> 
> Store position of widget before hide it
> 
> 
> Diffs
> -
> 
>   src/kstatusnotifieritem.cpp cf3e7b5 
>   src/kstatusnotifieritemprivate_p.h 8fdfd4c 
> 
> Diff: https://git.reviewboard.kde.org/r/127216/diff/
> 
> 
> Testing
> ---
> 
> Tested on pixel ration = 1
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127261: Fix dead lock when program use kauth exits.

[Xuetian Weng]

> On March 3, 2016, 7:05 a.m., Martin Gräßlin wrote:
> > nice work! I had run into it in the past and didn't succeed investigating 
> > it.
> 
> Xuetian Weng wrote:
> https://bugreports.qt.io/browse/QTBUG-51648
> 
> As pointed out by Thiago on irc, this should be considered as a bug in 
> Qt. Not sure if we want to commit it. As disconnecting this signal indeed 
> breaks some invariant in qtdbus (not critical though, since we are going to 
> exit anyway).
> 
> Martin Gräßlin wrote:
> Let's wait then whether Qt 5.6 comes with it fixed or not.

Well, Thiago said there's no time to fix it before 5.6.0 though.


- Xuetian


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127261/#review93082
---


On March 2, 2016, 8:58 p.m., Xuetian Weng wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127261/
> ---
> 
> (Updated March 2, 2016, 8:58 p.m.)
> 
> 
> Review request for KDE Frameworks and David Edmundson.
> 
> 
> Repository: kauth
> 
> 
> Description
> ---
> 
> I'm on Qt 5.6 RC, and just notice a issue that kded5 never cleanly exits.
> 
> With gdb attached to kded5, it shows following backtrace:
> 
> #1  0x75c820eb in QWaitConditionPrivate::wait 
> (time=18446744073709551615, this=0x74ac70) at 
> thread/qwaitcondition_unix.cpp:136
> #2  QWaitCondition::wait (this=this@entry=0x71c308, 
> mutex=mutex@entry=0x71c300, time=time@entry=18446744073709551615) at 
> thread/qwaitcondition_unix.cpp:208
> #3  0x75c7b08b in QSemaphore::acquire 
> (this=this@entry=0x7fffd840, n=n@entry=1) at thread/qsemaphore.cpp:137
> #4  0x75e80fff in QMetaObject::activate 
> (sender=sender@entry=0x976280, signalOffset=, 
> local_signal_index=local_signal_index@entry=0, argv=argv@entry=0x7fffd8d0)
> at kernel/qobject.cpp:3698
> #5  0x75e81687 in QMetaObject::activate 
> (sender=sender@entry=0x976280, m=m@entry=0x76092760 
> , local_signal_index=local_signal_index@entry=0, 
> argv=argv@entry=0x7fffd8d0) at kernel/qobject.cpp:3595
> #6  0x75e8172f in QObject::destroyed (this=this@entry=0x976280, 
> _t1=_t1@entry=0x976280) at .moc/moc_qobject.cpp:213
> #7  0x75e886e5 in QObject::~QObject (this=, 
> __in_chrg=) at kernel/qobject.cpp:913
> #8  0x7fffb39bbb09 in KAuth::DBusHelperProxy::~DBusHelperProxy 
> (this=0x976280, __in_chrg=) at 
> /chakra/core/kauth/src/kauth-5.19.0/src/backends/dbus/DBusHelperProxy.cpp:55
> #9  0x75e49ff9 in QLibraryPrivate::unload (this=0x71dba0, 
> flag=QLibraryPrivate::NoUnloadSys) at plugin/qlibrary.cpp:551
> #10 0x75e4e521 in QLibraryStore::cleanup () at 
> plugin/qlibrary.cpp:397
> #11 0x778592ef in __cxa_finalize () from /usr/lib/libc.so.6
> #12 0x75c52583 in __do_global_dtors_aux () from 
> /usr/lib/libQt5Core.so.5
> #13 0x7fffe230 in ?? ()
> #14 0x77dea867 in _dl_fini () from /lib64/ld-linux-x86-64.so.2
> 
> 
> Which indicates that kauth dbus plugin's QObject::destroyed is being 
> connected to QDBusConnectionPrivate with Qt::BlockQueuedConnection. But at 
> this point, QApplication is already gone and this call is never being 
> handled. Disconnect everything in destructor can fix this issue.
> 
> Related upstream qt code:
> https://github.com/qtproject/qtbase/blob/5.6.0/src/dbus/qdbusintegrator.cpp#L2135
> 
> 
> Diffs
> -
> 
>   src/backends/dbus/DBusHelperProxy.cpp 20dad0a 
> 
> Diff: https://git.reviewboard.kde.org/r/127261/diff/
> 
> 
> Testing
> ---
> 
> Now kded5 can exits upon logout/exit. Tested with kquitapp5 kded5.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127275: Ki18n: Fallback to QLocale::system uiLanguages in language initalisation

[Andre Heinecke]

> On March 4, 2016, 3:01 p.m., Chusslove Illich wrote:
> > src/klocalizedstring.cpp, line 368
> > 
> >
> > I would nevertheless ifdef it. It may be that some strange thing is 
> > intentionally done with locale variables (e.g. to test something or kill 
> > localization), and then the behavior would deviate from that documented for 
> > Gettext.

I'm assuming that QLocale::system() is also changed accodingly in that case so 
I don't think its a problem. The code looks like it's using the same 
environment variables: 
http://code.qt.io/cgit/qt/qtbase.git/tree/src/corelib/tools/qlocale_unix.cpp#n104
We still have to look at the environment variables in ki18n first because of 
modifier / charset handling, imo otherwise we could just use QLocale here.

For ifdef I would probably do an #infdef O_OS_UNIX instead of a Q_OS_WIN ? I'm 
not sure but I think this probably also makes sense on other platforms like 
android?


- Andre


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127275/#review93158
---


On March 4, 2016, 2:53 p.m., Andre Heinecke wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127275/
> ---
> 
> (Updated March 4, 2016, 2:53 p.m.)
> 
> 
> Review request for KDE Frameworks and Localization and Translation (l10n).
> 
> 
> Repository: ki18n
> 
> 
> Description
> ---
> 
> The intention for this patch is to fix the inital Language selection for 
> Windows where the environment variables used in Ki18n are not set.
> This is not a fix for a regression in Ki18n, afaik this never worked on 
> Windows, we had some hacks in Gpg4win to write the language into kdeglobals 
> during installation in kde4 times.
> 
> I don't think this needs to be ifdefed because it only appends so previous 
> language selection is not affected.
> 
> 
> Diffs
> -
> 
>   src/klocalizedstring.cpp b24fe9b 
> 
> Diff: https://git.reviewboard.kde.org/r/127275/diff/
> 
> 
> Testing
> ---
> 
> Tested on a german Windows system and got a "de" localized application.
> 
> 
> Thanks,
> 
> Andre Heinecke
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127275: Ki18n: Fallback to QLocale::system uiLanguages in language initalisation

[Chusslove Illich]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127275/#review93158
---




src/klocalizedstring.cpp (line 349)


I would nevertheless ifdef it. It may be that some strange thing is 
intentionally done with locale variables (e.g. to test something or kill 
localization), and then the behavior would deviate from that documented for 
Gettext.


- Chusslove Illich


On Март 4, 2016, 3:53 по п., Andre Heinecke wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127275/
> ---
> 
> (Updated Март 4, 2016, 3:53 по п.)
> 
> 
> Review request for KDE Frameworks and Localization and Translation (l10n).
> 
> 
> Repository: ki18n
> 
> 
> Description
> ---
> 
> The intention for this patch is to fix the inital Language selection for 
> Windows where the environment variables used in Ki18n are not set.
> This is not a fix for a regression in Ki18n, afaik this never worked on 
> Windows, we had some hacks in Gpg4win to write the language into kdeglobals 
> during installation in kde4 times.
> 
> I don't think this needs to be ifdefed because it only appends so previous 
> language selection is not affected.
> 
> 
> Diffs
> -
> 
>   src/klocalizedstring.cpp b24fe9b 
> 
> Diff: https://git.reviewboard.kde.org/r/127275/diff/
> 
> 
> Testing
> ---
> 
> Tested on a german Windows system and got a "de" localized application.
> 
> 
> Thanks,
> 
> Andre Heinecke
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126991: Try multiple authentication methods in case of failures

[Andreas Hartmetz]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126991/#review93157
---


Ship it!




Ship It!

- Andreas Hartmetz


On March 3, 2016, 9:01 p.m., Krzysztof Nowicki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126991/
> ---
> 
> (Updated March 3, 2016, 9:01 p.m.)
> 
> 
> Review request for KDE Frameworks and Dawit Alemayehu.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> When authenticating agains a server offering multiple authentication methods 
> make sure to attempt other methods in case the best one fails.
> 
> This also fixes a connection close issue in the middle of an NTLM 
> authentication dialog due to clearing the password.
> 
> 
> Diffs
> -
> 
>   src/ioslaves/http/http.h 621b2c7a957b9bc9cc14ff13ed3c3a72dec38190 
>   src/ioslaves/http/http.cpp a84129f1403cbf8b0f86f9fd0354bec90ac5fd39 
> 
> Diff: https://git.reviewboard.kde.org/r/126991/diff/
> 
> 
> Testing
> ---
> 
> I have performed testing on an IIS 7.5 server which offered 3 authentication 
> options: Negotiate, NTLM and Basic. Since I have Kerberos configured the 
> original code would only try Negotiate and because it failed it would retry 
> it endlessly. With this patch authentication correctly falls back to NTLM or 
> Basic (if NTLM fails too).
> 
> 
> Thanks,
> 
> Krzysztof Nowicki
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 299 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/299/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Fri, 04 Mar 2016 09:12:40 +
Build duration: 2 min 31 sec

CHANGE SET
Revision 6464f22534461b2b7c0e20f74caebd9a415aa16a by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit src/desktoptheme/breeze-light/metadata.desktop


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 
12 test(s)Failed: TestSuite.plasma-iconitemtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 67/107 (63%)CLASSES 67/107 (63%)LINE 4369/10325 
(42%)CONDITIONAL 2269/3495 (65%)

By packages
  
autotests
FILES 22/22 (100%)CLASSES 22/22 (100%)LINE 714/741 
(96%)CONDITIONAL 452/790 (57%)
src.declarativeimports.core
FILES 10/20 (50%)CLASSES 10/20 (50%)LINE 619/2060 
(30%)CONDITIONAL 278/414 (67%)
src.plasma
FILES 14/21 (67%)CLASSES 14/21 (67%)LINE 1662/3665 
(45%)CONDITIONAL 908/1322 (69%)
src.plasma.private
FILES 16/26 (62%)CLASSES 16/26 (62%)LINE 896/1748 
(51%)CONDITIONAL 371/555 (67%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/192 (0%)CONDITIONAL 0/0 
(100%)
src.plasmaquick
FILES 5/12 (42%)CLASSES 5/12 (42%)LINE 478/1806 
(26%)CONDITIONAL 260/414 (63%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 299 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/299/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Fri, 04 Mar 2016 09:12:40 +
Build duration: 3 min 3 sec

CHANGE SET
Revision 6464f22534461b2b7c0e20f74caebd9a415aa16a by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit src/desktoptheme/breeze-light/metadata.desktop


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.plasma-iconitemtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 64/103 (62%)CLASSES 64/103 (62%)LINE 3937/9857 
(40%)CONDITIONAL 1983/3084 (64%)

By packages
  
autotests
FILES 20/20 (100%)CLASSES 20/20 (100%)LINE 667/694 
(96%)CONDITIONAL 436/758 (58%)
src.declarativeimports.core
FILES 10/20 (50%)CLASSES 10/20 (50%)LINE 529/1837 
(29%)CONDITIONAL 192/290 (66%)
src.plasma
FILES 14/21 (67%)CLASSES 14/21 (67%)LINE 1660/3665 
(45%)CONDITIONAL 902/1322 (68%)
src.plasma.private
FILES 15/24 (63%)CLASSES 15/24 (63%)LINE 850/1674 
(51%)CONDITIONAL 352/525 (67%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/192 (0%)CONDITIONAL 0/0 
(100%)
src.plasmaquick
FILES 5/12 (42%)CLASSES 5/12 (42%)LINE 231/1682 
(14%)CONDITIONAL 101/189 (53%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 292 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/292/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Fri, 04 Mar 2016 09:12:40 +
Build duration: 2 min 18 sec

CHANGE SET
Revision 6464f22534461b2b7c0e20f74caebd9a415aa16a by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit src/desktoptheme/breeze-light/metadata.desktop


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.plasma-iconitemtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 64/103 (62%)CLASSES 64/103 (62%)LINE 3929/9816 
(40%)CONDITIONAL 1984/3084 (64%)

By packages
  
autotests
FILES 20/20 (100%)CLASSES 20/20 (100%)LINE 665/690 
(96%)CONDITIONAL 436/758 (58%)
src.declarativeimports.core
FILES 10/20 (50%)CLASSES 10/20 (50%)LINE 528/1836 
(29%)CONDITIONAL 192/290 (66%)
src.plasma
FILES 14/21 (67%)CLASSES 14/21 (67%)LINE 1657/3660 
(45%)CONDITIONAL 902/1322 (68%)
src.plasma.private
FILES 15/24 (63%)CLASSES 15/24 (63%)LINE 849/1667 
(51%)CONDITIONAL 353/525 (67%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/182 (0%)CONDITIONAL 0/0 
(100%)
src.plasmaquick
FILES 5/12 (42%)CLASSES 5/12 (42%)LINE 230/1668 
(14%)CONDITIONAL 101/189 (53%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 292 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/292/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Fri, 04 Mar 2016 09:12:40 +
Build duration: 2 min 55 sec

CHANGE SET
Revision 6464f22534461b2b7c0e20f74caebd9a415aa16a by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit src/desktoptheme/breeze-light/metadata.desktop


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 
12 test(s)Failed: TestSuite.plasma-iconitemtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 67/107 (63%)CLASSES 67/107 (63%)LINE 4378/10284 
(43%)CONDITIONAL 2279/3503 (65%)

By packages
  
autotests
FILES 22/22 (100%)CLASSES 22/22 (100%)LINE 712/737 
(97%)CONDITIONAL 452/790 (57%)
src.declarativeimports.core
FILES 10/20 (50%)CLASSES 10/20 (50%)LINE 618/2059 
(30%)CONDITIONAL 278/414 (67%)
src.plasma
FILES 14/21 (67%)CLASSES 14/21 (67%)LINE 1661/3660 
(45%)CONDITIONAL 912/1324 (69%)
src.plasma.private
FILES 16/26 (62%)CLASSES 16/26 (62%)LINE 910/1741 
(52%)CONDITIONAL 377/561 (67%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/182 (0%)CONDITIONAL 0/0 
(100%)
src.plasmaquick
FILES 5/12 (42%)CLASSES 5/12 (42%)LINE 477/1792 
(27%)CONDITIONAL 260/414 (63%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 
(100%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127275: Ki18n: Fallback to QLocale::system uiLanguages in language initalisation

[Andre Heinecke]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127275/
---

Review request for KDE Frameworks.


Repository: ki18n


Description
---

The intention for this patch is to fix the inital Language selection for 
Windows where the environment variables used in Ki18n are not set.
This is not a fix for a regression in Ki18n, afaik this never worked on 
Windows, we had some hacks in Gpg4win to write the language into kdeglobals 
during installation in kde4 times.

I don't think this needs to be ifdefed because it only appends so previous 
language selection is not affected.


Diffs
-

  src/klocalizedstring.cpp b24fe9b 

Diff: https://git.reviewboard.kde.org/r/127275/diff/


Testing
---

Tested on a german Windows system and got a "de" localized application.


Thanks,

Andre Heinecke

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: ki18n master stable-kf5-qt5 » Linux,gcc - Build # 57 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/ki18n%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/57/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 04 Mar 2016 09:09:45 +
Build duration: 1 min 26 sec

CHANGE SET
Revision be7e998af0ac032ec201fe88920d4e8b60062a82 by aleixpol: (Skip looking up 
. and .. to find the translations for an application)
  change: edit src/kcatalog.cpp
Revision b91904c55ef1aaeeb60f9e8153dc8a1f00d77fb0 by aheinecke: (Use portable 
import macro for nl_msg_cat_cntr)
  change: edit src/kcatalog.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 18/20 (90%)CLASSES 18/20 (90%)LINE 1837/3036 
(61%)CONDITIONAL 884/1404 (63%)

By packages
  
autotests
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 396/466 (85%)CONDITIONAL 
174/346 (50%)
src
FILES 10/12 (83%)CLASSES 10/12 (83%)LINE 1441/2570 
(56%)CONDITIONAL 710/1058 (67%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: ki18n master stable-kf5-qt5 » Linux,gcc - Build # 57 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/ki18n%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/57/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 04 Mar 2016 09:09:45 +
Build duration: 1 min 26 sec

CHANGE SET
Revision be7e998af0ac032ec201fe88920d4e8b60062a82 by aleixpol: (Skip looking up 
. and .. to find the translations for an application)
  change: edit src/kcatalog.cpp
Revision b91904c55ef1aaeeb60f9e8153dc8a1f00d77fb0 by aheinecke: (Use portable 
import macro for nl_msg_cat_cntr)
  change: edit src/kcatalog.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 18/20 (90%)CLASSES 18/20 (90%)LINE 1837/3036 
(61%)CONDITIONAL 884/1404 (63%)

By packages
  
autotests
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 396/466 (85%)CONDITIONAL 
174/346 (50%)
src
FILES 10/12 (83%)CLASSES 10/12 (83%)LINE 1441/2570 
(56%)CONDITIONAL 710/1058 (67%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: ki18n master kf5-qt5 » Linux,gcc - Build # 52 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/ki18n%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/52/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 04 Mar 2016 09:09:45 +
Build duration: 1 min 22 sec

CHANGE SET
Revision be7e998af0ac032ec201fe88920d4e8b60062a82 by aleixpol: (Skip looking up 
. and .. to find the translations for an application)
  change: edit src/kcatalog.cpp
Revision b91904c55ef1aaeeb60f9e8153dc8a1f00d77fb0 by aheinecke: (Use portable 
import macro for nl_msg_cat_cntr)
  change: edit src/kcatalog.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 18/20 (90%)CLASSES 18/20 (90%)LINE 1837/3036 
(61%)CONDITIONAL 884/1404 (63%)

By packages
  
autotests
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 396/466 (85%)CONDITIONAL 
174/346 (50%)
src
FILES 10/12 (83%)CLASSES 10/12 (83%)LINE 1441/2570 
(56%)CONDITIONAL 710/1058 (67%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: ki18n master kf5-qt5 » Linux,gcc - Build # 52 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/ki18n%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/52/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Fri, 04 Mar 2016 09:09:45 +
Build duration: 1 min 22 sec

CHANGE SET
Revision be7e998af0ac032ec201fe88920d4e8b60062a82 by aleixpol: (Skip looking up 
. and .. to find the translations for an application)
  change: edit src/kcatalog.cpp
Revision b91904c55ef1aaeeb60f9e8153dc8a1f00d77fb0 by aheinecke: (Use portable 
import macro for nl_msg_cat_cntr)
  change: edit src/kcatalog.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 18/20 (90%)CLASSES 18/20 (90%)LINE 1837/3036 
(61%)CONDITIONAL 884/1404 (63%)

By packages
  
autotests
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 396/466 (85%)CONDITIONAL 
174/346 (50%)
src
FILES 10/12 (83%)CLASSES 10/12 (83%)LINE 1441/2570 
(56%)CONDITIONAL 710/1058 (67%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127265: Fix windows build of Ki18n

[Andre Heinecke]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127265/
---

(Updated March 4, 2016, 9:09 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Andreas Cord-Landwehr and Kåre Särs.


Changes
---

Submitted with commit b91904c55ef1aaeeb60f9e8153dc8a1f00d77fb0 by Andre 
Heinecke to branch master.


Repository: ki18n


Description
---

In review Request 127048 (Restrict _nl_msg_cat_cntr use to GNU gettext 
implentations.) Unrelated Windows changes were requested and then introduced 
which in my opinion were wrong (and in the opinion of my compiler ;-) ).

You can't just do an extern "C" dllimport declaration inside a function body:

src/kcatalog.cpp:190:16: error: expected unqualified-id before string constant
 extern "C" int __declspec(dllimport) _nl_msg_cat_cntr;


Also that patch changed the Logic from an MSVC specific define to general 
Q_OS_WIN. This appears to be wrong, too. While I'm only testing with MinGW I'm 
pretty sure that the ifndef _MSC_VER was there for a reason.

This patch reverts the declaration move and logic change while keeping the 
__USE_GNU_GETTEXT guard.


Diffs
-

  src/kcatalog.cpp 083443d 

Diff: https://git.reviewboard.kde.org/r/127265/diff/


Testing
---

Compiled with mingw and __USE_GNU_GETTEXT for Windows. Also compiled for 
GNU/Linux.


Thanks,

Andre Heinecke

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127265: Fix windows build of Ki18n

[Andre Heinecke]

> On March 3, 2016, 9:35 p.m., Kevin Funk wrote:
> > Ship It!

Oh *facepalm* while pushing I noticed that I had not updated to latest changes 
and Thomas already fixed this issue,..
Anyhow Thomas patch did not use Q_DECL_IMPORT so I'm pushing that part of this 
patch.


- Andre


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127265/#review93140
---


On March 3, 2016, 5:49 p.m., Andre Heinecke wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127265/
> ---
> 
> (Updated March 3, 2016, 5:49 p.m.)
> 
> 
> Review request for KDE Frameworks, Andreas Cord-Landwehr and Kåre Särs.
> 
> 
> Repository: ki18n
> 
> 
> Description
> ---
> 
> In review Request 127048 (Restrict _nl_msg_cat_cntr use to GNU gettext 
> implentations.) Unrelated Windows changes were requested and then introduced 
> which in my opinion were wrong (and in the opinion of my compiler ;-) ).
> 
> You can't just do an extern "C" dllimport declaration inside a function body:
> 
> src/kcatalog.cpp:190:16: error: expected unqualified-id before string constant
>  extern "C" int __declspec(dllimport) _nl_msg_cat_cntr;
> 
> 
> Also that patch changed the Logic from an MSVC specific define to general 
> Q_OS_WIN. This appears to be wrong, too. While I'm only testing with MinGW 
> I'm pretty sure that the ifndef _MSC_VER was there for a reason.
> 
> This patch reverts the declaration move and logic change while keeping the 
> __USE_GNU_GETTEXT guard.
> 
> 
> Diffs
> -
> 
>   src/kcatalog.cpp 083443d 
> 
> Diff: https://git.reviewboard.kde.org/r/127265/diff/
> 
> 
> Testing
> ---
> 
> Compiled with mingw and __USE_GNU_GETTEXT for Windows. Also compiled for 
> GNU/Linux.
> 
> 
> Thanks,
> 
> Andre Heinecke
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel