Jenkins-kde-ci: kcoreaddons master kf5-qt5 » Linux,gcc - Build # 2 - Successful!

2016-03-22 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kcoreaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/2/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 22 Mar 2016 16:54:09 +
Build duration: 2 min 16 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 21 test(s), Skipped: 0 test(s), Total: 
21 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 10/10 (100%)FILES 76/91 (84%)CLASSES 76/91 (84%)LINE 5549/7713 
(72%)CONDITIONAL 11577/21481 (54%)

By packages
  
autotests
FILES 31/38 (82%)CLASSES 31/38 (82%)LINE 2384/2488 
(96%)CONDITIONAL 7038/13927 (51%)
src.desktoptojson
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 84/108 (78%)CONDITIONAL 
195/380 (51%)
src.lib
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 236/502 (47%)CONDITIONAL 
142/259 (55%)
src.lib.caching
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 352/764 (46%)CONDITIONAL 
200/380 (53%)
src.lib.io
FILES 9/10 (90%)CLASSES 9/10 (90%)LINE 738/1223 
(60%)CONDITIONAL 867/1412 (61%)
src.lib.jobs
FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 155/303 (51%)CONDITIONAL 
55/92 (60%)
src.lib.plugin
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 629/726 (87%)CONDITIONAL 
1144/1944 (59%)
src.lib.randomness
FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 21/98 (21%)CONDITIONAL 
21/34 (62%)
src.lib.text
FILES 5/8 (63%)CLASSES 5/8 (63%)LINE 312/729 (43%)CONDITIONAL 
1099/1765 (62%)
src.lib.util
FILES 10/10 (100%)CLASSES 10/10 (100%)LINE 638/772 
(83%)CONDITIONAL 816/1288 (63%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kcoreaddons master stable-kf5-qt5 » Linux,gcc - Build # 2 - Successful!

2016-03-22 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kcoreaddons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/2/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 22 Mar 2016 16:54:09 +
Build duration: 2 min 20 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 21 test(s), Skipped: 0 test(s), Total: 
21 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 10/10 (100%)FILES 76/91 (84%)CLASSES 76/91 (84%)LINE 5549/7711 
(72%)CONDITIONAL 12042/22409 (54%)

By packages
  
autotests
FILES 31/38 (82%)CLASSES 31/38 (82%)LINE 2384/2488 
(96%)CONDITIONAL 7273/14397 (51%)
src.desktoptojson
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 84/106 (79%)CONDITIONAL 
214/417 (51%)
src.lib
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 236/502 (47%)CONDITIONAL 
204/383 (53%)
src.lib.caching
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 352/764 (46%)CONDITIONAL 
202/384 (53%)
src.lib.io
FILES 9/10 (90%)CLASSES 9/10 (90%)LINE 738/1223 
(60%)CONDITIONAL 896/1470 (61%)
src.lib.jobs
FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 155/303 (51%)CONDITIONAL 
55/92 (60%)
src.lib.plugin
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 629/726 (87%)CONDITIONAL 
1195/2045 (58%)
src.lib.randomness
FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 21/98 (21%)CONDITIONAL 
23/38 (61%)
src.lib.text
FILES 5/8 (63%)CLASSES 5/8 (63%)LINE 312/729 (43%)CONDITIONAL 
1133/1833 (62%)
src.lib.util
FILES 10/10 (100%)CLASSES 10/10 (100%)LINE 638/772 
(83%)CONDITIONAL 847/1350 (63%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kdeclarative master kf5-qt5 » Linux,gcc - Build # 1 - Successful!

2016-03-22 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kdeclarative%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/1/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 22 Mar 2016 16:23:54 +
Build duration: 1 min 59 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/5 (100%)FILES 19/24 (79%)CLASSES 19/24 (79%)LINE 721/1217 
(59%)CONDITIONAL 319/568 (56%)

By packages
  
autotests
FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 388/470 (83%)CONDITIONAL 
192/370 (52%)
src.kdeclarative
FILES 3/4 (75%)CLASSES 3/4 (75%)LINE 154/317 (49%)CONDITIONAL 
60/100 (60%)
src.kdeclarative.private
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 24/58 (41%)CONDITIONAL 
6/10 (60%)
src.qmlcontrols.kquickcontrolsaddons
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 67/118 (57%)CONDITIONAL 
36/50 (72%)
src.quickaddons
FILES 2/6 (33%)CLASSES 2/6 (33%)LINE 88/254 (35%)CONDITIONAL 
25/38 (66%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kdeclarative master stable-kf5-qt5 » Linux,gcc - Build # 1 - Successful!

2016-03-22 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kdeclarative%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/1/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 22 Mar 2016 16:23:54 +
Build duration: 1 min 23 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/5 (100%)FILES 19/24 (79%)CLASSES 19/24 (79%)LINE 721/1217 
(59%)CONDITIONAL 319/568 (56%)

By packages
  
autotests
FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 388/470 (83%)CONDITIONAL 
192/370 (52%)
src.kdeclarative
FILES 3/4 (75%)CLASSES 3/4 (75%)LINE 154/317 (49%)CONDITIONAL 
60/100 (60%)
src.kdeclarative.private
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 24/58 (41%)CONDITIONAL 
6/10 (60%)
src.qmlcontrols.kquickcontrolsaddons
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 67/118 (57%)CONDITIONAL 
36/50 (72%)
src.quickaddons
FILES 2/6 (33%)CLASSES 2/6 (33%)LINE 88/254 (35%)CONDITIONAL 
25/38 (66%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126618: Make CMake macro kcoreaddons_desktop_to_json() work on windows.

2016-03-22 Thread Kåre Särs 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126618/
---

(Updated March 22, 2016, 4:53 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit 7ac7a605923f0bb2f0f367f6069a101a24bead9f by Kåre Särs to 
branch master.


Repository: kcoreaddons


Description
---

Without this patch kcoreaddons_desktop_to_json() will not find the service type 
destop file.

On windows GenericDataLocation returns "C:/Users//AppData/Local" or 
"C:/ProgramData". That is not a path that contains any destop files ;)

This patch adds KDE_INSTALL_FULL_KSERVICETYPES5DIR as fist item in the search 
paths and if not found searches like before.


Diffs
-

  KF5CoreAddonsMacros.cmake 5d8e3d4 

Diff: https://git.reviewboard.kde.org/r/126618/diff/


Testing
---

KTextEditor compiles on windows


Thanks,

Kåre Särs

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127462: Add support for XDG_*_HOME enviroment variables.

2016-03-22 Thread Sandro Knauß 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127462/
---

Review request for KDE Frameworks and Matthew Dawson.


Repository: kconfig


Description
---

According to freedesktop specification XDG_*_HOME env varaible should be
replaced, if they are not setted with default values.

https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html

as qgetenv only calls getenv, so no path is traslated to it default values. So 
we have to add this replacement manually. This would help to use XDG_*_HOME 
more often in configfiles.


Diffs
-

  autotests/kconfigtest.cpp e92197f3be57ead47b70ca5d040474e7a554c416 
  src/core/kconfig.cpp 07fa6f552c61c52cc1dd64a1c5fb0e2f00873d50 

Diff: https://git.reviewboard.kde.org/r/127462/diff/


Testing
---

Adding tests for XDG_*_HOME variables.


Thanks,

Sandro Knauß

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127437: Fix many threading issues in KUrlCompletion

2016-03-22 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127437/#review93863
---


Ship it!




Ship It!

- David Edmundson


On March 20, 2016, 2:46 p.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127437/
> ---
> 
> (Updated March 20, 2016, 2:46 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> * Major race with other threads due to using QDir::setCurrent()
> * Race conditions on m_terminationRequested and m_matches
> * Race with previous completion thread when its posted event arrives after 
> cancelling
> * Cancellation code spread out in many methods and never done fully correctly
> * isRunning() was missing one of the two threads, making unit test fail in 
> valgrind
> * Fix the rarely-hit code path where the thread isn't finished after 200ms
>- the current search string was lost because finished() wasn't called
>- the matches were not used, in case of user-completion (AFAICS)
>- changing the search string while the thread was running could lead to 
> the old search
>  string still being used for completion
>  (the misnamed finished() wasn't called, so KCompletion didn't get the 
> new string)
>   => added a variant of the unittest which doesn't wait for the thread 
> initially
> 
> + Simplify code using signal/slots rather than a custom event
> + Simplify code using enum rather than casting to/from int
> 
> Most of these bugs are from 2004 (e.g. commit ec83c408619e3) ;)
> 
> REVIEW: 127437
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt 4dff0a24d31897a9641a70017bd87e33415cef14 
>   autotests/kurlcompletiontest.cpp eef39ff17940fadcb9492e5e7092070c976310d4 
>   src/widgets/CMakeLists.txt 87dac50b377f6ea4c3cd39e9afa37a4680aecf31 
>   src/widgets/kurlcompletion.h 14fda22a0e08bcf2da30e19fed577c8bda64a4ca 
>   src/widgets/kurlcompletion.cpp 1dc8f4898fb78d6f49e687462446007a10305f98 
> 
> Diff: https://git.reviewboard.kde.org/r/127437/diff/
> 
> 
> Testing
> ---
> 
> Hit a crash in DirectoryListThread when playing with kopenwithtest.
> 
> kurlcompletiontest extended, kurlcompletion-nowait added, both pass, also in 
> valgrind (different timings).
> 
> 
> Thanks,
> 
> David Faure
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 1 - Unstable!

2016-03-22 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/1/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 22 Mar 2016 08:36:06 +
Build duration: 5 min 20 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 
49 test(s)Failed: TestSuite.kiocore-kfileitemtestFailed: 
TestSuite.kiowidgets-kurifiltertest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 260/338 (77%)CLASSES 260/338 (77%)LINE 26960/50894 
(53%)CONDITIONAL 14693/22809 (64%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7449/7742 
(96%)CONDITIONAL 4060/7456 (54%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 538/540 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 182/199 (91%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7833/14146 
(55%)CONDITIONAL 4095/5684 (72%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2281/7591 
(30%)CONDITIONAL 912/1403 (65%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 108/114 (95%)CONDITIONAL 
46/68 (68%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 430/844 (51%)CONDITIONAL 
313/459 (68%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1840/3852 
(48%)CONDITIONAL 1315/1948 (68%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 642/804 (80%)CONDITIONAL 
602/758 (79%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 684/1183 (58%)CONDITIONAL 
358/495 (72%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 690/768 (90%)CONDITIONAL 
433/820 (53%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/26 (54%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/126 (81%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 384/600 (64%)CONDITIONAL 
280/408 (69%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 280/285 (98%)CONDITIONAL 
144/254 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 32/35 (91%)CONDITIONAL 
42/52 (81%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 248/743 (33%)CONDITIONAL 
147/194 (76%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 20/27 (74%)CONDITIONAL 
14/18 (78%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 214/259 (83%)CONDITIONAL 
282/346 (82%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2697/10658 
(25%)CONDITIONAL 1280/1878 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 1 - Unstable!

2016-03-22 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/1/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 22 Mar 2016 08:30:41 +
Build duration: 5 min 30 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 
49 test(s)Failed: TestSuite.kiocore-kfileitemtestFailed: 
TestSuite.kiowidgets-kurifiltertest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 260/338 (77%)CLASSES 260/338 (77%)LINE 26969/50892 
(53%)CONDITIONAL 14706/22825 (64%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7447/7740 
(96%)CONDITIONAL 4061/7456 (54%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 538/540 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 182/199 (91%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7835/14146 
(55%)CONDITIONAL 4098/5686 (72%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2281/7591 
(30%)CONDITIONAL 912/1403 (65%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 108/114 (95%)CONDITIONAL 
46/68 (68%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 430/844 (51%)CONDITIONAL 
313/459 (68%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1849/3852 
(48%)CONDITIONAL 1324/1962 (67%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 642/804 (80%)CONDITIONAL 
602/758 (79%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 684/1183 (58%)CONDITIONAL 
358/495 (72%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 690/768 (90%)CONDITIONAL 
433/820 (53%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/26 (54%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/126 (81%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 384/600 (64%)CONDITIONAL 
280/408 (69%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 280/285 (98%)CONDITIONAL 
144/254 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 32/35 (91%)CONDITIONAL 
42/52 (81%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 248/743 (33%)CONDITIONAL 
147/194 (76%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 20/27 (74%)CONDITIONAL 
14/18 (78%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 214/259 (83%)CONDITIONAL 
282/346 (82%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2697/10658 
(25%)CONDITIONAL 1280/1878 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127437: Fix many threading issues in KUrlCompletion

2016-03-22 Thread David Faure 


> On March 21, 2016, 6:18 p.m., David Edmundson wrote:
> > src/widgets/kurlcompletion.cpp, line 1445
> > 
> >
> > this looks wrong, shouldn't it be insertItems (or ::addMatches which 
> > does the same thing)
> > 
> > we'll get this method called twice, once for each thread that takes 
> > longer than the initial timeout, setItems will discard matches from the 
> > first thread.

Only *one* of the threads is running. We are *either* running user completion 
("~") or directory completion.
Note how the previous code was calling stop+clear, as well.

I could have kept clear+addMatches, it would make no difference, it's the same 
as setItems (AFAICS).

I just don't call stop() anymore, because now stop() is "asking the thread to 
finish (abort)", while this slot is called once the thread has finished (or 
just before it really finishes, but at least it's about to, it doesn't need to 
be requested to stop).

Maybe an "else" between the last two if()s in the slot would make it clearer?

Thanks for the review, I'm open for more suggestions :-)


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127437/#review93829
---


On March 20, 2016, 2:46 p.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127437/
> ---
> 
> (Updated March 20, 2016, 2:46 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> * Major race with other threads due to using QDir::setCurrent()
> * Race conditions on m_terminationRequested and m_matches
> * Race with previous completion thread when its posted event arrives after 
> cancelling
> * Cancellation code spread out in many methods and never done fully correctly
> * isRunning() was missing one of the two threads, making unit test fail in 
> valgrind
> * Fix the rarely-hit code path where the thread isn't finished after 200ms
>- the current search string was lost because finished() wasn't called
>- the matches were not used, in case of user-completion (AFAICS)
>- changing the search string while the thread was running could lead to 
> the old search
>  string still being used for completion
>  (the misnamed finished() wasn't called, so KCompletion didn't get the 
> new string)
>   => added a variant of the unittest which doesn't wait for the thread 
> initially
> 
> + Simplify code using signal/slots rather than a custom event
> + Simplify code using enum rather than casting to/from int
> 
> Most of these bugs are from 2004 (e.g. commit ec83c408619e3) ;)
> 
> REVIEW: 127437
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt 4dff0a24d31897a9641a70017bd87e33415cef14 
>   autotests/kurlcompletiontest.cpp eef39ff17940fadcb9492e5e7092070c976310d4 
>   src/widgets/CMakeLists.txt 87dac50b377f6ea4c3cd39e9afa37a4680aecf31 
>   src/widgets/kurlcompletion.h 14fda22a0e08bcf2da30e19fed577c8bda64a4ca 
>   src/widgets/kurlcompletion.cpp 1dc8f4898fb78d6f49e687462446007a10305f98 
> 
> Diff: https://git.reviewboard.kde.org/r/127437/diff/
> 
> 
> Testing
> ---
> 
> Hit a crash in DirectoryListThread when playing with kopenwithtest.
> 
> kurlcompletiontest extended, kurlcompletion-nowait added, both pass, also in 
> valgrind (different timings).
> 
> 
> Thanks,
> 
> David Faure
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,All,gcc - Build # 1 - Successful!

2016-03-22 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/1/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Tue, 22 Mar 2016 07:01:09 +
Build duration: 2 min 9 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
10 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 3/4 (75%)FILES 40/46 (87%)CLASSES 40/46 (87%)LINE 6562/8814 
(74%)CONDITIONAL 3611/5606 (64%)

By packages
  
autotests
FILES 13/13 (100%)CLASSES 13/13 (100%)LINE 2785/2847 
(98%)CONDITIONAL 1483/2795 (53%)
src
FILES 13/15 (87%)CLASSES 13/15 (87%)LINE 751/1407 
(53%)CONDITIONAL 307/462 (66%)
src.platforms.wayland
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/89 (0%)CONDITIONAL 0/0 
(100%)
src.platforms.xcb
FILES 14/16 (88%)CLASSES 14/16 (88%)LINE 3026/4471 
(68%)CONDITIONAL 1821/2349 (78%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 1 - Successful!

2016-03-22 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/1/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Tue, 22 Mar 2016 07:01:09 +
Build duration: 37 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  ___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel