Jenkins-kde-ci: kpty master kf5-qt5 » Linux,gcc - Build # 9 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kpty%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/9/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 05 Apr 2016 06:24:08 + Build duration: 1 min 9 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 2/2 (100%)FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 434/557 (78%)CONDITIONAL 130/215 (60%) By packages autotests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 111/111 (100%)CONDITIONAL 41/72 (57%) src FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 323/446 (72%)CONDITIONAL 89/143 (62%)___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: kpty master kf5-qt5 » Linux,gcc - Build # 9 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kpty%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/9/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 05 Apr 2016 06:24:08 + Build duration: 1 min 9 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 2/2 (100%)FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 434/557 (78%)CONDITIONAL 130/215 (60%) By packages autotests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 111/111 (100%)CONDITIONAL 41/72 (57%) src FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 323/446 (72%)CONDITIONAL 89/143 (62%)___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127573: Don't crash if we have no openGL context
> On April 4, 2016, 6:26 p.m., Kai Uwe Broulik wrote: > > Should we add a property "supported" or similar so we can check whether the > > item works? > > > > I know we don't want to go down the "make tons of adjustments for 2d > > renderer"-route but so at least Plasma NM could hide the tab so it doesn't > > look as broken. > > David Edmundson wrote: > Maybe. I'm not sure. > > That current method wouldn't work, and we can't just move this call to > the constructor as there's no opengl context till the scenegraph is > initialised on the window anyway. Do-able but it gets a bit more complex. > > Other problem is that the network manager tab is lazy loaded, in order to > sometimes hide the tab, we'd have to load the contents first, which would > suck. > > Kai Uwe Broulik wrote: > > Other problem is that the network manager tab is lazy loaded > > It's not. Should be fixed though :) > > "visible: detailsTabBar.currentTab == speedTabButton" > > David Edmundson wrote: > oh right, I assumed it was because it wasn't crashing till I clicked the > tab, but I guess that's because when it's invisible it's not updating the > scenegraph. > > I've pushed for now, as this was the only crasher. > > In terms of making everything usable, this is only 1 of about 5 different > bugs, so we need to have this discussion on a more general level. is there an easy way from the API to get whether we are using OpenGL or 2D (or in future Vulkan)? - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127573/#review94246 --- On April 4, 2016, 10:06 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127573/ > --- > > (Updated April 4, 2016, 10:06 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdeclarative > > > Description > --- > > This means Plasma can be used with the QtQuick 2D renderer, albeit with > slightly missing functionality. > > > Diffs > - > > src/qmlcontrols/kquickcontrolsaddons/plotter.cpp > 233dd6b9bc0dbeddcbeb8ee02ebc500bf10282b3 > > Diff: https://git.reviewboard.kde.org/r/127573/diff/ > > > Testing > --- > > Ran plasmashell with the 2d renderer. > > > Thanks, > > David Edmundson > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127573: Don't crash if we have no openGL context
> On April 4, 2016, 4:26 p.m., Kai Uwe Broulik wrote: > > Should we add a property "supported" or similar so we can check whether the > > item works? > > > > I know we don't want to go down the "make tons of adjustments for 2d > > renderer"-route but so at least Plasma NM could hide the tab so it doesn't > > look as broken. > > David Edmundson wrote: > Maybe. I'm not sure. > > That current method wouldn't work, and we can't just move this call to > the constructor as there's no opengl context till the scenegraph is > initialised on the window anyway. Do-able but it gets a bit more complex. > > Other problem is that the network manager tab is lazy loaded, in order to > sometimes hide the tab, we'd have to load the contents first, which would > suck. > > Kai Uwe Broulik wrote: > > Other problem is that the network manager tab is lazy loaded > > It's not. Should be fixed though :) > > "visible: detailsTabBar.currentTab == speedTabButton" oh right, I assumed it was because it wasn't crashing till I clicked the tab, but I guess that's because when it's invisible it's not updating the scenegraph. I've pushed for now, as this was the only crasher. In terms of making everything usable, this is only 1 of about 5 different bugs, so we need to have this discussion on a more general level. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127573/#review94246 --- On April 4, 2016, 8:06 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127573/ > --- > > (Updated April 4, 2016, 8:06 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdeclarative > > > Description > --- > > This means Plasma can be used with the QtQuick 2D renderer, albeit with > slightly missing functionality. > > > Diffs > - > > src/qmlcontrols/kquickcontrolsaddons/plotter.cpp > 233dd6b9bc0dbeddcbeb8ee02ebc500bf10282b3 > > Diff: https://git.reviewboard.kde.org/r/127573/diff/ > > > Testing > --- > > Ran plasmashell with the 2d renderer. > > > Thanks, > > David Edmundson > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127573: Don't crash if we have no openGL context
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127573/ --- (Updated April 4, 2016, 8:06 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Changes --- Submitted with commit d50c54c8d24288924a9a366514aafb2bea3f3387 by David Edmundson to branch master. Repository: kdeclarative Description --- This means Plasma can be used with the QtQuick 2D renderer, albeit with slightly missing functionality. Diffs - src/qmlcontrols/kquickcontrolsaddons/plotter.cpp 233dd6b9bc0dbeddcbeb8ee02ebc500bf10282b3 Diff: https://git.reviewboard.kde.org/r/127573/diff/ Testing --- Ran plasmashell with the 2d renderer. Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127573: Don't crash if we have no openGL context
> On April 4, 2016, 4:26 nachm., Kai Uwe Broulik wrote: > > Should we add a property "supported" or similar so we can check whether the > > item works? > > > > I know we don't want to go down the "make tons of adjustments for 2d > > renderer"-route but so at least Plasma NM could hide the tab so it doesn't > > look as broken. > > David Edmundson wrote: > Maybe. I'm not sure. > > That current method wouldn't work, and we can't just move this call to > the constructor as there's no opengl context till the scenegraph is > initialised on the window anyway. Do-able but it gets a bit more complex. > > Other problem is that the network manager tab is lazy loaded, in order to > sometimes hide the tab, we'd have to load the contents first, which would > suck. > Other problem is that the network manager tab is lazy loaded It's not. Should be fixed though :) "visible: detailsTabBar.currentTab == speedTabButton" - Kai Uwe --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127573/#review94246 --- On April 4, 2016, 3:21 nachm., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127573/ > --- > > (Updated April 4, 2016, 3:21 nachm.) > > > Review request for KDE Frameworks. > > > Repository: kdeclarative > > > Description > --- > > This means Plasma can be used with the QtQuick 2D renderer, albeit with > slightly missing functionality. > > > Diffs > - > > src/qmlcontrols/kquickcontrolsaddons/plotter.cpp > 233dd6b9bc0dbeddcbeb8ee02ebc500bf10282b3 > > Diff: https://git.reviewboard.kde.org/r/127573/diff/ > > > Testing > --- > > Ran plasmashell with the 2d renderer. > > > Thanks, > > David Edmundson > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127560: Remove U(...) macro.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127560/
---
(Updated April 4, 2016, 10:57 a.m.)
Status
--
This change has been marked as submitted.
Review request for KDE Frameworks and John Layt.
Changes
---
Submitted with commit 3a5db6d8301dd323137fd4fa2c06332b08b833f1 by Andreas
Cord-Landwehr to branch master.
Repository: kunitconversion
Description
---
This unprefixed macro in a public header causes problem, once you are
using capital U as an object name and calling its constructor (e.g.,
when using Eigen headers where capital U is commong for matrices).
Remove macro, since it is not used in KUnitConversion.
Diffs
-
src/unit.h 9e176244165769b9e93c8ce828c6b2ac36f85a8a
Diff: https://git.reviewboard.kde.org/r/127560/diff/
Testing
---
Tested clean build of KUnitConversion, grepping for "U(" within framworks also
did not return any problem. Yet, I cannot judge if this macro is used anywhere
out of KF5.
Removing this macro also fixes my build of Kalzium, where the macro crashes
with Eigen headers.
Thanks,
Andreas Cord-Landwehr
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127514: Skip category test if no restriction is set.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127514/ --- (Updated April 4, 2016, 5:56 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Alex Richardson. Changes --- Submitted with commit ac16eeacb5a0fb8d5e1357bef3a810d5c4e22f40 by Andreas Cord-Landwehr to branch master. Repository: kcmutils Description --- Align the method's logic with the API documentation for KPluginSelector::addPlugins. The intended behavior is that if no categoryKey is set, the category key test is skipped. Diffs - src/kpluginselector.cpp a893e381d1376ccc5c8189b638609e141c198282 Diff: https://git.reviewboard.kde.org/r/127514/diff/ Testing --- Manual testing in Parley. Thanks, Andreas Cord-Landwehr ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127573: Don't crash if we have no openGL context
> On April 4, 2016, 4:26 p.m., Kai Uwe Broulik wrote: > > Should we add a property "supported" or similar so we can check whether the > > item works? > > > > I know we don't want to go down the "make tons of adjustments for 2d > > renderer"-route but so at least Plasma NM could hide the tab so it doesn't > > look as broken. Maybe. I'm not sure. That current method wouldn't work, and we can't just move this call to the constructor as there's no opengl context till the scenegraph is initialised on the window anyway. Do-able but it gets a bit more complex. Other problem is that the network manager tab is lazy loaded, in order to sometimes hide the tab, we'd have to load the contents first, which would suck. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127573/#review94246 --- On April 4, 2016, 3:21 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127573/ > --- > > (Updated April 4, 2016, 3:21 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdeclarative > > > Description > --- > > This means Plasma can be used with the QtQuick 2D renderer, albeit with > slightly missing functionality. > > > Diffs > - > > src/qmlcontrols/kquickcontrolsaddons/plotter.cpp > 233dd6b9bc0dbeddcbeb8ee02ebc500bf10282b3 > > Diff: https://git.reviewboard.kde.org/r/127573/diff/ > > > Testing > --- > > Ran plasmashell with the 2d renderer. > > > Thanks, > > David Edmundson > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127573: Don't crash if we have no openGL context
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127573/#review94246 --- Should we add a property "supported" or similar so we can check whether the item works? I know we don't want to go down the "make tons of adjustments for 2d renderer"-route but so at least Plasma NM could hide the tab so it doesn't look as broken. - Kai Uwe Broulik On April 4, 2016, 3:21 nachm., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127573/ > --- > > (Updated April 4, 2016, 3:21 nachm.) > > > Review request for KDE Frameworks. > > > Repository: kdeclarative > > > Description > --- > > This means Plasma can be used with the QtQuick 2D renderer, albeit with > slightly missing functionality. > > > Diffs > - > > src/qmlcontrols/kquickcontrolsaddons/plotter.cpp > 233dd6b9bc0dbeddcbeb8ee02ebc500bf10282b3 > > Diff: https://git.reviewboard.kde.org/r/127573/diff/ > > > Testing > --- > > Ran plasmashell with the 2d renderer. > > > Thanks, > > David Edmundson > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127573: Don't crash if we have no openGL context
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127573/#review94243 --- Ship it! Ship It! - Martin Gräßlin On April 4, 2016, 5:21 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127573/ > --- > > (Updated April 4, 2016, 5:21 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdeclarative > > > Description > --- > > This means Plasma can be used with the QtQuick 2D renderer, albeit with > slightly missing functionality. > > > Diffs > - > > src/qmlcontrols/kquickcontrolsaddons/plotter.cpp > 233dd6b9bc0dbeddcbeb8ee02ebc500bf10282b3 > > Diff: https://git.reviewboard.kde.org/r/127573/diff/ > > > Testing > --- > > Ran plasmashell with the 2d renderer. > > > Thanks, > > David Edmundson > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127572: KNewPasswordWidget: override sizeHint()
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127572/#review94244 --- Ship it! Works for me :) - Ragnar Thomsen On April 4, 2016, 3:48 p.m., Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127572/ > --- > > (Updated April 4, 2016, 3:48 p.m.) > > > Review request for KDE Frameworks, Christoph Feck, David Edmundson, and > Ragnar Thomsen. > > > Repository: kwidgetsaddons > > > Description > --- > > We have an use-case in Ark where the password widget belongs to a vertical > layout within a KCollapsibleGroupBox. > Without this patch, the strength meter bar takes room even if not visible, > resulting in a wasted empty space (see screenshots). > > > Diffs > - > > src/knewpasswordwidget.h acd14105fe9f2d3d212a9667be8b05823c2cb4a8 > src/knewpasswordwidget.cpp 72748d6b9e9fed979bd75ce856867a7bbf9e2fbd > > Diff: https://git.reviewboard.kde.org/r/127572/diff/ > > > Testing > --- > > > File Attachments > > > Before > > https://git.reviewboard.kde.org/media/uploaded/files/2016/04/04/e6462cad-f2c9-4b11-86f9-e49230072b77__knewpasswordwidget-no-hint.png > After > > https://git.reviewboard.kde.org/media/uploaded/files/2016/04/04/9d9b331a-678f-47f0-9335-87c4bfe16204__knewpasswordwidget-size-hint.png > > > Thanks, > > Elvis Angelaccio > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 7 - Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/7/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Mon, 04 Apr 2016 15:48:10 + Build duration: 8 min 10 sec CHANGE SET Revision 944c7e60dc3d2331bab1c0389cb7fa784a711985 by Marco Martin: (cache svg icons from icon theme) change: add autotests/data/icons/test-theme-two/apps/22/tst-plasma-framework-test-icon.svg change: add autotests/themetest.cpp change: edit src/plasma/private/theme_p.h change: add autotests/data/icons/test-theme-two/index.theme change: edit src/plasma/svg.cpp change: edit autotests/CMakeLists.txt change: edit src/plasma/private/theme_p.cpp change: add autotests/themetest.h JUNIT RESULTS Name: (root) Failed: 2 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-framesvgtest COBERTURA RESULTS Cobertura Coverage Report PACKAGES 5/7 (71%)FILES 54/98 (55%)CLASSES 54/98 (55%)LINE 3240/9780 (33%)CONDITIONAL 1676/2605 (64%) By packages autotests FILES 18/18 (100%)CLASSES 18/18 (100%)LINE 721/744 (97%)CONDITIONAL 475/832 (57%) src.declarativeimports.core FILES 8/18 (44%)CLASSES 8/18 (44%)LINE 457/1790 (26%)CONDITIONAL 166/232 (72%) src.plasma FILES 13/20 (65%)CLASSES 13/20 (65%)LINE 1254/3624 (35%)CONDITIONAL 700/1024 (68%) src.plasma.private FILES 13/24 (54%)CLASSES 13/24 (54%)LINE 805/1655 (49%)CONDITIONAL 333/513 (65%) src.plasma.scripting FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/181 (0%)CONDITIONAL 0/0 (100%) src.plasmaquick FILES 2/12 (17%)CLASSES 2/12 (17%)LINE 3/1673 (0%)CONDITIONAL 2/4 (50%) src.plasmaquick.private FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 (100%)___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 7 - Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/7/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Mon, 04 Apr 2016 15:48:10 + Build duration: 3 min 13 sec CHANGE SET Revision 944c7e60dc3d2331bab1c0389cb7fa784a711985 by Marco Martin: (cache svg icons from icon theme) change: edit src/plasma/private/theme_p.h change: add autotests/data/icons/test-theme-two/apps/22/tst-plasma-framework-test-icon.svg change: edit autotests/CMakeLists.txt change: add autotests/themetest.h change: edit src/plasma/private/theme_p.cpp change: add autotests/data/icons/test-theme-two/index.theme change: edit src/plasma/svg.cpp change: add autotests/themetest.cpp JUNIT RESULTS Name: (root) Failed: 2 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-framesvgtest COBERTURA RESULTS Cobertura Coverage Report PACKAGES 5/7 (71%)FILES 54/98 (55%)CLASSES 54/98 (55%)LINE 3241/9780 (33%)CONDITIONAL 1676/2605 (64%) By packages autotests FILES 18/18 (100%)CLASSES 18/18 (100%)LINE 722/744 (97%)CONDITIONAL 474/832 (57%) src.declarativeimports.core FILES 8/18 (44%)CLASSES 8/18 (44%)LINE 457/1790 (26%)CONDITIONAL 166/232 (72%) src.plasma FILES 13/20 (65%)CLASSES 13/20 (65%)LINE 1254/3624 (35%)CONDITIONAL 700/1024 (68%) src.plasma.private FILES 13/24 (54%)CLASSES 13/24 (54%)LINE 805/1655 (49%)CONDITIONAL 334/513 (65%) src.plasma.scripting FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/181 (0%)CONDITIONAL 0/0 (100%) src.plasmaquick FILES 2/12 (17%)CLASSES 2/12 (17%)LINE 3/1673 (0%)CONDITIONAL 2/4 (50%) src.plasmaquick.private FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 (100%)___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 7 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/7/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 04 Apr 2016 15:48:10 + Build duration: 3 min 55 sec CHANGE SET Revision 944c7e60dc3d2331bab1c0389cb7fa784a711985 by Marco Martin: (cache svg icons from icon theme) change: edit src/plasma/private/theme_p.cpp change: add autotests/data/icons/test-theme-two/index.theme change: add autotests/themetest.cpp change: edit autotests/CMakeLists.txt change: edit src/plasma/svg.cpp change: edit src/plasma/private/theme_p.h change: add autotests/themetest.h change: add autotests/data/icons/test-theme-two/apps/22/tst-plasma-framework-test-icon.svg JUNIT RESULTS Name: (root) Failed: 3 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-framesvgtest COBERTURA RESULTS Cobertura Coverage Report PACKAGES 5/7 (71%)FILES 55/100 (55%)CLASSES 55/100 (55%)LINE 3283/10199 (32%)CONDITIONAL 1693/2633 (64%) By packages autotests FILES 18/18 (100%)CLASSES 18/18 (100%)LINE 723/744 (97%)CONDITIONAL 475/832 (57%) src.declarativeimports.core FILES 8/18 (44%)CLASSES 8/18 (44%)LINE 457/2014 (23%)CONDITIONAL 166/232 (72%) src.plasma FILES 13/20 (65%)CLASSES 13/20 (65%)LINE 1254/3624 (35%)CONDITIONAL 700/1024 (68%) src.plasma.private FILES 14/26 (54%)CLASSES 14/26 (54%)LINE 846/1728 (49%)CONDITIONAL 350/541 (65%) src.plasma.scripting FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/181 (0%)CONDITIONAL 0/0 (100%) src.plasmaquick FILES 2/12 (17%)CLASSES 2/12 (17%)LINE 3/1795 (0%)CONDITIONAL 2/4 (50%) src.plasmaquick.private FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 (100%)___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 7 - Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/7/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 04 Apr 2016 15:48:10 + Build duration: 8 min 2 sec CHANGE SET Revision 944c7e60dc3d2331bab1c0389cb7fa784a711985 by Marco Martin: (cache svg icons from icon theme) change: add autotests/data/icons/test-theme-two/index.theme change: edit autotests/CMakeLists.txt change: add autotests/themetest.h change: add autotests/themetest.cpp change: add autotests/data/icons/test-theme-two/apps/22/tst-plasma-framework-test-icon.svg change: edit src/plasma/private/theme_p.cpp change: edit src/plasma/svg.cpp change: edit src/plasma/private/theme_p.h JUNIT RESULTS Name: (root) Failed: 3 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-framesvgtest COBERTURA RESULTS Cobertura Coverage Report PACKAGES 5/7 (71%)FILES 55/100 (55%)CLASSES 55/100 (55%)LINE 3283/10199 (32%)CONDITIONAL 1693/2633 (64%) By packages autotests FILES 18/18 (100%)CLASSES 18/18 (100%)LINE 723/744 (97%)CONDITIONAL 475/832 (57%) src.declarativeimports.core FILES 8/18 (44%)CLASSES 8/18 (44%)LINE 457/2014 (23%)CONDITIONAL 166/232 (72%) src.plasma FILES 13/20 (65%)CLASSES 13/20 (65%)LINE 1254/3624 (35%)CONDITIONAL 700/1024 (68%) src.plasma.private FILES 14/26 (54%)CLASSES 14/26 (54%)LINE 846/1728 (49%)CONDITIONAL 350/541 (65%) src.plasma.scripting FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/181 (0%)CONDITIONAL 0/0 (100%) src.plasmaquick FILES 2/12 (17%)CLASSES 2/12 (17%)LINE 3/1795 (0%)CONDITIONAL 2/4 (50%) src.plasmaquick.private FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/0 (100%)___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 127573: Don't crash if we have no openGL context
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127573/ --- Review request for KDE Frameworks. Repository: kdeclarative Description --- This means Plasma can be used with the QtQuick 2D renderer, albeit with slightly missing functionality. Diffs - src/qmlcontrols/kquickcontrolsaddons/plotter.cpp 233dd6b9bc0dbeddcbeb8ee02ebc500bf10282b3 Diff: https://git.reviewboard.kde.org/r/127573/diff/ Testing --- Ran plasmashell with the 2d renderer. Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 127536: KNewPasswordWidget: fix QPalette when the widget is disabled
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127536/ --- (Updated April 4, 2016, 2:33 p.m.) Review request for KDE Frameworks, Aleix Pol Gonzalez, Christoph Feck, and David Faure. Changes --- The bug also affects to the default QPalette of the verification line edit, when the widget is disabled before `init()` is executed. Repository: kwidgetsaddons Description --- If the widget gets disabled, the verification's QLineEdit is disabled as well, but its QPalette is wrong (see the screenshots). This patch fixes the bug by setting the Active color group for the palette. Diffs (updated) - autotests/knewpasswordwidgettest.h 3b7418700557cd3a2b3de91127f76a5bf99345d3 autotests/knewpasswordwidgettest.cpp 4507dbdc899407afb72ffa14437f050aae0b57df src/knewpasswordwidget.cpp 72748d6b9e9fed979bd75ce856867a7bbf9e2fbd Diff: https://git.reviewboard.kde.org/r/127536/diff/ Testing --- A test case is added to reproduce the bug. File Attachments Before https://git.reviewboard.kde.org/media/uploaded/files/2016/03/31/d4d0d5be-91d4-4787-adc2-032d358a3dc5__knewpasswordwidget-disabled1.png After https://git.reviewboard.kde.org/media/uploaded/files/2016/03/31/46e24106-ceb5-486f-8222-d928c8690929__knewpasswordwidget-disabled2.png Thanks, Elvis Angelaccio ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 127572: KNewPasswordWidget: override sizeHint()
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127572/ --- Review request for KDE Frameworks, Christoph Feck, David Edmundson, and Ragnar Thomsen. Repository: kwidgetsaddons Description --- We have an use-case in Ark where the password widget belongs to a vertical layout within a KCollapsibleGroupBox. Without this patch, the strength meter bar takes room even if not visible, resulting in a wasted empty space (see screenshots). Diffs - src/knewpasswordwidget.h acd14105fe9f2d3d212a9667be8b05823c2cb4a8 src/knewpasswordwidget.cpp 72748d6b9e9fed979bd75ce856867a7bbf9e2fbd Diff: https://git.reviewboard.kde.org/r/127572/diff/ Testing --- File Attachments Before https://git.reviewboard.kde.org/media/uploaded/files/2016/04/04/e6462cad-f2c9-4b11-86f9-e49230072b77__knewpasswordwidget-no-hint.png After https://git.reviewboard.kde.org/media/uploaded/files/2016/04/04/9d9b331a-678f-47f0-9335-87c4bfe16204__knewpasswordwidget-size-hint.png Thanks, Elvis Angelaccio ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: kauth testing?
Martin Graesslin wrote: > did it build the mac or the fake backend? On OS X, the Mac backend, and the polkit-qt-1 backend on Linux. I'm not 100% sure of the exact error on OS X because the notification popups don't work properly (they just show the title/caption). That's another point; I don't know if those notifications are posted by KAuth or by smb4k. Smb4k looks very much like a work in progress, so I'm inclined to put the blame there rather than with either KAuth or KNotifications but I'm not familiar enough with those frameworks to be affirmative about that. >> Is there a simple test app I could download and use to test this? > > Doesn't look like it, At least I didn't find any in the src repository. That was my impression too. Then how about a "real-life" application that's known to work and not too tightly coupled to Plasma nor too demanding to build in terms of dependencies? A propos that: does the KAuth mechanism actually work in the kwallet kcm provided by kwalletmanager, under a Plasma5 session? I still only see a call to KCModule::authAction() but cannot find a corresponding call to setAuthAction(), nor any use of "org.kde.kcontrol.kcmkwallet5.save" (defined in the kwallet.action file that's registered via kauth_install_actions). Cheers, René ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: networkmanager-qt master kf5-qt5 » Linux,gcc - Build # 7 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/networkmanager-qt%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/7/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 04 Apr 2016 07:45:24 + Build duration: 25 min CHANGE SET Revision 4eac629258721a10ce17928964f956c725370ec6 by jgrulich: (Fix build: build tun setting test only when NM 1.1.92 and higher is) change: edit autotests/settings/CMakeLists.txt JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 24 test(s), Skipped: 0 test(s), Total: 24 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 6/6 (100%)FILES 158/287 (55%)CLASSES 158/287 (55%)LINE 5578/10325 (54%)CONDITIONAL 1683/2805 (60%) By packages autotests FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 220/220 (100%)CONDITIONAL 130/260 (50%) autotests.settings FILES 42/42 (100%)CLASSES 42/42 (100%)LINE 1134/1142 (99%)CONDITIONAL 312/552 (57%) src FILES 25/91 (27%)CLASSES 25/91 (27%)LINE 838/3196 (26%)CONDITIONAL 367/588 (62%) src.dbus FILES 14/66 (21%)CLASSES 14/66 (21%)LINE 159/744 (21%)CONDITIONAL 4/8 (50%) src.fakenetwork FILES 6/8 (75%)CLASSES 6/8 (75%)LINE 490/712 (69%)CONDITIONAL 45/72 (63%) src.settings FILES 65/74 (88%)CLASSES 65/74 (88%)LINE 2737/4311 (63%)CONDITIONAL 825/1325 (62%)___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: networkmanager-qt master kf5-qt5 » Linux,gcc - Build # 7 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/networkmanager-qt%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/7/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 04 Apr 2016 07:45:24 + Build duration: 25 min CHANGE SET Revision 4eac629258721a10ce17928964f956c725370ec6 by jgrulich: (Fix build: build tun setting test only when NM 1.1.92 and higher is) change: edit autotests/settings/CMakeLists.txt JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 24 test(s), Skipped: 0 test(s), Total: 24 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 6/6 (100%)FILES 158/287 (55%)CLASSES 158/287 (55%)LINE 5578/10325 (54%)CONDITIONAL 1683/2805 (60%) By packages autotests FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 220/220 (100%)CONDITIONAL 130/260 (50%) autotests.settings FILES 42/42 (100%)CLASSES 42/42 (100%)LINE 1134/1142 (99%)CONDITIONAL 312/552 (57%) src FILES 25/91 (27%)CLASSES 25/91 (27%)LINE 838/3196 (26%)CONDITIONAL 367/588 (62%) src.dbus FILES 14/66 (21%)CLASSES 14/66 (21%)LINE 159/744 (21%)CONDITIONAL 4/8 (50%) src.fakenetwork FILES 6/8 (75%)CLASSES 6/8 (75%)LINE 490/712 (69%)CONDITIONAL 45/72 (63%) src.settings FILES 65/74 (88%)CLASSES 65/74 (88%)LINE 2737/4311 (63%)CONDITIONAL 825/1325 (62%)___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: MimeType issues on CI
On Mon, Apr 4, 2016 at 3:45 AM, Scarlett Clark wrote: > Right. For whatever reason several builds worked before it went boom... > reverted that commit. > Scarlett Hi, Based on my examination of the changes which were finally settled on, this should work properly now following a rebuild of all the things which provide mimetype information. Cheers, Ben > > On Sun, Apr 3, 2016 at 8:40 AM, David Faure wrote: >> >> On Sunday 03 April 2016 08:30:45 Scarlett Clark wrote: >> > I just committed some fixes, things should be working, I hope. >> >> Seems worse: >> >> 15:37:30 Traceback (most recent call last): >> 15:37:30 File "/home/jenkins/scripts/tools/perform-build.py", line 88, >> in >> 15:37:30 if not manager.install_build(): >> 15:37:30 File "/home/jenkins/scripts/tools/kdecilib.py", line 883, in >> install_build >> 15:37:30 command.append( mimeDirectory ) >> 15:37:30 AttributeError: 'str' object has no attribute 'append' >> >> >> https://build.kde.org/job/kcoreaddons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/5/console >> >> -- >> David Faure, fa...@kde.org, http://www.davidfaure.fr >> Working on KDE Frameworks 5 >> > > > ___ > Kde-frameworks-devel mailing list > Kde-frameworks-devel@kde.org > https://mail.kde.org/mailman/listinfo/kde-frameworks-devel > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: MimeType issues on CI (Was: Re: Delaying KF 5.21)
On Mon, Apr 4, 2016 at 12:16 AM, Daniel Vrátil wrote: > On Sunday, April 3, 2016 12:58:24 PM CEST David Faure wrote: >> On Sunday 03 April 2016 12:43:27 Daniel Vrátil wrote: >> > Turns out when you include /usr/share in XDG_DATA_DIRS, all mime types >> > that >> > might have been provided by other dependencies in >> > /srv/jenkins/.../foo/inst/ usr/share/mime are ignored, possibly due to >> > update-mime-database not being ran for those directories. >> >> I'm not sure I fully understand this sentence. Do you mean the value of >> XDG_DATA_DIRS at update-mime-database time or during the running of unit >> tests? > > XDG_DATA_DIRS value when running the unit tests. > >> update-mime-database works on one specific install dir and creates files >> there. The value of XDG_DATA_DIRS during the run of update-mime-database >> shouldn't matter. >> >> If the stuff /srv/jenkins/.../foo/inst/usr/share/mime is ignored, it can be >> either > >> 1) because update-mime-database wasn't run on that dir >>(which is my current hypothesis for the KIO kfileitemtest failure which >> needs a mimetype from kcoreaddons) > > The thing is that the content of /srv/jenkins/.../foo/inst/usr/share/mime is > NOT ignored, when /usr/share is NOT in XDG_DATA_DIRS. > > Once you include /usr/share in XDG_DATA_DIRS, the content of the /srv/.../mime > folders IS ignored. > > Akonadi installs a mime file to share/mime/packages/akonadi-mime.xml which > introduces some new mimetypes and are used to find the right serialize plugins > for those types. With /usr/share in XDG_DATA_DIRS Akonadi is not able to find > serializer plugins for application/x-vnd.akonadi.calendar.todo for instance, > because it (using QMimeDatabase) does not know about this mime type. Removing > /usr/share from XDG_DATA_DIRS makes Akonadi (QMimeDatabase) find application/ > x-vnd.akonadi.calendar.todo just find and thus find a respective serializer > plugin for the type. > > >> 2) because that dir isn't in >> XDG_DATA_DIRS (this is not the problem) later on. > > I verified that it is there. > >> 3) because >> update-mime-database ran but didn't create the stuff it's supposed to >> create -- I understand your email as saying this might be the problem, but >> I can't confirm it: > > If I compare output of "make install" from CI and running it locally, it > indeed appears that update-mime-database is not run on the CI at all: > > CI: > 16:22:17 Install the project... > 16:22:17 -- Install configuration: "Debug" > 16:22:17 -- Installing: /home/jenkins/sources/akonadi/kf5-qt5/local-inst/srv/ > jenkins/install/ubuntu/x86_64/g++/kf5-qt5/kde/pim/akonadi/inst/usr/share/mime/ > packages/akonadi-mime.xml > 16:22:17 -- Installing: /home/jenkins/sources/akonadi/kf5-qt5/local-inst/srv/ > jenkins/install/ubuntu/x86_64/g++/kf5-qt5/kde/pim/akonadi/inst/usr/lib/x86_64- > linux-gnu/cmake/KF5Akonadi/KF5AkonadiConfig.cmake > > > Locally: > -- Install configuration: "Debug" > -- Up-to-date: /opt/kde-devel/share/mime/packages/akonadi-mime.xml > -- Updating MIME database at /opt/kde-devel/share/mime > -- Up-to-date: /opt/kde-devel/lib64/cmake/KF5Akonadi/KF5AkonadiConfig.cmake > >> >> on my own system, I have /usr/share/mime/packages/kde.xml defining >> application/x-smb-workgroup and /usr/share in XDG_DATA_DIRS, and yet >> running update-mime-database on /d/kde/inst/kde_frameworks/share/mime >> creates >> /d/kde/inst/kde_frameworks/share/mime/application/x-smb-workgroup.xml as >> expected. >> > I manually ran update-mime-database on the akonadi and kdepim-runtime >> > install dirs on Jenkins and the Zanshin tests magically started passing >> > again. >> Yes, which only proves that the problem was that it didn't run, not that the >> value of XDG_DATA_DIRS is the problem. >> >> > Our idea for a quick dirty fix was to simply run update-mime-database once >> > CI sets up the environment variables but before the test is executed. >> > >> > David, do you have any better suggestions? >> >> Yes, I'd like to know why "make install" in e.g. kcoreaddons doesn't seem to >> run update-mime-database on CI while it does here (and given that >> update-mime-database *is* found in the CI). >> With the new CI I'm having trouble debugging this, there are no sources and >> build dirs from previous runs anymore :-) > > update-mime-database seems to be run by ECM, the documentation says > > # The follow macro is available:: > # > # update_xdg_mimetypes() > # > # Updates the XDG mime database at install time (unless the > ``$DESTDIR`` > # environment variable is set, in which case it is up to package > managers > to > # perform this task). > > I suspect that CI uses "make DESTDIR=/srv/jenkins/./foo/inst install" to > install stuff, thus not triggering the update, as documented and it's up to > the CI script to run it manually We use DESTDIR, yes. I believe Scarlett's fix should correct this, although a full rebuild of all Frameworks and dependencies of
Re: Encoding Issues?
Hi, > On Mon, Apr 4, 2016 at 6:45 AM, Christoph Cullmann > wrote: >> Hi, >> >>> This is likely something I can fix, but I am heading off to my grandsons >>> first birthday, will have to be later. >>> Thanks for understanding. >>> Scarlett >> no problem at all. >> >> I fixed the tests to work again, its not the CI's fault that they were not >> tolerant enough. >> Therefore: no need to hurry at all! >> >> Enjoy a nice birthday party! >> >> And: THANKS for your work on the CI! >> >> Greetings >> Christoph >> >>> >>> On Sun, Apr 3, 2016 at 9:58 AM, Christoph Cullmann >>> wrote: >>> Hi, the two failed ktexteditor tests seems to be encoding issues. KTextEditor lib no longer is able to detect UTF-8 for some files. Did the locale change to something non-UTF-8 on the CI? > > They were POSIX. > I've now changed the default, and ensured a wider range of en.* > locales are available at least. Thanks ;=) In any case, I hope the KTextEditor tests are now more "robust" against such things which is a good thing anyways. Greetings Christoph -- - Dr.-Ing. Christoph Cullmann - AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com Science Park 1 Tel: +49-681-38360-22 66123 Saarbrücken Fax: +49-681-38360-20 GERMANYWWW: http://www.AbsInt.com Geschäftsführung: Dr.-Ing. Christian Ferdinand Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: networkmanager-qt master stable-kf5-qt5 » Linux,gcc - Build # 7 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/networkmanager-qt%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/7/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 04 Apr 2016 07:45:24 + Build duration: 7 min 39 sec CHANGE SET Revision 4eac629258721a10ce17928964f956c725370ec6 by jgrulich: (Fix build: build tun setting test only when NM 1.1.92 and higher is) change: edit autotests/settings/CMakeLists.txt JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 24 test(s), Skipped: 0 test(s), Total: 24 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 6/6 (100%)FILES 158/287 (55%)CLASSES 158/287 (55%)LINE 5578/10325 (54%)CONDITIONAL 1683/2805 (60%) By packages autotests FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 220/220 (100%)CONDITIONAL 130/260 (50%) autotests.settings FILES 42/42 (100%)CLASSES 42/42 (100%)LINE 1134/1142 (99%)CONDITIONAL 312/552 (57%) src FILES 25/91 (27%)CLASSES 25/91 (27%)LINE 838/3196 (26%)CONDITIONAL 367/588 (62%) src.dbus FILES 14/66 (21%)CLASSES 14/66 (21%)LINE 159/744 (21%)CONDITIONAL 4/8 (50%) src.fakenetwork FILES 6/8 (75%)CLASSES 6/8 (75%)LINE 490/712 (69%)CONDITIONAL 45/72 (63%) src.settings FILES 65/74 (88%)CLASSES 65/74 (88%)LINE 2737/4311 (63%)CONDITIONAL 825/1325 (62%)___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: networkmanager-qt master stable-kf5-qt5 » Linux,gcc - Build # 7 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/networkmanager-qt%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/7/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 04 Apr 2016 07:45:24 + Build duration: 7 min 39 sec CHANGE SET Revision 4eac629258721a10ce17928964f956c725370ec6 by jgrulich: (Fix build: build tun setting test only when NM 1.1.92 and higher is) change: edit autotests/settings/CMakeLists.txt JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 24 test(s), Skipped: 0 test(s), Total: 24 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 6/6 (100%)FILES 158/287 (55%)CLASSES 158/287 (55%)LINE 5578/10325 (54%)CONDITIONAL 1683/2805 (60%) By packages autotests FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 220/220 (100%)CONDITIONAL 130/260 (50%) autotests.settings FILES 42/42 (100%)CLASSES 42/42 (100%)LINE 1134/1142 (99%)CONDITIONAL 312/552 (57%) src FILES 25/91 (27%)CLASSES 25/91 (27%)LINE 838/3196 (26%)CONDITIONAL 367/588 (62%) src.dbus FILES 14/66 (21%)CLASSES 14/66 (21%)LINE 159/744 (21%)CONDITIONAL 4/8 (50%) src.fakenetwork FILES 6/8 (75%)CLASSES 6/8 (75%)LINE 490/712 (69%)CONDITIONAL 45/72 (63%) src.settings FILES 65/74 (88%)CLASSES 65/74 (88%)LINE 2737/4311 (63%)CONDITIONAL 825/1325 (62%)___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Encoding Issues?
On Mon, Apr 4, 2016 at 6:45 AM, Christoph Cullmann wrote: > Hi, > >> This is likely something I can fix, but I am heading off to my grandsons >> first birthday, will have to be later. >> Thanks for understanding. >> Scarlett > no problem at all. > > I fixed the tests to work again, its not the CI's fault that they were not > tolerant enough. > Therefore: no need to hurry at all! > > Enjoy a nice birthday party! > > And: THANKS for your work on the CI! > > Greetings > Christoph > >> >> On Sun, Apr 3, 2016 at 9:58 AM, Christoph Cullmann >> wrote: >> >>> Hi, >>> >>> the two failed ktexteditor tests seems to be encoding issues. >>> >>> KTextEditor lib no longer is able to detect UTF-8 for some files. >>> >>> Did the locale change to something non-UTF-8 on the CI? They were POSIX. I've now changed the default, and ensured a wider range of en.* locales are available at least. Cheers, Ben >>> >>> Greetings >>> Christoph >>> >>> -- >>> - Dr.-Ing. Christoph Cullmann - >>> AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com >>> Science Park 1 Tel: +49-681-38360-22 >>> 66123 Saarbrücken Fax: +49-681-38360-20 >>> GERMANYWWW: http://www.AbsInt.com >>> >>> Geschäftsführung: Dr.-Ing. Christian Ferdinand >>> Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234 > > -- > - Dr.-Ing. Christoph Cullmann - > AbsInt Angewandte Informatik GmbH Email: cullm...@absint.com > Science Park 1 Tel: +49-681-38360-22 > 66123 Saarbrücken Fax: +49-681-38360-20 > GERMANYWWW: http://www.AbsInt.com > > Geschäftsführung: Dr.-Ing. Christian Ferdinand > Eingetragen im Handelsregister des Amtsgerichts Saarbrücken, HRB 11234 > ___ > Kde-frameworks-devel mailing list > Kde-frameworks-devel@kde.org > https://mail.kde.org/mailman/listinfo/kde-frameworks-devel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: networkmanager-qt master kf5-qt5 » Linux,gcc - Build # 6 - Failure!
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/networkmanager-qt%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/6/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 04 Apr 2016 06:55:53 + Build duration: 17 min CHANGE SET Revision 76e61e67e0c335a8459b2965c6a430a9580bbe5a by jgrulich: (Introduce TunSetting and Tun connection type from NetworkManager 1.2.0) change: edit TODO change: add src/settings/tunsetting.h change: edit src/settings/connectionsettings.cpp change: add autotests/settings/tunsettingtest.h change: add src/settings/tunsetting.cpp change: edit src/settings/connectionsettings.h change: add src/settings/tunsetting_p.h change: add autotests/settings/tunsettingtest.cpp change: edit autotests/settings/CMakeLists.txt change: edit src/CMakeLists.txt change: edit src/settings/setting.h ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[sysadmin/ci-master-config] docker/ubuntu-wily-slave: Setup environment for UTF-8 builds.
Git commit e11db4488e22e3338ab7ad48682020829823c065 by Ben Cooksley. Committed on 04/04/2016 at 07:11. Pushed by bcooksley into branch 'master'. Setup environment for UTF-8 builds. CCMAIL: cullm...@absint.com CCMAIL: kde-frameworks-devel@kde.org CCMAIL: sgcl...@kde.org M +2-0docker/ubuntu-wily-slave/Dockerfile http://commits.kde.org/sysadmin/ci-master-config/e11db4488e22e3338ab7ad48682020829823c065 diff --git a/docker/ubuntu-wily-slave/Dockerfile b/docker/ubuntu-wily-slave/Dockerfile index 530d8ff..52fff7f 100644 --- a/docker/ubuntu-wily-slave/Dockerfile +++ b/docker/ubuntu-wily-slave/Dockerfile @@ -21,6 +21,7 @@ RUN DEBIAN_FRONTEND=noninteractive apt-get -y --force-yes install \ wget \ openjdk-8-jdk \ git \ +language-pack-en \ openbox \ dbus-x11 \ gnupg2 \ @@ -245,6 +246,7 @@ RUN mkdir -p /var/run/sshd RUN groupadd -g 1000 jenkins RUN useradd -m -u 1000 -g 1000 -d /home/jenkins jenkins RUN echo 'jenkins:1234' | chpasswd #changeme +RUN echo 'export LANG="en_US.UTF-8"' >> /etc/profile USER jenkins RUN echo "eval \`dbus-launch --auto-syntax 2>&1\`" > ~/.bashrc ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Jenkins-kde-ci: networkmanager-qt master stable-kf5-qt5 » Linux,gcc - Build # 6 - Failure!
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/networkmanager-qt%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/6/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 04 Apr 2016 06:55:53 + Build duration: 4 min 7 sec CHANGE SET Revision 76e61e67e0c335a8459b2965c6a430a9580bbe5a by jgrulich: (Introduce TunSetting and Tun connection type from NetworkManager 1.2.0) change: add src/settings/tunsetting.cpp change: edit src/CMakeLists.txt change: add src/settings/tunsetting_p.h change: add autotests/settings/tunsettingtest.h change: edit autotests/settings/CMakeLists.txt change: edit src/settings/connectionsettings.cpp change: add src/settings/tunsetting.h change: edit src/settings/setting.h change: edit src/settings/connectionsettings.h change: edit TODO change: add autotests/settings/tunsettingtest.cpp ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
