date:20160410

Re: Review Request 127633: [kpeople] Add a check for PersonData being valid

2016-04-10 Thread Martin Klapetek


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127633/
---

(Updated April 11, 2016, 3:36 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and KDEPIM.


Changes
---

Submitted with commit 9467e77120f1e247933f2c60f91eba40df3eabdf by Martin 
Klapetek to branch master.


Repository: kpeople


Description
---

If there is a PersonData that does not have an id,
it's not a valid person representation.


Diffs
-

  autotests/persondatatests.cpp 677ee1b 
  src/persondata.h c3f99a9 
  src/persondata.cpp e4a0c54 

Diff: https://git.reviewboard.kde.org/r/127633/diff/


Testing
---

Tests pass.


Thanks,

Martin Klapetek

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127633: [kpeople] Add a check for PersonData being valid

2016-04-10 Thread Aleix Pol Gonzalez


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127633/#review94512
---


Ship it!




Ship It!

- Aleix Pol Gonzalez


On April 11, 2016, 4:13 a.m., Martin Klapetek wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127633/
> ---
> 
> (Updated April 11, 2016, 4:13 a.m.)
> 
> 
> Review request for KDE Frameworks and KDEPIM.
> 
> 
> Repository: kpeople
> 
> 
> Description
> ---
> 
> If there is a PersonData that does not have an id,
> it's not a valid person representation.
> 
> 
> Diffs
> -
> 
>   autotests/persondatatests.cpp 677ee1b 
>   src/persondata.h c3f99a9 
>   src/persondata.cpp e4a0c54 
> 
> Diff: https://git.reviewboard.kde.org/r/127633/diff/
> 
> 
> Testing
> ---
> 
> Tests pass.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127633: [kpeople] Add a check for PersonData being valid

2016-04-10 Thread Martin Klapetek


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127633/
---

Review request for KDE Frameworks and KDEPIM.


Repository: kpeople


Description
---

If there is a PersonData that does not have an id,
it's not a valid person representation.


Diffs
-

  autotests/persondatatests.cpp 677ee1b 
  src/persondata.h c3f99a9 
  src/persondata.cpp e4a0c54 

Diff: https://git.reviewboard.kde.org/r/127633/diff/


Testing
---

Tests pass.


Thanks,

Martin Klapetek

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127632: Prioritize correct extension per theme

2016-04-10 Thread Aleix Pol Gonzalez


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127632/
---

(Updated April 11, 2016, 1:05 a.m.)


Review request for KDE Frameworks and Christoph Feck.


Changes
---

Don't change the extensions vector if it was already in place.


Repository: kiconthemes


Description
---

Usually themes will have 1 kind of extension (2 tops) it doesn't make sense to 
bindly use an extensions vector that is statically defined.

Prioritizes the extensions that work, so it will find the icons sooner.


Diffs (updated)
-

  src/kiconloader.cpp 37528ad 
  src/kicontheme.h 3190665 
  src/kicontheme.cpp e7e003b 

Diff: https://git.reviewboard.kde.org/r/127632/diff/


Testing
---

Builds and tests still pass.
Also reducess faulty disk accesses to its 45%. Note that by this metric, it's 
almost as good as the RR #127236, but with a much smaller memory impact, since 
we're not caching all the icon names (which was specially bad as it was 
per-process).
```
$ strace kwrite |& grep ENOENT | wc -l
4699
$ strace kwrite |& grep ENOENT | wc -l
2119
```


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127632: Prioritize correct extension per theme

2016-04-10 Thread Aleix Pol Gonzalez


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127632/
---

Review request for KDE Frameworks and Christoph Feck.


Repository: kiconthemes


Description
---

Usually themes will have 1 kind of extension (2 tops) it doesn't make sense to 
bindly use an extensions vector that is statically defined.

Prioritizes the extensions that work, so it will find the icons sooner.


Diffs
-

  src/kiconloader.cpp 37528ad 
  src/kicontheme.h 3190665 
  src/kicontheme.cpp e7e003b 

Diff: https://git.reviewboard.kde.org/r/127632/diff/


Testing
---

Builds and tests still pass.
Also reducess faulty disk accesses to its 45%. Note that by this metric, it's 
almost as good as the RR #127236, but with a much smaller memory impact, since 
we're not caching all the icon names (which was specially bad as it was 
per-process).
```
$ strace kwrite |& grep ENOENT | wc -l
4699
$ strace kwrite |& grep ENOENT | wc -l
2119
```


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kiconthemes master stable-kf5-qt5 » Linux,gcc - Build # 9 - Fixed!

2016-04-10 Thread no-reply


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kiconthemes%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/9/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 10 Apr 2016 22:15:49 +
Build duration: 1 min 5 sec

CHANGE SET
Revision 43b8ab28903d8a4a96184e10a4efda868f06b96e by aleixpol: (Dont mark 
test as failed if an icon wasnt found)
  change: edit autotests/kiconloader_benchmark.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 9/12 (75%)CLASSES 9/12 (75%)LINE 1034/2323 
(45%)CONDITIONAL 654/1005 (65%)

By packages
  
autotests
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 349/351 (99%)CONDITIONAL 
204/394 (52%)
src
FILES 6/9 (67%)CLASSES 6/9 (67%)LINE 685/1972 (35%)CONDITIONAL 
450/611 (74%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kiconthemes master stable-kf5-qt5 » Linux,gcc - Build # 9 - Fixed!

2016-04-10 Thread no-reply


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kiconthemes%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/9/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 10 Apr 2016 22:15:49 +
Build duration: 1 min 5 sec

CHANGE SET
Revision 43b8ab28903d8a4a96184e10a4efda868f06b96e by aleixpol: (Dont mark 
test as failed if an icon wasnt found)
  change: edit autotests/kiconloader_benchmark.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 9/12 (75%)CLASSES 9/12 (75%)LINE 1034/2323 
(45%)CONDITIONAL 654/1005 (65%)

By packages
  
autotests
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 349/351 (99%)CONDITIONAL 
204/394 (52%)
src
FILES 6/9 (67%)CLASSES 6/9 (67%)LINE 685/1972 (35%)CONDITIONAL 
450/611 (74%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kiconthemes master kf5-qt5 » Linux,gcc - Build # 11 - Fixed!

2016-04-10 Thread no-reply


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kiconthemes%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/11/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 10 Apr 2016 22:15:49 +
Build duration: 1 min 6 sec

CHANGE SET
Revision 43b8ab28903d8a4a96184e10a4efda868f06b96e by aleixpol: (Dont mark 
test as failed if an icon wasnt found)
  change: edit autotests/kiconloader_benchmark.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 9/12 (75%)CLASSES 9/12 (75%)LINE 1034/2323 
(45%)CONDITIONAL 654/1005 (65%)

By packages
  
autotests
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 349/351 (99%)CONDITIONAL 
204/394 (52%)
src
FILES 6/9 (67%)CLASSES 6/9 (67%)LINE 685/1972 (35%)CONDITIONAL 
450/611 (74%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kiconthemes master kf5-qt5 » Linux,gcc - Build # 11 - Fixed!

2016-04-10 Thread no-reply


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kiconthemes%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/11/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 10 Apr 2016 22:15:49 +
Build duration: 1 min 6 sec

CHANGE SET
Revision 43b8ab28903d8a4a96184e10a4efda868f06b96e by aleixpol: (Dont mark 
test as failed if an icon wasnt found)
  change: edit autotests/kiconloader_benchmark.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 9/12 (75%)CLASSES 9/12 (75%)LINE 1034/2323 
(45%)CONDITIONAL 654/1005 (65%)

By packages
  
autotests
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 349/351 (99%)CONDITIONAL 
204/394 (52%)
src
FILES 6/9 (67%)CLASSES 6/9 (67%)LINE 685/1972 (35%)CONDITIONAL 
450/611 (74%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kiconthemes master stable-kf5-qt5 » Linux,gcc - Build # 8 - Still Unstable!

2016-04-10 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kiconthemes%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/8/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 10 Apr 2016 22:05:19 +
Build duration: 3 min 55 sec

CHANGE SET
Revision b84858ce6a25ced9228cde9db836fca9f36e9f5a by aleixpol: (Cleanup)
  change: edit src/kiconloader.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 
test(s)Failed: TestSuite.kiconthemes-kiconloader_benchmark

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 9/12 (75%)CLASSES 9/12 (75%)LINE 1033/2322 
(44%)CONDITIONAL 654/1005 (65%)

By packages
  
autotests
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 348/350 (99%)CONDITIONAL 
204/394 (52%)
src
FILES 6/9 (67%)CLASSES 6/9 (67%)LINE 685/1972 (35%)CONDITIONAL 
450/611 (74%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kiconthemes master kf5-qt5 » Linux,gcc - Build # 10 - Still Unstable!

2016-04-10 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kiconthemes%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/10/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 10 Apr 2016 22:05:19 +
Build duration: 2 min 44 sec

CHANGE SET
Revision b84858ce6a25ced9228cde9db836fca9f36e9f5a by aleixpol: (Cleanup)
  change: edit src/kiconloader.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 
test(s)Failed: TestSuite.kiconthemes-kiconloader_benchmark

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 9/12 (75%)CLASSES 9/12 (75%)LINE 1033/2322 
(44%)CONDITIONAL 654/1005 (65%)

By packages
  
autotests
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 348/350 (99%)CONDITIONAL 
204/394 (52%)
src
FILES 6/9 (67%)CLASSES 6/9 (67%)LINE 685/1972 (35%)CONDITIONAL 
450/611 (74%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Jenkins-kde-ci: kiconthemes master kf5-qt5 » Linux, gcc - Build # 9 - Unstable!

2016-04-10 Thread David Faure

* Start testing of KIconLoader_Benchmark *
Config: Using QtTest library 5.5.1, Qt 5.5.1 (x86_64-little_endian-lp64 shared 
(dynamic) debug build; by GCC 5.2.1 20151010)
PASS   : KIconLoader_Benchmark::initTestCase()
FAIL!  : KIconLoader_Benchmark::benchmark() '!icon.isNull()' returned FALSE. ()
   Loc: 
[/home/jenkins/sources/kiconthemes/kf5-qt5/autotests/kiconloader_benchmark.cpp(81)]
PASS   : KIconLoader_Benchmark::cleanupTestCase()
Totals: 2 passed, 1 failed, 0 skipped, 0 blacklisted
* Finished testing of KIconLoader_Benchmark *

I guess the dependency on an actual icon theme (breeze or oxygen) is missing in 
the CI.

The other unittest creates its own small fake theme so that it's standalone.
But this one would need a lot of icons in the fake theme :-)

Maybe it's enough to make it exit early if the first icon can't be loaded,
a benchmark is only useful when a human is looking at it anyway.

On Sunday 10 April 2016 22:00:05 no-re...@kde.org wrote:
> 
> GENERAL INFO
> 
> BUILD UNSTABLE
> Build URL: 
> https://build.kde.org/job/kiconthemes%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/9/
> Project: PLATFORM=Linux,compiler=gcc
> Date of build: Sun, 10 Apr 2016 21:57:59 +
> Build duration: 1 min 5 sec
> 
> CHANGE SET
> Revision da3afe6840bf4974bd8d022b86fb9778f2af8688 by aleixpol: (Save some 
> disk accesses)
>   change: edit autotests/kiconloader_unittest.cpp
>   change: add autotests/kiconloader_benchmark.cpp
>   change: edit autotests/CMakeLists.txt
>   change: edit src/kiconloader.cpp
> Revision 5c1d737796e8a1cebcba671217ad519971e0894b by aleixpol: (Properly call 
> QDir::entryList)
>   change: edit src/kicontheme.cpp
> 
> 
> JUNIT RESULTS
>   
> Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 
> 3 test(s)Failed: TestSuite.kiconthemes-kiconloader_benchmark
> 
> COBERTURA RESULTS
> 
> Cobertura Coverage Report
>   PACKAGES 2/2 (100%)FILES 9/12 (75%)CLASSES 9/12 (75%)LINE 1034/2324 
> (44%)CONDITIONAL 656/1011 (65%)
> 
> By packages
>   
>   autotests
>   FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 348/350 (99%)CONDITIONAL 
> 204/394 (52%)
>   src
>   FILES 6/9 (67%)CLASSES 6/9 (67%)LINE 686/1974 (35%)CONDITIONAL 
> 452/617 (73%)

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kiconthemes master stable-kf5-qt5 » Linux,gcc - Build # 7 - Unstable!

2016-04-10 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kiconthemes%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/7/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 10 Apr 2016 21:57:59 +
Build duration: 1 min 50 sec

CHANGE SET
Revision da3afe6840bf4974bd8d022b86fb9778f2af8688 by aleixpol: (Save some disk 
accesses)
  change: add autotests/kiconloader_benchmark.cpp
  change: edit src/kiconloader.cpp
  change: edit autotests/kiconloader_unittest.cpp
  change: edit autotests/CMakeLists.txt
Revision 5c1d737796e8a1cebcba671217ad519971e0894b by aleixpol: (Properly call 
QDir::entryList)
  change: edit src/kicontheme.cpp


JUNIT RESULTS

Name: (root) Failed: 3 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 3 
test(s)Failed: TestSuite.kiconthemes-kiconloader_benchmarkFailed: 
TestSuite.kiconthemes-kiconloader_resourcethemetestFailed: 
TestSuite.kiconthemes-kiconloader_unittest

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  ___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kiconthemes master kf5-qt5 » Linux,gcc - Build # 9 - Unstable!

2016-04-10 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kiconthemes%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/9/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 10 Apr 2016 21:57:59 +
Build duration: 1 min 5 sec

CHANGE SET
Revision da3afe6840bf4974bd8d022b86fb9778f2af8688 by aleixpol: (Save some disk 
accesses)
  change: edit autotests/kiconloader_unittest.cpp
  change: add autotests/kiconloader_benchmark.cpp
  change: edit autotests/CMakeLists.txt
  change: edit src/kiconloader.cpp
Revision 5c1d737796e8a1cebcba671217ad519971e0894b by aleixpol: (Properly call 
QDir::entryList)
  change: edit src/kicontheme.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 
test(s)Failed: TestSuite.kiconthemes-kiconloader_benchmark

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 9/12 (75%)CLASSES 9/12 (75%)LINE 1034/2324 
(44%)CONDITIONAL 656/1011 (65%)

By packages
  
autotests
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 348/350 (99%)CONDITIONAL 
204/394 (52%)
src
FILES 6/9 (67%)CLASSES 6/9 (67%)LINE 686/1974 (35%)CONDITIONAL 
452/617 (73%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127380: More conservative approach to saving some disk accesses

2016-04-10 Thread Aleix Pol Gonzalez


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127380/
---

(Updated April 10, 2016, 9:57 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Antonio Larrosa Jimenez and Christoph Feck.


Changes
---

Submitted with commit da3afe6840bf4974bd8d022b86fb9778f2af8688 by Aleix Pol to 
branch master.


Repository: kiconthemes


Description
---

My previous approach to KIconThemes felt like a dead end, I decided I'll take a 
more conservative approach. Here's a first step.


Diffs
-

  autotests/CMakeLists.txt 61e81f6 
  autotests/kiconloader_benchmark.cpp PRE-CREATION 
  autotests/kiconloader_unittest.cpp 0e47cc8 
  src/kiconloader.cpp 75ab482 
  src/kicontheme.cpp 0996054 

Diff: https://git.reviewboard.kde.org/r/127380/diff/


Testing
---

Attempts to call `KIconThemeDir::iconPath` on the benchmark: 4318 after/5040 
before= 17% less QFile::exists


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127380: More conservative approach to saving some disk accesses

2016-04-10 Thread Aleix Pol Gonzalez


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127380/
---

(Updated April 10, 2016, 9:57 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Antonio Larrosa Jimenez and Christoph Feck.


Changes
---

Submitted with commit da3afe6840bf4974bd8d022b86fb9778f2af8688 by Aleix Pol to 
branch master.


Repository: kiconthemes


Description
---

My previous approach to KIconThemes felt like a dead end, I decided I'll take a 
more conservative approach. Here's a first step.


Diffs
-

  autotests/CMakeLists.txt 61e81f6 
  autotests/kiconloader_benchmark.cpp PRE-CREATION 
  autotests/kiconloader_unittest.cpp 0e47cc8 
  src/kiconloader.cpp 75ab482 
  src/kicontheme.cpp 0996054 

Diff: https://git.reviewboard.kde.org/r/127380/diff/


Testing
---

Attempts to call `KIconThemeDir::iconPath` on the benchmark: 4318 after/5040 
before= 17% less QFile::exists


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

2016-04-10 Thread Anthony Fieroni


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127216/
---

Review request for KDE Frameworks, Martin Gräßlin and Martin Klapetek.


Changes
---

Works in all cases but session restored apps. This -> 
https://git.reviewboard.kde.org/r/127631/ is need to work and session restore.


Bugs: 356523
https://bugs.kde.org/show_bug.cgi?id=356523


Repository: knotifications


Description
---

Store position of widget before hide it


Diffs (updated)
-

  src/kstatusnotifieritem.cpp 27abfb8 

Diff: https://git.reviewboard.kde.org/r/127216/diff/


Testing
---

Tested on pixel ratio = 1 with Amarok, Kmail, Akregator, Kalarm, Ktimer
Close with 'X' - restore in correct pos
Hide by click at icon in systray - restore correct pos


Thanks,

Anthony Fieroni

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: [sonnet] about the QSettings format

2016-04-10 Thread David Faure

On Sunday 10 April 2016 18:50:00 Martin Sandsmark wrote:
> Hi!
> 
> On Sun, Apr 10, 2016 at 11:23:58AM +0200, David Faure wrote:
> > On Friday 01 April 2016 15:03:10 René J. V. Bertin wrote:
> > > Wasn't it decided a while ago (5.16.0 or so) that frameworks would use 
> > > QSettings::IniFormat and not QSettings::NativeFormat unless they had a 
> > > very good 
> > > reason, in order to have the same file format across platforms and avoid 
> > > storing 
> > > things in the registry under MS Windows?
> > Seems logical to me. CC'ing the sonnet maintainer.
> 
> I have no objections, as long as the old settings are copied over somehow.

Hmm we already care for backwards compatibility on Windows and OSX ?

(This would make no difference on Linux/BSD)

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127572: KNewPasswordWidget: override sizeHint()

2016-04-10 Thread Elvis Angelaccio


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127572/
---

(Updated April 10, 2016, 5:33 p.m.)


Status
--

This change has been discarded.


Review request for KDE Frameworks, Christoph Feck, David Edmundson, David 
Faure, and Ragnar Thomsen.


Repository: kwidgetsaddons


Description
---

We have an use-case in Ark where the password widget belongs to a vertical 
layout within a KCollapsibleGroupBox.
Without this patch, the strength meter bar takes room even if not visible, 
resulting in a wasted empty space (see screenshots).


Diffs
-

  src/knewpasswordwidget.h acd14105fe9f2d3d212a9667be8b05823c2cb4a8 
  src/knewpasswordwidget.cpp 72748d6b9e9fed979bd75ce856867a7bbf9e2fbd 

Diff: https://git.reviewboard.kde.org/r/127572/diff/


Testing
---


File Attachments


Before
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/04/04/e6462cad-f2c9-4b11-86f9-e49230072b77__knewpasswordwidget-no-hint.png
After
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/04/04/9d9b331a-678f-47f0-9335-87c4bfe16204__knewpasswordwidget-size-hint.png


Thanks,

Elvis Angelaccio

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127572: KNewPasswordWidget: override sizeHint()

2016-04-10 Thread David Faure



> On April 10, 2016, 12:47 p.m., David Faure wrote:
> > src/knewpasswordwidget.cpp, line 271
> > 
> >
> > This can't be right. Either they are underneath each other, or next to 
> > each other, but not both.
> > 
> > If both have a 100x100 size, you're returning 200x200, which is enough 
> > room for 4 sublayouts, not just 2.
> > 
> > Tell me more, why is the default sizeHint not good enough? Isn't there 
> > a toplevel layout with these two layouts in it?
> 
> Elvis Angelaccio wrote:
> > Isn't there a toplevel layout with these two layouts in it?
> 
> It looks like there isn't: https://paste.kde.org/pehesln9r
> 
> I'll try to add it.
> 
> Elvis Angelaccio wrote:
> > It looks like there isn't: https://paste.kde.org/pehesln9r
> > I'll try to add it.
> 
> Ehm, actually there is :)
> 
> It's vertical layout
> 
> David Faure wrote:
> Yep. If you commit a test app using a collapsible groupbox I can help 
> debug this. The bug might not be in this widget...
> 
> Elvis Angelaccio wrote:
> > If you commit a test app using a collapsible groupbox I can help debug 
> this.
> 
> Can/should I commit it to the kwidgetsaddons/tests folder? Otherwise I 
> can send you an archive with the test app code.
> 
> David Faure wrote:
> test programs in kwidgetsaddons/tests are always useful
> 
> Elvis Angelaccio wrote:
> There you go: 
> https://quickgit.kde.org/?p=kwidgetsaddons.git=commit=05bdd242f7f90e5d8f964332c724d15107173f39

Fixed in 
http://commits.kde.org/kwidgetsaddons/26a38bab8de9b2af90de814fe6f717b5645eefad


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127572/#review94479
---


On April 10, 2016, 12:38 p.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127572/
> ---
> 
> (Updated April 10, 2016, 12:38 p.m.)
> 
> 
> Review request for KDE Frameworks, Christoph Feck, David Edmundson, David 
> Faure, and Ragnar Thomsen.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> We have an use-case in Ark where the password widget belongs to a vertical 
> layout within a KCollapsibleGroupBox.
> Without this patch, the strength meter bar takes room even if not visible, 
> resulting in a wasted empty space (see screenshots).
> 
> 
> Diffs
> -
> 
>   src/knewpasswordwidget.h acd14105fe9f2d3d212a9667be8b05823c2cb4a8 
>   src/knewpasswordwidget.cpp 72748d6b9e9fed979bd75ce856867a7bbf9e2fbd 
> 
> Diff: https://git.reviewboard.kde.org/r/127572/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Before
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/04/e6462cad-f2c9-4b11-86f9-e49230072b77__knewpasswordwidget-no-hint.png
> After
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/04/9d9b331a-678f-47f0-9335-87c4bfe16204__knewpasswordwidget-size-hint.png
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127572: KNewPasswordWidget: override sizeHint()

2016-04-10 Thread Elvis Angelaccio



> On April 10, 2016, 12:47 p.m., David Faure wrote:
> > src/knewpasswordwidget.cpp, line 271
> > 
> >
> > This can't be right. Either they are underneath each other, or next to 
> > each other, but not both.
> > 
> > If both have a 100x100 size, you're returning 200x200, which is enough 
> > room for 4 sublayouts, not just 2.
> > 
> > Tell me more, why is the default sizeHint not good enough? Isn't there 
> > a toplevel layout with these two layouts in it?
> 
> Elvis Angelaccio wrote:
> > Isn't there a toplevel layout with these two layouts in it?
> 
> It looks like there isn't: https://paste.kde.org/pehesln9r
> 
> I'll try to add it.
> 
> Elvis Angelaccio wrote:
> > It looks like there isn't: https://paste.kde.org/pehesln9r
> > I'll try to add it.
> 
> Ehm, actually there is :)
> 
> It's vertical layout
> 
> David Faure wrote:
> Yep. If you commit a test app using a collapsible groupbox I can help 
> debug this. The bug might not be in this widget...
> 
> Elvis Angelaccio wrote:
> > If you commit a test app using a collapsible groupbox I can help debug 
> this.
> 
> Can/should I commit it to the kwidgetsaddons/tests folder? Otherwise I 
> can send you an archive with the test app code.
> 
> David Faure wrote:
> test programs in kwidgetsaddons/tests are always useful

There you go: 
https://quickgit.kde.org/?p=kwidgetsaddons.git=commit=05bdd242f7f90e5d8f964332c724d15107173f39


- Elvis


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127572/#review94479
---


On April 10, 2016, 12:38 p.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127572/
> ---
> 
> (Updated April 10, 2016, 12:38 p.m.)
> 
> 
> Review request for KDE Frameworks, Christoph Feck, David Edmundson, David 
> Faure, and Ragnar Thomsen.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> We have an use-case in Ark where the password widget belongs to a vertical 
> layout within a KCollapsibleGroupBox.
> Without this patch, the strength meter bar takes room even if not visible, 
> resulting in a wasted empty space (see screenshots).
> 
> 
> Diffs
> -
> 
>   src/knewpasswordwidget.h acd14105fe9f2d3d212a9667be8b05823c2cb4a8 
>   src/knewpasswordwidget.cpp 72748d6b9e9fed979bd75ce856867a7bbf9e2fbd 
> 
> Diff: https://git.reviewboard.kde.org/r/127572/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Before
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/04/e6462cad-f2c9-4b11-86f9-e49230072b77__knewpasswordwidget-no-hint.png
> After
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/04/9d9b331a-678f-47f0-9335-87c4bfe16204__knewpasswordwidget-size-hint.png
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127572: KNewPasswordWidget: override sizeHint()

2016-04-10 Thread David Faure



> On April 10, 2016, 12:47 p.m., David Faure wrote:
> > src/knewpasswordwidget.cpp, line 271
> > 
> >
> > This can't be right. Either they are underneath each other, or next to 
> > each other, but not both.
> > 
> > If both have a 100x100 size, you're returning 200x200, which is enough 
> > room for 4 sublayouts, not just 2.
> > 
> > Tell me more, why is the default sizeHint not good enough? Isn't there 
> > a toplevel layout with these two layouts in it?
> 
> Elvis Angelaccio wrote:
> > Isn't there a toplevel layout with these two layouts in it?
> 
> It looks like there isn't: https://paste.kde.org/pehesln9r
> 
> I'll try to add it.
> 
> Elvis Angelaccio wrote:
> > It looks like there isn't: https://paste.kde.org/pehesln9r
> > I'll try to add it.
> 
> Ehm, actually there is :)
> 
> It's vertical layout
> 
> David Faure wrote:
> Yep. If you commit a test app using a collapsible groupbox I can help 
> debug this. The bug might not be in this widget...
> 
> Elvis Angelaccio wrote:
> > If you commit a test app using a collapsible groupbox I can help debug 
> this.
> 
> Can/should I commit it to the kwidgetsaddons/tests folder? Otherwise I 
> can send you an archive with the test app code.

test programs in kwidgetsaddons/tests are always useful


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127572/#review94479
---


On April 10, 2016, 12:38 p.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127572/
> ---
> 
> (Updated April 10, 2016, 12:38 p.m.)
> 
> 
> Review request for KDE Frameworks, Christoph Feck, David Edmundson, David 
> Faure, and Ragnar Thomsen.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> We have an use-case in Ark where the password widget belongs to a vertical 
> layout within a KCollapsibleGroupBox.
> Without this patch, the strength meter bar takes room even if not visible, 
> resulting in a wasted empty space (see screenshots).
> 
> 
> Diffs
> -
> 
>   src/knewpasswordwidget.h acd14105fe9f2d3d212a9667be8b05823c2cb4a8 
>   src/knewpasswordwidget.cpp 72748d6b9e9fed979bd75ce856867a7bbf9e2fbd 
> 
> Diff: https://git.reviewboard.kde.org/r/127572/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Before
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/04/e6462cad-f2c9-4b11-86f9-e49230072b77__knewpasswordwidget-no-hint.png
> After
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/04/9d9b331a-678f-47f0-9335-87c4bfe16204__knewpasswordwidget-size-hint.png
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127572: KNewPasswordWidget: override sizeHint()

2016-04-10 Thread David Faure



> On April 10, 2016, 12:47 p.m., David Faure wrote:
> > src/knewpasswordwidget.cpp, line 271
> > 
> >
> > This can't be right. Either they are underneath each other, or next to 
> > each other, but not both.
> > 
> > If both have a 100x100 size, you're returning 200x200, which is enough 
> > room for 4 sublayouts, not just 2.
> > 
> > Tell me more, why is the default sizeHint not good enough? Isn't there 
> > a toplevel layout with these two layouts in it?
> 
> Elvis Angelaccio wrote:
> > Isn't there a toplevel layout with these two layouts in it?
> 
> It looks like there isn't: https://paste.kde.org/pehesln9r
> 
> I'll try to add it.
> 
> Elvis Angelaccio wrote:
> > It looks like there isn't: https://paste.kde.org/pehesln9r
> > I'll try to add it.
> 
> Ehm, actually there is :)
> 
> It's vertical layout

Yep. If you commit a test app using a collapsible groupbox I can help debug 
this. The bug might not be in this widget...


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127572/#review94479
---


On April 10, 2016, 12:38 p.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127572/
> ---
> 
> (Updated April 10, 2016, 12:38 p.m.)
> 
> 
> Review request for KDE Frameworks, Christoph Feck, David Edmundson, David 
> Faure, and Ragnar Thomsen.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> We have an use-case in Ark where the password widget belongs to a vertical 
> layout within a KCollapsibleGroupBox.
> Without this patch, the strength meter bar takes room even if not visible, 
> resulting in a wasted empty space (see screenshots).
> 
> 
> Diffs
> -
> 
>   src/knewpasswordwidget.h acd14105fe9f2d3d212a9667be8b05823c2cb4a8 
>   src/knewpasswordwidget.cpp 72748d6b9e9fed979bd75ce856867a7bbf9e2fbd 
> 
> Diff: https://git.reviewboard.kde.org/r/127572/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Before
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/04/e6462cad-f2c9-4b11-86f9-e49230072b77__knewpasswordwidget-no-hint.png
> After
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/04/9d9b331a-678f-47f0-9335-87c4bfe16204__knewpasswordwidget-size-hint.png
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127572: KNewPasswordWidget: override sizeHint()

2016-04-10 Thread Elvis Angelaccio



> On April 10, 2016, 12:47 p.m., David Faure wrote:
> > src/knewpasswordwidget.cpp, line 271
> > 
> >
> > This can't be right. Either they are underneath each other, or next to 
> > each other, but not both.
> > 
> > If both have a 100x100 size, you're returning 200x200, which is enough 
> > room for 4 sublayouts, not just 2.
> > 
> > Tell me more, why is the default sizeHint not good enough? Isn't there 
> > a toplevel layout with these two layouts in it?
> 
> Elvis Angelaccio wrote:
> > Isn't there a toplevel layout with these two layouts in it?
> 
> It looks like there isn't: https://paste.kde.org/pehesln9r
> 
> I'll try to add it.

> It looks like there isn't: https://paste.kde.org/pehesln9r
> I'll try to add it.

Ehm, actually there is :)

It's vertical layout


- Elvis


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127572/#review94479
---


On April 10, 2016, 12:38 p.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127572/
> ---
> 
> (Updated April 10, 2016, 12:38 p.m.)
> 
> 
> Review request for KDE Frameworks, Christoph Feck, David Edmundson, David 
> Faure, and Ragnar Thomsen.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> We have an use-case in Ark where the password widget belongs to a vertical 
> layout within a KCollapsibleGroupBox.
> Without this patch, the strength meter bar takes room even if not visible, 
> resulting in a wasted empty space (see screenshots).
> 
> 
> Diffs
> -
> 
>   src/knewpasswordwidget.h acd14105fe9f2d3d212a9667be8b05823c2cb4a8 
>   src/knewpasswordwidget.cpp 72748d6b9e9fed979bd75ce856867a7bbf9e2fbd 
> 
> Diff: https://git.reviewboard.kde.org/r/127572/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Before
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/04/e6462cad-f2c9-4b11-86f9-e49230072b77__knewpasswordwidget-no-hint.png
> After
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/04/9d9b331a-678f-47f0-9335-87c4bfe16204__knewpasswordwidget-size-hint.png
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127572: KNewPasswordWidget: override sizeHint()

2016-04-10 Thread Elvis Angelaccio



> On April 10, 2016, 12:47 p.m., David Faure wrote:
> > src/knewpasswordwidget.cpp, line 271
> > 
> >
> > This can't be right. Either they are underneath each other, or next to 
> > each other, but not both.
> > 
> > If both have a 100x100 size, you're returning 200x200, which is enough 
> > room for 4 sublayouts, not just 2.
> > 
> > Tell me more, why is the default sizeHint not good enough? Isn't there 
> > a toplevel layout with these two layouts in it?

> Isn't there a toplevel layout with these two layouts in it?

It looks like there isn't: https://paste.kde.org/pehesln9r

I'll try to add it.


- Elvis


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127572/#review94479
---


On April 10, 2016, 12:38 p.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127572/
> ---
> 
> (Updated April 10, 2016, 12:38 p.m.)
> 
> 
> Review request for KDE Frameworks, Christoph Feck, David Edmundson, David 
> Faure, and Ragnar Thomsen.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> We have an use-case in Ark where the password widget belongs to a vertical 
> layout within a KCollapsibleGroupBox.
> Without this patch, the strength meter bar takes room even if not visible, 
> resulting in a wasted empty space (see screenshots).
> 
> 
> Diffs
> -
> 
>   src/knewpasswordwidget.h acd14105fe9f2d3d212a9667be8b05823c2cb4a8 
>   src/knewpasswordwidget.cpp 72748d6b9e9fed979bd75ce856867a7bbf9e2fbd 
> 
> Diff: https://git.reviewboard.kde.org/r/127572/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Before
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/04/e6462cad-f2c9-4b11-86f9-e49230072b77__knewpasswordwidget-no-hint.png
> After
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/04/9d9b331a-678f-47f0-9335-87c4bfe16204__knewpasswordwidget-size-hint.png
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127572: KNewPasswordWidget: override sizeHint()

2016-04-10 Thread David Faure


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127572/#review94479
---




src/knewpasswordwidget.cpp (line 271)


This can't be right. Either they are underneath each other, or next to each 
other, but not both.

If both have a 100x100 size, you're returning 200x200, which is enough room 
for 4 sublayouts, not just 2.

Tell me more, why is the default sizeHint not good enough? Isn't there a 
toplevel layout with these two layouts in it?


- David Faure


On April 10, 2016, 12:38 p.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127572/
> ---
> 
> (Updated April 10, 2016, 12:38 p.m.)
> 
> 
> Review request for KDE Frameworks, Christoph Feck, David Edmundson, David 
> Faure, and Ragnar Thomsen.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> We have an use-case in Ark where the password widget belongs to a vertical 
> layout within a KCollapsibleGroupBox.
> Without this patch, the strength meter bar takes room even if not visible, 
> resulting in a wasted empty space (see screenshots).
> 
> 
> Diffs
> -
> 
>   src/knewpasswordwidget.h acd14105fe9f2d3d212a9667be8b05823c2cb4a8 
>   src/knewpasswordwidget.cpp 72748d6b9e9fed979bd75ce856867a7bbf9e2fbd 
> 
> Diff: https://git.reviewboard.kde.org/r/127572/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> Before
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/04/e6462cad-f2c9-4b11-86f9-e49230072b77__knewpasswordwidget-no-hint.png
> After
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/04/9d9b331a-678f-47f0-9335-87c4bfe16204__knewpasswordwidget-size-hint.png
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127536: KNewPasswordWidget: fix QPalette when the widget is disabled

2016-04-10 Thread Elvis Angelaccio


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127536/
---

(Updated April 10, 2016, 12:26 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Aleix Pol Gonzalez, Christoph Feck, and 
David Faure.


Changes
---

Submitted with commit 167113f16a3b3aeea5cd4050a9a6db78c20d74a2 by Elvis 
Angelaccio to branch master.


Repository: kwidgetsaddons


Description
---

If the widget gets disabled, the verification's QLineEdit is disabled as well, 
but its QPalette is wrong (see the screenshots).
This patch fixes the bug by setting the Active color group for the palette.


Diffs
-

  autotests/knewpasswordwidgettest.h 3b7418700557cd3a2b3de91127f76a5bf99345d3 
  autotests/knewpasswordwidgettest.cpp 4507dbdc899407afb72ffa14437f050aae0b57df 
  src/knewpasswordwidget.cpp 72748d6b9e9fed979bd75ce856867a7bbf9e2fbd 

Diff: https://git.reviewboard.kde.org/r/127536/diff/


Testing
---

A test case is added to reproduce the bug.


File Attachments


Before
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/03/31/d4d0d5be-91d4-4787-adc2-032d358a3dc5__knewpasswordwidget-disabled1.png
After
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/03/31/46e24106-ceb5-486f-8222-d928c8690929__knewpasswordwidget-disabled2.png


Thanks,

Elvis Angelaccio

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Finding local translations?

2016-04-10 Thread Boudewijn Rempt


On Sun, 10 Apr 2016, Boudewijn Rempt wrote:


On Sun, 10 Apr 2016, David Faure wrote:


On Saturday 09 April 2016 22:21:59 Chusslove Illich wrote:

KCatalog::catalogLocaleDir should first
execute when the first translation call happens


Maybe krita has some global static with an i18n() call in it then. Bad 

idea!

I recommend a breakpoint in KCatalog::catalogLocaleDir to find out more.




Hm, yes, that shouldn't happen! I'll check that first!




Ah, that was the problem indeed: for some static, someone had been
using i18n instead of ki18n...
--
Boudewijn Rempt | http://www.krita.org, http://www.valdyas.org
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Finding local translations?

2016-04-10 Thread Boudewijn Rempt


On Sat, 9 Apr 2016, Chusslove Illich wrote:


[: Boudewijn Rempt :]
However, KCatalog::catalogLocaleDir is run before the main runs, and uses
QStandardPaths to find the location of the translations. That's before
the XDG_DATA_DIRS environment variable is set.


[: Alexander Potashev :]
You can use a wrapper application that runs Krita with XDG_DATA_DIRS set
to whatever appropriate. Of course this is dirty, and we should instead
support custom paths to .mo files in KI18n.


I don't think there should be specific support in KI18n for setting custom
paths. What makes KI18n special compared to other code that uses
QStandardPaths?


Well... My goal is to make it possible to run krita without any environment
variables set. I already have a wrapper around QStandardPaths that also adds
paths relative to the executable itself. I also don't want wrapper applications
because that gives weird results in the task manager.


Regarding KCatalog::catalogLocaleDir being called before main runs in Krita,
I don't know why that is happening. KCatalog::catalogLocaleDir should first
execute when the first translation call happens (or first
availableDomainTranslations/availableApplicationTranslations call). I
checked it now with KWrite, and that is what is happening. I could happily
munge XDG_DATA_DIRS before QApplication in KWrite is created, and KCatalog
would heed it.


I will check that.

--
Boudewijn Rempt | http://www.krita.org, http://www.valdyas.org
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Finding local translations?

2016-04-10 Thread Boudewijn Rempt


On Sun, 10 Apr 2016, David Faure wrote:


On Saturday 09 April 2016 22:21:59 Chusslove Illich wrote:

KCatalog::catalogLocaleDir should first
execute when the first translation call happens


Maybe krita has some global static with an i18n() call in it then. Bad idea!
I recommend a breakpoint in KCatalog::catalogLocaleDir to find out more.




Hm, yes, that shouldn't happen! I'll check that first!

--
Boudewijn Rempt | http://www.krita.org, http://www.valdyas.org
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: baloo master kf5-qt5 » Linux,gcc - Build # 23 - Failure!

2016-04-10 Thread no-reply


GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/baloo%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/23/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 10 Apr 2016 10:55:14 +
Build duration: 16 min

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 23 - Fixed!

2016-04-10 Thread no-reply


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/23/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 10 Apr 2016 10:43:18 +
Build duration: 11 min

CHANGE SET
Revision 4a51dd6ee5ca902119ddc2c4481d63ee0ca1a58f by David Faure: (autotest: 
clean up symlink at end of test (the CI error was file)
  change: edit autotests/kdirlistertest.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 
50 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 260/338 (77%)CLASSES 260/338 (77%)LINE 26577/50383 
(53%)CONDITIONAL 14708/22807 (64%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7397/7714 
(96%)CONDITIONAL 4064/7464 (54%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7649/13951 
(55%)CONDITIONAL 4098/5672 (72%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2258/7554 
(30%)CONDITIONAL 911/1403 (65%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/68 (68%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/833 (51%)CONDITIONAL 
318/463 (69%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1754/3781 
(46%)CONDITIONAL 1249/1858 (67%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/758 (79%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 723/1155 (63%)CONDITIONAL 
384/533 (72%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 685/762 (90%)CONDITIONAL 
433/820 (53%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/126 (81%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 382/594 (64%)CONDITIONAL 
284/412 (69%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/254 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 31/34 (91%)CONDITIONAL 
42/52 (81%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/194 (75%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/18 (78%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 220/249 (88%)CONDITIONAL 
295/360 (82%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2668/10595 
(25%)CONDITIONAL 1306/1910 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: knewstuff master stable-kf5-qt5 » Linux,gcc - Build # 19 - Failure!

2016-04-10 Thread no-reply


GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/knewstuff%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/19/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 10 Apr 2016 10:50:08 +
Build duration: 4 min 27 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 23 - Fixed!

2016-04-10 Thread no-reply


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/23/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 10 Apr 2016 10:43:18 +
Build duration: 11 min

CHANGE SET
Revision 4a51dd6ee5ca902119ddc2c4481d63ee0ca1a58f by David Faure: (autotest: 
clean up symlink at end of test (the CI error was file)
  change: edit autotests/kdirlistertest.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 
50 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 260/338 (77%)CLASSES 260/338 (77%)LINE 26577/50383 
(53%)CONDITIONAL 14708/22807 (64%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7397/7714 
(96%)CONDITIONAL 4064/7464 (54%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7649/13951 
(55%)CONDITIONAL 4098/5672 (72%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2258/7554 
(30%)CONDITIONAL 911/1403 (65%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/68 (68%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/833 (51%)CONDITIONAL 
318/463 (69%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1754/3781 
(46%)CONDITIONAL 1249/1858 (67%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/758 (79%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 723/1155 (63%)CONDITIONAL 
384/533 (72%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 685/762 (90%)CONDITIONAL 
433/820 (53%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/126 (81%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 382/594 (64%)CONDITIONAL 
284/412 (69%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/254 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 31/34 (91%)CONDITIONAL 
42/52 (81%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/194 (75%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/18 (78%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 220/249 (88%)CONDITIONAL 
295/360 (82%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2668/10595 
(25%)CONDITIONAL 1306/1910 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 22 - Still Unstable!

2016-04-10 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/22/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 10 Apr 2016 09:25:38 +
Build duration: 20 min

CHANGE SET
Revision cf38cd936a85aa2f27aae9cafb8b24df0939422c by David Faure: (autotest: 
output more info when symlink creation fails, as it does in)
  change: edit autotests/kdirlistertest.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 
50 test(s)Failed: TestSuite.kiowidgets-kdirlistertest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 260/338 (77%)CLASSES 260/338 (77%)LINE 26540/50382 
(53%)CONDITIONAL 14686/22765 (65%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7364/7713 
(95%)CONDITIONAL 4036/7416 (54%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7649/13951 
(55%)CONDITIONAL 4096/5670 (72%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2258/7554 
(30%)CONDITIONAL 911/1403 (65%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/68 (68%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/833 (51%)CONDITIONAL 
321/463 (69%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1757/3781 
(46%)CONDITIONAL 1260/1874 (67%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/758 (79%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 716/1155 (62%)CONDITIONAL 
378/525 (72%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 685/762 (90%)CONDITIONAL 
433/820 (53%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/126 (81%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 382/594 (64%)CONDITIONAL 
284/412 (69%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/254 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 31/34 (91%)CONDITIONAL 
42/52 (81%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/194 (75%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/18 (78%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 220/249 (88%)CONDITIONAL 
295/360 (82%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2668/10595 
(25%)CONDITIONAL 1306/1910 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127536: KNewPasswordWidget: fix QPalette when the widget is disabled

2016-04-10 Thread David Faure


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127536/#review94475
---


Fix it, then Ship it!





autotests/knewpasswordwidgettest.cpp (line 247)


The function names are confusing: testDisableWidget and testWidgetDisabled? 
;-)

I guess this one could be testParentWidgetDisabled, right?

But since we're talking about test function naming, better practice is to 
use "should", like:
disablingPasswordWidgetShouldUseDisabledPalette
and
disablingParentShouldUseDisabledPalette
(or whatever it is these functions are testing ;)



autotests/knewpasswordwidgettest.cpp (line 260)


So if both lineedits use the wrong palette, the test passes :-)
I think comparing with widget->palette() would work.

About your previous reply to Aleix: indeed, if the test fails without the 
fix, then the test is good :-)


- David Faure


On April 4, 2016, 2:33 p.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127536/
> ---
> 
> (Updated April 4, 2016, 2:33 p.m.)
> 
> 
> Review request for KDE Frameworks, Aleix Pol Gonzalez, Christoph Feck, and 
> David Faure.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> If the widget gets disabled, the verification's QLineEdit is disabled as 
> well, but its QPalette is wrong (see the screenshots).
> This patch fixes the bug by setting the Active color group for the palette.
> 
> 
> Diffs
> -
> 
>   autotests/knewpasswordwidgettest.h 3b7418700557cd3a2b3de91127f76a5bf99345d3 
>   autotests/knewpasswordwidgettest.cpp 
> 4507dbdc899407afb72ffa14437f050aae0b57df 
>   src/knewpasswordwidget.cpp 72748d6b9e9fed979bd75ce856867a7bbf9e2fbd 
> 
> Diff: https://git.reviewboard.kde.org/r/127536/diff/
> 
> 
> Testing
> ---
> 
> A test case is added to reproduce the bug.
> 
> 
> File Attachments
> 
> 
> Before
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/31/d4d0d5be-91d4-4787-adc2-032d358a3dc5__knewpasswordwidget-disabled1.png
> After
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/03/31/46e24106-ceb5-486f-8222-d928c8690929__knewpasswordwidget-disabled2.png
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: [sonnet] about the QSettings format

2016-04-10 Thread David Faure

On Friday 01 April 2016 15:03:10 René J. V. Bertin wrote:
> Hi,
> 
> Wasn't it decided a while ago (5.16.0 or so) that frameworks would use 
> QSettings::IniFormat and not QSettings::NativeFormat unless they had a very 
> good 
> reason, in order to have the same file format across platforms and avoid 
> storing 
> things in the registry under MS Windows?

Seems logical to me. CC'ing the sonnet maintainer.

IMHO you can make a review request.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: threadweaver master stable-kf5-qt5 » Linux,gcc - Build # 9 - Fixed!

2016-04-10 Thread no-reply


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/threadweaver%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/9/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 10 Apr 2016 09:02:05 +
Build duration: 2 min 45 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 7 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 70/78 (90%)CLASSES 70/78 (90%)LINE 2524/2750 
(92%)CONDITIONAL 3137/6024 (52%)

By packages
  
autotests
FILES 19/19 (100%)CLASSES 19/19 (100%)LINE 1264/1269 
(100%)CONDITIONAL 2290/4522 (51%)
src
FILES 51/59 (86%)CLASSES 51/59 (86%)LINE 1260/1481 
(85%)CONDITIONAL 847/1502 (56%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: threadweaver master stable-kf5-qt5 » Linux,gcc - Build # 9 - Fixed!

2016-04-10 Thread no-reply


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/threadweaver%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/9/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 10 Apr 2016 09:02:05 +
Build duration: 2 min 45 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 7 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 70/78 (90%)CLASSES 70/78 (90%)LINE 2524/2750 
(92%)CONDITIONAL 3137/6024 (52%)

By packages
  
autotests
FILES 19/19 (100%)CLASSES 19/19 (100%)LINE 1264/1269 
(100%)CONDITIONAL 2290/4522 (51%)
src
FILES 51/59 (86%)CLASSES 51/59 (86%)LINE 1260/1481 
(85%)CONDITIONAL 847/1502 (56%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126161: OS X housekeeping

2016-04-10 Thread David Faure

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126161/#review94472
---

I liked what I was seeing in this patch  until I got to the horrible code 
duplication introduced by kinit_mac.mm. This is not the way to go.
Yes #ifdefs are a pain, but code duplication is 1000 times worse. In Qt, the 
_mac.mm files only contain code that is mac specific.

You could move all the code that is common between mac and linux into a 
separate helper file (say kinit_common.{cpp,h}), or you could organize it this 
way:
kinit.cpp/kinit.h -> shared code
kinit_unix.cpp -> linux/bsd-specific
kinit_mac.mm  -> OSX specific
(and the windows guys can make a kinit_win.cpp if they need to, although I'm 
not sure they use kdeinit at all)

Code duplication is the worst enemy of maintenability, I will never accept a 
patch that duplicates lots and lots of code. But other than that, many of the 
changes in this patch seem very sensible, I will definitely approve it once the 
code duplication is gone. Thanks!

src/kdeinit/kinit_mac.mm (line 103)

Ouch, major code duplication. Please move anything that is common between 
kinit.cpp and kinit_mac.mm into a common header (and/or .cpp file, but at least 
for the struct a header is enough).

src/kdeinit/kinit_mac.mm (line 145)

code duplication

src/kdeinit/kinit_mac.mm (line 164)

code duplication

src/kdeinit/kinit_mac.mm (line 210)

If people say ifdefs are bad, surely they are not as bad as duplicating 
hundreds of lines of code, making maintenance much more difficult in the future,

src/kdeinit/kinit_mac.mm (line 289)

I've seen this before  ;)

src/kdeinit/kinit_mac.mm (line 312)

duplicated -> factorize into separate .cpp/.h file

src/kdeinit/kinit_mac.mm (line 331)

duplicated, not mac specific -> factorize

src/kdeinit/kinit_mac.mm (line 361)

Does OOM protection actually exist on OSX?

This code seems quite linux specific to me, i.e. duplicated here but never 
enabled, right? -> remove

src/kdeinit/kinit_mac.mm (line 399)

I give up, this method is too big for me to see how much of it is 
duplicated from kinit.cpp and how much is OSX-specific.
This is a case where #ifdef might actually be much better...

src/kdeinit/kinit_mac.mm (line 656)

same as the linux code?

src/kdeinit/kinit_mac.mm (line 704)

same as the linux code?

src/kdeinit/kinit_mac.mm (line 891)

surely that's pure duplication from kinit.cpp?

src/kdeinit/kinit_mac.mm (line 1271)

yes, it was only used on non-mac, so remove it from here

src/klauncher/klauncher.cpp (line 376)

Please revert, startsWith has a QLatin1String overload.

src/klauncher/klauncher.cpp (line 759)

revert

src/klauncher/klauncher.cpp (line 823)

revert

src/klauncher/klauncher.cpp (line 867)

revert

src/klauncher/klauncher.cpp (line 900)

revert

src/klauncher/klauncher.cpp (line 1074)

revert

src/klauncher/klauncher.cpp (line 1175)

revert, operator== has a QLatin1String overload

src/klauncher/klauncher_main.cpp (line 152)

I'm curious, what's the difference between Q_OS_DARWIN and Q_OS_OSX?

src/wrapper.cpp (line 63)

Does qgetenv(MAC_DISPLAY) really do anything sensible on OSX? I assume this 
doesn't exist, right?

It seems to me that generate_socket_name should just assemble the socket 
name differently on Mac (and Windows), no?

- David Faure

On April 6, 2016, 5:16 p.m., René J.V. Bertin wrote:
> 
> ---
> This is an automatically

Re: Finding local translations?

2016-04-10 Thread David Faure

On Saturday 09 April 2016 22:21:59 Chusslove Illich wrote:
> KCatalog::catalogLocaleDir should first
> execute when the first translation call happens

Maybe krita has some global static with an i18n() call in it then. Bad idea!
I recommend a breakpoint in KCatalog::catalogLocaleDir to find out more.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Please add new versions on bugs.kde.org products on KF5 releases

2016-04-10 Thread David Faure

On Saturday 09 April 2016 19:02:02 Friedrich W. H. Kossebau wrote:
> IIRC elsewhere I have seen people using a version called "git" in issue 
> trackers, which would be used by developers for random snaphots and have them 
> state the git commit id explicitely in the bug report. 

Alternatively, one can use the version number of the last release, and still 
mention
in the bug report the git sha-1 they are using. This seems sufficient to me.

> But that makes it hard 
> to track regressions/new bugs between 2 versions.
> 
> So what about some "5.xx.0-pre" version, set once the "5.(xx-1).0" is 
> branched? That would allow to collect regressions/new bugs in the development 
> phase separately, without mixing them into bugs for the last released version.

Is there an actual need for this ? It seems to me that this is over-engineering 
it "just in case".

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

42 matches

Mail list logo