Re: Review Request 127988: [runtime] Link KF5::Crash in the binary not in the private library

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127988/
---

(Updated May 23, 2016, 5:46 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit 0f50e128929bc208ee672590a1a8db285335d3e5 by Martin 
Gräßlin to branch master.


Repository: kglobalaccel


Description
---

KCrash is only used by the kglobalacceld5 binary, but not in the
private library. So don't link it in the library as otherwise it's
get pulled into applications using the private library, but don't
want to use KCrash (example kwin_wayland).


Diffs
-

  src/runtime/CMakeLists.txt 50f64935657fda61b246610246977c19c6563147 

Diff: https://git.reviewboard.kde.org/r/127988/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127912: Add 2 methods to gain more info about a mimetype or protocol

[Martin Kostolný]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127912/
---

(Updated May 23, 2016, 4:49 a.m.)


Status
--

This change has been discarded.


Review request for KDE Frameworks, Krusader, David Edmundson, David Faure, and 
Marco Martin.


Repository: kio


Description
---

KProtocolManager has a method called protocolForArchiveMimetype. It gives one 
protocol for given mimetype even if there exist more then one protocol capable 
of handling this mimetype.

I suggest adding a method called protocolsForArchiveMimetype (note the "s") 
which would give us all protocols that can handle given mimetype. I also 
suggest to add a method for giving all archive mimetypes for given protocol.

This request is based on a potential need of some apps to prioritize one 
protocol over others (specifically krarc:/ from Krusader over other 
archive-handling protocols).


Diffs
-

  src/core/kprotocolmanager.h 13b8c07 
  src/core/kprotocolmanager.cpp 9a0a96f 

Diff: https://git.reviewboard.kde.org/r/127912/diff/


Testing
---

I've tested both methods through Krusader code. Partially covered in this 
phabricator task: https://phabricator.kde.org/T2401


Thanks,

Martin Kostolný

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127912: Add 2 methods to gain more info about a mimetype or protocol

[Martin Kostolný]

> On May 14, 2016, 1:59 p.m., David Faure wrote:
> > But how is the app supposed to then choose which protocol to use?
> > 
> > If it needs its own setting for the preferred kioslave, then what's the 
> > point of the query that returns a list?
> > 
> > In other words, if you know you want to prefer krarc, why not just query 
> > whether krarc is available and use it if yes?
> 
> Martin Kostolný wrote:
> I'm sorry, it is very well possible that I don't know the required API 
> for these queries. It is as You said: basically I need to test whether 
> krarc:/ is available and I also need to test if given mimetype can be handled 
> by krarc protocol. Is there a way to achieve that with current KIO API? 
> Thanks!
> 
> David Faure wrote:
> To find if krarc is available, use 
> KProtocolInfo::isKnownProtocol("krarc").
> 
> To find which archive mimetypes "krarc" can support, hmm, there was no 
> API for it, so I just added it. KProtocolInfo::archiveMimeTypes("krarc"), 
> requires KF 5.23 (released next month).
> See http://commits.kde.org/kio/a60c6c437067c9daa2b5bbe6638ba4080342dacf

Perfect, thanks a lot! :-)


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127912/#review95467
---


On May 14, 2016, 11:38 a.m., Martin Kostolný wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127912/
> ---
> 
> (Updated May 14, 2016, 11:38 a.m.)
> 
> 
> Review request for KDE Frameworks, Krusader, David Edmundson, David Faure, 
> and Marco Martin.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> KProtocolManager has a method called protocolForArchiveMimetype. It gives one 
> protocol for given mimetype even if there exist more then one protocol 
> capable of handling this mimetype.
> 
> I suggest adding a method called protocolsForArchiveMimetype (note the "s") 
> which would give us all protocols that can handle given mimetype. I also 
> suggest to add a method for giving all archive mimetypes for given protocol.
> 
> This request is based on a potential need of some apps to prioritize one 
> protocol over others (specifically krarc:/ from Krusader over other 
> archive-handling protocols).
> 
> 
> Diffs
> -
> 
>   src/core/kprotocolmanager.h 13b8c07 
>   src/core/kprotocolmanager.cpp 9a0a96f 
> 
> Diff: https://git.reviewboard.kde.org/r/127912/diff/
> 
> 
> Testing
> ---
> 
> I've tested both methods through Krusader code. Partially covered in this 
> phabricator task: https://phabricator.kde.org/T2401
> 
> 
> Thanks,
> 
> Martin Kostolný
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121218: Allow using new style connect syntax with KStandardAction::create()

[Gleb Popov]

> On April 5, 2015, 5:26 p.m., David Faure wrote:
> > Well, +1 for the idea. But I wonder what the apidox will look like, the 
> > macro+template probably don't make it work.
> > 
> > Also missing @since 5.10.
> > 
> > Ship it from me once the apidox issue is resolved.
> 
> Gleb Popov wrote:
> What apidox issue is being talked about? If it is about 
> `KSTANDARDACTION_WITH_NEW_STYLE_CONNECT`, then i was able to make it work 
> with some simple Doxyfile options.
> 
> See `save()` overload for example: 
> http://arrowd.name/html/namespace_k_standard_action.html#abd0ad3c1f3ee5c9d2ff068a06c8a6ac1
>  and 
> http://arrowd.name/html/namespace_k_standard_action.html#a92c0df356ef011d4a7ae9a844d4a0bc7
> 
> If this is OK, i can document all new connects with `@since@` too. Can 
> this be commited then?
> 
> David Faure wrote:
> Well that's ugly docs :) You should use #ifdef DOXYGEN_SHOULD_SKIP_THIS 
> around the enable_if and in the #else use the readable version (QAction *, 
> IIUC) so that doxygen sees something cleaner and readable by the developer 
> using this API.
> 
> But actually I don't even understand the use of enable_if here. How can a 
> pointer-to-function or a lambda be ambiguous with const char * ?
> 
> Alex Richardson wrote:
> I don't remember why I needed it because it's been a long time since I 
> wrote that code. But I think the compiler might try to substitute the 
> template parameter Func with `const char*` in some cases. The other way to 
> solve this might be to use like `const typename 
> QtPrivate::FunctionPointer::Object *receiver` instead of `QObject*` to 
> constrain the type of the Func argument.
> 
> David Faure wrote:
> I applied the patch locally to try what happens without the enable_if.
> Indeed openRecent() becomes ambiguous then.
> This is because of the use of template, the 
> compiler will happily instanciate that with Receiver=QObject and Func=const 
> char*, making it ambiguous with the old method. So your last suggestion 
> wouldn't help, this isn't about Receiver, it's about Func.
> 
> Indeed qtimer.h has similar stuff, pushed even further with
> // singleShot to a functor or function pointer (without context)
> template 
> static inline typename 
> QtPrivate::QEnableIf::IsPointerToMemberFunction
>  &&
> !QtPrivate::is_same char*, Func1>::value, void>::Type
> 
> :-)
> 
> Note however that, as I suspected, this is hidden from the unsuspecting 
> developer, by showing a "readable" version for the API doc.
> That's all I'm asking for ;)

Would you prefer `QEnableIf` or `std::enable_if`?


- Gleb


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121218/#review78527
---


On Dec. 24, 2014, 4:23 p.m., Alex Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121218/
> ---
> 
> (Updated Dec. 24, 2014, 4:23 p.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Nicolás Alvarez.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> ---
> 
> Not sure if MSVC has the necessary type_traits working, but can't test that 
> now since it don't have a Windows machine available.
> 
> 
> Diffs
> -
> 
>   autotests/kstandardactiontest.h 0008d281c0353e872feb7483c75762a0012a7b76 
>   autotests/kstandardactiontest.cpp 09ae35db05467d61b8baf50fac70c6228e324492 
>   src/kstandardaction.h d511778b7a24b1ec2e546949dab21f1ec2fea96f 
>   src/kstandardaction.cpp e5bea7965032355501b4c238e37abcc0f883c0b7 
> 
> Diff: https://git.reviewboard.kde.org/r/121218/diff/
> 
> 
> Testing
> ---
> 
> The newly added unit test passes
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kpty master stable-kf5-qt5 » Linux,gcc - Build # 43 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kpty%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/43/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 23 May 2016 02:42:56 +
Build duration: 51 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 432/557 
(78%)CONDITIONAL 125/243 (51%)

By packages
  
autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 111/111 
(100%)CONDITIONAL 38/72 (53%)
src
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 321/446 (72%)CONDITIONAL 
87/171 (51%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kpty master stable-kf5-qt5 » Linux,gcc - Build # 43 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kpty%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/43/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 23 May 2016 02:42:56 +
Build duration: 51 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 432/557 
(78%)CONDITIONAL 125/243 (51%)

By packages
  
autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 111/111 
(100%)CONDITIONAL 38/72 (53%)
src
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 321/446 (72%)CONDITIONAL 
87/171 (51%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kcoreaddons master kf5-qt5 » Linux,gcc - Build # 35 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kcoreaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/35/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 23 May 2016 02:39:45 +
Build duration: 3 min 6 sec

CHANGE SET
Revision 47af3e31625ec3326f5c192d629a9848edfd0817 by aleixpol: (Print the 
failing plugin when notifying a cast warning)
  change: edit src/lib/plugin/kpluginmetadata.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 
24 test(s)Failed: TestSuite.kpluginmetadatatest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 10/10 (100%)FILES 79/93 (85%)CLASSES 79/93 (85%)LINE 5748/8038 
(72%)CONDITIONAL 10486/24934 (42%)

By packages
  
autotests
FILES 33/40 (83%)CLASSES 33/40 (83%)LINE 2470/2578 
(96%)CONDITIONAL 6356/13167 (48%)
src.desktoptojson
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 82/106 (77%)CONDITIONAL 
145/392 (37%)
src.lib
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 299/526 (57%)CONDITIONAL 
190/897 (21%)
src.lib.caching
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 352/787 (45%)CONDITIONAL 
199/1048 (19%)
src.lib.io
FILES 9/10 (90%)CLASSES 9/10 (90%)LINE 745/1410 
(53%)CONDITIONAL 896/3362 (27%)
src.lib.jobs
FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 155/302 (51%)CONDITIONAL 
55/144 (38%)
src.lib.plugin
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 611/708 (86%)CONDITIONAL 
1009/2229 (45%)
src.lib.randomness
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/98 (66%)CONDITIONAL 
40/66 (61%)
src.lib.text
FILES 5/8 (63%)CLASSES 5/8 (63%)LINE 312/728 (43%)CONDITIONAL 
785/2029 (39%)
src.lib.util
FILES 10/10 (100%)CLASSES 10/10 (100%)LINE 657/795 
(83%)CONDITIONAL 811/1600 (51%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kcoreaddons master stable-kf5-qt5 » Linux,gcc - Build # 36 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kcoreaddons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/36/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 23 May 2016 02:39:45 +
Build duration: 2 min 45 sec

CHANGE SET
Revision 47af3e31625ec3326f5c192d629a9848edfd0817 by aleixpol: (Print the 
failing plugin when notifying a cast warning)
  change: edit src/lib/plugin/kpluginmetadata.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 
24 test(s)Failed: TestSuite.kpluginmetadatatest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 10/10 (100%)FILES 79/93 (85%)CLASSES 79/93 (85%)LINE 5748/8038 
(72%)CONDITIONAL 10510/25008 (42%)

By packages
  
autotests
FILES 33/40 (83%)CLASSES 33/40 (83%)LINE 2470/2578 
(96%)CONDITIONAL 6364/13183 (48%)
src.desktoptojson
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 82/106 (77%)CONDITIONAL 
145/392 (37%)
src.lib
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 299/526 (57%)CONDITIONAL 
190/907 (21%)
src.lib.caching
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 352/787 (45%)CONDITIONAL 
199/1048 (19%)
src.lib.io
FILES 9/10 (90%)CLASSES 9/10 (90%)LINE 745/1410 
(53%)CONDITIONAL 903/3388 (27%)
src.lib.jobs
FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 155/302 (51%)CONDITIONAL 
55/144 (38%)
src.lib.plugin
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 611/708 (86%)CONDITIONAL 
1011/2233 (45%)
src.lib.randomness
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/98 (66%)CONDITIONAL 
40/66 (61%)
src.lib.text
FILES 5/8 (63%)CLASSES 5/8 (63%)LINE 312/728 (43%)CONDITIONAL 
789/2041 (39%)
src.lib.util
FILES 10/10 (100%)CLASSES 10/10 (100%)LINE 657/795 
(83%)CONDITIONAL 814/1606 (51%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Can we have a headersclean check for frameworks?

[David Faure]

On jeudi 12 mai 2016 00:15:21 CEST Aleix Pol wrote:
> On Wed, May 11, 2016 at 10:51 PM, Stephen Kelly  wrote:
> > Hi,
> > 
> > Qt has a headersclean utility which runs each header through the compiler
> > on its own. That verifies that it doesn't cause certain warnings, can
> > compile in the presence of certain Qt defines, and includes or forward
> > declares everything it should.
> > 
> > We don't have such a thing in KF5, but as shown by
> > 
> >  https://quickgit.kde.org/?p=kconfigwidgets.git=commitdiff=2900814b
> > 
> > we would benefit from it.
> > 
> > Does anyone want to try to implement it (or borrow the Qt implementation)
> > and integrate it?
> > 
> > We can probably add it to ECM and run it as part of the build of
> > frameworks.
> That could make sense, maybe as a clazy check?
> 
> Can you point us to Qt's so we know what we're talking about?

It's about compiling the headers with a strict set of flags (and no .cpp code).
Sounds more like ECM than clazy to me.

See the hit for headersclean in mkspecs/features/qt_module_headers.prf
for the flags and the implementation:
it adds a "extra compiler command" which runs the actual C++ compiler, with as 
input all the public headers, and no linking happens (it obviously wouldn't 
link).

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 73 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/73/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 22 May 2016 22:33:45 +
Build duration: 6 min 2 sec

CHANGE SET
Revision 0052e698d40356a505e2ce720079c07a5602495b by David Faure: ([autotests] 
Port testtrash to QTemporaryDir to avoid the hardcoded path)
  change: edit src/ioslaves/trash/tests/testtrash.h
  change: edit src/ioslaves/trash/tests/testtrash.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 
50 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 260/338 (77%)CLASSES 260/338 (77%)LINE 26756/50650 
(53%)CONDITIONAL 14897/37427 (40%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7540/7856 
(96%)CONDITIONAL 4179/8152 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7668/14041 
(55%)CONDITIONAL 4142/8907 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2270/7564 
(30%)CONDITIONAL 914/4407 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/833 (51%)CONDITIONAL 
318/719 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1762/3781 
(47%)CONDITIONAL 1258/3434 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 
375/753 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 684/760 (90%)CONDITIONAL 
435/916 (47%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
329/410 (80%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2668/10603 
(25%)CONDITIONAL 1309/6792 (19%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 73 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/73/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 22 May 2016 22:33:45 +
Build duration: 6 min 2 sec

CHANGE SET
Revision 0052e698d40356a505e2ce720079c07a5602495b by David Faure: ([autotests] 
Port testtrash to QTemporaryDir to avoid the hardcoded path)
  change: edit src/ioslaves/trash/tests/testtrash.h
  change: edit src/ioslaves/trash/tests/testtrash.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 
50 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 260/338 (77%)CLASSES 260/338 (77%)LINE 26756/50650 
(53%)CONDITIONAL 14897/37427 (40%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7540/7856 
(96%)CONDITIONAL 4179/8152 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7668/14041 
(55%)CONDITIONAL 4142/8907 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2270/7564 
(30%)CONDITIONAL 914/4407 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/833 (51%)CONDITIONAL 
318/719 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1762/3781 
(47%)CONDITIONAL 1258/3434 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 
375/753 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 684/760 (90%)CONDITIONAL 
435/916 (47%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
329/410 (80%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2668/10603 
(25%)CONDITIONAL 1309/6792 (19%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127896: make dbus optional on osx: kauth

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127896/#review95710
---



Yes this should use OPTION() so that it shows up in cmake's various GUIs.

René: IMHO INCLUDE_DBUS_SUPPORT sounds like it's off by default, i.e. someone 
experiencing a bug might think they need to first enable dbus support... The 
option isn't to include, but to disable.

- David Faure


On May 20, 2016, 9:13 p.m., Nick Shaforostoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127896/
> ---
> 
> (Updated May 20, 2016, 9:13 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X, KDE Frameworks, David Edmundson, 
> and Martin Gräßlin.
> 
> 
> Repository: kauth
> 
> 
> Description
> ---
> 
> this is the first patch to make kde frameworks build (and then work) without 
> dbus.
> 
> this will allow homebrew users use precompiled vanilla Qt to build kde apps 
> on osx. as dbus is not a common service in osx world, kde apps on osx should 
> use native means for interprocess communication instead -- this will make 
> them better citizens in osx ecosystem.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 48dc2d9 
>   autotests/BackendsManager.cpp 59675b3 
>   autotests/CMakeLists.txt b53d760 
>   autotests/HelperTest.cpp 8050a06 
>   src/CMakeLists.txt 1b6930d 
>   src/ConfigureChecks.cmake d46761a 
> 
> Diff: https://git.reviewboard.kde.org/r/127896/diff/
> 
> 
> Testing
> ---
> 
> compiles fine on osx, compiles fine on linux, tests on linux still pass.
> 
> 
> Thanks,
> 
> Nick Shaforostoff
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 69 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/69/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 22 May 2016 22:33:45 +
Build duration: 4 min 29 sec

CHANGE SET
Revision 0052e698d40356a505e2ce720079c07a5602495b by David Faure: ([autotests] 
Port testtrash to QTemporaryDir to avoid the hardcoded path)
  change: edit src/ioslaves/trash/tests/testtrash.cpp
  change: edit src/ioslaves/trash/tests/testtrash.h


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 
50 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 260/338 (77%)CLASSES 260/338 (77%)LINE 26721/50631 
(53%)CONDITIONAL 14872/37403 (40%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7521/7837 
(96%)CONDITIONAL 4167/8128 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7660/14041 
(55%)CONDITIONAL 4138/8907 (46%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2267/7564 
(30%)CONDITIONAL 914/4407 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/833 (51%)CONDITIONAL 
318/719 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1754/3781 
(46%)CONDITIONAL 1249/3434 (36%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 
375/753 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 684/760 (90%)CONDITIONAL 
435/916 (47%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 382/594 (64%)CONDITIONAL 
284/580 (49%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
329/410 (80%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2666/10603 
(25%)CONDITIONAL 1305/6792 (19%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 69 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/69/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 22 May 2016 22:33:45 +
Build duration: 4 min 29 sec

CHANGE SET
Revision 0052e698d40356a505e2ce720079c07a5602495b by David Faure: ([autotests] 
Port testtrash to QTemporaryDir to avoid the hardcoded path)
  change: edit src/ioslaves/trash/tests/testtrash.cpp
  change: edit src/ioslaves/trash/tests/testtrash.h


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 
50 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 260/338 (77%)CLASSES 260/338 (77%)LINE 26721/50631 
(53%)CONDITIONAL 14872/37403 (40%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7521/7837 
(96%)CONDITIONAL 4167/8128 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7660/14041 
(55%)CONDITIONAL 4138/8907 (46%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2267/7564 
(30%)CONDITIONAL 914/4407 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/833 (51%)CONDITIONAL 
318/719 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1754/3781 
(46%)CONDITIONAL 1249/3434 (36%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 
375/753 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 684/760 (90%)CONDITIONAL 
435/916 (47%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 382/594 (64%)CONDITIONAL 
284/580 (49%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
329/410 (80%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2666/10603 
(25%)CONDITIONAL 1305/6792 (19%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: frameworkintegration master stable-kf5-qt5 » Linux,gcc - Build # 78 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/frameworkintegration%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/78/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 22 May 2016 22:18:08 +
Build duration: 56 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 72/205 
(35%)CONDITIONAL 34/172 (20%)

By packages
  
autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 25/27 (93%)CONDITIONAL 
5/10 (50%)
src.kstyle
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 47/178 (26%)CONDITIONAL 
29/162 (18%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: frameworkintegration master stable-kf5-qt5 » Linux,gcc - Build # 78 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/frameworkintegration%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/78/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 22 May 2016 22:18:08 +
Build duration: 56 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 72/205 
(35%)CONDITIONAL 34/172 (20%)

By packages
  
autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 25/27 (93%)CONDITIONAL 
5/10 (50%)
src.kstyle
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 47/178 (26%)CONDITIONAL 
29/162 (18%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kdeclarative master stable-kf5-qt5 » Linux,gcc - Build # 76 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kdeclarative%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/76/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 22 May 2016 22:17:38 +
Build duration: 1 min 29 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/5 (100%)FILES 19/24 (79%)CLASSES 19/24 (79%)LINE 743/1254 
(59%)CONDITIONAL 319/858 (37%)

By packages
  
autotests
FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 402/484 (83%)CONDITIONAL 
192/484 (40%)
src.kdeclarative
FILES 3/4 (75%)CLASSES 3/4 (75%)LINE 150/311 (48%)CONDITIONAL 
60/166 (36%)
src.kdeclarative.private
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 24/58 (41%)CONDITIONAL 
6/32 (19%)
src.qmlcontrols.kquickcontrolsaddons
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 79/144 (55%)CONDITIONAL 
36/78 (46%)
src.quickaddons
FILES 2/6 (33%)CLASSES 2/6 (33%)LINE 88/257 (34%)CONDITIONAL 
25/98 (26%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kdeclarative master stable-kf5-qt5 » Linux,gcc - Build # 76 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kdeclarative%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/76/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 22 May 2016 22:17:38 +
Build duration: 1 min 29 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/5 (100%)FILES 19/24 (79%)CLASSES 19/24 (79%)LINE 743/1254 
(59%)CONDITIONAL 319/858 (37%)

By packages
  
autotests
FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 402/484 (83%)CONDITIONAL 
192/484 (40%)
src.kdeclarative
FILES 3/4 (75%)CLASSES 3/4 (75%)LINE 150/311 (48%)CONDITIONAL 
60/166 (36%)
src.kdeclarative.private
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 24/58 (41%)CONDITIONAL 
6/32 (19%)
src.qmlcontrols.kquickcontrolsaddons
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 79/144 (55%)CONDITIONAL 
36/78 (46%)
src.quickaddons
FILES 2/6 (33%)CLASSES 2/6 (33%)LINE 88/257 (34%)CONDITIONAL 
25/98 (26%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121218: Allow using new style connect syntax with KStandardAction::create()

[David Faure]

> On April 5, 2015, 2:26 p.m., David Faure wrote:
> > Well, +1 for the idea. But I wonder what the apidox will look like, the 
> > macro+template probably don't make it work.
> > 
> > Also missing @since 5.10.
> > 
> > Ship it from me once the apidox issue is resolved.
> 
> Gleb Popov wrote:
> What apidox issue is being talked about? If it is about 
> `KSTANDARDACTION_WITH_NEW_STYLE_CONNECT`, then i was able to make it work 
> with some simple Doxyfile options.
> 
> See `save()` overload for example: 
> http://arrowd.name/html/namespace_k_standard_action.html#abd0ad3c1f3ee5c9d2ff068a06c8a6ac1
>  and 
> http://arrowd.name/html/namespace_k_standard_action.html#a92c0df356ef011d4a7ae9a844d4a0bc7
> 
> If this is OK, i can document all new connects with `@since@` too. Can 
> this be commited then?
> 
> David Faure wrote:
> Well that's ugly docs :) You should use #ifdef DOXYGEN_SHOULD_SKIP_THIS 
> around the enable_if and in the #else use the readable version (QAction *, 
> IIUC) so that doxygen sees something cleaner and readable by the developer 
> using this API.
> 
> But actually I don't even understand the use of enable_if here. How can a 
> pointer-to-function or a lambda be ambiguous with const char * ?
> 
> Alex Richardson wrote:
> I don't remember why I needed it because it's been a long time since I 
> wrote that code. But I think the compiler might try to substitute the 
> template parameter Func with `const char*` in some cases. The other way to 
> solve this might be to use like `const typename 
> QtPrivate::FunctionPointer::Object *receiver` instead of `QObject*` to 
> constrain the type of the Func argument.

I applied the patch locally to try what happens without the enable_if.
Indeed openRecent() becomes ambiguous then.
This is because of the use of template, the 
compiler will happily instanciate that with Receiver=QObject and Func=const 
char*, making it ambiguous with the old method. So your last suggestion 
wouldn't help, this isn't about Receiver, it's about Func.

Indeed qtimer.h has similar stuff, pushed even further with
// singleShot to a functor or function pointer (without context)
template 
static inline typename 
QtPrivate::QEnableIf::IsPointerToMemberFunction
 &&
!QtPrivate::is_same::value, void>::Type

:-)

Note however that, as I suspected, this is hidden from the unsuspecting 
developer, by showing a "readable" version for the API doc.
That's all I'm asking for ;)


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121218/#review78527
---


On Dec. 24, 2014, 1:23 p.m., Alex Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121218/
> ---
> 
> (Updated Dec. 24, 2014, 1:23 p.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Nicolás Alvarez.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> ---
> 
> Not sure if MSVC has the necessary type_traits working, but can't test that 
> now since it don't have a Windows machine available.
> 
> 
> Diffs
> -
> 
>   autotests/kstandardactiontest.h 0008d281c0353e872feb7483c75762a0012a7b76 
>   autotests/kstandardactiontest.cpp 09ae35db05467d61b8baf50fac70c6228e324492 
>   src/kstandardaction.h d511778b7a24b1ec2e546949dab21f1ec2fea96f 
>   src/kstandardaction.cpp e5bea7965032355501b4c238e37abcc0f883c0b7 
> 
> Diff: https://git.reviewboard.kde.org/r/121218/diff/
> 
> 
> Testing
> ---
> 
> The newly added unit test passes
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121218: Allow using new style connect syntax with KStandardAction::create()

[Alex Richardson]

> On April 5, 2015, 3:26 p.m., David Faure wrote:
> > Well, +1 for the idea. But I wonder what the apidox will look like, the 
> > macro+template probably don't make it work.
> > 
> > Also missing @since 5.10.
> > 
> > Ship it from me once the apidox issue is resolved.
> 
> Gleb Popov wrote:
> What apidox issue is being talked about? If it is about 
> `KSTANDARDACTION_WITH_NEW_STYLE_CONNECT`, then i was able to make it work 
> with some simple Doxyfile options.
> 
> See `save()` overload for example: 
> http://arrowd.name/html/namespace_k_standard_action.html#abd0ad3c1f3ee5c9d2ff068a06c8a6ac1
>  and 
> http://arrowd.name/html/namespace_k_standard_action.html#a92c0df356ef011d4a7ae9a844d4a0bc7
> 
> If this is OK, i can document all new connects with `@since@` too. Can 
> this be commited then?
> 
> David Faure wrote:
> Well that's ugly docs :) You should use #ifdef DOXYGEN_SHOULD_SKIP_THIS 
> around the enable_if and in the #else use the readable version (QAction *, 
> IIUC) so that doxygen sees something cleaner and readable by the developer 
> using this API.
> 
> But actually I don't even understand the use of enable_if here. How can a 
> pointer-to-function or a lambda be ambiguous with const char * ?

I don't remember why I needed it because it's been a long time since I wrote 
that code. But I think the compiler might try to substitute the template 
parameter Func with `const char*` in some cases. The other way to solve this 
might be to use like `const typename QtPrivate::FunctionPointer::Object 
*receiver` instead of `QObject*` to constrain the type of the Func argument.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121218/#review78527
---


On Dec. 24, 2014, 1:23 p.m., Alex Richardson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121218/
> ---
> 
> (Updated Dec. 24, 2014, 1:23 p.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Nicolás Alvarez.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> ---
> 
> Not sure if MSVC has the necessary type_traits working, but can't test that 
> now since it don't have a Windows machine available.
> 
> 
> Diffs
> -
> 
>   autotests/kstandardactiontest.h 0008d281c0353e872feb7483c75762a0012a7b76 
>   autotests/kstandardactiontest.cpp 09ae35db05467d61b8baf50fac70c6228e324492 
>   src/kstandardaction.h d511778b7a24b1ec2e546949dab21f1ec2fea96f 
>   src/kstandardaction.cpp e5bea7965032355501b4c238e37abcc0f883c0b7 
> 
> Diff: https://git.reviewboard.kde.org/r/121218/diff/
> 
> 
> Testing
> ---
> 
> The newly added unit test passes
> 
> 
> Thanks,
> 
> Alex Richardson
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: knotifyconfig master stable-kf5-qt5 » Linux,gcc - Build # 69 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/knotifyconfig%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/69/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 22 May 2016 21:04:02 +
Build duration: 50 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  ___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: knotifyconfig master stable-kf5-qt5 » Linux,gcc - Build # 69 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/knotifyconfig%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/69/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 22 May 2016 21:04:02 +
Build duration: 50 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  ___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kdeclarative master stable-kf5-qt5 » Linux,gcc - Build # 75 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kdeclarative%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/75/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 22 May 2016 17:31:32 +
Build duration: 11 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: knotifyconfig master stable-kf5-qt5 » Linux,gcc - Build # 68 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/knotifyconfig%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/68/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 22 May 2016 17:31:32 +
Build duration: 7.1 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: frameworkintegration master stable-kf5-qt5 » Linux,gcc - Build # 77 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/frameworkintegration%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/77/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 22 May 2016 17:31:32 +
Build duration: 7.6 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 72 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/72/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 22 May 2016 17:21:12 +
Build duration: 9 min 21 sec

CHANGE SET
Revision a60c6c437067c9daa2b5bbe6638ba4080342dacf by David Faure: (Add 
KProtocolInfo::archiveMimetypes(), discussed in)
  change: edit src/core/kprotocolinfo.h
  change: edit src/core/kprotocolinfo.cpp


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 
50 test(s)Failed: TestSuite.kiocore-klocalsocketservertestFailed: 
TestSuite.testtrash

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 20/20 (100%)FILES 258/336 (77%)CLASSES 258/336 (77%)LINE 26043/49890 
(52%)CONDITIONAL 14409/36511 (39%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7536/7856 
(96%)CONDITIONAL 4174/8152 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7637/14041 
(54%)CONDITIONAL 4085/8907 (46%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2270/7564 
(30%)CONDITIONAL 914/4407 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/833 (51%)CONDITIONAL 
318/719 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1762/3781 
(47%)CONDITIONAL 1258/3434 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 714/1155 (62%)CONDITIONAL 
378/753 (50%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 382/594 (64%)CONDITIONAL 
284/580 (49%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
329/410 (80%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2668/10603 
(25%)CONDITIONAL 1309/6792 (19%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 68 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/68/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 22 May 2016 17:21:12 +
Build duration: 8 min 55 sec

CHANGE SET
Revision a60c6c437067c9daa2b5bbe6638ba4080342dacf by David Faure: (Add 
KProtocolInfo::archiveMimetypes(), discussed in)
  change: edit src/core/kprotocolinfo.cpp
  change: edit src/core/kprotocolinfo.h


JUNIT RESULTS

Name: (root) Failed: 3 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 
50 test(s)Failed: TestSuite.kiocore-jobtestFailed: 
TestSuite.kiowidgets-clipboardupdatertestFailed: TestSuite.testtrash

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 260/338 (77%)CLASSES 260/338 (77%)LINE 26739/50633 
(53%)CONDITIONAL 14902/37399 (40%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7509/7837 
(96%)CONDITIONAL 4167/8128 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7677/14041 
(55%)CONDITIONAL 4153/8907 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2267/7564 
(30%)CONDITIONAL 914/4407 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 430/833 (52%)CONDITIONAL 
320/719 (45%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1754/3781 
(46%)CONDITIONAL 1249/3434 (36%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 723/1155 (63%)CONDITIONAL 
384/753 (51%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 680/762 (89%)CONDITIONAL 
432/912 (47%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 387/594 (65%)CONDITIONAL 
289/580 (50%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
329/410 (80%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2666/10603 
(25%)CONDITIONAL 1305/6792 (19%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127912: Add 2 methods to gain more info about a mimetype or protocol

[David Faure]

> On May 14, 2016, 1:59 p.m., David Faure wrote:
> > But how is the app supposed to then choose which protocol to use?
> > 
> > If it needs its own setting for the preferred kioslave, then what's the 
> > point of the query that returns a list?
> > 
> > In other words, if you know you want to prefer krarc, why not just query 
> > whether krarc is available and use it if yes?
> 
> Martin Kostolný wrote:
> I'm sorry, it is very well possible that I don't know the required API 
> for these queries. It is as You said: basically I need to test whether 
> krarc:/ is available and I also need to test if given mimetype can be handled 
> by krarc protocol. Is there a way to achieve that with current KIO API? 
> Thanks!

To find if krarc is available, use KProtocolInfo::isKnownProtocol("krarc").

To find which archive mimetypes "krarc" can support, hmm, there was no API for 
it, so I just added it. KProtocolInfo::archiveMimeTypes("krarc"), requires KF 
5.23 (released next month).
See http://commits.kde.org/kio/a60c6c437067c9daa2b5bbe6638ba4080342dacf


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127912/#review95467
---


On May 14, 2016, 11:38 a.m., Martin Kostolný wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127912/
> ---
> 
> (Updated May 14, 2016, 11:38 a.m.)
> 
> 
> Review request for KDE Frameworks, Krusader, David Edmundson, David Faure, 
> and Marco Martin.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> KProtocolManager has a method called protocolForArchiveMimetype. It gives one 
> protocol for given mimetype even if there exist more then one protocol 
> capable of handling this mimetype.
> 
> I suggest adding a method called protocolsForArchiveMimetype (note the "s") 
> which would give us all protocols that can handle given mimetype. I also 
> suggest to add a method for giving all archive mimetypes for given protocol.
> 
> This request is based on a potential need of some apps to prioritize one 
> protocol over others (specifically krarc:/ from Krusader over other 
> archive-handling protocols).
> 
> 
> Diffs
> -
> 
>   src/core/kprotocolmanager.h 13b8c07 
>   src/core/kprotocolmanager.cpp 9a0a96f 
> 
> Diff: https://git.reviewboard.kde.org/r/127912/diff/
> 
> 
> Testing
> ---
> 
> I've tested both methods through Krusader code. Partially covered in this 
> phabricator task: https://phabricator.kde.org/T2401
> 
> 
> Thanks,
> 
> Martin Kostolný
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

[René J . V . Bertin]

> On May 17, 2016, 4:37 p.m., Martin Gräßlin wrote:
> > given that Plasma integration got removed I suggest to create a dedicated 
> > osx-integration repository for it as well.
> 
> René J.V. Bertin wrote:
> I quite like the way things are, but yes, I've played with that idea. 
> 
> I guess I can simply fork `frameworkintegration`, change the project name 
> in the toplevel CMake file and strip everything except for the platformtheme.
> 
> How does this work from that point onwards?
> 
> Martin Gräßlin wrote:
> > I guess I can simply fork frameworkintegration, change the project name 
> in the toplevel CMake file and strip everything except for the platformtheme.
> 
> That's kind of how I did it for plasma-integration with git filter-tree.
> 
> > How does this work from that point onwards?
> 
> My suggestion would be to create something like an "OSX integration" 
> project in the metadata and have then all your repositories grouped there 
> including the new platform theme.
> 
> René J.V. Bertin wrote:
> This is something I'm completely new to; what metadata are we talking 
> about here?
> Also, can anyone with commit access to existing repositories also create 
> new ones on the server, and in what category would you suggest putting this?
> 
> Boudhayan Gupta wrote:
> For now, start with a scratch repo. Sysadmin will take care of the rest 
> for you.
> 
> René J.V. Bertin wrote:
> As I said, creating or proposing a new KDE package/repository is 
> completely new for me, even that instruction is still ambiguous. I take it 
> you're not talking about a scratch repo that exists only on one of my disks, 
> possibly not even on a remote mirror like github, but rather something that 
> would alert the sysadmins who will then take the appropriate actions?
> 
> I guess I should look through the developer/contributor instructions 
> again, I most certainly skipped this level of information when I first (and 
> last...) read that documentation.
> 
> Elvis Angelaccio wrote:
> Here you can find the instructions to create a scratch repo: 
> https://community.kde.org/Sysadmin/GitKdeOrgManual#Personal_scratch_repositories
> 
> René J.V. Bertin wrote:
> ah, great, thanks. Looks exactly what I need except that it doesn't 
> appear to say anything about the metadata Martin mentions. But it's a start :)
> 
> Martin Gräßlin wrote:
> The metadata is in kde-build-metadata.git 
> (https://quickgit.kde.org/?p=kde-build-metadata.git )
> 
> René J.V. Bertin wrote:
> Right, that metadata :)
> Seems that will be among the last things to update; I don't see any 
> project from scratch mentioned in that repo.
> 
> I've begun setting up an OS X Integration project. For some reason my git 
> install lacks the filter-tree command so I've gone the manual route copying 
> the frameworkintegration repo with the patch from this RR. I've removed all 
> files that shouldn't be included, changed names etc (haven't pruned the 
> dependencies yet), and committed to `scratch/rjvbb/osx-integration`. Very 
> much a work-in-progress; I'll have to update my own install (and "ports" 
> tree) to 5.22 before I can check building (though I presume it *should* build 
> against 5.20.0 if I downgrade the dependency requirement).
> 
> I just realise this gives the repo a commit history that's a *lot* larger 
> than the current code base. Is there something I should and could do about 
> that?
> 
> David Faure wrote:
> It's `git filter-branch` (not filter-tree). You should use it to avoid 
> the history of the stuff from other subdirs.

Dang, it looks like it's too late. I've tried

`git filter-branch --index-filter 'git rm --cached --ignore-unmatch -r -f 
src/kstyle src/integrationplugin src/infopage' HEAD`

and that appears to rewrite lots of things ... without actually making the 
output of `git log` any shorter or the size of `.git` any smaller.


- René J.V.


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126198/#review95538
---


On May 16, 2016, 9:49 p.m., René J.V. Bertin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126198/
> ---
> 
> (Updated May 16, 2016, 9:49 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X, KDE Frameworks, Plasma, and 
> Valorie Zimmerman.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> The KdePlatformTheme plugin can be enabled on OS X with a minimal patch to 
> Qt5; all that is required is to include the `qgenericunixservices` and 
> `qgenericunixthemes` components in the build, and to append `"kde"` to the 
> list returned by 

Re: Review Request 127988: [runtime] Link KF5::Crash in the binary not in the private library

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127988/#review95703
---


Ship it!




Ship It!

- David Edmundson


On May 22, 2016, 3:36 p.m., Martin Gräßlin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127988/
> ---
> 
> (Updated May 22, 2016, 3:36 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kglobalaccel
> 
> 
> Description
> ---
> 
> KCrash is only used by the kglobalacceld5 binary, but not in the
> private library. So don't link it in the library as otherwise it's
> get pulled into applications using the private library, but don't
> want to use KCrash (example kwin_wayland).
> 
> 
> Diffs
> -
> 
>   src/runtime/CMakeLists.txt 50f64935657fda61b246610246977c19c6563147 
> 
> Diff: https://git.reviewboard.kde.org/r/127988/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Martin Gräßlin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127988: [runtime] Link KF5::Crash in the binary not in the private library

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127988/
---

Review request for KDE Frameworks.


Repository: kglobalaccel


Description
---

KCrash is only used by the kglobalacceld5 binary, but not in the
private library. So don't link it in the library as otherwise it's
get pulled into applications using the private library, but don't
want to use KCrash (example kwin_wayland).


Diffs
-

  src/runtime/CMakeLists.txt 50f64935657fda61b246610246977c19c6563147 

Diff: https://git.reviewboard.kde.org/r/127988/diff/


Testing
---


Thanks,

Martin Gräßlin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

kptyprocesstest is still flaky

[David Faure]

The CI for KF5 is now all green except for kpty which is still flaky.

https://build.kde.org/view/Frameworks%20kf5-qt5/job/kpty%20master%20stable-kf5-qt5/42/PLATFORM=Linux,compiler=gcc/testReport/junit/%28root%29/TestSuite/kptyprocesstest/

Same failure as a few years ago:

FAIL!  : KPtyProcessTest::test_pty_signals() Compared values are not the same
   Actual   (QLatin1String(log)) : 
"<<<>bla\r\n$\n>foobar\r\n$\n!\n<>fooish\r\n$\n>bar\r\n$\n!\n<|$\n"
   Expected (QLatin1String(want)): 
"<>bla\r\n$\n!\nfoobar\r\n$\n!\n<>fooish\r\n$\n>bar\r\n$\n!\n<|$\n"
   Loc: 
[/home/jenkins/sources/kpty/stable-kf5-qt5/autotests/kptyprocesstest.cpp(201)]

I can reproduce it locally if I run the test in a loop.

Is this worth fixing, or should we just disable the test?
Ossi?

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kdelibs4support master stable-kf5-qt5 » Linux,gcc - Build # 43 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kdelibs4support%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/43/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 22 May 2016 13:13:09 +
Build duration: 3 min 47 sec

CHANGE SET
Revision 1738011ea72bd3466392fd470b03596a864e4eab by yurchor: (Update links 
using new Phabricator address scheme)
  change: edit docs/kdebugdialog5/index.docbook


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 
39 test(s)Failed: TestSuite.globalcleanuptest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 4/7 (57%)FILES 160/268 (60%)CLASSES 160/268 (60%)LINE 21694/42752 
(51%)CONDITIONAL 14666/36445 (40%)

By packages
  
autotests
FILES 63/63 (100%)CLASSES 63/63 (100%)LINE 11519/11768 
(98%)CONDITIONAL 8481/16820 (50%)
src.kdecore
FILES 75/94 (80%)CLASSES 75/94 (80%)LINE 9221/16840 
(55%)CONDITIONAL 5722/11781 (49%)
src.kdeui
FILES 18/70 (26%)CLASSES 18/70 (26%)LINE 938/9815 
(10%)CONDITIONAL 460/5673 (8%)
src.kio
FILES 4/27 (15%)CLASSES 4/27 (15%)LINE 16/2396 (1%)CONDITIONAL 
3/1226 (0%)
src.kparts
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/26 (0%)CONDITIONAL 0/14 
(0%)
src.kssl
FILES 0/8 (0%)CLASSES 0/8 (0%)LINE 0/1708 (0%)CONDITIONAL 0/836 
(0%)
src.solid
FILES 0/5 (0%)CLASSES 0/5 (0%)LINE 0/199 (0%)CONDITIONAL 0/95 
(0%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kross master kf5-qt5 » Linux,gcc - Build # 67 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kross%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/67/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 22 May 2016 12:55:16 +
Build duration: 1 min 14 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 129/137 
(94%)CONDITIONAL 65/98 (66%)

By packages
  
autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 56/56 (100%)CONDITIONAL 
33/50 (66%)
src.core
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 73/81 (90%)CONDITIONAL 
32/48 (67%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kross master kf5-qt5 » Linux,gcc - Build # 67 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kross%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/67/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 22 May 2016 12:55:16 +
Build duration: 1 min 14 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 129/137 
(94%)CONDITIONAL 65/98 (66%)

By packages
  
autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 56/56 (100%)CONDITIONAL 
33/50 (66%)
src.core
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 73/81 (90%)CONDITIONAL 
32/48 (67%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kross master stable-kf5-qt5 » Linux,gcc - Build # 64 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kross%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/64/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 22 May 2016 12:52:56 +
Build duration: 1 min 8 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 129/137 
(94%)CONDITIONAL 65/98 (66%)

By packages
  
autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 56/56 (100%)CONDITIONAL 
33/50 (66%)
src.core
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 73/81 (90%)CONDITIONAL 
32/48 (67%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kross master stable-kf5-qt5 » Linux,gcc - Build # 64 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kross%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/64/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 22 May 2016 12:52:56 +
Build duration: 1 min 8 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 129/137 
(94%)CONDITIONAL 65/98 (66%)

By packages
  
autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 56/56 (100%)CONDITIONAL 
33/50 (66%)
src.core
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 73/81 (90%)CONDITIONAL 
32/48 (67%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 54 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/54/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 22 May 2016 12:20:49 +
Build duration: 2 min 53 sec

CHANGE SET
Revision f4b9c9263ee0d63561b764c26c65fe8ed5d626bc by David Faure: (The CI says 
KDirWatch sometimes only emits dirty(), not created().)
  change: edit src/sycoca/ksycoca.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
10 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5465/7983 
(68%)CONDITIONAL 2962/6140 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1443/1529 
(94%)CONDITIONAL 891/1768 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1761/3042 
(58%)CONDITIONAL 757/1888 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2045/2799 
(73%)CONDITIONAL 1229/2056 (60%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 54 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/54/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 22 May 2016 12:20:49 +
Build duration: 2 min 53 sec

CHANGE SET
Revision f4b9c9263ee0d63561b764c26c65fe8ed5d626bc by David Faure: (The CI says 
KDirWatch sometimes only emits dirty(), not created().)
  change: edit src/sycoca/ksycoca.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
10 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5465/7983 
(68%)CONDITIONAL 2962/6140 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1443/1529 
(94%)CONDITIONAL 891/1768 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1761/3042 
(58%)CONDITIONAL 757/1888 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2045/2799 
(73%)CONDITIONAL 1229/2056 (60%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 49 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/49/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 22 May 2016 12:20:49 +
Build duration: 1 min 55 sec

CHANGE SET
Revision f4b9c9263ee0d63561b764c26c65fe8ed5d626bc by David Faure: (The CI says 
KDirWatch sometimes only emits dirty(), not created().)
  change: edit src/sycoca/ksycoca.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
10 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5457/7983 
(68%)CONDITIONAL 2947/6140 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1441/1529 
(94%)CONDITIONAL 881/1768 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1761/3042 
(58%)CONDITIONAL 756/1888 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2039/2799 
(73%)CONDITIONAL 1225/2056 (60%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 49 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/49/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 22 May 2016 12:20:49 +
Build duration: 1 min 55 sec

CHANGE SET
Revision f4b9c9263ee0d63561b764c26c65fe8ed5d626bc by David Faure: (The CI says 
KDirWatch sometimes only emits dirty(), not created().)
  change: edit src/sycoca/ksycoca.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
10 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5457/7983 
(68%)CONDITIONAL 2947/6140 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1441/1529 
(94%)CONDITIONAL 881/1768 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1761/3042 
(58%)CONDITIONAL 756/1888 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2039/2799 
(73%)CONDITIONAL 1225/2056 (60%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127971: [KToolBar] Disable toggleViewAction() when actions/options_show_toolbar is restricted

[David Faure]

> On May 22, 2016, 11:49 a.m., David Faure wrote:
> > Looks fine to me, except for the reasoning in the commit log. It's 
> > perfectly fine to reimplement an existing virtual method from a base class 
> > into a derived class, this doesn't break ABI.
> 
> Kai Uwe Broulik wrote:
> But Abi wiki page says you cannot if it's a "non leaf class ie. one that 
> is meant to be subclassed" which KMainWindow is. Regardless of whether we 
> provide our own menu the action should be disabled either way though.

You can, it's just that existing apps might not call your reimplementation 
until they get recompiled too. Which would only mean they don't get the fix, in 
this particular case, it doesn't mean they would get a new breakage. But yeah, 
orthogonal discussion. Just don't remove this part from the commit log, if it's 
irrelevant anyway ;-)


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127971/#review95698
---


On May 19, 2016, 9:37 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127971/
> ---
> 
> (Updated May 19, 2016, 9:37 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kxmlgui
> 
> 
> Description
> ---
> 
> While KXmlGui makes sure to prevent the user from hiding toolbars when not 
> allowed, right-clicking an empty space in a QMainWindow, such as the menu 
> bar, will yield a menu created by Qt, which knows nothing about Kiosk 
> restrictions, listing all toolbar toggle actions of this window.
> 
> 
> Diffs
> -
> 
>   autotests/ktoolbar_unittest.cpp d6c1e05 
>   src/ktoolbar.cpp 8fcb9cb 
> 
> Diff: https://git.reviewboard.kde.org/r/127971/diff/
> 
> 
> Testing
> ---
> 
> Comes with a unittest.
> 
> I can no longer hide the main toolbar in Dolphin or Gwenview when this action 
> is restricted by simply right-clicking the menu bar.
> 
> 
> File Attachments
> 
> 
> The Menu
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/05/19/076745b4-03a2-400f-9506-46999d4ce1e1__toolbartoggle.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 44 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/44/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 22 May 2016 11:54:22 +
Build duration: 5 min 39 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 
39 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 4/7 (57%)FILES 161/269 (60%)CLASSES 161/269 (60%)LINE 21707/42765 
(51%)CONDITIONAL 14666/36445 (40%)

By packages
  
autotests
FILES 64/64 (100%)CLASSES 64/64 (100%)LINE 11531/11780 
(98%)CONDITIONAL 8481/16820 (50%)
src.kdecore
FILES 75/94 (80%)CLASSES 75/94 (80%)LINE 9221/16840 
(55%)CONDITIONAL 5722/11781 (49%)
src.kdeui
FILES 18/70 (26%)CLASSES 18/70 (26%)LINE 939/9816 
(10%)CONDITIONAL 460/5673 (8%)
src.kio
FILES 4/27 (15%)CLASSES 4/27 (15%)LINE 16/2396 (1%)CONDITIONAL 
3/1226 (0%)
src.kparts
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/26 (0%)CONDITIONAL 0/14 
(0%)
src.kssl
FILES 0/8 (0%)CLASSES 0/8 (0%)LINE 0/1708 (0%)CONDITIONAL 0/836 
(0%)
src.solid
FILES 0/5 (0%)CLASSES 0/5 (0%)LINE 0/199 (0%)CONDITIONAL 0/95 
(0%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 44 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/44/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 22 May 2016 11:54:22 +
Build duration: 5 min 39 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 
39 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 4/7 (57%)FILES 161/269 (60%)CLASSES 161/269 (60%)LINE 21707/42765 
(51%)CONDITIONAL 14666/36445 (40%)

By packages
  
autotests
FILES 64/64 (100%)CLASSES 64/64 (100%)LINE 11531/11780 
(98%)CONDITIONAL 8481/16820 (50%)
src.kdecore
FILES 75/94 (80%)CLASSES 75/94 (80%)LINE 9221/16840 
(55%)CONDITIONAL 5722/11781 (49%)
src.kdeui
FILES 18/70 (26%)CLASSES 18/70 (26%)LINE 939/9816 
(10%)CONDITIONAL 460/5673 (8%)
src.kio
FILES 4/27 (15%)CLASSES 4/27 (15%)LINE 16/2396 (1%)CONDITIONAL 
3/1226 (0%)
src.kparts
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/26 (0%)CONDITIONAL 0/14 
(0%)
src.kssl
FILES 0/8 (0%)CLASSES 0/8 (0%)LINE 0/1708 (0%)CONDITIONAL 0/836 
(0%)
src.solid
FILES 0/5 (0%)CLASSES 0/5 (0%)LINE 0/199 (0%)CONDITIONAL 0/95 
(0%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127971: [KToolBar] Disable toggleViewAction() when actions/options_show_toolbar is restricted

[Kai Uwe Broulik]

> On Mai 22, 2016, 11:49 vorm., David Faure wrote:
> > Looks fine to me, except for the reasoning in the commit log. It's 
> > perfectly fine to reimplement an existing virtual method from a base class 
> > into a derived class, this doesn't break ABI.

But Abi wiki page says you cannot if it's a "non leaf class ie. one that is 
meant to be subclassed" which KMainWindow is. Regardless of whether we provide 
our own menu the action should be disabled either way though.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127971/#review95698
---


On Mai 19, 2016, 9:37 nachm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127971/
> ---
> 
> (Updated Mai 19, 2016, 9:37 nachm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kxmlgui
> 
> 
> Description
> ---
> 
> While KXmlGui makes sure to prevent the user from hiding toolbars when not 
> allowed, right-clicking an empty space in a QMainWindow, such as the menu 
> bar, will yield a menu created by Qt, which knows nothing about Kiosk 
> restrictions, listing all toolbar toggle actions of this window.
> 
> 
> Diffs
> -
> 
>   autotests/ktoolbar_unittest.cpp d6c1e05 
>   src/ktoolbar.cpp 8fcb9cb 
> 
> Diff: https://git.reviewboard.kde.org/r/127971/diff/
> 
> 
> Testing
> ---
> 
> Comes with a unittest.
> 
> I can no longer hide the main toolbar in Dolphin or Gwenview when this action 
> is restricted by simply right-clicking the menu bar.
> 
> 
> File Attachments
> 
> 
> The Menu
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/05/19/076745b4-03a2-400f-9506-46999d4ce1e1__toolbartoggle.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kdelibs4support master stable-kf5-qt5 » Linux,gcc - Build # 42 - Still unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kdelibs4support%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/42/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 22 May 2016 11:54:14 +
Build duration: 3 min 53 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 
39 test(s)Failed: TestSuite.globalcleanuptest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 4/7 (57%)FILES 160/268 (60%)CLASSES 160/268 (60%)LINE 21694/42752 
(51%)CONDITIONAL 14666/36445 (40%)

By packages
  
autotests
FILES 63/63 (100%)CLASSES 63/63 (100%)LINE 11519/11768 
(98%)CONDITIONAL 8481/16820 (50%)
src.kdecore
FILES 75/94 (80%)CLASSES 75/94 (80%)LINE 9221/16840 
(55%)CONDITIONAL 5722/11781 (49%)
src.kdeui
FILES 18/70 (26%)CLASSES 18/70 (26%)LINE 938/9815 
(10%)CONDITIONAL 460/5673 (8%)
src.kio
FILES 4/27 (15%)CLASSES 4/27 (15%)LINE 16/2396 (1%)CONDITIONAL 
3/1226 (0%)
src.kparts
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/26 (0%)CONDITIONAL 0/14 
(0%)
src.kssl
FILES 0/8 (0%)CLASSES 0/8 (0%)LINE 0/1708 (0%)CONDITIONAL 0/836 
(0%)
src.solid
FILES 0/5 (0%)CLASSES 0/5 (0%)LINE 0/199 (0%)CONDITIONAL 0/95 
(0%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

[David Faure]

> On May 17, 2016, 2:37 p.m., Martin Gräßlin wrote:
> > given that Plasma integration got removed I suggest to create a dedicated 
> > osx-integration repository for it as well.
> 
> René J.V. Bertin wrote:
> I quite like the way things are, but yes, I've played with that idea. 
> 
> I guess I can simply fork `frameworkintegration`, change the project name 
> in the toplevel CMake file and strip everything except for the platformtheme.
> 
> How does this work from that point onwards?
> 
> Martin Gräßlin wrote:
> > I guess I can simply fork frameworkintegration, change the project name 
> in the toplevel CMake file and strip everything except for the platformtheme.
> 
> That's kind of how I did it for plasma-integration with git filter-tree.
> 
> > How does this work from that point onwards?
> 
> My suggestion would be to create something like an "OSX integration" 
> project in the metadata and have then all your repositories grouped there 
> including the new platform theme.
> 
> René J.V. Bertin wrote:
> This is something I'm completely new to; what metadata are we talking 
> about here?
> Also, can anyone with commit access to existing repositories also create 
> new ones on the server, and in what category would you suggest putting this?
> 
> Boudhayan Gupta wrote:
> For now, start with a scratch repo. Sysadmin will take care of the rest 
> for you.
> 
> René J.V. Bertin wrote:
> As I said, creating or proposing a new KDE package/repository is 
> completely new for me, even that instruction is still ambiguous. I take it 
> you're not talking about a scratch repo that exists only on one of my disks, 
> possibly not even on a remote mirror like github, but rather something that 
> would alert the sysadmins who will then take the appropriate actions?
> 
> I guess I should look through the developer/contributor instructions 
> again, I most certainly skipped this level of information when I first (and 
> last...) read that documentation.
> 
> Elvis Angelaccio wrote:
> Here you can find the instructions to create a scratch repo: 
> https://community.kde.org/Sysadmin/GitKdeOrgManual#Personal_scratch_repositories
> 
> René J.V. Bertin wrote:
> ah, great, thanks. Looks exactly what I need except that it doesn't 
> appear to say anything about the metadata Martin mentions. But it's a start :)
> 
> Martin Gräßlin wrote:
> The metadata is in kde-build-metadata.git 
> (https://quickgit.kde.org/?p=kde-build-metadata.git )
> 
> René J.V. Bertin wrote:
> Right, that metadata :)
> Seems that will be among the last things to update; I don't see any 
> project from scratch mentioned in that repo.
> 
> I've begun setting up an OS X Integration project. For some reason my git 
> install lacks the filter-tree command so I've gone the manual route copying 
> the frameworkintegration repo with the patch from this RR. I've removed all 
> files that shouldn't be included, changed names etc (haven't pruned the 
> dependencies yet), and committed to `scratch/rjvbb/osx-integration`. Very 
> much a work-in-progress; I'll have to update my own install (and "ports" 
> tree) to 5.22 before I can check building (though I presume it *should* build 
> against 5.20.0 if I downgrade the dependency requirement).
> 
> I just realise this gives the repo a commit history that's a *lot* larger 
> than the current code base. Is there something I should and could do about 
> that?

It's `git filter-branch` (not filter-tree). You should use it to avoid the 
history of the stuff from other subdirs.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126198/#review95538
---


On May 16, 2016, 7:49 p.m., René J.V. Bertin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126198/
> ---
> 
> (Updated May 16, 2016, 7:49 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X, KDE Frameworks, Plasma, and 
> Valorie Zimmerman.
> 
> 
> Repository: frameworkintegration
> 
> 
> Description
> ---
> 
> The KdePlatformTheme plugin can be enabled on OS X with a minimal patch to 
> Qt5; all that is required is to include the `qgenericunixservices` and 
> `qgenericunixthemes` components in the build, and to append `"kde"` to the 
> list returned by `QCocoaIntegration::themeNames()` for instance under the 
> condition that `KDE_SESSION_VERSION` is set to a suitable value in the 
> environment.
> 
> This will allow KF5 and Qt5 applications to use the theme selected through 
> KDE if FrameworkIntegration is installed and KDE_SESSION_VERSION is set, 
> which seems like a sufficiently specific set of conditions that 

Re: Review Request 127971: [KToolBar] Disable toggleViewAction() when actions/options_show_toolbar is restricted

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127971/#review95698
---


Fix it, then Ship it!




Looks fine to me, except for the reasoning in the commit log. It's perfectly 
fine to reimplement an existing virtual method from a base class into a derived 
class, this doesn't break ABI.


autotests/ktoolbar_unittest.cpp (line 657)


better written as QVERIFY(!...)


- David Faure


On May 19, 2016, 9:37 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127971/
> ---
> 
> (Updated May 19, 2016, 9:37 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kxmlgui
> 
> 
> Description
> ---
> 
> While KXmlGui makes sure to prevent the user from hiding toolbars when not 
> allowed, right-clicking an empty space in a QMainWindow, such as the menu 
> bar, will yield a menu created by Qt, which knows nothing about Kiosk 
> restrictions, listing all toolbar toggle actions of this window.
> 
> 
> Diffs
> -
> 
>   autotests/ktoolbar_unittest.cpp d6c1e05 
>   src/ktoolbar.cpp 8fcb9cb 
> 
> Diff: https://git.reviewboard.kde.org/r/127971/diff/
> 
> 
> Testing
> ---
> 
> Comes with a unittest.
> 
> I can no longer hide the main toolbar in Dolphin or Gwenview when this action 
> is restricted by simply right-clicking the menu bar.
> 
> 
> File Attachments
> 
> 
> The Menu
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/05/19/076745b4-03a2-400f-9506-46999d4ce1e1__toolbartoggle.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kjsembed master stable-kf5-qt5 » Linux,gcc - Build # 35 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kjsembed%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/35/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 22 May 2016 11:44:57 +
Build duration: 37 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  ___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kjsembed master kf5-qt5 » Linux,gcc - Build # 35 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kjsembed%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/35/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 22 May 2016 11:43:37 +
Build duration: 49 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  ___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kjsembed master kf5-qt5 » Linux,gcc - Build # 35 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kjsembed%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/35/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 22 May 2016 11:43:37 +
Build duration: 49 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  ___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kjsembed master stable-kf5-qt5 » Linux,gcc - Build # 35 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kjsembed%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/35/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 22 May 2016 11:44:57 +
Build duration: 37 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  ___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kross master kf5-qt5 » Linux,gcc - Build # 66 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kross%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/66/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 22 May 2016 11:07:47 +
Build duration: 24 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kross master kf5-qt5 » Linux,gcc - Build # 65 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kross%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/65/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 22 May 2016 11:06:21 +
Build duration: 25 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kross master stable-kf5-qt5 » Linux,gcc - Build # 63 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kross%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/63/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 22 May 2016 10:58:02 +
Build duration: 29 sec

CHANGE SET
Revision 7f401e900daf95192858cd16ea77b0ca45211c5c by olivier: (update 
metainfo.yaml for new kapidox version)
  change: edit metainfo.yaml
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kross master kf5-qt5 » Linux,gcc - Build # 64 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kross%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/64/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 22 May 2016 10:57:13 +
Build duration: 38 sec

CHANGE SET
Revision 7f401e900daf95192858cd16ea77b0ca45211c5c by olivier: (update 
metainfo.yaml for new kapidox version)
  change: edit metainfo.yaml
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kjsembed master stable-kf5-qt5 » Linux,gcc - Build # 34 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kjsembed%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/34/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 22 May 2016 10:46:05 +
Build duration: 23 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kjsembed master kf5-qt5 » Linux,gcc - Build # 34 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kjsembed%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/34/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 22 May 2016 10:45:45 +
Build duration: 22 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 53 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/53/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 22 May 2016 10:38:37 +
Build duration: 2 min 4 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.kservicetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5462/7983 
(68%)CONDITIONAL 2956/6142 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1441/1529 
(94%)CONDITIONAL 886/1768 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1761/3042 
(58%)CONDITIONAL 755/1888 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2044/2799 
(73%)CONDITIONAL 1230/2058 (60%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kdelibs4support master stable-kf5-qt5 » Linux,gcc - Build # 41 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kdelibs4support%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/41/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 22 May 2016 10:39:37 +
Build duration: 38 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kpty master kf5-qt5 » Linux,gcc - Build # 42 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kpty%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/42/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 22 May 2016 10:36:49 +
Build duration: 49 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 432/557 
(78%)CONDITIONAL 125/243 (51%)

By packages
  
autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 111/111 
(100%)CONDITIONAL 38/72 (53%)
src
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 321/446 (72%)CONDITIONAL 
87/171 (51%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kpty master kf5-qt5 » Linux,gcc - Build # 42 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kpty%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/42/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 22 May 2016 10:36:49 +
Build duration: 49 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 432/557 
(78%)CONDITIONAL 125/243 (51%)

By packages
  
autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 111/111 
(100%)CONDITIONAL 38/72 (53%)
src
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 321/446 (72%)CONDITIONAL 
87/171 (51%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kjsembed master stable-kf5-qt5 » Linux,gcc - Build # 33 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kjsembed%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/33/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 22 May 2016 10:36:29 +
Build duration: 18 sec

CHANGE SET
Revision 3dbbeb869638c0ba68c206444b00dca9a516f58b by olivier: (update 
metainfo.yaml for new kapidox version)
  change: edit metainfo.yaml
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kjsembed master kf5-qt5 » Linux,gcc - Build # 33 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kjsembed%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/33/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 22 May 2016 10:36:00 +
Build duration: 21 sec

CHANGE SET
Revision 3dbbeb869638c0ba68c206444b00dca9a516f58b by olivier: (update 
metainfo.yaml for new kapidox version)
  change: edit metainfo.yaml
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kdesignerplugin master kf5-qt5 » Linux,gcc - Build # 23 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kdesignerplugin%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/23/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 22 May 2016 10:22:14 +
Build duration: 27 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kdesignerplugin master stable-kf5-qt5 » Linux,gcc - Build # 21 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kdesignerplugin%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/21/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 22 May 2016 10:19:08 +
Build duration: 31 sec

CHANGE SET
No changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kdelibs4support master stable-kf5-qt5 » Linux,gcc - Build # 40 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kdelibs4support%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/40/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 22 May 2016 10:18:47 +
Build duration: 33 sec

CHANGE SET
Revision abe5f9c94012d1476d86865c4b30c08331cf186b by olivier: (update 
metainfo.yaml for new kapidox version)
  change: edit metainfo.yaml
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 43 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/43/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 22 May 2016 10:18:16 +
Build duration: 29 sec

CHANGE SET
Revision abe5f9c94012d1476d86865c4b30c08331cf186b by olivier: (update 
metainfo.yaml for new kapidox version)
  change: edit metainfo.yaml
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kpty master kf5-qt5 » Linux,gcc - Build # 41 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kpty%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/41/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 22 May 2016 10:17:54 +
Build duration: 56 sec

CHANGE SET
Revision f5558b5971dbaf536bdbe190aaadd5d33f1364b8 by olivier: (update 
metainfo.yaml for new kapidox version)
  change: edit metainfo.yaml


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 
test(s)Failed: TestSuite.kptyprocesstest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 432/557 
(78%)CONDITIONAL 125/243 (51%)

By packages
  
autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 111/111 
(100%)CONDITIONAL 38/72 (53%)
src
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 321/446 (72%)CONDITIONAL 
87/171 (51%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 58 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/58/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Sun, 22 May 2016 10:16:42 +
Build duration: 5 min 30 sec

CHANGE SET
Revision 01ba27db392cc82597e00fbcaf9db83c67c6dc8d by olivier: (update 
metainfo.yaml for new kapidox version)
  change: edit metainfo.yaml


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 
13 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 8/8 (100%)FILES 74/111 (67%)CLASSES 74/111 (67%)LINE 4371/11261 
(39%)CONDITIONAL 2277/8377 (27%)

By packages
  
autotests
FILES 24/24 (100%)CLASSES 24/24 (100%)LINE 881/942 
(94%)CONDITIONAL 569/1134 (50%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 545/1847 
(30%)CONDITIONAL 202/1132 (18%)
src.plasma
FILES 14/20 (70%)CLASSES 14/20 (70%)LINE 1666/3628 
(46%)CONDITIONAL 948/2738 (35%)
src.plasma.private
FILES 15/24 (63%)CLASSES 15/24 (63%)LINE 900/1721 
(52%)CONDITIONAL 403/1006 (40%)
src.plasma.scripting
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 37/181 (20%)CONDITIONAL 
14/106 (13%)
src.plasmaquick
FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 300/1671 
(18%)CONDITIONAL 133/1277 (10%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)
src.scriptengines.qml.plasmoid
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1158 (1%)CONDITIONAL 
2/962 (0%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 58 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/58/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Sun, 22 May 2016 10:16:42 +
Build duration: 5 min 30 sec

CHANGE SET
Revision 01ba27db392cc82597e00fbcaf9db83c67c6dc8d by olivier: (update 
metainfo.yaml for new kapidox version)
  change: edit metainfo.yaml


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 
13 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 8/8 (100%)FILES 74/111 (67%)CLASSES 74/111 (67%)LINE 4371/11261 
(39%)CONDITIONAL 2277/8377 (27%)

By packages
  
autotests
FILES 24/24 (100%)CLASSES 24/24 (100%)LINE 881/942 
(94%)CONDITIONAL 569/1134 (50%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 545/1847 
(30%)CONDITIONAL 202/1132 (18%)
src.plasma
FILES 14/20 (70%)CLASSES 14/20 (70%)LINE 1666/3628 
(46%)CONDITIONAL 948/2738 (35%)
src.plasma.private
FILES 15/24 (63%)CLASSES 15/24 (63%)LINE 900/1721 
(52%)CONDITIONAL 403/1006 (40%)
src.plasma.scripting
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 37/181 (20%)CONDITIONAL 
14/106 (13%)
src.plasmaquick
FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 300/1671 
(18%)CONDITIONAL 133/1277 (10%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)
src.scriptengines.qml.plasmoid
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1158 (1%)CONDITIONAL 
2/962 (0%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127747: Create a new script that generate the documentation for all projects following the syntax I proposed

[Olivier Churlaud]

> On May 20, 2016, 3:50 a.m., Michael Pyne wrote:
> > I've looked at the code itself and it seems reasonable, so from that 
> > perspective and given the length of time there's been no -1's, I think it's 
> > safe to commit.
> > 
> > However you mentioned in the description that this isn't safe to commit to 
> > master. I have no clue how we generate apidox for KF5 and Plasma 5 so I'm 
> > not sure what you mean when you say we'd affect the currents script. What 
> > is your plan for integrating this without breaking the scripts? Is there 
> > work needed by others (sysadmin, EBN, etc.) to make apidox generation work 
> > with your patch committed? What's the action KDE developers must take after 
> > this, if any?
> 
> Olivier Churlaud wrote:
> Thank you for the review Michel. The only need will be to update the 
> metainfo.yml. I can do that for the frameworks if needed after commiting. Or 
> I can even do this before so that it doesn't break.
> 
> Commit plan:
> 1) update frameworks metainfo (they are back-compatibles but the *new* 
> script will break with the old metainfo.
> 2) commit in master
> 3) See if everything works as expected else correct.
> 4) Clean up the code and teach it new tricks ; Add other projects that 
> the frameworks.
> 
> Olivier Churlaud wrote:
> Oh and maybe the current folder containing the html pages should be 
> removed as well.
> 
> Olivier Churlaud wrote:
> I forgot something. The name of the script will change. So I have to 
> either see with a sysadmin to change the cronjob or overright the previous 
> one.
> 
> Ben Cooksley wrote:
> Please ping me on IRC and I can arrange access to api.kde.org.

@bcooksley: I pushed all modifications to the frameworks. Still to do (with 
you): Change the scriptname, check the cloned repos and merge my KApiDox branch 
in master. I'll ping you this week/tonight


- Olivier


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127747/#review95632
---


On April 25, 2016, 11:49 p.m., Olivier Churlaud wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127747/
> ---
> 
> (Updated April 25, 2016, 11:49 p.m.)
> 
> 
> Review request for KDE Frameworks, Albert Astals Cid, Alex Merry, Aurélien 
> Gâteau, and Allen Winter.
> 
> 
> Repository: kapidox
> 
> 
> Description
> ---
> 
> Keep in mind that it should not plainly replace kgenframeworks but be used by 
> all KDE projects. So in this proposition, the Frameworks are just one project 
> in others.
> 
> The code can be tested directly by checking the branch 
> `olivier/generate_all_repos`.
> 
> This MUST NOT be merged in master, because it will break the currents scripts 
> (see commit 3643dded7cf14a5634879e8e6e34be8840143d7e).
> 
> 
> Diffs
> -
> 
>   konqi_frameworks.png PRE-CREATION 
>   metainfo.yaml 4ff17c8 
>   metainfo_syntax.md PRE-CREATION 
>   src/kapidox/data/htmlresource/default_product.png PRE-CREATION 
>   src/kapidox/data/htmlresource/kde.css b864ef5 
>   src/kapidox/data/templates/doxygen2.html PRE-CREATION 
>   src/kapidox/data/templates/frontpage.html PRE-CREATION 
>   src/kapidox/data/templates/libinfo.html PRE-CREATION 
>   src/kapidox/data/templates/maintainers.html PRE-CREATION 
>   src/kapidox/data/templates/subgroup.html PRE-CREATION 
>   src/kapidox/generator.py 5b8ae40 
>   src/newkapidox.py PRE-CREATION 
>   src/notes PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127747/diff/
> 
> 
> Testing
> ---
> 
> Tested on various scenario cases.
> 
> 
> File Attachments
> 
> 
> This is an example of what I generated. (Threadweaver is duplicated and 
> modified to test different scenarios)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/04/25/2e4549e4-7c17-416c-9a72-b82d3bba18b3__doc.tar.gz
> 
> 
> Thanks,
> 
> Olivier Churlaud
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,All,gcc - Build # 26 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/26/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Sun, 22 May 2016 10:15:24 +
Build duration: 3 min 5 sec

CHANGE SET
Revision 2d2e0b01b578fc50d16fb46f1418e062459103e4 by olivier: (update 
metainfo.yaml for new kapidox version)
  change: edit metainfo.yaml


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.kwindowsystem-kmanagerselectiontest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 3/4 (75%)FILES 40/46 (87%)CLASSES 40/46 (87%)LINE 6644/8886 
(75%)CONDITIONAL 3683/6815 (54%)

By packages
  
autotests
FILES 13/13 (100%)CLASSES 13/13 (100%)LINE 2825/2896 
(98%)CONDITIONAL 1520/2909 (52%)
src
FILES 13/15 (87%)CLASSES 13/15 (87%)LINE 748/1400 
(53%)CONDITIONAL 307/692 (44%)
src.platforms.wayland
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/89 (0%)CONDITIONAL 0/2 (0%)
src.platforms.xcb
FILES 14/16 (88%)CLASSES 14/16 (88%)LINE 3071/4501 
(68%)CONDITIONAL 1856/3212 (58%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 48 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/48/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 22 May 2016 10:14:09 +
Build duration: 2 min 19 sec

CHANGE SET
Revision e948a39d1321881d8a115b5ac5606b5a2f50011a by olivier: (update 
metainfo.yaml for new kapidox version)
  change: edit metainfo.yaml


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.kservicetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5456/7982 
(68%)CONDITIONAL 2949/6140 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1441/1529 
(94%)CONDITIONAL 884/1768 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1761/3042 
(58%)CONDITIONAL 757/1888 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2038/2798 
(73%)CONDITIONAL 1223/2056 (59%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kpty master stable-kf5-qt5 » Linux,gcc - Build # 41 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kpty%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/41/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 22 May 2016 10:14:02 +
Build duration: 48 sec

CHANGE SET
Revision f5558b5971dbaf536bdbe190aaadd5d33f1364b8 by olivier: (update 
metainfo.yaml for new kapidox version)
  change: edit metainfo.yaml


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 432/557 
(78%)CONDITIONAL 125/243 (51%)

By packages
  
autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 111/111 
(100%)CONDITIONAL 38/72 (53%)
src
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 321/446 (72%)CONDITIONAL 
87/171 (51%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kpty master stable-kf5-qt5 » Linux,gcc - Build # 41 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kpty%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/41/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 22 May 2016 10:14:02 +
Build duration: 48 sec

CHANGE SET
Revision f5558b5971dbaf536bdbe190aaadd5d33f1364b8 by olivier: (update 
metainfo.yaml for new kapidox version)
  change: edit metainfo.yaml


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 432/557 
(78%)CONDITIONAL 125/243 (51%)

By packages
  
autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 111/111 
(100%)CONDITIONAL 38/72 (53%)
src
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 321/446 (72%)CONDITIONAL 
87/171 (51%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel