Re: KConfig compiler. GenerateProperties and Mutable.

2016-05-25 Thread Artem Fedoskin 
>>> We could also start with turning that into quint64, to already double
the number of possible settings, right? Easy short term fix.

Am I correct that with quint64 we will gain just 32 more additional unique
signal bit masks? The problem is that my config file has more than 300.

I managed to make mSettingsChanged QHash. This way we hold there
only non-modify signals. However, I encountered some other problems:

   1. Sometimes read function in Q_PROPERTY declaration starts with capital
   letter while the read function itself starts with the lowercase one. Almost
   the same thing happens with signal names. At each call to
   changeSignalName() and name() I make the first letter capital, is it OK?
   2. Some of the properties in my .kcfg file have min and max values but
   KConfigCompilerSignallingItem doesn't support them. Should I just copy all
   the stuff from ItemInt or is it better to make it a subclass of ItemInt?

Thank you for your help. After getting an answer to these questions I'm
going to file a review request for my patch.

Regards, Artem

2016-05-23 9:09 GMT+02:00 David Faure :

> On mardi 10 mai 2016 16:49:57 CEST Aleix Pol wrote:
> > On Mon, May 9, 2016 at 8:02 PM, Artem Fedoskin 
> wrote:
> > > Dear KDE developers,
> > >
> > > For my GSoC 2016 project at KDE (Lite version of KStars for mobile
> > > devices)
> > > I need to access C++ class generated from XML configure file with
> KConfig
> > > compiler from QML. I found in this patch
> > > https://git.reviewboard.kde.org/r/123367/ and in the source code of
> > > KConfig
> > > compiler that I should set GenerateProperties=true in my .kcfgc file to
> > > create option properties as Q_PROPERTY. However, I got following error
> > > "Too
> > > many signals to create unique bit masks". There is some conflict
> between
> > > Mutators and GenerateProperties options that causes this error in my
> XML
> > > configure file but I can't figure out what I should change to have
> setters
> > > in Q_PROPERTY.
> > >
> > > Would be grateful if someone could help me with this issue.
> > >
> > > Options.kcfgc - https://paste.kde.org/pm1klcbls
> > >
> > > kstars.kcfg - https://paste.kde.org/phit6qibo
> >
> > Hi Artem,
> > KConfigCompiler is limited in this regard by an implementation detail.
> > See "uint mSettingsChanged;".
> >
> > To solve it, I would patch kconfig_compiler and turn it into an
> > std::vector or patch kstars.kcfg to use separate config files
> > rather than a huge one.
>
> We could also start with turning that into quint64, to already double the
> number of possible settings, right? Easy short term fix.
>
> --
> David Faure, fa...@kde.org, http://www.davidfaure.fr
> Working on KDE Frameworks 5
>
>
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128017: Add donate menu item to help menu of our apps

2016-05-25 Thread Michael Pyne 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128017/#review95802
---



+1 From a technical side, it looks good to me (aside from the apidox fix).

I don't speak for KXMLGui so I didn't hit Ship It! but the idea and the 
implementation certainly make sense to me.


src/khelpmenu.h (line 235)


This needs to have a @since marker.


- Michael Pyne


On May 25, 2016, 10:55 p.m., Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128017/
> ---
> 
> (Updated May 25, 2016, 10:55 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kxmlgui
> 
> 
> Description
> ---
> 
> Our apps is defined as use our bugzilla for bug reporting.
> 
> 
> Diffs
> -
> 
>   src/khelpmenu.h df820f2 
>   src/khelpmenu.cpp 53397cc 
>   src/kxmlguiwindow.cpp b4162c8 
>   src/ui_standards.rc df9d913 
> 
> Diff: https://git.reviewboard.kde.org/r/128017/diff/
> 
> 
> Testing
> ---
> 
> Works, see http://i.imgur.com/iAuLId4.png (well for that you need the other 
> review i will use since it's kparts, i tried kiriki (regular kxmlgui) and 
> spectacle (manual khelpmenu) and it works fine)
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128019: Remove F1 as standard shortcut for Help

2016-05-25 Thread Thomas Pfeiffer 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128019/#review95801
---



As Kai said: Activating the help cursor by pressing F1 (and actually putting 
useful help behind it!) would be a great thing to have from a user's 
perspective.
Contextual help would be much more helpful than a plain old help text, and 
changing the cursor to the help cursor would be a far less annoying unintended 
action than opening the help browser.

The question is: Do we think there is a chance to get developers to actually 
put useful contextual help in their UIs in the the future, or will it likely 
just be doing nothing in the vast majority of apps?

- Thomas Pfeiffer


On May 25, 2016, 11:01 p.m., Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128019/
> ---
> 
> (Updated May 25, 2016, 11:01 p.m.)
> 
> 
> Review request for KDE Frameworks and KDE Usability.
> 
> 
> Repository: kconfig
> 
> 
> Description
> ---
> 
> F1 is too important and too easy to trigger for something like Help, that be 
> honest you don't need a shortcut for (since you don't invoke Help that often).
> 
> 
> Diffs
> -
> 
>   src/gui/kstandardshortcut.cpp 6be6309 
> 
> Diff: https://git.reviewboard.kde.org/r/128019/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128019: Remove F1 as standard shortcut for Help

2016-05-25 Thread Michael Pyne 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128019/#review95798
---



Is there any way to instead change it to an "F1, F1" sequence so that users 
actively trying to use this still have some easy way to do it, while preventing 
accidental initiations of help? I'm not sure if that's better for usability or 
worse though...

- Michael Pyne


On May 25, 2016, 11:01 p.m., Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128019/
> ---
> 
> (Updated May 25, 2016, 11:01 p.m.)
> 
> 
> Review request for KDE Frameworks and KDE Usability.
> 
> 
> Repository: kconfig
> 
> 
> Description
> ---
> 
> F1 is too important and too easy to trigger for something like Help, that be 
> honest you don't need a shortcut for (since you don't invoke Help that often).
> 
> 
> Diffs
> -
> 
>   src/gui/kstandardshortcut.cpp 6be6309 
> 
> Diff: https://git.reviewboard.kde.org/r/128019/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128019: Remove F1 as standard shortcut for Help

2016-05-25 Thread Luigi Toscano 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128019/#review95797
---



I disagree, but I fear I will be the only one.

- Luigi Toscano


On May 26, 2016, 1:01 a.m., Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128019/
> ---
> 
> (Updated May 26, 2016, 1:01 a.m.)
> 
> 
> Review request for KDE Frameworks and KDE Usability.
> 
> 
> Repository: kconfig
> 
> 
> Description
> ---
> 
> F1 is too important and too easy to trigger for something like Help, that be 
> honest you don't need a shortcut for (since you don't invoke Help that often).
> 
> 
> Diffs
> -
> 
>   src/gui/kstandardshortcut.cpp 6be6309 
> 
> Diff: https://git.reviewboard.kde.org/r/128019/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128019: Remove F1 as standard shortcut for Help

2016-05-25 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128019/#review95795
---



+1 only hit it accidentally.

If we were to provide Help on F1 it better be contextual and not launching an 
external application that takes time to load and has to be closed manually.

- Kai Uwe Broulik


On Mai 25, 2016, 11:01 nachm., Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128019/
> ---
> 
> (Updated Mai 25, 2016, 11:01 nachm.)
> 
> 
> Review request for KDE Frameworks and KDE Usability.
> 
> 
> Repository: kconfig
> 
> 
> Description
> ---
> 
> F1 is too important and too easy to trigger for something like Help, that be 
> honest you don't need a shortcut for (since you don't invoke Help that often).
> 
> 
> Diffs
> -
> 
>   src/gui/kstandardshortcut.cpp 6be6309 
> 
> Diff: https://git.reviewboard.kde.org/r/128019/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128019: Remove F1 as standard shortcut for Help

2016-05-25 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128019/#review95793
---



+1. After years of using KDE Software, I don't think any time I've hit it was 
on purpose.

- Aleix Pol Gonzalez


On May 26, 2016, 1:01 a.m., Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128019/
> ---
> 
> (Updated May 26, 2016, 1:01 a.m.)
> 
> 
> Review request for KDE Frameworks and KDE Usability.
> 
> 
> Repository: kconfig
> 
> 
> Description
> ---
> 
> F1 is too important and too easy to trigger for something like Help, that be 
> honest you don't need a shortcut for (since you don't invoke Help that often).
> 
> 
> Diffs
> -
> 
>   src/gui/kstandardshortcut.cpp 6be6309 
> 
> Diff: https://git.reviewboard.kde.org/r/128019/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 128019: Remove F1 as standard shortcut for Help

2016-05-25 Thread Albert Astals Cid 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128019/
---

Review request for KDE Frameworks and KDE Usability.


Repository: kconfig


Description
---

F1 is too important and too easy to trigger for something like Help, that be 
honest you don't need a shortcut for (since you don't invoke Help that often).


Diffs
-

  src/gui/kstandardshortcut.cpp 6be6309 

Diff: https://git.reviewboard.kde.org/r/128019/diff/


Testing
---


Thanks,

Albert Astals Cid

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 128018: Add donate menu item to help menu of our apps

2016-05-25 Thread Albert Astals Cid 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128018/
---

Review request for KDE Frameworks.


Repository: kparts


Description
---

Counterpart of https://git.reviewboard.kde.org/r/128017/ for kparts.


Diffs
-

  src/mainwindow.cpp 7e2ad9c 

Diff: https://git.reviewboard.kde.org/r/128018/diff/


Testing
---

Works


Thanks,

Albert Astals Cid

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 128017: Add donate menu item to help menu of our apps

2016-05-25 Thread Albert Astals Cid 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128017/
---

Review request for KDE Frameworks.


Repository: kxmlgui


Description
---

Our apps is defined as use our bugzilla for bug reporting.


Diffs
-

  src/khelpmenu.h df820f2 
  src/khelpmenu.cpp 53397cc 
  src/kxmlguiwindow.cpp b4162c8 
  src/ui_standards.rc df9d913 

Diff: https://git.reviewboard.kde.org/r/128017/diff/


Testing
---

Works, see http://i.imgur.com/iAuLId4.png (well for that you need the other 
review i will use since it's kparts, i tried kiriki (regular kxmlgui) and 
spectacle (manual khelpmenu) and it works fine)


Thanks,

Albert Astals Cid

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128014: [KToggleToolBarAction] Honor action/options_show_toolbar restriction

2016-05-25 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128014/#review95784
---


Ship it!




Ship It!

- David Edmundson


On May 25, 2016, 3:01 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128014/
> ---
> 
> (Updated May 25, 2016, 3:01 p.m.)
> 
> 
> Review request for KDE Frameworks and David Edmundson.
> 
> 
> Repository: kxmlgui
> 
> 
> Description
> ---
> 
> This makes sure the user is never presented the option to hide the toolbar. 
> Toolbars could still be hidden by unlocking toolbars after which a toolbar 
> action may show up.
> 
> 
> Diffs
> -
> 
>   src/ktoggletoolbaraction.cpp ceb6d43 
> 
> Diff: https://git.reviewboard.kde.org/r/128014/diff/
> 
> 
> Testing
> ---
> 
> Option no longer shows up. (Should've probably also hidden the Qt action in 
> my previous patch since that's what KAuthorized usually does)
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 128014: [KToggleToolBarAction] Honor action/options_show_toolbar restriction

2016-05-25 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128014/
---

Review request for KDE Frameworks and David Edmundson.


Repository: kxmlgui


Description
---

This makes sure the user is never presented the option to hide the toolbar. 
Toolbars could still be hidden by unlocking toolbars after which a toolbar 
action may show up.


Diffs
-

  src/ktoggletoolbaraction.cpp ceb6d43 

Diff: https://git.reviewboard.kde.org/r/128014/diff/


Testing
---

Option no longer shows up. (Should've probably also hidden the Qt action in my 
previous patch since that's what KAuthorized usually does)


Thanks,

Kai Uwe Broulik

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127843: Properly remove composed characters

2016-05-25 Thread Dominik Haumann 


> On Mai 24, 2016, 10:05 nachm., Milian Wolff wrote:
> > Jan, I think you've not yet uploaded the updated patch?
> 
> Jan Grulich wrote:
> That's right, because I wasn't successfull fixing this in a way Dominik 
> wanted me to fix and right now I don't have unfortunately time for that.

hm, what about this: We commit this patch, but with a testcase in autotests.

We can still change it later, but it is much better to have a fix than having 
no fix?


- Dominik


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127843/#review95764
---


On Mai 5, 2016, 10:53 vorm., Jan Grulich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127843/
> ---
> 
> (Updated Mai 5, 2016, 10:53 vorm.)
> 
> 
> Review request for Kate, KDE Frameworks, Christoph Cullmann, and Dominik 
> Haumann.
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> ---
> 
> When using Indic locales composed characters are not properly removed. 
> Pressing "delete" or "backspace" should remove the entire composed character 
> and not only one base character. You can see how it should behave when using 
> another text editor (e.g. libreoffice)
> 
> Can be tested with these words: ?? or ??? or 
> 
> Technical details:
> I'm not really sure whether exporting current text layout is the right way to 
> do this, I found that this is used when calling moveChar() which moves the 
> cursor exactly by one composed character so I was trying to find a way to do 
> it similarly.
> 
> 
> Diffs
> -
> 
>   src/document/katedocument.cpp 73778a1 
>   src/view/kateview.h 08db0df 
>   src/view/kateview.cpp fda6b2d 
> 
> Diff: https://git.reviewboard.kde.org/r/127843/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128011: Allow using new style connect syntax with KStandardAction::create()

2016-05-25 Thread Gleb Popov 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128011/
---

(Updated May 25, 2016, 3:23 p.m.)


Review request for KDE Frameworks, Alex Richardson and David Faure.


Changes
---

Document showStatusbar() properly.


Repository: kconfigwidgets


Description
---

This is https://git.reviewboard.kde.org/r/121218/ review brought in shape. I 
couldn't update diff there, so created new request.

What the generated docs looks like can be viewed there: 
http://arrowd.name/html/namespace_k_standard_action.html

Note that this requires simple Doxyfile to generate. How this should be handled?


Diffs (updated)
-

  autotests/kstandardactiontest.h 0008d28 
  autotests/kstandardactiontest.cpp 09ae35d 
  src/kstandardaction.h d511778 
  src/kstandardaction.cpp 216d3d6 

Diff: https://git.reviewboard.kde.org/r/128011/diff/


Testing
---


Thanks,

Gleb Popov

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 128011: Allow using new style connect syntax with KStandardAction::create()

2016-05-25 Thread Gleb Popov 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128011/
---

Review request for KDE Frameworks, Alex Richardson and David Faure.


Repository: kconfigwidgets


Description
---

This is https://git.reviewboard.kde.org/r/121218/ review brought in shape. I 
couldn't update diff there, so created new request.

What the generated docs looks like can be viewed there: 
http://arrowd.name/html/namespace_k_standard_action.html

Note that this requires simple Doxyfile to generate. How this should be handled?


Diffs
-

  autotests/kstandardactiontest.h 0008d28 
  autotests/kstandardactiontest.cpp 09ae35d 
  src/kstandardaction.h d511778 
  src/kstandardaction.cpp 216d3d6 

Diff: https://git.reviewboard.kde.org/r/128011/diff/


Testing
---


Thanks,

Gleb Popov

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127843: Properly remove composed characters

2016-05-25 Thread Jan Grulich 


> On Kvě. 24, 2016, 10:05 odp., Milian Wolff wrote:
> > Jan, I think you've not yet uploaded the updated patch?

That's right, because I wasn't successfull fixing this in a way Dominik wanted 
me to fix and right now I don't have unfortunately time for that.


- Jan


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127843/#review95764
---


On Kvě. 5, 2016, 10:53 dop., Jan Grulich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127843/
> ---
> 
> (Updated Kvě. 5, 2016, 10:53 dop.)
> 
> 
> Review request for Kate, KDE Frameworks, Christoph Cullmann, and Dominik 
> Haumann.
> 
> 
> Repository: ktexteditor
> 
> 
> Description
> ---
> 
> When using Indic locales composed characters are not properly removed. 
> Pressing "delete" or "backspace" should remove the entire composed character 
> and not only one base character. You can see how it should behave when using 
> another text editor (e.g. libreoffice)
> 
> Can be tested with these words: ?? or ??? or 
> 
> Technical details:
> I'm not really sure whether exporting current text layout is the right way to 
> do this, I found that this is used when calling moveChar() which moves the 
> cursor exactly by one composed character so I was trying to find a way to do 
> it similarly.
> 
> 
> Diffs
> -
> 
>   src/document/katedocument.cpp 73778a1 
>   src/view/kateview.h 08db0df 
>   src/view/kateview.cpp fda6b2d 
> 
> Diff: https://git.reviewboard.kde.org/r/127843/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 75 - Fixed!

2016-05-25 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/75/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 25 May 2016 09:11:21 +
Build duration: 6 min 55 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 
50 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 260/338 (77%)CLASSES 260/338 (77%)LINE 26746/50651 
(53%)CONDITIONAL 14889/37437 (40%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7537/7856 
(96%)CONDITIONAL 4176/8152 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7669/14041 
(55%)CONDITIONAL 4143/8907 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2270/7564 
(30%)CONDITIONAL 914/4407 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/833 (51%)CONDITIONAL 
318/719 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1754/3781 
(46%)CONDITIONAL 1249/3434 (36%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 
375/753 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 684/760 (90%)CONDITIONAL 
435/916 (47%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
329/410 (80%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2668/10604 
(25%)CONDITIONAL 1312/6802 (19%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 75 - Fixed!

2016-05-25 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/75/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 25 May 2016 09:11:21 +
Build duration: 6 min 55 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 
50 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 260/338 (77%)CLASSES 260/338 (77%)LINE 26746/50651 
(53%)CONDITIONAL 14889/37437 (40%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7537/7856 
(96%)CONDITIONAL 4176/8152 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 95/117 (81%)CLASSES 95/117 (81%)LINE 7669/14041 
(55%)CONDITIONAL 4143/8907 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2270/7564 
(30%)CONDITIONAL 914/4407 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/833 (51%)CONDITIONAL 
318/719 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1754/3781 
(46%)CONDITIONAL 1249/3434 (36%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 
375/753 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 684/760 (90%)CONDITIONAL 
435/916 (47%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
329/410 (80%)
src.widgets
FILES 29/62 (47%)CLASSES 29/62 (47%)LINE 2668/10604 
(25%)CONDITIONAL 1312/6802 (19%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127971: [KToolBar] Disable toggleViewAction() when actions/options_show_toolbar is restricted

2016-05-25 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127971/
---

(Updated May 25, 2016, 11:03 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit ba960d1e2ce5401c5fe74edf60b2b4e7c7e44fb0 by Kai Uwe 
Broulik to branch master.


Repository: kxmlgui


Description
---

While KXmlGui makes sure to prevent the user from hiding toolbars when not 
allowed, right-clicking an empty space in a QMainWindow, such as the menu bar, 
will yield a menu created by Qt, which knows nothing about Kiosk restrictions, 
listing all toolbar toggle actions of this window.


Diffs
-

  autotests/ktoolbar_unittest.cpp d6c1e05 
  src/ktoolbar.cpp 8fcb9cb 

Diff: https://git.reviewboard.kde.org/r/127971/diff/


Testing
---

Comes with a unittest.

I can no longer hide the main toolbar in Dolphin or Gwenview when this action 
is restricted by simply right-clicking the menu bar.


File Attachments


The Menu
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/05/19/076745b4-03a2-400f-9506-46999d4ce1e1__toolbartoggle.png


Thanks,

Kai Uwe Broulik

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel