date:20160724

Jenkins-kde-ci: kparts master kf5-qt5 » Linux,gcc - Build # 159 - Fixed!

2016-07-24 Thread no-reply


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kparts%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/159/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 24 Jul 2016 22:30:12 +
Build duration: 3 min 9 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 20/46 (43%)CLASSES 20/46 (43%)LINE 603/2607 
(23%)CONDITIONAL 199/1424 (14%)

By packages
  
autotests
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 175/186 (94%)CONDITIONAL 
77/156 (49%)
src
FILES 17/43 (40%)CLASSES 17/43 (40%)LINE 428/2421 
(18%)CONDITIONAL 122/1268 (10%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kparts master kf5-qt5 » Linux,gcc - Build # 159 - Fixed!

2016-07-24 Thread no-reply


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kparts%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/159/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 24 Jul 2016 22:30:12 +
Build duration: 3 min 9 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 20/46 (43%)CLASSES 20/46 (43%)LINE 603/2607 
(23%)CONDITIONAL 199/1424 (14%)

By packages
  
autotests
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 175/186 (94%)CONDITIONAL 
77/156 (49%)
src
FILES 17/43 (40%)CLASSES 17/43 (40%)LINE 428/2421 
(18%)CONDITIONAL 122/1268 (10%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120000: New Thermal and Electrical Units and Unit Convienience Function for KUnitConversion

2016-07-24 Thread Garret Wassermann



> On July 23, 2016, 8:29 a.m., Olivier Churlaud wrote:
> > It seems good to me.
> > 
> > If you are not told to hold this patch before friday, take it for a "Ship 
> > it" (and don't forget to add a line "REVIEW: 12" in your commit message)

Hi, I made the change. Also, I do not have commit rights yet. Can someone 
commit for me, or what do I need to do to get a developer commit rights? Thanks!


- Garret


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/12/#review97778
---


On July 24, 2016, 6:43 p.m., Garret Wassermann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/12/
> ---
> 
> (Updated July 24, 2016, 6:43 p.m.)
> 
> 
> Review request for KDE Frameworks and John Layt.
> 
> 
> Repository: kunitconversion
> 
> 
> Description
> ---
> 
> New Thermal and Electrical Units and Convienience Function for KUnitConversion
> 
> 
> Diffs
> -
> 
>   README.md fe8cbe8 
>   src/converter.cpp 0a7f862 
>   src/electrical_current.cpp PRE-CREATION 
>   src/electrical_current_p.h PRE-CREATION 
>   src/electrical_resistance.cpp PRE-CREATION 
>   src/electrical_resistance_p.h PRE-CREATION 
>   src/energy.cpp f525031 
>   src/thermal_conductivity.cpp PRE-CREATION 
>   src/thermal_conductivity_p.h PRE-CREATION 
>   src/thermal_flux.cpp PRE-CREATION 
>   src/thermal_flux_p.h PRE-CREATION 
>   src/thermal_generation.cpp PRE-CREATION 
>   src/thermal_generation_p.h PRE-CREATION 
>   src/unit.h e440346 
>   src/value.h c602150 
>   src/value.cpp a283be7 
>   src/voltage.cpp PRE-CREATION 
>   src/voltage_p.h PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/12/diff/
> 
> 
> Testing
> ---
> 
> I added some fundamental (base SI) units as well as some common derived units 
> in SI and English/Imperial system, mostly for electrical or thermal units. I 
> also added a simple member function to the Value class, symbolAsString(), to 
> immediately receive the current unit assigned to the Value object as a 
> QString. I was running into issues with my code where doing 
> v.unit()->symbol() wasn't working because I was getting KSharedPointers 
> instead of the object, and the program would just crash. I just wanted the 
> string! So I made a function, which helped with testing of the units.
> 
> The new categories work fine under my test program. I was able to convert 
> thermal units back and forth in my test program, so seems ok. The values also 
> appear correct from my tests (as long as I didn't mess anything up by hand!).
> 
> First time submitting review, so please let me know if there is something 
> else I should do better next time, thank you.
> 
> 
> Thanks,
> 
> Garret Wassermann
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120000: New Thermal and Electrical Units and Unit Convienience Function for KUnitConversion

2016-07-24 Thread Garret Wassermann


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/12/
---

(Updated July 24, 2016, 6:43 p.m.)


Review request for KDE Frameworks and John Layt.


Changes
---

Added @return doc string


Repository: kunitconversion


Description
---

New Thermal and Electrical Units and Convienience Function for KUnitConversion


Diffs (updated)
-

  README.md fe8cbe8 
  src/converter.cpp 0a7f862 
  src/electrical_current.cpp PRE-CREATION 
  src/electrical_current_p.h PRE-CREATION 
  src/electrical_resistance.cpp PRE-CREATION 
  src/electrical_resistance_p.h PRE-CREATION 
  src/energy.cpp f525031 
  src/thermal_conductivity.cpp PRE-CREATION 
  src/thermal_conductivity_p.h PRE-CREATION 
  src/thermal_flux.cpp PRE-CREATION 
  src/thermal_flux_p.h PRE-CREATION 
  src/thermal_generation.cpp PRE-CREATION 
  src/thermal_generation_p.h PRE-CREATION 
  src/unit.h e440346 
  src/value.h c602150 
  src/value.cpp a283be7 
  src/voltage.cpp PRE-CREATION 
  src/voltage_p.h PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/12/diff/


Testing
---

I added some fundamental (base SI) units as well as some common derived units 
in SI and English/Imperial system, mostly for electrical or thermal units. I 
also added a simple member function to the Value class, symbolAsString(), to 
immediately receive the current unit assigned to the Value object as a QString. 
I was running into issues with my code where doing v.unit()->symbol() wasn't 
working because I was getting KSharedPointers instead of the object, and the 
program would just crash. I just wanted the string! So I made a function, which 
helped with testing of the units.

The new categories work fine under my test program. I was able to convert 
thermal units back and forth in my test program, so seems ok. The values also 
appear correct from my tests (as long as I didn't mess anything up by hand!).

First time submitting review, so please let me know if there is something else 
I should do better next time, thank you.


Thanks,

Garret Wassermann

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128413: Add clipboard buttons in the Checksums tab

2016-07-24 Thread Elvis Angelaccio


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128413/
---

(Updated July 24, 2016, 10:07 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, KDE Usability and David Faure.


Changes
---

Submitted with commit a67b2ef0a38b7f80803d785c7784785e0e1093c5 by Elvis 
Angelaccio to branch master.


Repository: kio


Description
---

As discussed in RR 128283, we can improve the usability of the dialog if we add 
buttons to interact with the clipboard.

The Paste button is always visible, while the three Copy buttons are hidden 
until the correspoding checksum is computed.


Diffs
-

  src/widgets/checksumswidget.ui 543088e 
  src/widgets/kpropertiesdialog.cpp f6d835e 

Diff: https://git.reviewboard.kde.org/r/128413/diff/


Testing
---

Copy/Paste works as expected.


File Attachments


Paste button next to the input field.
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/07/22/0b0d3f06-7294-4ff1-b59d-d13c413c00f5__Spectacle.C31997.png
Example of Copy button
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/07/22/5f137d47-4592-4f4c-be96-4c2fc3d09978__Spectacle.J32017.png


Thanks,

Elvis Angelaccio

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128515: Fix KDescendantsProxyModel::setSourceModel() not clearing internal caches

2016-07-24 Thread David Faure



> On July 24, 2016, 9:26 p.m., Friedrich W. H. Kossebau wrote:
> > Please also try those other smoke unit tests.
> > I do not remember things detailed right now, but possibly 
> > `resetInternalData();` resulted in lots of signal emitted due to 
> > rowinserted or something, which broke at least assumptions of the smoke 
> > test, but possibly also for good reasons. But just a vague memory here.
> > Will have a look in one of the next days, thanks for pushing this further.

All kitemmodels test pass.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128515/#review97808
---


On July 24, 2016, 9:14 p.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128515/
> ---
> 
> (Updated July 24, 2016, 9:14 p.m.)
> 
> 
> Review request for KDE Frameworks, Friedrich W. H. Kossebau, Stephen Kelly, 
> and Sune Vuorela.
> 
> 
> Repository: kitemmodels
> 
> 
> Description
> ---
> 
> This fixes Sune's unittest.
> 
> 
> Diffs
> -
> 
>   autotests/kdescendantsproxymodeltest.cpp 
> 67c0fba5bdcf700659889731f80043911af211fb 
>   src/kdescendantsproxymodel.cpp 477cd961e57bd8d8863f543aac1c7ac806bff24c 
> 
> Diff: https://git.reviewboard.kde.org/r/128515/diff/
> 
> 
> Testing
> ---
> 
> Just the unittest.
> 
> 
> Thanks,
> 
> David Faure
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128515: Fix KDescendantsProxyModel::setSourceModel() not clearing internal caches

2016-07-24 Thread Friedrich W. H. Kossebau


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128515/#review97808
---



Please also try those other smoke unit tests.
I do not remember things detailed right now, but possibly 
`resetInternalData();` resulted in lots of signal emitted due to rowinserted or 
something, which broke at least assumptions of the smoke test, but possibly 
also for good reasons. But just a vague memory here.
Will have a look in one of the next days, thanks for pushing this further.

- Friedrich W. H. Kossebau


On July 24, 2016, 9:14 p.m., David Faure wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128515/
> ---
> 
> (Updated July 24, 2016, 9:14 p.m.)
> 
> 
> Review request for KDE Frameworks, Friedrich W. H. Kossebau, Stephen Kelly, 
> and Sune Vuorela.
> 
> 
> Repository: kitemmodels
> 
> 
> Description
> ---
> 
> This fixes Sune's unittest.
> 
> 
> Diffs
> -
> 
>   autotests/kdescendantsproxymodeltest.cpp 
> 67c0fba5bdcf700659889731f80043911af211fb 
>   src/kdescendantsproxymodel.cpp 477cd961e57bd8d8863f543aac1c7ac806bff24c 
> 
> Diff: https://git.reviewboard.kde.org/r/128515/diff/
> 
> 
> Testing
> ---
> 
> Just the unittest.
> 
> 
> Thanks,
> 
> David Faure
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128477: Do not delete system relevant files in tests (if we might succeed)

2016-07-24 Thread David Faure



> On July 18, 2016, 9:30 p.m., David Faure wrote:
> > Wow, it never occured to me that someone might run this test as root. I 
> > thought it was well known that development should not be done as root ;)
> > But I can see how it might happen when creating packages with unittests 
> > enabled or something.
> > 
> > The patch looks fine to me, not sure why you say "it probably still needs 
> > some more work" ?
> > 
> > Unfortunately I see no other way to test files owned by other users. But of 
> > course as long as this is tested once, the other tests could change 
> > permissions on a temp file to get into "missing permissions" error cases.
> 
> Tobias Berner wrote:
> It needs more work, because the test in itself is still basically a 
> russian roulette. My patch merely tries to break the fingers of the players 
> before their turn's up.
> 
> 
> I find it highly scary/nightmare inducing that there is a testcase that 
> has as 'failure' a destroyed operating system. This cannot meet any quality 
> standards I can think of.
> And I really find it quite scary that you use the "don't run as root" 
> excuse. Yes I grant you, that running tests with privileges may be wrong, but 
> I enabled them in our package builder to give them a go -- and there you 
> go...
> However, if running tests as root is wrong, trying to rm /etc or /boot 
> probably contradicts some Geneva convention.
> 
> 
> I think the proper way would be to make the test to only touch files it 
> itself creates & chowns. 
> Or the test could only try to remember a hardcoded `/tmp/kio_test/file` 
> and `/tmp/kio_test/dir` that have to be created before running the test 
> by the developer for these tests. 
> But it should _never_ opt to _well look at that nice system config 
> file/dir, that is certainly owned by root, let's try to remove that_ .
> 
> 
> What do you think would it be possible to reimplement the tests in that 
> way? Or would that break the tests?
> 
> 
> 
> [Please note, this is not an attack on you personally, but on the really 
> scary stuff the tests do].
> 
> Martin Gräßlin wrote:
> what about adding a check to our cmake configs to disallow running ctest 
> as root? I doubt that kio is the only KDE software which has dangerous tests 
> when running as root. I wouldn't trust my kwin tests to get executed as root 
> (as they interact with hardware).
> 
> Tobias Berner wrote:
> That would probably be a good first step. Can this be added somewhere 
> top-level (ecm), or would it have to be added to every KDE project? 
> I will gladly provide a patch for this.
> 
> Martin Gräßlin wrote:
> I was thinking of ecm, though my cmake knowledge is not sufficient to 
> properly know it. A candidate could be ecm-mark-as-test.

I modified jobtest to create its own "unreadable" file or dir(asking for 
people to create something before running automated tests is certainly not 
possible, we need a fully automated solution, for continuous integration and 
ease of use).

Similar contributions to the kio_trash unittest are welcome.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128477/#review97577
---


On July 23, 2016, 7:23 a.m., Tobias Berner wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128477/
> ---
> 
> (Updated July 23, 2016, 7:23 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Some tests for kio try to move system relevant files&paths with the blind 
> assumption that 
> the permissions to touch these files is not present. 
> The files are 
> - /etc/passwd
> - /etc/cups
> - /etc
> - /boot
> [sic!].
> 
> 
> Check that the process does not actually have the rights to touch system
> relevant files when running the
> - TestTrash::trashDirectoryOwnedByRoot
> - TestTrash::trashFileOwnedByRoot
> - JobTest::moveFileNoPermissions
> - JobTest::moveDirectoryNoPermissions
> tests -- and bail out of them if so.
> 
> 
> This patch probably still needs some more work [maybe I also missed another 
> naughty test?],
> and I welcome every kind of input on it (apart from the straw man *don't run 
> tests as root* ;) ).
> 
> 
> Diffs
> -
> 
>   autotests/jobtest.cpp 579c507 
>   src/ioslaves/trash/tests/testtrash.cpp c71df13 
> 
> Diff: https://git.reviewboard.kde.org/r/128477/diff/
> 
> 
> Testing
> ---
> 
> Without patch:
> - enjoying two hours of restoring a system without /etc & /boot
> 
> With patch:
> - grep 'must not' Testing/Temporary/LastTest.log.tmp
>  SKIP   : TestTrash::trashFileOwnedByRoot() Test must not be run

Re: Review Request 128398: Fix KDescendantsProxyModel::setSourceModel(...) to reset internal data

2016-07-24 Thread David Faure



> On July 21, 2016, 5:43 a.m., Sune Vuorela wrote:
> > I tried writing a small test for it, and it seemed like I could reproduce 
> > the issue. But my test didn't pass when I added this changeset.
> > 
> > Maybe I should publish my test case somewhere...
> 
> Sune Vuorela wrote:
> https://git.reviewboard.kde.org/r/128513/ - published there

https://git.reviewboard.kde.org/r/128515/ is a modified version of this patch, 
which actually fixes the unittest.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128398/#review97685
---


On July 8, 2016, 2:58 a.m., Friedrich W. H. Kossebau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128398/
> ---
> 
> (Updated July 8, 2016, 2:58 a.m.)
> 
> 
> Review request for KDE Frameworks, Stephen  Kelly and Stephen Kelly.
> 
> 
> Repository: kitemmodels
> 
> 
> Description
> ---
> 
> KDescendantsProxyModel currently does not reset its internal data when a 
> (new) source model is set.
> 
> Not sure the provided patch is the most correct one, but it works with the 
> current unit tests and for the use case where this bug was hit.
> I am still confused why 
> `KDescendantsProxyModelPrivate::synchronousMappingRefresh()` loops over 
> `while (!m_pendingParents.isEmpty())` on calling `processPendingParents();` 
> while `KDescendantsProxyModelPrivate::scheduleProcessPendingParents()` does 
> not.
> Especially when the `KDescendantsProxyModelPrivate::sourceModelReset()` 
> handler also only calls the latter.
> The sourceModelReset handler should be surely similar to what is done on 
> setting a new source model, so the patch for now copies that code. But from 
> what I understood by reading the code both of them should rather do a full 
> loop perhaps?
> 
> And `m_relayouting` should get a better name now, but no idea yet what would 
> be nice.
> 
> I have yet to grasp the proxymodeltest system to also write a matching unit 
> test, any proposal where I should start?
> 
> 
> Diffs
> -
> 
>   src/kdescendantsproxymodel.cpp 477cd96 
> 
> Diff: https://git.reviewboard.kde.org/r/128398/diff/
> 
> 
> Testing
> ---
> 
> Existing kitemmodels unit tests still pass.
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 128515: Fix KDescendantsProxyModel::setSourceModel() not clearing internal caches

2016-07-24 Thread David Faure


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128515/
---

Review request for KDE Frameworks, Friedrich W. H. Kossebau, Stephen Kelly, and 
Sune Vuorela.


Repository: kitemmodels


Description
---

This fixes Sune's unittest.


Diffs
-

  autotests/kdescendantsproxymodeltest.cpp 
67c0fba5bdcf700659889731f80043911af211fb 
  src/kdescendantsproxymodel.cpp 477cd961e57bd8d8863f543aac1c7ac806bff24c 

Diff: https://git.reviewboard.kde.org/r/128515/diff/


Testing
---

Just the unittest.


Thanks,

David Faure

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128513: Unittest for content test of kdescendantsproxymodel

2016-07-24 Thread Sune Vuorela


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128513/
---

(Updated July 24, 2016, 8:44 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, David Faure, Friedrich W. H. Kossebau, and 
Stephen Kelly.


Changes
---

Submitted with commit 3244f2ff34959f3e5c0a2c864a08737f47f96922 by Sune Vuorela 
to branch master.


Repository: kitemmodels


Description
---

A skipped unit test for https://git.reviewboard.kde.org/r/128398/

Note. the fix in that review does not seem to fix this test for me.


Diffs
-

  autotests/CMakeLists.txt dc8d779 
  autotests/kdescendantsproxymodeltest.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/128513/diff/


Testing
---


Thanks,

Sune Vuorela

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kparts master kf5-qt5 » Linux,gcc - Build # 158 - Unstable!

2016-07-24 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kparts%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/158/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 24 Jul 2016 15:24:34 +
Build duration: 4 min 12 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 2 
test(s)Failed: TestSuite.openorsavequestion_unittestFailed: TestSuite.parttest

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  ___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Jenkins-kde-ci: kwidgetsaddons master kf5-qt5 » Linux,gcc - Build # 58 - Still Unstable!

2016-07-24 Thread Christoph Feck

On Sunday 24 July 2016 16:06:52 no-re...@kde.org wrote:
> BUILD UNSTABLE
> Build URL:
> https://build.kde.org/job/kwidgetsaddons%20master%20kf5-qt5/PLATFO
> RM=Linux,compiler=gcc/58/ Project: PLATFORM=Linux,compiler=gcc
> Date of build: Sun, 24 Jul 2016 13:32:28 +
> Build duration: 5 min 41 sec
> 
> JUNIT RESULTS
> 
> Name: (root) Failed: 1 test(s), Passed: 11 test(s), Skipped: 0
> test(s), Total: 12 test(s)Failed: TestSuite.kdualactiontest

autotests/kdualaction passes locally. Any idea why it fails on CI? 
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 92 - Fixed!

2016-07-24 Thread no-reply


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/92/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 24 Jul 2016 13:43:48 +
Build duration: 3 min 22 sec

CHANGE SET
Revision 914db02a24e38997605a7199471d6fd71c6bf0c8 by scripty: (Qt 5.5.0 is now 
required, as discussed on kde-frameworks-devel)
  change: edit CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
10 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5463/7982 
(68%)CONDITIONAL 2951/6138 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1441/1529 
(94%)CONDITIONAL 881/1768 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1762/3042 
(58%)CONDITIONAL 757/1888 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2044/2798 
(73%)CONDITIONAL 1228/2054 (60%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 92 - Fixed!

2016-07-24 Thread no-reply


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/92/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 24 Jul 2016 13:43:48 +
Build duration: 3 min 22 sec

CHANGE SET
Revision 914db02a24e38997605a7199471d6fd71c6bf0c8 by scripty: (Qt 5.5.0 is now 
required, as discussed on kde-frameworks-devel)
  change: edit CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
10 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5463/7982 
(68%)CONDITIONAL 2951/6138 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1441/1529 
(94%)CONDITIONAL 881/1768 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1762/3042 
(58%)CONDITIONAL 757/1888 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2044/2798 
(73%)CONDITIONAL 1228/2054 (60%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kdesignerplugin master kf5-qt5 » Linux,gcc - Build # 46 - Unstable!

2016-07-24 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kdesignerplugin%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/46/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 24 Jul 2016 13:41:58 +
Build duration: 1 min 7 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 2 
test(s)Failed: TestSuite.minimaltestFailed: TestSuite.plugintest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 1/1 (100%)FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 94/98 
(96%)CONDITIONAL 37/50 (74%)

By packages
  
src
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 94/98 (96%)CONDITIONAL 
37/50 (74%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 91 - Fixed!

2016-07-24 Thread no-reply


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/91/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 24 Jul 2016 13:39:18 +
Build duration: 3 min 35 sec

CHANGE SET
Revision 914db02a24e38997605a7199471d6fd71c6bf0c8 by scripty: (Qt 5.5.0 is now 
required, as discussed on kde-frameworks-devel)
  change: edit CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
10 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5459/7982 
(68%)CONDITIONAL 2955/6138 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1443/1529 
(94%)CONDITIONAL 889/1768 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1762/3042 
(58%)CONDITIONAL 760/1888 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2038/2798 
(73%)CONDITIONAL 1221/2054 (59%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 91 - Fixed!

2016-07-24 Thread no-reply


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/91/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 24 Jul 2016 13:39:18 +
Build duration: 3 min 35 sec

CHANGE SET
Revision 914db02a24e38997605a7199471d6fd71c6bf0c8 by scripty: (Qt 5.5.0 is now 
required, as discussed on kde-frameworks-devel)
  change: edit CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
10 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5459/7982 
(68%)CONDITIONAL 2955/6138 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1443/1529 
(94%)CONDITIONAL 889/1768 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1762/3042 
(58%)CONDITIONAL 760/1888 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2038/2798 
(73%)CONDITIONAL 1221/2054 (59%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kwidgetsaddons master kf5-qt5 » Linux,gcc - Build # 58 - Still Unstable!

2016-07-24 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kwidgetsaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/58/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 24 Jul 2016 13:32:28 +
Build duration: 5 min 41 sec

CHANGE SET
Revision d151626183973d071e6c4f8ceaaf1b2866fa35fd by scripty: (Qt 5.5.0 is now 
required, as discussed on kde-frameworks-devel)
  change: edit CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 
12 test(s)Failed: TestSuite.kdualactiontest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 63/135 (47%)CLASSES 63/135 (47%)LINE 3301/13529 
(24%)CONDITIONAL 1243/7045 (18%)

By packages
  
autotests
FILES 23/23 (100%)CLASSES 23/23 (100%)LINE 1102/1105 
(100%)CONDITIONAL 547/1068 (51%)
src
FILES 40/112 (36%)CLASSES 40/112 (36%)LINE 2199/12424 
(18%)CONDITIONAL 696/5977 (12%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 153 - Fixed!

2016-07-24 Thread no-reply


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/153/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 24 Jul 2016 13:30:49 +
Build duration: 5 min 22 sec

CHANGE SET
Revision a7ffccf1d8cbf4f641e28b4de679d027284bd1fd by scripty: (Qt 5.5.0 is now 
required, as discussed on kde-frameworks-devel)
  change: edit CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 
50 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 262/341 (77%)CLASSES 262/341 (77%)LINE 27656/51067 
(54%)CONDITIONAL 15358/37799 (41%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7604/7919 
(96%)CONDITIONAL 4242/8264 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 96/117 (82%)CLASSES 96/117 (82%)LINE 7760/14123 
(55%)CONDITIONAL 4224/9043 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2308/7566 
(31%)CONDITIONAL 920/4401 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 430/833 (52%)CONDITIONAL 
322/719 (45%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1762/3783 
(47%)CONDITIONAL 1258/3434 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 
375/753 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
333/414 (80%)
src.widgets
FILES 30/65 (46%)CLASSES 30/65 (46%)LINE 3370/10867 
(31%)CONDITIONAL 1599/6898 (23%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 153 - Fixed!

2016-07-24 Thread no-reply


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/153/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 24 Jul 2016 13:30:49 +
Build duration: 5 min 22 sec

CHANGE SET
Revision a7ffccf1d8cbf4f641e28b4de679d027284bd1fd by scripty: (Qt 5.5.0 is now 
required, as discussed on kde-frameworks-devel)
  change: edit CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 
50 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 262/341 (77%)CLASSES 262/341 (77%)LINE 27656/51067 
(54%)CONDITIONAL 15358/37799 (41%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7604/7919 
(96%)CONDITIONAL 4242/8264 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 96/117 (82%)CLASSES 96/117 (82%)LINE 7760/14123 
(55%)CONDITIONAL 4224/9043 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2308/7566 
(31%)CONDITIONAL 920/4401 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 430/833 (52%)CONDITIONAL 
322/719 (45%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1762/3783 
(47%)CONDITIONAL 1258/3434 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 
375/753 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
333/414 (80%)
src.widgets
FILES 30/65 (46%)CLASSES 30/65 (46%)LINE 3370/10867 
(31%)CONDITIONAL 1599/6898 (23%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 91 - Still Unstable!

2016-07-24 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/91/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 24 Jul 2016 13:26:37 +
Build duration: 3 min 33 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.kservicetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5466/7983 
(68%)CONDITIONAL 2964/6138 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1443/1529 
(94%)CONDITIONAL 894/1768 (51%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1762/3042 
(58%)CONDITIONAL 756/1888 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2045/2799 
(73%)CONDITIONAL 1229/2054 (60%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 90 - Still Unstable!

2016-07-24 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/90/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 24 Jul 2016 13:25:37 +
Build duration: 3 min 25 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 
10 test(s)Failed: TestSuite.ksycocathreadtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5448/7982 
(68%)CONDITIONAL 2961/6138 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1425/1529 
(93%)CONDITIONAL 885/1768 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1763/3042 
(58%)CONDITIONAL 763/1888 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2044/2798 
(73%)CONDITIONAL 1228/2054 (60%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 128514: KIconLoader: reduce number of lookups when doing fallbacks

2016-07-24 Thread David Faure


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128514/
---

Review request for KDE Frameworks, Aleix Pol Gonzalez and Christoph Feck.


Repository: kiconthemes


Description
---

In the first pass, we already checked whether the icon exists in all icon 
themes.
So in the second pass, there's no point in starting with that again, we can go
ahead and start doing fallbacks right away.

(The comment about the two passes was removed in b84858c, but some of it still
applies.)

Tested with: strace -e file ./kiconengine_unittest testUnknownIconNotCached |& 
wc -l
Before: 6341
After: 4589


Diffs
-

  autotests/kiconloader_benchmark.cpp ded5e0221f8126139a019a8310e8f120672ac3b4 
  src/kiconloader.cpp 951775d77b7ec0e2d8099ee192ca25321dab4544 

Diff: https://git.reviewboard.kde.org/r/128514/diff/


Testing
---

strace as mentionned above.

All unittests still pass (incl fallback lookups, didn't check how complete 
those were, though)


Thanks,

David Faure

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128513: Unittest for content test of kdescendantsproxymodel

2016-07-24 Thread David Faure


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128513/#review97796
---


Fix it, then Ship it!




I suggest running astyle-kdelibs over the file.

Can be committed then.

BTW QEXPECT_FAIL is more correct than QSKIP for known failures, when possible.


autotests/kdescendantsproxymodeltest.cpp (line 28)


{ on separate line



autotests/kdescendantsproxymodeltest.cpp (line 30)


space after "for"



autotests/kdescendantsproxymodeltest.cpp (line 33)


space after for, kill trailing space



autotests/kdescendantsproxymodeltest.cpp (line 34)


{ on same line as for



autotests/kdescendantsproxymodeltest.cpp (line 43)


align to column 0



autotests/kdescendantsproxymodeltest.cpp (line 53)


swap args, expected value is second



autotests/kdescendantsproxymodeltest.cpp (line 64)


two spaces before =



autotests/kdescendantsproxymodeltest.cpp (line 66)


space after comma


- David Faure


On July 24, 2016, 11:56 a.m., Sune Vuorela wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128513/
> ---
> 
> (Updated July 24, 2016, 11:56 a.m.)
> 
> 
> Review request for KDE Frameworks, David Faure, Friedrich W. H. Kossebau, and 
> Stephen Kelly.
> 
> 
> Repository: kitemmodels
> 
> 
> Description
> ---
> 
> A skipped unit test for https://git.reviewboard.kde.org/r/128398/
> 
> Note. the fix in that review does not seem to fix this test for me.
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt dc8d779 
>   autotests/kdescendantsproxymodeltest.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128513/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sune Vuorela
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 152 - Unstable!

2016-07-24 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/152/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 24 Jul 2016 11:35:08 +
Build duration: 9 min 41 sec

CHANGE SET
Revision 80ea2009095011e59a742815ee583e71cfc75756 by David Faure: ([autotests] 
Use dir in unaccessible subdir as testcase for access)
  change: edit autotests/jobtest.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 
50 test(s)Failed: TestSuite.kiocore-threadtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 261/340 (77%)CLASSES 261/340 (77%)LINE 27608/51028 
(54%)CONDITIONAL 15327/37751 (41%)

By packages
  
autotests
FILES 64/64 (100%)CLASSES 64/64 (100%)LINE 7563/7880 
(96%)CONDITIONAL 4218/8216 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 96/117 (82%)CLASSES 96/117 (82%)LINE 7761/14123 
(55%)CONDITIONAL 4225/9043 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2308/7566 
(31%)CONDITIONAL 920/4401 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 430/833 (52%)CONDITIONAL 
322/719 (45%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1754/3783 
(46%)CONDITIONAL 1249/3434 (36%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 
375/753 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
333/414 (80%)
src.widgets
FILES 30/65 (46%)CLASSES 30/65 (46%)LINE 3370/10867 
(31%)CONDITIONAL 1600/6898 (23%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128398: Fix KDescendantsProxyModel::setSourceModel(...) to reset internal data

2016-07-24 Thread Sune Vuorela



> On July 21, 2016, 5:43 a.m., Sune Vuorela wrote:
> > I tried writing a small test for it, and it seemed like I could reproduce 
> > the issue. But my test didn't pass when I added this changeset.
> > 
> > Maybe I should publish my test case somewhere...

https://git.reviewboard.kde.org/r/128513/ - published there


- Sune


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128398/#review97685
---


On July 8, 2016, 2:58 a.m., Friedrich W. H. Kossebau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128398/
> ---
> 
> (Updated July 8, 2016, 2:58 a.m.)
> 
> 
> Review request for KDE Frameworks, Stephen  Kelly and Stephen Kelly.
> 
> 
> Repository: kitemmodels
> 
> 
> Description
> ---
> 
> KDescendantsProxyModel currently does not reset its internal data when a 
> (new) source model is set.
> 
> Not sure the provided patch is the most correct one, but it works with the 
> current unit tests and for the use case where this bug was hit.
> I am still confused why 
> `KDescendantsProxyModelPrivate::synchronousMappingRefresh()` loops over 
> `while (!m_pendingParents.isEmpty())` on calling `processPendingParents();` 
> while `KDescendantsProxyModelPrivate::scheduleProcessPendingParents()` does 
> not.
> Especially when the `KDescendantsProxyModelPrivate::sourceModelReset()` 
> handler also only calls the latter.
> The sourceModelReset handler should be surely similar to what is done on 
> setting a new source model, so the patch for now copies that code. But from 
> what I understood by reading the code both of them should rather do a full 
> loop perhaps?
> 
> And `m_relayouting` should get a better name now, but no idea yet what would 
> be nice.
> 
> I have yet to grasp the proxymodeltest system to also write a matching unit 
> test, any proposal where I should start?
> 
> 
> Diffs
> -
> 
>   src/kdescendantsproxymodel.cpp 477cd96 
> 
> Diff: https://git.reviewboard.kde.org/r/128398/diff/
> 
> 
> Testing
> ---
> 
> Existing kitemmodels unit tests still pass.
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 128513: Unittest for content test of kdescendantsproxymodel

2016-07-24 Thread Sune Vuorela


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128513/
---

Review request for KDE Frameworks, David Faure, Friedrich W. H. Kossebau, and 
Stephen Kelly.


Repository: kitemmodels


Description
---

A skipped unit test for https://git.reviewboard.kde.org/r/128398/

Note. the fix in that review does not seem to fix this test for me.


Diffs
-

  autotests/CMakeLists.txt dc8d779 
  autotests/kdescendantsproxymodeltest.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/128513/diff/


Testing
---


Thanks,

Sune Vuorela

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 150 - Fixed!

2016-07-24 Thread no-reply


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/150/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 24 Jul 2016 10:06:28 +
Build duration: 6 min 22 sec

CHANGE SET
Revision 09d6d77448fbb4d56877383cad7edd1ede825772 by David Faure: ([autotests] 
clean up after test, to avoid making further test methods)
  change: edit autotests/jobtest.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 
50 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 262/341 (77%)CLASSES 262/341 (77%)LINE 27656/51071 
(54%)CONDITIONAL 15359/37807 (41%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7605/7923 
(96%)CONDITIONAL 4246/8272 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 96/117 (82%)CLASSES 96/117 (82%)LINE 7760/14123 
(55%)CONDITIONAL 4222/9043 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2308/7566 
(31%)CONDITIONAL 920/4401 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/833 (51%)CONDITIONAL 
321/719 (45%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1762/3783 
(47%)CONDITIONAL 1258/3434 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 
375/753 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
333/414 (80%)
src.widgets
FILES 30/65 (46%)CLASSES 30/65 (46%)LINE 3371/10867 
(31%)CONDITIONAL 1601/6898 (23%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 150 - Fixed!

2016-07-24 Thread no-reply


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/150/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 24 Jul 2016 10:06:28 +
Build duration: 6 min 22 sec

CHANGE SET
Revision 09d6d77448fbb4d56877383cad7edd1ede825772 by David Faure: ([autotests] 
clean up after test, to avoid making further test methods)
  change: edit autotests/jobtest.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 
50 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 262/341 (77%)CLASSES 262/341 (77%)LINE 27656/51071 
(54%)CONDITIONAL 15359/37807 (41%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7605/7923 
(96%)CONDITIONAL 4246/8272 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 96/117 (82%)CLASSES 96/117 (82%)LINE 7760/14123 
(55%)CONDITIONAL 4222/9043 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2308/7566 
(31%)CONDITIONAL 920/4401 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/833 (51%)CONDITIONAL 
321/719 (45%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1762/3783 
(47%)CONDITIONAL 1258/3434 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 
375/753 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
333/414 (80%)
src.widgets
FILES 30/65 (46%)CLASSES 30/65 (46%)LINE 3371/10867 
(31%)CONDITIONAL 1601/6898 (23%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 150 - Fixed!

2016-07-24 Thread no-reply


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/150/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 24 Jul 2016 10:06:28 +
Build duration: 6 min 29 sec

CHANGE SET
Revision 09d6d77448fbb4d56877383cad7edd1ede825772 by David Faure: ([autotests] 
clean up after test, to avoid making further test methods)
  change: edit autotests/jobtest.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 
50 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 262/341 (77%)CLASSES 262/341 (77%)LINE 27657/51071 
(54%)CONDITIONAL 15366/37807 (41%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7605/7923 
(96%)CONDITIONAL 4250/8272 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 96/117 (82%)CLASSES 96/117 (82%)LINE 7762/14123 
(55%)CONDITIONAL 4226/9043 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2308/7566 
(31%)CONDITIONAL 920/4401 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/833 (51%)CONDITIONAL 
321/719 (45%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1762/3783 
(47%)CONDITIONAL 1258/3434 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 
375/753 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
333/414 (80%)
src.widgets
FILES 30/65 (46%)CLASSES 30/65 (46%)LINE 3370/10867 
(31%)CONDITIONAL 1600/6898 (23%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 150 - Fixed!

2016-07-24 Thread no-reply


GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/150/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 24 Jul 2016 10:06:28 +
Build duration: 6 min 29 sec

CHANGE SET
Revision 09d6d77448fbb4d56877383cad7edd1ede825772 by David Faure: ([autotests] 
clean up after test, to avoid making further test methods)
  change: edit autotests/jobtest.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 
50 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 262/341 (77%)CLASSES 262/341 (77%)LINE 27657/51071 
(54%)CONDITIONAL 15366/37807 (41%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7605/7923 
(96%)CONDITIONAL 4250/8272 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 96/117 (82%)CLASSES 96/117 (82%)LINE 7762/14123 
(55%)CONDITIONAL 4226/9043 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2308/7566 
(31%)CONDITIONAL 920/4401 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 428/833 (51%)CONDITIONAL 
321/719 (45%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1762/3783 
(47%)CONDITIONAL 1258/3434 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 
375/753 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
333/414 (80%)
src.widgets
FILES 30/65 (46%)CLASSES 30/65 (46%)LINE 3370/10867 
(31%)CONDITIONAL 1600/6898 (23%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 149 - Still Unstable!

2016-07-24 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/149/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 24 Jul 2016 09:51:29 +
Build duration: 7 min 21 sec

CHANGE SET
Revision dc8588efe72a5ca7670d0371537d99a0d4c690f5 by David Faure: 
(KNewFileMenu: fix copying template file from embedded resource)
  change: edit src/filewidgets/knewfilemenu.cpp
  change: edit autotests/knewfilemenutest.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 
50 test(s)Failed: TestSuite.kiocore-jobtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 262/341 (77%)CLASSES 262/341 (77%)LINE 27642/51070 
(54%)CONDITIONAL 15362/37807 (41%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7604/7922 
(96%)CONDITIONAL 4251/8272 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 96/117 (82%)CLASSES 96/117 (82%)LINE 7751/14123 
(55%)CONDITIONAL 4222/9043 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2308/7566 
(31%)CONDITIONAL 920/4401 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 430/833 (52%)CONDITIONAL 
322/719 (45%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1762/3783 
(47%)CONDITIONAL 1258/3434 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 
375/753 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 372/594 (63%)CONDITIONAL 
276/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
333/414 (80%)
src.widgets
FILES 30/65 (46%)CLASSES 30/65 (46%)LINE 3370/10867 
(31%)CONDITIONAL 1600/6898 (23%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 149 - Still Unstable!

2016-07-24 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/149/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 24 Jul 2016 09:44:31 +
Build duration: 6 min 42 sec

CHANGE SET
Revision dc8588efe72a5ca7670d0371537d99a0d4c690f5 by David Faure: 
(KNewFileMenu: fix copying template file from embedded resource)
  change: edit autotests/knewfilemenutest.cpp
  change: edit src/filewidgets/knewfilemenu.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 
50 test(s)Failed: TestSuite.kiocore-jobtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 262/341 (77%)CLASSES 262/341 (77%)LINE 27667/51070 
(54%)CONDITIONAL 15367/37807 (41%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7604/7922 
(96%)CONDITIONAL 4249/8272 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 96/117 (82%)CLASSES 96/117 (82%)LINE 7771/14123 
(55%)CONDITIONAL 4229/9043 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2308/7566 
(31%)CONDITIONAL 920/4401 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 430/833 (52%)CONDITIONAL 
322/719 (45%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1761/3783 
(47%)CONDITIONAL 1255/3434 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 
375/753 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
333/414 (80%)
src.widgets
FILES 30/65 (46%)CLASSES 30/65 (46%)LINE 3371/10867 
(31%)CONDITIONAL 1601/6898 (23%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 148 - Unstable!

2016-07-24 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/148/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 24 Jul 2016 09:38:49 +
Build duration: 12 min

CHANGE SET
Revision 99e643bbb86684f7bc740944183bba11d608fb0e by David Faure: (Add unittest 
to verify that KIO::storedPut() can handle qrc files as)
  change: edit autotests/knewfilemenutest.cpp
  change: edit autotests/jobtest.cpp
  change: edit autotests/jobtest.h


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 
50 test(s)Failed: TestSuite.kiocore-jobtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 262/341 (77%)CLASSES 262/341 (77%)LINE 27683/51061 
(54%)CONDITIONAL 15377/37793 (41%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7596/7914 
(96%)CONDITIONAL 4240/8258 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 96/117 (82%)CLASSES 96/117 (82%)LINE 7786/14123 
(55%)CONDITIONAL 4239/9043 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2308/7565 
(31%)CONDITIONAL 921/4401 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 430/833 (52%)CONDITIONAL 
322/719 (45%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1754/3783 
(46%)CONDITIONAL 1249/3434 (36%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 730/1155 (63%)CONDITIONAL 
390/753 (52%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
333/414 (80%)
src.widgets
FILES 30/65 (46%)CLASSES 30/65 (46%)LINE 3370/10867 
(31%)CONDITIONAL 1600/6898 (23%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128510: KNewFileMenu: fix copying template file from embedded resource

2016-07-24 Thread Wolfgang Bauer


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128510/
---

(Updated July 24, 2016, 9:44 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Chinmoy Ranjan Pradhan and David Faure.


Changes
---

Submitted with commit dc8588efe72a5ca7670d0371537d99a0d4c690f5 by David Faure 
to branch master.


Bugs: 359581
https://bugs.kde.org/show_bug.cgi?id=359581


Repository: kio


Description
---

KIO::storedTransferJob apparently doesn't support copying "files" from embedded 
Qt resources.
Therefore creating a new file via the "Create New" context menu results in an 
empty file in that case.

This patch fixes it by reading the source file into a QByteArray buffer first.


Diffs
-

  src/filewidgets/knewfilemenu.cpp 4908e4c 

Diff: https://git.reviewboard.kde.org/r/128510/diff/


Testing
---

Use "Create New"->"Text File" or "Create New"->HTML File" (in dolphin or the 
folderview plasmoid).
Before only an empty file was created, now the file has the intended content, 
and therefore the mimetype is also recognized correctly if it has no extension.


Thanks,

Wolfgang Bauer

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 148 - Still Unstable!

2016-07-24 Thread no-reply


GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/148/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 24 Jul 2016 09:38:49 +
Build duration: 4 min 41 sec

CHANGE SET
Revision 99e643bbb86684f7bc740944183bba11d608fb0e by David Faure: (Add unittest 
to verify that KIO::storedPut() can handle qrc files as)
  change: edit autotests/knewfilemenutest.cpp
  change: edit autotests/jobtest.cpp
  change: edit autotests/jobtest.h


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 
50 test(s)Failed: TestSuite.kiocore-jobtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 262/341 (77%)CLASSES 262/341 (77%)LINE 27638/51061 
(54%)CONDITIONAL 15346/37793 (41%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7596/7914 
(96%)CONDITIONAL 4242/8258 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 96/117 (82%)CLASSES 96/117 (82%)LINE 7758/14123 
(55%)CONDITIONAL 4222/9043 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2307/7565 
(30%)CONDITIONAL 920/4401 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 430/833 (52%)CONDITIONAL 
322/719 (45%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1754/3783 
(46%)CONDITIONAL 1249/3434 (36%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 
375/753 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
333/414 (80%)
src.widgets
FILES 30/65 (46%)CLASSES 30/65 (46%)LINE 3371/10867 
(31%)CONDITIONAL 1600/6898 (23%)___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128510: KNewFileMenu: fix copying template file from embedded resource

2016-07-24 Thread David Faure


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128510/#review97790
---


Ship it!




OK the bug wasn't that storedPut can't handle qrc files (so there's nothing to 
fix in the underlying layer), the bug was just that this QFile doesn't live 
long enough for the job execution.

But yes, in fact this patch is the simplest fix for it. I'll push it together 
with the unittest addition I made for it.

- David Faure


On July 23, 2016, 7:09 p.m., Wolfgang Bauer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128510/
> ---
> 
> (Updated July 23, 2016, 7:09 p.m.)
> 
> 
> Review request for KDE Frameworks, Chinmoy Ranjan Pradhan and David Faure.
> 
> 
> Bugs: 359581
> https://bugs.kde.org/show_bug.cgi?id=359581
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> KIO::storedTransferJob apparently doesn't support copying "files" from 
> embedded Qt resources.
> Therefore creating a new file via the "Create New" context menu results in an 
> empty file in that case.
> 
> This patch fixes it by reading the source file into a QByteArray buffer first.
> 
> 
> Diffs
> -
> 
>   src/filewidgets/knewfilemenu.cpp 4908e4c 
> 
> Diff: https://git.reviewboard.kde.org/r/128510/diff/
> 
> 
> Testing
> ---
> 
> Use "Create New"->"Text File" or "Create New"->HTML File" (in dolphin or the 
> folderview plasmoid).
> Before only an empty file was created, now the file has the intended content, 
> and therefore the mimetype is also recognized correctly if it has no 
> extension.
> 
> 
> Thanks,
> 
> Wolfgang Bauer
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128413: Add clipboard buttons in the Checksums tab

2016-07-24 Thread Elvis Angelaccio


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128413/#review97788
---



If there are no objections by today, I'm going to ship this.

- Elvis Angelaccio


On July 22, 2016, 9:21 p.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128413/
> ---
> 
> (Updated July 22, 2016, 9:21 p.m.)
> 
> 
> Review request for KDE Frameworks, KDE Usability and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> As discussed in RR 128283, we can improve the usability of the dialog if we 
> add buttons to interact with the clipboard.
> 
> The Paste button is always visible, while the three Copy buttons are hidden 
> until the correspoding checksum is computed.
> 
> 
> Diffs
> -
> 
>   src/widgets/checksumswidget.ui 543088e 
>   src/widgets/kpropertiesdialog.cpp f6d835e 
> 
> Diff: https://git.reviewboard.kde.org/r/128413/diff/
> 
> 
> Testing
> ---
> 
> Copy/Paste works as expected.
> 
> 
> File Attachments
> 
> 
> Paste button next to the input field.
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/22/0b0d3f06-7294-4ff1-b59d-d13c413c00f5__Spectacle.C31997.png
> Example of Copy button
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/22/5f137d47-4592-4f4c-be96-4c2fc3d09978__Spectacle.J32017.png
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

39 matches

Mail list logo