Re: Failing unittests

2016-08-07 Thread Martin Graesslin 
On Saturday, August 6, 2016 8:12:06 PM CEST David Faure wrote:
> Today is KF 5.25 tagging day, but the CI isn't green...
> kwayland: testWaylandFullscreenShell fails

Sorry about that. It's caused by a newer weston version [1] which got 
installed on Friday on build.kde.org. I just pushed a fix which QSKIPs if the 
old interface is not announced.

Cheers
Martin

[1] The Weston specific fullscreen shell extension got moved to Wayland 
Protocols and renamed to the conventions there.



signature.asc
Description: This is a digitally signed message part.

Re: Review Request 128583: Make KrossUi and the command-line tool optional

2016-08-07 Thread Alexander Potashev 


> On Авг. 3, 2016, 4:28 д.п., Aleix Pol Gonzalez wrote:
> > Why?
> 
> Alexander Potashev wrote:
> To make Kross easier to build for exotic (= non-Linux) platforms. (We 
> have no actual users for these options yet.)
> 
> Aleix Pol Gonzalez wrote:
> My experience says this tends to complicate the usage of the frameworks, 
> especially when it includes different targets being offered depending on how 
> it's built.

Ok, let's wait until these options are necessary.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128583/#review98025
---


On Авг. 3, 2016, 2:36 д.п., Alexander Potashev wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128583/
> ---
> 
> (Updated Авг. 3, 2016, 2:36 д.п.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kross
> 
> 
> Description
> ---
> 
> Make KrossUi and the command-line tool optional
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 6bf66a6d73a20077f223c3cf9bfd642935e85da4 
>   src/CMakeLists.txt 6f715fae9049e0b9c6327ff505b0b27351ec0f67 
>   src/modules/CMakeLists.txt 48e2c0219072b1b1335821b0290d261d8dc3d361 
> 
> Diff: https://git.reviewboard.kde.org/r/128583/diff/
> 
> 
> Testing
> ---
> 
> Still compiles successfully in all 4 configurations: {BUILD_KROSSUI = ON, 
> OFF} x {BUILD_KROSS_CLI = ON, OFF}.
> 
> 
> Thanks,
> 
> Alexander Potashev
> 
>

Re: Review Request 128583: Make KrossUi and the command-line tool optional

2016-08-07 Thread Alexander Potashev 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128583/
---

(Updated Авг. 8, 2016, 2:41 д.п.)


Status
--

This change has been discarded.


Review request for KDE Frameworks.


Repository: kross


Description
---

Make KrossUi and the command-line tool optional


Diffs
-

  CMakeLists.txt 6bf66a6d73a20077f223c3cf9bfd642935e85da4 
  src/CMakeLists.txt 6f715fae9049e0b9c6327ff505b0b27351ec0f67 
  src/modules/CMakeLists.txt 48e2c0219072b1b1335821b0290d261d8dc3d361 

Diff: https://git.reviewboard.kde.org/r/128583/diff/


Testing
---

Still compiles successfully in all 4 configurations: {BUILD_KROSSUI = ON, OFF} 
x {BUILD_KROSS_CLI = ON, OFF}.


Thanks,

Alexander Potashev

Re: Review Request 128589: Take over maintainership; remove framework deprecation flags

2016-08-07 Thread Alexander Potashev 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128589/
---

(Updated Авг. 8, 2016, 2:39 д.п.)


Status
--

This change has been discarded.


Review request for KDE Frameworks.


Repository: kross


Description
---

Take over maintainership; remove framework deprecation flags


Diffs
-

  metainfo.yaml 28937c96ba71aecd81d3565d071fe6560ef2e68e 

Diff: https://git.reviewboard.kde.org/r/128589/diff/


Testing
---


Thanks,

Alexander Potashev

Re: Review Request 128618: Fix creating symlink in Folder View

2016-08-07 Thread David Faure 


> On Aug. 6, 2016, 12:13 p.m., David Faure wrote:
> > src/core/copyjob.cpp, line 1531
> > 
> >
> > CopyJob stats the destination already, no need to do it again.
> > 
> > See line 410, the local path for the dest is even stored already:
> > m_dest = QUrl::fromLocalFile(sLocalPath);
> > 
> > So you should be able to just use if (m_dest.isLocalFile()) { ... } 
> > here.
> 
> Chinmoy Ranjan Pradhan wrote:
> In case of symlinks KIO::stat will fail because the destination doesn't 
> exist at the time of stat.
> 
> David Faure wrote:
> Wrong, it's stating the destination *directory*.
> 
> Chinmoy Ranjan Pradhan wrote:
> CopyJob will stat the destination directory only if it has been passed as 
> a parameter. But in KNewFileMenu the url of final link that is going to be 
> created is passed to KIO::link(this is also the case with KIO::copyAs as 
> well). That's why the stating fails.
> 
> (I used bunch of debug statements to confirm this failure)
> 
> David Faure wrote:
> Then KNewFileMenu should use KIO::linkAs rather than KIO::link.
> 
> (Not sure this will change what is being stat'ed though, please check)
> 
> Chinmoy Ranjan Pradhan wrote:
> I dont think using KIO::linkAs will make any difference. In its 
> implementation *asMethod* is set to false. So its as good as KIO::link.
> 
> David Faure wrote:
> Indeed, that was a copy/paste error. I now added unittests for KIO::link 
> and KIO::linkAs, and fixed KIO::linkAs to work as advertised. So now I can 
> say it for sure: KNewFileMenu should use KIO::linkAs (so that it fails when 
> the user types the name of an existing directory, rather than create the link 
> under that directory).
> 
> However this indeed doesn't help with the issue at hand, since CopyJob 
> will stat the given dest URL, which doesn't exist yet (that's the whole 
> point, checking if we can create it).
> 
> OK then for the additional KIO::stat, but it has to be done 
> asynchronously, no exec() inside a job. I.e. move the code under the exec to 
> a separate slot.
> 
> Chinmoy Ranjan Pradhan wrote:
> Just one quick question, why is it necessary to stat asyncronously and 
> not using a simple function call?

exec() is not "a simple function call", it runs a nested event loop, waiting 
for the job to terminate, but it means anything else could happen while in that 
event loop (timers, sockets...), so this creates lots of unexpected problems in 
complex programs.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128618/#review98157
---


On Aug. 6, 2016, 11:53 a.m., Chinmoy Ranjan Pradhan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128618/
> ---
> 
> (Updated Aug. 6, 2016, 11:53 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> KIO::link creates symlink when either protocol+host+port+username+password of 
> the source and the link are same or the link is going to be created locally. 
> In case of plasma's folder view none of the above cases are true therefore 
> creating a symlink in folder view plasmoid gives an error.  
> This patch aims to fix this issue.
> 
> 
> Diffs
> -
> 
>   src/core/copyjob.cpp c4c6b2c 
> 
> Diff: https://git.reviewboard.kde.org/r/128618/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> error message
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/06/d4da6ff3-53d8-49d1-a826-0c8cf12d7aa0__symlink_folderview.png
> 
> 
> Thanks,
> 
> Chinmoy Ranjan Pradhan
> 
>

Re: Review Request 128618: Fix creating symlink in Folder View

2016-08-07 Thread Chinmoy Ranjan Pradhan 


> On Aug. 6, 2016, 12:13 p.m., David Faure wrote:
> > src/core/copyjob.cpp, line 1531
> > 
> >
> > CopyJob stats the destination already, no need to do it again.
> > 
> > See line 410, the local path for the dest is even stored already:
> > m_dest = QUrl::fromLocalFile(sLocalPath);
> > 
> > So you should be able to just use if (m_dest.isLocalFile()) { ... } 
> > here.
> 
> Chinmoy Ranjan Pradhan wrote:
> In case of symlinks KIO::stat will fail because the destination doesn't 
> exist at the time of stat.
> 
> David Faure wrote:
> Wrong, it's stating the destination *directory*.
> 
> Chinmoy Ranjan Pradhan wrote:
> CopyJob will stat the destination directory only if it has been passed as 
> a parameter. But in KNewFileMenu the url of final link that is going to be 
> created is passed to KIO::link(this is also the case with KIO::copyAs as 
> well). That's why the stating fails.
> 
> (I used bunch of debug statements to confirm this failure)
> 
> David Faure wrote:
> Then KNewFileMenu should use KIO::linkAs rather than KIO::link.
> 
> (Not sure this will change what is being stat'ed though, please check)
> 
> Chinmoy Ranjan Pradhan wrote:
> I dont think using KIO::linkAs will make any difference. In its 
> implementation *asMethod* is set to false. So its as good as KIO::link.
> 
> David Faure wrote:
> Indeed, that was a copy/paste error. I now added unittests for KIO::link 
> and KIO::linkAs, and fixed KIO::linkAs to work as advertised. So now I can 
> say it for sure: KNewFileMenu should use KIO::linkAs (so that it fails when 
> the user types the name of an existing directory, rather than create the link 
> under that directory).
> 
> However this indeed doesn't help with the issue at hand, since CopyJob 
> will stat the given dest URL, which doesn't exist yet (that's the whole 
> point, checking if we can create it).
> 
> OK then for the additional KIO::stat, but it has to be done 
> asynchronously, no exec() inside a job. I.e. move the code under the exec to 
> a separate slot.

Just one quick question, why is it necessary to stat asyncronously and not 
using a simple function call?


- Chinmoy


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128618/#review98157
---


On Aug. 6, 2016, 11:53 a.m., Chinmoy Ranjan Pradhan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128618/
> ---
> 
> (Updated Aug. 6, 2016, 11:53 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> KIO::link creates symlink when either protocol+host+port+username+password of 
> the source and the link are same or the link is going to be created locally. 
> In case of plasma's folder view none of the above cases are true therefore 
> creating a symlink in folder view plasmoid gives an error.  
> This patch aims to fix this issue.
> 
> 
> Diffs
> -
> 
>   src/core/copyjob.cpp c4c6b2c 
> 
> Diff: https://git.reviewboard.kde.org/r/128618/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> error message
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/06/d4da6ff3-53d8-49d1-a826-0c8cf12d7aa0__symlink_folderview.png
> 
> 
> Thanks,
> 
> Chinmoy Ranjan Pradhan
> 
>

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 130 - Fixed!

2016-08-07 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/130/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Sun, 07 Aug 2016 12:03:10 +
Build duration: 3 min 11 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 
15 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 81/119 (68%)CLASSES 81/119 (68%)LINE 4911/11671 
(42%)CONDITIONAL 2654/8809 (30%)

By packages
  
autotests
FILES 28/28 (100%)CLASSES 28/28 (100%)LINE 1005/1050 
(96%)CONDITIONAL 634/1238 (51%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 648/2108 
(31%)CONDITIONAL 306/1304 (23%)
src.plasma
FILES 14/20 (70%)CLASSES 14/20 (70%)LINE 1662/3607 
(46%)CONDITIONAL 949/2696 (35%)
src.plasma.packagestructure
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 54/66 (82%)CONDITIONAL 
7/22 (32%)
src.plasma.private
FILES 14/24 (58%)CLASSES 14/24 (58%)LINE 919/1635 
(56%)CONDITIONAL 439/1064 (41%)
src.plasma.scripting
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 37/181 (20%)CONDITIONAL 
14/106 (13%)
src.plasmaquick
FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 544/1781 
(31%)CONDITIONAL 298/1389 (21%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)
src.scriptengines.qml.plasmoid
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1130 (1%)CONDITIONAL 
1/968 (0%)

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 130 - Fixed!

2016-08-07 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/130/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Sun, 07 Aug 2016 12:03:10 +
Build duration: 3 min 11 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 
15 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 81/119 (68%)CLASSES 81/119 (68%)LINE 4911/11671 
(42%)CONDITIONAL 2654/8809 (30%)

By packages
  
autotests
FILES 28/28 (100%)CLASSES 28/28 (100%)LINE 1005/1050 
(96%)CONDITIONAL 634/1238 (51%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 648/2108 
(31%)CONDITIONAL 306/1304 (23%)
src.plasma
FILES 14/20 (70%)CLASSES 14/20 (70%)LINE 1662/3607 
(46%)CONDITIONAL 949/2696 (35%)
src.plasma.packagestructure
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 54/66 (82%)CONDITIONAL 
7/22 (32%)
src.plasma.private
FILES 14/24 (58%)CLASSES 14/24 (58%)LINE 919/1635 
(56%)CONDITIONAL 439/1064 (41%)
src.plasma.scripting
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 37/181 (20%)CONDITIONAL 
14/106 (13%)
src.plasmaquick
FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 544/1781 
(31%)CONDITIONAL 298/1389 (21%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)
src.scriptengines.qml.plasmoid
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1130 (1%)CONDITIONAL 
1/968 (0%)

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 130 - Fixed!

2016-08-07 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/130/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Sun, 07 Aug 2016 11:25:30 +
Build duration: 8 min 32 sec

CHANGE SET
Revision 8abeceaffd0c93028810ea12131b7fa8bcd13b12 by David Faure: (Skip 
autotest that is broken with Qt 5.5)
  change: edit autotests/dialogstatetest.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 
15 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 81/119 (68%)CLASSES 81/119 (68%)LINE 4909/11671 
(42%)CONDITIONAL 2647/8809 (30%)

By packages
  
autotests
FILES 28/28 (100%)CLASSES 28/28 (100%)LINE 1003/1050 
(96%)CONDITIONAL 634/1238 (51%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 648/2108 
(31%)CONDITIONAL 300/1304 (23%)
src.plasma
FILES 14/20 (70%)CLASSES 14/20 (70%)LINE 1662/3607 
(46%)CONDITIONAL 949/2696 (35%)
src.plasma.packagestructure
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 54/66 (82%)CONDITIONAL 
7/22 (32%)
src.plasma.private
FILES 14/24 (58%)CLASSES 14/24 (58%)LINE 919/1635 
(56%)CONDITIONAL 438/1064 (41%)
src.plasma.scripting
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 37/181 (20%)CONDITIONAL 
14/106 (13%)
src.plasmaquick
FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 544/1781 
(31%)CONDITIONAL 298/1389 (21%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)
src.scriptengines.qml.plasmoid
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1130 (1%)CONDITIONAL 
1/968 (0%)

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 130 - Fixed!

2016-08-07 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/130/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Sun, 07 Aug 2016 11:25:30 +
Build duration: 8 min 32 sec

CHANGE SET
Revision 8abeceaffd0c93028810ea12131b7fa8bcd13b12 by David Faure: (Skip 
autotest that is broken with Qt 5.5)
  change: edit autotests/dialogstatetest.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 
15 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 81/119 (68%)CLASSES 81/119 (68%)LINE 4909/11671 
(42%)CONDITIONAL 2647/8809 (30%)

By packages
  
autotests
FILES 28/28 (100%)CLASSES 28/28 (100%)LINE 1003/1050 
(96%)CONDITIONAL 634/1238 (51%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 648/2108 
(31%)CONDITIONAL 300/1304 (23%)
src.plasma
FILES 14/20 (70%)CLASSES 14/20 (70%)LINE 1662/3607 
(46%)CONDITIONAL 949/2696 (35%)
src.plasma.packagestructure
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 54/66 (82%)CONDITIONAL 
7/22 (32%)
src.plasma.private
FILES 14/24 (58%)CLASSES 14/24 (58%)LINE 919/1635 
(56%)CONDITIONAL 438/1064 (41%)
src.plasma.scripting
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 37/181 (20%)CONDITIONAL 
14/106 (13%)
src.plasmaquick
FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 544/1781 
(31%)CONDITIONAL 298/1389 (21%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)
src.scriptengines.qml.plasmoid
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1130 (1%)CONDITIONAL 
1/968 (0%)

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 129 - Unstable!

2016-08-07 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/129/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Sun, 07 Aug 2016 11:25:30 +
Build duration: 8 min 19 sec

CHANGE SET
Revision 8abeceaffd0c93028810ea12131b7fa8bcd13b12 by David Faure: (Skip 
autotest that is broken with Qt 5.5)
  change: edit autotests/dialogstatetest.cpp


JUNIT RESULTS

Name: (root) Failed: 14 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 
15 test(s)Failed: TestSuite.coronatestFailed: TestSuite.dialognativetestFailed: 
TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: 
TestSuite.plasma-dialogstatetestFailed: 
TestSuite.plasma-fallbackpackagetestFailed: 
TestSuite.plasma-framesvgtestFailed: TestSuite.plasma-iconitemtestFailed: 
TestSuite.plasma-packagestructuretestFailed: 
TestSuite.plasma-packageurlinterceptortestFailed: 
TestSuite.plasma-pluginloadertestFailed: 
TestSuite.plasma-sortfiltermodeltestFailed: TestSuite.plasma-storagetestFailed: 
TestSuite.plasma-themetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/7 (71%)FILES 26/82 (32%)CLASSES 26/82 (32%)LINE 1614/9446 
(17%)CONDITIONAL 813/6601 (12%)

By packages
  
autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 18/21 (86%)CONDITIONAL 
2/20 (10%)
src.declarativeimports.core
FILES 6/18 (33%)CLASSES 6/18 (33%)LINE 203/2108 
(10%)CONDITIONAL 45/1304 (3%)
src.plasma
FILES 8/20 (40%)CLASSES 8/20 (40%)LINE 662/3607 
(18%)CONDITIONAL 409/2696 (15%)
src.plasma.private
FILES 5/24 (21%)CLASSES 5/24 (21%)LINE 406/1635 
(25%)CONDITIONAL 187/1064 (18%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/181 (0%)CONDITIONAL 0/106 
(0%)
src.plasmaquick
FILES 5/12 (42%)CLASSES 5/12 (42%)LINE 325/1781 
(18%)CONDITIONAL 170/1389 (12%)
src.plasmaquick.private
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/113 (0%)CONDITIONAL 0/22 
(0%)

Jenkins-kde-ci: kinit master stable-kf5-qt5 » Linux,gcc - Build # 173 - Fixed!

2016-08-07 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kinit%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/173/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 07 Aug 2016 09:23:17 +
Build duration: 5 min 38 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages

Jenkins-kde-ci: kinit master stable-kf5-qt5 » Linux,gcc - Build # 173 - Fixed!

2016-08-07 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kinit%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/173/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 07 Aug 2016 09:23:17 +
Build duration: 5 min 38 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages

Jenkins-kde-ci: frameworkintegration master stable-kf5-qt5 » Linux,gcc - Build # 185 - Fixed!

2016-08-07 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/frameworkintegration%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/185/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 07 Aug 2016 09:23:18 +
Build duration: 55 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 72/205 
(35%)CONDITIONAL 34/172 (20%)

By packages
  
autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 25/27 (93%)CONDITIONAL 
5/10 (50%)
src.kstyle
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 47/178 (26%)CONDITIONAL 
29/162 (18%)

Jenkins-kde-ci: frameworkintegration master stable-kf5-qt5 » Linux,gcc - Build # 185 - Fixed!

2016-08-07 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/frameworkintegration%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/185/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 07 Aug 2016 09:23:18 +
Build duration: 55 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 72/205 
(35%)CONDITIONAL 34/172 (20%)

By packages
  
autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 25/27 (93%)CONDITIONAL 
5/10 (50%)
src.kstyle
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 47/178 (26%)CONDITIONAL 
29/162 (18%)

Jenkins-kde-ci: kinit master stable-kf5-qt5 » Linux,gcc - Build # 172 - Failure!

2016-08-07 Thread no-reply 

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kinit%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/172/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 07 Aug 2016 09:22:03 +
Build duration: 10 sec

CHANGE SET
No changes

Jenkins-kde-ci: frameworkintegration master stable-kf5-qt5 » Linux,gcc - Build # 184 - Failure!

2016-08-07 Thread no-reply 

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/frameworkintegration%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/184/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 07 Aug 2016 09:22:03 +
Build duration: 10 sec

CHANGE SET
No changes

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 173 - Fixed!

2016-08-07 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/173/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 07 Aug 2016 09:07:29 +
Build duration: 12 min

CHANGE SET
Revision 63720d9d26109ec51c333d680a4b38ccce143d3e by David Faure: (Fix 
KIO::linkAs() to work as advertised, i.e. fail if dest already)
  change: edit src/core/copyjob.h
  change: edit autotests/jobtest.cpp
  change: edit autotests/jobtest.h
  change: edit src/core/copyjob.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 
50 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 262/341 (77%)CLASSES 262/341 (77%)LINE 27752/51155 
(54%)CONDITIONAL 15426/37911 (41%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7663/7984 
(96%)CONDITIONAL 4286/8366 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 96/117 (82%)CLASSES 96/117 (82%)LINE 7789/14123 
(55%)CONDITIONAL 4243/9051 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2310/7569 
(31%)CONDITIONAL 920/4401 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 430/832 (52%)CONDITIONAL 
324/719 (45%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1754/3783 
(46%)CONDITIONAL 1249/3434 (36%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 723/1155 (63%)CONDITIONAL 
384/753 (51%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
333/414 (80%)
src.widgets
FILES 30/65 (46%)CLASSES 30/65 (46%)LINE 3374/10888 
(31%)CONDITIONAL 1604/6900 (23%)

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 173 - Fixed!

2016-08-07 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/173/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 07 Aug 2016 09:07:29 +
Build duration: 12 min

CHANGE SET
Revision 63720d9d26109ec51c333d680a4b38ccce143d3e by David Faure: (Fix 
KIO::linkAs() to work as advertised, i.e. fail if dest already)
  change: edit src/core/copyjob.h
  change: edit autotests/jobtest.cpp
  change: edit autotests/jobtest.h
  change: edit src/core/copyjob.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 
50 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 262/341 (77%)CLASSES 262/341 (77%)LINE 27752/51155 
(54%)CONDITIONAL 15426/37911 (41%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7663/7984 
(96%)CONDITIONAL 4286/8366 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 96/117 (82%)CLASSES 96/117 (82%)LINE 7789/14123 
(55%)CONDITIONAL 4243/9051 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2310/7569 
(31%)CONDITIONAL 920/4401 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 430/832 (52%)CONDITIONAL 
324/719 (45%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1754/3783 
(46%)CONDITIONAL 1249/3434 (36%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 723/1155 (63%)CONDITIONAL 
384/753 (51%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
333/414 (80%)
src.widgets
FILES 30/65 (46%)CLASSES 30/65 (46%)LINE 3374/10888 
(31%)CONDITIONAL 1604/6900 (23%)

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 173 - Fixed!

2016-08-07 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/173/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 07 Aug 2016 09:07:29 +
Build duration: 6 min 17 sec

CHANGE SET
Revision 63720d9d26109ec51c333d680a4b38ccce143d3e by David Faure: (Fix 
KIO::linkAs() to work as advertised, i.e. fail if dest already)
  change: edit autotests/jobtest.cpp
  change: edit src/core/copyjob.h
  change: edit src/core/copyjob.cpp
  change: edit autotests/jobtest.h


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 
50 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 262/341 (77%)CLASSES 262/341 (77%)LINE 27737/51155 
(54%)CONDITIONAL 15417/37911 (41%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7666/7984 
(96%)CONDITIONAL 4285/8366 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 96/117 (82%)CLASSES 96/117 (82%)LINE 7774/14123 
(55%)CONDITIONAL 4236/9051 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2310/7569 
(31%)CONDITIONAL 920/4401 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 430/832 (52%)CONDITIONAL 
324/719 (45%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1762/3783 
(47%)CONDITIONAL 1258/3434 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 
375/753 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
333/414 (80%)
src.widgets
FILES 30/65 (46%)CLASSES 30/65 (46%)LINE 3373/10888 
(31%)CONDITIONAL 1603/6900 (23%)

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 173 - Fixed!

2016-08-07 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/173/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 07 Aug 2016 09:07:29 +
Build duration: 6 min 17 sec

CHANGE SET
Revision 63720d9d26109ec51c333d680a4b38ccce143d3e by David Faure: (Fix 
KIO::linkAs() to work as advertised, i.e. fail if dest already)
  change: edit autotests/jobtest.cpp
  change: edit src/core/copyjob.h
  change: edit src/core/copyjob.cpp
  change: edit autotests/jobtest.h


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 50 test(s), Skipped: 0 test(s), Total: 
50 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 262/341 (77%)CLASSES 262/341 (77%)LINE 27737/51155 
(54%)CONDITIONAL 15417/37911 (41%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7666/7984 
(96%)CONDITIONAL 4285/8366 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 96/117 (82%)CLASSES 96/117 (82%)LINE 7774/14123 
(55%)CONDITIONAL 4236/9051 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2310/7569 
(31%)CONDITIONAL 920/4401 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 430/832 (52%)CONDITIONAL 
324/719 (45%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1762/3783 
(47%)CONDITIONAL 1258/3434 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 
375/753 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
333/414 (80%)
src.widgets
FILES 30/65 (46%)CLASSES 30/65 (46%)LINE 3373/10888 
(31%)CONDITIONAL 1603/6900 (23%)

Re: Review Request 128618: Fix creating symlink in Folder View

2016-08-07 Thread David Faure 


> On Aug. 6, 2016, 12:13 p.m., David Faure wrote:
> > src/core/copyjob.cpp, line 1531
> > 
> >
> > CopyJob stats the destination already, no need to do it again.
> > 
> > See line 410, the local path for the dest is even stored already:
> > m_dest = QUrl::fromLocalFile(sLocalPath);
> > 
> > So you should be able to just use if (m_dest.isLocalFile()) { ... } 
> > here.
> 
> Chinmoy Ranjan Pradhan wrote:
> In case of symlinks KIO::stat will fail because the destination doesn't 
> exist at the time of stat.
> 
> David Faure wrote:
> Wrong, it's stating the destination *directory*.
> 
> Chinmoy Ranjan Pradhan wrote:
> CopyJob will stat the destination directory only if it has been passed as 
> a parameter. But in KNewFileMenu the url of final link that is going to be 
> created is passed to KIO::link(this is also the case with KIO::copyAs as 
> well). That's why the stating fails.
> 
> (I used bunch of debug statements to confirm this failure)
> 
> David Faure wrote:
> Then KNewFileMenu should use KIO::linkAs rather than KIO::link.
> 
> (Not sure this will change what is being stat'ed though, please check)
> 
> Chinmoy Ranjan Pradhan wrote:
> I dont think using KIO::linkAs will make any difference. In its 
> implementation *asMethod* is set to false. So its as good as KIO::link.

Indeed, that was a copy/paste error. I now added unittests for KIO::link and 
KIO::linkAs, and fixed KIO::linkAs to work as advertised. So now I can say it 
for sure: KNewFileMenu should use KIO::linkAs (so that it fails when the user 
types the name of an existing directory, rather than create the link under that 
directory).

However this indeed doesn't help with the issue at hand, since CopyJob will 
stat the given dest URL, which doesn't exist yet (that's the whole point, 
checking if we can create it).

OK then for the additional KIO::stat, but it has to be done asynchronously, no 
exec() inside a job. I.e. move the code under the exec to a separate slot.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128618/#review98157
---


On Aug. 6, 2016, 11:53 a.m., Chinmoy Ranjan Pradhan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128618/
> ---
> 
> (Updated Aug. 6, 2016, 11:53 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> KIO::link creates symlink when either protocol+host+port+username+password of 
> the source and the link are same or the link is going to be created locally. 
> In case of plasma's folder view none of the above cases are true therefore 
> creating a symlink in folder view plasmoid gives an error.  
> This patch aims to fix this issue.
> 
> 
> Diffs
> -
> 
>   src/core/copyjob.cpp c4c6b2c 
> 
> Diff: https://git.reviewboard.kde.org/r/128618/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> error message
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/06/d4da6ff3-53d8-49d1-a826-0c8cf12d7aa0__symlink_folderview.png
> 
> 
> Thanks,
> 
> Chinmoy Ranjan Pradhan
> 
>

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 172 - Unstable!

2016-08-07 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/172/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 07 Aug 2016 08:47:53 +
Build duration: 18 min

CHANGE SET
Revision 0b5c8385baaa455ed2e728d42ddd07c9754e84e2 by David Faure: ([autotests] 
add test for KIO::copyAs())
  change: edit autotests/jobtest.cpp


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 
50 test(s)Failed: TestSuite.kiocore-klocalsocketservertestFailed: 
TestSuite.kiocore-klocalsockettest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 262/341 (77%)CLASSES 262/341 (77%)LINE 27679/51123 
(54%)CONDITIONAL 15372/37867 (41%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7594/7952 
(95%)CONDITIONAL 4237/8322 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 96/117 (82%)CLASSES 96/117 (82%)LINE 7784/14123 
(55%)CONDITIONAL 4239/9051 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2313/7569 
(31%)CONDITIONAL 922/4401 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 429/832 (52%)CONDITIONAL 
322/719 (45%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1754/3783 
(46%)CONDITIONAL 1249/3434 (36%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 723/1155 (63%)CONDITIONAL 
384/753 (51%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
333/414 (80%)
src.widgets
FILES 30/65 (46%)CLASSES 30/65 (46%)LINE 3373/10888 
(31%)CONDITIONAL 1603/6900 (23%)

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 172 - Unstable!

2016-08-07 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/172/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 07 Aug 2016 08:47:53 +
Build duration: 18 min

CHANGE SET
Revision 0b5c8385baaa455ed2e728d42ddd07c9754e84e2 by David Faure: ([autotests] 
add test for KIO::copyAs())
  change: edit autotests/jobtest.cpp


JUNIT RESULTS

Name: (root) Failed: 3 test(s), Passed: 47 test(s), Skipped: 0 test(s), Total: 
50 test(s)Failed: TestSuite.kiocore-jobtestFailed: 
TestSuite.kiocore-klocalsocketservertestFailed: 
TestSuite.kiocore-klocalsockettest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 262/341 (77%)CLASSES 262/341 (77%)LINE 27638/51123 
(54%)CONDITIONAL 15331/37867 (40%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7555/7952 
(95%)CONDITIONAL 4193/8322 (50%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 529/530 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 96/117 (82%)CLASSES 96/117 (82%)LINE 7784/14123 
(55%)CONDITIONAL 4241/9051 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 20/36 (56%)CLASSES 20/36 (56%)LINE 2310/7569 
(31%)CONDITIONAL 920/4401 (21%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 429/832 (52%)CONDITIONAL 
322/719 (45%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1754/3783 
(46%)CONDITIONAL 1249/3434 (36%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 723/1155 (63%)CONDITIONAL 
384/753 (51%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 359/385 (93%)CONDITIONAL 
102/138 (74%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
333/414 (80%)
src.widgets
FILES 30/65 (46%)CLASSES 30/65 (46%)LINE 3374/10888 
(31%)CONDITIONAL 1604/6900 (23%)

Re: Review Request 128618: Fix creating symlink in Folder View

2016-08-07 Thread Chinmoy Ranjan Pradhan 


> On Aug. 6, 2016, 12:13 p.m., David Faure wrote:
> > src/core/copyjob.cpp, line 1531
> > 
> >
> > CopyJob stats the destination already, no need to do it again.
> > 
> > See line 410, the local path for the dest is even stored already:
> > m_dest = QUrl::fromLocalFile(sLocalPath);
> > 
> > So you should be able to just use if (m_dest.isLocalFile()) { ... } 
> > here.
> 
> Chinmoy Ranjan Pradhan wrote:
> In case of symlinks KIO::stat will fail because the destination doesn't 
> exist at the time of stat.
> 
> David Faure wrote:
> Wrong, it's stating the destination *directory*.
> 
> Chinmoy Ranjan Pradhan wrote:
> CopyJob will stat the destination directory only if it has been passed as 
> a parameter. But in KNewFileMenu the url of final link that is going to be 
> created is passed to KIO::link(this is also the case with KIO::copyAs as 
> well). That's why the stating fails.
> 
> (I used bunch of debug statements to confirm this failure)
> 
> David Faure wrote:
> Then KNewFileMenu should use KIO::linkAs rather than KIO::link.
> 
> (Not sure this will change what is being stat'ed though, please check)

I dont think using KIO::linkAs will make any difference. In its implementation 
*asMethod* is set to false. So its as good as KIO::link.


- Chinmoy


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128618/#review98157
---


On Aug. 6, 2016, 11:53 a.m., Chinmoy Ranjan Pradhan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128618/
> ---
> 
> (Updated Aug. 6, 2016, 11:53 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> KIO::link creates symlink when either protocol+host+port+username+password of 
> the source and the link are same or the link is going to be created locally. 
> In case of plasma's folder view none of the above cases are true therefore 
> creating a symlink in folder view plasmoid gives an error.  
> This patch aims to fix this issue.
> 
> 
> Diffs
> -
> 
>   src/core/copyjob.cpp c4c6b2c 
> 
> Diff: https://git.reviewboard.kde.org/r/128618/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> error message
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/06/d4da6ff3-53d8-49d1-a826-0c8cf12d7aa0__symlink_folderview.png
> 
> 
> Thanks,
> 
> Chinmoy Ranjan Pradhan
> 
>

Re: Review Request 128618: Fix creating symlink in Folder View

2016-08-07 Thread David Faure 


> On Aug. 6, 2016, 12:13 p.m., David Faure wrote:
> > src/core/copyjob.cpp, line 1531
> > 
> >
> > CopyJob stats the destination already, no need to do it again.
> > 
> > See line 410, the local path for the dest is even stored already:
> > m_dest = QUrl::fromLocalFile(sLocalPath);
> > 
> > So you should be able to just use if (m_dest.isLocalFile()) { ... } 
> > here.
> 
> Chinmoy Ranjan Pradhan wrote:
> In case of symlinks KIO::stat will fail because the destination doesn't 
> exist at the time of stat.
> 
> David Faure wrote:
> Wrong, it's stating the destination *directory*.
> 
> Chinmoy Ranjan Pradhan wrote:
> CopyJob will stat the destination directory only if it has been passed as 
> a parameter. But in KNewFileMenu the url of final link that is going to be 
> created is passed to KIO::link(this is also the case with KIO::copyAs as 
> well). That's why the stating fails.
> 
> (I used bunch of debug statements to confirm this failure)

Then KNewFileMenu should use KIO::linkAs rather than KIO::link.

(Not sure this will change what is being stat'ed though, please check)


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128618/#review98157
---


On Aug. 6, 2016, 11:53 a.m., Chinmoy Ranjan Pradhan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128618/
> ---
> 
> (Updated Aug. 6, 2016, 11:53 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> KIO::link creates symlink when either protocol+host+port+username+password of 
> the source and the link are same or the link is going to be created locally. 
> In case of plasma's folder view none of the above cases are true therefore 
> creating a symlink in folder view plasmoid gives an error.  
> This patch aims to fix this issue.
> 
> 
> Diffs
> -
> 
>   src/core/copyjob.cpp c4c6b2c 
> 
> Diff: https://git.reviewboard.kde.org/r/128618/diff/
> 
> 
> Testing
> ---
> 
> 
> File Attachments
> 
> 
> error message
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/08/06/d4da6ff3-53d8-49d1-a826-0c8cf12d7aa0__symlink_folderview.png
> 
> 
> Thanks,
> 
> Chinmoy Ranjan Pradhan
> 
>