Re: Review Request 128759: Show shortcut for New Folder action

[Elvis Angelaccio]

> On Aug. 25, 2016, 10:53 p.m., Albert Astals Cid wrote:
> > src/filewidgets/knewfilemenu.cpp, line 804
> > 
> >
> > Previously createDirectory was called unconditionally and now it is 
> > not, isn't that a problem?
> 
> Elvis Angelaccio wrote:
> Only if the action's triggered signal is not connected to the 
> createDirectory slot. I updated the apidox with this info, but yeah we can't 
> be 100% sure (unless there is a way to check whether a given signal is 
> connected to a given slot - perhaps some moc black magic?)
> 
> Albert Astals Cid wrote:
> It seems a bit convoluted to me, if you're not using a "create_dir" 
> action, createDirectory() will be automatically called for you, but if you're 
> using a "create_dir" you need to call createDirectory() manually? Why not 
> call createDirectory() in both cases?

We could do that, but then we also need to patch Dolphin to remove its 
connection to createDirectory() (otherwise the dialog is shown twice). If we go 
this way, I think we could even consider deprecating createDirectory() since it 
would be no longer necessary...


- Elvis


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128759/#review98665
---


On Aug. 26, 2016, 12:48 p.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128759/
> ---
> 
> (Updated Aug. 26, 2016, 12:48 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Bugs: 366075
> https://bugs.kde.org/show_bug.cgi?id=366075
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Dolphin sets a F10 shortcut to create new folders, but this shortcut doesn't 
> show up near the action. This happens because the action is created by 
> KNewFileMenu which doesn't know about the shortcut. Since we pass an action 
> collection to KNewFileMenu, this issue can be easily fixed by looking up a 
> fixed action key (e.g. `create_dir`, already used by Dolphin) and assuming 
> that the client code sets a shortcut for this action.
> 
> We just need to keep track whether we find such an action in the action 
> collection (otherwise "New -> Folder..." in Dolphin opens the dialog twice).
> 
> 
> Diffs
> -
> 
>   src/filewidgets/knewfilemenu.h dfc808b9072c118031d2ed675a6578e192f7abf6 
>   src/filewidgets/knewfilemenu.cpp a340429f5b7f99842747c6805187256e00179f22 
> 
> Diff: https://git.reviewboard.kde.org/r/128759/diff/
> 
> 
> Testing
> ---
> 
> Make sure that "New -> Folder" shows F10 as shortcut in Dolphin.
> Make sure that triggering the action doesn't show the dialog twice.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

Re: Review Request 128759: Show shortcut for New Folder action

[Albert Astals Cid]

> On Aug. 25, 2016, 10:53 p.m., Albert Astals Cid wrote:
> > src/filewidgets/knewfilemenu.cpp, line 804
> > 
> >
> > Previously createDirectory was called unconditionally and now it is 
> > not, isn't that a problem?
> 
> Elvis Angelaccio wrote:
> Only if the action's triggered signal is not connected to the 
> createDirectory slot. I updated the apidox with this info, but yeah we can't 
> be 100% sure (unless there is a way to check whether a given signal is 
> connected to a given slot - perhaps some moc black magic?)

It seems a bit convoluted to me, if you're not using a "create_dir" action, 
createDirectory() will be automatically called for you, but if you're using a 
"create_dir" you need to call createDirectory() manually? Why not call 
createDirectory() in both cases?


- Albert


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128759/#review98665
---


On Aug. 26, 2016, 12:48 p.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128759/
> ---
> 
> (Updated Aug. 26, 2016, 12:48 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Bugs: 366075
> https://bugs.kde.org/show_bug.cgi?id=366075
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Dolphin sets a F10 shortcut to create new folders, but this shortcut doesn't 
> show up near the action. This happens because the action is created by 
> KNewFileMenu which doesn't know about the shortcut. Since we pass an action 
> collection to KNewFileMenu, this issue can be easily fixed by looking up a 
> fixed action key (e.g. `create_dir`, already used by Dolphin) and assuming 
> that the client code sets a shortcut for this action.
> 
> We just need to keep track whether we find such an action in the action 
> collection (otherwise "New -> Folder..." in Dolphin opens the dialog twice).
> 
> 
> Diffs
> -
> 
>   src/filewidgets/knewfilemenu.h dfc808b9072c118031d2ed675a6578e192f7abf6 
>   src/filewidgets/knewfilemenu.cpp a340429f5b7f99842747c6805187256e00179f22 
> 
> Diff: https://git.reviewboard.kde.org/r/128759/diff/
> 
> 
> Testing
> ---
> 
> Make sure that "New -> Folder" shows F10 as shortcut in Dolphin.
> Make sure that triggering the action doesn't show the dialog twice.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 162 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/162/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Sat, 27 Aug 2016 20:21:50 +
Build duration: 5 min 47 sec

CHANGE SET
Revision cb6c63f9613a27dca47a285fb05614113d81b3c2 by kainz.a: (fix stylesheet 
stuff in computer icon)
  change: edit src/desktoptheme/breeze/icons/computer.svgz


JUNIT RESULTS

Name: (root) Failed: 2 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 
15 test(s)Failed: TestSuite.plasma-sortfiltermodeltestFailed: 
TestSuite.plasma-storagetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 66/111 (59%)CLASSES 66/111 (59%)LINE 4036/11067 
(36%)CONDITIONAL 2154/8291 (26%)

By packages
  
autotests
FILES 22/22 (100%)CLASSES 22/22 (100%)LINE 825/869 
(95%)CONDITIONAL 531/1032 (51%)
src.declarativeimports.core
FILES 9/18 (50%)CLASSES 9/18 (50%)LINE 501/1880 
(27%)CONDITIONAL 200/1154 (17%)
src.plasma
FILES 12/20 (60%)CLASSES 12/20 (60%)LINE 1588/3603 
(44%)CONDITIONAL 905/2698 (34%)
src.plasma.packagestructure
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 54/66 (82%)CONDITIONAL 
7/22 (32%)
src.plasma.private
FILES 8/22 (36%)CLASSES 8/22 (36%)LINE 666/1564 
(43%)CONDITIONAL 340/1018 (33%)
src.plasma.scripting
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 37/181 (20%)CONDITIONAL 
14/106 (13%)
src.plasmaquick
FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 323/1659 
(19%)CONDITIONAL 150/1269 (12%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)
src.scriptengines.qml.plasmoid
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1132 (1%)CONDITIONAL 
1/970 (0%)

Re: Review Request 128773: Revert "Don't use QQuickWidget::quickWindow() as it was added in Qt 5.5"

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128773/#review98728
---


Fix it, then Ship it!





src/kcmoduleqml.cpp (line 114)


Then you don't need this either.


- David Edmundson


On Aug. 26, 2016, 5 p.m., Rohan Garg wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128773/
> ---
> 
> (Updated Aug. 26, 2016, 5 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kcmutils
> 
> 
> Description
> ---
> 
> This reverts commit 5432c3edf5e074f1e951e6ecc682f7a400e2818f.
> 
> kcmutils now depends on Qt 5.5 so it should be fine to go in.
> 
> 
> Diffs
> -
> 
>   src/kcmoduleqml.cpp 1165c61 
> 
> Diff: https://git.reviewboard.kde.org/r/128773/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Rohan Garg
> 
>

[Differential] [Commented On] D2545: Cleanup KSharedUiServerProxy before qApp exists

[dfaure (David Faure)]

dfaure added a comment.


  Hmm can you check if https://codereview.qt-project.org/161056 fixes it?

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2545

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kfunk, vonreth, dfaure
Cc: #frameworks

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 253 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/253/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 27 Aug 2016 08:33:28 +
Build duration: 10 min

CHANGE SET
Revision 51021ef05e4254924bb7e71f2317543f1a42 by ivan.cukic: (Allows only 
one level of recursion)
  change: edit src/vimode/emulatedcommandbar/emulatedcommandbar.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 55 test(s), Skipped: 0 test(s), Total: 
55 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 24/28 (86%)FILES 294/330 (89%)CLASSES 294/330 (89%)LINE 33026/49326 
(67%)CONDITIONAL 16757/32850 (51%)

By packages
  
autotests.src
FILES 48/48 (100%)CLASSES 48/48 (100%)LINE 4077/4390 
(93%)CONDITIONAL 1927/3920 (49%)
autotests.src.vimode
FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 5525/5569 
(99%)CONDITIONAL 897/1658 (54%)
src.buffer
FILES 14/15 (93%)CLASSES 14/15 (93%)LINE 1617/1759 
(92%)CONDITIONAL 1255/1622 (77%)
src.completion
FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 1754/3102 
(57%)CONDITIONAL 1206/2798 (43%)
src.completion.expandingtree
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 184/464 (40%)CONDITIONAL 
79/354 (22%)
src.dialogs
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/935 (0%)CONDITIONAL 0/274 
(0%)
src.document
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 1808/3214 
(56%)CONDITIONAL 1498/3191 (47%)
src.export
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 106/125 (85%)CONDITIONAL 
106/152 (70%)
src.include.ktexteditor
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 203/244 
(83%)CONDITIONAL 144/228 (63%)
src.inputmode
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 172/326 (53%)CONDITIONAL 
40/85 (47%)
src.mode
FILES 5/6 (83%)CLASSES 5/6 (83%)LINE 159/423 (38%)CONDITIONAL 
97/269 (36%)
src.printing
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/885 (0%)CONDITIONAL 0/294 
(0%)
src.render
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 914/1225 
(75%)CONDITIONAL 606/932 (65%)
src.schema
FILES 2/9 (22%)CLASSES 2/9 (22%)LINE 21/1538 (1%)CONDITIONAL 
7/697 (1%)
src.script
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 700/1055 
(66%)CONDITIONAL 294/556 (53%)
src.search
FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 1012/1389 
(73%)CONDITIONAL 565/904 (63%)
src.spellcheck
FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 372/1336 (28%)CONDITIONAL 
205/820 (25%)
src.swapfile
FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 119/365 (33%)CONDITIONAL 
57/195 (29%)
src.syntax
FILES 11/12 (92%)CLASSES 11/12 (92%)LINE 1662/2151 
(77%)CONDITIONAL 1059/1784 (59%)
src.syntax.data
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 51/69 (74%)CONDITIONAL 
73/92 (79%)
src.undo
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 671/772 (87%)CONDITIONAL 
321/448 (72%)
src.utils
FILES 33/36 (92%)CLASSES 33/36 (92%)LINE 2570/3913 
(66%)CONDITIONAL 1332/2728 (49%)
src.variableeditor
FILES 0/7 (0%)CLASSES 0/7 (0%)LINE 0/668 (0%)CONDITIONAL 0/170 
(0%)
src.view
FILES 15/19 (79%)CLASSES 15/19 (79%)LINE 3298/6281 
(53%)CONDITIONAL 1486/3788 (39%)
src.vimode
FILES 34/34 (100%)CLASSES 34/34 (100%)LINE 1876/2340 
(80%)CONDITIONAL 1028/1751 (59%)
src.vimode.config
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/134 (0%)CONDITIONAL 0/90 
(0%)
src.vimode.emulatedcommandbar
FILES 12/12 (100%)CLASSES 12/12 (100%)LINE 902/914 
(99%)CONDITIONAL 615/680 (90%)
src.vimode.modes
FILES 10/10 (100%)CLASSES 10/10 (100%)LINE 3253/3740 
(87%)CONDITIONAL 1860/2370 (78%)

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 253 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/253/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sat, 27 Aug 2016 08:33:28 +
Build duration: 10 min

CHANGE SET
Revision 51021ef05e4254924bb7e71f2317543f1a42 by ivan.cukic: (Allows only 
one level of recursion)
  change: edit src/vimode/emulatedcommandbar/emulatedcommandbar.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 55 test(s), Skipped: 0 test(s), Total: 
55 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 24/28 (86%)FILES 294/330 (89%)CLASSES 294/330 (89%)LINE 33026/49326 
(67%)CONDITIONAL 16757/32850 (51%)

By packages
  
autotests.src
FILES 48/48 (100%)CLASSES 48/48 (100%)LINE 4077/4390 
(93%)CONDITIONAL 1927/3920 (49%)
autotests.src.vimode
FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 5525/5569 
(99%)CONDITIONAL 897/1658 (54%)
src.buffer
FILES 14/15 (93%)CLASSES 14/15 (93%)LINE 1617/1759 
(92%)CONDITIONAL 1255/1622 (77%)
src.completion
FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 1754/3102 
(57%)CONDITIONAL 1206/2798 (43%)
src.completion.expandingtree
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 184/464 (40%)CONDITIONAL 
79/354 (22%)
src.dialogs
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/935 (0%)CONDITIONAL 0/274 
(0%)
src.document
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 1808/3214 
(56%)CONDITIONAL 1498/3191 (47%)
src.export
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 106/125 (85%)CONDITIONAL 
106/152 (70%)
src.include.ktexteditor
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 203/244 
(83%)CONDITIONAL 144/228 (63%)
src.inputmode
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 172/326 (53%)CONDITIONAL 
40/85 (47%)
src.mode
FILES 5/6 (83%)CLASSES 5/6 (83%)LINE 159/423 (38%)CONDITIONAL 
97/269 (36%)
src.printing
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/885 (0%)CONDITIONAL 0/294 
(0%)
src.render
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 914/1225 
(75%)CONDITIONAL 606/932 (65%)
src.schema
FILES 2/9 (22%)CLASSES 2/9 (22%)LINE 21/1538 (1%)CONDITIONAL 
7/697 (1%)
src.script
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 700/1055 
(66%)CONDITIONAL 294/556 (53%)
src.search
FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 1012/1389 
(73%)CONDITIONAL 565/904 (63%)
src.spellcheck
FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 372/1336 (28%)CONDITIONAL 
205/820 (25%)
src.swapfile
FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 119/365 (33%)CONDITIONAL 
57/195 (29%)
src.syntax
FILES 11/12 (92%)CLASSES 11/12 (92%)LINE 1662/2151 
(77%)CONDITIONAL 1059/1784 (59%)
src.syntax.data
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 51/69 (74%)CONDITIONAL 
73/92 (79%)
src.undo
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 671/772 (87%)CONDITIONAL 
321/448 (72%)
src.utils
FILES 33/36 (92%)CLASSES 33/36 (92%)LINE 2570/3913 
(66%)CONDITIONAL 1332/2728 (49%)
src.variableeditor
FILES 0/7 (0%)CLASSES 0/7 (0%)LINE 0/668 (0%)CONDITIONAL 0/170 
(0%)
src.view
FILES 15/19 (79%)CLASSES 15/19 (79%)LINE 3298/6281 
(53%)CONDITIONAL 1486/3788 (39%)
src.vimode
FILES 34/34 (100%)CLASSES 34/34 (100%)LINE 1876/2340 
(80%)CONDITIONAL 1028/1751 (59%)
src.vimode.config
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/134 (0%)CONDITIONAL 0/90 
(0%)
src.vimode.emulatedcommandbar
FILES 12/12 (100%)CLASSES 12/12 (100%)LINE 902/914 
(99%)CONDITIONAL 615/680 (90%)
src.vimode.modes
FILES 10/10 (100%)CLASSES 10/10 (100%)LINE 3253/3740 
(87%)CONDITIONAL 1860/2370 (78%)