Re: Fwd: KStandardAction::showMenubar and native menubars

[René J . V . Bertin]

On Wednesday October 12 2016 01:12:14 Marko Käning wrote:

> > From: Albert Astals Cid 

> > My current (yet to implement/test) idea is have 
> > KStandardAction::showMenubar check all the menubars of the top level 
> > windows of the app and if they are all marked as native, then return a 
> > dummy QAction that is not inserted in the menubar/actionCollection and that 
> > already returns "true" for checked.
> >  
> > This way the app thinks it got a real action to control the menubar status, 
> > but it is never shown to the user.
> >  
> > What do you think, do you think it could work or it is trying to be too 
> > smart and it'll break somehow?

A "long" time ago I patched a menu(bar) related issue in KDE4 apps (but 
possibly in Qt4), with some help from Thomas Luebking. I'd have to hunt down 
the patch to see exactly how this was done, but IIRC it boiled down to checking 
the parent recursively. A native Mac menubar on OS X never has a parent.

I don't disagree with the idea of hiding the menu item when it cannot work, but 
I think we'll have to ensure that the algorithm doesn't simply assume that 
certain platforms have a native menubar. IOW, the algorithm should detect at 
runtime what kind of menubar is being used.

In fact, if you look at Qt5's own code the Qt::AA_DontUseNativeMenuBar 
attribute is ON by default, and is supposed to be turned off by platform 
plugins. An application can turn the attribute back on, and on OS X there can 
be a good reason for that which is related to menu item reuse. I've evoked that 
issue often enough so I won't go into details here, but suffice it to say that 
with the current Qt5 QMenu/Bar implementation you can end up with missing or 
inactive menu items if they're  reused in the native menubar and elsewhere.
That's a very lowlevel Qt5 issue, and the only reliable way around it I've 
found to date is to disable the native menubar in applications where the 
symptoms are particularly annoying (as in my last Kate builds).

A thought that just occurs to me: one way to deal with the "hide/show menubar" 
action would be to repurpose it to allow users to use a non-native menubar 
where that's possible. It'd be a bit of a geeky feature but so is hiding the 
menubar IMHO.

BTW, it seems hat the currently the menubar is detected as being hidden on OS 
X. At least, when I fire up an application with a non-native menubar (or using 
the XCB QPA plugin), the menubar is hidden at first. A bit surprising.

R

KStandardAction::showMenubar and native menubars

[Albert Astals Cid]

On platforms with native menubars (Mac, Unity) the showMenuBar action makes no 
sense since 
the menubar is integrated in the desktop shell instead of the application so 
the application gains 
no space by hiding/showing the menubar (sometimes it isn't possible to hide it 
at all)

So on thos platforms havign a menu item that does virtually nothing is bad and 
can be a little 
disconcerting.

I was thinking if we could somehow fix it centrally in frameworks instead of 
patching every app 
that has a KStandardAction::showMenubar

My current (yet to implement/test) idea is have KStandardAction::showMenubar 
check all the 
menubars of the top level windows of the app and if they are all marked as 
native, then return a 
dummy QAction that is not inserted in the menubar/actionCollection and that 
already returns 
"true" for checked.

This way the app thinks it got a real action to control the menubar status, but 
it is never shown 
to the user.

What do you think, do you think it could work or it is trying to be too smart 
and it'll break 
somehow?

Cheers,
  Albert

Review Request 129155: reviewboard-am: add Python 3 compatibility

[Peter Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129155/
---

Review request for KDE Frameworks.


Repository: kde-dev-scripts


Description
---

Tested with Python 2.7.12 and 3.5.2.


Diffs
-

  reviewboard-am e96c9a91c8e9186f8a24a03c551936f93a41d4e2 

Diff: https://git.reviewboard.kde.org/r/129155/diff/


Testing
---

(Note: changes the same context as review 129154.)


Thanks,

Peter Wu

Review Request 129154: reviewboard-am: add marker to ignore following text

[Peter Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129154/
---

Review request for KDE Frameworks and Aurélien Gâteau.


Repository: kde-dev-scripts


Description
---

Raw patches from reviewboard can contain additional text, ignore these
in favor of the commit message based on the description.


Diffs
-

  reviewboard-am e96c9a91c8e9186f8a24a03c551936f93a41d4e2 

Diff: https://git.reviewboard.kde.org/r/129154/diff/


Testing
---

Tested with https://git.reviewboard.kde.org/r/129137/ which somehow has 
retained the text in the diff: 
https://git.reviewboard.kde.org/r/129137/diff/raw/


Thanks,

Peter Wu

Re: Review Request 126291: initial implementation of a platform plugin for OS X (WIP)

[René J . V . Bertin]

> On Feb. 25, 2016, 8:26 a.m., Martin Gräßlin wrote:
> > src/kwindowsystem.cpp, lines 465-467
> > 
> >
> > I would prefer to not introduce new platform specific code in the 
> > shared part.
> > 
> > The idea you have here is right, but it's not OSX specific, the same 
> > applies for e.g. Wayland
> 
> René J.V. Bertin wrote:
> I agree. This function should probably be moved to the plugin. That's 
> just not a responsability I'd love to take for X11 and Wayland, otherwise I'd 
> have implemented this in my patch.
> 
> Can you or one of the other KWindowSystem devs take care of this on the 
> current supported platforms, so that I can adapt this patch?

Ping?


- René J.V.


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126291/#review92753
---


On March 4, 2016, 8:19 p.m., René J.V. Bertin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126291/
> ---
> 
> (Updated March 4, 2016, 8:19 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and KDE Frameworks.
> 
> 
> Repository: kwindowsystem
> 
> 
> Description
> ---
> 
> KWindowSystem has been lacking a platform plugin for OS X. This RR presents a 
> "backport" of the modified KDE4 KWindowSystem implementation that has been 
> used in the MacPorts kdelibs4 port for the last 2 or 3 (or more) years.
> 
> I have made some initial steps to remove deprecated Carbon API calls, but 
> this is clearly a work in progress.
> 
> Open questions include
> - is there any justification to run an event handler (or Cocoa observer) to 
> keep track of running applications, possibly even listing all their open 
> windows?
> - is there any use for the Qt event listener framework (cf. the 
> NETEventFilter in the X11 plugin)? I haven't yet had time to try to figure 
> out what this "could be good for", and am very open to suggestions in this 
> departments.
> - one application for such an event filter would be a listener that catches 
> the opening and closing of all windows by the running process, and keeps 
> track of their `WId`s. A new method could then be added (to `KWindowInfo`?) 
> to distinguish `WId`s created by the running application from "foreign" ones 
> (useful also on Wayland and MS Windows).
> 
> `KWindowSystem::setMainWindow` should become a front for payload provided by 
> the plugins. I'll leave that to the regular/official maintainer(s) of this 
> framework.
> 
> This code could probably do with *lots* of comments; I'll try to add them as 
> questions about this or that bit of code arise.
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt 65ed8d4 
>   autotests/kwindowsystem_threadtest.cpp a142bae 
>   src/debug_p.h 5ef8996 
>   src/debug_p.cpp 72abfb7 
>   src/kwindowsystem.cpp 407a67d 
>   src/platforms/osx/CMakeLists.txt 4fc3347 
>   src/platforms/osx/cocoa.json PRE-CREATION 
>   src/platforms/osx/kkeyserver.cpp 3ddb921 
>   src/platforms/osx/kwindowinfo.cpp e8555bb 
>   src/platforms/osx/kwindowinfo.mm PRE-CREATION 
>   src/platforms/osx/kwindowinfo_mac_p.h c8f307e 
>   src/platforms/osx/kwindowinfo_p_cocoa.h PRE-CREATION 
>   src/platforms/osx/kwindowsystem.cpp 1758829 
>   src/platforms/osx/kwindowsystem_mac_p.h PRE-CREATION 
>   src/platforms/osx/kwindowsystem_macobjc.mm PRE-CREATION 
>   src/platforms/osx/kwindowsystem_p_cocoa.h PRE-CREATION 
>   src/platforms/osx/plugin.h PRE-CREATION 
>   src/platforms/osx/plugin.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/126291/diff/
> 
> 
> Testing
> ---
> 
> On OS X 10.9.5 with Qt 5.5.1 and frameworks 5.16.0 .
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 215 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/215/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Tue, 11 Oct 2016 15:24:47 +
Build duration: 5 min 51 sec

CHANGE SET
Revision b0a5bc09efee3917ec11d713237f6941a8ef744d by Marco Martin: (use 
kwayland for shadows and dialog positioning)
  change: edit src/plasmaquick/dialogshadows_p.h
  change: edit CMakeLists.txt
  change: edit src/plasmaquick/CMakeLists.txt
  change: edit src/plasmaquick/dialogshadows.cpp
  change: edit src/plasmaquick/dialog.cpp
  change: edit src/plasma/config-plasma.h.cmake

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 215 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/215/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Tue, 11 Oct 2016 15:24:47 +
Build duration: 6 min 6 sec

CHANGE SET
Revision b0a5bc09efee3917ec11d713237f6941a8ef744d by Marco Martin: (use 
kwayland for shadows and dialog positioning)
  change: edit src/plasmaquick/CMakeLists.txt
  change: edit CMakeLists.txt
  change: edit src/plasmaquick/dialog.cpp
  change: edit src/plasmaquick/dialogshadows_p.h
  change: edit src/plasmaquick/dialogshadows.cpp
  change: edit src/plasma/config-plasma.h.cmake

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 215 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/215/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Tue, 11 Oct 2016 15:24:47 +
Build duration: 6 min 33 sec

CHANGE SET
Revision b0a5bc09efee3917ec11d713237f6941a8ef744d by Marco Martin: (use 
kwayland for shadows and dialog positioning)
  change: edit src/plasmaquick/CMakeLists.txt
  change: edit src/plasmaquick/dialogshadows.cpp
  change: edit src/plasmaquick/dialogshadows_p.h
  change: edit CMakeLists.txt
  change: edit src/plasmaquick/dialog.cpp
  change: edit src/plasma/config-plasma.h.cmake

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 215 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/215/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Tue, 11 Oct 2016 15:24:47 +
Build duration: 4 min 38 sec

CHANGE SET
Revision b0a5bc09efee3917ec11d713237f6941a8ef744d by Marco Martin: (use 
kwayland for shadows and dialog positioning)
  change: edit src/plasmaquick/dialog.cpp
  change: edit src/plasmaquick/dialogshadows.cpp
  change: edit src/plasmaquick/dialogshadows_p.h
  change: edit CMakeLists.txt
  change: edit src/plasmaquick/CMakeLists.txt
  change: edit src/plasma/config-plasma.h.cmake

Review Request 129150: Use less deprecated API

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129150/
---

Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

Make it easier to look at the compilation output.


Diffs
-

  src/plasma/containment.cpp 1c49f05 
  src/plasma/scripting/appletscript.cpp a2342a3 
  src/plasmaquick/appletquickitem.cpp 2f100b8 
  src/plasmaquick/configview.cpp 73e4974 
  src/plasmaquick/containmentview.cpp 43f0fdd 
  src/plasmaquick/view.cpp 6ab0012 
  src/scriptengines/qml/plasmoid/containmentinterface.cpp 160cdd7 
  src/scriptengines/qml/plasmoid/declarativeappletscript.cpp 173573e 

Diff: https://git.reviewboard.kde.org/r/129150/diff/


Testing
---


Thanks,

Aleix Pol Gonzalez

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 214 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/214/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Tue, 11 Oct 2016 13:34:16 +
Build duration: 8 min 54 sec

CHANGE SET
Revision ba9a8a16ab49e739428f263cf61234158b7e59bd by aleixpol: (Fix loading 
plasmoids by absolute path)
  change: edit src/plasmaquick/configmodel.cpp
  change: edit src/plasma/private/applet_p.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 
16 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 81/119 (68%)CLASSES 81/119 (68%)LINE 4917/11705 
(42%)CONDITIONAL 2653/8844 (30%)

By packages
  
autotests
FILES 28/28 (100%)CLASSES 28/28 (100%)LINE 1005/1050 
(96%)CONDITIONAL 634/1238 (51%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 648/2128 
(30%)CONDITIONAL 300/1308 (23%)
src.plasma
FILES 14/20 (70%)CLASSES 14/20 (70%)LINE 1660/3605 
(46%)CONDITIONAL 961/2707 (36%)
src.plasma.packagestructure
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 54/66 (82%)CONDITIONAL 
7/22 (32%)
src.plasma.private
FILES 14/24 (58%)CLASSES 14/24 (58%)LINE 927/1639 
(57%)CONDITIONAL 431/1068 (40%)
src.plasma.scripting
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 36/180 (20%)CONDITIONAL 
14/106 (13%)
src.plasmaquick
FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 545/1788 
(30%)CONDITIONAL 299/1399 (21%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)
src.scriptengines.qml.plasmoid
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1136 (1%)CONDITIONAL 
1/974 (0%)

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 214 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/214/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Tue, 11 Oct 2016 13:34:16 +
Build duration: 8 min 54 sec

CHANGE SET
Revision ba9a8a16ab49e739428f263cf61234158b7e59bd by aleixpol: (Fix loading 
plasmoids by absolute path)
  change: edit src/plasmaquick/configmodel.cpp
  change: edit src/plasma/private/applet_p.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 
16 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 81/119 (68%)CLASSES 81/119 (68%)LINE 4917/11705 
(42%)CONDITIONAL 2653/8844 (30%)

By packages
  
autotests
FILES 28/28 (100%)CLASSES 28/28 (100%)LINE 1005/1050 
(96%)CONDITIONAL 634/1238 (51%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 648/2128 
(30%)CONDITIONAL 300/1308 (23%)
src.plasma
FILES 14/20 (70%)CLASSES 14/20 (70%)LINE 1660/3605 
(46%)CONDITIONAL 961/2707 (36%)
src.plasma.packagestructure
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 54/66 (82%)CONDITIONAL 
7/22 (32%)
src.plasma.private
FILES 14/24 (58%)CLASSES 14/24 (58%)LINE 927/1639 
(57%)CONDITIONAL 431/1068 (40%)
src.plasma.scripting
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 36/180 (20%)CONDITIONAL 
14/106 (13%)
src.plasmaquick
FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 545/1788 
(30%)CONDITIONAL 299/1399 (21%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)
src.scriptengines.qml.plasmoid
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1136 (1%)CONDITIONAL 
1/974 (0%)

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 214 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/214/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Tue, 11 Oct 2016 13:34:16 +
Build duration: 6 min 38 sec

CHANGE SET
Revision ba9a8a16ab49e739428f263cf61234158b7e59bd by aleixpol: (Fix loading 
plasmoids by absolute path)
  change: edit src/plasmaquick/configmodel.cpp
  change: edit src/plasma/private/applet_p.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 
15 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 78/115 (68%)CLASSES 78/115 (68%)LINE 4477/11190 
(40%)CONDITIONAL 2350/8440 (28%)

By packages
  
autotests
FILES 26/26 (100%)CLASSES 26/26 (100%)LINE 935/979 
(96%)CONDITIONAL 596/1162 (51%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 561/1880 
(30%)CONDITIONAL 217/1152 (19%)
src.plasma
FILES 14/20 (70%)CLASSES 14/20 (70%)LINE 1658/3605 
(46%)CONDITIONAL 953/2707 (35%)
src.plasma.packagestructure
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 54/66 (82%)CONDITIONAL 
7/22 (32%)
src.plasma.private
FILES 13/22 (59%)CLASSES 13/22 (59%)LINE 867/1566 
(55%)CONDITIONAL 405/1022 (40%)
src.plasma.scripting
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 36/180 (20%)CONDITIONAL 
14/106 (13%)
src.plasmaquick
FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 324/1665 
(19%)CONDITIONAL 151/1273 (12%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)
src.scriptengines.qml.plasmoid
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1136 (1%)CONDITIONAL 
1/974 (0%)

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 214 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/214/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Tue, 11 Oct 2016 13:34:16 +
Build duration: 6 min 38 sec

CHANGE SET
Revision ba9a8a16ab49e739428f263cf61234158b7e59bd by aleixpol: (Fix loading 
plasmoids by absolute path)
  change: edit src/plasmaquick/configmodel.cpp
  change: edit src/plasma/private/applet_p.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 
15 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 78/115 (68%)CLASSES 78/115 (68%)LINE 4477/11190 
(40%)CONDITIONAL 2350/8440 (28%)

By packages
  
autotests
FILES 26/26 (100%)CLASSES 26/26 (100%)LINE 935/979 
(96%)CONDITIONAL 596/1162 (51%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 561/1880 
(30%)CONDITIONAL 217/1152 (19%)
src.plasma
FILES 14/20 (70%)CLASSES 14/20 (70%)LINE 1658/3605 
(46%)CONDITIONAL 953/2707 (35%)
src.plasma.packagestructure
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 54/66 (82%)CONDITIONAL 
7/22 (32%)
src.plasma.private
FILES 13/22 (59%)CLASSES 13/22 (59%)LINE 867/1566 
(55%)CONDITIONAL 405/1022 (40%)
src.plasma.scripting
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 36/180 (20%)CONDITIONAL 
14/106 (13%)
src.plasmaquick
FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 324/1665 
(19%)CONDITIONAL 151/1273 (12%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)
src.scriptengines.qml.plasmoid
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1136 (1%)CONDITIONAL 
1/974 (0%)

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 214 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/214/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Tue, 11 Oct 2016 13:34:16 +
Build duration: 6 min 27 sec

CHANGE SET
Revision ba9a8a16ab49e739428f263cf61234158b7e59bd by aleixpol: (Fix loading 
plasmoids by absolute path)
  change: edit src/plasmaquick/configmodel.cpp
  change: edit src/plasma/private/applet_p.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 
16 test(s)Failed: TestSuite.plasma-dialogstatetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 81/119 (68%)CLASSES 81/119 (68%)LINE 4871/11705 
(42%)CONDITIONAL 2630/8844 (30%)

By packages
  
autotests
FILES 28/28 (100%)CLASSES 28/28 (100%)LINE 981/1050 
(93%)CONDITIONAL 619/1238 (50%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 648/2128 
(30%)CONDITIONAL 300/1308 (23%)
src.plasma
FILES 14/20 (70%)CLASSES 14/20 (70%)LINE 1660/3605 
(46%)CONDITIONAL 961/2707 (36%)
src.plasma.packagestructure
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 54/66 (82%)CONDITIONAL 
7/22 (32%)
src.plasma.private
FILES 14/24 (58%)CLASSES 14/24 (58%)LINE 917/1639 
(56%)CONDITIONAL 428/1068 (40%)
src.plasma.scripting
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 36/180 (20%)CONDITIONAL 
14/106 (13%)
src.plasmaquick
FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 533/1788 
(30%)CONDITIONAL 294/1399 (21%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)
src.scriptengines.qml.plasmoid
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1136 (1%)CONDITIONAL 
1/974 (0%)

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 214 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/214/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Tue, 11 Oct 2016 13:34:16 +
Build duration: 2 min 40 sec

CHANGE SET
Revision ba9a8a16ab49e739428f263cf61234158b7e59bd by aleixpol: (Fix loading 
plasmoids by absolute path)
  change: edit src/plasma/private/applet_p.cpp
  change: edit src/plasmaquick/configmodel.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 
15 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 78/115 (68%)CLASSES 78/115 (68%)LINE 4475/11190 
(40%)CONDITIONAL 2349/8440 (28%)

By packages
  
autotests
FILES 26/26 (100%)CLASSES 26/26 (100%)LINE 933/979 
(95%)CONDITIONAL 596/1162 (51%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 561/1880 
(30%)CONDITIONAL 217/1152 (19%)
src.plasma
FILES 14/20 (70%)CLASSES 14/20 (70%)LINE 1658/3605 
(46%)CONDITIONAL 953/2707 (35%)
src.plasma.packagestructure
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 54/66 (82%)CONDITIONAL 
7/22 (32%)
src.plasma.private
FILES 13/22 (59%)CLASSES 13/22 (59%)LINE 867/1566 
(55%)CONDITIONAL 404/1022 (40%)
src.plasma.scripting
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 36/180 (20%)CONDITIONAL 
14/106 (13%)
src.plasmaquick
FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 324/1665 
(19%)CONDITIONAL 151/1273 (12%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)
src.scriptengines.qml.plasmoid
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1136 (1%)CONDITIONAL 
1/974 (0%)

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 214 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/214/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Tue, 11 Oct 2016 13:34:16 +
Build duration: 2 min 40 sec

CHANGE SET
Revision ba9a8a16ab49e739428f263cf61234158b7e59bd by aleixpol: (Fix loading 
plasmoids by absolute path)
  change: edit src/plasma/private/applet_p.cpp
  change: edit src/plasmaquick/configmodel.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 
15 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 78/115 (68%)CLASSES 78/115 (68%)LINE 4475/11190 
(40%)CONDITIONAL 2349/8440 (28%)

By packages
  
autotests
FILES 26/26 (100%)CLASSES 26/26 (100%)LINE 933/979 
(95%)CONDITIONAL 596/1162 (51%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 561/1880 
(30%)CONDITIONAL 217/1152 (19%)
src.plasma
FILES 14/20 (70%)CLASSES 14/20 (70%)LINE 1658/3605 
(46%)CONDITIONAL 953/2707 (35%)
src.plasma.packagestructure
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 54/66 (82%)CONDITIONAL 
7/22 (32%)
src.plasma.private
FILES 13/22 (59%)CLASSES 13/22 (59%)LINE 867/1566 
(55%)CONDITIONAL 404/1022 (40%)
src.plasma.scripting
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 36/180 (20%)CONDITIONAL 
14/106 (13%)
src.plasmaquick
FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 324/1665 
(19%)CONDITIONAL 151/1273 (12%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)
src.scriptengines.qml.plasmoid
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1136 (1%)CONDITIONAL 
1/974 (0%)

Re: Review Request 129143: Fix loading plasmoids by absolute path, fixes configmodeltest

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129143/
---

(Updated Oct. 11, 2016, 1:33 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit ba9a8a16ab49e739428f263cf61234158b7e59bd by Aleix Pol to 
branch master.


Repository: plasma-framework


Description
---

We were not looking into the plugin directory when figuring out the applet path.


Diffs
-

  src/plasma/private/applet_p.cpp 624e4fe 
  src/plasmaquick/configmodel.cpp 975854a 

Diff: https://git.reviewboard.kde.org/r/129143/diff/


Testing
---

`configmodeltest` passes.


Thanks,

Aleix Pol Gonzalez

Re: Review Request 129143: Fix loading plasmoids by absolute path, fixes configmodeltest

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129143/#review99935
---


Ship it!




Ship It!

- Marco Martin


On Oct. 10, 2016, 9:48 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129143/
> ---
> 
> (Updated Oct. 10, 2016, 9:48 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> We were not looking into the plugin directory when figuring out the applet 
> path.
> 
> 
> Diffs
> -
> 
>   src/plasma/private/applet_p.cpp 624e4fe 
>   src/plasmaquick/configmodel.cpp 975854a 
> 
> Diff: https://git.reviewboard.kde.org/r/129143/diff/
> 
> 
> Testing
> ---
> 
> `configmodeltest` passes.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

Re: Review Request 129146: Fix emitting close when an event has no actions

[David Edmundson]

> On Oct. 11, 2016, 12:16 p.m., Anthony Fieroni wrote:
> > src/knotificationmanager.cpp, line 203
> > 
> >
> > n->close()
> 
> David Edmundson wrote:
> I did think about that, but what if the userspace code is:
> 
> KNotification *n = new KNoti..
> n->ref();
> n->sendEvent();
> 
> we wouldn't want to close immediately.
> 
> Anthony Fieroni wrote:
> User must *never* do that, ref/deref interface is only for manager.

It's documented as being available for user use:

https://api.kde.org/frameworks-api/frameworks-apidocs/frameworks/knotifications/html/classKNotification.html#ac37dbd2cccd26af667bea20a7df831c3

>void KNotification::ref(   )   

>The notification will automatically be closed if all presentations are 
>finished.

>if you want to show your own presentation in your application, you should use 
>this function, so it will not be automatically closed when there is nothing to 
>show.

>Don't forgot to deref, or the notification may be never closed if there is no 
>timeout.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129146/#review99930
---


On Oct. 11, 2016, 11:19 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129146/
> ---
> 
> (Updated Oct. 11, 2016, 11:19 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: knotifications
> 
> 
> Description
> ---
> 
> KNotificatitionManager::self() has an early check if a notification has
> no actions. If it has no actions it tries to close the notification
> early. However it's dereferencing an object that it has not referenced,
> sending the ref count to -1, a corrupt state that is not handled
> gracefully in KNotification, and we don't ever close the notification.
> 
> By referencing and dereferencing we're still calling the cleanup in
> KNotification (if applicable) but without sending the ref count negative.
> 
> This fixes ksmserver waiting for the logout sound to play; which
> currently never emits close, as the default setup has no logout sound.
> 
> 
> Diffs
> -
> 
>   autotests/knotification_test.cpp 5d063f1a19d7f5e4d8c77d7e6301e81223401b08 
>   src/knotificationmanager.cpp c315db9a3f17771d4095cfdc7982475949213a1c 
> 
> Diff: https://git.reviewboard.kde.org/r/129146/diff/
> 
> 
> Testing
> ---
> 
> Autotest that used to fail included
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

Re: Review Request 129146: Fix emitting close when an event has no actions

[Anthony Fieroni]

> On Oct. 11, 2016, 3:16 p.m., Anthony Fieroni wrote:
> > src/knotificationmanager.cpp, line 203
> > 
> >
> > n->close()
> 
> David Edmundson wrote:
> I did think about that, but what if the userspace code is:
> 
> KNotification *n = new KNoti..
> n->ref();
> n->sendEvent();
> 
> we wouldn't want to close immediately.

User must *never* do that, ref/deref interface is only for manager.


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129146/#review99930
---


On Oct. 11, 2016, 2:19 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129146/
> ---
> 
> (Updated Oct. 11, 2016, 2:19 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: knotifications
> 
> 
> Description
> ---
> 
> KNotificatitionManager::self() has an early check if a notification has
> no actions. If it has no actions it tries to close the notification
> early. However it's dereferencing an object that it has not referenced,
> sending the ref count to -1, a corrupt state that is not handled
> gracefully in KNotification, and we don't ever close the notification.
> 
> By referencing and dereferencing we're still calling the cleanup in
> KNotification (if applicable) but without sending the ref count negative.
> 
> This fixes ksmserver waiting for the logout sound to play; which
> currently never emits close, as the default setup has no logout sound.
> 
> 
> Diffs
> -
> 
>   autotests/knotification_test.cpp 5d063f1a19d7f5e4d8c77d7e6301e81223401b08 
>   src/knotificationmanager.cpp c315db9a3f17771d4095cfdc7982475949213a1c 
> 
> Diff: https://git.reviewboard.kde.org/r/129146/diff/
> 
> 
> Testing
> ---
> 
> Autotest that used to fail included
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

Re: Review Request 129146: Fix emitting close when an event has no actions

[David Edmundson]

> On Oct. 11, 2016, 12:16 p.m., Anthony Fieroni wrote:
> > src/knotificationmanager.cpp, line 203
> > 
> >
> > n->close()

I did think about that, but what if the userspace code is:

KNotification *n = new KNoti..
n->ref();
n->sendEvent();

we wouldn't want to close immediately.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129146/#review99930
---


On Oct. 11, 2016, 11:19 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129146/
> ---
> 
> (Updated Oct. 11, 2016, 11:19 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: knotifications
> 
> 
> Description
> ---
> 
> KNotificatitionManager::self() has an early check if a notification has
> no actions. If it has no actions it tries to close the notification
> early. However it's dereferencing an object that it has not referenced,
> sending the ref count to -1, a corrupt state that is not handled
> gracefully in KNotification, and we don't ever close the notification.
> 
> By referencing and dereferencing we're still calling the cleanup in
> KNotification (if applicable) but without sending the ref count negative.
> 
> This fixes ksmserver waiting for the logout sound to play; which
> currently never emits close, as the default setup has no logout sound.
> 
> 
> Diffs
> -
> 
>   autotests/knotification_test.cpp 5d063f1a19d7f5e4d8c77d7e6301e81223401b08 
>   src/knotificationmanager.cpp c315db9a3f17771d4095cfdc7982475949213a1c 
> 
> Diff: https://git.reviewboard.kde.org/r/129146/diff/
> 
> 
> Testing
> ---
> 
> Autotest that used to fail included
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

Re: Review Request 129146: Fix emitting close when an event has no actions

[Anthony Fieroni]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129146/#review99930
---




src/knotificationmanager.cpp (line 203)


n->close()


- Anthony Fieroni


On Oct. 11, 2016, 2:19 p.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129146/
> ---
> 
> (Updated Oct. 11, 2016, 2:19 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: knotifications
> 
> 
> Description
> ---
> 
> KNotificatitionManager::self() has an early check if a notification has
> no actions. If it has no actions it tries to close the notification
> early. However it's dereferencing an object that it has not referenced,
> sending the ref count to -1, a corrupt state that is not handled
> gracefully in KNotification, and we don't ever close the notification.
> 
> By referencing and dereferencing we're still calling the cleanup in
> KNotification (if applicable) but without sending the ref count negative.
> 
> This fixes ksmserver waiting for the logout sound to play; which
> currently never emits close, as the default setup has no logout sound.
> 
> 
> Diffs
> -
> 
>   autotests/knotification_test.cpp 5d063f1a19d7f5e4d8c77d7e6301e81223401b08 
>   src/knotificationmanager.cpp c315db9a3f17771d4095cfdc7982475949213a1c 
> 
> Diff: https://git.reviewboard.kde.org/r/129146/diff/
> 
> 
> Testing
> ---
> 
> Autotest that used to fail included
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

Review Request 129146: Fix emitting close when an event has no actions

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129146/
---

Review request for KDE Frameworks.


Repository: knotifications


Description
---

KNotificatitionManager::self() has an early check if a notification has
no actions. If it has no actions it tries to close the notification
early. However it's dereferencing an object that it has not referenced,
sending the ref count to -1, a corrupt state that is not handled
gracefully in KNotification, and we don't ever close the notification.

By referencing and dereferencing we're still calling the cleanup in
KNotification (if applicable) but without sending the ref count negative.

This fixes ksmserver waiting for the logout sound to play; which
currently never emits close, as the default setup has no logout sound.


Diffs
-

  autotests/knotification_test.cpp 5d063f1a19d7f5e4d8c77d7e6301e81223401b08 
  src/knotificationmanager.cpp c315db9a3f17771d4095cfdc7982475949213a1c 

Diff: https://git.reviewboard.kde.org/r/129146/diff/


Testing
---

Autotest that used to fail included


Thanks,

David Edmundson

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 213 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/213/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Tue, 11 Oct 2016 10:32:14 +
Build duration: 10 min

CHANGE SET
Revision 98b7f48a895eeabb7d676726c0b7e70cce1a4aff by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit templates/cpp-plasmoid/cpp-plasmoid.kdevtemplate
  change: edit templates/qml-plasmoid/qml-plasmoid.kdevtemplate
  change: edit templates/plasma-wallpaper/plasma-wallpaper.kdevtemplate
  change: edit src/plasma/packagestructure/plasmatheme-packagestructure.json
  change: edit src/plasma/packagestructure/plasmoid-packagestructure.json


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 
16 test(s)Failed: TestSuite.plasma-configmodeltest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/8 (88%)FILES 77/112 (69%)CLASSES 77/112 (69%)LINE 4815/10566 
(46%)CONDITIONAL 2595/7854 (33%)

By packages
  
autotests
FILES 28/28 (100%)CLASSES 28/28 (100%)LINE 974/1050 
(93%)CONDITIONAL 613/1238 (50%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 648/2128 
(30%)CONDITIONAL 300/1308 (23%)
src.plasma
FILES 14/20 (70%)CLASSES 14/20 (70%)LINE 1657/3605 
(46%)CONDITIONAL 963/2707 (36%)
src.plasma.packagestructure
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 49/66 (74%)CONDITIONAL 
5/22 (23%)
src.plasma.private
FILES 14/24 (58%)CLASSES 14/24 (58%)LINE 921/1638 
(56%)CONDITIONAL 416/1054 (39%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/180 (0%)CONDITIONAL 0/106 
(0%)
src.plasmaquick
FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 535/1786 
(30%)CONDITIONAL 292/1397 (21%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 213 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/213/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Tue, 11 Oct 2016 10:32:14 +
Build duration: 2 min 24 sec

CHANGE SET
Revision 98b7f48a895eeabb7d676726c0b7e70cce1a4aff by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit templates/qml-plasmoid/qml-plasmoid.kdevtemplate
  change: edit templates/cpp-plasmoid/cpp-plasmoid.kdevtemplate
  change: edit src/plasma/packagestructure/plasmatheme-packagestructure.json
  change: edit src/plasma/packagestructure/plasmoid-packagestructure.json
  change: edit templates/plasma-wallpaper/plasma-wallpaper.kdevtemplate


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 
16 test(s)Failed: TestSuite.plasma-configmodeltest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/8 (88%)FILES 77/112 (69%)CLASSES 77/112 (69%)LINE 4805/10566 
(45%)CONDITIONAL 2589/7854 (33%)

By packages
  
autotests
FILES 28/28 (100%)CLASSES 28/28 (100%)LINE 976/1050 
(93%)CONDITIONAL 613/1238 (50%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 648/2128 
(30%)CONDITIONAL 300/1308 (23%)
src.plasma
FILES 14/20 (70%)CLASSES 14/20 (70%)LINE 1655/3605 
(46%)CONDITIONAL 959/2707 (35%)
src.plasma.packagestructure
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 49/66 (74%)CONDITIONAL 
5/22 (23%)
src.plasma.private
FILES 14/24 (58%)CLASSES 14/24 (58%)LINE 911/1638 
(56%)CONDITIONAL 414/1054 (39%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/180 (0%)CONDITIONAL 0/106 
(0%)
src.plasmaquick
FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 535/1786 
(30%)CONDITIONAL 292/1397 (21%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 213 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/213/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Tue, 11 Oct 2016 10:32:14 +
Build duration: 2 min 17 sec

CHANGE SET
Revision 98b7f48a895eeabb7d676726c0b7e70cce1a4aff by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit templates/plasma-wallpaper/plasma-wallpaper.kdevtemplate
  change: edit templates/qml-plasmoid/qml-plasmoid.kdevtemplate
  change: edit src/plasma/packagestructure/plasmatheme-packagestructure.json
  change: edit templates/cpp-plasmoid/cpp-plasmoid.kdevtemplate
  change: edit src/plasma/packagestructure/plasmoid-packagestructure.json


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 
15 test(s)Failed: TestSuite.plasma-configmodeltest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/8 (88%)FILES 74/108 (69%)CLASSES 74/108 (69%)LINE 4375/10051 
(44%)CONDITIONAL 2289/7450 (31%)

By packages
  
autotests
FILES 26/26 (100%)CLASSES 26/26 (100%)LINE 906/979 
(93%)CONDITIONAL 575/1162 (49%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 561/1880 
(30%)CONDITIONAL 217/1152 (19%)
src.plasma
FILES 14/20 (70%)CLASSES 14/20 (70%)LINE 1653/3605 
(46%)CONDITIONAL 951/2707 (35%)
src.plasma.packagestructure
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 49/66 (74%)CONDITIONAL 
5/22 (23%)
src.plasma.private
FILES 13/22 (59%)CLASSES 13/22 (59%)LINE 861/1565 
(55%)CONDITIONAL 391/1008 (39%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/180 (0%)CONDITIONAL 0/106 
(0%)
src.plasmaquick
FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 314/1663 
(19%)CONDITIONAL 144/1271 (11%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 213 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/213/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Tue, 11 Oct 2016 10:32:14 +
Build duration: 2 min 17 sec

CHANGE SET
Revision 98b7f48a895eeabb7d676726c0b7e70cce1a4aff by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit templates/qml-plasmoid/qml-plasmoid.kdevtemplate
  change: edit templates/cpp-plasmoid/cpp-plasmoid.kdevtemplate
  change: edit src/plasma/packagestructure/plasmatheme-packagestructure.json
  change: edit src/plasma/packagestructure/plasmoid-packagestructure.json
  change: edit templates/plasma-wallpaper/plasma-wallpaper.kdevtemplate


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 
15 test(s)Failed: TestSuite.plasma-configmodeltest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/8 (88%)FILES 74/108 (69%)CLASSES 74/108 (69%)LINE 4373/10051 
(44%)CONDITIONAL 2288/7450 (31%)

By packages
  
autotests
FILES 26/26 (100%)CLASSES 26/26 (100%)LINE 904/979 
(92%)CONDITIONAL 575/1162 (49%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 561/1880 
(30%)CONDITIONAL 217/1152 (19%)
src.plasma
FILES 14/20 (70%)CLASSES 14/20 (70%)LINE 1653/3605 
(46%)CONDITIONAL 951/2707 (35%)
src.plasma.packagestructure
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 49/66 (74%)CONDITIONAL 
5/22 (23%)
src.plasma.private
FILES 13/22 (59%)CLASSES 13/22 (59%)LINE 861/1565 
(55%)CONDITIONAL 390/1008 (39%)
src.plasma.scripting
FILES 0/3 (0%)CLASSES 0/3 (0%)LINE 0/180 (0%)CONDITIONAL 0/106 
(0%)
src.plasmaquick
FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 314/1663 
(19%)CONDITIONAL 144/1271 (11%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 132 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/132/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 11 Oct 2016 09:55:07 +
Build duration: 1 min 52 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.kservicetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5455/7983 
(68%)CONDITIONAL 2947/6138 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1442/1530 
(94%)CONDITIONAL 886/1768 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1760/3042 
(58%)CONDITIONAL 755/1888 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2037/2798 
(73%)CONDITIONAL 1221/2054 (59%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 130 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/130/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 11 Oct 2016 09:49:57 +
Build duration: 1 min 54 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.kservicetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5457/7982 
(68%)CONDITIONAL 2953/6138 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1442/1530 
(94%)CONDITIONAL 886/1768 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1762/3042 
(58%)CONDITIONAL 758/1888 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2037/2797 
(73%)CONDITIONAL 1224/2054 (60%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 129 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/129/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 11 Oct 2016 09:20:35 +
Build duration: 3 min 31 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.kservicetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5457/7983 
(68%)CONDITIONAL 2949/6138 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1442/1530 
(94%)CONDITIONAL 884/1768 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1761/3042 
(58%)CONDITIONAL 758/1888 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2038/2798 
(73%)CONDITIONAL 1222/2054 (59%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 131 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/131/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 11 Oct 2016 09:18:30 +
Build duration: 6 min 0 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.kservicetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5459/7983 
(68%)CONDITIONAL 2955/6138 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1444/1530 
(94%)CONDITIONAL 892/1768 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1761/3042 
(58%)CONDITIONAL 756/1888 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2038/2798 
(73%)CONDITIONAL 1222/2054 (59%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)

Jenkins-kde-ci: kcoreaddons master kf5-qt5 » Linux,gcc - Build # 95 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kcoreaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/95/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 11 Oct 2016 09:11:40 +
Build duration: 2 min 30 sec

CHANGE SET
Revision bc77577d7752e4069b9c7826673585e6c6e36e00 by scripty: (Upgrade KF5 
version to 5.28.0.)
  change: edit CMakeLists.txt
Revision 70c745d6147e465ce1e34b6037eb7dedb8e77f27 by David Edmundson: (Load 
user avatars from AccountsServicePath if it exists)
  change: add src/lib/util/config-accountsservice.h.cmake
  change: edit src/lib/util/kuser_unix.cpp
  change: edit src/lib/CMakeLists.txt
Revision a06cef31cc4c908bc9b76bd9d103fe9c60e0953f by montel: (Add more 
autotests)
  change: edit autotests/ktexttohtmltest.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 25 test(s), Skipped: 0 test(s), Total: 
25 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 10/10 (100%)FILES 79/93 (85%)CLASSES 79/93 (85%)LINE 5807/8092 
(72%)CONDITIONAL 10507/24985 (42%)

By packages
  
autotests
FILES 33/40 (83%)CLASSES 33/40 (83%)LINE 2502/2610 
(96%)CONDITIONAL 6395/13241 (48%)
src.desktoptojson
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 82/106 (77%)CONDITIONAL 
143/384 (37%)
src.lib
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 302/536 (56%)CONDITIONAL 
192/893 (22%)
src.lib.caching
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 352/787 (45%)CONDITIONAL 
197/1092 (18%)
src.lib.io
FILES 9/10 (90%)CLASSES 9/10 (90%)LINE 745/1401 
(53%)CONDITIONAL 906/3364 (27%)
src.lib.jobs
FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 158/303 (52%)CONDITIONAL 
57/146 (39%)
src.lib.plugin
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 611/708 (86%)CONDITIONAL 
971/2191 (44%)
src.lib.randomness
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/98 (66%)CONDITIONAL 
40/66 (61%)
src.lib.text
FILES 5/8 (63%)CLASSES 5/8 (63%)LINE 331/745 (44%)CONDITIONAL 
790/1996 (40%)
src.lib.util
FILES 10/10 (100%)CLASSES 10/10 (100%)LINE 659/798 
(83%)CONDITIONAL 816/1612 (51%)

Jenkins-kde-ci: kcoreaddons master kf5-qt5 » Linux,gcc - Build # 95 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kcoreaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/95/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 11 Oct 2016 09:11:40 +
Build duration: 2 min 30 sec

CHANGE SET
Revision bc77577d7752e4069b9c7826673585e6c6e36e00 by scripty: (Upgrade KF5 
version to 5.28.0.)
  change: edit CMakeLists.txt
Revision 70c745d6147e465ce1e34b6037eb7dedb8e77f27 by David Edmundson: (Load 
user avatars from AccountsServicePath if it exists)
  change: add src/lib/util/config-accountsservice.h.cmake
  change: edit src/lib/util/kuser_unix.cpp
  change: edit src/lib/CMakeLists.txt
Revision a06cef31cc4c908bc9b76bd9d103fe9c60e0953f by montel: (Add more 
autotests)
  change: edit autotests/ktexttohtmltest.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 25 test(s), Skipped: 0 test(s), Total: 
25 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 10/10 (100%)FILES 79/93 (85%)CLASSES 79/93 (85%)LINE 5807/8092 
(72%)CONDITIONAL 10507/24985 (42%)

By packages
  
autotests
FILES 33/40 (83%)CLASSES 33/40 (83%)LINE 2502/2610 
(96%)CONDITIONAL 6395/13241 (48%)
src.desktoptojson
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 82/106 (77%)CONDITIONAL 
143/384 (37%)
src.lib
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 302/536 (56%)CONDITIONAL 
192/893 (22%)
src.lib.caching
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 352/787 (45%)CONDITIONAL 
197/1092 (18%)
src.lib.io
FILES 9/10 (90%)CLASSES 9/10 (90%)LINE 745/1401 
(53%)CONDITIONAL 906/3364 (27%)
src.lib.jobs
FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 158/303 (52%)CONDITIONAL 
57/146 (39%)
src.lib.plugin
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 611/708 (86%)CONDITIONAL 
971/2191 (44%)
src.lib.randomness
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 65/98 (66%)CONDITIONAL 
40/66 (61%)
src.lib.text
FILES 5/8 (63%)CLASSES 5/8 (63%)LINE 331/745 (44%)CONDITIONAL 
790/1996 (40%)
src.lib.util
FILES 10/10 (100%)CLASSES 10/10 (100%)LINE 659/798 
(83%)CONDITIONAL 816/1612 (51%)

Re: Review Request 124905: Win: Hide console window for binaries in LIBEXEC

[Jarosław Staniek]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124905/#review99926
---



Reposting here, proposing to reopen it.

After a while: I think forcing to skip Qt LTS and going for 5.8.0 is not 
practical.
Are users of KIO and alike forced to patch KF5 to remove unwanted "black 
windows"?
That would look like unfortunate for developer experience of KF5 on Windows.
That's what exactly I am facing (and in fact migrating away from dbus too, thus 
decreasing my use of KF5 unfortunately on Windows).

Can we have a temporary fix at ECM of KF5 level (e.g. for Qt < 5.8.0)?

Kevin wrote:
> Well, you can always patch Qt?
> 
> Emerge applies that patch to qtbase already. So when you use Emerge, your
issue is fixed.
> Regarding upstream: I didn't push it to anything below Qt 5.8 b/c it's a
behavioral change after all. Not a simple bug fix.

> I'm lacking the motivation/time do so unfortunately. I've already spent
significant amount of my time on this issue, not planning to continue.

First, thanks for your time Kevin!
At my side, I am patching KF5 but am not very happy since we were close to have 
a solution and keep it 'proactively' until nobody is using Qt < 5.8.[*] This 
post isn't a request to grab your time away from the main project. Because I 
don't know if I'll be posting complete patch, so let's just have a reminder 
here for others that the workaround at the very downstream level is one of the 
worst solutions. The only worse thing is potential users of KF5 giving up for 
so easily avoidable issue. We can even have an option that sets WIN32, just not 
by default.

In theory Qt can be patched but I am not asking about the KDE-windows' 
development team itself using emerge. Sorry if that was not clear.
I am more wondering about where do we want to be with KF5 on Windows for 
3rd-party users that would eventually download prepackaged libs.
I'd like to think about KF5 like about similar product as Qt is. Stable API 
with (eventually) binaries available maybe via shiny installer. That's the way 
of consumption for most users not only on Windows. 

I think we don't need to discuss that there is Qt 5.6 LTS, why it exists and 
was demanded, and that users don't compile Qt. 
And that many people will stay with LTS for a long time. Or with Qt 5.7. And 
with not the newest compilers for that matter (even if this is unrelated to 
this very bug).
Because what we have is perceived as a bug or at least non-professional 
behavior.

So if patching is performed, and users are motivated to use the KF5 bits in 
question nevertheless, it's the KF5 that would be patched.
While better than asking to patch the Qt, that would be still unfortunate in my 
opinion because we have all means to act at our end even it "that's not our 
fault and the one-liner does not belong to KF5".

[*] That was more or less an attitude I practiced when developed the 1st KDE on 
Windows port in 2004 :)

- Jarosław Staniek


On July 11, 2016, 6:15 p.m., Kevin Funk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124905/
> ---
> 
> (Updated July 11, 2016, 6:15 p.m.)
> 
> 
> Review request for KDE Frameworks, Alex Merry and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Win: Hide console window for binaries in LIBEXEC
> 
> 
> Diffs
> -
> 
>   src/ioslaves/http/CMakeLists.txt 76a8e2800b84c312431cc1996ac81d1ef6fb5cfc 
>   src/ioslaves/http/kcookiejar/CMakeLists.txt 
> 7b4778d1f67c1ad9f9edcaa4692b39ee6fe3f365 
>   src/kioexec/CMakeLists.txt 91284a3a61b86770b4d1939da52d256840803608 
>   src/kioslave/CMakeLists.txt e02febd380b268c596e8ecc3b745b6f50993ab4e 
>   src/kpac/CMakeLists.txt fc5989714480ca49b5bd72e1c7b458b26bd0d9bc 
> 
> Diff: https://git.reviewboard.kde.org/r/124905/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

Re: Review Request 129143: Fix loading plasmoids by absolute path, fixes configmodeltest

[Marco Martin]

> On Oct. 11, 2016, 8:52 a.m., Kai Uwe Broulik wrote:
> > I have a FolderView applet in my panel (pointing to Downloads folder) and 
> > it is blank with this patch now.

ok, so please don't push this yet


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129143/#review99923
---


On Oct. 10, 2016, 9:48 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129143/
> ---
> 
> (Updated Oct. 10, 2016, 9:48 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> We were not looking into the plugin directory when figuring out the applet 
> path.
> 
> 
> Diffs
> -
> 
>   src/plasma/private/applet_p.cpp 624e4fe 
>   src/plasmaquick/configmodel.cpp 975854a 
> 
> Diff: https://git.reviewboard.kde.org/r/129143/diff/
> 
> 
> Testing
> ---
> 
> `configmodeltest` passes.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

Re: Review Request 129143: Fix loading plasmoids by absolute path, fixes configmodeltest

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129143/#review99923
---



I have a FolderView applet in my panel (pointing to Downloads folder) and it is 
blank with this patch now.

- Kai Uwe Broulik


On Okt. 10, 2016, 9:48 nachm., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129143/
> ---
> 
> (Updated Okt. 10, 2016, 9:48 nachm.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> We were not looking into the plugin directory when figuring out the applet 
> path.
> 
> 
> Diffs
> -
> 
>   src/plasma/private/applet_p.cpp 624e4fe 
>   src/plasmaquick/configmodel.cpp 975854a 
> 
> Diff: https://git.reviewboard.kde.org/r/129143/diff/
> 
> 
> Testing
> ---
> 
> `configmodeltest` passes.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

Re: Review Request 129143: Fix loading plasmoids by absolute path, fixes configmodeltest

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129143/#review99921
---


Ship it!




this version seems to work well

- Marco Martin


On Oct. 10, 2016, 9:48 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129143/
> ---
> 
> (Updated Oct. 10, 2016, 9:48 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> We were not looking into the plugin directory when figuring out the applet 
> path.
> 
> 
> Diffs
> -
> 
>   src/plasma/private/applet_p.cpp 624e4fe 
>   src/plasmaquick/configmodel.cpp 975854a 
> 
> Diff: https://git.reviewboard.kde.org/r/129143/diff/
> 
> 
> Testing
> ---
> 
> `configmodeltest` passes.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>