Review Request 129315: Don't install plasmoid desktop files as services

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129315/
---

Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

It shouldn't have an impact anymore.


Diffs
-

  KF5PlasmaMacros.cmake 5827854 

Diff: https://git.reviewboard.kde.org/r/129315/diff/


Testing
---


Thanks,

Aleix Pol Gonzalez

Re: Review Request 129236: KAuth: make sure we can do more than one request

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129236/
---

(Updated Nov. 3, 2016, 1:27 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Olivier Goffart.


Changes
---

Submitted with commit 0e651f1ca2b50fb996f7f18a0782b304e681bc59 by Aleix Pol to 
branch master.


Repository: kauth


Description
---

It was failing because subsequent connects return false.
Only try to catch the error if a problem was reported.

Declares some enums so they print something when on QDebug.
Outputs errors into warnings instead of debug.
Removes some tr() string puzzles.

Fixes a behavior change introduced in QtDBus by:
https://code.qt.io/cgit/qt/qtbase.git/commit/?h=dev=6f275a4beb9a42b9d5ac99682ce9939a66239778
https://codereview.qt-project.org/#/c/161325/


Diffs
-

  autotests/HelperTest.cpp 8050a06 
  src/backends/dbus/DBusHelperProxy.cpp c60def8 
  src/kauthaction.h 96f550b 
  src/kauthexecutejob.cpp 2901e3b 

Diff: https://git.reviewboard.kde.org/r/129236/diff/


Testing
---

Now my snap helper can install and then uninstall an application right away.
Unit tests pass on my system.


Thanks,

Aleix Pol Gonzalez

[Differential] [Updated] D3226: Don't be fatal on File field not being properly parsed

[apol (Aleix Pol Gonzalez)]

apol marked an inline comment as done.
apol added a comment.


  In https://phabricator.kde.org/D3226#60186, @aacid wrote:
  
  > If the file is broken maybe we should just fail in a more understandable 
way so people fix their software?
  
  
  The best way so people get to fix their software would be just to change the 
WARNING for a FATAL_ERROR. If you have a good idea of how to fail better, I'll 
be happy to include it.
  
  Maybe look for File= and then make sure it's a kcfg file separately?

REVISION DETAIL
  https://phabricator.kde.org/D3226

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #frameworks
Cc: aacid, kfunk

Re: Review Request 129314: Setup targets for cross compiling.

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129314/#review100526
---




KF5DocToolsMacros.cmake (line 150)


Doesn't cmake already do this expansion itself? What error are you trying 
to fix?



src/checkXML5.cpp (line 35)


Reading the documentation these two versions do the exact same thing.


- Aleix Pol Gonzalez


On Nov. 2, 2016, 8:55 p.m., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129314/
> ---
> 
> (Updated Nov. 2, 2016, 8:55 p.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Bugs: 371987
> https://bugs.kde.org/show_bug.cgi?id=371987
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Fix 'checkXML5 generates html files in workdir for valid docbooks'.
> 
> BUG:371987
> 
> 
> Diffs
> -
> 
>   KF5DocToolsMacros.cmake d73201dbecaf370898f66f807e6d8856d6f88a8d 
>   src/checkXML5.cpp 437296a0b582c5b3e11c72712c62188dbcef5aa7 
> 
> Diff: https://git.reviewboard.kde.org/r/129314/diff/
> 
> 
> Testing
> ---
> 
> tested on opensuse 13.2
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

Re: Review Request 129299: Warn on startup about ambiguous shortcuts (with an exception for Shift+Delete)

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129299/#review100525
---



+1, after some thinking and discussion.

Would it make sense to get this in once 5.28 is out, to have some time to fix 
broken applications?

- Aleix Pol Gonzalez


On Oct. 31, 2016, 8:18 p.m., Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129299/
> ---
> 
> (Updated Oct. 31, 2016, 8:18 p.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Elvis Angelaccio.
> 
> 
> Repository: kxmlgui
> 
> 
> Description
> ---
> 
> Add a warning at the createGui stage about ambiguous shortcuts being found in 
> the same action collection.
> 
> This is usually a developer issue, but the error message about ambiguity will 
> only show up when someone tries to use the shortcut, so it is relatively easy 
> to miss if you do not try all your actions via a shortcut.
> 
> Also if the involved shortcut is one of the non primary shortcuts of 
> edit_cut, just give it away, since it's usually Shift+Delete being fought 
> over.
> 
> 
> Diffs
> -
> 
>   src/kxmlguiwindow.cpp 519fb26 
> 
> Diff: https://git.reviewboard.kde.org/r/129299/diff/
> 
> 
> Testing
> ---
> 
> gwenview now defaults to Shift+Delete being "Hard delete" and not "Cut", if 
> you remove the 
>   if (action == editCutAction || existingShortcutAction == editCutAction) {
> part, you get warning about the actions involved
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

Re: Review Request 129299: Warn on startup about ambiguous shortcuts (with an exception for Shift+Delete)

[Aleix Pol Gonzalez]

> On Nov. 1, 2016, 2:35 a.m., Aleix Pol Gonzalez wrote:
> > src/kxmlguiwindow.cpp, line 313
> > 
> >
> > How come this is the _only_ exception?
> 
> Albert Astals Cid wrote:
> Because it's the only case where our StandardActions actually have 
> conflicts. DeleteFile vs EditCut
> 
> Aleix Pol Gonzalez wrote:
> If kxmlgui allows itself to have an exception, applications might 
> eventually also need such exceptions.
> 
> Albert Astals Cid wrote:
> I don't know what you mean, please explain what an application might want?

To create their own exceptions? I think it's weird that we have logic to detect 
only this case.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129299/#review100456
---


On Oct. 31, 2016, 8:18 p.m., Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129299/
> ---
> 
> (Updated Oct. 31, 2016, 8:18 p.m.)
> 
> 
> Review request for KDE Frameworks, David Faure and Elvis Angelaccio.
> 
> 
> Repository: kxmlgui
> 
> 
> Description
> ---
> 
> Add a warning at the createGui stage about ambiguous shortcuts being found in 
> the same action collection.
> 
> This is usually a developer issue, but the error message about ambiguity will 
> only show up when someone tries to use the shortcut, so it is relatively easy 
> to miss if you do not try all your actions via a shortcut.
> 
> Also if the involved shortcut is one of the non primary shortcuts of 
> edit_cut, just give it away, since it's usually Shift+Delete being fought 
> over.
> 
> 
> Diffs
> -
> 
>   src/kxmlguiwindow.cpp 519fb26 
> 
> Diff: https://git.reviewboard.kde.org/r/129299/diff/
> 
> 
> Testing
> ---
> 
> gwenview now defaults to Shift+Delete being "Hard delete" and not "Cut", if 
> you remove the 
>   if (action == editCutAction || existingShortcutAction == editCutAction) {
> part, you get warning about the actions involved
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

Re: Review Request 129314: Setup targets for cross compiling.

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129314/#review100517
---



works for me, but let's wait for Luigi's OK

- Burkhard Lück


On Nov. 2, 2016, 7:55 nachm., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129314/
> ---
> 
> (Updated Nov. 2, 2016, 7:55 nachm.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Bugs: 371987
> https://bugs.kde.org/show_bug.cgi?id=371987
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Fix 'checkXML5 generates html files in workdir for valid docbooks'.
> 
> BUG:371987
> 
> 
> Diffs
> -
> 
>   KF5DocToolsMacros.cmake d73201dbecaf370898f66f807e6d8856d6f88a8d 
>   src/checkXML5.cpp 437296a0b582c5b3e11c72712c62188dbcef5aa7 
> 
> Diff: https://git.reviewboard.kde.org/r/129314/diff/
> 
> 
> Testing
> ---
> 
> tested on opensuse 13.2
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

Review Request 129314: Setup targets for cross compiling.

[Ralf Habacker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129314/
---

Review request for Documentation, KDE Frameworks and Luigi Toscano.


Bugs: 371987
https://bugs.kde.org/show_bug.cgi?id=371987


Repository: kdoctools


Description
---

Fix 'checkXML5 generates html files in workdir for valid docbooks'.

BUG:371987


Diffs
-

  KF5DocToolsMacros.cmake d73201dbecaf370898f66f807e6d8856d6f88a8d 
  src/checkXML5.cpp 437296a0b582c5b3e11c72712c62188dbcef5aa7 

Diff: https://git.reviewboard.kde.org/r/129314/diff/


Testing
---

tested on opensuse 13.2


Thanks,

Ralf Habacker

Re: Review Request 129209: Rename subdir kcontrol to kcontrol5

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129209/#review100513
---



+1 if Luigi is happy, I'm happy.

- Aleix Pol Gonzalez


On Oct. 17, 2016, 4:31 p.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129209/
> ---
> 
> (Updated Oct. 17, 2016, 4:31 p.m.)
> 
> 
> Review request for Documentation and KDE Frameworks.
> 
> 
> Repository: kdelibs4support
> 
> 
> Description
> ---
> 
> in distributions the doc packages for kdelibs4support and kde-runtime are 
> usually designed to be co-installable, 
> but this fails in some distributions due to conflicting file paths, therefore:
>  
> * subdir kcontrol is renamed to kcontrol5
> * install target for kcm_ssl docbook changed to kcontrol5
> * X-DocPath changed to kcontrol5/kcm_ssl/index.html
> 
> 
> Diffs
> -
> 
>   docs/CMakeLists.txt f90fa81 
>   docs/kcontrol/CMakeLists.txt  
>   docs/kcontrol/kcm_ssl/CMakeLists.txt  
>   docs/kcontrol/kcm_ssl/details.png  
>   docs/kcontrol/kcm_ssl/index.docbook  
>   docs/kcontrol/kcm_ssl/module.png  
>   docs/kcontrol5/kcm_ssl/CMakeLists.txt 4d3bc75 
>   src/kssl/kcm/kcm_ssl.desktop 6ec8be6 
> 
> Diff: https://git.reviewboard.kde.org/r/129209/diff/
> 
> 
> Testing
> ---
> 
> builds and installs properly
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

Re: Review Request 129209: Rename subdir kcontrol to kcontrol5

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129209/#review100512
---



kdeframeworks ping?

- Burkhard Lück


On Okt. 17, 2016, 2:31 nachm., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129209/
> ---
> 
> (Updated Okt. 17, 2016, 2:31 nachm.)
> 
> 
> Review request for Documentation and KDE Frameworks.
> 
> 
> Repository: kdelibs4support
> 
> 
> Description
> ---
> 
> in distributions the doc packages for kdelibs4support and kde-runtime are 
> usually designed to be co-installable, 
> but this fails in some distributions due to conflicting file paths, therefore:
>  
> * subdir kcontrol is renamed to kcontrol5
> * install target for kcm_ssl docbook changed to kcontrol5
> * X-DocPath changed to kcontrol5/kcm_ssl/index.html
> 
> 
> Diffs
> -
> 
>   docs/CMakeLists.txt f90fa81 
>   docs/kcontrol/CMakeLists.txt  
>   docs/kcontrol/kcm_ssl/CMakeLists.txt  
>   docs/kcontrol/kcm_ssl/details.png  
>   docs/kcontrol/kcm_ssl/index.docbook  
>   docs/kcontrol/kcm_ssl/module.png  
>   docs/kcontrol5/kcm_ssl/CMakeLists.txt 4d3bc75 
>   src/kssl/kcm/kcm_ssl.desktop 6ec8be6 
> 
> Diff: https://git.reviewboard.kde.org/r/129209/diff/
> 
> 
> Testing
> ---
> 
> builds and installs properly
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

[Differential] [Request, 128 lines] D3234: Separate sort roles and filters

[apol (Aleix Pol Gonzalez)]

apol created this revision.
apol added reviewers: Frameworks, leinir, mart.

REVISION SUMMARY
  They're semantically two different things.
  
  Readability
  
  Don't treat filters as specific cases
  
  Make it possible to query kns entries by their unique id

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3234

AFFECTED FILES
  src/attica/atticaprovider.cpp
  src/core/engine.cpp
  src/core/engine_p.h
  src/core/provider_p.h
  src/downloadmanager.cpp
  src/downloadmanager.h
  src/downloadwidget.cpp
  src/staticxml/staticxmlprovider.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #frameworks, leinir, mart

Re: Review Request 129298: RFC: supporting dependencies on KPackage

[Aleix Pol Gonzalez]

> On Oct. 31, 2016, 6:19 p.m., Marco Martin wrote:
> > autotests/data/testpackagesdep/metadata.json, line 14
> > 
> >
> > if kns ends up using ids, maybe the server should be specified as well, 
> > as the id would be server-dependent?
> 
> Aleix Pol Gonzalez wrote:
> I'm not sure, either way we need changes in the KNS API, as the current 
> search in place won't work. I'd prefer if we could use rdn-like notation on 
> kns.
> 
> I don't think it should be server-dependent. If anything, if the user 
> changes the contents server, it might not find the component.
> 
> Dan Leinir Turthra Jensen wrote:
> Hmm... a knsrc points to a providers file, which in turn can hold more 
> than one provider. The providers in the provider file have an ID, so perhaps 
> we can use that? So we'd end up with e.g. 
> kns://colors.knsrc/api.kde-look.org/1159726 instead. While the api bit 
> looks like a server address, it's just the ID as found in the providers file 
> (and might be any string, technically), and so that would be enough (just) to 
> uniquely identify the item as found on a provider which (like with the kde 
> store) might have multiple "servers".
> 
> Marco Martin wrote:
> could a content be identified like org.joe.beautifulicontheme ?
> then the server having some function to resolve 
> org.joe.beautifulicontheme to its id like 137345
> 
> Dan Leinir Turthra Jensen wrote:
> ...what server? That is just another string ID (technically the number 
> that you get in OCS is just a string, and at least one implementation 
> (MidGard) uses that fact). i really don't see how we can get away with having 
> anything less than two string IDs (server ID as defined in a providers.xml, 
> and content ID as unique to that provider) to uniquely identify a content 
> item... i also don't really see why it'd necessarily be better, in any real 
> way other than aesthetics of the link, to have anything more concise than 
> kns://knsrcfile/providerID/contentID (and possibly kns://providerID/contentID 
> in cases of using the default provider as defined by kns internally, which 
> resolves to using KDE's providers.xml).

I'll come up with a patch to search-by-id, I guess everything will look much 
more clear afterwards.
Nevertheless, I think it's clear that passing a providerID bypasses the 
provider abstraction.

If we want to make sure a specific package is installed, maybe it would make 
sense to add a 3rd plugin which is `http://` or even `ocs://` that assume the 
resource is a KPackage.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129298/#review100442
---


On Oct. 31, 2016, 6:09 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129298/
> ---
> 
> (Updated Oct. 31, 2016, 6:09 p.m.)
> 
> 
> Review request for KDE Frameworks, Plasma, Dan Leinir Turthra Jensen, and 
> Marco Martin.
> 
> 
> Repository: kpackage
> 
> 
> Description
> ---
> 
> Makes it possible to specify components to be installed together with a 
> KPackage. They will be specified by a url, we'll have handlers for any kind, 
> making reasonably extensible and doesn't tie us to a technology.
> 
> In this repository I created two Proof of Concept of such handlers, one for 
> the appstream urls and one for KNS: kde:scratch/apol/kpackage-install-helpers
> 
> 
> Diffs
> -
> 
>   autotests/CMakeLists.txt 395b16e 
>   autotests/data/testpackagesdep/contents/ui/main.qml PRE-CREATION 
>   autotests/data/testpackagesdep/metadata.json PRE-CREATION 
>   autotests/data/testpackagesdep/testpackagesdep.testappdataxml PRE-CREATION 
>   src/kpackage/config-package.h.cmake 61f2f0c 
>   src/kpackage/private/packagejobthread.cpp 0a0cc01 
>   src/kpackage/private/packagejobthread_p.h 1babf0b 
> 
> Diff: https://git.reviewboard.kde.org/r/129298/diff/
> 
> 
> Testing
> ---
> 
> None. just builds. It's a proof of concept, not even the test I added was 
> tested, it was just to display what it could look like.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

[Differential] [Updated, 1 line] D3226: Don't be fatal on File field not being properly parsed

[apol (Aleix Pol Gonzalez)]

apol updated this revision to Diff 7826.
apol added a comment.


  Dropped weird regex change

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3226?vs=7824=7826

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3226

AFFECTED FILES
  KF5ConfigMacros.cmake

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #frameworks
Cc: kfunk

[Differential] [Updated] D3226: Don't be fatal on File field not being properly parsed

[apol (Aleix Pol Gonzalez)]

apol marked an inline comment as done.
apol added inline comments.

INLINE COMMENTS

> kfunk wrote in KF5ConfigMacros.cmake:71
> I suggest to add some commentary here.

Right, actually I was thinking of removing this part as the fallback fixes the 
issues we found.

REVISION DETAIL
  https://phabricator.kde.org/D3226

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #frameworks
Cc: kfunk

[Differential] [Changed Subscribers] D3226: Don't be fatal on File field not being properly parsed

[kfunk (Kevin Funk)]

kfunk added inline comments.

INLINE COMMENTS

> KF5ConfigMacros.cmake:71
> file(READ ${_tmp_FILE} _contents)
> -   string(REGEX MATCH "File=([^\n]+\\.kcfg)\n" "" "${_contents}")
> +   string(REGEX MATCH "File=([^\n]+\\.kcfg)c?\n" "" "${_contents}")
> set(_kcfg_FILENAME "${CMAKE_MATCH_1}")

I suggest to add some commentary here.

REVISION DETAIL
  https://phabricator.kde.org/D3226

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #frameworks
Cc: kfunk

[Differential] [Request, 3 lines] D3226: Don't be fatal on File field not being properly parsed

[apol (Aleix Pol Gonzalez)]

apol created this revision.
apol added a reviewer: Frameworks.

REVISION SUMMARY
  Fallback on trying the same filename as the actual file.
  There were some regressions due to the former matching expression:
  string(REGEX REPLACE "^(.*\n)?File=([^\n]+kcfg).*\n.*$" "\\2"  _kcfg_FILENAME 
"${_contents}")
  
  This one would allow for the File field to be the kcfgc file (which doesn't
  make sense).
  With this patch we're not reproducing this behaviour, but we're allowing for 
the
  things that aren't building to work. After all, most kcfg and kcfgc files 
share
  the same name.

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3226

AFFECTED FILES
  KF5ConfigMacros.cmake

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #frameworks

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 236 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/236/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Wed, 02 Nov 2016 11:00:07 +
Build duration: 8 min 56 sec

CHANGE SET
Revision 62b0865492d863cd000814054681ba6a97972cd5 by Marco Martin: (make sure 
OSD doesn#039;t have Dialog flag)
  change: edit src/plasmaquick/dialog.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 
15 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 78/115 (68%)CLASSES 78/115 (68%)LINE 4494/11230 
(40%)CONDITIONAL 2358/8462 (28%)

By packages
  
autotests
FILES 26/26 (100%)CLASSES 26/26 (100%)LINE 933/979 
(95%)CONDITIONAL 596/1162 (51%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 561/1880 
(30%)CONDITIONAL 217/1152 (19%)
src.plasma
FILES 14/20 (70%)CLASSES 14/20 (70%)LINE 1658/3608 
(46%)CONDITIONAL 953/2705 (35%)
src.plasma.packagestructure
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 51/65 (78%)CONDITIONAL 
7/22 (32%)
src.plasma.private
FILES 13/22 (59%)CLASSES 13/22 (59%)LINE 878/1567 
(56%)CONDITIONAL 407/1022 (40%)
src.plasma.scripting
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 36/180 (20%)CONDITIONAL 
14/106 (13%)
src.plasmaquick
FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 335/1702 
(20%)CONDITIONAL 157/1293 (12%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)
src.scriptengines.qml.plasmoid
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1136 (1%)CONDITIONAL 
1/978 (0%)

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 236 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/236/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Wed, 02 Nov 2016 11:00:07 +
Build duration: 8 min 56 sec

CHANGE SET
Revision 62b0865492d863cd000814054681ba6a97972cd5 by Marco Martin: (make sure 
OSD doesn#039;t have Dialog flag)
  change: edit src/plasmaquick/dialog.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 
15 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 78/115 (68%)CLASSES 78/115 (68%)LINE 4494/11230 
(40%)CONDITIONAL 2358/8462 (28%)

By packages
  
autotests
FILES 26/26 (100%)CLASSES 26/26 (100%)LINE 933/979 
(95%)CONDITIONAL 596/1162 (51%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 561/1880 
(30%)CONDITIONAL 217/1152 (19%)
src.plasma
FILES 14/20 (70%)CLASSES 14/20 (70%)LINE 1658/3608 
(46%)CONDITIONAL 953/2705 (35%)
src.plasma.packagestructure
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 51/65 (78%)CONDITIONAL 
7/22 (32%)
src.plasma.private
FILES 13/22 (59%)CLASSES 13/22 (59%)LINE 878/1567 
(56%)CONDITIONAL 407/1022 (40%)
src.plasma.scripting
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 36/180 (20%)CONDITIONAL 
14/106 (13%)
src.plasmaquick
FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 335/1702 
(20%)CONDITIONAL 157/1293 (12%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)
src.scriptengines.qml.plasmoid
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1136 (1%)CONDITIONAL 
1/978 (0%)

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 236 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/236/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Wed, 02 Nov 2016 11:00:07 +
Build duration: 6 min 24 sec

CHANGE SET
Revision 62b0865492d863cd000814054681ba6a97972cd5 by Marco Martin: (make sure 
OSD doesn#039;t have Dialog flag)
  change: edit src/plasmaquick/dialog.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 
16 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 81/119 (68%)CLASSES 81/119 (68%)LINE 4925/11748 
(42%)CONDITIONAL 2657/8866 (30%)

By packages
  
autotests
FILES 28/28 (100%)CLASSES 28/28 (100%)LINE 1005/1050 
(96%)CONDITIONAL 634/1238 (51%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 648/2129 
(30%)CONDITIONAL 300/1308 (23%)
src.plasma
FILES 14/20 (70%)CLASSES 14/20 (70%)LINE 1660/3608 
(46%)CONDITIONAL 961/2705 (36%)
src.plasma.packagestructure
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 51/65 (78%)CONDITIONAL 
7/22 (32%)
src.plasma.private
FILES 14/24 (58%)CLASSES 14/24 (58%)LINE 918/1640 
(56%)CONDITIONAL 428/1068 (40%)
src.plasma.scripting
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 36/180 (20%)CONDITIONAL 
14/106 (13%)
src.plasmaquick
FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 565/1827 
(31%)CONDITIONAL 306/1419 (22%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)
src.scriptengines.qml.plasmoid
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1136 (1%)CONDITIONAL 
1/978 (0%)

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 236 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/236/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Wed, 02 Nov 2016 11:00:07 +
Build duration: 6 min 24 sec

CHANGE SET
Revision 62b0865492d863cd000814054681ba6a97972cd5 by Marco Martin: (make sure 
OSD doesn#039;t have Dialog flag)
  change: edit src/plasmaquick/dialog.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 16 test(s), Skipped: 0 test(s), Total: 
16 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 9/9 (100%)FILES 81/119 (68%)CLASSES 81/119 (68%)LINE 4925/11748 
(42%)CONDITIONAL 2657/8866 (30%)

By packages
  
autotests
FILES 28/28 (100%)CLASSES 28/28 (100%)LINE 1005/1050 
(96%)CONDITIONAL 634/1238 (51%)
src.declarativeimports.core
FILES 10/18 (56%)CLASSES 10/18 (56%)LINE 648/2129 
(30%)CONDITIONAL 300/1308 (23%)
src.plasma
FILES 14/20 (70%)CLASSES 14/20 (70%)LINE 1660/3608 
(46%)CONDITIONAL 961/2705 (36%)
src.plasma.packagestructure
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 51/65 (78%)CONDITIONAL 
7/22 (32%)
src.plasma.private
FILES 14/24 (58%)CLASSES 14/24 (58%)LINE 918/1640 
(56%)CONDITIONAL 428/1068 (40%)
src.plasma.scripting
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 36/180 (20%)CONDITIONAL 
14/106 (13%)
src.plasmaquick
FILES 6/12 (50%)CLASSES 6/12 (50%)LINE 565/1827 
(31%)CONDITIONAL 306/1419 (22%)
src.plasmaquick.private
FILES 1/3 (33%)CLASSES 1/3 (33%)LINE 31/113 (27%)CONDITIONAL 
6/22 (27%)
src.scriptengines.qml.plasmoid
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 11/1136 (1%)CONDITIONAL 
1/978 (0%)