[Differential] [Accepted] D3287: Make sure we don't break compilation with past broken units

[dfaure (David Faure)]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  The error message is a bit confusing, it sounds like the right file is 
${_tmp_FILE}.
  So I would suggest this instead
  
message(WARNING "${_tmp_FILE}: Broken \"File\" field, make sure it's 
pointing at the right file")
  
  Also, shouldn't the regexp be File=(.*)\n ? Basically, anything in the File 
field that is not *.kcfg should lead to "Broken File Field", right?
  So in fact this is a bugfix (not "old broken behaviour") because it gives a 
better error message in case the file says File=foo : it will say "Broken File 
Field" instead of "Couldn't read the File field" (which would send people on 
the wrong track ... the field is here, it can be read, it just has the wrong 
contents).

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3287

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #frameworks, dfaure

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,All,gcc - Build # 82 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/82/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Mon, 07 Nov 2016 07:33:48 +
Build duration: 1 min 45 sec

CHANGE SET
Revision 2472ca786195ad9a9a8d6e4cbc9878899042887d by Martin Gräßlin: 
([autotests] Fix broken KWindowInfoTest)
  change: edit autotests/kwindowinfox11test.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 
13 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 4/5 (80%)FILES 44/50 (88%)CLASSES 44/50 (88%)LINE 6789/9062 
(75%)CONDITIONAL 3790/7057 (54%)

By packages
  
autotests
FILES 15/15 (100%)CLASSES 15/15 (100%)LINE 2936/3007 
(98%)CONDITIONAL 1613/3109 (52%)
autotests.helper
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 7/10 (70%)CONDITIONAL 
3/6 (50%)
src
FILES 14/16 (88%)CLASSES 14/16 (88%)LINE 769/1424 
(54%)CONDITIONAL 315/706 (45%)
src.platforms.wayland
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/89 (0%)CONDITIONAL 0/2 (0%)
src.platforms.xcb
FILES 14/16 (88%)CLASSES 14/16 (88%)LINE 3077/4532 
(68%)CONDITIONAL 1859/3234 (57%)

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,All,gcc - Build # 82 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/82/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Mon, 07 Nov 2016 07:33:48 +
Build duration: 1 min 45 sec

CHANGE SET
Revision 2472ca786195ad9a9a8d6e4cbc9878899042887d by Martin Gräßlin: 
([autotests] Fix broken KWindowInfoTest)
  change: edit autotests/kwindowinfox11test.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 
13 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 4/5 (80%)FILES 44/50 (88%)CLASSES 44/50 (88%)LINE 6789/9062 
(75%)CONDITIONAL 3790/7057 (54%)

By packages
  
autotests
FILES 15/15 (100%)CLASSES 15/15 (100%)LINE 2936/3007 
(98%)CONDITIONAL 1613/3109 (52%)
autotests.helper
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 7/10 (70%)CONDITIONAL 
3/6 (50%)
src
FILES 14/16 (88%)CLASSES 14/16 (88%)LINE 769/1424 
(54%)CONDITIONAL 315/706 (45%)
src.platforms.wayland
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/89 (0%)CONDITIONAL 0/2 (0%)
src.platforms.xcb
FILES 14/16 (88%)CLASSES 14/16 (88%)LINE 3077/4532 
(68%)CONDITIONAL 1859/3234 (57%)

Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,All,gcc - Build # 83 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/83/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Mon, 07 Nov 2016 07:33:48 +
Build duration: 1 min 43 sec

CHANGE SET
Revision 2472ca786195ad9a9a8d6e4cbc9878899042887d by Martin Gräßlin: 
([autotests] Fix broken KWindowInfoTest)
  change: edit autotests/kwindowinfox11test.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 
13 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 4/5 (80%)FILES 44/50 (88%)CLASSES 44/50 (88%)LINE 6791/9062 
(75%)CONDITIONAL 3796/7057 (54%)

By packages
  
autotests
FILES 15/15 (100%)CLASSES 15/15 (100%)LINE 2938/3007 
(98%)CONDITIONAL 1618/3109 (52%)
autotests.helper
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 7/10 (70%)CONDITIONAL 
3/6 (50%)
src
FILES 14/16 (88%)CLASSES 14/16 (88%)LINE 770/1424 
(54%)CONDITIONAL 317/706 (45%)
src.platforms.wayland
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/89 (0%)CONDITIONAL 0/2 (0%)
src.platforms.xcb
FILES 14/16 (88%)CLASSES 14/16 (88%)LINE 3076/4532 
(68%)CONDITIONAL 1858/3234 (57%)

Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,All,gcc - Build # 83 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/83/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Mon, 07 Nov 2016 07:33:48 +
Build duration: 1 min 43 sec

CHANGE SET
Revision 2472ca786195ad9a9a8d6e4cbc9878899042887d by Martin Gräßlin: 
([autotests] Fix broken KWindowInfoTest)
  change: edit autotests/kwindowinfox11test.cpp


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 
13 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 4/5 (80%)FILES 44/50 (88%)CLASSES 44/50 (88%)LINE 6791/9062 
(75%)CONDITIONAL 3796/7057 (54%)

By packages
  
autotests
FILES 15/15 (100%)CLASSES 15/15 (100%)LINE 2938/3007 
(98%)CONDITIONAL 1618/3109 (52%)
autotests.helper
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 7/10 (70%)CONDITIONAL 
3/6 (50%)
src
FILES 14/16 (88%)CLASSES 14/16 (88%)LINE 770/1424 
(54%)CONDITIONAL 317/706 (45%)
src.platforms.wayland
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/89 (0%)CONDITIONAL 0/2 (0%)
src.platforms.xcb
FILES 14/16 (88%)CLASSES 14/16 (88%)LINE 3076/4532 
(68%)CONDITIONAL 1858/3234 (57%)

Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,All,gcc - Build # 82 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/82/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Mon, 07 Nov 2016 06:45:51 +
Build duration: 1 min 44 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 
13 test(s)Failed: TestSuite.kwindowsystem-kwindowinfox11test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 4/5 (80%)FILES 44/50 (88%)CLASSES 44/50 (88%)LINE 6767/9054 
(75%)CONDITIONAL 3766/7039 (54%)

By packages
  
autotests
FILES 15/15 (100%)CLASSES 15/15 (100%)LINE 2914/2999 
(97%)CONDITIONAL 1590/3091 (51%)
autotests.helper
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 7/10 (70%)CONDITIONAL 
3/6 (50%)
src
FILES 14/16 (88%)CLASSES 14/16 (88%)LINE 770/1424 
(54%)CONDITIONAL 317/706 (45%)
src.platforms.wayland
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/89 (0%)CONDITIONAL 0/2 (0%)
src.platforms.xcb
FILES 14/16 (88%)CLASSES 14/16 (88%)LINE 3076/4532 
(68%)CONDITIONAL 1856/3234 (57%)

Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,All,gcc - Build # 81 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/81/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Mon, 07 Nov 2016 06:41:01 +
Build duration: 1 min 40 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 
13 test(s)Failed: TestSuite.kwindowsystem-kwindowinfox11test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 4/5 (80%)FILES 44/50 (88%)CLASSES 44/50 (88%)LINE 6767/9054 
(75%)CONDITIONAL 3766/7039 (54%)

By packages
  
autotests
FILES 15/15 (100%)CLASSES 15/15 (100%)LINE 2914/2999 
(97%)CONDITIONAL 1590/3091 (51%)
autotests.helper
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 7/10 (70%)CONDITIONAL 
3/6 (50%)
src
FILES 14/16 (88%)CLASSES 14/16 (88%)LINE 770/1424 
(54%)CONDITIONAL 317/706 (45%)
src.platforms.wayland
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/89 (0%)CONDITIONAL 0/2 (0%)
src.platforms.xcb
FILES 14/16 (88%)CLASSES 14/16 (88%)LINE 3076/4532 
(68%)CONDITIONAL 1856/3234 (57%)

Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,All,gcc - Build # 80 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/80/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Mon, 07 Nov 2016 06:29:07 +
Build duration: 8 min 48 sec

CHANGE SET
Revision ebba68eebf90f6536dabc7d448aa1be524d7bf28 by Martin Gräßlin: (Expose 
desktopFileName in KWindowInfo)
  change: edit src/platforms/xcb/kwindowinfo_p_x11.h
  change: edit src/kwindowinfo_p.h
  change: edit src/kwindowinfo.h
  change: edit src/platforms/xcb/kwindowinfo.cpp
  change: edit src/kwindowinfo.cpp
  change: edit autotests/kwindowinfox11test.cpp


JUNIT RESULTS

Name: (root) Failed: 3 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
13 test(s)Failed: TestSuite.kwindowsystem-kwindowinfox11testFailed: 
TestSuite.kwindowsystem-kwindowsystem_threadtestFailed: 
TestSuite.kwindowsystem-kwindowsystemx11test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 4/5 (80%)FILES 39/49 (80%)CLASSES 39/49 (80%)LINE 5651/8619 
(66%)CONDITIONAL 3071/6575 (47%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 2394/2564 
(93%)CONDITIONAL 1284/2627 (49%)
autotests.helper
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 7/10 (70%)CONDITIONAL 
3/6 (50%)
src
FILES 12/16 (75%)CLASSES 12/16 (75%)LINE 603/1424 
(42%)CONDITIONAL 289/706 (41%)
src.platforms.wayland
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/89 (0%)CONDITIONAL 0/2 (0%)
src.platforms.xcb
FILES 12/16 (75%)CLASSES 12/16 (75%)LINE 2647/4532 
(58%)CONDITIONAL 1495/3234 (46%)

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,All,gcc - Build # 81 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/81/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Mon, 07 Nov 2016 06:29:07 +
Build duration: 1 min 46 sec

CHANGE SET
Revision ebba68eebf90f6536dabc7d448aa1be524d7bf28 by Martin Gräßlin: (Expose 
desktopFileName in KWindowInfo)
  change: edit src/platforms/xcb/kwindowinfo.cpp
  change: edit autotests/kwindowinfox11test.cpp
  change: edit src/platforms/xcb/kwindowinfo_p_x11.h
  change: edit src/kwindowinfo.h
  change: edit src/kwindowinfo_p.h
  change: edit src/kwindowinfo.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 
13 test(s)Failed: TestSuite.kwindowsystem-kwindowinfox11test

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 4/5 (80%)FILES 44/50 (88%)CLASSES 44/50 (88%)LINE 6767/9054 
(75%)CONDITIONAL 3766/7039 (54%)

By packages
  
autotests
FILES 15/15 (100%)CLASSES 15/15 (100%)LINE 2914/2999 
(97%)CONDITIONAL 1591/3091 (51%)
autotests.helper
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 7/10 (70%)CONDITIONAL 
3/6 (50%)
src
FILES 14/16 (88%)CLASSES 14/16 (88%)LINE 769/1424 
(54%)CONDITIONAL 315/706 (45%)
src.platforms.wayland
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/89 (0%)CONDITIONAL 0/2 (0%)
src.platforms.xcb
FILES 14/16 (88%)CLASSES 14/16 (88%)LINE 3077/4532 
(68%)CONDITIONAL 1857/3234 (57%)

Re: Review Request 129327: Expose desktopFileName in KWindowInfo

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129327/
---

(Updated Nov. 7, 2016, 7:29 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Eike Hein.


Repository: kwindowsystem


Description
---

This change introduced a new method in KWindowInfo:
QByteArray KWindowInfo::desktopFileName() const

It returns the desktop file name of the application if known on the
given platform. So far only provided on X11 through
NETWinInfo::desktopFileName.


Diffs
-

  autotests/kwindowinfox11test.cpp 5dfbcfa67d74244122c86433a40a7ed6923fb1ab 
  src/kwindowinfo.h 5d9799b20d640caa1b1cf9ab4d9dc69b8cceefe3 
  src/kwindowinfo.cpp 658a0b645797676d4e48585ede3d832333688081 
  src/kwindowinfo_p.h 45390c06e7b5ad064ea9368ca102b2462a029c06 
  src/platforms/xcb/kwindowinfo.cpp eca607e18a979439593e05e1da232548d0e7d139 
  src/platforms/xcb/kwindowinfo_p_x11.h 
68805765fd630c2bc7cf0d77be688333b4a363f7 

Diff: https://git.reviewboard.kde.org/r/129327/diff/


Testing
---


Thanks,

Martin Gräßlin

Review Request 129348: [htmlcreator] Port to QtWebEngine

[Anthony Fieroni]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129348/
---

Review request for KDE Frameworks, Christoph Feck and David Faure.


Summary (updated)
-

[htmlcreator] Port to QtWebEngine


Repository: kio-extras


Description (updated)
---

Enable html thimbnail only if WebEngineWidgets is at least version 5.6


Diffs (updated)
-

  thumbnail/CMakeLists.txt 2600bfe 
  thumbnail/htmlcreator.h 0f1770a 
  thumbnail/htmlcreator.cpp 99d2636 

Diff: https://git.reviewboard.kde.org/r/129348/diff/


Testing
---


Thanks,

Anthony Fieroni

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 262 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/262/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 07 Nov 2016 02:43:20 +
Build duration: 11 min

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 
52 test(s)Failed: TestSuite.kiocore-threadtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 270/339 (80%)CLASSES 270/339 (80%)LINE 29272/51387 
(57%)CONDITIONAL 16014/38135 (42%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7783/8107 
(96%)CONDITIONAL 4358/8520 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 96/116 (83%)CLASSES 96/116 (83%)LINE 7822/14144 
(55%)CONDITIONAL 4273/9073 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3405/7561 
(45%)CONDITIONAL 1261/4383 (29%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 443/841 (53%)CONDITIONAL 
329/725 (45%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1763/3778 
(47%)CONDITIONAL 1259/3432 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 
375/753 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 
111/138 (80%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
333/414 (80%)
src.widgets
FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3606/10966 
(33%)CONDITIONAL 1732/6962 (25%)

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 265 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/265/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Mon, 07 Nov 2016 02:26:09 +
Build duration: 12 min

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 
52 test(s)Failed: TestSuite.kiocore-threadtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 270/339 (80%)CLASSES 270/339 (80%)LINE 29274/51387 
(57%)CONDITIONAL 16017/38135 (42%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7783/8107 
(96%)CONDITIONAL 4356/8520 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 96/116 (83%)CLASSES 96/116 (83%)LINE 7816/14144 
(55%)CONDITIONAL 4278/9073 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3405/7561 
(45%)CONDITIONAL 1261/4383 (29%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 443/841 (53%)CONDITIONAL 
329/725 (45%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1763/3778 
(47%)CONDITIONAL 1259/3432 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 713/1155 (62%)CONDITIONAL 
375/753 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 
111/138 (80%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
333/414 (80%)
src.widgets
FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3614/10966 
(33%)CONDITIONAL 1734/6962 (25%)

[Differential] [Request, 8 lines] D3287: Make sure we don't break compilation with past broken units

[apol (Aleix Pol Gonzalez)]

apol created this revision.
apol added reviewers: Frameworks, dfaure.

REVISION SUMMARY
  Show a warning together with the old broken behavior

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3287

AFFECTED FILES
  KF5ConfigMacros.cmake

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #frameworks, dfaure

[Differential] [Closed] D3251: Properly parse function keywords

[apol (Aleix Pol Gonzalez)]

apol closed this revision.

REVISION DETAIL
  https://phabricator.kde.org/D3251

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #frameworks, dfaure

Re: Review Request 129335: Fix cmake warking

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129335/
---

(Updated Nov. 6, 2016, 11:27 p.m.)


Status
--

This change has been marked as submitted.


Review request for Documentation, KDE Frameworks and Luigi Toscano.


Changes
---

Submitted with commit 888cb08e4317befac8c01c6d4f55b4622c340a6c by Aleix Pol to 
branch master.


Repository: kdoctools


Description
---

Now I don't get the error anymore.

```
CMake Warning (dev) at 
/home/apol/devel/kde5/lib64/cmake/KF5DocTools/KF5DocToolsMacros.cmake:121 (if):
  Policy CMP0054 is not set: Only interpret if() arguments as variables or
  keywords when unquoted.  Run "cmake --help-policy CMP0054" for policy
  details.  Use the cmake_policy command to set the policy and suppress this
  warning.

  Quoted variables like "" will no longer be dereferenced when the policy is
  set to NEW.  Since the policy is not set the OLD behavior will be used.
Call Stack (most recent call first):
  doc/afaras/CMakeLists.txt:1 (kdoctools_create_handbook)
This warning is for project developers.  Use -Wno-dev to suppress it.
```


Diffs
-

  KF5DocToolsMacros.cmake d73201d 

Diff: https://git.reviewboard.kde.org/r/129335/diff/


Testing
---


Thanks,

Aleix Pol Gonzalez

Re: Review Request 129356: kdesignerplugin - add overrides to the generated source

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129356/#review100672
---


Ship it!




Ship It!

- David Faure


On Nov. 6, 2016, 10:30 p.m., Allen Winter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129356/
> ---
> 
> (Updated Nov. 6, 2016, 10:30 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdesignerplugin
> 
> 
> Description
> ---
> 
> add Q_DECL_OVERRIDE to the kgendesignerplugin.cpp generated code so 
> -Wsuggest-overrides doesn't complain
> 
> 
> Diffs
> -
> 
>   src/kgendesignerplugin.cpp 33326d0 
> 
> Diff: https://git.reviewboard.kde.org/r/129356/diff/
> 
> 
> Testing
> ---
> 
> The generated code can be compiled with -Wsuggest-overrides without 
> complaining.
> make test passes
> 
> also removed tabs from the generated source code
> 
> 
> Thanks,
> 
> Allen Winter
> 
>

Jenkins-kde-ci: kunitconversion master stable-kf5-qt5 » Linux,gcc - Build # 86 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kunitconversion%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/86/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 06 Nov 2016 23:01:48 +
Build duration: 56 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 61/61 (100%)CLASSES 61/61 (100%)LINE 3397/3615 
(94%)CONDITIONAL 229/504 (45%)

By packages
  
autotests
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 87/87 (100%)CONDITIONAL 
49/98 (50%)
src
FILES 55/55 (100%)CLASSES 55/55 (100%)LINE 3310/3528 
(94%)CONDITIONAL 180/406 (44%)

Jenkins-kde-ci: kunitconversion master stable-kf5-qt5 » Linux,gcc - Build # 86 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kunitconversion%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/86/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 06 Nov 2016 23:01:48 +
Build duration: 56 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 61/61 (100%)CLASSES 61/61 (100%)LINE 3397/3615 
(94%)CONDITIONAL 229/504 (45%)

By packages
  
autotests
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 87/87 (100%)CONDITIONAL 
49/98 (50%)
src
FILES 55/55 (100%)CLASSES 55/55 (100%)LINE 3310/3528 
(94%)CONDITIONAL 180/406 (44%)

Jenkins-kde-ci: kunitconversion master kf5-qt5 » Linux,gcc - Build # 90 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kunitconversion%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/90/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 06 Nov 2016 23:01:27 +
Build duration: 59 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 61/61 (100%)CLASSES 61/61 (100%)LINE 3397/3615 
(94%)CONDITIONAL 229/504 (45%)

By packages
  
autotests
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 87/87 (100%)CONDITIONAL 
49/98 (50%)
src
FILES 55/55 (100%)CLASSES 55/55 (100%)LINE 3310/3528 
(94%)CONDITIONAL 180/406 (44%)

Jenkins-kde-ci: kunitconversion master kf5-qt5 » Linux,gcc - Build # 90 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kunitconversion%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/90/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 06 Nov 2016 23:01:27 +
Build duration: 59 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 61/61 (100%)CLASSES 61/61 (100%)LINE 3397/3615 
(94%)CONDITIONAL 229/504 (45%)

By packages
  
autotests
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 87/87 (100%)CONDITIONAL 
49/98 (50%)
src
FILES 55/55 (100%)CLASSES 55/55 (100%)LINE 3310/3528 
(94%)CONDITIONAL 180/406 (44%)

Jenkins-kde-ci: kunitconversion master stable-kf5-qt5 » Linux,gcc - Build # 85 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kunitconversion%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/85/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 06 Nov 2016 22:35:09 +
Build duration: 8.3 sec

CHANGE SET
Revision 8bf303250a58ae4bb682851a97549f6d040b9acd by Allen Winter: (add 
overrides REVIEW: 129354)
  change: edit src/currency.cpp
  change: edit src/energy.cpp
  change: edit src/velocity.cpp
  change: edit src/angle.cpp
  change: edit src/temperature.cpp
  change: edit src/fuel_efficiency.cpp

Jenkins-kde-ci: kunitconversion master kf5-qt5 » Linux,gcc - Build # 89 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kunitconversion%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/89/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 06 Nov 2016 22:35:09 +
Build duration: 8.8 sec

CHANGE SET
Revision 8bf303250a58ae4bb682851a97549f6d040b9acd by Allen Winter: (add 
overrides REVIEW: 129354)
  change: edit src/energy.cpp
  change: edit src/currency.cpp
  change: edit src/velocity.cpp
  change: edit src/fuel_efficiency.cpp
  change: edit src/temperature.cpp
  change: edit src/angle.cpp

Re: Review Request 129355: kparts add overrides

[Allen Winter]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129355/
---

(Updated Nov. 6, 2016, 11:35 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit fd8693fba950010b64b4d7ae2e6ca84e68562e61 by Allen Winter 
to branch master.


Repository: kparts


Description
---

Add Q_DECL_OVERRIDES as suggested by -Wsuggest-override


Diffs
-

  src/scriptableextension_p.h c8e58be 

Diff: https://git.reviewboard.kde.org/r/129355/diff/


Testing
---

all warnings for -Wsuggest-override are gone
make test still passes


Thanks,

Allen Winter

Re: Review Request 129354: kunitconversion - add overrides

[Allen Winter]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129354/
---

(Updated Nov. 6, 2016, 10:34 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit 8bf303250a58ae4bb682851a97549f6d040b9acd by Allen Winter 
to branch master.


Repository: kunitconversion


Description
---

Add Q_DECL_OVERRIDES as suggested by -Wsuggest-override


Diffs
-

  src/angle.cpp aab158f 
  src/currency.cpp 0edfff5 
  src/energy.cpp 08646cc 
  src/fuel_efficiency.cpp 2dc744a 
  src/temperature.cpp 8bf586e 
  src/velocity.cpp aa0a69b 

Diff: https://git.reviewboard.kde.org/r/129354/diff/


Testing
---

all warnings for -Wsuggest-override are gone
make test still passes


Thanks,

Allen Winter

Review Request 129356: kdesignerplugin - add overrides to the generated source

[Allen Winter]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129356/
---

Review request for KDE Frameworks.


Repository: kdesignerplugin


Description
---

add Q_DECL_OVERRIDE to the kgendesignerplugin.cpp generated code so 
-Wsuggest-overrides doesn't complain


Diffs
-

  src/kgendesignerplugin.cpp 33326d0 

Diff: https://git.reviewboard.kde.org/r/129356/diff/


Testing
---

The generated code can be compiled with -Wsuggest-overrides without complaining.
make test passes

also removed tabs from the generated source code


Thanks,

Allen Winter

Re: Review Request 129355: kparts add overrides

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129355/#review100671
---


Ship it!




Ship It!

- David Faure


On Nov. 6, 2016, 9:06 p.m., Allen Winter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129355/
> ---
> 
> (Updated Nov. 6, 2016, 9:06 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kparts
> 
> 
> Description
> ---
> 
> Add Q_DECL_OVERRIDES as suggested by -Wsuggest-override
> 
> 
> Diffs
> -
> 
>   src/scriptableextension_p.h c8e58be 
> 
> Diff: https://git.reviewboard.kde.org/r/129355/diff/
> 
> 
> Testing
> ---
> 
> all warnings for -Wsuggest-override are gone
> make test still passes
> 
> 
> Thanks,
> 
> Allen Winter
> 
>

Re: Review Request 129354: kunitconversion - add overrides

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129354/#review100670
---


Ship it!




Ship It!

- David Faure


On Nov. 6, 2016, 8:52 p.m., Allen Winter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129354/
> ---
> 
> (Updated Nov. 6, 2016, 8:52 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kunitconversion
> 
> 
> Description
> ---
> 
> Add Q_DECL_OVERRIDES as suggested by -Wsuggest-override
> 
> 
> Diffs
> -
> 
>   src/angle.cpp aab158f 
>   src/currency.cpp 0edfff5 
>   src/energy.cpp 08646cc 
>   src/fuel_efficiency.cpp 2dc744a 
>   src/temperature.cpp 8bf586e 
>   src/velocity.cpp aa0a69b 
> 
> Diff: https://git.reviewboard.kde.org/r/129354/diff/
> 
> 
> Testing
> ---
> 
> all warnings for -Wsuggest-override are gone
> make test still passes
> 
> 
> Thanks,
> 
> Allen Winter
> 
>

Re: Review Request 129186: [baloo] Speedup Positioncodec::encode()

[David Faure]

> On Nov. 6, 2016, 7:36 p.m., David Faure wrote:
> > src/codecs/coding.cpp, line 177
> > 
> >
> > remove space before auto; make it "const auto" while at it?

ignore the const bit, that was nonsense.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129186/#review100660
---


On Nov. 6, 2016, 12:58 p.m., Christian Ehrlicher wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129186/
> ---
> 
> (Updated Nov. 6, 2016, 12:58 p.m.)
> 
> 
> Review request for Baloo, KDE Frameworks and Vishesh Handa.
> 
> 
> Repository: baloo
> 
> 
> Description
> ---
> 
> This patch speeds up PostingCodec::encode() by a factor of ~4 by not adding 
> every single encoded int32 to the resulting bytearray which results in a lot 
> of small memcpy operations.
> The idea is to use a preallocated QByteArray and directly encode the integers 
> into this buffer. This makes the code a little bit more complex but the 
> speedup should be gain enough for this.
> 
> 
> Ping! No interest in this patch? Should I discard it?
> 
> 
> Diffs
> -
> 
>   src/codecs/coding.cpp 5961077 
> 
> Diff: https://git.reviewboard.kde.org/r/129186/diff/
> 
> 
> Testing
> ---
> 
> positoncodectest calculates the same md5sum as before.
> 
> 
> Thanks,
> 
> Christian Ehrlicher
> 
>

Review Request 129355: kparts add overrides

[Allen Winter]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129355/
---

Review request for KDE Frameworks.


Repository: kparts


Description
---

Add Q_DECL_OVERRIDES as suggested by -Wsuggest-override


Diffs
-

  src/scriptableextension_p.h c8e58be 

Diff: https://git.reviewboard.kde.org/r/129355/diff/


Testing
---

all warnings for -Wsuggest-override are gone
make test still passes


Thanks,

Allen Winter

Review Request 129354: kunitconversion - add overrides

[Allen Winter]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129354/
---

Review request for KDE Frameworks.


Repository: kunitconversion


Description
---

Add Q_DECL_OVERRIDES as suggested by -Wsuggest-override


Diffs
-

  src/angle.cpp aab158f 
  src/currency.cpp 0edfff5 
  src/energy.cpp 08646cc 
  src/fuel_efficiency.cpp 2dc744a 
  src/temperature.cpp 8bf586e 
  src/velocity.cpp aa0a69b 

Diff: https://git.reviewboard.kde.org/r/129354/diff/


Testing
---

all warnings for -Wsuggest-override are gone
make test still passes


Thanks,

Allen Winter

Re: Review Request 129281: [Konsole] Render text at primary font's baseline

[Christoph Feck]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129281/
---

(Updated Nov. 6, 2016, 9:40 p.m.)


Review request for KDE Frameworks and Konsole.


Changes
---

Use 'if' again (instead of ternary operator).


Bugs: 371687
http://bugs.kde.org/show_bug.cgi?id=371687


Repository: konsole


Description
---

When Konsole draws a line of text, it first computes the rectangle of the line 
that the text covers (taking into account cells width and height), then passes 
this rectangle to the drawText(QRect, flags, text) call.

Qt detects if the selected font does not offer all characters in the text, and 
substitutes individual characters with a different font. Due to designer 
choices, the same font point size does not lead to same pixel height (or ascent 
size) in all fonts, so the substituted characters might be larger than the 
characters from the primary font.

Using a rectangle causes Qt to position glyphs relative to the bounding box of 
the text, instead of anchored to the baseline.

This patch uses a pixel position instead of a rectangle to draw the text, 
taking into account only the baseline of the primary font.

I have added all "frameworks" developers to increase possible test coverage.


Diffs (updated)
-

  src/TerminalDisplay.cpp 39a8b84 

Diff: https://git.reviewboard.kde.org/r/129281/diff/


Testing
---

On my system, lines with substituted Unicode characters are no longer shifted 
away from the baseline, and therefore do not appear cropped.

Further testing is needed, as there are many (equivalent, similar, or 
different) bug reports about font rendering on different systems, see 
https://bugs.kde.org/buglist.cgi?bug_status=UNCONFIRMED_status=CONFIRMED=font=konsole


Thanks,

Christoph Feck

Re: Review Request 129281: [Konsole] Render text at primary font's baseline

[Christoph Feck]

> On Nov. 6, 2016, 2:35 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> > src/TerminalDisplay.cpp, line 859
> > 
> >
> > Minor nitpick: is there any reason not to unconditionally add the 
> > LTR_OVERRIDE_CHAR?
> > 
> > I don't like the ? : stuff, and the line gets overly long.
> 
> Martin Tobias Holmedahl Sandsmark wrote:
> otherwise it looks good, so +1 from me.

You are right about the ternary operator, I will change it in a minute.

Regarding the LTR stuff, apparently there are console applications (editors?) 
that actually understand RTL languages, and know how to reverse text layout 
(Pango/Harfbuzz-style). For those applications, we cannot use Qt's bidi 
processing (i.e. reversing), but have to render them in the order they are 
written to the console stream.

Since there seems to be no protocol to detect such applications, all Konsole 
can do is to offer a checkbox in its advanced settings.


- Christoph


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129281/#review100648
---


On Oct. 29, 2016, 2:27 a.m., Christoph Feck wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129281/
> ---
> 
> (Updated Oct. 29, 2016, 2:27 a.m.)
> 
> 
> Review request for KDE Frameworks and Konsole.
> 
> 
> Bugs: 371687
> http://bugs.kde.org/show_bug.cgi?id=371687
> 
> 
> Repository: konsole
> 
> 
> Description
> ---
> 
> When Konsole draws a line of text, it first computes the rectangle of the 
> line that the text covers (taking into account cells width and height), then 
> passes this rectangle to the drawText(QRect, flags, text) call.
> 
> Qt detects if the selected font does not offer all characters in the text, 
> and substitutes individual characters with a different font. Due to designer 
> choices, the same font point size does not lead to same pixel height (or 
> ascent size) in all fonts, so the substituted characters might be larger than 
> the characters from the primary font.
> 
> Using a rectangle causes Qt to position glyphs relative to the bounding box 
> of the text, instead of anchored to the baseline.
> 
> This patch uses a pixel position instead of a rectangle to draw the text, 
> taking into account only the baseline of the primary font.
> 
> I have added all "frameworks" developers to increase possible test coverage.
> 
> 
> Diffs
> -
> 
>   src/TerminalDisplay.cpp 39a8b84 
> 
> Diff: https://git.reviewboard.kde.org/r/129281/diff/
> 
> 
> Testing
> ---
> 
> On my system, lines with substituted Unicode characters are no longer shifted 
> away from the baseline, and therefore do not appear cropped.
> 
> Further testing is needed, as there are many (equivalent, similar, or 
> different) bug reports about font rendering on different systems, see 
> https://bugs.kde.org/buglist.cgi?bug_status=UNCONFIRMED_status=CONFIRMED=font=konsole
> 
> 
> Thanks,
> 
> Christoph Feck
> 
>

Re: Review Request 129186: [baloo] Speedup Positioncodec::encode()

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129186/#review100660
---


Fix it, then Ship it!





src/codecs/coding.cpp (line 160)


remove space before auto; make it "const auto" while at it?


- David Faure


On Nov. 6, 2016, 12:58 p.m., Christian Ehrlicher wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129186/
> ---
> 
> (Updated Nov. 6, 2016, 12:58 p.m.)
> 
> 
> Review request for Baloo, KDE Frameworks and Vishesh Handa.
> 
> 
> Repository: baloo
> 
> 
> Description
> ---
> 
> This patch speeds up PostingCodec::encode() by a factor of ~4 by not adding 
> every single encoded int32 to the resulting bytearray which results in a lot 
> of small memcpy operations.
> The idea is to use a preallocated QByteArray and directly encode the integers 
> into this buffer. This makes the code a little bit more complex but the 
> speedup should be gain enough for this.
> 
> 
> Ping! No interest in this patch? Should I discard it?
> 
> 
> Diffs
> -
> 
>   src/codecs/coding.cpp 5961077 
> 
> Diff: https://git.reviewboard.kde.org/r/129186/diff/
> 
> 
> Testing
> ---
> 
> positoncodectest calculates the same md5sum as before.
> 
> 
> Thanks,
> 
> Christian Ehrlicher
> 
>

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 139 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/139/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 06 Nov 2016 19:17:05 +
Build duration: 6 min 40 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 
11 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5461/7984 
(68%)CONDITIONAL 2949/6140 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1442/1530 
(94%)CONDITIONAL 881/1768 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1760/3042 
(58%)CONDITIONAL 756/1888 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2043/2799 
(73%)CONDITIONAL 1227/2056 (60%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 139 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/139/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 06 Nov 2016 19:17:05 +
Build duration: 6 min 40 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 
11 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5461/7984 
(68%)CONDITIONAL 2949/6140 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1442/1530 
(94%)CONDITIONAL 881/1768 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1760/3042 
(58%)CONDITIONAL 756/1888 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2043/2799 
(73%)CONDITIONAL 1227/2056 (60%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)

Re: Review Request 129283: kwidgetaddons - add overrides

[Christoph Feck]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129283/#review100658
---


Ship it!




Merci :)

- Christoph Feck


On Nov. 6, 2016, 7:26 p.m., Allen Winter wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129283/
> ---
> 
> (Updated Nov. 6, 2016, 7:26 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> Add Q_DECL_OVERRIDES as suggested by -Wsuggest-override
> 
> 
> Diffs
> -
> 
>   src/kacceleratormanager_p.h 55ab1c1 
>   src/kcharselect_p.h e4efdab 
>   src/kcursor_p.h fcac8d9 
>   src/kfontaction.h ae84944 
>   src/kmultitabbar.h 79e62ed 
>   src/kmultitabbar_p.h 6311413 
>   src/kurllabel.h eeba9e0 
> 
> Diff: https://git.reviewboard.kde.org/r/129283/diff/
> 
> 
> Testing
> ---
> 
> all warnings for -Wsuggest-override are gone
> make test still passes
> 
> 
> Thanks,
> 
> Allen Winter
> 
>

Re: Review Request 129351: Only search for a avatar if loginName isn't empty

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129351/
---

(Updated Nov. 6, 2016, 7:06 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, David Edmundson and Michael Pyne.


Changes
---

Submitted with commit d922477fc2ca03cc0a2e9ee2470f3cb4b37e0c2e by Heiko Becker 
to branch master.


Repository: kcoreaddons


Description
---

70c745d6147e465ce1e34b6037eb7dedb8e77f27 introduced fetching user
avatars via AccountsService. It's seems pointless to search for an
avatar with an empty user name, e.g. an invalid user, though.
Furthermore it makes kusertest fail with the following message if
ACCOUNTS_SERVICE_ICON_DIR exists:
'Actual (invalidKUser.faceIconPath()): "/var/lib/AccountsService/icons/"
Expected (QString())'


Diffs
-

  src/lib/util/kuser_unix.cpp d45d0a1ff20b0b93c720d4320b44f4f5e57045a6 

Diff: https://git.reviewboard.kde.org/r/129351/diff/


Testing
---

kusertest doesn't fail anymore.


Thanks,

Heiko Becker

Re: Review Request 129351: Only search for a avatar if loginName isn't empty

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129351/#review100656
---


Ship it!




Ship It!

- David Edmundson


On Nov. 6, 2016, 6:43 p.m., Heiko Becker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129351/
> ---
> 
> (Updated Nov. 6, 2016, 6:43 p.m.)
> 
> 
> Review request for KDE Frameworks, David Edmundson and Michael Pyne.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> 70c745d6147e465ce1e34b6037eb7dedb8e77f27 introduced fetching user
> avatars via AccountsService. It's seems pointless to search for an
> avatar with an empty user name, e.g. an invalid user, though.
> Furthermore it makes kusertest fail with the following message if
> ACCOUNTS_SERVICE_ICON_DIR exists:
> 'Actual (invalidKUser.faceIconPath()): "/var/lib/AccountsService/icons/"
> Expected (QString())'
> 
> 
> Diffs
> -
> 
>   src/lib/util/kuser_unix.cpp d45d0a1ff20b0b93c720d4320b44f4f5e57045a6 
> 
> Diff: https://git.reviewboard.kde.org/r/129351/diff/
> 
> 
> Testing
> ---
> 
> kusertest doesn't fail anymore.
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

Review Request 129351: Only search for a avatar if loginName isn't empty

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129351/
---

Review request for KDE Frameworks, David Edmundson and Michael Pyne.


Repository: kcoreaddons


Description
---

70c745d6147e465ce1e34b6037eb7dedb8e77f27 introduced fetching user
avatars via AccountsService. It's seems pointless to search for an
avatar with an empty user name, e.g. an invalid user, though.
Furthermore it makes kusertest fail with the following message if
ACCOUNTS_SERVICE_ICON_DIR exists:
'Actual (invalidKUser.faceIconPath()): "/var/lib/AccountsService/icons/"
Expected (QString())'


Diffs
-

  src/lib/util/kuser_unix.cpp d45d0a1ff20b0b93c720d4320b44f4f5e57045a6 

Diff: https://git.reviewboard.kde.org/r/129351/diff/


Testing
---

kusertest doesn't fail anymore.


Thanks,

Heiko Becker

Re: Review Request 129283: kwidgetaddons - add overrides

[Allen Winter]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129283/
---

(Updated Nov. 6, 2016, 6:26 p.m.)


Review request for KDE Frameworks.


Changes
---

restore the 'int' I removed accidentally


Repository: kwidgetsaddons


Description
---

Add Q_DECL_OVERRIDES as suggested by -Wsuggest-override


Diffs (updated)
-

  src/kacceleratormanager_p.h 55ab1c1 
  src/kcharselect_p.h e4efdab 
  src/kcursor_p.h fcac8d9 
  src/kfontaction.h ae84944 
  src/kmultitabbar.h 79e62ed 
  src/kmultitabbar_p.h 6311413 
  src/kurllabel.h eeba9e0 

Diff: https://git.reviewboard.kde.org/r/129283/diff/


Testing
---

all warnings for -Wsuggest-override are gone
make test still passes


Thanks,

Allen Winter

Re: Review Request 129283: kwidgetaddons - add overrides

[Allen Winter]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129283/
---

(Updated Nov. 6, 2016, 6:18 p.m.)


Review request for KDE Frameworks.


Changes
---

remove "virtual" as requested.


Repository: kwidgetsaddons


Description
---

Add Q_DECL_OVERRIDES as suggested by -Wsuggest-override


Diffs (updated)
-

  src/kacceleratormanager_p.h 55ab1c1 
  src/kcharselect_p.h e4efdab 
  src/kcursor_p.h fcac8d9 
  src/kfontaction.h ae84944 
  src/kmultitabbar.h 79e62ed 
  src/kmultitabbar_p.h 6311413 
  src/kurllabel.h eeba9e0 

Diff: https://git.reviewboard.kde.org/r/129283/diff/


Testing
---

all warnings for -Wsuggest-override are gone
make test still passes


Thanks,

Allen Winter

Re: Review Request 129186: [baloo] Speedup Positioncodec::encode()

[Michael Stemle]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129186/#review100652
---


Ship it!




Ship It!

- Michael Stemle


On Nov. 6, 2016, 12:58 p.m., Christian Ehrlicher wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129186/
> ---
> 
> (Updated Nov. 6, 2016, 12:58 p.m.)
> 
> 
> Review request for Baloo, KDE Frameworks and Vishesh Handa.
> 
> 
> Repository: baloo
> 
> 
> Description
> ---
> 
> This patch speeds up PostingCodec::encode() by a factor of ~4 by not adding 
> every single encoded int32 to the resulting bytearray which results in a lot 
> of small memcpy operations.
> The idea is to use a preallocated QByteArray and directly encode the integers 
> into this buffer. This makes the code a little bit more complex but the 
> speedup should be gain enough for this.
> 
> 
> Ping! No interest in this patch? Should I discard it?
> 
> 
> Diffs
> -
> 
>   src/codecs/coding.cpp 5961077 
> 
> Diff: https://git.reviewboard.kde.org/r/129186/diff/
> 
> 
> Testing
> ---
> 
> positoncodectest calculates the same md5sum as before.
> 
> 
> Thanks,
> 
> Christian Ehrlicher
> 
>

Re: Review Request 129281: [Konsole] Render text at primary font's baseline

[Martin Tobias Holmedahl Sandsmark]

> On Nov. 6, 2016, 1:35 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> > src/TerminalDisplay.cpp, line 859
> > 
> >
> > Minor nitpick: is there any reason not to unconditionally add the 
> > LTR_OVERRIDE_CHAR?
> > 
> > I don't like the ? : stuff, and the line gets overly long.

otherwise it looks good, so +1 from me.


- Martin Tobias Holmedahl


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129281/#review100648
---


On Oct. 29, 2016, 12:27 a.m., Christoph Feck wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129281/
> ---
> 
> (Updated Oct. 29, 2016, 12:27 a.m.)
> 
> 
> Review request for KDE Frameworks and Konsole.
> 
> 
> Bugs: 371687
> http://bugs.kde.org/show_bug.cgi?id=371687
> 
> 
> Repository: konsole
> 
> 
> Description
> ---
> 
> When Konsole draws a line of text, it first computes the rectangle of the 
> line that the text covers (taking into account cells width and height), then 
> passes this rectangle to the drawText(QRect, flags, text) call.
> 
> Qt detects if the selected font does not offer all characters in the text, 
> and substitutes individual characters with a different font. Due to designer 
> choices, the same font point size does not lead to same pixel height (or 
> ascent size) in all fonts, so the substituted characters might be larger than 
> the characters from the primary font.
> 
> Using a rectangle causes Qt to position glyphs relative to the bounding box 
> of the text, instead of anchored to the baseline.
> 
> This patch uses a pixel position instead of a rectangle to draw the text, 
> taking into account only the baseline of the primary font.
> 
> I have added all "frameworks" developers to increase possible test coverage.
> 
> 
> Diffs
> -
> 
>   src/TerminalDisplay.cpp 39a8b84 
> 
> Diff: https://git.reviewboard.kde.org/r/129281/diff/
> 
> 
> Testing
> ---
> 
> On my system, lines with substituted Unicode characters are no longer shifted 
> away from the baseline, and therefore do not appear cropped.
> 
> Further testing is needed, as there are many (equivalent, similar, or 
> different) bug reports about font rendering on different systems, see 
> https://bugs.kde.org/buglist.cgi?bug_status=UNCONFIRMED_status=CONFIRMED=font=konsole
> 
> 
> Thanks,
> 
> Christoph Feck
> 
>

Re: Review Request 129281: [Konsole] Render text at primary font's baseline

[Martin Tobias Holmedahl Sandsmark]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129281/#review100648
---




src/TerminalDisplay.cpp (line 859)


Minor nitpick: is there any reason not to unconditionally add the 
LTR_OVERRIDE_CHAR?

I don't like the ? : stuff, and the line gets overly long.


- Martin Tobias Holmedahl Sandsmark


On Oct. 29, 2016, 12:27 a.m., Christoph Feck wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129281/
> ---
> 
> (Updated Oct. 29, 2016, 12:27 a.m.)
> 
> 
> Review request for KDE Frameworks and Konsole.
> 
> 
> Bugs: 371687
> http://bugs.kde.org/show_bug.cgi?id=371687
> 
> 
> Repository: konsole
> 
> 
> Description
> ---
> 
> When Konsole draws a line of text, it first computes the rectangle of the 
> line that the text covers (taking into account cells width and height), then 
> passes this rectangle to the drawText(QRect, flags, text) call.
> 
> Qt detects if the selected font does not offer all characters in the text, 
> and substitutes individual characters with a different font. Due to designer 
> choices, the same font point size does not lead to same pixel height (or 
> ascent size) in all fonts, so the substituted characters might be larger than 
> the characters from the primary font.
> 
> Using a rectangle causes Qt to position glyphs relative to the bounding box 
> of the text, instead of anchored to the baseline.
> 
> This patch uses a pixel position instead of a rectangle to draw the text, 
> taking into account only the baseline of the primary font.
> 
> I have added all "frameworks" developers to increase possible test coverage.
> 
> 
> Diffs
> -
> 
>   src/TerminalDisplay.cpp 39a8b84 
> 
> Diff: https://git.reviewboard.kde.org/r/129281/diff/
> 
> 
> Testing
> ---
> 
> On my system, lines with substituted Unicode characters are no longer shifted 
> away from the baseline, and therefore do not appear cropped.
> 
> Further testing is needed, as there are many (equivalent, similar, or 
> different) bug reports about font rendering on different systems, see 
> https://bugs.kde.org/buglist.cgi?bug_status=UNCONFIRMED_status=CONFIRMED=font=konsole
> 
> 
> Thanks,
> 
> Christoph Feck
> 
>

Re: Review Request 129186: [baloo] Speedup Positioncodec::encode()

[Christian Ehrlicher]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129186/
---

(Updated Nov. 6, 2016, 12:58 p.m.)


Review request for Baloo, KDE Frameworks and Vishesh Handa.


Changes
---

New patch with changes from comments


Repository: baloo


Description
---

This patch speeds up PostingCodec::encode() by a factor of ~4 by not adding 
every single encoded int32 to the resulting bytearray which results in a lot of 
small memcpy operations.
The idea is to use a preallocated QByteArray and directly encode the integers 
into this buffer. This makes the code a little bit more complex but the speedup 
should be gain enough for this.


Ping! No interest in this patch? Should I discard it?


Diffs (updated)
-

  src/codecs/coding.cpp 5961077 

Diff: https://git.reviewboard.kde.org/r/129186/diff/


Testing
---

positoncodectest calculates the same md5sum as before.


Thanks,

Christian Ehrlicher

Re: Review Request 129315: Don't install plasmoid desktop files as services

[David Faure]

> On Nov. 3, 2016, 12:53 p.m., Marco Martin wrote:
> > I'm in favor of this, let's wait to 5.29 tough

5.28 RC is tagged, you can now push commits for 5.29.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129315/#review100537
---


On Nov. 3, 2016, 1:06 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129315/
> ---
> 
> (Updated Nov. 3, 2016, 1:06 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> It shouldn't have an impact anymore.
> 
> 
> Diffs
> -
> 
>   KF5PlasmaMacros.cmake 5827854 
> 
> Diff: https://git.reviewboard.kde.org/r/129315/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

Re: Review Request 129335: Fix cmake warking

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129335/#review100640
---


Ship it!




Ship It!

- David Faure


On Nov. 4, 2016, 11:39 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129335/
> ---
> 
> (Updated Nov. 4, 2016, 11:39 p.m.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Now I don't get the error anymore.
> 
> ```
> CMake Warning (dev) at 
> /home/apol/devel/kde5/lib64/cmake/KF5DocTools/KF5DocToolsMacros.cmake:121 
> (if):
>   Policy CMP0054 is not set: Only interpret if() arguments as variables or
>   keywords when unquoted.  Run "cmake --help-policy CMP0054" for policy
>   details.  Use the cmake_policy command to set the policy and suppress this
>   warning.
> 
>   Quoted variables like "" will no longer be dereferenced when the policy is
>   set to NEW.  Since the policy is not set the OLD behavior will be used.
> Call Stack (most recent call first):
>   doc/afaras/CMakeLists.txt:1 (kdoctools_create_handbook)
> This warning is for project developers.  Use -Wno-dev to suppress it.
> ```
> 
> 
> Diffs
> -
> 
>   KF5DocToolsMacros.cmake d73201d 
> 
> Diff: https://git.reviewboard.kde.org/r/129335/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

Re: Review Request 129261: Hide the "Show Menu Bar" action if all the menubars are native

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129261/#review100639
---


Fix it, then Ship it!





src/kstandardaction.cpp (line 201)


why not qobject_cast? (in all 3 places)


- David Faure


On Oct. 25, 2016, 10:15 p.m., Albert Astals Cid wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129261/
> ---
> 
> (Updated Oct. 25, 2016, 10:15 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> ---
> 
> Some applications have a "Show Menu Bar" action that is a bit silly on 
> systems where the menubar is part of the shell (for example Unity 7).
> 
> This patch attempts to fix it by iterating all the main windows when they are 
> shown and if all the menubars of all mainwindows are native, then hides the 
> show menu bar action (basically erasing it from existence).
> 
> It's not the nicest of the codes and probably has some edge cases but works 
> on the general case so i think it's worth the effort.
> 
> 
> Diffs
> -
> 
>   src/kstandardaction.cpp 89d011e 
> 
> Diff: https://git.reviewboard.kde.org/r/129261/diff/
> 
> 
> Testing
> ---
> 
> Tried konsole, kate and dolphin under Unity 7 on Ubuntu 16.10
> 
> konsole and kate work fine (i.e. the action is gone from the menus and all is 
> good)
> 
> dolphin is not 100% "perfectly behabed" (i.e. the "control" toolbar item is 
> supposed to not be shown when menubars are shown and in this case it's shown) 
> but it's not a regression and imho it's the dolphin code being a bit weird (i 
> can propose a patch for it if this gets accepted)
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

Re: Review Request 129186: [baloo] Speedup Positioncodec::encode()

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129186/#review100638
---




src/codecs/coding.cpp (line 114)


static ?



src/codecs/coding.cpp (line 183)


I wonder why this loop isn't also used for the first item as well. With v = 
0 initially, it would write n-v i.e. n, i.e. the first item, and code would be 
overall simpler (no first-item special case, which also means no empty-list 
special case, the for loop would just be skipped if values.isEmpty()).


- David Faure


On Nov. 5, 2016, 11:39 p.m., Christian Ehrlicher wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129186/
> ---
> 
> (Updated Nov. 5, 2016, 11:39 p.m.)
> 
> 
> Review request for Baloo, KDE Frameworks and Vishesh Handa.
> 
> 
> Repository: baloo
> 
> 
> Description
> ---
> 
> This patch speeds up PostingCodec::encode() by a factor of ~4 by not adding 
> every single encoded int32 to the resulting bytearray which results in a lot 
> of small memcpy operations.
> The idea is to use a preallocated QByteArray and directly encode the integers 
> into this buffer. This makes the code a little bit more complex but the 
> speedup should be gain enough for this.
> 
> 
> Ping! No interest in this patch? Should I discard it?
> 
> 
> Diffs
> -
> 
>   src/codecs/coding.cpp 5961077 
> 
> Diff: https://git.reviewboard.kde.org/r/129186/diff/
> 
> 
> Testing
> ---
> 
> positoncodectest calculates the same md5sum as before.
> 
> 
> Thanks,
> 
> Christian Ehrlicher
> 
>

Jenkins-kde-ci: kactivities master stable-kf5-qt5 » Linux,gcc - Build # 280 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kactivities%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/280/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 06 Nov 2016 11:14:13 +
Build duration: 1 min 7 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  

Jenkins-kde-ci: kactivities master stable-kf5-qt5 » Linux,gcc - Build # 280 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kactivities%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/280/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 06 Nov 2016 11:14:13 +
Build duration: 1 min 7 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  

Re: KStandardAction::showMenubar and native menubars

[Albert Astals Cid]

El diumenge, 6 de novembre de 2016, a les 10:43:42 CET, David Faure va 
escriure:
> On mercredi 12 octobre 2016 00:05:30 CET Albert Astals Cid wrote:
> > My current (yet to implement/test) idea is have
> > KStandardAction::showMenubar check all the menubars of the top level
> > windows of the app and if they are all marked as native, then return a
> > dummy QAction that is not inserted in the menubar/actionCollection and
> > that already returns "true" for checked.
> Why not just call QAction::setVisible(false) ?

Yep, that's what 
  https://git.reviewboard.kde.org/r/129261/
does.

Cheers,
  Albert

Re: Review Request 129186: [baloo] Speedup Positioncodec::encode()

[David Faure]

> On Nov. 6, 2016, 5:40 a.m., Michael Stemle wrote:
> > src/codecs/coding.cpp, line 186
> > 
> >
> > PEDANTIC QUESTION: Why do we `resize()` rather than just using 
> > `QByteArray((values.size() + 1) * 5, '\0')`? I get that it's effectively 
> > the same thing, but it seems like it would be more concise to use the 
> > constructor.

Resize is faster because it doesn't fill the contents with zeroes.


> On Nov. 6, 2016, 5:40 a.m., Michael Stemle wrote:
> > src/codecs/coding.cpp, line 171
> > 
> >
> > QUESTION: I don't see anything here that would really need us to keep 
> > the original code around. Are we just keeping it around in case we find 
> > something wrong in this code later?
> > 
> > It kinda seems like we should remove it. If we do decide to keep this 
> > conditional, should we name it something more obviously related to this 
> > change?

I agree about not keeping dead code around, it's just confusing. One can use 
git to find it later on if needed.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129186/#review100622
---


On Nov. 5, 2016, 11:39 p.m., Christian Ehrlicher wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129186/
> ---
> 
> (Updated Nov. 5, 2016, 11:39 p.m.)
> 
> 
> Review request for Baloo, KDE Frameworks and Vishesh Handa.
> 
> 
> Repository: baloo
> 
> 
> Description
> ---
> 
> This patch speeds up PostingCodec::encode() by a factor of ~4 by not adding 
> every single encoded int32 to the resulting bytearray which results in a lot 
> of small memcpy operations.
> The idea is to use a preallocated QByteArray and directly encode the integers 
> into this buffer. This makes the code a little bit more complex but the 
> speedup should be gain enough for this.
> 
> 
> Ping! No interest in this patch? Should I discard it?
> 
> 
> Diffs
> -
> 
>   src/codecs/coding.cpp 5961077 
> 
> Diff: https://git.reviewboard.kde.org/r/129186/diff/
> 
> 
> Testing
> ---
> 
> positoncodectest calculates the same md5sum as before.
> 
> 
> Thanks,
> 
> Christian Ehrlicher
> 
>

Re: Please add consistency in naming of (noK)Syntax(-)Highlighting library

[Volker Krause]

On Friday 04 November 2016 14:54:25 Volker Krause wrote:
> Hi,
> 
> On Thursday 03 November 2016 11:38:21 Friedrich W. H. Kossebau wrote:
> > one of the things we praise about Qt is the predictability of class names
> > and methods names. Because the patterns used with them decrease the amount
> > of knowledge one needs to have, as things can be derived. No need to look
> > up in a dictionary, just take the base name and apply a common pattern.
> > 
> > When hearing about the new KDE Frameworks library for syntax highlighting,
> > I expected I could derive the name of the lib as with the other KDE
> > Frameworks libraries with a generic name:
> > - repo ksyntaxhighlighting
> > - namespace KSyntaxHighlighting
> 
> is this part of the KF5 style-guide? If so, I wasn't aware of that, sorry.
> 
> > But now I learned that I have to remember some extra rules in my mind:
> > - syntax highlighting: no k-prefix
> > - syntax highlighting: there is a hyphen in the repo name
> 
> Well, there's at least a dozen or so other frameworks (in particular, newer
> ones) with similar patterns. So it doesn't look like we are the odd
> exception here.
> 
> > Creating software means dealing with complex systems. Every extra
> > irregularities makes things only more complex, so best are avoided if
> > possible.
> > If there are no pressing needs for the no-k-prefix and custom repo naming,
> > please consider changing that still before the upcoming release in a few
> > days. I know the extra work sucks, but it sucks even more for all the
> > people running into the irregularly named library here in all the months
> > and years to come.
> 
> I don't mind doing the extra work, but I need input on whether this is
> actually desired or considered "legacy style". David?

The namespace has a K prefix now.

Regards,
Volker

signature.asc
Description: This is a digitally signed message part.

Jenkins-kde-ci: kactivities master stable-kf5-qt5 » Linux,gcc - Build # 279 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kactivities%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/279/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 06 Nov 2016 10:07:36 +
Build duration: 2 min 11 sec

CHANGE SET
No changes

Re: Review Request 129205: [kcoredirlister] Ability to watch files changes

[David Faure]

> On Oct. 30, 2016, 10:38 p.m., David Faure wrote:
> > KCoreDirLister is complex enough, I'd rather not add features to it.
> > 
> > Let's take a step back.
> > 
> > This looks like an already solved problem to me, if I understand it 
> > correctly:
> >  - a kioslave creates a virtual filesystem on top of the local file system 
> > (there are many doing that: kio_desktop, kio_stash, 3 baloo ones 
> > (baloosearch, timeline, tags) in fact there are at least 21 (those with 
> > Class=:local) but they don't all care about deletion, e.g. because readonly)
> >  - the user deletes/renames a local file (or even adds a file, that should 
> > be added to the virtual filesystem)
> >  - somehow (see below) the app (via KCoreDirLister) needs to be notified 
> > using a URL of that virtual filesystem (not just file:///).
> > right?
> > 
> > The way this has always been done, where implemented (kio_desktop, 
> > kio_stash, and in the past some others) is the following
> >  - because kioslaves are short-lived, they can't do the watching (this 
> > replies to Mark's suggestion number 1)
> >  - a kded module is created, to do the watching using KDirWatch - of only 
> > those files that the kioslave is listing
> >  - the kded module emits KDirNotify DBus signals when a file is 
> > removed/renamed, using the kioslave's URL scheme.
> > 
> > You can see these existing kded modules here:
> > - for desktop: plasma-workspace/kioslave/desktop/desktopnotifier.cpp
> > - for baloo: frameworks/baloo/src/kioslaves/kded/
> > - for stash: playground/utils/kio-stash/src/iodaemon/
> > 
> > It seems to me that simply filenamesearch needs its own similar kded 
> > module. I don't see any in kio-extras/filenamesearch.
> 
> Albert Astals Cid wrote:
> Given we seem to have "a few" of those kded modules, is there something 
> we can do to help people making them and not having the same trouble over and 
> over again?
> 
> David Faure wrote:
> What do you mean? Documentation, yes. Shared code? I'm not sure. We're 
> talking about one class with one constructor and 2 or 3 methods, and what to 
> react to, depends on the kioslave. And how to react (converting from file:// 
> to custom://) depends on the kioslave too.
> 
> (BTW use desktopnotifier or kio-stash as example, baloo is a bit 
> different because it's listening to another daemon (so it didn't really need 
> a kded module in the first place)
> 
> Albert Astals Cid wrote:
> Some documentation i guess, this is not the first time this question has 
> come up, and i guess people just don't know what to do to update stuff when 
> slaves are short lived and stateless.

Documentation added in SlaveBase: 
http://commits.kde.org/kio/6a17de1b68d36f87d1fd9813750805f78d069bc3


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129205/#review100411
---


On Oct. 31, 2016, 3:53 p.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129205/
> ---
> 
> (Updated Oct. 31, 2016, 3:53 p.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> David, i will discard review if you don't like it, cause watching files 
> changes can be *really* expensive. I try to:
> 1. to not break abi compability
> 2. to extend filenamesearch with this option
> 3. to fix https://git.reviewboard.kde.org/r/129141/
> 
> 
> Diffs
> -
> 
>   src/core/kcoredirlister.h e6ba2ac 
>   src/core/kcoredirlister.cpp 508516e 
>   src/core/kcoredirlister_p.h 9a3cc7b 
>   tests/kdirlistertest_gui.h 8316b20 
>   tests/kdirlistertest_gui.cpp 11e89cf 
> 
> Diff: https://git.reviewboard.kde.org/r/129205/diff/
> 
> 
> Testing
> ---
> 
> For 3. i still can't figure out why in filenamesearch signal for delete 
> item(s) is not triggered.
> 1. Search for file (by name) in dolphin
> 2. When appear in view delete him
> 3. Signal ItemsDeleted is not triggered, file stays in the view even if new 
> search is performed and reload is needed. The cache look good, tests pass, 
> works but in filenamesearch.
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129170/#review100629
---


Ship it!




Looks ok now, except for the ATime/MTime/CTime business, and @since 5.28 should 
now be @since 5.29 (which is good because the translators have one month to 
translate all these new strings).

Neither ATime nor CTime is actually used in this code, feel free to remove it, 
maybe in a commit that you would rebase this one upon, or I can do it after you 
push. So at a minimum, replace MTime with "modification time", fix @since, then 
push.

Thanks!

- David Faure


On Nov. 1, 2016, 8:10 p.m., Romário Rios wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129170/
> ---
> 
> (Updated Nov. 1, 2016, 8:10 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: karchive
> 
> 
> Description
> ---
> 
> This method is similar to `QIODevice::errorString()`. I added a public 
> `errorString()` method and a protected `setErrorString()` method, to allow 
> `KArchive`'s subclasses to implement their own error messages. I also 
> implemented most error messages from most subclasses.
> 
> 
> Diffs
> -
> 
>   autotests/karchivetest.cpp d0fbf41 
>   src/k7zip.h 5b95f49 
>   src/k7zip.cpp 692b1db 
>   src/kar.h 85bd650 
>   src/kar.cpp 7204fb1 
>   src/karchive.h b528a4a 
>   src/karchive.cpp a1a160a 
>   src/karchive_p.h 256620d 
>   src/krcc.h 18c7d00 
>   src/krcc.cpp 1947dd6 
>   src/ktar.h 4bca898 
>   src/ktar.cpp f70b155 
>   src/kzip.h 84156c7 
>   src/kzip.cpp 94d4276 
> 
> Diff: https://git.reviewboard.kde.org/r/129170/diff/
> 
> 
> Testing
> ---
> 
> I added `QVERIFY` calls after all errors in `karchivetests.cpp`. Perhaps 
> we'll need more tests, but I'm not sure how to make an archive to fail in 
> some specific way aside from the very basics ("file not found", etc.).
> 
> 
> Thanks,
> 
> Romário Rios
> 
>

Re: KStandardAction::showMenubar and native menubars

[David Faure]

On mercredi 12 octobre 2016 00:05:30 CET Albert Astals Cid wrote:
> My current (yet to implement/test) idea is have KStandardAction::showMenubar
> check all the menubars of the top level windows of the app and if they are
> all marked as native, then return a dummy QAction that is not inserted in
> the menubar/actionCollection and that already returns "true" for checked.

Why not just call QAction::setVisible(false) ?

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

Re: Review Request 129133: Silent warning of unused variable in lamda function

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129133/#review100628
---




src/runtime/kwalletd/migrationwizard.cpp (line 37)


OK, but isn't this a case where a lambda is just overkill? Just forward the 
signal:

connect(_ui._optionNo, ::toggled, this, 
::completeChanged);


- David Faure


On Oct. 9, 2016, 4:04 p.m., Nilesh Kokane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129133/
> ---
> 
> (Updated Oct. 9, 2016, 4:04 p.m.)
> 
> 
> Review request for KDE Frameworks and Valentin Rusu.
> 
> 
> Repository: kwallet
> 
> 
> Description
> ---
> 
> ^^
> 
> 
> Diffs
> -
> 
>   src/runtime/kwalletd/migrationwizard.cpp cdd2a92 
> 
> Diff: https://git.reviewboard.kde.org/r/129133/diff/
> 
> 
> Testing
> ---
> 
> Done
> 
> 
> Thanks,
> 
> Nilesh Kokane
> 
>

Re: KIO, proxies, libproxy and OS X/MSWin

[David Faure]

On jeudi 22 septembre 2016 13:20:35 CET René J.V. Bertin wrote:
> Hi,
> 
> Can someone provide a synthetic resume of how KIO handles proxies 

Via QNetworkProxy it seems, in the slaves themselves.
See kio/src/ioslaves/http/http.cpp

> I observe that
> - KIO doesn't link to libproxy and doesn't require its presence in order to
> build - libproxy is capable of detecting the system settings on OS X
> - Qt can build against libproxy but doesn't appear to use it on OS X
> - kcm_kio.so is at least partly effective on OS X, when testing with
> konqueror5: -- manual proxy configuration is taken into account
> -- the direct/no proxy setting is respected
> -- auto-detection of the system proxy configuration doesn't fill in the
> dialog form, but connections *are* routed through the proxy -- automatic
> proxy detection doesn't work correctly and leads to using direct
> connections.

I think "automatic proxy detection" is the use case where javascript has to be 
executed to find out which proxy to use (kio/src/kpac). Needs re-testing after
the port to Qt5, I suppose.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

Re: Review Request 129257: [KNewStuff] Make it possible to query installed entries

[Michael Stemle]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129257/#review100624
---


Ship it!




Ship It!

- Michael Stemle


On Oct. 25, 2016, 11:57 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129257/
> ---
> 
> (Updated Oct. 25, 2016, 11:57 p.m.)
> 
> 
> Review request for KDE Frameworks and Jeremy Whiting.
> 
> 
> Repository: knewstuff
> 
> 
> Description
> ---
> 
> Much like with updates. It will be useful to be able to query for installed 
> packages without having to look them all up.
> 
> 
> Diffs
> -
> 
>   src/core/engine.cpp ab47405 
>   src/core/engine_p.h 11571bf 
>   src/downloadmanager.h 39769f3 
>   src/downloadmanager.cpp 8ce813b 
> 
> Diff: https://git.reviewboard.kde.org/r/129257/diff/
> 
> 
> Testing
> ---
> 
> Works on my newbackends branch for discover where I refactored the internals 
> to be more async, there we can just fetch the installed packages at start 
> without having to fetch everything.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>