[Differential] [Commented On] D3392: winutils_p.h: Restore compatibility with WinXP SDK

[kfunk (Kevin Funk)]

kfunk added a comment.


  And I meant this line: 
https://code.woboq.org/qt5/qtbase/src/corelib/io/qfsfileengine_win.cpp.html#547 
(Woboq bug..., can't link the Windows version of `QFSFileEngine::drivers()`...)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3392

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kfunk, #frameworks, brauch

[Differential] [Accepted] D3392: winutils_p.h: Restore compatibility with WinXP SDK

[brauch (Sven Brauch)]

brauch accepted this revision.
brauch added a comment.
This revision is now accepted and ready to land.


  Ok then, even if it breaks on WinXP occasionally, I guess the impact is 
negligible.

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3392

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kfunk, #frameworks, brauch

[Differential] [Commented On] D3392: winutils_p.h: Restore compatibility with WinXP SDK

[kfunk (Kevin Funk)]

kfunk added a comment.


  In https://phabricator.kde.org/D3392#63341, @brauch wrote:
  
  > Hm, there is at least one race condition here: thread A does old = 
::SetErrorMode(...), then if before it resets it thread B does the same, then 
the old mode might never be restored. We can put a mutex but of course there 
might be another piece of code which does the same. So *shrug* not sure what to 
do, I guess it's just bad API and that's why MS replaced it.
  
  
  I really just wouldn't care about it. We likely never ever run in that 
scenario.
  
  Keep in mind, that Qt uses `Get/SetErrorMode` like this since ages:
  
https://code.woboq.org/qt5/qtbase/src/corelib/io/qfsfileengine_unix.cpp.html#_ZN13QFSFileEngine6drivesEv
 (here and in other places). It's essentially the same code; not protected by a 
mutex or anything.
  
  > Maybe on XP we should just set the flag once on startup? At least that's 
not racy.

REVISION DETAIL
  https://phabricator.kde.org/D3392

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kfunk, #frameworks, brauch

[Differential] [Updated] D3392: winutils_p.h: Restore compatibility with WinXP SDK

[brauch (Sven Brauch)]

brauch added a comment.


  Hm, there is at least one race condition here: thread A does old = 
::SetErrorMode(...), then if before it resets it thread B does the same, then 
the old mode might never be restored. We can put a mutex but of course there 
might be another piece of code which does the same. So *shrug* not sure what to 
do, I guess it's just bad API and that's why MS replaced it.
  
  Maybe on XP we should just set the flag once on startup? At least that's not 
racy.

REVISION DETAIL
  https://phabricator.kde.org/D3392

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kfunk, #frameworks, brauch

[Differential] [Updated] D3392: winutils_p.h: Restore compatibility with WinXP SDK

[kfunk (Kevin Funk)]

kfunk added reviewers: brauch, Frameworks.

REVISION DETAIL
  https://phabricator.kde.org/D3392

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kfunk, brauch, #frameworks

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 280 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/280/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 16 Nov 2016 21:06:19 +
Build duration: 7 min 2 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 
52 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 271/340 (80%)CLASSES 271/340 (80%)LINE 29299/51405 
(57%)CONDITIONAL 16035/38159 (42%)

By packages
  
autotests
FILES 66/66 (100%)CLASSES 66/66 (100%)LINE 7818/8142 
(96%)CONDITIONAL 4370/8542 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 96/116 (83%)CLASSES 96/116 (83%)LINE 7816/14144 
(55%)CONDITIONAL 4280/9073 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3404/7559 
(45%)CONDITIONAL 1260/4381 (29%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 443/841 (53%)CONDITIONAL 
329/725 (45%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1763/3778 
(47%)CONDITIONAL 1259/3432 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 704/1138 (62%)CONDITIONAL 
377/757 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 
111/138 (80%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
333/414 (80%)
src.widgets
FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3614/10968 
(33%)CONDITIONAL 1733/6962 (25%)

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 280 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/280/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 16 Nov 2016 21:06:19 +
Build duration: 7 min 2 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 
52 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 271/340 (80%)CLASSES 271/340 (80%)LINE 29299/51405 
(57%)CONDITIONAL 16035/38159 (42%)

By packages
  
autotests
FILES 66/66 (100%)CLASSES 66/66 (100%)LINE 7818/8142 
(96%)CONDITIONAL 4370/8542 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 96/116 (83%)CLASSES 96/116 (83%)LINE 7816/14144 
(55%)CONDITIONAL 4280/9073 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3404/7559 
(45%)CONDITIONAL 1260/4381 (29%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 443/841 (53%)CONDITIONAL 
329/725 (45%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1763/3778 
(47%)CONDITIONAL 1259/3432 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 704/1138 (62%)CONDITIONAL 
377/757 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 
111/138 (80%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
333/414 (80%)
src.widgets
FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3614/10968 
(33%)CONDITIONAL 1733/6962 (25%)

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 275 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/275/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 16 Nov 2016 21:04:09 +
Build duration: 7 min 22 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 
52 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 271/340 (80%)CLASSES 271/340 (80%)LINE 29290/51405 
(57%)CONDITIONAL 16026/38159 (42%)

By packages
  
autotests
FILES 66/66 (100%)CLASSES 66/66 (100%)LINE 7818/8142 
(96%)CONDITIONAL 4372/8542 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 96/116 (83%)CLASSES 96/116 (83%)LINE 7815/14144 
(55%)CONDITIONAL 4273/9073 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3404/7559 
(45%)CONDITIONAL 1260/4381 (29%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 443/841 (53%)CONDITIONAL 
329/725 (45%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1763/3778 
(47%)CONDITIONAL 1259/3432 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 704/1138 (62%)CONDITIONAL 
377/757 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 
111/138 (80%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
333/414 (80%)
src.widgets
FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3606/10968 
(33%)CONDITIONAL 1731/6962 (25%)

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 275 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/275/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 16 Nov 2016 21:04:09 +
Build duration: 7 min 22 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 
52 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 271/340 (80%)CLASSES 271/340 (80%)LINE 29290/51405 
(57%)CONDITIONAL 16026/38159 (42%)

By packages
  
autotests
FILES 66/66 (100%)CLASSES 66/66 (100%)LINE 7818/8142 
(96%)CONDITIONAL 4372/8542 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 96/116 (83%)CLASSES 96/116 (83%)LINE 7815/14144 
(55%)CONDITIONAL 4273/9073 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3404/7559 
(45%)CONDITIONAL 1260/4381 (29%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 443/841 (53%)CONDITIONAL 
329/725 (45%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1763/3778 
(47%)CONDITIONAL 1259/3432 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 704/1138 (62%)CONDITIONAL 
377/757 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 
111/138 (80%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
333/414 (80%)
src.widgets
FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3606/10968 
(33%)CONDITIONAL 1731/6962 (25%)

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 145 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/145/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 16 Nov 2016 20:42:11 +
Build duration: 5 min 53 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.kservicetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5465/7983 
(68%)CONDITIONAL 2963/6138 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1444/1530 
(94%)CONDITIONAL 894/1768 (51%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1761/3042 
(58%)CONDITIONAL 756/1888 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2044/2798 
(73%)CONDITIONAL 1228/2054 (60%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

[Anthony Fieroni]

> On Ноев. 15, 2016, 6:40 след обяд, David Faure wrote:
> > This fix makes sense to me (well, I suggested it) ;)
> > 
> > As to why it doesn't work, that requires more info about how filenamesearch 
> > URLs are actually being used. Is this documented somewhere, or does it 
> > require testing and debugging?
> 
> Anthony Fieroni wrote:
> I don't see documementation, in Dolphin it is used 
> KDirLister::openUrl(QUrl("filenamesearch:?search=file&url=file:///path/to/file"))

https://git.reviewboard.kde.org/r/129141/


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129394/#review100862
---


On Ноев. 14, 2016, 1:44 след обяд, Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129394/
> ---
> 
> Review request for KDE Frameworks, Anthony Fieroni, David Faure, and Emmanuel 
> Pescosta.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> ---
> 
> Bug is introduced in https://git.reviewboard.kde.org/r/129297/
> When is fixed new kio-extras realease is needed for 16.08 branch.
> 
> 
> Diffs
> -
> 
>   filenamesearch/kded/filenamesearchmodule.cpp 3f9f582 
> 
> Diff: https://git.reviewboard.kde.org/r/129394/diff/
> 
> 
> Testing
> ---
> 
> No big ram usage but still not works as expected.
> 1. Perform search in Dolphin
> 2. Delete one result item
> 3. View must be update, but it's not
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

Re: Send Email with attachment with my Qt Application

[Christoph Feck]

On 16.11.2016 19:58, Boudhayan Gupta wrote:

KService, and all of KDE software written in C++/Qt, are configured
with CMake and not QMake. There's no .pro files, but CMakeLists.txt
files.


This is not true. KDE Frameworks support both qmake and cmake. On the
API pages, the required instructions for use are explained.

https://api.kde.org/frameworks-api/frameworks-apidocs/frameworks/kservice/html/index.html

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

[Anthony Fieroni]

> On Ноев. 15, 2016, 6:40 след обяд, David Faure wrote:
> > This fix makes sense to me (well, I suggested it) ;)
> > 
> > As to why it doesn't work, that requires more info about how filenamesearch 
> > URLs are actually being used. Is this documented somewhere, or does it 
> > require testing and debugging?

I don't see documementation, in Dolphin it is used 
KDirLister::openUrl(QUrl("filenamesearch:?search=file&url=file:///path/to/file"))


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129394/#review100862
---


On Ноев. 14, 2016, 1:44 след обяд, Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129394/
> ---
> 
> Review request for KDE Frameworks, Anthony Fieroni, David Faure, and Emmanuel 
> Pescosta.
> 
> 
> Repository: kio-extras
> 
> 
> Description
> ---
> 
> Bug is introduced in https://git.reviewboard.kde.org/r/129297/
> When is fixed new kio-extras realease is needed for 16.08 branch.
> 
> 
> Diffs
> -
> 
>   filenamesearch/kded/filenamesearchmodule.cpp 3f9f582 
> 
> Diff: https://git.reviewboard.kde.org/r/129394/diff/
> 
> 
> Testing
> ---
> 
> No big ram usage but still not works as expected.
> 1. Perform search in Dolphin
> 2. Delete one result item
> 3. View must be update, but it's not
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

Re: Send Email with attachment with my Qt Application

[Boudhayan Gupta]

Hi Charles-Elie,

KService, and all of KDE software written in C++/Qt, are configured
with CMake and not QMake. There's no .pro files, but CMakeLists.txt
files. You'll need to install CMake, and build by doing:

cd /path/to/sources
cmake .
make && sudo make install

Hope this helps.

Thanks,
Boudhayan Gupta

On 16 November 2016 at 23:01, Charles-Elie Gentil  wrote:
> In fact I did not understand how to build KService, but I think I have
> found: I probably have to create the .pro file myself.
>
> For the direct use of invokMailer, I have already tried but I can not use
> ShellExecute on my Mac. But I will try again.
>
> Best regards,
>
> Charlie
>
> m...@jiyuusoft.net
> http://blog.jiyuusoft.net
>
> Le 16 nov. 2016 à 17:24, David Edmundson  a
> écrit :
>
> Sorry, didn't read that second line properly about attachments properly.
>
> What error do you get when buildling kservice?
> You may find this tool that builds dependencies useful: https://inqlude.org.
>
> Alternatively, you can probably just extract this one invokeMailer here:
> https://api.kde.org/frameworks/kservice/html/ktoolinvocation__win_8cpp_source.html
>
> It appears KToolInvocation doesn't have an OS X backend.
>
> David
>
>

Re: Send Email with attachment with my Qt Application

[Charles-Elie Gentil]

In fact I did not understand how to build KService, but I think I have found: I 
probably have to create the .pro file myself.

For the direct use of invokMailer, I have already tried but I can not use 
ShellExecute on my Mac. But I will try again.

Best regards,

Charlie

m...@jiyuusoft.net
http://blog.jiyuusoft.net

> Le 16 nov. 2016 à 17:24, David Edmundson  a écrit 
> :
> 
> Sorry, didn't read that second line properly about attachments properly.
> 
> What error do you get when buildling kservice?
> You may find this tool that builds dependencies useful: https://inqlude.org 
> . 
> 
> Alternatively, you can probably just extract this one invokeMailer here:
> https://api.kde.org/frameworks/kservice/html/ktoolinvocation__win_8cpp_source.html
>  
> 
> 
> It appears KToolInvocation doesn't have an OS X backend.
> 
> David

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

[Anthony Fieroni]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127216/#review100891
---



Ping, i'm still using it without issues, it isn't good enough?

- Anthony Fieroni


On Ноев. 13, 2016, 7:17 преди обяд, Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127216/
> ---
> 
> (Updated Ноев. 13, 2016, 7:17 преди обяд)
> 
> 
> Review request for KDE Frameworks, Martin Gräßlin and Martin Klapetek.
> 
> 
> Bugs: 356523
> https://bugs.kde.org/show_bug.cgi?id=356523
> 
> 
> Repository: knotifications
> 
> 
> Description
> ---
> 
> Store position of widget before hide it
> 
> 
> Diffs
> -
> 
>   src/kstatusnotifieritem.cpp 3eb39b2 
>   src/kstatusnotifieritemprivate_p.h 8fdfd4c 
> 
> Diff: https://git.reviewboard.kde.org/r/127216/diff/
> 
> 
> Testing
> ---
> 
> Tested on pixel ratio = 1 with Amarok, Kmail, Akregator, Kalarm, Ktimer
> Close with 'X' - restore in correct pos
> Hide by click at icon in systray - restore correct pos
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

Re: Review Request 129418: Adjust directory structure to Frameworks policies

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129418/
---

(Updated Nov. 16, 2016, 6:55 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Sune Vuorela.


Changes
---

Submitted with commit 96d2e4e7dfe3d13b85ee37df0961d33566e8659a by Heiko Becker 
to branch master.


Repository: prison


Description
---

According to the requirements listed on
https://community.kde.org/Frameworks/Policies#Framework_directory_structure


Diffs
-

  CMakeLists.txt 37fb3a0 
  lib/CMakeLists.txt  
  lib/abstractbarcode.h  
  lib/abstractbarcode.cpp  
  lib/code39barcode.h  
  lib/code39barcode.cpp  
  lib/code93barcode.h  
  lib/code93barcode.cpp  
  lib/datamatrixbarcode.h  
  lib/datamatrixbarcode.cpp  
  lib/prison.h  
  lib/prison.cpp  
  lib/qrcodebarcode.h  
  lib/qrcodebarcode.cpp  
  src/CMakeLists.txt PRE-CREATION 
  tests/barcodeexamplewidget.cpp ef385a5 
  tests/prison.cpp a722367 
  tools/CMakeLists.txt  
  tools/prison-datamatrix.cpp 6491b76 

Diff: https://git.reviewboard.kde.org/r/129418/diff/


Testing
---

cmake .. && make


Thanks,

Heiko Becker

Re: Review Request 129417: Add metainfo.yaml

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129417/
---

(Updated Nov. 16, 2016, 5:55 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Sune Vuorela.


Changes
---

Submitted with commit 1b72429bdd256711b1f430367408abe9ddee8186 by Heiko Becker 
to branch master.


Repository: prison


Description
---

Striking one requirement for becoming a framework from the list.


Diffs
-

  metainfo.yaml PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/129417/diff/


Testing
---


Thanks,

Heiko Becker

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 390 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/390/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 16 Nov 2016 17:31:12 +
Build duration: 8 min 40 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 66 test(s), Skipped: 0 test(s), Total: 
66 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 24/28 (86%)FILES 294/330 (89%)CLASSES 294/330 (89%)LINE 33121/49348 
(67%)CONDITIONAL 16844/32946 (51%)

By packages
  
autotests.src
FILES 48/48 (100%)CLASSES 48/48 (100%)LINE 4119/4432 
(93%)CONDITIONAL 1947/3960 (49%)
autotests.src.vimode
FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 5525/5569 
(99%)CONDITIONAL 897/1658 (54%)
src.buffer
FILES 14/15 (93%)CLASSES 14/15 (93%)LINE 1618/1771 
(91%)CONDITIONAL 1256/1630 (77%)
src.completion
FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 1754/3102 
(57%)CONDITIONAL 1206/2798 (43%)
src.completion.expandingtree
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 184/464 (40%)CONDITIONAL 
79/354 (22%)
src.dialogs
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/875 (0%)CONDITIONAL 0/258 
(0%)
src.document
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 1815/3217 
(56%)CONDITIONAL 1525/3229 (47%)
src.export
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 106/125 (85%)CONDITIONAL 
106/152 (70%)
src.include.ktexteditor
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 205/244 
(84%)CONDITIONAL 144/228 (63%)
src.inputmode
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 172/325 (53%)CONDITIONAL 
40/89 (45%)
src.mode
FILES 5/6 (83%)CLASSES 5/6 (83%)LINE 158/422 (37%)CONDITIONAL 
97/269 (36%)
src.printing
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/885 (0%)CONDITIONAL 0/294 
(0%)
src.render
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 912/1217 
(75%)CONDITIONAL 620/932 (67%)
src.schema
FILES 2/9 (22%)CLASSES 2/9 (22%)LINE 21/1538 (1%)CONDITIONAL 
7/697 (1%)
src.script
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 700/1055 
(66%)CONDITIONAL 295/556 (53%)
src.search
FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 1029/1404 
(73%)CONDITIONAL 576/913 (63%)
src.spellcheck
FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 372/1336 (28%)CONDITIONAL 
205/820 (25%)
src.swapfile
FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 123/373 (33%)CONDITIONAL 
60/203 (30%)
src.syntax
FILES 11/12 (92%)CLASSES 11/12 (92%)LINE 1663/2152 
(77%)CONDITIONAL 1059/1784 (59%)
src.syntax.data
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 51/69 (74%)CONDITIONAL 
73/92 (79%)
src.undo
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 671/772 (87%)CONDITIONAL 
321/448 (72%)
src.utils
FILES 33/36 (92%)CLASSES 33/36 (92%)LINE 2570/3913 
(66%)CONDITIONAL 1334/2728 (49%)
src.variableeditor
FILES 0/7 (0%)CLASSES 0/7 (0%)LINE 0/668 (0%)CONDITIONAL 0/170 
(0%)
src.view
FILES 15/19 (79%)CLASSES 15/19 (79%)LINE 3321/6291 
(53%)CONDITIONAL 1493/3791 (39%)
src.vimode
FILES 34/34 (100%)CLASSES 34/34 (100%)LINE 1876/2340 
(80%)CONDITIONAL 1028/1751 (59%)
src.vimode.config
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/134 (0%)CONDITIONAL 0/90 
(0%)
src.vimode.emulatedcommandbar
FILES 12/12 (100%)CLASSES 12/12 (100%)LINE 903/915 
(99%)CONDITIONAL 616/682 (90%)
src.vimode.modes
FILES 10/10 (100%)CLASSES 10/10 (100%)LINE 3253/3740 
(87%)CONDITIONAL 1860/2370 (78%)

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 390 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/390/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 16 Nov 2016 17:31:12 +
Build duration: 8 min 40 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 66 test(s), Skipped: 0 test(s), Total: 
66 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 24/28 (86%)FILES 294/330 (89%)CLASSES 294/330 (89%)LINE 33121/49348 
(67%)CONDITIONAL 16844/32946 (51%)

By packages
  
autotests.src
FILES 48/48 (100%)CLASSES 48/48 (100%)LINE 4119/4432 
(93%)CONDITIONAL 1947/3960 (49%)
autotests.src.vimode
FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 5525/5569 
(99%)CONDITIONAL 897/1658 (54%)
src.buffer
FILES 14/15 (93%)CLASSES 14/15 (93%)LINE 1618/1771 
(91%)CONDITIONAL 1256/1630 (77%)
src.completion
FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 1754/3102 
(57%)CONDITIONAL 1206/2798 (43%)
src.completion.expandingtree
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 184/464 (40%)CONDITIONAL 
79/354 (22%)
src.dialogs
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/875 (0%)CONDITIONAL 0/258 
(0%)
src.document
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 1815/3217 
(56%)CONDITIONAL 1525/3229 (47%)
src.export
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 106/125 (85%)CONDITIONAL 
106/152 (70%)
src.include.ktexteditor
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 205/244 
(84%)CONDITIONAL 144/228 (63%)
src.inputmode
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 172/325 (53%)CONDITIONAL 
40/89 (45%)
src.mode
FILES 5/6 (83%)CLASSES 5/6 (83%)LINE 158/422 (37%)CONDITIONAL 
97/269 (36%)
src.printing
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/885 (0%)CONDITIONAL 0/294 
(0%)
src.render
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 912/1217 
(75%)CONDITIONAL 620/932 (67%)
src.schema
FILES 2/9 (22%)CLASSES 2/9 (22%)LINE 21/1538 (1%)CONDITIONAL 
7/697 (1%)
src.script
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 700/1055 
(66%)CONDITIONAL 295/556 (53%)
src.search
FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 1029/1404 
(73%)CONDITIONAL 576/913 (63%)
src.spellcheck
FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 372/1336 (28%)CONDITIONAL 
205/820 (25%)
src.swapfile
FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 123/373 (33%)CONDITIONAL 
60/203 (30%)
src.syntax
FILES 11/12 (92%)CLASSES 11/12 (92%)LINE 1663/2152 
(77%)CONDITIONAL 1059/1784 (59%)
src.syntax.data
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 51/69 (74%)CONDITIONAL 
73/92 (79%)
src.undo
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 671/772 (87%)CONDITIONAL 
321/448 (72%)
src.utils
FILES 33/36 (92%)CLASSES 33/36 (92%)LINE 2570/3913 
(66%)CONDITIONAL 1334/2728 (49%)
src.variableeditor
FILES 0/7 (0%)CLASSES 0/7 (0%)LINE 0/668 (0%)CONDITIONAL 0/170 
(0%)
src.view
FILES 15/19 (79%)CLASSES 15/19 (79%)LINE 3321/6291 
(53%)CONDITIONAL 1493/3791 (39%)
src.vimode
FILES 34/34 (100%)CLASSES 34/34 (100%)LINE 1876/2340 
(80%)CONDITIONAL 1028/1751 (59%)
src.vimode.config
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/134 (0%)CONDITIONAL 0/90 
(0%)
src.vimode.emulatedcommandbar
FILES 12/12 (100%)CLASSES 12/12 (100%)LINE 903/915 
(99%)CONDITIONAL 616/682 (90%)
src.vimode.modes
FILES 10/10 (100%)CLASSES 10/10 (100%)LINE 3253/3740 
(87%)CONDITIONAL 1860/2370 (78%)

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 279 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/279/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 16 Nov 2016 17:12:02 +
Build duration: 15 min

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 
52 test(s)Failed: TestSuite.kiowidgets-kurifiltertest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 271/340 (80%)CLASSES 271/340 (80%)LINE 29306/51405 
(57%)CONDITIONAL 16028/38159 (42%)

By packages
  
autotests
FILES 66/66 (100%)CLASSES 66/66 (100%)LINE 7820/8142 
(96%)CONDITIONAL 4372/8542 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 96/116 (83%)CLASSES 96/116 (83%)LINE 7814/14144 
(55%)CONDITIONAL 4270/9073 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3403/7559 
(45%)CONDITIONAL 1259/4381 (29%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 443/841 (53%)CONDITIONAL 
329/725 (45%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1755/3778 
(46%)CONDITIONAL 1250/3432 (36%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 714/1138 (63%)CONDITIONAL 
386/757 (51%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 
111/138 (80%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/26 (96%)CONDITIONAL 
17/22 (77%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
333/414 (80%)
src.widgets
FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3614/10968 
(33%)CONDITIONAL 1734/6962 (25%)

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 274 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/274/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 16 Nov 2016 17:13:48 +
Build duration: 10 min

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 
52 test(s)Failed: TestSuite.kiocore-threadtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 270/339 (80%)CLASSES 270/339 (80%)LINE 29254/51370 
(57%)CONDITIONAL 16011/38137 (42%)

By packages
  
autotests
FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7783/8107 
(96%)CONDITIONAL 4358/8520 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 96/116 (83%)CLASSES 96/116 (83%)LINE 7815/14144 
(55%)CONDITIONAL 4270/9073 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3403/7559 
(45%)CONDITIONAL 1259/4381 (29%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 443/841 (53%)CONDITIONAL 
329/725 (45%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1763/3778 
(47%)CONDITIONAL 1259/3432 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 704/1138 (62%)CONDITIONAL 
377/757 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 
111/138 (80%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
333/414 (80%)
src.widgets
FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3606/10968 
(33%)CONDITIONAL 1732/6962 (25%)

Re: Review Request 129418: Adjust directory structure to Frameworks policies

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129418/#review100889
---


Ship it!




LGTM

- Aleix Pol Gonzalez


On Nov. 16, 2016, 6:02 p.m., Heiko Becker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129418/
> ---
> 
> (Updated Nov. 16, 2016, 6:02 p.m.)
> 
> 
> Review request for KDE Frameworks and Sune Vuorela.
> 
> 
> Repository: prison
> 
> 
> Description
> ---
> 
> According to the requirements listed on
> https://community.kde.org/Frameworks/Policies#Framework_directory_structure
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 37fb3a0 
>   lib/CMakeLists.txt  
>   lib/abstractbarcode.h  
>   lib/abstractbarcode.cpp  
>   lib/code39barcode.h  
>   lib/code39barcode.cpp  
>   lib/code93barcode.h  
>   lib/code93barcode.cpp  
>   lib/datamatrixbarcode.h  
>   lib/datamatrixbarcode.cpp  
>   lib/prison.h  
>   lib/prison.cpp  
>   lib/qrcodebarcode.h  
>   lib/qrcodebarcode.cpp  
>   src/CMakeLists.txt PRE-CREATION 
>   tests/barcodeexamplewidget.cpp ef385a5 
>   tests/prison.cpp a722367 
>   tools/CMakeLists.txt  
>   tools/prison-datamatrix.cpp 6491b76 
> 
> Diff: https://git.reviewboard.kde.org/r/129418/diff/
> 
> 
> Testing
> ---
> 
> cmake .. && make
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 144 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/144/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 16 Nov 2016 16:52:39 +
Build duration: 6 min 48 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.kservicetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5465/7983 
(68%)CONDITIONAL 2964/6138 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1444/1530 
(94%)CONDITIONAL 894/1768 (51%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1761/3042 
(58%)CONDITIONAL 756/1888 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2044/2798 
(73%)CONDITIONAL 1229/2054 (60%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)

Re: Review Request 129417: Add metainfo.yaml

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129417/#review100888
---


Ship it!




yay, great to see these points getting addressed.

- Martin Gräßlin


On Nov. 16, 2016, 6:02 p.m., Heiko Becker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129417/
> ---
> 
> (Updated Nov. 16, 2016, 6:02 p.m.)
> 
> 
> Review request for KDE Frameworks and Sune Vuorela.
> 
> 
> Repository: prison
> 
> 
> Description
> ---
> 
> Striking one requirement for becoming a framework from the list.
> 
> 
> Diffs
> -
> 
>   metainfo.yaml PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/129417/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

Review Request 129417: Add metainfo.yaml

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129417/
---

Review request for KDE Frameworks and Sune Vuorela.


Repository: prison


Description
---

Striking one requirement for becoming a framework from the list.


Diffs
-

  metainfo.yaml PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/129417/diff/


Testing
---


Thanks,

Heiko Becker

Review Request 129418: Adjust directory structure to Frameworks policies

[Heiko Becker]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129418/
---

Review request for KDE Frameworks and Sune Vuorela.


Repository: prison


Description
---

According to the requirements listed on
https://community.kde.org/Frameworks/Policies#Framework_directory_structure


Diffs
-

  CMakeLists.txt 37fb3a0 
  lib/CMakeLists.txt  
  lib/abstractbarcode.h  
  lib/abstractbarcode.cpp  
  lib/code39barcode.h  
  lib/code39barcode.cpp  
  lib/code93barcode.h  
  lib/code93barcode.cpp  
  lib/datamatrixbarcode.h  
  lib/datamatrixbarcode.cpp  
  lib/prison.h  
  lib/prison.cpp  
  lib/qrcodebarcode.h  
  lib/qrcodebarcode.cpp  
  src/CMakeLists.txt PRE-CREATION 
  tests/barcodeexamplewidget.cpp ef385a5 
  tests/prison.cpp a722367 
  tools/CMakeLists.txt  
  tools/prison-datamatrix.cpp 6491b76 

Diff: https://git.reviewboard.kde.org/r/129418/diff/


Testing
---

cmake .. && make


Thanks,

Heiko Becker

Re: Review Request 129414: KMessageWidget: fix layout when word-wrap is enabled without actions

[Elvis Angelaccio]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129414/
---

(Updated Nov. 16, 2016, 4:41 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, KDE Usability and Christoph Feck.


Changes
---

Submitted with commit 30ee80052d2b2e4e00cb141cd836c648a4753f04 by Elvis 
Angelaccio to branch master.


Repository: kwidgetsaddons


Description
---

If we enable word-wrap on a vanilla KMessageWidget (with no additional tool 
buttons added), the close button is placed on row number 1 (in the grid 
layout), resulting in wasted space (see first messagewidget in the screenshots).

This patch places the close button on row number 1 only when we actually have 
other buttons in the messagewidget. This way we save space in the normal case.


Diffs
-

  src/kmessagewidget.cpp e8b25f6427534a4991bb1dfe9f820cb651238e18 
  tests/kmessagewidgettest.cpp 441e961ac9b851ccc713ab1713e797bd20389efd 

Diff: https://git.reviewboard.kde.org/r/129414/diff/


Testing
---

Manual testing in the (expanded) kmessagewidgettest.


File Attachments


Before: wasted space in the first messagewidget
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/11/16/e2fb5bce-e249-44fc-9ece-d49c0cf656e1__Spectacle.E12435.png
After: no wasted space in the first messagewidget
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/11/16/09986a2d-f1be-48ad-92f0-87d264873ad9__Spectacle.J13060.png
Before (with text wrapped)
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/11/16/ab594606-7f90-4ca8-949d-9baafd448252__Spectacle.X22288.png
After (with text wrapped)
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/11/16/f574d6e6-7c92-443a-b1de-345cb3ed3ad3__Spectacle.J21199.png


Thanks,

Elvis Angelaccio

Re: Send Email with attachment with my Qt Application

[Charles-Elie Gentil]

Hello,

I try this solution with mailto, but adding attachment don’t work with this 
command

Best regards,

Charlie

m...@jiyuusoft.net
http://blog.jiyuusoft.net

> Le 16 nov. 2016 à 17:18, David Edmundson  a écrit 
> :
> 
> 
> ​You can just use QDesktopServices::openUrl() with a mailto: URL.
> 
> http://doc.qt.io/qt-5/qdesktopservices.html#openUrl 
> 
> 
> David

Re: Send Email with attachment with my Qt Application

[David Edmundson]

Sorry, didn't read that second line properly about attachments properly.

What error do you get when buildling kservice?
You may find this tool that builds dependencies useful: https://inqlude.org.


Alternatively, you can probably just extract this one invokeMailer here:
https://api.kde.org/frameworks/kservice/html/ktoolinvocation__win_8cpp_source.html

It appears KToolInvocation doesn't have an OS X backend.

David

Re: Send Email with attachment with my Qt Application

[David Edmundson]

​You can just use QDesktopServices::openUrl() with a mailto: URL.

http://doc.qt.io/qt-5/qdesktopservices.html#openUrl

David

Re: Review Request 129414: KMessageWidget: fix layout when word-wrap is enabled without actions

[Christoph Feck]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129414/#review100887
---


Ship it!




Ship It!

- Christoph Feck


On Nov. 16, 2016, 5:11 p.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129414/
> ---
> 
> (Updated Nov. 16, 2016, 5:11 p.m.)
> 
> 
> Review request for KDE Frameworks, KDE Usability and Christoph Feck.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> If we enable word-wrap on a vanilla KMessageWidget (with no additional tool 
> buttons added), the close button is placed on row number 1 (in the grid 
> layout), resulting in wasted space (see first messagewidget in the 
> screenshots).
> 
> This patch places the close button on row number 1 only when we actually have 
> other buttons in the messagewidget. This way we save space in the normal case.
> 
> 
> Diffs
> -
> 
>   src/kmessagewidget.cpp e8b25f6427534a4991bb1dfe9f820cb651238e18 
>   tests/kmessagewidgettest.cpp 441e961ac9b851ccc713ab1713e797bd20389efd 
> 
> Diff: https://git.reviewboard.kde.org/r/129414/diff/
> 
> 
> Testing
> ---
> 
> Manual testing in the (expanded) kmessagewidgettest.
> 
> 
> File Attachments
> 
> 
> Before: wasted space in the first messagewidget
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/11/16/e2fb5bce-e249-44fc-9ece-d49c0cf656e1__Spectacle.E12435.png
> After: no wasted space in the first messagewidget
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/11/16/09986a2d-f1be-48ad-92f0-87d264873ad9__Spectacle.J13060.png
> Before (with text wrapped)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/11/16/ab594606-7f90-4ca8-949d-9baafd448252__Spectacle.X22288.png
> After (with text wrapped)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/11/16/f574d6e6-7c92-443a-b1de-345cb3ed3ad3__Spectacle.J21199.png
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

[Differential] [Updated, 194 lines] D3386: Generate an instance with KSharedConfig::Ptr for singleton and arg

[Martin Gräßlin]

graesslin updated this revision to Diff 8228.
graesslin added a comment.


  Added a test case

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3386?vs=8220&id=8228

BRANCH
  kconfigcompiler-instance-ksharedconfig

REVISION DETAIL
  https://phabricator.kde.org/D3386

AFFECTED FILES
  autotests/kconfig_compiler/CMakeLists.txt
  autotests/kconfig_compiler/kconfigcompiler_test.cpp
  autotests/kconfig_compiler/test8c.cpp.ref
  autotests/kconfig_compiler/test8c.h.ref
  autotests/kconfig_compiler/test8c.kcfg
  autotests/kconfig_compiler/test8c.kcfgc
  autotests/kconfig_compiler/test8main.cpp
  src/kconfig_compiler/kconfig_compiler.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #frameworks
Cc: apol

Re: Review Request 129414: KMessageWidget: fix layout when word-wrap is enabled without actions

[Elvis Angelaccio]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129414/
---

(Updated Nov. 16, 2016, 4:11 p.m.)


Review request for KDE Frameworks and Christoph Feck.


Changes
---

Use top-vertical alignment for close button


Repository: kwidgetsaddons


Description
---

If we enable word-wrap on a vanilla KMessageWidget (with no additional tool 
buttons added), the close button is placed on row number 1 (in the grid 
layout), resulting in wasted space (see first messagewidget in the screenshots).

This patch places the close button on row number 1 only when we actually have 
other buttons in the messagewidget. This way we save space in the normal case.


Diffs (updated)
-

  src/kmessagewidget.cpp e8b25f6427534a4991bb1dfe9f820cb651238e18 
  tests/kmessagewidgettest.cpp 441e961ac9b851ccc713ab1713e797bd20389efd 

Diff: https://git.reviewboard.kde.org/r/129414/diff/


Testing
---

Manual testing in the (expanded) kmessagewidgettest.


File Attachments


Before: wasted space in the first messagewidget
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/11/16/e2fb5bce-e249-44fc-9ece-d49c0cf656e1__Spectacle.E12435.png
After: no wasted space in the first messagewidget
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/11/16/09986a2d-f1be-48ad-92f0-87d264873ad9__Spectacle.J13060.png
Before (with text wrapped)
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/11/16/ab594606-7f90-4ca8-949d-9baafd448252__Spectacle.X22288.png
After (with text wrapped)
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/11/16/f574d6e6-7c92-443a-b1de-345cb3ed3ad3__Spectacle.J21199.png


Thanks,

Elvis Angelaccio

Re: Review Request 129414: KMessageWidget: fix layout when word-wrap is enabled without actions

[Heiko Tietze]

> On Nov. 16, 2016, 1:10 nachm., Christoph Feck wrote:
> > Could you add a screen shot that shows actually wrapped text?
> 
> Christoph Feck wrote:
> Thanks, so the close icon is vertically centered.
> 
> Heiko, do you agree that the close icon would look better if it was also 
> top-aligned like the message icon?
> 
> Heiko Tietze wrote:
> Better you align it vertically with the left-hand topic icon meaning at 
> top. That would be also place this icon according the usual position.
> 
> Elvis Angelaccio wrote:
> This is how it looks with top vertical alignment: 
> http://i.imgur.com/i1nrxmN.png

Perfect (this is in particular relevant for more than two lines).


- Heiko


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129414/#review100879
---


On Nov. 16, 2016, 1:47 nachm., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129414/
> ---
> 
> (Updated Nov. 16, 2016, 1:47 nachm.)
> 
> 
> Review request for KDE Frameworks, KDE Usability and Christoph Feck.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> If we enable word-wrap on a vanilla KMessageWidget (with no additional tool 
> buttons added), the close button is placed on row number 1 (in the grid 
> layout), resulting in wasted space (see first messagewidget in the 
> screenshots).
> 
> This patch places the close button on row number 1 only when we actually have 
> other buttons in the messagewidget. This way we save space in the normal case.
> 
> 
> Diffs
> -
> 
>   src/kmessagewidget.cpp e8b25f6427534a4991bb1dfe9f820cb651238e18 
>   tests/kmessagewidgettest.cpp 441e961ac9b851ccc713ab1713e797bd20389efd 
> 
> Diff: https://git.reviewboard.kde.org/r/129414/diff/
> 
> 
> Testing
> ---
> 
> Manual testing in the (expanded) kmessagewidgettest.
> 
> 
> File Attachments
> 
> 
> Before: wasted space in the first messagewidget
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/11/16/e2fb5bce-e249-44fc-9ece-d49c0cf656e1__Spectacle.E12435.png
> After: no wasted space in the first messagewidget
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/11/16/09986a2d-f1be-48ad-92f0-87d264873ad9__Spectacle.J13060.png
> Before (with text wrapped)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/11/16/ab594606-7f90-4ca8-949d-9baafd448252__Spectacle.X22288.png
> After (with text wrapped)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/11/16/f574d6e6-7c92-443a-b1de-345cb3ed3ad3__Spectacle.J21199.png
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

Re: Review Request 129414: KMessageWidget: fix layout when word-wrap is enabled without actions

[Elvis Angelaccio]

> On Nov. 16, 2016, 1:10 p.m., Christoph Feck wrote:
> > Could you add a screen shot that shows actually wrapped text?
> 
> Christoph Feck wrote:
> Thanks, so the close icon is vertically centered.
> 
> Heiko, do you agree that the close icon would look better if it was also 
> top-aligned like the message icon?
> 
> Heiko Tietze wrote:
> Better you align it vertically with the left-hand topic icon meaning at 
> top. That would be also place this icon according the usual position.

This is how it looks with top vertical alignment: http://i.imgur.com/i1nrxmN.png


- Elvis


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129414/#review100879
---


On Nov. 16, 2016, 1:47 p.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129414/
> ---
> 
> (Updated Nov. 16, 2016, 1:47 p.m.)
> 
> 
> Review request for KDE Frameworks, KDE Usability and Christoph Feck.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> If we enable word-wrap on a vanilla KMessageWidget (with no additional tool 
> buttons added), the close button is placed on row number 1 (in the grid 
> layout), resulting in wasted space (see first messagewidget in the 
> screenshots).
> 
> This patch places the close button on row number 1 only when we actually have 
> other buttons in the messagewidget. This way we save space in the normal case.
> 
> 
> Diffs
> -
> 
>   src/kmessagewidget.cpp e8b25f6427534a4991bb1dfe9f820cb651238e18 
>   tests/kmessagewidgettest.cpp 441e961ac9b851ccc713ab1713e797bd20389efd 
> 
> Diff: https://git.reviewboard.kde.org/r/129414/diff/
> 
> 
> Testing
> ---
> 
> Manual testing in the (expanded) kmessagewidgettest.
> 
> 
> File Attachments
> 
> 
> Before: wasted space in the first messagewidget
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/11/16/e2fb5bce-e249-44fc-9ece-d49c0cf656e1__Spectacle.E12435.png
> After: no wasted space in the first messagewidget
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/11/16/09986a2d-f1be-48ad-92f0-87d264873ad9__Spectacle.J13060.png
> Before (with text wrapped)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/11/16/ab594606-7f90-4ca8-949d-9baafd448252__Spectacle.X22288.png
> After (with text wrapped)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/11/16/f574d6e6-7c92-443a-b1de-345cb3ed3ad3__Spectacle.J21199.png
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

Re: Review Request 129414: KMessageWidget: fix layout when word-wrap is enabled without actions

[Heiko Tietze]

> On Nov. 16, 2016, 1:10 nachm., Christoph Feck wrote:
> > Could you add a screen shot that shows actually wrapped text?
> 
> Christoph Feck wrote:
> Thanks, so the close icon is vertically centered.
> 
> Heiko, do you agree that the close icon would look better if it was also 
> top-aligned like the message icon?

Better you align it vertically with the left-hand topic icon meaning at top. 
That would be also place this icon according the usual position.


- Heiko


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129414/#review100879
---


On Nov. 16, 2016, 1:47 nachm., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129414/
> ---
> 
> (Updated Nov. 16, 2016, 1:47 nachm.)
> 
> 
> Review request for KDE Frameworks, KDE Usability and Christoph Feck.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> If we enable word-wrap on a vanilla KMessageWidget (with no additional tool 
> buttons added), the close button is placed on row number 1 (in the grid 
> layout), resulting in wasted space (see first messagewidget in the 
> screenshots).
> 
> This patch places the close button on row number 1 only when we actually have 
> other buttons in the messagewidget. This way we save space in the normal case.
> 
> 
> Diffs
> -
> 
>   src/kmessagewidget.cpp e8b25f6427534a4991bb1dfe9f820cb651238e18 
>   tests/kmessagewidgettest.cpp 441e961ac9b851ccc713ab1713e797bd20389efd 
> 
> Diff: https://git.reviewboard.kde.org/r/129414/diff/
> 
> 
> Testing
> ---
> 
> Manual testing in the (expanded) kmessagewidgettest.
> 
> 
> File Attachments
> 
> 
> Before: wasted space in the first messagewidget
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/11/16/e2fb5bce-e249-44fc-9ece-d49c0cf656e1__Spectacle.E12435.png
> After: no wasted space in the first messagewidget
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/11/16/09986a2d-f1be-48ad-92f0-87d264873ad9__Spectacle.J13060.png
> Before (with text wrapped)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/11/16/ab594606-7f90-4ca8-949d-9baafd448252__Spectacle.X22288.png
> After (with text wrapped)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/11/16/f574d6e6-7c92-443a-b1de-345cb3ed3ad3__Spectacle.J21199.png
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

[Differential] [Commented On] D3386: Generate an instance with KSharedConfig::Ptr for singleton and arg

[apol (Aleix Pol Gonzalez)]

apol added a comment.


  Then please include a test with your new feature.

REVISION DETAIL
  https://phabricator.kde.org/D3386

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #frameworks
Cc: apol

[Differential] [Commented On] D3386: Generate an instance with KSharedConfig::Ptr for singleton and arg

[Martin Gräßlin]

graesslin added a comment.


  Just checked: the only test with a combination of arg="true" and singleton is 
signals_test_singleton.kcfgc which is used by kconfigcompiler_test_signals.cpp, 
but there is no code comparison in that test.
  
  The only other arg="true" case is test8a.kcfg, but that one is not a 
singleton.

REVISION DETAIL
  https://phabricator.kde.org/D3386

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #frameworks
Cc: apol

[Differential] [Commented On] D3386: Generate an instance with KSharedConfig::Ptr for singleton and arg

[Martin Gräßlin]

graesslin added a comment.


  In https://phabricator.kde.org/D3386#63201, @apol wrote:
  
  > How can tests still pass? they compare the generated code.
  
  
  eh no idea. I did a make clean, make, make test in the folder. Maybe there is 
no test for the singleton + arg="true" combination?

REVISION DETAIL
  https://phabricator.kde.org/D3386

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #frameworks
Cc: apol

[Differential] [Commented On] D3386: Generate an instance with KSharedConfig::Ptr for singleton and arg

[apol (Aleix Pol Gonzalez)]

apol added a comment.


  How can tests still pass? they compare the generated code.

REVISION DETAIL
  https://phabricator.kde.org/D3386

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #frameworks
Cc: apol

Send Email with attachment with my Qt Application

[Charles-Elie Gentil]

Hi,


I work on a Qt application with which I have to send an email with an 
attachment. I want use the native client of device. Unfortunately, mailto can’t 
send attachment. Also I have looking the source code of Calligra and it seem 
that it would be possible to use KToolInvocation::invokMailer.
For this, I want try to use KService, but I don’t found the way to build this.

Can you help me ? or have you a (MacOS & Win) solution to send this email 
without use KService ?

Thank you in advance.

Best regards,

Charlie

m...@jiyuusoft.net
http://blog.jiyuusoft.net

Re: Review Request 129414: KMessageWidget: fix layout when word-wrap is enabled without actions

[Christoph Feck]

> On Nov. 16, 2016, 2:10 p.m., Christoph Feck wrote:
> > Could you add a screen shot that shows actually wrapped text?

Thanks, so the close icon is vertically centered.

Heiko, do you agree that the close icon would look better if it was also 
top-aligned like the message icon?


- Christoph


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129414/#review100879
---


On Nov. 16, 2016, 2:47 p.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129414/
> ---
> 
> (Updated Nov. 16, 2016, 2:47 p.m.)
> 
> 
> Review request for KDE Frameworks, KDE Usability and Christoph Feck.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> If we enable word-wrap on a vanilla KMessageWidget (with no additional tool 
> buttons added), the close button is placed on row number 1 (in the grid 
> layout), resulting in wasted space (see first messagewidget in the 
> screenshots).
> 
> This patch places the close button on row number 1 only when we actually have 
> other buttons in the messagewidget. This way we save space in the normal case.
> 
> 
> Diffs
> -
> 
>   src/kmessagewidget.cpp e8b25f6427534a4991bb1dfe9f820cb651238e18 
>   tests/kmessagewidgettest.cpp 441e961ac9b851ccc713ab1713e797bd20389efd 
> 
> Diff: https://git.reviewboard.kde.org/r/129414/diff/
> 
> 
> Testing
> ---
> 
> Manual testing in the (expanded) kmessagewidgettest.
> 
> 
> File Attachments
> 
> 
> Before: wasted space in the first messagewidget
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/11/16/e2fb5bce-e249-44fc-9ece-d49c0cf656e1__Spectacle.E12435.png
> After: no wasted space in the first messagewidget
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/11/16/09986a2d-f1be-48ad-92f0-87d264873ad9__Spectacle.J13060.png
> Before (with text wrapped)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/11/16/ab594606-7f90-4ca8-949d-9baafd448252__Spectacle.X22288.png
> After (with text wrapped)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/11/16/f574d6e6-7c92-443a-b1de-345cb3ed3ad3__Spectacle.J21199.png
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

[Differential] [Request, 33 lines] D3386: Generate an instance with KSharedConfig::Ptr for singleton and arg

[Martin Gräßlin]

graesslin created this revision.
graesslin added a reviewer: Frameworks.

REVISION SUMMARY
  In case a kcfg with arg="true" was used and singleton the static
  instance method only accepted a QString config name. This made it
  impossible to combine a singleton config with an already existing and
  open KSharedConfig::Ptr.
  
  With this change an overloaded instance method is added which takes a
  KSharedConfig::Ptr as argument. The private ctor, though, only takes a
  KSharedConfig::Ptr and the instance method taking a QString argument
  uses KSharedConfig::openConfig on the config file name.
  
  This provides full API compatibility and at the same time allows to use
  KSharedConfig in addition to the arg name based variant.

TEST PLAN
  kconfigcompiler tests still pass and a config with singleton
  and arg="true" generates the code as I need it

BRANCH
  kconfigcompiler-instance-ksharedconfig

REVISION DETAIL
  https://phabricator.kde.org/D3386

AFFECTED FILES
  src/kconfig_compiler/kconfig_compiler.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #frameworks

Jenkins-kde-ci: knewstuff master kf5-qt5 » Linux,gcc - Build # 293 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/knewstuff%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/293/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 16 Nov 2016 13:51:53 +
Build duration: 5 min 51 sec

CHANGE SET
Revision 7a644d7147edb816b69fa973630cea6aa72bc3ef by admin: (The src/ dir is 
needed for the entry.h header)
  change: edit src/core/CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/10 (50%)FILES 11/62 (18%)CLASSES 11/62 (18%)LINE 755/5323 
(14%)CONDITIONAL 368/3100 (12%)

By packages
  
autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 77/77 (100%)CONDITIONAL 
40/80 (50%)
autotests.kmoretools
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 160/175 (91%)CONDITIONAL 
84/192 (44%)
src
FILES 2/9 (22%)CLASSES 2/9 (22%)LINE 23/1024 (2%)CONDITIONAL 
0/384 (0%)
src.attica
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/281 (0%)CONDITIONAL 0/205 
(0%)
src.core
FILES 3/22 (14%)CLASSES 3/22 (14%)LINE 99/1651 (6%)CONDITIONAL 
54/1093 (5%)
src.core.jobs
FILES 0/6 (0%)CLASSES 0/6 (0%)LINE 0/187 (0%)CONDITIONAL 0/76 
(0%)
src.kmoretools
FILES 3/5 (60%)CLASSES 3/5 (60%)LINE 396/889 (45%)CONDITIONAL 
190/550 (35%)
src.staticxml
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/154 (0%)CONDITIONAL 0/124 
(0%)
src.ui
FILES 0/11 (0%)CLASSES 0/11 (0%)LINE 0/743 (0%)CONDITIONAL 
0/310 (0%)
src.upload
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/142 (0%)CONDITIONAL 0/86 
(0%)

Jenkins-kde-ci: knewstuff master kf5-qt5 » Linux,gcc - Build # 293 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/knewstuff%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/293/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 16 Nov 2016 13:51:53 +
Build duration: 5 min 51 sec

CHANGE SET
Revision 7a644d7147edb816b69fa973630cea6aa72bc3ef by admin: (The src/ dir is 
needed for the entry.h header)
  change: edit src/core/CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/10 (50%)FILES 11/62 (18%)CLASSES 11/62 (18%)LINE 755/5323 
(14%)CONDITIONAL 368/3100 (12%)

By packages
  
autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 77/77 (100%)CONDITIONAL 
40/80 (50%)
autotests.kmoretools
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 160/175 (91%)CONDITIONAL 
84/192 (44%)
src
FILES 2/9 (22%)CLASSES 2/9 (22%)LINE 23/1024 (2%)CONDITIONAL 
0/384 (0%)
src.attica
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/281 (0%)CONDITIONAL 0/205 
(0%)
src.core
FILES 3/22 (14%)CLASSES 3/22 (14%)LINE 99/1651 (6%)CONDITIONAL 
54/1093 (5%)
src.core.jobs
FILES 0/6 (0%)CLASSES 0/6 (0%)LINE 0/187 (0%)CONDITIONAL 0/76 
(0%)
src.kmoretools
FILES 3/5 (60%)CLASSES 3/5 (60%)LINE 396/889 (45%)CONDITIONAL 
190/550 (35%)
src.staticxml
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/154 (0%)CONDITIONAL 0/124 
(0%)
src.ui
FILES 0/11 (0%)CLASSES 0/11 (0%)LINE 0/743 (0%)CONDITIONAL 
0/310 (0%)
src.upload
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/142 (0%)CONDITIONAL 0/86 
(0%)

Jenkins-kde-ci: knewstuff master stable-kf5-qt5 » Linux,gcc - Build # 298 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/knewstuff%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/298/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 16 Nov 2016 13:51:53 +
Build duration: 1 min 26 sec

CHANGE SET
Revision 7a644d7147edb816b69fa973630cea6aa72bc3ef by admin: (The src/ dir is 
needed for the entry.h header)
  change: edit src/core/CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/10 (50%)FILES 11/62 (18%)CLASSES 11/62 (18%)LINE 755/5323 
(14%)CONDITIONAL 368/3100 (12%)

By packages
  
autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 77/77 (100%)CONDITIONAL 
40/80 (50%)
autotests.kmoretools
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 160/175 (91%)CONDITIONAL 
84/192 (44%)
src
FILES 2/9 (22%)CLASSES 2/9 (22%)LINE 23/1024 (2%)CONDITIONAL 
0/384 (0%)
src.attica
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/281 (0%)CONDITIONAL 0/205 
(0%)
src.core
FILES 3/22 (14%)CLASSES 3/22 (14%)LINE 99/1651 (6%)CONDITIONAL 
54/1093 (5%)
src.core.jobs
FILES 0/6 (0%)CLASSES 0/6 (0%)LINE 0/187 (0%)CONDITIONAL 0/76 
(0%)
src.kmoretools
FILES 3/5 (60%)CLASSES 3/5 (60%)LINE 396/889 (45%)CONDITIONAL 
190/550 (35%)
src.staticxml
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/154 (0%)CONDITIONAL 0/124 
(0%)
src.ui
FILES 0/11 (0%)CLASSES 0/11 (0%)LINE 0/743 (0%)CONDITIONAL 
0/310 (0%)
src.upload
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/142 (0%)CONDITIONAL 0/86 
(0%)

Jenkins-kde-ci: knewstuff master stable-kf5-qt5 » Linux,gcc - Build # 298 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/knewstuff%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/298/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 16 Nov 2016 13:51:53 +
Build duration: 1 min 26 sec

CHANGE SET
Revision 7a644d7147edb816b69fa973630cea6aa72bc3ef by admin: (The src/ dir is 
needed for the entry.h header)
  change: edit src/core/CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/10 (50%)FILES 11/62 (18%)CLASSES 11/62 (18%)LINE 755/5323 
(14%)CONDITIONAL 368/3100 (12%)

By packages
  
autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 77/77 (100%)CONDITIONAL 
40/80 (50%)
autotests.kmoretools
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 160/175 (91%)CONDITIONAL 
84/192 (44%)
src
FILES 2/9 (22%)CLASSES 2/9 (22%)LINE 23/1024 (2%)CONDITIONAL 
0/384 (0%)
src.attica
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/281 (0%)CONDITIONAL 0/205 
(0%)
src.core
FILES 3/22 (14%)CLASSES 3/22 (14%)LINE 99/1651 (6%)CONDITIONAL 
54/1093 (5%)
src.core.jobs
FILES 0/6 (0%)CLASSES 0/6 (0%)LINE 0/187 (0%)CONDITIONAL 0/76 
(0%)
src.kmoretools
FILES 3/5 (60%)CLASSES 3/5 (60%)LINE 396/889 (45%)CONDITIONAL 
190/550 (35%)
src.staticxml
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/154 (0%)CONDITIONAL 0/124 
(0%)
src.ui
FILES 0/11 (0%)CLASSES 0/11 (0%)LINE 0/743 (0%)CONDITIONAL 
0/310 (0%)
src.upload
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/142 (0%)CONDITIONAL 0/86 
(0%)

Re: Review Request 129414: KMessageWidget: fix layout when word-wrap is enabled without actions

[Elvis Angelaccio]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129414/
---

(Updated Nov. 16, 2016, 1:47 p.m.)


Review request for KDE Frameworks, KDE Usability and Christoph Feck.


Changes
---

Screenshots before/after with wrapped text.


Repository: kwidgetsaddons


Description
---

If we enable word-wrap on a vanilla KMessageWidget (with no additional tool 
buttons added), the close button is placed on row number 1 (in the grid 
layout), resulting in wasted space (see first messagewidget in the screenshots).

This patch places the close button on row number 1 only when we actually have 
other buttons in the messagewidget. This way we save space in the normal case.


Diffs
-

  src/kmessagewidget.cpp e8b25f6427534a4991bb1dfe9f820cb651238e18 
  tests/kmessagewidgettest.cpp 441e961ac9b851ccc713ab1713e797bd20389efd 

Diff: https://git.reviewboard.kde.org/r/129414/diff/


Testing
---

Manual testing in the (expanded) kmessagewidgettest.


File Attachments (updated)


Before: wasted space in the first messagewidget
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/11/16/e2fb5bce-e249-44fc-9ece-d49c0cf656e1__Spectacle.E12435.png
After: no wasted space in the first messagewidget
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/11/16/09986a2d-f1be-48ad-92f0-87d264873ad9__Spectacle.J13060.png
Before (with text wrapped)
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/11/16/ab594606-7f90-4ca8-949d-9baafd448252__Spectacle.X22288.png
After (with text wrapped)
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/11/16/f574d6e6-7c92-443a-b1de-345cb3ed3ad3__Spectacle.J21199.png


Thanks,

Elvis Angelaccio

Jenkins-kde-ci: knewstuff master stable-kf5-qt5 » Linux,gcc - Build # 297 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/knewstuff%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/297/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 16 Nov 2016 13:40:23 +
Build duration: 32 sec

CHANGE SET
Revision 4f6f543fd19d79f91fbf77c5fa88dc45e7d5ab99 by admin: (There should only 
be one project() call in the project)
  change: edit src/core/CMakeLists.txt
  change: edit src/qtquick/CMakeLists.txt
  change: edit src/CMakeLists.txt

Jenkins-kde-ci: knewstuff master kf5-qt5 » Linux,gcc - Build # 292 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/knewstuff%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/292/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 16 Nov 2016 13:40:23 +
Build duration: 34 sec

CHANGE SET
Revision 4f6f543fd19d79f91fbf77c5fa88dc45e7d5ab99 by admin: (There should only 
be one project() call in the project)
  change: edit src/CMakeLists.txt
  change: edit src/qtquick/CMakeLists.txt
  change: edit src/core/CMakeLists.txt

Jenkins-kde-ci: knewstuff master stable-kf5-qt5 » Linux,gcc - Build # 296 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/knewstuff%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/296/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 16 Nov 2016 13:28:56 +
Build duration: 7 min 8 sec

CHANGE SET
Revision 11dc09fae3b99b018db29136d5e59ce4896f13fe by admin: (The core debug 
file is in src/core, not src/)
  change: edit autotests/CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/10 (50%)FILES 11/62 (18%)CLASSES 11/62 (18%)LINE 755/5323 
(14%)CONDITIONAL 368/3100 (12%)

By packages
  
autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 77/77 (100%)CONDITIONAL 
40/80 (50%)
autotests.kmoretools
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 160/175 (91%)CONDITIONAL 
84/192 (44%)
src
FILES 2/9 (22%)CLASSES 2/9 (22%)LINE 23/1024 (2%)CONDITIONAL 
0/384 (0%)
src.attica
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/281 (0%)CONDITIONAL 0/205 
(0%)
src.core
FILES 3/22 (14%)CLASSES 3/22 (14%)LINE 99/1651 (6%)CONDITIONAL 
54/1093 (5%)
src.core.jobs
FILES 0/6 (0%)CLASSES 0/6 (0%)LINE 0/187 (0%)CONDITIONAL 0/76 
(0%)
src.kmoretools
FILES 3/5 (60%)CLASSES 3/5 (60%)LINE 396/889 (45%)CONDITIONAL 
190/550 (35%)
src.staticxml
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/154 (0%)CONDITIONAL 0/124 
(0%)
src.ui
FILES 0/11 (0%)CLASSES 0/11 (0%)LINE 0/743 (0%)CONDITIONAL 
0/310 (0%)
src.upload
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/142 (0%)CONDITIONAL 0/86 
(0%)

Jenkins-kde-ci: knewstuff master kf5-qt5 » Linux,gcc - Build # 291 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/knewstuff%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/291/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 16 Nov 2016 13:28:56 +
Build duration: 7 min 14 sec

CHANGE SET
Revision 11dc09fae3b99b018db29136d5e59ce4896f13fe by admin: (The core debug 
file is in src/core, not src/)
  change: edit autotests/CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/10 (50%)FILES 11/62 (18%)CLASSES 11/62 (18%)LINE 755/5323 
(14%)CONDITIONAL 368/3100 (12%)

By packages
  
autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 77/77 (100%)CONDITIONAL 
40/80 (50%)
autotests.kmoretools
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 160/175 (91%)CONDITIONAL 
84/192 (44%)
src
FILES 2/9 (22%)CLASSES 2/9 (22%)LINE 23/1024 (2%)CONDITIONAL 
0/384 (0%)
src.attica
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/281 (0%)CONDITIONAL 0/205 
(0%)
src.core
FILES 3/22 (14%)CLASSES 3/22 (14%)LINE 99/1651 (6%)CONDITIONAL 
54/1093 (5%)
src.core.jobs
FILES 0/6 (0%)CLASSES 0/6 (0%)LINE 0/187 (0%)CONDITIONAL 0/76 
(0%)
src.kmoretools
FILES 3/5 (60%)CLASSES 3/5 (60%)LINE 396/889 (45%)CONDITIONAL 
190/550 (35%)
src.staticxml
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/154 (0%)CONDITIONAL 0/124 
(0%)
src.ui
FILES 0/11 (0%)CLASSES 0/11 (0%)LINE 0/743 (0%)CONDITIONAL 
0/310 (0%)
src.upload
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/142 (0%)CONDITIONAL 0/86 
(0%)

Jenkins-kde-ci: knewstuff master kf5-qt5 » Linux,gcc - Build # 291 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/knewstuff%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/291/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 16 Nov 2016 13:28:56 +
Build duration: 7 min 14 sec

CHANGE SET
Revision 11dc09fae3b99b018db29136d5e59ce4896f13fe by admin: (The core debug 
file is in src/core, not src/)
  change: edit autotests/CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/10 (50%)FILES 11/62 (18%)CLASSES 11/62 (18%)LINE 755/5323 
(14%)CONDITIONAL 368/3100 (12%)

By packages
  
autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 77/77 (100%)CONDITIONAL 
40/80 (50%)
autotests.kmoretools
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 160/175 (91%)CONDITIONAL 
84/192 (44%)
src
FILES 2/9 (22%)CLASSES 2/9 (22%)LINE 23/1024 (2%)CONDITIONAL 
0/384 (0%)
src.attica
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/281 (0%)CONDITIONAL 0/205 
(0%)
src.core
FILES 3/22 (14%)CLASSES 3/22 (14%)LINE 99/1651 (6%)CONDITIONAL 
54/1093 (5%)
src.core.jobs
FILES 0/6 (0%)CLASSES 0/6 (0%)LINE 0/187 (0%)CONDITIONAL 0/76 
(0%)
src.kmoretools
FILES 3/5 (60%)CLASSES 3/5 (60%)LINE 396/889 (45%)CONDITIONAL 
190/550 (35%)
src.staticxml
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/154 (0%)CONDITIONAL 0/124 
(0%)
src.ui
FILES 0/11 (0%)CLASSES 0/11 (0%)LINE 0/743 (0%)CONDITIONAL 
0/310 (0%)
src.upload
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/142 (0%)CONDITIONAL 0/86 
(0%)

Jenkins-kde-ci: knewstuff master stable-kf5-qt5 » Linux,gcc - Build # 296 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/knewstuff%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/296/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 16 Nov 2016 13:28:56 +
Build duration: 7 min 8 sec

CHANGE SET
Revision 11dc09fae3b99b018db29136d5e59ce4896f13fe by admin: (The core debug 
file is in src/core, not src/)
  change: edit autotests/CMakeLists.txt


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/10 (50%)FILES 11/62 (18%)CLASSES 11/62 (18%)LINE 755/5323 
(14%)CONDITIONAL 368/3100 (12%)

By packages
  
autotests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 77/77 (100%)CONDITIONAL 
40/80 (50%)
autotests.kmoretools
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 160/175 (91%)CONDITIONAL 
84/192 (44%)
src
FILES 2/9 (22%)CLASSES 2/9 (22%)LINE 23/1024 (2%)CONDITIONAL 
0/384 (0%)
src.attica
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/281 (0%)CONDITIONAL 0/205 
(0%)
src.core
FILES 3/22 (14%)CLASSES 3/22 (14%)LINE 99/1651 (6%)CONDITIONAL 
54/1093 (5%)
src.core.jobs
FILES 0/6 (0%)CLASSES 0/6 (0%)LINE 0/187 (0%)CONDITIONAL 0/76 
(0%)
src.kmoretools
FILES 3/5 (60%)CLASSES 3/5 (60%)LINE 396/889 (45%)CONDITIONAL 
190/550 (35%)
src.staticxml
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/154 (0%)CONDITIONAL 0/124 
(0%)
src.ui
FILES 0/11 (0%)CLASSES 0/11 (0%)LINE 0/743 (0%)CONDITIONAL 
0/310 (0%)
src.upload
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/142 (0%)CONDITIONAL 0/86 
(0%)

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 389 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/389/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 16 Nov 2016 12:57:06 +
Build duration: 26 min

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 3 test(s), Passed: 63 test(s), Skipped: 0 test(s), Total: 
66 test(s)Failed: TestSuite.kateindenttest_testCppstyleFailed: 
TestSuite.kateindenttest_testCstyleFailed: TestSuite.kateindenttest_testRuby

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 24/28 (86%)FILES 294/330 (89%)CLASSES 294/330 (89%)LINE 32996/49348 
(67%)CONDITIONAL 16775/32946 (51%)

By packages
  
autotests.src
FILES 48/48 (100%)CLASSES 48/48 (100%)LINE 4043/4432 
(91%)CONDITIONAL 1921/3960 (49%)
autotests.src.vimode
FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 5525/5569 
(99%)CONDITIONAL 897/1658 (54%)
src.buffer
FILES 14/15 (93%)CLASSES 14/15 (93%)LINE 1617/1771 
(91%)CONDITIONAL 1255/1630 (77%)
src.completion
FILES 16/16 (100%)CLASSES 16/16 (100%)LINE 1754/3102 
(57%)CONDITIONAL 1206/2798 (43%)
src.completion.expandingtree
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 184/464 (40%)CONDITIONAL 
79/354 (22%)
src.dialogs
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/875 (0%)CONDITIONAL 0/258 
(0%)
src.document
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 1794/3217 
(56%)CONDITIONAL 1502/3229 (47%)
src.export
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 106/125 (85%)CONDITIONAL 
106/152 (70%)
src.include.ktexteditor
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 203/244 
(83%)CONDITIONAL 144/228 (63%)
src.inputmode
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 172/325 (53%)CONDITIONAL 
40/89 (45%)
src.mode
FILES 5/6 (83%)CLASSES 5/6 (83%)LINE 158/422 (37%)CONDITIONAL 
97/269 (36%)
src.printing
FILES 0/4 (0%)CLASSES 0/4 (0%)LINE 0/885 (0%)CONDITIONAL 0/294 
(0%)
src.render
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 912/1217 
(75%)CONDITIONAL 620/932 (67%)
src.schema
FILES 2/9 (22%)CLASSES 2/9 (22%)LINE 21/1538 (1%)CONDITIONAL 
7/697 (1%)
src.script
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 688/1055 
(65%)CONDITIONAL 290/556 (52%)
src.search
FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 1029/1404 
(73%)CONDITIONAL 576/913 (63%)
src.spellcheck
FILES 5/7 (71%)CLASSES 5/7 (71%)LINE 372/1336 (28%)CONDITIONAL 
205/820 (25%)
src.swapfile
FILES 1/2 (50%)CLASSES 1/2 (50%)LINE 123/373 (33%)CONDITIONAL 
60/203 (30%)
src.syntax
FILES 11/12 (92%)CLASSES 11/12 (92%)LINE 1652/2152 
(77%)CONDITIONAL 1050/1784 (59%)
src.syntax.data
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 51/69 (74%)CONDITIONAL 
73/92 (79%)
src.undo
FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 671/772 (87%)CONDITIONAL 
321/448 (72%)
src.utils
FILES 33/36 (92%)CLASSES 33/36 (92%)LINE 2569/3913 
(66%)CONDITIONAL 1331/2728 (49%)
src.variableeditor
FILES 0/7 (0%)CLASSES 0/7 (0%)LINE 0/668 (0%)CONDITIONAL 0/170 
(0%)
src.view
FILES 15/19 (79%)CLASSES 15/19 (79%)LINE 3320/6291 
(53%)CONDITIONAL 1491/3791 (39%)
src.vimode
FILES 34/34 (100%)CLASSES 34/34 (100%)LINE 1876/2340 
(80%)CONDITIONAL 1028/1751 (59%)
src.vimode.config
FILES 0/1 (0%)CLASSES 0/1 (0%)LINE 0/134 (0%)CONDITIONAL 0/90 
(0%)
src.vimode.emulatedcommandbar
FILES 12/12 (100%)CLASSES 12/12 (100%)LINE 903/915 
(99%)CONDITIONAL 616/682 (90%)
src.vimode.modes
FILES 10/10 (100%)CLASSES 10/10 (100%)LINE 3253/3740 
(87%)CONDITIONAL 1860/2370 (78%)

Jenkins-kde-ci: knewstuff master stable-kf5-qt5 » Linux,gcc - Build # 295 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/knewstuff%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/295/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 16 Nov 2016 13:09:37 +
Build duration: 6 min 40 sec

CHANGE SET
Revision 29e1276039878c52fa331862deb259c75908ab5c by admin: (Split core from 
KNewStuff, add prelim QML components)
  change: add src/qtquick/qmlplugin.h
  change: edit autotests/knewstuffentrytest.cpp
  change: edit src/downloadwidget.cpp
  change: edit src/core/xmlloader_p.h
  change: add src/core/jobs/downloadjob.cpp
  change: edit src/core/cache_p.h
  change: add src/ui/widgetquestionlistener.h
  change: add src/qtquick/qml/NewStuffList.qml
  change: edit src/core/installation.cpp
  change: delete src/ui/itemsmodel.cpp
  change: add src/core/jobs/httpjob.h
  change: add src/core/questionmanager.h
  change: add KF5NewStuffCoreConfig.cmake.in
  change: edit src/core/entryinternal.cpp
  change: edit src/ui/itemsgridviewdelegate.cpp
  change: add src/core/CMakeLists.txt
  change: add src/qtquick/engine.h
  change: edit tests/CMakeLists.txt
  change: edit autotests/CMakeLists.txt
  change: edit src/core/security.cpp
  change: edit src/core/author_p.h
  change: edit src/uploaddialog.cpp
  change: edit src/core/engine.cpp
  change: edit src/staticxml/staticxmlprovider_p.h
  change: delete src/ui/imageloader.cpp
  change: edit src/core/author.cpp
  change: add src/qtquick/downloadlinkinfo.cpp
  change: edit src/downloadmanager.h
  change: edit autotests/knewstuffauthortest.cpp
  change: edit src/attica/atticaprovider_p.h
  change: add src/core/jobs/filecopyjob.cpp
  change: add src/qtquick/qmldir
  change: edit src/ui/itemsviewbasedelegate_p.h
  change: edit src/core/xmlloader.cpp
  change: add src/core/questionlistener.cpp
  change: edit src/downloadwidget.h
  change: edit src/upload/atticahelper_p.h
  change: add src/core/jobs/httpworker.h
  change: edit src/staticxml/staticxmlprovider.cpp
  change: add src/qtquick/engine.cpp
  change: add src/core/jobs/filecopyworker.h
  change: add src/ui/widgetquestionlistener.cpp
  change: edit src/entry_p.h
  change: edit src/ui/entrydetailsdialog.cpp
  change: edit src/ui/itemsviewbasedelegate.cpp
  change: edit src/core/installation_p.h
  change: edit src/core/cache.cpp
  change: edit src/ui/itemsviewdelegate_p.h
  change: edit src/button.cpp
  change: edit src/downloadwidget_p.h
  change: add src/core/imageloader_p.h
  change: add src/core/jobs/filecopyworker.cpp
  change: add src/core/imageloader.cpp
  change: edit CMakeLists.txt
  change: edit src/attica/atticaprovider.cpp
  change: add KF5NewStuffQuickConfig.cmake.in
  change: delete src/ui/imageloader_p.h
  change: add src/core/downloadmanager.h
  change: edit src/core/security_p.h
  change: edit src/core/engine_p.h
  change: edit src/CMakeLists.txt
  change: add src/core/jobs/filecopyjob.h
  change: add src/core/question.cpp
  change: edit src/ui/itemsgridviewdelegate_p.h
  change: delete src/ui/itemsmodel_p.h
  change: add src/core/itemsmodel.cpp
  change: add src/qtquick/qmlplugin.cpp
  change: edit src/downloaddialog.cpp
  change: add src/core/questionmanager.cpp
  change: edit src/core/provider.cpp
  change: edit src/ui/entrydetailsdialog_p.h
  change: add src/core/itemsmodel_p.h
  change: add src/core/jobs/httpworker.cpp
  change: edit src/ui/itemsviewdelegate.cpp
  change: edit src/core/entryinternal_p.h
  change: add src/core/jobs/httpjob.cpp
  change: add src/qtquick/downloadlinkinfo.h
  change: add src/core/jobs/downloadjob.h
  change: add src/qtquick/itemsmodel.h
  change: add src/core/jobs/jobbase.h
  change: edit KF5NewStuffConfig.cmake.in
  change: add src/qtquick/CMakeLists.txt
  change: add src/core/downloadmanager.cpp
  change: edit src/entry.cpp
  change: edit src/downloadmanager.cpp
  change: edit src/core/provider_p.h
  change: add src/core/question.h
  change: edit src/upload/atticahelper.cpp
  change: add src/qtquick/itemsmodel.cpp
  change: edit src/entry.h
  change: add src/core/questionlistener.h
  change: edit src/uploaddialog_p.h
  change: add src/qtquick/qml/NewStuffItem.qml

Jenkins-kde-ci: knewstuff master kf5-qt5 » Linux,gcc - Build # 290 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/knewstuff%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/290/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 16 Nov 2016 13:09:38 +
Build duration: 28 sec

CHANGE SET
Revision 29e1276039878c52fa331862deb259c75908ab5c by admin: (Split core from 
KNewStuff, add prelim QML components)
  change: add src/ui/widgetquestionlistener.h
  change: delete src/ui/itemsmodel.cpp
  change: add src/core/itemsmodel.cpp
  change: add KF5NewStuffCoreConfig.cmake.in
  change: edit src/attica/atticaprovider_p.h
  change: edit src/core/installation_p.h
  change: edit src/ui/itemsviewbasedelegate.cpp
  change: edit src/core/xmlloader.cpp
  change: add src/qtquick/CMakeLists.txt
  change: add src/qtquick/downloadlinkinfo.cpp
  change: edit src/core/engine.cpp
  change: add src/core/questionlistener.cpp
  change: edit src/downloadwidget_p.h
  change: edit src/downloaddialog.cpp
  change: add src/qtquick/itemsmodel.h
  change: edit src/downloadwidget.h
  change: delete src/ui/imageloader_p.h
  change: edit src/uploaddialog_p.h
  change: edit src/staticxml/staticxmlprovider_p.h
  change: add src/core/downloadmanager.cpp
  change: edit src/core/provider.cpp
  change: edit src/ui/itemsviewdelegate.cpp
  change: edit src/core/cache.cpp
  change: add src/core/jobs/filecopyjob.cpp
  change: add src/qtquick/qml/NewStuffItem.qml
  change: edit src/downloadwidget.cpp
  change: edit src/button.cpp
  change: add src/core/jobs/downloadjob.cpp
  change: edit src/entry.h
  change: edit CMakeLists.txt
  change: edit autotests/knewstuffentrytest.cpp
  change: add src/qtquick/downloadlinkinfo.h
  change: add src/core/downloadmanager.h
  change: edit src/ui/entrydetailsdialog.cpp
  change: add src/qtquick/qmldir
  change: edit tests/CMakeLists.txt
  change: edit src/ui/itemsviewdelegate_p.h
  change: add src/core/jobs/filecopyworker.cpp
  change: add src/core/jobs/httpworker.cpp
  change: add src/qtquick/itemsmodel.cpp
  change: add src/qtquick/qmlplugin.cpp
  change: edit KF5NewStuffConfig.cmake.in
  change: delete src/ui/itemsmodel_p.h
  change: edit autotests/CMakeLists.txt
  change: edit src/core/xmlloader_p.h
  change: add src/core/CMakeLists.txt
  change: add src/qtquick/engine.h
  change: edit autotests/knewstuffauthortest.cpp
  change: edit src/core/security.cpp
  change: edit src/core/entryinternal.cpp
  change: add src/core/jobs/httpjob.cpp
  change: add src/core/jobs/httpworker.h
  change: edit src/upload/atticahelper.cpp
  change: edit src/entry_p.h
  change: edit src/core/security_p.h
  change: edit src/ui/itemsgridviewdelegate.cpp
  change: add src/core/jobs/filecopyjob.h
  change: add src/core/jobs/jobbase.h
  change: edit src/ui/itemsgridviewdelegate_p.h
  change: add src/core/questionmanager.cpp
  change: edit src/downloadmanager.h
  change: edit src/core/provider_p.h
  change: edit src/ui/entrydetailsdialog_p.h
  change: add src/core/jobs/httpjob.h
  change: add src/core/question.cpp
  change: edit src/upload/atticahelper_p.h
  change: add src/qtquick/qml/NewStuffList.qml
  change: add src/core/imageloader.cpp
  change: edit src/core/author.cpp
  change: edit src/attica/atticaprovider.cpp
  change: add src/core/imageloader_p.h
  change: edit src/staticxml/staticxmlprovider.cpp
  change: edit src/ui/itemsviewbasedelegate_p.h
  change: add src/core/question.h
  change: edit src/uploaddialog.cpp
  change: add src/core/questionmanager.h
  change: edit src/core/entryinternal_p.h
  change: edit src/core/cache_p.h
  change: edit src/entry.cpp
  change: add src/qtquick/qmlplugin.h
  change: edit src/downloadmanager.cpp
  change: add KF5NewStuffQuickConfig.cmake.in
  change: add src/core/questionlistener.h
  change: add src/core/jobs/downloadjob.h
  change: add src/core/itemsmodel_p.h
  change: edit src/core/engine_p.h
  change: edit src/core/installation.cpp
  change: add src/core/jobs/filecopyworker.h
  change: add src/qtquick/engine.cpp
  change: edit src/core/author_p.h
  change: delete src/ui/imageloader.cpp
  change: edit src/CMakeLists.txt
  change: add src/ui/widgetquestionlistener.cpp

Re: Review Request 129414: KMessageWidget: fix layout when word-wrap is enabled without actions

[Christoph Feck]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129414/#review100879
---



Could you add a screen shot that shows actually wrapped text?

- Christoph Feck


On Nov. 16, 2016, 12:48 p.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129414/
> ---
> 
> (Updated Nov. 16, 2016, 12:48 p.m.)
> 
> 
> Review request for KDE Frameworks, KDE Usability and Christoph Feck.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> If we enable word-wrap on a vanilla KMessageWidget (with no additional tool 
> buttons added), the close button is placed on row number 1 (in the grid 
> layout), resulting in wasted space (see first messagewidget in the 
> screenshots).
> 
> This patch places the close button on row number 1 only when we actually have 
> other buttons in the messagewidget. This way we save space in the normal case.
> 
> 
> Diffs
> -
> 
>   src/kmessagewidget.cpp e8b25f6427534a4991bb1dfe9f820cb651238e18 
>   tests/kmessagewidgettest.cpp 441e961ac9b851ccc713ab1713e797bd20389efd 
> 
> Diff: https://git.reviewboard.kde.org/r/129414/diff/
> 
> 
> Testing
> ---
> 
> Manual testing in the (expanded) kmessagewidgettest.
> 
> 
> File Attachments
> 
> 
> Before: wasted space in the first messagewidget
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/11/16/e2fb5bce-e249-44fc-9ece-d49c0cf656e1__Spectacle.E12435.png
> After: no wasted space in the first messagewidget
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/11/16/09986a2d-f1be-48ad-92f0-87d264873ad9__Spectacle.J13060.png
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

Re: Review Request 129389: KRecentFilesAction: improve addUrl() apidox

[Elvis Angelaccio]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129389/
---

(Updated Nov. 16, 2016, 12:50 p.m.)


Review request for KDE Frameworks.


Changes
---

Follow Aleix's suggestion


Repository: kconfigwidgets


Description
---

If we add an url to the recent files list, the recentFilesAction will be 
enabled. This makes sense but can be unexpected (e.g. if one manually disabled 
the action), so add it to the apidox of the method.


Diffs (updated)
-

  src/krecentfilesaction.h c13c81f8e3c334e3efe229c8befcc50be37a75a0 

Diff: https://git.reviewboard.kde.org/r/129389/diff/


Testing
---


Thanks,

Elvis Angelaccio

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 273 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/273/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 16 Nov 2016 12:32:33 +
Build duration: 16 min

CHANGE SET
Revision d1c652aa68d0b891f7f9c4fe664e0d3cbdb133af by elvis.angelaccio: (Allow 
uppercase checksums matching in Checksums tab)
  change: edit src/widgets/kpropertiesdialog.cpp
  change: edit src/widgets/kpropertiesdialog_p.h


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 
52 test(s)Failed: TestSuite.kiowidgets-kurifiltertest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 271/340 (80%)CLASSES 271/340 (80%)LINE 29300/51405 
(57%)CONDITIONAL 16031/38159 (42%)

By packages
  
autotests
FILES 66/66 (100%)CLASSES 66/66 (100%)LINE 7820/8142 
(96%)CONDITIONAL 4372/8542 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 96/116 (83%)CLASSES 96/116 (83%)LINE 7813/14144 
(55%)CONDITIONAL 4273/9073 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3406/7559 
(45%)CONDITIONAL 1260/4381 (29%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 443/841 (53%)CONDITIONAL 
329/725 (45%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1755/3778 
(46%)CONDITIONAL 1251/3432 (36%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 714/1138 (63%)CONDITIONAL 
386/757 (51%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 
111/138 (80%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
144/256 (56%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/26 (96%)CONDITIONAL 
17/22 (77%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
333/414 (80%)
src.widgets
FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3606/10968 
(33%)CONDITIONAL 1732/6962 (25%)

Re: Review Request 129415: Allow uppercase checksums matching in Checksums tab

[Elvis Angelaccio]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129415/
---

(Updated Nov. 16, 2016, 12:32 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Changes
---

Submitted with commit d1c652aa68d0b891f7f9c4fe664e0d3cbdb133af by Elvis 
Angelaccio to branch master.


Bugs: 372518
https://bugs.kde.org/show_bug.cgi?id=372518


Repository: kio


Description
---

While the checksum in cache is always guaranteed to be lowercase, the
one from the line edit may be uppercase. If we make it lowercase
*before* processing it, we can also simplify the regexes.

BUG: 372518
FIXED-IN: 5.29


Diffs
-

  src/widgets/kpropertiesdialog.cpp 18c8479bef72390a2a4f44b3a5b0d28197826d25 
  src/widgets/kpropertiesdialog_p.h 8ad19e6974ccdeca2b98d4e4c57f8f8830cc0d31 

Diff: https://git.reviewboard.kde.org/r/129415/diff/


Testing
---

Uppercase characters in the line edit are now matched as expected.


Thanks,

Elvis Angelaccio

Re: Review Request 129415: Allow uppercase checksums matching in Checksums tab

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129415/#review100878
---


Ship it!




Ship It!

- David Faure


On Nov. 16, 2016, noon, Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129415/
> ---
> 
> (Updated Nov. 16, 2016, noon)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Bugs: 372518
> https://bugs.kde.org/show_bug.cgi?id=372518
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> While the checksum in cache is always guaranteed to be lowercase, the
> one from the line edit may be uppercase. If we make it lowercase
> *before* processing it, we can also simplify the regexes.
> 
> BUG: 372518
> FIXED-IN: 5.29
> 
> 
> Diffs
> -
> 
>   src/widgets/kpropertiesdialog.cpp 18c8479bef72390a2a4f44b3a5b0d28197826d25 
>   src/widgets/kpropertiesdialog_p.h 8ad19e6974ccdeca2b98d4e4c57f8f8830cc0d31 
> 
> Diff: https://git.reviewboard.kde.org/r/129415/diff/
> 
> 
> Testing
> ---
> 
> Uppercase characters in the line edit are now matched as expected.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

Re: Review Request 129414: KMessageWidget: fix layout when word-wrap is enabled without actions

[Heiko Tietze]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129414/#review100877
---


Ship it!




Ship It!

- Heiko Tietze


On Nov. 16, 2016, 11:48 vorm., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129414/
> ---
> 
> (Updated Nov. 16, 2016, 11:48 vorm.)
> 
> 
> Review request for KDE Frameworks, KDE Usability and Christoph Feck.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> If we enable word-wrap on a vanilla KMessageWidget (with no additional tool 
> buttons added), the close button is placed on row number 1 (in the grid 
> layout), resulting in wasted space (see first messagewidget in the 
> screenshots).
> 
> This patch places the close button on row number 1 only when we actually have 
> other buttons in the messagewidget. This way we save space in the normal case.
> 
> 
> Diffs
> -
> 
>   src/kmessagewidget.cpp e8b25f6427534a4991bb1dfe9f820cb651238e18 
>   tests/kmessagewidgettest.cpp 441e961ac9b851ccc713ab1713e797bd20389efd 
> 
> Diff: https://git.reviewboard.kde.org/r/129414/diff/
> 
> 
> Testing
> ---
> 
> Manual testing in the (expanded) kmessagewidgettest.
> 
> 
> File Attachments
> 
> 
> Before: wasted space in the first messagewidget
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/11/16/e2fb5bce-e249-44fc-9ece-d49c0cf656e1__Spectacle.E12435.png
> After: no wasted space in the first messagewidget
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/11/16/09986a2d-f1be-48ad-92f0-87d264873ad9__Spectacle.J13060.png
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

Re: python binding's __init__.py

[Harald Sitter]

On Tue, Nov 15, 2016 at 4:04 PM, Stephen Kelly  wrote:
> Harald Sitter wrote:
>
>> Alohas
>>
>> I am currently trying to package kitemmodels' python bindings. The
>> module generator installs
>>
>> -./usr/lib/python2.7/dist-packages/PyKF5/__init__.py
>> -./usr/lib/python2.7/dist-packages/PyKF5/KItemModels.so
>>
>> This will cause a fairly shitty problem on packaging level, when a
>> second framework wants to generate bindings. Both would be installing
>> __init__.py in the same path, thus conflicting with one another, thus
>> making the packages not co-installable.
>>
>> I rather think we need a pykf5 framework which does nothing more than
>> install an empty __init__.py which will need to be installed to use
>> any bindings OR change the installation path to fully isolate the
>> directories PyKF5ItemModels/KItemModels.so.
>> Latter will make for ugly code on the python side, so I think the
>> former approach would be the best solution.
>
> Hi Harald,
>
> Thanks for working on this!
>
> Could you review the discussion in
>
>  http://comments.gmane.org/gmane.comp.kde.distributions/92
>
> ?
>
> My hope was that packagers could choose one of the KF5 packages which
> provides an __init__.py and use the file from that package, and remove it
> from any other py-kf5 packages. Is that workable?

The problem with this is that every distribution needs to do the same
thing in their ever so slightly different packaging systems.
If we apply that same solution on an upstream level we solve it for
all distributions at once. On top of that one couldn't just
arbitrarily pick a framework to install the _init_.py as then all
other python bindings would depend on this framework, even if they
have no actual link dependency, so on a package binary package level
one would probably want to separate the file into a generic pykf5
package which is a dependency of all modules. That said, IMO we should
just do that globally and introduce a pykf5 framework which does
nothing but install the __init__.py.

HS

Re: Review Request 129389: KRecentFilesAction: improve addUrl() apidox

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129389/#review100876
---




src/krecentfilesaction.h (line 147)


How about this:
`Add URL to recent files list. This will enable this action.`


- Aleix Pol Gonzalez


On Nov. 13, 2016, 12:33 p.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129389/
> ---
> 
> (Updated Nov. 13, 2016, 12:33 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> ---
> 
> If we add an url to the recent files list, the recentFilesAction will be 
> enabled. This makes sense but can be unexpected (e.g. if one manually 
> disabled the action), so add it to the apidox of the method.
> 
> 
> Diffs
> -
> 
>   src/krecentfilesaction.h c13c81f8e3c334e3efe229c8befcc50be37a75a0 
> 
> Diff: https://git.reviewboard.kde.org/r/129389/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

Review Request 129415: Allow uppercase checksums matching in Checksums tab

[Elvis Angelaccio]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129415/
---

Review request for KDE Frameworks and David Faure.


Bugs: 372518
https://bugs.kde.org/show_bug.cgi?id=372518


Repository: kio


Description
---

While the checksum in cache is always guaranteed to be lowercase, the
one from the line edit may be uppercase. If we make it lowercase
*before* processing it, we can also simplify the regexes.

BUG: 372518
FIXED-IN: 5.29


Diffs
-

  src/widgets/kpropertiesdialog.cpp 18c8479bef72390a2a4f44b3a5b0d28197826d25 
  src/widgets/kpropertiesdialog_p.h 8ad19e6974ccdeca2b98d4e4c57f8f8830cc0d31 

Diff: https://git.reviewboard.kde.org/r/129415/diff/


Testing
---

Uppercase characters in the line edit are now matched as expected.


Thanks,

Elvis Angelaccio

Re: Review Request 129389: KRecentFilesAction: improve addUrl() apidox

[Elvis Angelaccio]

> On Nov. 14, 2016, 11:22 p.m., Aleix Pol Gonzalez wrote:
> > src/krecentfilesaction.h, line 146
> > 
> >
> > How about this?
> > ```
> > /**
> >  *  Adds a URL to the recent files list.
> >  *
> >  *  @param url The URL of the file
> >  *  @param name The user visible pretty name that appears before 
> > the URL
> >  *  
> >  *  @note this will create a new QAction instance.
> >  */
> > ```

We could do this, but my point is that

recentFiles->setEnabled(false);
recentFiles->addUrl(QUrl(...));

makes `recentFiles` enabled and this could be unexpected. That's why I think we 
should (also) mention this in the apidox.


- Elvis


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129389/#review100846
---


On Nov. 13, 2016, 11:33 a.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129389/
> ---
> 
> (Updated Nov. 13, 2016, 11:33 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kconfigwidgets
> 
> 
> Description
> ---
> 
> If we add an url to the recent files list, the recentFilesAction will be 
> enabled. This makes sense but can be unexpected (e.g. if one manually 
> disabled the action), so add it to the apidox of the method.
> 
> 
> Diffs
> -
> 
>   src/krecentfilesaction.h c13c81f8e3c334e3efe229c8befcc50be37a75a0 
> 
> Diff: https://git.reviewboard.kde.org/r/129389/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

Review Request 129414: KMessageWidget: fix layout when word-wrap is enabled without actions

[Elvis Angelaccio]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129414/
---

Review request for KDE Frameworks, KDE Usability and Christoph Feck.


Repository: kwidgetsaddons


Description
---

If we enable word-wrap on a vanilla KMessageWidget (with no additional tool 
buttons added), the close button is placed on row number 1 (in the grid 
layout), resulting in wasted space (see first messagewidget in the screenshots).

This patch places the close button on row number 1 only when we actually have 
other buttons in the messagewidget. This way we save space in the normal case.


Diffs
-

  src/kmessagewidget.cpp e8b25f6427534a4991bb1dfe9f820cb651238e18 
  tests/kmessagewidgettest.cpp 441e961ac9b851ccc713ab1713e797bd20389efd 

Diff: https://git.reviewboard.kde.org/r/129414/diff/


Testing
---

Manual testing in the (expanded) kmessagewidgettest.


File Attachments


Before: wasted space in the first messagewidget
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/11/16/e2fb5bce-e249-44fc-9ece-d49c0cf656e1__Spectacle.E12435.png
After: no wasted space in the first messagewidget
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/11/16/09986a2d-f1be-48ad-92f0-87d264873ad9__Spectacle.J13060.png


Thanks,

Elvis Angelaccio

KService cmake fails on Windows with BUILD_TESTING enabled

[Cordylus Interneter]

I was able to cmake KService on Windows XP only with -DBUILD_TESTING=0, 
otherwise during cmake I get:


CMake Error at autotests/CMakeLists.txt:37 (file):
  file COPY cannot find
  "D:/KDE/kservice-5.28.0/autotests/fakeplugin.desktop".


CMake Error at autotests/CMakeLists.txt:38 (file):
  file RENAME failed to rename

D:/KDE/kservice-5.28.0/autotests/fakeplugin.desktop

  to

D:/KDE/kservice-5.28.0/autotests/fakeplugin_json_old.desktop

  because: No such file or directory


And so on. The files are there, so I have no idea what's wrong. Other KF5 
packages build normally, tests included.

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 272 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/272/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 16 Nov 2016 08:11:07 +
Build duration: 22 min

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 
52 test(s)Failed: TestSuite.kiowidgets-kdirlistertest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 21/21 (100%)FILES 271/340 (80%)CLASSES 271/340 (80%)LINE 29279/51403 
(57%)CONDITIONAL 16025/38159 (42%)

By packages
  
autotests
FILES 66/66 (100%)CLASSES 66/66 (100%)LINE 7811/8142 
(96%)CONDITIONAL 4366/8542 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 96/116 (83%)CLASSES 96/116 (83%)LINE 7805/14144 
(55%)CONDITIONAL 4274/9073 (47%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3410/7559 
(45%)CONDITIONAL 1261/4381 (29%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 443/841 (53%)CONDITIONAL 
329/725 (45%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1763/3778 
(47%)CONDITIONAL 1259/3432 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 
602/831 (72%)
src.ioslaves.trash
FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 704/1138 (62%)CONDITIONAL 
377/757 (50%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 
445/936 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 
111/138 (80%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 
146/542 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 
14/22 (64%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 
333/414 (80%)
src.widgets
FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3606/10966 
(33%)CONDITIONAL 1732/6962 (25%)

Re: Review Request 129397: Set environment variables from KLaunchRequest when starting new process

[David Faure]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129397/#review100871
---


Ship it!




Ship It!

- David Faure


On Nov. 16, 2016, 7:32 a.m., Jan Grulich wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129397/
> ---
> 
> (Updated Nov. 16, 2016, 7:32 a.m.)
> 
> 
> Review request for KDE Frameworks, David Edmundson and David Faure.
> 
> 
> Repository: kinit
> 
> 
> Description
> ---
> 
> One more patch in the series adding support for launching apps on a discrete 
> gpu. When using KToolInvocation to start an app we call klauncher for which 
> we need to set required env variables which needs to be set to actually run 
> the app on the discrete gpu.
> 
> 
> Diffs
> -
> 
>   src/klauncher/klauncher.cpp 828038b 
> 
> Diff: https://git.reviewboard.kde.org/r/129397/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jan Grulich
> 
>