Jenkins-kde-ci: frameworkintegration master stable-kf5-qt5 » Linux,gcc - Build # 298 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/frameworkintegration%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/298/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 29 Nov 2016 03:33:41 + Build duration: 1 min 10 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 2/2 (100%)FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 72/205 (35%)CONDITIONAL 34/172 (20%) By packages autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 25/27 (93%)CONDITIONAL 5/10 (50%) src.kstyle FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 47/178 (26%)CONDITIONAL 29/162 (18%)
Jenkins-kde-ci: frameworkintegration master stable-kf5-qt5 » Linux,gcc - Build # 298 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/frameworkintegration%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/298/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 29 Nov 2016 03:33:41 + Build duration: 1 min 10 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 2/2 (100%)FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 72/205 (35%)CONDITIONAL 34/172 (20%) By packages autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 25/27 (93%)CONDITIONAL 5/10 (50%) src.kstyle FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 47/178 (26%)CONDITIONAL 29/162 (18%)
Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 281 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/281/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 29 Nov 2016 03:25:01 + Build duration: 18 min CHANGE SET Revision 6bb531da547aa5d9393e7825e13d2864a74c62ac by scripty: (SVN_SILENT made messages (.desktop file) - always resolve ours) change: edit src/urifilters/ikws/searchproviders/archpkg.desktop change: edit src/urifilters/ikws/searchproviders/grec.desktop change: edit src/urifilters/ikws/searchproviders/soundcloud.desktop change: edit src/widgets/kiodndpopupmenuplugin.desktop JUNIT RESULTS Name: (root) Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: TestSuite.kiocore-threadtestFailed: TestSuite.kiofilewidgets-knewfilemenutestFailed: TestSuite.kiowidgets-kurifiltertest COBERTURA RESULTS Cobertura Coverage Report PACKAGES 21/21 (100%)FILES 267/338 (79%)CLASSES 267/338 (79%)LINE 27883/51266 (54%)CONDITIONAL 15429/38003 (41%) By packages autotests FILES 64/64 (100%)CLASSES 64/64 (100%)LINE 7686/8003 (96%)CONDITIONAL 4294/8386 (51%) autotests.http FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 (100%)CONDITIONAL 200/336 (60%) autotests.kcookiejar FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 60/90 (67%) src.core FILES 96/116 (83%)CLASSES 96/116 (83%)LINE 7759/14144 (55%)CONDITIONAL 4244/9073 (47%) src.core.kssl FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 3/6 (50%) src.filewidgets FILES 25/36 (69%)CLASSES 25/36 (69%)LINE 2884/7559 (38%)CONDITIONAL 1044/4381 (24%) src.gui FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 46/72 (64%) src.ioslaves.file FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 443/841 (53%)CONDITIONAL 329/725 (45%) src.ioslaves.http FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1755/3778 (46%)CONDITIONAL 1250/3432 (36%) src.ioslaves.http.kcookiejar FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 602/831 (72%) src.ioslaves.trash FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 714/1138 (63%)CONDITIONAL 386/757 (51%) src.ioslaves.trash.tests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 445/936 (48%) src.kioslave FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 5/10 (50%) src.kntlm FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 111/138 (80%) src.kpasswdserver FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 382/594 (64%)CONDITIONAL 285/580 (49%) src.kpasswdserver.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 146/256 (57%) src.urifilters.fixhost FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 36/54 (67%) src.urifilters.ikws FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 146/542 (27%) src.urifilters.localdomain FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/26 (96%)CONDITIONAL 17/22 (77%) src.urifilters.shorturi FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 333/414 (80%) src.widgets FILES 31/64 (48%)CLASSES 31/64 (48%)LINE 2894/10968 (26%)CONDITIONAL 1447/6962 (21%)
Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 286 - Still Unstable!
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/286/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 29 Nov 2016 03:25:02 + Build duration: 7 min 43 sec CHANGE SET Revision 6bb531da547aa5d9393e7825e13d2864a74c62ac by scripty: (SVN_SILENT made messages (.desktop file) - always resolve ours) change: edit src/urifilters/ikws/searchproviders/soundcloud.desktop change: edit src/urifilters/ikws/searchproviders/archpkg.desktop change: edit src/widgets/kiodndpopupmenuplugin.desktop change: edit src/urifilters/ikws/searchproviders/grec.desktop JUNIT RESULTS Name: (root) Failed: 1 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: TestSuite.kiofilewidgets-knewfilemenutest COBERTURA RESULTS Cobertura Coverage Report PACKAGES 21/21 (100%)FILES 268/339 (79%)CLASSES 268/339 (79%)LINE 27924/51301 (54%)CONDITIONAL 15445/38025 (41%) By packages autotests FILES 65/65 (100%)CLASSES 65/65 (100%)LINE 7719/8038 (96%)CONDITIONAL 4304/8408 (51%) autotests.http FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 (100%)CONDITIONAL 200/336 (60%) autotests.kcookiejar FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 60/90 (67%) src.core FILES 96/116 (83%)CLASSES 96/116 (83%)LINE 7763/14144 (55%)CONDITIONAL 4248/9073 (47%) src.core.kssl FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 3/6 (50%) src.filewidgets FILES 25/36 (69%)CLASSES 25/36 (69%)LINE 2886/7559 (38%)CONDITIONAL 1046/4381 (24%) src.gui FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 46/72 (64%) src.ioslaves.file FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 443/841 (53%)CONDITIONAL 329/725 (45%) src.ioslaves.http FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1770/3778 (47%)CONDITIONAL 1265/3432 (37%) src.ioslaves.http.kcookiejar FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 620/781 (79%)CONDITIONAL 602/831 (72%) src.ioslaves.trash FILES 7/9 (78%)CLASSES 7/9 (78%)LINE 704/1138 (62%)CONDITIONAL 377/757 (50%) src.ioslaves.trash.tests FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 686/764 (90%)CONDITIONAL 445/936 (48%) src.kioslave FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 5/10 (50%) src.kntlm FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 111/138 (80%) src.kpasswdserver FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 280/580 (48%) src.kpasswdserver.autotests FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 146/256 (57%) src.urifilters.fixhost FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 36/54 (67%) src.urifilters.ikws FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 240/725 (33%)CONDITIONAL 146/542 (27%) src.urifilters.localdomain FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 19/26 (73%)CONDITIONAL 14/22 (64%) src.urifilters.shorturi FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 239/268 (89%)CONDITIONAL 333/414 (80%) src.widgets FILES 31/64 (48%)CLASSES 31/64 (48%)LINE 2902/10968 (26%)CONDITIONAL 1449/6962 (21%)
[Differential] [Updated] D2854: New: ECMAddQCH, for generating qch & doxygen tag files
kossebau updated the test plan for this revision. REVISION DETAIL https://phabricator.kde.org/D2854 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, staniek, #frameworks Cc: shumski, kfunk, staniek, winterz, ochurlaud, #kdevelop
[Differential] [Updated, 34 lines] D3458: Create a QCH file with the API dox, optionally, using ECMAddQCH
kossebau updated this revision to Diff 8590. kossebau added a comment. update to latest version of proposed ECMAddQCH CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3458?vs=8486=8590 BRANCH addQCHBuild REVISION DETAIL https://phabricator.kde.org/D3458 AFFECTED FILES CMakeLists.txt KF5ArchiveConfig.cmake.in src/CMakeLists.txt EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, #frameworks
[Differential] [Updated, 36 lines] D3439: Create a QCH file with the API dox, optionally, using ECMAddQCH
kossebau updated this revision to Diff 8589. kossebau added a comment. update to latest version of proposed ECMAddQCH CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3439?vs=8488=8589 BRANCH addQCHBuild REVISION DETAIL https://phabricator.kde.org/D3439 AFFECTED FILES CMakeLists.txt KF5JobWidgetsConfig.cmake.in src/CMakeLists.txt EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, #frameworks, ochurlaud Cc: shumski
[Differential] [Updated, 33 lines] D3438: Create a QCH file with the API dox, optionally, using ECMAddQCH
kossebau updated this revision to Diff 8588. kossebau added a comment. update to latest version of proposed ECMAddQCH CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3438?vs=8487=8588 BRANCH addQCHBuild REVISION DETAIL https://phabricator.kde.org/D3438 AFFECTED FILES CMakeLists.txt KF5CoreAddonsConfig.cmake.in src/lib/CMakeLists.txt EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, #frameworks, ochurlaud
[Differential] [Updated, 1,080 lines] D2854: New: ECMAddQCH, for generating qch & doxygen tag files
kossebau updated this revision to Diff 8586. kossebau added a comment. integrate feedback from review with use for kdb, kproperty & kreport CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2854?vs=8485=8586 BRANCH addApiDox REVISION DETAIL https://phabricator.kde.org/D2854 AFFECTED FILES kde-modules/KDEInstallDirs.cmake modules/ECMAddQCH.cmake modules/ECMDoxygenQCH.config.in modules/ECMDoxygenQCHLayout.xml EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, staniek, #frameworks Cc: shumski, kfunk, staniek, winterz, ochurlaud, #kdevelop
[Differential] [Commented On] D3530: Import plasma-workspace kioslaves
aacid added a comment. In https://phabricator.kde.org/D3530#65733, @davidedmundson wrote: > > These don't seem very "core" to me, maybe material for kio-extras ? > > Summarising the mailing list thread/bug report where this happened: > > The reason this came up is because Dolphin effectively hard depends on them. Particularly remote:/ > Dolphin in other environments currently gives a big error until you install plasma-workspace, which defeats the point of the split. Maybe Dolphin needs to be patched not to assume remote:/ will always be available? REVISION DETAIL https://phabricator.kde.org/D3530 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: elvisangelaccio, dfaure, #frameworks, #plasma Cc: aacid, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D3530: Import plasma-workspace kioslaves
davidedmundson added a comment. > These don't seem very "core" to me, maybe material for kio-extras ? Summarising the mailing list thread/bug report where this happened: The reason this came up is because Dolphin effectively hard depends on them. Particularly remote:/ Dolphin in other environments currently gives a big error until you install plasma-workspace, which defeats the point of the split. Being in kio-extras would sort of work for Dolphin, but it's a bit misleading as they're supposedly "extra". Extra implies it's an optional add on; whereas Dolphin apparently needs this. Plasma-integration/plasma-workspace rely on them too, so we can't have them in kio-extras, as that puts an applications dependency on Plasma, which we also can't really have. REVISION DETAIL https://phabricator.kde.org/D3530 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: elvisangelaccio, dfaure, #frameworks, #plasma Cc: aacid, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
Re: Review Request 129389: KRecentFilesAction: improve addUrl() apidox
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129389/#review101165 --- Ship it! Ship It! - Albert Astals Cid On Nov. 16, 2016, 12:50 p.m., Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129389/ > --- > > (Updated Nov. 16, 2016, 12:50 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kconfigwidgets > > > Description > --- > > If we add an url to the recent files list, the recentFilesAction will be > enabled. This makes sense but can be unexpected (e.g. if one manually > disabled the action), so add it to the apidox of the method. > > > Diffs > - > > src/krecentfilesaction.h c13c81f8e3c334e3efe229c8befcc50be37a75a0 > > Diff: https://git.reviewboard.kde.org/r/129389/diff/ > > > Testing > --- > > > Thanks, > > Elvis Angelaccio > >
[Differential] [Commented On] D3530: Import plasma-workspace kioslaves
aacid added a comment. These don't seem very "core" to me, maybe material for kio-extras ? I'll let dfaure decide though :D REVISION DETAIL https://phabricator.kde.org/D3530 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: elvisangelaccio, dfaure, #frameworks, #plasma Cc: aacid, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D3530: Import plasma-workspace kioslaves
elvisangelaccio added a comment. In https://phabricator.kde.org/D3530#65685, @davidedmundson wrote: > Would it be possible to make the version in frameworks co-installable with plasma? > > As long as the .protocol file still says protocol=desktop, dolphin and Plasma won't care what the .protocol filename is; the protocol file says which library to load, and KIO will just pick the first one that matches. At which point we can rename the .protocol and .so file to desktop5/remote5, without any issue. > > People without Plasma load the version from frameworks, people with Plasma use the Plasma one until 5.9, when we just stop installing ours having already raised the frameworks dependency. It works in theory.. > > The only thing I'm not sure of is the kded modules and the other sort of unrelated .desktop files installed by the desktop kioslave. Probably also the kde modules need renaming? Both p-w and kio installs them in `/qt/plugins/kf5/kded/` REVISION DETAIL https://phabricator.kde.org/D3530 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: elvisangelaccio, dfaure, #frameworks, #plasma Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Commented On] D3530: Import plasma-workspace kioslaves
davidedmundson added a comment. Would it be possible to make the version in frameworks co-installable with plasma? As long as the .protocol file still says protocol=desktop, dolphin and Plasma won't care what the .protocol filename is; the protocol file says which library to load, and KIO will just pick the first one that matches. At which point we can rename the .protocol and .so file to desktop5/remote5, without any issue. People without Plasma load the version from frameworks, people with Plasma use the Plasma one until 5.9, when we just stop installing ours having already raised the frameworks dependency. It works in theory.. The only thing I'm not sure of is the kded modules and the other sort of unrelated .desktop files installed by the desktop kioslave. REVISION DETAIL https://phabricator.kde.org/D3530 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: elvisangelaccio, dfaure, #frameworks, #plasma Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Updated] D3530: Import plasma-workspace kioslaves
elvisangelaccio added a dependent revision: D3531: Drop kioslave folder, will be in KIO 5.29. REVISION DETAIL https://phabricator.kde.org/D3530 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: elvisangelaccio, dfaure, #frameworks, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
[Differential] [Request, 2,130 lines] D3530: Import plasma-workspace kioslaves
elvisangelaccio created this revision. elvisangelaccio added reviewers: dfaure, Frameworks, Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY As discussed on plasma-devel, this patch imports the kioslaves from plasma-workspace (`remote://`, `application://` and `desktop://`) in kio. At least `remote://` is used also by Dolphin, so the idea is that this move will make possible to remove plasma-workspace as runtime dependency for whoever is using those slaves. This patch just imports the `kioslave` folder (+ history [1]) from the root of plasma-wrokspace to the root of kio, but doesn't build it yet. I will do that in another commit (I'll also need to move the 3 slaves to `src/ioslaves/`). [1] I used this script: https://gist.github.com/tsayen/f1c1c4d62d4fda77abf1586bd39f9b74 REVISION DETAIL https://phabricator.kde.org/D3530 AFFECTED FILES kioslave/CMakeLists.txt kioslave/applications/CMakeLists.txt kioslave/applications/Messages.sh kioslave/applications/applications.protocol kioslave/applications/kio_applications.cpp kioslave/applications/programs.protocol kioslave/desktop/CMakeLists.txt kioslave/desktop/ExtraDesktop.sh kioslave/desktop/Home.desktop kioslave/desktop/desktop.protocol kioslave/desktop/desktopnotifier.cpp kioslave/desktop/desktopnotifier.desktop kioslave/desktop/desktopnotifier.h kioslave/desktop/directory.desktop kioslave/desktop/directory.trash kioslave/desktop/kio_desktop.cpp kioslave/desktop/kio_desktop.h kioslave/desktop/tests/CMakeLists.txt kioslave/desktop/tests/kio_desktop_test.cpp kioslave/remote/CMakeLists.txt kioslave/remote/Messages.sh kioslave/remote/kdedmodule/CMakeLists.txt kioslave/remote/kdedmodule/remotedirnotify.cpp kioslave/remote/kdedmodule/remotedirnotify.desktop kioslave/remote/kdedmodule/remotedirnotify.h kioslave/remote/kdedmodule/remotedirnotifymodule.cpp kioslave/remote/kdedmodule/remotedirnotifymodule.h kioslave/remote/kio_remote.cpp kioslave/remote/kio_remote.h kioslave/remote/remote.protocol kioslave/remote/remoteimpl.cpp kioslave/remote/remoteimpl.h EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: elvisangelaccio, dfaure, #frameworks, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
Re: Review Request 129560: More utempter path searching
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129560/ --- (Updated Nov. 28, 2016, 9:50 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Rohan Garg. Changes --- Submitted with commit 053ee8add12db44e6eaa68fd02e34ef1b97ba528 by Jonathan Riddell to branch master. Repository: kpty Description --- Debian stable still has it in /usr/lib/utempter/ so search there Also I don't think it wants to use CMAKE_PREFIX_PATH which is empty by default, I think this was intended to be CMAKE_INSTALL_PREFIX old review: https://git.reviewboard.kde.org/r/129090/ Diffs - cmake/FindUTEMPTER.cmake c5a1e41 Diff: https://git.reviewboard.kde.org/r/129560/diff/ Testing --- now it finds utempter in Debian stable (jessie) Thanks, Jonathan Riddell
Re: Review Request 129389: KRecentFilesAction: improve addUrl() apidox
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129389/#review101158 --- Ping? - Elvis Angelaccio On Nov. 16, 2016, 12:50 p.m., Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129389/ > --- > > (Updated Nov. 16, 2016, 12:50 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kconfigwidgets > > > Description > --- > > If we add an url to the recent files list, the recentFilesAction will be > enabled. This makes sense but can be unexpected (e.g. if one manually > disabled the action), so add it to the apidox of the method. > > > Diffs > - > > src/krecentfilesaction.h c13c81f8e3c334e3efe229c8befcc50be37a75a0 > > Diff: https://git.reviewboard.kde.org/r/129389/diff/ > > > Testing > --- > > > Thanks, > > Elvis Angelaccio > >
