Re: Review Request 129666: [KNotificationRestrictions] Let user can specify restriction reason string

2016-12-25 Thread Anthony Fieroni 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129666/
---

(Updated Дек. 26, 2016, 6:54 преди обяд)


Review request for KDE Frameworks and Martin Klapetek.


Repository: knotifications


Description
---

"no_reason_specified" looks annoying reason


Diffs (updated)
-

  src/knotificationrestrictions.h e9179ae 
  src/knotificationrestrictions.cpp 5f5d908 

Diff: https://git.reviewboard.kde.org/r/129666/diff/


Testing
---


Thanks,

Anthony Fieroni

Re: Review Request 129666: [KNotificationRestrictions] Let user can specify restriction reason string

2016-12-25 Thread Martin Klapetek 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129666/#review101576
---




src/knotificationrestrictions.h (line 97)


Remove this



src/knotificationrestrictions.cpp (line 82)


The coding style, as is elsewhere, is newline after comma


- Martin Klapetek


On Dec. 18, 2016, 9:34 a.m., Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129666/
> ---
> 
> (Updated Dec. 18, 2016, 9:34 a.m.)
> 
> 
> Review request for KDE Frameworks and Martin Klapetek.
> 
> 
> Repository: knotifications
> 
> 
> Description
> ---
> 
> "no_reason_specified" looks annoying reason
> 
> 
> Diffs
> -
> 
>   src/knotificationrestrictions.h e9179ae 
>   src/knotificationrestrictions.cpp 5f5d908 
> 
> Diff: https://git.reviewboard.kde.org/r/129666/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

Re: All Frameworks modules are now available as repositories on Phabricator

2016-12-25 Thread Aleix Pol 
On Mon, Dec 26, 2016 at 1:19 AM, Luigi Toscano  wrote:
> ... so that it's easier to use Differential for reviews.
>
> --
> Luigi

Thanks Luigi! :)

Aleix

All Frameworks modules are now available as repositories on Phabricator

2016-12-25 Thread Luigi Toscano 
... so that it's easier to use Differential for reviews.

-- 
Luigi

Review Request 129704: Delegate plasmapkg2 completely into kpackagetool5

2016-12-25 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129704/
---

Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

They're supposed to do the same, completely different codebases. Also some 
things had to be ported.

I'd recommend everything to be ported to use kpackagetool (knsrc files!) but 
still it's better to at least make sure we stick to one set of features.


Diffs
-

  src/plasmapkg/CMakeLists.txt 7d3df5d22 
  src/plasmapkg/main.cpp dfbd2f4c3 
  src/plasmapkg/plasmapkg.h 3383980db 
  src/plasmapkg/plasmapkg.cpp 3724ae85e 

Diff: https://git.reviewboard.kde.org/r/129704/diff/


Testing
---

`plasmapkg2 --help` returns `kpackagetool5`'s.


Thanks,

Aleix Pol Gonzalez

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 389 - Still Unstable!

2016-12-25 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/389/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 25 Dec 2016 23:15:31 +
Build duration: 13 min

CHANGE SET
Revision 2c4f0b8b2c8d28bd125c1a4d2937f2d50929be90 by kainz.a: (add r mimetype 
support BUG: 371811)
  change: add icons-dark/mimetypes/32/application-x-rdata.svg
  change: add icons/mimetypes/64/application-x-rdata.svg
  change: add icons/mimetypes/32/application-x-rdata.svg
  change: add icons/mimetypes/22/application-x-rdata.svg
  change: add icons-dark/mimetypes/64/text-x-r.svg
  change: add icons-dark/mimetypes/16/application-x-rdata.svg
  change: add icons/mimetypes/16/text-x-r.svg
  change: add icons/mimetypes/22/text-x-r.svg
  change: add icons-dark/mimetypes/22/application-x-rdata.svg
  change: add icons/mimetypes/16/application-x-rdata.svg
  change: add icons-dark/mimetypes/22/text-x-r.svg
  change: add icons-dark/mimetypes/64/application-x-rdata.svg
  change: add icons/mimetypes/64/text-x-r.svg
  change: add icons/mimetypes/32/text-x-r.svg
  change: add icons-dark/mimetypes/32/text-x-r.svg
  change: add icons-dark/mimetypes/16/text-x-r.svg


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 
test(s)Failed: TestSuite.dupe

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 105/132 
(80%)CONDITIONAL 46/78 (59%)

By packages
  
default>
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 63/75 (84%)CONDITIONAL 
32/52 (62%)

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 392 - Still Unstable!

2016-12-25 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/392/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 25 Dec 2016 23:15:31 +
Build duration: 2 min 23 sec

CHANGE SET
Revision 2c4f0b8b2c8d28bd125c1a4d2937f2d50929be90 by kainz.a: (add r mimetype 
support BUG: 371811)
  change: add icons/mimetypes/64/text-x-r.svg
  change: add icons/mimetypes/32/application-x-rdata.svg
  change: add icons-dark/mimetypes/16/text-x-r.svg
  change: add icons/mimetypes/32/text-x-r.svg
  change: add icons-dark/mimetypes/22/application-x-rdata.svg
  change: add icons-dark/mimetypes/64/text-x-r.svg
  change: add icons/mimetypes/16/text-x-r.svg
  change: add icons-dark/mimetypes/22/text-x-r.svg
  change: add icons/mimetypes/64/application-x-rdata.svg
  change: add icons-dark/mimetypes/64/application-x-rdata.svg
  change: add icons-dark/mimetypes/16/application-x-rdata.svg
  change: add icons-dark/mimetypes/32/application-x-rdata.svg
  change: add icons/mimetypes/22/text-x-r.svg
  change: add icons/mimetypes/16/application-x-rdata.svg
  change: add icons/mimetypes/22/application-x-rdata.svg
  change: add icons-dark/mimetypes/32/text-x-r.svg


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 
test(s)Failed: TestSuite.dupe

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 105/132 
(80%)CONDITIONAL 46/78 (59%)

By packages
  
default>
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 63/75 (84%)CONDITIONAL 
32/52 (62%)

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 388 - Still Unstable!

2016-12-25 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/388/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 25 Dec 2016 22:48:06 +
Build duration: 17 min

CHANGE SET
Revision 23b488dda70cea8f535ac3e519a0a227e88a75dd by kainz.a: (add calligra 
icons)
  change: add icons/actions/22/select.svg
  change: add icons/actions/32/select.svg
  change: add icons-dark/actions/16/select.svg
  change: add icons/actions/16/select.svg
  change: add icons/actions/24/select.svg
  change: add icons-dark/actions/22/select.svg
  change: add icons/actions/16/borderpainter.svg
  change: add icons-dark/actions/24/select.svg
  change: add icons-dark/actions/16/borderpainter.svg
  change: add icons-dark/actions/32/select.svg


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 
test(s)Failed: TestSuite.dupe

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 105/132 
(80%)CONDITIONAL 46/78 (59%)

By packages
  
default>
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 63/75 (84%)CONDITIONAL 
32/52 (62%)

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 391 - Still Unstable!

2016-12-25 Thread no-reply 

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/391/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Sun, 25 Dec 2016 22:48:06 +
Build duration: 16 min

CHANGE SET
Revision 23b488dda70cea8f535ac3e519a0a227e88a75dd by kainz.a: (add calligra 
icons)
  change: add icons/actions/24/select.svg
  change: add icons-dark/actions/32/select.svg
  change: add icons-dark/actions/22/select.svg
  change: add icons-dark/actions/16/select.svg
  change: add icons/actions/16/select.svg
  change: add icons/actions/16/borderpainter.svg
  change: add icons/actions/32/select.svg
  change: add icons/actions/22/select.svg
  change: add icons-dark/actions/16/borderpainter.svg
  change: add icons-dark/actions/24/select.svg


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 
test(s)Failed: TestSuite.dupe

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 105/132 
(80%)CONDITIONAL 46/78 (59%)

By packages
  
default>
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 63/75 (84%)CONDITIONAL 
32/52 (62%)

[Differential] [Updated] D3689: KGlobalAccel: [runtime] Introduce a KGLOBALACCEL_TEST_MODE env variable

2016-12-25 Thread ltoscano (Luigi Toscano) 
ltoscano set the repository for this revision to R268 KGlobalAccel.

REPOSITORY
  R268 KGlobalAccel

REVISION DETAIL
  https://phabricator.kde.org/D3689

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #frameworks
Cc: aacid