Re: Review Request 129665: [KStatusNotifierItem] Restore mnimized window as normal

[Anthony Fieroni]

> On Ян. 26, 2017, 7:18 преди обяд, Anthony Fieroni wrote:
> > Ping
> 
> Anthony Fieroni wrote:
> KMail do this explicitly, i think it should be expected behavior.

Ping


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129665/#review102245
---


On Ян. 21, 2017, 7:52 преди обяд, Anthony Fieroni wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129665/
> ---
> 
> (Updated Ян. 21, 2017, 7:52 преди обяд)
> 
> 
> Review request for KDE Frameworks and Martin Gräßlin.
> 
> 
> Repository: knotifications
> 
> 
> Description
> ---
> 
> I think, we want minized window to be shown as normal when it's closed in 
> tray. Why we could want a window to be shown as minimized ?
> 
> 
> Diffs
> -
> 
>   src/kstatusnotifieritem.cpp fcbe6a8 
> 
> Diff: https://git.reviewboard.kde.org/r/129665/diff/
> 
> 
> Testing
> ---
> 
> + Remove deprecated warnings
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

Re: Review Request 129245: Add Korean Alphabet(Hangul) and Vietnamese Pronunciation.

[DaeHyun Sung]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129245/
---

(Updated Feb. 2, 2017, 3:45 a.m.)


Status
--

This change has been discarded.


Review request for KDE Frameworks and Christoph Feck.


Repository: kwidgetsaddons


Description
---

Add Korean Alphabet(Hangul) and Vietnamese Pronunciation.
==

Unihan_Readings.txt included in Unihan.zip defines the notation and 
pronunciation of East Asian languages such as Chinese, Japanese, Korean, 
Vietnamese.
Unihan_Readings.txt’ has some properties.
Such as 
kCantonese, kDefinition, kHangul, kHanyuPinlu, kHanyuPinyin, kJapaneseKun, 
kJapaneseOn, kKorean, kMandarin, kTang, kVietnamese, kXHC1983.

I add Unihan_Readings.txt defined kVietnamese property and kHangul property in 
this program.


Unihan_Readings.txt’s property kVietnamese describe Vietnamese character(Qu?c 
ng?) pronunciation. this property defined Unihan version 3.1.1. Now Unihan 
database version is 9.0.0.
Unihan_Readings.txt’s property kHangul describe Korean character(??,Hangul) 
describe Korean pronunciation for this character in hangul.(Hangul is Korean 
Alphabet) this property defined Unihan version 5.0. Now Unihan database version 
is 9.0.0.

1. Why do I add kHangul(Korean Alphabet[Hangul]) property?
Because, Unicode Consortium presented kHangul property on Unihan version 5.
Unicode Unihan database document ( http://www.unicode.org/reports/tr38/  ) 
describe “kKorean” property.
“kKorean property’s description” 
The Korean pronunciation(s) of this character, using the Yale romanization 
system. (See  for a 
discussion of the various Korean romanization systems.)
Use of the kKorean field is not recommended. The kHangul field, which is 
aligned to the KS X 1001 and KS X 1002 standards, is recommended to be used 
instead.

Now, Revised Romanization of Korean (RR, also called South Korean or Ministry 
of Culture (MC) 2000)  is the most commonly used and widely accepted system of 
romanization for Korean instead of "Yale romanization system"[kKorean property] 
in Unihan database.

So,  I add kHangul property and add “Korean Alphabet(Hangul)” notation.

2. Why do i add kVietnamese(Vietnamese pronunciation[Qu?c ng?]) property?
“Unicode Consortium’s version9 guide chapter18. East Asia shows these paragraph.
In Vietnam, a set of native ideographs was created for Vietnamese based on the 
same principles used to create new ideographs for Chinese. These Vietnamese 
ideographs were used through the beginning of the 20th century and are 
occasionally used in more recent signage and other limited contexts.

Although the term “CJK”—Chinese, Japanese, and Korean—is used throughout this 
text to describe the languages that currently use Han ideographic characters, 
it should be noted that earlier Vietnamese writing systems were based on Han 
ideographs. Consequently, the term “CJKV” would be more accurate in a 
historical sense. Han ideographs are still used for historical, religious, and 
pedagogical purposes in Vietnam. “

So I read Unihan documentation specification, then  support Vietnamese language.


Diffs
-

  src/kcharselect.cpp 30ddd34 
  src/kcharselectdata.cpp 92c1c79 

Diff: https://git.reviewboard.kde.org/r/129245/diff/


Testing
---


Thanks,

DaeHyun Sung

[Differential] [Updated, 248 lines] D4329: KMessageWidget: fix behaviour on overlapping calls of animatedShow/animatedHide

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 10838.
kossebau added a comment.


  add a note to the "500" value in code to keep test in sync

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4329?vs=10837&id=10838

BRANCH
  fixKMessageWidgetInstantShowHide

REVISION DETAIL
  https://phabricator.kde.org/D4329

AFFECTED FILES
  autotests/kmessagewidgetautotest.cpp
  autotests/kmessagewidgetautotest.h
  src/kmessagewidget.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kossebau, #frameworks, dhaumann
Cc: cfeck

[Differential] [Updated, 247 lines] D4329: KMessageWidget: fix behaviour on overlapping calls of animatedShow/animatedHide

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 10837.
kossebau marked 5 inline comments as done.
kossebau added a comment.


  updates to code style, avoid unneeded include

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4329?vs=10669&id=10837

BRANCH
  fixKMessageWidgetInstantShowHide

REVISION DETAIL
  https://phabricator.kde.org/D4329

AFFECTED FILES
  autotests/kmessagewidgetautotest.cpp
  autotests/kmessagewidgetautotest.h
  src/kmessagewidget.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kossebau, #frameworks, dhaumann
Cc: cfeck

[Differential] [Updated, 38 lines] D4392: Fix KEditListWidget losing the focus on click of buttons

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 10836.
kossebau marked an inline comment as done.
kossebau added a comment.


  adapt to local syntax style for pointer types

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4392?vs=10818&id=10836

BRANCH
  makeKListEditWidgetNotLoseFocus

REVISION DETAIL
  https://phabricator.kde.org/D4392

AFFECTED FILES
  src/keditlistwidget.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kossebau, #frameworks
Cc: cfeck

[Differential] [Changed Subscribers] D4392: Fix KEditListWidget losing the focus on click of buttons

[Christoph Feck]

cfeck added inline comments.

INLINE COMMENTS

> keditlistwidget.cpp:153
> +// TODO: merge with enableMoveButtons()
> +QPushButton* const buttons[3] = { servUpButton, servDownButton, 
> servRemoveButton };
> +

Please use "Type *ptr" instead of "Type* ptr" throughout.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D4392

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kossebau, #frameworks
Cc: cfeck

[Differential] [Changed Subscribers] D4329: KMessageWidget: fix behaviour on overlapping calls of animatedShow/animatedHide

[Christoph Feck]

cfeck added inline comments.

INLINE COMMENTS

> kmessagewidgetautotest.cpp:24
>  #include 
> +#include 
>  #include 

Isn't QSignalSpy part of QtTest? In other words, isn't it included by above 
#include line?

> kmessagewidgetautotest.cpp:125
> +w.animatedShow();
> +if (delay) QTest::qWait(overlappingWaitingTime);
> +w.animatedHide();

if (delay) {

  QTest::bla;

}

> kmessagewidgetautotest.cpp:158
> +w.animatedHide();
> +if (delay) QTest::qWait(overlappingWaitingTime);
> +w.animatedShow();

s.a.

> kmessagewidgetautotest.cpp:189
> +w.animatedShow();
> +if (delay) QTest::qWait(overlappingWaitingTime);
> +w.animatedShow();

s.a.

> kmessagewidgetautotest.cpp:218
> +w.animatedHide();
> +if (delay) QTest::qWait(overlappingWaitingTime);
> +w.animatedHide();

s.a.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D4329

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kossebau, #frameworks, dhaumann
Cc: cfeck

[Differential] [Accepted] D4355: Add methods to hide the reveal password action

[Christoph Feck]

cfeck accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  disable-visibility-action

REVISION DETAIL
  https://phabricator.kde.org/D4355

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, broulik, cfeck
Cc: #frameworks

Re: Review Request 129849: KToolTipWidget: don't take ownership of the content widget

[Christoph Feck]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129849/#review102346
---


Ship it!




Ship It!

- Christoph Feck


On Jan. 17, 2017, 11:47 p.m., Elvis Angelaccio wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129849/
> ---
> 
> (Updated Jan. 17, 2017, 11:47 p.m.)
> 
> 
> Review request for KDE Frameworks and Christoph Feck.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> ---
> 
> While the layout of the tooltip sets the tooltip as parent of the content 
> widget, we don't really need to take ownership of it. We can just restore the 
> old parent once we are done.
> This prevents a double delete crash if someone (by accident) deletes first 
> the tooltip and then the content.
> 
> 
> Diffs
> -
> 
>   autotests/ktooltipwidgettest.h 556d93edd7792736bb7b41761f2d8934395d2f3c 
>   autotests/ktooltipwidgettest.cpp 89124c6b3f16b76a346a8c9c74ff2f9efe0c9e83 
>   src/ktooltipwidget.h cde7e66af797c9888dec59ef50831a2260a2c238 
>   src/ktooltipwidget.cpp 544eb74d005bb4c963c8cc6cd8b941c018cf463e 
> 
> Diff: https://git.reviewboard.kde.org/r/129849/diff/
> 
> 
> Testing
> ---
> 
> Test case reproduces the crash, which is fixed by the patch.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

breeze-icons and the symlink business

[Harald Sitter]

hola

breeze-icons uses lots of symlinks. Unfortunately, ever so often our
icon designers make a mistake and create a bad symlink. To mitigate
this I added a bunch of tests making sure everything is nice and
dandy.

In the mean parts of the build were changed to not tolerate broken
symlinks. While I don't really have a problem with that in of itself,
the code largely simply ignores the possibility of broken symlinks and
fails with the most shitty error messages you could think of. Given
our artists are not software engineers they are having a hard time
figuring out what is going on. And TBH, I too had to stat files to get
to the bottom of the errors. This is a fairly shit situation as on the
one hand we want lovely icons and on the other hand the people working
on the icons can't understand what needs fixing without having to find
a developer they aren't too afraid of to talk to.

This really needs fixing.

Notably offenders I had a fight with today:


# breeze-validate-svg (introduced by Jos)

This is a bash script running xmllint.

## Problem 1: Sources

The custom target sets `SOURCES ${SVGS}` this has no notable advantage
other than making the svgs show up in an IDE, it does however mean
that cmake will try to inspect them (as a build tool does when they
get told something is a source) and then falls flat on the face when
it encounters a broken symlink as it now can't determine the source
type resulting in this lovely error

```
21:39:07 CMake Error at CMakeLists.txt:70 (add_custom_target):
21:39:07   Cannot find source file:
21:39:07
21:39:07 
/home/jenkins/sources/breeze-icons/kf5-qt5/icons-dark/categories/32/applications-other.svg
```

## Problem 2: The code

The bash code in of itself runs find with -exec on xmllint. Problem
being that if the symlink is broken xmllint will (rightfully) complain

```
warning: failed to load external entity
"./icons-dark/categories/32/applications-other.svg"
```

While that is much better than the earlier problem it's still plenty
unobvious what the underlying cause for this is. Supposedly the script
should skip bogus symlinks.

## Problem 3: Oh but really

This isn't really related to the issue of bad symlink handling:

- apparently this didn't get a review. why ever would this not get a review?
- this should be a test and only run when testing is enabled
- when xmllint is not present it should report this in some form or
fashion during the test run so one knows linting is not done
- it should record its complaints via ctest so jenkins can display them properly
- I fail to appreciate the reason this needs to depend on bash (versus
sh, or well, neither)

## Fix Suggestion

- don't needlesly set SOURCE
- don't pass bad paths to xmllint
- deal with stuff in problem 3


# RCC generation (introduced by Gleb, enabled by Jaroslaw)

This is a bunch of cmake rigging and helper binaries to assemble the
icons into an rcc.

## Problem

`cmake -E copy_directory` is used to copy the src tree of the themes
into the build dir from which the resource file gets assembled. I am
guessing copy_directory does not preserver, but resolve symlinks
because it greets us with the ever so opaque error:

```
Error copying directory from
"/home/me/src/git/breeze-icons/icons-dark" to
"/home/me/src/git/breeze-icons/build/icon
s-dark/res".
```

## Fix Suggestion

This is slightly less trivial since the rcc/qrc helpers seem to depend
on resolved symlinks, so I am guessing a way to deal with this would
be to use cmake's `file(COPY...)` instead of copy_directory and then
have another helper run through the directories to flatten out the
symlinks (dropping broken symlinks).


Kindly fix this to empower the artists to know what's going on again :(
HS

[Differential] [Closed] D4365: Make it possible to adopt resources, mostly for system-wide settings

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R304:15c638307a91: Make it possible to adopt resources, mostly 
for system-wide settings (authored by apol).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4365?vs=10759&id=10832

REVISION DETAIL
  https://phabricator.kde.org/D4365

AFFECTED FILES
  src/core/engine.cpp
  src/core/engine.h
  src/core/installation.cpp
  src/core/installation.h
  src/ui/itemsviewbasedelegate.cpp
  src/ui/itemsviewdelegate.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #frameworks, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

NOW is the time to fill in the Ideas page for GSoC! Application deadline 9 Feb.

[Valorie Zimmerman]

Hello GSoC mentors, and teams supporting mentors,

We've asked for more time to get ramped up for GSoC, and so the
calendar has been moved back to early February. However, that means
that our Ideas page needs to be filled NOW, so that it can be taken
into consideration once the Org Applications are all in. The quality
of our ideas and the guidance they give our students are the most
important part of our application. Please begin filling in your ideas
now, and ensure that it is comprehensive and accurate.

Including screenshots and other images is allowed, if it enriches the
idea for a project. Please ensure complete information about how to
contact the team; this is crucial. Take a look at the landing page
https://community.kde.org/GSoC -- experienced mentors agree that 1.
commits must be made before the student proposal is submitted, and
linked on that proposal, and 2. that regular communication from the
student must be initiated by the student at least weekly, and we
expect daily or nearly daily communication with the team in a more
informal way.

Be sure to point students to that information, as this should thin our
proposals, and raise the quality.

TL;DR: Fill out https://community.kde.org/GSoC/2017/Ideas; read
https://community.kde.org/GSoC. Now.

Valorie

-- 
http://about.me/valoriez

Re: Phabricator: All repositories registered - upcoming workflow changes

[Francis Herne]

On Thu, 2 Feb 2017 07:45:15 +1300
Ben Cooksley  wrote:
[snip]
> 
> I think that we need some cleanup on the old reviews (Albert Astal Cid
> started
> some time ago) and more important strongly tell new users (and old
> users) to use Phabricator. I don't think that anyone wants to lose
> the work, but if a review has not been touched in a few months maybe
> it's time to see it is still
> interesting.
> If we start doing this now (or yesterday), the flow of new patches in
> reviewboard should decrease quickly.
> 
> 
> Getting everyone to shift over was the whole point of this thread. No
> new reviews should be opened on ReviewBoard, and existing ones
> shouldnt take more than a few weeks to clear.
> 
> Anything older than that usually won't apply to the code anymore.
> 
[snip]
> 
> Regards,
> Ben

Not every project is Plasma!

The churn rate in most projects is very low - as an arbitrary
statistic, the mean age of lines in kdevplatform is about 6 years. [1]

Almost every review since the KF5 port at least is semantically
meaningful, even when a few lines have been changed that prevent the
patch from applying.



Completely aside from open reviews, the history of comments and
revisions to committed ones is indispensable.

I don't know if you've seen my IRC comments, but in many cases the
reviewboard comments are the only record of why things are done in a
particular way. There's much more information in them than the commit
history, especially when the commit message or code comment says
 "see ".

As a relative newcomer to the project, reading the reviews has saved me
literally hours compared to reverse-engineering the author's thought
process, and I'm one user out of dozens (hundreds?).


From another of your messages:
> There won't be any auto-forwarding - we'll be removing the subdomains
> completely.

Given the poor quality of KDE's mail indexing, this will make finding
comments for a given review somewhere between painful and impossible.

The logged update emails don't include the actual diffs *at all*, which
will make most comments meaningless in any case.

If you go ahead with this, we will lose years of accumulated knowledge
about the project, and it will cost many (many!) hours of developers'
time. I really did mean it when I wrote 'catastrophic'.

-Francis



[1]
`for file in $(git ls-files); do git blame --line-porcelain "$file"
| grep author-time; done | awk '{ total += ($2 /86400) } END { print
total/NR }'`
* 86400, to readable date, comes out as 22 May 2011.

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 494 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/494/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 01 Feb 2017 22:58:01 +
Build duration: 20 min

CHANGE SET
Revision dda94baa71a4cd407057cfec12118baa7ec5f21d by Harald Sitter: (fix broken 
Directories entries)
  change: edit icons/index.theme
  change: edit icons-dark/index.theme


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 
test(s)Failed: TestSuite.scalable

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 219/268 
(82%)CONDITIONAL 122/206 (59%)

By packages
  

FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 177/211 (84%)CONDITIONAL 
108/180 (60%)

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 494 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/494/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 01 Feb 2017 22:57:43 +
Build duration: 20 min

CHANGE SET
Revision dda94baa71a4cd407057cfec12118baa7ec5f21d by Harald Sitter: (fix broken 
Directories entries)
  change: edit icons/index.theme
  change: edit icons-dark/index.theme


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 
test(s)Failed: TestSuite.scalable

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 219/268 
(82%)CONDITIONAL 122/206 (59%)

By packages
  

FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 177/211 (84%)CONDITIONAL 
108/180 (60%)

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 493 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/493/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 01 Feb 2017 22:53:20 +
Build duration: 3 min 17 sec

CHANGE SET
Revision 33395cc021368931514f7c7a7c8ebba3cb3601dc by Harald Sitter: (assert 
with more variables in scope when context can't be resolved)
  change: edit autotests/scalabletest.cpp
Revision 960d16296d2964067e48598f0cd094a00c272fb3 by Harald Sitter: (handle 
bogus config groups more gracefully and avoid asserting)
  change: edit autotests/scalabletest.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 
test(s)Failed: TestSuite.scalable

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 219/268 
(82%)CONDITIONAL 126/206 (61%)

By packages
  

FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 177/211 (84%)CONDITIONAL 
112/180 (62%)

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 493 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/493/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 01 Feb 2017 22:53:20 +
Build duration: 3 min 15 sec

CHANGE SET
Revision 33395cc021368931514f7c7a7c8ebba3cb3601dc by Harald Sitter: (assert 
with more variables in scope when context can't be resolved)
  change: edit autotests/scalabletest.cpp
Revision 960d16296d2964067e48598f0cd094a00c272fb3 by Harald Sitter: (handle 
bogus config groups more gracefully and avoid asserting)
  change: edit autotests/scalabletest.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 
test(s)Failed: TestSuite.scalable

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 219/268 
(82%)CONDITIONAL 126/206 (61%)

By packages
  

FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 177/211 (84%)CONDITIONAL 
112/180 (62%)

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 492 - Still unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/492/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 01 Feb 2017 22:05:38 +
Build duration: 23 min

CHANGE SET
Revision 94078d17256bdd79c032b6d6b7b2f0ef2d3e1d73 by kainz.a: (update 
categories icon-dark links)
  change: edit icons-dark/categories/32/applications-system.svg
  change: edit icons-dark/categories/32/applications-other.svg


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 
test(s)Failed: TestSuite.scalable

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 98/132 
(74%)CONDITIONAL 40/78 (51%)

By packages
  

FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 56/75 (75%)CONDITIONAL 
26/52 (50%)

Re: Phabricator: All repositories registered - upcoming workflow changes

[René J . V . Bertin]

On Wednesday February 01 2017 23:03:53 Albert Astals Cid wrote:

> You'd be surprised (yes i have a script that actually applies the MRs and 
> lots 
> of them even very old apply).

Old also doesn't mean unmaintained. I have a number of RRs that I keep rebasing 
because I'm still waiting for a green light or more information how to proceed 
on 1 or 2 remaining issues.

On Wednesday February 1 2017 22:16:50 Ben Cooksley wrote:

> Reviewboard would still be running on the server - and all the issues that
> come with that.

So put it on an old or cheap/basic machine that runs no other services, or on a 
ditto virtual machine that runs in low priority?

R.

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 492 - Still unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/492/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 01 Feb 2017 22:05:38 +
Build duration: 4 min 23 sec

CHANGE SET
Revision 94078d17256bdd79c032b6d6b7b2f0ef2d3e1d73 by kainz.a: (update 
categories icon-dark links)
  change: edit icons-dark/categories/32/applications-other.svg
  change: edit icons-dark/categories/32/applications-system.svg


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 
test(s)Failed: TestSuite.scalable

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 98/132 
(74%)CONDITIONAL 40/78 (51%)

By packages
  

FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 56/75 (75%)CONDITIONAL 
26/52 (50%)

Re: Phabricator: All repositories registered - upcoming workflow changes

[Albert Astals Cid]

El dijous, 2 de febrer de 2017, a les 7:45:15 CET, Ben Cooksley va escriure:
> Anything older than that usually won't apply to the code anymore.

You'd be surprised (yes i have a script that actually applies the MRs and lots 
of them even very old apply).

Cheers,
  Albert

Re: Raising the requirement to Qt 5.6 ?

[Albert Astals Cid]

El dimecres, 1 de febrer de 2017, a les 14:16:35 CET, David Faure va escriure:
> On mardi 31 janvier 2017 01:25:58 CET Aleix Pol wrote:
> > On Tue, Jan 31, 2017 at 12:59 AM, Albert Astals Cid  wrote:
> > > Now that Qt 5.8 is out, should we increase requirement to Qt 5.6 as the
> > > rules say?
> > 
> > +1
> > Let's!
> 
> Yes, the good thing about generic rules is that we can apply them without
> having to re-negociate ;-)

So does anyone actually have a script to do this?

Cheers,
  Albert

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 491 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/491/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 01 Feb 2017 21:54:26 +
Build duration: 2 min 37 sec

CHANGE SET
Revision 4fde0df7c68954692a9cabceeedf8774efe775b9 by kainz.a: (add preferences 
folder to cmake)
  change: edit icons/CMakeLists.txt
  change: edit icons-dark/CMakeLists.txt

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 491 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/491/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 01 Feb 2017 21:54:26 +
Build duration: 23 sec

CHANGE SET
Revision 4fde0df7c68954692a9cabceeedf8774efe775b9 by kainz.a: (add preferences 
folder to cmake)
  change: edit icons/CMakeLists.txt
  change: edit icons-dark/CMakeLists.txt

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 490 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/490/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 01 Feb 2017 21:36:11 +
Build duration: 45 sec

CHANGE SET
Revision 9e283f5b05dc6a3ad0a7f5870090251d7719ff0d by kainz.a: (move preferences 
into a single folder and make them scalable)
  change: delete icons/apps/32/preferences-desktop-user-password.svg
  change: delete icons/apps/32/preferences-desktop-default-applications.svg
  change: delete icons-dark/apps/32/preferences-desktop-notification.svg
  change: delete icons/apps/32/preferences-system-network-sharing.svg
  change: delete icons/apps/32/system-users.svg
  change: delete icons/apps/32/preferences-desktop-display-color.svg
  change: add icons-dark/preferences/32/system-lock-screen.svg
  change: edit icons-dark/index.theme
  change: delete icons-dark/apps/32/window-duplicate.svg
  change: add icons-dark/preferences/32/preferences-web-browser-cookies.svg
  change: delete icons-dark/apps/32/preferences-desktop-gaming.svg
  change: delete icons/apps/32/preferences-web-browser-adblock.svg
  change: add icons/preferences/32/preferences-desktop-peripherals.svg
  change: delete icons/apps/32/preferences-desktop-icons.svg
  change: add icons-dark/preferences/32/help-about.svg
  change: add icons/preferences/32/preferences-desktop-cryptography.svg
  change: delete icons-dark/apps/32/plasmashell.svg
  change: delete icons-dark/apps/32/system-users.svg
  change: delete icons/apps/32/window-duplicate.svg
  change: add icons-dark/preferences/32/preferences-desktop-display.svg
  change: delete icons/apps/32/preferences-gtk-config.svg
  change: add icons/preferences/32/plasma-search.svg
  change: add icons/preferences/32/preferences-kde-connect.svg
  change: delete icons-dark/apps/32/kde-gtk-config.svg
  change: add icons/preferences/32/preferences-desktop-theme.svg
  change: add icons/preferences/32/system-run.svg
  change: delete icons-dark/apps/32/baloo.svg
  change: delete icons/apps/32/preferences-desktop-launch-feedback.svg
  change: add icons-dark/preferences/32/preferences-desktop-accessibility.svg
  change: delete icons-dark/apps/32/preferences-desktop-notification-bell.svg
  change: delete icons-dark/apps/32/gtkconfig.svg
  change: delete icons/apps/32/preferences-desktop-display.svg
  change: delete icons/apps/32/preferences-system-network.svg
  change: delete icons-dark/apps/32/preferences-desktop-color.svg
  change: add icons-dark/preferences/32/preferences-desktop-keyboard.svg
  change: add icons/preferences/32/preferences-desktop-baloo.svg
  change: add icons/preferences/32/mediacontrol.svg
  change: add icons/preferences/32/preferences-desktop-emoticons.svg
  change: delete icons/apps/32/view-media-playlist.svg
  change: delete icons-dark/apps/32/preferences-desktop-display-color.svg
  change: delete icons-dark/apps/32/system-lock-screen.svg
  change: add icons-dark/preferences/32/kded5.svg
  change: add icons/preferences/32/preferences-desktop-accessibility.svg
  change: delete icons/apps/32/preferences-system-windows-actions.svg
  change: add icons/preferences/32/preferences-system-windows-move.svg
  change: add icons-dark/preferences/32/preferences-desktop-emoticons.svg
  change: add icons-dark/preferences/32/ksmserver.svg
  change: delete icons-dark/apps/32/preferences-desktop-peripherals.svg
  change: add icons/preferences/32/preferences-desktop-font.svg
  change: add icons/preferences/32/preferences-system-login.svg
  change: delete icons-dark/apps/32/preferences-system-windows.svg
  change: add icons/preferences/32/preferences-desktop-multimedia.svg
  change: delete icons/apps/32/preferences-desktop-color.svg
  change: delete icons-dark/apps/32/preferences-web-browser-identification.svg
  change: delete icons/apps/32/preferences-desktop-wallpaper.svg
  change: add 
icons-dark/preferences/32/preferences-desktop-notification-bell.svg
  change: delete icons/apps/32/preferences-system-login.svg
  change: delete icons/apps/32/krunner.svg
  change: delete icons/apps/32/preferences-desktop-user.svg
  change: add icons-dark/preferences/32/preferences-desktop-user-password.svg
  change: delete icons/apps/32/preferences-system-bluetooth.svg
  change: add icons-dark/preferences/32/preferences-desktop-user.svg
  change: delete icons-dark/apps/32/view-media-playlist.svg
  change: delete icons-dark/apps/32/preferences-web-browser-adblock.svg
  change: add icons-dark/preferences/32/kde-gtk-config.svg
  change: add icons-dark/preferences/32/preferences-web-browser-adblock.svg
  change: delete icons-dark/apps/32/preferences-desktop-baloo.svg
  change: delete icons-dark/apps/32/ksmserver.svg
  change: add icons-dark/preferences/32/preferences-web-browser-stylesheets.svg
  change: delete icons-dark/apps/32/preferences-desktop.svg
  change: add icons-dark/preferences/32/preferences-system-windows-actions.svg
  change: add icons-dark/preferences/32/preferences-desk

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 490 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/490/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 01 Feb 2017 21:36:11 +
Build duration: 2 min 58 sec

CHANGE SET
Revision 9e283f5b05dc6a3ad0a7f5870090251d7719ff0d by kainz.a: (move preferences 
into a single folder and make them scalable)
  change: add icons/preferences/32/face-smile.svg
  change: delete icons/apps/32/window-duplicate.svg
  change: delete icons/apps/32/preferences-web-browser-adblock.svg
  change: add icons/preferences/32/preferences-desktop-default-applications.svg
  change: delete icons-dark/apps/32/preferences-desktop-font.svg
  change: delete icons/apps/32/preferences-system-windows-move.svg
  change: add icons-dark/preferences/32/face-smile.svg
  change: edit icons/categories/32/applications-other.svg
  change: delete icons-dark/apps/32/view-media-playlist.svg
  change: delete icons-dark/apps/32/preferences-web-browser-identification.svg
  change: delete icons/apps/32/face-smile.svg
  change: delete icons/apps/32/system-users.svg
  change: delete icons-dark/apps/32/preferences-desktop-user-password.svg
  change: delete icons-dark/apps/32/preferences-desktop-text-to-speech.svg
  change: add icons/preferences/32/help-about.svg
  change: add icons/preferences/32/preferences-desktop-font.svg
  change: edit icons/categories/32/applications-system.svg
  change: add icons/preferences/32/preferences-desktop-peripherals.svg
  change: delete icons/apps/32/drive-removable-media.svg
  change: delete icons-dark/apps/32/preferences-desktop-display.svg
  change: delete icons-dark/apps/32/preferences-web-browser-shortcuts.svg
  change: add icons-dark/preferences/32/mediacontrol.svg
  change: add icons-dark/preferences/32/podcast-amarok.svg
  change: delete icons-dark/apps/32/nepomuk.svg
  change: delete icons-dark/apps/32/preferences-system-time.svg
  change: add icons/preferences/32/preferences-system-power-management.svg
  change: delete icons/apps/32/preferences-system-power-management.svg
  change: delete icons/apps/32/preferences-desktop-font.svg
  change: add icons/preferences/32/preferences-desktop-launch-feedback.svg
  change: delete icons-dark/apps/32/preferences-other.svg
  change: delete icons-dark/apps/32/preferences-desktop-theme.svg
  change: add icons/preferences/32/nepomuk.svg
  change: add icons/preferences/32/preferences-web-browser-cache.svg
  change: add icons/preferences/32/preferences-system-windows.svg
  change: add icons/preferences/32/kaccess.svg
  change: delete icons-dark/apps/32/mediacontrol.svg
  change: delete icons/apps/32/preferences-desktop-wallpaper.svg
  change: delete icons-dark/apps/32/ksmserver.svg
  change: add icons/preferences/32/preferences-plugin.svg
  change: delete icons/apps/32/preferences-desktop-screensaver.svg
  change: delete icons/apps/32/gtkconfig.svg
  change: delete icons/apps/32/preferences-desktop-display-color.svg
  change: add icons/preferences/32/kded5.svg
  change: add icons-dark/preferences/32/gtkconfig.svg
  change: delete icons/apps/32/amarok_change_language.svg
  change: delete icons/apps/32/preferences-desktop-locale.svg
  change: add icons/preferences/32/preferences-desktop-user-password.svg
  change: add icons/preferences/32/preferences-desktop-cryptography.svg
  change: delete icons-dark/apps/32/preferences-web-browser-cookies.svg
  change: add icons-dark/preferences/32/kde-gtk-config.svg
  change: delete icons/apps/32/preferences-gtk-config.svg
  change: add icons/preferences/32/preferences-desktop-multimedia.svg
  change: add icons/preferences/32/preferences-desktop-baloo.svg
  change: delete icons/apps/32/preferences-web-browser-ssl.svg
  change: add icons-dark/preferences/32/preferences-desktop-screensaver.svg
  change: add icons-dark/preferences/32/preferences-system-session-services.svg
  change: add icons-dark/preferences/32/preferences-system-windows-actions.svg
  change: add icons-dark/preferences/32/preferences-plugin.svg
  change: add icons/preferences/32/preferences-desktop-screensaver.svg
  change: add icons/preferences/32/system-run.svg
  change: add icons-dark/preferences/32/preferences-system-network.svg
  change: delete icons/apps/32/preferences-desktop-user-password.svg
  change: delete icons/apps/32/preferences-desktop-emoticons.svg
  change: delete icons-dark/apps/32/preferences-kde-connect.svg
  change: delete icons/apps/32/preferences-desktop-launch-feedback.svg
  change: add 
icons-dark/preferences/32/preferences-desktop-default-applications.svg
  change: add icons-dark/preferences/32/preferences-web-browser-cache.svg
  change: add icons/preferences/32/preferences-desktop-gaming.svg
  change: add icons-dark/preferences/32/preferences-desktop-display-color.svg
  change: delete icons/apps/32/preferences-system-network.svg
  change: add icons-dark/preferences/32/preferences-system-time.svg
  change: add icons-dark/preferences/32/preferences-system-windows-move.svg
  change

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 489 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/489/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 01 Feb 2017 20:53:21 +
Build duration: 16 min

CHANGE SET
Revision 7ccdffe1ed220b7079a4a39a6568d19a8da6a7d1 by kainz.a: (apps/32 
preferences icons are now scalable icons)
  change: edit icons/index.theme
  change: edit icons-dark/index.theme


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 
test(s)Failed: TestSuite.scalable

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 223/263 
(85%)CONDITIONAL 129/206 (63%)

By packages
  

FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 181/206 (88%)CONDITIONAL 
115/180 (64%)

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 489 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/489/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 01 Feb 2017 20:53:21 +
Build duration: 2 min 36 sec

CHANGE SET
Revision 7ccdffe1ed220b7079a4a39a6568d19a8da6a7d1 by kainz.a: (apps/32 
preferences icons are now scalable icons)
  change: edit icons/index.theme
  change: edit icons-dark/index.theme


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 
test(s)Failed: TestSuite.scalable

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 223/263 
(85%)CONDITIONAL 129/206 (63%)

By packages
  

FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 181/206 (88%)CONDITIONAL 
115/180 (64%)

Re: Phabricator: All repositories registered - upcoming workflow changes

[Martin Gräßlin]

Am 1. Februar 2017 20:34:52 MEZ schrieb Ben Cooksley :
>On Wed, Feb 1, 2017 at 9:48 PM, Milian Wolff  wrote:
>> On Tuesday, January 31, 2017 7:56:52 PM CET Ben Cooksley wrote:
>>> On Tue, Jan 31, 2017 at 11:36 PM, René J.V. Bertin
>
>> wrote:
>>> > On Sunday January 29 2017 08:32:21 Ben Cooksley wrote:
>>> >
>>> > Hi,
>>>
>>> Hi Rene,
>>>
>>> > >From this point forward, communities should be moving away from
>>> >>
>>> >>Reviewboard to Phabricator for conducting code review. Sysadmin
>will
>>> >>be announcing a timeline for the shutdown of Reviewboard in the
>near
>>> >>future.
>>> >>
>>> > I hope that shutdown doesn't mean complete disconnect; it would
>probably
>>> > be a loss of as-yet unknown importance if all code reviews become
>>> > unavailable.
>>> >
>>> > I'll miss ReviewBoard. Phabrithingy may be more powerful and
>versatile,
>>> > but RB had its advantages too which could be why it's still being
>used
>>> > (quite a lot, as far as I can see) and hasn't been integrated with
>KDE's
>>> > own IDE yet.
>>>
>>> It will be a complete shutdown of Reviewboard - we'll be archiving
>it
>>> in the event for some reason it becomes necessary to access the data
>>> it stores.
>>
>> This is a *very* bad idea!
>>
>> - Quite some commits will lose some extended history from the review
>comments
>> - What about the not-yet-merged changes?
>
>There will sufficient time between now and when the shutdown is
>actually actioned during which it's expected any remaining reviews can
>either be finished off, or moved to Phabricator (As said in my
>original mail, we'll be publishing a timeline for this - which will
>have stages where no new reviews can be opened, etc)
>
>>
>> If at all possible, please find a way to keep this site alive in a
>read-only
>> mode.
>>
>>> In most cases mailing lists should have the history of reviews in
>>> their archives, so those will continue to be accessible through list
>>> archives in the long run.
>>
>> And how do you find the corresponding mail archive thread based on a
>> reviewboard URL? Will there be auto-forwarding in-place?
>
>There won't be any auto-forwarding - we'll be removing the subdomains
>completely.

Could you please reconsider? Every fixed KWin bug report has a link to the 
review request where the patch is discussed.

Losing this would be a huge blow to our source code and bug report history.

Please leave the history of review request around.

Thank you
Martin

Re: Phabricator: All repositories registered - upcoming workflow changes

[Ben Cooksley]

On Wed, Feb 1, 2017 at 9:48 PM, Milian Wolff  wrote:
> On Tuesday, January 31, 2017 7:56:52 PM CET Ben Cooksley wrote:
>> On Tue, Jan 31, 2017 at 11:36 PM, René J.V. Bertin 
> wrote:
>> > On Sunday January 29 2017 08:32:21 Ben Cooksley wrote:
>> >
>> > Hi,
>>
>> Hi Rene,
>>
>> > >From this point forward, communities should be moving away from
>> >>
>> >>Reviewboard to Phabricator for conducting code review. Sysadmin will
>> >>be announcing a timeline for the shutdown of Reviewboard in the near
>> >>future.
>> >>
>> > I hope that shutdown doesn't mean complete disconnect; it would probably
>> > be a loss of as-yet unknown importance if all code reviews become
>> > unavailable.
>> >
>> > I'll miss ReviewBoard. Phabrithingy may be more powerful and versatile,
>> > but RB had its advantages too which could be why it's still being used
>> > (quite a lot, as far as I can see) and hasn't been integrated with KDE's
>> > own IDE yet.
>>
>> It will be a complete shutdown of Reviewboard - we'll be archiving it
>> in the event for some reason it becomes necessary to access the data
>> it stores.
>
> This is a *very* bad idea!
>
> - Quite some commits will lose some extended history from the review comments
> - What about the not-yet-merged changes?

There will sufficient time between now and when the shutdown is
actually actioned during which it's expected any remaining reviews can
either be finished off, or moved to Phabricator (As said in my
original mail, we'll be publishing a timeline for this - which will
have stages where no new reviews can be opened, etc)

>
> If at all possible, please find a way to keep this site alive in a read-only
> mode.
>
>> In most cases mailing lists should have the history of reviews in
>> their archives, so those will continue to be accessible through list
>> archives in the long run.
>
> And how do you find the corresponding mail archive thread based on a
> reviewboard URL? Will there be auto-forwarding in-place?

There won't be any auto-forwarding - we'll be removing the subdomains
completely.
>
> Bye
>
> --
> Milian Wolff
> m...@milianw.de
> http://milianw.de

Cheers,
Ben

Re: Phabricator: All repositories registered - upcoming workflow changes

[Ben Cooksley]

On 2/02/2017 12:41 AM, "Luigi Toscano"  wrote:

On Wednesday, 1 February 2017 10:31:44 CET Francis Herne wrote:
> Sorry, forgot to reply-all and only sent to kdevelop-devel...
>
> -
>
> Hi,
>
> First off, there's a lot of postponed, or at least possibly-useful,
> work on ReviewBoard which would be lost. Some of this is from newish
> contributors who might be discouraged - e.g. the author of
> https://git.reviewboard.kde.org/r/129589/ mentioned on IRC the other
> day that he's hoping to complete it at some point.


I think that we need some cleanup on the old reviews (Albert Astal Cid
started
some time ago) and more important strongly tell new users (and old users) to
use Phabricator. I don't think that anyone wants to lose the work, but if a
review has not been touched in a few months maybe it's time to see it is
still
interesting.
If we start doing this now (or yesterday), the flow of new patches in
reviewboard should decrease quickly.


Getting everyone to shift over was the whole point of this thread. No new
reviews should be opened on ReviewBoard, and existing ones shouldnt take
more than a few weeks to clear.

Anything older than that usually won't apply to the code anymore.



> For already-committed work:
>
> Even if the mail-archiving infrastructure was in a useful state, this
> would be inconvenient - there are more than a *thousand* REVIEW: tags in
> kdev* project commits, plus several comments with "see ".
>
> Many mailing lists aren't logged at all, there's no internal
> search with only patchy Google indexing, and 'browsing' the archive
> means clicking through arbitrarily-grouped mails by date with minimal
> threading. That's not merely inconvenient, it's going to cause a
> catastrophic loss of information.

I agree as well that the review information should be kept online.

--
Luigi


Regards,
Ben

Re: Phabricator: All repositories registered - upcoming workflow changes

[Ben Cooksley]

On 1/02/2017 10:38 PM, "René J.V. Bertin"  wrote:

On Wednesday February 1 2017 22:16:50 Ben Cooksley wrote:

>We'd still have to keep the software running, and up to date (to avoid
>it becoming a security risk).

Running yes, but if log-in is disabled at the core and not linked to the
central LDAP service or whatever it is you use, what significant security
risk could it pose?
I don't have the impression the software has been upgraded that frequently
but I haven't been monitoring that either.


It gets upgraded, particularly when there is a security advisory. Most
Reviewboard updates don't make user visible changes though - they're minor
bug fix updates.

Reviewboard would still be running on the server - and all the issues that
come with that.


>I'd prefer to optimise our resources towards keeping what we are
>actively using in the best condition, rather than having to remain
>concerned with keeping legacy systems running for purely archival
>purposes.
>
>We have a significant amount of systems already (and associated
>technical debt in some instances). Let's not make the problem any
>worse please.

I guess it depends on the importance you attach on being able to retrieve
things from revision and review histories. That's not to say it should be
kept around online forever, but I'd say 2 years is a reasonable time to
keep providing read-only access before archiving and taking everything
offline for good.
I'd offer to help during that period but without any experience with the
associated kind of sysadminship I'm not convinced that would be of much
value.

I take it you investigated whether there is any existing way to transfer
existing records from ReviewBoard to Phabricator? That would make the whole
issue moot.


Migrating things, particularly line by line comments, was too difficult
compared to the benefit provided.


R.


Regards,
Ben

[Differential] [Request, 10 lines] D4398: Don't generate appdata if it's marked as NoDisplay

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Plasma, Frameworks, mart.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Only generate appdata information for the packages end-users are supposed to
  know about

TEST PLAN
  org.kde.plasma.private.systemtray doesn't generate an appdata file anymore

REPOSITORY
  R290 KPackage

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4398

AFFECTED FILES
  KF5PackageMacros.cmake
  src/kpackagetool/kpackagetool.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma, #frameworks, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 3 lines] D4396: Specify NoDisplay type

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Plasma, Frameworks, mart, davidedmundson.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Otherwise toBool doesn't work.
  I didn't see it called anywhere as property("NoDisplay") == "true", so it
  shouldn't be a problem like similar cases before

TEST PLAN
  See upcoming patches

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4396

AFFECTED FILES
  src/plasma/data/servicetypes/plasma-applet.desktop

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #plasma, #frameworks, mart, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D4362: RFC: [AppletQuickItem] Cache QQmlComponent used for settings QtQuick Controls 1 style

[Marco Martin]

mart added a comment.


  In https://phabricator.kde.org/D4362#81771, @davidedmundson wrote:
  
  > Personally I would just kill the whole thing.
  >
  > - All Plasma code all uses Plasma Components not QQC so this has zero 
effect. It was for an idea that didn't really materialise
  
  
  actually it did materialise, and has nothing to do with plasmacomponents:
  
  - if you use normal QQC1 in a plasmoid, it will have the plasma theme, so it 
is supported (and you can't be sure it is actually not used, especially in 
stuff from the store)
  - if you use the same component in a config dialog, it will use the QStyle 
theme
  
  then.. this thing cannot work anymore for qqc2 as their theming approach is 
completely different, but is a future problem.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D4362

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: mart, davidedmundson, plasma-devel, #frameworks, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

[Differential] [Accepted] D4365: Make it possible to adopt resources, mostly for system-wide settings

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R304 KNewStuff

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4365

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #frameworks, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Jenkins-kde-ci: kdeclarative master kf5-qt5 » Linux,gcc - Build # 426 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kdeclarative%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/426/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 01 Feb 2017 16:18:31 +
Build duration: 1 min 29 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/5 (100%)FILES 19/25 (76%)CLASSES 19/25 (76%)LINE 740/1269 
(58%)CONDITIONAL 319/864 (37%)

By packages
  
autotests
FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 402/484 (83%)CONDITIONAL 
192/484 (40%)
src.kdeclarative
FILES 3/4 (75%)CLASSES 3/4 (75%)LINE 150/312 (48%)CONDITIONAL 
60/166 (36%)
src.kdeclarative.private
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 24/58 (41%)CONDITIONAL 
6/32 (19%)
src.qmlcontrols.kquickcontrolsaddons
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 79/144 (55%)CONDITIONAL 
36/78 (46%)
src.quickaddons
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 85/271 (31%)CONDITIONAL 
25/104 (24%)

Jenkins-kde-ci: kdeclarative master kf5-qt5 » Linux,gcc - Build # 426 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kdeclarative%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/426/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 01 Feb 2017 16:18:31 +
Build duration: 1 min 29 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 5/5 (100%)FILES 19/25 (76%)CLASSES 19/25 (76%)LINE 740/1269 
(58%)CONDITIONAL 319/864 (37%)

By packages
  
autotests
FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 402/484 (83%)CONDITIONAL 
192/484 (40%)
src.kdeclarative
FILES 3/4 (75%)CLASSES 3/4 (75%)LINE 150/312 (48%)CONDITIONAL 
60/166 (36%)
src.kdeclarative.private
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 24/58 (41%)CONDITIONAL 
6/32 (19%)
src.qmlcontrols.kquickcontrolsaddons
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 79/144 (55%)CONDITIONAL 
36/78 (46%)
src.quickaddons
FILES 2/7 (29%)CLASSES 2/7 (29%)LINE 85/271 (31%)CONDITIONAL 
25/104 (24%)

Jenkins-kde-ci: kxmlrpcclient master kf5-qt5 » Linux,gcc - Build # 386 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kxmlrpcclient%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/386/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 01 Feb 2017 16:18:26 +
Build duration: 1 min 4 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 303/422 
(72%)CONDITIONAL 109/208 (52%)

By packages
  
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 149/149 
(100%)CONDITIONAL 32/62 (52%)
src
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 154/273 (56%)CONDITIONAL 
77/146 (53%)

Jenkins-kde-ci: kxmlrpcclient master kf5-qt5 » Linux,gcc - Build # 386 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kxmlrpcclient%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/386/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 01 Feb 2017 16:18:26 +
Build duration: 1 min 4 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 7/7 (100%)CLASSES 7/7 (100%)LINE 303/422 
(72%)CONDITIONAL 109/208 (52%)

By packages
  
autotests
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 149/149 
(100%)CONDITIONAL 32/62 (52%)
src
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 154/273 (56%)CONDITIONAL 
77/146 (53%)

[Differential] [Accepted] D4357: Re-enable Log-to-File for KNotifications

[Martin Klapetek]

mck182 accepted this revision.
mck182 added a comment.
This revision is now accepted and ready to land.


  Looks good, should be fine.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D4357

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: cfeck, mck182
Cc: #frameworks

Jenkins-kde-ci: kross master kf5-qt5 » Linux,gcc - Build # 393 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kross%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/393/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 01 Feb 2017 15:22:36 +
Build duration: 2 min 8 sec

CHANGE SET
No changes

Jenkins-kde-ci: kdeclarative master kf5-qt5 » Linux,gcc - Build # 425 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kdeclarative%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/425/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 01 Feb 2017 15:22:36 +
Build duration: 2 min 8 sec

CHANGE SET
No changes

Jenkins-kde-ci: kxmlrpcclient master kf5-qt5 » Linux,gcc - Build # 385 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/kxmlrpcclient%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/385/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 01 Feb 2017 15:22:36 +
Build duration: 2 min 8 sec

CHANGE SET
No changes

Jenkins-kde-ci: kservice master stable-kf5-qt5 » Linux,gcc - Build # 225 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/kservice%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/225/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 01 Feb 2017 14:22:20 +
Build duration: 5 min 47 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 
11 test(s)Failed: TestSuite.kservicetest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 6/7 (86%)FILES 75/84 (89%)CLASSES 75/84 (89%)LINE 5490/8009 
(69%)CONDITIONAL 2985/6178 (48%)

By packages
  
autotests
FILES 14/14 (100%)CLASSES 14/14 (100%)LINE 1466/1554 
(94%)CONDITIONAL 903/1792 (50%)
src.kbuildsycoca
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 61/67 (91%)CONDITIONAL 
15/20 (75%)
src.kdeinit
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/326 (0%)CONDITIONAL 0/262 
(0%)
src.plugin
FILES 2/3 (67%)CLASSES 2/3 (67%)LINE 47/100 (47%)CONDITIONAL 
36/96 (38%)
src.services
FILES 29/30 (97%)CLASSES 29/30 (97%)LINE 1765/3045 
(58%)CONDITIONAL 762/1892 (40%)
src.sycoca
FILES 26/31 (84%)CLASSES 26/31 (84%)LINE 2043/2797 
(73%)CONDITIONAL 1235/2066 (60%)
tests.pluginlocator
FILES 3/3 (100%)CLASSES 3/3 (100%)LINE 108/120 (90%)CONDITIONAL 
34/50 (68%)

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 488 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/488/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 01 Feb 2017 13:47:19 +
Build duration: 16 min

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 
test(s)Failed: TestSuite.scalable

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 214/263 
(81%)CONDITIONAL 124/206 (60%)

By packages
  

FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 172/206 (83%)CONDITIONAL 
110/180 (61%)

Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 144 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/144/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Wed, 01 Feb 2017 13:47:19 +
Build duration: 1 min 11 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 3/4 (75%)FILES 4/20 (20%)CLASSES 4/20 (20%)LINE 48/1439 
(3%)CONDITIONAL 21/624 (3%)

By packages
  
autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 30/39 (77%)CONDITIONAL 
14/40 (35%)
autotests.helper
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 7/10 (70%)CONDITIONAL 
3/6 (50%)
src
FILES 2/16 (13%)CLASSES 2/16 (13%)LINE 11/1301 (1%)CONDITIONAL 
4/576 (1%)
src.platforms.wayland
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/89 (0%)CONDITIONAL 0/2 (0%)

Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 144 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/144/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Wed, 01 Feb 2017 13:47:19 +
Build duration: 1 min 11 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 3/4 (75%)FILES 4/20 (20%)CLASSES 4/20 (20%)LINE 48/1439 
(3%)CONDITIONAL 21/624 (3%)

By packages
  
autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 30/39 (77%)CONDITIONAL 
14/40 (35%)
autotests.helper
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 7/10 (70%)CONDITIONAL 
3/6 (50%)
src
FILES 2/16 (13%)CLASSES 2/16 (13%)LINE 11/1301 (1%)CONDITIONAL 
4/576 (1%)
src.platforms.wayland
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/89 (0%)CONDITIONAL 0/2 (0%)

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 488 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/488/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 01 Feb 2017 13:39:38 +
Build duration: 2 min 54 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 
test(s)Failed: TestSuite.scalable

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 214/263 
(81%)CONDITIONAL 124/206 (60%)

By packages
  

FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 172/206 (83%)CONDITIONAL 
110/180 (61%)

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,NoX11,gcc - Build # 146 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/146/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Wed, 01 Feb 2017 13:39:38 +
Build duration: 4 min 2 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 3/4 (75%)FILES 4/20 (20%)CLASSES 4/20 (20%)LINE 54/1439 
(4%)CONDITIONAL 30/624 (5%)

By packages
  
autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 36/39 (92%)CONDITIONAL 
23/40 (58%)
autotests.helper
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 7/10 (70%)CONDITIONAL 
3/6 (50%)
src
FILES 2/16 (13%)CLASSES 2/16 (13%)LINE 11/1301 (1%)CONDITIONAL 
4/576 (1%)
src.platforms.wayland
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/89 (0%)CONDITIONAL 0/2 (0%)

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,NoX11,gcc - Build # 146 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/146/
Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc
Date of build: Wed, 01 Feb 2017 13:39:38 +
Build duration: 4 min 2 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 3/4 (75%)FILES 4/20 (20%)CLASSES 4/20 (20%)LINE 54/1439 
(4%)CONDITIONAL 30/624 (5%)

By packages
  
autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 36/39 (92%)CONDITIONAL 
23/40 (58%)
autotests.helper
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 7/10 (70%)CONDITIONAL 
3/6 (50%)
src
FILES 2/16 (13%)CLASSES 2/16 (13%)LINE 11/1301 (1%)CONDITIONAL 
4/576 (1%)
src.platforms.wayland
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/89 (0%)CONDITIONAL 0/2 (0%)

Re: Review Request 129839: KFileMetaData: add a new property DiscNumber for audio files from multi-disc albums

[Matthieu Gallien]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129839/#review102339
---



Should I move the review request to phabricator ?

- Matthieu Gallien


On Jan. 15, 2017, 4:01 p.m., Matthieu Gallien wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129839/
> ---
> 
> (Updated Jan. 15, 2017, 4:01 p.m.)
> 
> 
> Review request for Baloo and KDE Frameworks.
> 
> 
> Repository: kfilemetadata
> 
> 
> Description
> ---
> 
> the new property is appended at the end of the existing enums such that
> binary compatibility is kept. The special values at the end of the enums
> are currently only used by automatic tests of KFileMetaData. There
> should be no harm by this commit.
> 
> At time of this commit, lxr.kde.org shows no user of the special values
> at the end of the enum. My patch should not cause any problems.
> 
> One interesting question is how to manage caching of new properties in
> Baloo when one modify KFileMetaData. I currently have no idea.
> 
> There should be more patches to add new properties after this review if 
> needed (some music related properties are still missing).
> 
> 
> Diffs
> -
> 
>   autotests/taglibextractortest.cpp d46e49ea6a189d16459799100ec49480bed893c3 
>   src/extractors/taglibextractor.cpp 8fcad93ca4fc6572a412c1f729d1ef361dd7e8cf 
>   src/properties.h 1763b9bfa4a250231932e588edbd6bebc4af3f0a 
>   src/propertyinfo.cpp 97003ae70c683eb73e2ecd84899ae35d29edaefc 
> 
> Diff: https://git.reviewboard.kde.org/r/129839/diff/
> 
> 
> Testing
> ---
> 
> Automatic tests are still all OK on my setup.
> 
> I have modified my music player to makes use of it and it works.
> 
> I have not yet any clear idea how to makes Baloo reindex the files to cache 
> new properties.
> 
> 
> Thanks,
> 
> Matthieu Gallien
> 
>

Re: Review Request 129798: add more audio formats to automatic test and fix one problem with Musepack

[Matthieu Gallien]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129798/#review102338
---



Should I move the review request to phabricator ?

- Matthieu Gallien


On Jan. 15, 2017, 4:03 p.m., Matthieu Gallien wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129798/
> ---
> 
> (Updated Jan. 15, 2017, 4:03 p.m.)
> 
> 
> Review request for Baloo and KDE Frameworks.
> 
> 
> Repository: kfilemetadata
> 
> 
> Description
> ---
> 
> Musepack extraction of album artist was using the wrong tag name (tested
> against easytag and picard).
> 
> See also this page (http://taglib.org/api/classTagLib_1_1APE_1_1Tag.html) 
> that seems to indicate that APE is using "ALBUM ARTIST" with a space between 
> both words.
> 
> 
> Diffs
> -
> 
>   autotests/samplefiles/test.flac PRE-CREATION 
>   autotests/samplefiles/test.m4a PRE-CREATION 
>   autotests/samplefiles/test.mp3 PRE-CREATION 
>   autotests/samplefiles/test.mpc PRE-CREATION 
>   autotests/samplefiles/test.ogg PRE-CREATION 
>   autotests/taglibextractortest.cpp d46e49e 
>   src/extractors/taglibextractor.cpp 8fcad93 
> 
> Diff: https://git.reviewboard.kde.org/r/129798/diff/
> 
> 
> Testing
> ---
> 
> I have tested with automatic tests of KFileMetaData and also the encoding 
> problem in Musepack format against Easytag and Picard applications.
> 
> 
> Thanks,
> 
> Matthieu Gallien
> 
>

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,All,gcc - Build # 146 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/146/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Wed, 01 Feb 2017 13:39:38 +
Build duration: 1 min 53 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 
13 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 4/5 (80%)FILES 44/50 (88%)CLASSES 44/50 (88%)LINE 6811/9081 
(75%)CONDITIONAL 3804/7069 (54%)

By packages
  
autotests
FILES 15/15 (100%)CLASSES 15/15 (100%)LINE 2940/3011 
(98%)CONDITIONAL 1616/3115 (52%)
autotests.helper
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 7/10 (70%)CONDITIONAL 
3/6 (50%)
src
FILES 14/16 (88%)CLASSES 14/16 (88%)LINE 778/1434 
(54%)CONDITIONAL 317/710 (45%)
src.platforms.wayland
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/89 (0%)CONDITIONAL 0/2 (0%)
src.platforms.xcb
FILES 14/16 (88%)CLASSES 14/16 (88%)LINE 3086/4537 
(68%)CONDITIONAL 1868/3236 (58%)

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,All,gcc - Build # 146 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/146/
Project: PLATFORM=Linux,Variation=All,compiler=gcc
Date of build: Wed, 01 Feb 2017 13:39:38 +
Build duration: 1 min 53 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 
13 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 4/5 (80%)FILES 44/50 (88%)CLASSES 44/50 (88%)LINE 6811/9081 
(75%)CONDITIONAL 3804/7069 (54%)

By packages
  
autotests
FILES 15/15 (100%)CLASSES 15/15 (100%)LINE 2940/3011 
(98%)CONDITIONAL 1616/3115 (52%)
autotests.helper
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 7/10 (70%)CONDITIONAL 
3/6 (50%)
src
FILES 14/16 (88%)CLASSES 14/16 (88%)LINE 778/1434 
(54%)CONDITIONAL 317/710 (45%)
src.platforms.wayland
FILES 0/2 (0%)CLASSES 0/2 (0%)LINE 0/89 (0%)CONDITIONAL 0/2 (0%)
src.platforms.xcb
FILES 14/16 (88%)CLASSES 14/16 (88%)LINE 3086/4537 
(68%)CONDITIONAL 1868/3236 (58%)

[Differential] [Updated, 43 lines] D4363: Don't set gnu style parameter with Clang and MSVC

[Hannah von Reth]

vonreth updated this revision to Diff 10822.
vonreth added a comment.


  Small fix

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4363?vs=10756&id=10822

BRANCH
  arcpatch-D4363

REVISION DETAIL
  https://phabricator.kde.org/D4363

AFFECTED FILES
  kde-modules/KDECompilerSettings.cmake
  kde-modules/KDEFrameworkCompilerSettings.cmake

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: vonreth, #windows, bcooksley, alexmerry, dfaure
Cc: #frameworks, #build_system

[Differential] [Updated] D4392: Fix KEditListWidget losing the focus on click of buttons

[Friedrich W. H. Kossebau]

kossebau retitled this revision from "Fix KEditListWidget losing the focus on 
click of Add button" to "Fix KEditListWidget losing the focus on click of 
buttons".
kossebau updated the summary for this revision.
kossebau updated the test plan for this revision.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D4392

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kossebau, #frameworks

Re: KConfig issues prevent compiling KDE applications under Windows

[David Faure]

On mardi 31 janvier 2017 07:58:15 CET Jasem Mutlaq wrote:
> Hello,
> 
> KConfig used to work perfectly fine under Windows. I recently tried to
> compile KStars under Windows 10 (64bit) with MSVC 2015 and Qt 5.8 using
> Craft, but encountered an issue as explained in this bug report:
> 
> https://bugs.kde.org/show_bug.cgi?id=375654
> 
> I talked with Craft maintainers (Hannah et al) and they told me this was an
> issue from KConfig side, not Craft. Can someone please look into this and
> fix it as it our release is dependent on this.

KF5ConfigCore.lib(KF5ConfigCore.dll) : error LNK2005: "public: class 
QMap::iterator __cdecl KEntryMap::findEntry(class 
QByteArray const &,class QByteArray const &,class QFlags)" (?findEntry@KEntryMap@@QEAA?AVite
rator@?$QMap@UKEntryKey@@UKEntryAEBVQByteArray@@0V?
$QFlags@W4SearchFlag@KEntryMap@Z) 
already defined in kconfigdata.cpp.obj

Thanks MSVC for a very readable error message as always ;)

One note though: this is a failure to link a unittest, your release isn't 
blocked, you can just disable the building of unittests in kconfig.

The double definition can be explained, the unittest links to KF5ConfigCore
and then also compiles in ../src/core/kconfigdata.cpp because that class is not 
exported. This is something we do in quite a number of other places too, 
always for autotests.

kde-windows people, if you confirm there is no way to make this work
(some linker flag maybe?), then I do see one solution: the one used by Qt (and 
konqueror), which is an export macro that only exports the class when 
compilation of autotests is enabled. See konqueror/src/konqprivate_export.h 
for an example.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

[Differential] [Updated, 38 lines] D4392: Fix KEditListWidget losing the focus on click of Add button

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 10818.
kossebau added a comment.


  remove QDebug include again

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4392?vs=10817&id=10818

BRANCH
  makeKListEditWidgetNotLoseFocus

REVISION DETAIL
  https://phabricator.kde.org/D4392

AFFECTED FILES
  src/keditlistwidget.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kossebau, #frameworks

[Differential] [Updated, 39 lines] D4392: Fix KEditListWidget losing the focus on click of Add button

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 10817.
kossebau added a comment.


  Update to catch some more unwanted focus losts

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4392?vs=10811&id=10817

BRANCH
  makeKListEditWidgetNotLoseFocus

REVISION DETAIL
  https://phabricator.kde.org/D4392

AFFECTED FILES
  src/keditlistwidget.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kossebau, #frameworks

[Differential] [Closed] D4389: Don't set gnu style parameter with Clang and MSVC

[Hannah von Reth]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:16a148feda4e: Fix ENABLE_CLAZY on Windows (authored by 
vonreth).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4389?vs=10802&id=10816

REVISION DETAIL
  https://phabricator.kde.org/D4389

AFFECTED FILES
  kde-modules/KDECMakeSettings.cmake

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: vonreth, smartins, alexmerry, apol
Cc: #windows, #build_system, #frameworks

Re: Raising the requirement to Qt 5.6 ?

[David Faure]

On mardi 31 janvier 2017 01:25:58 CET Aleix Pol wrote:
> On Tue, Jan 31, 2017 at 12:59 AM, Albert Astals Cid  wrote:
> > Now that Qt 5.8 is out, should we increase requirement to Qt 5.6 as the
> > rules say?
> 
> +1
> Let's!

Yes, the good thing about generic rules is that we can apply them without 
having to re-negociate ;-)

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

[Differential] [Abandoned] D4084: Add unit test for desktopToJson being called without an explicit serviceType

[David Edmundson]

davidedmundson abandoned this revision.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D4084

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, #frameworks, apol
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 8 lines] D4392: Fix KEditListWidget losing the focus on click of Add button

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  When the user triggers the Add button by keyboard focus or mouse,
  the button has focus when it gets disabled in the addItem() handler.
  Which results in the focus being passed on, to whatever next widget
  in the tab focus order(?) can get focus. Inside KEditListWidget
  these are the other buttons, which are usually disabled when an
  item is added, so the focus is moved out of the KEditListWidget.
  Which usually makes no sense, as the user may want to do more actions
  on the list, until explicitly leaving the scene.

TEST PLAN
  Usages of KListEditWidget in KDevelop's "New from Template..." dialog,
  e.g. in the test cases of class data pages, no longer are frustrating,
  as no longer will the focus move to the "Back" dialog button after
  clicking "Add".

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  makeKListEditWidgetNotLoseFocus

REVISION DETAIL
  https://phabricator.kde.org/D4392

AFFECTED FILES
  src/keditlistwidget.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: kossebau, #frameworks

Re: Phabricator: All repositories registered - upcoming workflow changes

[Luigi Toscano]

On Wednesday, 1 February 2017 10:31:44 CET Francis Herne wrote:
> Sorry, forgot to reply-all and only sent to kdevelop-devel...
> 
> -
> 
> Hi,
> 
> First off, there's a lot of postponed, or at least possibly-useful,
> work on ReviewBoard which would be lost. Some of this is from newish
> contributors who might be discouraged - e.g. the author of
> https://git.reviewboard.kde.org/r/129589/ mentioned on IRC the other
> day that he's hoping to complete it at some point.


I think that we need some cleanup on the old reviews (Albert Astal Cid started 
some time ago) and more important strongly tell new users (and old users) to 
use Phabricator. I don't think that anyone wants to lose the work, but if a 
review has not been touched in a few months maybe it's time to see it is still 
interesting. 
If we start doing this now (or yesterday), the flow of new patches in 
reviewboard should decrease quickly.


> For already-committed work:
> 
> Even if the mail-archiving infrastructure was in a useful state, this
> would be inconvenient - there are more than a *thousand* REVIEW: tags in
> kdev* project commits, plus several comments with "see ".
> 
> Many mailing lists aren't logged at all, there's no internal
> search with only patchy Google indexing, and 'browsing' the archive
> means clicking through arbitrarily-grouped mails by date with minimal
> threading. That's not merely inconvenient, it's going to cause a
> catastrophic loss of information.

I agree as well that the review information should be kept online.

-- 
Luigi

Re: Phabricator: All repositories registered - upcoming workflow changes

[Luigi Toscano]

On Wednesday, 1 February 2017 11:52:01 CET Alexander Zhigalin wrote:
> Completely agreeing with Rene, Luigi and Milian.
> All this sounds very sad to me.
> Phabricator is indeed very powerful and better for management stuff.
> But Differential is not even merely comparable to RB by ease of use, mail
> notifications, review immediateness and usage speed...

If you have concerns and blockers that prevents the usage of Phabricator, 
please add tickets to the "Phabricator" board on our instance:
https://phabricator.kde.org/project/view/68/

There is no discussion around the point that, if reviewboard is kept around, 
it would be in read only mode and phabricator will be the only way to submit 
patches. But we are trying to see if it is possible to keep the content 
online, as it is not rare to go and check the history of a review, and not 
only for 2 years.

-- 
Luigi

[Differential] [Accepted] D4389: Don't set gnu style parameter with Clang and MSVC

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  2

REVISION DETAIL
  https://phabricator.kde.org/D4389

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: vonreth, smartins, alexmerry, apol
Cc: #windows, #build_system, #frameworks

Re:Phabricator: All repositories registered - upcoming workflow changes

[Alexander Zhigalin]

Completely agreeing with Rene, Luigi and Milian.
All this sounds very sad to me.
Phabricator is indeed very powerful and better for management stuff.
But Differential is not even merely comparable to RB by ease of use, mail 
notifications, review immediateness and usage speed...

> On Tuesday, January 31, 2017 7:56:52 PM CET Ben Cooksley wrote:
> 
>> On Tue, Jan 31, 2017 at 11:36 PM, René J.V. Bertin 
> 
> wrote:
> 
>>> On Sunday January 29 2017 08:32:21 Ben Cooksley wrote:
>>>
>>> Hi,
>>
>> Hi Rene,
>>
>>> >From this point forward, communities should be moving away from

Reviewboard to Phabricator for conducting code review. Sysadmin will
be announcing a timeline for the shutdown of Reviewboard in the near
future.

>>> I hope that shutdown doesn't mean complete disconnect; it would probably
>>> be a loss of as-yet unknown importance if all code reviews become
>>> unavailable.
>>>
>>> I'll miss ReviewBoard. Phabrithingy may be more powerful and versatile,
>>> but RB had its advantages too which could be why it's still being used
>>> (quite a lot, as far as I can see) and hasn't been integrated with KDE's
>>> own IDE yet.
>>
>> It will be a complete shutdown of Reviewboard - we'll be archiving it
>> in the event for some reason it becomes necessary to access the data
>> it stores.
> 
> This is a *very* bad idea!
> 
> - Quite some commits will lose some extended history from the review comments
> - What about the not-yet-merged changes?
> 
> If at all possible, please find a way to keep this site alive in a read-only
> mode.
> 
>> In most cases mailing lists should have the history of reviews in
>> their archives, so those will continue to be accessible through list
>> archives in the long run.
> 
> And how do you find the corresponding mail archive thread based on a
> reviewboard URL? Will there be auto-forwarding in-place?
> 
> Bye
> 
> --
> Milian Wolff
> m...@milianw.de
> http://milianw.de

Re: Phabricator: All repositories registered - upcoming workflow changes

[Francis Herne]

Sorry, forgot to reply-all and only sent to kdevelop-devel...

-

Hi,

First off, there's a lot of postponed, or at least possibly-useful,
work on ReviewBoard which would be lost. Some of this is from newish
contributors who might be discouraged - e.g. the author of
https://git.reviewboard.kde.org/r/129589/ mentioned on IRC the other
day that he's hoping to complete it at some point.

For already-committed work:

Even if the mail-archiving infrastructure was in a useful state, this
would be inconvenient - there are more than a *thousand* REVIEW: tags in
kdev* project commits, plus several comments with "see ".

Many mailing lists aren't logged at all, there's no internal
search with only patchy Google indexing, and 'browsing' the archive
means clicking through arbitrarily-grouped mails by date with minimal
threading. That's not merely inconvenient, it's going to cause a
catastrophic loss of information.

Please reconsider.

-Francis

On Wed, 1 Feb 2017 07:56:52 +1300
Ben Cooksley  wrote:

> On Tue, Jan 31, 2017 at 11:36 PM, René J.V. Bertin
>  wrote:  
> > On Sunday January 29 2017 08:32:21 Ben Cooksley wrote:
> >
> > Hi,
> 
> Hi Rene,
>   
> >
> > >From this point forward, communities should be moving away from
> >>Reviewboard to Phabricator for conducting code review. Sysadmin will
> >>be announcing a timeline for the shutdown of Reviewboard in the near
> >>future.
> >
> > I hope that shutdown doesn't mean complete disconnect; it would
> > probably be a loss of as-yet unknown importance if all code reviews
> > become unavailable.
> >
> > I'll miss ReviewBoard. Phabrithingy may be more powerful and
> > versatile, but RB had its advantages too which could be why it's
> > still being used (quite a lot, as far as I can see) and hasn't been
> > integrated with KDE's own IDE yet.
> 
> It will be a complete shutdown of Reviewboard - we'll be archiving it
> in the event for some reason it becomes necessary to access the data
> it stores.
> 
> In most cases mailing lists should have the history of reviews in
> their archives, so those will continue to be accessible through list
> archives in the long run.
> 
>   
> >
> > R.
> 
> Cheers,
> Ben  

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 487 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/487/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 01 Feb 2017 10:38:39 +
Build duration: 16 min

CHANGE SET
Revision b19994a0dad01d37ae8e5bcd1fb5b4cfc8b8b15e by Harald Sitter: (more 
documentation to trigger a build)
  change: edit autotests/scalabletest.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 
test(s)Failed: TestSuite.scalable

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 214/263 
(81%)CONDITIONAL 124/206 (60%)

By packages
  

FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 172/206 (83%)CONDITIONAL 
110/180 (61%)

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 487 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/487/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 01 Feb 2017 10:38:39 +
Build duration: 4 min 36 sec

CHANGE SET
Revision b19994a0dad01d37ae8e5bcd1fb5b4cfc8b8b15e by Harald Sitter: (more 
documentation to trigger a build)
  change: edit autotests/scalabletest.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 
test(s)Failed: TestSuite.scalable

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 214/263 
(81%)CONDITIONAL 124/206 (60%)

By packages
  

FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 172/206 (83%)CONDITIONAL 
110/180 (61%)

Jenkins-kde-ci: breeze-icons master kf5-qt5 » Linux,gcc - Build # 486 - Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/486/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 01 Feb 2017 10:23:19 +
Build duration: 4 min 46 sec

CHANGE SET
Revision 30a693cf033bb2ebba84d1c652b9e18d20d20100 by Harald Sitter: (add docs 
to trigger build)
  change: edit autotests/scalabletest.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 
test(s)Failed: TestSuite.scalable

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 2/2 (100%)FILES 6/6 (100%)CLASSES 6/6 (100%)LINE 214/263 
(81%)CONDITIONAL 124/206 (60%)

By packages
  

FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 42/57 (74%)CONDITIONAL 
14/26 (54%)
autotests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 172/206 (83%)CONDITIONAL 
110/180 (61%)

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 486 - Still Failing!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/486/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 01 Feb 2017 10:23:19 +
Build duration: 4 min 1 sec

CHANGE SET
Revision 30a693cf033bb2ebba84d1c652b9e18d20d20100 by Harald Sitter: (add docs 
to trigger build)
  change: edit autotests/scalabletest.cpp

Re: Phabricator: All repositories registered - upcoming workflow changes

[Milian Wolff]

On Tuesday, January 31, 2017 7:56:52 PM CET Ben Cooksley wrote:
> On Tue, Jan 31, 2017 at 11:36 PM, René J.V. Bertin  
wrote:
> > On Sunday January 29 2017 08:32:21 Ben Cooksley wrote:
> > 
> > Hi,
> 
> Hi Rene,
> 
> > >From this point forward, communities should be moving away from
> >>
> >>Reviewboard to Phabricator for conducting code review. Sysadmin will
> >>be announcing a timeline for the shutdown of Reviewboard in the near
> >>future.
> >>
> > I hope that shutdown doesn't mean complete disconnect; it would probably
> > be a loss of as-yet unknown importance if all code reviews become
> > unavailable.
> > 
> > I'll miss ReviewBoard. Phabrithingy may be more powerful and versatile,
> > but RB had its advantages too which could be why it's still being used
> > (quite a lot, as far as I can see) and hasn't been integrated with KDE's
> > own IDE yet.
>
> It will be a complete shutdown of Reviewboard - we'll be archiving it
> in the event for some reason it becomes necessary to access the data
> it stores.

This is a *very* bad idea!

- Quite some commits will lose some extended history from the review comments
- What about the not-yet-merged changes?

If at all possible, please find a way to keep this site alive in a read-only 
mode.
 
> In most cases mailing lists should have the history of reviews in
> their archives, so those will continue to be accessible through list
> archives in the long run.

And how do you find the corresponding mail archive thread based on a 
reviewboard URL? Will there be auto-forwarding in-place?

Bye

-- 
Milian Wolff
m...@milianw.de
http://milianw.de

Re: Phabricator: All repositories registered - upcoming workflow changes

[René J . V . Bertin]

On Wednesday February 1 2017 22:16:50 Ben Cooksley wrote:

>We'd still have to keep the software running, and up to date (to avoid
>it becoming a security risk).

Running yes, but if log-in is disabled at the core and not linked to the 
central LDAP service or whatever it is you use, what significant security risk 
could it pose?
I don't have the impression the software has been upgraded that frequently but 
I haven't been monitoring that either.

>I'd prefer to optimise our resources towards keeping what we are
>actively using in the best condition, rather than having to remain
>concerned with keeping legacy systems running for purely archival
>purposes.
>
>We have a significant amount of systems already (and associated
>technical debt in some instances). Let's not make the problem any
>worse please.

I guess it depends on the importance you attach on being able to retrieve 
things from revision and review histories. That's not to say it should be kept 
around online forever, but I'd say 2 years is a reasonable time to keep 
providing read-only access before archiving and taking everything offline for 
good.
I'd offer to help during that period but without any experience with the 
associated kind of sysadminship I'm not convinced that would be of much value.

I take it you investigated whether there is any existing way to transfer 
existing records from ReviewBoard to Phabricator? That would make the whole 
issue moot.

R.

Re: Phabricator: All repositories registered - upcoming workflow changes

[Ben Cooksley]

On Wed, Feb 1, 2017 at 9:26 PM, René J.V. Bertin  wrote:
> On Wednesday February 1 2017 20:59:46 Ben Cooksley wrote:
>
> Hi
>
>>
>>While I have yet to test it, Reviewboard does use quite a bit of AJAX
>>and other dynamic resources - so I won't be surprised to find out that
>>the usual mechanisms for creating static copies of sites don't produce
>>a workable result.
>
> Hmmm, I think one doesn't need to be logged in in order to consult and 
> download things, correct? If so, disabling authentication is all that's 
> needed to make the site read-only.

We'd still have to keep the software running, and up to date (to avoid
it becoming a security risk).

I'd prefer to optimise our resources towards keeping what we are
actively using in the best condition, rather than having to remain
concerned with keeping legacy systems running for purely archival
purposes.

We have a significant amount of systems already (and associated
technical debt in some instances). Let's not make the problem any
worse please.

>
> R.

Cheers,
Ben

[Differential] [Updated] D4389: Don't set gnu style parameter with Clang and MSVC

[Hannah von Reth]

vonreth updated the summary for this revision.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D4389

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: vonreth, apol, smartins, alexmerry
Cc: #windows, #build_system, #frameworks

[Differential] [Updated, 2 lines] D4389: Don't set gnu style parameter with Clang and MSVC

[Hannah von Reth]

vonreth updated this revision to Diff 10802.
vonreth added a comment.


  Trying to split the review

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4389?vs=10801&id=10802

BRANCH
  2

REVISION DETAIL
  https://phabricator.kde.org/D4389

AFFECTED FILES
  kde-modules/KDECMakeSettings.cmake

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: vonreth, apol, smartins, alexmerry
Cc: #windows, #build_system, #frameworks

[Differential] [Request, 40 lines] D4389: Don't set gnu style parameter with Clang and MSVC

[Hannah von Reth]

vonreth created this revision.
vonreth added reviewers: apol, smartins, alexmerry.
vonreth added subscribers: Frameworks, Build System, Windows.
vonreth added projects: Frameworks, Build System.

REVISION SUMMARY
  Setting the gnu style compiler flags with clang-cl results in a
  huge bunch of unknown argument warnings.
  
  The patch just tests for Clang AND NOT MSVC, while we might wan't
  a more fine gained test for clang-cl, as in theory it could be
  possible to use a plain clang++ with msvc.
  
  Fix ENABLE_CLAZY on Windows

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4389

AFFECTED FILES
  kde-modules/KDECMakeSettings.cmake
  kde-modules/KDECompilerSettings.cmake
  kde-modules/KDEFrameworkCompilerSettings.cmake

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: vonreth, apol, smartins, alexmerry
Cc: #windows, #build_system, #frameworks

Re: Phabricator: All repositories registered - upcoming workflow changes

[René J . V . Bertin]

On Wednesday February 1 2017 20:59:46 Ben Cooksley wrote:

Hi

>
>While I have yet to test it, Reviewboard does use quite a bit of AJAX
>and other dynamic resources - so I won't be surprised to find out that
>the usual mechanisms for creating static copies of sites don't produce
>a workable result.

Hmmm, I think one doesn't need to be logged in in order to consult and download 
things, correct? If so, disabling authentication is all that's needed to make 
the site read-only.

R.

Re: Phabricator: All repositories registered - upcoming workflow changes

[Ben Cooksley]

On Wed, Feb 1, 2017 at 8:10 AM, Luigi Toscano  wrote:
> Ben Cooksley ha scritto:
>> On Tue, Jan 31, 2017 at 11:36 PM, René J.V. Bertin  
>> wrote:
>>> On Sunday January 29 2017 08:32:21 Ben Cooksley wrote:
>>>
>>> Hi,
>>
>> Hi Rene,
>>
>>>
>>> >From this point forward, communities should be moving away from
 Reviewboard to Phabricator for conducting code review. Sysadmin will
 be announcing a timeline for the shutdown of Reviewboard in the near
 future.
>>>
>>> I hope that shutdown doesn't mean complete disconnect; it would probably be 
>>> a loss of as-yet unknown importance if all code reviews become unavailable.
>>>
>>> I'll miss ReviewBoard. Phabrithingy may be more powerful and versatile, but 
>>> RB had its advantages too which could be why it's still being used (quite a 
>>> lot, as far as I can see) and hasn't been integrated with KDE's own IDE yet.
>>
>> It will be a complete shutdown of Reviewboard - we'll be archiving it
>> in the event for some reason it becomes necessary to access the data
>> it stores.
>
> Isn't it a way to change the site in static website and keep it alive?
> Checking the history of a review can tell a lot. Also for discarded reviews.

While I have yet to test it, Reviewboard does use quite a bit of AJAX
and other dynamic resources - so I won't be surprised to find out that
the usual mechanisms for creating static copies of sites don't produce
a workable result.

>
>>
>> In most cases mailing lists should have the history of reviews in
>> their archives, so those will continue to be accessible through list
>> archives in the long run.
>
> I think we should ensure to have the archives on mail.kde.org if this is the 
> case.

Unfortunately a number of lists have their archiving disabled - so
we'll need archives from a member of the community to re-seed the
server copies (this was a historical decision, taken before KDE 3 even
existed I suspect).

>
>
> --
> Luigi

Regards,
Ben