D5092: [KMessageWidget] Fix wrong size hint when animatedShow() is called with a hidden parentWidget()
cfeck created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY If the parent widget is not visible, then immediately show() the message widget to compute proper size hint. Otherwise, when the widget is later implicitely shown when parent gets visible, we are too late. Fixes https://bugs.kde.org/show_bug.cgi?id=377676 REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D5092 AFFECTED FILES src/kmessagewidget.cpp To: cfeck, kossebau, elvisangelaccio Cc: #frameworks
D5091: Updated user agents (Firefox 52 ESR, Chromium 52)
ltoscano created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY New user agents, as the available ones are a bit old. TEST PLAN Compiles, and the new user agents can be selected for example in Konqueror. The generated user agent (at least on Linux-based systems) matches the expected pattern. REPOSITORY R241 KIO BRANCH add-current-useragents REVISION DETAIL https://phabricator.kde.org/D5091 AFFECTED FILES src/kcms/kio/uasproviders/chrome570oncurrent.desktop src/kcms/kio/uasproviders/firefox520oncurrent.desktop To: ltoscano, dfaure Cc: #frameworks
D5090: More focus on KIO than Konqueror
ltoscano created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY - more highlight on "applications that use a certain KIO", Konqueror is an example; - use kio_http and not Konqueror in the user agent; - no more confusion on the old KDE-as-the-destkop. Not totally sure about how much this can be easily understood, but KIO for sure can be used without Konqueror, so this is step forward. TEST PLAN Compiles, the new strings are used. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D5090 AFFECTED FILES src/core/kprotocolmanager.cpp src/kcms/kio/cache.cpp src/kcms/kio/kcookiesmain.cpp src/kcms/kio/kcookiespolicies.cpp src/kcms/kio/smbrodlg.cpp src/kcms/kio/useragent.desktop To: ltoscano, dfaure Cc: #frameworks
D4975: Prevent misdetection of EOF on Linux
ossi added a comment. yeah, but without knowing the root cause, your fix may be just wrong, or at least the comment/commit message may be misleading. also, https://community.kde.org/Policies/Commit_Policy#Don.27t_commit_code_you_don.27t_understand REPOSITORY R291 KPty REVISION DETAIL https://phabricator.kde.org/D4975 To: Lekensteyn, #konsole, hindenburg, ossi Cc: #frameworks
D4975: Prevent misdetection of EOF on Linux
Lekensteyn added a comment. In https://phabricator.kde.org/D4975#95754, @ossi wrote: > first try googling it; maybe there is even a response on stackoverflow (as so often happens). Was one of the first things to try, that only pointed to an issue in Emacs and another that clarified that FIONREAD does not work for things like UDP sockets. > then try posting it yourself to stackoverflow. > dunno whether such questions are welcome on the linux-kernel list, but if not, there might be other lists where it would fit. I doubt that SO would know the answer to this, *some* Linux kernel list would probably work, but then a stripped down testcase is likely needed and I don't really feel like wasting much more time on this. The problem is real. REPOSITORY R291 KPty REVISION DETAIL https://phabricator.kde.org/D4975 To: Lekensteyn, #konsole, hindenburg, ossi Cc: #frameworks
D4975: Prevent misdetection of EOF on Linux
ossi added a comment. first try googling it; maybe there is even a response on stackoverflow (as so often happens). then try posting it yourself to stackoverflow. dunno whether such questions are welcome on the linux-kernel list, but if not, there might be other lists where it would fit. INLINE COMMENTS > Lekensteyn wrote in kptydevice.cpp:307 > Constrained in what sense? Should the first known broken kernel version be > noted here? basically what you put in the commit message. REPOSITORY R291 KPty REVISION DETAIL https://phabricator.kde.org/D4975 To: Lekensteyn, #konsole, hindenburg, ossi Cc: #frameworks
D5089: KDE compiler settings fail to consider AppleClang
kfunk requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D5089 To: rjvbb, #build_system, #frameworks, kfunk Cc: kfunk, apol, kde-mac, #frameworks, #build_system
D5089: KDE compiler settings fail to consider AppleClang
kfunk added a comment. +1 to apol's recommendation. `... MATCHES "Clang"` is the expression everyone uses. Even in cmake.git: Modules/CMakeDetermineCCompiler.cmake 138: if(CMAKE_C_COMPILER_ID MATCHES "GNU" OR CMAKE_C_COMPILER_ID MATCHES "Clang") Also see: http://stackoverflow.com/questions/10046114/in-cmake-how-can-i-test-if-the-compiler-is-clang REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D5089 To: rjvbb, #build_system, #frameworks Cc: kfunk, apol, kde-mac, #frameworks, #build_system
Jenkins-kde-ci: kmediaplayer master kf5-qt5 » Linux,gcc - Build # 476 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kmediaplayer%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/476/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 17 Mar 2017 18:10:12 + Build duration: 57 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 2/2 (100%)FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 183/240 (76%)CONDITIONAL 78/148 (53%) By packages autotests FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 113/131 (86%)CONDITIONAL 59/118 (50%) src FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 70/109 (64%)CONDITIONAL 19/30 (63%)
Jenkins-kde-ci: kmediaplayer master kf5-qt5 » Linux,gcc - Build # 476 - Fixed!
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kmediaplayer%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/476/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 17 Mar 2017 18:10:12 + Build duration: 57 sec CHANGE SET No changes JUNIT RESULTS Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s) COBERTURA RESULTS Cobertura Coverage Report PACKAGES 2/2 (100%)FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 183/240 (76%)CONDITIONAL 78/148 (53%) By packages autotests FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 113/131 (86%)CONDITIONAL 59/118 (50%) src FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 70/109 (64%)CONDITIONAL 19/30 (63%)
D5089: KDE compiler settings fail to consider AppleClang
rjvbb added a comment. In https://phabricator.kde.org/D5089#95732, @apol wrote: > Maybe it would make sense to use MATCHES? are there any other *Clang*? That was my first idea, use `MATCHES "*Clang"`, but then I realised I have no idea if there are other SomethingClang. Searching the CMake sources for `[^"]Clang"` shows only AppleClang but I also see Android-Clang.cmake and Windows-Clang.cmake files. If we don't worry about the sudden future introduction of new AndroidClang, WindowsClang or FooClang IDs then yes, using MATCHES will be cleaner. Come to think of it, it might actually be better because all possible Clang flavours will be covered. After all there's only 1 Clang check currently that's Apple specific, and I left that one alone because it shouldn't trigger on Mac. I'll see what others think. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D5089 To: rjvbb, #build_system, #frameworks Cc: apol, kde-mac, #frameworks, #build_system
Jenkins-kde-ci: kmediaplayer master kf5-qt5 » Linux,gcc - Build # 475 - Failure!
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kmediaplayer%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/475/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 17 Mar 2017 17:57:41 + Build duration: 1 min 20 sec CHANGE SET No changes
D5089: KDE compiler settings fail to consider AppleClang
apol added a comment. Maybe it would make sense to use MATCHES? are there any other *Clang*? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D5089 To: rjvbb, #build_system, #frameworks Cc: apol, kde-mac, #frameworks, #build_system
D4975: Prevent misdetection of EOF on Linux
Lekensteyn added a comment. In https://phabricator.kde.org/D4975#95727, @ossi wrote: > please verify that this is in fact a kernel bug (include ml references), not something that should be expected for some weird reasons (compare the solaris path). I suspect it is a kernel bug, but have no ml references. It seems to be a race condition for which it is hard to prove that it does not exist. See https://bugs.kde.org/show_bug.cgi?id=372991#c10, poll returned but FIONREAD outputted 0 bytes. > if this is a bug, does it actually affect released versions which are not being "upgraded away" on short notice? i wouldn't want a workaround for a bug that had a very short life span. This issue has been there for several months (maybe even a year) and I regularly (multiple times a week) hit this condition when interrupting a program (today it even happened when interrupting a `git push` which was waiting for the SSH passphrase). I have tried to pinpoint the root cause (but failed even after spending hours), what else should I do or can I try? INLINE COMMENTS > ossi wrote in kptydevice.cpp:307 > this should be constrained more - affected versions, and the fact that it's a > bug. Constrained in what sense? Should the first known broken kernel version be noted here? REPOSITORY R291 KPty REVISION DETAIL https://phabricator.kde.org/D4975 To: Lekensteyn, #konsole, hindenburg, ossi Cc: #frameworks
D4975: Prevent misdetection of EOF on Linux
ossi added a comment.
please verify that this is in fact a kernel bug (include ml references), not
something that should be expected for some weird reasons (compare the solaris
path).
if this is a bug, does it actually affect released versions which are not
being "upgraded away" on short notice? i wouldn't want a workaround for a bug
that had a very short life span.
INLINE COMMENTS
> kptydevice.cpp:307
> +#else
> +// On Linux, for some unknown reason 0 bytes can be returned after an
> +// interrupt signal even if a slave is still attached. To avoid
> marking
this should be constrained more - affected versions, and the fact that it's a
bug.
> kptydevice.cpp:315
> +return true;
> +} else if (available) {
> +maybeEof = false;
need no else after return.
REPOSITORY
R291 KPty
REVISION DETAIL
https://phabricator.kde.org/D4975
To: Lekensteyn, #konsole, hindenburg, ossi
Cc: #frameworks
D5089: KDE compiler settings fail to consider AppleClang
rjvbb created this revision. rjvbb added projects: Build System, Frameworks. REVISION SUMMARY KDECompilerSettings.cmake and KDEFrameworksCompilerSettings.cmake fail to consider the fact that cmake considers Apple's clang compiler to be different (differences that exist but are largely irrelevant for KDE and the ECM in particular). I just ran into a failure building the KJs 5.32.0 framework as a result, using the system/Xcode clang compiler for OS X 10.9.5 . The build system had failed to put the compiler into C++11 mode. This patch address the issue by checking the CMAKE_*_COMPILER_ID against both "Clang" and "AppleClang". A more elegant approach may be possible with regexp pattern matching but might cause problems if other clang flavours exist and match that shouldn't . TEST PLAN With this patch KJs builds without further errors. I will update this ticket should I run into unforeseen side-effects. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D5089 AFFECTED FILES kde-modules/KDECompilerSettings.cmake kde-modules/KDEFrameworkCompilerSettings.cmake To: rjvbb, #build_system, #frameworks Cc: kde-mac, #frameworks, #build_system
D5087: Introduce ecm_generate_qmltypes
apol updated this revision to Diff 12570. apol added a comment. Some adaptions so it works for Plasma Framework too REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5087?vs=12565&id=12570 BRANCH master REVISION DETAIL https://phabricator.kde.org/D5087 AFFECTED FILES modules/ECMGenerateQmlTypes.cmake modules/test_execute_and_compare.cmake To: apol, #frameworks, #build_system
D5088: Generate plugins.qmltypes files for the plugins we install
apol created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: plasma-devel. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D5088 AFFECTED FILES CMakeLists.txt src/declarativeimports/calendar/CMakeLists.txt src/declarativeimports/calendar/plugins.qmltypes src/declarativeimports/core/CMakeLists.txt src/declarativeimports/core/plugins.qmltypes src/declarativeimports/plasmacomponents/CMakeLists.txt src/declarativeimports/plasmacomponents/plugins.qmltypes src/declarativeimports/plasmaextracomponents/CMakeLists.txt src/declarativeimports/plasmaextracomponents/plugins.qmltypes src/declarativeimports/platformcomponents/CMakeLists.txt src/declarativeimports/platformcomponents/plugins.qmltypes To: apol, #plasma, #frameworks Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
D4975: Prevent misdetection of EOF on Linux
cfeck added a reviewer: ossi. REPOSITORY R291 KPty REVISION DETAIL https://phabricator.kde.org/D4975 To: Lekensteyn, #konsole, hindenburg, ossi Cc: #frameworks
D5087: Introduce ecm_generate_qmltypes
apol created this revision. Restricted Application added projects: Frameworks, Build System. REVISION SUMMARY Introduces a function that allows to generate plugins.qmltypes files for our qml plugins using qmlplugindump much like Qt does. TEST PLAN Introduced it locally on Purpose and it works REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D5087 AFFECTED FILES modules/ECMGenerateQmlTypes.cmake modules/test_execute_and_compare.cmake To: apol, #frameworks, #build_system
D5079: debug when disabling kcrash due to env vars
sitter added a reviewer: dfaure. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D5079 To: sitter, dfaure Cc: #frameworks
D5079: debug when disabling kcrash due to env vars
sitter created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY otherwise it's fairly inobvious why drkonqi doesn't kick in REPOSITORY R285 KCrash BRANCH master REVISION DETAIL https://phabricator.kde.org/D5079 AFFECTED FILES src/kcrash.cpp To: sitter Cc: #frameworks
Re: Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130013/ --- (Updated March 17, 2017, 8:23 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Anthony Fieroni. Changes --- Submitted with commit f9c8bb29b2cf5d46ff68c0261393084d1ff16ece by Igor Poboiko to branch master. Repository: kfilemetadata Description --- After commit 7c7e985a4678fef5f5d0dd8faa9b9cb42e3844b4 (see https://git.reviewboard.kde.org/r/129720/), PlainTextExtractor no longer matches ANY of the text/ mimetypes. This broke completely Baloo indexing e.g. simple plain text files. Introduced check however allows to provide "text/plain" as supported mimetype for the extractor and hope that everything containing plain text will be inherited from it. Diffs - autotests/CMakeLists.txt 5ab742b autotests/extractorcollectiontest.cpp PRE-CREATION src/externalextractor.cpp 05f0645 src/extractors/plaintextextractor.cpp 26e1247 Diff: https://git.reviewboard.kde.org/r/130013/diff/ Testing --- KFileMetaData compiles. Baloo indexes plain text files. Everybody is happy. Thanks, Igor Poboiko
Re: Review Request 130013: Make PlainTextExtractor match "text/plain" mimetype
> On mars 15, 2017, 9:55 matin, Matthieu Gallien wrote:
> > Ship It!
>
> Matthieu Gallien wrote:
> KFileMetaData being in use by itself, IMHO Baloo problematics should not
> block this correction.
>
> Matthieu Gallien wrote:
> I almost forgot to ask an automatic test for your fix. Please do not ship
> without it.
>
> Matthieu Gallien wrote:
> You can see that current tests do not cover the line you are modifying:
> https://build.kde.org/view/Frameworks%20kf5-qt5/job/kfilemetadata%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/lastCompletedBuild/cobertura/src_extractors/plaintextextractor_cpp/
> .
>
> Igor Poboiko wrote:
> Unfortunately, I've got not that much experience in writing autotests...
>
> I think the proper test that would have revealed that problem would be
> actually a test for ExtractorCollection::fetchExtractors (just check some
> more or less obvious mimetypes and see that correct plugins are returned).
> If you think this is fine, I can see how other tests are done and then
> add one.
>
> Matthieu Gallien wrote:
> Thanks for taking care of that bug.
>
> Do not feel scared, there are already tests that may get you started. I
> am also very happy to help if I can.
> In the current automatic tests, you will see that there are example files
> in the samplefiles directory. There is even one called plain_text_file.txt.
> You can have a look at any of the tests called
> extractortest.{h|cpp}. They may provide you inspiration.
>
> Let me know if I can help you.
Thanks for having taken care of automatic test.
I had a more general look at the exitsing tests with plain_text_file.txt. They
are completely like the other automatic tests like taglib, the extractor is
hardcoded. No way they would detect the bug you are fixing.
If nobody beats me to it, I will try to fix that problem soon.
As far as I am concerned, please push your fix.
- Matthieu
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/130013/#review102851
---
On mars 16, 2017, 9:33 après-midi, Igor Poboiko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/130013/
> ---
>
> (Updated mars 16, 2017, 9:33 après-midi)
>
>
> Review request for KDE Frameworks and Anthony Fieroni.
>
>
> Repository: kfilemetadata
>
>
> Description
> ---
>
> After commit 7c7e985a4678fef5f5d0dd8faa9b9cb42e3844b4 (see
> https://git.reviewboard.kde.org/r/129720/), PlainTextExtractor no longer
> matches ANY of the text/ mimetypes.
> This broke completely Baloo indexing e.g. simple plain text files.
> Introduced check however allows to provide "text/plain" as supported mimetype
> for the extractor and hope that everything containing plain text will be
> inherited from it.
>
>
> Diffs
> -
>
> autotests/CMakeLists.txt 5ab742b
> autotests/extractorcollectiontest.cpp PRE-CREATION
> src/externalextractor.cpp 05f0645
> src/extractors/plaintextextractor.cpp 26e1247
>
> Diff: https://git.reviewboard.kde.org/r/130013/diff/
>
>
> Testing
> ---
>
> KFileMetaData compiles.
> Baloo indexes plain text files.
> Everybody is happy.
>
>
> Thanks,
>
> Igor Poboiko
>
>
