D5312: KPasswordDialog: don't hide visibility action in plaintext mode

2017-04-05 Thread Elvis Angelaccio 
elvisangelaccio added a dependent revision: D5313: Add workaround for bug in 
QLineEdit's clear button.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D5312

To: elvisangelaccio, cfeck, fvogt
Cc: #frameworks

D5312: KPasswordDialog: don't hide visibility action in plaintext mode

2017-04-05 Thread Elvis Angelaccio 
elvisangelaccio created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  Otherwise the user cannot tell whether what's going to be typed will be
  visible or not.
  
  BUG: 378276
  FIXED-IN: 5.34

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  kpassworddialog-leak

REVISION DETAIL
  https://phabricator.kde.org/D5312

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/kpassworddialogautotest.cpp
  autotests/kpassworddialogautotest.h
  src/kpassworddialog.cpp

To: elvisangelaccio, cfeck, fvogt
Cc: #frameworks

D5138: Fill UDS_CREATION_TIME with the value of st_birthtime on FreeBSD

2017-04-05 Thread Albert Astals Cid 
aacid added a comment.


  tobias will you commit this? Or are we still waiting for some other approval?

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5138

To: tcberner, arrowdodger, rakuco, dfaure, adridg
Cc: aacid, kfunk, emmanuelp, #frameworks

D5143: Introduce fetch-translations build command

2017-04-05 Thread Harald Sitter 
sitter accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5143

To: apol, #frameworks, #build_system, kfunk, ltoscano, aacid, ilic, sitter
Cc: sitter

D5143: Introduce fetch-translations build command

2017-04-05 Thread Luigi Toscano 
ltoscano added inline comments.

INLINE COMMENTS

> KDECMakeSettings.cmake:289
> +option(KDE_L10N_AUTO_TRANSLATIONS "Automatically 'make 
> fetch-translations`" OFF)
> +set(KDE_L10N_BRANCH "trunk" CACHE STRING "Branch from l10n.kde.org to 
> fetch from: trunk | stable | lts | trunk_kde4 | stable_kde4")
> +

Do we want to have trunk, stable and lts to always point to the most recent 
version vs using trunk_kf5, stable_kf5, lts_kf5? I'm thinking about what will 
happen with KF6 in few years.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5143

To: apol, #frameworks, #build_system, kfunk, ltoscano, aacid, ilic, sitter
Cc: sitter

D5197: Make it possible to use the fetched translations

2017-04-05 Thread Aleix Pol Gonzalez 
apol updated this revision to Diff 13120.
apol added a comment.


  FWIW this works, although it feels weird to include the source dir despite it 
not existing

REPOSITORY
  R325 KAlgebra

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5197?vs=12870=13120

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5197

AFFECTED FILES
  CMakeLists.txt

To: apol, #frameworks
Cc: ltoscano

D5143: Introduce fetch-translations build command

2017-04-05 Thread Aleix Pol Gonzalez 
apol added a comment.


  Fixed.
  Can I please have a ship it?  we can maybe polish it over time

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D5143

To: apol, #frameworks, #build_system, kfunk, ltoscano, aacid, ilic
Cc: sitter

D5143: Introduce fetch-translations build command

2017-04-05 Thread Aleix Pol Gonzalez 
apol marked 3 inline comments as done.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D5143

To: apol, #frameworks, #build_system, kfunk, ltoscano, aacid, ilic
Cc: sitter

D5167: Move .po and .ts files look-up to build-time

2017-04-05 Thread Aleix Pol Gonzalez 
apol updated this revision to Diff 13118.
apol added a comment.


  Makes it possible to have ${CMAKE_SOURCE_DIR} and ${CMAKE_BINARY_DIR}

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5167?vs=12987=13118

BRANCH
  fetchbuildtime

REVISION DETAIL
  https://phabricator.kde.org/D5167

AFFECTED FILES
  CMakeLists.txt
  cmake/KF5I18NMacros.cmake
  cmake/build-pofiles.cmake
  cmake/build-tsfiles.cmake

To: apol, #frameworks, sitter, ltoscano, ilic
Cc: aacid

D5143: Introduce fetch-translations build command

2017-04-05 Thread Aleix Pol Gonzalez 
apol updated this revision to Diff 13117.
apol added a comment.


  Address sitter's comments

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5143?vs=13006=13117

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5143

AFFECTED FILES
  kde-modules/KDECMakeSettings.cmake

To: apol, #frameworks, #build_system, kfunk, ltoscano, aacid, ilic
Cc: sitter

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 494 - Fixed!

2017-04-05 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/494/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 05 Apr 2017 14:28:18 +
Build duration: 5 min 35 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 
53 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 22/22 (100%)FILES 275/344 (80%)CLASSES 275/344 (80%)LINE 29977/52022 
(58%)CONDITIONAL 16427/39075 (42%)

By packages
  
autotests
FILES 66/66 (100%)CLASSES 66/66 (100%)LINE 7971/8288 
(96%)CONDITIONAL 4446/8694 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 97/117 (83%)CLASSES 97/117 (83%)LINE 8100/14183 
(57%)CONDITIONAL 4442/9267 (48%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3469/7561 
(46%)CONDITIONAL 1293/4381 (30%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 447/849 (53%)CONDITIONAL 
330/749 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1767/3780 
(47%)CONDITIONAL 1275/3460 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 621/782 (79%)CONDITIONAL 
607/839 (72%)
src.ioslaves.remote
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 70/258 (27%)CONDITIONAL 
14/200 (7%)
src.ioslaves.trash
FILES 8/10 (80%)CLASSES 8/10 (80%)LINE 727/1173 
(62%)CONDITIONAL 411/851 (48%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 707/785 (90%)CONDITIONAL 
461/970 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 
111/138 (80%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 242/727 (33%)CONDITIONAL 
150/546 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 21/29 (72%)CONDITIONAL 
16/26 (62%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 237/266 (89%)CONDITIONAL 
332/412 (81%)
src.widgets
FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3665/11070 
(33%)CONDITIONAL 1763/7138 (25%)

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 494 - Fixed!

2017-04-05 Thread no-reply 

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/494/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 05 Apr 2017 14:28:18 +
Build duration: 5 min 35 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 
53 test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 22/22 (100%)FILES 275/344 (80%)CLASSES 275/344 (80%)LINE 29977/52022 
(58%)CONDITIONAL 16427/39075 (42%)

By packages
  
autotests
FILES 66/66 (100%)CLASSES 66/66 (100%)LINE 7971/8288 
(96%)CONDITIONAL 4446/8694 (51%)
autotests.http
FILES 9/9 (100%)CLASSES 9/9 (100%)LINE 543/544 
(100%)CONDITIONAL 200/336 (60%)
autotests.kcookiejar
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 179/198 (90%)CONDITIONAL 
60/90 (67%)
src.core
FILES 97/117 (83%)CLASSES 97/117 (83%)LINE 8100/14183 
(57%)CONDITIONAL 4442/9267 (48%)
src.core.kssl
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 35/93 (38%)CONDITIONAL 
3/6 (50%)
src.filewidgets
FILES 26/36 (72%)CLASSES 26/36 (72%)LINE 3469/7561 
(46%)CONDITIONAL 1293/4381 (30%)
src.gui
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 104/110 (95%)CONDITIONAL 
46/72 (64%)
src.ioslaves.file
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 447/849 (53%)CONDITIONAL 
330/749 (44%)
src.ioslaves.http
FILES 8/8 (100%)CLASSES 8/8 (100%)LINE 1767/3780 
(47%)CONDITIONAL 1275/3460 (37%)
src.ioslaves.http.kcookiejar
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 621/782 (79%)CONDITIONAL 
607/839 (72%)
src.ioslaves.remote
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 70/258 (27%)CONDITIONAL 
14/200 (7%)
src.ioslaves.trash
FILES 8/10 (80%)CLASSES 8/10 (80%)LINE 727/1173 
(62%)CONDITIONAL 411/851 (48%)
src.ioslaves.trash.tests
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 707/785 (90%)CONDITIONAL 
461/970 (48%)
src.kioslave
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 14/27 (52%)CONDITIONAL 
5/10 (50%)
src.kntlm
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 373/385 (97%)CONDITIONAL 
111/138 (80%)
src.kpasswdserver
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 377/594 (63%)CONDITIONAL 
280/580 (48%)
src.kpasswdserver.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 283/286 (99%)CONDITIONAL 
146/256 (57%)
src.urifilters.fixhost
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 25/34 (74%)CONDITIONAL 
36/54 (67%)
src.urifilters.ikws
FILES 5/10 (50%)CLASSES 5/10 (50%)LINE 242/727 (33%)CONDITIONAL 
150/546 (27%)
src.urifilters.localdomain
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 21/29 (72%)CONDITIONAL 
16/26 (62%)
src.urifilters.shorturi
FILES 2/2 (100%)CLASSES 2/2 (100%)LINE 237/266 (89%)CONDITIONAL 
332/412 (81%)
src.widgets
FILES 32/64 (50%)CLASSES 32/64 (50%)LINE 3665/11070 
(33%)CONDITIONAL 1763/7138 (25%)

D5143: Introduce fetch-translations build command

2017-04-05 Thread Harald Sitter 
sitter added a comment.


  needs a version bump in the docs now 
  
  beyond that LGTM

INLINE COMMENTS

> KDECMakeSettings.cmake:86
> +#
> +# Since 5.33.0
>  

5.34 now

> KDECMakeSettings.cmake:323
> +COMMAND ruby "${CMAKE_BINARY_DIR}/releaseme/fetchpo.rb" --origin 
> ${KDE_L10N_BRANCH} --project "${reponame}" "${CMAKE_CURRENT_SOURCE_DIR}" 
> "${CMAKE_BINARY_DIR}/po"
> +BYPRODUCTS "${CMAKE_BINARY_DIR}/po"
> +DEPENDS "${CMAKE_BINARY_DIR}/releaseme"

This was only introduced in cmake 3.2. I am not sure we care or if this even 
would cause problems beyond a warning, but technically frameworks are 3.0 
compatible (or so they claim anyway ;)). Seeing as the feature is opt-in it 
probably doesn't matter eitherway.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D5143

To: apol, #frameworks, #build_system, kfunk, ltoscano, aacid, ilic
Cc: sitter

D5302: Use -Wno-gnu-zero-variadic-macro-arguments more

2017-04-05 Thread Kevin Funk 
This revision was automatically updated to reflect the committed changes.
Closed by commit R240:c20a9f69e8e2: Use -Wno-gnu-zero-variadic-macro-arguments 
more (authored by kfunk).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5302?vs=13096=13113

REVISION DETAIL
  https://phabricator.kde.org/D5302

AFFECTED FILES
  kde-modules/KDECompilerSettings.cmake
  kde-modules/KDEFrameworkCompilerSettings.cmake

To: kfunk, kossebau, apol, dfaure
Cc: apol, #frameworks, #build_system

D5296: Use non-deprecated root element

2017-04-05 Thread Friedrich W. H. Kossebau 
kossebau added a comment.


  In https://phabricator.kde.org/D5296#99818, @aacid wrote:
  
  > Do you know where we do the parsing that allows both gui and kpartgui to be 
"valid"?
  >
  > I did some searching and i think i found it but would be nice if you can 
find it and we agree on it D:
  
  
  What I found is that the parsing does not check the name of the root element, 
so ,  or the more ancient  (which I came across 
e.g. in some rc files KDevPlatform) all work. Or whatever else one might use, 
like  ;)
  
  For code which does that, I think e.g. of  `KXMLGUIClient::setDOMDocument()` 
,
 which just takes the `doc.documentElement()` of the passed DOM documents 
without any validation.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D5296

To: kossebau, #frameworks
Cc: aacid

D5302: Use -Wno-gnu-zero-variadic-macro-arguments more

2017-04-05 Thread David Faure 
dfaure added a comment.


  5.33 is tagged since last saturday, you can push without waiting. It's always 
summer in master, for KF5.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5302

To: kfunk, kossebau, apol, dfaure
Cc: apol, #frameworks, #build_system

D5302: Use -Wno-gnu-zero-variadic-macro-arguments more

2017-04-05 Thread Kevin Funk 
kfunk added a comment.


  FYI: I'll wait with pushing until v5.33 is released.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5302

To: kfunk, kossebau, dfaure, apol
Cc: apol, #frameworks, #build_system

D5302: Use -Wno-gnu-zero-variadic-macro-arguments more

2017-04-05 Thread Aleix Pol Gonzalez 
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D5302

To: kfunk, kossebau, dfaure, apol
Cc: apol, #frameworks, #build_system

D3830: Add a new FindGperf module

2017-04-05 Thread Adriaan de Groot 
adridg accepted this revision.
adridg added a comment.


  I just happened to need a FindGperf in another project today, so I've tested 
this in non-ECM settings (adding this plus ECMFindModuleHelpers to that 
project's own cmake/) and it works fine on FreeBSD. The docs in the header are 
good, too: they let me replace some custom cruft in under five minutes with 
simpler ECM code.
  
  So from the FreeBSD side: ship it.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  pino-gperf

REVISION DETAIL
  https://phabricator.kde.org/D3830

To: pino, #frameworks, #build_system, #windows, kde-mac, rjvbb, adridg
Cc: kfunk, rjvbb, adridg

D5302: Use -Wno-gnu-zero-variadic-macro-arguments more

2017-04-05 Thread Kevin Funk 
kfunk added a comment.


  In https://phabricator.kde.org/D5302#99816, @apol wrote:
  
  > +1
  >
  > Which warnings? Are they proper warnings that should be fixed?
  
  
  See comment inside the source code: It's triggered by normal usage from 
`qCDebug()`...

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D5302

To: kfunk, kossebau, dfaure
Cc: apol, #frameworks, #build_system

D3830: Add a new FindGperf module

2017-04-05 Thread René J . V . Bertin 
rjvbb accepted this revision.
rjvbb added a comment.
This revision is now accepted and ready to land.


  Sorry, I haven't had the occasion to test this modification but given our 
exchange above this ought to be fine as far as I can tell.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  pino-gperf

REVISION DETAIL
  https://phabricator.kde.org/D3830

To: pino, #frameworks, #build_system, #windows, kde-mac, rjvbb
Cc: kfunk, rjvbb, adridg