D6042: Don't use the path as is if it's a data: url
apol created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY The path is the content, so it basically will set the same content as filename. This change it to default to "data" in a case where I identified it to be a problem, it could possibly be useful in other places. BUG: 379093 TEST PLAN Tests pass REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D6042 AFFECTED FILES src/core/copyjob.cpp To: apol, #frameworks
D6041: Port a bunch of classes away from Plasma::Package
apol created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Ported away some classes, removes many unneeded casts that happen when starting. TEST PLAN Tests still pass, plasma starts properly REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D6041 AFFECTED FILES autotests/CMakeLists.txt autotests/packageurlinterceptortest.cpp autotests/packageurlinterceptortest.h src/plasma/pluginloader.cpp src/plasma/pluginloader.h src/plasmaquick/appletquickitem.cpp src/plasmaquick/appletquickitem.h src/plasmaquick/configview.cpp src/plasmaquick/containmentview.cpp src/plasmaquick/packageurlinterceptor.cpp src/plasmaquick/packageurlinterceptor.h src/plasmaquick/private/appletquickitem_p.h src/plasmaquick/view.cpp src/scriptengines/qml/plasmoid/containmentinterface.cpp src/scriptengines/qml/plasmoid/wallpaperinterface.cpp src/scriptengines/qml/plasmoid/wallpaperinterface.h To: apol, #frameworks, #plasma Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D5972: Set (and unset, as necessary) QT_NO_EXCEPTIONS for Clang (and ICC)
thiago added a comment. In https://phabricator.kde.org/D5972#112994, @rjvbb wrote: > Yes, here too, haven't had time to read back up on and go through the whole Qt code review process. What branch should I target, anyway? 5.9, with a possible backport to 5.6. There's still time for 5.6.3. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D5972 To: rjvbb, #build_system, #frameworks, kfunk Cc: thiago, #frameworks, #build_system
D5972: Set (and unset, as necessary) QT_NO_EXCEPTIONS for Clang (and ICC)
rjvbb added a comment. In https://phabricator.kde.org/D5972#112975, @thiago wrote: > Makes sense to work around older versions of Qt without the fix. > > But it needs a fix. That is still pending. Yes, here too, haven't had time to read back up on and go through the whole Qt code review process. What branch should I target, anyway? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D5972 To: rjvbb, #build_system, #frameworks, kfunk Cc: thiago, #frameworks, #build_system
D5972: Set (and unset, as necessary) QT_NO_EXCEPTIONS for Clang (and ICC)
thiago added a comment. Makes sense to work around older versions of Qt without the fix. But it needs a fix. That is still pending. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D5972 To: rjvbb, #build_system, #frameworks, kfunk Cc: thiago, #frameworks, #build_system
Re: extra-cmake-modules in kdesupport?
On Tue, May 30, 2017 at 4:10 PM, Luigi Toscano wrote: > On Tuesday, 30 May 2017 16:06:56 CEST Harald Sitter wrote: >> Is there a reason ECM's project is placed in kdesupport rather than >> frameworks? >> >> https://cgit.kde.org/sysadmin/repo-metadata.git/tree/projects/kdesupport/ext >> ra-cmake-modules >> >> Seems a bit fishy at best and practically means that if ECM ever were >> to get translations it wouldn't inherit the translation settings >> applying to frameworks/* >> https://cgit.kde.org/sysadmin/repo-metadata.git/tree/config/i18n_defaults.js >> on >> >> Can we fix this or is this actually intentional? > > > I think that we can fix that only if we define a tier 0 for Frameworks. > Otherwise tier 1 frameworks wouldn't be able to depend on it, by definition. That was actually the reason, as far as I remember. The plan was to move things up to cmake at some point, which never happened because we'd obviously have to require new versions of cmake all the time. Tier 0 works for me, I agree it's what it is anyway, they're even released together. Aleix
Re: extra-cmake-modules in kdesupport?
On Tuesday, 30 May 2017 16:06:56 CEST Harald Sitter wrote: > Is there a reason ECM's project is placed in kdesupport rather than > frameworks? > > https://cgit.kde.org/sysadmin/repo-metadata.git/tree/projects/kdesupport/ext > ra-cmake-modules > > Seems a bit fishy at best and practically means that if ECM ever were > to get translations it wouldn't inherit the translation settings > applying to frameworks/* > https://cgit.kde.org/sysadmin/repo-metadata.git/tree/config/i18n_defaults.js > on > > Can we fix this or is this actually intentional? I think that we can fix that only if we define a tier 0 for Frameworks. Otherwise tier 1 frameworks wouldn't be able to depend on it, by definition. -- Luigi
extra-cmake-modules in kdesupport?
Is there a reason ECM's project is placed in kdesupport rather than frameworks? https://cgit.kde.org/sysadmin/repo-metadata.git/tree/projects/kdesupport/extra-cmake-modules Seems a bit fishy at best and practically means that if ECM ever were to get translations it wouldn't inherit the translation settings applying to frameworks/* https://cgit.kde.org/sysadmin/repo-metadata.git/tree/config/i18n_defaults.json Can we fix this or is this actually intentional? HS
D5865: Add missing KDE_ENABLE_NAMED_OPERATORS function
rjvbb edited the summary of this revision. rjvbb edited the test plan for this revision. rjvbb set the repository for this revision to R240 Extra CMake Modules. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D5865 To: rjvbb, #frameworks, #build_system, cgilles, kfunk Cc: thiago, kfunk
D5865: Add missing KDE_ENABLE_NAMED_OPERATORS function
rjvbb updated this revision to Diff 14971. rjvbb added a comment. Updated as requested. GIven the controversy I thought it might be useful to add at least a target-specific enabler macro (which may need some polishing or simplification - using generator expressions may not be required here? Do we also want the per-file version? Not that I want to have the last word, but it's not me who brought up fixing code and filing bug reports. And contrary to FOSS projects, MS *do* have the resources and the means to push patches to all currently supported versions of their product. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5865?vs=14635&id=14971 REVISION DETAIL https://phabricator.kde.org/D5865 AFFECTED FILES kde-modules/KDECompilerSettings.cmake To: rjvbb, #frameworks, #build_system, cgilles, kfunk Cc: thiago, kfunk
D5865: Add missing KDE_ENABLE_NAMED_OPERATORS function
kfunk added a comment. In https://phabricator.kde.org/D5865#112766, @rjvbb wrote: > KDE is FOSS not bound to Microsoft by any corporate buy-in or whatever, right? What non-sense is this? Please stay on topic. There's a benefit we make sure KDE software is compiling under MSVC given its popularity on Windows. > If there's a bug to report it's the lack of standard compliance in MSVC - how have MS reacted to such reports? ... and you're going to have them fix older MSVC versions to support your use-case? This discussion is such a waste of time really. Please face the reality and show some pragmatism: Named operators do not work on MSVC prior to MSVC 2017, period. +1 on Thiago's solution, for the good. Let's just print a warning for MSVC prior to version 2017: > That's a fine solution. If you're going to print a warning and you're serious about cross-platformness support, I suggest printing the warning for ALL compilers: "Warning: using C++ operator names is not compatible with MSVC prior to version 2017 (19.1). You should reconsider using this macro if your code is meant to be cross-platform". REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D5865 To: rjvbb, #frameworks, #build_system, cgilles, kfunk Cc: thiago, kfunk
D5972: Set (and unset, as necessary) QT_NO_EXCEPTIONS for Clang (and ICC)
rjvbb edited the summary of this revision. rjvbb added a reviewer: kfunk. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D5972 To: rjvbb, #build_system, #frameworks, kfunk Cc: #frameworks, #build_system
D5865: Add missing KDE_ENABLE_NAMED_OPERATORS function
rjvbb added a comment. KDE is FOSS not bound to Microsoft by any corporate buy-in or whatever, right? If there's a bug to report it's the lack of standard compliance in MSVC - how have MS reacted to such reports? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D5865 To: rjvbb, #frameworks, #build_system, cgilles, kfunk Cc: thiago, kfunk
KDE CI: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 - Build # 13 - Still Unstable!
BUILD UNSTABLE Build URL https://build-sandbox.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20XenialQt5.7/13/ Project: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 Date of build: Tue, 30 May 2017 07:07:14 + Build duration: 3 min 17 sec and counting JUnit Tests Name: (root) Failed: 4 test(s), Passed: 21 test(s), Skipped: 0 test(s), Total: 25 test(s)Failed: TestSuite.kdirwatch_fam_unittestFailed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kdirwatch_stat_unittest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report100% (10/10)85% (79/93)85% (79/93)72% (5933/8239)42% (10640/25227)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests83% (33/40)83% (33/40)96% (2566/2682)48% (6525/13503)src.desktoptojson100% (3/3)100% (3/3)79% (84/106)38% (146/384)src.lib67% (2/3)67% (2/3)56% (302/536)22% (192/893)src.lib.caching100% (2/2)100% (2/2)45% (352/787)18% (195/1086)src.lib.io90% (9/10)90% (9/10)53% (744/1397)26% (837/3214)src.lib.jobs71% (5/7)71% (5/7)52% (159/304)39% (57/146)src.lib.plugin100% (8/8)100% (8/8)86% (646/748)44% (1035/2326)src.lib.randomness100% (2/2)100% (2/2)67% (66/99)58% (45/78)src.lib.text63% (5/8)63% (5/8)46% (349/764)40% (794/1981)src.lib.util100% (10/10)100% (10/10)81% (665/816)50% (814/1616) build.log Description: Binary data
