KDE CI: Frameworks baloo kf5-qt5 XenialQt5.7 - Build # 10 - Still Unstable!
BUILD UNSTABLE Build URL https://build-sandbox.kde.org/job/Frameworks%20baloo%20kf5-qt5%20XenialQt5.7/10/ Project: Frameworks baloo kf5-qt5 XenialQt5.7 Date of build: Mon, 05 Jun 2017 01:44:21 + Build duration: 2 min 41 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kinotifytest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report100% (12/12)77% (111/144)77% (111/144)73% (5039/6932)50% (2613/5194)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests.benchmarks100% (2/2)100% (2/2)100% (42/42)89% (16/18)autotests.integration100% (3/3)100% (3/3)95% (242/255)64% (140/220)autotests.unit.codecs100% (3/3)100% (3/3)100% (40/40)57% (25/44)autotests.unit.engine100% (17/17)100% (17/17)100% (736/736)53% (390/740)autotests.unit.file100% (11/11)100% (11/11)97% (788/809)51% (438/864)autotests.unit.lib100% (6/6)100% (6/6)97% (315/326)52% (156/302)src.codecs100% (5/5)100% (5/5)87% (120/138)76% (32/42)src.engine97% (38/39)97% (38/39)79% (1607/2038)58% (796/1379)src.file39% (17/44)39% (17/44)45% (678/1506)38% (374/980)src.file.extractor100% (2/2)100% (2/2)69% (20/29)58% (7/12)src.file.extractor.autotests100% (1/1)100% (1/1)100% (22/22)61% (11/18)src.lib55% (6/11)55% (6/11)43% (429/991)40% (228/575) build.log Description: Binary data
D3439: Create a QCH file with the API dox, optionally, using ECMAddQCH
This revision was automatically updated to reflect the committed changes. Closed by commit R288:66510d55dbe0: [FEATURE] Option to build & install QCH file with the public API dox (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3439?vs=14669=15154#toc REPOSITORY R288 KJobWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3439?vs=14669=15154 REVISION DETAIL https://phabricator.kde.org/D3439 AFFECTED FILES CMakeLists.txt KF5JobWidgetsConfig.cmake.in src/CMakeLists.txt To: kossebau, #frameworks, ochurlaud Cc: shumski
D3609: Create a QCH file with the API dox, optionally, using ECMAddQch
This revision was automatically updated to reflect the committed changes. Closed by commit R216:6891e5a13848: [FEATURE] Option to build & install QCH file with the public API dox (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3609?vs=14670=15153#toc REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3609?vs=14670=15153 REVISION DETAIL https://phabricator.kde.org/D3609 AFFECTED FILES CMakeLists.txt KF5SyntaxHighlightingConfig.cmake.in src/lib/CMakeLists.txt To: kossebau, #frameworks
KDE CI: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 - Build # 20 - Still Unstable!
BUILD UNSTABLE Build URL https://build-sandbox.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20XenialQt5.7/20/ Project: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 Date of build: Mon, 05 Jun 2017 00:21:11 + Build duration: 3 min 28 sec and counting JUnit Tests Name: (root) Failed: 3 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 25 test(s)Failed: TestSuite.kdirwatch_fam_unittestFailed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_qfswatch_unittest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report100% (10/10)85% (79/93)85% (79/93)73% (6039/8239)43% (10830/25227)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests83% (33/40)83% (33/40)97% (2599/2682)49% (6620/13503)src.desktoptojson100% (3/3)100% (3/3)79% (84/106)38% (146/384)src.lib67% (2/3)67% (2/3)56% (302/536)22% (192/893)src.lib.caching100% (2/2)100% (2/2)45% (352/787)18% (195/1086)src.lib.io90% (9/10)90% (9/10)58% (817/1397)29% (932/3214)src.lib.jobs71% (5/7)71% (5/7)52% (159/304)39% (57/146)src.lib.plugin100% (8/8)100% (8/8)86% (646/748)44% (1035/2326)src.lib.randomness100% (2/2)100% (2/2)67% (66/99)58% (45/78)src.lib.text63% (5/8)63% (5/8)46% (349/764)40% (794/1981)src.lib.util100% (10/10)100% (10/10)81% (665/816)50% (814/1616) build.log Description: Binary data
D3438: Create a QCH file with the API dox, optionally, using ECMAddQCH
This revision was automatically updated to reflect the committed changes. Closed by commit R244:f1ccb8877e78: [FEATURE] Option to build & install QCH file with the public API dox (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3438?vs=14667=15152#toc REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3438?vs=14667=15152 REVISION DETAIL https://phabricator.kde.org/D3438 AFFECTED FILES CMakeLists.txt KF5CoreAddonsConfig.cmake.in src/lib/CMakeLists.txt To: kossebau, #frameworks, ochurlaud
D3458: Create a QCH file with the API dox, optionally, using ECMAddQCH
This revision was automatically updated to reflect the committed changes. kossebau marked an inline comment as done. Closed by commit R243:42292d5214c6: [FEATURE] Option to build & install QCH file with the public API dox (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3458?vs=14668=15151#toc REPOSITORY R243 KArchive CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3458?vs=14668=15151 REVISION DETAIL https://phabricator.kde.org/D3458 AFFECTED FILES CMakeLists.txt KF5ArchiveConfig.cmake.in src/CMakeLists.txt To: kossebau, #frameworks Cc: dfaure
D2854: New: ECMAddQch, for generating qch & doxygen tag files
This revision was automatically updated to reflect the committed changes. Closed by commit R240:c837f58d505b: New: ECMAddQch, for generating qch & doxygen tag files (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D2854?vs=14672=15148#toc REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2854?vs=14672=15148 REVISION DETAIL https://phabricator.kde.org/D2854 AFFECTED FILES docs/module/ECMAddQch.rst find-modules/FindQHelpGenerator.cmake kde-modules/KDEInstallDirs.cmake modules/ECMAddQch.cmake modules/ECMQchDoxygen.config.in modules/ECMQchDoxygenLayout.xml tests/CMakeLists.txt tests/KDEInstallDirsTest/var_list.cmake To: kossebau, #frameworks, #build_system, staniek Cc: shumski, kfunk, staniek, winterz, ochurlaud, #kdevelop
D1231: Add Remote Access interface to KWayland
Kanedias added a dependent revision: D6096: Add Wayland RemoteAccess capabilities to KRfb. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin, davidedmundson Cc: #frameworks, davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
D1231: Add Remote Access interface to KWayland
Kanedias added a dependent revision: D1230: GBM remote access support for KWin. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D1231 To: Kanedias, graesslin, davidedmundson Cc: #frameworks, davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas
Re: Version macro
On domenica 4 giugno 2017 20:31:43 CEST, A. Bikadorov wrote: Quick question: is there a macro to find out the version of a frameworks library (KIO) at compile time? Yes, $framework_VERSION. Example usage: https://cgit.kde.org/dolphin.git/commit/?id=5f484d8ee865554f933dd22fd1a2e597b1ecb52a Like PLASMA_MAKE_VERSION or QT_VERSION_CHECK. Thanks Alex Cheers, Elvis
Version macro
Quick question: is there a macro to find out the version of a frameworks library (KIO) at compile time? Like PLASMA_MAKE_VERSION or QT_VERSION_CHECK. Thanks Alex
D5983: Check error status after every PolKitAuthority usage
skalinichev added a comment. In https://phabricator.kde.org/D5983#113975, @aacid wrote: > Did you commit this on purpose without the review being accepted or was it a mistake? Yeah, I did it on purpose since: 1. It was on review long enough (more than a week), so anyone who wanted to review it had plenty of time to do so. 2. There are no open issues. 3. The patch itself is very simple: it just checks error status after polkit authority function calls. 4. I've been using it localy on 2 different configurations for more than 2 weeks with no issues. Anyway if you have any comments regarding this patch please feel free to make a postreiew I'll gladly fix any bugs you can find! REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D5983 To: skalinichev Cc: aacid, #frameworks
D5983: Check error status after every PolKitAuthority usage
aacid added a comment. Did you commit this on purpose without the review being accepted or was it a mistake? REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D5983 To: skalinichev Cc: aacid, #frameworks
D6086: Left-click mini-map to jump to clicked area
kfunk accepted this revision.
kfunk added a comment.
This revision is now accepted and ready to land.
+1 on the behavior change, this is a much desired change :)
INLINE COMMENTS
> kateviewhelpers.cpp:204
> +if (m_leftMouseDown) {
> +int newVal = ((e->pos().y()-m_mapGroveRect.top()) /
> (double)m_mapGroveRect.height()) * (double)(maximum()+pageStep()) -
> pageStep()/2;
> +if (newVal < 0) newVal = 0;
Style: `((a - b)) / ...`
> kateviewhelpers.cpp:205
> +int newVal = ((e->pos().y()-m_mapGroveRect.top()) /
> (double)m_mapGroveRect.height()) * (double)(maximum()+pageStep()) -
> pageStep()/2;
> +if (newVal < 0) newVal = 0;
> +if (newVal > maximum()) newVal = maximum();
Use `qBound(...)`?
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D6086
To: sars, #ktexteditor, #kate, dhaumann, kfunk
Cc: kfunk, broulik, kwrite-devel, #frameworks
D6087: Haskell: Add all language pragmas as keywords.
arrowdodger edited the summary of this revision. arrowdodger edited the test plan for this revision. arrowdodger added a reviewer: Framework: Syntax Hightlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D6087 To: arrowdodger, #framework_syntax_hightlighting Cc: #frameworks
D6087: Haskell: Add all language pragmas as keywords.
arrowdodger created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D6087 AFFECTED FILES data/syntax/haskell.xml To: arrowdodger Cc: #frameworks
D6086: Left-click mini-map to jump to clicked area
broulik added a comment. Fair enough, +1 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D6086 To: sars, #ktexteditor, #kate, dhaumann Cc: broulik, kwrite-devel, #frameworks
D6086: Left-click mini-map to jump to clicked area
sars added a comment. Reasoning behind the change of behavior: - With mini-map it is seems a bit more logical to jump to the clicked place in stead of "searching your way there". (You already know where you want to go). - Page Up/Down and mouse scroll can still be used. - The middle click action is not very well known. - On Windows middle-click does nothing. - At least VisualStudio and Sublime does it like this. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D6086 To: sars, #ktexteditor, #kate, dhaumann Cc: broulik, kwrite-devel, #frameworks
D6086: Left-click mini-map to jump to clicked area
broulik added a comment. Shouldn't left click scroll up and down a bit with middle click jumping to position - that's the behavior of Qt's scroll bars. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D6086 To: sars, #ktexteditor, #kate, dhaumann Cc: broulik, kwrite-devel, #frameworks
D6086: Left-click mini-map to jump to clicked area
sars created this revision. Restricted Application added subscribers: Frameworks, kwrite-devel. Restricted Application added a project: Frameworks. REVISION SUMMARY This patch implements the jump to clicked position in "show-minimap" mode for the scrollbar. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D6086 AFFECTED FILES src/view/kateviewhelpers.cpp src/view/kateviewhelpers.h To: sars, #ktexteditor, #kate, dhaumann Cc: kwrite-devel, #frameworks
