D6701: Make ECMPoQmToolsTestactually fail if a translation is wrong
wbauer added inline comments. INLINE COMMENTS > apol wrote in check.cmake.in:79 > It should also change the other `set(fail)` calls. > > Or am I missing something? The other `set(fail)` calls *are* at the top-level and not inside a function. So, no, it doesn't make sense there. The function only goes from line#69 to #84. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D6701 To: wbauer, skelly Cc: apol, #frameworks, #build_system
D7011: Extract lineedit password
mlaurent created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Now we can use lineedit password outside kpassworddialog. It's useful in kdepim for example. TEST PLAN I added autotest and test apps. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D7011 AFFECTED FILES autotests/CMakeLists.txt autotests/kpassworddialogautotest.cpp autotests/lineeditpasswordtest.cpp autotests/lineeditpasswordtest.h src/CMakeLists.txt src/kpassworddialog.cpp src/kpassworddialog.h src/kpassworddialog.ui src/lineeditpassword.cpp src/lineeditpassword.h tests/CMakeLists.txt tests/testpasswordlineedit.cpp To: mlaurent, cfeck, dfaure Cc: #frameworks
KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 42 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/42/ Project: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 Date of build: Mon, 31 Jul 2017 02:48:58 + Build duration: 8 min 8 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 65 test(s), Skipped: 0 test(s), Total: 66 test(s)Failed: TestSuite.bug205447 build.log Description: Binary data
D6972: Add CC BY-SA 4.0 International
lueck added inline comments. INLINE COMMENTS > template.docbook:20 > > > needs update to new license REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D6972 To: ltoscano Cc: lueck, #frameworks, #documentation, skadinna
D6701: Make ECMPoQmToolsTestactually fail if a translation is wrong
apol added inline comments.
INLINE COMMENTS
> check.cmake.in:79
> message(WARNING "${name}[${lang}] output was
> \"${stripped_output}\", but expected
> \"${exp_output_${catalog_name}_${lang}}\"")
> -set(fail ON)
> +set(fail ON PARENT_SCOPE)
> else()
It should also change the other `set(fail)` calls.
Or am I missing something?
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D6701
To: wbauer, skelly
Cc: apol, #frameworks, #build_system
D6994: Allow to build KConfig without Qt5Gui
apol requested changes to this revision. apol added a subscriber: aacid. apol added a comment. This revision now requires changes to proceed. @aacid concern also applies here. I'm fine with the change as long as it's coherent. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D6994 To: vkrause, #frameworks, apol Cc: aacid
D6994: Allow to build KConfig without Qt5Gui
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D6994 To: vkrause, #frameworks, apol
D7010: KSqueezedTextLabel: call updateGeometry() when text changes
brauch added a comment. With enough dedication, probably yes ... REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D7010 To: brauch, cfeck Cc: aacid, #frameworks
D7010: KSqueezedTextLabel: call updateGeometry() when text changes
aacid added a comment. do we have autotests for this? Can they be added? REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D7010 To: brauch, cfeck Cc: aacid, #frameworks
D7010: KSqueezedTextLabel: call updateGeometry() when text changes
brauch created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY By changing the full text, the sizeHint() of the widget changes. If the text is currently squeezed, this however does not imply that the text passed to QLabel::setText() changes (which is a no-up if not). Thus we need to call updateGeometry() to notify the layout system about the size change. Otherwise, the label misbehaves when you e.g. set the size policy to Minimum and place it next to a spacer with Expanding policy, and then change the text. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D7010 AFFECTED FILES src/ksqueezedtextlabel.cpp To: brauch, cfeck Cc: #frameworks
D6990: Allow to build Sonnet without Qt5Widgets
aacid added a comment. I would really prefer if the option-ability of Widgets was enabled by a setting or something, we really want to avoid people not having widgets installed and getting a subpar build unless they really really ask for it REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D6990 To: vkrause, #frameworks, cordlandwehr Cc: aacid
D7008: Don't export internal helper executables
vkrause created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY Exporting the executables will make the cmake config file check for their presence when used, which isn't really necessary, and is actually a problem for cross-compilation, where the helper executables don't exist for the target but for the host. REPOSITORY R246 Sonnet BRANCH master REVISION DETAIL https://phabricator.kde.org/D7008 AFFECTED FILES data/CMakeLists.txt To: vkrause, #frameworks, cordlandwehr
KDE CI: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 - Build # 40 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20XenialQt5.7/40/ Project: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 Date of build: Sun, 30 Jul 2017 17:03:58 + Build duration: 7 min 30 sec and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 25 test(s), Skipped: 0 test(s), Total: 25 test(s) Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report100% (10/10)85% (79/93)85% (79/93)74% (6105/8282)43% (10616/24632)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests83% (33/40)83% (33/40)97% (2631/2718)49% (6497/13336)src.desktoptojson100% (3/3)100% (3/3)79% (84/106)38% (123/324)src.lib67% (2/3)67% (2/3)60% (326/541)27% (225/829)src.lib.caching100% (2/2)100% (2/2)45% (352/787)18% (192/1076)src.lib.io90% (9/10)90% (9/10)59% (825/1397)30% (932/3158)src.lib.jobs71% (5/7)71% (5/7)52% (159/304)39% (57/146)src.lib.plugin100% (8/8)100% (8/8)86% (646/748)44% (984/2216)src.lib.randomness100% (2/2)100% (2/2)67% (66/99)58% (44/76)src.lib.text63% (5/8)63% (5/8)46% (349/764)40% (748/1867)src.lib.util100% (10/10)100% (10/10)82% (667/818)51% (814/1604) build.log Description: Binary data
KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 - Build # 35 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/35/ Project: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 Date of build: Sun, 30 Jul 2017 17:03:58 + Build duration: 4 min 39 sec and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 22 test(s) build.log Description: Binary data
KDE CI: Frameworks bluez-qt kf5-qt5 XenialQt5.7 - Build # 14 - Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20bluez-qt%20kf5-qt5%20XenialQt5.7/14/ Project: Frameworks bluez-qt kf5-qt5 XenialQt5.7 Date of build: Sun, 30 Jul 2017 16:34:10 + Build duration: 7 min 43 sec and counting JUnit Tests Name: (root) Failed: 8 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 10 test(s)Failed: TestSuite.bluezqt-adaptertestFailed: TestSuite.bluezqt-agentmanagertestFailed: TestSuite.bluezqt-devicetestFailed: TestSuite.bluezqt-inputtestFailed: TestSuite.bluezqt-managertestFailed: TestSuite.bluezqt-mediaplayertestFailed: TestSuite.bluezqt-obexmanagertestFailed: TestSuite.bluezqt-qmltests Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report100% (3/3)48% (41/86)48% (41/86)25% (1030/4146)7% (312/4230)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (18/18)100% (18/18)49% (684/1383)8% (235/2902)src35% (19/54)35% (19/54)14% (315/2331)6% (72/1270)src.imports29% (4/14)29% (4/14)7% (31/432)9% (5/58) build.log Description: Binary data
KDE CI: Frameworks bluez-qt kf5-qt5 FreeBSDQt5.7 - Build # 15 - Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20bluez-qt%20kf5-qt5%20FreeBSDQt5.7/15/ Project: Frameworks bluez-qt kf5-qt5 FreeBSDQt5.7 Date of build: Sun, 30 Jul 2017 16:34:10 + Build duration: 2 min 22 sec and counting JUnit Tests Name: (root) Failed: 8 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: TestSuite.bluezqt-adaptertestFailed: TestSuite.bluezqt-agentmanagertestFailed: TestSuite.bluezqt-devicetestFailed: TestSuite.bluezqt-inputtestFailed: TestSuite.bluezqt-managertestFailed: TestSuite.bluezqt-mediaplayertestFailed: TestSuite.bluezqt-obexmanagertestFailed: TestSuite.bluezqt-qmltests build.log Description: Binary data
D6992: Fix build on Linux without X11
graesslin added a comment. But then the root problem of not having an ifdef branch as fallback is also not fixed. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D6992 To: vkrause, #frameworks, bshah, graesslin Cc: graesslin, bshah
D6992: Fix build on Linux without X11
vkrause added a comment. I agree on this needing runtime rather than compile-time selection code. I disagree on this not happening in reality though, the KF5 Yocto recipes assume there is no X11, which is why I ran into this in the first place :) REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D6992 To: vkrause, #frameworks, bshah, graesslin Cc: graesslin, bshah
D6992: Fix build on Linux without X11
graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. Sorry to say, but the approach is wrong in general. The problem is that the platform is runtime selected and not compile time. This patch fixes a very special case which does not exist in reality: distros build with both X11 and Wayland. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D6992 To: vkrause, #frameworks, bshah, graesslin Cc: graesslin, bshah
Re: Review Request 127111: kurlnavigator: add new signal selectParentOfPreviousUrl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127111/ --- (Updated July 30, 2017, 5:32 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, Emmanuel Pescosta and Frank Reininghaus. Changes --- Submitted with commit fa6bad3be579ec89c8126b00438234d0bc16c508 by Gregor Mi to branch master. Bugs: 335616 https://bugs.kde.org/show_bug.cgi?id=335616 Repository: kio Description --- Moved logic from https://git.reviewboard.kde.org/r/123253 to here. Provides a signal to implement bug https://bugs.kde.org/show_bug.cgi?id=335616: "Dolphin: Navigate to parent folder selects child folder". Diffs - autotests/CMakeLists.txt 83b7b73b4b92e09076ece2d4618559ddb8089368 autotests/urlutiltest.cpp PRE-CREATION src/filewidgets/kurlnavigator.h ff155c7bbdc8c72f579f730993286a4dccae6338 src/filewidgets/kurlnavigator.cpp 033046f06dd5bea3f4124669c55803aba3a31789 src/filewidgets/urlutil_p.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/127111/diff/ Testing --- Thanks, Gregor Mi
D6994: Allow to build KConfig without Qt5Gui
vkrause created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY This is particularly useful for cross-compilation, where we only need the kconfig_compiler on the host system. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D6994 AFFECTED FILES CMakeLists.txt autotests/CMakeLists.txt src/CMakeLists.txt src/core/CMakeLists.txt src/gui/CMakeLists.txt src/kconf_update/CMakeLists.txt src/kconfig_compiler/CMakeLists.txt To: vkrause, #frameworks
KDE CI: Frameworks kconfig kf5-qt5 FreeBSDQt5.7 - Build # 19 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20FreeBSDQt5.7/19/ Project: Frameworks kconfig kf5-qt5 FreeBSDQt5.7 Date of build: Sun, 30 Jul 2017 13:43:24 + Build duration: 1 min 1 sec and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 35 test(s), Skipped: 0 test(s), Total: 35 test(s) build.log Description: Binary data
D6992: Fix build on Linux without X11
vkrause updated this revision to Diff 17388. REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6992?vs=17387=17388 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6992 AFFECTED FILES CMakeLists.txt src/config-kcrash.h.cmake src/kcrash.cpp To: vkrause, #frameworks, bshah Cc: bshah
D6992: Fix build on Linux without X11
bshah added a comment. Also, you will need to make similar change on kinit.cpp in kinit. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D6992 To: vkrause, #frameworks, bshah Cc: bshah
D6992: Fix build on Linux without X11
bshah requested changes to this revision. bshah added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kcrash.cpp:272 > return "WIN_DISPLAY"; > +#else > +return "WAYLAND_DISPLAY"; That sounds wrong.. possibly you have to check if HAVE_WAYLAND is true.. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D6992 To: vkrause, #frameworks, bshah Cc: bshah
D6992: Fix build on Linux without X11
vkrause created this revision. Restricted Application added a project: Frameworks. REPOSITORY R285 KCrash BRANCH master REVISION DETAIL https://phabricator.kde.org/D6992 AFFECTED FILES src/kcrash.cpp To: vkrause, #frameworks
D6976: Make ECM a dependency for all frameworks
This revision was automatically updated to reflect the committed changes. Closed by commit R868:ee7c296202da: Make ECM a dependency for all frameworks (authored by vkrause). REPOSITORY R868 Yocto: KDE Frameworks Packaging CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6976?vs=17353=17381 REVISION DETAIL https://phabricator.kde.org/D6976 AFFECTED FILES classes/cmake_kf5.bbclass recipes-kf5/tier1/karchive.inc To: vkrause, cordlandwehr Cc: #frameworks
D6990: Allow to build Sonnet without Qt5Widgets
vkrause created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY This is useful for cross-compilation, where we only need the QtCore-only parsetrigrams build tool on the host and avoids having to pull in a full graphics stack for the host build in Yocto. REPOSITORY R246 Sonnet BRANCH master REVISION DETAIL https://phabricator.kde.org/D6990 AFFECTED FILES CMakeLists.txt src/CMakeLists.txt To: vkrause, #frameworks, cordlandwehr
D6976: Make ECM a dependency for all frameworks
cordlandwehr accepted this revision. This revision is now accepted and ready to land. REPOSITORY R868 Yocto: KDE Frameworks Packaging BRANCH master REVISION DETAIL https://phabricator.kde.org/D6976 To: vkrause, cordlandwehr Cc: #frameworks
