D7533: KIO: port the URI filter plugins from KServiceTypeTrader to json+KPluginMetaData

[Bhushan Shah]

bshah added a comment.


  In https://phabricator.kde.org/D7533#140680, @dfaure wrote:
  
  > Ah, phabricator is strange, I have indeed modified the commit log before 
doing `arc diff` but it didn't update it here.
  
  
  And it also did overwrite your change in actual commit message it seems 
*shrug*

REVISION DETAIL
  https://phabricator.kde.org/D7533

To: dfaure, apol, davidedmundson, arichardson, bshah
Cc: vandenoever, elvisangelaccio, bshah, #frameworks

D7580: Support loading by stream and restoring state on reload

[Friedrich W . H . Kossebau]

kossebau created this revision.

REVISION SUMMARY
  The KTextEditor preview plugin* repeatedly feeds new
  versions to the same kpart instance, to allow instant
  preview of changes. To avoid stressing of the filesystem
  the stream API of the kpart is used if available.
  *https://frinring.wordpress.com/2017/08/21/look-what-you-have-donewwdo/
  
  This patch adds support for the stream API.
  Additionally it remembers the view state on closing an url,
  and if the same url is load again, the view state is restored.
  The latter allows continuous display of the same, but
  updated file as e.g. happening with the preview plugin.
  
  Open questions:
  a) use of the streaming API matching intentions?
  b) Restoring of view state overlaps with support in browser history,
  
for which there is the KParts::OpenUrlArguments property of ReadOnlyPart.
That one only supports x/y offset, so how would zoom and other custom
state properties be save and retrieved again, if they should?
  
  This patch should help to solve this questions in general, so it is
  known what to do for other kparts.

TEST PLAN
  Editing SVG files in Kate/Kdevelop using the preview plugin* will
  no longer reset the offset to 0,0 each time the view is updated on
  changes, also is the filesystem no longer used on updates.
  
  - kde:scratch/kossebau/ktexteditorpreviewplugin

REPOSITORY
  R383 SVGPart

BRANCH
  supportstreamandreload

REVISION DETAIL
  https://phabricator.kde.org/D7580

AFFECTED FILES
  svgpart.cpp
  svgpart.h

To: kossebau, #frameworks, dfaure

D7446: Add a Recent Documents places item to Dolphin and file pickers by default

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7446

To: ngraham, #dolphin, #kde_applications
Cc: #frameworks, broulik, elvisangelaccio, dfaure, davidedmundson, ltoscano, 
#konqueror, navarromorales, firef, andrebarros, emmanuelp

D7446: Add a Recent Documents places item to Dolphin and file pickers by default

[Nathaniel Graham]

ngraham updated this revision to Diff 18867.
ngraham added a comment.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.


  This update implements the following requested changes:
  
  1. Located after Home bookmark and before Trash bookmark
  2. Moved to KIO's `kfileplacesmodel.cpp`, which makes it appear in file 
pickers as well

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7446?vs=18468=18867

REVISION DETAIL
  https://phabricator.kde.org/D7446

AFFECTED FILES
  src/filewidgets/kfileplacesmodel.cpp

To: ngraham, #dolphin, #kde_applications
Cc: #frameworks, broulik, elvisangelaccio, dfaure, davidedmundson, ltoscano, 
#konqueror, navarromorales, firef, andrebarros, emmanuelp

D7407: audiocd-kio : modernise debugging

[Luigi Toscano]

ltoscano added inline comments.

INLINE COMMENTS

> CMakeLists.txt:84
>  set(kio_audiocd_PART_SRCS audiocd.cpp )
> +ecm_qt_declare_logging_category(kio_audiocd_PART_SRCS HEADER logging.h 
> IDENTIFIER AUDIOCD CATEGORY_NAME kf5.kio.audiocd)
>  

I would follow a bit more the (unwritten, but used) convention from other 
projects:

Please use org.kde; kf5, so far, has mostly been used for Framworks.

I'd suggest to call the generated file _logging (or 
_debug) as it was done elsewhere.

And the identifier could be AUDIOCD_LOG as well.

> audiocd.cpp:59
>  #include 
> +#include 
>  #include 

Is this needed when the generated logging header is included?

REPOSITORY
  R342 KIO AudioCD

REVISION DETAIL
  https://phabricator.kde.org/D7407

To: rjvbb, #frameworks
Cc: ltoscano

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.9 - Build # 14 - Still Failing!

[no-reply]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.9/14/
 Project:
Frameworks kio kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Sun, 27 Aug 2017 21:18:44 +
 Build duration:
6 min 5 sec and counting
   CONSOLE OUTPUT
  Started by an SCM change[Pipeline] nodeRunning on Windows Builder 2 in C:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] deleteDir[Pipeline] }[Pipeline] // stage[Pipeline] }java.nio.file.FileSystemException: C:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9\build\autotests: The process cannot access the file because it is being used by another process.	at sun.nio.fs.WindowsException.translateToIOException(Unknown Source)	at sun.nio.fs.WindowsException.rethrowAsIOException(Unknown Source)	at sun.nio.fs.WindowsException.rethrowAsIOException(Unknown Source)	at sun.nio.fs.WindowsFileSystemProvider.implDelete(Unknown Source)	at sun.nio.fs.AbstractFileSystemProvider.deleteIfExists(Unknown Source)	at java.nio.file.Files.deleteIfExists(Unknown Source)	at hudson.Util.tryOnceDeleteFile(Util.java:290)	at hudson.Util.deleteFile(Util.java:245)	at hudson.FilePath.deleteRecursive(FilePath.java:1211)	at hudson.FilePath.deleteContentsRecursive(FilePath.java:1220)	at hudson.FilePath.deleteRecursive(FilePath.java:1202)	at hudson.FilePath.deleteContentsRecursive(FilePath.java:1220)	at hudson.FilePath.deleteRecursive(FilePath.java:1202)	at hudson.FilePath.access$1000(FilePath.java:197)	at hudson.FilePath$14.invoke(FilePath.java:1181)	at hudson.FilePath$14.invoke(FilePath.java:1178)	at hudson.FilePath$FileCallableWrapper.call(FilePath.java:2750)	at hudson.remoting.UserRequest.perform(UserRequest.java:181)	at hudson.remoting.UserRequest.perform(UserRequest.java:52)	at hudson.remoting.Request$2.run(Request.java:336)	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68)	at java.util.concurrent.FutureTask.run(Unknown Source)	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)	at hudson.remoting.Engine$1$1.run(Engine.java:98)	at java.lang.Thread.run(Unknown Source)Caused: java.io.IOException: Unable to delete 'C:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9\build\autotests'. Tried 3 times (of a maximum of 3) waiting 0.1 sec between attempts.	at hudson.Util.deleteFile(Util.java:250)	at hudson.FilePath.deleteRecursive(FilePath.java:1211)	at hudson.FilePath.deleteContentsRecursive(FilePath.java:1220)	at hudson.FilePath.deleteRecursive(FilePath.java:1202)	at hudson.FilePath.deleteContentsRecursive(FilePath.java:1220)	at hudson.FilePath.deleteRecursive(FilePath.java:1202)	at hudson.FilePath.access$1000(FilePath.java:197)	at hudson.FilePath$14.invoke(FilePath.java:1181)	at hudson.FilePath$14.invoke(FilePath.java:1178)	at hudson.FilePath$FileCallableWrapper.call(FilePath.java:2750)	at hudson.remoting.UserRequest.perform(UserRequest.java:181)	at hudson.remoting.UserRequest.perform(UserRequest.java:52)	at hudson.remoting.Request$2.run(Request.java:336)	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68)	at java.util.concurrent.FutureTask.run(Unknown Source)	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)	at hudson.remoting.Engine$1$1.run(Engine.java:98)	at java.lang.Thread.run(Unknown Source)	at ..remote call to JNLP4-connect connection from katze.kde.org/5.9.99.173:58265(Native Method)	at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1554)	at hudson.remoting.UserResponse.retrieve(UserRequest.java:281)	at hudson.remoting.Channel.call(Channel.java:839)	at hudson.FilePath.act(FilePath.java:987)Caused: java.io.IOException: remote file operation failed: C:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9 at hudson.remoting.Channel@4f128057:JNLP4-connect connection from katze.kde.org/5.9.99.173:58265	at hudson.FilePath.act(FilePath.java:994)	at hudson.FilePath.act(FilePath.java:976)	at hudson.FilePath.deleteRecursive(FilePath.java:1178)	at org.jenkinsci.plugins.workflow.steps.DeleteDirStep$Execution.run(DeleteDirStep.java:77)	at org.jenkinsci.plugins.workflow.steps.DeleteDirStep$Execution.run(DeleteDirStep.java:69)	at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution$1$1.call(SynchronousNonBlockingStepExecution.java:49)	at hudson.security.ACL.impersonate(ACL.java:260)	at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution$1.run(SynchronousNonBlockingStepExecution.java:46)	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)	at java.util.concurrent.FutureTask.run(FutureTask.java:266)	at 

D7530: KIO: Task should be used in QVector, not QList.

[Milian Wolff]

mwolff accepted this revision.
This revision is now accepted and ready to land.

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7530

To: dfaure, mwolff
Cc: #frameworks

D7529: KIO: fix long-standing memory leak on exit.

[Milian Wolff]

mwolff accepted this revision.
mwolff added a comment.
This revision is now accepted and ready to land.


  lgtm, despite the `delete this`: 
https://isocpp.org/wiki/faq/freestore-mgmt#delete-this, esp. if you have proper 
unit tests and ran it through valgrind

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7529

To: dfaure, mwolff
Cc: #frameworks

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.9 - Build # 13 - Failure!

[no-reply]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.9/13/
 Project:
Frameworks kio kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Sun, 27 Aug 2017 20:23:18 +
 Build duration:
4 min 1 sec and counting
   CONSOLE OUTPUT
  Started by an SCM change[Pipeline] nodeRunning on Windows Builder 1 in C:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] deleteDir[Pipeline] }[Pipeline] // stage[Pipeline] }java.nio.file.FileSystemException: C:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9\build\autotests: The process cannot access the file because it is being used by another process.	at sun.nio.fs.WindowsException.translateToIOException(Unknown Source)	at sun.nio.fs.WindowsException.rethrowAsIOException(Unknown Source)	at sun.nio.fs.WindowsException.rethrowAsIOException(Unknown Source)	at sun.nio.fs.WindowsFileSystemProvider.implDelete(Unknown Source)	at sun.nio.fs.AbstractFileSystemProvider.deleteIfExists(Unknown Source)	at java.nio.file.Files.deleteIfExists(Unknown Source)	at hudson.Util.tryOnceDeleteFile(Util.java:290)	at hudson.Util.deleteFile(Util.java:245)	at hudson.FilePath.deleteRecursive(FilePath.java:1211)	at hudson.FilePath.deleteContentsRecursive(FilePath.java:1220)	at hudson.FilePath.deleteRecursive(FilePath.java:1202)	at hudson.FilePath.deleteContentsRecursive(FilePath.java:1220)	at hudson.FilePath.deleteRecursive(FilePath.java:1202)	at hudson.FilePath.access$1000(FilePath.java:197)	at hudson.FilePath$14.invoke(FilePath.java:1181)	at hudson.FilePath$14.invoke(FilePath.java:1178)	at hudson.FilePath$FileCallableWrapper.call(FilePath.java:2750)	at hudson.remoting.UserRequest.perform(UserRequest.java:181)	at hudson.remoting.UserRequest.perform(UserRequest.java:52)	at hudson.remoting.Request$2.run(Request.java:336)	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68)	at java.util.concurrent.FutureTask.run(Unknown Source)	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)	at hudson.remoting.Engine$1$1.run(Engine.java:98)	at java.lang.Thread.run(Unknown Source)Caused: java.io.IOException: Unable to delete 'C:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9\build\autotests'. Tried 3 times (of a maximum of 3) waiting 0.1 sec between attempts.	at hudson.Util.deleteFile(Util.java:250)	at hudson.FilePath.deleteRecursive(FilePath.java:1211)	at hudson.FilePath.deleteContentsRecursive(FilePath.java:1220)	at hudson.FilePath.deleteRecursive(FilePath.java:1202)	at hudson.FilePath.deleteContentsRecursive(FilePath.java:1220)	at hudson.FilePath.deleteRecursive(FilePath.java:1202)	at hudson.FilePath.access$1000(FilePath.java:197)	at hudson.FilePath$14.invoke(FilePath.java:1181)	at hudson.FilePath$14.invoke(FilePath.java:1178)	at hudson.FilePath$FileCallableWrapper.call(FilePath.java:2750)	at hudson.remoting.UserRequest.perform(UserRequest.java:181)	at hudson.remoting.UserRequest.perform(UserRequest.java:52)	at hudson.remoting.Request$2.run(Request.java:336)	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68)	at java.util.concurrent.FutureTask.run(Unknown Source)	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)	at hudson.remoting.Engine$1$1.run(Engine.java:98)	at java.lang.Thread.run(Unknown Source)	at ..remote call to JNLP4-connect connection from ange.kde.org/144.76.172.7:57409(Native Method)	at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1554)	at hudson.remoting.UserResponse.retrieve(UserRequest.java:281)	at hudson.remoting.Channel.call(Channel.java:839)	at hudson.FilePath.act(FilePath.java:987)Caused: java.io.IOException: remote file operation failed: C:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9 at hudson.remoting.Channel@57ff14ca:JNLP4-connect connection from ange.kde.org/144.76.172.7:57409	at hudson.FilePath.act(FilePath.java:994)	at hudson.FilePath.act(FilePath.java:976)	at hudson.FilePath.deleteRecursive(FilePath.java:1178)	at org.jenkinsci.plugins.workflow.steps.DeleteDirStep$Execution.run(DeleteDirStep.java:77)	at org.jenkinsci.plugins.workflow.steps.DeleteDirStep$Execution.run(DeleteDirStep.java:69)	at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution$1$1.call(SynchronousNonBlockingStepExecution.java:49)	at hudson.security.ACL.impersonate(ACL.java:260)	at org.jenkinsci.plugins.workflow.steps.SynchronousNonBlockingStepExecution$1.run(SynchronousNonBlockingStepExecution.java:46)	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)	at java.util.concurrent.FutureTask.run(FutureTask.java:266)	at 

D7527: Add mimetype filtering capabilities to KUrlCompletion

[Milian Wolff]

mwolff added a comment.


  In https://phabricator.kde.org/D7527#139670, @dfaure wrote:
  
  > Almost perfect ;-)
  
  
  Indeed, should have reviewed it closer myself. Fixed and pushed - thanks for 
the review David!

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7527

To: mwolff, dfaure
Cc: #frameworks

D7527: Add mimetype filtering capabilities to KUrlCompletion

[Milian Wolff]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:1a92575c73d2: Add mimetype filtering capabilities to 
KUrlCompletion (authored by mwolff).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D7527?vs=18718=18861#toc

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7527?vs=18718=18861

REVISION DETAIL
  https://phabricator.kde.org/D7527

AFFECTED FILES
  autotests/kurlcompletiontest.cpp
  src/widgets/kurlcompletion.cpp
  src/widgets/kurlcompletion.h
  src/widgets/kurlrequester.cpp
  tests/kurlrequestertest_gui.cpp

To: mwolff, dfaure
Cc: #frameworks

D7533: KIO: port the URI filter plugins from KServiceTypeTrader to json+KPluginMetaData

[David Faure]

dfaure closed this revision.

REVISION DETAIL
  https://phabricator.kde.org/D7533

To: dfaure, apol, davidedmundson, arichardson, bshah
Cc: vandenoever, elvisangelaccio, bshah, #frameworks

D7533: KIO: port the URI filter plugins from KServiceTypeTrader to json+KPluginMetaData

[David Faure]

dfaure added a comment.


  Ah, phabricator is strange, I have indeed modified the commit log before 
doing `arc diff` but it didn't update it here.

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7533

To: dfaure, apol, davidedmundson, arichardson, bshah
Cc: vandenoever, elvisangelaccio, bshah, #frameworks

Re: relocatable kdoctools

[Luigi Toscano]

Harald Sitter wrote:
> On Tue, Aug 22, 2017 at 10:18 PM, Luigi Toscano
>  wrote:
>> Harald Sitter wrote:

>>> The reason this puzzles me is that the relocatable code for Windows
>>> would work just fine for Linux and OSX, from what I can tell there is
>>> no real downside to it besides the additional code, which we need
>>> anyway. On the other hand, the conditional treatment of Windows gives
>>> the Windows code branch substantially less implicit run exposure (i.e.
>>> most devs/testers aren't on Windows, so fewer people build the
>>> relevant if-branch).
>>>
>>> With that in mind: how about we drop the harcoding code path and make
>>> the Windows code path the default and have kdoctools assets always be
>>> relocatable?
>>
>> No problem with relocatable code, in general, but my personal problem with
>> that code is that I have to rethink every time what it's doing and think 
>> twice
>> when I had to change it (as I did now with the review above), because of the
>> way it works. It may be a limitation of mine, but is there some way to make
>> what it's trying to do in a more simple way?
> 
> Mh, yes. Relativity calculation is always a strain on the mind for
> sure. The way I see it this is fairly isolated in the cmake logic
> though and ideally only needs figuring out once, so it shouldn't need
> changes that often? I mean, from a usage point of view when working on
> a dtd or xsl you use the same cmake-level variable regardless of the
> path being absolute or relative anyway. On the cmake-level the
> principal difference between absolute and relative is that the
> variable is converted into a relative one using a `file(RELATIVE_PATH
> ...)` call.
> 
> Do you have a specific example of where you had trouble wrapping your
> head around it?
> 
> FWIW, I think the cmake code at hand would actually be easier on the
> eyes without the if branch and some simplification. If there are no
> objections to turning the build relocatable by default I'll go ahead
> and prepare a diff for review. Then we can talk about tweaking that
> should it be necessary.

Even without the if branch it would be still complicated. But I have no
objections to discuss and approve a patch which unifies the code and also
avoids that opensuse-specific patch.

Ciao
-- 
Luigi

D7479: klauncher: fix appId matching for flatpak apps

[Elvis Angelaccio]

This revision was automatically updated to reflect the committed changes.
Closed by commit R303:1ebdf8ea6ac1: klauncher: fix appId matching for flatpak 
apps (authored by elvisangelaccio).

REPOSITORY
  R303 KInit

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7479?vs=18758=18856

REVISION DETAIL
  https://phabricator.kde.org/D7479

AFFECTED FILES
  src/klauncher/klauncher.cpp

To: elvisangelaccio, dfaure, apol
Cc: #frameworks

D7401: Solid/Mac : fleshing out the skeleton IOKit backend (WIP)

[Gilles Caulier]

cgilles added a comment.


  I don't yet tested, i'm currently busy to prepare digiKam 5.7.0, to review 
last code from GSoC 2017 students, and to prepare Randa event tasks.
  
  Do you come to Randa ? If yes, we can take a look together while the event...
  
  Gilles

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D7401

To: rjvbb, #frameworks
Cc: cgilles, kde-mac

D7401: Solid/Mac : fleshing out the skeleton IOKit backend (WIP)

[René J . V . Bertin]

rjvbb added a comment.


  I can commit it anytime, as soon as I get a green light (within a reasonable 
amount of time). Have you tested it?
  
  I expect that the only possible risk with these modifications is that they 
might break the build itself on newer OS versions than I have myself. Other 
than that I don't think there's any code currently that relies on the existing 
Mac support in Solid...

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D7401

To: rjvbb, #frameworks
Cc: cgilles, kde-mac

D7563: Add privilegeExecution field to file protocol description

[Chinmoy Ranjan Pradhan]

chinmoyr added a dependent revision: D7571: Enable modifying root-owned files 
in Dolphin.

REVISION DETAIL
  https://phabricator.kde.org/D7563

To: chinmoyr, #frameworks, dfaure
Cc: elvisangelaccio

D7401: Solid/Mac : fleshing out the skeleton IOKit backend (WIP)

[Gilles Caulier]

cgilles added a comment.


  Rene, this is a great improvement for MacOS support. Congratualtions.
  
  When code will be add to KDE::Solid framework ?
  
  Best
  
  Gilles Caulier

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D7401

To: rjvbb, #frameworks
Cc: cgilles, kde-mac

KDE CI: Frameworks syntax-highlighting kf5-qt5 WindowsMSVCQt5.9 - Build # 9 - Fixed!

[no-reply]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20WindowsMSVCQt5.9/9/
 Project:
Frameworks syntax-highlighting kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Sun, 27 Aug 2017 10:28:29 +
 Build duration:
7 min 18 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 8 test(s)

build.log
Description: Binary data

D7533: KIO: port the URI filter plugins from KServiceTypeTrader to json+KPluginMetaData

[Bhushan Shah]

bshah accepted this revision.
bshah added a comment.
This revision is now accepted and ready to land.


  Looks good to me.
  
  (Maybe modify the commit message to remove the priority int/string bits)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7533

To: dfaure, apol, davidedmundson, arichardson, bshah
Cc: vandenoever, elvisangelaccio, bshah, #frameworks

KDE CI: Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.7 - Build # 83 - Fixed!

[no-reply]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20FreeBSDQt5.7/83/
 Project:
Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.7
 Date of build:
Sun, 27 Aug 2017 10:02:55 +
 Build duration:
1 min 37 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 8 test(s)

build.log
Description: Binary data

D7484: Add highlight definition for Tiger

[Dominik Haumann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:b3d7d9cd02f6: Add highlight definition for Tiger 
(authored by dhaumann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7484?vs=18664=18837

REVISION DETAIL
  https://phabricator.kde.org/D7484

AFFECTED FILES
  autotests/folding/highlight.tig.fold
  autotests/html/highlight.tig.html
  autotests/input/highlight.tig
  autotests/reference/highlight.tig.ref
  data/syntax/tiger.xml

To: pablooliveira, dhaumann
Cc: #frameworks, cullmann, vkrause, dhaumann

KDE CI: Frameworks kirigami kf5-qt5 WindowsMSVCQt5.9 - Build # 17 - Fixed!

[no-reply]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20WindowsMSVCQt5.9/17/
 Project:
Frameworks kirigami kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Sun, 27 Aug 2017 07:57:29 +
 Build duration:
2 min 36 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

build.log
Description: Binary data

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 58 - Still Unstable!

[no-reply]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/58/
 Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
 Date of build:
Sun, 27 Aug 2017 07:57:29 +
 Build duration:
34 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests

build.log
Description: Binary data

KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 62 - Still Unstable!

[no-reply]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/62/
 Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
 Date of build:
Sun, 27 Aug 2017 07:57:29 +
 Build duration:
1 min 1 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.qmltests
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

build.log
Description: Binary data