KDE CI: Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.9 - Build # 25 - Still unstable!

[no-reply]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20WindowsMSVCQt5.9/25/
 Project:
Frameworks plasma-framework kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Fri, 15 Sep 2017 03:05:10 +
 Build duration:
51 min and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.coronatestFailed: TestSuite.plasma-dialogstatetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetestFailed: TestSuite.plasma-themetest

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 71 - Still Unstable!

[no-reply]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/71/
 Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7
 Date of build:
Fri, 15 Sep 2017 03:04:40 +
 Build duration:
22 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 65 test(s), Skipped: 0 test(s), Total: 66 test(s)Failed: TestSuite.kateindenttest_testCstyle

KDE CI: Frameworks plasma-framework kf5-qt5 XenialQt5.7 - Build # 107 - Still Unstable!

[no-reply]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20XenialQt5.7/107/
 Project:
Frameworks plasma-framework kf5-qt5 XenialQt5.7
 Date of build:
Fri, 15 Sep 2017 03:05:10 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report86%
(6/7)62%
(57/92)62%
(57/92)38%
(3492/9218)26%
(1857/7148)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(22/22)100%
(22/22)76%
(607/795)38%
(390/1028)src.declarativeimports.core57%
(4/7)57%
(4/7)28%
(245/880)14%
(85/618)src.plasma62%
(13/21)62%
(13/21)40%
(1412/3572)29%
(772/2695)src.plasma.private46%
(11/24)46%
(11/24)39%
(649/1649)28%
(303/1080)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/190)0%
(0/126)src.plasmaquick50%
(6/12)50%
(6/12)27%
(548/2019)19%
(301/1579)src.plasmaquick.private33%
(1/3)33%
(1/3)27%
(31/113)27%
(6/22)

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 - Build # 111 - Still Unstable!

[no-reply]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/111/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7
 Date of build:
Fri, 15 Sep 2017 03:05:10 +
 Build duration:
9 min 28 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

KDE CI: Frameworks kirigami kf5-qt5 XenialQt5.7 - Build # 81 - Still Unstable!

[no-reply]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/81/
 Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
 Date of build:
Fri, 15 Sep 2017 03:03:55 +
 Build duration:
2 min 18 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.qmltests
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  Cobertura Coverage Report

KDE CI: Frameworks kirigami kf5-qt5 FreeBSDQt5.7 - Build # 77 - Still Unstable!

[no-reply]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/77/
 Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
 Date of build:
Fri, 15 Sep 2017 03:03:55 +
 Build duration:
51 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: TestSuite.qmltests

D7828: createKMessageBox tries to focus a default button when available

[Albert Astals Cid]

aacid added a comment.


  This should come with an autotest

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D7828

To: emateli, #frameworks
Cc: aacid, #frameworks

D6233: KKeyServer: fix handling of KeypadModifier.

[David Faure]

dfaure added a comment.


  Alt+Shift+right bug fixed in https://phabricator.kde.org/D7829
  
  Meta+Shift+Print is another issue, I get 
   KGlobalAccelImpl::grabKey: keyQt (0x 100011e ) failed to resolve to x11 
keycode
  and
   KGlobalAccelImpl::x11KeyPress: keyQt= "130a" "Meta+Shift+SysReq"

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D6233

To: dfaure, graesslin
Cc: broulik, martinkostolny, bcooksley, graesslin, #frameworks

D7828: createKMessageBox tries to focus a default button when available

[Emirald Mateli]

emateli edited the summary of this revision.
emateli edited the test plan for this revision.
emateli added a reviewer: Frameworks.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D7828

To: emateli, #frameworks
Cc: #frameworks

D7829: Fix kglobalaccel regression on Alt+Shift+arrowkey.

[Kai Uwe Broulik]

broulik added a comment.


  Doesn't fix Meta+Shift+PrintScr for me

REVISION DETAIL
  https://phabricator.kde.org/D7829

To: dfaure, graesslin, jriddell, martinkostolny, broulik
Cc: #frameworks

D7829: Fix kglobalaccel regression on Alt+Shift+arrowkey.

[David Faure]

dfaure created this revision.

REVISION SUMMARY
  When keysym1 (i.e. with shift) is 0, then we must use keysym0 (the version 
without shift) in any case.

TEST PLAN
  Adding a global shortcut with Alt+Shift+Right works now.
  Previously it would decode it at "Alt+" at keypress time.

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7829

AFFECTED FILES
  src/platforms/xcb/kkeyserver.cpp

To: dfaure, graesslin, jriddell, martinkostolny, broulik
Cc: #frameworks

D7828: createKMessageBox tries to focus a default button when available

[Emirald Mateli]

emateli created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  createKMessageBox-btn-focus

REVISION DETAIL
  https://phabricator.kde.org/D7828

AFFECTED FILES
  src/kmessagebox.cpp

To: emateli
Cc: #frameworks

KDE CI: Frameworks kwindowsystem kf5-qt5 XenialQt5.7 - Build # 30 - Still Unstable!

[no-reply]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20XenialQt5.7/30/
 Project:
Frameworks kwindowsystem kf5-qt5 XenialQt5.7
 Date of build:
Thu, 14 Sep 2017 20:52:56 +
 Build duration:
8 min 57 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.kwindowsystem-compositingenabled_testFailed: TestSuite.kwindowsystem-kwindoweffectstestFailed: TestSuite.kwindowsystem-kwindowinfox11testFailed: TestSuite.kwindowsystem-kwindowsystem_threadtestFailed: TestSuite.kwindowsystem-kwindowsystemplatformwaylandtestFailed: TestSuite.kwindowsystem-kwindowsystemx11testFailed: TestSuite.kwindowsystem-netrootinfotestwm
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report75%
(3/4)80%
(35/44)80%
(35/44)71%
(5680/8023)47%
(2989/6308)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(15/15)100%
(15/15)84%
(2556/3036)43%
(1335/3129)src69%
(11/16)69%
(11/16)50%
(715/1434)36%
(258/712)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/89)0%
(0/2)src.platforms.xcb82%
(9/11)82%
(9/11)70%
(2409/3464)57%
(1396/2465)

KDE CI: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.7 - Build # 29 - Still Unstable!

[no-reply]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20FreeBSDQt5.7/29/
 Project:
Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.7
 Date of build:
Thu, 14 Sep 2017 20:52:56 +
 Build duration:
4 min 5 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: TestSuite.kwindowsystem-netrootinfotestwm

D6233: KKeyServer: fix handling of KeypadModifier.

[David Faure]

dfaure added a comment.


  Thanks for the reports. These shortcuts get converted correctly 
(https://commits.kde.org/kwindowsystem/af6d5ab12b2d99b39a73ed8df903368470ded55b),
 so the problem must be in the shift handling in xcbKeyPressEventToQt().

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D6233

To: dfaure, graesslin
Cc: broulik, martinkostolny, bcooksley, graesslin, #frameworks

D7827: Syntax indexer: Catch invalid a-Z/A-Z ranges in regexps

[Dominik Haumann]

dhaumann created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  Motivated by incorrect regular expressions of the form [a-zA-z] or [a-Z], 
this patch extends the highlighting indexer to check for this kind of errors. 
This, however, is only a heuristic, so theoretically, we may have false 
positives. This is not an issue so far, though. In fact, this check detects two 
more issues, which are fixed with this change as well.

TEST PLAN
  make test

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D7827

AFFECTED FILES
  data/syntax/bitbake.xml
  data/syntax/haml.xml
  src/indexer/katehighlightingindexer.cpp

To: dhaumann, #framework_syntax_highlighting, gregsteuck, vkrause, cullmann
Cc: #frameworks

D7792: Fixing incorrectly capitalized regexps

[Dominik Haumann]

dhaumann closed this revision.
dhaumann added a comment.


  Committed with 
https://cgit.kde.org/syntax-highlighting.git/commit/?id=212e6db4bbbaec14bb56a8b608f5cf0b7e2b0f4b

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D7792

To: gregsteuck, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, #frameworks

D7823: Add FindGLIB2.cmake and FindPulseAudio.cmake to ECM

[Jonathan Marten]

marten added a comment.


  It's the same source really - the only differences between those in 
kdelibs4support and ecm/attic are that the former uses endif(same_as_if) and 
the latter uses endif().
  Nothing else within Frameworks, Plasma or applications uses anything from 
ecm/attic directly.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D7823

To: marten, #frameworks, #build_system
Cc: cfeck, heikobecker

D7823: Add FindGLIB2.cmake and FindPulseAudio.cmake to ECM

[Christoph Feck]

cfeck added a comment.


  In other words, your suggestion is not to add it to ecm, but to move it from 
attic/modules to find-modules.
  
  That raises the question, how one is supposed to use the attic modules, 
without copying them manually.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D7823

To: marten, #frameworks, #build_system
Cc: cfeck, heikobecker

D7823: Add FindGLIB2.cmake and FindPulseAudio.cmake to ECM

[Jonathan Marten]

marten added a subscriber: heikobecker.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D7823

To: marten, #frameworks, #build_system
Cc: heikobecker

D7823: Add FindGLIB2.cmake and FindPulseAudio.cmake to ECM

[Jonathan Marten]

marten created this revision.
Restricted Application added projects: Frameworks, Build System.

REVISION SUMMARY
  These modules are used in a number of places within Frameworks, Plasma and 
dependencies:
  
  FindGLIB2:
  
plasma-desktop/applets/kimpanel/cmake/FindGLIB2.cmake
kdelibs4support/cmake/modules/FindGLIB2.cmake
ecm/attic/modules/FindGLIB2.cmake
phonon/cmake/FindGLIB2.cmake
polkit-qt/cmake/modules/FindGLIB2.cmake
  
  FindPulseAudio:
  
kdelibs4support/cmake/modules/FindPulseAudio.cmake
ecm/attic/modules/FindPulseAudio.cmake
phonon/cmake/FindPulseAudio.cmake
  
  Apart from those in Phonon, each set is all the same apart from minor 
formatting differences.
  
  These two modules will also be required by KMix when it is finally ported 
away from KDElibs4Support.  Since these common files are used in multiple 
places, it makes sense to have them included in ECM instead of making local 
copies.

TEST PLAN
  Built and installed ECM with these two modules added, configured KMix with 
KDELibs4Support removed.
  GLIB2 and PulseAudio are found correctly using the modules installed by ECM.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D7823

AFFECTED FILES
  find-modules/FindGLIB2.cmake
  find-modules/FindPulseAudio.cmake

To: marten, #frameworks, #build_system

D7699: Add support for custom search paths for application-specific syntax and theme definitions

[Michael Hansen]

zrax added a comment.


  Is anything else needed for this?  I'm assuming installing the indexer would 
go as a separate review and that nobody is waiting for me to add that here...

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D7699

To: zrax, #kate, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, vkrause, cullmann, #framework_syntax_highlighting, #frameworks

D7819: Add extra visual indicator for Checkbox/Radio keyboard focus

[David Edmundson]

davidedmundson added a comment.


  See second line attached:
  
  F3910924: Spectacle.G18840.png 
  
  F3910925: Spectacle.i18840.png 

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D7819

To: davidedmundson, #plasma, #vdg
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D7819: Add extra visual indicator for Checkbox/Radio keyboard focus

[David Edmundson]

davidedmundson created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  This draws a line underneath a Plasma checkbox label when it has
  keyboard focus. This is needed as when an item is checked, the focus
  shadow is practically invisible.
  
  Visuals when clicking is completely unchanged
  This brings it more in line with our QStyle.

TEST PLAN
  Attached runtime tests

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7819

AFFECTED FILES
  src/declarativeimports/plasmastyle/CheckBoxStyle.qml
  src/declarativeimports/plasmastyle/RadioButtonStyle.qml
  tests/components/checkbox.qml
  tests/components/radiobutton.qml

To: davidedmundson, #plasma, #vdg
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7 - Build # 110 - Still Unstable!

[no-reply]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.7/110/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.7
 Date of build:
Thu, 14 Sep 2017 12:51:21 +
 Build duration:
5 min 26 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

KDE CI: Frameworks plasma-framework kf5-qt5 XenialQt5.7 - Build # 106 - Still Unstable!

[no-reply]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20XenialQt5.7/106/
 Project:
Frameworks plasma-framework kf5-qt5 XenialQt5.7
 Date of build:
Thu, 14 Sep 2017 12:51:21 +
 Build duration:
5 min 2 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report86%
(6/7)62%
(57/92)62%
(57/92)38%
(3492/9218)26%
(1857/7148)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(22/22)100%
(22/22)76%
(607/795)38%
(390/1028)src.declarativeimports.core57%
(4/7)57%
(4/7)28%
(245/880)14%
(85/618)src.plasma62%
(13/21)62%
(13/21)40%
(1412/3572)29%
(772/2695)src.plasma.private46%
(11/24)46%
(11/24)39%
(649/1649)28%
(303/1080)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/190)0%
(0/126)src.plasmaquick50%
(6/12)50%
(6/12)27%
(548/2019)19%
(301/1579)src.plasmaquick.private33%
(1/3)33%
(1/3)27%
(31/113)27%
(6/22)

D7815: Don't list tab names twice

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:7141ad172165: Don't list tab names twice (authored by 
davidedmundson).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7815?vs=19521=19524

REVISION DETAIL
  https://phabricator.kde.org/D7815

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qml/TabButton.qml

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D7815: Don't list tab names twice

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7815

To: davidedmundson, #plasma, broulik
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D7815: Don't list tab names twice

[David Edmundson]

davidedmundson updated this revision to Diff 19521.
davidedmundson added a comment.


  update

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7815?vs=19520=19521

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7815

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qml/TabButton.qml

To: davidedmundson, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D7815: Don't list tab names twice

[David Edmundson]

davidedmundson created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  The name (with a correct role) is already exported as a tab
  
  By having the static text internally we get the name twice when we do a
  flat review of the controls.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7815

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qml/TabButton.qml

To: davidedmundson, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Re: KGlobalAccel regression in latest frameworks release

[Jonathan Riddell]

I've tagged v5.38.1 and released a tar with the change reverted.  I've
not reverted it in master branch so it will need to be fixed or
reverted before 5.39.0

Jonthan

D5034: Add support for x-gvfs style options in fstab

[Kai Uwe Broulik]

broulik abandoned this revision.
broulik added a comment.


  Superseded by https://phabricator.kde.org/D7774

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D5034

To: broulik, #plasma, dhaumann, dfaure
Cc: bruns, dhaumann, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart