KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7 - Build # 75 - Still Unstable!

2017-09-25 Thread no-reply 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.7/75/
 Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.7
 Date of build:
Tue, 26 Sep 2017 02:55:45 +
 Build duration:
21 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 65 test(s), Skipped: 0 test(s), Total: 66 test(s)Failed: TestSuite.kateindenttest_testCstyle

D7750: fix crash when more than one instances of ExtractorCollection are destructed

2017-09-25 Thread Matthieu Gallien 
mgallien marked an inline comment as done.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D7750

To: mgallien, #frameworks, dfaure
Cc: dfaure, anthonyfieroni

D7750: fix crash when more than one instances of ExtractorCollection are destructed

2017-09-25 Thread Matthieu Gallien 
mgallien added a comment.


  Reverted most of my changes and only use a private method with two parameters 
to set the ExtractorPlugin in Extractor class. The second parameter should 
indicate if the Extractor instance is owner of the plugin or not. The private 
class is no longer included in extractorcollection.cpp.
  I am not really sure this is the right approach as it is very easy to use a 
wrong combination for the arguments of Extractor::setExtractorPlugin. I will 
try to improve on that.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D7750

To: mgallien, #frameworks, dfaure
Cc: dfaure, anthonyfieroni

D7750: fix crash when more than one instances of ExtractorCollection are destructed

2017-09-25 Thread Matthieu Gallien 
mgallien updated this revision to Diff 19918.
mgallien marked 6 inline comments as done.
mgallien added a comment.


  add missing noexcept

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7750?vs=19917=19918

BRANCH
  fixPluginDelete

REVISION DETAIL
  https://phabricator.kde.org/D7750

AFFECTED FILES
  autotests/extractorcollectiontest.cpp
  src/extractor.cpp
  src/extractor.h
  src/extractor_p.h
  src/extractorcollection.cpp

To: mgallien, #frameworks, dfaure
Cc: dfaure, anthonyfieroni

D7750: fix crash when more than one instances of ExtractorCollection are destructed

2017-09-25 Thread Matthieu Gallien 
mgallien updated this revision to Diff 19917.
mgallien added a comment.


  reduce the scope of modifications, use an enum to indicate if the plugin 
should be deleted
  and use private methods instead of direct access to private class

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7750?vs=19450=19917

BRANCH
  fixPluginDelete

REVISION DETAIL
  https://phabricator.kde.org/D7750

AFFECTED FILES
  autotests/extractorcollectiontest.cpp
  src/extractor.cpp
  src/extractor.h
  src/extractor_p.h
  src/extractorcollection.cpp

To: mgallien, #frameworks, dfaure
Cc: dfaure, anthonyfieroni

D7976: Highlighting indexer: factor out checks for smaller while loop

2017-09-25 Thread Dominik Haumann 
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:4b6a5d89aa77: Highlighting indexer: factor out checks for 
smaller while loop (authored by dhaumann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7976?vs=19878=19902

REVISION DETAIL
  https://phabricator.kde.org/D7976

AFFECTED FILES
  src/indexer/katehighlightingindexer.cpp

To: dhaumann, vkrause
Cc: #frameworks

D7977: KSqueezedTextLabel: Squeeze text when changing indent or margin

2017-09-25 Thread Henrik Fehlauer 
rkflx edited the summary of this revision.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D7977

To: rkflx, #frameworks, dhaumann, cfeck

D7977: KSqueezedTextLabel: Squeeze text when changing indent or margin

2017-09-25 Thread Henrik Fehlauer 
rkflx added a comment.


  In https://phabricator.kde.org/D7977#148689, @cfeck wrote:
  
  > > Qt does not send a resize event
  >
  > But does it send QEvent::ContentsRectChange?
  
  
  No, because this one is only emitted by `setContentsMargin`, but not by 
`setMargin` (read https://phabricator.kde.org/D7164#143540 (¹) again for what's 
the difference) or `setIndent`.
  
  Even if there were resize related events (in some situations we even get 
some), we are not interested in them. The label should react by squeezing, not 
by adjusting size, as the detailed investigations in 
https://phabricator.kde.org/T6982#111367 conclude.
  
  `testChrome` suggests to unify the behaviour of all its three chrome related 
calls. My patch is the most straightforward way to get there and I don't see 
how we could bolt on something convoluted through the event system without even 
reimplementing the setters to emit an otherwise missing event.
  
  Let me know if you have any concerns against my approach, I'll gladly respond 
to them.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D7977

To: rkflx, #frameworks, dhaumann, cfeck

[kglobalaccel] src/runtime/plugins/xcb: Revert "KGlobalAccel: port to KKeyServer's new method symXModXToKeyQt, to fix numpad keys"

2017-09-25 Thread Martin Flöser 
Git commit 68e35f234ca7d866bcb54442d22892450d871848 by Martin Flöser.
Committed on 25/09/2017 at 15:30.
Pushed by graesslin into branch 'master'.

Revert "KGlobalAccel: port to KKeyServer's new method symXModXToKeyQt, to fix 
numpad keys"

This reverts commit 2c20ddff034e4958bf0536ca91ae9e444955305d.

I'm reverting as we don't have a fix yet and the next release is too
close to risk any changes. As explained in the original review request
for this feature: touching this code base is dangerous. The code is
extremely fragile.

A month of living in master was not enough to spot the severe regressions
we had. As we are now only a few days away from next release we cannot
expect to discover regressions any fix would cause. I don't really see a
solution to this problem: any change might cause issues especially in
KWin, KScreenLocker and KGlobalAccel. All of them have the problem that
the maintainer of those components is not running X11 and won't spot the
regressions. Futhermore we don't have any test cases for the complete key
handing stack on X11. We won't find the regressions. My personal
recommendation would be to no longer change the X11 side and instead all
together work on Wayland and get it ready. There the world looks better:
we have a sane input stack which is completly unit tested. The first
regression caused by the changes here was discovered by a KWin test case
for Wayland. That's the world where we can change and improve the stack.
Let X die, long live Wayland!

If someone wants to take on the task to improve the X11 stack here I
expect some serious work on the testability of this fragile stack. If we
see that the shortcuts will still match I would be way more confident to
accept a change.

CCMAIL: kde-frameworks-devel@kde.org
BUG: 384597

M  +45   -7src/runtime/plugins/xcb/kglobalaccel_x11.cpp

https://commits.kde.org/kglobalaccel/68e35f234ca7d866bcb54442d22892450d871848

diff --git a/src/runtime/plugins/xcb/kglobalaccel_x11.cpp 
b/src/runtime/plugins/xcb/kglobalaccel_x11.cpp
index d76f1d5..9b37c7b 100644
--- a/src/runtime/plugins/xcb/kglobalaccel_x11.cpp
+++ b/src/runtime/plugins/xcb/kglobalaccel_x11.cpp
@@ -122,7 +122,6 @@ bool KGlobalAccelImpl::grabKey( int keyQt, bool grab )
 // can remove shift for some keys. (all the %&* and such)
 if( !(keyQt & Qt::SHIFT) &&
 !KKeyServer::isShiftAsModifierAllowed( keyQt ) &&
-!(keyQt & Qt::KeypadModifier) &&
 keySymX != xcb_key_symbols_get_keysym(m_keySymbols, keyCodeX, 0) &&
 keySymX == xcb_key_symbols_get_keysym(m_keySymbols, keyCodeX, 1) )
 {
@@ -244,12 +243,51 @@ bool KGlobalAccelImpl::x11KeyPress(xcb_key_press_event_t 
*pEvent)
 xcb_ungrab_keyboard(c, XCB_TIME_CURRENT_TIME);
 xcb_flush(c);
 
-int keyQt;
-if (!KKeyServer::xcbKeyPressEventToQt(pEvent, )) {
-qCWarning(KGLOBALACCELD) << "KKeyServer::xcbKeyPressEventToQt failed";
-return false;
-}
-//qDebug() << "keyQt=" << QString::number(keyQt, 16);
+xcb_keycode_t keyCodeX = pEvent->detail;
+uint16_t keyModX = pEvent->state & (g_keyModMaskXAccel | 
KKeyServer::MODE_SWITCH);
+
+xcb_keysym_t keySymX = xcb_key_press_lookup_keysym(m_keySymbols, pEvent, 
0);
+
+   // If numlock is active and a keypad key is pressed, XOR the SHIFT 
state.
+   //  e.g., KP_4 => Shift+KP_Left, and Shift+KP_4 => KP_Left.
+if (pEvent->state & KKeyServer::modXNumLock()) {
+   // If this is a keypad key,
+   if( keySymX >= XK_KP_Space && keySymX <= XK_KP_9 ) {
+   switch( keySymX ) {
+
+   // Leave the following keys unaltered
+   // FIXME: The proper solution is to see which 
keysyms don't change when shifted.
+   case XK_KP_Multiply:
+   case XK_KP_Add:
+   case XK_KP_Subtract:
+   case XK_KP_Divide:
+case XK_KP_Enter:
+   break;
+
+   default:
+   keyModX ^= KKeyServer::modXShift();
+   }
+   }
+   }
+
+   int keyCodeQt;
+   int keyModQt;
+   KKeyServer::symXToKeyQt(keySymX, );
+   KKeyServer::modXToQt(keyModX, );
+
+   if ((keyModQt & Qt::SHIFT) && !KKeyServer::isShiftAsModifierAllowed( 
keyCodeQt ) ) {
+#ifdef KDEDGLOBALACCEL_TRACE
+   qCDebug(KGLOBALACCELD) << "removing shift modifier";
+#endif
+if (keyCodeQt != Qt::Key_Tab) { // KKeySequenceWidget does not map 
shift+tab to backtab
+static const int FirstLevelShift = 1;
+keySymX = xcb_key_symbols_get_keysym(m_keySymbols, keyCodeX, 
FirstLevelShift);
+KKeyServer::symXToKeyQt(keySymX, );
+}
+   keyModQt &= ~Qt::SHIFT;
+   }
+
+   int keyQt = keyCodeQt | keyModQt;
 
// All

D7976: Highlighting indexer: factor out checks for smaller while loop

2017-09-25 Thread Volker Krause 
vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  refactorindexer

REVISION DETAIL
  https://phabricator.kde.org/D7976

To: dhaumann, vkrause
Cc: #frameworks

D7884: - Increase size of trailing mark

2017-09-25 Thread Helio Castro 
helio added a comment.


  In https://phabricator.kde.org/D7884#148489, @cullmann wrote:
  
  > I would rather go with the "make the markers much larger but less contrast" 
solution than a setting for their size.
  >  Perhaps we really just need to look at how other editors do that.
  >  Eye-cancer like markers are no solution either, but I agree that if people 
turn them on, they should be able to spot them easily.
  
  
  And then will end up with the regular "this size is not good to me, can you 
make larger/smaller ?".
  Unfortunately, no size fits all, so i made the reasonable assumption to go 
from the original size to the near character size. 
  I honestly think that this will cover the 99% of users that will need this 
feature.
  
  This is how it appears on vim:
  F3943600: on_vim.png 
  
  We don't have the option on gedit.
  
  On Atom, we can't change color, we just can change the character of 
"Invisibles", which makes very bad at least on my screen:
  F3944421: atom.png 

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D7884

To: helio, mwolff, kfunk
Cc: cullmann, anthonyfieroni, dhaumann, sars, #frameworks

D7884: - Increase size of trailing mark

2017-09-25 Thread Helio Castro 
helio added a comment.


  Fixed requests

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D7884

To: helio, mwolff, kfunk
Cc: cullmann, anthonyfieroni, dhaumann, sars, #frameworks

D7884: - Increase size of trailing mark

2017-09-25 Thread Helio Castro 
helio updated this revision to Diff 19888.
helio marked 3 inline comments as done.
helio added a comment.


  - Moved calc logic to updateMarkerSize
  - Fix identation
  - Make value properly float
  - Update view when apply pressed

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7884?vs=19786=19888

BRANCH
  big_trailing

REVISION DETAIL
  https://phabricator.kde.org/D7884

AFFECTED FILES
  src/dialogs/katedialogs.cpp
  src/dialogs/textareaappearanceconfigwidget.ui
  src/render/katerenderer.cpp
  src/render/katerenderer.h
  src/utils/kateconfig.cpp
  src/utils/kateconfig.h
  src/view/kateviewinternal.cpp

To: helio, mwolff, kfunk
Cc: cullmann, anthonyfieroni, dhaumann, sars, #frameworks

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.7 - Build # 110 - Still Unstable!

2017-09-25 Thread no-reply 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/110/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.7
 Date of build:
Mon, 25 Sep 2017 07:59:29 +
 Build duration:
19 min and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

KDE CI: Frameworks kio kf5-qt5 XenialQt5.7 - Build # 109 - Still Unstable!

2017-09-25 Thread no-reply 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20XenialQt5.7/109/
 Project:
Frameworks kio kf5-qt5 XenialQt5.7
 Date of build:
Mon, 25 Sep 2017 07:59:29 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: TestSuite.kiowidgets-kurifiltertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(22/22)80%
(278/346)80%
(278/346)57%
(29966/52248)42%
(16567/39291)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(67/67)100%
(67/67)96%
(8078/8399)51%
(4503/8824)autotests.http100%
(9/9)100%
(9/9)100%
(543/544)60%
(200/336)autotests.kcookiejar100%
(1/1)100%
(1/1)90%
(179/198)67%
(60/90)src.core85%
(99/117)85%
(99/117)57%
(8156/14198)49%
(4557/9279)src.core.kssl100%
(1/1)100%
(1/1)38%
(35/93)50%
(3/6)src.filewidgets73%
(27/37)73%
(27/37)46%
(3492/7603)30%
(1301/4403)src.gui100%
(2/2)100%
(2/2)95%
(104/110)75%
(54/72)src.ioslaves.file100%
(2/2)100%
(2/2)51%
(435/849)42%
(317/749)src.ioslaves.http100%
(8/8)100%
(8/8)47%
(1762/3781)38%
(1317/3462)src.ioslaves.http.kcookiejar100%
(2/2)100%
(2/2)80%
(622/782)72%
(608/839)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(70/258)8%
(16/200)src.ioslaves.trash80%
(8/10)80%
(8/10)60%
(704/1173)47%
(404/851)src.ioslaves.trash.tests100%
(2/2)100%
(2/2)90%
(707/785)48%
(461/970)src.kioslave100%
(1/1)100%
(1/1)52%
(14/27)50%
(5/10)src.kntlm100%
(2/2)100%
(2/2)97%
(373/385)80%
(111/138)src.kpasswdserver100%
(2/2)100%
(2/2)64%
(382/594)49%
(284/580)src.kpasswdserver.autotests100%
(1/1)100%
(1/1)99%
(283/286)56%

D7841: kioexec: Do not start to watch a temporary copy until after the copy is complete

2017-09-25 Thread Jonathan Marten 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:c76c1486ec79: kioexec: Watch the file when it has 
finished copying (authored by marten).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7841?vs=19864=19885

REVISION DETAIL
  https://phabricator.kde.org/D7841

AFFECTED FILES
  src/kioexec/main.cpp

To: marten, #frameworks, dfaure
Cc: elvisangelaccio, dfaure