date:20171011

D8254: Make file ioslave backend on removeables are user-frendly on linux

2017-10-11 Thread Nathaniel Graham

ngraham added a reviewer: Frameworks.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8254

To: vova7890, #frameworks
Cc: alexeymin, #frameworks

D8256: Add _XOPEN_SOURCE to C definitions

2017-10-11 Thread A . Wilcox

awilcox added a comment.


  Please do note that `_XOPEN_SOURCE` must be `600` and not `700` because some 
components of KDE still use `rindex` which is no longer supported in X/Open 7 
.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D8256

To: awilcox, alexmerry
Cc: #frameworks, #build_system

D8256: Add _XOPEN_SOURCE to C definitions

2017-10-11 Thread A . Wilcox

awilcox created this revision.
awilcox added a reviewer: alexmerry.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.

REVISION SUMMARY
  (This was reported on the KDE bug tracker as Bug 373175 
.  The summary of that bug 
follows.)
  
  When building on non-glibc Unix platforms, such as Solaris, NetBSD, and 
Linux/musl or Linux/uclibc, multiple components of KF5 fail to build.  This is 
because -std=iso9899:1990 is specified (for strict C90 compliance) but 
_XOPEN_SOURCE is not defined, so none of the POSIX interfaces are exported.  I 
have seen this reported in at least:
  
  - kinit
  - kscreenlocker
  - plasma-workspace
  
  The attached patch resolves this issue on all our build boxes; additionally, 
applying it to my glibc builder did not change the already working result.

TEST PLAN
  The entire Adélie Linux distribution's set of KDE packages has been built 
against extra-cmake-modules-5.38.0 with this patch applied.  The Plasma 5 
desktop and KDE software build, test, and run correctly (where applicable).

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D8256

AFFECTED FILES
  kde-modules/KDECompilerSettings.cmake

To: awilcox, alexmerry
Cc: #frameworks, #build_system

D7130: KMoreTools: Update and fix desktopfiles

2017-10-11 Thread Nathaniel Graham

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  I'm afraid this doesn't merge cleanly onto master. @gregormi, can you rebase 
it against current master so that I can merge it?

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D7130

To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson, 
ngraham
Cc: ngraham, ltoscano, #frameworks

D8064: Correct installation of start_kdeinit when DESTDIR and libcap are used together

2017-10-11 Thread A . Wilcox

awilcox updated this revision to Diff 20619.
awilcox added a comment.


  This diff was created with  `git diff`.

REPOSITORY
  R303 KInit

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8064?vs=20125=20619

REVISION DETAIL
  https://phabricator.kde.org/D8064

AFFECTED FILES
  src/start_kdeinit/CMakeLists.txt

To: awilcox, dfaure
Cc: graesslin, #frameworks

D8254: Make file ioslave backend on removeables are user-frendly on linux

2017-10-11 Thread Vova

vova7890 created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  Currently on linux copying file on the flash drive is showing momental 
progress 0 -> 100% and at the end of 100% is waiting while file are flushed on 
the drive. 
  This is almost linux bug with dirty_cache, but had another way to write the 
file. This patch is implements by checking what drive has dest file, and tryng 
to optimize of file writing by cheking is the device are "removable"(if true - 
appends O_SYNC for ::open) and how many kbytes device can transfer per single 
transfer.  So for now, the progress bar is shows real percent of progress and 
abort or pause is working are propertly.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8254

AFFECTED FILES
  b/src/ioslaves/file/file_unix.cpp

To: vova7890
Cc: #frameworks

D7130: KMoreTools: Update and fix desktopfiles

2017-10-11 Thread Nathaniel Graham

ngraham added a comment.


  My brain knows that, but apparently my fingers didn't. :p

REPOSITORY
  R304 KNewStuff

BRANCH
  mydev

REVISION DETAIL
  https://phabricator.kde.org/D7130

To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson, 
ngraham
Cc: ngraham, ltoscano, #frameworks

D7130: KMoreTools: Update and fix desktopfiles

2017-10-11 Thread Nathaniel Graham

ngraham edited the summary of this revision.

REPOSITORY
  R304 KNewStuff

BRANCH
  mydev

REVISION DETAIL
  https://phabricator.kde.org/D7130

To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson, 
ngraham
Cc: ngraham, ltoscano, #frameworks

D7130: KMoreTools: Update and fix desktopfiles

2017-10-11 Thread Luigi Toscano

ltoscano added a comment.


  BUG: n

REPOSITORY
  R304 KNewStuff

BRANCH
  mydev

REVISION DETAIL
  https://phabricator.kde.org/D7130

To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson, 
ngraham
Cc: ngraham, ltoscano, #frameworks

D7130: KMoreTools: Update and fix desktopfiles

2017-10-11 Thread Nathaniel Graham

ngraham edited the summary of this revision.

REPOSITORY
  R304 KNewStuff

BRANCH
  mydev

REVISION DETAIL
  https://phabricator.kde.org/D7130

To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson, 
ngraham
Cc: ngraham, ltoscano, #frameworks

D7130: KMoreTools: Update and fix desktopfiles

2017-10-11 Thread Elvis Angelaccio

elvisangelaccio accepted this revision as: elvisangelaccio.
elvisangelaccio added a comment.


  I had tested the patch and it was fixing the bug.
  I'm fine with this as long as @gregormi volunteers to maintain this code 
updated (and eventually to switch to a better design, if possible).

REPOSITORY
  R304 KNewStuff

BRANCH
  mydev

REVISION DETAIL
  https://phabricator.kde.org/D7130

To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson, 
ngraham
Cc: ngraham, ltoscano, #frameworks

D7369: Wayland foreign protocol

2017-10-11 Thread Martin Flöser

graesslin added a comment.


  There is still quite some documentation missing. Especially the server side 
is not yet documented enough that I would know how to use the new API and what 
it does. It's totally fine to copy and adapt the documentation from the Wayland 
xml protocol.

INLINE COMMENTS

> xdgforeign.h:116
> +
> +XdgExported *exportSurface(Surface *surface, QObject *parent = nullptr);
> +

Please add documentation

> xdgforeign.h:208
> +
> +XdgImported *import(const QString & handle, QObject *parent = nullptr);
> +

Please add documentation

> xdgforeign.h:268
> +
> +QString handle() const;
> +

what's the handle?

> xdgforeign.h:327
> +
> +void setParentOf(Surface *surface);
> +

please add documentation

> xdgforeign_interface.h:38
> +
> +class KWAYLANDSERVER_EXPORT XdgForeignInterface : public QObject
> +{

This needs documentation

> xdgforeign_interface.h:45-46
> +
> +void create();
> +bool isValid();
> +

Please add documentation? I wouldn't know what create is needed for.

> xdgforeign_interface.h:49
> +/**
> + * if a client did set 
> + */

did set "what"?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D7369

To: mart, #plasma, #kwin, davidedmundson, graesslin
Cc: davidedmundson, graesslin, plasma-devel, #frameworks, leezu, ZrenBot, 
alexeymin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, 
sebas, apol, mart, hein

D8243: Implement support for categories on KfilesPlacesView

2017-10-11 Thread Renato Oliveira Filho

renatoo updated this revision to Diff 20613.
renatoo added a comment.


  Does not use KCategorizedView
  
  Instead of use KCategorizedView, draw the section over the first item area

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8243?vs=20587=20613

BRANCH
  model-hide-row

REVISION DETAIL
  https://phabricator.kde.org/D8243

AFFECTED FILES
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesitem_p.h
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h
  src/filewidgets/kfileplacesview.cpp

To: renatoo, #frameworks, dfaure
Cc: anthonyfieroni, cfeck, #frameworks

KDE CI: Frameworks kio kf5-qt5 XenialQt5.7 - Build # 117 - Still Unstable!

2017-10-11 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20XenialQt5.7/117/
 Project:
Frameworks kio kf5-qt5 XenialQt5.7
 Date of build:
Wed, 11 Oct 2017 17:47:39 +
 Build duration:
6 min 40 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: TestSuite.kiowidgets-kurifiltertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(22/22)80%
(279/349)80%
(279/349)57%
(29969/52345)42%
(16572/39352)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(67/67)100%
(67/67)96%
(8078/8399)51%
(4501/8824)autotests.http100%
(9/9)100%
(9/9)100%
(543/544)60%
(200/336)autotests.kcookiejar100%
(1/1)100%
(1/1)90%
(179/198)67%
(60/90)src.core85%
(99/117)85%
(99/117)57%
(8157/14205)49%
(4558/9280)src.core.kssl100%
(1/1)100%
(1/1)38%
(35/93)50%
(3/6)src.filewidgets73%
(27/37)73%
(27/37)46%
(3490/7603)30%
(1299/4403)src.gui100%
(2/2)100%
(2/2)95%
(104/110)75%
(54/72)src.ioslaves.file60%
(3/5)60%
(3/5)46%
(436/939)39%
(319/809)src.ioslaves.http100%
(8/8)100%
(8/8)47%
(1770/3781)38%
(1326/3462)src.ioslaves.http.kcookiejar100%
(2/2)100%
(2/2)80%
(622/782)72%
(608/839)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(70/258)8%
(16/200)src.ioslaves.trash80%
(8/10)80%
(8/10)60%
(704/1173)47%
(404/851)src.ioslaves.trash.tests100%
(2/2)100%
(2/2)90%
(707/785)48%
(461/970)src.kioslave100%
(1/1)100%
(1/1)52%
(14/27)50%
(5/10)src.kntlm100%
(2/2)100%
(2/2)97%
(373/385)80%
(111/138)src.kpasswdserver100%
(2/2)100%
(2/2)63%
(377/594)48%
(280/580)src.kpasswdserver.autotests100%
(1/1)100%
(1/1)99%
(283/286)57%

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.7 - Build # 118 - Still Failing!

2017-10-11 Thread CI System

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/118/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.7
 Date of build:
Wed, 11 Oct 2017 17:47:39 +
 Build duration:
3 min 3 sec and counting
   CONSOLE OUTPUT
  [...truncated 398.55 KB...]Generating MOC source EWIEGA46WW/moc_httpobjecttest.cppGenerating MOC source Z6OQ364BWP/moc_http.cppGenerating MOC compilation mocs_compilation.cpp[ 26%] Built target httpobjecttest_autogen[ 26%] Building CXX object src/ioslaves/help/CMakeFiles/kio_help.dir/xslt_help.cpp.o[ 26%] Building CXX object src/ioslaves/file/CMakeFiles/kio_file.dir/file_unix.cpp.o[ 27%] Building CXX object src/ioslaves/help/CMakeFiles/kio_ghelp.dir/main_ghelp.cpp.o[ 27%] Building CXX object src/ioslaves/help/CMakeFiles/kio_ghelp.dir/xslt_help.cpp.o[ 27%] Building CXX object src/ioslaves/file/CMakeFiles/kio_file.dir/fdreceiver.cpp.oIn file included from /usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.7/src/ioslaves/file/fdreceiver.cpp:26:/usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.7/src/ioslaves/file/sharefd_p.h:46:33: warning: braces around scalar initializer [-Wbraced-scalar-init]sockaddr_un a{ AF_UNIX, {0}};^~~/usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.7/src/ioslaves/file/sharefd_p.h:46:36: warning: missing field 'sun_path' initializer [-Wmissing-field-initializers]sockaddr_un a{ AF_UNIX, {0}};   ^/usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.7/src/ioslaves/file/sharefd_p.h:51:18: error: cannot initialize a parameter of type 'char *' with an rvalue of type 'char (*)[104]'::strcpy(_path, finalPath.c_str()); ^~~/usr/include/string.h:82:31: note: passing argument to parameter herechar*strcpy(char * __restrict, const char * __restrict); ^2 warnings and 1 error generated.[ 27%] Building CXX object src/ioslaves/file/CMakeFiles/kio_file.dir/kio_file_autogen/mocs_compilation.cpp.ogmake[2]: *** [src/ioslaves/file/CMakeFiles/kio_file.dir/build.make:111: src/ioslaves/file/CMakeFiles/kio_file.dir/fdreceiver.cpp.o] Error 1gmake[2]: *** Waiting for unfinished jobs[ 28%] Building CXX object src/ioslaves/help/CMakeFiles/kio_help.dir/kio_help_autogen/mocs_compilation.cpp.o[ 28%] Building CXX object src/ioslaves/help/CMakeFiles/kio_ghelp.dir/kio_ghelp_autogen/mocs_compilation.cpp.o[ 28%] Linking CXX shared module ../../../bin/kf5/kio/help.so[ 28%] Linking CXX shared module ../../../bin/kf5/kio/ghelp.so[ 28%] Built target kio_help[ 28%] Built target kio_ghelpgmake[1]: *** [CMakeFiles/Makefile2:1611: src/ioslaves/file/CMakeFiles/kio_file.dir/all] Error 2Generating MOC source include/delegateanimationhandler.mocGenerating MOC source include/moc_delegateanimationhandler_p.cppGenerating MOC source include/moc_dropjob.cppGenerating MOC source include/fileundomanager.mocGenerating MOC source include/moc_fileundomanager.cppGenerating MOC source include/moc_fileundomanager_p.cppGenerating MOC source include/jobuidelegate.mocGenerating MOC source include/moc_joburlcache_p.cppGenerating MOC source include/moc_kacleditwidget.cppGenerating MOC source include/moc_kacleditwidget_p.cppGenerating MOC source include/moc_kautomount.cppGenerating MOC source include/moc_kbuildsycocaprogressdialog.cppGenerating MOC source include/moc_kdirlister.cppGenerating MOC source include/moc_kdirmodel.cppGenerating MOC source include/moc_kdynamicjobtracker_p.cppGenerating MOC source include/moc_kfile.cppGenerating MOC source include/moc_kopenwithdialog.cppGenerating MOC source include/moc_kopenwithdialog_p.cppGenerating MOC source include/koverlayiconplugin.moc/usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.7/src/widgets/koverlayiconplugin.cpp:0: Note: No relevant classes found. No output generated.Generating MOC source include/moc_kpropertiesdialog.cppGenerating MOC source include/moc_kpropertiesdialog_p.cppGenerating MOC source include/krun.mocGenerating MOC source include/moc_krun.cppGenerating MOC source include/moc_krun_p.cppGenerating MOC source include/moc_kurlcombobox.cppGenerating MOC source include/kurlcompletion.mocGenerating MOC source include/moc_kurlcompletion.cppGenerating MOC source include/kurlrequester.mocGenerating MOC source include/moc_kurlrequester.cppGenerating MOC source include/moc_kurlrequesterdialog.cppGenerating MOC source include/moc_pastejob.cppGenerating MOC source include/moc_previewjob.cppGenerating MOC source EWIEGA46WW/moc_accessmanager.cppGenerating MOC source EWIEGA46WW/moc_accessmanagerreply_p.cppGenerating MOC source EWIEGA46WW/moc_clipboardupdater_p.cppGenerating MOC source EWIEGA46WW/moc_dndpopupmenuplugin.cppGenerating MOC source EWIEGA46WW/moc_executablefileopendialog_p.cppGenerating MOC source EWIEGA46WW/moc_jobuidelegate.cppGenerating MOC source

D6829: Add ability to use the new kauth helper in file ioslave

2017-10-11 Thread Chinmoy Ranjan Pradhan

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:c4726e843e42: Add ability to use the new kauth helper in 
file ioslave (authored by chinmoyr).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D6829?vs=20311=20610#toc

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6829?vs=20311=20610

REVISION DETAIL
  https://phabricator.kde.org/D6829

AFFECTED FILES
  src/core/global.h
  src/core/slavebase.cpp
  src/core/slavebase.h
  src/core/slaveinterface.cpp
  src/core/slaveinterface.h
  src/ioslaves/file/file.h
  src/ioslaves/file/file_p.h
  src/ioslaves/file/file_unix.cpp
  src/ioslaves/file/file_win.cpp

To: chinmoyr, dfaure, #frameworks
Cc: #frameworks

D7130: KMoreTools: Update and fix desktopfiles

2017-10-11 Thread Luigi Toscano

ltoscano added a comment.


  The line `update desktop files including fix for PartitionManager and 
KDiskFree (https://bugs.kde.org/show_bug.cgi?id=369646)` should be fixed to 
have BUG:...

REPOSITORY
  R304 KNewStuff

BRANCH
  mydev

REVISION DETAIL
  https://phabricator.kde.org/D7130

To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson, 
ngraham
Cc: ngraham, ltoscano, #frameworks

D7130: KMoreTools: Update and fix desktopfiles

2017-10-11 Thread Luigi Toscano

ltoscano resigned from this revision.
ltoscano added a comment.
This revision is now accepted and ready to land.


  I still disagree in the way this is done, as it means manually periodically 
updating the information and it's definitely not the right thing to do.
  
  That said, if @elvisangelaccio approves this, it can go in as temporary fix 
but the next update should work on using the appstream library to get those 
information from appstream files. Or any other solutions which does not involve 
duplicating the information.
  
  I'm removing my vote but please wait for Elvis.

REPOSITORY
  R304 KNewStuff

BRANCH
  mydev

REVISION DETAIL
  https://phabricator.kde.org/D7130

To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson, 
ngraham
Cc: ngraham, ltoscano, #frameworks

D7130: KMoreTools: Update and fix desktopfiles

2017-10-11 Thread Nathaniel Graham

ngraham added a comment.


  @ltoscano, can we commit this?

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D7130

To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson, 
ngraham
Cc: ngraham, ltoscano, #frameworks

KDE CI: Frameworks kio kf5-qt5 XenialQt5.7 - Build # 116 - Still Unstable!

2017-10-11 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20XenialQt5.7/116/
 Project:
Frameworks kio kf5-qt5 XenialQt5.7
 Date of build:
Wed, 11 Oct 2017 16:48:31 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: TestSuite.kiowidgets-kurifiltertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(22/22)80%
(279/348)80%
(279/348)57%
(29964/52298)42%
(16564/39317)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(67/67)100%
(67/67)96%
(8075/8399)51%
(4500/8824)autotests.http100%
(9/9)100%
(9/9)100%
(543/544)60%
(200/336)autotests.kcookiejar100%
(1/1)100%
(1/1)90%
(179/198)67%
(60/90)src.core85%
(99/117)85%
(99/117)57%
(8157/14198)49%
(4556/9279)src.core.kssl100%
(1/1)100%
(1/1)38%
(35/93)50%
(3/6)src.filewidgets73%
(27/37)73%
(27/37)46%
(3491/7603)30%
(1300/4403)src.gui100%
(2/2)100%
(2/2)95%
(104/110)75%
(54/72)src.ioslaves.file75%
(3/4)75%
(3/4)48%
(436/899)41%
(319/775)src.ioslaves.http100%
(8/8)100%
(8/8)47%
(1762/3781)38%
(1317/3462)src.ioslaves.http.kcookiejar100%
(2/2)100%
(2/2)80%
(622/782)72%
(608/839)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(70/258)8%
(16/200)src.ioslaves.trash80%
(8/10)80%
(8/10)60%
(704/1173)47%
(404/851)src.ioslaves.trash.tests100%
(2/2)100%
(2/2)90%
(707/785)48%
(461/970)src.kioslave100%
(1/1)100%
(1/1)52%
(14/27)50%
(5/10)src.kntlm100%
(2/2)100%
(2/2)97%
(373/385)80%
(111/138)src.kpasswdserver100%
(2/2)100%
(2/2)64%
(382/594)49%
(284/580)src.kpasswdserver.autotests100%
(1/1)100%
(1/1)99%
(283/286)56%

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.7 - Build # 117 - Still Failing!

2017-10-11 Thread CI System

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/117/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.7
 Date of build:
Wed, 11 Oct 2017 16:45:43 +
 Build duration:
7 min 24 sec and counting
   CONSOLE OUTPUT
  [...truncated 392.35 KB...][ 25%] Built target kfileitemtest_autogenScanning dependencies of target httpobjecttest_autogen[ 25%] Automatic MOC for target httpobjecttestGenerating MOC source include/http.mocGenerating MOC source include/moc_httpfilter.cppGenerating MOC source EWIEGA46WW/moc_httpobjecttest.cppGenerating MOC source Z6OQ364BWP/moc_http.cppGenerating MOC compilation mocs_compilation.cpp[ 25%] Built target httpobjecttest_autogenScanning dependencies of target httpauthenticationtest_autogen[ 25%] Automatic MOC for target httpauthenticationtestGenerating MOC source EWIEGA46WW/moc_httpauthenticationtest.cppGenerating MOC compilation mocs_compilation.cpp[ 25%] Built target httpauthenticationtest_autogenScanning dependencies of target kcookiejartest_autogen[ 26%] Automatic MOC for target kcookiejartestGenerating MOC source include/kcookiejartest.mocGenerating MOC compilation mocs_compilation.cpp[ 26%] Built target kcookiejartest_autogenScanning dependencies of target kio_file[ 26%] Building CXX object src/ioslaves/file/CMakeFiles/kio_file.dir/file.cpp.oGenerating MOC source include/moc_kpropertiesdialog.cppGenerating MOC source include/moc_kpropertiesdialog_p.cppGenerating MOC source include/krun.mocGenerating MOC source include/moc_krun.cppGenerating MOC source include/moc_krun_p.cppGenerating MOC source include/moc_kurlcombobox.cppGenerating MOC source include/kurlcompletion.mocGenerating MOC source include/moc_kurlcompletion.cppGenerating MOC source include/kurlrequester.mocGenerating MOC source include/moc_kurlrequester.cppGenerating MOC source include/moc_kurlrequesterdialog.cppGenerating MOC source include/moc_pastejob.cppGenerating MOC source include/moc_previewjob.cppGenerating MOC source EWIEGA46WW/moc_accessmanager.cppGenerating MOC source EWIEGA46WW/moc_accessmanagerreply_p.cppGenerating MOC source EWIEGA46WW/moc_clipboardupdater_p.cppGenerating MOC source EWIEGA46WW/moc_dndpopupmenuplugin.cppGenerating MOC source EWIEGA46WW/moc_executablefileopendialog_p.cppGenerating MOC source EWIEGA46WW/moc_jobuidelegate.cppGenerating MOC source EWIEGA46WW/moc_kabstractfileitemactionplugin.cppGenerating MOC source EWIEGA46WW/moc_kfileitemactions.cppGenerating MOC source EWIEGA46WW/moc_kfileitemactions_p.cppGenerating MOC source EWIEGA46WW/moc_kfileitemdelegate.cppGenerating MOC source EWIEGA46WW/moc_koverlayiconplugin.cppGenerating MOC source EWIEGA46WW/moc_kshellcompletion.cppGenerating MOC source EWIEGA46WW/moc_ksslcertificatebox.cppGenerating MOC source EWIEGA46WW/moc_ksslinfodialog.cppGenerating MOC source EWIEGA46WW/moc_kurifilter.cppGenerating MOC source EWIEGA46WW/moc_kurifiltersearchprovideractions.cppGenerating MOC source EWIEGA46WW/moc_openfilemanagerwindowjob.cppGenerating MOC source EWIEGA46WW/moc_pastedialog_p.cppGenerating MOC source EWIEGA46WW/moc_renamedialog.cppGenerating MOC source EWIEGA46WW/moc_skipdialog.cppGenerating MOC compilation mocs_compilation.cpp[ 26%] Built target KF5KIOWidgets_autogen[ 26%] Building CXX object src/ioslaves/file/CMakeFiles/kio_file.dir/file_unix.cpp.oScanning dependencies of target file_helper[ 26%] Building CXX object src/ioslaves/file/kauth/CMakeFiles/file_helper.dir/filehelper.cpp.o/usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.7/src/ioslaves/file/kauth/filehelper.cpp:135:20: error: use of undeclared identifier 'errno'reply.setError(errno ? errno : -1);   ^/usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.7/src/ioslaves/file/kauth/filehelper.cpp:135:28: error: use of undeclared identifier 'errno'reply.setError(errno ? errno : -1);   ^2 errors generated.gmake[2]: *** [src/ioslaves/file/kauth/CMakeFiles/file_helper.dir/build.make:63: src/ioslaves/file/kauth/CMakeFiles/file_helper.dir/filehelper.cpp.o] Error 1gmake[1]: *** [CMakeFiles/Makefile2:1702: src/ioslaves/file/kauth/CMakeFiles/file_helper.dir/all] Error 2gmake[1]: *** Waiting for unfinished jobs[ 26%] Building CXX object src/ioslaves/file/CMakeFiles/kio_file.dir/fdreceiver.cpp.o[ 26%] Building CXX object src/ioslaves/file/CMakeFiles/kio_file.dir/kio_file_autogen/mocs_compilation.cpp.oIn file included from /usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.7/src/ioslaves/file/fdreceiver.cpp:26:/usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.7/src/ioslaves/file/sharefd_p.h:46:33: warning: braces around scalar initializer [-Wbraced-scalar-init]sockaddr_un a{ AF_UNIX, {0}};^~~/usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.7/src/ioslaves/file/sharefd_p.h:46:36: warning: missing field 'sun_path' initializer [-Wmissing-field-initializers]sockaddr_un

KDE CI: Frameworks kio kf5-qt5 XenialQt5.7 - Build # 115 - Still Unstable!

2017-10-11 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20XenialQt5.7/115/
 Project:
Frameworks kio kf5-qt5 XenialQt5.7
 Date of build:
Wed, 11 Oct 2017 16:31:13 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: TestSuite.kiowidgets-kurifiltertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(22/22)80%
(279/348)80%
(279/348)57%
(29958/52298)42%
(16564/39317)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(67/67)100%
(67/67)96%
(8078/8399)51%
(4503/8824)autotests.http100%
(9/9)100%
(9/9)100%
(543/544)60%
(200/336)autotests.kcookiejar100%
(1/1)100%
(1/1)90%
(179/198)67%
(60/90)src.core85%
(99/117)85%
(99/117)57%
(8148/14198)49%
(4551/9279)src.core.kssl100%
(1/1)100%
(1/1)38%
(35/93)50%
(3/6)src.filewidgets73%
(27/37)73%
(27/37)46%
(3491/7603)30%
(1300/4403)src.gui100%
(2/2)100%
(2/2)95%
(104/110)75%
(54/72)src.ioslaves.file75%
(3/4)75%
(3/4)48%
(436/899)41%
(319/775)src.ioslaves.http100%
(8/8)100%
(8/8)47%
(1762/3781)38%
(1317/3462)src.ioslaves.http.kcookiejar100%
(2/2)100%
(2/2)80%
(622/782)72%
(608/839)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(70/258)8%
(16/200)src.ioslaves.trash80%
(8/10)80%
(8/10)60%
(704/1173)47%
(404/851)src.ioslaves.trash.tests100%
(2/2)100%
(2/2)90%
(707/785)48%
(461/970)src.kioslave100%
(1/1)100%
(1/1)52%
(14/27)50%
(5/10)src.kntlm100%
(2/2)100%
(2/2)97%
(373/385)80%
(111/138)src.kpasswdserver100%
(2/2)100%
(2/2)64%
(382/594)49%
(284/580)src.kpasswdserver.autotests100%
(1/1)100%
(1/1)99%
(283/286)57%

KCModuleContainer

2017-10-11 Thread Martin Koller

Hi,

I'm trying to use KCModuleContainer to show 3 kcm modules, however this class 
constantly crashes
when switching tabs.
checking the sourcecode, I see the reason:
void KCModuleContainer::tabSwitched(int index)
...
setAboutData(mod->aboutData());


but since the base class KCModule always deletes the previous set KAboutData 
(which is owned by the loaded modules)
the problem is clear.

This leads me to the general question: Is this class used at all, since
https://lxr.kde.org/ident?v=kf5-qt5&_i=KCModuleContainer
shows no users.

And another interesting thing is that the header file is installed here 
(openSuse 42.2, KF5 5.38.0) twice:

/usr/include/KF5/KDELibs4Support/KDE/KCModuleContainer
/usr/include/KF5/KCMUtils/KCModuleContainer

Is this class meant to be no longer used ?

-- 
Best regards/Schöne Grüße

Martin
A: Because it breaks the logical sequence of discussion
Q: Why is top posting bad?

()  ascii ribbon campaign - against html e-mail 
/\- against proprietary attachments

Geschenkideen, Accessoires, Seifen, Kulinarisches: www.lillehus.at

D6197: Add kauth helper to file ioslave

2017-10-11 Thread Chinmoy Ranjan Pradhan

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:29a741982fe5: Add kauth helper to file ioslave (authored 
by chinmoyr).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D6197?vs=20310=20608#toc

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6197?vs=20310=20608

REVISION DETAIL
  https://phabricator.kde.org/D6197

AFFECTED FILES
  src/ioslaves/file/CMakeLists.txt
  src/ioslaves/file/file_p.h
  src/ioslaves/file/kauth/CMakeLists.txt
  src/ioslaves/file/kauth/file.actions
  src/ioslaves/file/kauth/filehelper.cpp
  src/ioslaves/file/kauth/filehelper.h

To: chinmoyr, elvisangelaccio, #frameworks, dfaure

D8050: Expose wl_display_set_global_filter as a virtual method

2017-10-11 Thread Martin Flöser

graesslin added a comment.

  In https://phabricator.kde.org/D8050#154356, @davidedmundson wrote:

  > I'm not resubmitting something just for the purpose of you two winding each 
other up.

  Eh, it was not meant like that. I just wanted to point out that this does not 
need any changes in the code, but in the CI system.

  > We're in no rush for this. I'll check what suse has and go from there.

  I created https://phabricator.kde.org/T7182 for updating the image.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D8050

To: davidedmundson, #plasma, graesslin, bcooksley
Cc: bcooksley, graesslin, plasma-devel, #frameworks, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.7 - Build # 116 - Failure!

2017-10-11 Thread CI System

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/116/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.7
 Date of build:
Wed, 11 Oct 2017 16:31:13 +
 Build duration:
7 min 39 sec and counting
   CONSOLE OUTPUT
  [...truncated 386.71 KB...]Generating MOC compilation mocs_compilation.cpp[ 29%] Built target listdirtest_autogenScanning dependencies of target kfileitemtest_autogen[ 29%] Automatic MOC for target kfileitemtestGenerating MOC source EWIEGA46WW/moc_kfileitemtest.cppGenerating MOC compilation mocs_compilation.cpp[ 29%] Built target kfileitemtest_autogenScanning dependencies of target httpobjecttest_autogen[ 29%] Automatic MOC for target httpobjecttestGenerating MOC source include/http.mocGenerating MOC source include/moc_httpfilter.cppGenerating MOC source EWIEGA46WW/moc_httpobjecttest.cppGenerating MOC source Z6OQ364BWP/moc_http.cppGenerating MOC compilation mocs_compilation.cpp[ 29%] Built target httpobjecttest_autogenScanning dependencies of target httpauthenticationtest_autogen[ 29%] Automatic MOC for target httpauthenticationtestGenerating MOC source EWIEGA46WW/moc_httpauthenticationtest.cppGenerating MOC compilation mocs_compilation.cpp[ 29%] Built target httpauthenticationtest_autogenScanning dependencies of target kcookiejartest_autogen[ 29%] Automatic MOC for target kcookiejartestGenerating MOC source include/kcookiejartest.mocGenerating MOC compilation mocs_compilation.cpp[ 29%] Built target kcookiejartest_autogenScanning dependencies of target kio_file[ 29%] Building CXX object src/ioslaves/file/CMakeFiles/kio_file.dir/file.cpp.o[ 29%] Building CXX object src/ioslaves/file/CMakeFiles/kio_file.dir/file_unix.cpp.oGenerating MOC source include/moc_kpropertiesdialog.cppGenerating MOC source include/moc_kpropertiesdialog_p.cppGenerating MOC source include/krun.mocGenerating MOC source include/moc_krun.cppGenerating MOC source include/moc_krun_p.cppGenerating MOC source include/moc_kurlcombobox.cppGenerating MOC source include/kurlcompletion.mocGenerating MOC source include/moc_kurlcompletion.cppGenerating MOC source include/kurlrequester.mocGenerating MOC source include/moc_kurlrequester.cppGenerating MOC source include/moc_kurlrequesterdialog.cppGenerating MOC source include/moc_pastejob.cppGenerating MOC source include/moc_previewjob.cppGenerating MOC source EWIEGA46WW/moc_accessmanager.cppGenerating MOC source EWIEGA46WW/moc_accessmanagerreply_p.cppGenerating MOC source EWIEGA46WW/moc_clipboardupdater_p.cppGenerating MOC source EWIEGA46WW/moc_dndpopupmenuplugin.cppGenerating MOC source EWIEGA46WW/moc_executablefileopendialog_p.cppGenerating MOC source EWIEGA46WW/moc_jobuidelegate.cppGenerating MOC source EWIEGA46WW/moc_kabstractfileitemactionplugin.cppGenerating MOC source EWIEGA46WW/moc_kfileitemactions.cppGenerating MOC source EWIEGA46WW/moc_kfileitemactions_p.cppGenerating MOC source EWIEGA46WW/moc_kfileitemdelegate.cppGenerating MOC source EWIEGA46WW/moc_koverlayiconplugin.cppGenerating MOC source EWIEGA46WW/moc_kshellcompletion.cppGenerating MOC source EWIEGA46WW/moc_ksslcertificatebox.cppGenerating MOC source EWIEGA46WW/moc_ksslinfodialog.cppGenerating MOC source EWIEGA46WW/moc_kurifilter.cppGenerating MOC source EWIEGA46WW/moc_kurifiltersearchprovideractions.cppGenerating MOC source EWIEGA46WW/moc_openfilemanagerwindowjob.cppGenerating MOC source EWIEGA46WW/moc_pastedialog_p.cppGenerating MOC source EWIEGA46WW/moc_renamedialog.cppGenerating MOC source EWIEGA46WW/moc_skipdialog.cppGenerating MOC compilation mocs_compilation.cpp[ 29%] Built target KF5KIOWidgets_autogen[ 29%] Building CXX object src/ioslaves/file/CMakeFiles/kio_file.dir/fdreceiver.cpp.oScanning dependencies of target kio_ghelp[ 29%] Building CXX object src/ioslaves/help/CMakeFiles/kio_ghelp.dir/kio_help.cpp.oIn file included from /usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.7/src/ioslaves/file/fdreceiver.cpp:26:/usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.7/src/ioslaves/file/sharefd_p.h:46:33: warning: braces around scalar initializer [-Wbraced-scalar-init]sockaddr_un a{ AF_UNIX, {0}};^~~/usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.7/src/ioslaves/file/sharefd_p.h:46:36: warning: missing field 'sun_path' initializer [-Wmissing-field-initializers]sockaddr_un a{ AF_UNIX, {0}};   ^/usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.7/src/ioslaves/file/sharefd_p.h:51:18: error: cannot initialize a parameter of type 'char *' with an rvalue of type 'char (*)[104]'::strcpy(_path, finalPath.c_str()); ^~~/usr/include/string.h:82:31: note: passing argument to parameter herechar*strcpy(char * __restrict, const char * __restrict); ^2 warnings and 1 error generated.gmake[2]: *** [src/ioslaves/file/CMakeFiles/kio_file.dir/build.make:111:

D8050: Expose wl_display_set_global_filter as a virtual method

2017-10-11 Thread David Edmundson

davidedmundson added a comment.


  I'm not resubmitting something just for the purpose of you two winding each 
other up.
  
  We're in no rush for this. I'll check what suse has and go from there.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D8050

To: davidedmundson, #plasma, graesslin, bcooksley
Cc: bcooksley, graesslin, plasma-devel, #frameworks, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D6709: [RFC] Add support for sharing file descriptor between KIO slave and KAuth helper

2017-10-11 Thread Chinmoy Ranjan Pradhan

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:0c2a6811dc50: Add support for sharing file descriptor 
between file ioslave and its KAuth… (authored by chinmoyr).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D6709?vs=20232=20607#toc

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6709?vs=20232=20607

REVISION DETAIL
  https://phabricator.kde.org/D6709

AFFECTED FILES
  src/ioslaves/file/CMakeLists.txt
  src/ioslaves/file/fdreceiver.cpp
  src/ioslaves/file/fdreceiver.h
  src/ioslaves/file/kauth/fdsender.cpp
  src/ioslaves/file/kauth/fdsender.h
  src/ioslaves/file/sharefd_p.h

To: chinmoyr, thiago, #frameworks, dfaure
Cc: dfaure, davidedmundson, elvisangelaccio, shortstheory

KDE CI: Frameworks kwindowsystem kf5-qt5 XenialQt5.7 - Build # 35 - Still Unstable!

2017-10-11 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20XenialQt5.7/35/
 Project:
Frameworks kwindowsystem kf5-qt5 XenialQt5.7
 Date of build:
Wed, 11 Oct 2017 15:39:26 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: (root) Failed: 5 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.kwindowsystem-compositingenabled_testFailed: TestSuite.kwindowsystem-kwindoweffectstestFailed: TestSuite.kwindowsystem-kwindowinfox11testFailed: TestSuite.kwindowsystem-kwindowsystem_threadtestFailed: TestSuite.kwindowsystem-kwindowsystemx11test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)80%
(37/46)80%
(37/46)71%
(5714/8054)48%
(3008/6330)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(16/16)100%
(16/16)85%
(2577/3047)43%
(1345/3137)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src69%
(11/16)69%
(11/16)50%
(721/1444)37%
(263/720)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/89)0%
(0/2)src.platforms.xcb82%
(9/11)82%
(9/11)70%
(2409/3464)57%
(1397/2465)

D8224: Support flatpak platform

2017-10-11 Thread Martin Flöser

This revision was automatically updated to reflect the committed changes.
Closed by commit R278:ec3c59e535fa: Support flatpak platform (authored by 
graesslin).

REPOSITORY
  R278 KWindowSystem

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8224?vs=20524=20603

REVISION DETAIL
  https://phabricator.kde.org/D8224

AFFECTED FILES
  src/kwindowsystem.cpp
  src/pluginwrapper.cpp

To: graesslin, #frameworks, #flatpak, apol, davidedmundson

D8250: [client] Drop the checks for platformName being "wayland"

2017-10-11 Thread Martin Flöser

graesslin created this revision.
graesslin added reviewers: Frameworks, KWin, Flatpak.
Restricted Application added a subscriber: plasma-devel.
Restricted Application added projects: Plasma on Wayland, Frameworks.

REVISION SUMMARY
  There are also QPA's which are "wayland" but have a different name. An
  example is flatpak. Any code using KWayland::Client is basically
  disabled on this platform due to the incorrect checks for the platform
  name.
  
  If we run on a platform which provides wl_display through the native
  interface we should be able to assume that it truly is Wayland and that
  it speaks wayland. Similar for all the other checks. The only
  problematic code might be the check in Surface, but on the other hand we
  can assume that code using Surface::fromWindow has also created a
  ConnectionThread and thus knows whether it's Wayland or not.
  
  This fixes the Plasma integration for flatpak.

TEST PLAN
  Flatpak windows have decorations in Plasma now.

REPOSITORY
  R127 KWayland

BRANCH
  drop-platform-check

REVISION DETAIL
  https://phabricator.kde.org/D8250

AFFECTED FILES
  src/client/compositor.cpp
  src/client/connection_thread.cpp
  src/client/shell.cpp
  src/client/surface.cpp

To: graesslin, #frameworks, #kwin, #flatpak
Cc: plasma-devel, leezu, ZrenBot, alexeymin, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D8050: Expose wl_display_set_global_filter as a virtual method

2017-10-11 Thread Martin Flöser

graesslin accepted this revision.
graesslin added a comment.


  I'm accepting this revision again. The CI system needs to have the PPA 
activated again as the old CI system had.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D8050

To: davidedmundson, #plasma, graesslin, bcooksley
Cc: bcooksley, graesslin, plasma-devel, #frameworks, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8050: Expose wl_display_set_global_filter as a virtual method

2017-10-11 Thread Martin Flöser

graesslin added a comment.


  In https://phabricator.kde.org/D8050#154207, @bcooksley wrote:
  
  > Please remedy the Wayland dependency incompatibility.
  >
  > In the event the relevant package is not available in the distribution in 
question, you'll need to contact it's packagers and make the appropriate 
arrangements before filing any Sysadmin tickets for a version upgrade to be 
made.
  
  
  @bcooksley in the old CI system we had a PPA for the latest and greatest 
Wayland in the Ubuntu installs. Why is this missing now? It didn't occur to me 
that this would cause a regression as we fixed this issue years ago...

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D8050

To: davidedmundson, #plasma, graesslin, bcooksley
Cc: bcooksley, graesslin, plasma-devel, #frameworks, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8243: Implement support for categories on KfilesPlacesView

2017-10-11 Thread Anthony Fieroni

anthonyfieroni added a reviewer: dfaure.
anthonyfieroni added inline comments.

INLINE COMMENTS

> kfileplacesview.h:37
>   */
> -class KIOFILEWIDGETS_EXPORT KFilePlacesView : public QListView
> +class KIOFILEWIDGETS_EXPORT KFilePlacesView : public KCategorizedView
>  {

You cannot do that, you have better chance to win a lottery than to keep ABI 
compatibility. Better approach is to make changes in delegate.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8243

To: renatoo, #frameworks, dfaure
Cc: anthonyfieroni, cfeck, #frameworks

D8243: Implement support for categories on KfilesPlacesView

2017-10-11 Thread Christoph Feck

cfeck added a reviewer: Frameworks.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8243

To: renatoo, #frameworks
Cc: cfeck, #frameworks

D8243: Implement support for categories on KfilesPlacesView

2017-10-11 Thread Renato Oliveira Filho

renatoo created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  Make use of KCategorizedView on file dialogs to classify the entries in
  groups,
  most similar as possible with dolphin

TEST PLAN
  From an kde app try to open/save a file.
  It should show a new file dialog with categories on the places planel

REPOSITORY
  R241 KIO

BRANCH
  model-hide-row

REVISION DETAIL
  https://phabricator.kde.org/D8243

AFFECTED FILES
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesitem_p.h
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h
  src/filewidgets/kfileplacesview.cpp
  src/filewidgets/kfileplacesview.h

To: renatoo
Cc: #frameworks

D7884: - Increase size of trailing mark

2017-10-11 Thread Kåre Särs

sars added a comment.


  I'm OK with an option for this. The only problem, with the option in the 
screen-shot, is that it could be interpreted as also effecting the tabulator 
mark.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D7884

To: helio, mwolff, kfunk
Cc: cullmann, anthonyfieroni, dhaumann, sars, #frameworks

D7660: Fix a regression caused by changing backspace key behavior

2017-10-11 Thread Anthony Fieroni

anthonyfieroni added inline comments.

INLINE COMMENTS

> katedocument.cpp:3169-3223
>  if (!(config()->backspaceIndents())) {
>  // ordinary backspace
> -KTextEditor::Cursor beginCursor(line, 
> view->textLayout(c)->previousCursorPosition(c.column()));
> +KTextEditor::Cursor beginCursor(line, 0);
>  KTextEditor::Cursor endCursor(line, col);
> -
> +if (!view->config()->backspaceRemoveComposed()) { // Normal 
> backspace behavior
> +// move to left of surrogate pair
> +if (!isValidTextPosition(beginCursor)) {

This peace of code should be simplified, to not have code dublication.

  if (config()->backspaceIndents()) {
   // backspace indents: erase to next indent position
Kate::TextLine textLine = m_buffer->plainLine(line);
  
// don't forget this check really
if (!textLine) {
return;
}
  
int colX = textLine->toVirtualColumn(col, config()->tabWidth());
int pos = textLine->firstChar();
if (pos > 0) {
pos = textLine->toVirtualColumn(pos, config()->tabWidth());
}
  
if (pos < 0 || pos >= (int)colX) {
// only spaces on left side of cursor
indent(KTextEditor::Range(line, 0, line, 0), -1);
}
  }

Then validate pos and add 2 backspace behaviors.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D7660

To: safaalfulaij, #ktexteditor, jgrulich, hein, dhaumann
Cc: anthonyfieroni, cullmann, jgrulich, dhaumann, hein, kwrite-devel, 
#frameworks

D7660: Fix a regression caused by changing backspace key behavior

2017-10-11 Thread Christoph Cullmann

cullmann added a comment.


  All issues addressed, or?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D7660

To: safaalfulaij, #ktexteditor, jgrulich, hein, dhaumann
Cc: cullmann, jgrulich, dhaumann, hein, kwrite-devel, #frameworks

D7884: - Increase size of trailing mark

2017-10-11 Thread Christoph Cullmann

cullmann added a comment.


  Given it seems Atom even has the option to choose the sign for that, we can 
live with an option I assume (and the code for it is already written anyways).
  
  Others ok with that, too?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D7884

To: helio, mwolff, kfunk
Cc: cullmann, anthonyfieroni, dhaumann, sars, #frameworks

D8050: Expose wl_display_set_global_filter as a virtual method

2017-10-11 Thread David Edmundson

davidedmundson added a comment.


  This was reverted since yesterday when we noticed CI failed.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D8050

To: davidedmundson, #plasma, graesslin, bcooksley
Cc: bcooksley, graesslin, plasma-devel, #frameworks, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8050: Expose wl_display_set_global_filter as a virtual method

2017-10-11 Thread Ben Cooksley

bcooksley requested changes to this revision.
bcooksley added a comment.
This revision now requires changes to proceed.


  Please remedy the Wayland dependency incompatibility.
  
  In the event the relevant package is not available in the distribution in 
question, you'll need to contact it's packagers and make the appropriate 
arrangements before filing any Sysadmin tickets for a version upgrade to be 
made.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D8050

To: davidedmundson, #plasma, graesslin, bcooksley
Cc: bcooksley, graesslin, plasma-devel, #frameworks, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8050: Expose wl_display_set_global_filter as a virtual method

2017-10-11 Thread Ben Cooksley

bcooksley reopened this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D8050

To: davidedmundson, #plasma, graesslin
Cc: graesslin, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7369: Wayland foreign protocol

2017-10-11 Thread Marco Martin

mart added a comment.


  In https://phabricator.kde.org/D7369#154153, @graesslin wrote:
  
  > In https://phabricator.kde.org/D7369#153978, @mart wrote:
  >
  > > In https://phabricator.kde.org/D7369#152358, @graesslin wrote:
  > >
  > > > Documentation is still missing, Unstable suffix is still in two many 
API calls.
  > >
  > >
  > > i think the importerUnstableV2Announced exporterUnstableV2Announced 
should remain with unstable and versioned?
  >
  >
  > Yes, those can stay. Other signals are similar.
  
  
  so how is the current state, can go in? (btw, the unstable-v2 protocol was 
just pushed to master, so another roadblock done)

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D7369

To: mart, #plasma, #kwin, davidedmundson, graesslin
Cc: davidedmundson, graesslin, plasma-devel, #frameworks, leezu, ZrenBot, 
alexeymin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, 
sebas, apol, mart, hein

D7369: Wayland foreign protocol

2017-10-11 Thread Marco Martin

mart updated this revision to Diff 20584.
mart added a comment.
Restricted Application edited projects, added Plasma on Wayland; removed Plasma.


  - update to the upstream xml protocol

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7369?vs=20553=20584

BRANCH
  mart/xdgforeign

REVISION DETAIL
  https://phabricator.kde.org/D7369

AFFECTED FILES
  autotests/client/CMakeLists.txt
  autotests/client/test_xdg_foreign.cpp
  src/client/CMakeLists.txt
  src/client/protocols/xdg-foreign-unstable-v2.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/xdgforeign.cpp
  src/client/xdgforeign.h
  src/client/xdgforeign_p.h
  src/client/xdgforeign_v2.cpp
  src/client/xdgforeign_v2.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/xdgforeign_interface.cpp
  src/server/xdgforeign_interface.h
  src/server/xdgforeign_v2_interface.cpp
  src/server/xdgforeign_v2_interface_p.h
  tests/CMakeLists.txt
  tests/xdgforeigntest.cpp

To: mart, #plasma, #kwin, davidedmundson, graesslin
Cc: davidedmundson, graesslin, plasma-devel, #frameworks, leezu, ZrenBot, 
alexeymin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, 
sebas, apol, mart, hein

KDE CI: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 - Build # 55 - Fixed!

2017-10-11 Thread CI System

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20XenialQt5.7/55/
 Project:
Frameworks kcoreaddons kf5-qt5 XenialQt5.7
 Date of build:
Wed, 11 Oct 2017 06:56:21 +
 Build duration:
9 min 4 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 25 test(s), Skipped: 0 test(s), Total: 25 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(10/10)85%
(79/93)85%
(79/93)74%
(6131/8297)44%
(10750/24682)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests83%
(33/40)83%
(33/40)97%
(2631/2718)49%
(6497/13336)src.desktoptojson100%
(3/3)100%
(3/3)79%
(84/106)38%
(123/324)src.lib67%
(2/3)67%
(2/3)60%
(325/541)27%
(220/821)src.lib.caching100%
(2/2)100%
(2/2)45%
(352/787)18%
(192/1076)src.lib.io90%
(9/10)90%
(9/10)61%
(848/1397)33%
(1055/3166)src.lib.jobs71%
(5/7)71%
(5/7)52%
(159/304)39%
(57/146)src.lib.plugin100%
(8/8)100%
(8/8)85%
(650/763)44%
(986/2266)src.lib.randomness100%
(2/2)100%
(2/2)67%
(66/99)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)46%
(349/764)40%
(748/1867)src.lib.util100%
(10/10)100%
(10/10)82%
(667/818)52%
(828/1604)

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 - Build # 51 - Still Unstable!

2017-10-11 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/51/
 Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7
 Date of build:
Wed, 11 Oct 2017 06:56:21 +
 Build duration:
2 min 14 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 21 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_stat_unittest

47 matches

Mail list logo