D8352: Use KIO::PreviewJob::defaultPlugins()
This revision was automatically updated to reflect the committed changes. Closed by commit R320:76375dcd7c8a: Use KIO::PreviewJob::defaultPlugins() (authored by ngraham). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8352?vs=20929=21032 REVISION DETAIL https://phabricator.kde.org/D8352 AFFECTED FILES thumbnail/thumbnail.cpp To: ngraham, #frameworks, broulik, elvisangelaccio, markg
D8387: Workaround incorrectly returned EEXIST instead of EPERM regression introduced by libsmbclient 4.7
ngraham added a reviewer: Frameworks. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D8387 To: madcatx, ngraham, davidedmundson, elvisangelaccio, #frameworks Cc: z3ntu
D8352: Use KIO::PreviewJob::defaultPlugins()
ngraham added a comment. Yep, I have tested that in https://phabricator.kde.org/D7440. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabricator.kde.org/D8352 To: ngraham, #frameworks, broulik, elvisangelaccio, markg
D8352: Use KIO::PreviewJob::defaultPlugins()
markg accepted this revision. markg added a comment. This revision is now accepted and ready to land. Please do make sure (just as a test before you push this) that the default plugins (which now is all except for the text plugin if i recall correctly) are enabled in Dolphin' settings (General -> Previews). REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabricator.kde.org/D8352 To: ngraham, #frameworks, broulik, elvisangelaccio, markg
D8352: Use KIO::PreviewJob::defaultPlugins()
ngraham added reviewers: broulik, elvisangelaccio, markg. ngraham added a comment. The dependent revision is now merged. Anyone object to this? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D8352 To: ngraham, #frameworks, broulik, elvisangelaccio, markg
D8383: [server] Support inhibiting the IdleInterface
graesslin created this revision. graesslin added reviewers: Frameworks, KWin, Plasma on Wayland. Restricted Application added a subscriber: plasma-devel. Restricted Application added projects: Plasma on Wayland, Frameworks. REVISION SUMMARY This is a preparation step to support idle_inhibit_unstable_v1 protocol. As in Plasma powermanagement, screen locking, dpms, etc. is not controlled by the wayland compositor but by external components through the IdleTimeout interface the compositor needs a way to inhibit the idle timeouts. So once idle_inhibit_unstable_v1 is implemented the compositor can hook this up to the inhibit API in IdleInterface and thus inhibit powermanagement, etc. as requested by the idle_inhibit_unstable_v1 protocol. The added API is straight forward: - inhibit: inhibits idle timeouts - uninhibit: uninhibits again - inhibit and uninhibit must be called in pairs, so twice inhibit, means uninhibit must be called twice - isInhibited: whether it's inhibited - and a signal that it changed The signal is mostly used internally to stop the timers. TEST PLAN Test case extended REPOSITORY R127 KWayland BRANCH inhibit-idle REVISION DETAIL https://phabricator.kde.org/D8383 AFFECTED FILES autotests/client/test_idle.cpp src/server/idle_interface.cpp src/server/idle_interface.h To: graesslin, #frameworks, #kwin, #plasma_on_wayland Cc: plasma-devel, leezu, ZrenBot, alexeymin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein
KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.7 - Build # 53 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.7/53/ Project: Frameworks kwayland kf5-qt5 FreeBSDQt5.7 Date of build: Fri, 20 Oct 2017 13:45:50 + Build duration: 12 min and counting JUnit Tests Name: (root) Failed: 17 test(s), Passed: 17 test(s), Skipped: 1 test(s), Total: 35 test(s)Failed: TestSuite.kwayland-testCompositorFailed: TestSuite.kwayland-testDataDeviceFailed: TestSuite.kwayland-testDataSourceFailed: TestSuite.kwayland-testRegionFailed: TestSuite.kwayland-testShmPoolFailed: TestSuite.kwayland-testSubCompositorFailed: TestSuite.kwayland-testSubSurfaceFailed: TestSuite.kwayland-testTextInputFailed: TestSuite.kwayland-testWaylandConnectionThreadFailed: TestSuite.kwayland-testWaylandFullscreenShellFailed: TestSuite.kwayland-testWaylandRegistryFailed: TestSuite.kwayland-testWaylandServerDisplayFailed: TestSuite.kwayland-testWaylandShellFailed: TestSuite.kwayland-testWaylandSurfaceFailed: TestSuite.kwayland-testWindowmanagementFailed: TestSuite.kwayland-testXdgForeignFailed: TestSuite.kwayland-testXdgShellV5
D8250: [client] Drop the checks for platformName being "wayland"
This revision was automatically updated to reflect the committed changes. Closed by commit R127:1203580ca069: [client] Drop the checks for platformName being wayland (authored by graesslin). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8250?vs=20602=21012 REVISION DETAIL https://phabricator.kde.org/D8250 AFFECTED FILES src/client/compositor.cpp src/client/connection_thread.cpp src/client/shell.cpp src/client/surface.cpp To: graesslin, #frameworks, #kwin, #flatpak, davidedmundson Cc: davidedmundson, plasma-devel, leezu, ZrenBot, alexeymin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein
KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.7 - Build # 123 - Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.7/123/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.7 Date of build: Fri, 20 Oct 2017 12:56:05 + Build duration: 25 min and counting JUnit Tests Name: (root) Failed: 32 test(s), Passed: 21 test(s), Skipped: 0 test(s), Total: 53 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiofilewidgets-kdiroperatortestFailed: TestSuite.kiofilewidgets-kfilecopytomenutestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiofilewidgets-kfilewidgettestFailed: TestSuite.kiofilewidgets-knewfilemenutestFailed: TestSuite.kiofilewidgets-kurlcomboboxtestFailed: TestSuite.kiofilewidgets-kurlnavigatortestFailed: TestSuite.kiofilewidgets-kurlrequestertestFailed: TestSuite.kiogui-favicontestFailed: TestSuite.kioslave-httpauthenticationtestFailed: TestSuite.kioslave-httpheaderdispositiontestFailed: TestSuite.kioslave-httpheadertokenizetestFailed: TestSuite.kioslave-httpobjecttestFailed: TestSuite.kioslave-kcookiejartestFailed: TestSuite.kiowidgets-accessmanagertestFailed: TestSuite.kiowidgets-accessmanagertest-qnamFailed: TestSuite.kiowidgets-clipboardupdatertestFailed: TestSuite.kiowidgets-dropjobtestFailed: TestSuite.kiowidgets-fileundomanagertestFailed: TestSuite.kiowidgets-jobguitestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltestFailed: TestSuite.kiowidgets-kfileitemactionstestFailed: TestSuite.kiowidgets-krununittestFailed: TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: TestSuite.kiowidgets-kurifiltertestFailed: TestSuite.kiowidgets-kurlcompletiontestFailed: TestSuite.kiowidgets-kurlcompletiontest-nowaitFailed: TestSuite.kiowidgets-pastetestFailed: TestSuite.kpasswdservertest
D8250: [client] Drop the checks for platformName being "wayland"
graesslin added a comment. In https://phabricator.kde.org/D8250#157282, @davidedmundson wrote: > Meh. > We're potentially gonna get some mental crashes. Yes, but it should also be obvious. If it crashes with one of these methods in the backtrace we can be sure someone didn't check properly. REPOSITORY R127 KWayland BRANCH drop-platform-check REVISION DETAIL https://phabricator.kde.org/D8250 To: graesslin, #frameworks, #kwin, #flatpak, davidedmundson Cc: davidedmundson, plasma-devel, leezu, ZrenBot, alexeymin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein
D8296: Use Alt+, as the standard shortcut for "Configure "
ngraham added a comment. If there are no objections, can someone grudgingly mark it as approved? ;-) REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D8296 To: ngraham, #frameworks, #vdg Cc: aacid, argonel, kfunk, marten, graesslin, broulik, #frameworks
KDE CI: Frameworks kio kf5-qt5 XenialQt5.7 - Build # 122 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20XenialQt5.7/122/ Project: Frameworks kio kf5-qt5 XenialQt5.7 Date of build: Fri, 20 Oct 2017 12:56:05 + Build duration: 19 min and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: TestSuite.kiowidgets-kurifiltertest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report100% (22/22)80% (278/346)80% (278/346)57% (29961/52254)42% (16564/39299)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (67/67)100% (67/67)96% (8078/8399)51% (4500/8824)autotests.http100% (9/9)100% (9/9)100% (543/544)60% (200/336)autotests.kcookiejar100% (1/1)100% (1/1)90% (179/198)67% (60/90)src.core85% (99/117)85% (99/117)57% (8157/14198)49% (4560/9279)src.core.kssl100% (1/1)100% (1/1)38% (35/93)50% (3/6)src.filewidgets73% (27/37)73% (27/37)46% (3491/7603)30% (1300/4403)src.gui100% (2/2)100% (2/2)95% (104/110)75% (54/72)src.ioslaves.file100% (2/2)100% (2/2)51% (435/849)42% (317/749)src.ioslaves.http100% (8/8)100% (8/8)47% (1762/3781)38% (1317/3462)src.ioslaves.http.kcookiejar100% (2/2)100% (2/2)80% (622/782)72% (608/839)src.ioslaves.remote100% (2/2)100% (2/2)27% (70/258)8% (16/200)src.ioslaves.trash80% (8/10)80% (8/10)60% (704/1173)47% (404/851)src.ioslaves.trash.tests100% (2/2)100% (2/2)90% (707/785)48% (461/970)src.kioslave100% (1/1)100% (1/1)52% (14/27)50% (5/10)src.kntlm100% (2/2)100% (2/2)97% (373/385)80% (111/138)src.kpasswdserver100% (2/2)100% (2/2)63% (377/594)48% (280/580)src.kpasswdserver.autotests100% (1/1)100% (1/1)99% (283/286)57%
D8347: KIO::PreviewJob::defaultPlugins() function
This revision was automatically updated to reflect the committed changes. Closed by commit R241:3042e12296db: KIO::PreviewJob::defaultPlugins() function (authored by ngraham). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8347?vs=21004=21005#toc REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8347?vs=21004=21005 REVISION DETAIL https://phabricator.kde.org/D8347 AFFECTED FILES src/widgets/previewjob.cpp src/widgets/previewjob.h To: ngraham, #frameworks, broulik, #dolphin, markg Cc: markg, anthonyfieroni, elvisangelaccio, #frameworks
D8347: KIO::PreviewJob::defaultPlugins() function
ngraham updated this revision to Diff 21004. ngraham added a comment. Correcting the @since version number REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8347?vs=20975=21004 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8347 AFFECTED FILES src/widgets/previewjob.cpp src/widgets/previewjob.h To: ngraham, #frameworks, broulik, #dolphin, markg Cc: markg, anthonyfieroni, elvisangelaccio, #frameworks
D8243: Implement support for categories on KfilesPlacesView
ngraham added a comment. @markg Ultimately I think everyone is in agreement in wanting the "single scrollbar" approach for items in whatever you call the default list on Dolphin's left side. Splitting everything into distinct panels and embedding all the panels in a single scrollview is one way to get there. Putting all the features people want in the Places panel is another way. I don't have super strong feelings on the approach taken, because I think either one will get where we want to go, but I do see a lot more activity and excitement in the "add things to the Places panel" approach. Since you prefer the "make everything its own panel" approach, maybe you can submit a patch so we can judge the different approaches somewhere separate and we don't have to have the same discussion every time someone proposes adding something to the places panel. :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8243 To: renatoo, #frameworks, dfaure, ervin, #vdg Cc: markg, ngraham, mlaurent, ervin, anthonyfieroni, cfeck, #frameworks
D8243: Implement support for categories on KfilesPlacesView
markg added a comment. In https://phabricator.kde.org/D8243#157346, @renatoo wrote: > In https://phabricator.kde.org/D8243#157336, @markg wrote: > > > We have such a nice modular design with panels yet we keep cramming everything in the places panel... Why? > > It's not just here, I've seen patches like this for Dolphin as well. > > > > Imho, the places panel should only contain the top places - favorites if you will - that you might want to access quickly. Nothing else and should stay small. > > Baloo -> new panel > > Devices -> new panel > > Remote devices -> Either in Devices or a new panel as well > > etc.. > > > > Having more panels will give a whole different issues. Scrolling. Since each panel would be relatively small if you add many you will get scrollbars within the panels. Well, lets just get rid of the per panel scrollbar and merely have one for the whole "panel container" (like in macOS finder). > > > > Just my 5 cents... > > > @markg, I never used macOs finder, but looking at the internet images. This is exactly what I am proposing and what we have on dolphin today. A single list with only one scrollbar split in sections. > > I am just trying to keep the same visuals on both (dolphin and file dialog) to avoid confusion for users, they can get lost if you show different information. > > > Our final idea is that you will be able to hide sections that you do not want, For example the local devices and network. You "intend" to, yes :) But with your changes you get the situation where you have multiple scrollbars if you have multiple panels enabled, one scrollbar in each panel. In Finder, you have 1 scrollbar for the whole panel area. I like the goal! I want to get there as well! But it would be my preference to get there with individual panels. That would also make the code much simpler. Anyhow, that's just a "i would like..." opinion. It's not a critic to slow you down or stop this patch. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8243 To: renatoo, #frameworks, dfaure, ervin, #vdg Cc: markg, ngraham, mlaurent, ervin, anthonyfieroni, cfeck, #frameworks
D8243: Implement support for categories on KfilesPlacesView
renatoo added a comment. In https://phabricator.kde.org/D8243#157336, @markg wrote: > We have such a nice modular design with panels yet we keep cramming everything in the places panel... Why? > It's not just here, I've seen patches like this for Dolphin as well. > > Imho, the places panel should only contain the top places - favorites if you will - that you might want to access quickly. Nothing else and should stay small. > Baloo -> new panel > Devices -> new panel > Remote devices -> Either in Devices or a new panel as well > etc.. > > Having more panels will give a whole different issues. Scrolling. Since each panel would be relatively small if you add many you will get scrollbars within the panels. Well, lets just get rid of the per panel scrollbar and merely have one for the whole "panel container" (like in macOS finder). > > Just my 5 cents... @markg, I never used macOs finder, but looking at the internet images. This is exactly what I am proposing and what we have on dolphin today. A single list with only one scrollbar split in sections. I am just trying to keep the same visuals on both (dolphin and file dialog) to avoid confusion for users, they can get lost if you show different information. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8243 To: renatoo, #frameworks, dfaure, ervin, #vdg Cc: markg, ngraham, mlaurent, ervin, anthonyfieroni, cfeck, #frameworks
D8348: Add a section for removable devices
renatoo updated this revision to Diff 21003. renatoo added a comment. Fixed unit test REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8348?vs=20987=21003 REVISION DETAIL https://phabricator.kde.org/D8348 AFFECTED FILES autotests/kfileplacesmodeltest.cpp src/filewidgets/kfileplacesitem.cpp src/filewidgets/kfileplacesitem_p.h To: renatoo, #dolphin, #frameworks, #vdg Cc: anthonyfieroni, ngraham, #frameworks
D8243: Implement support for categories on KfilesPlacesView
markg added a comment. We have such a nice modular design with panels yet we keep cramming everything in the places panel... Why? It's not just here, I've seen patches like this for Dolphin as well. Imho, the places panel should only contain the top places - favorites if you will - that you might want to access quickly. Nothing else and should stay small. Baloo -> new panel Devices -> new panel Remote devices -> Either in Devices or a new panel as well etc.. Having more panels will give a whole different issues. Scrolling. Since each panel would be relatively small if you add many you will get scrollbars within the panels. Well, lets just get rid of the per panel scrollbar and merely have one for the whole "panel container" (like in macOS finder). Just my 5 cents... REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8243 To: renatoo, #frameworks, dfaure, ervin, #vdg Cc: markg, ngraham, mlaurent, ervin, anthonyfieroni, cfeck, #frameworks
D8250: [client] Drop the checks for platformName being "wayland"
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Meh. We're potentially gonna get some mental crashes. Can't find a better option though :/ REPOSITORY R127 KWayland BRANCH drop-platform-check REVISION DETAIL https://phabricator.kde.org/D8250 To: graesslin, #frameworks, #kwin, #flatpak, davidedmundson Cc: davidedmundson, plasma-devel, leezu, ZrenBot, alexeymin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein
