date:20171024

D8461: Remove unused config.h.cmake entries

2017-10-24 Thread David Kahles

davidk updated this revision to Diff 21277.
davidk added a comment.


  Fix commit message.

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8461?vs=21276=21277

BRANCH
  cleanup

REVISION DETAIL
  https://phabricator.kde.org/D8461

AFFECTED FILES
  ConfigureChecks.cmake
  config.h.cmake

To: davidk
Cc: #frameworks

D8461: Remove unused config.h.cmake entries

2017-10-24 Thread David Kahles

davidk created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  I'm not sure why they were introduced, but they aren't used anywhere in the
  code.

TEST PLAN
  - "grep -r HAVE_MALLOC_H baloo"
  - "grep -r HAVE_MALLOC_TRIM baloo"
- Compiles.

REPOSITORY
  R293 Baloo

BRANCH
  cleanup

REVISION DETAIL
  https://phabricator.kde.org/D8461

AFFECTED FILES
  ConfigureChecks.cmake
  config.h.cmake

To: davidk
Cc: #frameworks

D7828: createKMessageBox tries to focus a default button when available

2017-10-24 Thread Nathaniel Graham

ngraham added a comment.


  In https://phabricator.kde.org/D7828#159556, @abetts wrote:
  
  > If you have two highlights, how do you know what's going to be activated 
when hitting enter?
  
  
  My thoughts exactly.

REVISION DETAIL
  https://phabricator.kde.org/D7828

To: emateli, #frameworks, ngraham, aacid, #vdg
Cc: abetts, subdiff, ngraham, aacid, #frameworks

D7194: Detach before setting the d pointer

2017-10-24 Thread Friedrich W . H . Kossebau

kossebau added subscribers: whiting, kossebau.
kossebau added a comment.


  @apol  @whiting @leinir This change might have broken quite some things: 
EntryInternal has been an explicitly shared data object for some years (cmp. 
`QExplicitlySharedDataPointer d;`), and quite some logic seems to 
depend on that. E.g `ItemsModel`, which keeps a separate copy of the list of 
EntryInternal objects, does not update those objects on changes, but relies on 
this to happen automagically due to the explicitely shared data, 
https://phabricator.kde.org/R304:c32c8d002e1216373560c94738841a7a5e1b976b tries 
to work-around that, but actually makes things more convoluted.
  Same with `DownloadWidgetPrivate` and `Cache`, which both keep a set of 
changed entries as a `QSet`, which they maintain by 
`QSet::insert()`, just that this will due to same uniqueId not update the 
contained item to the latest version. Still those (potentially outdated) 
objects are then passed via signals to e.g. library consumers, which get 
outdated or incomplete data (like installedFiles values).
  Similar issue with `AtticaProvider::entryFromAtticaContent()` which also 
assumes in the logic explicitly shared data so the cache object gets all the 
updated data as well.
  
  Given this is a public class, this is quite some behavioural change. One 
could assume this breaks 3rd-party code in a similar way. There is no 
specification of the behaviour in the API dox though, so unsure myself what is 
the best solution: 
https://api.kde.org/frameworks/knewstuff/html/classKNSCore_1_1EntryInternal.html
  
  One fallout is at least this bug: https://bugs.kde.org/show_bug.cgi?id=386156
  
  I had started a patch to fix this, but it has grown a lot to make up for the 
now no longer explicitely shared nature of this class, and there are still 
issues in some places. So I wonder if it is better to simply revert this commit 
instead, document the old behaviour properly in the API and fix the places 
which rely on non-explicitely shared data objects. That might be only some 
newer code, given the old behaviour has stayed around for some years.
  
  What do you think?

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D7194

To: apol, leinir
Cc: kossebau, whiting, mutlaqja, broulik, #frameworks

D7828: createKMessageBox tries to focus a default button when available

2017-10-24 Thread Andres Betts

abetts added a comment.


  I am leaning toward implementing the change. The reason being that the user 
gets a duplicate indication of focus when likely they might feel confused, I 
have been at times too, by not knowing clearly where the highlight is. If you 
have two highlights, how do you know what's going to be activated when hitting 
enter?

REVISION DETAIL
  https://phabricator.kde.org/D7828

To: emateli, #frameworks, ngraham, aacid, #vdg
Cc: abetts, subdiff, ngraham, aacid, #frameworks

D7828: createKMessageBox tries to focus a default button when available

2017-10-24 Thread Roman Gilg

subdiff added a comment.


  Hi Emirald,
  
  first let me tell you that I totally get where you're coming from. To be 
honest the selected checkbox in this specific dialog of Dolphin has annoyed me 
already for a long time. So thank you for looking into this.
  
  But we have to dissect the situation a bit more: A button with focus and the 
default button in a KMessageBox are two different things per definition as 
Albert pointed out.
  
  That said I can only think of one sensible case where this distinction makes 
sense: When //no// element has focus, but you still want a default action to 
trigger on Enter. In any case having focus on some control element but then 
pressing Enter triggering an action related to some other button doesn't seem 
like good Ui to me. So this sounds similar to what you say.
  
  But in the end it should be up to the app developer to decide if the focus 
and default action element are the same one or different ones in his 
KMessageBox. I would still advise him in general to not make them different, 
but don't forget that your change is a change in Frameworks restricting it to 
our presumed best practice for //all// apps using a KMessageBox. And there 
might be corner cases we haven't thought about, where different focus and 
default action make sense.
  
  That said the focused checkbox in Dolphin should go away (as I said in the 
beginning it annoyed me already for a longer time). The rationale behind this 
was maybe, so a user could press Space for activating the checkbox and Enter 
for triggering the default action, but checking a focused checkbox with Space 
and not Enter isn't obvious and this checkbox also isn't something a user 
totally needs to have one button keyboard access to. So just set in this 
specific Dolphin dialog the focus item to the Ok button. By the way this is not 
something totally new to Dolphin. The "Confirm delete" dialog has its default 
button focused.

REVISION DETAIL
  https://phabricator.kde.org/D7828

To: emateli, #frameworks, ngraham, aacid, #vdg
Cc: subdiff, ngraham, aacid, #frameworks

D8457: Don't build the kconfig_compiler tests when crosscompiling

2017-10-24 Thread Aleix Pol Gonzalez

apol created this revision.
apol added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  We will be using an external version of it in practice

REPOSITORY
  R237 KConfig

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8457

AFFECTED FILES
  autotests/CMakeLists.txt

To: apol, #frameworks

D7828: createKMessageBox tries to focus a default button when available

2017-10-24 Thread Nathaniel Graham

ngraham added a comment.


  In https://phabricator.kde.org/D7828#159511, @aacid wrote:
  
  > > Without this patch, the *actual* default button is virtually 
indistinguishable from other buttons when it doesn't have focus. It looks like 
this, with only a slightly lighter background than the other buttons:
  >
  > This is a bug of the breeze style, go fix it there.
  
  
  Sure: https://bugs.kde.org/show_bug.cgi?id=386158
  
  If the Breeze folks indicate that their preferred solution is to implement 
this patch, can we go for it?

REVISION DETAIL
  https://phabricator.kde.org/D7828

To: emateli, #frameworks, ngraham, aacid, #vdg
Cc: ngraham, aacid, #frameworks

D8427: Allow cross compiling resource file

2017-10-24 Thread Aleix Pol Gonzalez

apol added a comment.


  Hey @vpinon. What's special about qrcAlias is that it's not installed. 
Usually this kind of tooling (thinking kconfigcompiler) is installed, then 
there's an easy way to pull it in.
  
  I'd say that the ideal way to treat this is by rewriting the tool in cmake 
scripts (or python or a scripting language we agree it makes sense). This way 
this becomes a no-brainer.
  
  As for this patch, I'd suggest something like:
  
-DQRCALIAS_EXECUTABLE=

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8427

To: vpinon, apol, kfunk
Cc: #frameworks, bartoloni, benjaminnelan, afarid, fernandoteles, mardelle

D7828: createKMessageBox tries to focus a default button when available

2017-10-24 Thread Albert Astals Cid

aacid added a comment.


  > You can't interact with the list so it is ruled out for being focused. The 
check box acts as a confirmation and thus is a secondary element which you also 
do not want to toggle by mistake, so it rests upon the buttons to have it.
  
  This makes some sense, but aren't you are breaking existing code?
  
  see detailedErrorInternal, detailedSorryInternal, they call setFocus on a 
button which you are probably then overriding?

REVISION DETAIL
  https://phabricator.kde.org/D7828

To: emateli, #frameworks, ngraham, aacid, #vdg
Cc: ngraham, aacid, #frameworks

D7828: createKMessageBox tries to focus a default button when available

2017-10-24 Thread Albert Astals Cid

aacid added a comment.


  > Without this patch, the *actual* default button is virtually 
indistinguishable from other buttons when it doesn't have focus. It looks like 
this, with only a slightly lighter background than the other buttons:
  
  This is a bug of the breeze style, go fix it there.

REVISION DETAIL
  https://phabricator.kde.org/D7828

To: emateli, #frameworks, ngraham, aacid, #vdg
Cc: ngraham, aacid, #frameworks

D8437: KWidgetsAddons : more compact password dialog

2017-10-24 Thread Kevin Funk

kfunk requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D8437

To: rjvbb, #frameworks, kfunk
Cc: cfeck, ngraham

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-10-24 Thread Simone Gaiarin

simgunz added a comment.


  Ok. Now it should work properly.
  
  I've also added a tooltip to the search box to explain the down arrow feature 
so that it is not hidden.
  The current text is: "Type some text to filter the application tree.\nPress 
down arrow to navigate the results tree."

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8056

To: simgunz, dfaure, #frameworks, #vdg, ngraham
Cc: abetts, ngraham, alexeymin, #frameworks

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-10-24 Thread Simone Gaiarin

simgunz updated this revision to Diff 21261.
simgunz added a comment.


  - Automatically select first match of the filter
  - ArrowDown on lineEdit pass focus to QTreeView
  - Add tooltip to explain how to use the search filter

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8056?vs=20087=21261

BRANCH
  openwithdialog-filter-app-tree

REVISION DETAIL
  https://phabricator.kde.org/D8056

AFFECTED FILES
  src/widgets/kopenwithdialog.cpp
  src/widgets/kopenwithdialog.h
  src/widgets/kopenwithdialog_p.h

To: simgunz, dfaure, #frameworks, #vdg, ngraham
Cc: abetts, ngraham, alexeymin, #frameworks

D8427: Allow cross compiling resource file

2017-10-24 Thread Vincent Pinon

vpinon added a comment.


  Note: if you want to see the rest of frameworks cross-building for Kdenlive:
  https://github.com/vpinon/mxe/tree/master/plugins/kdeframeworks

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8427

To: vpinon, apol, kfunk
Cc: #frameworks, bartoloni, benjaminnelan, afarid, fernandoteles, mardelle

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

2017-10-24 Thread Simone Gaiarin

simgunz added a comment.


  Here is a picture:
  
  F5448036: openwith_filter.png 

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8056

To: simgunz, dfaure, #frameworks, #vdg, ngraham
Cc: abetts, ngraham, alexeymin, #frameworks

D8427: Allow cross compiling resource file

2017-10-24 Thread Vincent Pinon

vpinon added a comment.


  Thank you Aleix,
  You're right!
  //Before// launching cmake for cross compiling, I build the tool for host 
(this requires to have Qt5 dev files on build host):
  I haven't found a way to access the host compiler & libs //within// cmake 
(which has a toolchain file to switch to cross-compiling).
  My complete cross compiling sequence is (in Makefile syntax for MXE):
  
cd "$(1)" && $(BUILD_CXX) -std=c++11 qrcAlias.cpp -o $(PREFIX)/bin/qrcAlias 
-fPIC $(shell pkg-config --cflags Qt5Core --libs Qt5Core)
mkdir "$(1)/build"
cd "$(1)/build" && cmake .. \
-DCMAKE_TOOLCHAIN_FILE="$(CMAKE_TOOLCHAIN_FILE)" \
-DCMAKE_BUILD_TYPE=Release \
-DKDE_INSTALL_USE_QT_SYS_PATHS=ON \
-DBUILD_TESTING=OFF \
-DBINARY_ICONS_RESOURCE=ON \
-DQRCALIAS_EXECUTABLE=$(PREFIX)/bin/qrcAlias
$(MAKE) -C "$(1)/build" -j $(JOBS) install
  
  Would you have directions for a better approach? Or should I just add in 
comment the line to build qrcAlias?
  I wanted to have a look at how KF5_HOST_TOOLING works, but couldn't find 
where it is defined in ECM or in the frameworks that use it (kdecoration, 
kdeclarative)...

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D8427

To: vpinon, apol, kfunk
Cc: #frameworks, bartoloni, benjaminnelan, afarid, fernandoteles, mardelle

D8451: JavaScript: include standard mime types

2017-10-24 Thread Nikita Skovoroda

ChALkeR edited the summary of this revision.
ChALkeR added a reviewer: Framework: Syntax Highlighting.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D8451

To: ChALkeR, #framework_syntax_highlighting
Cc: #frameworks

D8451: JavaScript: include standard mime types

2017-10-24 Thread Nikita Skovoroda

ChALkeR created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  Add application/javascript and text/javascript mimetypes to
  javascript.xml
  
  application/javascript is the main one used in shared-mime-info,
  without it syntax highlighting is not working for *.mjs files.
  
  text/javascript is added as a safeguard in case if shared-mime-info
  switches to it later, as there is ambiguity between which of those two
  should be the main one, and IANA could switch to text/javascript.
  
  Refs:
  
  - 
https://cgit.freedesktop.org/xdg/shared-mime-info/tree/freedesktop.org.xml.in
  - https://www.iana.org/assignments/media-types/application/javascript
  - https://tools.ietf.org/html/rfc4329
  - https://html.spec.whatwg.org/multipage/scripting.html#javascript-mime-type
  - https://github.com/bmeck/I-D/blob/master/javascript-mjs/draft.md

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D8451

AFFECTED FILES
  data/syntax/javascript.xml

To: ChALkeR
Cc: #frameworks

D8434: Created 'shared' section

2017-10-24 Thread Laurent Montel

mlaurent added a comment.


  +1 for me :) But I am not the maintainer :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8434

To: renatoo, ngraham, #frameworks, #dolphin
Cc: mlaurent, #frameworks

D8367: Hidding place groups implementation in KFilePlacesModel

2017-10-24 Thread Renato Oliveira Filho

renatoo added a comment.


  Pleas unit test "hiddenCount" when groups are invisible, it is used by the 
view in https://phabricator.kde.org/D8450

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8367

To: franckarrecot, renatoo, mlaurent, ngraham
Cc: ngraham, mlaurent, #frameworks

D8367: Hidding place groups implementation in KFilePlacesModel

2017-10-24 Thread Renato Oliveira Filho

renatoo added inline comments.

INLINE COMMENTS

> kfileplacesmodel.cpp:257
>  
>  bool KFilePlacesModel::isHidden(const QModelIndex ) const
>  {

should this  check if the group which the index belongs is hider or not?

Something like:

return (data(index, HiddenRole).toBool() ||  isPlaceGroupHidden(index));

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8367

To: franckarrecot, renatoo, mlaurent, ngraham
Cc: ngraham, mlaurent, #frameworks

D8450: WIP: User can now hide an entire places group

2017-10-24 Thread Franck Arrecot

franckarrecot updated this revision to Diff 21244.
franckarrecot added a comment.


  -

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8450?vs=21242=21244

REVISION DETAIL
  https://phabricator.kde.org/D8450

AFFECTED FILES
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h
  src/filewidgets/kfileplacesview.cpp

To: franckarrecot, ngraham, renatoo, mlaurent
Cc: #frameworks

D8367: Hidding place groups implementation in KFilePlacesModel

2017-10-24 Thread Franck Arrecot

franckarrecot updated this revision to Diff 21243.
franckarrecot added a comment.


  adding more services from model usefull to views

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8367?vs=21177=21243

REVISION DETAIL
  https://phabricator.kde.org/D8367

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesitem_p.h
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h

To: franckarrecot, renatoo, mlaurent, ngraham
Cc: ngraham, mlaurent, #frameworks

D8450: WIP: User can now hide an entire places group

2017-10-24 Thread Franck Arrecot

franckarrecot created this revision.
franckarrecot added reviewers: ngraham, renatoo, mlaurent.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  Through the ui the user can now right click on a place group
  and request to hide it.
  
  Note: It is not the collapsing solution, which would need a way bigger
  effort on the model to be achieve but an intermediary solution that could
  be useful for users.
  
  Dependds on https://phabricator.kde.org/D8367
  BUG: 300247

TEST PLAN
  Manual testing with the ui.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8450

AFFECTED FILES
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h
  src/filewidgets/kfileplacesview.cpp

To: franckarrecot, ngraham, renatoo, mlaurent
Cc: #frameworks

D8437: KWidgetsAddons : more compact password dialog

2017-10-24 Thread Nathaniel Graham

ngraham added a comment.


  Couple more changes, if you please:
  
  - Add the before-and-after screenshots to the Test Plan section so everyone 
who comes here sees them
  - Add "BUG: 381231" on its own line in the Summary section, which will make 
that bug get automatically closed once this is landed.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D8437

To: rjvbb, #frameworks
Cc: cfeck, ngraham

D8437: KWidgetsAddons : more compact password dialog

2017-10-24 Thread Nathaniel Graham

ngraham added a comment.


  Yeah, could you remove that and any other uynnecessary lines, so we have the 
bare minimum set of changes necessary to improve this?

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D8437

To: rjvbb, #frameworks
Cc: cfeck, ngraham

D7828: createKMessageBox tries to focus a default button when available

2017-10-24 Thread Nathaniel Graham

ngraham added a reviewer: VDG.

REVISION DETAIL
  https://phabricator.kde.org/D7828

To: emateli, #frameworks, ngraham, aacid, #vdg
Cc: ngraham, aacid, #frameworks

D8445: [PlasmaComponents Menu] Add ungrabMouseHack

2017-10-24 Thread David Edmundson

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  I was under the impression this hack was only needed when used on a window 
that doesn't take focus. 
  
(https://bugreports.qt.io/browse/QTBUG-59044?focusedCommentId=354424=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-354424)
  
  The popup should, so it doesn't match my findings in the qtbug you're linking 
to.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D8445

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8434: Created 'shared' section

2017-10-24 Thread Renato Oliveira Filho

renatoo marked an inline comment as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8434

To: renatoo, ngraham, #frameworks, #dolphin
Cc: mlaurent, #frameworks

D8434: Created 'shared' section

2017-10-24 Thread Renato Oliveira Filho

renatoo updated this revision to Diff 21238.
renatoo added a comment.


  Used QLatin1String for static strings

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8434?vs=21229=21238

REVISION DETAIL
  https://phabricator.kde.org/D8434

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesitem_p.h

To: renatoo, ngraham, #frameworks, #dolphin
Cc: mlaurent, #frameworks

D8434: Created 'shared' section

2017-10-24 Thread Laurent Montel

mlaurent added inline comments.

INLINE COMMENTS

> kfileplacesitem.cpp:168
> +if (protocol == QLatin1String("remote") ||
> +KProtocolInfo::protocolClass(protocol) != ":local") {
> +return NetworkType;

!= QLatin1String(":local")

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8434

To: renatoo, ngraham, #frameworks, #dolphin
Cc: mlaurent, #frameworks

D8445: [PlasmaComponents Menu] Add ungrabMouseHack

2017-10-24 Thread Kai Uwe Broulik

broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  Ensures the PlasmaComponents.Menu doesn't confuse MouseArea states.

TEST PLAN
  Put a ContextMenu into NotificationPopup, opened it, selected an item, and 
the MouseArea knew it wasn't pressed anymore. Before it got confused.
  Also played around in Kickoff and Task Manager and didn't notice anything 
suspicious

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D8445

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qmenu.cpp
  src/declarativeimports/plasmacomponents/qmenu.h

To: broulik, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Re: Python bindings using cppyy (was: An update on Python bindings)

2017-10-24 Thread Shaheed Haque

Hi all,

I have a preliminary version of the Cppyy bindings generator CMake
support available here:


https://bitbucket.org/wlav/cppyy-backend/pull-requests/6/an-interim-experimental-version-of-a/diff

There are some TODOs yet to be addressed, but I would appreciate
feedback on how easy it would be to integrate this with KDE's
buildsystem, especially for the frameworks. I'm a CMake noob, but the
basic idea I have is that the packager of some_framework might do
something like this:

find_package(cppyy)
CPPYY_ADD_BINDINGS(
...
LINK_LIBRARIES some_framework_LIBRARIES
H_DIR some_framework_INCLUDE_DIRS
H_FILES )

Thanks, Shaheed

On 16 October 2017 at 16:16, Shaheed Haque  wrote:
> As promised, here is an interim update on the investigation into the
> use of cppyy-based bindings for KF5 (and more...) instead of SIP-based
> bindings.
>
> The first thing is that the underlying technology of cppyy,
> cling/ROOT, has been under development at CERN for quite a while. It
> directly reads regular C++ files (there is no intermediate format like
> SIP).
>
> The bindings it generates from Python to C++ seem far more complete
> and automatic than SIP. For example:
>
> - Template instantiation is done on the fly as needed.
>
> - Since it uses C++ directly, there is none the effort required to
> decollide SIP's notion of forward and duplicate declarations.
>
> - Function overloads are cleanly handled, as are most (all?) operators.
>
> The net result is that so far, there is about 3 days work and
> approximately [1] no "customisation" required in order to get to
> roughly where the SIP based bindings were after 18 months. Without the
> need for customisations on a mass scale, I suspect that we might get
> away without anything like the tooling I had to create to SIP, and
> just integrate with CMake
> (https://root.cern.ch/how/integrate-root-my-project-cmake).
>
> This all sounds pretty amazing, right? Well, there are a few caveats...
>
> - The packaging is pretty new, and is evolving pretty rapidly. We
> are/will be an early adopter (https://bitbucket.org/wlav/cppyy/ and
> https://bitbucket.org/wlav/cppyy-backend). Packaging is via PyPI and
> pip/pip3.
>
> - There is a lot of documentation around for the system overall, but
> frankly, it has  been/still is a struggle to understand how the
> different parts relate to each other as some parts are obsolete, and
> other parts have yet to be built out to their intended end-state.
>
> - There are bugs [1], [2]. The upstream dev has been very responsive,
> and the overall quality approach looks sound. IIUC, the vast bulk of
> the code seems to be in daily use at CERN (and is based on LLVM).
>
> - Need to look into the exact usage of Qt-specifics: signals/slots and
> interoperability with SIP-based PyQt
> (https://root.cern.ch/root/htmldoc/guides/users-guide/PythonRuby.html#glue-ing-applications,
> https://root.cern.ch/doc/v606_ORIG/guide/ROOTandQt.html)
>
> - Need to figure out how any customisations which *are* required
> should be handled.
>
> These seem like perfectly tractable issues, and so I conclude that
> using cppyy is definitely the way to go. With luck and a bit of
> effort, I am hopeful that we can get to some REALLY
> easy-to-develop-and-maintain bindings.
>
> [1] There is a bug with the binding producing stuff for private definitions.
>
> [2] There is a bug with missing globals.
>
>
[snip]

D8243: Implement support for categories on KfilesPlacesView

2017-10-24 Thread Renato Oliveira Filho

renatoo marked 2 inline comments as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8243

To: renatoo, #frameworks, dfaure, ervin, #vdg
Cc: markg, ngraham, mlaurent, ervin, anthonyfieroni, cfeck, #frameworks

D8434: Created 'shared' section

2017-10-24 Thread Renato Oliveira Filho

renatoo updated this revision to Diff 21229.
renatoo added a comment.


  Updated parent branch

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8434?vs=21176=21229

REVISION DETAIL
  https://phabricator.kde.org/D8434

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesitem_p.h

To: renatoo, ngraham, #frameworks, #dolphin
Cc: #frameworks

D8332: Added baloo urls into places model

2017-10-24 Thread Renato Oliveira Filho

renatoo updated this revision to Diff 21227.
renatoo added a comment.


  Upated parent branch

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8332?vs=20952=21227

REVISION DETAIL
  https://phabricator.kde.org/D8332

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesview.cpp

To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham
Cc: usta, mlaurent, dvratil, ngraham, #frameworks

D8348: Add a section for removable devices

2017-10-24 Thread Renato Oliveira Filho

renatoo updated this revision to Diff 21228.
renatoo added a comment.


  Updated parent branch

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8348?vs=21003=21228

REVISION DETAIL
  https://phabricator.kde.org/D8348

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesitem_p.h

To: renatoo, #dolphin, #frameworks, #vdg
Cc: anthonyfieroni, ngraham, #frameworks

D8243: Implement support for categories on KfilesPlacesView

2017-10-24 Thread Renato Oliveira Filho

renatoo updated this revision to Diff 21226.
renatoo added a comment.


  Fixed typo

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8243?vs=20951=21226

REVISION DETAIL
  https://phabricator.kde.org/D8243

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesitem_p.h
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesmodel.h
  src/filewidgets/kfileplacesview.cpp
  src/filewidgets/kfileplacesview.h

To: renatoo, #frameworks, dfaure, ervin, #vdg
Cc: markg, ngraham, mlaurent, ervin, anthonyfieroni, cfeck, #frameworks

D8436: use a single QML engine

2017-10-24 Thread Marco Martin

mart edited the test plan for this revision.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D8436

To: mart, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8436: use a single QML engine

2017-10-24 Thread Marco Martin

mart added a comment.


  In https://phabricator.kde.org/D8436#159212, @davidedmundson wrote:
  
  > Given the fallout we had when we made the similar change in Plasma, please 
don't merge until the start of the next release cycle.
  
  
  after november first week release? ok
  
  > Can you expand your "normal system settings seems unaffected" into 
something more thorough with a list of the relevant KCMs.
  
  currently ported modules are
  
  - desktop theme
  - look and feel
  - sound
  - splash screen
  - boot splash

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D8436

To: mart, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8436: use a single QML engine

2017-10-24 Thread David Edmundson

davidedmundson added a comment.


  Given the fallout we had when we made the similar change in Plasma, please 
don't merge until the start of the next release cycle.
  
  Can you expand your "normal system settings seems unaffected" into something 
more thorough with a list of the relevant KCMs.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D8436

To: mart, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8436: use a single QML engine

2017-10-24 Thread Marco Martin

mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in configmodule.cpp:106
> !!

this version now should work, as the context is used now: the way the static 
attached property function finds it is quite an heuristic, but should be 100% 
reliable

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D8436

To: mart, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8436: use a single QML engine

2017-10-24 Thread Marco Martin

mart updated this revision to Diff 21223.
mart added a comment.


  - use the qmlobject's rootcontext instead of the engine as is now shared

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8436?vs=21184=21223

BRANCH
  arcpatch-D8436

REVISION DETAIL
  https://phabricator.kde.org/D8436

AFFECTED FILES
  src/quickaddons/configmodule.cpp

To: mart, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8436: use a single QML engine

2017-10-24 Thread Marco Martin

mart updated this revision to Diff 21224.
mart added a comment.


  - use the qmlobject's rootcontext instead of the engine as is now shared

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8436?vs=21223=21224

BRANCH
  arcpatch-D8436

REVISION DETAIL
  https://phabricator.kde.org/D8436

AFFECTED FILES
  src/quickaddons/configmodule.cpp

To: mart, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8402: Support "domain-suffix-match" in Security8021xSetting

2017-10-24 Thread Marius Kittler

Martchus added a task: T7232: Allow specifying domain in plasma-nm Wi-Fi 
security settings.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D8402

To: Martchus, #plasma, jgrulich
Cc: jgrulich, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8402: Support "domain-suffix-match" in Security8021xSetting

2017-10-24 Thread Jan Grulich

This revision was automatically updated to reflect the committed changes.
Closed by commit R282:7491ed93c8cb: Support domain-suffix-match in 
Security8021xSetting (authored by jgrulich).

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8402?vs=21153=21220

REVISION DETAIL
  https://phabricator.kde.org/D8402

AFFECTED FILES
  autotests/settings/8021xsettingtest.cpp
  src/settings/security8021xsetting.cpp
  src/settings/security8021xsetting.h
  src/settings/security8021xsetting_p.h

To: Martchus, #plasma, jgrulich
Cc: jgrulich, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8402: Support "domain-suffix-match" in Security8021xSetting

2017-10-24 Thread Marius Kittler

Martchus added a comment.


  I don't have commit access so somebody needs to merge this for me.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D8402

To: Martchus, #plasma, jgrulich
Cc: jgrulich, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7828: createKMessageBox tries to focus a default button when available

2017-10-24 Thread Emirald Mateli

emateli added a comment.


  @aacid the issue at hand is that in this particular scenario the default 
button more or less equals to the one that has focus.
  
  There are only 3 types of widgets that can be created here: buttons, a list 
or a check box.
  
  You can't interact with the list so it is ruled out for being focused. The 
check box acts as a confirmation and thus is a secondary element which you also 
do not want to toggle by mistake, so it rests upon the buttons to have it.
  If any button is to have focus then it might as well be the default one,  
giving it to another button will break the enter button since the focused 
button's handler will be invoked over the default's. 
  This also has the added benefit of allowing to invoke the default action via 
space bar.

REVISION DETAIL
  https://phabricator.kde.org/D7828

To: emateli, #frameworks, ngraham, aacid
Cc: ngraham, aacid, #frameworks

KDE CI: Frameworks kwindowsystem kf5-qt5 WindowsMSVCQt5.9 - Build # 12 - Failure!

2017-10-24 Thread CI System

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20WindowsMSVCQt5.9/12/
 Project:
Frameworks kwindowsystem kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Tue, 24 Oct 2017 07:45:17 +
 Build duration:
1 hr 9 min and counting
   CONSOLE OUTPUT
  [...truncated 7.91 KB...] > git checkout -f 1a3b8539d3b5a908beab2d33b4f441a912692801Commit message: "KKeyServer: fix handling of Meta+Shift+Print, Alt+Shift+arrowkey etc." > git rev-list ec3c59e535fa4a185b40f032c7d703317afc5537 # timeout=10[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/sysadmin/ci-tooling > git init C:\CI\workspace\Frameworks kwindowsystem kf5-qt5 WindowsMSVCQt5.9\ci-tooling # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/ci-tooling > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/sysadmin/ci-tooling +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/sysadmin/ci-tooling # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/sysadmin/ci-tooling # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/ci-tooling > git fetch --tags --progress https://anongit.kde.org/sysadmin/ci-tooling +refs/heads/*:refs/remotes/origin/* > git rev-parse "origin/master^{commit}" # timeout=10Checking out Revision df9cfcfef76e2f7f3fd2355f15438e4579a46f92 (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f df9cfcfef76e2f7f3fd2355f15438e4579a46f92Commit message: "KDevelop has quite a few tests that timeout on Windows. To help keep the builders free, drop this down from it's normally very high default so the tests get killed off sooner"[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/sysadmin/repo-metadata > git init C:\CI\workspace\Frameworks kwindowsystem kf5-qt5 WindowsMSVCQt5.9\ci-tooling\repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* > git rev-parse "origin/master^{commit}" # timeout=10Checking out Revision 535b1c344dad1aac19764f5bf9979f822b27a14e (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f 535b1c344dad1aac19764f5bf9979f822b27a14eCommit message: "kolf/master is KF5-based"[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/kde-build-metadata > git init C:\CI\workspace\Frameworks kwindowsystem kf5-qt5 WindowsMSVCQt5.9\ci-tooling\kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/*ERROR: Error cloning remote repo 'origin'hudson.plugins.git.GitException: Command "git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/*" returned status code 128:stdout: stderr: fatal: unable to access 'https://anongit.kde.org/kde-build-metadata/': Failed to connect to anongit.kde.org port 443: Timed out	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1924)	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1643)	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:71)	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:352)	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$2.execute(CliGitAPIImpl.java:559)	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:153)	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:146)	at hudson.remoting.UserRequest.perform(UserRequest.java:181)	at hudson.remoting.UserRequest.perform(UserRequest.java:52)	at hudson.remoting.Request$2.run(Request.java:336)	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68)	at java.util.concurrent.FutureTask.run(Unknown Source)	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)	at

D7401: Solid/Mac : fleshing out the skeleton IOKit backend (WIP)

2017-10-24 Thread Kevin Funk

kfunk requested changes to this revision.
kfunk added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> iokitdevice.cpp:307
> +default:
> +vendor = QString();
> +break;

Why not `return` here as well? For consistency.

You can end the function with

  Q_UNREACHABLE();
  return {};

Very common pattern.

> iokitdevice.cpp:463
>  {
> -return (type == Solid::DeviceInterface::GenericInterface
> -|| type == d->type);
> +bool ret = false;
> +switch (type) {

Returning inside the case statements would make this code clearer as well.

> iokitdeviceinterface.h:51
>  IOKitDevice *m_device;
> +IOKitDevice *copy;
>  };

`m_` prefix missing. Would call it `m_deviceCopy`.

> rjvbb wrote in iokitstorage.cpp:36
> Did you check that these are indeed pointers? ;)

Yes. And they are, no?

> rjvbb wrote in iokitstorage.cpp:75
> I don't get it, sorry, can you explain in more words how you'd want to see 
> this changed? If I remove this extra ctor, I can no longer call 
> `IOKitStorage(this).vendor()` in `IOKitDevice::vendor()` without extra code 
> that's also going to add noise.
> 
> I get a warning when I remove the const attribute from 
> `IOKitDevice::vendor()`, which suggests that I'd no longer be reimplementing 
> a virtual method but adding a method instead.
> 
> All these "extra" ctors hand off the pointer to a "const this" to 
> `DeviceInterface` which finally makes a deep copy. I find that cleaner than 
> creating a deep copy of `this` everywhere needed and ensuring it gets 
> deallocated (even via QPointers).
> Unusual doesn't mean wrong (we're on Mac here, after all ^^)

Okay, well, leave it like that.

I'm running out of time to properly explain how I'd envision this code to be 
like in a perfect world.

> iokitstorage.cpp:73
> +
> +const IOKitDevice *m_device;
> +DASessionRef daSession;

Inconsistent member naming. Some with `m_` prefix, some without. Choose one 
style. Private classes' members usually live without the `m_` prefix, but we 
don't mind them being around (in KDE land)

> iokitstorage.h:43
> +
> +const QString vendor();
> +const QString product();

Remove `const` from return type, but make the method `const`.

> iokitstorageaccess.cpp:56
> +
> +const IOKitDevice *m_device;
> +DASessionRef daSession;

Dito, inconsistent member naming.

> iokitvolume.cpp:70
> +
> +const IOKitDevice *m_device;
> +DASessionRef daSession;

Dito, inconsistent member naming.

And given that I've noticed that three times now, this again leads to the 
conclusion this is very repetitive code amongst . 
`{IOKitStorageAccess,IOKitVolume,IOKitStorage}::Private`.

Maybe there should be helper class for accessing a `CFDictionary` instead which 
all these classes use?

I'm not trying to piss you off René, but this is slightly sloppy coding which 
easy for the initial writer to do, but will bite us any time in the future when 
someone unfamiliar with the code needs to do fixes to this code and potentially 
fixes only one copy of these snippets. Please think about your architecture 
more carefully.

> iokitvolume.h:45
> +
> +virtual bool isIgnored() const Q_DECL_OVERRIDE;
> +virtual Solid::StorageVolume::UsageType usage() const Q_DECL_OVERRIDE;

No `virtual` needed if there's already a `Q_DECL_OVERRIDE` or `override`.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D7401

To: rjvbb, #frameworks, kfunk
Cc: kfunk, anthonyfieroni, cgilles, kde-mac

KDE CI: Frameworks kglobalaccel kf5-qt5 WindowsMSVCQt5.9 - Build # 10 - Failure!

2017-10-24 Thread CI System

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kglobalaccel%20kf5-qt5%20WindowsMSVCQt5.9/10/
 Project:
Frameworks kglobalaccel kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Tue, 24 Oct 2017 05:34:12 +
 Build duration:
3 hr 14 min and counting
   CONSOLE OUTPUT
  [...truncated 1.78 KB...][Pipeline] { (Checkout Sources)[Pipeline] deleteDir[Pipeline] checkoutCloning the remote Git repositoryCloning repository git://anongit.kde.org/kglobalaccel > git init C:\CI\workspace\Frameworks kglobalaccel kf5-qt5 WindowsMSVCQt5.9 # timeout=10Fetching upstream changes from git://anongit.kde.org/kglobalaccel > git --version # timeout=10 > git fetch --tags --progress git://anongit.kde.org/kglobalaccel +refs/heads/*:refs/remotes/origin/* # timeout=120 > git config remote.origin.url git://anongit.kde.org/kglobalaccel # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url git://anongit.kde.org/kglobalaccel # timeout=10Fetching upstream changes from git://anongit.kde.org/kglobalaccel > git fetch --tags --progress git://anongit.kde.org/kglobalaccel +refs/heads/*:refs/remotes/origin/* # timeout=120 > git rev-parse "origin/master^{commit}" # timeout=10Checking out Revision ee2c53757aaa63e23c6eb66cf6c8fc0b88271386 (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f ee2c53757aaa63e23c6eb66cf6c8fc0b88271386Commit message: "Revert "Revert "KGlobalAccel: port to KKeyServer's new method symXModXToKeyQt, to fix numpad keys""" > git rev-list c9aa3ee8df915859e9bc5ed88bd5385cf7f3e14e # timeout=10[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/sysadmin/ci-tooling > git init C:\CI\workspace\Frameworks kglobalaccel kf5-qt5 WindowsMSVCQt5.9\ci-tooling # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/ci-tooling > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/sysadmin/ci-tooling +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/sysadmin/ci-tooling # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/sysadmin/ci-tooling # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/ci-tooling > git fetch --tags --progress https://anongit.kde.org/sysadmin/ci-tooling +refs/heads/*:refs/remotes/origin/* > git rev-parse "origin/master^{commit}" # timeout=10Checking out Revision df9cfcfef76e2f7f3fd2355f15438e4579a46f92 (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f df9cfcfef76e2f7f3fd2355f15438e4579a46f92Commit message: "KDevelop has quite a few tests that timeout on Windows. To help keep the builders free, drop this down from it's normally very high default so the tests get killed off sooner"[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/sysadmin/repo-metadata > git init C:\CI\workspace\Frameworks kglobalaccel kf5-qt5 WindowsMSVCQt5.9\ci-tooling\repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/*ERROR: Error cloning remote repo 'origin'hudson.plugins.git.GitException: Command "git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/*" returned status code 128:stdout: stderr: fatal: unable to access 'https://anongit.kde.org/sysadmin/repo-metadata/': Failed to connect to anongit.kde.org port 443: Timed out	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1924)	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1643)	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:71)	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:352)	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$2.execute(CliGitAPIImpl.java:559)	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:153)	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:146)	at hudson.remoting.UserRequest.perform(UserRequest.java:181)	at hudson.remoting.UserRequest.perform(UserRequest.java:52)	at hudson.remoting.Request$2.run(Request.java:336)	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:68)	at java.util.concurrent.FutureTask.run(Unknown Source)	at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)	at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)	at hudson.remoting.Engine$1$1.run(Engine.java:98)	at java.lang.Thread.run(Unknown Source)	Suppressed:

D8243: Implement support for categories on KfilesPlacesView

2017-10-24 Thread David Faure

dfaure added inline comments.

INLINE COMMENTS

> kfileplacesview.cpp:1146
> +
> +const int totlaItemsHeight = (fm.height() / 2) * rowCount;
> +const int totoalSectionsHeight = delegate->sectionHeaderHeight() * 
> sectionsCount();

typo (total)

> kfileplacesview.cpp:1147
> +const int totlaItemsHeight = (fm.height() / 2) * rowCount;
> +const int totoalSectionsHeight = delegate->sectionHeaderHeight() * 
> sectionsCount();
> +const int maxHeight = ((q->height() - totoalSectionsHeight - 
> totlaItemsHeight) / rowCount) - 1;

different typo (total) ;-)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8243

To: renatoo, #frameworks, dfaure, ervin, #vdg
Cc: markg, ngraham, mlaurent, ervin, anthonyfieroni, cfeck, #frameworks

KDE CI: Frameworks kwindowsystem kf5-qt5 XenialQt5.7 - Build # 36 - Still Unstable!

2017-10-24 Thread CI System

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20XenialQt5.7/36/
 Project:
Frameworks kwindowsystem kf5-qt5 XenialQt5.7
 Date of build:
Tue, 24 Oct 2017 07:45:17 +
 Build duration:
8 min 16 sec and counting
   JUnit Tests
  Name: (root) Failed: 5 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.kwindowsystem-compositingenabled_testFailed: TestSuite.kwindowsystem-kwindoweffectstestFailed: TestSuite.kwindowsystem-kwindowinfox11testFailed: TestSuite.kwindowsystem-kwindowsystem_threadtestFailed: TestSuite.kwindowsystem-kwindowsystemx11test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report80%
(4/5)83%
(38/46)83%
(38/46)71%
(5778/8085)48%
(3040/6342)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(16/16)100%
(16/16)85%
(2609/3080)43%
(1352/3151)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src75%
(12/16)75%
(12/16)50%
(728/1444)37%
(267/720)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/89)0%
(0/2)src.platforms.xcb82%
(9/11)82%
(9/11)70%
(2434/3462)58%
(1418/2463)

D7829: KKeyServer: fix handling of Meta+Shift+Print, Alt+Shift+arrowkey etc.

2017-10-24 Thread David Faure

This revision was automatically updated to reflect the committed changes.
Closed by commit R278:1a3b8539d3b5: KKeyServer: fix handling of 
Meta+Shift+Print, Alt+Shift+arrowkey etc. (authored by dfaure).

REPOSITORY
  R278 KWindowSystem

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7829?vs=20212=21214

REVISION DETAIL
  https://phabricator.kde.org/D7829

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/kkeyserver_x11_unittest.cpp
  src/platforms/xcb/kkeyserver.cpp

To: dfaure, graesslin, jriddell, martinkostolny, broulik
Cc: ngraham, #frameworks

D8330: Open files in TagLib extractor readonly

2017-10-24 Thread David Kahles

davidk added reviewers: vhanda, cgiboudeaux, dfaure.
davidk added a comment.


  Adding some devs who worked on kfilemetadata in the past.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D8330

To: davidk, #frameworks, vhanda, cgiboudeaux, dfaure
Cc: mgallien, ngraham, #frameworks

D1231: Add Remote Access interface to KWayland

2017-10-24 Thread Oleg Chernovskiy

Kanedias marked 5 inline comments as done.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D1231

To: Kanedias, graesslin, davidedmundson
Cc: subdiff, ngraham, alexeymin, #frameworks, davidedmundson, plasma-devel, 
leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
eliasp, sebas, apol, mart, hein

D1231: Add Remote Access interface to KWayland

2017-10-24 Thread Oleg Chernovskiy

Kanedias updated this revision to Diff 21212.
Kanedias added a comment.


  Updated against latest master,
  fixed review comments

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1231?vs=16359=21212

REVISION DETAIL
  https://phabricator.kde.org/D1231

AFFECTED FILES
  autotests/client/CMakeLists.txt
  autotests/client/test_remote_access.cpp
  src/client/CMakeLists.txt
  src/client/protocols/remote-access.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/remote_access.cpp
  src/client/remote_access.h
  src/server/CMakeLists.txt
  src/server/display.cpp
  src/server/display.h
  src/server/remote_access_interface.cpp
  src/server/remote_access_interface.h
  src/server/remote_access_interface_p.h
  src/tools/mapping.txt

To: Kanedias, graesslin, davidedmundson
Cc: subdiff, ngraham, alexeymin, #frameworks, davidedmundson, plasma-devel, 
leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
eliasp, sebas, apol, mart, hein

58 matches

Mail list logo