D8577: Fix: Missing dependencies for ktexeditor autotests

[Christoph Cullmann]

cullmann added a comment.


  Hmm, I would rather like to have this fixed than having that dependency just 
for that.
  I thought during the port it compiled completely without QtScript.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D8577

To: hgoebel, #ktexteditor, dfaure
Cc: cullmann, dhaumann, #frameworks, kevinapavew, demsking, sars

D8671: KEmoticons: port plugins to JSON and add support for loading with KPluginMetaData

[David Faure]

dfaure added a comment.


  The KCM uses KServiceTypeTrader so we still need the desktop files.

REPOSITORY
  R301 KEmoticons

REVISION DETAIL
  https://phabricator.kde.org/D8671

To: dfaure, #frameworks
Cc: apol

D8671: KEmoticons: port plugins to JSON and add support for loading with KPluginMetaData

[Aleix Pol Gonzalez]

apol added a comment.


  Other than that +1

INLINE COMMENTS

> CMakeLists.txt:19
>  )
> -set_target_properties(emoticonstheme_adium PROPERTIES 
> LIBRARY_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/bin/kf5/emoticonsthemes")
> -install(
> -TARGETS emoticonstheme_adium
> -DESTINATION ${KDE_INSTALL_PLUGINDIR}/kf5/emoticonsthemes
> -)
> +# KF6: remove
>  install(

Why do we need to keep them?

Whoever uses this it will be with the new version of the library as well.

REPOSITORY
  R301 KEmoticons

REVISION DETAIL
  https://phabricator.kde.org/D8671

To: dfaure, #frameworks
Cc: apol

D8577: Fix: Missing dependencies for ktexeditor autotests

[Hartmut Goebel]

hgoebel added a comment.


  QtScript is only required for the tests. Maybe just a left-over #include?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D8577

To: hgoebel, #ktexteditor, dfaure
Cc: dhaumann, #frameworks, kevinapavew, demsking, cullmann, sars

KDE CI: Frameworks extra-cmake-modules kf5-qt5 FreeBSDQt5.7 - Build # 58 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20extra-cmake-modules%20kf5-qt5%20FreeBSDQt5.7/58/
 Project:
Frameworks extra-cmake-modules kf5-qt5 FreeBSDQt5.7
 Date of build:
Sun, 05 Nov 2017 23:00:27 +
 Build duration:
1 min 1 sec and counting

KDE CI: Frameworks kemoticons kf5-qt5 XenialQt5.7 - Build # 28 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kemoticons%20kf5-qt5%20XenialQt5.7/28/
 Project:
Frameworks kemoticons kf5-qt5 XenialQt5.7
 Date of build:
Sun, 05 Nov 2017 22:52:22 +
 Build duration:
5 min 42 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.kemoticons-kemoticontestFailed: TestSuite.kemoticons-ktexttohtmlplugintest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(3/3)83%
(10/12)83%
(10/12)36%
(225/621)26%
(122/477)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(3/3)100%
(3/3)95%
(146/153)66%
(102/154)src.core71%
(5/7)71%
(5/7)15%
(70/459)4%
(13/313)src.integrationplugin100%
(2/2)100%
(2/2)100%
(9/9)70%
(7/10)

D8672: Fix build with LibreSSL

[Heiko Becker]

heikobecker created this revision.
heikobecker added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  Unfortunately LibreSSL sets OPENSSL_VERSION_NUMBER to
  0x2000L and doesn't support the OpenSSL 1.1 API.

TEST PLAN
  Builds with LibreSSL

REPOSITORY
  R239 KDELibs4Support

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8672

AFFECTED FILES
  src/kssl/kopenssl.cpp
  src/kssl/kopenssl.h
  src/kssl/ksslcertificate.cpp

To: heikobecker, #frameworks

KDE CI: Frameworks kio kf5-qt5 XenialQt5.7 - Build # 131 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20XenialQt5.7/131/
 Project:
Frameworks kio kf5-qt5 XenialQt5.7
 Date of build:
Sun, 05 Nov 2017 22:45:27 +
 Build duration:
5 min 18 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 54 test(s)Failed: TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: TestSuite.kiowidgets-kurifiltertest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(22/22)80%
(278/346)80%
(278/346)57%
(30042/52384)42%
(16597/39374)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(67/67)100%
(67/67)96%
(8078/8399)51%
(4503/8824)autotests.http100%
(9/9)100%
(9/9)100%
(543/544)60%
(200/336)autotests.kcookiejar100%
(1/1)100%
(1/1)90%
(179/198)67%
(60/90)src.core85%
(99/117)85%
(99/117)57%
(8157/14199)49%
(4558/9281)src.core.kssl100%
(1/1)100%
(1/1)38%
(35/93)50%
(3/6)src.filewidgets73%
(27/37)73%
(27/37)46%
(3569/7729)30%
(1329/4476)src.gui100%
(2/2)100%
(2/2)95%
(104/110)75%
(54/72)src.ioslaves.file100%
(2/2)100%
(2/2)51%
(435/849)42%
(317/749)src.ioslaves.http100%
(8/8)100%
(8/8)47%
(1770/3783)38%
(1326/3462)src.ioslaves.http.kcookiejar100%
(2/2)100%
(2/2)80%
(622/782)72%
(608/839)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(70/258)8%
(16/200)src.ioslaves.trash80%
(8/10)80%
(8/10)59%
(694/1173)46%
(395/851)src.ioslaves.trash.tests100%
(2/2)100%
(2/2)90%
(707/785)48%
(461/970)src.kioslave100%
(1/1)100%
(1/1)52%
(14/27)50%
(5/10)src.kntlm100%
(2/2)100%
(2/2)97%
(373/385)80%
(111/138)src.kpasswdserver100%
(2/2)100%
(2/2)64%
(382/594)49%
(284/580)src.kpasswdserver.autotests100%
(1/1)100%
(1/1)99%
(283/286)57%

D8348: Add a section for removable devices

[Nathaniel Graham]

ngraham added a comment.


  In https://phabricator.kde.org/D8348#164713, @abetts wrote:
  
  > What about something like this as well
  >
  > F548: Unmount.png 
  >
  > The removable device gets an "unmount" or "disconnect" icon on hover?
  >
  > Thoughts?
  
  
  Yes yes yes! That would also resolve 
https://bugs.kde.org/show_bug.cgi?id=154499
  
  Of course, if this isn't an easy change, we may not want to overload the 
patch.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8348

To: renatoo, #dolphin, #frameworks, #vdg, ervin, ngraham
Cc: abetts, mlaurent, anthonyfieroni, ngraham, #frameworks

D8577: Fix: Missing dependencies for ktexeditor autotests

[Dominik Haumann]

dhaumann added a comment.


  I am a bit surprised by this commit: we just removed the dependency on 
QtScript in favor of QtQML and now it's back. I don't think this hurts much, 
but the goal is to not depend on it... ?!

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D8577

To: hgoebel, #ktexteditor, dfaure
Cc: dhaumann, #frameworks, kevinapavew, demsking, cullmann, sars

D8348: Add a section for removable devices

[Andres Betts]

abetts added a comment.


  What about something like this as well
  
  F548: Unmount.png 
  
  The removable device gets an "unmount" or "disconnect" icon on hover?
  
  Thoughts?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8348

To: renatoo, #dolphin, #frameworks, #vdg, ervin, ngraham
Cc: abetts, mlaurent, anthonyfieroni, ngraham, #frameworks

D8671: KEmoticons: port plugins to JSON and add support for loading with KPluginMetaData

[David Faure]

dfaure created this revision.
dfaure added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  This makes it possible to run the autotests without installing kemoticons.

TEST PLAN
  ctest; also playing a bit with `kcmshell5 emoticons`, but not full coverage 
there.

REPOSITORY
  R301 KEmoticons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8671

AFFECTED FILES
  src/core/kemoticons.cpp
  src/providers/adium/CMakeLists.txt
  src/providers/adium/adium_emoticons.cpp
  src/providers/adium/emoticonstheme_adium.json
  src/providers/kde/CMakeLists.txt
  src/providers/kde/emoticonstheme_kde.json
  src/providers/kde/kde_emoticons.cpp
  src/providers/pidgin/CMakeLists.txt
  src/providers/pidgin/emoticonstheme_pidgin.json
  src/providers/pidgin/pidgin_emoticons.cpp
  src/providers/xmpp/CMakeLists.txt
  src/providers/xmpp/emoticonstheme_xmpp.json
  src/providers/xmpp/xmpp_emoticons.cpp

To: dfaure, #frameworks

D8434: Created 'remote' section

[Renato Oliveira Filho]

renatoo marked 2 inline comments as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8434

To: renatoo, ngraham, #frameworks, #dolphin, mwolff, mlaurent, dfaure
Cc: dfaure, elvisangelaccio, mwolff, mlaurent, #frameworks

D8434: Created 'remote' section

[Renato Oliveira Filho]

renatoo updated this revision to Diff 21934.
renatoo marked 4 inline comments as done.
renatoo added a comment.


  Fixed typos

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8434?vs=21809=21934

REVISION DETAIL
  https://phabricator.kde.org/D8434

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesitem_p.h

To: renatoo, ngraham, #frameworks, #dolphin, mwolff, mlaurent, dfaure
Cc: dfaure, elvisangelaccio, mwolff, mlaurent, #frameworks

D8348: Add a section for removable devices

[Renato Oliveira Filho]

renatoo updated this revision to Diff 21933.
renatoo added a comment.


  Parent branch update

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8348?vs=21808=21933

REVISION DETAIL
  https://phabricator.kde.org/D8348

AFFECTED FILES
  autotests/kfileplacesmodeltest.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesitem_p.h

To: renatoo, #dolphin, #frameworks, #vdg, ervin, ngraham
Cc: mlaurent, anthonyfieroni, ngraham, #frameworks

D8332: Added baloo urls into places model

[Renato Oliveira Filho]

renatoo updated this revision to Diff 21932.
renatoo marked an inline comment as done.
renatoo added a comment.


  Fixed import

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8332?vs=21807=21932

REVISION DETAIL
  https://phabricator.kde.org/D8332

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/kfileplacesmodeltest.cpp
  autotests/kfileplacesviewtest.cpp
  src/filewidgets/kfileplacesmodel.cpp
  src/filewidgets/kfileplacesview.cpp

To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham, 
ervin, mlaurent
Cc: dfaure, ervin, usta, mlaurent, dvratil, ngraham, #frameworks

Re: Python bindings using cppyy (was: An update on Python bindings)

[Shaheed Haque]

Philipp,

On 5 November 2017 at 14:48, Philipp A.  wrote:

> Hi Shaheed, Chris,
>
> Shaheed Haque  schrieb am Sa., 4. Nov. 2017 um
> 18:35 Uhr:
>
>> FWIW, I already tried that (types.ModuleType is itself a perfectly
>> subclassable class!) […]
>>
>> Now, none of that may be a limiting factor in the plan you seem to be
>> discussing, but it was part of what made me think "here be dragons"...
>
>
> For me that sounds like a perfectly acceptable clearly-defined instruction:
>
>- If you can, don’t use a __init__.py for namespace packages (because
>it’s simple).
>- If you need an __init__.py, only use one or use identical ones.
>
> Reasons for needing a __init__.py include the need for toplevel
> constants/classes/functions, or supporting Python 2. The docs also say that
> you can mix __init__.py omission and (identical) __init__.pys.
>
> I created an example here: https://github.com/flying-sheep/namespace-test
>

As I said, I know how this works, and am using it. As I also said, I'm
happy for others to pursue ECM-based bindings because I don't plan to.

My branch in pykde5.git is now at the point where the packaging now works
with wheels. With any luck, the combination of CMake and pip/setuptools I
have
brewed there will facilitate any ECM-based bindings. Note: the packaging
code depends very much on the evolving PR at
https://bitbucket.org/wlav/cppyy-backend/pull-requests/6/an-interim-experimental-version-of-a.
Neither branch is ready to merge or formally review.

I plan to continue to push forward on the remaining functional TODOs.

Thanks, Shaheed

You can see that by using a __init__.py in exactly one of the merged
> packages, you can define toplevel constants/classes/functions like BASE in
> the example.
>
> If we need, we can also define toplevel constants and so on in multiple
> distributions, like this (this specific version requires all distributions
> to know about all others, but that’s automatable):
>
> *namespace-test-1/namespace_test/namespace_test_1_init.py*:
> FOO = 1
> *namespace-test-2/namespace_test/**namespace_test_2_init.py*:
> BAR= 1
> *namespace-test-{1,2}/namespace_test/**__init__.py*:
> from pkgutil import extend_path
> __path__ = extend_path(__path__, __name__)
> try:
> from .namespace_test_1_init import *
> except ImportError:
> pass
> try:
> from .namespace_test_2_init import *
> except ImportError:
> pass
>
> Chris Burel  schrieb am So., 5. Nov. 2017 um
> 02:49 Uhr:
>
>> I think this is a remarkably short sighted statement. It assumes that
>> people that would use these bindings have no existing Python codebase at
>> all, and can afford to start a brand new project. The reality is much
>> different. […]
>
>
> No, because you’re missing something here: There’s no KF5 bindings. So
> every project that’ll use Shaheed’s new cool KF5 bindings will be a new
> project.
>
> Therefore the only thing Python 2 KF5 bindings would accomplish is to make
> people think that starting a *new* Python 2 project in 2018 was still a
> good idea. Which it isn’t.
>

D8332: Added baloo urls into places model

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> kfileplacesviewtest.cpp:30
> +
> +#include 
> +#include 

Please don't include the full module (which also contains all QtCore)

#include  is OK, #include  is not. Confusing, I know.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8332

To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham, 
ervin, mlaurent
Cc: dfaure, ervin, usta, mlaurent, dvratil, ngraham, #frameworks

D8434: Created 'remote' section

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kfileplacesmodeltest.cpp:804
> +
> +// check if url list is corret after insertion
> +QStringList urls;

typo: correct

> kfileplacesmodeltest.cpp:812
> +
> +// check if the new ulr was inserted int the right position (end of 
> "Remote" section)
> +QTRY_COMPARE(spy_inserted.count(), 1);

typo: URL
typo: *in* the

> kfileplacesmodeltest.cpp:819
> +
> +// check if the new ulr has the right group "Remote"
> +const QModelIndex index = m_places->index(expectedRow, 0);

typo: URL

> kfileplacesitem_p.h:48
>  PlacesType = 0,
> -RecentlySavedType = 1,
> -SearchForType = 2,
> -DevicesType = 3,
> -RemovableDevicesType = 4
> +RemoteType = 1,
> +RecentlySavedType = 2,

If the actual numbers don't matter (as shown by this commit), why do we even 
number these explicitly? I would just remove all the =0, =1, =2... values.
It will make the diff smaller in the next such commit ;)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8434

To: renatoo, ngraham, #frameworks, #dolphin, mwolff, mlaurent, dfaure
Cc: dfaure, elvisangelaccio, mwolff, mlaurent, #frameworks

D8461: Remove unused config.h.cmake entries

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  The answer to "I'm not sure why" is easy: `git log -S MALLOC` shows exactly 
two commits, the one that introduced the usage of this stuff, and the one that 
removed it again. Ain't git great?
  
  BTW, I see more dead code, like `baloo_removexattr`, `baloo_getxattr` and 
then apparently baloo_setxattr is only used by unittests.

REPOSITORY
  R293 Baloo

BRANCH
  cleanup

REVISION DETAIL
  https://phabricator.kde.org/D8461

To: davidk, dfaure
Cc: dfaure, #frameworks

D8577: Fix: Missing dependencies for ktexeditor autotests

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D8577

To: hgoebel, #ktexteditor, dfaure
Cc: #frameworks, kevinapavew, demsking, cullmann, sars, dhaumann

D8577: Fix: Missing dependencies for ktexeditor autotests

[David Faure]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:d6fc0b782046: Fix: Missing dependencies for ktexeditor 
autotests (authored by hgoebel, committed by dfaure).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D8577?vs=21656=21931#toc

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8577?vs=21656=21931

REVISION DETAIL
  https://phabricator.kde.org/D8577

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/src/vimode/CMakeLists.txt

To: hgoebel, #ktexteditor, dfaure
Cc: #frameworks, kevinapavew, demsking, cullmann, sars, dhaumann

D8590: KPageListView: Update width on font change

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R236 KWidgetsAddons

BRANCH
  KPageListView-updateWidth

REVISION DETAIL
  https://phabricator.kde.org/D8590

To: volkov, cfeck, wojnilowicz, dfaure, rkflx, broulik
Cc: #frameworks

D8619: Refactor and remove duplicate code in kfileplacesview

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kfileplacesview.cpp:66
> +QSize sizeHint(const QStyleOptionViewItem ,
> const QModelIndex ) const Q_DECL_OVERRIDE;
> +void paint(QPainter *painter,

re-indent after the removal of "virtual"

> kfileplacesview.cpp:68
> +void paint(QPainter *painter,
> const QStyleOptionViewItem ,
> const QModelIndex ) const Q_DECL_OVERRIDE;

same here, please re-indent after the removal of "virtual"

> kfileplacesview.cpp:737
> +
> +KFilePlacesViewDelegate *delegate = dynamic_cast *>(itemDelegate());
> +if (!delegate) {

You use qobject_cast elsewhere, why not here too?

Or even... you use static_cast for the delegate in 90% of the code, why two 
uses of qobject_cast?

If it's mandatory for the delegate to be a KFilePlacesViewDelegate, it's 
mandatory everywhere, right?

(too bad setItemDelegate isn't virtual, we could have caught it there...)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8619

To: mlaurent, #frameworks, ervin, dfaure
Cc: dfaure, ngraham

D8632: kded: remove dbus calls to ksplash.

[David Faure]

This revision was automatically updated to reflect the committed changes.
Closed by commit R297:185afa8a3af8: kded: remove dbus calls to ksplash. 
(authored by dfaure).

REPOSITORY
  R297 KDED

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8632?vs=21812=21929

REVISION DETAIL
  https://phabricator.kde.org/D8632

AFFECTED FILES
  src/kded.cpp

To: dfaure, davidedmundson
Cc: #plasma, #frameworks

D8640: [KDirModel] Emit change for HasJobRole when jobs change

[David Faure]

dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kdirmodel.cpp:696
> +std::set_symmetric_difference(urlList.begin(), urlList.end(),
> +  m_allCurrentDestUrls.begin(), 
> m_allCurrentDestUrls.end(),
> +  std::back_inserter(dirtyUrls));

constBegin() / constEnd(), on the non-const m_allCurrentDestUrls, to avoid a 
detach?

> kdirmodel.cpp:703
> +if (KDirModelNode *node = nodeForUrl(QUrl(dirtyUrl))) {
> +const QModelIndex idx = q->index(node->rowNumber(), 0);
> +emit q->dataChanged(idx, idx, {KDirModel::HasJobRole});

You should use indexForNode() instead, to cover the case of the root URL, and 
to set the proper internal pointer in the index (for tree models).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8640

To: broulik, #frameworks, dfaure, hein, mwolff

D8660: ECMAddTests: set QT_PLUGIN_PATH so locally built plugins can be found

[David Faure]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:f7707bb546bc: ECMAddTests: set QT_PLUGIN_PATH so locally 
built plugins can be found (authored by dfaure).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8660?vs=21894=21928

REVISION DETAIL
  https://phabricator.kde.org/D8660

AFFECTED FILES
  modules/ECMAddTests.cmake

To: dfaure, cgiboudeaux, kfunk
Cc: #frameworks, #build_system

D8670: Change label "Advanced options" > "Terminal options"

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  terminal-options-label

REVISION DETAIL
  https://phabricator.kde.org/D8670

To: simgunz, dfaure, ngraham, fabianr
Cc: #frameworks

D8643: Fix display of remote:/ in the qfiledialog

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> kfileitem.cpp:559
>  d->m_strName = name;
> -d->m_strText = KIO::decodeFileName(d->m_strName);
> +if (!d->m_entry.contains(KIO::UDSEntry::UDS_DISPLAY_NAME)) {
> +d->m_strText = KIO::decodeFileName(d->m_strName);

Wouldn't it be safer to say if (!name.isEmpty()), for the actual bug you were 
experiencing?

Otherwise I'm afraid that this commit breaks a number of things, like after 
renaming a file, the new name doesn't appear because the old "display name" 
still applies, or the documented use case for setName which is kfind wanting to 
display subdir/subsubdir/file.txt (same issue, UDS_DISPLAY_NAME would prevent 
that from working).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8643

To: apol, #frameworks, davidedmundson
Cc: dfaure, ngraham

Re: Test failures with krunner 5.39.0

[David Faure]

On mercredi 1 novembre 2017 16:37:30 EET Hartmut Goebel wrote:
> Hallo,
> 
> I'm packaging krunner 5.39.0 for GNU Guix [1]. GNU Guix builds all
> software in an isolated environment (a container), which includes only
> the packages and tools specified explicitly.
> 
> When running the tests, dbusrunnertest faills, with this notable warning
> and the error show below:
> 
>DBusRunnerTest::testMatch() org.kde.krunner: Invalid entry: "DBus
> runner test"
> 
> Any idea what may be missing, what needs to be set up (env-var,
> directory, package, paths)? Any idea hos to debug this further?
> 
> All required packages and all optional/feature packages (except of QCH)
> are installed. I tried running the tests with both dbus-launch and
> without. The external program "testremoterunner" gets started. strace -e
> trace=file" shows nothing relevant (as far as I can tell).
> 
> * Start testing of DBusRunnerTest *
> Config: Using QtTest library 5.9.2, Qt 5.9.2 (x86_64-little_endian-lp64
> shared (dynamic) release build; by GCC 5.4.0)
> PASS   : DBusRunnerTest::initTestCase()
> QWARN  : DBusRunnerTest::testMatch() inotify_add_watch("/etc/mtab")
> failed: "No such file or directory"
> QWARN  : DBusRunnerTest::testMatch() inotify_add_watch("/etc/fstab")
> failed: "No such file or directory"
> QWARN  : DBusRunnerTest::testMatch() org.kde.krunner: Invalid entry:
> "DBus runner test"

I've been debugging this today too (just saw this email now).

It works after "make install", right?
The issue is that when the servicetype isn't installed, the sycoca indexing 
doesn't contain the necessary properties.

The real long term solution would be to port this from KServiceTypeTrader 
(i.e. desktop files) to KPluginMetadata (i.e. plugins with json).
But of course keeping compatibility with desktop file based runners.

I'm doing exactly this for emoticon themes right now, if that works we can 
look at doing the same here.

I saw weird things in gdb while trying to debug this, so I'm only 99% sure of 
my diagnostic, but what's for sure is that it works for me after make install
(into a path whose /share subdir is in $XDG_DATA_DIRS, of course),
and that I can see how the missing servicetype is a huge problem anyway.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

D8670: Change label "Advanced options" > "Terminal options"

[Simone Gaiarin]

simgunz added reviewers: dfaure, ngraham, fabianr.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8670

To: simgunz, dfaure, ngraham, fabianr
Cc: #frameworks

D8670: Change label "Advanced options" > "Terminal options"

[Simone Gaiarin]

simgunz created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  Be more specific with the label as HIG say

REPOSITORY
  R241 KIO

BRANCH
  terminal-options-label

REVISION DETAIL
  https://phabricator.kde.org/D8670

AFFECTED FILES
  src/widgets/kopenwithdialog.cpp

To: simgunz
Cc: #frameworks

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

[Simone Gaiarin]

simgunz added a comment.


  I have fixed what dfaure suggested. I couldn't remove the cast at line 463 
because a Segmentation fault happens. It is not clear to me why exactly.
  
  Regarding removing the categories I need to work on that, because it is not 
trivial apparently. I thought it was enough to remove line 399-404, but in that 
case the treeview is almost empty once opened (only the "Help" item is shown).
  
  I run out of time for today, I'll work on that soon.

REPOSITORY
  R241 KIO

BRANCH
  openwithdialog-filter-app-tree

REVISION DETAIL
  https://phabricator.kde.org/D8056

To: simgunz, dfaure, #frameworks, #vdg, ngraham
Cc: subdiff, fabianr, abetts, ngraham, alexeymin, #frameworks

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

[Simone Gaiarin]

simgunz updated this revision to Diff 21925.
simgunz marked 4 inline comments as done.
simgunz added a comment.


  - Fix code styling
  - Set appModel and proxyModel together, store proxyModel in data member
  - Avoid casts using pointer to proxyModel

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8056?vs=21261=21925

BRANCH
  openwithdialog-filter-app-tree

REVISION DETAIL
  https://phabricator.kde.org/D8056

AFFECTED FILES
  src/widgets/kopenwithdialog.cpp
  src/widgets/kopenwithdialog.h
  src/widgets/kopenwithdialog_p.h

To: simgunz, dfaure, #frameworks, #vdg, ngraham
Cc: subdiff, fabianr, abetts, ngraham, alexeymin, #frameworks

D8636: Add support for downloading the 2nd or 3rd download link from a kde store product when fetching lookandfeel dependencies

[Aleix Pol Gonzalez]

apol added a comment.


  In https://phabricator.kde.org/D8636#164605, @Zren wrote:
  
  > Quick note since I just notice you suggested a lowercase `i` in 
`?linkid=3`, should I change it to lowercase or stick with camelcase?
  
  
  I don't really mind, maybe leave it as `link`?

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D8636

To: Zren, apol
Cc: #frameworks

D8636: Add support for downloading the 2nd or 3rd download link from a kde store product when fetching lookandfeel dependencies

[Chris Holland]

Zren added a comment.


  Quick note since I just notice you suggested a lowercase `i` in `?linkid=3`, 
should I change it to lowercase or stick with camelcase?

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D8636

To: Zren, apol
Cc: #frameworks

Re: Python bindings using cppyy (was: An update on Python bindings)

[Philipp A.]

Hi Shaheed, Chris,

Shaheed Haque  schrieb am Sa., 4. Nov. 2017 um
18:35 Uhr:

> FWIW, I already tried that (types.ModuleType is itself a perfectly
> subclassable class!) […]
>
> Now, none of that may be a limiting factor in the plan you seem to be
> discussing, but it was part of what made me think "here be dragons"...


For me that sounds like a perfectly acceptable clearly-defined instruction:

   - If you can, don’t use a __init__.py for namespace packages (because
   it’s simple).
   - If you need an __init__.py, only use one or use identical ones.

Reasons for needing a __init__.py include the need for toplevel
constants/classes/functions, or supporting Python 2. The docs also say that
you can mix __init__.py omission and (identical) __init__.pys.

I created an example here: https://github.com/flying-sheep/namespace-test

You can see that by using a __init__.py in exactly one of the merged
packages, you can define toplevel constants/classes/functions like BASE in
the example.

If we need, we can also define toplevel constants and so on in multiple
distributions, like this (this specific version requires all distributions
to know about all others, but that’s automatable):

*namespace-test-1/namespace_test/namespace_test_1_init.py*:
FOO = 1
*namespace-test-2/namespace_test/**namespace_test_2_init.py*:
BAR= 1
*namespace-test-{1,2}/namespace_test/**__init__.py*:
from pkgutil import extend_path
__path__ = extend_path(__path__, __name__)
try:
from .namespace_test_1_init import *
except ImportError:
pass
try:
from .namespace_test_2_init import *
except ImportError:
pass

Chris Burel  schrieb am So., 5. Nov. 2017 um
02:49 Uhr:

> I think this is a remarkably short sighted statement. It assumes that
> people that would use these bindings have no existing Python codebase at
> all, and can afford to start a brand new project. The reality is much
> different. […]


No, because you’re missing something here: There’s no KF5 bindings. So
every project that’ll use Shaheed’s new cool KF5 bindings will be a new
project.

Therefore the only thing Python 2 KF5 bindings would accomplish is to make
people think that starting a *new* Python 2 project in 2018 was still a
good idea. Which it isn’t.

Re: Python bindings using cppyy (was: An update on Python bindings)

[Chris Burel]

> On Nov 4, 2017, at 4:46 AM, Philipp A.  wrote:
> 
> Entirely new bindings lead to new applications being written using those 
> bindings. Writing applications in Python 2 is an immediate maintenance burden 
> and people only do it because of stubborn ideology or a complete lack of 
> awareness that Python 2 is being killed off for good.
I think this is a remarkably short sighted statement. It assumes that people 
that would use these bindings have no existing Python codebase at all, and can 
afford to start a brand new project. The reality is much different.

Let's take a specific example. I have 6 years experience writing Python for the 
visual effects industry. We have a 10 year old Python 2 codebase. We also use 
an application from Autodesk called Maya. It has been a Qt 4 application with 
Python 2 embedded since 2012. In 2016 they jumped to qt 5 and pyside2. Now 
Autodesk knows that companies have built large codebase around their product 
that requires Python 2. What would've happened if pyside2 did not support 
Python 2.7? They'd be stuck either forcing all their customers to move to 
Python 3 and risk people not wanting the new version of the software, or they'd 
be prevented from moving to Qt 5.

So no, Python 2 is not dead. Not by a long shot.

-Chris

D7660: Fix a regression caused by changing backspace key behavior

[Safa Alfulaij]

safaalfulaij updated this revision to Diff 21916.
safaalfulaij added a comment.


  - Applying last comment (hopefully I did what you meant :!)

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7660?vs=19781=21916

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7660

AFFECTED FILES
  autotests/src/katedocument_test.cpp
  src/dialogs/katedialogs.cpp
  src/dialogs/navigationconfigwidget.ui
  src/document/katedocument.cpp
  src/utils/kateconfig.cpp
  src/utils/kateconfig.h

To: safaalfulaij, #ktexteditor, jgrulich, hein, dhaumann
Cc: ngraham, anthonyfieroni, cullmann, jgrulich, dhaumann, hein, kwrite-devel, 
#frameworks

D8330: Open files in TagLib extractor readonly

[Nathaniel Graham]

ngraham added a comment.


  Is this ready to land, or do we need some more eyeballs on it first?

REPOSITORY
  R286 KFileMetaData

BRANCH
  readOnly

REVISION DETAIL
  https://phabricator.kde.org/D8330

To: davidk, #frameworks, vhanda, cgiboudeaux, dfaure, mgallien
Cc: mgallien, ngraham, #frameworks

Re: Python bindings using cppyy (was: An update on Python bindings)

[Boudewijn Rempt]

On Sat, 4 Nov 2017, Chris Burel wrote:

> I think this is a remarkably short sighted statement. It assumes that people 
> that would use these bindings have no existing Python codebase at all, and 
> can afford to start a brand new project. The reality is much different.
> 
> Let's take a specific example. I have 6 years experience writing Python for 
> the visual effects industry. We have a 10 year old Python 2 codebase. We also 
> use an application from Autodesk called Maya. It has been a Qt 4 application 
> with Python 2 embedded since 2012. In 2016 they jumped to qt 5 and pyside2. 
> Now Autodesk knows that companies have built large codebase around their 
> product that requires Python 2. What would've happened if pyside2 did not 
> support Python 2.7? They'd be stuck either forcing all their customers to 
> move to Python 3 and risk people not wanting the new version of the software, 
> or they'd be prevented from moving to Qt 5.
> 

You will have to switch to Python 3 by 2019, since that's what the VFX 
Reference Platform says. If you haven't started on the migration yet, you're 
very late. And the VFX Refernece Platform is basically Autodesk telling the 
rest of the industry what to use, including their weird patchset for Qt...

> So no, Python 2 is not dead. Not by a long shot.

For VFX, it will be dead in 2019. See http://www.vfxplatform.com/


-- 
Boudewijn Rempt | http://www.krita.org, http://www.valdyas.org

D8660: ECMAddTests: set QT_PLUGIN_PATH so locally built plugins can be found

[Christophe Giboudeaux]

cgiboudeaux accepted this revision.
cgiboudeaux added a comment.
This revision is now accepted and ready to land.


  +1. Tested with a few repo without noticing any regression.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8660

To: dfaure, cgiboudeaux, kfunk
Cc: #frameworks, #build_system

D7823: Add FindGLIB2.cmake and FindPulseAudio.cmake to ECM

[Christophe Giboudeaux]

cgiboudeaux added a comment.


  In https://phabricator.kde.org/D7823#164474, @cgiboudeaux wrote:
  
  > Don't forget to create .rst files in doc/find-module and change 'Since 
5.39.0' to 'Since 5.40.0'
  
  
  '5.41.0', sorry

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D7823

To: marten, #frameworks, #build_system, cgiboudeaux
Cc: cgiboudeaux, cfeck, heikobecker

D7823: Add FindGLIB2.cmake and FindPulseAudio.cmake to ECM

[Christophe Giboudeaux]

cgiboudeaux accepted this revision.
cgiboudeaux added a comment.
This revision is now accepted and ready to land.


  No news from the ECM maintainer, please push. 
  Don't forget to create .rst files in doc/find-module and change 'Since 
5.39.0' to 'Since 5.40.0'

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D7823

To: marten, #frameworks, #build_system, cgiboudeaux
Cc: cgiboudeaux, cfeck, heikobecker

KDE CI: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 - Build # 61 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20XenialQt5.7/61/
 Project:
Frameworks kcoreaddons kf5-qt5 XenialQt5.7
 Date of build:
Sun, 05 Nov 2017 10:02:28 +
 Build duration:
8 min 2 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 25 test(s), Skipped: 0 test(s), Total: 25 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(10/10)85%
(79/93)85%
(79/93)74%
(6142/8308)44%
(10789/24748)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests83%
(33/40)83%
(33/40)97%
(2636/2723)49%
(6513/13368)src.desktoptojson100%
(3/3)100%
(3/3)79%
(84/106)38%
(123/324)src.lib67%
(2/3)67%
(2/3)60%
(325/541)27%
(220/821)src.lib.caching100%
(2/2)100%
(2/2)45%
(352/787)18%
(192/1076)src.lib.io90%
(9/10)90%
(9/10)61%
(848/1397)33%
(1058/3170)src.lib.jobs71%
(5/7)71%
(5/7)52%
(159/304)39%
(57/146)src.lib.plugin100%
(8/8)100%
(8/8)85%
(650/763)44%
(988/2270)src.lib.randomness100%
(2/2)100%
(2/2)67%
(66/99)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)46%
(355/770)40%
(766/1893)src.lib.util100%
(10/10)100%
(10/10)82%
(667/818)52%
(828/1604)

D8662: Validate that for all attributes an itemData exists

[Dominik Haumann]

dhaumann updated this revision to Diff 21900.
dhaumann added a comment.


  - Fix typo

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8662?vs=21899=21900

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8662

AFFECTED FILES
  src/indexer/katehighlightingindexer.cpp

To: dhaumann, vkrause, cullmann
Cc: #frameworks

D8662: Validate that for all attributes an itemData exists

[Dominik Haumann]

dhaumann added a comment.


  This patch is not yet ready, since we still have the following errors:
  
  1. data/syntax/haml.xml" Reference of non-existing itemData attributes: 
QSet("Array", "Ruby embedded in haml", "Escaped Text")
  2. data/syntax/lilypond.xml" Reference of non-existing itemData attributes: 
QSet("Tremolo")
  3. data/syntax/metafont.xml" Reference of non-existing itemData attributes: 
QSet("Bullet", "Verbatim", "Tex")
  4. data/syntax/relaxng.xml" Reference of non-existing itemData attributes: 
QSet("Entity Reference")
  5. data/syntax/rhtml.xml" Reference of non-existing itemData attributes: 
QSet("RUBY RAILS ERB Text")
  6. data/syntax/rmarkdown.xml" Reference of non-existing itemData attributes: 
QSet("Markdown", "Document Headers")
  7. data/syntax/stata.xml" Reference of non-existing itemData attributes: 
QSet("String2")
  
  Help to fix these is welcome.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D8662

To: dhaumann, vkrause, cullmann
Cc: #frameworks

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7 - Build # 57 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.7/57/
 Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.7
 Date of build:
Sun, 05 Nov 2017 10:02:28 +
 Build duration:
2 min 41 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 20 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_stat_unittestFailed: TestSuite.kshelltest

D8662: Validate that for all attributes an itemData exists

[Dominik Haumann]

dhaumann created this revision.
dhaumann added reviewers: vkrause, cullmann.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  This patch adds a check at compile time that verifies that for
  all refereced attributes an itemData item must exist. If not,
  a failure is raised, stopping the process of creating the Qt
  resource file that contains the syntax highlighting files.

TEST PLAN
  make

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8662

AFFECTED FILES
  src/indexer/katehighlightingindexer.cpp

To: dhaumann, vkrause, cullmann
Cc: #frameworks

D8084: KAutoSaveFile breaks if source file name contains a space!

[Jean-Baptiste Mardelle]

This revision was automatically updated to reflect the committed changes.
Closed by commit R244:8ed107304694: Fix KAutoSave bug on file with white space 
in it (authored by mardelle).

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8084?vs=21868=21898

REVISION DETAIL
  https://phabricator.kde.org/D8084

AFFECTED FILES
  autotests/kautosavefiletest.cpp
  src/lib/io/kautosavefile.cpp

To: mardelle, #frameworks, shaforostoff, dfaure
Cc: dfaure, ngraham, cfeck, ltoscano

D8660: ECMAddTests: set QT_PLUGIN_PATH so locally built plugins can be found

[David Faure]

dfaure created this revision.
dfaure added reviewers: cgiboudeaux, kfunk.
Restricted Application added projects: Frameworks, Build System.

REVISION SUMMARY
  This of course requires running the unittests via ctest rather than
  launching the executable directly.

TEST PLAN
  `ctest -V -R kurifiltertest` in kio, which prints 
QCoreApplication::libraryPaths() at the beginning of the test.
  With this commit, builddir/kio/bin is added at the front of the list, and the 
kurifilter plugins from kio's build are loaded.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D8660

AFFECTED FILES
  CMakeLists.txt

To: dfaure, cgiboudeaux, kfunk
Cc: #frameworks, #build_system

D7612: KDECMakeSettings: more docu about the layout of the build dir

[David Faure]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:d5ac6b2455d0: KDECMakeSettings: more docu about the 
layout of the build dir (authored by dfaure).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7612?vs=18945=21892

REVISION DETAIL
  https://phabricator.kde.org/D7612

AFFECTED FILES
  kde-modules/KDECMakeSettings.cmake

To: dfaure, kossebau
Cc: #build_system, #frameworks

D7612: KDECMakeSettings: more docu about the layout of the build dir

[David Faure]

dfaure added a comment.


  No feedback, but this is just docu, I'll push it.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D7612

To: dfaure, kossebau
Cc: #build_system, #frameworks

KDE CI: Frameworks kxmlgui kf5-qt5 XenialQt5.7 - Build # 49 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kxmlgui%20kf5-qt5%20XenialQt5.7/49/
 Project:
Frameworks kxmlgui kf5-qt5 XenialQt5.7
 Date of build:
Sun, 05 Nov 2017 08:41:48 +
 Build duration:
2 min 25 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)57%
(39/68)57%
(39/68)43%
(4033/9290)34%
(2200/6463)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(11/11)100%
(11/11)99%
(1360/1372)49%
(610/1236)src49%
(28/57)49%
(28/57)34%
(2673/7918)30%
(1590/5227)

KDE CI: Frameworks kwidgetsaddons kf5-qt5 XenialQt5.7 - Build # 55 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20XenialQt5.7/55/
 Project:
Frameworks kwidgetsaddons kf5-qt5 XenialQt5.7
 Date of build:
Sun, 05 Nov 2017 08:41:08 +
 Build duration:
3 min 8 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 19 test(s), Skipped: 0 test(s), Total: 19 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)56%
(83/148)56%
(83/148)30%
(4384/14402)23%
(1779/7879)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(33/33)100%
(33/33)99%
(1577/1592)52%
(838/1606)src43%
(50/115)43%
(50/115)22%
(2807/12810)15%
(941/6273)

D8084: KAutoSaveFile breaks if source file name contains a space!

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D8084

To: mardelle, #frameworks, shaforostoff, dfaure
Cc: dfaure, ngraham, cfeck, ltoscano

KDE CI: Frameworks kemoticons kf5-qt5 XenialQt5.7 - Build # 27 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kemoticons%20kf5-qt5%20XenialQt5.7/27/
 Project:
Frameworks kemoticons kf5-qt5 XenialQt5.7
 Date of build:
Sun, 05 Nov 2017 09:02:28 +
 Build duration:
5 min 44 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.kemoticons-kemoticontestFailed: TestSuite.kemoticons-ktexttohtmlplugintest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(3/3)83%
(10/12)83%
(10/12)36%
(225/621)26%
(122/477)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(3/3)100%
(3/3)95%
(146/153)66%
(102/154)src.core71%
(5/7)71%
(5/7)15%
(70/459)4%
(13/313)src.integrationplugin100%
(2/2)100%
(2/2)100%
(9/9)70%
(7/10)

D8660: ECMAddTests: set QT_PLUGIN_PATH so locally built plugins can be found

[David Faure]

dfaure updated this revision to Diff 21894.
dfaure added a comment.


  now with the right patch...

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8660?vs=21893=21894

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8660

AFFECTED FILES
  modules/ECMAddTests.cmake

To: dfaure, cgiboudeaux, kfunk
Cc: #frameworks, #build_system