D4911: add Baloo DBus signals for moved or removed files

2017-11-18 Thread Nathaniel Graham
ngraham added a comment.


  Not to throw cold water on your patch (it's nice to see someone working on 
Baloo!), but perhaps we should continue @cullmann's work to move over to 
Tracker instead. It's an active project, and we would benefit from all the work 
that the GNOME people are putting into it. I fear that Baloo is destined to 
suffer a slow death from bitrot unless it gains at least one full-time 
maintainer. If that happens, Elisa won't be able to rely on it anyway, and that 
code will need to be removed or ported over to use Tracker (or whatever else we 
use instead).

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D4911

To: mgallien, vhanda, dfaure
Cc: ngraham, cullmann, apol, #frameworks


D4911: add Baloo DBus signals for moved or removed files

2017-11-18 Thread Matthieu Gallien
mgallien added a comment.


  Ping

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D4911

To: mgallien, vhanda, dfaure
Cc: cullmann, apol, #frameworks


D6317: fix crash on Windows when deleting an instance of QtMultimediaExtractor

2017-11-18 Thread Matthieu Gallien
mgallien abandoned this revision.
mgallien added a comment.


  I do not have time to properly work on that. See 
https://phabricator.kde.org/D8886 .

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D6317

To: mgallien, #frameworks, davidedmundson
Cc: davidedmundson, #frameworks


D8886: remove extractor based on QtMultimedia

2017-11-18 Thread Matthieu Gallien
mgallien created this revision.
mgallien added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  It is not working well and do not provide much advantages on Linux and 
Windows platforms
  
  It is based on QMediaPlayer and that is not playing well with sound
  volume applet for example.

TEST PLAN
  still compile and run test from taglib extractor

REPOSITORY
  R286 KFileMetaData

BRANCH
  upstream

REVISION DETAIL
  https://phabricator.kde.org/D8886

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/qtmultimediaextractortest.cpp
  autotests/qtmultimediaextractortest.h
  src/extractors/CMakeLists.txt
  src/extractors/qtmultimediaextractor.cpp
  src/extractors/qtmultimediaextractor.h

To: mgallien, #frameworks


D8332: Added baloo urls into places model

2017-11-18 Thread Nathaniel Graham
ngraham added a comment.


  @ervin and @dvratil, I'd like to land this in one week, since it's an open 
dependency blocking a lot of great work in Dolphin. Please respond if you have 
any remaining concerns, and preferably update your status if you don't.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8332

To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham, 
ervin, mlaurent, dfaure
Cc: mwolff, dfaure, ervin, usta, mlaurent, dvratil, ngraham, #frameworks


D8546: Add Aztec code generator

2017-11-18 Thread Volker Krause
vkrause updated this revision to Diff 22559.
vkrause added a comment.


  Separate test images into those containing only rendering/layouting data and 
those with full data encoding.

REPOSITORY
  R280 Prison

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8546?vs=22205=22559

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8546

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/aztec/aztec.qrc
  autotests/aztec/encoding/aztec-complete-big.png
  autotests/aztec/encoding/aztec-complete-compact1.png
  autotests/aztec/encoding/aztec-complete-compact3.png
  autotests/aztec/encoding/aztec-complete-compact4.png
  autotests/aztec/encoding/aztec-complete-full5.png
  autotests/aztec/rendering/aztec-compact-data-0011.png
  autotests/aztec/rendering/aztec-compact-data-0101.png
  autotests/aztec/rendering/aztec-compact-data-1001.png
  autotests/aztec/rendering/aztec-compact-data-1010.png
  autotests/aztec/rendering/aztec-compact-data-.png
  autotests/aztec/rendering/aztec-compact-grid.png
  autotests/aztec/rendering/aztec-compact-mode-.png
  autotests/aztec/rendering/aztec-compact-mode-1234-rev.png
  autotests/aztec/rendering/aztec-compact-mode-1234.png
  autotests/aztec/rendering/aztec-full-data-0011.png
  autotests/aztec/rendering/aztec-full-data-0101.png
  autotests/aztec/rendering/aztec-full-data-1001.png
  autotests/aztec/rendering/aztec-full-data-1010.png
  autotests/aztec/rendering/aztec-full-data-.png
  autotests/aztec/rendering/aztec-full-grid.png
  autotests/aztec/rendering/aztec-full-mode-.png
  autotests/aztec/rendering/aztec-full-mode-1234-rev.png
  autotests/aztec/rendering/aztec-full-mode-1234.png
  autotests/aztecbarcodetest.cpp
  autotests/reedsolomontest.cpp
  src/lib/CMakeLists.txt
  src/lib/aztecbarcode.cpp
  src/lib/aztecbarcode.h
  src/lib/bitvector.cpp
  src/lib/bitvector_p.h
  src/lib/prison.cpp
  src/lib/reedsolomon.cpp
  src/lib/reedsolomon_p.h

To: vkrause, #frameworks, svuorela, dfaure
Cc: dfaure, #frameworks