D9128: [knewstuff] Respect global variable
anthonyfieroni added a comment. In https://phabricator.kde.org/D9128#176957, @mpyne wrote: > Though maybe weak pointers were just there to avoid circular references? Yes, it's look like. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D9128 To: anthonyfieroni, leinir, dfaure, mpyne Cc: mpyne, #frameworks
D9128: [knewstuff] Respect global variable
mpyne accepted this revision. mpyne added a comment. This revision is now accepted and ready to land. I think the change looks good. But if the cache here is holding a *weak* pointer to a `Cache` then every user of this s_cache should be checking for null pointers each time, right? We can do the improved lifetime checking here but I think it would also have worked fine to check weak pointers before using them. Though maybe weak pointers were just there to avoid circular references? REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D9128 To: anthonyfieroni, leinir, dfaure, mpyne Cc: mpyne, #frameworks
D9217: KUriFilter: don't return an error on non-existing files.
dhaumann added a comment. I was just testing this. With this patch, a non-existing ~/test: 1. Dolphin goes to /home/dh/test, and a red box tells the folder does not exist. This is better than the protocol-error message, so https://bugs.kde.org/show_bug.cgi?id=372813 should be fixed. 2. In the file open-dialog: This expands also to /home/dh/test, but does not raise an error. So the contents of the listview remains the same. In summary: 1. is certainly better with this patch. 2. file open dialog was possibly better without this patch, since "~/home" resulted in "/" and not silently in some location that does not exist. This should probably be improved in the file-open dialog itself? All in all, this patch is an improvement. REVISION DETAIL https://phabricator.kde.org/D9217 To: dfaure, emateli, elvisangelaccio, gregormi Cc: dhaumann, broulik, #frameworks
D9217: KUriFilter: don't return an error on non-existing files.
dhaumann added a reviewer: gregormi. REVISION DETAIL https://phabricator.kde.org/D9217 To: dfaure, emateli, elvisangelaccio, gregormi Cc: broulik, #frameworks
D9233: Fix build against older TagLib
This revision was automatically updated to reflect the committed changes. Closed by commit R286:d2d0ae83d2ca: Fix build against TagLib 1.11 (authored by dvratil). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9233?vs=23583=23588 REVISION DETAIL https://phabricator.kde.org/D9233 AFFECTED FILES src/extractors/taglibextractor.cpp To: dvratil, mgallien, aacid Cc: #frameworks
D9233: Fix build against older TagLib
mgallien accepted this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D9233 To: dvratil, mgallien, aacid Cc: #frameworks
D9233: Fix build against older TagLib
aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D9233 To: dvratil, mgallien, aacid Cc: #frameworks
D9233: Fix build against older TagLib
dvratil created this revision. dvratil added a reviewer: mgallien. dvratil added a project: Frameworks. REVISION SUMMARY Fix build of KFileMetadata against TagLib older than 1.11. Fixes build on Windows where Craft only has Taglib 1.9.2 by default. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D9233 AFFECTED FILES src/extractors/taglibextractor.cpp To: dvratil, mgallien Cc: #frameworks
D8056: Improve usability of "Open With" dialog by adding option to filter the application tree
ngraham added a comment. @simgunz, how are we doing on addressing the latest review comments? I just love this new UI; it's a huge improvement over the status quo IMHO, and it would be nice to get it in sometime soon. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8056 To: simgunz, dfaure, #frameworks, #vdg, ngraham, rkflx Cc: rkflx, subdiff, fabianr, abetts, ngraham, alexeymin, #frameworks
KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 21 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/21/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Wed, 06 Dec 2017 19:33:36 + Build duration: 12 min and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 54 test(s), Skipped: 0 test(s), Total: 56 test(s)Failed: TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: TestSuite.kiowidgets-kurifiltertest
KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 21 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/21/ Project: Frameworks kio kf5-qt5 SUSEQt5.7 Date of build: Wed, 06 Dec 2017 19:33:36 + Build duration: 11 min and counting JUnit Tests Name: (root) Failed: 2 test(s), Passed: 54 test(s), Skipped: 0 test(s), Total: 56 test(s)Failed: TestSuite.kiowidgets-kurifiltersearchprovideractionstestFailed: TestSuite.kiowidgets-kurifiltertest
D9128: [knewstuff] Respect global variable
anthonyfieroni added a comment. Any opinion? REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D9128 To: anthonyfieroni, leinir, dfaure Cc: #frameworks
KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 2 - Still Failing!
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/2/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Wed, 06 Dec 2017 19:33:36 + Build duration: 3 min 12 sec and counting CONSOLE OUTPUT [...truncated 424.16 KB...]gmake[2]: *** [src/ioslaves/file/CMakeFiles/kio_file.dir/build.make:63: src/ioslaves/file/CMakeFiles/kio_file.dir/file.cpp.o] Error 1gmake[2]: *** Waiting for unfinished jobs[ 31%] Building CXX object src/ioslaves/file/CMakeFiles/kio_file.dir/file_unix.cpp.oScanning dependencies of target kio_http_cache_cleaner[ 31%] Building CXX object src/ioslaves/http/CMakeFiles/kio_http_cache_cleaner.dir/http_cache_cleaner.cpp.o[ 31%] Building CXX object src/ioslaves/help/CMakeFiles/kio_ghelp.dir/xslt_help.cpp.oGenerating MOC source include/delegateanimationhandler.mocGenerating MOC source include/moc_delegateanimationhandler_p.cppGenerating MOC source include/moc_dropjob.cppGenerating MOC source include/fileundomanager.mocGenerating MOC source include/moc_fileundomanager.cppGenerating MOC source include/moc_fileundomanager_p.cppGenerating MOC source include/jobuidelegate.mocGenerating MOC source include/moc_joburlcache_p.cppGenerating MOC source include/moc_kacleditwidget.cppGenerating MOC source include/moc_kacleditwidget_p.cppGenerating MOC source include/moc_kautomount.cppGenerating MOC source include/moc_kbuildsycocaprogressdialog.cppGenerating MOC source include/moc_kdirlister.cppGenerating MOC source include/moc_kdirmodel.cppGenerating MOC source include/moc_kdynamicjobtracker_p.cppGenerating MOC source include/moc_kfile.cppGenerating MOC source include/moc_kopenwithdialog.cppGenerating MOC source include/moc_kopenwithdialog_p.cppGenerating MOC source include/koverlayiconplugin.moc/usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.9/src/widgets/koverlayiconplugin.cpp:0: Note: No relevant classes found. No output generated.[ 31%] Linking CXX shared module ../../../bin/kf5/kio/help.so[ 31%] Built target kio_help[ 31%] Building CXX object src/ioslaves/help/CMakeFiles/kio_ghelp.dir/kio_ghelp_autogen/mocs_compilation.cpp.oScanning dependencies of target kio_http[ 31%] Building CXX object src/ioslaves/http/CMakeFiles/kio_http_cache_cleaner.dir/kio_http_cache_cleaner_autogen/mocs_compilation.cpp.o[ 31%] Building CXX object src/ioslaves/http/CMakeFiles/kio_http.dir/http.cpp.o[ 31%] Linking CXX shared module ../../../bin/kf5/kio/ghelp.soScanning dependencies of target kio_ftp[ 31%] Building CXX object src/ioslaves/ftp/CMakeFiles/kio_ftp.dir/ftp.cpp.ogmake[1]: *** [CMakeFiles/Makefile2:1609: src/ioslaves/file/CMakeFiles/kio_file.dir/all] Error 2gmake[1]: *** Waiting for unfinished jobs[ 31%] Building CXX object src/ioslaves/http/CMakeFiles/kio_http.dir/httpauthentication.cpp.o[ 31%] Linking CXX executable ../../../bin/kio_http_cache_cleaner[ 31%] Built target kio_ghelp[ 31%] Building CXX object src/ioslaves/ftp/CMakeFiles/kio_ftp.dir/kio_ftp_autogen/mocs_compilation.cpp.o[ 31%] Built target kio_http_cache_cleaner[ 31%] Building CXX object src/ioslaves/http/CMakeFiles/kio_http.dir/httpfilter.cpp.oIn file included from /usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.9/src/ioslaves/http/httpauthentication.cpp:26:/usr/include/gssapi.h:3:2: warning: "this file includes which is deprecated, use instead" [-W#warnings]#warning "this file includes which is deprecated, use instead" ^1 warning generated.[ 31%] Building CXX object src/ioslaves/http/CMakeFiles/kio_http.dir/kio_http_autogen/mocs_compilation.cpp.o[ 31%] Linking CXX shared module ../../../bin/kf5/kio/ftp.so[ 31%] Built target kio_ftp[ 32%] Linking CXX shared module ../../../bin/kf5/kio/http.so[ 32%] Built target kio_httpGenerating MOC source include/moc_kpropertiesdialog.cppGenerating MOC source include/moc_kpropertiesdialog_p.cppGenerating MOC source include/krun.mocGenerating MOC source include/moc_krun.cppGenerating MOC source include/moc_krun_p.cppGenerating MOC source include/moc_kurlcombobox.cppGenerating MOC source include/kurlcompletion.mocGenerating MOC source include/moc_kurlcompletion.cppGenerating MOC source include/kurlrequester.mocGenerating MOC source include/moc_kurlrequester.cppGenerating MOC source include/moc_kurlrequesterdialog.cppGenerating MOC source include/moc_pastejob.cppGenerating MOC source include/moc_previewjob.cppGenerating MOC source EWIEGA46WW/moc_accessmanager.cppGenerating MOC source EWIEGA46WW/moc_accessmanagerreply_p.cppGenerating MOC source EWIEGA46WW/moc_clipboardupdater_p.cppGenerating MOC source EWIEGA46WW/moc_dndpopupmenuplugin.cppGenerating MOC source EWIEGA46WW/moc_executablefileopendialog_p.cppGenerating MOC source EWIEGA46WW/moc_jobuidelegate.cppGenerating MOC source EWIEGA46WW/moc_kabstractfileitemactionplugin.cppGenerating MOC source EWIEGA46WW/moc_kfileitemactions.cppGenerating MOC source EWIEGA46WW/moc_kfileitemactions_p.cppGenerating MOC source
D9220: [KOpenWithDialog] Remove redundant creation of KLineEdit
This revision was automatically updated to reflect the committed changes. Closed by commit R241:9f722407d902: [KOpenWithDialog] Remove redundant creation of KLineEdit (authored by anthonyfieroni). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9220?vs=23545=23582 REVISION DETAIL https://phabricator.kde.org/D9220 AFFECTED FILES src/widgets/kopenwithdialog.cpp To: anthonyfieroni, dfaure, mwolff Cc: #frameworks
D9214: Remove unused keyword lists and contexts
This revision was automatically updated to reflect the committed changes. Closed by commit R216:f78b2e533fc1: Remove unused keyword lists and contexts (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9214?vs=23530=23579 REVISION DETAIL https://phabricator.kde.org/D9214 AFFECTED FILES data/syntax/ample.xml data/syntax/ansforth94.xml data/syntax/css.xml data/syntax/dosbat.xml data/syntax/euphoria.xml data/syntax/freebasic.xml data/syntax/fsharp.xml data/syntax/gcc.xml data/syntax/ilerpg.xml data/syntax/metafont.xml data/syntax/pango.xml data/syntax/powershell.xml data/syntax/ruby.xml data/syntax/scss.xml data/syntax/tcsh.xml data/syntax/vhdl.xml data/syntax/xmldebug.xml data/syntax/xonotic-console.xml To: dhaumann, vkrause Cc: #frameworks
D9212: Pony: Remove unused keyword lists
This revision was automatically updated to reflect the committed changes. Closed by commit R216:f930d6dbc399: Pony: Remove unused keyword lists (authored by dhaumann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9212?vs=23527=23578 REVISION DETAIL https://phabricator.kde.org/D9212 AFFECTED FILES data/syntax/pony.xml To: dhaumann, jpoelen, jpoelen2, vkrause Cc: #frameworks
D9212: Pony: Remove unused keyword lists
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH PonyCleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D9212 To: dhaumann, jpoelen, jpoelen2, vkrause Cc: #frameworks
D9214: Remove unused keyword lists and contexts
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH RemoveUnusedKeywordLists (branched from master) REVISION DETAIL https://phabricator.kde.org/D9214 To: dhaumann, vkrause Cc: #frameworks
KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 1 - Failure!
BUILD FAILURE
Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/1/
Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
Date of build:
Wed, 06 Dec 2017 18:07:56 +
Build duration:
1 min 54 sec and counting
CONSOLE OUTPUT
Started by user Tobias C. Berner[Pipeline] nodeRunning on FreeBSD Builder 2 in /usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.9[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] deleteDir[Pipeline] checkoutCloning the remote Git repositoryCloning repository git://anongit.kde.org/kio > git init /usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.9 # timeout=10Fetching upstream changes from git://anongit.kde.org/kio > git --version # timeout=10 > git fetch --tags --progress git://anongit.kde.org/kio +refs/heads/*:refs/remotes/origin/* # timeout=120 > git config remote.origin.url git://anongit.kde.org/kio # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url git://anongit.kde.org/kio # timeout=10Fetching upstream changes from git://anongit.kde.org/kio > git fetch --tags --progress git://anongit.kde.org/kio +refs/heads/*:refs/remotes/origin/* # timeout=120 > git rev-parse origin/master^{commit} # timeout=10Checking out Revision 73bc57f82042b3374a12bce270ce028d7473684c (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f 73bc57f82042b3374a12bce270ce028d7473684cCommit message: "QTest::qWaitForWindowActive uses Q_REQUIRED_RESULT"First time build. Skipping changelog.[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/sysadmin/ci-tooling > git init /usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.9/ci-tooling # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/ci-tooling > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/sysadmin/ci-tooling +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/sysadmin/ci-tooling # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/sysadmin/ci-tooling # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/ci-tooling > git fetch --tags --progress https://anongit.kde.org/sysadmin/ci-tooling +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision 2b00a24eb7b9655869e5a57f28c544d6f379a9fc (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f 2b00a24eb7b9655869e5a57f28c544d6f379a9fcCommit message: "QCA isn't available for Qt 5.7"[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/sysadmin/repo-metadata > git init /usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.9/ci-tooling/repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision 9413af76df3d6bb10b1da0565ec19f6d996903a4 (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f 9413af76df3d6bb10b1da0565ec19f6d996903a4Commit message: "Move Plasma MyCroft to KDE Review at the request of it's maintainer. Fixes T7540"[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/kde-build-metadata > git init /usr/home/jenkins/workspace/Frameworks kio kf5-qt5 FreeBSDQt5.9/ci-tooling/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* > git rev-parse
D9217: KUriFilter: don't return an error on non-existing files.
emateli added a comment. I can't seem to be able to properly run this(whatever changes I make to the kshorturifilter.cpp seem to be ignored?!) but on paper looks good to me. Do we mark https://phabricator.kde.org/D8920 as abandoned, or wait for this to commit then the new `dir` property of KUrlNavigator can be pushed as well. REVISION DETAIL https://phabricator.kde.org/D9217 To: dfaure, emateli, elvisangelaccio Cc: broulik, #frameworks
D8652: Add supported transformations to OutputDevice
graesslin added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. In https://phabricator.kde.org/D8652#176706, @davidedmundson wrote: > The comment about being static needs to be in the protocol xml too. Then this is good to go. > > ( though what's your reasoning for not just having the argument as a Wayland array ?) I didn't think of it. Just followed the existing way to announce modes. REPOSITORY R127 KWayland BRANCH supported-transformations REVISION DETAIL https://phabricator.kde.org/D8652 To: graesslin, #frameworks, #kwin, #plasma, sebas, davidedmundson Cc: sebas, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart
D8652: Add supported transformations to OutputDevice
davidedmundson accepted this revision. davidedmundson added a comment. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. The comment about being static needs to be in the protocol xml too. Then this is good to go. ( though what's your reasoning for not just having the argument as a Wayland array ?) REPOSITORY R127 KWayland BRANCH supported-transformations REVISION DETAIL https://phabricator.kde.org/D8652 To: graesslin, #frameworks, #kwin, #plasma, sebas, davidedmundson Cc: sebas, davidedmundson, plasma-devel, leezu, ZrenBot, alexeymin, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, apol, mart, hein
D8450: User can now hide an entire places group from KFilePlacesView
renatoo accepted this revision.
renatoo added a comment.
Looks good and work as expected
INLINE COMMENTS
> kfileplacesview.cpp:766
> +}
> if (!clickOverHeader && index.isValid()) {
> if (!placesModel->isDevice(index)) {
I think that you can replace
if (!clickOverHeader && index.isValid()) {
with
else if (index.isValid()) {
}
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8450
To: franckarrecot, ngraham, renatoo, ervin, mwolff, mlaurent
Cc: mwolff, #frameworks
D8367: Hidding place groups implementation in KFilePlacesModel
renatoo accepted this revision. renatoo added a comment. Looks good and works as expected REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8367 To: franckarrecot, renatoo, ngraham, ervin, mwolff, mlaurent Cc: mwolff, ngraham, mlaurent, #frameworks
D8450: User can now hide an entire places group from KFilePlacesView
mwolff accepted this revision.
mwolff added a comment.
This revision is now accepted and ready to land.
one minor nit, otherwise lgtm
INLINE COMMENTS
> kfileplacesmodel.cpp:431
> +QModelIndexList indexes;
> +for (int row = 0; row < rowCount(); ++row) {
> +const QModelIndex current = index(row, 0);
only call rowCount once:
for (int row = 0, c = rowCount(); row < c; ++row) {
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D8450
To: franckarrecot, ngraham, renatoo, ervin, mwolff, mlaurent
Cc: mwolff, #frameworks
D8367: Hidding place groups implementation in KFilePlacesModel
mwolff accepted this revision. mwolff added a comment. This revision is now accepted and ready to land. lgtm REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8367 To: franckarrecot, renatoo, ngraham, ervin, mwolff, mlaurent Cc: mwolff, ngraham, mlaurent, #frameworks
KDE CI: Frameworks kconfig kf5-qt5 SUSEQt5.10 - Build # 8 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20SUSEQt5.10/8/ Project: Frameworks kconfig kf5-qt5 SUSEQt5.10 Date of build: Wed, 06 Dec 2017 10:55:04 + Build duration: 2 min 0 sec and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 36 test(s), Skipped: 0 test(s), Total: 36 test(s)
D9224: Deprecate KDesktopFile::sortOrder()
volkov updated this revision to Diff 23553. volkov added a comment. add 'since 5.42' REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9224?vs=23552=23553 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9224 AFFECTED FILES autotests/kdesktopfiletest.cpp src/core/kdesktopfile.cpp src/core/kdesktopfile.h To: volkov, dfaure, #frameworks Cc: #frameworks
D9224: Deprecate KDesktopFile::sortOrder()
This revision was automatically updated to reflect the committed changes. Closed by commit R237:a69d8e562b6e: Deprecate KDesktopFile::sortOrder() (authored by volkov). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9224?vs=23553=23554 REVISION DETAIL https://phabricator.kde.org/D9224 AFFECTED FILES autotests/kdesktopfiletest.cpp src/core/kdesktopfile.cpp src/core/kdesktopfile.h To: volkov, dfaure, #frameworks Cc: #frameworks
D9224: Deprecate KDesktopFile::sortOrder()
dfaure accepted this revision. dfaure added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kdesktopfile.h:221 > * @return the value of the "SortOrder=" entry. > + * @deprecated > + * SortOrder was used to specify the order of menu items, but @deprecated since 5.42 REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D9224 To: volkov, dfaure, #frameworks Cc: #frameworks
D9224: Deprecate KDesktopFile::sortOrder()
volkov updated this revision to Diff 23552. volkov added a comment. make the test buildable with KDE_NO_DEPRECATED REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9224?vs=23551=23552 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9224 AFFECTED FILES autotests/kdesktopfiletest.cpp src/core/kdesktopfile.cpp src/core/kdesktopfile.h To: volkov, dfaure, #frameworks Cc: #frameworks
D9224: Deprecate KDesktopFile::sortOrder()
volkov added reviewers: dfaure, Frameworks. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D9224 To: volkov, dfaure, #frameworks Cc: #frameworks
D9224: Deprecate KDesktopFile::sortOrder()
volkov created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY The SortOrder key is deprecated by the Desktop Entry Specification: https://standards.freedesktop.org/desktop-entry-spec/latest/apc.html REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D9224 AFFECTED FILES src/core/kdesktopfile.cpp src/core/kdesktopfile.h To: volkov Cc: #frameworks
D9223: [Plasma Dialog] Call window effects only if visible
broulik created this revision. broulik added reviewers: Plasma, graesslin. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY It spends 160ms in total on plasmashell startup for me here. TEST PLAN My plasma popups are still properly blurred both on X and Wayland The `updateTheme()` method is called way to often, however. Didn't check whether it was generating the mask or the X calls (probably both) is what makes it slow. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9223 AFFECTED FILES src/plasmaquick/dialog.cpp To: broulik, #plasma, graesslin Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
KDE CI: Frameworks kconfig kf5-qt5 SUSEQt5.10 - Build # 7 - Still Failing!
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20SUSEQt5.10/7/ Project: Frameworks kconfig kf5-qt5 SUSEQt5.10 Date of build: Wed, 06 Dec 2017 10:13:12 + Build duration: 4 min 36 sec and counting CONSOLE OUTPUT [...truncated 256.41 KB...][ 61%] Linking CXX executable ../bin/kstandardshortcuttest[ 61%] Linking CXX executable ../bin/kconfigskeletontest[ 61%] Building CXX object autotests/kconfig_compiler/CMakeFiles/test5.dir/test5_autogen/mocs_compilation.cpp.o[ 61%] Building CXX object autotests/kconfig_compiler/CMakeFiles/kconfigcompiler-signals-test.dir/signals_test_singleton.cpp.o[ 61%] Built target kconfigskeletontest[ 61%] Built target kstandardshortcuttest[ 62%] Building CXX object autotests/kconfig_compiler/CMakeFiles/kconfigcompiler-signals-test.dir/signals_test_no_singleton.cpp.oScanning dependencies of target test4[ 63%] Building CXX object autotests/kconfig_compiler/CMakeFiles/test4.dir/test4main.cpp.o[ 63%] Linking CXX executable ../bin/kconfigloadertest[ 63%] Linking CXX executable ../../bin/test5[ 64%] Built target test5[ 64%] Built target kconfigloadertestScanning dependencies of target test3aScanning dependencies of target test1[ 64%] Building CXX object autotests/kconfig_compiler/CMakeFiles/test3a.dir/test3amain.cpp.o[ 64%] Building CXX object autotests/kconfig_compiler/CMakeFiles/test1.dir/test1main.cpp.o[ 64%] Building CXX object autotests/kconfig_compiler/CMakeFiles/test4.dir/test4.cpp.o[ 64%] Building CXX object autotests/kconfig_compiler/CMakeFiles/test1.dir/test1.cpp.o[ 64%] Building CXX object autotests/kconfig_compiler/CMakeFiles/test3a.dir/test3a.cpp.o[ 64%] Building CXX object autotests/kconfig_compiler/CMakeFiles/test4.dir/test4_autogen/mocs_compilation.cpp.o[ 65%] Linking CXX executable ../../bin/test4[ 66%] Building CXX object autotests/kconfig_compiler/CMakeFiles/test3a.dir/test3a_autogen/mocs_compilation.cpp.o[ 66%] Linking CXX executable ../../bin/test3a[ 66%] Built target test4Scanning dependencies of target test6[ 67%] Building CXX object autotests/kconfig_compiler/CMakeFiles/test6.dir/test6main.cpp.o[ 68%] Building CXX object autotests/kconfig_compiler/CMakeFiles/test1.dir/test1_autogen/mocs_compilation.cpp.o[ 68%] Linking CXX executable ../../bin/test1[ 70%] Built target test3a[ 70%] Built target test1[ 70%] Building CXX object autotests/kconfig_compiler/CMakeFiles/test6.dir/test6.cpp.o[ 70%] Building CXX object autotests/kconfig_compiler/CMakeFiles/kconfigcompiler-signals-test.dir/signals_test_singleton_dpointer.cpp.o[ 71%] Building CXX object autotests/kconfig_compiler/CMakeFiles/kconfigcompiler-signals-test.dir/signals_test_no_singleton_dpointer.cpp.o[ 71%] Building CXX object autotests/kconfig_compiler/CMakeFiles/kconfigcompiler-signals-test.dir/kconfigcompiler-signals-test_autogen/mocs_compilation.cpp.o[ 71%] Building CXX object autotests/kconfig_compiler/CMakeFiles/test6.dir/test6_autogen/mocs_compilation.cpp.oScanning dependencies of target test11Scanning dependencies of target test7[ 72%] Building CXX object autotests/kconfig_compiler/CMakeFiles/test11.dir/test11main.cpp.o[ 72%] Building CXX object autotests/kconfig_compiler/CMakeFiles/test7.dir/test7main.cpp.o[ 72%] Building CXX object autotests/kconfig_compiler/CMakeFiles/test11.dir/test11.cpp.o[ 73%] Linking CXX executable ../../bin/test6Scanning dependencies of target test2[ 73%] Building CXX object autotests/kconfig_compiler/CMakeFiles/test2.dir/test2main.cpp.o[ 73%] Building CXX object autotests/kconfig_compiler/CMakeFiles/test11.dir/test11a.cpp.o[ 73%] Linking CXX executable ../../bin/kconfigcompiler-signals-test[ 73%] Built target test6[ 74%] Building CXX object autotests/kconfig_compiler/CMakeFiles/test11.dir/test11_autogen/mocs_compilation.cpp.o[ 74%] Building CXX object autotests/kconfig_compiler/CMakeFiles/test2.dir/test2.cpp.o[ 75%] Building CXX object autotests/kconfig_compiler/CMakeFiles/test7.dir/test7.cpp.o[ 76%] Building CXX object autotests/kconfig_compiler/CMakeFiles/test2.dir/test2_autogen/mocs_compilation.cpp.o[ 76%] Built target kconfigcompiler-signals-testScanning dependencies of target test12Scanning dependencies of target test8[ 76%] Building CXX object autotests/kconfig_compiler/CMakeFiles/test12.dir/test12main.cpp.o[ 77%] Building CXX object autotests/kconfig_compiler/CMakeFiles/test8.dir/test8main.cpp.o[ 77%] Linking CXX executable ../../bin/test11[ 77%] Built target test11[ 77%] Building CXX object autotests/kconfig_compiler/CMakeFiles/test12.dir/test12.cpp.o[ 77%] Building CXX object autotests/kconfig_compiler/CMakeFiles/test7.dir/test7_autogen/mocs_compilation.cpp.o[ 77%] Linking CXX executable ../../bin/test7[ 77%] Linking CXX executable ../../bin/test2[ 77%] Built target test7[ 77%] Building CXX object autotests/kconfig_compiler/CMakeFiles/test8.dir/test8a.cpp.o[ 78%] Built target test2[ 79%] Building CXX object
D9189: Do not crash when setting new line edit on an editable combo box
This revision was automatically updated to reflect the committed changes. Closed by commit R284:fa2c4484d8db: Do not crash when setting new line edit on an editable combo box (authored by mwolff). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9189?vs=23508=23549#toc REPOSITORY R284 KCompletion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9189?vs=23508=23549 REVISION DETAIL https://phabricator.kde.org/D9189 AFFECTED FILES autotests/kcombobox_unittest.cpp src/kcombobox.cpp To: mwolff, dfaure, anthonyfieroni Cc: #frameworks
KDE CI: Frameworks kconfig kf5-qt5 SUSEQt5.10 - Build # 6 - Failure!
BUILD FAILURE Build URL https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20SUSEQt5.10/6/ Project: Frameworks kconfig kf5-qt5 SUSEQt5.10 Date of build: Wed, 06 Dec 2017 10:00:49 + Build duration: 11 min and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 36 test(s), Skipped: 0 test(s), Total: 36 test(s) CONSOLE OUTPUT [...truncated 403.29 KB...][ 91%] Built target test_translation_kde[ 93%] Built target test_dpointer[ 96%] Built target test_qdebugcategory[ 98%] Built target test_signal[100%] Built target kstandardshortcuttestInstall the project...-- Install configuration: "Debug"-- Installing: /home/jenkins/workspace/Frameworks kconfig kf5-qt5 SUSEQt5.10/install-divert/home/jenkins/install-prefix/lib64/cmake/KF5Config/KF5ConfigConfig.cmake-- Installing: /home/jenkins/workspace/Frameworks kconfig kf5-qt5 SUSEQt5.10/install-divert/home/jenkins/install-prefix/lib64/cmake/KF5Config/KF5ConfigConfigVersion.cmake-- Installing: /home/jenkins/workspace/Frameworks kconfig kf5-qt5 SUSEQt5.10/install-divert/home/jenkins/install-prefix/lib64/cmake/KF5Config/KF5ConfigMacros.cmake-- Installing: /home/jenkins/workspace/Frameworks kconfig kf5-qt5 SUSEQt5.10/install-divert/home/jenkins/install-prefix/lib64/cmake/KF5Config/KF5ConfigTargets.cmake-- Installing: /home/jenkins/workspace/Frameworks kconfig kf5-qt5 SUSEQt5.10/install-divert/home/jenkins/install-prefix/lib64/cmake/KF5Config/KF5ConfigTargets-debug.cmake-- Installing: /home/jenkins/workspace/Frameworks kconfig kf5-qt5 SUSEQt5.10/install-divert/home/jenkins/install-prefix/lib64/cmake/KF5Config/KF5ConfigCompilerTargets.cmake-- Installing: /home/jenkins/workspace/Frameworks kconfig kf5-qt5 SUSEQt5.10/install-divert/home/jenkins/install-prefix/lib64/cmake/KF5Config/KF5ConfigCompilerTargets-debug.cmake-- Installing: /home/jenkins/workspace/Frameworks kconfig kf5-qt5 SUSEQt5.10/install-divert/home/jenkins/install-prefix/include/KF5/kconfig_version.h-- Installing: /home/jenkins/workspace/Frameworks kconfig kf5-qt5 SUSEQt5.10/install-divert/home/jenkins/install-prefix/lib64/libKF5ConfigCore.so.5.41.0-- Installing: /home/jenkins/workspace/Frameworks kconfig kf5-qt5 SUSEQt5.10/install-divert/home/jenkins/install-prefix/lib64/libKF5ConfigCore.so.5-- Installing: /home/jenkins/workspace/Frameworks kconfig kf5-qt5 SUSEQt5.10/install-divert/home/jenkins/install-prefix/lib64/libKF5ConfigCore.so-- Set runtime path of "/home/jenkins/workspace/Frameworks kconfig kf5-qt5 SUSEQt5.10/install-divert//home/jenkins/install-prefix/lib64/libKF5ConfigCore.so.5.41.0" to "/home/jenkins/install-prefix/lib64"-- Installing: /home/jenkins/workspace/Frameworks kconfig kf5-qt5 SUSEQt5.10/install-divert/home/jenkins/install-prefix/include/KF5/KConfigCore/kconfigcore_export.h-- Installing: /home/jenkins/workspace/Frameworks kconfig kf5-qt5 SUSEQt5.10/install-divert/home/jenkins/install-prefix/include/KF5/KConfigCore/KAuthorized-- Installing: /home/jenkins/workspace/Frameworks kconfig kf5-qt5 SUSEQt5.10/install-divert/home/jenkins/install-prefix/include/KF5/KConfigCore/KConfig-- Installing: /home/jenkins/workspace/Frameworks kconfig kf5-qt5 SUSEQt5.10/install-divert/home/jenkins/install-prefix/include/KF5/KConfigCore/KConfigBase-- Installing: /home/jenkins/workspace/Frameworks kconfig kf5-qt5 SUSEQt5.10/install-divert/home/jenkins/install-prefix/include/KF5/KConfigCore/KConfigGroup-- Installing: /home/jenkins/workspace/Frameworks kconfig kf5-qt5 SUSEQt5.10/install-divert/home/jenkins/install-prefix/include/KF5/KConfigCore/KDesktopFile-- Installing: /home/jenkins/workspace/Frameworks kconfig kf5-qt5 SUSEQt5.10/install-divert/home/jenkins/install-prefix/include/KF5/KConfigCore/KSharedConfig-- Installing: /home/jenkins/workspace/Frameworks kconfig kf5-qt5 SUSEQt5.10/install-divert/home/jenkins/install-prefix/include/KF5/KConfigCore/KCoreConfigSkeleton-- Installing: /home/jenkins/workspace/Frameworks kconfig kf5-qt5 SUSEQt5.10/install-divert/home/jenkins/install-prefix/include/KF5/KConfigCore/KEMailSettings-- Installing: /home/jenkins/workspace/Frameworks kconfig kf5-qt5 SUSEQt5.10/install-divert/home/jenkins/install-prefix/include/KF5/KConfigCore/ConversionCheck-- Installing: /home/jenkins/workspace/Frameworks kconfig kf5-qt5 SUSEQt5.10/install-divert/home/jenkins/install-prefix/include/KF5/KConfigCore/kauthorized.h-- Installing: /home/jenkins/workspace/Frameworks kconfig kf5-qt5 SUSEQt5.10/install-divert/home/jenkins/install-prefix/include/KF5/KConfigCore/kconfig.h-- Installing: /home/jenkins/workspace/Frameworks kconfig kf5-qt5 SUSEQt5.10/install-divert/home/jenkins/install-prefix/include/KF5/KConfigCore/kconfigbase.h-- Installing: /home/jenkins/workspace/Frameworks kconfig kf5-qt5 SUSEQt5.10/install-divert/home/jenkins/install-prefix/include/KF5/KConfigCore/kconfiggroup.h-- Installing: /home/jenkins/workspace/Frameworks kconfig kf5-qt5
D8689: Fix the result of KDesktopFile::sortOrder()
This revision was automatically updated to reflect the committed changes. Closed by commit R237:d328dd6ac725: Fix the result of KDesktopFile::sortOrder() (authored by volkov). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8689?vs=22018=23548 REVISION DETAIL https://phabricator.kde.org/D8689 AFFECTED FILES autotests/kdesktopfiletest.cpp autotests/kdesktopfiletest.h src/core/kdesktopfile.cpp To: volkov, #frameworks, dfaure Cc: dfaure, #frameworks
D9220: [KOpenWithDialog] Remove redundant creation of KLineEdit
dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9220 To: anthonyfieroni, dfaure, mwolff Cc: #frameworks
D9221: WIP: [KLineEdit] Use Qt's built-in clear button functionality
broulik created this revision. broulik added a reviewer: Frameworks. Restricted Application added a project: Frameworks. REVISION SUMMARY TODO - Figure out how to get the clear button used size (though from what I can tell it's only used by kcombobox and khtml REPOSITORY R284 KCompletion REVISION DETAIL https://phabricator.kde.org/D9221 AFFECTED FILES src/klineedit.cpp src/klineedit.h src/klineedit_p.h To: broulik, #frameworks
D9220: [KOpenWithDialog] Remove redundant creation of KLineEdit
anthonyfieroni added a comment. It should https://api.kde.org/frameworks/kcompletion/html/kcombobox_8cpp_source.html#l00090 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9220 To: anthonyfieroni, dfaure, mwolff Cc: #frameworks
D9220: [KOpenWithDialog] Remove redundant creation of KLineEdit
dfaure added a comment. Is the clear button still shown? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9220 To: anthonyfieroni, dfaure, mwolff Cc: #frameworks
D9220: [KOpenWithDialog] Remove redundant creation of KLineEdit
anthonyfieroni created this revision. anthonyfieroni added reviewers: dfaure, mwolff. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY KHistoryComboBox creates editable KLineEdit REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9220 AFFECTED FILES src/widgets/kopenwithdialog.cpp To: anthonyfieroni, dfaure, mwolff Cc: #frameworks
D8367: Hidding place groups implementation in KFilePlacesModel
mlaurent accepted this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8367 To: franckarrecot, renatoo, ngraham, ervin, mwolff, mlaurent Cc: mwolff, ngraham, mlaurent, #frameworks
D8450: User can now hide an entire places group from KFilePlacesView
mlaurent accepted this revision. mlaurent added inline comments. INLINE COMMENTS > ervin wrote in kfileplacesview.cpp:863-866 > This duplicates code from the next if branch below... I wonder if before or > after that commit we shouldn't try to refactor that and remove some of the > code duplication around the delegate animation use? Ok for removing duplicate code after this patch. Too hard to add patch before it. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8450 To: franckarrecot, ngraham, renatoo, ervin, mwolff, mlaurent Cc: mwolff, #frameworks
Re: Failing KTextEditor unit tests
On lundi 4 décembre 2017 18:38:50 CET Ben Cooksley wrote: > If someone has a list of common font packages for SUSE then I can add > those to the image relatively easy, which will probably fix those > tests. dejavu-fonts might be enough. But otherwise here's a more complete list, from my Leap 42.3 system. adobe-sourcecodepro-fonts adobe-sourcesanspro-fonts adobe-sourceserifpro-fonts cantarell-fonts dejavu-fonts google-carlito-fonts google-droid-fonts google-opensans-fonts google-roboto-fonts hack-fonts kde-oxygen-fonts liberation-fonts lilypond-century-schoolbook-l-fonts lilypond-emmentaler-fonts noto-coloremoji-fonts noto-emoji-fonts noto-sans-fonts stix-fonts xorg-x11-fonts -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5
D9219: WIP: Extend Scripting API
dhaumann created this revision. dhaumann added reviewers: cullmann, mwolff. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This patch extends the KTextEditor scripting API by: - String editor.clipboardText() - StringList editor.clipboardHistory() - void editor.setClipboardText(String text) What's new here is that we introduced a new keyword 'editor' similar to 'view' and 'document'. We can extend this editor object with general purpose functions that are related to the editor. For now, this review request is mostly to raise a discussion about whether we really want to go this way, or whether there is a better way of adding this. TEST PLAN make test, and playing around with this in .js functions. Seems to work as expected. REPOSITORY R39 KTextEditor BRANCH Scripting (branched from master) REVISION DETAIL https://phabricator.kde.org/D9219 AFFECTED FILES src/CMakeLists.txt src/script/katescript.cpp src/script/katescript.h src/script/katescripteditor.cpp src/script/katescripteditor.h To: dhaumann, cullmann, mwolff Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann
