KDE CI: Frameworks baloo kf5-qt5 SUSEQt5.10 - Build # 16 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20baloo%20kf5-qt5%20SUSEQt5.10/16/ Project: Frameworks baloo kf5-qt5 SUSEQt5.10 Date of build: Mon, 08 Jan 2018 23:49:41 + Build duration: 4 min 14 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kinotifytest
D9750: ExpandingWidgetModel: find the right-most column based on location
mwolff created this revision. mwolff added a reviewer: Kate. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. mwolff requested review of this revision. REVISION SUMMARY This fixes the width calculation for the argument hint completion items. There, the view apparently reorders the column, or hides some, and thus the last sibling by column number is not actually the right-most one. In truth, the old algorithm even produced negative widget values, which prevented the argument hint widgets from ever being shown. This patch fixes that. Note: You'll probably need KDevelop to see the effect. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9750 AFFECTED FILES src/completion/expandingtree/expandingwidgetmodel.cpp To: mwolff, #kate Cc: #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann
D9749: Simplify code: return early to reduce indentation depth
mwolff created this revision. mwolff added a reviewer: Kate. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. mwolff requested review of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D9749 AFFECTED FILES src/completion/expandingtree/expandingwidgetmodel.cpp To: mwolff, #kate Cc: #frameworks, michaelh, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann
D9734: [KFileItemActions] Allow specifying the number of selected files required for an action
broulik created this revision. broulik added reviewers: Frameworks, dfaure, michaelh, mlaurent. Restricted Application added a project: Frameworks. broulik requested review of this revision. REVISION SUMMARY This was mostly prompted by https://phabricator.kde.org/D9698 since Kompare can only compare two files and it makes no sense to offer this option for less or more than that. It is done as a QStringList so you could specify multiple criteria, e.g. only show for 2 or 4 files. If the need should arise, this could be made more sophisticated by adding support for e.g. ranges and less than/more than operators, but let's keep it simple for now. CHANGELOG: KonqPopupMenu/Plugin can now use the X-KDE-RequiredNumberOfUrls key to require a certain number of files to be selected before being shown TEST PLAN Added X-KDE-RequiredNumberOfUrls=2 to the desktop file, action showed up only when I selected two files. Also tested `2,4` where it would show up if 2 or 4 files are selected Older KIO versions would just ignore that key and always show the action, which is fine. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9734 AFFECTED FILES src/widgets/kfileitemactions.cpp To: broulik, #frameworks, dfaure, michaelh, mlaurent
D9712: balooctl status: produce parseable output
michaelh marked 2 inline comments as done. michaelh added inline comments. INLINE COMMENTS > lueck wrote in statuscommand.cpp:108 > > The only thing translated in this function is the filename. I am new to > > this, but I think that is the only item that does not need translation. > > It should be exactly the other way round, right? > > "File: %1"will be translated e.g. in german to "Datei: %1" and at runtime %1 > is replaced by the string value of filePath > > > To ease translation, should I break up the strings a little bit? > > Please no, word puzzles are evil for translators Just installed baloo5-lang. Now I see the difference REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D9712 To: michaelh, #frameworks Cc: elvisangelaccio, lueck, dfaure, ngraham
D9712: balooctl status: produce parseable output
michaelh updated this revision to Diff 24943. michaelh added a comment. - Localized messages - Sending error messages to stderr REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9712?vs=24888=24943 BRANCH ctl REVISION DETAIL https://phabricator.kde.org/D9712 AFFECTED FILES src/tools/balooctl/statuscommand.cpp To: michaelh, #frameworks Cc: elvisangelaccio, lueck, dfaure, ngraham
D9669: Use cmake function 'kdbusaddons_generate_dbus_service_file' from kdbusaddons to generate dbus service file
habacker added a comment. Add you as subscriber. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9669 To: habacker, dfaure, kfunk, bcooksley Cc: #frameworks
D9669: Use cmake function 'kdbusaddons_generate_dbus_service_file' from kdbusaddons to generate dbus service file
dfaure added a comment. In https://phabricator.kde.org/D9669#187624, @habacker wrote: > thanks for this pointer, see T7711 FYI, I can't, it's a "private" issue by default. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9669 To: habacker, dfaure, kfunk, bcooksley Cc: #frameworks
D9669: Use cmake function 'kdbusaddons_generate_dbus_service_file' from kdbusaddons to generate dbus service file
habacker added a comment. thanks for this pointer, see T7711 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9669 To: habacker, dfaure, kfunk, bcooksley Cc: #frameworks
D6830: Make use of kauth helper in copy method of file ioslave
chinmoyr added a comment. ping REPOSITORY R241 KIO BRANCH 6830 REVISION DETAIL https://phabricator.kde.org/D6830 To: chinmoyr, dfaure, #frameworks Cc: elvisangelaccio, #frameworks
D6832: Integrate new file ioslave in KIO job
chinmoyr added a comment. ping REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D6832 To: chinmoyr, dfaure, #frameworks Cc: mreeves, #frameworks
D7272: [DropJob] Enable drag and drop in a read-only folder
chinmoyr added a comment. ping REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7272 To: chinmoyr, #frameworks, dfaure Cc: mreeves, ngraham
D9729: [KPropertiesDialog] Enable word wrap for checksum description
broulik created this revision. broulik added reviewers: Frameworks, elvisangelaccio. Restricted Application added a project: Frameworks. broulik requested review of this revision. REVISION SUMMARY Depending on locale this text can become rather long making the dialog overly wide. TEST PLAN No longer have a wide dialog REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9729 AFFECTED FILES src/widgets/checksumswidget.ui To: broulik, #frameworks, elvisangelaccio
D8536: Add more hashing algorithms to KPropertiesDialog
broulik added inline comments. INLINE COMMENTS > checksumswidget.ui:62 > > - MD5: > + Value > Perhaps "Result:"? > checksumswidget.ui:76 > + > + Algorithm > + Shouldn't that have a colon at the end? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8536 To: petermajchrak, elvisangelaccio, #vdg, colomar Cc: broulik, colomar, anthonyfieroni, bcooksley, alexeymin, ngraham, elvisangelaccio, #frameworks
D9669: Use cmake function 'kdbusaddons_generate_dbus_service_file' from kdbusaddons to generate dbus service file
dfaure added a comment. As a KDE sysadmin ticket; the sysadmins want to centralize KDE's issues with Phabricator before reporting them upstream (to present a unified front and avoid duplicates). REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9669 To: habacker, dfaure, kfunk, bcooksley Cc: #frameworks
D9429: Remove unused and duplicated file
habacker closed this revision. habacker added a comment. patch has been applied REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D9429 To: habacker, dfaure, apol Cc: apol, #frameworks
D9669: Use cmake function 'kdbusaddons_generate_dbus_service_file' from kdbusaddons to generate dbus service file
habacker added a comment. In https://phabricator.kde.org/D9669#187313, @habacker wrote: > - 5.42.0 is out, update version to 5.43.0 The patch update demonstrates a surprising phabricator behavior not updating commit messages - where should I report it ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9669 To: habacker, dfaure, kfunk, bcooksley Cc: #frameworks
KDE CI: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.9 - Build # 6 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20FreeBSDQt5.9/6/ Project: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.9 Date of build: Mon, 08 Jan 2018 08:06:23 + Build duration: 5 min 48 sec and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 13 test(s)
KDE CI: Frameworks kwindowsystem kf5-qt5 SUSEQt5.7 - Build # 10 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20SUSEQt5.7/10/ Project: Frameworks kwindowsystem kf5-qt5 SUSEQt5.7 Date of build: Mon, 08 Jan 2018 08:06:23 + Build duration: 3 min 34 sec and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 14 test(s) Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report67% (4/6)80% (47/59)80% (47/59)75% (7194/9558)54% (4087/7516)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests89% (16/18)89% (16/18)97% (3077/3161)52% (1748/3371)autotests.helper100% (1/1)100% (1/1)70% (7/10)50% (3/6)src94% (15/16)94% (15/16)57% (794/1395)46% (342/747)src.platforms.wayland0% (0/3)0% (0/3)0% (0/71)100% (0/0)src.platforms.xcb94% (15/16)94% (15/16)71% (3316/4642)60% (1994/3342)tests0% (0/5)0% (0/5)0% (0/279)0% (0/50)
KDE CI: Frameworks kwindowsystem kf5-qt5 SUSEQt5.10 - Build # 10 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20SUSEQt5.10/10/ Project: Frameworks kwindowsystem kf5-qt5 SUSEQt5.10 Date of build: Mon, 08 Jan 2018 08:06:23 + Build duration: 3 min 34 sec and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 14 test(s) Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report67% (4/6)80% (47/59)80% (47/59)75% (7194/9558)54% (4089/7516)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests89% (16/18)89% (16/18)97% (3077/3161)52% (1748/3371)autotests.helper100% (1/1)100% (1/1)70% (7/10)50% (3/6)src94% (15/16)94% (15/16)57% (793/1395)46% (343/747)src.platforms.wayland0% (0/3)0% (0/3)0% (0/71)100% (0/0)src.platforms.xcb94% (15/16)94% (15/16)71% (3317/4642)60% (1995/3342)tests0% (0/5)0% (0/5)0% (0/279)0% (0/50)
