D8958: Fix unintentional breadcrumb menu item activation

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Ah, OK.

REPOSITORY
  R241 KIO

BRANCH
  fix_accidental_breadcrumb_menu_item_activation

REVISION DETAIL
  https://phabricator.kde.org/D8958

To: aleksejshilin, #frameworks, dfaure
Cc: broulik, ngraham, michaelh

D10646: Support case-insensitive WordDetect

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  In general looks good, and it even revealed a bug as I understand.
  
  However, the KTextEditor framework still has its own implementation of the 
syntax highlighting. Can you also provide a patch there, so both 
implementations behave the same?

INLINE COMMENTS

> rule_p.h:249
>  QString m_word;
> +Qt::CaseSensitivity m_caseSensitivity;
>  };

Could you initialize this to CaseInsensitive with in-class member 
initialization?

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  word_insensitive

REVISION DETAIL
  https://phabricator.kde.org/D10646

To: jpoelen, dhaumann
Cc: dhaumann, #frameworks, michaelh

D10627: Reduce plasmashell frozen time to almost nothing

[Jaime Torres Amate]

jtamate retitled this revision from "Reduce plasma lock up time to almost 
nothing" to "Reduce plasmashell frozen time to almost nothing".
jtamate edited the summary of this revision.
jtamate edited the test plan for this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  polling (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10627

To: jtamate, #frameworks, #plasma, davidedmundson
Cc: broulik, davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.9 - Build # 197 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.9/197/
 Project:
Frameworks kio kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Mon, 19 Feb 2018 04:00:34 +
 Build duration:
1 hr 12 min and counting
   CONSOLE OUTPUT
  [...truncated 581.13 KB...][ 46%] Linking CXX executable ..\bin\kmountpointtest.exe[ 46%] Built target kmountpointtestScanning dependencies of target listdirtest[ 46%] Building CXX object autotests/CMakeFiles/listdirtest.dir/listdirtest.cpp.obj[ 46%] Building CXX object autotests/CMakeFiles/listdirtest.dir/listdirtest_autogen/mocs_compilation.cpp.objlistdirtest.cppmocs_compilation.cpp[ 46%] Linking CXX executable ..\bin\listdirtest.exe[ 46%] Built target listdirtestScanning dependencies of target globaltest[ 46%] Building CXX object autotests/CMakeFiles/globaltest.dir/globaltest.cpp.obj[ 46%] Building CXX object autotests/CMakeFiles/globaltest.dir/globaltest_autogen/mocs_compilation.cpp.objglobaltest.cppmocs_compilation.cpp[ 46%] Linking CXX executable ..\bin\globaltest.exe[ 46%] Built target globaltestScanning dependencies of target jobremotetest[ 46%] Building CXX object autotests/CMakeFiles/jobremotetest.dir/jobremotetest.cpp.obj[ 46%] Building CXX object autotests/CMakeFiles/jobremotetest.dir/jobremotetest_autogen/mocs_compilation.cpp.objjobremotetest.cppmocs_compilation.cpp[ 46%] Linking CXX executable ..\bin\jobremotetest.exe[ 46%] Built target jobremotetestScanning dependencies of target upurltest[ 47%] Building CXX object autotests/CMakeFiles/upurltest.dir/upurltest.cpp.obj[ 47%] Building CXX object autotests/CMakeFiles/upurltest.dir/upurltest_autogen/mocs_compilation.cpp.objupurltest.cppmocs_compilation.cpp[ 47%] Linking CXX executable ..\bin\upurltest.exe[ 47%] Built target upurltestScanning dependencies of target dataprotocoltest[ 47%] Building CXX object autotests/CMakeFiles/dataprotocoltest.dir/dataprotocoltest.cpp.obj[ 47%] Building CXX object autotests/CMakeFiles/dataprotocoltest.dir/dataprotocoltest_autogen/mocs_compilation.cpp.objdataprotocoltest.cppmocs_compilation.cpp[ 47%] Linking CXX executable ..\bin\dataprotocoltest.exe[ 47%] Built target dataprotocoltestScanning dependencies of target udsentry_benchmark[ 47%] Building CXX object autotests/CMakeFiles/udsentry_benchmark.dir/udsentry_benchmark.cpp.obj[ 47%] Building CXX object autotests/CMakeFiles/udsentry_benchmark.dir/udsentry_benchmark_autogen/mocs_compilation.cpp.objudsentry_benchmark.cppmocs_compilation.cpp[ 47%] Linking CXX executable ..\bin\udsentry_benchmark.exe[ 47%] Built target udsentry_benchmarkScanning dependencies of target jobtest[ 47%] Building CXX object autotests/CMakeFiles/jobtest.dir/jobtest.cpp.obj[ 47%] Building CXX object autotests/CMakeFiles/jobtest.dir/jobtest_autogen/mocs_compilation.cpp.objjobtest.cppmocs_compilation.cpp[ 47%] Linking CXX executable ..\bin\jobtest.exe[ 47%] Built target jobtestScanning dependencies of target kprotocolinfotest[ 47%] Building CXX object autotests/CMakeFiles/kprotocolinfotest.dir/kprotocolinfotest.cpp.obj[ 47%] Building CXX object autotests/CMakeFiles/kprotocolinfotest.dir/kprotocolinfotest_autogen/mocs_compilation.cpp.objkprotocolinfotest.cppmocs_compilation.cpp[ 47%] Linking CXX executable ..\bin\kprotocolinfotest.exe[ 47%] Built target kprotocolinfotestScanning dependencies of target ktcpsockettest[ 47%] Building CXX object autotests/CMakeFiles/ktcpsockettest.dir/ktcpsockettest.cpp.obj[ 47%] Building CXX object autotests/CMakeFiles/ktcpsockettest.dir/ktcpsockettest_autogen/mocs_compilation.cpp.objktcpsockettest.cppmocs_compilation.cpp[ 47%] Linking CXX executable ..\bin\ktcpsockettest.exe[ 47%] Built target ktcpsockettestScanning dependencies of target mkpathjobtest[ 47%] Building CXX object autotests/CMakeFiles/mkpathjobtest.dir/mkpathjobtest.cpp.obj[ 47%] Building CXX object autotests/CMakeFiles/mkpathjobtest.dir/mkpathjobtest_autogen/mocs_compilation.cpp.objmkpathjobtest.cppmocs_compilation.cpp[ 48%] Linking CXX executable ..\bin\mkpathjobtest.exe[ 48%] Built target mkpathjobtestScanning dependencies of target threadtest[ 48%] Building CXX object autotests/CMakeFiles/threadtest.dir/threadtest.cpp.obj[ 48%] Building CXX object autotests/CMakeFiles/threadtest.dir/threadtest_autogen/mocs_compilation.cpp.objthreadtest.cppmocs_compilation.cppC:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9\autotests\threadtest.cpp(53): warning C4551: function call missing argument list[ 48%] Linking CXX executable ..\bin\threadtest.exeScanning dependencies of target udsentrytest[ 48%] Building CXX object autotests/CMakeFiles/udsentrytest.dir/udsentrytest.cpp.obj[ 48%] Building CXX object autotests/CMakeFiles/udsentrytest.dir/udsentrytest_autogen/mocs_compilation.cpp.objudsentrytest.cppmocs_compilation.cppC:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9\autotests\udsentrytest.cpp(241): error C3861: 'QT_LSTAT': identifier not foundjom: C:\CI\workspace\Frameworks kio kf5-qt5 

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 121 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/121/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 19 Feb 2018 04:00:34 +
 Build duration:
31 min and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiofilewidgets-kfileplacesviewtestFailed: TestSuite.kiofilewidgets-kfilewidgettestFailed: TestSuite.kiowidgets-kdirmodeltest

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 141 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/141/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 19 Feb 2018 04:00:34 +
 Build duration:
25 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(295/443)67%
(295/443)53%
(31533/59566)38%
(18516/48842)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8565/9113)48%
(5229/10793)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8350/14337)50%
(4872/9704)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(30/38)79%
(30/38)49%
(3873/7837)33%
(1637/4928)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(511/974)41%
(412/996)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 139 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/139/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.7
 Date of build:
Mon, 19 Feb 2018 04:00:34 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(295/443)67%
(295/443)53%
(31513/59565)38%
(18503/48918)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8565/9113)48%
(5232/10793)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8347/14337)50%
(4873/9708)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(30/38)79%
(30/38)49%
(3871/7837)33%
(1635/4928)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(511/974)41%
(412/996)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%

D8958: Fix unintentional breadcrumb menu item activation

[Алексей Шилин]

aleksejshilin added a comment.


  In D8958#209050 , @dfaure wrote:
  
  > Instead of the bool member, isn't it enough to test the distance again in 
mouseReleaseEvent? AFAIK that's how most widget do it. It also leads to one 
difference of behaviour in case someone moves the mouse a bit and then back to 
the original position, in that case the mouseReleaseEvent considers that no 
move happened (not sure if that's what you want here).
  
  
  If user moved the mouse considerably, then it's assumed to be intentional, 
and the subsequent release event shouldn't be ignored even if the final 
position is the same as the initial one. This way it is consistent with 
drag'n'drop behavior.
  
  Besides, only the first mouse release event should be ignored, so a flag is 
needed anyway.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8958

To: aleksejshilin, #frameworks, dfaure
Cc: broulik, ngraham, michaelh

D10279: add 24px media-album-cover icon

[Nathaniel Graham]

ngraham added a comment.


  You're not doing anything wrong, we're just being a bit slow to respond, and 
I'm sorry for that. I'll see if I can rustle up some reviewers.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10279

To: astippich, #breeze, #vdg, andreaska
Cc: ngraham, #frameworks, michaelh

D10635: Bug 383764: remove last file being copied/moved when the action was canceled or when the disk was full

[Nathaniel Graham]

ngraham added a comment.


  Fixing now.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10635

To: meven, dfaure
Cc: ltoscano, ngraham, #frameworks, michaelh

D10635: Bug 383764: remove last file being copied/moved when the action was canceled or when the disk was full

[Luigi Toscano]

ltoscano added a comment.


  In D10635#209216 , @ngraham wrote:
  
  > I like to use the full string since not all of our users or people browsing 
the bug tracker will be familiar enough with all our products and their 
versioning conventions to able to map a version number to its product. Is there 
a technical reason why the field should only have the version number instead of 
the full string?
  
  
  And they should not need to track the product: the version is per component. 
  So please fix this page 
https://community.kde.org/Guidelines_and_HOWTOs/Write_a_version_string (or I 
can do it) to describe the current status and ask for feedback if you want to 
change it without deciding for everyone. According the current usage, only the 
version number is used and needed, with the exception sometimes of applications 
part of KDE Applications, where some authors decide to use "x.y.z (KDE 
Applications some.thin.g)".
  In general using the version number only does not require looking for the 
version of the product.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10635

To: meven, dfaure
Cc: ltoscano, ngraham, #frameworks, michaelh

D10635: Bug 383764: remove last file being copied/moved when the action was canceled or when the disk was full

[Nathaniel Graham]

ngraham added a comment.


  I like to use the full string since not all of our users or people browsing 
the bug tracker will be familiar enough with all our products and their 
versioning conventions to able to map a version number to its product. Is there 
a technical reason why the field should only have the version number instead of 
the full string?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10635

To: meven, dfaure
Cc: ltoscano, ngraham, #frameworks, michaelh

D10635: Bug 383764: remove last file being copied/moved when the action was canceled or when the disk was full

[Luigi Toscano]

ltoscano added a comment.


  FIXED-IN: 5.44
  is enough. Not sure why the rules about the versioning changed.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10635

To: meven, dfaure
Cc: ltoscano, ngraham, #frameworks, michaelh

D10635: Bug 383764: remove last file being copied/moved when the action was canceled or when the disk was full

[Nathaniel Graham]

ngraham added a comment.


  Thanks for the patch! For formatting guidelines, please see 
https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch
  
  In essence, put "BUG: 383764" on its own line in the Summary section, and 
remove it from the title.
  
  Also please put "FIXED-IN: KDE Frameworks 5.44" on its own line, since that's 
the version of KDE Frameworks that this will make it into.
  
  One comment about the code, indicated below. Works great in testing, and I'm 
excited to get this in.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10635

To: meven, dfaure
Cc: ngraham, #frameworks, michaelh

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 140 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/140/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 18 Feb 2018 21:56:18 +
 Build duration:
28 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(295/443)67%
(295/443)53%
(31499/59565)38%
(18500/48842)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8565/9113)48%
(5227/10793)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8327/14336)50%
(4860/9704)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(30/38)79%
(30/38)49%
(3871/7837)33%
(1635/4928)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)53%
(512/974)41%
(413/996)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1783/4338)35%
(1375/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.9 - Build # 196 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.9/196/
 Project:
Frameworks kio kf5-qt5 WindowsMSVCQt5.9
 Date of build:
Sun, 18 Feb 2018 21:56:18 +
 Build duration:
14 min and counting
   CONSOLE OUTPUT
  [...truncated 579.37 KB...][ 46%] Linking CXX executable ..\bin\kmountpointtest.exe[ 46%] Built target kmountpointtestScanning dependencies of target listdirtest[ 46%] Building CXX object autotests/CMakeFiles/listdirtest.dir/listdirtest.cpp.obj[ 46%] Building CXX object autotests/CMakeFiles/listdirtest.dir/listdirtest_autogen/mocs_compilation.cpp.objlistdirtest.cppmocs_compilation.cpp[ 46%] Linking CXX executable ..\bin\listdirtest.exe[ 46%] Built target listdirtestScanning dependencies of target globaltest[ 46%] Building CXX object autotests/CMakeFiles/globaltest.dir/globaltest.cpp.objglobaltest.cppmocs_compilation.cpp[ 46%] Linking CXX executable ..\bin\globaltest.exe[ 46%] Built target globaltestScanning dependencies of target jobremotetest[ 46%] Building CXX object autotests/CMakeFiles/jobremotetest.dir/jobremotetest.cpp.obj[ 46%] Building CXX object autotests/CMakeFiles/jobremotetest.dir/jobremotetest_autogen/mocs_compilation.cpp.objjobremotetest.cppmocs_compilation.cpp[ 46%] Linking CXX executable ..\bin\jobremotetest.exe[ 46%] Built target jobremotetestScanning dependencies of target upurltest[ 46%] Building CXX object autotests/CMakeFiles/upurltest.dir/upurltest.cpp.obj[ 47%] Building CXX object autotests/CMakeFiles/upurltest.dir/upurltest_autogen/mocs_compilation.cpp.objupurltest.cppmocs_compilation.cpp[ 47%] Linking CXX executable ..\bin\upurltest.exe[ 47%] Built target upurltestScanning dependencies of target dataprotocoltest[ 47%] Building CXX object autotests/CMakeFiles/dataprotocoltest.dir/dataprotocoltest_autogen/mocs_compilation.cpp.obj[ 47%] Building CXX object autotests/CMakeFiles/dataprotocoltest.dir/dataprotocoltest.cpp.objdataprotocoltest.cppmocs_compilation.cpp[ 47%] Linking CXX executable ..\bin\dataprotocoltest.exe[ 47%] Built target dataprotocoltestScanning dependencies of target udsentry_benchmark[ 47%] Building CXX object autotests/CMakeFiles/udsentry_benchmark.dir/udsentry_benchmark.cpp.obj[ 47%] Building CXX object autotests/CMakeFiles/udsentry_benchmark.dir/udsentry_benchmark_autogen/mocs_compilation.cpp.objudsentry_benchmark.cppmocs_compilation.cpp[ 47%] Linking CXX executable ..\bin\udsentry_benchmark.exe[ 47%] Built target udsentry_benchmarkScanning dependencies of target jobtest[ 47%] Building CXX object autotests/CMakeFiles/jobtest.dir/jobtest.cpp.obj[ 47%] Building CXX object autotests/CMakeFiles/jobtest.dir/jobtest_autogen/mocs_compilation.cpp.objjobtest.cppmocs_compilation.cpp[ 47%] Linking CXX executable ..\bin\jobtest.exe[ 47%] Built target jobtestScanning dependencies of target kprotocolinfotest[ 47%] Building CXX object autotests/CMakeFiles/kprotocolinfotest.dir/kprotocolinfotest.cpp.obj[ 47%] Building CXX object autotests/CMakeFiles/kprotocolinfotest.dir/kprotocolinfotest_autogen/mocs_compilation.cpp.objkprotocolinfotest.cppmocs_compilation.cpp[ 47%] Linking CXX executable ..\bin\kprotocolinfotest.exe[ 47%] Built target kprotocolinfotestScanning dependencies of target ktcpsockettest[ 47%] Building CXX object autotests/CMakeFiles/ktcpsockettest.dir/ktcpsockettest.cpp.obj[ 47%] Building CXX object autotests/CMakeFiles/ktcpsockettest.dir/ktcpsockettest_autogen/mocs_compilation.cpp.objktcpsockettest.cppmocs_compilation.cpp[ 47%] Linking CXX executable ..\bin\ktcpsockettest.exe[ 47%] Built target ktcpsockettestScanning dependencies of target mkpathjobtest[ 47%] Building CXX object autotests/CMakeFiles/mkpathjobtest.dir/mkpathjobtest_autogen/mocs_compilation.cpp.obj[ 47%] Building CXX object autotests/CMakeFiles/mkpathjobtest.dir/mkpathjobtest.cpp.objmkpathjobtest.cppmocs_compilation.cpp[ 48%] Linking CXX executable ..\bin\mkpathjobtest.exe[ 48%] Built target mkpathjobtestScanning dependencies of target threadtest[ 48%] Building CXX object autotests/CMakeFiles/threadtest.dir/threadtest.cpp.obj[ 48%] Building CXX object autotests/CMakeFiles/threadtest.dir/threadtest_autogen/mocs_compilation.cpp.objthreadtest.cppmocs_compilation.cppC:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9\autotests\threadtest.cpp(53): warning C4551: function call missing argument list[ 48%] Linking CXX executable ..\bin\threadtest.exe[ 48%] Built target threadtestScanning dependencies of target udsentrytest[ 48%] Building CXX object autotests/CMakeFiles/udsentrytest.dir/udsentrytest.cpp.obj[ 48%] Building CXX object autotests/CMakeFiles/udsentrytest.dir/udsentrytest_autogen/mocs_compilation.cpp.objudsentrytest.cppmocs_compilation.cppC:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9\autotests\udsentrytest.cpp(241): error C3861: 'QT_LSTAT': identifier not foundjom: C:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.9\build\autotests\CMakeFiles\udsentrytest.dir\build.make 

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.7 - Build # 138 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.7/138/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.7
 Date of build:
Sun, 18 Feb 2018 21:56:18 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)67%
(295/443)67%
(295/443)53%
(31517/59564)38%
(18505/48918)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)94%
(8565/9113)48%
(5228/10793)autotests.http100%
(9/9)100%
(9/9)100%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)100%
(5/5)75%
(3/4)src.core84%
(101/120)84%
(101/120)58%
(8346/14337)50%
(4873/9708)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets79%
(30/38)79%
(30/38)49%
(3871/7837)33%
(1635/4928)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(511/974)41%
(412/996)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/104)0%
(0/75)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1788/4338)35%
(1373/3979)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash67%
(8/12)67%

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 120 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/120/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Sun, 18 Feb 2018 21:56:18 +
 Build duration:
6 min 4 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 55 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiowidgets-kdirmodeltest

D10616: Add Ctrl+H to the list of shortcuts for "show/hide hidden files"

[Nathaniel Graham]

ngraham closed this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10616

To: ngraham, #frameworks, #dolphin, elvisangelaccio, markg
Cc: markg, michaelh

D10646: Support case-insensitive WordDetect

[jonathan poelen]

jpoelen created this revision.
jpoelen added a reviewer: dhaumann.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
jpoelen requested review of this revision.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  word_insensitive

REVISION DETAIL
  https://phabricator.kde.org/D10646

AFFECTED FILES
  autotests/folding/highlight.cmake.fold
  src/lib/rule.cpp
  src/lib/rule_p.h

To: jpoelen, dhaumann
Cc: dhaumann, #frameworks, michaelh

D10433: Add QML support for Prison

[Sune Vuorela]

svuorela added a comment.


  I am a bit unsure if this is the right approach. I can still be convinced 
both ways.
  
  one of the big differences from prison/qt4 to prison/qt5 was that it changed 
from being a barcode display library to a barcode generation library, removing 
all means of actually displaying them.
  
  I don't know if a better approach would be to still not actually display 
anything, but do a bit more to make it possible to just use a AbstractBarcode 
in a QImageItem.
  
  I am also not sure how a custom AbstractBarcode could be fitted in here, and 
if it is actually relevant to care for a thirdparty AbstractBarcode 
implementation.
  
  This is a bit of rambling, but I'm not fully sure what way to sway. The code 
as such is good, but I'd like to just bounce these questions around first.

REPOSITORY
  R280 Prison

REVISION DETAIL
  https://phabricator.kde.org/D10433

To: vkrause, #frameworks, svuorela
Cc: broulik, davidedmundson, michaelh

D8958: Fix unintentional breadcrumb menu item activation

[David Faure]

dfaure added a comment.


  Instead of the bool member, isn't it enough to test the distance again in 
mouseReleaseEvent? AFAIK that's how most widget do it. It also leads to one 
difference of behaviour in case someone moves the mouse a bit and then back to 
the original position, in that case the mouseReleaseEvent considers that no 
move happened (not sure if that's what you want here).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8958

To: aleksejshilin, #frameworks, dfaure
Cc: broulik, ngraham, michaelh

D10450: Generate a custom target in kcoreaddons_desktop_to_json

[Tobias C . Berner]

tcberner abandoned this revision.
tcberner added a comment.


  Works for me

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D10450

To: tcberner, #freebsd, mpyne, bshah, dfaure, rakuco
Cc: bcooksley, rikmills, rakuco, kfunk, adridg, kossebau, #frameworks, michaelh

D10635: Bug 383764: remove last file being copied/moved when the action was canceled or when the disk was full

[Elvis Angelaccio]

elvisangelaccio added a reviewer: dfaure.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10635

To: meven, dfaure
Cc: #frameworks, michaelh

D10450: Generate a custom target in kcoreaddons_desktop_to_json

[Raphael Kubo da Costa]

rakuco added a comment.


  I agree this can be abandoned -- whatever solution we agree upon should 
probably be done in plasma-desktop.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D10450

To: tcberner, #freebsd, mpyne, bshah, dfaure, rakuco
Cc: bcooksley, rikmills, rakuco, kfunk, adridg, kossebau, #frameworks, michaelh

D10567: Remove handling of privilege operation confirmation prompts from KIO::Job

[Chinmoy Ranjan Pradhan]

chinmoyr added a dependent revision: D10568: Handle privilege operation 
confirmation prompts in SlaveBase.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10567

To: chinmoyr, dfaure
Cc: fvogt, #frameworks, michaelh

D10568: Handle privilege operation confirmation prompts in SlaveBase

[Chinmoy Ranjan Pradhan]

chinmoyr edited the summary of this revision.
chinmoyr added a dependency: D10567: Remove handling of privilege operation 
confirmation prompts from KIO::Job.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10568

To: chinmoyr, dfaure
Cc: fvogt, #frameworks, michaelh

D10641: Revoke temporary authorization of KIO slave before sending it to klauncher

[Chinmoy Ranjan Pradhan]

chinmoyr edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10641

To: chinmoyr, dfaure
Cc: fvogt, #frameworks, michaelh

D10437: Revoke authorization of file ioslave before it is used by another process

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 27483.
chinmoyr retitled this revision from "Limit the use of file.so for privilege 
operation to one application" to "Revoke authorization of file ioslave before 
it is used by another process".
chinmoyr edited the summary of this revision.
chinmoyr edited the test plan for this revision.
chinmoyr added a dependency: D10641: Revoke temporary authorization of KIO 
slave before sending it to klauncher.
chinmoyr added a comment.


  Updated test plan

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10437?vs=27482=27483

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10437

AFFECTED FILES
  src/ioslaves/file/file_unix.cpp

To: chinmoyr, #frameworks, dfaure, fvogt
Cc: markg, anthonyfieroni, michaelh

D10437: Limit the use of file.so for privilege operation to one application

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 27482.
chinmoyr added a comment.


  Changed approach. Now temporary authorization is revoked.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10437?vs=26905=27482

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10437

AFFECTED FILES
  src/ioslaves/file/file_unix.cpp

To: chinmoyr, #frameworks, dfaure, fvogt
Cc: markg, anthonyfieroni, michaelh

D10641: Revoke temporary authorization of KIO slave before sending it to klauncher

[Chinmoy Ranjan Pradhan]

chinmoyr added a dependent revision: D10437: Revoke authorization of file 
ioslave before it is used by another process.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10641

To: chinmoyr, dfaure
Cc: fvogt, #frameworks, michaelh

D10638: [KAuth] Implement revokeTemporaryAuthorization in Polkit1Backend

[Chinmoy Ranjan Pradhan]

chinmoyr added a dependent revision: D10641: Revoke temporary authorization of 
KIO slave before sending it to klauncher.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D10638

To: chinmoyr, #frameworks
Cc: michaelh

D10641: Revoke temporary authorization of KIO slave before sending it to klauncher

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
chinmoyr added a reviewer: dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
chinmoyr requested review of this revision.

REVISION SUMMARY
  An idle slave authorized for privilege operation can be easily misused.
  This patch changes SlaveBase to revoke temporary authorization(s) of the 
slave before
  sending it to klauncher.
  
  Depends on D10568  and D10638 


TEST PLAN
  1.An over-simplified version of how the slave is sent to klauncher:
  2.SlaveBase calls `connectSlave(d->poolSocket)`
  3.This in turn emits `newConnection`
  4.In klauncher this signal connects to `acceptSlave` which creates a new 
IdleSlave.
  5.Then `mConnectionServer` gets the connection backend of the Slave and sets 
it as the connection backed in IdleSlave.
  6.IdleSlave then sends CMD_SLAVE_STATUS command and gets Slave's details. 
(pid, protocol etc)
  7.kaluncher then stores this IdleSlave.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10641

AFFECTED FILES
  src/core/CMakeLists.txt
  src/core/slavebase.cpp
  src/core/slavebase.h

To: chinmoyr, dfaure
Cc: fvogt, #frameworks, michaelh

D10568: Handle privilege operation confirmation prompts in SlaveBase

[Chinmoy Ranjan Pradhan]

chinmoyr added a dependent revision: D10641: Revoke temporary authorization of 
KIO slave before sending it to klauncher.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10568

To: chinmoyr, dfaure
Cc: fvogt, #frameworks, michaelh

D10627: Reduce plasma lock up time to almost nothing

[Kai Uwe Broulik]

broulik added a comment.


  It's lookup, not lockup

REPOSITORY
  R120 Plasma Workspace

BRANCH
  polling (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10627

To: jtamate, #frameworks, #plasma, davidedmundson
Cc: broulik, davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10629: Avoid a double emitResult()

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  A quick search through plasma codebase reveals that `setResult` followed by 
`emitResult` is done quite often. Care to fix these, too? :)

REPOSITORY
  R120 Plasma Workspace

BRANCH
  double_finish (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10629

To: jtamate, #frameworks, #plasma, broulik
Cc: broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10433: Add QML support for Prison

[Volker Krause]

vkrause added a comment.


  ping? :)

REPOSITORY
  R280 Prison

REVISION DETAIL
  https://phabricator.kde.org/D10433

To: vkrause, #frameworks, svuorela
Cc: broulik, davidedmundson, michaelh

D10567: Remove handling of privilege operation confirmation prompts from KIO::Job

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 27478.
chinmoyr added a comment.


  removed m_data

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10567?vs=27315=27478

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10567

AFFECTED FILES
  src/core/job.cpp
  src/core/job_p.h
  src/core/simplejob.cpp
  src/core/slavebase.cpp

To: chinmoyr, dfaure
Cc: fvogt, #frameworks, michaelh

D10636: Add support for revoking temporary authorization in KAuth

[Chinmoy Ranjan Pradhan]

chinmoyr added a dependent revision: D10638: [KAuth] Implement 
revokeTemporaryAuthorization in Polkit1Backend.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D10636

To: chinmoyr, #frameworks
Cc: fvogt, dfaure, michaelh

D10638: [KAuth] Implement revokeTemporaryAuthorization in Polkit1Backend

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
chinmoyr added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
chinmoyr requested review of this revision.

REVISION SUMMARY
  Same as title.
  
  Depends on D10636 

REPOSITORY
  R283 KAuth

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10638

AFFECTED FILES
  src/backends/polkit-1/Polkit1Backend.cpp
  src/backends/polkit-1/Polkit1Backend.h

To: chinmoyr, #frameworks
Cc: michaelh

D10636: Add support for revoking temporary authorization in KAuth

[Chinmoy Ranjan Pradhan]

chinmoyr edited the summary of this revision.

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D10636

To: chinmoyr, #frameworks
Cc: fvogt, dfaure, michaelh

D10636: Add support for revoking temporary authorization in KAuth

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
chinmoyr added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
chinmoyr requested review of this revision.

REVISION SUMMARY
  Revoking authorization for a KAuth::Action is required to fix one security 
issue in KIO's file ioslave.

TEST PLAN
  All unit tests pass.

REPOSITORY
  R283 KAuth

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10636

AFFECTED FILES
  autotests/SetupActionTest.cpp
  autotests/TestBackend.cpp
  autotests/TestBackend.h
  src/AuthBackend.cpp
  src/AuthBackend.h
  src/kauthaction.cpp
  src/kauthaction.h

To: chinmoyr, #frameworks
Cc: fvogt, dfaure, michaelh

D10635: Bug 383764: remove last file being copied/moved when the action was canceled or when the disk was full

[Méven Car]

meven created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
meven requested review of this revision.

REVISION SUMMARY
  Add a DeleteJob for the last file that was being copied/moved when pasting or 
dropping a file when the copyjob failed because of a user cancelation or 
because the destination disk was full.

TEST PLAN
  Copy using paste action a file and cancel the action before it finishes, the 
destination file should be removed
Same operation using a drop "copy" action

REPOSITORY
  R241 KIO

BRANCH
  bug-383764-clean-up-incomplete-files-after-cancelation (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10635

AFFECTED FILES
  src/core/copyjob.cpp
  src/core/copyjob.h
  src/widgets/dropjob.cpp
  src/widgets/pastejob.cpp

To: meven
Cc: #frameworks, michaelh

D10625: Fix readelf command name on x86

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:ca65aab3a12b: Fix readelf command name on x86 (authored 
by vkrause).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10625?vs=27448=27471

REVISION DETAIL
  https://phabricator.kde.org/D10625

AFFECTED FILES
  toolchain/deployment-file.json.in

To: vkrause, #build_system, apol
Cc: #frameworks, michaelh

D10602: Remove obsolete policy settings

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:e0f78079800c: Remove obsolete policy settings (authored 
by vkrause).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10602?vs=27399=27470

REVISION DETAIL
  https://phabricator.kde.org/D10602

AFFECTED FILES
  toolchain/Android.cmake

To: vkrause, #build_system, apol
Cc: #frameworks, michaelh

D10601: Extend search path for NDK dependencies

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:37c2eba28855: Extend search path for NDK dependencies 
(authored by vkrause).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10601?vs=27398=27469

REVISION DETAIL
  https://phabricator.kde.org/D10601

AFFECTED FILES
  toolchain/Android.cmake

To: vkrause, #build_system, apol
Cc: #frameworks, michaelh

Re: proposal to extend and to improve KColorSchemeManager

[Aleix Pol]

On Sun, Feb 18, 2018 at 2:56 PM, Alexander Semke  wrote:
> Hi,
>
> I recently switched from using Digikam's code for the handling of color
> schemes in the application to KColorSchemeManager in LabPlot [1].
> It works, but there're couple of things that I miss:
>
> * "Default"-entry in the color scheme menu to easily switch to the default
> desktop color scheme
> * save the settings for the selected color scheme and load the proper scheme
> on start
> * automatically set the corresponding action in the scheme menu checked for
> the used color scheme on start
> * include couple of "kf5 default" color scheme definition files as part of
> KF5 so the application don't need to provide them on their own
> * standard name and icon used for the color scheme menu title
> * main menu bar and QMdiArea don't get updated on color scheme changes. For
> QMdiArea I added a "hack" in LabPlot now [1], the problem with the menu bar
> still remains.
>
> At the moment it looks to me like different applications (digikam, kdevelop,
> krita, labplot, kstars, etc.) take care of these points on their own or
> don't handle them at all.
> It would be great to provide this kind of functionality in a central place.
> This would also help to provide a common behavior for all KF5-based
> applications.
>
> Any thoughts on this?

It all sounds like there's bugs that needs fixing to me. It's much
better than adding work-arounds in your applications.

Patches welcome! :)
Aleix

On Sun, Feb 18, 2018 at 2:56 PM, Alexander Semke  wrote:
> Hi,
>
> I recently switched from using Digikam's code for the handling of color
> schemes in the application to KColorSchemeManager in LabPlot [1].
> It works, but there're couple of things that I miss:
>
> * "Default"-entry in the color scheme menu to easily switch to the default
> desktop color scheme
> * save the settings for the selected color scheme and load the proper scheme
> on start
> * automatically set the corresponding action in the scheme menu checked for
> the used color scheme on start
> * include couple of "kf5 default" color scheme definition files as part of
> KF5 so the application don't need to provide them on their own
> * standard name and icon used for the color scheme menu title
> * main menu bar and QMdiArea don't get updated on color scheme changes. For
> QMdiArea I added a "hack" in LabPlot now [1], the problem with the menu bar
> still remains.
>
> At the moment it looks to me like different applications (digikam, kdevelop,
> krita, labplot, kstars, etc.) take care of these points on their own or
> don't handle them at all.
> It would be great to provide this kind of functionality in a central place.
> This would also help to provide a common behavior for all KF5-based
> applications.
>
> Any thoughts on this?
>
>
> Regards,
> Alexander
>
> [1]
> https://cgit.kde.org/labplot.git/commit/?id=c609edcb6255242ea25ad81ff6601061edcbe57f

D10601: Extend search path for NDK dependencies

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10601

To: vkrause, #build_system, apol
Cc: #frameworks, michaelh

D10602: Remove obsolete policy settings

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10602

To: vkrause, #build_system, apol
Cc: #frameworks, michaelh

D10625: Fix readelf command name on x86

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10625

To: vkrause, #build_system, apol
Cc: #frameworks, michaelh

proposal to extend and to improve KColorSchemeManager

[Alexander Semke]

Hi,

I recently switched from using Digikam's code for the handling of color 
schemes in the application to KColorSchemeManager in LabPlot [1].

It works, but there're couple of things that I miss:

* "Default"-entry in the color scheme menu to easily switch to the 
default desktop color scheme
* save the settings for the selected color scheme and load the proper 
scheme on start
* automatically set the corresponding action in the scheme menu checked 
for the used color scheme on start
* include couple of "kf5 default" color scheme definition files as part 
of KF5 so the application don't need to provide them on their own

* standard name and icon used for the color scheme menu title
* main menu bar and QMdiArea don't get updated on color scheme changes. 
For QMdiArea I added a "hack" in LabPlot now [1], the problem with the 
menu bar still remains.


At the moment it looks to me like different applications (digikam, 
kdevelop, krita, labplot, kstars, etc.) take care of these points on 
their own or don't handle them at all.
It would be great to provide this kind of functionality in a central 
place. This would also help to provide a common behavior for all 
KF5-based applications.


Any thoughts on this?


Regards,
Alexander

[1] 
https://cgit.kde.org/labplot.git/commit/?id=c609edcb6255242ea25ad81ff6601061edcbe57f

D10414: Add move semantics support to KIO::UDSEntry.

[Mark Gaiser]

markg added a comment.


  In D10414#208515 , @bcooksley 
wrote:
  
  > Looks like QT_LSTAT doesn't exist on Windows - see 
https://git.reviewboard.kde.org/r/127727/
  
  
  Would including "kioglobal_p.h" perhaps fix this?
  
#ifndef QT_LSTAT
#define QT_LSTAT kio_windows_lstat
#endif
  
  It's a private header, but it's just for the unit tests. That would probably 
be fine.
  
  If someone could test that on a windows setup?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10414

To: markg, dfaure
Cc: bcooksley, apol, #frameworks, michaelh

D10617: Fix "ambiguous shortcut" issue introduced with D10314

[Mark Gaiser]

markg added a comment.


  In D10617#208703 , 
@elvisangelaccio wrote:
  
  > In D10617#208513 , @ngraham 
wrote:
  >
  > > The shortcut won't affect other apps since the file dialog its its own 
context. Even if the host app uses F12 for something, the file dialog will grab 
the key first, so there's no "ambiguous shortcut" issue.
  >
  >
  > Yes, you won't get the ambiguous shortcut dialog but it'd be a bad idea to 
use F12 for two different things within the same app (the file dialog //is// 
part of the app).
  
  
  If it were F11 (which it was) then this patch would be very intrusive as you 
could have potentially broken fullscreen support (with F11), but it isn't it's 
F12..
  Note that you can in fact see this "broken fullscreen". Open gwenview, open 
an image and press F11, then do CTRL+O to open the file open dialog. Now F11 
only has effect on that file open dialog.
  
  But for F12, i don't see anything wrong. As far as i'm aware it isn't bound 
to any really crucial actions (i would call fullscreen crucial aka F11).
  F12 in chrome opens the developer console.
  F12 in konsole prints the tilde sign (there is another dedicated key for 
that, right under escape)
  
  F12 seems fine to me. Yes, you'd get into the weird issue that F12 in the app 
might have a different behavior in a file open dialog opened by the very same 
app, but that is with every key you choose.
  As long as we are consistent in keys which i thing Nate is very much trying 
to do (good job!).
  
  Also, note that F11 in kwrite binds to something completely different (show 
line numbers).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10617

To: ngraham, #frameworks, #dolphin, markg, elvisangelaccio
Cc: michaelh

D10631: Update links to dependencies, and mark Android as officially supported

[Sune Vuorela]

svuorela accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R280 Prison

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10631

To: vkrause, svuorela
Cc: #frameworks, michaelh

D10603: Make DMTX dependency optional

[Sune Vuorela]

svuorela accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R280 Prison

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10603

To: vkrause, #frameworks, svuorela
Cc: michaelh

D10312: FileUndoManager: don't delete non-existing local files

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> dfaure wrote in fileundomanager.cpp:404
> Yep.

Ok, that's enough to fix the dolphin side, but now the new unit test doesn't 
pass...

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10312

To: elvisangelaccio, dfaure
Cc: ngraham, #frameworks, michaelh

D10631: Update links to dependencies, and mark Android as officially supported

[Volker Krause]

vkrause created this revision.
vkrause added a reviewer: svuorela.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
vkrause requested review of this revision.

REPOSITORY
  R280 Prison

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10631

AFFECTED FILES
  Mainpage.dox
  README.md
  cmake/FindDmtx.cmake
  cmake/FindQRencode.cmake
  metainfo.yaml

To: vkrause, svuorela
Cc: #frameworks, michaelh

D10603: Make DMTX dependency optional

[Volker Krause]

vkrause updated this revision to Diff 27458.
vkrause added a comment.


  Address review comments.

REPOSITORY
  R280 Prison

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10603?vs=27400=27458

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10603

AFFECTED FILES
  CMakeLists.txt
  src/lib/CMakeLists.txt
  src/lib/config-prison.h.in
  src/lib/prison.cpp

To: vkrause, #frameworks, svuorela
Cc: michaelh

D10617: Fix "ambiguous shortcut" issue introduced with D10314

[Elvis Angelaccio]

elvisangelaccio added a comment.


  In D10617#208513 , @ngraham wrote:
  
  > The shortcut won't affect other apps since the file dialog its its own 
context. Even if the host app uses F12 for something, the file dialog will grab 
the key first, so there's no "ambiguous shortcut" issue.
  
  
  Yes, you won't get the ambiguous shortcut dialog but it'd be a bad idea to 
use F12 for two different things within the same app (the file dialog //is// 
part of the app).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10617

To: ngraham, #frameworks, #dolphin, markg, elvisangelaccio
Cc: michaelh

D10629: Avoid a double emitResult()

[Jaime Torres Amate]

jtamate created this revision.
jtamate added reviewers: Frameworks, Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
jtamate requested review of this revision.

REVISION SUMMARY
  ServiceJob::setResult already does a emitResult.
  Discovered with the assert created in https://phabricator.kde.org/D9862

REPOSITORY
  R120 Plasma Workspace

BRANCH
  double_finish (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10629

AFFECTED FILES
  dataengines/notifications/notificationaction.cpp

To: jtamate, #frameworks, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10627: Reduce plasma lock up time to almost nothing

[Jaime Torres Amate]

jtamate added a comment.


  May I do the other 2 commits without another revision?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  polling (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10627

To: jtamate, #frameworks, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10627: Reduce plasma lock up time to almost nothing

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  This code already has a platform check before adding the native event filter.
  
  IMHO we could just make this an assert.
  
  But I like your approach too.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  polling (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10627

To: jtamate, #frameworks, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10627: Reduce plasma lock up time to almost nothing

[Jaime Torres Amate]

jtamate created this revision.
jtamate added reviewers: Frameworks, Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
jtamate requested review of this revision.

REVISION SUMMARY
  CCBUG: 358231
  CCBUG: 342056
  Even the icon with the number of tasks pending moves from time to time.
  
  To reduce the lock up time, a similar patch must be applied also to
  frameworks/kwindowsystem src/platforms/xcb/kxmessages.cpp
  frameworks/plasma-framework src/plasma/private/effectwatcher.cpp
  
  According to the documentation (and a look to the source code)
  http://doc.qt.io/qt-5/qabstractnativeeventfilter.html
  
  The type of event eventType is specific to the platform plugin chosen
  at run-time, and can be used to cast message to the right type.
  
  On X11, eventType is set to "xcb_generic_event_t", and the message can
  be casted to a xcb_generic_event_t pointer.
  
  The other eventType are "windows_generic_MSG" and "mac_generic_NSEvent".
  No other eventType starts with an 'x'.

TEST PLAN
  Cut & paste 2000 small files.
  Before, a lock up of minutes
  After, a lock up of seconds

REPOSITORY
  R120 Plasma Workspace

BRANCH
  polling (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10627

AFFECTED FILES
  shell/screenpool.cpp

To: jtamate, #frameworks, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10279: add 24px media-album-cover icon

[Alexander Stippich]

astippich added a comment.


  Hi, it would be nice to get some feedback on this. Same for D10293 
 and D10292 
.
  If this is not the proper way to contribute to breeze icons, please point me 
in the right direction.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10279

To: astippich, #breeze, #vdg, andreaska
Cc: ngraham, #frameworks, michaelh

D10603: Make DMTX dependency optional

[Sune Vuorela]

svuorela added a comment.


  Thanks. The ability to cleanly do something like that was one of the reasons 
for the api changes I did between qt4 and qt5.

INLINE COMMENTS

> prison.cpp:44
> +#ifdef HAVE_DMTX
>  case Prison::DataMatrix:
>  return new DataMatrixBarcode;

I'm wondering if it isn't better to have

  case Prison::DataMatrix:
  #ifdef HAVE_DTMX
  return new DataMatrixBarcode;
  #else
  return nullptr
  #endif

to avoid potentially having a unhandled enum value in switch warning.

REPOSITORY
  R280 Prison

REVISION DETAIL
  https://phabricator.kde.org/D10603

To: vkrause, #frameworks, svuorela
Cc: michaelh

D10625: Fix readelf command name on x86

[Volker Krause]

vkrause created this revision.
vkrause added a reviewer: Build System.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added a subscriber: Frameworks.
vkrause requested review of this revision.

REVISION SUMMARY
  The prefix for the command is i686-linux-android, while the toolchain is
  x86 in this case. On ARM both values are the same.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10625

AFFECTED FILES
  toolchain/deployment-file.json.in

To: vkrause, #build_system
Cc: #frameworks, michaelh

D9862: Don't create 2 msgbox (one of them crashes) when can't change rights.

[Jaime Torres Amate]

jtamate added a comment.


  #10 0x7ff925c93845 in KJob::finishJob(bool) (this=0x221d0d0, 
emitResult=true) at /g/5kde/frameworks/kcoreaddons/src/lib/jobs/kjob.cpp:101
  #11 0x7ff925c93f9b in KJob::emitResult() (this=0x221d0d0) at 
/g/5kde/frameworks/kcoreaddons/src/lib/jobs/kjob.cpp:300
  #12 0x7ff927683a05 in KIO::FileCopyJob::slotResult(KJob*) 
(this=0x221d0d0, job=0x2bf3b50) at 
/g/5kde/frameworks/kio/src/core/filecopyjob.cpp:573
  #13 0x7ff925c931a8 in QtPrivate::FunctorCall, 
QtPrivate::List, void, void (KCompositeJob::*)(KJob*)>::call(void 
(KCompositeJob::*)(KJob*), KCompositeJob*, void**) (f= 
KCompositeJob::slotResult(KJob*), o=0x221d0d0, arg=0x7ffed77d7280) at 
/usr/include/qt5/QtCore/qobjectdefs_impl.h:136
  #14 0x7ff925c92d9e in QtPrivate::FunctionPointer::call, void>(void 
(KCompositeJob::*)(KJob*), KCompositeJob*, void**) (f= 
KCompositeJob::slotResult(KJob*), o=0x221d0d0, arg=0x7ffed77d7280) at 
/usr/include/qt5/QtCore/qobjectdefs_impl.h:169
  #15 0x7ff925c929b7 in QtPrivate::QSlotObject, void>::impl(int, 
QtPrivate::QSlotObjectBase*, QObject*, void**, bool*) (which=1, 
this_=0x2b623d0, r=0x221d0d0, a=0x7ffed77d7280, ret=0x0) at 
/usr/include/qt5/QtCore/qobjectdefs_impl.h:398
  #16 0x7ff923d930cc in QMetaObject::activate(QObject*, int, int, void**) 
() at /usr/lib64/libQt5Core.so.5
  #17 0x7ff925c958dd in KJob::result(KJob*, KJob::QPrivateSignal) 
(this=0x2bf3b50, _t1=0x2bf3b50, _t2=...) at 
/virtual/kde5/5kde/build/frameworks/kcoreaddons/src/lib/KF5CoreAddons_autogen/include/moc_kjob.cpp:569
  #18 0x7ff925c938b5 in KJob::finishJob(bool) (this=0x2bf3b50, 
emitResult=true) at /g/5kde/frameworks/kcoreaddons/src/lib/jobs/kjob.cpp:116
  #19 0x7ff925c93f9b in KJob::emitResult() (this=0x2bf3b50) at 
/g/5kde/frameworks/kcoreaddons/src/lib/jobs/kjob.cpp:300
  #20 0x7ff92768c93e in KIO::SimpleJob::slotFinished() (this=0x2bf3b50) at 
/g/5kde/frameworks/kio/src/core/simplejob.cpp:232
  #21 0x7ff92768f23c in QtPrivate::FunctorCall, 
QtPrivate::List<>, void, void (KIO::SimpleJob::*)()>::call(void 
(KIO::SimpleJob::*)(), KIO::SimpleJob*, void**) (f= 
KIO::SimpleJob::slotFinished(), o=0x2bf3b50, arg=0x7ffed77d7530) at 
/usr/include/qt5/QtCore/qobjectdefs_impl.h:136
  #22 0x7ff92768f00c in QtPrivate::FunctionPointer::call, void>(void 
(KIO::SimpleJob::*)(), KIO::SimpleJob*, void**) (f= 
KIO::SimpleJob::slotFinished(), o=0x2bf3b50, arg=0x7ffed77d7530) at 
/usr/include/qt5/QtCore/qobjectdefs_impl.h:169
  #23 0x7ff92768eea7 in QtPrivate::QSlotObject, void>::impl(int, QtPrivate::QSlotObjectBase*, QObject*, 
void**, bool*) (which=1, this_=0x287bbd0, r=0x2bf3b50, a=0x7ffed77d7530, 
ret=0x0) at /usr/include/qt5/QtCore/qobjectdefs_impl.h:398
  #24 0x7ff923d930cc in QMetaObject::activate(QObject*, int, int, void**) 
() at /usr/lib64/libQt5Core.so.5
  #25 0x7ff92767163f in KIO::SlaveInterface::finished() (this=0x1ae9da0) at 
/g/5kde/build/frameworks/kio/src/core/KF5KIOCore_autogen/include/moc_slaveinterface.cpp:437
  #26 0x7ff92766f140 in KIO::SlaveInterface::dispatch(int, QByteArray 
const&) (this=0x1ae9da0, _cmd=104, rawdata=...) at 
/g/5kde/frameworks/kio/src/core/slaveinterface.cpp:160
  #27 0x7ff92766edbb in KIO::SlaveInterface::dispatch() (this=0x1ae9da0) at 
/g/5kde/frameworks/kio/src/core/slaveinterface.cpp:89
  #28 0x7ff927673598 in KIO::Slave::gotInput() (this=0x1ae9da0) at 
/g/5kde/frameworks/kio/src/core/slave.cpp:406
  #29 0x7ff927708675 in KIO::Slave::qt_static_metacall(QObject*, 
QMetaObject::Call, int, void**) (_o=0x1ae9da0, 
_c=QMetaObject::InvokeMetaMethod, _id=2, _a=0x7ffed77d78f0) at 
/g/5kde/build/frameworks/kio/src/core/KF5KIOCore_autogen/EWIEGA46WW/moc_slave.cpp:89
  #30 0x7ff923d92fca in QMetaObject::activate(QObject*, int, int, void**) 
() at /usr/lib64/libQt5Core.so.5
  #31 0x7ff927618e75 in KIO::Connection::readyRead() (this=0x1a6bfe0) at 
/g/5kde/build/frameworks/kio/src/core/KF5KIOCore_autogen/include/moc_connection_p.cpp:143
  #32 0x7ff927617c61 in KIO::ConnectionPrivate::dequeue() (this=0x1c817e0) 
at /g/5kde/frameworks/kio/src/core/connection.cpp:46
  #33 0x7ff927618c86 in KIO::Connection::qt_static_metacall(QObject*, 
QMetaObject::Call, int, void**) (_o=0x1a6bfe0, 
_c=QMetaObject::InvokeMetaMethod, _id=1, _a=0x7ff90c00cbe0) at 
/g/5kde/build/frameworks/kio/src/core/KF5KIOCore_autogen/include/moc_connection_p.cpp:87
  #34 0x7ff923d939b2 in QObject::event(QEvent*) () at 
/usr/lib64/libQt5Core.so.5
  #35 0x7ff9251bdf0c in QApplicationPrivate::notify_helper(QObject*, 
QEvent*) () at /usr/lib64/libQt5Widgets.so.5
  #36 0x7ff9251c5204 in QApplication::notify(QObject*, QEvent*) () at 
/usr/lib64/libQt5Widgets.so.5
  #37 0x7ff923d64ea8 in QCoreApplication::notifyInternal2(QObject*, 
QEvent*) () at /usr/lib64/libQt5Core.so.5
  #38 0x7ff923d67885 in 

D9862: Don't create 2 msgbox (one of them crashes) when can't change rights.

[Jaime Torres Amate]

jtamate updated this revision to Diff 27444.
jtamate added a comment.


  Now with an Q_ASSERT that really shows the origin of the problem.
  
  In the case of pressing the "skip All" button when can't change permissions 
is:

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9862?vs=27429=27444

BRANCH
  skip (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D9862

AFFECTED FILES
  src/lib/jobs/kjob.cpp

To: jtamate, #frameworks, dfaure
Cc: michaelh