D10851: autotests: Introduce aliases DocId, DeviceId and Inode

[Michael Heidelbach]

michaelh created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
michaelh requested review of this revision.

REVISION SUMMARY
  Find and replace `quint64` with `DocId`
  Add `#include "idutils.h"` until it compiles
  
  see: D10825 

TEST PLAN
  build

REPOSITORY
  R293 Baloo

BRANCH
  aliases-tests (branched from flexible-docid)

REVISION DETAIL
  https://phabricator.kde.org/D10851

AFFECTED FILES
  autotests/integration/dbstate.h
  autotests/integration/filesearchstoretest.cpp
  autotests/integration/querytest.cpp
  autotests/integration/writetransactiontest.cpp
  autotests/unit/codecs/postingcodectest.cpp
  autotests/unit/engine/andpostingiteratortest.cpp
  autotests/unit/engine/documentiddbtest.cpp
  autotests/unit/engine/documenturldbtest.cpp
  autotests/unit/engine/idtreedbtest.cpp
  autotests/unit/engine/mtimedbtest.cpp
  autotests/unit/engine/orpostingiteratortest.cpp
  autotests/unit/engine/phraseanditeratortest.cpp
  autotests/unit/engine/positiondbtest.cpp
  autotests/unit/engine/postingdbtest.cpp
  autotests/unit/engine/transactiontest.cpp
  autotests/unit/file/basicindexingqueuetest.cpp
  autotests/unit/file/metadatamovertest.cpp

To: michaelh
Cc: #frameworks, michaelh

D10124: Faster simplejob start

[Jaime Torres Amate]

jtamate added a comment.


  
  
  In D10124#213918 , @dfaure wrote:
  
  > This commit leads to
  >
  > 20:29:06.184 okteta(12932) QObject::connect|?libKF5KIOCore.so.5? 
QObject::connect: No such slot KIO::ListJob::slotTotalSize(KIO::filesize_t) in 
/d/kde/src/5/frameworks/kio/src/core/listjob.cpp:289
  >
  > Please fix ;)
  
  
  Please, take a look at: https://phabricator.kde.org/D10537

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10124

To: jtamate, #frameworks, mwolff, dfaure
Cc: mwolff, broulik, ngraham, anthonyfieroni, michaelh

CI & Binary Factory maintenance

[Ben Cooksley]

Hi all,

To permit extensive maintenance on the underlying nodes which support
the CI system & Binary Factory, I have temporarily disabled the
mechanism which triggers builds on the CI and have brought the Binary
Factory into a halted state.

During this time builds will not be triggered as they normally would.

Following the maintenance the system will need to perform a complete
rebuild of all Windows based projects, and will also need to catch up
on the builds it has missed. As such it may take up to 24-48 hours
before the system is fully functional again.

Regards,
Ben Cooksley
KDE Sysadmin

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 55 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/55/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 25 Feb 2018 02:19:38 +
 Build duration:
1 day 5 hr and counting
   CONSOLE OUTPUT
  [...truncated 81.99 KB...]-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Looking for __GLIBC__-- Looking for __GLIBC__ - found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Looking for pthread.h-- Looking for pthread.h - found-- Looking for pthread_create-- Looking for pthread_create - not found-- Looking for pthread_create in pthreads-- Looking for pthread_create in pthreads - not found-- Looking for pthread_create in pthread-- Looking for pthread_create in pthread - found-- Found Threads: TRUE  -- Could NOT find FAM (missing: FAM_INCLUDE_DIR FAM_LIBRARIES) -- Looking for include files sys/types.h, sys/mman.h-- Looking for include files sys/types.h, sys/mman.h - found-- Looking for getgrouplist-- Looking for getgrouplist - found-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success-- Performing Test COMPILER_HAS_DEPRECATED_ATTR-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success-- The sip executable must be available to use PythonModuleGeneration.-- Found SharedMimeInfo: /usr/bin/update-mime-database (found suitable version "1.9", minimum required is "1.3") -- Performing Test HAVE_QFILESYSTEMWATCHER-- Performing Test HAVE_QFILESYSTEMWATCHER - Success-- The following OPTIONAL packages have been found: * Threads * Inotify   Filesystem alteration notifications using inotify * SharedMimeInfo (required version >= 1.3), A database of common MIME types,Allows KDE applications to determine file types-- The following REQUIRED packages have been found: * ECM (required version >= 5.43.0), Extra CMake Modules.,  * Qt5Core * Qt5 (required version >= 5.7.0)-- The following features have been disabled: * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- The following OPTIONAL packages have not been found: * FAM, File alteration notification support via a separate service,Provides file alteration notification facilities using a separate service. FAM provides additional support for NFS. * PythonModuleGeneration-- Configuring done-- Generating done-- Build files have been written to: /home/jenkins/workspace/Frameworks kcoreaddons kf5-qt5 SUSEQt5.10/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[Frameworks kcoreaddons kf5-qt5 SUSEQt5.10] Running shell script+ python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kcoreaddons --branchGroup kf5-qt5 --platform SUSEQt5.10 --usingInstall /home/jenkins//install-prefix/Scanning dependencies of target KF5CoreAddons_autogenScanning dependencies of target desktoptojson_autogen[  1%] Automatic MOC for target KF5CoreAddons[  2%] Automatic MOC for target desktoptojson[  2%] Built target desktoptojson_autogenScanning dependencies of target ktexttohtmltest_autogen[  3%] Automatic MOC for target ktexttohtmltest[  3%] Built target ktexttohtmltest_autogenScanning dependencies of target desktoptojson[  4%] Building CXX object src/desktoptojson/CMakeFiles/desktoptojson.dir/main.cpp.o[  4%] Built target KF5CoreAddons_autogenScanning dependencies of target ktexttohtmltest[  4%] Building CXX object autotests/CMakeFiles/ktexttohtmltest.dir/ktexttohtmltest.cpp.o[  5%] Building CXX object autotests/CMakeFiles/ktexttohtmltest.dir/__/src/lib/text/ktexttohtml.cpp.o[  5%] Building CXX object autotests/CMakeFiles/ktexttohtmltest.dir/ktexttohtmltest_autogen/mocs_compilation.cpp.o[  6%] Linking CXX executable ../bin/ktexttohtmltest[  6%] Built target ktexttohtmltestCannot contact Docker Swarm-941f42b05f00: java.lang.InterruptedExceptionmake[2]: *** Deleting file 'src/desktoptojson/CMakeFiles/desktoptojson.dir/main.cpp.o'make[1]: *** [CMakeFiles/Makefile2:301: src/desktoptojson/CMakeFiles/desktoptojson.dir/all] Terminatedmake: *** [Makefile:141: all] Error 2[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] sh[Frameworks kcoreaddons kf5-qt5 SUSEQt5.10] Running shell script+ python3 -u ci-tooling/helpers/capture-workspace.py --environment production[Pipeline] emailextrecipients[Pipeline] emailext

D10825: Introduce aliases DocId, DeviceId and Inode

[Michael Heidelbach]

michaelh updated this revision to Diff 28088.
michaelh marked an inline comment as done.
michaelh edited the summary of this revision.
michaelh added a comment.


  - Merge branch 'flexible-docid' of git://anongit.kde.org/baloo into aliases
  - Correct indentation

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10825?vs=28001=28088

BRANCH
  aliases (branched from flexible-docid)

REVISION DETAIL
  https://phabricator.kde.org/D10825

AFFECTED FILES
  src/codecs/coding.h
  src/codecs/positioncodec.cpp
  src/codecs/postingcodec.cpp
  src/codecs/postingcodec.h
  src/engine/andpostingiterator.cpp
  src/engine/andpostingiterator.h
  src/engine/document.cpp
  src/engine/document.h
  src/engine/documentdatadb.cpp
  src/engine/documentdatadb.h
  src/engine/documentdb.cpp
  src/engine/documentdb.h
  src/engine/documentiddb.cpp
  src/engine/documentiddb.h
  src/engine/documenttimedb.cpp
  src/engine/documenttimedb.h
  src/engine/documenturldb.cpp
  src/engine/documenturldb.h
  src/engine/idfilenamedb.cpp
  src/engine/idfilenamedb.h
  src/engine/idtreedb.cpp
  src/engine/idtreedb.h
  src/engine/idutils.h
  src/engine/mtimedb.cpp
  src/engine/mtimedb.h
  src/engine/orpostingiterator.cpp
  src/engine/orpostingiterator.h
  src/engine/phraseanditerator.cpp
  src/engine/phraseanditerator.h
  src/engine/positiondb.cpp
  src/engine/positioninfo.h
  src/engine/postingdb.cpp
  src/engine/postingdb.h
  src/engine/postingiterator.cpp
  src/engine/postingiterator.h
  src/engine/transaction.cpp
  src/engine/transaction.h
  src/engine/vectorpositioninfoiterator.cpp
  src/engine/vectorpositioninfoiterator.h
  src/engine/vectorpostingiterator.cpp
  src/engine/vectorpostingiterator.h
  src/engine/writetransaction.cpp
  src/engine/writetransaction.h
  src/file/extractor/app.cpp
  src/file/extractor/app.h
  src/file/extractor/autotests/iohandlertest.cpp
  src/file/extractor/iohandler.cpp
  src/file/extractor/iohandler.h
  src/file/extractor/result.cpp
  src/file/extractor/result.h
  src/file/extractorprocess.cpp
  src/file/extractorprocess.h
  src/file/filecontentindexer.cpp
  src/file/filecontentindexerprovider.cpp
  src/file/filecontentindexerprovider.h
  src/file/indexcleaner.cpp
  src/file/metadatamover.cpp
  src/file/modifiedfileindexer.cpp
  src/file/unindexedfileindexer.cpp
  src/file/unindexedfileiterator.cpp
  src/lib/file.cpp
  src/lib/searchstore.cpp
  src/tools/balooctl/main.cpp
  src/tools/balooctl/statuscommand.cpp
  src/tools/balooshow/main.cpp

To: michaelh, adridg, #baloo, #frameworks
Cc: ngraham, alexeymin, ashaposhnikov, michaelh, spoorun, nicolasfella

D10825: Introduce aliases DocId, DeviceId and Inode

[Michael Heidelbach]

michaelh marked an inline comment as done.
michaelh added a comment.


  @alexeymin , @ngraham: I asked IRC:kdevelop how to turn `-Wstrict-aliasing` 
on and was pointed to cmake docs. If this setting is defined in one of the 
cmake-files, why do they differ? Could it be an internal setting of the IDE? 
I'm using KDevelop and there seems to be no option to switch that on.

INLINE COMMENTS

> ngraham wrote in idtreedb.cpp:76
> Unintentional indentation?

I wonder how that came about.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10825

To: michaelh, adridg, #baloo, #frameworks
Cc: ngraham, alexeymin, ashaposhnikov, michaelh, spoorun, nicolasfella

D10849: Add template for Plasma wallpaper with QML extension

[Friedrich W . H . Kossebau]

kossebau created this revision.
kossebau added a reviewer: mart.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
kossebau requested review of this revision.

REVISION SUMMARY
  Allows to quickly start a new wallpaper which also wants to use a custom QML
  extension.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  addtemplatewallpaperwithqmlext

REVISION DETAIL
  https://phabricator.kde.org/D10849

AFFECTED FILES
  templates/CMakeLists.txt
  templates/plasma-wallpaper-with-qml-extension/CMakeLists.txt
  templates/plasma-wallpaper-with-qml-extension/Messages.sh
  templates/plasma-wallpaper-with-qml-extension/README
  templates/plasma-wallpaper-with-qml-extension/package/contents/config/main.xml
  templates/plasma-wallpaper-with-qml-extension/package/contents/ui/config.qml
  templates/plasma-wallpaper-with-qml-extension/package/contents/ui/main.qml
  templates/plasma-wallpaper-with-qml-extension/package/metadata.desktop
  
templates/plasma-wallpaper-with-qml-extension/plasma-wallpaper-with-qml-extension.kdevtemplate
  templates/plasma-wallpaper-with-qml-extension/plugin/%{APPNAMELC}plugin.cpp
  templates/plasma-wallpaper-with-qml-extension/plugin/%{APPNAMELC}plugin.h
  templates/plasma-wallpaper-with-qml-extension/plugin/CMakeLists.txt
  templates/plasma-wallpaper-with-qml-extension/plugin/qmldir

To: kossebau, mart
Cc: #frameworks, michaelh

D10848: Templates: consistent naming, fix translation catalog names & more

[Friedrich W . H . Kossebau]

kossebau created this revision.
kossebau added a reviewer: mart.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
kossebau requested review of this revision.

REVISION SUMMARY
  - remove unneeded cmake includes
  - consistently use org.kde.plasma.* prefix for names
  - fix catalog names to match applet identifier
  - bump min cmake version to 3.0
  - remove duplicated X-KDE-PluginInfo-Name entries
  - remove no longer (Plasma >=5.8) needed i18nd in wallpaper code
  - prepare qml extension for ki18n usage

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  brushovertemplates

REVISION DETAIL
  https://phabricator.kde.org/D10848

AFFECTED FILES
  templates/cpp-plasmoid/CMakeLists.txt
  templates/cpp-plasmoid/Messages.sh
  templates/cpp-plasmoid/src/CMakeLists.txt
  templates/cpp-plasmoid/src/package/metadata.desktop
  templates/plasma-wallpaper/CMakeLists.txt
  templates/plasma-wallpaper/package/contents/ui/main.qml
  templates/qml-plasmoid-with-qml-extension/CMakeLists.txt
  templates/qml-plasmoid-with-qml-extension/Messages.sh
  templates/qml-plasmoid-with-qml-extension/package/metadata.desktop
  templates/qml-plasmoid-with-qml-extension/plugin/%{APPNAMELC}plugin.cpp
  templates/qml-plasmoid-with-qml-extension/plugin/CMakeLists.txt
  templates/qml-plasmoid/CMakeLists.txt
  templates/qml-plasmoid/Messages.sh
  templates/qml-plasmoid/package/metadata.desktop

To: kossebau, mart
Cc: #frameworks, michaelh

D10414: Add move semantics support to KIO::UDSEntry.

[Ben Cooksley]

bcooksley added a comment.


  Uploading a new diff is the right thing to do in this case, however that 
won't be truly representative of what was landed in the end unless this is 
first reverted.
  (Objective being the complete, updated diff being shown here)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10414

To: markg, dfaure
Cc: bcooksley, apol, #frameworks, michaelh

D10663: Remove a partially copied file if copyjob was cancelled in the middle of file copying

[Nathaniel Graham]

ngraham added a comment.


  In D10663#213898 , @dfaure wrote:
  
  > Better make it happen all the time, and better make it work right. A flag 
almost sounds like a excuse for a half-hearted feature ("if it works badly in 
case XYZ, then apps can just opt out"). I don't see why the app would care, 
really. It wants to copy A to B, and wants to know if it worked or not; details 
like cleaning up on cancel are best handled by the KIO library.
  
  
  +1

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10663

To: dmitrio, #frameworks, dfaure
Cc: ngraham, anthonyfieroni, meven, #frameworks, michaelh

D10757: Reset QLocale internals when we have a custom app language

[Aleix Pol Gonzalez]

apol added a comment.


  Go for it +1
  
  I'd still try to add the needed API in Qt though.

REPOSITORY
  R263 KXmlGui

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10757

To: aacid, apol, ilic
Cc: lueck, #frameworks, michaelh

D10825: Introduce aliases DocId, DeviceId and Inode

[Nathaniel Graham]

ngraham added a comment.


  Nice job, looks good. No compilation warnings for me, no test failures, and 
all functionality that I tested still works. I found a few minor formatting 
issues; see the below comments.

INLINE COMMENTS

> idtreedb.cpp:76
>  
> -QVector IdTreeDB::get(quint64 docId)
> -{
> -MDB_val key;
> -key.mv_size = sizeof(quint64);
> -key.mv_data = static_cast();
> +QVector IdTreeDB::get(DocId docId)
> +{

Unintentional indentation?

> result.h:44
>  
> -quint64 id() const;
> +Baloo::DocId id() const;
>  QVariantMap map() const;

Can we `#include "idutils.h"` on this file too, so we don't have to use the 
`Baloo::` namespace prefix here and in the implementation file?

> main.cpp:114
>  for (QString url : urls) {
> -quint64 fid = 0;
> +Baloo::DocId fid = 0;
>  if (url.startsWith(QLatin1String("file:"))) {

Ditto.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10825

To: michaelh, adridg, #baloo, #frameworks
Cc: ngraham, alexeymin, ashaposhnikov, michaelh, spoorun, nicolasfella

D10757: Reset QLocale internals when we have a custom app language

[Albert Astals Cid]

aacid updated this revision to Diff 28076.
aacid added a comment.


  Now includes an auto test.
  
  It's not amazing since it doesn't totally reproduce the real world scenario 
but should be close enough.
  
  Had to make two functions be exported but since the header is not installed 
and it's on the KDEPrivate namespace we should be fine

REPOSITORY
  R263 KXmlGui

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10757?vs=27886=28076

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10757

AFFECTED FILES
  autotests/kxmlgui_unittest.cpp
  autotests/kxmlgui_unittest.h
  src/CMakeLists.txt
  src/kswitchlanguagedialog_p.cpp
  src/kswitchlanguagedialog_p.h

To: aacid, apol, ilic
Cc: lueck, #frameworks, michaelh

D10829: Use DocumentId class

[Alexey Min]

alexeymin added a comment.


  In D10829#213553 , @michaelh wrote:
  
  > That's great. Any clues to solve this?
  >
  >   [ 35%] Building CXX object 
src/file/extractor/autotests/CMakeFiles/extractorIOTest.dir/__/iohandler.cpp.o
  >   [ 35%] Linking CXX executable ../../../../bin/extractorIOTest
  >   CMakeFiles/extractorIOTest.dir/__/iohandler.cpp.o: In function 
`Baloo::IOHandler::nextId()':
  >   
/home/super/devel/kde/src/frameworks/baloo-flex/src/file/extractor/iohandler.cpp:46:
 undefined reference to `Baloo::DocumentId::DocumentId(unsigned long long)'
  >   
/home/super/devel/kde/src/frameworks/baloo-flex/src/file/extractor/iohandler.cpp:49:
 undefined reference to `Baloo::DocumentId::operator unsigned long long() const'
  >   collect2: error: ld returned 1 exit status
  >
  >
  > I know cmake only a very little bit and baloo seems very complicated an 
that respect.
  
  
  Error compiling tests. Probably you need to add sources (.cpp - files) 
containing mentioned references to test target in CMakeLists.txt too

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10829

To: michaelh, adridg, #baloo, #frameworks
Cc: alexeymin, ashaposhnikov, michaelh, spoorun, nicolasfella

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 76 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/76/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.7
 Date of build:
Sun, 25 Feb 2018 21:41:42 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3559/13336)19%
(1978/10551)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1139)28%
(421/1490)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/447)0%
(0/239)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(253/2225)7%
(101/1488)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/522)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3488)28%
(827/2917)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)42%
(671/1612)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(553/2011)17%
(306/1757)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1158)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%
  

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 73 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/73/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 25 Feb 2018 21:31:34 +
 Build duration:
14 min and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3558/13339)19%
(1978/10551)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(607/1138)28%
(421/1490)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/447)0%
(0/239)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(254/2229)7%
(102/1492)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/522)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3488)28%
(827/2913)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)42%
(671/1612)28%
(317/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(553/2011)17%
(306/1757)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1158)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.7 - Build # 75 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.7/75/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.7
 Date of build:
Sun, 25 Feb 2018 21:23:29 +
 Build duration:
18 min and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3559/13336)19%
(1978/10551)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1139)28%
(421/1490)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/447)0%
(0/239)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(253/2225)7%
(101/1488)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/522)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3488)28%
(827/2917)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)42%
(671/1612)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(553/2011)17%
(306/1757)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1158)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%
  

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 49 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/49/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Sun, 25 Feb 2018 21:31:34 +
 Build duration:
6 min 9 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 72 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/72/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 25 Feb 2018 21:23:29 +
 Build duration:
6 min 39 sec and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)27%
(3560/13340)19%
(1979/10551)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1139)28%
(421/1490)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/447)0%
(0/239)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(254/2229)7%
(102/1492)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/522)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3488)28%
(827/2913)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)42%
(671/1612)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(553/2011)17%
(306/1757)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1158)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%
  

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 48 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/48/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Sun, 25 Feb 2018 21:23:29 +
 Build duration:
4 min 52 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

D10732: Help automoc to find metadata JSON files referenced in the code

[Friedrich W . H . Kossebau]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:c03c2d526593: Help automoc to find metadata JSON files 
referenced in the code (authored by kossebau).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D10732?vs=27868=28073#toc

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10732?vs=27868=28073

REVISION DETAIL
  https://phabricator.kde.org/D10732

AFFECTED FILES
  CMakeLists.txt
  KF5PlasmaConfig.cmake.in

To: kossebau, #frameworks, #build_system, apol
Cc: michaelh

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.7 - Build # 23 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.7/23/
 Project:
Frameworks kpackage kf5-qt5 SUSEQt5.7
 Date of build:
Sun, 25 Feb 2018 20:58:34 +
 Build duration:
2 min 25 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)96%
(27/28)96%
(27/28)73%
(1619/2214)51%
(1275/2495)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(12/12)100%
(12/12)100%
(546/548)51%
(328/638)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(560/757)64%
(659/1037)src.kpackage.private100%
(8/8)100%
(8/8)79%
(294/370)52%
(128/246)src.kpackagetool100%
(3/3)100%
(3/3)39%
(205/521)27%
(153/562)

KDE CI: Frameworks kpackage kf5-qt5 SUSEQt5.10 - Build # 23 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20SUSEQt5.10/23/
 Project:
Frameworks kpackage kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 25 Feb 2018 20:58:34 +
 Build duration:
1 min 46 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)96%
(27/28)96%
(27/28)73%
(1619/2214)51%
(1275/2495)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(12/12)100%
(12/12)100%
(546/548)51%
(328/638)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(560/757)64%
(659/1037)src.kpackage.private100%
(8/8)100%
(8/8)79%
(294/370)52%
(128/246)src.kpackagetool100%
(3/3)100%
(3/3)39%
(205/521)27%
(153/562)

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.9 - Build # 17 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.9/17/
 Project:
Frameworks kpackage kf5-qt5 FreeBSDQt5.9
 Date of build:
Sun, 25 Feb 2018 20:58:34 +
 Build duration:
1 min 18 sec and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.plasma-packagestructuretestFailed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream

D10733: Help automoc to find metadata JSON files referenced in the code

[Friedrich W . H . Kossebau]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R290:108ed2839cb2: Help automoc to find metadata JSON files 
referenced in the code (authored by kossebau).

REPOSITORY
  R290 KPackage

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10733?vs=27869=28069

REVISION DETAIL
  https://phabricator.kde.org/D10733

AFFECTED FILES
  CMakeLists.txt
  KF5PackageConfig.cmake.in

To: kossebau, #frameworks, #build_system, apol
Cc: michaelh, kmorwinski

D10732: Help automoc to find metadata JSON files referenced in the code

[Friedrich W . H . Kossebau]

kossebau added a comment.


  Given there was no principal objection and this code is following the pattern 
of D10724 , going to push now as well, so 
it gets some more field-testing before next weeks tagging.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10732

To: kossebau, #frameworks, #build_system, apol
Cc: michaelh, kmorwinski

D10733: Help automoc to find metadata JSON files referenced in the code

[Friedrich W . H . Kossebau]

kossebau added a comment.


  Given this code is the same as D10724 , 
going to push now as well, so it gets some more field-testing before next weeks 
tagging.

REPOSITORY
  R290 KPackage

REVISION DETAIL
  https://phabricator.kde.org/D10733

To: kossebau, #frameworks, #build_system, apol
Cc: michaelh, kmorwinski

D10414: Add move semantics support to KIO::UDSEntry.

[Mark Gaiser]

markg added a comment.


  I seem to be making a mess of this commit. Sorry for that.
  https://p.sc2.nl/B13Etcldf with the changes.
  
  Regarding arc to push a change back here again, how do you do that for 
something that is already committed?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10414

To: markg, dfaure
Cc: bcooksley, apol, #frameworks, michaelh, kmorwinski

D10414: Add move semantics support to KIO::UDSEntry.

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> dfaure wrote in udsentrytest.cpp:235
> That's rather overkill (and a wrong use of the QUrl API). You want to use 
> QFileInfo for this.

The comment is marked as done, but the code that was pushed still uses QUrl.

> dfaure wrote in udsentrytest.cpp:269
> swap it around: what you test on the left, what you expect on the right. This 
> makes error messages more readable.  (same above, of course)

Same here, this was not fixed in the commit that was pushed.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10414

To: markg, dfaure
Cc: bcooksley, apol, #frameworks, michaelh, kmorwinski

D10826: Introduce DocumentId class

[Michael Heidelbach]

michaelh added a comment.


  @svuorela: Thank you very much. I will try you suggestion as soon as I'm able 
to get the tests compiled.

INLINE COMMENTS

> svuorela wrote in documentid.h:34
> Does it need to be exported? Is things outside of the baloo engine need to 
> access this? (or is it just avaliable for tests)
> 
> If it is public-public, you need to be careful about the class size and 
> ensure you have enough bits to work with in the members.

I got linker errors without this, so ... err yes.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10826

To: michaelh, adridg, #baloo, #frameworks
Cc: svuorela, ashaposhnikov, michaelh, kmorwinski, spoorun, nicolasfella, 
alexeymin

D10124: Faster simplejob start

[David Faure]

dfaure added a comment.


  This commit leads to
  
  20:29:06.184 okteta(12932) QObject::connect|?libKF5KIOCore.so.5? 
QObject::connect: No such slot KIO::ListJob::slotTotalSize(KIO::filesize_t) in 
/d/kde/src/5/frameworks/kio/src/core/listjob.cpp:289
  
  Please fix ;)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10124

To: jtamate, #frameworks, mwolff, dfaure
Cc: mwolff, broulik, ngraham, anthonyfieroni, michaelh, kmorwinski

D10663: Remove a partially copied file if copyjob was cancelled in the middle of file copying

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.


  I don't like the idea of a flag for this in the API. It just moves the 
problem (of whether it's safe / a good idea to clean up) to the applications, 
who are not in a better place to decide about this. Better make it happen all 
the time, and better make it work right. A flag almost sounds like a excuse for 
a half-hearted feature ("if it works badly in case XYZ, then apps can just opt 
out"). I don't see why the app would care, really. It wants to copy A to B, and 
wants to know if it worked or not; details like cleaning up on cancel are best 
handled by the KIO library.
  
  I don't see any provision for the case I mentioned, where the destination 
file already exists, and should therefore NOT be deleted?
  
  I'm also missing a unittest for this. Now it should be quite easy to 
unittest. Copy a dir with two files, connect to copyingDone() to know when the 
first file was copied, then kill the job in the slot [possibly as a Queued 
invocation]. Dest dir should have only the first file. Then the same when 
connecting to copying(), i.e. before the copy of the first file. Dest dir 
should be empty. And then unittests with existing files at destination.
  
  Thanks for your work on this.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10663

To: dmitrio, #frameworks, dfaure
Cc: ngraham, anthonyfieroni, meven, #frameworks, michaelh, kmorwinski

D10702: Always use a job to delete files to avoid freezing process waiting on IO

[Mark Gaiser]

markg added a comment.


  In D10702#213845 , @dfaure wrote:
  
  > "unlink() in most of the modern filesystems is not affected by the size of 
the file" doesn't match my experience, I have seen konqueror/dolphin freeze for 
10s while deleting a 8GB file (on a somewhat old system, no SSD). And that 
would actually be the reason for this patch to go in. But on the other hand, I 
have a hard time believing that this patch doesn't make things slower for the 
case of many small files, due to the communication overhead with the kioslave 
(and that's the reason I wrote this code in the first place).
  >
  > Maybe the right solution is to use QFile::remove if the file is small, and 
use the kioslave if the file is big. But finding the file size in the first 
place takes a little bit of time too :-)
  
  
  Note that the issue here is the blocking part which @meven tried to solve :)
  The performance impact this would potentially have is merely the point i 
happen to notice.
  
  But the blocking issue remains, also with your suggestion of QFile::remove.
  An alternative approach (that does not involve std::async) is to pre-scan the 
list of files for local files and send them all at once to the kioslave, just 
as a list of files to be deleted. A downside in that approach would be the 
requirement to change the slave as well to handle this.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10702

To: meven, #frameworks, dfaure, ngraham, #dolphin, jtamate
Cc: jtamate, markg, ngraham, #frameworks, michaelh, kmorwinski

D10702: Always use a job to delete files to avoid freezing process waiting on IO

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.


  "unlink() in most of the modern filesystems is not affected by the size of 
the file" doesn't match my experience, I have seen konqueror/dolphin freeze for 
10s while deleting a 8GB file (on a somewhat old system, no SSD). And that 
would actually be the reason for this patch to go in. But on the other hand, I 
have a hard time believing that this patch doesn't make things slower for the 
case of many small files, due to the communication overhead with the kioslave 
(and that's the reason I wrote this code in the first place).
  
  Maybe the right solution is to use QFile::remove if the file is small, and 
use the kioslave if the file is big. But finding the file size in the first 
place takes a little bit of time too :-)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10702

To: meven, #frameworks, dfaure, ngraham, #dolphin, jtamate
Cc: jtamate, markg, ngraham, #frameworks, michaelh, kmorwinski

D10826: Introduce DocumentId class

[Sune Vuorela]

svuorela added a comment.


  A quick review of some quirks and weirdnesses in c++

INLINE COMMENTS

> documentid.cpp:67
> +#if(0)
> +// Due to operator DeviceIdAndInode(), apparently the following
> +// became obsolete.

if you make operator DeviceIdAndInode explicit, you probably end up with a bit 
better behavior.

Else the compiler happily converts a documentid to a deviceidandinode in order 
to make various comparisons at compile time.

e.g. DocumentId id(5,5);
bool b = true;
if (id == b) { ... }  should compile, but probably isn't intended behavior..

> documentid.h:34
> +
> +class BALOO_ENGINE_EXPORT DocumentId
> +{

Does it need to be exported? Is things outside of the baloo engine need to 
access this? (or is it just avaliable for tests)

If it is public-public, you need to be careful about the class size and ensure 
you have enough bits to work with in the members.

> documentid.h:41
> +//TODO: DocumentId(const QT_STATBUF& stBuf);
> +~DocumentId();
> +

is this needed? or is the default generated good enough?

> documentid.h:45
> +
> +DocumentId operator=(const DeviceIdAndInode devino);
> +DocumentId operator=(const DocumentId& id);

shouldn't this return a DocumentId& rather than a copy?

> documentid.h:46
> +DocumentId operator=(const DeviceIdAndInode devino);
> +DocumentId operator=(const DocumentId& id);
> +

=default

  or if you remove the custom dtor, this will be autogenerated.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10826

To: michaelh, adridg, #baloo, #frameworks
Cc: svuorela, ashaposhnikov, michaelh, kmorwinski, spoorun, nicolasfella, 
alexeymin

D10803: handle more tags in taglibextractor

[Michael Heidelbach]

michaelh added a comment.


  In D10803#213767 , @astippich 
wrote:
  
  > I don't know dolphin works, but given how KFileMetadata is designed, the 
new tags should be ignored until explicit support is added in dolphin.
  
  
  Please try that. For unknown types baloo-widgets (responsible for 
infopanel/tooltips) falls back to `value.toString()`, no idea what will happen 
when you feed it with binary data. The cover properties return binary data, 
right?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D10803

To: astippich, mgallien
Cc: dfaure, michaelh, ngraham, #frameworks, kmorwinski

D10803: handle more tags in taglibextractor

[Matthieu Gallien]

mgallien added a subscriber: dfaure.
mgallien added inline comments.

INLINE COMMENTS

> astippich wrote in properties.h:168
> I noticed the typo as well, but I think this is a matter of API 
> compatibility, so I left it unchanged. Matthieu should know.

It is part of the source compatibility promise for a major version of 
KFileMetaData. However, you can add a new one and push the data to both 
properties. This way, we could deprecate the one with the typo. @dfaure do you 
have another solution ?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D10803

To: astippich, mgallien
Cc: dfaure, michaelh, ngraham, #frameworks, kmorwinski

D10803: handle more tags in taglibextractor

[Alexander Stippich]

astippich added a comment.


  I don't know dolphin works, but given how KFileMetadata is designed, the new 
tags should be ignored until explicit support is added in dolphin.

INLINE COMMENTS

> michaelh wrote in properties.h:164
> ?

Oops, seems like a wrong copy & paste :)  will fix

> michaelh wrote in properties.h:168
> Will we break ABI with correct 'Language'?

I noticed the typo as well, but I think this is a matter of API compatibility, 
so I left it unchanged. Matthieu should know.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D10803

To: astippich, mgallien
Cc: michaelh, ngraham, #frameworks, kmorwinski

D10803: handle more tags in taglibextractor

[Michael Heidelbach]

michaelh added a comment.


  Nice! How do the infopanel or tooltips of dolphin look with this?

INLINE COMMENTS

> properties.h:164
>  /**
> - * The language the document is written in. This directly maps to the
> + * The language the document is written in. Thiof a media file.s 
> directly maps to the
>   * 'dc:language' tag from DublinCore. We do NOT employ any language

?

> properties.h:168
>   */
>  Langauge,
>  

Will we break ABI with correct 'Language'?

> propertyinfo.cpp:586
>  { QStringLiteral("linecount"), Property::LineCount },
>  { QStringLiteral("language"), Property::Langauge },
>  { QStringLiteral("copyright"), Property::Copyright },

Language?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D10803

To: astippich, mgallien
Cc: michaelh, ngraham, #frameworks, kmorwinski

D10694: epubextractor: Handle multiple subjects better

[Matthieu Gallien]

mgallien added a comment.


  In D10694#210509 , @michaelh wrote:
  
  > The only component I could find to be affected by this change is 
`baloo-widgets`. I have already adapted it to this change. And yes, it will 
handle both.
  >  It will take a some time to publish it because some other stuff has to get 
reviewed first.
  >  I you know of any component or application using the epub-extractor of 
KFileMetadata apart from baloo-widgets please let me know.
  
  
  I do understand that you have searched inside KDE hosted code. Still, you are 
modifying the behavior. To me, it is necessary to have a test that ensures that 
possible existing clients are not affected by your change. Could you add it ?

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D10694

To: michaelh, mgallien, dfaure
Cc: #frameworks, ashaposhnikov, michaelh, kmorwinski, spoorun, navarromorales, 
isidorov, nicolasfella, firef, andrebarros, alexeymin, emmanuelp

D10807: fileindexerconfig: Exclude Vaults by default

[Michael Heidelbach]

michaelh added a comment.


  In D10807#213250 , @rkflx wrote:
  
  > What about users who manually create and mount FUSE-type encrypted 
directories? Plasma Vault is just a nice interface for this workflow, after all.
  
  
  Good point.
  
  > A more general approach would be to look at the filesystem type in `mount` 
(do we have an API for that?). I'd imagine a user configurable whitelist and/or 
blacklist (in a config file, not sure that's UI material) would be most 
flexible. Perhaps there's already similar code in Baloo for handling removable 
devices or remote filesystems, or is this all based on some hardcoded path 
heuristics?
  
  Not sure, apparently baloo reads `/etc/mtab` only to disable copy-on-write on 
btrfs.
  Baloo needs a better handling of filesystems. I just started to tackle this 
(see T8054 ). When I'm done with that, it 
should be possible to white-/blacklist specific filesystems.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10807

To: michaelh, #baloo, #frameworks, ngraham, #plasma
Cc: rkflx, alexeymin, plasma-devel, ivan, nicolasfella, ashaposhnikov, 
michaelh, kmorwinski, spoorun, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.9 - Build # 26 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.9/26/
 Project:
Frameworks kwayland kf5-qt5 FreeBSDQt5.9
 Date of build:
Sun, 25 Feb 2018 13:16:12 +
 Build duration:
38 min and counting
   JUnit Tests
  Name: (root) Failed: 13 test(s), Passed: 24 test(s), Skipped: 0 test(s), Total: 37 test(s)Failed: TestSuite.kwayland-testCompositorFailed: TestSuite.kwayland-testDataDeviceFailed: TestSuite.kwayland-testDataSourceFailed: TestSuite.kwayland-testQtSurfaceExtensionFailed: TestSuite.kwayland-testRegionFailed: TestSuite.kwayland-testShmPoolFailed: TestSuite.kwayland-testSubCompositorFailed: TestSuite.kwayland-testSubSurfaceFailed: TestSuite.kwayland-testWaylandConnectionThreadFailed: TestSuite.kwayland-testWaylandRegistryFailed: TestSuite.kwayland-testWaylandServerDisplayFailed: TestSuite.kwayland-testWaylandShellFailed: TestSuite.kwayland-testWaylandSurface

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.7 - Build # 29 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.7/29/
 Project:
Frameworks kwayland kf5-qt5 SUSEQt5.7
 Date of build:
Sun, 25 Feb 2018 13:37:42 +
 Build duration:
5 min 17 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 42 test(s), Skipped: 0 test(s), Total: 42 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report57%
(4/7)91%
(222/243)91%
(222/243)85%
(23760/27912)53%
(11657/22188)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(39/39)100%
(39/39)99%
(11101/11170)50%
(7634/15231)autotests.server100%
(5/5)100%
(5/5)99%
(359/362)49%
(220/446)src.client99%
(68/69)99%
(68/69)85%
(5585/6536)66%
(1759/2674)src.server99%
(110/111)99%
(110/111)87%
(6715/7694)65%
(2044/3158)src.tools0%
(0/2)0%
(0/2)0%
(0/779)0%
(0/346)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/16)tests0%
(0/14)0%
(0/14)0%
(0/1251)0%
(0/317)

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.7 - Build # 28 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.7/28/
 Project:
Frameworks kwayland kf5-qt5 SUSEQt5.7
 Date of build:
Sun, 25 Feb 2018 13:16:12 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 41 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: TestSuite.kwayland-testRegion
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report57%
(4/7)91%
(222/243)91%
(222/243)85%
(23758/27912)53%
(11655/22188)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(39/39)100%
(39/39)99%
(11099/11170)50%
(7632/15231)autotests.server100%
(5/5)100%
(5/5)99%
(359/362)49%
(220/446)src.client99%
(68/69)99%
(68/69)85%
(5585/6536)66%
(1759/2674)src.server99%
(110/111)99%
(110/111)87%
(6715/7694)65%
(2044/3158)src.tools0%
(0/2)0%
(0/2)0%
(0/779)0%
(0/346)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/16)tests0%
(0/14)0%
(0/14)0%
(0/1251)0%
(0/317)

D10823: idutils: Fix typo

[Michael Heidelbach]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:fa08a62b0fdf: idutils: Fix typo (authored by michaelh).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10823?vs=27999=28027

REVISION DETAIL
  https://phabricator.kde.org/D10823

AFFECTED FILES
  src/engine/idutils.h

To: michaelh, adridg, #baloo, #frameworks, alexeymin
Cc: alexeymin, ashaposhnikov, michaelh, kmorwinski, spoorun, nicolasfella

D10142: [server] Properly handle the situation when the DataSource for a drag gets destroyed

[Martin Flöser]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:2dfe16d774c7: [server] Properly handle the situation when 
the DataSource for a drag gets… (authored by graesslin).
Restricted Application edited projects, added Plasma; removed Plasma on Wayland.

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10142?vs=26054=28025

REVISION DETAIL
  https://phabricator.kde.org/D10142

AFFECTED FILES
  autotests/client/test_drag_drop.cpp
  src/server/datadevice_interface.cpp
  src/server/seat_interface.cpp
  src/server/seat_interface_p.h

To: graesslin, #frameworks, #kwin, #plasma, romangg
Cc: plasma-devel, michaelh, kmorwinski, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, schernikov, alexeymin, eliasp, hein

D10823: idutils: Fix typo

[Adriaan de Groot]

adridg accepted this revision.
adridg added a comment.


  I'm so happy :)
  
  This is partly to help @michaelh get into the swing of things, with writing a 
patch, pushing it to review, getting it okayed .. a bit of "this is the 
process". Of course later there's no need for typo-fix reviews that don't 
affect user-visible strings.
  
  As for landing in the right branch .. er .. to me that's arcane (ha!) 
knowledge. I would suggest landing this one, and then you can see where it ends 
up :)

REPOSITORY
  R293 Baloo

BRANCH
  typo (branched from flexible-docid)

REVISION DETAIL
  https://phabricator.kde.org/D10823

To: michaelh, adridg, #baloo, #frameworks, alexeymin
Cc: alexeymin, ashaposhnikov, michaelh, kmorwinski, spoorun, nicolasfella

D10829: Use DocumentId class

[Michael Heidelbach]

michaelh added a comment.


  That's great. Any clues to solve this?
  
[ 35%] Building CXX object 
src/file/extractor/autotests/CMakeFiles/extractorIOTest.dir/__/iohandler.cpp.o
[ 35%] Linking CXX executable ../../../../bin/extractorIOTest
CMakeFiles/extractorIOTest.dir/__/iohandler.cpp.o: In function 
`Baloo::IOHandler::nextId()':

/home/super/devel/kde/src/frameworks/baloo-flex/src/file/extractor/iohandler.cpp:46:
 undefined reference to `Baloo::DocumentId::DocumentId(unsigned long long)'

/home/super/devel/kde/src/frameworks/baloo-flex/src/file/extractor/iohandler.cpp:49:
 undefined reference to `Baloo::DocumentId::operator unsigned long long() const'
collect2: error: ld returned 1 exit status
  
  I know cmake only a very little bit and baloo seems very complicated an that 
respect.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10829

To: michaelh, adridg, #baloo, #frameworks
Cc: alexeymin, ashaposhnikov, michaelh, kmorwinski, spoorun, nicolasfella

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.7 - Build # 44 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.7/44/
 Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.7
 Date of build:
Sun, 25 Feb 2018 12:03:21 +
 Build duration:
15 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 67 test(s), Skipped: 0 test(s), Total: 67 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report82%
(23/28)89%
(301/337)89%
(301/337)69%
(34097/49359)52%
(17892/34196)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(49/49)100%
(49/49)94%
(4381/4672)49%
(2166/4386)autotests.src.vimode100%
(16/16)100%
(16/16)99%
(5493/5534)58%
(1073/1846)src.buffer88%
(15/17)88%
(15/17)91%
(1704/1881)77%
(1326/1724)src.completion100%
(16/16)100%
(16/16)57%
(1779/3121)43%
(1243/2905)src.completion.expandingtree100%
(5/5)100%
(5/5)40%
(185/460)22%
(79/360)src.dialogs0%
(0/4)0%
(0/4)0%
(0/830)0%
(0/242)src.document100%
(4/4)100%
(4/4)59%
(1889/3183)49%
(1718/3499)src.export100%
(4/4)100%
(4/4)86%
(107/125)69%
(118/170)src.include.ktexteditor100%
(14/14)100%
(14/14)92%
(227/248)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)59%
(178/301)44%
(34/77)src.mode83%
(5/6)83%
(5/6)40%
(170/420)37%
(103/275)src.part0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/832)0%
(0/296)src.render100%
(9/9)100%
(9/9)76%
(927/1219)66%
(627/944)src.schema22%
(2/9)22%
(2/9)1%
(21/1501)1%
(6/729)src.script100%
(17/17)100%
(17/17)70%
(739/1057)59%
(306/517)src.search100%
(7/7)100%
(7/7)73%
(1099/1501)63%
(609/965)src.spellcheck75%
(6/8)75%
(6/8)30%

D10829: Use DocumentId class

[Michael Heidelbach]

michaelh updated this revision to Diff 28013.
michaelh added a comment.


  - idutils: Use DocumentId constructor
  - DocumentId: Add 'QDebug operator<<'

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10829?vs=28008=28013

BRANCH
  use-class (branched from flexible-docid)

REVISION DETAIL
  https://phabricator.kde.org/D10829

AFFECTED FILES
  src/engine/CMakeLists.txt
  src/engine/andpostingiterator.h
  src/engine/documentid.cpp
  src/engine/documentid.h
  src/engine/idutils.h
  src/engine/postingiterator.h

To: michaelh, adridg, #baloo, #frameworks
Cc: alexeymin, ashaposhnikov, michaelh, kmorwinski, spoorun, nicolasfella

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.9 - Build # 29 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.9/29/
 Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.9
 Date of build:
Sun, 25 Feb 2018 12:03:21 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 66 test(s), Skipped: 0 test(s), Total: 66 test(s)

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 43 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/43/
 Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 25 Feb 2018 12:03:21 +
 Build duration:
7 min 0 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 67 test(s), Skipped: 0 test(s), Total: 67 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report82%
(23/28)89%
(301/337)89%
(301/337)69%
(34085/49353)52%
(17891/34194)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.src100%
(49/49)100%
(49/49)94%
(4370/4669)49%
(2164/4386)autotests.src.vimode100%
(16/16)100%
(16/16)99%
(5493/5534)58%
(1073/1846)src.buffer88%
(15/17)88%
(15/17)91%
(1704/1881)77%
(1326/1724)src.completion100%
(16/16)100%
(16/16)57%
(1778/3121)43%
(1242/2905)src.completion.expandingtree100%
(5/5)100%
(5/5)40%
(185/460)22%
(79/360)src.dialogs0%
(0/4)0%
(0/4)0%
(0/830)0%
(0/242)src.document100%
(4/4)100%
(4/4)59%
(1889/3183)49%
(1718/3499)src.export100%
(4/4)100%
(4/4)86%
(107/125)69%
(118/170)src.include.ktexteditor100%
(14/14)100%
(14/14)92%
(227/248)65%
(146/226)src.inputmode100%
(8/8)100%
(8/8)59%
(178/301)44%
(34/77)src.mode83%
(5/6)83%
(5/6)40%
(170/420)37%
(103/275)src.part0%
(0/1)0%
(0/1)0%
(0/8)100%
(0/0)src.printing0%
(0/4)0%
(0/4)0%
(0/832)0%
(0/296)src.render100%
(9/9)100%
(9/9)76%
(927/1219)66%
(627/944)src.schema22%
(2/9)22%
(2/9)1%
(21/1501)1%
(6/729)src.script100%
(17/17)100%
(17/17)70%
(739/1057)59%
(306/517)src.search100%
(7/7)100%
(7/7)73%
(1099/1501)63%
(609/965)src.spellcheck75%
(6/8)75%
(6/8)30%

D10641: Revoke temporary authorization of KIO slave before sending status to IdleSlave

[Chinmoy Ranjan Pradhan]

chinmoyr removed a dependent revision: D10437: Update file ioslave's temporary 
authorization list.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10641

To: chinmoyr, dfaure
Cc: fvogt, #frameworks, michaelh, kmorwinski

D10437: Update file ioslave's temporary authorization list

[Chinmoy Ranjan Pradhan]

chinmoyr edited dependencies, added: D10818: Store PolicyKit action which the 
slave is authorized to perform; removed: D10641: Revoke temporary authorization 
of KIO slave before sending status to IdleSlave.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10437

To: chinmoyr, #frameworks, dfaure, fvogt
Cc: markg, anthonyfieroni, michaelh, kmorwinski

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.7 - Build # 43 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.7/43/
 Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.7
 Date of build:
Sun, 25 Feb 2018 11:54:51 +
 Build duration:
5 min 15 sec and counting
   CONSOLE OUTPUT
  [...truncated 147.76 KB...][  8%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextblock.cpp.o[  9%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextrange.cpp.o[  9%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextcursor.cpp.o[  9%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextline.cpp.o[  9%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetexthistory.cpp.o[  9%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextfolding.cpp.o[ 10%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katecompletionwidget.cpp.o[ 10%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katecompletionmodel.cpp.o[ 10%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katecompletiontree.cpp.o[ 10%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katecompletionconfig.cpp.o[ 11%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/kateargumenthinttree.cpp.o[ 11%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/kateargumenthintmodel.cpp.o[ 11%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katecompletiondelegate.cpp.o[ 12%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/expandingtree/expandingwidgetmodel.cpp.o[ 12%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/expandingtree/expandingdelegate.cpp.o[ 12%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/expandingtree/expandingtree.cpp.o[ 12%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katewordcompletion.cpp.o[ 13%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katekeywordcompletion.cpp.o[ 13%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/dialogs/kateconfigpage.cpp.o[ 13%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/dialogs/katedialogs.cpp.o[ 13%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/document/katedocument.cpp.o[ 14%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/document/katebuffer.cpp.o[ 14%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/undo/kateundo.cpp.o[ 14%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/undo/katemodifiedundo.cpp.o[ 15%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/undo/kateundomanager.cpp.o[ 15%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/script/kateindentscript.cpp.o[ 15%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/script/katescript.cpp.o[ 15%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/script/katecommandlinescript.cpp.o[ 16%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/script/katescriptmanager.cpp.o[ 16%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/script/katescriptaction.cpp.o[ 16%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/script/katescriptdocument.cpp.o[ 16%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/script/katescripthelpers.cpp.o[ 17%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/script/katescriptview.cpp.o[ 17%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/mode/katemodemanager.cpp.o[ 17%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/mode/katemodeconfigpage.cpp.o[ 18%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/mode/katemodemenu.cpp.o[ 18%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/mode/katewildcardmatcher.cpp.o[ 18%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/variableeditor/variablelineedit.cpp.o[ 18%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/variableeditor/variablelistview.cpp.o[ 19%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/variableeditor/variableeditor.cpp.o[ 19%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/variableeditor/variableitem.cpp.o[ 19%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/variableeditor/katehelpbutton.cpp.o[ 20%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/printing/kateprinter.cpp.o[ 20%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/printing/printpainter.cpp.o[ 20%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/printing/printconfigwidgets.cpp.o[ 20%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/render/katerenderer.cpp.o[ 21%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/render/katerenderrange.cpp.o[ 21%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/render/katelayoutcache.cpp.o[ 21%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/render/katetextlayout.cpp.o[ 22%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/render/katelinelayout.cpp.o[ 22%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/search/kateregexp.cpp.o[ 22%] Building CXX object 

D10818: Store PolicyKit action which the slave is authorized to perform

[Chinmoy Ranjan Pradhan]

chinmoyr added a dependent revision: D10437: Update file ioslave's temporary 
authorization list.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10818

To: chinmoyr, dfaure
Cc: #frameworks, michaelh, kmorwinski

D10568: Handle privilege operation confirmation prompts in SlaveBase

[Chinmoy Ranjan Pradhan]

chinmoyr added a dependent revision: D10818: Store PolicyKit action which the 
slave is authorized to perform.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10568

To: chinmoyr, dfaure
Cc: fvogt, #frameworks, michaelh, kmorwinski

D10818: Store PolicyKit action which the slave is authorized to perform

[Chinmoy Ranjan Pradhan]

chinmoyr added a dependency: D10568: Handle privilege operation confirmation 
prompts in SlaveBase.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10818

To: chinmoyr, dfaure
Cc: #frameworks, michaelh, kmorwinski

D10568: Handle privilege operation confirmation prompts in SlaveBase

[Chinmoy Ranjan Pradhan]

chinmoyr removed a dependent revision: D10641: Revoke temporary authorization 
of KIO slave before sending status to IdleSlave.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10568

To: chinmoyr, dfaure
Cc: fvogt, #frameworks, michaelh, kmorwinski

D10641: Revoke temporary authorization of KIO slave before sending status to IdleSlave

[Chinmoy Ranjan Pradhan]

chinmoyr removed a dependency: D10568: Handle privilege operation confirmation 
prompts in SlaveBase.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10641

To: chinmoyr, dfaure
Cc: fvogt, #frameworks, michaelh, kmorwinski

D10641: Revoke temporary authorization of KIO slave before sending status to IdleSlave

[Chinmoy Ranjan Pradhan]

chinmoyr added a dependency: D10820: Send slave's polkit authorization status 
to the host.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10641

To: chinmoyr, dfaure
Cc: fvogt, #frameworks, michaelh, kmorwinski

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.9 - Build # 28 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.9/28/
 Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.9
 Date of build:
Sun, 25 Feb 2018 11:54:51 +
 Build duration:
2 min 28 sec and counting
   CONSOLE OUTPUT
  [...truncated 119.39 KB...][  5%] Generating ui_searchbarpower.h[  6%] Generating ui_spellcheckbar.h[  6%] Generating ui_spellcheckconfigwidget.h[  6%] Generating ui_howtoimportschema.h[  7%] Generating qrc_ktexteditor.cpp[  7%] Generating qrc_script.cppScanning dependencies of target KF5TextEditor[  7%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katesecuretextbuffer.cpp.o[  7%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextline.cpp.o[  8%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextbuffer.cpp.o[  8%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextblock.cpp.o[  8%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextcursor.cpp.o[  9%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextrange.cpp.o[  9%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetexthistory.cpp.o[  9%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextfolding.cpp.o[ 10%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katecompletionwidget.cpp.o[ 10%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katecompletionmodel.cpp.o[ 10%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katecompletiontree.cpp.o[ 10%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katecompletionconfig.cpp.o[ 11%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/kateargumenthinttree.cpp.o[ 11%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/kateargumenthintmodel.cpp.o[ 11%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katecompletiondelegate.cpp.o[ 12%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/expandingtree/expandingwidgetmodel.cpp.o[ 12%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/expandingtree/expandingdelegate.cpp.o[ 12%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/expandingtree/expandingtree.cpp.o[ 12%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katewordcompletion.cpp.o[ 13%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katekeywordcompletion.cpp.o[ 13%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/dialogs/kateconfigpage.cpp.o[ 13%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/dialogs/katedialogs.cpp.o[ 13%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/document/katedocument.cpp.o[ 14%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/document/katebuffer.cpp.o[ 14%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/undo/kateundo.cpp.o[ 14%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/undo/katemodifiedundo.cpp.o[ 15%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/undo/kateundomanager.cpp.o[ 15%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/script/katescript.cpp.o[ 15%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/script/kateindentscript.cpp.o[ 15%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/script/katecommandlinescript.cpp.o[ 16%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/script/katescriptmanager.cpp.o[ 16%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/script/katescriptaction.cpp.o[ 16%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/script/katescriptdocument.cpp.o[ 17%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/script/katescriptview.cpp.o[ 17%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/script/katescripthelpers.cpp.o[ 17%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/mode/katemodemanager.cpp.o[ 17%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/mode/katemodeconfigpage.cpp.o[ 18%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/mode/katemodemenu.cpp.o[ 18%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/mode/katewildcardmatcher.cpp.o[ 18%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/variableeditor/variablelineedit.cpp.o[ 18%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/variableeditor/variablelistview.cpp.o[ 19%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/variableeditor/variableeditor.cpp.o[ 19%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/variableeditor/variableitem.cpp.o[ 19%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/variableeditor/katehelpbutton.cpp.o[ 20%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/printing/kateprinter.cpp.o[ 20%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/printing/printpainter.cpp.o[ 20%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/printing/printconfigwidgets.cpp.o[ 20%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/render/katerenderer.cpp.o[ 21%] 

D10820: Send slave's polkit authorization status to the host

[Chinmoy Ranjan Pradhan]

chinmoyr added a dependent revision: D10641: Revoke temporary authorization of 
KIO slave before sending status to IdleSlave.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10820

To: chinmoyr, dfaure
Cc: #frameworks, michaelh, kmorwinski

D10829: Use DocumentId class

[Michael Heidelbach]

michaelh added a comment.


  @alexeymin: Could you use inline comments, please. That would help me a lot. 
And: thank you for your comments. It is really nice to have someone commenting 
without me poking first. ;-)

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10829

To: michaelh, adridg, #baloo, #frameworks
Cc: alexeymin, ashaposhnikov, michaelh, kmorwinski, spoorun, nicolasfella

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 42 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/42/
 Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 25 Feb 2018 11:54:51 +
 Build duration:
1 min 47 sec and counting
   CONSOLE OUTPUT
  [...truncated 143.08 KB...][  5%] Generating ui_opensaveconfigadvwidget.h[  5%] Generating ui_completionconfigwidget.h[  5%] Generating ui_searchbarincremental.h[  5%] Generating ui_searchbarpower.h[  5%] Generating ui_spellcheckconfigwidget.h[  6%] Generating ui_spellcheckbar.h[  6%] Generating ui_howtoimportschema.h[  7%] Generating qrc_ktexteditor.cpp[  7%] Generating qrc_script.cppScanning dependencies of target KF5TextEditor[  8%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextbuffer.cpp.o[  8%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katesecuretextbuffer.cpp.o[  8%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextcursor.cpp.o[  8%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextblock.cpp.o[  8%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextline.cpp.o[  9%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextrange.cpp.o[  9%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetexthistory.cpp.o[  9%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextfolding.cpp.o[ 10%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katecompletionwidget.cpp.o[ 10%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katecompletionmodel.cpp.o[ 10%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katecompletiontree.cpp.o[ 10%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katecompletionconfig.cpp.o[ 11%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/kateargumenthinttree.cpp.o[ 11%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/kateargumenthintmodel.cpp.o[ 11%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katecompletiondelegate.cpp.o[ 12%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/expandingtree/expandingwidgetmodel.cpp.o[ 12%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/expandingtree/expandingdelegate.cpp.o[ 12%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/expandingtree/expandingtree.cpp.o[ 12%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katewordcompletion.cpp.o[ 13%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katekeywordcompletion.cpp.o[ 13%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/dialogs/kateconfigpage.cpp.o[ 13%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/dialogs/katedialogs.cpp.o[ 13%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/document/katedocument.cpp.o[ 14%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/document/katebuffer.cpp.o[ 14%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/undo/kateundo.cpp.o[ 14%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/undo/katemodifiedundo.cpp.o[ 15%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/undo/kateundomanager.cpp.o[ 15%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/script/katescript.cpp.o[ 15%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/script/kateindentscript.cpp.o[ 15%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/script/katecommandlinescript.cpp.o[ 16%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/script/katescriptmanager.cpp.o[ 16%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/script/katescriptaction.cpp.o[ 16%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/script/katescriptdocument.cpp.o[ 17%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/script/katescriptview.cpp.o[ 17%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/script/katescripthelpers.cpp.o[ 17%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/mode/katemodemanager.cpp.o[ 17%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/mode/katemodeconfigpage.cpp.o[ 18%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/mode/katemodemenu.cpp.o[ 18%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/mode/katewildcardmatcher.cpp.o[ 18%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/variableeditor/variablelineedit.cpp.o[ 18%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/variableeditor/variablelistview.cpp.o[ 19%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/variableeditor/variableeditor.cpp.o[ 19%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/variableeditor/variableitem.cpp.o[ 19%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/variableeditor/katehelpbutton.cpp.o[ 20%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/printing/kateprinter.cpp.o[ 20%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/printing/printpainter.cpp.o[ 20%] Building CXX object 

D10820: Send slave's polkit authorization status to the host

[Chinmoy Ranjan Pradhan]

chinmoyr edited the summary of this revision.
chinmoyr added a dependency: D10818: Store PolicyKit action which the slave is 
authorized to perform.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10820

To: chinmoyr, dfaure
Cc: #frameworks, michaelh, kmorwinski

D10818: Store PolicyKit action which the slave is authorized to perform

[Chinmoy Ranjan Pradhan]

chinmoyr added a dependent revision: D10820: Send slave's polkit authorization 
status to the host.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10818

To: chinmoyr, dfaure
Cc: #frameworks, michaelh, kmorwinski

D10820: Send slave's polkit authorization status to the host

[Chinmoy Ranjan Pradhan]

chinmoyr added a dependent revision: D10822: Store temporary authorization 
status in IdleSlave.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10820

To: chinmoyr, dfaure
Cc: #frameworks, michaelh, kmorwinski

D10822: Store temporary authorization status in IdleSlave

[Chinmoy Ranjan Pradhan]

chinmoyr edited the summary of this revision.
chinmoyr added a dependency: D10820: Send slave's polkit authorization status 
to the host.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10822

To: chinmoyr, dfaure
Cc: #frameworks, michaelh, kmorwinski

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.7 - Build # 42 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.7/42/
 Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.7
 Date of build:
Sun, 25 Feb 2018 11:42:16 +
 Build duration:
6 min 51 sec and counting
   CONSOLE OUTPUT
  [...truncated 132.03 KB...]./src./src/%{APPNAMELC}.json./src/%{APPNAMELC}plugin.cpp./src/CMakeLists.txt./src/%{APPNAMELC}view.cpp./src/%{APPNAMELC}view.h./src/Messages.sh./src/%{APPNAMELC}plugin.h./ktexteditor-plugin.png[  1%] Built target ktexteditor-plugin[  1%] Built target kauth_ktexteditor_helper_autogen[  1%] actions for org.kde.ktexteditor.katetextbufferScanning dependencies of target kauth_ktexteditor_helper[  1%] Built target org.kde.ktexteditor.katetextbuffer.policy-customtarget[  1%] Building CXX object src/CMakeFiles/kauth_ktexteditor_helper.dir/buffer/katesecuretextbuffer.cpp.o[  1%] Building CXX object src/CMakeFiles/kauth_ktexteditor_helper.dir/kauth_ktexteditor_helper_autogen/mocs_compilation.cpp.o[  2%] Linking CXX executable ../bin/kauth_ktexteditor_helper[  2%] Built target kauth_ktexteditor_helper[  2%] Built target KF5TextEditor_autogen[  2%] Generating ui_textareaappearanceconfigwidget.h[  3%] Generating ui_commandmenueditwidget.h[  3%] Generating ui_configwidget.h[  3%] Generating ui_completionconfigtab.h[  3%] Generating ui_commandmenuconfigwidget.h[  3%] Generating ui_bordersappearanceconfigwidget.h[  3%] Generating ui_editconfigwidget.h[  4%] Generating ui_opensaveconfigadvwidget.h[  4%] Generating ui_indentationconfigwidget.h[  5%] Generating ui_filetypeconfigwidget.h[  5%] Generating ui_navigationconfigwidget.h[  5%] Generating ui_opensaveconfigwidget.h[  5%] Generating ui_searchbarincremental.h[  6%] Generating ui_spellcheckbar.h[  6%] Generating ui_completionconfigwidget.h[  6%] Generating ui_searchbarpower.h[  6%] Generating ui_spellcheckconfigwidget.h[  6%] Generating ui_howtoimportschema.h[  7%] Generating qrc_ktexteditor.cpp[  7%] Generating qrc_script.cppScanning dependencies of target KF5TextEditor[  7%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katesecuretextbuffer.cpp.o[  8%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextbuffer.cpp.o[  8%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextblock.cpp.o[  8%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextcursor.cpp.o[  9%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextrange.cpp.o[  9%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextline.cpp.o[  9%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetexthistory.cpp.o[  9%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextfolding.cpp.o[ 10%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katecompletionwidget.cpp.o[ 10%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katecompletionmodel.cpp.o[ 10%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katecompletiontree.cpp.o[ 10%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katecompletionconfig.cpp.o[ 11%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/kateargumenthinttree.cpp.o[ 11%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/kateargumenthintmodel.cpp.o[ 11%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katecompletiondelegate.cpp.o[ 12%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/expandingtree/expandingwidgetmodel.cpp.o[ 12%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/expandingtree/expandingdelegate.cpp.o[ 12%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/expandingtree/expandingtree.cpp.o[ 12%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katewordcompletion.cpp.o[ 13%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katekeywordcompletion.cpp.o[ 13%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/dialogs/kateconfigpage.cpp.o[ 13%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/dialogs/katedialogs.cpp.o[ 13%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/document/katedocument.cpp.o[ 14%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/document/katebuffer.cpp.o[ 14%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/undo/kateundo.cpp.o[ 14%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/undo/katemodifiedundo.cpp.o[ 15%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/undo/kateundomanager.cpp.o/home/jenkins/workspace/Frameworks ktexteditor kf5-qt5 SUSEQt5.7/src/document/katedocument.cpp: In member function ‘void KTextEditor::DocumentPrivate::readVariableLine(QString, bool)’:/home/jenkins/workspace/Frameworks ktexteditor kf5-qt5 SUSEQt5.7/src/document/katedocument.cpp:4634:97: error: direct-list-initialization of ‘auto’ requires exactly one element [-fpermissive] const auto l{ QLatin1String("unix"), 

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.9 - Build # 27 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.9/27/
 Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.9
 Date of build:
Sun, 25 Feb 2018 11:42:16 +
 Build duration:
4 min 36 sec and counting
   CONSOLE OUTPUT
  [...truncated 105.83 KB...][  1%] actions for org.kde.ktexteditor.katetextbuffer[  1%] Built target org.kde.ktexteditor.katetextbuffer.policy-customtarget../CMakeLists.txt./README.md./ktexteditor-plugin.kdevtemplate./ktexteditor-plugin.png./src./src/%{APPNAMELC}.json./src/%{APPNAMELC}plugin.cpp./src/%{APPNAMELC}plugin.h./src/%{APPNAMELC}view.cpp./src/%{APPNAMELC}view.h./src/CMakeLists.txt./src/Messages.sh[  1%] Built target ktexteditor-plugin[  1%] Built target kauth_ktexteditor_helper_autogenScanning dependencies of target kauth_ktexteditor_helper[  1%] Building CXX object src/CMakeFiles/kauth_ktexteditor_helper.dir/kauth_ktexteditor_helper_autogen/mocs_compilation.cpp.o[  1%] Building CXX object src/CMakeFiles/kauth_ktexteditor_helper.dir/buffer/katesecuretextbuffer.cpp.o[  2%] Linking CXX executable ../bin/kauth_ktexteditor_helper[  2%] Built target kauth_ktexteditor_helper[  2%] Built target KF5TextEditor_autogen[  2%] Generating ui_bordersappearanceconfigwidget.h[  2%] Generating ui_commandmenuconfigwidget.h[  2%] Generating ui_configwidget.h[  2%] Generating ui_textareaappearanceconfigwidget.h[  3%] Generating ui_commandmenueditwidget.h[  3%] Generating ui_completionconfigtab.h[  3%] Generating ui_navigationconfigwidget.h[  3%] Generating ui_indentationconfigwidget.h[  3%] Generating ui_editconfigwidget.h[  3%] Generating ui_opensaveconfigwidget.h[  5%] Generating ui_filetypeconfigwidget.h[  5%] Generating ui_opensaveconfigadvwidget.h[  5%] Generating ui_completionconfigwidget.h[  5%] Generating ui_searchbarincremental.h[  5%] Generating ui_searchbarpower.h[  6%] Generating ui_spellcheckbar.h[  6%] Generating ui_spellcheckconfigwidget.h[  6%] Generating ui_howtoimportschema.h[  7%] Generating qrc_ktexteditor.cpp[  7%] Generating qrc_script.cppScanning dependencies of target KF5TextEditor[  7%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katesecuretextbuffer.cpp.o[  7%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextline.cpp.o[  8%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextbuffer.cpp.o[  8%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextblock.cpp.o[  9%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextrange.cpp.o[  9%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextcursor.cpp.o[  9%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetexthistory.cpp.o[  9%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextfolding.cpp.o[ 10%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katecompletionwidget.cpp.o[ 10%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katecompletionmodel.cpp.o[ 10%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katecompletiontree.cpp.o[ 10%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katecompletionconfig.cpp.o[ 11%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/kateargumenthinttree.cpp.o[ 11%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/kateargumenthintmodel.cpp.o[ 11%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katecompletiondelegate.cpp.o[ 12%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/expandingtree/expandingwidgetmodel.cpp.o[ 12%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/expandingtree/expandingdelegate.cpp.o[ 12%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/expandingtree/expandingtree.cpp.o[ 12%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katewordcompletion.cpp.o[ 13%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katekeywordcompletion.cpp.o[ 13%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/dialogs/kateconfigpage.cpp.o[ 13%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/dialogs/katedialogs.cpp.o[ 13%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/document/katedocument.cpp.o[ 14%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/document/katebuffer.cpp.o[ 14%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/undo/kateundo.cpp.o[ 14%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/undo/katemodifiedundo.cpp.o[ 15%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/undo/kateundomanager.cpp.o[ 15%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/script/katescript.cpp.o[ 15%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/script/kateindentscript.cpp.o[ 15%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/script/katecommandlinescript.cpp.o[ 16%] Building CXX object 

KDE CI: Frameworks ktexteditor kf5-qt5 SUSEQt5.10 - Build # 41 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20SUSEQt5.10/41/
 Project:
Frameworks ktexteditor kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 25 Feb 2018 11:42:16 +
 Build duration:
2 min 1 sec and counting
   CONSOLE OUTPUT
  [...truncated 133.59 KB...]./src/%{APPNAMELC}.json./src/Messages.sh./src/%{APPNAMELC}plugin.h./ktexteditor-plugin.png./README.md[  1%] Built target ktexteditor-plugin[  1%] Built target kauth_ktexteditor_helper_autogen[  1%] actions for org.kde.ktexteditor.katetextbuffer[  1%] Built target org.kde.ktexteditor.katetextbuffer.policy-customtargetScanning dependencies of target kauth_ktexteditor_helper[  1%] Building CXX object src/CMakeFiles/kauth_ktexteditor_helper.dir/buffer/katesecuretextbuffer.cpp.o[  1%] Building CXX object src/CMakeFiles/kauth_ktexteditor_helper.dir/kauth_ktexteditor_helper_autogen/mocs_compilation.cpp.o[  2%] Linking CXX executable ../bin/kauth_ktexteditor_helper[  2%] Built target kauth_ktexteditor_helper[  2%] Built target KF5TextEditor_autogen[  2%] Generating ui_configwidget.h[  2%] Generating ui_textareaappearanceconfigwidget.h[  3%] Generating ui_commandmenueditwidget.h[  3%] Generating ui_commandmenuconfigwidget.h[  3%] Generating ui_bordersappearanceconfigwidget.h[  3%] Generating ui_completionconfigtab.h[  3%] Generating ui_opensaveconfigwidget.h[  4%] Generating ui_filetypeconfigwidget.h[  4%] Generating ui_navigationconfigwidget.h[  4%] Generating ui_indentationconfigwidget.h[  4%] Generating ui_editconfigwidget.h[  5%] Generating ui_opensaveconfigadvwidget.h[  5%] Generating ui_searchbarincremental.h[  5%] Generating ui_completionconfigwidget.h[  5%] Generating ui_searchbarpower.h[  6%] Generating ui_spellcheckbar.h[  6%] Generating ui_spellcheckconfigwidget.h[  6%] Generating ui_howtoimportschema.h[  6%] Generating qrc_script.cpp[  7%] Generating qrc_ktexteditor.cppScanning dependencies of target KF5TextEditor[  8%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextbuffer.cpp.o[  8%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katesecuretextbuffer.cpp.o[  8%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextline.cpp.o[  8%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextblock.cpp.o[  8%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextcursor.cpp.o[  9%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextrange.cpp.o[  9%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetexthistory.cpp.o[  9%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/buffer/katetextfolding.cpp.o[ 10%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katecompletionwidget.cpp.o[ 10%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katecompletionmodel.cpp.o[ 10%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katecompletiontree.cpp.o[ 10%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katecompletionconfig.cpp.o[ 11%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/kateargumenthinttree.cpp.o[ 11%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/kateargumenthintmodel.cpp.o[ 11%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katecompletiondelegate.cpp.o[ 12%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/expandingtree/expandingwidgetmodel.cpp.o[ 12%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/expandingtree/expandingdelegate.cpp.o[ 12%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/expandingtree/expandingtree.cpp.o[ 12%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katewordcompletion.cpp.o[ 13%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/completion/katekeywordcompletion.cpp.o[ 13%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/dialogs/kateconfigpage.cpp.o[ 13%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/dialogs/katedialogs.cpp.o[ 13%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/document/katedocument.cpp.o[ 14%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/document/katebuffer.cpp.o[ 14%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/undo/kateundo.cpp.o[ 14%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/undo/katemodifiedundo.cpp.o[ 15%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/undo/kateundomanager.cpp.o[ 15%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/script/katescript.cpp.o[ 15%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/script/kateindentscript.cpp.o[ 15%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/script/katecommandlinescript.cpp.o[ 16%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/script/katescriptmanager.cpp.o[ 16%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/script/katescriptaction.cpp.o[ 16%] Building CXX object 

D10829: Use DocumentId class

[Alexey Min]

alexeymin added a comment.


  To solve this warning you need to fix DocumentId class, add operator<<() for 
QDebug.
  
  In D10826  add:
  `QDebug operator<<(QDebug stream, const Baloo::DocumentId );` outside 
of baloo namespace, don't forget to `#include ` in header
  
  Implement this operator in .cpp file, eg. `stream << docId.inode() << 
docId.deviceId(); return stream` or whatever, as it is done in 
`src/engine/document.h` line 103

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10829

To: michaelh, adridg, #baloo, #frameworks
Cc: alexeymin, ashaposhnikov, michaelh, kmorwinski, spoorun, nicolasfella

D9211: Iterate over initializer_lists to avoid mem allocs

[Dominik Haumann]

dhaumann closed this revision.
dhaumann added a comment.


  Committed with 
https://cgit.kde.org/ktexteditor.git/commit/?id=ac8f9f61a0d160a04fd46cb7f87b1509987892aa

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D9211

To: dhaumann, mwolff, apol
Cc: ngraham, #frameworks, michaelh, kevinapavew, kmorwinski, demsking, 
cullmann, sars, dhaumann

D9211: Iterate over initializer_lists to avoid mem allocs

[Dominik Haumann]

dhaumann marked 2 inline comments as done.

REPOSITORY
  R39 KTextEditor

BRANCH
  AvoidAllocs (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D9211

To: dhaumann, mwolff, apol
Cc: ngraham, #frameworks, michaelh, kevinapavew, kmorwinski, demsking, 
cullmann, sars, dhaumann

D9211: Iterate over initializer_lists to avoid mem allocs

[Dominik Haumann]

dhaumann marked 8 inline comments as done.
dhaumann added a comment.


  Mark comments as done.

INLINE COMMENTS

> mwolff wrote in katedocument.cpp:109
> you want to return `std::distance(list.begin(), it)` here

Good catch!

REPOSITORY
  R39 KTextEditor

BRANCH
  AvoidAllocs (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D9211

To: dhaumann, mwolff, apol
Cc: ngraham, #frameworks, michaelh, kevinapavew, kmorwinski, demsking, 
cullmann, sars, dhaumann

D10825: Introduce aliases DocId, DeviceId and Inode

[Michael Heidelbach]

michaelh added inline comments.

INLINE COMMENTS

> idutils.h:49
> +return *(reinterpret_cast(arr));
>  }
>  

@alexeymin: This will become

  return DocumentId(devId, inode);

The warning should be gone after that.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10825

To: michaelh, adridg, #baloo, #frameworks
Cc: alexeymin, ashaposhnikov, michaelh, kmorwinski, spoorun, nicolasfella

D10825: Introduce aliases DocId, DeviceId and Inode

[Michael Heidelbach]

michaelh added a comment.


  In D10825#213478 , @alexeymin 
wrote:
  
  > This gives a bunch of warnings like
  >
  >   src/engine/idutils.h:48:43: warning: dereferencing type-punned pointer 
will break strict-aliasing rules [-Wstrict-aliasing]
  >return *(reinterpret-cast(arr));
  >
  > Were these before...?
  
  
  I haven't seen those. I wouldn't have submitted it otherwise. I'll have a 
look, what this means.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10825

To: michaelh, adridg, #baloo, #frameworks
Cc: alexeymin, ashaposhnikov, michaelh, kmorwinski, spoorun, nicolasfella

D10825: Introduce aliases DocId, DeviceId and Inode

[Alexey Min]

alexeymin added a comment.


  This gives a bunch of warnings like
  
src/engine/idutils.h:48:43: warning: dereferencing type-punned pointer will 
break strict-aliasing rules [-Wstrict-aliasing]
return *(reinterpret-cast(arr));
  
  Were these before...?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10825

To: michaelh, adridg, #baloo, #frameworks
Cc: alexeymin, ashaposhnikov, michaelh, kmorwinski, spoorun, nicolasfella

D10437: Update file ioslave's temporary authorization list

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 28009.
chinmoyr retitled this revision from "Revoke authorization of file ioslave 
before it is used by another process" to "Update file ioslave's temporary 
authorization list".
chinmoyr edited the summary of this revision.
chinmoyr added a comment.


  Updated function name.
  Updated title and summary.
  With this it is the third time I am completely changing the title and 
summary. When will it be too much? Or should I create a new patch everytime 
there's a change in approach?

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10437?vs=27483=28009

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10437

AFFECTED FILES
  src/ioslaves/file/file_unix.cpp

To: chinmoyr, #frameworks, dfaure, fvogt
Cc: markg, anthonyfieroni, michaelh, kmorwinski

D10823: idutils: Fix typo

[Michael Heidelbach]

michaelh added a comment.


  In D10823#213409 , @alexeymin 
wrote:
  
  > Maybe such kinds of changes can be committed without review? ;)
  
  
  This is to make @adridg happy. The real fun starts, when you take a look at 
the stack of this.
  
  I need to be sure: `arc land` will push this to the flexible-docid branch?

REPOSITORY
  R293 Baloo

BRANCH
  typo (branched from flexible-docid)

REVISION DETAIL
  https://phabricator.kde.org/D10823

To: michaelh, adridg, #baloo, #frameworks, alexeymin
Cc: alexeymin, ashaposhnikov, michaelh, kmorwinski, spoorun, nicolasfella

D10826: Introduce DocumentId class

[Michael Heidelbach]

michaelh added a dependent revision: D10829: Use DocumentId class.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10826

To: michaelh, adridg, #baloo, #frameworks
Cc: ashaposhnikov, michaelh, kmorwinski, spoorun, nicolasfella, alexeymin

D10829: Use DocumentId class

[Michael Heidelbach]

michaelh edited the summary of this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10829

To: michaelh, adridg, #baloo, #frameworks
Cc: ashaposhnikov, michaelh, kmorwinski, spoorun, nicolasfella, alexeymin

D10829: Use DocumentId class

[Michael Heidelbach]

michaelh added a dependency: D10826: Introduce DocumentId class.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10829

To: michaelh, adridg, #baloo, #frameworks
Cc: ashaposhnikov, michaelh, kmorwinski, spoorun, nicolasfella, alexeymin

D10829: Use DocumentId class

[Michael Heidelbach]

michaelh created this revision.
michaelh added reviewers: adridg, Baloo, Frameworks.
michaelh added a project: Baloo.
Restricted Application added a project: Frameworks.
michaelh requested review of this revision.

TEST PLAN
  library compiles
  test compile produces linker error

REPOSITORY
  R293 Baloo

BRANCH
  use-class (branched from flexible-docid)

REVISION DETAIL
  https://phabricator.kde.org/D10829

AFFECTED FILES
  src/engine/CMakeLists.txt
  src/engine/andpostingiterator.h
  src/engine/document.h
  src/engine/idutils.h
  src/engine/positioninfo.h
  src/engine/postingiterator.h

To: michaelh, adridg, #baloo, #frameworks
Cc: ashaposhnikov, michaelh, kmorwinski, spoorun, nicolasfella, alexeymin

D10826: Introduce DocumentId class

[Michael Heidelbach]

michaelh added a dependency: D10825: Introduce aliases DocId, DeviceId and 
Inode.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10826

To: michaelh, adridg, #baloo, #frameworks
Cc: ashaposhnikov, michaelh, kmorwinski, spoorun, nicolasfella, alexeymin

D10825: Introduce aliases DocId, DeviceId and Inode

[Michael Heidelbach]

michaelh added a dependent revision: D10826: Introduce DocumentId class.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10825

To: michaelh, adridg, #baloo, #frameworks
Cc: ashaposhnikov, michaelh, kmorwinski, spoorun, nicolasfella, alexeymin

D10826: Introduce DocumentId class

[Michael Heidelbach]

michaelh created this revision.
michaelh added reviewers: adridg, Baloo, Frameworks.
michaelh added projects: Baloo, Frameworks.
michaelh requested review of this revision.

REVISION SUMMARY
  This class shall successively replace the current DocId(quint64) to gain more 
flexibility.
  
  - Account for 64bit inodes
  - Port away from stBuf.st_dev which is not always constant
  - Use document ids of variable size
  
  T8054 

TEST PLAN
  make test

REPOSITORY
  R293 Baloo

BRANCH
  flex-class (branched from flexible-docid)

REVISION DETAIL
  https://phabricator.kde.org/D10826

AFFECTED FILES
  src/engine/documentid.cpp
  src/engine/documentid.h

To: michaelh, adridg, #baloo, #frameworks
Cc: ashaposhnikov, michaelh, kmorwinski, spoorun, nicolasfella, alexeymin

D10823: idutils: Fix typo

[Alexey Min]

alexeymin accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  typo (branched from flexible-docid)

REVISION DETAIL
  https://phabricator.kde.org/D10823

To: michaelh, adridg, #baloo, #frameworks, alexeymin
Cc: alexeymin, ashaposhnikov, michaelh, kmorwinski, spoorun, nicolasfella

D10823: idutils: Fix typo

[Alexey Min]

alexeymin added a comment.


  Maybe such kinds of changes can be committed without review? ;)

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10823

To: michaelh, adridg, #baloo, #frameworks
Cc: alexeymin, ashaposhnikov, michaelh, kmorwinski, spoorun, nicolasfella

D10825: Introduce aliases DocId, DeviceId and Inode

[Michael Heidelbach]

michaelh created this revision.
michaelh added reviewers: adridg, Baloo, Frameworks.
michaelh added a project: Baloo.
Restricted Application added a project: Frameworks.
michaelh requested review of this revision.

REVISION SUMMARY
  This is the first step of porting away from using quint64 as Document id
  and turning it into a class.
  
  It is done by find/replace quint64 and adding `#include "idutils.h"` until it 
compiled

TEST PLAN
  make test

REPOSITORY
  R293 Baloo

BRANCH
  aliases (branched from flexible-docid)

REVISION DETAIL
  https://phabricator.kde.org/D10825

AFFECTED FILES
  src/codecs/coding.h
  src/codecs/positioncodec.cpp
  src/codecs/postingcodec.cpp
  src/codecs/postingcodec.h
  src/engine/andpostingiterator.cpp
  src/engine/andpostingiterator.h
  src/engine/document.cpp
  src/engine/document.h
  src/engine/documentdatadb.cpp
  src/engine/documentdatadb.h
  src/engine/documentdb.cpp
  src/engine/documentdb.h
  src/engine/documentiddb.cpp
  src/engine/documentiddb.h
  src/engine/documenttimedb.cpp
  src/engine/documenttimedb.h
  src/engine/documenturldb.cpp
  src/engine/documenturldb.h
  src/engine/idfilenamedb.cpp
  src/engine/idfilenamedb.h
  src/engine/idtreedb.cpp
  src/engine/idtreedb.h
  src/engine/idutils.h
  src/engine/mtimedb.cpp
  src/engine/mtimedb.h
  src/engine/orpostingiterator.cpp
  src/engine/orpostingiterator.h
  src/engine/phraseanditerator.cpp
  src/engine/phraseanditerator.h
  src/engine/positiondb.cpp
  src/engine/positioninfo.h
  src/engine/postingdb.cpp
  src/engine/postingdb.h
  src/engine/postingiterator.cpp
  src/engine/postingiterator.h
  src/engine/transaction.cpp
  src/engine/transaction.h
  src/engine/vectorpositioninfoiterator.cpp
  src/engine/vectorpositioninfoiterator.h
  src/engine/vectorpostingiterator.cpp
  src/engine/vectorpostingiterator.h
  src/engine/writetransaction.cpp
  src/engine/writetransaction.h
  src/file/extractor/app.cpp
  src/file/extractor/app.h
  src/file/extractor/autotests/iohandlertest.cpp
  src/file/extractor/iohandler.cpp
  src/file/extractor/iohandler.h
  src/file/extractor/result.cpp
  src/file/extractor/result.h
  src/file/extractorprocess.cpp
  src/file/extractorprocess.h
  src/file/filecontentindexer.cpp
  src/file/filecontentindexerprovider.cpp
  src/file/filecontentindexerprovider.h
  src/file/indexcleaner.cpp
  src/file/metadatamover.cpp
  src/file/modifiedfileindexer.cpp
  src/file/unindexedfileindexer.cpp
  src/file/unindexedfileiterator.cpp
  src/lib/file.cpp
  src/lib/searchstore.cpp
  src/tools/balooctl/main.cpp
  src/tools/balooctl/statuscommand.cpp
  src/tools/balooshow/main.cpp

To: michaelh, adridg, #baloo, #frameworks
Cc: ashaposhnikov, michaelh, kmorwinski, spoorun, nicolasfella, alexeymin

D10825: Introduce aliases DocId, DeviceId and Inode

[Michael Heidelbach]

michaelh added a dependency: D10823: idutils: Fix typo.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10825

To: michaelh, adridg, #baloo, #frameworks
Cc: ashaposhnikov, michaelh, kmorwinski, spoorun, nicolasfella, alexeymin

D10823: idutils: Fix typo

[Michael Heidelbach]

michaelh added a dependent revision: D10825: Introduce aliases DocId, DeviceId 
and Inode.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10823

To: michaelh, adridg, #baloo, #frameworks
Cc: ashaposhnikov, michaelh, kmorwinski, spoorun, nicolasfella, alexeymin

D10824: Delete IdleSlave having temporary authorization

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
chinmoyr added a reviewer: dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
chinmoyr requested review of this revision.

REVISION SUMMARY
  IdleSlave with temporary authorization can be easily misused. So delete any 
such IdleSlave.
  
  Depends on D10822 

REPOSITORY
  R303 KInit

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10824

AFFECTED FILES
  src/klauncher/klauncher.cpp

To: chinmoyr, dfaure
Cc: #frameworks, michaelh, kmorwinski

D10822: Store temporary authorization status in IdleSlave

[Chinmoy Ranjan Pradhan]

chinmoyr added a dependent revision: D10824: Delete IdleSlave having temporary 
authorization.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10822

To: chinmoyr, dfaure
Cc: #frameworks, michaelh, kmorwinski

D10823: idutils: Fix typo

[Michael Heidelbach]

michaelh added a comment.


  Let's start slowly

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D10823

To: michaelh, adridg, #baloo, #frameworks
Cc: ashaposhnikov, michaelh, kmorwinski, spoorun, nicolasfella, alexeymin

D10823: idutils: Fix typo

[Michael Heidelbach]

michaelh created this revision.
michaelh added reviewers: adridg, Baloo, Frameworks.
michaelh added projects: Baloo, Frameworks.
michaelh requested review of this revision.

REPOSITORY
  R293 Baloo

BRANCH
  typo (branched from flexible-docid)

REVISION DETAIL
  https://phabricator.kde.org/D10823

AFFECTED FILES
  src/engine/idutils.h

To: michaelh, adridg, #baloo, #frameworks
Cc: ashaposhnikov, michaelh, kmorwinski, spoorun, nicolasfella, alexeymin

D10822: Store temporary authorization status in IdleSlave

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
chinmoyr added a reviewer: dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
chinmoyr requested review of this revision.

REVISION SUMMARY
  It will be used by klauncher to decide whether or not to kill the IdleSlave.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10822

AFFECTED FILES
  src/core/idleslave.cpp
  src/core/idleslave.h

To: chinmoyr, dfaure
Cc: #frameworks, michaelh, kmorwinski

D10759: Use QLocale instead of QLocale::system

[Albert Astals Cid]

aacid abandoned this revision.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D10759

To: aacid, apol, ilic
Cc: kossebau, apol, #frameworks, #build_system, michaelh, kmorwinski

D10758: Use QLocale instead of QLocale::system

[Albert Astals Cid]

aacid abandoned this revision.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D10758

To: aacid, apol, ilic
Cc: lueck, #frameworks, michaelh, kmorwinski