KDE CI: Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.9 - Build # 20 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20FreeBSDQt5.9/20/
 Project:
Frameworks kwindowsystem kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 06 Apr 2018 04:33:02 +
 Build duration:
42 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: TestSuite.kwindowsystem-kwindowinfox11testFailed: TestSuite.kwindowsystem-netrootinfotestwm

KDE CI: Frameworks kwindowsystem kf5-qt5 SUSEQt5.9 - Build # 11 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20SUSEQt5.9/11/
 Project:
Frameworks kwindowsystem kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 06 Apr 2018 04:33:02 +
 Build duration:
9 min 45 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.kwindowsystem-kwindowinfox11testFailed: TestSuite.kwindowsystem-netrootinfotestwm
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)79%
(46/58)79%
(46/58)75%
(7167/9602)54%
(4042/7520)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests89%
(16/18)89%
(16/18)96%
(3043/3176)51%
(1716/3359)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src93%
(14/15)93%
(14/15)57%
(794/1395)46%
(340/739)src.platforms.wayland0%
(0/3)0%
(0/3)0%
(0/71)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)71%
(3323/4670)59%
(1983/3366)tests0%
(0/5)0%
(0/5)0%
(0/280)0%
(0/50)

KDE CI: Frameworks kwindowsystem kf5-qt5 SUSEQt5.10 - Build # 24 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20SUSEQt5.10/24/
 Project:
Frameworks kwindowsystem kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 06 Apr 2018 04:33:02 +
 Build duration:
8 min 45 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.kwindowsystem-kwindowinfox11testFailed: TestSuite.kwindowsystem-netrootinfotestwm
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)79%
(46/58)79%
(46/58)75%
(7168/9602)54%
(4042/7520)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests89%
(16/18)89%
(16/18)96%
(3044/3176)51%
(1718/3359)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src93%
(14/15)93%
(14/15)57%
(795/1395)46%
(339/739)src.platforms.wayland0%
(0/3)0%
(0/3)0%
(0/71)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)71%
(3322/4670)59%
(1982/3366)tests0%
(0/5)0%
(0/5)0%
(0/280)0%
(0/50)

D11924: Add "SkipSwitcher" to API

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R278:6178ab9b4006: Add SkipSwitcher to API 
(authored by sharvey, committed by ngraham).

REPOSITORY
  R278 KWindowSystem

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11924?vs=31330=31459

REVISION DETAIL
  https://phabricator.kde.org/D11924

AFFECTED FILES
  autotests/kwindowinfox11test.cpp
  autotests/netwininfotestwm.cpp
  src/kwindowsystem.h
  src/netwm_def.h
  src/platforms/xcb/atoms_p.h
  src/platforms/xcb/netwm.cpp

To: sharvey, hein, graesslin
Cc: ngraham, graesslin, apol, #frameworks, michaelh

D11924: Add "SkipSwitcher" to API

[Nathaniel Graham]

ngraham added a comment.


  Ok, doing it now.

REPOSITORY
  R278 KWindowSystem

BRANCH
  skip-switcher (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11924

To: sharvey, hein, graesslin
Cc: ngraham, graesslin, apol, #frameworks, michaelh

D11924: Add "SkipSwitcher" to API

[Martin Flöser]

graesslin added a comment.


  In D11924#240631 , @ngraham wrote:
  
  > Martin, @sharvey does not yet have commit access. Would you like to land 
this patch for him, or should I?
  
  
  Please push, I probably won't get to it the next two weeks.

REPOSITORY
  R278 KWindowSystem

BRANCH
  skip-switcher (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11924

To: sharvey, hein, graesslin
Cc: ngraham, graesslin, apol, #frameworks, michaelh

KDE CI: Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9 - Build # 96 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20FreeBSDQt5.9/96/
 Project:
Frameworks plasma-framework kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 06 Apr 2018 03:25:06 +
 Build duration:
44 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.plasma-packagestructuretest

KDE CI: Frameworks kconfig kf5-qt5 FreeBSDQt5.9 - Build # 18 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20FreeBSDQt5.9/18/
 Project:
Frameworks kconfig kf5-qt5 FreeBSDQt5.9
 Date of build:
Fri, 06 Apr 2018 03:24:15 +
 Build duration:
35 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 34 test(s), Skipped: 0 test(s), Total: 35 test(s)Failed: TestSuite.kconfigcompiler-basic-test

KDE CI: Frameworks plasma-framework kf5-qt5 SUSEQt5.10 - Build # 121 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20plasma-framework%20kf5-qt5%20SUSEQt5.10/121/
 Project:
Frameworks plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 06 Apr 2018 03:25:06 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: (root) Failed: 7 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-dialogqmltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(55/159)35%
(55/159)26%
(3558/13481)19%
(1978/10637)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests85%
(22/26)85%
(22/26)53%
(609/1140)28%
(421/1492)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/453)0%
(0/241)src.declarativeimports.core22%
(4/18)22%
(4/18)11%
(253/2314)7%
(102/1552)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/525)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma55%
(12/22)55%
(12/22)41%
(1442/3500)28%
(827/2913)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/141)0%
(0/14)src.plasma.private46%
(11/24)46%
(11/24)41%
(671/1622)28%
(318/1121)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)27%
(552/2015)17%
(305/1779)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1177)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%
   

KDE CI: Frameworks kconfig kf5-qt5 SUSEQt5.9 - Build # 9 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20SUSEQt5.9/9/
 Project:
Frameworks kconfig kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 06 Apr 2018 03:24:15 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 35 test(s), Skipped: 0 test(s), Total: 36 test(s)Failed: TestSuite.kconfigcompiler-basic-test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report86%
(6/7)91%
(79/87)91%
(79/87)79%
(6736/8572)56%
(4162/7433)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(23/23)100%
(23/23)99%
(1907/1917)51%
(1276/2492)autotests.kconfig_compiler96%
(25/26)96%
(25/26)97%
(295/305)51%
(129/252)src.core88%
(21/24)88%
(21/24)68%
(2309/3388)54%
(1305/2420)src.gui78%
(7/9)78%
(7/9)61%
(440/716)50%
(164/325)src.kconf_update100%
(2/2)100%
(2/2)72%
(421/588)56%
(285/508)src.kconfig_compiler100%
(1/1)100%
(1/1)86%
(1364/1579)78%
(1003/1290)src.kreadconfig0%
(0/2)0%
(0/2)0%
(0/79)0%
(0/146)

KDE CI: Frameworks kconfig kf5-qt5 SUSEQt5.10 - Build # 28 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20SUSEQt5.10/28/
 Project:
Frameworks kconfig kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 06 Apr 2018 03:24:15 +
 Build duration:
5 min 27 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 35 test(s), Skipped: 0 test(s), Total: 36 test(s)Failed: TestSuite.kconfigcompiler-basic-test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report86%
(6/7)91%
(79/87)91%
(79/87)79%
(6734/8568)56%
(4160/7427)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(23/23)100%
(23/23)99%
(1907/1917)51%
(1276/2492)autotests.kconfig_compiler96%
(25/26)96%
(25/26)97%
(295/305)51%
(129/252)src.core88%
(21/24)88%
(21/24)68%
(2307/3384)54%
(1303/2414)src.gui78%
(7/9)78%
(7/9)61%
(440/716)50%
(164/325)src.kconf_update100%
(2/2)100%
(2/2)72%
(421/588)56%
(285/508)src.kconfig_compiler100%
(1/1)100%
(1/1)86%
(1364/1579)78%
(1003/1290)src.kreadconfig0%
(0/2)0%
(0/2)0%
(0/79)0%
(0/146)

D11452: sanitizer: Improve device listing

[Michael Heidelbach]

michaelh added inline comments.

INLINE COMMENTS

> bruns wrote in databasesanitizer.cpp:251
> You can check if your output goes to a tty or is redirected:
> https://code.qt.io/cgit/qt/qtbase.git/tree/src/corelib/global/qlogging.cpp#n263

Hey, that's an IIFE! Never seen it in C++ before.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11452

To: michaelh, #baloo, #frameworks
Cc: bruns, smithjd, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
alexeymin

D11907: advancedqueryparsertest: Add more tests

[Michael Heidelbach]

michaelh retitled this revision from "advancedqueryparsertest: Add more test" 
to "advancedqueryparsertest: Add more tests".

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11907

To: michaelh, #baloo, bruns
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D11452: sanitizer: Improve device listing

[Michael Heidelbach]

michaelh updated this revision to Diff 31438.
michaelh added a comment.


  - Apply some sugested changes

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11452?vs=30714=31438

BRANCH
  sanitize-devices (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11452

AFFECTED FILES
  src/engine/databasesanitizer.cpp
  src/engine/databasesanitizer.h
  src/engine/fsutils.cpp
  src/engine/fsutils.h
  src/engine/idutils.h
  src/tools/baloodb/main.cpp

To: michaelh, #baloo, #frameworks
Cc: bruns, smithjd, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
alexeymin

D11452: sanitizer: Improve device listing

[Michael Heidelbach]

michaelh added inline comments.

INLINE COMMENTS

> bruns wrote in databasesanitizer.cpp:251
> You can check if your output goes to a tty or is redirected:
> https://code.qt.io/cgit/qt/qtbase.git/tree/src/corelib/global/qlogging.cpp#n263

That's great, thank you. I'll add some color to stdout in another patch.

> bruns wrote in databasesanitizer.cpp:253
> print as hex(major):hex(minor) ?

Good idea was my first thought, but after trying, I must say it does not add 
really much info and makes the output harder to read. 
The decimal is needed, because this function is mainly for selecting a 
`deviceId` to be used with 'clean', 'list' and upcoming 'repair' commands. I'd 
prefer to just print the decimal.

> bruns wrote in fsutils.cpp:111
> Use of Solid would be preferred.

Sure? We would have to add Solid as a dependency for `libKF5BalooEngine.so`. 
`databasesanitizer` currently is experimental not exported by default (You 
cannot see this because I haven't rebase yet.).
I did not use Solid, because I don't know it well and it seemed easier to copy 
and adapt `FSUtils::getDirectoryFileSystem`. I'm not objecting to use Solid 
though.

The true reason for 'fsutils`'s existence is to disable CoW on btrfs. Can Solid 
do that? If so we can drop `fsutils`.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11452

To: michaelh, #baloo, #frameworks
Cc: bruns, smithjd, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
alexeymin

D11452: sanitizer: Improve device listing

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> databasesanitizer.cpp:251
> +// TODO coloring would be nice, but "...|grep '^!'" does not work 
> with it.
> +// out << QStringLiteral("%1").arg(dev.mounted ? "+" : "\033[1;31m!")
> +out << QStringLiteral("%1").arg(dev.mounted ? "+" : "!")

You can check if your output goes to a tty or is redirected:
https://code.qt.io/cgit/qt/qtbase.git/tree/src/corelib/global/qlogging.cpp#n263

> databasesanitizer.cpp:253
> +out << QStringLiteral("%1").arg(dev.mounted ? "+" : "!")
> +<< sep << QStringLiteral("device:%1").arg(dev.id)
> +<< sep << QStringLiteral("indexed-items:%1").arg(dev.items);

print as hex(major):hex(minor) ?

> fsutils.cpp:111
> +
> +const QVector FSUtils::attachedDevices()
> +{

Use of Solid would be preferred.

> fsutils.h:51
> +quint64 id = 0;
> +QString filesystem = QString();
> +QString name = QString();

No need for explicitly calling the default constructor, this is only needed for 
POD types (e.g. quint64).

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11452

To: michaelh, #baloo, #frameworks
Cc: bruns, smithjd, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
alexeymin

D11826: Simplify Term operator&& and ||

[Michael Heidelbach]

michaelh added a comment.


  Oops, accepted it too quickly, forgot about the `failmessage`s.

REPOSITORY
  R293 Baloo

BRANCH
  baloo_term_cleanup

REVISION DETAIL
  https://phabricator.kde.org/D11826

To: bruns, #baloo, michaelh
Cc: michaelh, #frameworks, ashaposhnikov, astippich, spoorun, ngraham, alexeymin

D11826: Simplify Term operator&& and ||

[Michael Heidelbach]

michaelh accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  baloo_term_cleanup

REVISION DETAIL
  https://phabricator.kde.org/D11826

To: bruns, #baloo, michaelh
Cc: michaelh, #frameworks, ashaposhnikov, astippich, spoorun, ngraham, alexeymin

D11907: advancedqueryparsertest: Add more test

[Michael Heidelbach]

michaelh marked 5 inline comments as done.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11907

To: michaelh, #baloo, bruns
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D11907: advancedqueryparsertest: Add more test

[Michael Heidelbach]

michaelh updated this revision to Diff 31428.
michaelh added a comment.


  - Apply suggested changes

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11907?vs=31390=31428

BRANCH
  advancedqueryparsertest (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11907

AFFECTED FILES
  autotests/unit/lib/advancedqueryparsertest.cpp

To: michaelh, #baloo, bruns
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D11826: Simplify Term operator&& and ||

[Stefan Brüns]

bruns added a dependency: D11907: advancedqueryparsertest: Add more test.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11826

To: bruns, #baloo
Cc: michaelh, #frameworks, ashaposhnikov, astippich, spoorun, ngraham, alexeymin

D11907: advancedqueryparsertest: Add more test

[Stefan Brüns]

bruns added a dependent revision: D11826: Simplify Term operator&& and ||.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11907

To: michaelh, #baloo, bruns
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D11753: baloodb: Add clean command

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> michaelh wrote in databasesanitizer.cpp:333
> 8 meanings of MOOD acronym or abbreviation.
> MOOD stands for
> 
>   Magic of Ordinary Days
>   Meet only Original Designs
>   Michigan Out of Doors
>   Movie Organizer Online Database
>   Miata Owners on Delmarva
>   Methodology for Object Oriented Design
>   Metrics for Object Oriented Design
>   Museum of Outstanding Design
>
> 
> typo? :-)

s/mood/moot/

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11753

To: michaelh, #baloo, #frameworks
Cc: bruns, cfeck, smithjd, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, alexeymin

D11907: advancedqueryparsertest: Add more test

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> advancedqueryparsertest.cpp:235
> +<< Term{Term::And, QList{
> +Term{QStringLiteral(""), QStringLiteral("a"), Term::Contains},
> +Term{QStringLiteral(""), QStringLiteral("b"), Term::Contains},

`Term{QString(), QStringLiteral("a"), Term::Contains},`

see http://blog.qt.io/blog/2014/06/13/qt-weekly-13-qstringliteral/

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11907

To: michaelh, #baloo, bruns
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D11907: advancedqueryparsertest: Add more test

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> michaelh wrote in advancedqueryparsertest.cpp:255
> What about this one? Drop it?

I think it should stay as it exercises the stack in the query parser

Pseudocode:

  s[0] = a, AND
  s[1] = b, AND
  t = construct (c AND d)
  t = Term( s[1].term, t, s[1].op)  
  t = Term( s[0].term, t, s[0].op)

> advancedqueryparsertest.cpp:290
> +// a && b && c && d can be combined into one AND term with 4 subterms
> +QTest::addRow("&&")
> +<< (Term{QStringLiteral(""), QStringLiteral("a"), Term::Contains}

Use "a && b && c && d", makes grepping in case of failure easier?

> advancedqueryparsertest.cpp:305
> +// (a AND b) AND (c OR d) can be merged as (a AND b AND (c OR D)
> +QTest::addRow("(&&) AND (||)")
> +<< ((Term{QStringLiteral(""), QStringLiteral("a"), Term::Contains}

dito, "(a && b) && (c || d)"

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11907

To: michaelh, #baloo, bruns
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D5971: Expose the symbolic 22px kde icon by moving it to kde-symbolic and symlinking to it

[Chris Holland]

Zren added a reviewer: Breeze.
Zren added a comment.


  Forgot to add reviewers.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D5971

To: Zren, #breeze
Cc: #frameworks, michaelh, ngraham

D11948: [KFileWidget] Hardcode example user name

[Elvis Angelaccio]

elvisangelaccio added a comment.


  +1

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11948

To: broulik, #frameworks
Cc: elvisangelaccio, michaelh, ngraham

D11924: Add "SkipSwitcher" to API

[Nathaniel Graham]

ngraham added a comment.


  Martin, @sharvey does not yet have commit access. Would you like to land this 
patch for him, or should I?

REPOSITORY
  R278 KWindowSystem

BRANCH
  skip-switcher (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11924

To: sharvey, hein, graesslin
Cc: ngraham, graesslin, apol, #frameworks, michaelh

D11960: Support nvidia reset notifications in QtQuickViews

[David Edmundson]

davidedmundson updated this revision to Diff 31400.
davidedmundson added a comment.


  Shorter version

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11960?vs=31399=31400

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11960

AFFECTED FILES
  src/quickaddons/qtquicksettings.cpp

To: davidedmundson, #plasma, hein
Cc: #frameworks, michaelh, ngraham

D11960: Support nvidia reset notifications in QtQuickViews

[Eike Hein]

hein accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R296 KDeclarative

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11960

To: davidedmundson, #plasma, hein
Cc: #frameworks, michaelh, ngraham

D11960: Support nvidia reset notifications in QtQuickViews

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
davidedmundson requested review of this revision.

REVISION SUMMARY
  In line with changes in Qt, we support 
  GL_PURGED_CONTEXT_RESET_NV. On a graphical error
  we recreate entire QtQuick scene contexts.
  
  It can break custom render loops, so the change
  is opt-in. This flag enables it for all plasma windows.

TEST PLAN
  Suspended PC, resume.
  Icons on desktop are not garbled pernamently.
  Unpatched kwin with Aurorae does not busy-loop forever.

REPOSITORY
  R296 KDeclarative

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11960

AFFECTED FILES
  src/quickaddons/qtquicksettings.cpp

To: davidedmundson, #plasma
Cc: #frameworks, michaelh, ngraham

D11753: baloodb: Add clean command

[Michael Heidelbach]

michaelh added inline comments.

INLINE COMMENTS

> bruns wrote in databasesanitizer.cpp:333
> Fair reason, the comment below is also mood then ...

8 meanings of MOOD acronym or abbreviation.
MOOD stands for

  Magic of Ordinary Days
  Meet only Original Designs
  Michigan Out of Doors
  Movie Organizer Online Database
  Miata Owners on Delmarva
  Methodology for Object Oriented Design
  Metrics for Object Oriented Design
  Museum of Outstanding Design
   

typo? :-)

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11753

To: michaelh, #baloo, #frameworks
Cc: bruns, cfeck, smithjd, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, alexeymin

D11907: advancedqueryparsertest: Add more test

[Michael Heidelbach]

michaelh added inline comments.

INLINE COMMENTS

> advancedqueryparsertest.cpp:255
> +;
> +searchInput = QStringLiteral("(a AND (b AND (c AND d)))");
> +QTest::newRow(qPrintable(searchInput))

What about this one? Drop it?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11907

To: michaelh, #baloo, bruns
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D11907: advancedqueryparsertest: Add more test

[Michael Heidelbach]

michaelh updated this revision to Diff 31390.
michaelh added a comment.


  - Remove duplicated data again

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11907?vs=31381=31390

BRANCH
  advancedqueryparsertest (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11907

AFFECTED FILES
  autotests/unit/lib/advancedqueryparsertest.cpp

To: michaelh, #baloo, bruns
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D11907: advancedqueryparsertest: Add more test

[Michael Heidelbach]

michaelh added a comment.


  With this D11826  makes a difference. In 
terms of comprehension I'm also almost there.
  `testNestedParentheses` still has some value as it tests nested parentheses 
more extensively than the one already there.
  
  Unless you have more comments, I suggest to land these tests before D11826 
, rebase  D11826 
 and change the respective `failmessage`s 
to an empty string.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11907

To: michaelh, #baloo, bruns
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D11826: Simplify Term operator&& and ||

[Michael Heidelbach]

michaelh added a comment.


  Regard this as accepted, but please see D11907 
 for landing sequence.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11826

To: bruns, #baloo
Cc: michaelh, #frameworks, ashaposhnikov, astippich, spoorun, ngraham, alexeymin

D11907: advancedqueryparsertest: Add more test

[Michael Heidelbach]

michaelh updated this revision to Diff 31381.
michaelh added a comment.


  - Add (a AND b) AND (c OR d) can be merged as (a AND b AND (c OR D)

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11907?vs=31375=31381

BRANCH
  advancedqueryparsertest (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11907

AFFECTED FILES
  autotests/unit/lib/advancedqueryparsertest.cpp

To: michaelh, #baloo, bruns
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D10937: Retouching of Screen Layout Selection OSD Icons

[Phil Stefan]

pstefan updated this revision to Diff 31376.

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10937?vs=28315=31376

REVISION DETAIL
  https://phabricator.kde.org/D10937

AFFECTED FILES
  icons-dark/applets/128/osd-duplicate.svg
  icons-dark/applets/128/osd-rotate-ccw.svg
  icons-dark/applets/128/osd-rotate-cw.svg
  icons-dark/applets/128/osd-rotate-flip.svg
  icons-dark/applets/128/osd-rotate-normal.svg
  icons-dark/applets/128/osd-sbs-left.svg
  icons-dark/applets/128/osd-sbs-sright.svg
  icons-dark/applets/128/osd-shutd-laptop.svg
  icons-dark/applets/128/osd-shutd-screen.svg
  icons-dark/applets/256/osd-duplicate.svg
  icons-dark/applets/256/osd-rotate-ccw.svg
  icons-dark/applets/256/osd-rotate-cw.svg
  icons-dark/applets/256/osd-rotate-flip.svg
  icons-dark/applets/256/osd-rotate-normal.svg
  icons-dark/applets/256/osd-sbs-left.svg
  icons-dark/applets/256/osd-sbs-sright.svg
  icons-dark/applets/256/osd-shutd-laptop.svg
  icons-dark/applets/256/osd-shutd-screen.svg
  icons-dark/applets/32/osd-duplicate.svg
  icons-dark/applets/32/osd-rotate-ccw.svg
  icons-dark/applets/32/osd-rotate-cw.svg
  icons-dark/applets/32/osd-rotate-flip.svg
  icons-dark/applets/32/osd-rotate-normal.svg
  icons-dark/applets/32/osd-sbs-left.svg
  icons-dark/applets/32/osd-sbs-sright.svg
  icons-dark/applets/32/osd-shutd-laptop.svg
  icons-dark/applets/32/osd-shutd-screen.svg
  icons-dark/applets/48/osd-duplicate.svg
  icons-dark/applets/48/osd-rotate-ccw.svg
  icons-dark/applets/48/osd-rotate-cw.svg
  icons-dark/applets/48/osd-rotate-flip.svg
  icons-dark/applets/48/osd-rotate-normal.svg
  icons-dark/applets/48/osd-sbs-left.svg
  icons-dark/applets/48/osd-sbs-sright.svg
  icons-dark/applets/48/osd-shutd-laptop.svg
  icons-dark/applets/48/osd-shutd-screen.svg
  icons-dark/applets/64/osd-duplicate.svg
  icons-dark/applets/64/osd-rotate-ccw.svg
  icons-dark/applets/64/osd-rotate-cw.svg
  icons-dark/applets/64/osd-rotate-flip.svg
  icons-dark/applets/64/osd-rotate-normal.svg
  icons-dark/applets/64/osd-sbs-left.svg
  icons-dark/applets/64/osd-sbs-sright.svg
  icons-dark/applets/64/osd-shutd-laptop.svg
  icons-dark/applets/64/osd-shutd-screen.svg
  icons/applets/128/osd-duplicate.svg
  icons/applets/128/osd-rotate-ccw.svg
  icons/applets/128/osd-rotate-cw.svg
  icons/applets/128/osd-rotate-flip.svg
  icons/applets/128/osd-rotate-normal.svg
  icons/applets/128/osd-sbs-left.svg
  icons/applets/128/osd-sbs-sright.svg
  icons/applets/128/osd-shutd-laptop.svg
  icons/applets/128/osd-shutd-screen.svg
  icons/applets/256/osd-duplicate.svg
  icons/applets/256/osd-rotate-ccw.svg
  icons/applets/256/osd-rotate-cw.svg
  icons/applets/256/osd-rotate-flip.svg
  icons/applets/256/osd-rotate-normal.svg
  icons/applets/256/osd-sbs-left.svg
  icons/applets/256/osd-sbs-sright.svg
  icons/applets/256/osd-shutd-laptop.svg
  icons/applets/256/osd-shutd-screen.svg
  icons/applets/32/osd-duplicate.svg
  icons/applets/32/osd-rotate-ccw.svg
  icons/applets/32/osd-rotate-cw.svg
  icons/applets/32/osd-rotate-flip.svg
  icons/applets/32/osd-rotate-normal.svg
  icons/applets/32/osd-sbs-left.svg
  icons/applets/32/osd-sbs-sright.svg
  icons/applets/32/osd-shutd-laptop.svg
  icons/applets/32/osd-shutd-screen.svg
  icons/applets/48/osd-duplicate.svg
  icons/applets/48/osd-rotate-ccw.svg
  icons/applets/48/osd-rotate-cw.svg
  icons/applets/48/osd-rotate-flip.svg
  icons/applets/48/osd-rotate-normal.svg
  icons/applets/48/osd-sbs-left.svg
  icons/applets/48/osd-sbs-sright.svg
  icons/applets/48/osd-shutd-laptop.svg
  icons/applets/48/osd-shutd-screen.svg
  icons/applets/64/osd-duplicate.svg
  icons/applets/64/osd-rotate-ccw.svg
  icons/applets/64/osd-rotate-cw.svg
  icons/applets/64/osd-rotate-flip.svg
  icons/applets/64/osd-rotate-normal.svg
  icons/applets/64/osd-sbs-left.svg
  icons/applets/64/osd-sbs-sright.svg
  icons/applets/64/osd-shutd-laptop.svg
  icons/applets/64/osd-shutd-screen.svg

To: pstefan, #breeze, ngraham
Cc: emateli, abetts, mart, ngraham, #frameworks, davidc, michaelh, crozbo, 
firef, alexeymin, skadinna, aaronhoneycutt, mbohlender

D11907: advancedqueryparsertest: Add more test

[Michael Heidelbach]

michaelh updated this revision to Diff 31375.
michaelh added a comment.


  - Remove duplicated data

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11907?vs=31373=31375

BRANCH
  advancedqueryparsertest (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11907

AFFECTED FILES
  autotests/unit/lib/advancedqueryparsertest.cpp

To: michaelh, #baloo, bruns
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D11907: advancedqueryparsertest: Add more test

[Michael Heidelbach]

michaelh retitled this revision from "advancedqueryparsertest: Add optimization 
test" to "advancedqueryparsertest: Add more test".

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11907

To: michaelh, #baloo, bruns
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D11907: advancedqueryparsertest: Add optimization test

[Michael Heidelbach]

michaelh updated this revision to Diff 31373.
michaelh added a comment.


  - Rename testOptimizedLogic
  - Add a different testOptimizedLogic

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11907?vs=31230=31373

BRANCH
  advancedqueryparsertest (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11907

AFFECTED FILES
  autotests/unit/lib/advancedqueryparsertest.cpp

To: michaelh, #baloo, bruns
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

KDE CI: Frameworks ktexteditor kf5-qt5 FreeBSDQt5.9 - Build # 47 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20FreeBSDQt5.9/47/
 Project:
Frameworks ktexteditor kf5-qt5 FreeBSDQt5.9
 Date of build:
Thu, 05 Apr 2018 10:26:45 +
 Build duration:
14 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 65 test(s), Skipped: 0 test(s), Total: 66 test(s)Failed: TestSuite.completion_test

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 185 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/185/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.9
 Date of build:
Thu, 05 Apr 2018 10:29:47 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 54 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-privilegejobtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiofilewidgets-kfileplacesviewtest

KDE CI: Frameworks kinit kf5-qt5 SUSEQt5.9 - Build # 10 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kinit%20kf5-qt5%20SUSEQt5.9/10/
 Project:
Frameworks kinit kf5-qt5 SUSEQt5.9
 Date of build:
Thu, 05 Apr 2018 10:30:01 +
 Build duration:
2 min 34 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(2/3)70%
(7/10)70%
(7/10)24%
(488/2016)14%
(193/1395)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalssrc0%
(0/2)0%
(0/2)0%
(0/294)0%
(0/157)src.kdeinit100%
(3/3)100%
(3/3)43%
(415/957)29%
(174/608)src.klauncher80%
(4/5)80%
(4/5)10%
(73/765)3%
(19/630)

D11941: Make it possible for KTextEditor to build on Android NDK's gcc 4.9

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:d1660b637918: Make it possible for KTextEditor to build on 
Android NDKs gcc 4.9 (authored by apol).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11941?vs=31347=31367

REVISION DETAIL
  https://phabricator.kde.org/D11941

AFFECTED FILES
  src/buffer/katesecuretextbuffer.cpp
  src/document/katedocument.cpp

To: apol, #frameworks, cullmann
Cc: cullmann, michaelh, kevinapavew, ngraham, demsking, sars, dhaumann

D11888: Handle adjacent special characters correctly

[Michael Heidelbach]

michaelh added a comment.


  Apart from `QLatin1Char` and `token.isEmpty()` we're done, I think.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11888

To: bruns, #baloo, michaelh
Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D11745: databasesanitizer: Use flags for filtering

[Michael Heidelbach]

michaelh updated this revision to Diff 31365.
michaelh added a comment.


  - Correct typo(?)

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11745?vs=30716=31365

BRANCH
  sanitize-enums (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11745

AFFECTED FILES
  src/engine/databasesanitizer.cpp
  src/engine/databasesanitizer.h
  src/tools/baloodb/main.cpp

To: michaelh, #baloo, #frameworks
Cc: bruns, ngraham, smithjd, ashaposhnikov, michaelh, astippich, spoorun, 
alexeymin

D11948: [KFileWidget] Hardcode example user name

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
broulik requested review of this revision.

REVISION SUMMARY
  Don't create `KUser()` instance just for an example text in "What's This" 
mode.
  When logged in via LDAP this can create quite some delay until the dialog 
opens.

TEST PLAN
  Dialog opens quicker now, even on local login it spends 1ms in there for no 
real gain.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D11948

AFFECTED FILES
  src/filewidgets/kfilewidget.cpp

To: broulik, #frameworks
Cc: michaelh, ngraham

D11945: Optimize AppArmor & SELinux highlighting and improve regex

[Nibaldo González]

nibags added a reviewer: dhaumann.
nibags added a project: Framework: Syntax Highlighting.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D11945

To: nibags, dhaumann
Cc: #frameworks, michaelh, genethomas, ngraham, cullmann, vkrause, dhaumann

D11745: databasesanitizer: Use flags for filtering

[Michael Heidelbach]

michaelh added inline comments.

INLINE COMMENTS

> bruns wrote in databasesanitizer.h:41
> Is this correct? IgnoreMounted = (1 << 1) = 2 == IgnoreUnavailable?

That's a sneaky question! :-)

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11745

To: michaelh, #baloo, #frameworks
Cc: bruns, ngraham, smithjd, ashaposhnikov, michaelh, astippich, spoorun, 
alexeymin

D11945: Optimize AppArmor & SELinux highlighting and improve regex

[Nibaldo González]

nibags created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
nibags requested review of this revision.

REVISION SUMMARY
  Some optimizations are made (some suggested from D10621 
) and other improvements, such as:
  
  AppArmor:
  
  - Add the profile flag 'xattrs' keyword (for future versions of AppArmor).
  - Allow any character as escape.
  - Improvements in the Boolean assignment (for future versions of AppArmor).
  
  SELinux:
  
  - Improvements in the highlighting of Regex.

TEST PLAN
  Changes were tested

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  opt-apparmor-selinux (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11945

AFFECTED FILES
  autotests/html/usr.bin.apparmor-profile-test.html
  autotests/reference/test.cil.ref
  autotests/reference/test.fc.ref
  autotests/reference/usr.bin.apparmor-profile-test.ref
  data/syntax/apparmor.xml
  data/syntax/selinux-cil.xml
  data/syntax/selinux-fc.xml

To: nibags
Cc: #frameworks, michaelh, ngraham