D12854: Awk: fix regex in a function and update syntax for gawk

[jonathan poelen]

jpoelen updated this revision to Diff 34098.
jpoelen added a comment.


  - Awk: add collating symbols and equivalence classes

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12854?vs=34076=34098

BRANCH
  awk

REVISION DETAIL
  https://phabricator.kde.org/D12854

AFFECTED FILES
  autotests/folding/highlight.awk.fold
  autotests/html/highlight.awk.html
  autotests/input/highlight.awk
  autotests/reference/highlight.awk.ref
  data/syntax/awk.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann
Cc: kde-frameworks-devel, michaelh, genethomas, ngraham, bruns, cullmann, 
vkrause, dhaumann

D12860: DoxygenLua: fix closing comment blocks

[jonathan poelen]

jpoelen edited the test plan for this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D12860

To: jpoelen, #framework_syntax_highlighting, dhaumann
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12860: DoxygenLua: fix closing comment blocks

[jonathan poelen]

jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D12860

To: jpoelen, #framework_syntax_highlighting, dhaumann
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12860: DoxygenLua: fix closing comment blocks

[jonathan poelen]

jpoelen created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
jpoelen requested review of this revision.

REVISION SUMMARY
  Kate-editor needs the context to be marked dynamic to use a placeholder in a 
dynamic rule.
  
  BUG: 394184

TEST PLAN
  Open Kate with the code lua below:
  
[[
commented out
]]
local test
  
  An equivalent is already in autotests/input/highlight.lua

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  luafix

REVISION DETAIL
  https://phabricator.kde.org/D12860

AFFECTED FILES
  data/syntax/doxygenlua.xml

To: jpoelen
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12858: [KCharSelect] Fix table cell width

[Christoph Feck]

cfeck created this revision.
cfeck added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
cfeck requested review of this revision.

REVISION SUMMARY
  Qt 5.11 now respects minimumSectionWidth (QTBUG-68239).
  
  Without this property set, the table cells end up wider than requested.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D12858

AFFECTED FILES
  src/kcharselect.cpp

To: cfeck, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12392: Fix the "Default" color scheme to match Breeze again

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R265:ebdb8424cd12: Fix the Default color scheme to 
match Breeze again (authored by ngraham).

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12392?vs=32683=34085

REVISION DETAIL
  https://phabricator.kde.org/D12392

AFFECTED FILES
  src/kcolorscheme.cpp

To: ngraham, #breeze, #plasma, hein
Cc: kde-frameworks-devel, cfeck, abetts, michaelh, ngraham, bruns

D12392: Fix the "Default" color scheme to match Breeze again

[Nathaniel Graham]

ngraham added a comment.


  Thanks! I didn't find anything in kdelibs or the color KCM code, actually. 
The Colors KCM has several other color schemes listed in there, but not a copy 
of Breeze.

REPOSITORY
  R265 KConfigWidgets

BRANCH
  fix-default-color-scheme (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12392

To: ngraham, #breeze, #plasma, hein
Cc: kde-frameworks-devel, cfeck, abetts, michaelh, ngraham, bruns

D12689: Lua: updated for Lua5.3

[jonathan poelen]

jpoelen added a comment.


  There is indeed a problem with Kate, but it works with KSyntaxHighlighting. I 
will look in what part of doxygenlua.xml the problem is.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D12689

To: jpoelen, dhaumann, #framework_syntax_highlighting
Cc: kde-frameworks-devel, michaelh, genethomas, ngraham, bruns, cullmann, 
vkrause, dhaumann

D12854: Awk: fix regex in a function and update syntax for gawk

[jonathan poelen]

jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D12854

To: jpoelen, #framework_syntax_highlighting, dhaumann
Cc: kde-frameworks-devel, michaelh, genethomas, ngraham, bruns, cullmann, 
vkrause, dhaumann

D12854: Awk: fix regex in a function and update syntax for gawk

[jonathan poelen]

jpoelen created this revision.
jpoelen added a project: Framework: Syntax Highlighting.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
jpoelen requested review of this revision.

REVISION SUMMARY
  - fix `match(str, /it's a regex, not an operator and normal text/)`
  - fix escaped characters
  - add `Symbol`, `Separator Symbol` and `Control Flow` style
  - add some functions and keywords.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  awk

REVISION DETAIL
  https://phabricator.kde.org/D12854

AFFECTED FILES
  autotests/folding/highlight.awk.fold
  autotests/html/highlight.awk.html
  autotests/input/highlight.awk
  autotests/reference/highlight.awk.ref
  data/syntax/awk.xml

To: jpoelen
Cc: kde-frameworks-devel, michaelh, genethomas, ngraham, bruns, cullmann, 
vkrause, dhaumann

D12787: Ignore more types of source files

[Nathaniel Graham]

ngraham added reviewers: michaelh, bruns.
ngraham added a comment.


  Friendly ping!

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D12787

To: ngraham, michaelh, bruns
Cc: cfeck, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns

D12130: Use the more user-friendly string "File type" in the save dialogs

[Henrik Fehlauer]

rkflx added a comment.
Restricted Application added a subscriber: kde-frameworks-devel.


  In D12130#250478 , @ngraham wrote:
  
  > Yes, and I did more investigation myself, and all the glue is in 
plasma-integration. Some changes might be needed there too (or maybe //all// 
the changes will be needed there, we'll see!)
  
  
  Are you sure about the relation to `plasma-integration`? To me it seems that 
the widget can also be used standalone. Also, in KDE4 `plasma-integration` was 
not even there, yet the string was shown in the UI, and different types of 
dialogs were possible. My guess would be that this can be solved entirely in 
`KIO`, perhaps by following code paths relating to `selectMimeTypeFilter`.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12130

To: ngraham, #frameworks, #vdg, bruns, alexeymin, rkflx, abetts
Cc: kde-frameworks-devel, safaalfulaij, davidc, ltoscano, cfeck, rkflx, 
alexeymin, abetts, bruns, michaelh, ngraham

D12848: Set fix steps for icon sizes

[Henrik Fehlauer]

rkflx added a comment.


  As mentioned in the task:
  
  In T8552#139581 , @rkflx wrote:
  
  > > In T8552#139578 , @anemeth 
wrote:
  > > 
  > >> Could we have the same icon zoom slider as in Dolphin?
  > >>
  > >> - Predefined sizes only, no arbitary icon sizes
  >
  > Hm, OTOH if we keep the buttons, having predefined sizes in the slider is 
not needed anymore… Better keep the fine-grained control for those that want 
and need it. Removing that could be disliked by some.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12848

To: anemeth, #frameworks, #vdg
Cc: rkflx, ngraham, kde-frameworks-devel, michaelh, bruns

Re: kfilemetadata compile failure

[Matthieu Gallien]

On dimanche 13 mai 2018 23:03:02 CEST Albert Astals Cid wrote:
> El divendres, 11 de maig de 2018, a les 23:22:15 CEST, Jonathan Riddell va
> 
> escriure:
> > On Thu, Apr 26, 2018 at 08:31:46AM +0200, Kevin Funk wrote:
> > > On Wednesday, 25 April 2018 14:34:58 CEST Jonathan Riddell wrote:
> > > > kfilemetadata does not compile in KDE neon from git master currently
> > > > 
> > > > /workspace/build/src/extractors/ffmpegextractor.cpp:97:15: error:
> > > > ‘AVCodecParameters’ does not name a type
> > > > 12:27:35  const AVCodecParameters* codec = stream->codecpar;
> > > > 
> > > > https://build.neon.kde.org/job/xenial_unstable_kde_kfilemetadata_bin_a
> > > > md
> > > > 64/1 45/console
> > > 
> > > Raised a concern on the resp. Phab Diff (to ping the responsible 
people):
> > >   https://phabricator.kde.org/R286:037208a787e0c2412ab616ff1573c323a2346
> > >   d2
> > >   d
> 
> If phabricator had worked i would have read that.
> 
> > This compile failure is still in the shortly to be released kfilemetadata
> > tar
> > 
> > https://build.neon.kde.org/job/xenial_release_kde_kfilemetadata_bin_amd64/
> > 37 /console 14:11:40
> > /workspace/build/src/extractors/ffmpegextractor.cpp:97:15: error:
> > ‘AVCodecParameters’ does not name a type 14:11:40  const
> > AVCodecParameters* codec = stream->codecpar;
> 
> your avcodec is too old, get a new one.
> 
> But yes, either the commit should be reverted or the the avcodec cmake
> requirement increased.

Sorry, I have completely forgotten to check that during the review. This is my 
fault.
What is the best way to revert for the v5.46.0 release and bump the dependency 
on master ?

> Cheers,
>   Albert
> 
> > Jonathan

KDE CI: Frameworks kfilemetadata kf5-qt5 FreeBSDQt5.10 - Build # 7 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kfilemetadata%20kf5-qt5%20FreeBSDQt5.10/7/
 Project:
Frameworks kfilemetadata kf5-qt5 FreeBSDQt5.10
 Date of build:
Sun, 13 May 2018 21:22:44 +
 Build duration:
1 min 7 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 12 test(s)

Re: kfilemetadata compile failure

[Albert Astals Cid]

El divendres, 11 de maig de 2018, a les 23:22:15 CEST, Jonathan Riddell va 
escriure:
> On Thu, Apr 26, 2018 at 08:31:46AM +0200, Kevin Funk wrote:
> > On Wednesday, 25 April 2018 14:34:58 CEST Jonathan Riddell wrote:
> > > kfilemetadata does not compile in KDE neon from git master currently
> > > 
> > > /workspace/build/src/extractors/ffmpegextractor.cpp:97:15: error:
> > > ‘AVCodecParameters’ does not name a type
> > > 12:27:35  const AVCodecParameters* codec = stream->codecpar;
> > > 
> > > https://build.neon.kde.org/job/xenial_unstable_kde_kfilemetadata_bin_amd
> > > 64/1 45/console
> > 
> > Raised a concern on the resp. Phab Diff (to ping the responsible people):
> >   https://phabricator.kde.org/R286:037208a787e0c2412ab616ff1573c323a2346d2
> >   d

If phabricator had worked i would have read that.

> 
> This compile failure is still in the shortly to be released kfilemetadata
> tar
> 
> https://build.neon.kde.org/job/xenial_release_kde_kfilemetadata_bin_amd64/37
> /console 14:11:40 /workspace/build/src/extractors/ffmpegextractor.cpp:97:15:
> error: ‘AVCodecParameters’ does not name a type 14:11:40  const
> AVCodecParameters* codec = stream->codecpar;

your avcodec is too old, get a new one.

But yes, either the commit should be reverted or the the avcodec cmake 
requirement increased.

Cheers,
  Albert

> 
> Jonathan

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 - Build # 44 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/44/
 Project:
Frameworks kdelibs4support kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 13 May 2018 20:04:19 +
 Build duration:
8 min 38 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.ktabwidget_unittest

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.10 - Build # 4 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.10/4/
 Project:
Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.10
 Date of build:
Sun, 13 May 2018 20:04:19 +
 Build duration:
7 min 42 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kstandarddirstest

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.9 - Build # 17 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.9/17/
 Project:
Frameworks kdelibs4support kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 13 May 2018 20:04:19 +
 Build duration:
3 min 32 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.ktabwidget_unittest

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 83 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/83/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 13 May 2018 18:56:53 +
 Build duration:
8 min 19 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 28 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/28/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 13 May 2018 18:56:53 +
 Build duration:
3 min 6 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10 - Build # 6 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.10/6/
 Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10
 Date of build:
Sun, 13 May 2018 18:56:54 +
 Build duration:
2 min 57 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 20 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kdirwatch_stat_unittest

KDE CI: Frameworks kconfig kf5-qt5 SUSEQt5.10 - Build # 36 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20SUSEQt5.10/36/
 Project:
Frameworks kconfig kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 13 May 2018 18:31:38 +
 Build duration:
6 min 30 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 35 test(s), Skipped: 0 test(s), Total: 36 test(s)Failed: TestSuite.kconfigcompiler-basic-test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report86%
(6/7)91%
(79/87)91%
(79/87)79%
(6734/8570)56%
(4160/7431)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(23/23)100%
(23/23)99%
(1907/1917)51%
(1276/2492)autotests.kconfig_compiler96%
(25/26)96%
(25/26)97%
(295/305)51%
(129/252)src.core88%
(21/24)88%
(21/24)68%
(2307/3386)54%
(1303/2418)src.gui78%
(7/9)78%
(7/9)61%
(440/716)50%
(164/325)src.kconf_update100%
(2/2)100%
(2/2)72%
(421/588)56%
(285/508)src.kconfig_compiler100%
(1/1)100%
(1/1)86%
(1364/1579)78%
(1003/1290)src.kreadconfig0%
(0/2)0%
(0/2)0%
(0/79)0%
(0/146)

KDE CI: Frameworks kconfig kf5-qt5 FreeBSDQt5.10 - Build # 6 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20FreeBSDQt5.10/6/
 Project:
Frameworks kconfig kf5-qt5 FreeBSDQt5.10
 Date of build:
Sun, 13 May 2018 18:31:38 +
 Build duration:
2 min 20 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 34 test(s), Skipped: 0 test(s), Total: 35 test(s)Failed: TestSuite.kconfigcompiler-basic-test

KDE CI: Frameworks kconfig kf5-qt5 SUSEQt5.9 - Build # 18 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20SUSEQt5.9/18/
 Project:
Frameworks kconfig kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 13 May 2018 18:31:38 +
 Build duration:
1 min 37 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 35 test(s), Skipped: 0 test(s), Total: 36 test(s)Failed: TestSuite.kconfigcompiler-basic-test
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report86%
(6/7)91%
(79/87)91%
(79/87)79%
(6736/8572)56%
(4161/7433)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(23/23)100%
(23/23)99%
(1907/1917)51%
(1276/2492)autotests.kconfig_compiler96%
(25/26)96%
(25/26)97%
(295/305)51%
(129/252)src.core88%
(21/24)88%
(21/24)68%
(2309/3388)54%
(1304/2420)src.gui78%
(7/9)78%
(7/9)61%
(440/716)50%
(164/325)src.kconf_update100%
(2/2)100%
(2/2)72%
(421/588)56%
(285/508)src.kconfig_compiler100%
(1/1)100%
(1/1)86%
(1364/1579)78%
(1003/1290)src.kreadconfig0%
(0/2)0%
(0/2)0%
(0/79)0%
(0/146)

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.9 - Build # 29 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.9/29/
 Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 13 May 2018 15:57:38 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)78%
(239/306)57%
(143/252)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)54%
(15/28)autotests100%
(5/5)100%
(5/5)79%
(197/249)57%
(128/224)

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.10 - Build # 5 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.10/5/
 Project:
Frameworks breeze-icons kf5-qt5 FreeBSDQt5.10
 Date of build:
Sun, 13 May 2018 15:57:38 +
 Build duration:
1 min 14 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: TestSuite.scalable

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 85 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/85/
 Project:
Frameworks breeze-icons kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 13 May 2018 15:57:38 +
 Build duration:
1 min 35 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)78%
(239/306)57%
(143/252)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)54%
(15/28)autotests100%
(5/5)100%
(5/5)79%
(197/249)57%
(128/224)

D12848: Set fix steps for icon sizes

[Alex Nemeth]

anemeth updated this revision to Diff 34064.
anemeth added a comment.


  - Remove unused function

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12848?vs=34063=34064

BRANCH
  standard-icon-sizes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12848

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kdiroperator.h
  src/filewidgets/kfilewidget.cpp

To: anemeth, #frameworks, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D12848: Set fix steps for icon sizes

[Alex Nemeth]

anemeth edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12848

To: anemeth, #frameworks, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D12848: Set fix steps for icon sizes

[Alex Nemeth]

anemeth edited the summary of this revision.
anemeth edited the test plan for this revision.
anemeth added reviewers: Frameworks, VDG.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12848

To: anemeth, #frameworks, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12848: Set fix steps for icon sizes

[Alex Nemeth]

anemeth added a subscriber: ngraham.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12848

To: anemeth, #frameworks, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D12848: Set fix steps for icon sizes

[Alex Nemeth]

anemeth created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
anemeth requested review of this revision.

REPOSITORY
  R241 KIO

BRANCH
  standard-icon-sizes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12848

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kdiroperator.h
  src/filewidgets/kfilewidget.cpp

To: anemeth
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12800: split tests for better readability

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:0c738df2c2b7: split tests for better readability 
(authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12800?vs=33935=34059

REVISION DETAIL
  https://phabricator.kde.org/D12800

AFFECTED FILES
  autotests/taglibextractortest.cpp
  autotests/taglibextractortest.h

To: astippich, mgallien, bruns
Cc: bruns, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham

KDE CI: Frameworks kfilemetadata kf5-qt5 FreeBSDQt5.10 - Build # 6 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kfilemetadata%20kf5-qt5%20FreeBSDQt5.10/6/
 Project:
Frameworks kfilemetadata kf5-qt5 FreeBSDQt5.10
 Date of build:
Sun, 13 May 2018 10:25:42 +
 Build duration:
11 sec and counting
   CONSOLE OUTPUT
  [...truncated 23 B...][Pipeline] nodeRunning on FreeBSD Builder 3 in /usr/home/jenkins/workspace/Frameworks kfilemetadata kf5-qt5 FreeBSDQt5.10[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] deleteDir[Pipeline] checkoutCloning the remote Git repositoryCloning repository git://anongit.kde.org/kfilemetadata > git init /usr/home/jenkins/workspace/Frameworks kfilemetadata kf5-qt5 FreeBSDQt5.10 # timeout=10Fetching upstream changes from git://anongit.kde.org/kfilemetadata > git --version # timeout=10 > git fetch --tags --progress git://anongit.kde.org/kfilemetadata +refs/heads/*:refs/remotes/origin/* # timeout=120 > git config remote.origin.url git://anongit.kde.org/kfilemetadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url git://anongit.kde.org/kfilemetadata # timeout=10Fetching upstream changes from git://anongit.kde.org/kfilemetadata > git fetch --tags --progress git://anongit.kde.org/kfilemetadata +refs/heads/*:refs/remotes/origin/* # timeout=120 > git rev-parse origin/master^{commit} # timeout=10Checking out Revision 0c738df2c2b7cc7ae8e3c7754d4f0529625bf364 (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f 0c738df2c2b7cc7ae8e3c7754d4f0529625bf364Commit message: "split tests for better readability" > git rev-list --no-walk 1491c4a2d9fd7adb075258d7eb65f4ae1d7169f4 # timeout=10[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/sysadmin/ci-tooling > git init /usr/home/jenkins/workspace/Frameworks kfilemetadata kf5-qt5 FreeBSDQt5.10/ci-tooling # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/ci-tooling > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/sysadmin/ci-tooling +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/sysadmin/ci-tooling # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/sysadmin/ci-tooling # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/ci-tooling > git fetch --tags --progress https://anongit.kde.org/sysadmin/ci-tooling +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision d178bf051ee03e154ea7abcf519e18a32b2f5411 (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f d178bf051ee03e154ea7abcf519e18a32b2f5411Commit message: "Use the right API for iterating a directory"[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/sysadmin/repo-metadata > git init /usr/home/jenkins/workspace/Frameworks kfilemetadata kf5-qt5 FreeBSDQt5.10/ci-tooling/repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision ca1e3a2ee3b31dbe12c8766a608af49f28b61345 (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f ca1e3a2ee3b31dbe12c8766a608af49f28b61345Commit message: "Create various repositories for the Nomad Project"[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/kde-build-metadata > git init /usr/home/jenkins/workspace/Frameworks kfilemetadata kf5-qt5 FreeBSDQt5.10/ci-tooling/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10Fetching upstream changes from 

D12801: search for album artist and albumartist tags in taglibextractor

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:5b6caa0b118b: search for album artist and albumartist 
tags in taglibextractor (authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12801?vs=33936=34058

REVISION DETAIL
  https://phabricator.kde.org/D12801

AFFECTED FILES
  src/extractors/taglibextractor.cpp

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns

D12392: Fix the "Default" color scheme to match Breeze again

[Eike Hein]

hein accepted this revision.
hein added a comment.
This revision is now accepted and ready to land.


  This looks good, but I think there might be additional copies of these values 
in (a) the color KCM code and (b) the kdeglobals code in kdelibs4support, did 
you have a chance to look into those?

REPOSITORY
  R265 KConfigWidgets

BRANCH
  fix-default-color-scheme (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12392

To: ngraham, #breeze, #plasma, hein
Cc: kde-frameworks-devel, cfeck, abetts, michaelh, ngraham, bruns