KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 274 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/274/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Tue, 29 May 2018 03:36:24 + Build duration: 33 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-ktcpsockettest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report64% (23/36)66% (294/443)66% (294/443)53% (31908/60038)38% (18948/49410)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (73/73)100% (73/73)95% (8829/9263)50% (5582/11155)autotests.http100% (9/9)100% (9/9)99% (586/587)59% (217/368)autotests.kcookiejar100% (1/1)100% (1/1)91% (180/198)67% (63/94)src100% (1/1)100% (1/1)86% (6/7)67% (4/6)src.core84% (100/119)84% (100/119)58% (8397/14504)50% (4899/9814)src.core.kssl100% (1/1)100% (1/1)40% (35/88)50% (3/6)src.filewidgets78% (31/40)78% (31/40)49% (3918/7918)33% (1656/4966)src.gui100% (2/2)100% (2/2)95% (104/110)77% (57/74)src.ioslaves.file100% (5/5)100% (5/5)52% (522/1008)42% (418/1004)src.ioslaves.file.kauth0% (0/3)0% (0/3)0% (0/104)0% (0/75)src.ioslaves.ftp0% (0/2)0% (0/2)0% (0/1365)0% (0/1515)src.ioslaves.help0% (0/5)0% (0/5)0% (0/247)0% (0/184)src.ioslaves.http89% (8/9)89% (8/9)41% (1784/4339)35% (1381/3995)src.ioslaves.http.kcookiejar33% (2/6)33% (2/6)47% (631/1333)55% (649/1174)src.ioslaves.remote100% (2/2)100% (2/2)28% (72/258)8% (19/242)src.ioslaves.remote.kdedmodule0% (0/4)0% (0/4)0% (0/14)100% (0/0)src.ioslaves.telnet0% (0/1)0% (0/1)0% (0/43)0% (0/30)src.ioslaves.trash64% (7/11)64% (7/11)52%
KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 124 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/124/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Tue, 29 May 2018 03:36:24 + Build duration: 19 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-ktcpsockettest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report64% (23/36)66% (294/443)66% (294/443)53% (31964/60038)38% (18972/49406)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (73/73)100% (73/73)95% (8829/9263)50% (5580/11155)autotests.http100% (9/9)100% (9/9)99% (586/587)59% (217/368)autotests.kcookiejar100% (1/1)100% (1/1)91% (180/198)67% (63/94)src100% (1/1)100% (1/1)86% (6/7)67% (4/6)src.core84% (100/119)84% (100/119)58% (8455/14504)50% (4924/9818)src.core.kssl100% (1/1)100% (1/1)40% (35/88)50% (3/6)src.filewidgets78% (31/40)78% (31/40)49% (3918/7918)33% (1656/4966)src.gui100% (2/2)100% (2/2)95% (104/110)77% (57/74)src.ioslaves.file100% (5/5)100% (5/5)52% (521/1008)42% (417/1004)src.ioslaves.file.kauth0% (0/3)0% (0/3)0% (0/104)0% (0/75)src.ioslaves.ftp0% (0/2)0% (0/2)0% (0/1365)0% (0/1515)src.ioslaves.help0% (0/5)0% (0/5)0% (0/247)0% (0/184)src.ioslaves.http89% (8/9)89% (8/9)41% (1784/4339)35% (1381/3995)src.ioslaves.http.kcookiejar33% (2/6)33% (2/6)47% (630/1333)55% (648/1174)src.ioslaves.remote100% (2/2)100% (2/2)28% (72/258)8% (19/242)src.ioslaves.remote.kdedmodule0% (0/4)0% (0/4)0% (0/14)100% (0/0)src.ioslaves.telnet0% (0/1)0% (0/1)0% (0/43)0% (0/30)src.ioslaves.trash64% (7/11)64% (7/11)52%
D12335: Avoid infinite loops when fetching the URL from DocumentUrlDB
smithjd added a comment. Restricted Application added a subscriber: kde-frameworks-devel. Is your report in bug https://bugs.kde.org/show_bug.cgi?id=364574 related to this diff? If so it could be marked as a duplicate. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12335 To: bruns, #baloo, michaelh, #frameworks, ngraham Cc: kde-frameworks-devel, smithjd, ngraham, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, bruns
KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 28 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/28/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 29 May 2018 03:36:24 + Build duration: 5 min 7 sec and counting JUnit Tests Name: (root) Failed: 5 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiocore-ktcpsockettestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest
D12025: Terminate query execution early if subterm returns empty result set
dhaumann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH terminate_empty_terms_early REVISION DETAIL https://phabricator.kde.org/D12025 To: bruns, #baloo, michaelh, #frameworks, dhaumann Cc: kde-frameworks-devel, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns
D13067: add pgf to the latex-ish file formats (same format as tikz)
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. This patch is correct, except that the version needs to be increased. Will integrate later. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D13067 To: jan.hajer, dhaumann Cc: dhaumann, kde-frameworks-devel, michaelh, genethomas, ngraham, bruns, cullmann, vkrause
D13067: add pgf to the latex-ish file formats (same format as tikz)
dhaumann added a project: Framework: Syntax Highlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D13067 To: jan.hajer Cc: kde-frameworks-devel, michaelh, genethomas, ngraham, bruns, cullmann, vkrause, dhaumann
D12233: Avoid manipulation of lists with quadratic complexity
dhaumann added a comment.
Looks good to me.
INLINE COMMENTS
> pendingfilequeue.cpp:69
> +const auto droppedFilesBegin = std::partition(m_cache.begin(), end,
> keepFile);
> +for (auto it = droppedFilesBegin; it != end; it++) {
> +m_pendingFiles.remove(it->path());
++it is faster.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D12233
To: bruns, #baloo, michaelh
Cc: dhaumann, ngraham, kde-frameworks-devel, jtamate, bruns, ashaposhnikov,
michaelh, astippich, spoorun
D12047: Avoid crash when reading corrupt data from document terms db
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. If the format is really such that a term must appear before any Suffix, then this patch is already better that before. Could it happen to have e.g.: a\0b1c1 If so, this code would extend the Suffix b with Suffix c. Would that be correct? Or can that never happen? Or should c be a Suffix for a? If so, this code should be improved. REPOSITORY R293 Baloo BRANCH b392878_avoid_docterms_decode_crash REVISION DETAIL https://phabricator.kde.org/D12047 To: bruns, #baloo, michaelh, ngraham, #frameworks, dhaumann Cc: dhaumann, kde-frameworks-devel, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns
D12025: Terminate query execution early if subterm returns empty result set
bruns added a comment. If there a no comments, I will push tomorrow. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12025 To: bruns, #baloo, michaelh, #frameworks Cc: kde-frameworks-devel, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns
D12025: Terminate query execution early if subterm returns empty result set
bruns updated this revision to Diff 35070. bruns added a comment. Restricted Application added a subscriber: kde-frameworks-devel. Rebase REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12025?vs=31612=35070 BRANCH terminate_empty_terms_early REVISION DETAIL https://phabricator.kde.org/D12025 AFFECTED FILES src/engine/transaction.cpp src/lib/searchstore.cpp To: bruns, #baloo, michaelh, #frameworks Cc: kde-frameworks-devel, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns
D12047: Avoid crash when reading corrupt data from document terms db
bruns updated this revision to Diff 35069. bruns added a comment. Rebase REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12047?vs=31672=35069 BRANCH b392878_avoid_docterms_decode_crash REVISION DETAIL https://phabricator.kde.org/D12047 AFFECTED FILES src/codecs/doctermscodec.cpp src/engine/documentdb.cpp To: bruns, #baloo, michaelh, ngraham, #frameworks Cc: kde-frameworks-devel, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns
D12233: Avoid manipulation of lists with quadratic complexity
bruns marked 2 inline comments as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12233 To: bruns, #baloo, michaelh Cc: ngraham, kde-frameworks-devel, jtamate, bruns, ashaposhnikov, michaelh, astippich, spoorun
D12233: Avoid manipulation of lists with quadratic complexity
bruns commandeered this revision. bruns edited reviewers, added: michaelh; removed: bruns. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12233 To: bruns, #baloo, michaelh Cc: ngraham, kde-frameworks-devel, jtamate, bruns, ashaposhnikov, michaelh, astippich, spoorun
D12233: Avoid manipulation of lists with quadratic complexity
bruns updated this revision to Diff 35068. bruns added a comment. Fix remaining issue (inverse condition in std::partition), cleanup REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12233?vs=32595=35068 BRANCH arcpatch-D12233 REVISION DETAIL https://phabricator.kde.org/D12233 AFFECTED FILES src/file/fileindexscheduler.cpp src/file/pendingfilequeue.cpp To: michaelh, #baloo, bruns Cc: ngraham, kde-frameworks-devel, jtamate, bruns, ashaposhnikov, michaelh, astippich, spoorun
D12047: Avoid crash when reading corrupt data from document terms db
bruns added a comment. If there is noone willing to review, I will push this tomorrow REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12047 To: bruns, #baloo, michaelh, ngraham, #frameworks Cc: kde-frameworks-devel, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns
D12513: CVE-2018-10361: privilege escalation
aacid added a comment. I think it was agreed this is an improvement, so i'm going to suggest we commit it. I'm definitely very short on time to spend here because someone added poppler to oss-fuzz and i've a pile of files that are crashing / causing bad behaviour on poppler to care for. Once this is in, we should open a bug/phabricator task/wathever with what is missing and the recommendations to fix it. Also not sure if useful but since kio is getting support for writting to "root owned" files we should investigate if maybe we can just simply drop this code altogether? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12513 To: cullmann, dfaure Cc: kwrite-devel, kde-frameworks-devel, mgerstner, aacid, ngraham, fvogt, cullmann, michaelh, kevinapavew, bruns, demsking, sars, dhaumann
KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 123 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/123/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Mon, 28 May 2018 17:55:47 + Build duration: 31 min and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-ktcpsockettest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report64% (23/36)66% (294/443)66% (294/443)53% (31977/60039)38% (18978/49406)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (73/73)100% (73/73)95% (8829/9263)50% (5582/11155)autotests.http100% (9/9)100% (9/9)99% (586/587)59% (217/368)autotests.kcookiejar100% (1/1)100% (1/1)91% (180/198)67% (63/94)src100% (1/1)100% (1/1)86% (6/7)67% (4/6)src.core84% (100/119)84% (100/119)58% (8467/14505)50% (4929/9818)src.core.kssl100% (1/1)100% (1/1)40% (35/88)50% (3/6)src.filewidgets78% (31/40)78% (31/40)49% (3918/7918)33% (1656/4966)src.gui100% (2/2)100% (2/2)95% (104/110)77% (57/74)src.ioslaves.file100% (5/5)100% (5/5)52% (522/1008)42% (418/1004)src.ioslaves.file.kauth0% (0/3)0% (0/3)0% (0/104)0% (0/75)src.ioslaves.ftp0% (0/2)0% (0/2)0% (0/1365)0% (0/1515)src.ioslaves.help0% (0/5)0% (0/5)0% (0/247)0% (0/184)src.ioslaves.http89% (8/9)89% (8/9)41% (1784/4339)35% (1381/3995)src.ioslaves.http.kcookiejar33% (2/6)33% (2/6)47% (630/1333)55% (648/1174)src.ioslaves.remote100% (2/2)100% (2/2)28% (72/258)8% (19/242)src.ioslaves.remote.kdedmodule0% (0/4)0% (0/4)0% (0/14)100% (0/0)src.ioslaves.telnet0% (0/1)0% (0/1)0% (0/43)0% (0/30)src.ioslaves.trash64% (7/11)64% (7/11)52%
KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 273 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/273/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Mon, 28 May 2018 17:55:47 + Build duration: 5 min 16 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-ktcpsockettest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report64% (23/36)66% (294/443)66% (294/443)53% (31895/60038)38% (18936/49410)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (73/73)100% (73/73)95% (8829/9263)50% (5580/11155)autotests.http100% (9/9)100% (9/9)99% (586/587)59% (217/368)autotests.kcookiejar100% (1/1)100% (1/1)91% (180/198)67% (63/94)src100% (1/1)100% (1/1)86% (6/7)67% (4/6)src.core84% (100/119)84% (100/119)58% (8397/14504)50% (4901/9814)src.core.kssl100% (1/1)100% (1/1)40% (35/88)50% (3/6)src.filewidgets78% (31/40)78% (31/40)49% (3917/7918)33% (1655/4966)src.gui100% (2/2)100% (2/2)95% (104/110)77% (57/74)src.ioslaves.file100% (5/5)100% (5/5)52% (521/1008)42% (417/1004)src.ioslaves.file.kauth0% (0/3)0% (0/3)0% (0/104)0% (0/75)src.ioslaves.ftp0% (0/2)0% (0/2)0% (0/1365)0% (0/1515)src.ioslaves.help0% (0/5)0% (0/5)0% (0/247)0% (0/184)src.ioslaves.http89% (8/9)89% (8/9)41% (1789/4339)35% (1379/3995)src.ioslaves.http.kcookiejar33% (2/6)33% (2/6)47% (631/1333)55% (649/1174)src.ioslaves.remote100% (2/2)100% (2/2)28% (72/258)8% (19/242)src.ioslaves.remote.kdedmodule0% (0/4)0% (0/4)0% (0/14)100% (0/0)src.ioslaves.telnet0% (0/1)0% (0/1)0% (0/43)0% (0/30)src.ioslaves.trash64% (7/11)64% (7/11)51%
KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 27 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/27/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 28 May 2018 17:55:48 + Build duration: 5 min 30 sec and counting JUnit Tests Name: (root) Failed: 5 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiocore-ktcpsockettestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest
KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.10 - Build # 8 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.10/8/ Project: Frameworks kpackage kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 28 May 2018 17:36:22 + Build duration: 55 sec and counting JUnit Tests Name: (root) Failed: 5 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-plasmoidpackagetestFailed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream
D13137: Updated handles and overflow-menu-*
hein accepted this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D13137 To: alex-l, mart, andreask, andreaska, hein Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13137: Updated handles and overflow-menu-*
andreask accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D13137 To: alex-l, mart, andreask, andreaska Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D12291: Accept file descriptor only from root owned process
chinmoyr abandoned this revision. chinmoyr added a comment. As of now this change is not of any importance. If in future a situation arises where we need it I will reopen this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12291 To: chinmoyr, #frameworks, dfaure, ossi Cc: kde-frameworks-devel, ossi, michaelh, ngraham, bruns
D13137: Updated handles and overflow-menu-*
mart added a comment. +1 from me, exactly what was needed! any definitive ship it from other vdg people REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D13137 To: alex-l, mart, andreask, andreaska Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D12291: Accept file descriptor only from root owned process
chinmoyr updated this revision to Diff 35010. chinmoyr added a comment. Accept socket connection where getsockopt() is not present REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12291?vs=34966=35010 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12291 AFFECTED FILES src/ioslaves/file/fdreceiver.cpp To: chinmoyr, #frameworks, dfaure, ossi Cc: kde-frameworks-devel, ossi, michaelh, ngraham, bruns
D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kcoredirlister.cpp:963
> QUrl oldurl = src.adjusted(QUrl::StripTrailingSlash);
> -KFileItem *fileitem = findByUrl(nullptr, oldurl);
> -if (!fileitem) {
> +// refresh the found item
> +KFileItem fileitem = findByUrl(nullptr, oldurl, true);
Where did the old code call refresh() (which you now call inside findByUrl)? I
don't see it, I only see more specific calls in more specific cases. So this
looks slower and possibly incorrect (for non-local-files).
> kcoredirlister.cpp:1004
> if (nameOnly) {
> -fileitem->setName(dst.fileName());
> +fileitem.setName(dst.fileName());
> } else {
This used to modify the fileitem in dirItem->lstItems, now it's modifying a
copy.
Same for all other fileitem.setFoo calls below.
Is there a call to reinsert missing?
> kcoredirlister.cpp:1843
> -const KFileItem oldItem = *tmp;
> -*tmp = item;
> foreach (KCoreDirLister *kdl, listers) {
This used to modify the item in dir->lstItems, so you need to reinsert in order
to not lose the changes.
> kcoredirlister.cpp:2042
> +KFileItem oldItem = item;
> +item.refresh();
> +
Needs to be reinserted afterwards.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10742
To: jtamate, #frameworks, dfaure
Cc: bruns, kde-frameworks-devel, mwolff, markg, michaelh, ngraham
D12291: Accept file descriptor only from root owned process
ossi added inline comments. INLINE COMMENTS > chinmoyr wrote in fdreceiver.cpp:89 > > i don't see why that would be horrible > > I meant adding "acceptConnection = true;" after #warning would look weird. > Obviously that's not even an issue and I shouldn't have mentioned it. > > There is a discussion[1] going on related to a similar change in ktexteditor. > Because ktexteditor also uses polkit to save files in read-only location, one > of the suggestions to improve this process, in case the owner of target is > not root, was to either ignore the operation or drop privileges to > owner/group of the directory. Now in KIO the kauth helper performs every > operation as root. So if in future it is decided to do a privilege drop > before performing any file operation on non-root targets then this change > will likely be a hindrance. After considering the fact that this is also > redundant, now I am not really feeling confident about this change. Just out > of curiosity, I want to know (although I feel weird for asking this) what was > your reason for accepting this patch? > > [1]: https://bugzilla.suse.com/show_bug.cgi?id=1033055#c13 i initially didn't notice the problem we're currently discussing. but more generally: it's a second layer of security, just in case somebody accidentally f*cks up the perms of their runtime dir (not something to be particularly concerned about; you'd certainly have bigger problems in this case). it might also help detecting configuration problems (though for that you'd have to add reasonable error reporting). and if done right, it's (currently) harmless, and i didn't feel like arguing over it. but i myself would just drop it. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D12291 To: chinmoyr, #frameworks, dfaure, ossi Cc: kde-frameworks-devel, ossi, michaelh, ngraham, bruns
D12745: Unify API for file descriptor sharing
dfaure accepted this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D12745 To: chinmoyr, dfaure, ossi Cc: kde-frameworks-devel, michaelh, ngraham, bruns
KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 27 - Fixed!
BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/27/ Project: Frameworks purpose kf5-qt5 SUSEQt5.9 Date of build: Mon, 28 May 2018 06:28:41 + Build duration: 6 min 11 sec and counting JUnit Tests Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s) Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report24% (5/21)30% (17/57)30% (17/57)21% (465/2175)22% (283/1270)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (4/4)100% (4/4)97% (150/155)62% (117/188)src100% (8/8)100% (8/8)75% (227/303)55% (130/237)src.externalprocess0% (0/2)0% (0/2)0% (0/142)0% (0/94)src.plugins.email0% (0/1)0% (0/1)0% (0/57)0% (0/32)src.plugins.imgur0% (0/2)0% (0/2)0% (0/188)0% (0/78)src.plugins.kdeconnect0% (0/1)0% (0/1)0% (0/34)0% (0/12)src.plugins.ktp-sendfile0% (0/1)0% (0/1)0% (0/30)0% (0/16)src.plugins.nextcloud0% (0/3)0% (0/3)0% (0/81)0% (0/40)src.plugins.pastebin0% (0/1)0% (0/1)0% (0/56)0% (0/36)src.plugins.phabricator0% (0/3)0% (0/3)0% (0/220)0% (0/90)src.plugins.phabricator.quick0% (0/6)0% (0/6)0% (0/86)0% (0/59)src.plugins.phabricator.tests0% (0/1)0% (0/1)0% (0/60)0% (0/28)src.plugins.reviewboard0% (0/3)0% (0/3)0% (0/242)0% (0/80)src.plugins.reviewboard.quick0% (0/8)0% (0/8)0% (0/159)0% (0/100)src.plugins.saveas100% (1/1)100% (1/1)58% (31/53)63% (30/48)src.plugins.telegram0% (0/1)0% (0/1)0% (0/59)0% (0/20)src.plugins.youtube0% (0/5)0% (0/5)0% (0/122)0% (0/44)src.quick100% (2/2)100% (2/2)100% (9/9)100%
KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 51 - Still Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/51/ Project: Frameworks purpose kf5-qt5 SUSEQt5.10 Date of build: Mon, 28 May 2018 06:28:41 + Build duration: 1 min 48 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltest Cobertura Report Project Coverage Summary Name PackagesFilesClassesLinesConditionalsCobertura Coverage Report24% (5/21)30% (17/57)30% (17/57)19% (423/2172)20% (248/1270)Coverage Breakdown by Package Name FilesClassesLinesConditionalsautotests100% (4/4)100% (4/4)90% (140/155)54% (102/188)src100% (8/8)100% (8/8)66% (197/300)46% (110/237)src.externalprocess0% (0/2)0% (0/2)0% (0/142)0% (0/94)src.plugins.email0% (0/1)0% (0/1)0% (0/57)0% (0/32)src.plugins.imgur0% (0/2)0% (0/2)0% (0/188)0% (0/78)src.plugins.kdeconnect0% (0/1)0% (0/1)0% (0/34)0% (0/12)src.plugins.ktp-sendfile0% (0/1)0% (0/1)0% (0/30)0% (0/16)src.plugins.nextcloud0% (0/3)0% (0/3)0% (0/81)0% (0/40)src.plugins.pastebin0% (0/1)0% (0/1)0% (0/56)0% (0/36)src.plugins.phabricator0% (0/3)0% (0/3)0% (0/220)0% (0/90)src.plugins.phabricator.quick0% (0/6)0% (0/6)0% (0/86)0% (0/59)src.plugins.phabricator.tests0% (0/1)0% (0/1)0% (0/60)0% (0/28)src.plugins.reviewboard0% (0/3)0% (0/3)0% (0/242)0% (0/80)src.plugins.reviewboard.quick0% (0/8)0% (0/8)0% (0/159)0% (0/100)src.plugins.saveas100% (1/1)100% (1/1)55% (29/53)63% (30/48)src.plugins.telegram0% (0/1)0% (0/1)0% (0/59)0% (0/20)src.plugins.youtube0% (0/5)0% (0/5)0% (0/122)0% (0/44)src.quick100% (2/2)100% (2/2)100% (9/9)100%
D12291: Accept file descriptor only from root owned process
chinmoyr added inline comments. INLINE COMMENTS > ossi wrote in fdreceiver.cpp:89 > i don't see why that would be horrible; as i pointed out multiple times > already, this change is redundant. one correction, though: add a code comment > here rather than extending the commit message. > > getsockopt() is standard, but the actual options aren't. you could change the > ifdef to SO_PEERCRED itself, but that wouldn't actually add any portability. > i don't see why that would be horrible I meant adding "acceptConnection = true;" after #warning would look weird. Obviously that's not even an issue and I shouldn't have mentioned it. There is a discussion[1] going on related to a similar change in ktexteditor. Because ktexteditor also uses polkit to save files in read-only location, one of the suggestions to improve this process, in case the owner of target is not root, was to either ignore the operation or drop privileges to owner/group of the directory. Now in KIO the kauth helper performs every operation as root. So if in future it is decided to do a privilege drop before performing any file operation on non-root targets then this change will likely be a hindrance. After considering the fact that this is also redundant, now I am not really feeling confident about this change. Just out of curiosity, I want to know (although I feel weird for asking this) what was your reason for accepting this patch? [1]: https://bugzilla.suse.com/show_bug.cgi?id=1033055#c13 REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D12291 To: chinmoyr, #frameworks, dfaure, ossi Cc: kde-frameworks-devel, ossi, michaelh, ngraham, bruns
KDE CI: Frameworks ki18n kf5-qt5 WindowsMSVCQt5.10 - Build # 21 - Unstable!
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20ki18n%20kf5-qt5%20WindowsMSVCQt5.10/21/ Project: Frameworks ki18n kf5-qt5 WindowsMSVCQt5.10 Date of build: Mon, 28 May 2018 06:05:36 + Build duration: 2 min 17 sec and counting JUnit Tests Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.ki18n-klocalizedstringtest
