D13554: [Properties dialog] Make all field values on general tab selectable
ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13554 To: ngraham, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13554: [Properties dialog] Make all field values on general tab selectable
ngraham created this revision. ngraham added a reviewer: Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY The Location field was already selectable; this patches extends that courtesy to all the rest. BUG: 105692 FIXED-IN 5.48 REPOSITORY R241 KIO BRANCH everything-is-selectable (branched from master) REVISION DETAIL https://phabricator.kde.org/D13554 AFFECTED FILES src/widgets/kpropertiesdialog.cpp To: ngraham, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13552: Improve some permissions-related strings
ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13552 To: ngraham, #frameworks, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13552: Improve some permissions-related strings
ngraham created this revision. ngraham added reviewers: Frameworks, VDG. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. ngraham requested review of this revision. REVISION SUMMARY BUG: 96714 FIXED-IN: 5.48 Improve some permissions-related strings to be clearer. TEST PLAN File: Folder: REPOSITORY R241 KIO BRANCH improve-permission-strings (branched from master) REVISION DETAIL https://phabricator.kde.org/D13552 AFFECTED FILES src/widgets/kpropertiesdialog.cpp To: ngraham, #frameworks, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13510: Add XDG WM Base support to our XDGShell API
romangg added inline comments.
INLINE COMMENTS
> registry.cpp:88
> #include
> +#include
>
nitpick: put this include directly below the other xdg-shell ones above.
> xdgshell_stable.cpp:195
> +
> +uint32_t constraint = 0;
> +if
> (positioner.constraints().testFlag(XdgPositioner::Constraint::SlideX)) {
`= XDG_POSITIONER_CONSTRAINT_ADJUSTMENT_NONE`
> xdgshell_interface.h:64
> +Stable,
> +Dave
> };
Is this the natural evolution of all protocols? In the end they become you?
> xdgshell_stable_interface.cpp:79
> +if (!configureSerials.contains(serial)) {
> +// TODO: send error?
> +return;
not according to specs
> xdgshell_stable_interface.cpp:160
> +const quint32 serial = global->display()->nextSerial();
> +wl_array state;
> +wl_array_init(&state);
Could you pls name this better: for example wlStates
> xdgshell_stable_interface.cpp:222
> +Q_UNUSED(client)
> +// TODO: send protocol error if there are still surfaces mapped
> +wl_resource_destroy(resource);
Do it?
> xdgshell_stable_interface.cpp:246
> +if (it != surfaces.constEnd()) {
> +wl_resource_post_error(surface->resource(), XDG_WM_BASE_ERROR_ROLE,
> "ShellSurface already created");
> +return;
Wrong id `XDG_WM_BASE_ERROR_ROLE`.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D13510
To: davidedmundson, #kwin
Cc: romangg, zzag, kde-frameworks-devel, michaelh, ngraham, bruns
D13549: Switch KIO::convertSize() to KFormat::formatByteSize()
pino created this revision. pino added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. pino requested review of this revision. REVISION SUMMARY Make KIO::convertSize() use KFormat::formatByteSize(), instead of using an own copy of the same function. The handling of the user configuration of the default dialect is left as-is, and it should work fine since the two enums BinaryUnitDialect (the removed one, and the one in KFormat) are the same. TEST PLAN Builds fine, no changes to the result of KIO::convertSize(). REPOSITORY R241 KIO BRANCH kformat (branched from master) REVISION DETAIL https://phabricator.kde.org/D13549 AFFECTED FILES src/core/global.cpp To: pino, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13541: Port solid from Qt5::Widgets to Qt5::Gui
dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. const auto would be even nicer, if possible. Besides that, lgtm. REPOSITORY R245 Solid BRANCH gui-instead-of-widgets REVISION DETAIL https://phabricator.kde.org/D13541 To: graesslin, #frameworks, dhaumann Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns
D13495: Fix XDGV6 popup test
davidedmundson added a comment. You can only set the size in the ctor, so needed a new instance. For the rest of the tests we don't need different sizes. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13495 To: davidedmundson, #kwin Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns
D13495: Fix XDGV6 popup test
romangg added a comment. What's with positioner2? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13495 To: davidedmundson, #kwin Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns
D13535: Do not cancel old clipboard selection if it is same as the new one.
fvogt added a comment.
Yes, a unit test makes sense. I tried to add
// replace the data source with itself, ensure that it did not get cancelled
// replace the data source with itself, ensure that it did not get cancelled
selectionOfferedSpy.clear();
dataSource2->offer(QStringLiteral("text/plain"));
dataDevice->setSelection(2, dataSource2.data());
QVERIFY(selectionOfferedSpy.wait());
QVERIFY(sourceCancelled2Spy.isEmpty());
in TestDataDevice::testReplaceSource() and it fails without this patch.
With this patch however, the selection isn't offered (is that correct
behaviour?) so the wait() times out.
Is there a better way to test this?
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D13535
To: fvogt, #plasma, #frameworks
Cc: graesslin, kde-frameworks-devel, michaelh, ngraham, bruns
D13488: Make XDGShellV5 co-compilable with XDGWMBase
romangg added inline comments. INLINE COMMENTS > xdgshell_v5.cpp:36 > public: > -void setupV5(xdg_shell *shell) override; > +void setupV5(xdg_shell *shell); > void release() override; This should be still an override. > wayland-xdg-shell-v5-client-protocol.h:1 > +/* Generated by wayland-scanner 1.14.0 */ > + Is this file not also changed like the other ones? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13488 To: davidedmundson, #plasma Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns
D13541: Port solid from Qt5::Widgets to Qt5::Gui
graesslin created this revision. graesslin added a reviewer: Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. graesslin requested review of this revision. REVISION SUMMARY The only usage of widgets was to get the active window. Incorrectly this was done through QWidget which would fail for any application using just QtGui (e.g. QtQuick). As QGuiApplication also provides access to the focus window we can use QtGui API instead. As a note: the whole thing is X11 specific as a window ID is passed to another process, which cannot work on Wayland. It's possible to get it work on Wayland, but that would require: - changes to the dbus protocol - add a dependency to KWayland - or extend QtWayland to generate the required code TEST PLAN Compiles REPOSITORY R245 Solid BRANCH gui-instead-of-widgets REVISION DETAIL https://phabricator.kde.org/D13541 AFFECTED FILES CMakeLists.txt src/solid/CMakeLists.txt src/solid/devices/backends/udisks2/udisksstorageaccess.cpp To: graesslin, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13535: Do not cancel old clipboard selection if it is same as the new one.
graesslin added a comment. I would appreciate a unit test for the issue. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13535 To: fvogt, #plasma, #frameworks Cc: graesslin, kde-frameworks-devel, michaelh, ngraham, bruns
D13536: Do not cancel old clipboard selection if it is same as the new one.
michalsrb abandoned this revision. michalsrb added a comment. Already submitted: https://phabricator.kde.org/D13535 REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13536 To: michalsrb Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13533: Add the arclint file in kwayland
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH add-arclint REVISION DETAIL https://phabricator.kde.org/D13533 To: bshah, #frameworks, mart Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D12820: Add KWayland virtual desktop protocol
mart updated this revision to Diff 36161. mart added a comment. - remove release from the protocol - new_id is id REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12820?vs=36052&id=36161 BRANCH mart/plasmavirtualdesktop REVISION DETAIL https://phabricator.kde.org/D12820 AFFECTED FILES autotests/client/CMakeLists.txt autotests/client/test_plasma_virtual_desktop.cpp src/client/CMakeLists.txt src/client/plasmavirtualdesktop.cpp src/client/plasmavirtualdesktop.h src/client/plasmawindowmanagement.cpp src/client/plasmawindowmanagement.h src/client/protocols/plasma-virtual-desktop.xml src/client/protocols/plasma-window-management.xml src/client/registry.cpp src/client/registry.h src/server/CMakeLists.txt src/server/display.cpp src/server/display.h src/server/plasmavirtualdesktop_interface.cpp src/server/plasmavirtualdesktop_interface.h src/server/plasmawindowmanagement_interface.cpp src/server/plasmawindowmanagement_interface.h src/tools/mapping.txt To: mart, #kwin, #plasma, graesslin, hein Cc: davidedmundson, zzag, bshah, romangg, kde-frameworks-devel, michaelh, ngraham, bruns
D13494: Fix stupid copy paste bug in XDGShellV6 Client
romangg accepted this revision.
romangg added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> xdgshell_v6.cpp:180
> uint32_t constraint = 0;
> +
> if
> (positioner.constraints().testFlag(XdgPositioner::Constraint::SlideX)) {
remove this new line
REPOSITORY
R127 KWayland
BRANCH
xdg_squash
REVISION DETAIL
https://phabricator.kde.org/D13494
To: davidedmundson, #kwin, romangg
Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns
D13536: Do not cancel old clipboard selection if it is same as the new one.
michalsrb created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. michalsrb requested review of this revision. REVISION SUMMARY GTK applications seem to call wl_data_device::set_selection multiple times with the same wl_data_source object, replacing it with itself. If we cancel it, they will destroy it and the selection will be gone. With this patch it is again possible to copy from GTK applications. BUG: 395366 REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D13536 AFFECTED FILES src/server/datadevice_interface.cpp To: michalsrb Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13535: Do not cancel old clipboard selection if it is same as the new one.
fvogt created this revision. fvogt added reviewers: Plasma, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. fvogt requested review of this revision. REVISION SUMMARY GTK applications seem to call wl_data_device::set_selection multiple times with the same wl_data_source object, replacing it with itself. If we cancel it, they will destroy it and the selection will be gone. With this patch it is again possible to copy from GTK applications. BUG: 395366 TEST PLAN Patch provided by the reporter, he reported success. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D13535 AFFECTED FILES src/server/datadevice_interface.cpp To: fvogt, #plasma, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13533: Add the arclint file in kwayland
bshah created this revision. bshah added a reviewer: Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. bshah requested review of this revision. REVISION SUMMARY - xml linter to make sure that we don't add broken protocols - merge-conflict so that we don't commit merge-conflict markers - spell check for documentation - cppcheck to check the code TEST PLAN broke some files manually, and then ran arc lint REPOSITORY R127 KWayland BRANCH add-arclint REVISION DETAIL https://phabricator.kde.org/D13533 AFFECTED FILES .arclint To: bshah, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D12820: Add KWayland virtual desktop protocol
davidedmundson added a comment. Cool. I'm happy with the protocol, except for one important comment. IMHO worth doing the kwin/plasma code before pushing the frameworks code. INLINE COMMENTS > plasma-virtual-desktop.xml:62 > + > + > + This still isn't deletable, see my comment from last time. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D12820 To: mart, #kwin, #plasma, graesslin, hein Cc: davidedmundson, zzag, bshah, romangg, kde-frameworks-devel, michaelh, ngraham, bruns
