KDE CI: Frameworks kservice kf5-qt5 WindowsMSVCQt5.10 - Build # 23 - Still unstable!

2018-06-19 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20WindowsMSVCQt5.10/23/
 Project:
Frameworks kservice kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Wed, 20 Jun 2018 00:15:03 +
 Build duration:
3 min 10 sec and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 10 test(s)Failed: TestSuite.kmimeassociationstestFailed: TestSuite.kplugininfotestFailed: TestSuite.kservicetestFailed: TestSuite.ksycocathreadtest

D13043: Properly sanitize input

2018-06-19 Thread Aleix Pol Gonzalez 
apol added a comment.


  Yep, this was from the old and deprecated modeltest.cpp.
  
  I'll have to look into how to do it right :P

REPOSITORY
  R275 KItemModels

REVISION DETAIL
  https://phabricator.kde.org/D13043

To: apol, #frameworks, broulik
Cc: dfaure, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 - Build # 147 - Fixed!

2018-06-19 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.10/147/
 Project:
Frameworks kio kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Tue, 19 Jun 2018 22:29:26 +
 Build duration:
14 min and counting

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 297 - Unstable!

2018-06-19 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/297/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 19 Jun 2018 22:29:26 +
 Build duration:
5 min 29 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesviewtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(294/443)66%
(294/443)53%
(31922/60072)38%
(18963/49460)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(73/73)100%
(73/73)95%
(8858/9290)50%
(5611/11209)autotests.http100%
(9/9)100%
(9/9)99%
(586/587)59%
(217/368)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(180/198)67%
(63/94)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(100/119)84%
(100/119)58%
(8393/14498)50%
(4897/9794)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets78%
(31/40)78%
(31/40)49%
(3917/7918)33%
(1655/4966)src.gui100%
(2/2)100%
(2/2)95%
(104/110)77%
(57/74)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(526/1015)42%
(421/1012)src.ioslaves.file.kauth0%
(0/3)0%
(0/3)0%
(0/107)0%
(0/77)src.ioslaves.ftp0%
(0/2)0%
(0/2)0%
(0/1365)0%
(0/1515)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/247)0%
(0/184)src.ioslaves.http89%
(8/9)89%
(8/9)41%
(1789/4339)35%
(1379/3995)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(631/1333)55%
(649/1174)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/258)8%
(19/242)src.ioslaves.remote.kdedmodule0%
(0/4)0%
(0/4)0%
(0/14)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash64%
(7/11)64%

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 53 - Still Unstable!

2018-06-19 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/53/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 19 Jun 2018 22:29:26 +
 Build duration:
5 min 7 sec and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

D13554: [Properties dialog] Make all field values on general tab selectable

2018-06-19 Thread Nathaniel Graham 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:025e5e9957ff: [Properties dialog] Make all field values 
on general tab selectable (authored by ngraham).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13554?vs=36188=36361

REVISION DETAIL
  https://phabricator.kde.org/D13554

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp

To: ngraham, #frameworks, #dolphin, elvisangelaccio
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13622: Remove unused entry X-KDE-DBus-ModuleName from kded plugins' metadata

2018-06-19 Thread Friedrich W. H. Kossebau 
kossebau added a comment.


  In D13622#280325 , @dfaure wrote:
  
  > Note: kcoreaddons, baloo, kservice/autotests, and kdelibs4support mention 
this key too, you can clean it all up ;)
  
  
  Done. Thanks for quick review :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13622

To: kossebau, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kservice kf5-qt5 SUSEQt5.10 - Build # 36 - Still Unstable!

2018-06-19 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20SUSEQt5.10/36/
 Project:
Frameworks kservice kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 19 Jun 2018 22:10:31 +
 Build duration:
1 min 56 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.kplugininfotestFailed: TestSuite.kservicetestFailed: TestSuite.ksycocathreadtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report75%
(6/8)83%
(73/88)83%
(73/88)68%
(5507/8115)48%
(3183/6678)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(13/14)93%
(13/14)84%
(1306/1559)45%
(907/2007)src.kbuildsycoca100%
(1/1)100%
(1/1)92%
(54/59)68%
(15/22)src.kdeinit0%
(0/2)0%
(0/2)0%
(0/334)0%
(0/278)src.plugin67%
(2/3)67%
(2/3)49%
(47/96)42%
(44/106)src.services97%
(29/30)97%
(29/30)61%
(1849/3036)41%
(818/1982)src.sycoca83%
(25/30)83%
(25/30)77%
(2143/2793)62%
(1366/2195)tests0%
(0/5)0%
(0/5)0%
(0/118)0%
(0/40)tests.pluginlocator100%
(3/3)100%
(3/3)90%
(108/120)69%
(33/48)

KDE CI: Frameworks kservice kf5-qt5 FreeBSDQt5.10 - Build # 11 - Unstable!

2018-06-19 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20FreeBSDQt5.10/11/
 Project:
Frameworks kservice kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 19 Jun 2018 22:10:32 +
 Build duration:
1 min 28 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 10 test(s)Failed: TestSuite.kmimeassociationstest

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 31 - Still Unstable!

2018-06-19 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/31/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 19 Jun 2018 22:07:26 +
 Build duration:
3 min 30 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 86 - Still Unstable!

2018-06-19 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/86/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 19 Jun 2018 22:07:26 +
 Build duration:
3 min 7 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kdirwatch_stat_unittest

KDE CI: Frameworks kservice kf5-qt5 WindowsMSVCQt5.10 - Build # 22 - Failure!

2018-06-19 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kservice%20kf5-qt5%20WindowsMSVCQt5.10/22/
 Project:
Frameworks kservice kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Tue, 19 Jun 2018 22:10:31 +
 Build duration:
15 sec and counting
   CONSOLE OUTPUT
  [...truncated 6.56 KB...] > git rev-parse "origin/master^{commit}" # timeout=10Checking out Revision ac7c689b6a2f8a9042fb00fc96a9cbd17443a5ab (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f ac7c689b6a2f8a9042fb00fc96a9cbd17443a5abCommit message: "Remove unused key X-KDE-DBus-ModuleName from test service metadata" > git rev-list --no-walk 9d924e0825d0efe5c9bb53114d5c686b3e821038 # timeout=10[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/sysadmin/ci-tooling > git init C:\CI\workspace\Frameworks kservice kf5-qt5 WindowsMSVCQt5.10\ci-tooling # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/ci-tooling > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/sysadmin/ci-tooling +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/sysadmin/ci-tooling # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/sysadmin/ci-tooling # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/ci-tooling > git fetch --tags --progress https://anongit.kde.org/sysadmin/ci-tooling +refs/heads/*:refs/remotes/origin/* > git rev-parse "origin/master^{commit}" # timeout=10Checking out Revision 9e85874c7e28696fa620b23b82303d6ac7fb9119 (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f 9e85874c7e28696fa620b23b82303d6ac7fb9119Commit message: "Disable execution of tests for messagelib. The tests in this project spawn resident processes which run indefinitely, preventing CTest from continuing. This in turn blocks CI nodes and prevents the system from otherwise operating correctly."[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/sysadmin/repo-metadata > git init C:\CI\workspace\Frameworks kservice kf5-qt5 WindowsMSVCQt5.10\ci-tooling\repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* > git rev-parse "origin/master^{commit}" # timeout=10Checking out Revision 3408189d2fe373642a3a7e6828cebcd39899cbbd (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f 3408189d2fe373642a3a7e6828cebcd39899cbbd[Pipeline] }[Pipeline] // stage[Pipeline] }hudson.plugins.git.GitException: Command "git checkout -f 3408189d2fe373642a3a7e6828cebcd39899cbbd" returned status code 1:stdout: stderr: error: unable to write file snapshots/kde_projects.xmlNote: checking out '3408189d2fe373642a3a7e6828cebcd39899cbbd'.You are in 'detached HEAD' state. You can look around, make experimentalchanges and commit them, and you can discard any commits you make in thisstate without impacting any branches by performing another checkout.If you want to create a new branch to retain commits you create, you maydo so (now or later) by using -b with the checkout command again. Example:  git checkout -b HEAD is now at 3408189 Krita's stable branch is now 4.1	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2002)	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$800(CliGitAPIImpl.java:72)	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$9.execute(CliGitAPIImpl.java:2301)Also:   hudson.remoting.Channel$CallSiteStackTrace: Remote call to JNLP4-connect connection from aranea.kde.org/195.201.167.114:49680		at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1741)		at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:357)		at hudson.remoting.Channel.call(Channel.java:955)		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:146)		at sun.reflect.GeneratedMethodAccessor345.invoke(Unknown Source)		at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)		at java.lang.reflect.Method.invoke(Method.java:498)		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:132)		at

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10 - Build # 9 - Still Unstable!

2018-06-19 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.10/9/
 Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 19 Jun 2018 22:07:26 +
 Build duration:
3 min 15 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 20 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kdirwatch_stat_unittest

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 - Build # 49 - Still Unstable!

2018-06-19 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/49/
 Project:
Frameworks kdelibs4support kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 19 Jun 2018 22:02:01 +
 Build duration:
4 min 32 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.ktabwidget_unittest

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.9 - Build # 22 - Still Unstable!

2018-06-19 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.9/22/
 Project:
Frameworks kdelibs4support kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 19 Jun 2018 22:02:01 +
 Build duration:
4 min 14 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.ktabwidget_unittest

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.10 - Build # 9 - Still Unstable!

2018-06-19 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.10/9/
 Project:
Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 19 Jun 2018 22:02:01 +
 Build duration:
3 min 45 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kmimetypetestFailed: TestSuite.kstandarddirstest

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 52 - Still Unstable!

2018-06-19 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/52/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 19 Jun 2018 21:49:46 +
 Build duration:
4 min 7 sec and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

KDE CI: Frameworks kio kf5-qt5 WindowsMSVCQt5.10 - Build # 146 - Failure!

2018-06-19 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20WindowsMSVCQt5.10/146/
 Project:
Frameworks kio kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Tue, 19 Jun 2018 21:49:46 +
 Build duration:
12 sec and counting
   CONSOLE OUTPUT
  Started by an SCM changeRunning in Durability level: MAX_SURVIVABILITY[Pipeline] nodeRunning on Windows Builder 1 in C:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.10[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] deleteDir[Pipeline] checkoutCloning the remote Git repositoryCloning repository git://anongit.kde.org/kio > git init C:\CI\workspace\Frameworks kio kf5-qt5 WindowsMSVCQt5.10 # timeout=10Fetching upstream changes from git://anongit.kde.org/kio > git --version # timeout=10 > git fetch --tags --progress git://anongit.kde.org/kio +refs/heads/*:refs/remotes/origin/* # timeout=120ERROR: Error cloning remote repo 'origin'hudson.plugins.git.GitException: Command "git fetch --tags --progress git://anongit.kde.org/kio +refs/heads/*:refs/remotes/origin/*" returned status code 128:stdout: stderr: remote: Counting objects: 7232   remote: Counting objects: 16794   remote: Counting objects: 33937, done.remote: Compressing objects:   0% (1/8538)   remote: Compressing objects:   1% (86/8538)   remote: Compressing objects:   2% (171/8538)   remote: Compressing objects:   3% (257/8538)   remote: Compressing objects:   4% (342/8538)   remote: Compressing objects:   5% (427/8538)   remote: Compressing objects:   6% (513/8538)   remote: Compressing objects:   7% (598/8538)   remote: Compressing objects:   8% (684/8538)   remote: Compressing objects:   9% (769/8538)   remote: Compressing objects:  10% (854/8538)   remote: Compressing objects:  11% (940/8538)   remote: Compressing objects:  12% (1025/8538)   remote: Compressing objects:  13% (1110/8538)   remote: Compressing objects:  14% (1196/8538)   remote: Compressing objects:  15% (1281/8538)   remote: Compressing objects:  16% (1367/8538)   remote: Compressing objects:  16% (1444/8538)   remote: Compressing objects:  17% (1452/8538)   remote: Compressing objects:  18% (1537/8538)   remote: Compressing objects:  19% (1623/8538)   remote: Compressing objects:  20% (1708/8538)   remote: Compressing objects:  21% (1793/8538)   remote: Compressing objects:  22% (1879/8538)   remote: Compressing objects:  23% (1964/8538)   remote: Compressing objects:  23% (2015/8538)   remote: Compressing objects:  23% (2044/8538)   remote: Compressing objects:  24% (2050/8538)   remote: Compressing objects:  25% (2135/8538)   remote: Compressing objects:  26% (2220/8538)   remote: Compressing objects:  27% (2306/8538)   remote: Compressing objects:  28% (2391/8538)   remote: Compressing objects:  29% (2477/8538)   remote: Compressing objects:  30% (2562/8538)   remote: Compressing objects:  31% (2647/8538)   remote: Compressing objects:  32% (2733/8538)   remote: Compressing objects:  33% (2818/8538)   remote: Compressing objects:  34% (2903/8538)   remote: Compressing objects:  35% (2989/8538)   remote: Compressing objects:  36% (3074/8538)   remote: Compressing objects:  37% (3160/8538)   remote: Compressing objects:  38% (3245/8538)   remote: Compressing objects:  39% (3330/8538)   remote: Compressing objects:  40% (3416/8538)   remote: Compressing objects:  41% (3501/8538)   remote: Compressing objects:  42% (3586/8538)   remote: Compressing objects:  43% (3672/8538)   remote: Compressing objects:  44% (3757/8538)   remote: Compressing objects:  45% (3843/8538)   remote: Compressing objects:  46% (3928/8538)   remote: Compressing objects:  47% (4013/8538)   remote: Compressing objects:  48% (4099/8538)   remote: Compressing objects:  49% (4184/8538)   remote: Compressing objects:  50% (4269/8538)   remote: Compressing objects:  51% (4355/8538)   remote: Compressing objects:  52% (4440/8538)   remote: Compressing objects:  53% (4526/8538)   remote: Compressing objects:  54% (4611/8538)   remote: Compressing objects:  55% (4696/8538)   remote: Compressing objects:  56% (4782/8538)   remote: Compressing objects:  57% (4867/8538)   remote: Compressing objects:  58% (4953/8538)   remote: Compressing objects:  59% (5038/8538)   remote: Compressing objects:  60% (5123/8538)   remote: Compressing objects:  61% (5209/8538)   remote: Compressing objects:  62%

D13622: Remove unused entry X-KDE-DBus-ModuleName from kded plugins' metadata

2018-06-19 Thread Friedrich W. H. Kossebau 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:486c4e86c8d3: Remove unused entry X-KDE-DBus-ModuleName 
from kded plugins metadata (authored by kossebau).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13622?vs=36356=36359

REVISION DETAIL
  https://phabricator.kde.org/D13622

AFFECTED FILES
  src/ioslaves/http/kcookiejar/kcookiejar.json
  src/ioslaves/remote/kdedmodule/remotedirnotify.desktop
  src/kioexec/kioexecd.json
  src/kpac/proxyscout.json
  src/kpasswdserver/kpasswdserver.json

To: kossebau, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13621: KDEDModule servicetype definition: remove unused key X-KDE-DBus-ModuleName

2018-06-19 Thread Friedrich W. H. Kossebau 
This revision was automatically updated to reflect the committed changes.
Closed by commit R297:6b42fefabd2a: KDEDModule servicetype definition: remove 
unused key X-KDE-DBus-ModuleName (authored by kossebau).

REPOSITORY
  R297 KDED

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13621?vs=36354=36358

REVISION DETAIL
  https://phabricator.kde.org/D13621

AFFECTED FILES
  src/kdedmodule.desktop

To: kossebau, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13622: Remove unused entry X-KDE-DBus-ModuleName from kded plugins' metadata

2018-06-19 Thread David Faure 
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Note: kcoreaddons, baloo, kservice/autotests, and kdelibs4support mention 
this key too, you can clean it all up ;)
  
  Thanks!

REPOSITORY
  R241 KIO

BRANCH
  removeModuleNameKey

REVISION DETAIL
  https://phabricator.kde.org/D13622

To: kossebau, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13621: KDEDModule servicetype definition: remove unused key X-KDE-DBus-ModuleName

2018-06-19 Thread David Faure 
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Indeed, not used, and not useful.

REPOSITORY
  R297 KDED

BRANCH
  removeModuleNameKey

REVISION DETAIL
  https://phabricator.kde.org/D13621

To: kossebau, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13622: Remove unused entry X-KDE-DBus-ModuleName from kded plugins' metadata

2018-06-19 Thread Friedrich W. H. Kossebau 
kossebau created this revision.
kossebau added a reviewer: dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  That entry has never been used, instead the plugin id (as by
  KPluginMetaData::pluginId()) has been used for the module name in the
  D-Bus object path.

REPOSITORY
  R241 KIO

BRANCH
  removeModuleNameKey

REVISION DETAIL
  https://phabricator.kde.org/D13622

AFFECTED FILES
  src/ioslaves/http/kcookiejar/kcookiejar.json
  src/ioslaves/remote/kdedmodule/remotedirnotify.desktop
  src/kioexec/kioexecd.json
  src/kpac/proxyscout.json
  src/kpasswdserver/kpasswdserver.json

To: kossebau, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13621: KDEDModule servicetype definition: remove unused key X-KDE-DBus-ModuleName

2018-06-19 Thread Friedrich W. H. Kossebau 
kossebau created this revision.
kossebau added a reviewer: dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  This key was introduced in 2008 in some places, but seems it got never
  taken into account by the actual kded module loading code when deciding
  about the name for the module's D-Bus object path
  (at least by what I found in the kdelibs/kded/kdbusaddons repo history).
  
  As any existing kded modules are fine with getting the D-Bus module
  name derived from the plugin id (either as set via plugin metadata or
  by the binary name), this unused key can be removed again.

REPOSITORY
  R297 KDED

BRANCH
  removeModuleNameKey

REVISION DETAIL
  https://phabricator.kde.org/D13621

AFFECTED FILES
  src/kdedmodule.desktop

To: kossebau, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13554: [Properties dialog] Make all field values on general tab selectable

2018-06-19 Thread Elvis Angelaccio 
elvisangelaccio accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  everything-is-selectable (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13554

To: ngraham, #frameworks, #dolphin, elvisangelaccio
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13571: Correct KFormat::formatBytes examples

2018-06-19 Thread Stefan Brüns 
bruns added a comment.


  In D13571#280135 , @apol wrote:
  
  > In D13571#279554 , @bruns wrote:
  >
  > > In D13571#279550 , @apol wrote:
  > >
  > > > > The given example is just plain wrong. It does not work, it is just 
some false prosa.
  > > >
  > > > Fair enough, yet the API user may want to be able to understand what's 
the logic behind it, so if it can be explained on the documentation that could 
be useful.
  > >
  > >
  > > What is "it"?
  > >
  > > This patch does not change any behaviour, it just ensures the 
documentation matches reality.
  >
  >
  > Don't make me read the code. You are updating documentation, the 
documentation itself needs to offer such information.
  
  
  I was referring to you vague formulation "understand what's the logic behind 
it". Apparently you need some clarification for "something". Why don't you tell 
what "something" is?
  
  Instead of accepting a documentation *fix*, you are nitpicking about 
something, but you do not really tell what you don't like.
  
  The example code neither compiles, nor does the output - after fixing the 
broken code - match the output from the documentation.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D13571

To: bruns, #frameworks
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D13601: OutputManagement fractional scaling

2018-06-19 Thread David Edmundson 
davidedmundson added a dependent revision: D13617: Support kwin fractional 
scaling in wayland backend.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D13601

To: davidedmundson, #kwin
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D13510: Add XDG WM Base support to our XDGShell API

2018-06-19 Thread David Edmundson 
davidedmundson added a dependency: D13530: Add XDG WmBase support.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D13510

To: davidedmundson, #kwin
Cc: romangg, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D13495: Fix XDGV6 popup test

2018-06-19 Thread David Edmundson 
davidedmundson added a dependent revision: D13530: Add XDG WmBase support.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D13495

To: davidedmundson, #kwin
Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D13488: Make XDGShellV5 co-compilable with XDGWMBase

2018-06-19 Thread David Edmundson 
davidedmundson added a dependent revision: D13530: Add XDG WmBase support.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D13488

To: davidedmundson, #plasma
Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns

D13494: Fix stupid copy paste bug in XDGShellV6 Client

2018-06-19 Thread David Edmundson 
davidedmundson added a dependent revision: D13530: Add XDG WmBase support.

REPOSITORY
  R127 KWayland

BRANCH
  xdg_squash

REVISION DETAIL
  https://phabricator.kde.org/D13494

To: davidedmundson, #kwin, romangg
Cc: romangg, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 51 - Still Unstable!

2018-06-19 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/51/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 19 Jun 2018 14:54:40 +
 Build duration:
11 min and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

D13590: Use QUrl < instead of QString.compare

2018-06-19 Thread Jaime Torres Amate 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:bba871deced2: Use QUrl  instead of QString.compare 
(authored by jtamate).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13590?vs=36283=36343

REVISION DETAIL
  https://phabricator.kde.org/D13590

AFFECTED FILES
  src/widgets/kdirmodel.cpp

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 59 - Still Unstable!

2018-06-19 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/59/
 Project:
Frameworks kwayland kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 19 Jun 2018 14:19:24 +
 Build duration:
7 min 4 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 43 test(s), Skipped: 0 test(s), Total: 44 test(s)Failed: TestSuite.kwayland-testRemoteAccess
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report57%
(4/7)90%
(225/251)90%
(225/251)84%
(24102/28745)52%
(11791/22732)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client98%
(40/41)98%
(40/41)98%
(11225/11508)49%
(7708/15599)autotests.server100%
(5/5)100%
(5/5)99%
(359/362)49%
(220/446)src.client97%
(69/71)97%
(69/71)84%
(5688/6743)65%
(1782/2752)src.server97%
(111/115)97%
(111/115)86%
(6830/7964)64%
(2081/3256)src.tools0%
(0/2)0%
(0/2)0%
(0/786)0%
(0/346)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/16)tests0%
(0/14)0%
(0/14)0%
(0/1262)0%
(0/317)

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 - Build # 21 - Still Unstable!

2018-06-19 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.10/21/
 Project:
Frameworks kwayland kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 19 Jun 2018 14:19:24 +
 Build duration:
6 min 50 sec and counting
   JUnit Tests
  Name: (root) Failed: 13 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kwayland-testCompositorFailed: TestSuite.kwayland-testDataDeviceFailed: TestSuite.kwayland-testDataSourceFailed: TestSuite.kwayland-testRegionFailed: TestSuite.kwayland-testRemoteAccessFailed: TestSuite.kwayland-testShmPoolFailed: TestSuite.kwayland-testSubCompositorFailed: TestSuite.kwayland-testSubSurfaceFailed: TestSuite.kwayland-testWaylandConnectionThreadFailed: TestSuite.kwayland-testWaylandRegistryFailed: TestSuite.kwayland-testWaylandServerDisplayFailed: TestSuite.kwayland-testWaylandShellFailed: TestSuite.kwayland-testWaylandSurface

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.9 - Build # 31 - Still Unstable!

2018-06-19 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/31/
 Project:
Frameworks kwayland kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 19 Jun 2018 14:19:24 +
 Build duration:
5 min 44 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 43 test(s), Skipped: 0 test(s), Total: 44 test(s)Failed: TestSuite.kwayland-testRemoteAccess
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report57%
(4/7)90%
(225/251)90%
(225/251)84%
(24104/28746)52%
(11791/22732)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client98%
(40/41)98%
(40/41)98%
(11227/11509)49%
(7708/15599)autotests.server100%
(5/5)100%
(5/5)99%
(359/362)49%
(220/446)src.client97%
(69/71)97%
(69/71)84%
(5688/6743)65%
(1782/2752)src.server97%
(111/115)97%
(111/115)86%
(6830/7964)64%
(2081/3256)src.tools0%
(0/2)0%
(0/2)0%
(0/786)0%
(0/346)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/16)tests0%
(0/14)0%
(0/14)0%
(0/1262)0%
(0/317)

D13502: Fix compiler warning about hidden virtual overloads

2018-06-19 Thread David Edmundson 
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:7b9932e70739: Fix compiler warning about hidden virtual 
overloads (authored by davidedmundson).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13502?vs=36073=36339

REVISION DETAIL
  https://phabricator.kde.org/D13502

AFFECTED FILES
  src/client/textinput_v0.cpp
  src/client/textinput_v2.cpp

To: davidedmundson, #kwin, zzag
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D13552: [Properties dialog] Improve some permissions-related strings

2018-06-19 Thread Andres Betts 
abetts added a comment.


  +1

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13552

To: ngraham, #frameworks, #vdg, #dolphin
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D13571: Correct KFormat::formatBytes examples

2018-06-19 Thread Aleix Pol Gonzalez 
apol added a comment.


  In D13571#279554 , @bruns wrote:
  
  > In D13571#279550 , @apol wrote:
  >
  > > > The given example is just plain wrong. It does not work, it is just 
some false prosa.
  > >
  > > Fair enough, yet the API user may want to be able to understand what's 
the logic behind it, so if it can be explained on the documentation that could 
be useful.
  >
  >
  > What is "it"?
  >
  > This patch does not change any behaviour, it just ensures the documentation 
matches reality.
  
  
  Don't make me read the code. You are updating documentation, the 
documentation itself needs to offer such information.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D13571

To: bruns, #frameworks
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D13552: [Properties dialog] Improve some permissions-related strings

2018-06-19 Thread Nathaniel Graham 
ngraham added a comment.


  Friendly ping!

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13552

To: ngraham, #frameworks, #vdg, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13554: [Properties dialog] Make all field values on general tab selectable

2018-06-19 Thread Nathaniel Graham 
ngraham added a comment.


  Friendly ping!

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13554

To: ngraham, #frameworks, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13043: Properly sanitize input

2018-06-19 Thread David Faure 
dfaure added a comment.


  BTW, the commit message refers to ModelTest, but that's the old 
modeltest.cpp, not the new QAbstractItemModelTester, right?
  
  I'm working on QConcatenateTablesProxyModel 
(https://codereview.qt-project.org/166323) and there QAbstractItemModelTester 
passes with asserts for all these invalid calls. The old modeltest is now 
considered wrong ;)
  
  Not saying this commit should be reverted or anything, this is just to let 
you know about QAbstractItemModelTester and the fact that the new idea is 
narrow contract, asserting is good, while the old modeltest assumed very 
tolerant model implementations.

REPOSITORY
  R275 KItemModels

REVISION DETAIL
  https://phabricator.kde.org/D13043

To: apol, #frameworks, broulik
Cc: dfaure, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D13442: Implemented displaying of total lines in kate

2018-06-19 Thread Shubham 
shubham added a comment.


  Cullman,brauch,dhaumann : can you please tell how to have a context menu?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13442

To: shubham, #ktexteditor, cullmann, brauch
Cc: firef, mludwig, zhigalin, ngraham, dhaumann, kwrite-devel, 
kde-frameworks-devel, michaelh, kevinapavew, bruns, demsking, head7, cullmann, 
kfunk, sars

D13601: OutputManagement fractional scaling

2018-06-19 Thread David Edmundson 
davidedmundson updated this revision to Diff 36330.
davidedmundson added a comment.


  const

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13601?vs=36318=36330

BRANCH
  davidedmundson/scalef

REVISION DETAIL
  https://phabricator.kde.org/D13601

AFFECTED FILES
  autotests/client/test_wayland_outputdevice.cpp
  autotests/client/test_wayland_outputmanagement.cpp
  src/client/outputconfiguration.cpp
  src/client/outputconfiguration.h
  src/client/outputdevice.cpp
  src/client/outputdevice.h
  src/client/protocols/output-management.xml
  src/client/protocols/outputdevice.xml
  src/client/registry.cpp
  src/server/outputchangeset.cpp
  src/server/outputchangeset.h
  src/server/outputchangeset_p.h
  src/server/outputconfiguration_interface.cpp
  src/server/outputdevice_interface.cpp
  src/server/outputdevice_interface.h
  src/server/outputmanagement_interface.cpp

To: davidedmundson, #kwin
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D13601: OutputManagement fractional scaling

2018-06-19 Thread Vlad Zagorodniy 
zzag added inline comments.

INLINE COMMENTS

> outputconfiguration_interface.cpp:194
> +Q_UNUSED(client);
> +qreal scale = wl_fixed_to_double(scale_fixed);
> +

Nitpick: can be const. :-)

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D13601

To: davidedmundson, #kwin
Cc: zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D13601: OutputManagement fractional scaling

2018-06-19 Thread David Edmundson 
davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  In order to have fractional scaling in kwin, we need to communicate it with 
  kscreen, which means changing the data type in our config protocols.
  
  This introduces a new method on outputdevice and outputconfiguration
  to set/request scale as a float.
  
  wl_output is and should remain unchanged as an int
  
  No urgent rush for reviewing/merging this as it's useless without other 
changes.

TEST PLAN
  Attached unit tests

REPOSITORY
  R127 KWayland

BRANCH
  davidedmundson/scalef

REVISION DETAIL
  https://phabricator.kde.org/D13601

AFFECTED FILES
  autotests/client/test_wayland_outputdevice.cpp
  autotests/client/test_wayland_outputmanagement.cpp
  src/client/outputconfiguration.cpp
  src/client/outputconfiguration.h
  src/client/outputdevice.cpp
  src/client/outputdevice.h
  src/client/protocols/output-management.xml
  src/client/protocols/outputdevice.xml
  src/client/registry.cpp
  src/server/outputchangeset.cpp
  src/server/outputchangeset.h
  src/server/outputchangeset_p.h
  src/server/outputconfiguration_interface.cpp
  src/server/outputdevice_interface.cpp
  src/server/outputdevice_interface.h
  src/server/outputmanagement_interface.cpp

To: davidedmundson, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

2018-06-19 Thread Friedrich W. H. Kossebau 
kossebau added a comment.


  Some quick feedback, though no in-detail review myself for now, not sure I 
will be able later, so needs others as well.

INLINE COMMENTS

> kformat.h:117
> + * @see formatValue
> + */
> +enum class Unit {

Please add missing "@since 5.48"
(as last item, following 
https://community.kde.org/Frameworks/Frameworks_Documentation_Policy#Document_Public_and_Protected_Members)

> kformat.h:134
> + * @see formatValue
> + */
> +enum class UnitPrefix {

@since 5.48

> kformat.h:339
> + * Example:
> + * format.formatValue(1000, KFormat::Unit::Bit, 1, 
> KFormat::UnitPrefix::Kilo) => "1.0 kbit"
> + *

Please wrap example code with tags for nice highlighting, and for that adapt 
also string to be real code, e.g. like this:

  * @code
  * // sets value to "1.0 kbit"
  * auto value = format.formatValue(1000, KFormat::Unit::Bit, 1, 
KFormat::UnitPrefix::Kilo);
  * @endcode

> kformat.h:356
> + * @see BinaryUnitDialect
> + */
> +QString formatValue(double value,

@since 5.48

> kformat.h:367-369
> + * format.formatValue(1000, QStringLiteral("bit"), 1, 
> KFormat::UnitPrefix::Kilo) => "1.0 kbit"
> + * format.formatValue(1000, QStringLiteral("bit/s") => "1.0 kbit/s"
> + * format.formatValue(12.3e6, QStringLiteral("bit/s") => "12.3 Mbit/s"

same code/endcode treatment please

> kformat.h:380
> + * @see UnitPrefix
> + */
> +QString formatValue(double value,

@since 5.48

> kformat.h:382
> +QString formatValue(double value,
> +QString unit,
> +int precision = 1,

pass by const reference -> const QString& unit

That the unitstring argument is modified internally in the private method is a 
current implementation detail which should not leak into the public API

> kformatprivate.cpp:138-145
> +case KFormat::Unit::Bit:
> +unitString = QStringLiteral("bit");
> +break;
> +case KFormat::Unit::Byte:
> +unitString = QStringLiteral("B");
> +break;
> +case KFormat::Unit::Meter:

Are we sure those unit symbols do not need to be localized? What about 
languages using different scripts (cyrillic, chinese, arabic, etc)?

> kformatprivate.cpp:154
> +//: value without prefix, format " "
> +return tr("%1 %2", "no Prefix").arg(numString).arg(unitString);
> +}

Please use multi-argument arg method with string arguments: 
arg(numString).arg(unitString) -> arg(prefixString, unitString)

> kformatprivate.cpp:172
> +//: value with prefix, format " "
> +return tr("%1 %2%3", 
> "MetricBinaryDialect").arg(numString).arg(prefixString).arg(unitString);
> +}

arg(prefixString, unitString)

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D13583

To: bruns, #frameworks
Cc: kossebau, kde-frameworks-devel, astippich, michaelh, ngraham, bruns

D10716: handle wrong password when using sudo which asks for another password

2018-06-19 Thread Harald Sitter 
sitter requested changes to this revision.
This revision now requires changes to proceed.

REPOSITORY
  R299 KDESu

REVISION DETAIL
  https://phabricator.kde.org/D10716

To: jriddell, sitter
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D10716: handle wrong password when using sudo which asks for another password

2018-06-19 Thread Harald Sitter 
sitter added a comment.
Restricted Application edited subscribers, added: kde-frameworks-devel; 
removed: Frameworks.


  ping ping ping

REPOSITORY
  R299 KDESu

REVISION DETAIL
  https://phabricator.kde.org/D10716

To: jriddell, sitter
Cc: kde-frameworks-devel, michaelh, ngraham, bruns, #frameworks

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.9 - Build # 30 - Still Unstable!

2018-06-19 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.9/30/
 Project:
Frameworks kwayland kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 19 Jun 2018 08:16:32 +
 Build duration:
6 min 15 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 43 test(s), Skipped: 0 test(s), Total: 44 test(s)Failed: TestSuite.kwayland-testRemoteAccess
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report57%
(4/7)90%
(225/251)90%
(225/251)84%
(24105/28746)52%
(11791/22732)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client98%
(40/41)98%
(40/41)98%
(11228/11509)49%
(7708/15599)autotests.server100%
(5/5)100%
(5/5)99%
(359/362)49%
(220/446)src.client97%
(69/71)97%
(69/71)84%
(5688/6743)65%
(1782/2752)src.server97%
(111/115)97%
(111/115)86%
(6830/7964)64%
(2081/3256)src.tools0%
(0/2)0%
(0/2)0%
(0/786)0%
(0/346)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/16)tests0%
(0/14)0%
(0/14)0%
(0/1262)0%
(0/317)

KDE CI: Frameworks kwayland kf5-qt5 SUSEQt5.10 - Build # 58 - Still Unstable!

2018-06-19 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20SUSEQt5.10/58/
 Project:
Frameworks kwayland kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 19 Jun 2018 08:16:32 +
 Build duration:
6 min 38 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 43 test(s), Skipped: 0 test(s), Total: 44 test(s)Failed: TestSuite.kwayland-testRemoteAccess
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report57%
(4/7)90%
(225/251)90%
(225/251)84%
(24105/28746)52%
(11792/22732)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client98%
(40/41)98%
(40/41)98%
(11228/11509)49%
(7708/15599)autotests.server100%
(5/5)100%
(5/5)99%
(359/362)49%
(220/446)src.client97%
(69/71)97%
(69/71)84%
(5688/6743)65%
(1783/2752)src.server97%
(111/115)97%
(111/115)86%
(6830/7964)64%
(2081/3256)src.tools0%
(0/2)0%
(0/2)0%
(0/786)0%
(0/346)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/16)tests0%
(0/14)0%
(0/14)0%
(0/1262)0%
(0/317)

KDE CI: Frameworks kwayland kf5-qt5 FreeBSDQt5.10 - Build # 20 - Still Unstable!

2018-06-19 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kwayland%20kf5-qt5%20FreeBSDQt5.10/20/
 Project:
Frameworks kwayland kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 19 Jun 2018 08:16:32 +
 Build duration:
6 min 34 sec and counting
   JUnit Tests
  Name: (root) Failed: 13 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kwayland-testCompositorFailed: TestSuite.kwayland-testDataDeviceFailed: TestSuite.kwayland-testDataSourceFailed: TestSuite.kwayland-testRegionFailed: TestSuite.kwayland-testRemoteAccessFailed: TestSuite.kwayland-testShmPoolFailed: TestSuite.kwayland-testSubCompositorFailed: TestSuite.kwayland-testSubSurfaceFailed: TestSuite.kwayland-testWaylandConnectionThreadFailed: TestSuite.kwayland-testWaylandRegistryFailed: TestSuite.kwayland-testWaylandServerDisplayFailed: TestSuite.kwayland-testWaylandShellFailed: TestSuite.kwayland-testWaylandSurface

D13500: Honor BUILD_TESTING

2018-06-19 Thread Vlad Zagorodniy 
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:2d06b24a86f2: Honor BUILD_TESTING (authored by zzag).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13500?vs=36068=36307

REVISION DETAIL
  https://phabricator.kde.org/D13500

AFFECTED FILES
  CMakeLists.txt

To: zzag, #kwin, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13403: Android: Make it possible to override a target's APK directory

2018-06-19 Thread Volker Krause 
vkrause added inline comments.

INLINE COMMENTS

> ECMAndroidDeployQt.cmake:58
> +COMMAND LANG=C cmake 
> -DINPUT_FILE="${QTANDROID_EXPORTED_TARGET}-deployment.json.in2" 
> -DOUTPUT_FILE="${QTANDROID_EXPORTED_TARGET}-deployment.json" 
> "-DTARGET=$" 
> "-DOUTPUT_DIR=$" 
> "-DEXPORT_DIR=${CMAKE_INSTALL_PREFIX}" 
> "-DECM_ADDITIONAL_FIND_ROOT_PATH=\"${ECM_ADDITIONAL_FIND_ROOT_PATH}\"" 
> "-DANDROID_EXTRA_LIBS=\"${ANDROID_EXTRA_LIBS}\"" -P 
> ${_CMAKE_ANDROID_DIR}/specifydependencies.cmake
> +COMMAND $/androiddeployqt --gradle 
> --input "${QTANDROID_EXPORTED_TARGET}-deployment.json" --output 
> "${EXPORT_DIR}" --android-platform $ENV{ANDROID_NDK_PLATFORM} --deployment 
> bundled ${arguments}
>  )

This seems to introduce a new assumption on ANDRDOID_NDK_PLATFORM being set as 
an environment variable? Should we check for that/document that, or am I 
entirely misreading this somehow?

The rest looks good to me.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D13403

To: apol, #frameworks
Cc: vkrause, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D13500: Honor BUILD_TESTING

2018-06-19 Thread David Edmundson 
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  honor-build-testing

REVISION DETAIL
  https://phabricator.kde.org/D13500

To: zzag, #kwin, davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13500: Honor BUILD_TESTING

2018-06-19 Thread Vlad Zagorodniy 
zzag added a comment.


  Ping.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D13500

To: zzag, #kwin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns