D13805: Present error dialog when user tries to create directory named "." or ".."

[Thomas Marshall]

tmarshall created this revision.
tmarshall added a reviewer: Dolphin.
tmarshall added a project: Dolphin.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
tmarshall requested review of this revision.

REVISION SUMMARY
  BUG: 387449
  
  In Dolphin, when a user tries to create a folder named "." or "..", they are 
presented with a dialog that informs them that since the folder name they 
entered begins with a ".", the folder they are about to create will be hidden. 
This is, of course, misleading. This patch instead presents them with a similar 
dialog, informing them of the error and asking them for a new name.
  
  Before:
  
  F5976307: image.png 
  
  After:
  
  F5976315: image.png 

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13805

AFFECTED FILES
  src/filewidgets/knewfilemenu.cpp

To: tmarshall, #dolphin
Cc: kde-frameworks-devel, michaelh, spoorun, navarromorales, isidorov, firef, 
ngraham, andrebarros, bruns, emmanuelp

D13804: [KRecentDocument] Consider duplicate entries only based on path, not launched app

[Christoph Feck]

cfeck added a comment.


  But if I open the file in Kate, it appears in Kate's "Open Recent" menu, even 
if I previously had opened it in KWrite?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13804

To: ngraham, broulik, #dolphin, #frameworks
Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 - Build # 51 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/51/
 Project:
Frameworks kdelibs4support kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 30 Jun 2018 00:39:58 +
 Build duration:
6 min 11 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.ktabwidget_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report29%
(4/14)43%
(124/291)43%
(124/291)47%
(21610/45959)38%
(13044/34249)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault0%
(0/1)0%
(0/1)0%
(0/87)0%
(0/56)autotests98%
(44/45)98%
(44/45)97%
(11364/11759)50%
(7174/14375)src0%
(0/1)0%
(0/1)0%
(0/4)0%
(0/2)src.kdebugdialog0%
(0/7)0%
(0/7)0%
(0/256)0%
(0/73)src.kdecore76%
(65/86)76%
(65/86)53%
(9471/17864)48%
(5539/11459)src.kdeui19%
(13/68)19%
(13/68)8%
(765/9694)6%
(330/5364)src.kio7%
(2/27)7%
(2/27)0%
(10/2258)0%
(1/1238)src.kioslave.metainfo0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/4)src.kparts0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/12)src.kssl0%
(0/8)0%
(0/8)0%
(0/1807)0%
(0/853)src.kssl.kcm0%
(0/3)0%
(0/3)0%
(0/264)0%
(0/145)src.solid0%
(0/3)0%
(0/3)0%
(0/188)0%
(0/87)src.solid-networkstatus.kded0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/94)tests0%
(0/34)0%
(0/34)0%
(0/1537)0%
(0/487)

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.9 - Build # 24 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.9/24/
 Project:
Frameworks kdelibs4support kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 30 Jun 2018 00:39:58 +
 Build duration:
5 min 59 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.ktabwidget_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report29%
(4/14)43%
(124/291)43%
(124/291)47%
(21745/45961)38%
(13176/34249)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault0%
(0/1)0%
(0/1)0%
(0/87)0%
(0/56)autotests98%
(44/45)98%
(44/45)98%
(11469/11759)50%
(7254/14375)src0%
(0/1)0%
(0/1)0%
(0/4)0%
(0/2)src.kdebugdialog0%
(0/7)0%
(0/7)0%
(0/256)0%
(0/73)src.kdecore76%
(65/86)76%
(65/86)53%
(9501/17866)49%
(5591/11459)src.kdeui19%
(13/68)19%
(13/68)8%
(765/9694)6%
(330/5364)src.kio7%
(2/27)7%
(2/27)0%
(10/2258)0%
(1/1238)src.kioslave.metainfo0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/4)src.kparts0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/12)src.kssl0%
(0/8)0%
(0/8)0%
(0/1807)0%
(0/853)src.kssl.kcm0%
(0/3)0%
(0/3)0%
(0/264)0%
(0/145)src.solid0%
(0/3)0%
(0/3)0%
(0/188)0%
(0/87)src.solid-networkstatus.kded0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/94)tests0%
(0/34)0%
(0/34)0%
(0/1537)0%
(0/487)

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.10 - Build # 11 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.10/11/
 Project:
Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.10
 Date of build:
Sat, 30 Jun 2018 00:39:58 +
 Build duration:
4 min 39 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 37 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kmimetypetestFailed: TestSuite.kstandarddirstest

D11828: Simplify orPostingIterator and make it faster

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> fvogt wrote in orpostingiterator.cpp:86
> Looks like most of those parens  are unnecessary.

only one pair is, the others support readability, see Qt Coding Style:

> Use parentheses to group expressions

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D11828

To: bruns, #baloo, michaelh, #frameworks
Cc: fvogt, kde-frameworks-devel, #frameworks, ashaposhnikov, michaelh, 
astippich, spoorun, ngraham, bruns, abrahams

D13804: [KRecentDocument] Consider duplicate entries only based on path, not launched app

[Nathaniel Graham]

ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13804

To: ngraham, broulik, #dolphin, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13804: [KRecentDocument] Consider duplicate entries only based on path, not launched app

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: broulik, Dolphin, Frameworks.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  BUG: 379129
  FIXED-IN 5.48
  
  `KRecentDocuments` currently checks for duplicate entries, but its criteria 
are very restrictive: not only does the path need to match, but also the app 
that the path was opened with. As a result, if you open a file with two 
different apps (say, Kate and KWrite), you get two entries. From a regular user 
perspective, these are duplicates--especially since the entries are not visibly 
badged in any way with what app they will open with, so they look identical. 
Even if they were, it's not really a useful feature; when you want to access a 
recently-used document, it's highly likely that you just want to use the 
default app to open it.
  
  This patch removed the app-matching criteria and considers an entry a 
duplicate only if its path matches that of an existing entry.

TEST PLAN
  Open the same document with both Kate and KWrite. Only one copt of the 
document shows up in recentdocuments:/ in Dolphin.

REPOSITORY
  R241 KIO

BRANCH
  more-liberal-recent-document-duplicate-detection (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13804

AFFECTED FILES
  src/core/krecentdocument.cpp

To: ngraham, broulik, #dolphin, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13601: OutputManagement fractional scaling

[David Edmundson]

davidedmundson updated this revision to Diff 36919.
davidedmundson added a comment.


  Also emit scale changed when scaleF changes

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13601?vs=36910=36919

REVISION DETAIL
  https://phabricator.kde.org/D13601

AFFECTED FILES
  autotests/client/test_wayland_outputdevice.cpp
  autotests/client/test_wayland_outputmanagement.cpp
  src/client/outputconfiguration.cpp
  src/client/outputconfiguration.h
  src/client/outputdevice.cpp
  src/client/outputdevice.h
  src/client/protocols/output-management.xml
  src/client/protocols/outputdevice.xml
  src/client/registry.cpp
  src/server/outputchangeset.cpp
  src/server/outputchangeset.h
  src/server/outputchangeset_p.h
  src/server/outputconfiguration_interface.cpp
  src/server/outputdevice_interface.cpp
  src/server/outputdevice_interface.h
  src/server/outputmanagement_interface.cpp

To: davidedmundson, #kwin, romangg
Cc: romangg, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D13800: Drop outdated QT_USE_FAST_OPERATOR_PLUS

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:484d5f4ceea2: Drop outdated QT_USE_FAST_OPERATOR_PLUS 
(authored by kossebau).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13800?vs=36900=36917

REVISION DETAIL
  https://phabricator.kde.org/D13800

AFFECTED FILES
  kde-modules/KDEFrameworkCompilerSettings.cmake

To: kossebau, vkrause
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D13601: OutputManagement fractional scaling

[David Edmundson]

davidedmundson updated this revision to Diff 36910.
davidedmundson added a comment.


  Rebase

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13601?vs=36908=36910

REVISION DETAIL
  https://phabricator.kde.org/D13601

AFFECTED FILES
  autotests/client/test_wayland_outputdevice.cpp
  autotests/client/test_wayland_outputmanagement.cpp
  src/client/outputconfiguration.cpp
  src/client/outputconfiguration.h
  src/client/outputdevice.cpp
  src/client/outputdevice.h
  src/client/protocols/output-management.xml
  src/client/protocols/outputdevice.xml
  src/client/registry.cpp
  src/server/outputchangeset.cpp
  src/server/outputchangeset.h
  src/server/outputchangeset_p.h
  src/server/outputconfiguration_interface.cpp
  src/server/outputdevice_interface.cpp
  src/server/outputdevice_interface.h
  src/server/outputmanagement_interface.cpp

To: davidedmundson, #kwin, romangg
Cc: romangg, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D13601: OutputManagement fractional scaling

[David Edmundson]

davidedmundson updated this revision to Diff 36908.
davidedmundson added a comment.


  qFuzzyCompare

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13601?vs=36907=36908

REVISION DETAIL
  https://phabricator.kde.org/D13601

AFFECTED FILES
  autotests/client/test_wayland_outputdevice.cpp
  autotests/client/test_wayland_outputmanagement.cpp
  src/client/outputconfiguration.cpp
  src/client/outputconfiguration.h
  src/client/outputdevice.cpp
  src/client/outputdevice.h
  src/client/protocols/output-management.xml
  src/client/protocols/outputdevice.xml
  src/client/registry.cpp
  src/server/outputchangeset.cpp
  src/server/outputchangeset.h
  src/server/outputchangeset_p.h
  src/server/outputconfiguration_interface.cpp
  src/server/outputdevice_interface.cpp
  src/server/outputdevice_interface.h
  src/server/outputmanagement_interface.cpp

To: davidedmundson, #kwin, romangg
Cc: romangg, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D13601: OutputManagement fractional scaling

[David Edmundson]

davidedmundson updated this revision to Diff 36907.
davidedmundson marked 2 inline comments as done.
davidedmundson added a comment.


  qFuzzyCompare
  
  (not sure it's relevant as the comparison it makes is greater than 
  the resolution of wl_fixed, but whatever)

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13601?vs=36518=36907

REVISION DETAIL
  https://phabricator.kde.org/D13601

AFFECTED FILES
  autotests/client/test_wayland_outputdevice.cpp
  autotests/client/test_wayland_outputmanagement.cpp
  src/client/outputconfiguration.cpp
  src/client/outputconfiguration.h
  src/client/outputdevice.cpp
  src/client/outputdevice.h
  src/client/protocols/output-management.xml
  src/client/protocols/outputdevice.xml
  src/client/registry.cpp
  src/server/outputchangeset.cpp
  src/server/outputchangeset.h
  src/server/outputchangeset_p.h
  src/server/outputconfiguration_interface.cpp
  src/server/outputdevice_interface.cpp
  src/server/outputdevice_interface.h
  src/server/outputmanagement_interface.cpp

To: davidedmundson, #kwin, romangg
Cc: romangg, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

[Alexander Stippich]

astippich accepted this revision.
astippich added a comment.
This revision is now accepted and ready to land.


  working fine here, but someone more qualified should have a look at the code

REPOSITORY
  R244 KCoreAddons

BRANCH
  d13583

REVISION DETAIL
  https://phabricator.kde.org/D13583

To: bruns, #frameworks, astippich
Cc: kossebau, kde-frameworks-devel, astippich, michaelh, ngraham, bruns

D13800: Drop outdated QT_USE_FAST_OPERATOR_PLUS

[Volker Krause]

vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  dropQT_USE_FAST_OPERATOR_PLUS

REVISION DETAIL
  https://phabricator.kde.org/D13800

To: kossebau, vkrause
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D13700: implement reading of the replaygain tags

[Alexander Stippich]

astippich added a comment.


  baloo handles floats actually just fine

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D13700

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D13700: implement reading of the replaygain tags

[Alexander Stippich]

astippich updated this revision to Diff 36901.
astippich added a comment.


  - use floats to store the replaygain tags

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13700?vs=36571=36901

BRANCH
  replaygain

REVISION DETAIL
  https://phabricator.kde.org/D13700

AFFECTED FILES
  autotests/samplefiles/test.flac
  autotests/samplefiles/test.mp3
  autotests/samplefiles/test.mpc
  autotests/samplefiles/test.ogg
  autotests/samplefiles/test.opus
  autotests/taglibextractortest.cpp
  src/extractors/taglibextractor.cpp
  src/extractors/taglibextractor.h
  src/properties.h
  src/propertyinfo.cpp

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D13800: Drop outdated QT_USE_FAST_OPERATOR_PLUS

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Some context from Olivier:
  [15:06]  isn't QT_USE_FAST_CONCATENATION no more a thing since late 
4.8, and in qt5 only QT_USE_FAST_OPERATOR_PLUS is still considered?
  [15:12]  and QT_USE_QSTRINGBUILDER is a superset of 
QT_USE_FAST_OPERATOR_PLUS, so with the initial the latter is not needed, or?
  [15:13]  ogoffart: hi. can you confirm that^ ?
  [16:52]  frinring: yes, QT_USE_QSTRINGBUILDER is the new name
  [16:55]  ogoffart: not just the new name, but also covers 
qbytearray, right? so QT_USE_FAST_CONCATENATION is defunc in qt5, 
QT_USE_FAST_OPERATOR_PLUS undocumented but still covering qstring, and 
QT_USE_QSTRINGBUILDER the documented thing, which covers both qstring & 
qbytearray
  [16:55]  so dropping QT_USE_FAST_CONCATENATION from code is dead 
code clean up, replacing QT_USE_FAST_OPERATOR_PLUS with QT_USE_QSTRINGBUILDER 
needs some check first, right?
  [16:57]  yes, right
  
  And related old blog post: 
http://blog.qt.io/blog/2011/06/13/string-concatenation-with-qstringbuilder/

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D13800

To: kossebau
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D13800: Drop outdated QT_USE_FAST_OPERATOR_PLUS

[Friedrich W. H. Kossebau]

kossebau created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  QT_USE_FAST_OPERATOR_PLUS has been deprecated in Qt 4.8, in favour of
  QT_USE_QSTRINGBUILDER. The latter also covers QByteArray.
  
  Qt5 headers still supports QT_USE_FAST_OPERATOR_PLUS (at least 5.11.1),
  as subset of QT_USE_QSTRINGBUILDER as it was introduced in Qt4.8,
  but not as documented build flag.
  
  Given QT_USE_QSTRINGBUILDER is set here and thus triggers anything that
  QT_USE_FAST_OPERATOR_PLUS would trigger in Qt code, removing it should
  clean up the macro from undocumented features and thus reduce confusion.
  
  No non-Qt is known at least in KDE repos which checks this build flag
  otherwise, so no regression should be expected here as well.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  dropQT_USE_FAST_OPERATOR_PLUS

REVISION DETAIL
  https://phabricator.kde.org/D13800

AFFECTED FILES
  kde-modules/KDEFrameworkCompilerSettings.cmake

To: kossebau
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D13798: Port remaining uses of qDebug() to qcDebug(ATTICA)

[Ralf Habacker]

habacker created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
habacker requested review of this revision.

TEST PLAN
  compiled on linux

REPOSITORY
  R235 Attica

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13798

AFFECTED FILES
  src/atticabasejob.cpp
  src/buildservicejobparser.cpp
  src/parser.cpp
  src/postfiledata.cpp
  src/postjob.cpp
  src/projectparser.cpp
  src/provider.cpp
  src/providermanager.cpp
  src/publisherparser.cpp
  src/putjob.cpp
  src/remoteaccountparser.cpp

To: habacker
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

[Christoph Feck]

cfeck added a comment.


  I don't understand. The brightness should be as close as possible to the 
brightness of the window background, that's why we only used a small blending 
factor. If your window text color is black, and your hightlight background is 
also black (with white highlight text), you see nothing?

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D13777

To: rjvbb, ngraham, #frameworks
Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D13797: Only add actual documents to Recent Documents

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Dolphin, Frameworks, broulik.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  KIO's Recent Documents feature is not as useful as it could be right now 
because KRun and the KURl dialog unconditionally add all URLs to it, so it 
tends to fill up with web links, appstream:/ URLs, and the like.
  
  This patch fixes that by having them only append a URL to Recent Documents if 
it's actually a document.

TEST PLAN
  Compiled, deployed, and rebooted.
  
  Used KRunner to go to https://kde.org and several other websites and then 
navigated to `recentdocuments:/ in Dolphin. No web URLs appeared in the list of 
recent documents.
  
  Opened a random file in Dolphin and then went to `recentdocuments:/`; the 
file still showed up there, as expected.

REPOSITORY
  R241 KIO

BRANCH
  recent-documents-only-shows-actual-documents (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13797

AFFECTED FILES
  src/widgets/krun.cpp
  src/widgets/kurlrequesterdialog.cpp

To: ngraham, #dolphin, #frameworks, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13698: Improve ECMAddAppIconMacro.

[Dominik Schmidt]

dschmidt marked 8 inline comments as done.
dschmidt added inline comments.

INLINE COMMENTS

> cgiboudeaux wrote in ECMAddAppIcon.cmake:161
> 36? It's not mentioned in the doc.

Good catch, I forgot to update this part after I fixed the resolutions in a 
different place.. The resolutions I copied from the original ownCloud macro 
were wrong in the first place, maybe because Apple changed the 
rules/resolutions at some point.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D13698

To: dschmidt, vonreth, vpinon, apol, alexmerry
Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D13698: Improve ECMAddAppIconMacro.

[Dominik Schmidt]

dschmidt updated this revision to Diff 36891.
dschmidt added a comment.


  Fix since version in FindIcoTool too

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13698?vs=36890=36891

BRANCH
  app-icon-modernization

REVISION DETAIL
  https://phabricator.kde.org/D13698

AFFECTED FILES
  docs/find-module/FindIcoTool.rst
  find-modules/FindIcoTool.cmake
  modules/ECMAddAppIcon.cmake
  tests/ECMAddAppIconTest/128-category-name-sidebar.png
  tests/ECMAddAppIconTest/16-category-name-sidebar.png
  tests/ECMAddAppIconTest/CMakeLists.txt
  tests/ECMAddAppIconTest/check_files.cmake.in

To: dschmidt, vonreth, vpinon, apol, alexmerry
Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D13698: Improve ECMAddAppIconMacro.

[Dominik Schmidt]

dschmidt updated this revision to Diff 36890.
dschmidt added a comment.


  Fix comment

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13698?vs=36889=36890

BRANCH
  app-icon-modernization

REVISION DETAIL
  https://phabricator.kde.org/D13698

AFFECTED FILES
  docs/find-module/FindIcoTool.rst
  find-modules/FindIcoTool.cmake
  modules/ECMAddAppIcon.cmake
  tests/ECMAddAppIconTest/128-category-name-sidebar.png
  tests/ECMAddAppIconTest/16-category-name-sidebar.png
  tests/ECMAddAppIconTest/CMakeLists.txt
  tests/ECMAddAppIconTest/check_files.cmake.in

To: dschmidt, vonreth, vpinon, apol, alexmerry
Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D13698: Improve ECMAddAppIconMacro.

[Dominik Schmidt]

dschmidt updated this revision to Diff 36889.
dschmidt added a comment.


  Fix "Since version" and wrong resolutions in a few places

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13698?vs=36719=36889

BRANCH
  app-icon-modernization

REVISION DETAIL
  https://phabricator.kde.org/D13698

AFFECTED FILES
  docs/find-module/FindIcoTool.rst
  find-modules/FindIcoTool.cmake
  modules/ECMAddAppIcon.cmake
  tests/ECMAddAppIconTest/128-category-name-sidebar.png
  tests/ECMAddAppIconTest/16-category-name-sidebar.png
  tests/ECMAddAppIconTest/CMakeLists.txt
  tests/ECMAddAppIconTest/check_files.cmake.in

To: dschmidt, vonreth, vpinon, apol, alexmerry
Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D12820: Add KWayland virtual desktop protocol

[Marco Martin]

mart marked an inline comment as done.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D12820

To: mart, #kwin, #plasma, graesslin, hein
Cc: davidedmundson, zzag, bshah, romangg, kde-frameworks-devel, michaelh, 
ngraham, bruns

D12820: Add KWayland virtual desktop protocol

[Marco Martin]

mart updated this revision to Diff 36888.
mart marked an inline comment as done.
mart added a comment.


  - better comments

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12820?vs=36887=36888

BRANCH
  mart/plasmavirtualdesktop

REVISION DETAIL
  https://phabricator.kde.org/D12820

AFFECTED FILES
  .arclint
  CMakeLists.txt
  autotests/client/CMakeLists.txt
  autotests/client/test_datadevice.cpp
  autotests/client/test_plasma_virtual_desktop.cpp
  autotests/client/test_plasma_window_model.cpp
  autotests/client/test_plasmashell.cpp
  autotests/client/test_wayland_registry.cpp
  autotests/client/test_wayland_surface.cpp
  autotests/client/test_wayland_windowmanagement.cpp
  autotests/client/test_xdg_output.cpp
  autotests/client/test_xdg_shell_v6.cpp
  src/client/CMakeLists.txt
  src/client/plasmashell.cpp
  src/client/plasmashell.h
  src/client/plasmavirtualdesktop.cpp
  src/client/plasmavirtualdesktop.h
  src/client/plasmawindowmanagement.cpp
  src/client/plasmawindowmanagement.h
  src/client/plasmawindowmodel.cpp
  src/client/plasmawindowmodel.h
  src/client/protocols/fullscreen-shell.xml
  src/client/protocols/outputdevice.xml
  src/client/protocols/plasma-shell.xml
  src/client/protocols/plasma-virtual-desktop.xml
  src/client/protocols/plasma-window-management.xml
  src/client/protocols/xdg-output-unstable-v1.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/textinput.h
  src/client/textinput_v0.cpp
  src/client/textinput_v2.cpp
  src/client/xdgoutput.cpp
  src/client/xdgoutput.h
  src/client/xdgshell_v6.cpp
  src/server/CMakeLists.txt
  src/server/datadevice_interface.cpp
  src/server/display.cpp
  src/server/display.h
  src/server/plasmashell_interface.cpp
  src/server/plasmashell_interface.h
  src/server/plasmavirtualdesktop_interface.cpp
  src/server/plasmavirtualdesktop_interface.h
  src/server/plasmawindowmanagement_interface.cpp
  src/server/plasmawindowmanagement_interface.h
  src/server/surface_interface.cpp
  src/server/xdgforeign_v2_interface.cpp
  src/server/xdgoutput_interface.cpp
  src/server/xdgoutput_interface.h
  src/tools/mapping.txt
  tests/plasmasurfacetest.cpp

To: mart, #kwin, #plasma, graesslin, hein
Cc: davidedmundson, zzag, bshah, romangg, kde-frameworks-devel, michaelh, 
ngraham, bruns

D12820: Add KWayland virtual desktop protocol

[Marco Martin]

mart updated this revision to Diff 36887.
mart added a comment.


  - add desktopActivated signal
  - correct behavior for set on all desktops
  - add new tests for on all desktops
  - make the old isOnallVirtualDesktops api work

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12820?vs=36528=36887

BRANCH
  mart/plasmavirtualdesktop

REVISION DETAIL
  https://phabricator.kde.org/D12820

AFFECTED FILES
  .arclint
  CMakeLists.txt
  autotests/client/CMakeLists.txt
  autotests/client/test_datadevice.cpp
  autotests/client/test_plasma_virtual_desktop.cpp
  autotests/client/test_plasma_window_model.cpp
  autotests/client/test_plasmashell.cpp
  autotests/client/test_wayland_registry.cpp
  autotests/client/test_wayland_surface.cpp
  autotests/client/test_wayland_windowmanagement.cpp
  autotests/client/test_xdg_output.cpp
  autotests/client/test_xdg_shell_v6.cpp
  src/client/CMakeLists.txt
  src/client/plasmashell.cpp
  src/client/plasmashell.h
  src/client/plasmavirtualdesktop.cpp
  src/client/plasmavirtualdesktop.h
  src/client/plasmawindowmanagement.cpp
  src/client/plasmawindowmanagement.h
  src/client/plasmawindowmodel.cpp
  src/client/plasmawindowmodel.h
  src/client/protocols/fullscreen-shell.xml
  src/client/protocols/outputdevice.xml
  src/client/protocols/plasma-shell.xml
  src/client/protocols/plasma-virtual-desktop.xml
  src/client/protocols/plasma-window-management.xml
  src/client/protocols/xdg-output-unstable-v1.xml
  src/client/registry.cpp
  src/client/registry.h
  src/client/textinput.h
  src/client/textinput_v0.cpp
  src/client/textinput_v2.cpp
  src/client/xdgoutput.cpp
  src/client/xdgoutput.h
  src/client/xdgshell_v6.cpp
  src/server/CMakeLists.txt
  src/server/datadevice_interface.cpp
  src/server/display.cpp
  src/server/display.h
  src/server/plasmashell_interface.cpp
  src/server/plasmashell_interface.h
  src/server/plasmavirtualdesktop_interface.cpp
  src/server/plasmavirtualdesktop_interface.h
  src/server/plasmawindowmanagement_interface.cpp
  src/server/plasmawindowmanagement_interface.h
  src/server/surface_interface.cpp
  src/server/xdgforeign_v2_interface.cpp
  src/server/xdgoutput_interface.cpp
  src/server/xdgoutput_interface.h
  src/tools/mapping.txt
  tests/plasmasurfacetest.cpp

To: mart, #kwin, #plasma, graesslin, hein
Cc: davidedmundson, zzag, bshah, romangg, kde-frameworks-devel, michaelh, 
ngraham, bruns

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 59 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/59/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.10
 Date of build:
Fri, 29 Jun 2018 14:12:35 +
 Build duration:
7 min 7 sec and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiofilewidgets-kfilewidgettestFailed: TestSuite.kiogui-favicontestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 153 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/153/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 29 Jun 2018 14:12:35 +
 Build duration:
6 min 9 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfilewidgettest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(257/395)65%
(257/395)53%
(31754/59694)38%
(16063/42562)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(54/54)100%
(54/54)95%
(8783/9213)51%
(3846/7606)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(98/116)84%
(98/116)58%
(8363/14397)50%
(4667/9301)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)50%
(3926/7912)34%
(1590/4659)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(525/1013)39%
(315/814)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1775/4320)35%
(1304/3700)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(628/1330)55%
(619/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
(5/9)51%
 

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 304 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/304/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 29 Jun 2018 14:12:35 +
 Build duration:
4 min 56 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfilewidgettest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(257/395)65%
(257/395)53%
(31692/59693)38%
(16055/42564)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(54/54)100%
(54/54)95%
(8783/9213)51%
(3846/7606)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(98/116)84%
(98/116)58%
(8306/14396)50%
(4654/9297)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)50%
(3925/7912)34%
(1589/4659)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(525/1013)39%
(315/814)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4320)35%
(1306/3700)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(629/1330)55%
(620/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
(5/9)51%
  

KDE CI: Frameworks kpackage kf5-qt5 FreeBSDQt5.10 - Build # 11 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kpackage%20kf5-qt5%20FreeBSDQt5.10/11/
 Project:
Frameworks kpackage kf5-qt5 FreeBSDQt5.10
 Date of build:
Fri, 29 Jun 2018 14:08:55 +
 Build duration:
1 min 2 sec and counting
   JUnit Tests
  Name: (root) Failed: 4 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: TestSuite.plasma-packagestructuretestFailed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream

D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

[René J . V . Bertin]

rjvbb updated this revision to Diff 36886.
rjvbb added a comment.


  A new revision:
  
  - makes a start with the requested export of the QSettings functionality
  - drops the alpha tweak and introduces a new experiment:
  
  Since background colours are not obtained from theme colours designed for 
that purpose AND they're mixed with the widget background, I tried to use the 
hardcoded default colours as a reference. Instead of changing the selected 
theme colours in a qualitative fashion they are brightness-corrected to give 
them the same perceived intensity as the default colours as much as that is 
possible in RGB space. Basically this is greyscale normalisation done 
individually for each colour role, and the idea is to achieve a more consistent 
contrast pattern across message roles and themes.
  
  The correction is activated by an env. variable 
(`KMESSAGEWIDGET_BACKGROUND_BRIGHTNESS_MATCHED`). I introduced to make testing 
comparisons easier (= avoid recompilation). The effect is very subtle with the 
Breeze themes (improves readability a bit for the dark ones, I think), stronger 
with my own theme. It may however have unexpected effects so maybe the switch 
should be preserved IF this experiment is maintained.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13777?vs=36858=36886

REVISION DETAIL
  https://phabricator.kde.org/D13777

AFFECTED FILES
  src/kmessagewidget.cpp

To: rjvbb, ngraham, #frameworks
Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

D13777: KMessageWidget : revert to using highlight colour for Information style (WIP)

[René J . V . Bertin]

rjvbb set the repository for this revision to R236 KWidgetsAddons.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D13777

To: rjvbb, ngraham, #frameworks
Cc: cfeck, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kdeclarative kf5-qt5 FreeBSDQt5.10 - Build # 13 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20FreeBSDQt5.10/13/
 Project:
Frameworks kdeclarative kf5-qt5 FreeBSDQt5.10
 Date of build:
Fri, 29 Jun 2018 14:04:50 +
 Build duration:
1 min 41 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)

PSA: Phabricator staging repositories

[Bhushan Shah]

Hello developers,

So in last few days I and Ben has been working on setting up the staging
repositories for phabricator. More information on this feature is
documented as part of Harbormaster documentation [1] change handoff
section.

To explain further, this will allow the people to push commits for
review to a dedicated staging area, which opens up the new possibilities
like,

- Landing the changes directly from Web UI
- Handing over the changes to CI systems like build.kde.org or
  build.neon.kde.org or binary-factory.kde.org which in turn can run the
  build against proposed changes and send status back to review saying
  "Hey! That review doesn't build" or "All Green!"

Currently required changes for those two usecases is not implemented
yet. But, enabling staging repository is the first step in that
direction. Currently we have all pieces to enable the staging area in
the repositories ready, but it is not enabled. As we think we should
notify community about upcoming changes. We will be enabling this feature
in upcoming week.

# So how does staging repository works?

When you create a diff using arcanist, what it does is, push the commit
for which changes were created to tag like phabricator/diff/12345, where
12345 represents the diff ID to different git mirror of mainline git
repositories on git.kde.org.

The URL where this tags will be pushed is,

"stag...@git.kde.org:reponame.git"

One imporant thing to note is, stag...@git.kde.org won't accept the
normal pushes, and for most of the developers this URL is implementation
detail. You should not push direct changes to this repositories.

Also, to allow non-developers to push to the staging area, we have
enabled the option to upload ssh keys for the normal users. The keys
added there will be synced to stag...@git.kde.org automatically allowing
the non-developers to push to staging area.

So in general here is what you should do,

# For users who want to submit the changes to phabricator

Please make sure you have your keys uploaded to identity.kde.org, you
can do it by clicking on "Manage SSH Keys" option in right sidebar
after logging in.

# For both users and developers

Make sure your ~/.ssh/config have entry for stag...@git.kde.org.

Below is example from my ssh config.

Host git.kde.org
HostName git.kde.org
User staging
IdentityFile ~/.ssh/id_rsa_kde

# For maintainers of projects

For some reason you don't want your project to use the staging
repositories on phabricator, or have any questions, please get in touch
with us.

PS: We are interested in getting some beta testing for this feature
before we enable this changes to all repositories, if you maintain a
project and if you are interested in testing this out, please mention
us.

PPS: I have just sent this e-mail to few lists I am subscribed to
(kde-devel, kde-core-devel, kde-frameworks-devel, plasma-devel and
sysadmin list) but if you think I have missed sending this to some list,
feel free to forward it and please make sure to include sysad...@kde.org
or me in reply.

Thanks

[1] https://secure.phabricator.com/book/phabricator/article/harbormaster/

-- 
Bhushan Shah
http://blog.bshah.in
IRC Nick : bshah on Freenode
GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D


signature.asc
Description: PGP signature

D13698: Improve ECMAddAppIconMacro.

[Christophe Giboudeaux]

cgiboudeaux added inline comments.

INLINE COMMENTS

> FindIcoTool.cmake:25
> +#
> +# Since 5.49.
> +

The next release will be 5.48

> ECMAddAppIcon.cmake:11-12
> +#   ICONS  [ [...]]
> +#   [SIDEBAR_ICONS  [ [...]] # Since 5.49
> +#   [OUTFILE_BASENAME ]) # Since 5.49
> +#   )

5.48

> ECMAddAppIcon.cmake:30
> +# icons to the generated iconset. They are used when a folder monitored by 
> the
> +# application is dragged into Finder's sidebar. Since 5.49.
> +#

5.48

> ECMAddAppIcon.cmake:35
> +# and ``.ico`` on Windows. If you don't specify it, it 
> defaults
> +# to ``.``. Since 5.49.
> +#

5.48

> ECMAddAppIcon.cmake:142
>  
> -foreach(icon ${ARG_ICONS})
> -get_filename_component(icon_full ${icon} ABSOLUTE)
> -if (NOT EXISTS "${icon_full}")
> -message(AUTHOR_WARNING "${icon_full} does not exist, ignoring")
> -else()
> -get_filename_component(icon_name ${icon} NAME)
> -string(REGEX MATCH "([0-9]+)\\-[^/]+\\.([a-z]+)$"
> -   _dummy "${icon_name}")
> -set(size  "${CMAKE_MATCH_1}")
> -set(ext   "${CMAKE_MATCH_2}")
> -if (NOT (ext STREQUAL "svg" OR ext STREQUAL "svgz"))
> -if (NOT size)
> -message(AUTHOR_WARNING "${icon_full} is not named 
> correctly for ecm_add_app_icon - ignoring")
> -elseif (NOT ext STREQUAL "png")
> -message(AUTHOR_WARNING "${icon_full} is not a png file - 
> ignoring")
> -else()
> -list(FIND known_sizes "${size}" offset)
> -if (offset GREATER -1)
> -list(APPEND icons_at_${size}px "${icon_full}")
> -endif()
> -endif()
> -endif()
> -endif()
> -endforeach()
> +_ecm_add_app_icon_categorize_icons("${ARG_ICONS}" "icons" 
> "16;32;48;64;128;256;512;1024")
> +if(ARG_SIDEBAR_ICONS)

24 is mentioned in the doc but unused here. Is it expected?

> ECMAddAppIcon.cmake:161
> +  ${sidebar_icons_at_32px}
> +  ${sidebar_icons_at_36px}
> +  ${sidebar_icons_at_64px})

36? It's not mentioned in the doc.

> ECMAddAppIcon.cmake:228
> +
> +foreach(size 16 32 48 64 128 ${maxSize})
> +if(NOT icons_at_${size}px)

not 24 ?

> CMakeLists.txt:14
>  
> -ecm_add_app_icon(OUT ICONS ${ICONS})
> +ecm_add_app_icon(OUT ICONS ${ICONS} SIDEBAR_ICONS ${SIDEBAR_ICONS} 
> OUTFILE_BASENAME "SuperBasename")
>  

The test shouldn't "replace" the simple form. Add a new one instead to have 
both forms tested.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D13698

To: dschmidt, vonreth, vpinon, apol, alexmerry
Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D9446: WIP: Allow to autogenerate and install categories file

[David Faure]

dfaure added a comment.


  On the other hand it means that when you add a new category, you get to 
recompile *everything* :-)

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D9446

To: mlaurent, kfunk, lbeltrame, cgiboudeaux, dfaure, fvogt
Cc: ltoscano, kde-frameworks-devel, kde-buildsystem, habacker, michaelh, 
ngraham, bruns

D13792: Remove unused include

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D13792

To: rempt, #frameworks, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D10166: Add -Wlogical-op -Wzero-as-null-pointer-constant to KF5 warnings

[Albert Astals Cid]

This revision was automatically updated to reflect the committed changes.
Closed by commit R240:60cb4b74bce8: Add -Wlogical-op 
-Wzero-as-null-pointer-constant to KF5 warnings (authored by aacid).

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10166?vs=36684=36880

REVISION DETAIL
  https://phabricator.kde.org/D10166

AFFECTED FILES
  kde-modules/KDEFrameworkCompilerSettings.cmake

To: aacid, cgiboudeaux, apol
Cc: apol, kde-frameworks-devel, kde-buildsystem, cgiboudeaux, dhaumann, 
michaelh, ngraham, bruns

D9446: WIP: Allow to autogenerate and install categories file

[Ralf Habacker]

habacker added a comment.


  In D9446#284185 , @ltoscano wrote:
  
  > There can be more headers file for the same repository, and it has not been 
a problem in practice because the categories usually maps to different groups 
of files in different directories.
  >  See for example kopete, wacomtablet o kgraphviewer.
  
  
  I made a query to the kde git repos about the use of 
ecm_qt_declare_logging_category and got
  
61 kdevelop
57 kdepim-addons
39 kdepim
29 kdepim-runtime
23 plasma-workspace
20 kwin
13 kstars
11 messagelib
11 ark
11 akonadi-import-wizard
10 akonadi

  
  Sure, it works, but is it efficient to have 61 files, for example in 
kdevelop, just to declare debug categories and always have to remember which 
ones to include? 
  In Umbrello, for example, I have only one header file that contains debug 
support, regardless of part of the application.
  
  To have such support, ecm_qt_declare_logging_category only needs to bre able 
to append code fragments to the related header or cpp file

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D9446

To: mlaurent, kfunk, lbeltrame, cgiboudeaux, dfaure, fvogt
Cc: ltoscano, kde-frameworks-devel, kde-buildsystem, habacker, michaelh, 
ngraham, bruns

D13792: Remove unused include

[Boudewijn Rempt]

rempt created this revision.
rempt added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
rempt requested review of this revision.

REVISION SUMMARY
  While trying to figure out how to make kconfig work with qiodevices instead 
of files, I found this.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D13792

AFFECTED FILES
  src/core/kconfigbackend.cpp

To: rempt, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KColorScheme::BackgroundRole and theming

[J.V. Bertin]

Hi,

FYI, I just launched an idea in Visual Design Group forum (https://
forum.kde.org/viewtopic.php?f=285=153023) with an implicit question: is 
there a reason KColorScheme::BackgroundRole was never exposed completely 
to theming?

R.

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10 - Build # 10 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.10/10/
 Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10
 Date of build:
Fri, 29 Jun 2018 06:09:27 +
 Build duration:
1 hr 6 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 20 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kdirwatch_stat_unittest

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 32 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/32/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 29 Jun 2018 06:09:26 +
 Build duration:
1 hr 2 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(69/81)85%
(69/81)75%
(6240/8332)43%
(10010/23181)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2665/2741)49%
(5716/11733)src.desktoptojson100%
(2/2)100%
(2/2)78%
(88/113)38%
(122/322)src.lib50%
(1/2)50%
(1/2)62%
(352/572)26%
(243/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/782)18%
(184/1038)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1049/2827)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(652/767)42%
(968/2303)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)47%
(368/778)44%
(845/1899)src.lib.util100%
(10/10)100%
(10/10)80%
(680/852)52%
(787/1523)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 87 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/87/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 29 Jun 2018 06:09:26 +
 Build duration:
6 min 2 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kdirwatch_stat_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(69/81)85%
(69/81)75%
(6241/8332)43%
(10019/23183)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2667/2741)49%
(5725/11731)src.desktoptojson100%
(2/2)100%
(2/2)78%
(88/113)38%
(123/326)src.lib50%
(1/2)50%
(1/2)61%
(351/572)26%
(243/928)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/782)18%
(184/1038)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1047/2821)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(652/767)42%
(968/2305)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)47%
(368/778)45%
(846/1899)src.lib.util100%
(10/10)100%
(10/10)80%
(680/852)52%
(787/1523)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)