KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.9 - Build # 45 - Fixed!

2018-07-06 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.9/45/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 07 Jul 2018 03:17:18 +
 Build duration:
7 min 53 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report23%
(5/22)27%
(14/52)27%
(14/52)21%
(435/2095)20%
(214/1077)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)97%
(119/123)58%
(56/96)src100%
(8/8)100%
(8/8)75%
(235/312)59%
(124/210)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/136)0%
(0/88)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/12)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/55)0%
(0/20)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/186)0%
(0/69)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/12)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/79)0%
(0/34)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/29)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/215)0%
(0/80)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/82)0%
(0/57)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/233)0%
(0/76)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
(0/92)src.plugins.saveas100%
(1/1)100%
(1/1)57%
(29/51)64%
(28/44)src.plugins.telegram0%
(0/1)0%
(0/1)0%
(0/48)0%
(0/22)src.plugins.youtube0%
(0/4)0%
(0/4)0%
(0/112)0%

KDE CI: Frameworks purpose kf5-qt5 SUSEQt5.10 - Build # 69 - Still Unstable!

2018-07-06 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20purpose%20kf5-qt5%20SUSEQt5.10/69/
 Project:
Frameworks purpose kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 07 Jul 2018 03:17:17 +
 Build duration:
1 min 44 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report23%
(5/22)27%
(14/52)27%
(14/52)19%
(406/2095)17%
(186/1077)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)92%
(113/123)50%
(48/96)src100%
(8/8)100%
(8/8)68%
(212/312)50%
(104/210)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/136)0%
(0/88)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/12)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/55)0%
(0/20)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/186)0%
(0/69)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/12)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/79)0%
(0/34)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/29)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/215)0%
(0/80)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/82)0%
(0/57)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/233)0%
(0/76)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
(0/92)src.plugins.saveas100%
(1/1)100%
(1/1)57%
(29/51)64%
(28/44)src.plugins.telegram0%
(0/1)0%
(0/1)0%
(0/48)0%
(0/22)src.plugins.youtube0%
(0/4)0%
(0/4)0%
(0/112)0%

KDE CI: Frameworks kdewebkit kf5-qt5 FreeBSDQt5.10 - Build # 9 - Fixed!

2018-07-06 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20kdewebkit%20kf5-qt5%20FreeBSDQt5.10/9/
 Project:
Frameworks kdewebkit kf5-qt5 FreeBSDQt5.10
 Date of build:
Fri, 06 Jul 2018 22:59:09 +
 Build duration:
37 sec and counting

KDE CI: Frameworks kdewebkit kf5-qt5 FreeBSDQt5.10 - Build # 8 - Failure!

2018-07-06 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks%20kdewebkit%20kf5-qt5%20FreeBSDQt5.10/8/
 Project:
Frameworks kdewebkit kf5-qt5 FreeBSDQt5.10
 Date of build:
Fri, 06 Jul 2018 22:54:41 +
 Build duration:
21 sec and counting
   CONSOLE OUTPUT
  [...truncated 12.36 KB...] > git config remote.origin.url https://anongit.kde.org/sysadmin/ci-tooling # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/ci-tooling > git fetch --tags --progress https://anongit.kde.org/sysadmin/ci-tooling +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision 607d67774127f681e3bf0191d2382eea58daea47 (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f 607d67774127f681e3bf0191d2382eea58daea47Commit message: "Android: include necessary options for marble"[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/sysadmin/repo-metadata > git init /usr/home/jenkins/workspace/Frameworks kdewebkit kf5-qt5 FreeBSDQt5.10/ci-tooling/repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision 40e76b906b4b270161a877ef9acfde46b10fde1c (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f 40e76b906b4b270161a877ef9acfde46b10fde1cCommit message: "Update translations branch for Latte Dock"[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/kde-build-metadata > git init /usr/home/jenkins/workspace/Frameworks kdewebkit kf5-qt5 FreeBSDQt5.10/ci-tooling/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision 17e9d42733440f6023e15c39873332e56cfb78b1 (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f 17e9d42733440f6023e15c39873332e56cfb78b1Commit message: "Allow stable-qt5-kf5 users to attempt to build digikam..."[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Setup Dependencies)[Pipeline] sh[Frameworks kdewebkit kf5-qt5 FreeBSDQt5.10] Running shell script+ python3.5 -u ci-tooling/helpers/prepare-dependencies.py --product Frameworks --project kdewebkit --branchGroup kf5-qt5 --environment production --platform FreeBSDQt5.10 --installTo /usr/home/jenkins//install-prefix/Traceback (most recent call last):  File "/usr/local/lib/python3.5/urllib/request.py", line 1254, in do_openh.request(req.get_method(), req.selector, req.data, headers)  File "/usr/local/lib/python3.5/http/client.py", line 1107, in requestself._send_request(method, url, body, headers)  File "/usr/local/lib/python3.5/http/client.py", line 1152, in _send_requestself.endheaders(body)  File "/usr/local/lib/python3.5/http/client.py", line 1103, in endheadersself._send_output(message_body)  File "/usr/local/lib/python3.5/http/client.py", line 934, in _send_outputself.send(msg)  File "/usr/local/lib/python3.5/http/client.py", line 877, in sendself.connect()  File "/usr/local/lib/python3.5/http/client.py", line 1253, in connectsuper().connect()  File "/usr/local/lib/python3.5/http/client.py", line 849, in connect(self.host,self.port), self.timeout, self.source_address)  File "/usr/local/lib/python3.5/socket.py", line 712, in create_connectionraise err  File "/usr/local/lib/python3.5/socket.py", line 703, in create_connectionsock.connect(sa)ConnectionRefusedError: [Errno 61] Connection refusedDuring handling of the above exception, another exception occurred:Traceback (most recent call last):  File "ci-tooling/helpers/prepare-dependencies.py", line 60, in

D13814: Speedup sort

2018-07-06 Thread Jaime Torres Amate 
jtamate added a comment.


  I really, really hate these things. 
  I've been testing this patch more than one month without any problem.
  And now, after pushing it, I got crashes everytime I start dolphin without 
parameters (user home).
  But not if I start it in / and keep changing directories, including user home.
  
  Please, test dolphin with latest sources.
  
  #6  0x7fc0ba4e5904 in 
icu_61_1::RuleBasedCollator::getAttribute(UColAttribute, UErrorCode&) const () 
from /usr/lib64/libicui18n.so.61.1
  #7  0x7fc0ba4e6dc6 in 
icu_61_1::RuleBasedCollator::setAttribute(UColAttribute, UColAttributeValue, 
UErrorCode&) () from /usr/lib64/libicui18n.so.61.1
  #8  0x7fc0c0dfec25 in QCollatorPrivate::init() () at 
tools/qcollator_icu.cpp:82
  #9  0x7fc0c0dfedab in QCollator::compare (this=0x1928070, s1=0x1bd6b98, 
len1=19, s2=0x1d70af8, len2=17) at tools/qcollator_icu.cpp:109
  #10 0x7fc0c880ac30 in KFileItemModel::sortRoleCompare 
(this=this@entry=0x1928040, a=a@entry=0x1c0e1f0, b=b@entry=0x1cfbdf0, 
collator=...) at 
/g/5kde/kde/applications/dolphin/src/kitemviews/kfileitemmodel.cpp:1836
  #11 0x7fc0c880b2a2 in KFileItemModel::lessThan 
(this=this@entry=0x1928040, a=0x1c0e1f0, b=0x1cfbdf0, collator=...) at 
/g/5kde/kde/applications/dolphin/src/kitemviews/kfileitemmodel.cpp:1707
  #12 0x7fc0c8811715 in KFileItemModeloperator() 
(__closure=0x7ffe8d4307a8, b=, a=) at 
/g/5kde/kde/applications/dolphin/src/kitemviews/kfileitemmodel.cpp:1717

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D13814

To: jtamate, #dolphin, #frameworks, markg, elvisangelaccio
Cc: elvisangelaccio, apol, bruns, markg, kfm-devel, spoorun, navarromorales, 
firef, andrebarros, emmanuelp

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 68 - Still Unstable!

2018-07-06 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/68/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.10
 Date of build:
Fri, 06 Jul 2018 20:05:10 +
 Build duration:
6 min 23 sec and counting
   JUnit Tests
  Name: (root) Failed: 5 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiofilewidgets-kfilewidgettestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 67 - Still Unstable!

2018-07-06 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/67/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.10
 Date of build:
Fri, 06 Jul 2018 15:07:25 +
 Build duration:
4 hr 57 min and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 51 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiocore-threadtestFailed: TestSuite.kiofilewidgets-kfilewidgettestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

KDE CI: Frameworks kauth kf5-qt5 WindowsMSVCQt5.10 - Build # 18 - Unstable!

2018-07-06 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kauth%20kf5-qt5%20WindowsMSVCQt5.10/18/
 Project:
Frameworks kauth kf5-qt5 WindowsMSVCQt5.10
 Date of build:
Fri, 06 Jul 2018 16:25:05 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.KAuthHelperTest

D13926: Avoid warnings for PolkitQt5-1 headers

2018-07-06 Thread Friedrich W. H. Kossebau 
kossebau created this revision.
kossebau added a reviewer: shumski.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Adding the include dir as SYSTEM makes the compiler skip warnings
  for headers in that path

REPOSITORY
  R283 KAuth

BRANCH
  polkitheaderassystemones

REVISION DETAIL
  https://phabricator.kde.org/D13926

AFFECTED FILES
  src/ConfigureChecks.cmake

To: kossebau, shumski
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13635: Fixes for Java comments

2018-07-06 Thread Volker Krause 
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:8f28e0b576e1: Fixes for Java comments (authored by 
vkrause).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D13635?vs=36400=37274#toc

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13635?vs=36400=37274

REVISION DETAIL
  https://phabricator.kde.org/D13635

AFFECTED FILES
  autotests/folding/highlight.java.fold
  autotests/html/highlight.java.html
  autotests/input/highlight.java
  autotests/reference/highlight.java.ref
  data/syntax/java.xml
  data/syntax/javadoc.xml

To: vkrause, dhaumann
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.10 - Build # 28 - Fixed!

2018-07-06 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20FreeBSDQt5.10/28/
 Project:
Frameworks syntax-highlighting kf5-qt5 FreeBSDQt5.10
 Date of build:
Fri, 06 Jul 2018 15:34:50 +
 Build duration:
6 min 22 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 8 test(s)

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10 - Build # 102 - Fixed!

2018-07-06 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.10/102/
 Project:
Frameworks syntax-highlighting kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 06 Jul 2018 15:34:50 +
 Build duration:
5 min 22 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 9 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)82%
(27/33)82%
(27/33)79%
(2274/2891)68%
(1562/2301)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(8/8)100%
(8/8)97%
(499/512)63%
(243/388)examples0%
(0/2)0%
(0/2)0%
(0/197)0%
(0/98)src.cli0%
(0/1)0%
(0/1)0%
(0/67)0%
(0/30)src.indexer100%
(1/1)100%
(1/1)76%
(179/236)76%
(153/202)src.lib86%
(18/21)86%
(18/21)85%
(1596/1879)74%
(1166/1583)

KDE CI: Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9 - Build # 44 - Fixed!

2018-07-06 Thread CI System 
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20SUSEQt5.9/44/
 Project:
Frameworks syntax-highlighting kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 06 Jul 2018 15:34:50 +
 Build duration:
3 min 42 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 9 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report60%
(3/5)82%
(27/33)82%
(27/33)79%
(2274/2891)68%
(1562/2301)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(8/8)100%
(8/8)97%
(499/512)63%
(243/388)examples0%
(0/2)0%
(0/2)0%
(0/197)0%
(0/98)src.cli0%
(0/1)0%
(0/1)0%
(0/67)0%
(0/30)src.indexer100%
(1/1)100%
(1/1)76%
(179/236)76%
(153/202)src.lib86%
(18/21)86%
(18/21)85%
(1596/1879)74%
(1166/1583)

D13898: Use non deprecated fastInsert in file.cpp (first of many to come)

2018-07-06 Thread Stefan Brüns 
bruns added inline comments.

INLINE COMMENTS

> file.cpp:889
> +#if HAVE_POSIX_ACL
> +targetPath = linkTarget.toLocal8Bit();
> +#endif

isn't this the same as linkTargetBuffer?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13898

To: jtamate, dfaure, #frameworks
Cc: bruns, kde-frameworks-devel, michaelh, ngraham

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 312 - Still Unstable!

2018-07-06 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/312/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 06 Jul 2018 15:11:53 +
 Build duration:
6 min 10 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfilewidgettest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(257/395)65%
(257/395)53%
(31659/59659)38%
(16037/42564)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(54/54)100%
(54/54)95%
(8744/9173)51%
(3844/7606)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(98/116)84%
(98/116)58%
(8312/14402)50%
(4648/9297)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)50%
(3925/7912)34%
(1589/4659)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(525/1013)39%
(315/814)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1775/4320)35%
(1304/3700)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(629/1330)55%
(620/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
(5/9)51%

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 158 - Still Unstable!

2018-07-06 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/158/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 06 Jul 2018 15:10:37 +
 Build duration:
4 min 37 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfilewidgettest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(257/395)65%
(257/395)53%
(31718/59660)38%
(16066/42562)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(54/54)100%
(54/54)95%
(8744/9173)51%
(3844/7606)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(98/116)84%
(98/116)58%
(8371/14403)50%
(4672/9301)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)50%
(3926/7912)34%
(1590/4659)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(525/1013)39%
(315/814)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1775/4320)35%
(1304/3700)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(628/1330)55%
(619/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
(5/9)51%

D13814: Speedup sort

2018-07-06 Thread Jaime Torres Amate 
This revision was automatically updated to reflect the committed changes.
Closed by commit R318:63825de82f3a: Speedup sort (authored by jtamate).

REPOSITORY
  R318 Dolphin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13814?vs=37182=37273

REVISION DETAIL
  https://phabricator.kde.org/D13814

AFFECTED FILES
  src/kitemviews/kfileitemmodel.cpp
  src/kitemviews/kfileitemmodel.h

To: jtamate, #dolphin, #frameworks, markg, elvisangelaccio
Cc: elvisangelaccio, apol, bruns, markg, kfm-devel, spoorun, navarromorales, 
firef, andrebarros, emmanuelp

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 311 - Still Unstable!

2018-07-06 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/311/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 06 Jul 2018 15:07:25 +
 Build duration:
4 min 27 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfilewidgettest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(257/395)65%
(257/395)53%
(31651/59658)38%
(16036/42564)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(54/54)100%
(54/54)95%
(8744/9173)51%
(3844/7606)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(98/116)84%
(98/116)58%
(8304/14401)50%
(4645/9297)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)50%
(3925/7912)34%
(1589/4659)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(525/1013)39%
(315/814)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1775/4320)35%
(1304/3700)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(629/1330)55%
(620/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
(5/9)51%

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 157 - Still Unstable!

2018-07-06 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/157/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 06 Jul 2018 14:48:05 +
 Build duration:
22 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfilewidgettest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(257/395)65%
(257/395)53%
(31747/59660)38%
(16082/42562)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(54/54)100%
(54/54)95%
(8744/9173)51%
(3846/7606)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(98/116)84%
(98/116)58%
(8384/14403)50%
(4674/9301)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)50%
(3925/7912)34%
(1589/4659)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(526/1013)39%
(316/814)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4320)35%
(1306/3700)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(628/1330)55%
(619/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
(5/9)52%

D13917: Use non deprecated fastInsert in renameDialog

2018-07-06 Thread Jaime Torres Amate 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:e7bd1c4b0abe: Use non deprecated fastInsert in 
renameDialog (authored by jtamate).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13917?vs=37231=37271

REVISION DETAIL
  https://phabricator.kde.org/D13917

AFFECTED FILES
  src/widgets/renamedialog.cpp

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13916: Use non deprecated fastInsert in slaveBase

2018-07-06 Thread Jaime Torres Amate 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:be6075a2659f: Use non deprecated fastInsert in slaveBase 
(authored by jtamate).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13916?vs=37230=37270

REVISION DETAIL
  https://phabricator.kde.org/D13916

AFFECTED FILES
  src/core/slavebase.cpp

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 66 - Still Unstable!

2018-07-06 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/66/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.10
 Date of build:
Fri, 06 Jul 2018 15:01:43 +
 Build duration:
4 min 12 sec and counting
   JUnit Tests
  Name: (root) Failed: 5 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiofilewidgets-kfilewidgettestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 310 - Still Unstable!

2018-07-06 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/310/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 06 Jul 2018 15:01:10 +
 Build duration:
4 min 26 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfilewidgettest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(257/395)65%
(257/395)53%
(31654/59658)38%
(16035/42564)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(54/54)100%
(54/54)95%
(8744/9173)51%
(3844/7606)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(98/116)84%
(98/116)58%
(8302/14401)50%
(4642/9297)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)50%
(3925/7912)34%
(1589/4659)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(525/1013)39%
(315/814)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1775/4320)35%
(1304/3700)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(629/1330)55%
(620/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
(5/9)51%

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 65 - Still Unstable!

2018-07-06 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/65/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.10
 Date of build:
Fri, 06 Jul 2018 14:57:46 +
 Build duration:
3 min 54 sec and counting
   JUnit Tests
  Name: (root) Failed: 5 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiofilewidgets-kfilewidgettestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

D13918: Use non deprecated fastInsert in kio_trash

2018-07-06 Thread Jaime Torres Amate 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:7b1210091c55: Use non deprecated fastInsert in kio_trash 
(authored by jtamate).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13918?vs=37232=37265

REVISION DETAIL
  https://phabricator.kde.org/D13918

AFFECTED FILES
  src/ioslaves/trash/kio_trash.cpp

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13918: Use non deprecated fastInsert in kio_trash

2018-07-06 Thread Jaime Torres Amate 
jtamate edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13918

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 309 - Still Unstable!

2018-07-06 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/309/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 06 Jul 2018 14:55:03 +
 Build duration:
4 min 42 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfilewidgettest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(257/395)65%
(257/395)53%
(31650/59658)38%
(16037/42564)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(54/54)100%
(54/54)95%
(8744/9173)51%
(3846/7606)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(98/116)84%
(98/116)58%
(8303/14401)50%
(4646/9297)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)50%
(3925/7912)34%
(1589/4659)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(525/1013)39%
(315/814)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1775/4320)35%
(1304/3700)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(629/1330)55%
(620/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
(5/9)51%

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 64 - Still Unstable!

2018-07-06 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/64/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.10
 Date of build:
Fri, 06 Jul 2018 14:53:01 +
 Build duration:
4 min 40 sec and counting
   JUnit Tests
  Name: (root) Failed: 5 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiofilewidgets-kfilewidgettestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 308 - Still Unstable!

2018-07-06 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/308/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 06 Jul 2018 14:48:05 +
 Build duration:
6 min 56 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 57 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiofilewidgets-kfilewidgettest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(257/395)65%
(257/395)53%
(31673/59659)38%
(16042/42564)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(54/54)100%
(54/54)95%
(8742/9173)51%
(3843/7606)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(98/116)84%
(98/116)58%
(8323/14402)50%
(4650/9297)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)50%
(3925/7912)34%
(1589/4659)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(525/1013)39%
(315/814)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1775/4320)35%
(1304/3700)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(629/1330)55%
(620/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
(5/9)51%

D13915: Use non deprecated fastInsert in file_unix

2018-07-06 Thread Jaime Torres Amate 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:7048d259529f: Use non deprecated fastInsert in file_unix 
(authored by jtamate).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13915?vs=37227=37264

REVISION DETAIL
  https://phabricator.kde.org/D13915

AFFECTED FILES
  src/ioslaves/file/file_unix.cpp

To: jtamate, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13913: Use non deprecated fastInsert and replace in http.cpp

2018-07-06 Thread Jaime Torres Amate 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:de53875a6f52: Use non deprecated fastInsert and replace 
in http.cpp (authored by jtamate).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13913?vs=37225=37263

REVISION DETAIL
  https://phabricator.kde.org/D13913

AFFECTED FILES
  src/ioslaves/http/http.cpp

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 63 - Still Unstable!

2018-07-06 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/63/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.10
 Date of build:
Fri, 06 Jul 2018 14:48:05 +
 Build duration:
4 min 54 sec and counting
   JUnit Tests
  Name: (root) Failed: 5 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiofilewidgets-kfilewidgettestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

D13912: Use non deprecated replace in ForwardingSlave

2018-07-06 Thread Jaime Torres Amate 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:30a0b32d10e4: Use non deprecated replace in 
ForwardingSlave (authored by jtamate).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13912?vs=37224=37262

REVISION DETAIL
  https://phabricator.kde.org/D13912

AFFECTED FILES
  src/core/forwardingslavebase.cpp

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13910: Use non deprecated fastInsert in remoteimpl.cpp

2018-07-06 Thread Jaime Torres Amate 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:b4708f4ce2ec: Use non deprecated fastInsert in 
remoteimpl.cpp (authored by jtamate).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13910?vs=37221=37261

REVISION DETAIL
  https://phabricator.kde.org/D13910

AFFECTED FILES
  src/ioslaves/remote/remoteimpl.cpp

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13909: Use non deprecated fastInsert in kfileitemtest

2018-07-06 Thread Jaime Torres Amate 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:c2bd52926734: Use non deprecated fastInsert in 
kfileitemtest (authored by jtamate).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13909?vs=37219=37260

REVISION DETAIL
  https://phabricator.kde.org/D13909

AFFECTED FILES
  autotests/kfileitemtest.cpp

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13908: Use non deprecated fastInsert in ftp.cpp

2018-07-06 Thread Jaime Torres Amate 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:f4b6e71c6839: Use non deprecated fastInsert in ftp.cpp 
(authored by jtamate).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13908?vs=37218=37259

REVISION DETAIL
  https://phabricator.kde.org/D13908

AFFECTED FILES
  src/ioslaves/ftp/ftp.cpp

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13880: [KMoreTools] Reduce menu hierarchy

2018-07-06 Thread gregormi 
gregormi added a comment.


  The spirit goes in the right direction; please proceed :-). Note, that Kate's 
project plugin also uses KMoreTools.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D13880

To: nicolasfella, gregormi, dhaumann, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13880: [KMoreTools] Reduce menu hierarchy

2018-07-06 Thread Nathaniel Graham 
ngraham added a comment.


  Sounds good to me! It sounds like we're all in agreement?

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D13880

To: nicolasfella, gregormi, dhaumann, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13635: Fixes for Java comments

2018-07-06 Thread Dominik Haumann 
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  I'll give the OK, but please increase kateversion to 5.0 first.

INLINE COMMENTS

> javadoc.xml:3
>  
> - extensions="" license="LGPL" author="Alfredo Luiz Foltran Fialho 
> (alfolt...@ig.com.br)">
> + extensions="" license="LGPL" author="Alfredo Luiz Foltran Fialho 
> (alfolt...@ig.com.br)">
>   

kateversion="5.0", since you use dsAnnotation (iirc).

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13635

To: vkrause, dhaumann
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D13627: [KIconThemes] Isolate private data from race conditions

2018-07-06 Thread Anthony Fieroni 
anthonyfieroni added a comment.


  
https://phabricator.kde.org/source/kiconthemes/browse/master/src/kiconloader.cpp$603
  So the problem maybe not here as IconLoader loads icons but in icon writer
  @davidedmundson , @dfaure who writes icon-cache.kcache in ~/.cache ?

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D13627

To: anthonyfieroni, davidedmundson, dfaure, #frameworks, hein
Cc: hein, kde-frameworks-devel, michaelh, ngraham, bruns

D13358: Add new class that is a model of numbers between two values

2018-07-06 Thread Volker Krause 
vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R275 KItemModels

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13358

To: davidedmundson, vkrause
Cc: broulik, markg, kde-frameworks-devel, michaelh, ngraham, bruns

D13921: Don't show confirmation dialog for Trash action by default

2018-07-06 Thread Алексей Шилин 
aleksejshilin created this revision.
aleksejshilin added a reviewer: dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
aleksejshilin requested review of this revision.

REVISION SUMMARY
  Dolphin and KIO default confirmation settings were not in sync: the former
  defaults to not showing the dialog while the latter used to default to the
  opposite.
  
  This change resolves the inconsistency by adjusting KIO defaults.
  
  BUG: 385492

TEST PLAN
  1. Create a new user account and log into it.
  2. Open Dolphin.
  3. Create a text file and hit Del. The confirmation dialog should *not* 
appear.
  4. Check that permanent deletion (Shift+Del) and emptying the Trash still 
show the confirmation dialog.

REPOSITORY
  R241 KIO

BRANCH
  dont_confirm_trash

REVISION DETAIL
  https://phabricator.kde.org/D13921

AFFECTED FILES
  src/widgets/jobuidelegate.cpp

To: aleksejshilin, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13898: Use non deprecated fastInsert in file.cpp (first of many to come)

2018-07-06 Thread Jaime Torres Amate 
jtamate updated this revision to Diff 37240.
jtamate marked 2 inline comments as done.
jtamate added a comment.


  Incorporated Stephan code.
  Fill again the extra data like User/Group. 
  I don't see any change and I don't want to break anything more.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13898?vs=37216=37240

REVISION DETAIL
  https://phabricator.kde.org/D13898

AFFECTED FILES
  src/ioslaves/file/file.cpp

To: jtamate, dfaure, #frameworks
Cc: bruns, kde-frameworks-devel, michaelh, ngraham

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 62 - Still Unstable!

2018-07-06 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/62/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.10
 Date of build:
Fri, 06 Jul 2018 09:51:06 +
 Build duration:
5 min 36 sec and counting
   JUnit Tests
  Name: (root) Failed: 5 test(s), Passed: 52 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiofilewidgets-kfilewidgettestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

D13898: Use non deprecated fastInsert in file.cpp (first of many to come)

2018-07-06 Thread Stefan Brüns 
bruns added inline comments.

INLINE COMMENTS

> jtamate wrote in file.cpp:864
> According to the man page (2+3), readlink() //does not append a null byte to 
> buf//.
> 
>   It will (silently) truncate the contents (to a length of bufsiz 
> characters), in case the buffer is too small to hold all of the contents.

The comment does not solve the issue, neither does it help to clarify anything 
...

`buffersize` has to be larger than buff.st_size, otherwise there is no 
possibility to diffentiate the 'fits exactly' and 'was truncated' cases, both 
will return `n == buffersize`.

the correct fix is to use:

  // Add one to the size, to be able to detect truncation -
  // in case n == bufferSize, truncation *may* have occured
  size_t bufferSize = qBound(lowerLimit, buff.st_size + 1, 1024);

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13898

To: jtamate, dfaure, #frameworks
Cc: bruns, kde-frameworks-devel, michaelh, ngraham

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 61 - Still Unstable!

2018-07-06 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/61/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.10
 Date of build:
Thu, 05 Jul 2018 17:29:45 +
 Build duration:
16 hr and counting
   JUnit Tests
  Name: (root) Failed: 8 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 57 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiocore-threadtestFailed: TestSuite.kiofilewidgets-kfileplacesmodeltestFailed: TestSuite.kiofilewidgets-kfilewidgettestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltestFailed: TestSuite.kiowidgets-krununittest

D12945: kcoredirlister lstItems benchmark

2018-07-06 Thread David Faure 
dfaure added a comment.


  It's also interesting to look at numbers for small directories (which is 
still the most common case, too).
  
  This code could use a run of uncrustify to match the coding style of the rest 
of kio, but otherwise it looks good.

INLINE COMMENTS

> kcoredirlister_benchmark.cpp:372
> +//BEGIN List
> +// List Implementation (without the NonMovable part)
> +class ListImplementation:public Base

In the long run, people will really wonder what's that about, since your other 
commit will remove the NonMovableList class/hack ;)

> kcoredirlister_benchmark.cpp:679
> +data.f.setMimeFilter(QStringList("text/text"));
> +QUrl directoryUrl = QUrl::fromLocalFile("");
> +// Add every item in data.lstItems

fromLocalFile("") doesn't look valid to me

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12945

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13698: Improve ECMAddAppIconMacro.

2018-07-06 Thread Christophe Giboudeaux 
cgiboudeaux added a comment.


  The 5.48 release is close. Don't forget to push these changes.

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  app-icon-modernization

REVISION DETAIL
  https://phabricator.kde.org/D13698

To: dschmidt, vonreth, vpinon, apol, alexmerry, cgiboudeaux
Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D13627: [KIconThemes] Isolate private data from race conditions

2018-07-06 Thread David Faure 
dfaure added a comment.


  "global map that holds per thread iconloader instances" is called 
QThreadStorage.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D13627

To: anthonyfieroni, davidedmundson, dfaure, #frameworks, hein
Cc: hein, kde-frameworks-devel, michaelh, ngraham, bruns

D10742: get rid of the raw KFileItem pointers in KCoreDirListerCache

2018-07-06 Thread David Faure 
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Since the goal is to speed up findByUrl, can you add a Q_BENCHMARK for 
findByUrl?
  I do expect it to be faster of course --- a little bit at the expense of the 
code which modifies items and now has to reinsert them (and that code is hard 
to benchmark, it's mostly called from async slots...).
  
  Thanks.

INLINE COMMENTS

> kcoredirlister.cpp:2463
>  Q_ASSERT(!item.isNull());
> -(*lstNewItems)[directoryUrl].append(item);  // items not 
> filtered
> +(lstNewItems)[directoryUrl].append(item);  // items not 
> filtered
>  } else {

The parenthesis around lstNewItems can be removed now.

> kcoredirlister.cpp:2476
> +auto kit = items.cbegin();
> +const auto kend = items.end();
>  for (; kit != kend; ++kit) {

end() inconsistent with cbegin() on the line just above.

Works because the container is const, but still, better be consistent.

> kcoredirlister.cpp:2489
>  Q_ASSERT(!item.isNull());
> -(*lstNewItems)[directoryUrl].append(item);
> +(lstNewItems)[directoryUrl].append(item);
>  } else {

The parenthesis around lstNewItems can be removed now.

> kcoredirlister.cpp:2691
> +foreach (const KFileItem , *allItems) {
> +result.append(item);
> +}

Is this loop necessary? Can't we return KFileItemList(*allItems) ? There's such 
a ctor in KFileItemList.

> kcoredirlister_p.h:308
> +auto it = std::lower_bound(dirItem->lstItems.begin(), 
> dirItem->lstItems.end(), oldUrl);
> +dirItem->lstItems.erase(it);
> +dirItem->insert(item);

This is invalid code in case lower_bound() returns end().

If you're sure it "shouldn't happen" because reinsert is always called for 
items that are already in lstItems, then add a Q_ASSERT. Otherwise if().

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10742

To: jtamate, #frameworks, dfaure
Cc: bruns, kde-frameworks-devel, mwolff, markg, michaelh, ngraham

D13676: Make it possible to change directory up even with trailing slashes in the url

2018-07-06 Thread David Faure 
dfaure added a comment.


  Unittests would help ;)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13676

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13917: Use non deprecated fastInsert in renameDialog

2018-07-06 Thread David Faure 
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13917

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13916: Use non deprecated fastInsert in slaveBase

2018-07-06 Thread David Faure 
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13916

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13918: Use non deprecated fastInsert in kio_trash

2018-07-06 Thread David Faure 
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  I remember there were good reasons for not setting UDS_LOCAL_PATH in 
kio_trash, but by now I forgot what they were exactly :-)
  
  I expect that some code will resolve to local paths before getting a chance 
to notice that it's in fact a trash url and trigger trash-specific code.
  But feel free to test that, provided the testing is complete enough :)
  (context menu, properties dialog, dnd for restoring, ...). That last one is a 
good one, we need to make sure kio_trash is involved otherwise the .trashinfo 
file won't get cleaned up.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13918

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13918: Use non deprecated fastInsert in kio_trash

2018-07-06 Thread Jaime Torres Amate 
jtamate created this revision.
jtamate added reviewers: dfaure, Frameworks.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
jtamate requested review of this revision.

REVISION SUMMARY
  This is the last one for kio
  The entry is cleared or new before calling createUDSEntry
  
  By the way, to fix https://bugs.kde.org/show_bug.cgi?id=368104
  Is it right to add KIO::UDSEntry::UDS_LOCAL_PATH in createUDSEntry?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13918

AFFECTED FILES
  src/ioslaves/trash/kio_trash.cpp

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13915: Use non deprecated fastInsert in file_unix

2018-07-06 Thread David Faure 
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13915

To: jtamate, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13913: Use non deprecated fastInsert and replace in http.cpp

2018-07-06 Thread David Faure 
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13913

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13917: Use non deprecated fastInsert in renameDialog

2018-07-06 Thread Jaime Torres Amate 
jtamate created this revision.
jtamate added reviewers: dfaure, Frameworks.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
jtamate requested review of this revision.

REVISION SUMMARY
  The entries are local variables.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13917

AFFECTED FILES
  src/widgets/renamedialog.cpp

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13912: Use non deprecated replace in ForwardingSlave

2018-07-06 Thread David Faure 
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13912

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13910: Use non deprecated fastInsert in remoteimpl.cpp

2018-07-06 Thread David Faure 
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13910

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13909: Use non deprecated fastInsert in kfileitemtest

2018-07-06 Thread David Faure 
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13909

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13908: Use non deprecated fastInsert in ftp.cpp

2018-07-06 Thread David Faure 
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13908

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13916: Use non deprecated fastInsert in slaveBase

2018-07-06 Thread Jaime Torres Amate 
jtamate created this revision.
jtamate added reviewers: dfaure, Frameworks.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
jtamate requested review of this revision.

REVISION SUMMARY
  Entry is local.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13916

AFFECTED FILES
  src/core/slavebase.cpp

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13782: RFC: Ignore NTFS hidden flag for root volume

2018-07-06 Thread Kai Uwe Broulik 
broulik updated this revision to Diff 37229.
broulik added a comment.


  Also check for `DT_UNKNOWN`

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13782?vs=36838=37229

REVISION DETAIL
  https://phabricator.kde.org/D13782

AFFECTED FILES
  src/ioslaves/file/file_unix.cpp

To: broulik, dfaure, ngraham, yurikoles, bruns
Cc: wbauer, kde-frameworks-devel, michaelh, ngraham, bruns

D13782: RFC: Ignore NTFS hidden flag for root volume

2018-07-06 Thread Jaime Torres Amate 
jtamate added a dependent revision: D13915: Use non deprecated fastInsert in 
file_unix.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13782

To: broulik, dfaure, ngraham, yurikoles, bruns
Cc: wbauer, kde-frameworks-devel, michaelh, ngraham, bruns

D13915: Use non deprecated fastInsert in file_unix

2018-07-06 Thread Jaime Torres Amate 
jtamate added a dependency: D13782: RFC: Ignore NTFS hidden flag for root 
volume.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13915

To: jtamate, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13915: Use non deprecated fastInsert in file_unix

2018-07-06 Thread Jaime Torres Amate 
jtamate created this revision.
jtamate added a reviewer: dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
jtamate requested review of this revision.

REVISION SUMMARY
  The entry is local.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13915

AFFECTED FILES
  src/ioslaves/file/file_unix.cpp

To: jtamate, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13914: Avoid compiler warnings for taglib headers

2018-07-06 Thread Matthieu Gallien 
mgallien accepted this revision.
mgallien added a comment.
This revision is now accepted and ready to land.


  Thanks

REPOSITORY
  R286 KFileMetaData

BRANCH
  avoidtaglibheaderwarnings

REVISION DETAIL
  https://phabricator.kde.org/D13914

To: kossebau, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D13914: Avoid compiler warnings for taglib headers

2018-07-06 Thread Friedrich W. H. Kossebau 
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:90a9ff80ca3b: Avoid compiler warnings for taglib headers 
(authored by kossebau).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13914?vs=37226=37228

REVISION DETAIL
  https://phabricator.kde.org/D13914

AFFECTED FILES
  autotests/CMakeLists.txt
  src/CMakeLists.txt
  src/writers/CMakeLists.txt

To: kossebau, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D13914: Avoid compiler warnings for taglib headers

2018-07-06 Thread Friedrich W. H. Kossebau 
kossebau created this revision.
kossebau added a reviewer: mgallien.
Restricted Application added projects: Frameworks, Baloo.
Restricted Application added subscribers: Baloo, kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Declaring them as system headers (-> -isystem) tells the compiler
  we cannot do anything about them, so it stays silent for them.
  
  Completes b680861aa2ed973eb6694a9dda1c327107323062 


TEST PLAN
  Still builds and installs, but no longer warns about issues in taglib
  headers.

REPOSITORY
  R286 KFileMetaData

BRANCH
  avoidtaglibheaderwarnings

REVISION DETAIL
  https://phabricator.kde.org/D13914

AFFECTED FILES
  autotests/CMakeLists.txt
  src/CMakeLists.txt
  src/writers/CMakeLists.txt

To: kossebau, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D13913: Use non deprecated fastInsert and replace in http.cpp

2018-07-06 Thread Jaime Torres Amate 
jtamate created this revision.
jtamate added reviewers: dfaure, Frameworks.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
jtamate requested review of this revision.

REVISION SUMMARY
  In davParsePropstats there are chances of replacing already inserted data.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13913

AFFECTED FILES
  src/ioslaves/http/http.cpp

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13816: Make KItinerary work as a static library

2018-07-06 Thread Volker Krause 
vkrause added a comment.


  In D13816#287459 , 
@lepagevalleeemmanuel wrote:
  
  > > Or does anyone have an idea how to solve this more elegantly? :)
  >
  > Hi, we talked about this at Randa and QtWorldSummit last year. Sorry for 
stopping working on this after I made enough progress to make it work for me. I 
was assigned to work on other things. The clean way is using:
  >
  > Q_IMPORT_PLUGIN(KirigamiPlugin)
  
  
  Right, that works for plugins. There is even 
https://codereview.qt-project.org/#/c/195680/ since 5.11 allowing us to hook 
"plugin loading", for things covered by static construction in the dynamic 
case. The patch here is looking more at something like the bug report you 
mentioned below, ie. use of static construction in libraries rather than 
plugins.
  
  > Like other Qt static modules, This can be semi-automated using MOC magic 
and CMake-foo. All the magic is there 
https://github.com/ring-project/ring-kde-appimage-builder/tree/gentoo_base . 
It's not very clean, but it works. I have to catch a plane later today, so I 
can't write a lengthy comment right now.
  
  Most of those patches seem to be dealing with the Qt5::Test dependency or 
other dependency-related changes, ie. this should be pretty harmless to 
integrate?
  
  > Just to say, fixing static frameworks and LTO bugs reduce the size of the 
KF5 based APK/AppImage by 86% and they load 6-8 time faster when PGO/FDO is 
enabled. Of course all of this is not "free". There is a non-trivial amount of 
work before @apol SDK or mine can work with random KF5 apps. Things like 
https://bugs.kde.org/show_bug.cgi?id=387820 become real crashers instead of 
unrefined behaviors. I brute force fixed all of them using horrible hacks to 
Ring-KDE could ship on Android/Plasma_Mobile/Appimage/macOS with a 13-18mb 
(with or without breeze icons) size instead of ~185-200mb (with or without 
breeze icons).
  
  That bug report is more what I'm looking at here. I disagree with your 
assessment though that this is undefined behavior or broken in the current 
dynamic code. Static construction is actually a pattern used all over the 
place, among them are qrc, the qml compiler and the ECM qm catalog loader, as 
well as custom code as you found in KConfig, or as this patch tries to  support 
in KItinerary. So I think we need a proper solution for this.

REPOSITORY
  R1003 KItinerary: Travel Reservation handling library

REVISION DETAIL
  https://phabricator.kde.org/D13816

To: vkrause, #frameworks
Cc: mart, lepagevalleeemmanuel, apol, kde-pim, dvasin, rodsevich, winterz, 
vkrause, mlaurent, knauss, dvratil

D13912: Use non deprecated replace in ForwardingSlave

2018-07-06 Thread Jaime Torres Amate 
jtamate created this revision.
jtamate added reviewers: dfaure, Frameworks.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
jtamate requested review of this revision.

REVISION SUMMARY
  There is no contract that ensures entry does not have already those data 
inserted, so better safe than sorry.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13912

AFFECTED FILES
  src/core/forwardingslavebase.cpp

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13910: Use non deprecated fastInsert in remoteimpl.cpp

2018-07-06 Thread Jaime Torres Amate 
jtamate created this revision.
jtamate added reviewers: dfaure, Frameworks.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
jtamate requested review of this revision.

REVISION SUMMARY
  All entries are cleared before fastInsert

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13910

AFFECTED FILES
  src/ioslaves/remote/remoteimpl.cpp

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13909: Use non deprecated fastInsert in kfileitemtest

2018-07-06 Thread Jaime Torres Amate 
jtamate created this revision.
jtamate added reviewers: dfaure, Frameworks.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
jtamate requested review of this revision.

REVISION SUMMARY
  Use fastInsert instead of insert.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13909

AFFECTED FILES
  autotests/kfileitemtest.cpp

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13908: Use non deprecated fastInsert in ftp.cpp

2018-07-06 Thread Jaime Torres Amate 
jtamate created this revision.
jtamate added reviewers: dfaure, Frameworks.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
jtamate requested review of this revision.

REVISION SUMMARY
  Use fastInsert instead of insert.
  All entries are local or there is an assert for size=0

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13908

AFFECTED FILES
  src/ioslaves/ftp/ftp.cpp

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13898: Use non deprecated fastInsert in file.cpp (first of many to come)

2018-07-06 Thread Jaime Torres Amate 
jtamate added inline comments.

INLINE COMMENTS

> bruns wrote in file.cpp:864
> This is broken (although not new).
> 
> `buff.st_size` is the size of the target name **without** null byte.
> readlink(..., .., bufferSize) thus will typically read exactly bufferSize 
> bytes, thus n == bufferSize
> As a result, the 'good' case in the branches below will not pass, and a 
> resize(bufferSize *= 2) and another readlink will happen.

According to the man page (2+3), readlink() //does not append a null byte to 
buf//.

  It will (silently) truncate the contents (to a length of bufsiz characters), 
in case the buffer is too small to hold all of the contents.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13898

To: jtamate, dfaure, #frameworks
Cc: bruns, kde-frameworks-devel, michaelh, ngraham

D13898: Use non deprecated fastInsert in file.cpp (first of many to come)

2018-07-06 Thread Jaime Torres Amate 
jtamate updated this revision to Diff 37216.
jtamate marked 3 inline comments as done.
jtamate added a comment.


  Added a comment: // readlink doesn't append a null byte to 
linkTargetBuffer.data()
  Using target path to read ACL in a non broken symbolic link.
  Do not fill remaining data in case of broken link, doesn't affect dolphin.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13898?vs=37184=37216

REVISION DETAIL
  https://phabricator.kde.org/D13898

AFFECTED FILES
  src/ioslaves/file/file.cpp

To: jtamate, dfaure, #frameworks
Cc: bruns, kde-frameworks-devel, michaelh, ngraham

D13884: [KMessageWidget] Update stylesheet when palette changes

2018-07-06 Thread Dominik Haumann 
dhaumann added a comment.


  Late to the game, but also +1 from me.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D13884

To: broulik, #frameworks, rjvbb, ngraham, cfeck
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D13829: Lua: fix multi-line string

2018-07-06 Thread Dominik Haumann 
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Looks good to me.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  lua

REVISION DETAIL
  https://phabricator.kde.org/D13829

To: jpoelen, dhaumann, cullmann, #ktexteditor, #kate
Cc: kde-frameworks-devel, michaelh, ngraham, bruns