KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 340 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/340/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 04 Aug 2018 03:42:31 +
 Build duration:
43 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 58 test(s), Skipped: 0 test(s), Total: 59 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesviewtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(258/396)65%
(258/396)53%
(31893/59892)38%
(16120/42656)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(55/55)100%
(55/55)95%
(9006/9436)51%
(3923/7700)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(98/116)84%
(98/116)58%
(8295/14357)50%
(4639/9285)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3895/7924)34%
(1587/4669)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(528/1015)39%
(316/814)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4320)35%
(1306/3700)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(629/1330)55%
(620/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
(5/9)52%

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 187 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/187/
 Project:
Frameworks kio kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 04 Aug 2018 03:42:31 +
 Build duration:
26 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 58 test(s), Skipped: 0 test(s), Total: 59 test(s)Failed: TestSuite.kiofilewidgets-kfileplacesviewtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)65%
(258/396)65%
(258/396)53%
(31951/59894)38%
(16144/42654)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(55/55)100%
(55/55)95%
(9006/9436)51%
(3920/7700)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core84%
(98/116)84%
(98/116)58%
(8357/14359)50%
(4669/9289)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3893/7924)34%
(1585/4669)src.gui100%
(2/2)100%
(2/2)94%
(103/109)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)52%
(527/1015)39%
(315/814)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1364)0%
(0/1414)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/245)0%
(0/144)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1770/4320)35%
(1306/3700)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(628/1330)55%
(619/1123)src.ioslaves.remote100%
(2/2)100%
(2/2)28%
(72/257)7%
(14/212)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/30)src.ioslaves.trash56%
(5/9)56%
(5/9)52%
  

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.9 - Build # 28 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.9/28/
 Project:
Frameworks kdelibs4support kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 04 Aug 2018 03:42:17 +
 Build duration:
22 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.ktabwidget_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report29%
(4/14)43%
(124/291)43%
(124/291)47%
(21750/45961)38%
(13184/34249)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault0%
(0/1)0%
(0/1)0%
(0/87)0%
(0/56)autotests98%
(44/45)98%
(44/45)98%
(11469/11759)50%
(7254/14375)src0%
(0/1)0%
(0/1)0%
(0/4)0%
(0/2)src.kdebugdialog0%
(0/7)0%
(0/7)0%
(0/256)0%
(0/73)src.kdecore76%
(65/86)76%
(65/86)53%
(9506/17866)49%
(5599/11459)src.kdeui19%
(13/68)19%
(13/68)8%
(765/9694)6%
(330/5364)src.kio7%
(2/27)7%
(2/27)0%
(10/2258)0%
(1/1238)src.kioslave.metainfo0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/4)src.kparts0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/12)src.kssl0%
(0/8)0%
(0/8)0%
(0/1807)0%
(0/853)src.kssl.kcm0%
(0/3)0%
(0/3)0%
(0/264)0%
(0/145)src.solid0%
(0/3)0%
(0/3)0%
(0/188)0%
(0/87)src.solid-networkstatus.kded0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/94)tests0%
(0/34)0%
(0/34)0%
(0/1537)0%
(0/487)

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 97 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/97/
 Project:
Frameworks kio kf5-qt5 FreeBSDQt5.10
 Date of build:
Sat, 04 Aug 2018 03:42:31 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: (root) Failed: 5 test(s), Passed: 53 test(s), Skipped: 0 test(s), Total: 58 test(s)Failed: TestSuite.kiocore-jobtestFailed: TestSuite.kiocore-kmountpointtestFailed: TestSuite.kiofilewidgets-kfileplacesviewtestFailed: TestSuite.kiowidgets-kdirlistertestFailed: TestSuite.kiowidgets-kdirmodeltest

KDE CI: Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.10 - Build # 14 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20FreeBSDQt5.10/14/
 Project:
Frameworks kdelibs4support kf5-qt5 FreeBSDQt5.10
 Date of build:
Sat, 04 Aug 2018 03:42:17 +
 Build duration:
7 min 9 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 38 test(s), Skipped: 0 test(s), Total: 39 test(s)Failed: TestSuite.kstandarddirstest

KDE CI: Frameworks kdelibs4support kf5-qt5 SUSEQt5.10 - Build # 54 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kdelibs4support%20kf5-qt5%20SUSEQt5.10/54/
 Project:
Frameworks kdelibs4support kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 04 Aug 2018 03:42:17 +
 Build duration:
6 min 55 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.ktabwidget_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report29%
(4/14)43%
(124/291)43%
(124/291)47%
(21615/45959)38%
(13051/34249)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault0%
(0/1)0%
(0/1)0%
(0/87)0%
(0/56)autotests98%
(44/45)98%
(44/45)97%
(11364/11759)50%
(7174/14375)src0%
(0/1)0%
(0/1)0%
(0/4)0%
(0/2)src.kdebugdialog0%
(0/7)0%
(0/7)0%
(0/256)0%
(0/73)src.kdecore76%
(65/86)76%
(65/86)53%
(9476/17864)48%
(5546/11459)src.kdeui19%
(13/68)19%
(13/68)8%
(765/9694)6%
(330/5364)src.kio7%
(2/27)7%
(2/27)0%
(10/2258)0%
(1/1238)src.kioslave.metainfo0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/4)src.kparts0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/12)src.kssl0%
(0/8)0%
(0/8)0%
(0/1807)0%
(0/853)src.kssl.kcm0%
(0/3)0%
(0/3)0%
(0/264)0%
(0/145)src.solid0%
(0/3)0%
(0/3)0%
(0/188)0%
(0/87)src.solid-networkstatus.kded0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/94)tests0%
(0/34)0%
(0/34)0%
(0/1537)0%
(0/487)

D11924: Add "SkipSwitcher" to API

[David Faure]

dfaure added a comment.
Restricted Application edited subscribers, added: kde-frameworks-devel; 
removed: Frameworks.


  The CI for kwindowsystem fails ever since this was committed, can somebody 
please take a look?
  
  
https://build.kde.org/view/Frameworks/job/Frameworks%20kwindowsystem%20kf5-qt5%20SUSEQt5.10/34/testReport/junit/(root)/TestSuite/kwindowsystem_kwindowinfox11test/
  
  FAIL!  : KWindowInfoX11Test::testState(skipSwitcher) Compared values are not 
the same
  
Loc: [/home/jenkins/workspace/Frameworks kwindowsystem kf5-qt5 
SUSEQt5.10/autotests/kwindowinfox11test.cpp(230)]

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D11924

To: sharvey, hein, graesslin
Cc: dfaure, kde-frameworks-devel, #plasma, ngraham, graesslin, apol, michaelh, 
bruns, #frameworks

D12872: ScalableTest, add "scalable" plasma-browser-integration

[David Faure]

dfaure added a comment.


  Ping? Can you push this?

REPOSITORY
  R266 Breeze Icons

BRANCH
  scalable_pbi (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12872

To: maximilianocuria, #frameworks, dfaure, andreaska, andreask, ngraham
Cc: heikobecker, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10 - Build # 21 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20FreeBSDQt5.10/21/
 Project:
Frameworks kcoreaddons kf5-qt5 FreeBSDQt5.10
 Date of build:
Fri, 03 Aug 2018 16:01:58 +
 Build duration:
4 min 39 sec and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 20 test(s), Skipped: 0 test(s), Total: 23 test(s)Failed: TestSuite.kdirwatch_inotify_unittestFailed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kdirwatch_stat_unittest

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.10 - Build # 98 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.10/98/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.10
 Date of build:
Fri, 03 Aug 2018 16:01:58 +
 Build duration:
3 min 21 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kdirwatch_stat_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(69/81)85%
(69/81)75%
(6323/8419)43%
(10140/23405)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2698/2772)49%
(5806/11893)src.desktoptojson100%
(2/2)100%
(2/2)78%
(88/113)38%
(123/326)src.lib50%
(1/2)50%
(1/2)61%
(351/572)26%
(243/928)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/782)18%
(184/1038)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1047/2821)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(652/767)42%
(968/2305)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)47%
(368/778)45%
(846/1899)src.lib.util100%
(10/10)100%
(10/10)81%
(731/908)52%
(827/1583)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

KDE CI: Frameworks kcoreaddons kf5-qt5 SUSEQt5.9 - Build # 43 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20SUSEQt5.9/43/
 Project:
Frameworks kcoreaddons kf5-qt5 SUSEQt5.9
 Date of build:
Fri, 03 Aug 2018 16:01:58 +
 Build duration:
3 min 25 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(69/81)85%
(69/81)75%
(6322/8419)43%
(10130/23401)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2696/2772)49%
(5797/11895)src.desktoptojson100%
(2/2)100%
(2/2)78%
(88/113)38%
(122/322)src.lib50%
(1/2)50%
(1/2)62%
(352/572)26%
(243/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/782)18%
(184/1038)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1049/2827)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(652/767)42%
(968/2303)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)47%
(368/778)44%
(845/1899)src.lib.util100%
(10/10)100%
(10/10)81%
(731/908)52%
(826/1581)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

D14565: Fix overflow in rounding code

[Sune Vuorela]

This revision was automatically updated to reflect the committed changes.
Closed by commit R244:ea2779611800: Fix overflow in rounding code (authored by 
svuorela).

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14565?vs=39024=39025

REVISION DETAIL
  https://phabricator.kde.org/D14565

AFFECTED FILES
  autotests/kformattest.cpp
  src/lib/util/kformatprivate.cpp

To: svuorela, cfeck, safaalfulaij
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14565: Fix overflow in rounding code

[Christoph Feck]

cfeck accepted this revision.
cfeck added a comment.
This revision is now accepted and ready to land.


  Merci!

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14565

To: svuorela, cfeck, safaalfulaij
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14565: Fix overflow in rounding code

[Sune Vuorela]

svuorela added a comment.


  In D14565#302581 , @cfeck wrote:
  
  > In D14565#302551 , @safaalfulaij 
wrote:
  >
  > > Maybe you should use `largeValue` instead of `largevalue`.
  >
  >
  > Yes, that would be consistent with what we do elsewhere.
  
  
  Done.
  
  > I had hoped a junior would grab this ticket before a senior ruins the show 
(insert emoticon here), but having a fast fix for 5.49.0 is surely also nice.
  
  I was considering leaving it for another week or two, but then I would 
probably have forgotten about it.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D14565

To: svuorela, cfeck, safaalfulaij
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14565: Fix overflow in rounding code

[Sune Vuorela]

svuorela updated this revision to Diff 39024.
svuorela added a comment.


  s/largevalue/largeValue/

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14565?vs=38978=39024

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14565

AFFECTED FILES
  autotests/kformattest.cpp
  src/lib/util/kformatprivate.cpp

To: svuorela, cfeck, safaalfulaij
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14579: api for multi level kcms

[Marco Martin]

mart added a reviewer: Frameworks.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D14579

To: mart, #plasma, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14580: support for multi pages kcms

[Marco Martin]

mart added a reviewer: Frameworks.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D14580

To: mart, #plasma, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14580: support for multi pages kcms

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
mart requested review of this revision.

REVISION SUMMARY
  support multiple levels for QML kcms.
  use a Kirigami.ApplicationItem, so qml kcms can now use the full Kirigami api
  and use the application's pagerow for their levels.
  The breadcrumb of levels is supposed to be shown by the systemsettings shell.
  Depends on D14579 

TEST PLAN
  Old kcms still work as they did
  a mqml kcm can push multiple pages

REPOSITORY
  R295 KCMUtils

BRANCH
  mart/multipageKCM

REVISION DETAIL
  https://phabricator.kde.org/D14580

AFFECTED FILES
  src/CMakeLists.txt
  src/kcmoduleqml.cpp
  src/kcmoduleqml_p.h

To: mart, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14579: api for multi level kcms

[Marco Martin]

mart added a dependent revision: D14580: support for multi pages kcms.

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D14579

To: mart, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14579: api for multi level kcms

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
mart requested review of this revision.

REVISION SUMMARY
  Support the concept of multi level kcms: systemsettings and kcmshell will
  be able to show a breadcrumb to navigate between levels
  QML kcms can push and remove levels with standard Kirigami api,
  while qwidgets based kcms would need to manually use a QStackWidget and make 
use of this api
  to advertise their own lovels

TEST PLAN
  added a level to an existing kcm

REPOSITORY
  R265 KConfigWidgets

BRANCH
  mart/multipageKCM

REVISION DETAIL
  https://phabricator.kde.org/D14579

AFFECTED FILES
  src/kcmodule.cpp
  src/kcmodule.h

To: mart, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14502: Reuse function that already does the same

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R249:3e66e1496235: Reuse function that already does the same 
(authored by apol).

REPOSITORY
  R249 KI18n

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14502?vs=38816=39005

REVISION DETAIL
  https://phabricator.kde.org/D14502

AFFECTED FILES
  src/klocalizedstring.cpp

To: apol, #frameworks, ilic, aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14435: Fix KTimeComboBox input mask for AM/PM times

[Glenn Watson]

glennw added a comment.


  Yes, you got the address and the reference correct - that sounds like it 
would have been quite the project!

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D14435

To: glennw, cfeck, mlaurent
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D14569: Make it possible for ECM to detect po files at configure time

[Christophe Giboudeaux]

cgiboudeaux accepted this revision.
cgiboudeaux added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> KDECMakeSettings.cmake:95
> +#
> +# ``KDE_L10N_SYNC_TRANSLATIONS`` (OFF by default) will downloadthe 
> translations at configuration
> +# time instead of build time.

typo, "download the"

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14569

To: apol, #frameworks, cgiboudeaux
Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D14502: Reuse function that already does the same

[Albert Astals Cid]

aacid accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R249 KI18n

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14502

To: apol, #frameworks, ilic, aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14270: CoffeeScript: fix templates in embedded JavaScript code & add escapes

[Nibaldo González]

nibags closed this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14270

To: nibags, dhaumann, cullmann, #framework_syntax_highlighting, #kate
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14526: AppArmor: update syntax and various improvements/fixes

[Nibaldo González]

nibags added reviewers: dhaumann, cullmann.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14526

To: nibags, #framework_syntax_highlighting, #kate, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann