D15318: [WIP] Automatically re-upload saved files located on remote locations instead of asking first

[Nathaniel Graham]

ngraham planned changes to this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15318

To: ngraham, #frameworks, broulik, jtamate
Cc: elvisangelaccio, kde-frameworks-devel, broulik, jtamate, michaelh, ngraham, 
bruns

D15318: [WIP] Automatically re-upload saved files located on remote locations instead of asking first

[Nathaniel Graham]

ngraham updated this revision to Diff 41374.
ngraham added a comment.


  Adjust message string

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15318?vs=41370=41374

BRANCH
  samba-auto-re-upload-after-save (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15318

AFFECTED FILES
  src/kioexec/kioexecd.cpp

To: ngraham, #frameworks, broulik, jtamate
Cc: elvisangelaccio, kde-frameworks-devel, broulik, jtamate, michaelh, ngraham, 
bruns

D15318: [WIP] Automatically re-upload saved files located on remote locations instead of asking first

[Nathaniel Graham]

ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15318

To: ngraham, #frameworks, broulik, jtamate
Cc: elvisangelaccio, kde-frameworks-devel, broulik, jtamate, michaelh, ngraham, 
bruns

D15318: [WIP] Automatically re-upload saved files located on remote locations instead of asking first

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15318

To: ngraham, #frameworks, broulik, jtamate
Cc: elvisangelaccio, kde-frameworks-devel, broulik, jtamate, michaelh, ngraham, 
bruns

D15406: Manually resize KCMUtilDialog to sizeHint()

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Awesome. Tested it out, and this definitely helps for 1366x768. Doesn't 
regress the 1920x1090 or larger case, either.
  
  To get High DPI support working, I bet we need to multiply some of these 
values by `QApplication::devicePixelRatio()`, but that's only a theory at this 
point...

REPOSITORY
  R295 KCMUtils

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15406

To: valeriymalov, #frameworks, ngraham
Cc: acrouthamel, kde-frameworks-devel, michaelh, ngraham, bruns

D15318: [WIP] Automatically re-upload saved files located on remote locations instead of asking first

[Nathaniel Graham]

ngraham planned changes to this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15318

To: ngraham, #frameworks, broulik, jtamate
Cc: elvisangelaccio, kde-frameworks-devel, broulik, jtamate, michaelh, ngraham, 
bruns

D15318: [WIP] Automatically re-upload saved files located on remote locations instead of asking first

[Nathaniel Graham]

ngraham updated this revision to Diff 41370.
ngraham added a comment.


  Implement first pass at some user-friendly error checking

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15318?vs=41305=41370

BRANCH
  samba-auto-re-upload-after-save (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15318

AFFECTED FILES
  src/kioexec/kioexecd.cpp

To: ngraham, #frameworks, broulik, jtamate
Cc: elvisangelaccio, kde-frameworks-devel, broulik, jtamate, michaelh, ngraham, 
bruns

D15340: Add Solarized Light and Dark themes

[Andrew Crouthamel]

acrouthamel added a comment.


  I just realized the output was HTML. Ok, I can see what is going on now. If 
you could let me know if I am missing the "code-editor" though, that would be 
great!

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D15340

To: acrouthamel, #kate, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, 
genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars

D15340: Add Solarized Light and Dark themes

[Andrew Crouthamel]

acrouthamel added a comment.


  In D15340#322631 , @dhaumann wrote:
  
  > Sure, please use kdesrc-build as described here:
  >  https://community.kde.org/Guidelines_and_HOWTOs/Build_from_source
  >
  > Once setup, you can build everything by invoking ./kdesrc-build
  >  You can also pass a module to build:
  >
  >   ./kdesrc-build syntax-highlighting
  >   
  >
  > Ideally, you should build with dependencies:
  >
  >   ./kdesrc-build --include-dependencies syntax-highlighting
  >   
  >
  > If you need help, feel free to ask.
  
  
  Thanks for the help! So I have kdesrc-build setup, I pulled and built 
syntax-highlighting. The only bin file is kate-syntax-highlighter. So I checked 
the help on that and tried running:
  
kate-syntax-highlighter ~/Development/kdesrc-build/kdesrc-build-test.pl -t 
'Solarized Dark'
  
  Unfortunately I do not get any colorized output in Konsole. Any tips? Is this 
the new "code-editor" or am I still missing something?

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D15340

To: acrouthamel, #kate, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, michaelh, 
genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause, sars

D14724: autotests: don't fail if an unrelated window shows up.

[Jaime Torres Amate]

jtamate added a comment.


  It works for me if I use ctest -j6 . but fails for me if I use ctest -j12 .  
or ctest -j4 .
  
  13/15 Test  #3: plasma-dialogstatetest ...***Failed2.42 sec
  
  3/15 Test  #3: plasma-dialogstatetest ...***Failed1.71 sec

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D14724

To: dfaure, hein, drosca, broulik, davidedmundson
Cc: jtamate, kde-frameworks-devel, #plasma, michaelh, ngraham, bruns

D14724: autotests: don't fail if an unrelated window shows up.

[David Faure]

dfaure added a comment.


  @hein - or anyone else - ping?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D14724

To: dfaure, hein, drosca, broulik, davidedmundson
Cc: kde-frameworks-devel, #plasma, michaelh, ngraham, bruns

D15407: Fix OCS provider URL in about dialog

[Dominik Haumann]

dhaumann added a reviewer: alexanderschmidt.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D15407

To: broulik, #frameworks, leinir, alexanderschmidt
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15408: Don't assert deleting the temporary file

[Jaime Torres Amate]

jtamate created this revision.
jtamate added reviewers: dfaure, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
jtamate requested review of this revision.

REVISION SUMMARY
  Change the names of the temporary files to something more difficult for other 
KDE programs to create.
  Remove the asserts. 
  In the very unlikely situation when the preview temporary file has been 
replaced by other temporary file, nothing can be done to avoid to delete the 
file.

TEST PLAN
  With a lot of images in the trash, while dolphin create the previews, empty 
the trash. (It can take a while, around 3000 images, until it asserts).
  Before: a crash in the second assert (Is a file?), because the temporary file 
was already deleted, therefore it is not a file.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15408

AFFECTED FILES
  src/widgets/previewjob.cpp

To: jtamate, dfaure, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15407: Fix OCS provider URL in about dialog

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Frameworks, leinir.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Fixes loading provider information

TEST PLAN
  The URL stored at http://download.kde.org/ocs/providers.xml changed
  
  Opened about dialog, pretended it had ocs usernames, got "providers loaded" 
instead of "no providers"
  Don't actually know what apps has OCS users that could be shown there

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D15407

AFFECTED FILES
  src/kaboutapplicationpersonmodel_p.cpp

To: broulik, #frameworks, leinir
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.9 - Build # 55 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.9/55/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 10 Sep 2018 15:01:26 +
 Build duration:
8 min 30 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(69/81)85%
(69/81)75%
(6334/8432)43%
(10159/23449)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2700/2776)49%
(5801/11903)src.desktoptojson100%
(2/2)100%
(2/2)78%
(88/113)38%
(122/322)src.lib50%
(1/2)50%
(1/2)62%
(352/572)26%
(243/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/782)18%
(184/1038)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1049/2827)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(654/770)42%
(975/2315)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)48%
(374/784)45%
(863/1927)src.lib.util100%
(10/10)100%
(10/10)81%
(731/908)52%
(826/1581)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 111 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/111/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 10 Sep 2018 15:01:26 +
 Build duration:
3 min 25 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kdirwatch_stat_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(69/81)85%
(69/81)75%
(6335/8432)43%
(10169/23453)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2702/2776)49%
(5810/11901)src.desktoptojson100%
(2/2)100%
(2/2)78%
(88/113)38%
(123/326)src.lib50%
(1/2)50%
(1/2)61%
(351/572)26%
(243/928)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/782)18%
(184/1038)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1047/2821)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(654/770)42%
(975/2317)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)48%
(374/784)45%
(864/1927)src.lib.util100%
(10/10)100%
(10/10)81%
(731/908)52%
(827/1583)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

D15406: Manually resize KCMUtilDialog to sizeHint()

[Valeriy Malov]

valeriymalov created this revision.
valeriymalov added reviewers: Frameworks, ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
valeriymalov requested review of this revision.

REVISION SUMMARY
  Workaround for https://bugreports.qt.io/browse/QTBUG-3459
  
  Currently adjustSize() is limited to 2/3 of the screen size for windows
  This adds unnecessary scrollbars on dialogs that would otherwise fit the
  screen
  Manually resize the window after adjustSize() happens to avoid this
  limitation
  
  CCBUG: 389585

TEST PLAN
  Tested on a 1366x768 laptop, with this patch networkmanagement window opens
  in full screen height (respecting the panel)

REPOSITORY
  R295 KCMUtils

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15406

AFFECTED FILES
  src/kcmultidialog.cpp

To: valeriymalov, #frameworks, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14530: Fix crash when save a QImage to the eps format file

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Given this here still shows up in my phabricator list, and having given 
"smart" ;) comments on the bug report, please find a patch based on my comments 
at D15405 .

REPOSITORY
  R287 KImageFormats

REVISION DETAIL
  https://phabricator.kde.org/D14530

To: zccrs, mlaurent, kossebau, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15405: [EPS] Fix crash at app shutdown (being tried to persist clipboard image)

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: zccrs, dfaure, pino.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  Deny any capabilities when there is no QApp instance.
  
  BUG: 397040

TEST PLAN
  Untested, as I do not experience the bug on my system and had no time to
  invest into trying to.

REPOSITORY
  R287 KImageFormats

BRANCH
  fixepscrashonappshutdown

REVISION DETAIL
  https://phabricator.kde.org/D15405

AFFECTED FILES
  src/imageformats/eps.cpp

To: kossebau, zccrs, dfaure, pino
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15177: Emit signals when a package is installed/uninstalled

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> broulik wrote in packagejob.cpp:90
> Can this be invalid or does `install` already check for validity?

bool PackageJobThread::installPackage(const QString , const QString , 
OperationType operation)
{

...

  if (!meta.isValid()) {
qCDebug(KPACKAGE_LOG) << "No metadata file in package" << src << path;
d->errorMessage = i18n("No metadata file in package: %1", src);
d->errorCode = Package::JobError::MetadataFileMissingError;
return false;
}

REPOSITORY
  R290 KPackage

REVISION DETAIL
  https://phabricator.kde.org/D15177

To: davidedmundson, #plasma
Cc: broulik, Zren, kde-frameworks-devel, michaelh, ngraham, bruns

D15177: Emit signals when a package is installed/uninstalled

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R290 KPackage

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15177

To: davidedmundson, #plasma, broulik
Cc: broulik, Zren, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.11 - Build # 9 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.11/9/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Mon, 10 Sep 2018 10:42:23 +
 Build duration:
3 min 4 sec and counting
   CONSOLE OUTPUT
  [...truncated 318.88 KB...] ^file:///C:/CI/workspace/Frameworks/kio/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/modifications.elements:43: parser error : expected '>'   ^file:///C:/CI/workspace/Frameworks/kio/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/modifications.elements:43: parser error : Content error in the external subset   ^index.docbook:8: parser error : Entity 'language' not defined ^index.docbook:12: parser error : Entity 'Ferdinand.Gassauer' not defined^index.docbook:12: parser error : Entity 'Ferdinand.Gassauer.mail' not defined ^index.docbook:18: parser error : Entity 'kde' not definedThe help system of ^index.docbook:21: parser error : Entity 'khelpcenter' not defined See  The . ^jom: C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\build\docs\kioslave5\help\CMakeFiles\docs-kioslave5-help-index-cache-bz2.dir\build.make [docs\kioslave5\help\index.cache.bz2] Error 1file:///C:/CI/workspace/Frameworks/kio/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/kdedbx45.dtd:102: warning: failed to load external entity "file:///C:/CI/workspace/Craft/CI-Qt511/windows-msvc2017_64-cl-debug/bin/data/xml/docbook/schema/dtd/4.5/docbookx.dtd"%DocBookDTD;^file:///C:/CI/workspace/Frameworks/kio/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/modifications.elements:43: validity error : PEReference: %div.title.content; not found ^file:///C:/CI/workspace/Frameworks/kio/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/modifications.elements:43: parser error : ContentDecl : Name or '(' expected ^file:///C:/CI/workspace/Frameworks/kio/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/dat[  1%] Generating index.cache.bz2a/kf5/kdoctools/customization/dtd/modifications.elements:43: parser error : expected '>'   ^file:///C:/CI/workspace/Frameworks/kio/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/modifications.elements:43: parser error : Content error in the external subset   ^index.docbook:8: parser error : Entity 'language' not defined ^index.docbook:12: parser error : Entity 'Hamish.Rodda' not defined   ^index.docbook:12: parser error : Entity 'Hamish.Rodda.mail' not defined   ^jom: C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\build\docs\kioslave5\webdav\CMakeFiles\docs-kioslave5-webdav-index-cache-bz2.dir\build.make [docs\kioslave5\webdav\index.cache.bz2] Error 1jom: C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\build\CMakeFiles\Makefile2 [docs\kioslave5\ftp\CMakeFiles\docs-kioslave5-ftp-index-cache-bz2.dir\all] Error 2jom: C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\build\CMakeFiles\Makefile2 [docs\kioslave5\help\CMakeFiles\docs-kioslave5-help-index-cache-bz2.dir\all] Error 2jom: C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\build\CMakeFiles\Makefile2 [docs\kioslave5\webdav\CMakeFiles\docs-kioslave5-webdav-index-cache-bz2.dir\all] Error 2jom: C:\CI\workspace\Frameworks\kio\kf5-qt5 WindowsMSVCQt5.11\build\CMakeFiles\Makefile2 [docs\kioslave5\data\CMakeFiles\docs-kioslave5-data-index-cache-bz2.dir\all] Error 2file:///C:/CI/workspace/Frameworks/kio/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/kdedbx45.dtd:102: warning: failed to load external entity "file:///C:/CI/workspace/Craft/CI-Qt511/windows-msvc2017_64-cl-debug/bin/data/xml/docbook/schema/dtd/4.5/docbookx.dtd"%DocBookDTD;^file:///C:/CI/workspace/Frameworks/kio/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/modifications.elements:43: validity error : PEReference: %div.title.content; not found ^file:///C:/CI/workspace/Frameworks/kio/kf5-qt5%20WindowsMSVCQt5.11/install-prefix/bin/data/kf5/kdoctools/customization/dtd/modifications.elements:43: parser error : ContentDecl : Name or '(' expected 

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.11 - Build # 16 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.11/16/
 Project:
kf5-qt5 FreeBSDQt5.11
 Date of build:
Mon, 10 Sep 2018 10:42:13 +
 Build duration:
2 min 8 sec and counting

KDE CI: Frameworks » kpackage » kf5-qt5 AndroidQt5.11 - Build # 17 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20AndroidQt5.11/17/
 Project:
kf5-qt5 AndroidQt5.11
 Date of build:
Mon, 10 Sep 2018 10:42:15 +
 Build duration:
50 sec and counting
   CONSOLE OUTPUT
  [...truncated 72.79 KB...]  "KF5DocTools_DIR" to a directory containing one of the above files.  If  "KF5DocTools" provides a separate development package or SDK, be sure it  has been installed.-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success-- Performing Test COMPILER_HAS_DEPRECATED_ATTR-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success-- The following REQUIRED packages have been found: * Qt5 (required version >= 5.8.0) * KF5Archive (required version >= 5.50.0) * Gettext * KF5I18n (required version >= 5.50.0) * KF5CoreAddons (required version >= 5.50.0) * ECM (required version >= 1.6.0), Extra CMake Modules.,  * Qt5Core * Qt5Test (required version >= 5.8.0)   Required for tests-- The following features have been disabled: * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- The following OPTIONAL packages have not been found: * KF5DocTools (required version >= 5.50.0), Tools to generate documentation-- Configuring done-- Generating done-- Build files have been written to: /home/user/workspace/Frameworks/kpackage/kf5-qt5 AndroidQt5.11/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[kf5-qt5 AndroidQt5.11] Running shell script+ python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kpackage --branchGroup kf5-qt5 --platform AndroidQt5.11 --usingInstall /home/user/install-prefix/Scanning dependencies of target mockhandler_autogenScanning dependencies of target testpackage-rccScanning dependencies of target KF5Package_autogen[  1%] Automatic MOC for target mockhandler[  3%] Generating testpackage-rcc/contents.rcc[  5%] Automatic MOC for target KF5Package[  5%] Built target testpackage-rcc[  5%] Built target mockhandler_autogen[  5%] Built target KF5Package_autogen[  6%] Automatic RCC for kpackage.qrcScanning dependencies of target mockhandler[  8%] Building CXX object autotests/mockdepresolver/CMakeFiles/mockhandler.dir/mockhandler_autogen/mocs_compilation.cpp.o[ 10%] Building CXX object autotests/mockdepresolver/CMakeFiles/mockhandler.dir/main.cpp.oScanning dependencies of target KF5Package[ 11%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/package.cpp.o[ 13%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/private/packagejob.cpp.o[ 15%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/private/packages.cpp.o[ 16%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/packagestructure.cpp.o[ 18%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/packageloader.cpp.o[ 20%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/private/versionparser.cpp.o[ 22%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/private/packagejobthread.cpp.o[ 23%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/version.cpp.o[ 25%] Linking CXX executable ../../bin/mockhandler[ 27%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/kpackage_debug.cpp.o[ 27%] Built target mockhandler[ 28%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/KF5Package_autogen/mocs_compilation.cpp.o[ 30%] Building CXX object src/kpackage/CMakeFiles/KF5Package.dir/KF5Package_autogen/EWIEGA46WW/qrc_kpackage.cpp.o[ 32%] Linking CXX shared library ../../bin/libKF5Package.so/home/user/install-prefix/include/KF5/KI18n/klocalizedstring.h:1340: error: undefined reference to 'ki18nd(char const*, char const*)'/home/user/install-prefix/include/KF5/KI18n/klocalizedstring.h:1340: error: undefined reference to 'KLocalizedString::toString() const'/home/user/install-prefix/include/KF5/KI18n/klocalizedstring.h:1340: error: undefined reference to 'KLocalizedString::~KLocalizedString()'/home/user/install-prefix/include/KF5/KI18n/klocalizedstring.h:1352: error: undefined reference to 'ki18nd(char const*, char const*)'/home/user/install-prefix/include/KF5/KI18n/klocalizedstring.h:1352: error: undefined reference to 'KLocalizedString::subs(QString const&, int, QChar) const'/home/user/install-prefix/include/KF5/KI18n/klocalizedstring.h:1352: error: undefined reference to 'KLocalizedString::subs(QString const&, int, QChar) const'/home/user/install-prefix/include/KF5/KI18n/klocalizedstring.h:1352: error: undefined reference to 'KLocalizedString::toString() const'/home/user/install-prefix/include/KF5/KI18n/klocalizedstring.h:1352: error: undefined reference to 'KLocalizedString::~KLocalizedString()'/home/user/install-prefix/include/KF5/KI18n/klocalizedstring.h:1352: error: undefined reference to 

KDE CI: Frameworks » kunitconversion » kf5-qt5 AndroidQt5.11 - Build # 15 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kunitconversion/job/kf5-qt5%20AndroidQt5.11/15/
 Project:
kf5-qt5 AndroidQt5.11
 Date of build:
Mon, 10 Sep 2018 10:42:12 +
 Build duration:
37 sec and counting
   CONSOLE OUTPUT
  [...truncated 72.30 KB...] * Qt5Test * Qt5 (required version >= 5.8.0)-- The following features have been disabled: * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- Configuring done-- Generating doneCMake Warning:  Manually-specified variables were not used by the project:KF5_HOST_TOOLING-- Build files have been written to: /home/user/workspace/Frameworks/kunitconversion/kf5-qt5 AndroidQt5.11/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[kf5-qt5 AndroidQt5.11] Running shell script+ python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kunitconversion --branchGroup kf5-qt5 --platform AndroidQt5.11 --usingInstall /home/user/install-prefix/Scanning dependencies of target KF5UnitConversion_autogen[  2%] Automatic MOC for target KF5UnitConversion[  2%] Built target KF5UnitConversion_autogenScanning dependencies of target KF5UnitConversion[  4%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/converter.cpp.o[  7%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/value.cpp.o[  9%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/unit.cpp.o[ 14%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/unitcategory.cpp.o[ 14%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/length.cpp.o[ 16%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/area.cpp.o[ 19%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/volume.cpp.o[ 21%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/temperature.cpp.o[ 23%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/velocity.cpp.o[ 26%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/mass.cpp.o[ 28%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/pressure.cpp.o[ 30%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/energy.cpp.o[ 33%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/currency.cpp.o[ 35%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/power.cpp.o[ 38%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/fuel_efficiency.cpp.o[ 40%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/timeunit.cpp.o[ 42%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/density.cpp.o[ 45%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/acceleration.cpp.o[ 47%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/force.cpp.o[ 50%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/angle.cpp.o[ 52%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/frequency.cpp.o[ 54%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/thermal_conductivity.cpp.o[ 57%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/thermal_flux.cpp.o[ 59%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/thermal_generation.cpp.o[ 61%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/voltage.cpp.o[ 64%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/electrical_current.cpp.o[ 66%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/electrical_resistance.cpp.o[ 69%] Building CXX object src/CMakeFiles/KF5UnitConversion.dir/KF5UnitConversion_autogen/mocs_compilation.cpp.o[ 71%] Linking CXX shared library ../bin/libKF5UnitConversion.so/home/user/workspace/Frameworks/kunitconversion/kf5-qt5 AndroidQt5.11/src/unit.cpp:33: error: undefined reference to 'KLocalizedString::KLocalizedString()'/home/user/workspace/Frameworks/kunitconversion/kf5-qt5 AndroidQt5.11/src/unit.cpp:33: error: undefined reference to 'KLocalizedString::KLocalizedString()'/home/user/workspace/Frameworks/kunitconversion/kf5-qt5 AndroidQt5.11/src/unit.cpp:33: error: undefined reference to 'KLocalizedString::KLocalizedString()'/home/user/workspace/Frameworks/kunitconversion/kf5-qt5 AndroidQt5.11/src/unit.cpp:49: error: undefined reference to 'KLocalizedString::KLocalizedString(KLocalizedString const&)'/home/user/workspace/Frameworks/kunitconversion/kf5-qt5 AndroidQt5.11/src/unit.cpp:49: error: undefined reference to 'KLocalizedString::KLocalizedString(KLocalizedString const&)'/home/user/workspace/Frameworks/kunitconversion/kf5-qt5 AndroidQt5.11/src/unit.cpp:49: error: undefined reference to 'KLocalizedString::KLocalizedString(KLocalizedString const&)'/home/user/workspace/Frameworks/kunitconversion/kf5-qt5 AndroidQt5.11/src/unit.cpp:53: error: undefined reference to 'KLocalizedString::~KLocalizedString()'/home/user/workspace/Frameworks/kunitconversion/kf5-qt5 AndroidQt5.11/src/unit.cpp:53: error: undefined reference to 'KLocalizedString::~KLocalizedString()'/home/user/workspace/Frameworks/kunitconversion/kf5-qt5 AndroidQt5.11/src/unit.cpp:53: error: undefined reference to 

D14632: keyword rule: Spport for keywords inclusion from another language/file

[Christoph Cullmann]

cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.


  Please unite the includedDefinitions()
  Beside that, I think it would make sense to have the resolveIncludeKeywords() 
part inside the KeywordList class, then we don't need that many friends.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14632

To: jpoelen, #framework_syntax_highlighting, cullmann, dhaumann
Cc: kwrite-devel, vkrause, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D15177: Emit signals when a package is installed/uninstalled

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> packagejob.cpp:90
> +if (ok) {
> +const QString pluginId = d->package->metadata().pluginId();
> +const QStringList serviceTypes = 
> d->package->metadata().serviceTypes();

Can this be invalid or does `install` already check for validity?

REPOSITORY
  R290 KPackage

REVISION DETAIL
  https://phabricator.kde.org/D15177

To: davidedmundson, #plasma
Cc: broulik, Zren, kde-frameworks-devel, michaelh, ngraham, bruns

D15242: RFC: [KFileItem] Handle permissions ourselves in isReadable()/isWritable()

[Kai Uwe Broulik]

broulik abandoned this revision.
broulik added a comment.


  Was an idea :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15242

To: broulik, dfaure, elvisangelaccio, fvogt, lbeltrame
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15397: Perl: fix brackets, variables, string references and others

[Nibaldo González]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:d0c698198ec8: Perl: fix brackets, variables, string 
references and others (authored by nibags).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15397?vs=41317=41319

REVISION DETAIL
  https://phabricator.kde.org/D15397

AFFECTED FILES
  autotests/folding/highlight.pl.fold
  autotests/html/highlight.pl.html
  autotests/input/highlight.pl
  autotests/reference/highlight.pl.ref
  data/syntax/perl.xml

To: nibags, cullmann, dhaumann, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D15397: Perl: fix brackets, variables, string references and others

[Nibaldo González]

nibags edited the summary of this revision.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix-perl

REVISION DETAIL
  https://phabricator.kde.org/D15397

To: nibags, cullmann, dhaumann, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D15397: Perl: fix brackets, variables, string references and others

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Nice, looks a lot better in the comparison screenshots.
  I had this issues in my own scripts, too, but was too dumb to fix that 
myself, thanks ;=)

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix-perl

REVISION DETAIL
  https://phabricator.kde.org/D15397

To: nibags, cullmann, dhaumann, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 FreeBSDQt5.11 - Build # 44 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20FreeBSDQt5.11/44/
 Project:
kf5-qt5 FreeBSDQt5.11
 Date of build:
Mon, 10 Sep 2018 08:10:40 +
 Build duration:
1 min 10 sec and counting

D15390: Bash: fix parameter & brace expansion

[Nibaldo González]

nibags closed this revision.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D15390

To: nibags, cullmann, dhaumann, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D15397: Perl: fix brackets, variables, string references and others

[Nibaldo González]

nibags retitled this revision from "Perl: fix brackets, variables, strings ref. 
and some improvements" to "Perl: fix brackets, variables, string references and 
others".

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D15397

To: nibags, cullmann, dhaumann, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D15397: Perl: fix brackets, variables, strings ref. and some improvements

[Nibaldo González]

nibags edited the summary of this revision.
nibags added reviewers: cullmann, dhaumann, Framework: Syntax Highlighting.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D15397

To: nibags, cullmann, dhaumann, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D15397: Perl: fix brackets, variables, strings ref. and some improvements

[Nibaldo González]

nibags created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix-perl

REVISION DETAIL
  https://phabricator.kde.org/D15397

AFFECTED FILES
  autotests/folding/highlight.pl.fold
  autotests/html/highlight.pl.html
  autotests/input/highlight.pl
  autotests/reference/highlight.pl.ref
  data/syntax/perl.xml

To: nibags
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D14632: keyword rule: Spport for keywords inclusion from another language/file

[Christoph Cullmann]

cullmann added a comment.


  The properties##CSS variant is really just like what I 
wanted, too!
  Nice.
  Only nitpick API wise: I would not expose the difference between 
includedDefinitions and includedKeywordDefinitions, I would just like to have 
all included definitions in includedDefinitions (and the docs altered that this 
covers all kind of includes)
  Beside making the API more complex I see no benefit in differentiating 
between that.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14632

To: jpoelen, #framework_syntax_highlighting, cullmann, dhaumann
Cc: kwrite-devel, vkrause, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D15390: Bash: fix parameter & brace expansion

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.


  +1, thanks.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix-bash

REVISION DETAIL
  https://phabricator.kde.org/D15390

To: nibags, cullmann, dhaumann, #framework_syntax_highlighting
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann