D15318: Automatically re-upload saved files located on remote locations instead of asking first

[Nathaniel Graham]

ngraham planned changes to this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15318

To: ngraham, #frameworks, broulik, jtamate
Cc: elvisangelaccio, kde-frameworks-devel, broulik, jtamate, michaelh, ngraham, 
bruns

D15318: Automatically re-upload saved files located on remote locations instead of asking first

[Nathaniel Graham]

ngraham retitled this revision from "[WIP] Automatically re-upload saved files 
located on remote locations instead of asking first" to "Automatically 
re-upload saved files located on remote locations instead of asking first".
ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15318

To: ngraham, #frameworks, broulik, jtamate
Cc: elvisangelaccio, kde-frameworks-devel, broulik, jtamate, michaelh, ngraham, 
bruns

D15318: [WIP] Automatically re-upload saved files located on remote locations instead of asking first

[Nathaniel Graham]

ngraham updated this revision to Diff 41718.
ngraham added a comment.


  - Only allow one upload job at a time; if one is already going, restart it

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15318?vs=41374=41718

BRANCH
  samba-auto-re-upload-after-save (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15318

AFFECTED FILES
  src/kioexec/kioexecd.cpp
  src/kioexec/kioexecd.h

To: ngraham, #frameworks, broulik, jtamate
Cc: elvisangelaccio, kde-frameworks-devel, broulik, jtamate, michaelh, ngraham, 
bruns

D14632: keyword rule: Spport for keywords inclusion from another language/file

[jonathan poelen]

jpoelen added a comment.


  Sorry to answer so late, I had trouble logging in.
  
  I think I misinterpreted the use of `includedDefinitions()`. For me, this 
function lists the languages ​included by the rules and which influence the 
colors. While the inclusion of a keyword list has no influence here. In the 
case of SASS, there is no IncludeRules to CSS because small syntactic details 
do not allow it, it would not be logical to have CSS in the list of 
`includedDefinitions()`.
  
  Basically, I added `includedKeywordDefinitions()` because of a Format test 
that did not work. But it's true that putting it in the public interface is not 
a good idea.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D14632

To: jpoelen, #framework_syntax_highlighting, cullmann, dhaumann
Cc: kwrite-devel, vkrause, kde-frameworks-devel, michaelh, kevinapavew, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.10 - Build # 112 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.10/112/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 15 Sep 2018 21:56:22 +
 Build duration:
3 min 17 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: TestSuite.kmoretoolstest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report38%
(5/13)18%
(11/61)18%
(11/61)16%
(897/5707)13%
(413/3297)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)100%
(81/81)53%
(38/72)autotests.kmoretools50%
(1/2)50%
(1/2)73%
(198/273)37%
(63/172)src22%
(2/9)22%
(2/9)2%
(22/960)0%
(0/368)src.attica0%
(0/2)0%
(0/2)0%
(0/283)0%
(0/215)src.core18%
(3/17)18%
(3/17)11%
(186/1697)10%
(124/1182)src.core.jobs0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/83)src.kmoretools60%
(3/5)60%
(3/5)52%
(410/796)36%
(188/528)src.qtquick0%
(0/5)0%
(0/5)0%
(0/276)0%
(0/104)src.staticxml0%
(0/1)0%
(0/1)0%
(0/157)0%
(0/134)src.ui0%
(0/8)0%
(0/8)0%
(0/745)0%
(0/317)src.upload0%
(0/1)0%
(0/1)0%
(0/121)0%
(0/80)tests0%
(0/2)0%
(0/2)0%
(0/32)0%
(0/20)tests.kmoretools0%
(0/1)0%
(0/1)0%
(0/101)0%
(0/22)

KDE CI: Frameworks » knewstuff » kf5-qt5 SUSEQt5.9 - Build # 71 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/knewstuff/job/kf5-qt5%20SUSEQt5.9/71/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 15 Sep 2018 21:56:22 +
 Build duration:
1 min 36 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: TestSuite.kmoretoolstest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report38%
(5/13)18%
(11/61)18%
(11/61)16%
(897/5707)13%
(413/3297)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)100%
(81/81)53%
(38/72)autotests.kmoretools50%
(1/2)50%
(1/2)73%
(198/273)37%
(63/172)src22%
(2/9)22%
(2/9)2%
(22/960)0%
(0/368)src.attica0%
(0/2)0%
(0/2)0%
(0/283)0%
(0/215)src.core18%
(3/17)18%
(3/17)11%
(186/1697)10%
(124/1182)src.core.jobs0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/83)src.kmoretools60%
(3/5)60%
(3/5)52%
(410/796)36%
(188/528)src.qtquick0%
(0/5)0%
(0/5)0%
(0/276)0%
(0/104)src.staticxml0%
(0/1)0%
(0/1)0%
(0/157)0%
(0/134)src.ui0%
(0/8)0%
(0/8)0%
(0/745)0%
(0/317)src.upload0%
(0/1)0%
(0/1)0%
(0/121)0%
(0/80)tests0%
(0/2)0%
(0/2)0%
(0/32)0%
(0/20)tests.kmoretools0%
(0/1)0%
(0/1)0%
(0/101)0%
(0/22)

D13880: [KMoreTools] Reduce menu hierarchy

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R304:9f54611a472d: [KMoreTools] Reduce menu hierarchy 
(authored by nicolasfella).

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13880?vs=41581=41716

REVISION DETAIL
  https://phabricator.kde.org/D13880

AFFECTED FILES
  src/kmoretools/kmoretools.cpp

To: nicolasfella, gregormi, dhaumann, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13880: [KMoreTools] Reduce menu hierarchy

[Dominik Haumann]

dhaumann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R304 KNewStuff

BRANCH
  arcpatch-D13880

REVISION DETAIL
  https://phabricator.kde.org/D13880

To: nicolasfella, gregormi, dhaumann, ngraham
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D9987: Lessen log spam by not checking for existence of file with empty name

[Dominik Haumann]

dhaumann added a comment.


  FYI: This now landed with 88be459559448d9d30b33f33b3ffd31fc41327c7 
 
(cf. https://commits.kde.org/kinit/88be459559448d9d30b33f33b3ffd31fc41327c7)

REPOSITORY
  R303 KInit

REVISION DETAIL
  https://phabricator.kde.org/D9987

To: rkflx, #frameworks
Cc: dfaure, kde-frameworks-devel, dhaumann, michaelh, ngraham, bruns

D15526: Fix rendering glitches caused by rounding errors in Code 128

[Sune Vuorela]

svuorela accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R280 Prison

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15526

To: vkrause, svuorela
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15527: Remove assumption about the barcode aspect ratio from the QML integration

[Sune Vuorela]

svuorela accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R280 Prison

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15527

To: vkrause, svuorela
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D8708: Introduce AbstractAnnotationItemDelegate for more control by consumer

[Dominik Haumann]

dhaumann added a comment.


  I commented on some things - I did not try this, though.
  
  What I would like to see is a comment // KF6: Merge 
KTextEditor::AnnotationViewInterfaceV2 into 
KTextEditor::AnnotationViewInterface (kossebau).
  For me, this comment is really important, since this tells you that you will 
in 2-3 years (when Qt6 arrives) work on this and merge it down: Since there is 
only you (KDevelop) who is using this interface, so you have to maintain it ;)
  
  Would you go over my comments and provide an updated version? Not all 
comments are real issues.

INLINE COMMENTS

> abstractannotationitemdelegate.h:39
> + * \brief The style option set for an annotation item, as painted by 
> AbstractAnnotationItemDelegate
> + */
> +class KTEXTEDITOR_EXPORT StyleOptionAnnotationItem : public QStyleOption

@since 5.52 :-)

> abstractannotationitemdelegate.h:52
> +/**
> + * Number of wrapped lines for the given real line
> + */

I am asking myself: Is wrappedLineCount >= 1 always true? If so, can you add 
this as documentation? wrappedLineCount == 1 means no wrapping line?

> abstractannotationitemdelegate.h:65
> +/**
> + * Recommended size for icons or other symbols
> + */

Is this to be set by the user, and if so, is there any special meaning to a 
default-constructed QSize()?

> abstractannotationitemdelegate.h:80
> + */
> +enum AnnotationItemGroupPosition {
> +InvalidGroupPosition = 0,  ///< Position not specified or not 
> belonging to a group

Is this a bitmask? The << 0, <<1, <<2 notation implies that it is.

> abstractannotationitemdelegate.h:95
> +public:
> +StyleOptionAnnotationItem()
> +: contentFontMetrics(QFont())

You export the class, but then the constructors are inlined. Could you please 
move the implementation to the cpp file? That leaves us more room to fixes by 
shipping an updated version of the library.

> abstractannotationitemdelegate.h:114
> +/**
> + * \brief An delegate for rendering line annotation information and handling 
> events for them
> + *

Typ: A delegate ...
And: I suggest to remove "for them".

> abstractannotationitemdelegate.h:136
> +protected:
> +explicit AbstractAnnotationItemDelegate(QObject *parent = nullptr)
> +: QObject(parent)

Same here: Could you move the implementation to ktexteditor.cpp?

> abstractannotationitemdelegate.h:141
> +public:
> +~AbstractAnnotationItemDelegate() override = default;
> +

Same here: Please move the destructor to ktexteditor.cpp. You can keep = 
default there, but not here.

> abstractannotationitemdelegate.h:179
> + * Whenever a help event occurs, this function is called with the event 
> view option
> + * and @p model and @p line specifiying the item where the event occurs.
> + * This pure abstract function must be reimplemented to provide custom 
> tooltips.

typo: specifying

> abstractannotationitemdelegate.h:183
> + * @param view the view for which the help event is requested
> + * @param option the style option object with the info needed for 
> styling, incl. the rect of the annotation
> + * @param model the annotation model providing the annotation information

inlc. -> including. No need for abbreviations

> annotationinterface.h:285
> + * and additionally
> + * - (1) set a custom AbstractAnnotationItemDelegate for the View:
> + *

Change trailing ':' to '.'

> annotationinterface.h:288
> + * For a more detailed explanation about whether you want to set a custom
> + * delegate fpr rendering the annotations, read the detailed documentation 
> about the
> + * AbstractAnnotationItemDelegate.

typo: fpr

> annotationinterface.h:328
> +/**
> + * Returns the currently used \ref AbstractAnnotationItemDelegate
> + *

I think you don't need to type "\ref". doxygen will create the link for you 
anyways. Same below.

> annotationinterface.h:330
> + *
> + * @returns the current \ref AbstractAnnotationItemDelegate
> + */

... or a nullptr, if no delegate was set. maybe? I am asking, since it could 
also return some default implementation.

> kateannotationitemdelegate.cpp:52-53
> +{
> +Q_ASSERT(painter);
> +Q_ASSERT(model);
> +if (!painter || !model) {

Given you check for a valid pointers here, would it also be an option to pass 
references? Or would that violate Qt style API?

> kateannotationitemdelegate.cpp:57
> +}
> +// TODO: also test line for validness for sake of completeness?
> +

validness --> validity :-)

> kateannotationitemdelegate.h:2-4
> +   Copyright (C) 2002 John Firebaugh 
> +   Copyright (C) 2001 Anders Lund 
> +   Copyright (C) 2001 Christoph Cullmann 

Is this copyright really correct?

> kateannotationitemdelegate.h:9
> +   modify it under the terms of the GNU Library General Public
> +   License version 2 as published by the Free Software Foundation.
> +

This is v2 only, I think this should be avoided at all costs... We try to get 
to v2+... I think you can change 

D6513: Add support for Attica tags support

[Dan Leinir Turthra Jensen]

leinir reopened this revision.
leinir added a comment.
This revision is now accepted and ready to land.


  In D6513#326519 , @rikmills wrote:
  
  > In D6513#326071 , @ngraham wrote:
  >
  > > FYI, this included an ABI change to `SearchRequest` that broke Discover: 
https://bugs.kde.org/show_bug.cgi?id=398412
  >
  >
  > I see this revision has been reverted in master in 
293ae2448f54fd1b1f7cacc86cd40b30a3fb087d 

  
  
  It has. I am currently (bar the odd break for a cup of tea) knee deep in 
house renovations, but i will be reopening this when i work out what to do to 
make this not ABI incompatible. In the meantime, suggestions for achieving the 
least hacky approach would be appreciated.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D6513

To: leinir, #knewstuff, apol, #kde_store, whiting, ahiemstra, mlaurent, dfaure, 
cfeck
Cc: rikmills, dfaure, cfeck, mlaurent, ngraham, ahiemstra, 
kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, bruns

D6513: Add support for Attica tags support

[Rik Mills]

rikmills added a comment.


  In D6513#326071 , @ngraham wrote:
  
  > FYI, this included an ABI change to `SearchRequest` that broke Discover: 
https://bugs.kde.org/show_bug.cgi?id=398412
  
  
  I see this revision has been reverted in master in 
293ae2448f54fd1b1f7cacc86cd40b30a3fb087d 


REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D6513

To: leinir, #knewstuff, apol, #kde_store, whiting, ahiemstra, mlaurent, dfaure, 
cfeck
Cc: rikmills, dfaure, cfeck, mlaurent, ngraham, ahiemstra, 
kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, bruns

D14757: Warn user before copy/move operation if available space is not enough

[Nathaniel Graham]

ngraham added a comment.


  We don't actually need to create a messagebox because it's up to the caller 
to display the error in an appropriate manner. For example, Dolphin shows 
errors inline rather than with dialog boxes. So we shouldn't create a 
messagebox at all.
  
  Let's see if we can figure out what to do:
  
  Elsewhere in `src/core/copyjob.cpp`, in `CopyJobPrivate::copyNextFile()`, we 
already check for the size of each individual file:
  
if (m_freeSpace < (*it).size) {
q->setError(ERR_DISK_FULL);
q->emitResult();
return;
}
  
  This works, but results in a half-finished copy, as it dies once it 
encounters the first file that doesn't fit. In 
`CopyJobPrivate::statCurrentSrc()`, the comment `//TODO warn user beforehand if 
space is not enough` gives us a clue for what to do: just add the same logic 
there, but check the total size of all copied files rather than the size of 
each individual file. So you would add the following:
  
if (m_totalSize > m_freeSpace) {
q->setError(ERR_DISK_FULL);
q->emitResult();
return;
}
  
  For bonus points, set the error text to something appropriate for each error. 
For example, something like this would work for the "whole transfer is too big" 
case:
  
q->setErrorText(
xi18n("There will not be enough free space available at 
%1 to hold the file (%2 are required but only %3 are 
available",
m_globalDest.toLocalFile(),
KIO::convertSize(m_totalSize),
KIO::convertSize(m_freeSpace) ) );

INLINE COMMENTS

> copyjob.cpp:887
>  qCDebug(KIO_COPYJOB_DEBUG)<<"Stating finished. To 
> copy:"<  //TODO warn user beforehand if space is not enough
> +if (m_totalSize > m_freeSpace) {

You can remove this comment now. :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14757

To: shubham, pino, dfaure, broulik
Cc: ngraham, dfaure, pino, kde-frameworks-devel, michaelh, bruns

D8708: Introduce AbstractAnnotationItemDelegate for more control by consumer

[Friedrich W. H. Kossebau]

kossebau updated this revision to Diff 41694.
kossebau added a comment.


  fix crash due to (no longer needed) circular dependencies on view object
  constrctions

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8708?vs=41225=41694

BRANCH
  addAnnotationItemDelegate

REVISION DETAIL
  https://phabricator.kde.org/D8708

AFFECTED FILES
  src/CMakeLists.txt
  src/include/CMakeLists.txt
  src/include/ktexteditor/abstractannotationitemdelegate.h
  src/include/ktexteditor/annotationinterface.h
  src/view/kateannotationitemdelegate.cpp
  src/view/kateannotationitemdelegate.h
  src/view/kateview.cpp
  src/view/kateview.h
  src/view/kateviewhelpers.cpp
  src/view/kateviewhelpers.h
  src/view/kateviewinternal.h

To: kossebau, #kate, #kdevelop
Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

Re: ABI break in KNewStuff

[Jonathan Riddell]

Now reverted

On Sat, 15 Sep 2018 at 11:56, David Edmundson
 wrote:
>
> >2ad3e66d81b63495a59d012f673af7bd854b53d7 is not included in the latest 
> >KNewStuff release 5.50,
>
> Oh. Thank goodness for people running various CI builds.
> @packagers, sorry for the noise
>
> @Jonathan
> That's handy. Go ahead and revert.

Re: ABI break in KNewStuff

[David Edmundson]

>2ad3e66d81b63495a59d012f673af7bd854b53d7 is not included in the latest
KNewStuff release 5.50,

Oh. Thank goodness for people running various CI builds.
@packagers, sorry for the noise

@Jonathan
That's handy. Go ahead and revert.

D15527: Remove assumption about the barcode aspect ratio from the QML integration

[Volker Krause]

vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  So far this only really worked for square 2d barcodes but produced very
  narrow results for 1d codes. Now the 1d codes are rendered as high as
  requested by the user.
  
  Also, register the Code 128 type with QML.

REPOSITORY
  R280 Prison

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15527

AFFECTED FILES
  src/quick/barcodequickitem.cpp
  src/quick/barcodequickitem.h

To: vkrause
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15526: Fix rendering glitches caused by rounding errors in Code 128

[Volker Krause]

vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REPOSITORY
  R280 Prison

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15526

AFFECTED FILES
  src/lib/code128barcode.cpp

To: vkrause
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15525: Fix rendering Aztec codes with an aspect ratio != 1

[Volker Krause]

vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REPOSITORY
  R280 Prison

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D15525

AFFECTED FILES
  src/lib/aztecbarcode.cpp

To: vkrause
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

Re: ABI break in KNewStuff

[Jonathan Riddell]

On Fri, Sep 14, 2018 at 06:05:26PM +0100, David Edmundson wrote:
> Packagers,
> 
> There's an ABI break in KNewStuff 5.55
> 
> (2ad3e66d81b63495a59d012f673af7bd854b53d7)
> 
> It's released now, I don't think we have any option as fixing it would mean we
> have 2 ABI breaks.
> 
> Can people please rebuild everything that depends on it. Especially
> plasma-discover.
> 
> See https://bugs.kde.org/398412 which is getting multiple reports a day.

2ad3e66d81b63495a59d012f673af7bd854b53d7 is not included in the latest 
KNewStuff release 5.50, it can be safely reverted from Git

Jonathan

D15511: Add support for Code 128 barcodes

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R280:fa3f31329aea: Add support for Code 128 barcodes (authored 
by vkrause).

REPOSITORY
  R280 Prison

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15511?vs=41659=41685

REVISION DETAIL
  https://phabricator.kde.org/D15511

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/code128barcodetest.cpp
  src/lib/CMakeLists.txt
  src/lib/code128barcode.cpp
  src/lib/code128barcode.h
  src/lib/prison.cpp
  src/lib/prison.h
  tests/barcode.qml

To: vkrause, svuorela
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15426: Avoid QByteArray::remove in AccessManagerReply::readData

[Luca Beltrame]

lbeltrame added a reviewer: dfaure.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15426

To: fvogt, #frameworks, elvisangelaccio, dfaure
Cc: ngraham, bruns, kde-frameworks-devel, michaelh

Re: Fwd: KDE CI: Administration » Dependency Build Plasma kf5-qt5 SUSEQt5.11 - Build # 5 - Failure!

[Christophe Giboudeaux]

On jeudi 13 septembre 2018 21:47:36 CEST Ben Cooksley wrote:
> Hi all,
> 
> Please see below. If someone could please take a look and fix this failure
> that would be appreciated.
> 
> On another note, the Marble build recently broke with a similar error - has
> something been changed in Frameworks to remove a dependency on DBus by any
> chance?
> 
[...]
> CMake Error at lib/CMakeLists.txt:17 (add_library):
> Target "milou" links to target "Qt5::DBus" but the target was not found.
> Perhaps a find_package() call is missing for an IMPORTED target, or an
> ALIAS target is missing?

For the record, this issue was fixed yesterday. 
The problem was a change in kpackage which added Qt5::DBus to the PUBLIC 
interface link.

Milou depends on plasma-framework which depends on kpackage but nothing was 
looking for Qt5DBus.

There are different ways to avoid this kind of build issues:
- add a find_dependency() call to your FooConfig.cmake file when you add a new 
public dependency
- and before that, make sure it's not a 'PRIVATE' link target. This was the 
case here, the commit didn't change the API.