D16395: Update the "About KDE" text

2018-10-23 Thread Andres Betts
abetts added a comment.


  > KDE has created the friendly and powerful Plasma desktop environment
  
  KDE has created the most friendly and powerful desktop environment, Plasma.
  
  > KDE is a cooperative enterprise in which no single entity
  
  KDE is a disaggregated development community not governed by...
  
  Just my .02 :D

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D16395

To: ngraham, #vdg, #plasma, #frameworks, #kde_applications
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns


D15002: Allow to install syntax files instead of having them in a resource

2018-10-23 Thread Christoph Cullmann
cullmann reopened this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  If you have ideas how, patches are welcome.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D15002

To: cullmann, vkrause, dhaumann
Cc: kfunk, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, 
bruns, demsking, cullmann, sars


KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 173 - Failure!

2018-10-23 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/173/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Wed, 24 Oct 2018 03:58:25 +
 Build duration:
25 min and counting
   CONSOLE OUTPUT
  [...truncated 17.01 KB...]Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/sysadmin/repo-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/sysadmin/repo-metadata > git fetch --tags --progress https://anongit.kde.org/sysadmin/repo-metadata +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision 0397c046ef10da81d9d12b51a3a9c97ada4db5b6 (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f 0397c046ef10da81d9d12b51a3a9c97ada4db5b6Commit message: "Move kdev-rust to unmaintained"[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/kde-build-metadata > git init /home/jenkins/workspace/Frameworks/plasma-framework/kf5-qt5 SUSEQt5.9/ci-tooling/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/kde-build-metadata # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-build-metadata > git fetch --tags --progress https://anongit.kde.org/kde-build-metadata +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision a2cf808c838fc1b1548a5f694b0f3e6397f4367f (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f a2cf808c838fc1b1548a5f694b0f3e6397f4367fCommit message: "kdev-rust moved to unmaintained"[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/kapidox > git init /home/jenkins/workspace/Frameworks/plasma-framework/kf5-qt5 SUSEQt5.9/ci-tooling/kapidox # timeout=10Fetching upstream changes from https://anongit.kde.org/kapidox > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/kapidox +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/kapidox # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/kapidox # timeout=10Fetching upstream changes from https://anongit.kde.org/kapidox > git fetch --tags --progress https://anongit.kde.org/kapidox +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision 022a670f2a09f8a243d95bc326cde15a53e2c6f7 (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f 022a670f2a09f8a243d95bc326cde15a53e2c6f7Commit message: "GIT_SILENT Upgrade KF5 version to 5.52.0."[Pipeline] checkoutCloning the remote Git repositoryCloning repository https://anongit.kde.org/kde-dev-scripts > git init /home/jenkins/workspace/Frameworks/plasma-framework/kf5-qt5 SUSEQt5.9/ci-tooling/kde-dev-scripts # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-dev-scripts > git --version # timeout=10 > git fetch --tags --progress https://anongit.kde.org/kde-dev-scripts +refs/heads/*:refs/remotes/origin/* > git config remote.origin.url https://anongit.kde.org/kde-dev-scripts # timeout=10 > git config --add remote.origin.fetch +refs/heads/*:refs/remotes/origin/* # timeout=10 > git config remote.origin.url https://anongit.kde.org/kde-dev-scripts # timeout=10Fetching upstream changes from https://anongit.kde.org/kde-dev-scripts > git fetch --tags --progress https://anongit.kde.org/kde-dev-scripts +refs/heads/*:refs/remotes/origin/* > git rev-parse origin/master^{commit} # timeout=10Checking out Revision 9a2d6fa83de1b4cc00e11f1d37afb17c765dff6f (origin/master) > git config core.sparsecheckout # timeout=10 > git checkout -f 9a2d6fa83de1b4cc00e11f1d37afb17c765dff6fCommit message: "Do not spellcheck the file with mistakes"[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Setup Dependencies)[Pipeline] sh[kf5-qt5 SUSEQt5.9] Running shell script+ python3 -u ci-tooling/helpers/prepare-dependencies.py --product Frameworks --project plasma-framework --branchGroup kf5-qt5 --environment production 

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.10 - Build # 122 - Fixed!

2018-10-23 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.10/122/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 24 Oct 2018 03:58:33 +
 Build duration:
8 min 8 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report22%
(5/23)26%
(14/53)26%
(14/53)19%
(417/2155)17%
(192/1106)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)97%
(124/128)55%
(54/98)src100%
(8/8)100%
(8/8)68%
(212/312)50%
(104/210)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/136)0%
(0/96)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/12)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/34)0%
(0/14)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/55)0%
(0/20)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/186)0%
(0/69)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/12)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/79)0%
(0/34)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/29)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/222)0%
(0/82)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/99)0%
(0/62)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/233)0%
(0/76)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/153)0%
(0/92)src.plugins.saveas100%
(1/1)100%
(1/1)57%
(29/51)64%
(28/44)src.plugins.telegram0%
(0/1)0%
(0/1)0%
(0/45)0%

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 248 - Still Unstable!

2018-10-23 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/248/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 24 Oct 2018 03:58:24 +
 Build duration:
8 min 39 sec and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(44/126)35%
(44/126)27%
(3601/13121)19%
(1821/9446)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(607/1113)29%
(313/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2221)7%
(96/1444)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)41%
(1420/3492)30%
(794/2633)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/135)0%
(0/12)src.plasma.private47%
(9/19)47%
(9/19)43%
(665/1544)30%
(301/1003)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)29%
(579/1978)18%
(312/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1096)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
  

D16395: Update the "About KDE" text

2018-10-23 Thread Nathaniel Graham
ngraham edited the test plan for this revision.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D16395

To: ngraham, #vdg, #plasma, #frameworks, #kde_applications
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D16395: Update the "About KDE" text

2018-10-23 Thread Nathaniel Graham
ngraham created this revision.
ngraham added reviewers: VDG, Plasma, Frameworks, KDE Applications.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This text had not been updated in a while, and mentioned "workspaces" as a 
product line. Let's bring it up to date.

TEST PLAN
  [image goes here]

REPOSITORY
  R263 KXmlGui

BRANCH
  update-about-kde-text (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16395

AFFECTED FILES
  src/kaboutkdedialog_p.cpp

To: ngraham, #vdg, #plasma, #frameworks, #kde_applications
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D15194: Draw a line separating PlasmaComponents tab bar from its content area

2018-10-23 Thread Nathaniel Graham
ngraham abandoned this revision.
ngraham added a comment.


  Not needed; we can and arguably should do all of this only in Kickoff since 
this style isn't guaranteed to look good everywhere. We'll do everything in 
D15206 .

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15194

To: ngraham, #plasma, #vdg
Cc: dhaumann, romangg, abetts, kde-frameworks-devel, michaelh, ngraham, bruns


D16392: [Config] Remove KDE4 config support, stop writing arbitrary config files

2018-10-23 Thread Nathaniel Graham
ngraham added a comment.


  Looks good, but what's our transition plan? Does this need any special 
handling for people who already have old config files?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D16392

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D15002: Allow to install syntax files instead of having them in a resource

2018-10-23 Thread Kevin Funk
kfunk added inline comments.

INLINE COMMENTS

> CMakeLists.txt:3
>  macro(generate_php_syntax_definition targetFile srcFile)
> -add_custom_command(
> -OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/${targetFile}
> -COMMAND ${PERL_EXECUTABLE} 
> ${CMAKE_CURRENT_SOURCE_DIR}/generators/generate-php.pl < 
> ${CMAKE_CURRENT_SOURCE_DIR}/syntax/${srcFile} > 
> ${CMAKE_CURRENT_BINARY_DIR}/${targetFile}
> -DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/generators/generate-php.pl 
> ${CMAKE_CURRENT_SOURCE_DIR}/syntax/${srcFile}
> -)
> +execute_process(COMMAND ${CMAKE_COMMAND} -E make_directory 
> ${CMAKE_CURRENT_BINARY_DIR}/syntax)
> +execute_process(COMMAND ${PERL_EXECUTABLE} 
> ${CMAKE_CURRENT_SOURCE_DIR}/generators/generate-php.pl

Note: The Ninja generator doesn't like this:

  CMake Warning (dev):
Policy CMP0058 is not set: Ninja requires custom command byproducts to be
explicit.  Run "cmake --help-policy CMP0058" for policy details.  Use the
cmake_policy command to set the policy and suppress this warning.
  
This project specifies custom command DEPENDS on files in the build tree
that are not specified as the OUTPUT or BYPRODUCTS of any
add_custom_command or add_custom_target:
  
 data/syntax/css-php.xml
 data/syntax/html-php.xml
 data/syntax/javascript-php.xml
  
For compatibility with versions of CMake that did not have the BYPRODUCTS
option, CMake is generating phony rules for such files to convince 'ninja'
to build.
  
Project authors should add the missing BYPRODUCTS or OUTPUT options to the
custom commands that produce these files.
  This warning is for project developers.  Use -Wno-dev to suppress it.

There must be a way to implement this feature and keep using 
`add_custom_command`...? Using `execute_process()` is usually a bad sign (tm). 
Note that these commands will be executed each CMake run(!)

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D15002

To: cullmann, vkrause, dhaumann
Cc: kfunk, dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, ngraham, 
bruns, demsking, cullmann, sars


D16385: [sftp] reformat to 4 space indentation

2018-10-23 Thread Aleix Pol Gonzalez
apol accepted this revision.

REPOSITORY
  R320 KIO Extras

BRANCH
  sftp-4space

REVISION DETAIL
  https://phabricator.kde.org/D16385

To: sitter, asn, ngraham, apol
Cc: asn, kde-frameworks-devel, kfm-devel, broulik, sourabhboss, feverfew, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp


D16392: [Config] Remove KDE4 config support, stop writing arbitrary config files

2018-10-23 Thread Stefan Brüns
bruns edited the summary of this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D16392

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D16392: [Config] Remove KDE4 config support, stop writing arbitrary config files

2018-10-23 Thread Stefan Brüns
bruns created this revision.
bruns added reviewers: Baloo, Frameworks, poboiko, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The KDE4 baloofilerc was only used by dolphin in the KDE4 migration
  phase and is no longer needed.
  
  In case a baloofilerc in the legacy location does not exist, the effect
  is even worse - the KConfig is instantiated with an empty path, and the
  config file name is derived from the application name. This leads to
  adding a "[General]" section in e.g. kcmshell5rc or systemsettingsrc.

TEST PLAN
  modify config using `balooctl config {add,rm}` or using SystemSettings
  -> .config/baloorc resp. .config/systemsettingsrc is no longer written,
  only .config/baloofilerc.

REPOSITORY
  R293 Baloo

BRANCH
  excludes

REVISION DETAIL
  https://phabricator.kde.org/D16392

AFFECTED FILES
  src/lib/indexerconfig.cpp

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


D16350: Allow KHelpCenter to open the right pages of KDE help when KHelpClient is invoked with an anchor

2018-10-23 Thread Yuri Chornoivan
yurchor updated this revision to Diff 44126.
yurchor added a comment.


  Save some clazy's kittens by using overloaded arg().

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16350?vs=44014=44126

REVISION DETAIL
  https://phabricator.kde.org/D16350

AFFECTED FILES
  src/khelpclient.cpp

To: yurchor, #documentation, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D15443: [server] Allow multiple touch interfaces per client

2018-10-23 Thread David Edmundson
davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  refactorSeatTouch

REVISION DETAIL
  https://phabricator.kde.org/D15443

To: romangg, #kwin, #frameworks, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns


D16084: Add Media and MediaEndpoint API header generation

2018-10-23 Thread David Rosca
This revision was automatically updated to reflect the committed changes.
Closed by commit R269:a65823a9aa43: Add Media and MediaEndpoint API header 
generation (authored by mweichselbaumer, committed by drosca).

REPOSITORY
  R269 BluezQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16084?vs=43243=44121

REVISION DETAIL
  https://phabricator.kde.org/D16084

AFFECTED FILES
  src/CMakeLists.txt
  tests/mediaendpointconnector.cpp
  tests/mediaendpointconnector.h

To: mweichselbaumer, drosca
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D16084: Add Media and MediaEndpoint API header generation

2018-10-23 Thread David Rosca
drosca accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D16084

To: mweichselbaumer, drosca
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D16387: [sftp] put request chunk debugging into own category

2018-10-23 Thread Kai Uwe Broulik
broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R320 KIO Extras

BRANCH
  sftp-trace-level

REVISION DETAIL
  https://phabricator.kde.org/D16387

To: sitter, asn, broulik, ngraham
Cc: kde-frameworks-devel, kfm-devel, sourabhboss, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp


D16387: [sftp] put request chunk debugging into own category

2018-10-23 Thread Andreas Schneider
asn added a comment.


  LGTM

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D16387

To: sitter, asn, broulik, ngraham
Cc: kde-frameworks-devel, kfm-devel, sourabhboss, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp


D16387: [sftp] put request chunk debugging into own category

2018-10-23 Thread Harald Sitter
sitter created this revision.
sitter added reviewers: asn, broulik, ngraham.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  it's excessively verbose and not necessarily useful unless one is actually
  debugging request handling, so separating this from the general slave
  debugging seems handy as one can enable one without the other.
  
  CCBUG: 368877

TEST PLAN
  builds, installs, has separate logging categories

REPOSITORY
  R320 KIO Extras

BRANCH
  sftp-trace-level

REVISION DETAIL
  https://phabricator.kde.org/D16387

AFFECTED FILES
  sftp/CMakeLists.txt
  sftp/kio_sftp.cpp

To: sitter, asn, broulik, ngraham
Cc: kde-frameworks-devel, kfm-devel, sourabhboss, feverfew, michaelh, spoorun, 
navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp


D16385: [sftp] reformat to 4 space indentation

2018-10-23 Thread Nathaniel Graham
ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R320 KIO Extras

BRANCH
  sftp-4space

REVISION DETAIL
  https://phabricator.kde.org/D16385

To: sitter, asn, ngraham
Cc: asn, kde-frameworks-devel, kfm-devel, broulik, sourabhboss, feverfew, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp


D16385: [sftp] reformat to 4 space indentation

2018-10-23 Thread Harald Sitter
sitter created this revision.
sitter added a reviewer: asn.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  while that generates history noise it's also much easier on the eyes and
  something @asn wants to happen.
  
  so, here we are

TEST PLAN
  builds

REPOSITORY
  R320 KIO Extras

BRANCH
  sftp-4space

REVISION DETAIL
  https://phabricator.kde.org/D16385

AFFECTED FILES
  sftp/kio_sftp.cpp

To: sitter, asn
Cc: asn, kde-frameworks-devel, kfm-devel, broulik, sourabhboss, feverfew, 
michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp


D16265: [Scheduler] Use flag to track when a runner is going idle

2018-10-23 Thread Stefan Brüns
bruns edited the summary of this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D16265

To: bruns, #baloo, #frameworks, poboiko, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams


KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.9 - Build # 172 - Still Unstable!

2018-10-23 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.9/172/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Tue, 23 Oct 2018 10:19:16 +
 Build duration:
3 min 25 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 14 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.plasma-iconitemtest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(9/18)45%
(57/126)45%
(57/126)39%
(5180/13181)29%
(2737/9444)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(13/14)93%
(13/14)96%
(1068/1117)51%
(552/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core44%
(7/16)44%
(7/16)33%
(749/2240)27%
(388/1442)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)48%
(1700/3506)39%
(1030/2633)src.plasma.packagestructure57%
(4/7)57%
(4/7)37%
(51/138)42%
(5/12)src.plasma.private63%
(12/19)63%
(12/19)61%
(945/1558)42%
(425/1003)src.plasma.scripting67%
(2/3)67%
(2/3)20%
(34/166)10%
(13/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)30%
(589/1977)19%
(319/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid17%
(1/6)17%
(1/6)1%
(13/1098)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
(0/2)0%
(0/61)0%
(0/16)tests.testengine0%

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 247 - Still Unstable!

2018-10-23 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/247/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Tue, 23 Oct 2018 10:19:16 +
 Build duration:
3 min 3 sec and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(44/126)35%
(44/126)27%
(3601/13121)19%
(1821/9446)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(607/1113)29%
(313/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/463)0%
(0/231)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2221)7%
(96/1444)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)41%
(1420/3492)30%
(794/2633)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/135)0%
(0/12)src.plasma.private47%
(9/19)47%
(9/19)43%
(665/1544)30%
(301/1003)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)29%
(579/1978)18%
(312/1702)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1096)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
   

D7909: Add syntax support for Crystal Programming Language

2018-10-23 Thread Faustino Aguilar
faguilar added a comment.


  In D7909#346328 , @cullmann wrote:
  
  > Ping? ;=)
  
  
  Hi, I'm still here, I need some more time to get it working well. :)

REPOSITORY
  R40 Kate

REVISION DETAIL
  https://phabricator.kde.org/D7909

To: faguilar, dhaumann, vkrause, #framework_syntax_highlighting, #kate, mwolff, 
cullmann
Cc: kwrite-devel, oprypin, mwolff, cullmann, ngraham, #kate, #frameworks, 
faguilar, bmortimer, michaelh, genethomas, bruns, demsking, vkrause, sars, 
dhaumann