D15368: [Comic Thumbnailer] support more image formats

[Florian Léger]

fleger added reviewers: broulik, Frameworks.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D15368

To: fleger, broulik, #frameworks
Cc: kde-frameworks-devel, kfm-devel, alexde, sourabhboss, feverfew, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D15367: [Comic Thumbnailer] fix CBR thumbnail generation

[Florian Léger]

fleger added reviewers: broulik, Frameworks.
Herald added projects: Dolphin, Frameworks.
Herald added subscribers: kfm-devel, kde-frameworks-devel.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D15367

To: fleger, broulik, #frameworks
Cc: kde-frameworks-devel, kfm-devel, alexde, sourabhboss, feverfew, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

KDE CI: Frameworks » kcrash » kf5-qt5 WindowsMSVCQt5.11 - Build # 14 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcrash/job/kf5-qt5%20WindowsMSVCQt5.11/14/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Thu, 22 Nov 2018 09:55:53 +
 Build duration:
20 hr and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 2 test(s)Failed: TestSuite.kcrashtest

D16919: Re-add DBus test

[Ben Cooksley]

bcooksley added a comment.


  When you did your reproduction attempt @hindenburg did you use the binaries 
the CI system itself uses, or did you build Frameworks, etc yourself?

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D16919

To: davidedmundson, #konsole, #frameworks, hindenburg
Cc: bcooksley, hindenburg, konsole-devel, ngraham, maximilianocuria

D17088: [thumbnailer appimage] Fix building with libappimage not in system path

[Friedrich W. H. Kossebau]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R320:6c2ebbb5b853: [thumbnailer appimage] Fix building with 
libappimage not in system path (authored by kossebau).

REPOSITORY
  R320 KIO Extras

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17088?vs=45983=46055

REVISION DETAIL
  https://phabricator.kde.org/D17088

AFFECTED FILES
  thumbnail/CMakeLists.txt

To: kossebau, broulik, TheAssassin, azubieta
Cc: kde-frameworks-devel, kfm-devel, alexde, sourabhboss, feverfew, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D17091: Remove ununsed wdfInc parameter for addTerm and addPositionTerm

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:26a879838ace: Remove ununsed wdfInc parameter for addTerm 
and addPositionTerm (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17091?vs=45990=46052

REVISION DETAIL
  https://phabricator.kde.org/D17091

AFFECTED FILES
  src/engine/document.cpp
  src/engine/document.h
  src/engine/termgenerator.cpp
  src/engine/termgenerator.h
  src/file/basicindexingjob.cpp
  src/file/extractor/result.cpp

To: bruns, #baloo, #frameworks, ngraham, poboiko, apol
Cc: apol, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D17089: Do not add Type::Document/Presentation/Spreadsheet twice for MS Office docs

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
bruns marked an inline comment as done.
Closed by commit R293:149c8b2379df: Do not add 
Type::Document/Presentation/Spreadsheet twice for MS Office docs (authored by 
bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17089?vs=45987=46050

REVISION DETAIL
  https://phabricator.kde.org/D17089

AFFECTED FILES
  src/file/basicindexingjob.cpp

To: bruns, #baloo, #frameworks, ngraham, poboiko, lbeltrame
Cc: lbeltrame, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D17090: Use append instead of operator+= when appending to an QVector

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:4b406b107792: Use append instead of operator+= when 
appending to an QVectorint (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17090?vs=45988=46051

REVISION DETAIL
  https://phabricator.kde.org/D17090

AFFECTED FILES
  src/engine/document.cpp

To: bruns, #baloo, #frameworks, ngraham, poboiko, lbeltrame
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17114: [KUrlNavigator] Re-activate on mouse middle button click

[Thomas Surrel]

thsurrel updated this revision to Diff 46049.
thsurrel added a comment.


  Fix

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17114?vs=46047=46049

BRANCH
  arc_kurlnavigator (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17114

AFFECTED FILES
  src/filewidgets/kurlnavigator.cpp
  src/filewidgets/kurlnavigator.h

To: thsurrel, #frameworks, elvisangelaccio
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17114: [KUrlNavigator] Re-activate on mouse middle button click

[Thomas Surrel]

thsurrel edited the summary of this revision.
thsurrel edited the test plan for this revision.
thsurrel added reviewers: Frameworks, elvisangelaccio.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17114

To: thsurrel, #frameworks, elvisangelaccio
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17114: [KUrlNavigator] Re-activate on mouse middle button click

[Thomas Surrel]

thsurrel created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
thsurrel requested review of this revision.

REPOSITORY
  R241 KIO

BRANCH
  arc_kurlnavigator (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17114

AFFECTED FILES
  src/filewidgets/kurlnavigator.cpp
  src/filewidgets/kurlnavigator.h

To: thsurrel
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12674: Mark `Phonon4Qt5` dependency as optional in CMakeLists file

[Christoph Feck]

cfeck set the repository for this revision to R289 KNotifications.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D12674

To: ntninja, kde-frameworks-devel, apol
Cc: kde-frameworks-devel, apol, ltoscano, cgiboudeaux, michaelh, ngraham, bruns

D12709: Allow skipping the build of the KPackage install handlers when building `frameworkintegration`

[Alexander Schlarb]

ntninja added a comment.


  Since these changes have been approved and marked read-to-land for quite some 
time, could this please be done soon? Thank you!

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D12709

To: ntninja, dfaure
Cc: dfaure, apol, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 WindowsMSVCQt5.11 - Build # 39 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20WindowsMSVCQt5.11/39/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Thu, 22 Nov 2018 20:29:06 +
 Build duration:
12 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 82 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/82/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Thu, 22 Nov 2018 20:27:38 +
 Build duration:
1 min 54 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)77%
(232/300)58%
(105/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)56%
(10/18)autotests100%
(5/5)100%
(5/5)78%
(190/243)58%
(95/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 138 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/138/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 22 Nov 2018 20:27:38 +
 Build duration:
1 min 44 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)77%
(232/300)58%
(105/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)56%
(10/18)autotests100%
(5/5)100%
(5/5)78%
(190/243)58%
(95/164)

D16983: Move firewall-applet icons to status category

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:7e27acf7e1a8: Move firewall-applet icons to status 
category (authored by ndavis).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D16983?vs=45929=46038#toc

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16983?vs=45929=46038

REVISION DETAIL
  https://phabricator.kde.org/D16983

AFFECTED FILES
  icons-dark/apps/16/firewall-applet-error.svg
  icons-dark/apps/16/firewall-applet-panic.svg
  icons-dark/apps/16/firewall-applet-shields_up.svg
  icons-dark/apps/16/firewall-applet.svg
  icons-dark/apps/22/firewall-applet-error.svg
  icons-dark/apps/22/firewall-applet-panic.svg
  icons-dark/apps/22/firewall-applet-shields_up.svg
  icons-dark/apps/22/firewall-applet.svg
  icons-dark/status/16/firewall-applet-error.svg
  icons-dark/status/16/firewall-applet-panic.svg
  icons-dark/status/16/firewall-applet-shields_up.svg
  icons-dark/status/16/firewall-applet.svg
  icons-dark/status/22/firewall-applet-error.svg
  icons-dark/status/22/firewall-applet-panic.svg
  icons-dark/status/22/firewall-applet-shields_up.svg
  icons-dark/status/22/firewall-applet.svg
  icons/apps/16/firewall-applet-error.svg
  icons/apps/16/firewall-applet-panic.svg
  icons/apps/16/firewall-applet-shields_up.svg
  icons/apps/16/firewall-applet.svg
  icons/apps/22/firewall-applet-error.svg
  icons/apps/22/firewall-applet-panic.svg
  icons/apps/22/firewall-applet-shields_up.svg
  icons/apps/22/firewall-applet.svg
  icons/status/16/firewall-applet-error.svg
  icons/status/16/firewall-applet-panic.svg
  icons/status/16/firewall-applet-shields_up.svg
  icons/status/16/firewall-applet.svg
  icons/status/22/firewall-applet-error.svg
  icons/status/22/firewall-applet-panic.svg
  icons/status/22/firewall-applet-shields_up.svg
  icons/status/22/firewall-applet.svg

To: ndavis, #vdg, #breeze, ngraham
Cc: sitter, aacid, ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 137 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/137/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 22 Nov 2018 20:11:23 +
 Build duration:
7 min 8 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)78%
(234/300)58%
(106/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)56%
(10/18)autotests100%
(5/5)100%
(5/5)79%
(192/243)59%
(96/164)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.9 - Build # 81 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.9/81/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Thu, 22 Nov 2018 20:11:23 +
 Build duration:
1 min 28 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: TestSuite.scalable
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(2/2)100%
(6/6)100%
(6/6)78%
(234/300)58%
(106/182)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault100%
(1/1)100%
(1/1)74%
(42/57)56%
(10/18)autotests100%
(5/5)100%
(5/5)79%
(192/243)59%
(96/164)

D17062: Fix angle and margin of 32px dialog-ok-apply

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:e1375f0efcdf: Fix angle and margin of 32px 
dialog-ok-apply (authored by trickyricky26, committed by ndavis).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17062?vs=46036=46037

REVISION DETAIL
  https://phabricator.kde.org/D17062

AFFECTED FILES
  icons-dark/actions/32/dialog-ok-apply.svg
  icons-dark/actions/32/dialog-ok.svg
  icons-dark/actions/32/gtk-ok.svg
  icons/actions/32/dialog-ok-apply.svg
  icons/actions/32/dialog-ok.svg
  icons/actions/32/gtk-ok.svg

To: trickyricky26, #vdg, #breeze, ndavis
Cc: ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

D17062: Fix angle and margin of 32px dialog-ok-apply

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  All correct!

REPOSITORY
  R266 Breeze Icons

BRANCH
  arcpatch-D17062

REVISION DETAIL
  https://phabricator.kde.org/D17062

To: trickyricky26, #vdg, #breeze, ndavis
Cc: ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

D17062: Fix angle and margin of 32px dialog-ok-apply

[TrickyRicky]

trickyricky26 retitled this revision from "Fix wrong angle and margin of 32px 
dialog-ok-apply; new symlinks" to "Fix angle and margin of 32px 
dialog-ok-apply".

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17062

To: trickyricky26, #vdg, #breeze, ndavis
Cc: ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

D12674: Mark `Phonon4Qt5` dependency as optional in CMakeLists file

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Makes sense to me, it's even already if'd!

REVISION DETAIL
  https://phabricator.kde.org/D12674

To: ntninja, kde-frameworks-devel, apol
Cc: kde-frameworks-devel, apol, ltoscano, cgiboudeaux, michaelh, ngraham, bruns

D17062: Fix wrong angle and margin of 32px dialog-ok-apply; new symlinks

[TrickyRicky]

trickyricky26 updated this revision to Diff 46036.
trickyricky26 added a comment.


  Rebase onto master

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17062?vs=45914=46036

BRANCH
  arcpatch-D17062

REVISION DETAIL
  https://phabricator.kde.org/D17062

AFFECTED FILES
  icons-dark/actions/32/dialog-ok-apply.svg
  icons-dark/actions/32/dialog-ok.svg
  icons-dark/actions/32/gtk-ok.svg
  icons/actions/32/dialog-ok-apply.svg
  icons/actions/32/dialog-ok.svg
  icons/actions/32/gtk-ok.svg

To: trickyricky26, #vdg, #breeze, ndavis
Cc: ndavis, kde-frameworks-devel, michaelh, ngraham, bruns

D12674: Mark `Phonon4Qt5` dependency as optional in CMakeLists file

[Alexander Schlarb]

ntninja updated this revision to Diff 46035.
ntninja added a comment.


  Updated to latest KF5 version and probably fixed the issue mentioned in 
review – although I have no idea what it was.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12674?vs=33575=46035

REVISION DETAIL
  https://phabricator.kde.org/D12674

AFFECTED FILES
  CMakeLists.txt

To: ntninja
Cc: kde-frameworks-devel, apol, ltoscano, cgiboudeaux, michaelh, ngraham, bruns

D12674: Mark `Phonon4Qt5` dependency as optional in CMakeLists file

[Alexander Schlarb]

ntninja added a reviewer: kde-frameworks-devel.

REVISION DETAIL
  https://phabricator.kde.org/D12674

To: ntninja, kde-frameworks-devel
Cc: kde-frameworks-devel, apol, ltoscano, cgiboudeaux, michaelh, ngraham, bruns

D17089: Do not add Type::Document/Presentation/Spreadsheet twice for MS Office docs

[Stefan Brüns]

bruns marked an inline comment as done.
bruns added inline comments.

INLINE COMMENTS

> lbeltrame wrote in basicindexingjob.cpp:153
> Remove instead of committing commented out code?

I prefer not to remove it, at least not completely. I think it is useful to 
have the mimetypes listed explicitly, so if someone greps for it it is obvious 
these are already covered.
probably:

  // The pre-XML MS Office formats are already covered by the "contains" above:
  // "application/vnd.ms-powerpoint"
  // "application/vnd.ms-excel"

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17089

To: bruns, #baloo, #frameworks, ngraham, poboiko, lbeltrame
Cc: lbeltrame, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D16919: Re-add DBus test

[Kurt Hindenburg]

hindenburg added a comment.


  I manage to build the docker kdeorg/ci-suse-qt59  image - and of course the 
tests pass - so I'm not sure how to help now.  I've already disabled this test 
again to avoid the sysadmins having more work to do.

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D16919

To: davidedmundson, #konsole, #frameworks, hindenburg
Cc: hindenburg, konsole-devel, ngraham, maximilianocuria

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 268 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/268/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 22 Nov 2018 18:11:23 +
 Build duration:
7 min 46 sec and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(44/125)35%
(44/125)27%
(3587/13046)19%
(1812/9409)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(607/1113)29%
(313/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/461)0%
(0/231)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2220)7%
(96/1442)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)41%
(1400/3442)30%
(785/2609)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/135)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)44%
(671/1521)30%
(301/990)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)29%
(579/1979)18%
(312/1704)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1096)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
   

D17052: Simplify reference counting of FrameData

[Aleix Pol Gonzalez]

apol closed this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D17052

To: apol, #plasma, #frameworks, zzag
Cc: mart, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D17052: Simplify reference counting of FrameData

[Vlad Zagorodniy]

zzag accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17052

To: apol, #plasma, #frameworks, zzag
Cc: mart, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D17052: Simplify reference counting of FrameData

[Aleix Pol Gonzalez]

apol updated this revision to Diff 46026.
apol added a comment.


  Change destructor

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17052?vs=45893=46026

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17052

AFFECTED FILES
  src/plasma/framesvg.cpp
  src/plasma/private/framesvg_p.h
  src/plasma/private/theme_p.cpp

To: apol, #plasma, #frameworks
Cc: mart, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D17052: Simplify reference counting of FrameData

[Aleix Pol Gonzalez]

apol marked an inline comment as done.
apol added inline comments.

INLINE COMMENTS

> zzag wrote in framesvg.cpp:569
> Do we really need to pass a shared pointer? Wouldn't it better to just pass a 
> raw pointer? We won't do any ownership-related stuff anyway.

It doesn't really make a difference because it's a const& so it doesn't 
construct a new object (i.e. it doesn't refcount +1 and -1 upon leave).
On the other hand this makes it possible to pass the object we store without 
calling anything which I see as an advantage.

> zzag wrote in framesvg.cpp:618
> Just newFd->cacheId.

Can't do, QWeakPointer doesn't overload operator->

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D17052

To: apol, #plasma, #frameworks
Cc: mart, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D17079: Provide a qqc2/kirigami-based about page

[Marco Martin]

mart added a comment.


  In D17079#364263 , @apol wrote:
  
  > In D17079#364163 , @ltoscano 
wrote:
  >
  > > In D17079#364157 , @mart wrote:
  > >
  > > > I think this ui should really go into KCoreAddons itself. Would it be 
accepted there?
  > >
  > >
  > > kcoreaddons is tier1 just like kirigami. Why not create a new Frameworks, 
kirigami-addons (or another appropriate name), which would collect all the 
common UI items which depends on other frameworks? Basically the kxmlgui of 
Kirigami.
  >
  >
  > I think an external framework is a big overkill. In this case, it's only 
runtime dependencies so both either kcoreaddons or kirigami could offer it. I 
would favor putting it in kirigami because there's the duck-typing opportunity 
there too, but it may be a stretch.
  >  That said, we'll need someone to register the KAbout* types somewhere too, 
but we can also rely on applications doing that as a first iteration.
  
  
  one thing i'm a bit concerned is kirigami becomeing too much of a QML kdelibs 
monolith :p

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17079

To: apol, #plasma, #frameworks
Cc: mart, leinir, ngraham, ltoscano, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D17071: Don't include any directory sizes in DirectorySizeJob

[Adriaan de Groot]

adridg added a comment.


  With UFS, stat(1) tells me
  
[adridg@beastie .../kio/build]$ stat .
2080587972 222556 drwxr-xr-x 9 adridg adridg 4294967295 17 "Nov 22 14:40:28 
2018" "Nov 22 14:42:22 2018" "Nov 22 14:42:22 2018" "Nov 22 14:39:51 2018" 
131072 17 0x800 .
  
  So that's a size of 17 -- on UFS that looks like the count of the files in 
the directory (I added a file and then size is 18).
  
  Without this patch: jobtest has 71 tests, all pass.
  With this patch: jobtest has 71 tests, all pass.
  
  (Note that I ran the test against Frameworks 5.51, since I don't have 5.52 
installed yet)

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17071

To: davidedmundson, dfaure, apol
Cc: adridg, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D17079: Provide a qqc2/kirigami-based about page

[Aleix Pol Gonzalez]

apol added a comment.


  In D17079#364163 , @ltoscano wrote:
  
  > In D17079#364157 , @mart wrote:
  >
  > > I think this ui should really go into KCoreAddons itself. Would it be 
accepted there?
  >
  >
  > kcoreaddons is tier1 just like kirigami. Why not create a new Frameworks, 
kirigami-addons (or another appropriate name), which would collect all the 
common UI items which depends on other frameworks? Basically the kxmlgui of 
Kirigami.
  
  
  I think an external framework is a big overkill. In this case, it's only 
runtime dependencies so both either kcoreaddons or kirigami could offer it. I 
would favor putting it in kirigami because there's the duck-typing opportunity 
there too, but it may be a stretch.
  That said, we'll need someone to register the KAbout* types somewhere too, 
but we can also rely on applications doing that as a first iteration.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17079

To: apol, #plasma, #frameworks
Cc: mart, leinir, ngraham, ltoscano, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D17103: SpellCheckBar: Use DictionaryComboBox instead of plain QComboBox

[loh tar]

loh.tar added a comment.


  It would be nice someone could explain, or point me where to read, why there 
is no (more) direct use of Sonnet stuff in KTextEditor/Kate.
  
  1. KTextEditor::SpellCheckBar looks (almost) the same as Sonnet::Dialog but 
has differently ingredients. I had expect, after my first poke around in 
Sonnet, that these are appear in Kate. Yes some, but not all.
  2. I was even more surprised to see that Sonnet ships some demo/test 
applications where the spellcheck, respectively correction by mouse, works like 
a charm with a morphed context menu shown only what is of interest, where as 
Kate shows the full menu where you have to fiddle down/around which is pretty 
annoying, almost unusable.
  
  To 1., if it is desired to get rid of KTextEditor::SpellCheckBar and use 
Sonnet::Dialog, I would try to do it. The usability of both are not so nice. I 
use the Nano editor for some tasks and like there spell check user interface, 
very handy. Well, it's for me indeed a major reason to use Nano at all. So, I 
would try to "copy" that interface.
  
  To 2., needless to emphasize, I like to see that in Kate too

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17103

To: loh.tar, cullmann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, michaelh, ngraham, bruns, 
demsking, head7, cullmann, kfunk, sars, dhaumann

D17103: SpellCheckBar: Use DictionaryComboBox instead of plain QComboBox

[loh tar]

loh.tar created this revision.
loh.tar added a reviewer: cullmann.
loh.tar added a project: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.

REVISION SUMMARY
  This patch alone is reasonable but become really important with the aim of 
D17030 
  and complies to D17056 

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17103

AFFECTED FILES
  src/spellcheck/spellcheckbar.cpp
  src/spellcheck/spellcheckbar.ui

To: loh.tar, cullmann
Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, michaelh, ngraham, bruns, 
demsking, head7, cullmann, kfunk, sars, dhaumann

D17070: Don't double-count size of directories in DirectorySizeJob

[Adriaan de Groot]

adridg added a comment.


  With UFS, stat(1) tells me
  
[adridg@beastie .../kio/build]$ stat .
2080587972 222556 drwxr-xr-x 9 adridg adridg 4294967295 17 "Nov 22 14:40:28 
2018" "Nov 22 14:42:22 2018" "Nov 22 14:42:22 2018" "Nov 22 14:39:51 2018" 
131072 17 0x800 .
  
  So that's a size of 17 -- on UFS that looks like the count of the files in 
the directory (I added a file and then size is 18).
  
  Without this patch: jobtest has 71 tests, all pass.
  With this patch: jobtest has 71 tests, 1 fails.
  
QDEBUG : JobTest::directorySize() totalSize:  50
QDEBUG : JobTest::directorySize() totalFiles:  7
QDEBUG : JobTest::directorySize() totalSubdirs:  4
FAIL!  : JobTest::directorySize() 'job->totalSize() >= 60' returned FALSE. 
(totalSize was 50)
   Loc: [/home/adridg/src/kde/tier-3/kio/autotests/jobtest.cpp(1099)]
  
  With this patch, and D17071  as well, the 
failure is the same: 71 tests, 1 fails, same case and failure message.
  
  (Note that I ran the test against Frameworks 5.51, since I don't have 5.52 
installed yet)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17070

To: davidedmundson, dfaure
Cc: adridg, kde-frameworks-devel, michaelh, ngraham, bruns

D17079: Provide a qqc2/kirigami-based about page

[Luigi Toscano]

ltoscano added a comment.


  In D17079#364157 , @mart wrote:
  
  > I think this ui should really go into KCoreAddons itself. Would it be 
accepted there?
  
  
  kcoreaddons is tier1 just like kirigami. Why not create a new Frameworks, 
kirigami-addons (or another appropriate name), which would collect all the 
common UI items which depends on other frameworks? Basically the kxmlgui of 
Kirigami.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17079

To: apol, #plasma, #frameworks
Cc: mart, leinir, ngraham, ltoscano, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D17079: Provide a qqc2/kirigami-based about page

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> DiscoverWindow.qml:76
>  }
> +TopLevelPageData {
> +id: aboutAction

can you try how does it look for this page to be pushed as a layer instead of 
the main PageRow?
would be like applicationWindow().pageStack.layers.push(thecomponentorurl)
it would end up more "modal"than using the main row.
I have no idea what would be better usability-wise, but is a thing could be 
tried (and then codified in the hig)

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17079

To: apol, #plasma, #frameworks
Cc: mart, leinir, ngraham, ltoscano, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D17079: Provide a qqc2/kirigami-based about page

[Marco Martin]

mart added a comment.


  I think this ui should really go into KCoreAddons itself. Would it be 
accepted there?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17079

To: apol, #plasma, #frameworks
Cc: mart, leinir, ngraham, ltoscano, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D17052: Simplify reference counting of FrameData

[Marco Martin]

mart added a comment.


  after adressing zzag's comments, is good to go for me

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D17052

To: apol, #plasma, #frameworks
Cc: mart, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D17078: Make it possible to use KAboutData/License/Person from QML

[Marco Martin]

mart added a comment.


  adding a default value should be bc, the opposite of course is not..
  in its current state, looks good to me

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D17078

To: apol, #frameworks, dfaure
Cc: mart, mpyne, broulik, anthonyfieroni, kde-frameworks-devel, michaelh, 
ngraham, bruns

D17079: Provide a qqc2/kirigami-based about page

[Marco Martin]

mart added a comment.


  In D17079#363975 , @ngraham wrote:
  
  > Cool!
  >
  > For this design, I'd like to get rid of the tabs and put everything in a 
scrollview. We generally have enough space that a tabbed view is overkill.
  
  
  +1

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17079

To: apol, #plasma, #frameworks
Cc: mart, leinir, ngraham, ltoscano, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D17079: Provide a qqc2/kirigami-based about page

[Dan Leinir Turthra Jensen]

leinir added a comment.


  Basically what Nate said, this is a great idea :) Thinking that having this 
is already an improvement, but also perhaps that having it as a scrollable page 
would indeed feel more natural here rather than tabs... Thinking this seems 
like a good place to use the fact that Cards are good for not-quite-similar 
data, or am i off there?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17079

To: apol, #plasma, #frameworks
Cc: leinir, ngraham, ltoscano, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17052: Simplify reference counting of FrameData

[Marco Martin]

mart added a comment.


  things like https://bugs.kde.org/show_bug.cgi?id=398854 i guess

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D17052

To: apol, #plasma, #frameworks
Cc: mart, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D17085: Fix language load after including keywords from this language in another file

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Uh, good catch.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix-keys-include

REVISION DETAIL
  https://phabricator.kde.org/D17085

To: nibags, #framework_syntax_highlighting, cullmann, dhaumann, vkrause, jpoelen
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

D17091: Remove ununsed wdfInc parameter for addTerm and addPositionTerm

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  I'd change the wording. It's being exported, only that the headers aren't 
being installed so it's not really usable. ;)

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17091

To: bruns, #baloo, #frameworks, ngraham, poboiko, apol
Cc: apol, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D17088: [thumbnailer appimage] Fix building with libappimage not in system path

[TheAssassin]

TheAssassin added a comment.


  There will be packages for libappimage (hopefully) soon, which provide a 
`.pc` file. This provides an alternative to using these generated CMake config 
files, which can be used through CMake's pkg-config module 
(`find_package(PkgConfig)`).

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D17088

To: kossebau, broulik, TheAssassin, azubieta
Cc: kde-frameworks-devel, kfm-devel, alexde, sourabhboss, feverfew, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D17088: [thumbnailer appimage] Fix building with libappimage not in system path

[Kai Uwe Broulik]

broulik added a comment.


  Don't know much cmake but still builds fine here with this change, so +1 from 
me

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D17088

To: kossebau, broulik, TheAssassin, azubieta
Cc: kde-frameworks-devel, kfm-devel, alexde, sourabhboss, feverfew, michaelh, 
spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, 
mikesomov

D17086: Add icons for application-vnd.appimage

[TheAssassin]

TheAssassin added a comment.


  AppImages are, after all, only ELF executables. They're not archives. Using a 
zipper implies this, though. I really like the initial version that mimics the 
"normal executable" icon better. The dark blue is quite nice, but I thought 
perhaps a color from the official AppImage logo might fit better.
  
  A few alternative background colors, taken from the official AppImage logo:
  
  - 97b8ca (inner background, top, near center)
  - 5389a9 (inner background, bottom left)
  - 75a1ba (inner background, ~ vertical center)
  
  The logo could by the way also be used for the type 1 MIME type, 
`application/x-iso9660-appimage` and `application/x-appimage` IIRC. 
  You might also add a `1` somewhere in there to indicate the type, but as both 
are still relevant and should mostly work equally, that's not really necessary.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17086

To: kossebau, #vdg, ngraham
Cc: TheAssassin, ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 267 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/267/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 22 Nov 2018 10:00:51 +
 Build duration:
4 min 18 sec and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(44/125)35%
(44/125)27%
(3599/13091)19%
(1820/9433)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(607/1113)29%
(313/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/461)0%
(0/231)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2220)7%
(96/1442)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)41%
(1418/3488)30%
(794/2633)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/135)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)44%
(665/1520)30%
(300/990)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)29%
(579/1979)18%
(312/1704)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1096)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
   

KDE CI: Frameworks » kcrash » kf5-qt5 WindowsMSVCQt5.11 - Build # 13 - Aborted!

[CI System]

BUILD ABORTED
 Build URL
https://build.kde.org/job/Frameworks/job/kcrash/job/kf5-qt5%20WindowsMSVCQt5.11/13/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Mon, 19 Nov 2018 13:03:21 +
 Build duration:
2 days 20 hr and counting

D17093: Rust & Yacc/Bison: improve comments

[Nibaldo González]

nibags created this revision.
nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  Add `##Alerts` and `##Modelines` in comments. It also increases "kateversion" 
to 5.0 in yacc.xml, since it uses WordDetect rules.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  improve-comments-rust-yacc

REVISION DETAIL
  https://phabricator.kde.org/D17093

AFFECTED FILES
  autotests/folding/highlight.y.fold
  autotests/folding/test.rs.fold
  autotests/html/highlight.y.html
  autotests/html/test.rs.html
  autotests/input/highlight.y
  autotests/input/test.rs
  autotests/reference/highlight.y.ref
  autotests/reference/test.rs.ref
  data/syntax/rust.xml
  data/syntax/yacc.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

D17092: Add syntax highlighting for TypeScript & TypeScript React

[Nibaldo González]

nibags created this revision.
nibags added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nibags requested review of this revision.

REVISION SUMMARY
  TypeScript is a superset of JavaScript, therefore, it use JavaScript 
highlighting, adding some features and built-in classes and functions. It is 
based on the official TextMate grammar files: 
https://github.com/Microsoft/TypeScript-TmLanguage
  
  The TypeScript React highlighting adds support for tags, such as XML.
  
  Also, some modifications are made to the JavaScript & JavaScript React:
  
  JavaScript:
  
  - The shebang is corrected, empty lines are no longer allowed before the 
shebang.
  - Add missing keywords.
  - Add rule to highlight "default" in switch conditions.
  - Add operator: "=>".
  - The "FindComments" & "FindStrings" contexts are created, which is used by 
typescript.xml.
  
  JavaScript React:
  
  - Fix shebang.
  - Fix: add Doxygen comments.
  - Other minor changes.
  
  Depends on D17085 
  
  FEATURE: 384716

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  add-typescript

REVISION DETAIL
  https://phabricator.kde.org/D17092

AFFECTED FILES
  autotests/folding/highlight.js.fold
  autotests/folding/test.js.fold
  autotests/folding/test.jsx.fold
  autotests/folding/test.qml.fold
  autotests/folding/test.ts.fold
  autotests/folding/test.tsx.fold
  autotests/html/highlight.js.html
  autotests/html/test.jsx.html
  autotests/html/test.ts.html
  autotests/html/test.tsx.html
  autotests/input/test.jsx
  autotests/input/test.ts
  autotests/input/test.tsx
  autotests/reference/highlight.js.ref
  autotests/reference/test.jsx.ref
  autotests/reference/test.ts.ref
  autotests/reference/test.tsx.ref
  data/syntax/javascript-react.xml
  data/syntax/javascript.xml
  data/syntax/typescript-react.xml
  data/syntax/typescript.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

D17085: Fix language load after including keywords from this language in another file

[Nibaldo González]

nibags added a dependent revision: D17092: Add syntax highlighting for 
TypeScript & TypeScript React.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D17085

To: nibags, #framework_syntax_highlighting, cullmann, dhaumann, vkrause, jpoelen
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

D17071: Don't include any directory sizes in DirectorySizeJob

[David Faure]

dfaure added a comment.


  (sure it's convenient for the unittest, but less meaningful for the users)

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17071

To: davidedmundson, dfaure, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D17071: Don't include any directory sizes in DirectorySizeJob

[David Faure]

dfaure added a comment.


  Hmm hmm. The goal of this was to behave like "du" as much as possible. As you 
say, the real bug isn't that we count directories, but that we count files "as 
is" instead of blocks. But I'm not sure how easily we could get block 
information from here.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17071

To: davidedmundson, dfaure, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns