D17086: Add icons for application-vnd.appimage/x-iso9660-appimage

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Yep, that was it. Looks beautiful. Ship it!

REPOSITORY
  R266 Breeze Icons

BRANCH
  addappimageiconv2

REVISION DETAIL
  https://phabricator.kde.org/D17086

To: kossebau, #vdg, ngraham
Cc: TheAssassin, ngraham, kde-frameworks-devel, michaelh, bruns

D17013: Show menu bar, how to re-enable, common shortcut dialog

[Albert Astals Cid]

aacid added a comment.


  the documentation is mising a @since 5.SOMETHING

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D17013

To: lsartorelli, ngraham, #frameworks, #kde_applications
Cc: aacid, cfeck, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

T10112: KDEInstallDirs on Mac

[René J . V . Bertin]

rjvbb added a comment.


  A more complete draft:
  F6442989: patch-mac-installdirs.diff 

TASK DETAIL
  https://phabricator.kde.org/T10112

To: rjvbb
Cc: yurikoles, kde-mac, #kde_applications, #frameworks, #build_system

D17084: Prolog & Lua: fix shebang

[Dominik Haumann]

dhaumann added a comment.


  Btw, I think in this case the fix is correct.
  
  But sometimes, detecting a Shebang in an extra context introduces regressions 
when the language is used in other xml files via IncludeRules. This seems not 
the case here, though, so all is fine.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D17084

To: nibags, #framework_syntax_highlighting, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

D16878: Resolve symlinks in exclude folders

[Nathaniel Graham]

ngraham added a comment.


  Does this fix https://bugs.kde.org/show_bug.cgi?id=342224?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D16878

To: poboiko, #frameworks, #baloo
Cc: ngraham, bruns, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, 
spoorun, abrahams

D17178: Don't ask for confimation when reloading

[Nicolas Fella]

nicolasfella edited the summary of this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17178

To: nicolasfella, #kate, ngraham
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

D17178: Don't ask for confimation when reloading

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added reviewers: Kate, ngraham.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  When reloading the document it is unnecessary to show the document modified 
dialog that offers to reload 
  since that is what the user expects.

TEST PLAN
  Modify document externally, relaod via F5  -> 
no confirmation dialog

REPOSITORY
  R39 KTextEditor

BRANCH
  noreloadconfirm

REVISION DETAIL
  https://phabricator.kde.org/D17178

AFFECTED FILES
  src/document/katedocument.cpp

To: nicolasfella, #kate, ngraham
Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, 
cullmann, sars, dhaumann

Setting bug report address in KPlugin json data?

[René J . V . Bertin]

Hi,

I cannot seem to find how to set a bug reporting address in a plugin json file. 
Is that possible and if so, how?

I'm a bit annoyed by the default "please use BKO to report bugs" ...

Thanks,
R

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.9 - Build # 73 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.9/73/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Mon, 26 Nov 2018 16:57:05 +
 Build duration:
4 min 0 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kdirwatch_stat_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)84%
(69/82)84%
(69/82)75%
(6332/8449)43%
(10151/23439)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2701/2777)49%
(5802/11905)src.desktoptojson100%
(2/2)100%
(2/2)78%
(88/113)38%
(122/322)src.lib33%
(1/3)33%
(1/3)60%
(352/590)26%
(243/938)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(184/1044)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1043/2803)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(654/770)42%
(975/2315)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)48%
(374/784)45%
(863/1927)src.lib.util100%
(10/10)100%
(10/10)81%
(728/904)52%
(823/1573)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 129 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/129/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 26 Nov 2018 16:57:05 +
 Build duration:
3 min 52 sec and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kdirwatch_stat_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)84%
(69/82)84%
(69/82)75%
(6331/8449)43%
(10151/23443)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2701/2777)49%
(5801/11903)src.desktoptojson100%
(2/2)100%
(2/2)78%
(88/113)38%
(123/326)src.lib33%
(1/3)33%
(1/3)59%
(351/590)26%
(243/942)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(184/1044)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1041/2797)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(654/770)42%
(975/2317)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)48%
(374/784)45%
(864/1927)src.lib.util100%
(10/10)100%
(10/10)81%
(728/904)52%
(824/1575)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

D17079: Provide a qqc2/kirigami-based about page

[Aleix Pol Gonzalez]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R134:673981634266: Provide a qqc2/kirigami-based about page 
(authored by apol).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17079?vs=45968=46277

REVISION DETAIL
  https://phabricator.kde.org/D17079

AFFECTED FILES
  discover/DiscoverObject.cpp
  discover/main.cpp
  discover/qml/AboutPage.qml
  discover/qml/DiscoverDrawer.qml
  discover/qml/DiscoverWindow.qml
  discover/resources.qrc

To: apol, #plasma, #frameworks
Cc: vkrause, mart, leinir, ngraham, ltoscano, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D17078: Make it possible to use KAboutData/License/Person from QML

[Aleix Pol Gonzalez]

apol closed this revision.

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D17078

To: apol, #frameworks, dfaure, aacid
Cc: aacid, mart, mpyne, broulik, anthonyfieroni, kde-frameworks-devel, 
michaelh, ngraham, bruns

D17078: Make it possible to use KAboutData/License/Person from QML

[Aleix Pol Gonzalez]

apol marked 2 inline comments as done.

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17078

To: apol, #frameworks, dfaure, aacid
Cc: aacid, mart, mpyne, broulik, anthonyfieroni, kde-frameworks-devel, 
michaelh, ngraham, bruns

D17078: Make it possible to use KAboutData/License/Person from QML

[Albert Astals Cid]

aacid accepted this revision.
aacid added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> kaboutdata.h:92
> + *
> + * Default arguments @since 5.53
>   */

Change "Default arguments @since 5.53" to "name default argument @since 5.53"

REPOSITORY
  R244 KCoreAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17078

To: apol, #frameworks, dfaure, aacid
Cc: aacid, mart, mpyne, broulik, anthonyfieroni, kde-frameworks-devel, 
michaelh, ngraham, bruns

D17161: Replace Latin1 character remnant with escaped UTF-8 sequence

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:c405714eb8e6: Replace Latin1 character remnant with 
escaped UTF-8 sequence (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17161?vs=46224=46275

REVISION DETAIL
  https://phabricator.kde.org/D17161

AFFECTED FILES
  autotests/unit/engine/queryparsertest.cpp

To: bruns, #baloo, #frameworks, ngraham, poboiko
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17078: Make it possible to use KAboutData/License/Person from QML

[Aleix Pol Gonzalez]

apol updated this revision to Diff 46274.
apol added a comment.


  @since

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17078?vs=46273=46274

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17078

AFFECTED FILES
  src/lib/kaboutdata.cpp
  src/lib/kaboutdata.h

To: apol, #frameworks, dfaure
Cc: aacid, mart, mpyne, broulik, anthonyfieroni, kde-frameworks-devel, 
michaelh, ngraham, bruns

D17078: Make it possible to use KAboutData/License/Person from QML

[Aleix Pol Gonzalez]

apol updated this revision to Diff 46273.
apol added a comment.


  More @since

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17078?vs=46272=46273

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17078

AFFECTED FILES
  src/lib/kaboutdata.cpp
  src/lib/kaboutdata.h

To: apol, #frameworks, dfaure
Cc: aacid, mart, mpyne, broulik, anthonyfieroni, kde-frameworks-devel, 
michaelh, ngraham, bruns

D17078: Make it possible to use KAboutData/License/Person from QML

[Aleix Pol Gonzalez]

apol updated this revision to Diff 46272.
apol added a comment.


  Polishing

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17078?vs=46271=46272

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17078

AFFECTED FILES
  src/lib/kaboutdata.cpp
  src/lib/kaboutdata.h

To: apol, #frameworks, dfaure
Cc: aacid, mart, mpyne, broulik, anthonyfieroni, kde-frameworks-devel, 
michaelh, ngraham, bruns

D17030: DictionaryComboBox: Keep user preferred dictionaries on top

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Makes sense to me, visually speaking!

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D17030

To: loh.tar, #frameworks, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17078: Make it possible to use KAboutData/License/Person from QML

[Aleix Pol Gonzalez]

apol updated this revision to Diff 46271.
apol added a subscriber: aacid.
apol added a comment.


  Add CONSTANT as suggested by @aacid

REPOSITORY
  R244 KCoreAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17078?vs=45984=46271

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17078

AFFECTED FILES
  src/lib/kaboutdata.cpp
  src/lib/kaboutdata.h

To: apol, #frameworks, dfaure
Cc: aacid, mart, mpyne, broulik, anthonyfieroni, kde-frameworks-devel, 
michaelh, ngraham, bruns

D17078: Make it possible to use KAboutData/License/Person from QML

[Aleix Pol Gonzalez]

apol added a comment.


  Can somebody accept it or reject it, please? :P

REPOSITORY
  R244 KCoreAddons

REVISION DETAIL
  https://phabricator.kde.org/D17078

To: apol, #frameworks, dfaure
Cc: mart, mpyne, broulik, anthonyfieroni, kde-frameworks-devel, michaelh, 
ngraham, bruns

D17030: DictionaryComboBox: Keep user preferred dictionaries on top

[loh tar]

loh.tar edited the test plan for this revision.
loh.tar added a reviewer: VDG.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D17030

To: loh.tar, #frameworks, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17013: Show menu bar, how to re-enable, common shortcut dialog

[Luca Sartorelli]

lsartorelli added a comment.


  Usually the message should be always shown, but I think there there are some 
exceptions.
  
  - for Kate the message is supposed to be off till its code base is upgraded 
with the removal of ts own popup.
  - for dolphin the message should be shown only if the menu bar and the tool 
bar are hided at the same time. (in this case a better message could be shown)

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D17013

To: lsartorelli, ngraham, #frameworks, #kde_applications
Cc: aacid, cfeck, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D17017: Fix assert when cleaning up symlinks in PreviewJob

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:7ce34436a038: Fix assert when cleaning up symlinks in 
PreviewJob (authored by davidedmundson).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17017?vs=45809=46264

REVISION DETAIL
  https://phabricator.kde.org/D17017

AFFECTED FILES
  src/widgets/previewjob.cpp

To: davidedmundson, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17013: Show menu bar, how to re-enable, common shortcut dialog

[Nathaniel Graham]

ngraham added a comment.


  Looking better now. Do we really want to only optionally show the warning 
with a bool argument? In general bool arguments to functions are discouraged 
because they're not very readable. And if the whole point of this function is 
to always show a consistent message, don't we want it to always be shown when 
an app uses this function?

INLINE COMMENTS

> aacid wrote in ktoggleshowmenubaraction.cpp:77
> No strong opinion really, anyone else has an idea?

I would recommend telling the user how they can add one. Since a shortcut is 
set by default, only advanced users who change this would trigger that boundary 
condition anyway, and they'd read the warning and understand what's going on.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D17013

To: lsartorelli, ngraham, #frameworks, #kde_applications
Cc: aacid, cfeck, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 269 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/269/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 26 Nov 2018 13:54:59 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)35%
(44/125)35%
(44/125)27%
(3587/13046)19%
(1812/9409)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(607/1113)29%
(313/1084)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/461)0%
(0/231)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2220)7%
(96/1442)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/497)0%
(0/187)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)41%
(1400/3442)30%
(785/2609)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/135)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)44%
(671/1521)30%
(301/990)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/161)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick27%
(3/11)27%
(3/11)29%
(579/1979)18%
(312/1704)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/107)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1096)0%
(0/906)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
 

D17173: Add error value for job owner dying

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> global.h:249
> +ERR_CANNOT_CREATE_SLAVE = KJob::UserDefinedError + 73, ///< used by 
> Slave::createSlave, @since 5.30
> +ERR_OWNER_DIED = KJob::UserDefinedError + 75, ///< Value used between 
> kuiserver and views when the job owner disappears unexpectedly. It should not 
> be emitted by slaves. @since 5.53
>  };

I didn't write 74 because there's that other patch with the FAT32 size limit 
error - and I didn't want to go first and make him rebase.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17173

To: davidedmundson
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D17173: Add error value for job owner dying

[Kai Uwe Broulik]

broulik added a comment.


  +1

INLINE COMMENTS

> global.h:249
> +ERR_CANNOT_CREATE_SLAVE = KJob::UserDefinedError + 73, ///< used by 
> Slave::createSlave, @since 5.30
> +ERR_OWNER_DIED = KJob::UserDefinedError + 75, ///< Value used between 
> kuiserver and views when the job owner disappears unexpectedly. It should not 
> be emitted by slaves. @since 5.53
>  };

Why not 74?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17173

To: davidedmundson
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D17173: Add error value for job owner dying

[David Edmundson]

davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  When kuiserver detects that a job owner has terminated whilst jobs are
  still running we need an error value to send to the client views, such
  as plasmashell, to report this error.

TEST PLAN
  None, it's a line in an enum

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17173

AFFECTED FILES
  src/core/global.h

To: davidedmundson
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17013: Show menu bar, how to re-enable, common shortcut dialog

[Luca Sartorelli]

lsartorelli updated this revision to Diff 46248.
lsartorelli added a comment.


  Hi, you are right, I did not realize a bit of mess in between my revisions.
  
  Now all the requests should have been fulfilled properly.
  
  Thanks for this massive support and please, just let me know if I need to fix 
something else.

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17013?vs=45934=46248

REVISION DETAIL
  https://phabricator.kde.org/D17013

AFFECTED FILES
  src/CMakeLists.txt
  src/ktoggleshowmenubaraction.cpp
  src/ktoggleshowmenubaraction.h

To: lsartorelli, ngraham, #frameworks, #kde_applications
Cc: aacid, cfeck, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions

[René J . V . Bertin]

rjvbb added a comment.


  bump?

REPOSITORY
  R32 KDevelop

REVISION DETAIL
  https://phabricator.kde.org/D16882

To: rjvbb, #kdevelop, kossebau
Cc: egospodinova, kossebau, kde-frameworks-devel, kdevelop-devel, glebaccon, 
antismap, iodelay, vbspam, geetamc, Pilzschaf, akshaydeo, surgenight, arrowd

D16919: Re-add DBus test

[Ben Cooksley]

bcooksley added a comment.


  The best we have documentation wise is 
https://phabricator.kde.org/w/continuous-integration/ however these are quite 
out of date (and incomplete).

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D16919

To: davidedmundson, #konsole, #frameworks, hindenburg
Cc: bcooksley, hindenburg, konsole-devel, ngraham, maximilianocuria

D17017: Fix assert when cleaning up symlinks in PreviewJob

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17017

To: davidedmundson, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns