D17295: BrightScript: Add function/sub folding

[Daniel Levin]

dlevin updated this revision to Diff 46667.
dlevin added a comment.


  Increased version number.

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17295?vs=4=46667

REVISION DETAIL
  https://phabricator.kde.org/D17295

AFFECTED FILES
  autotests/folding/brightscript.brs.fold
  data/syntax/brightscript.xml

To: dlevin, cullmann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17295: BrightScript: Add function/sub folding

[Daniel Levin]

dlevin created this revision.
dlevin added a reviewer: cullmann.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
dlevin requested review of this revision.

REVISION SUMMARY
  Global and local function folding, including closures.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D17295

AFFECTED FILES
  autotests/folding/brightscript.brs.fold
  data/syntax/brightscript.xml

To: dlevin, cullmann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » attica » kf5-qt5 WindowsMSVCQt5.11 - Build # 18 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/attica/job/kf5-qt5%20WindowsMSVCQt5.11/18/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sat, 01 Dec 2018 22:53:36 +
 Build duration:
6 hr 6 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.providertest

D17282: Use escaped UTF-8 sequence instead of Latin1 characters, minor cleanups

[Nathaniel Graham]

ngraham added a comment.


  Weird, why does Phabricator think `termgeneratortest.cpp` is a binary file?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17282

To: bruns, #baloo, #frameworks, ngraham, astippich
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17220: Improve symbolism for off and muted status icon

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:b8d080c4e6a1: Improve symbolism for off and muted status 
icon (authored by trickyricky26, committed by ngraham).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17220?vs=46587=46661

REVISION DETAIL
  https://phabricator.kde.org/D17220

AFFECTED FILES
  icons-dark/status/16/audio-off.svg
  icons-dark/status/16/audio-volume-low.svg
  icons-dark/status/16/audio-volume-medium.svg
  icons-dark/status/16/audio-volume-muted.svg
  icons-dark/status/16/camera-off.svg
  icons-dark/status/16/mic-off.svg
  icons-dark/status/16/microphone-sensitivity-low.svg
  icons-dark/status/16/microphone-sensitivity-medium.svg
  icons-dark/status/16/microphone-sensitivity-muted.svg
  icons-dark/status/22/audio-off.svg
  icons-dark/status/22/audio-on.svg
  icons-dark/status/22/audio-ready.svg
  icons-dark/status/22/audio-volume-low.svg
  icons-dark/status/22/audio-volume-medium.svg
  icons-dark/status/22/audio-volume-muted.svg
  icons-dark/status/22/camera-off.svg
  icons-dark/status/22/input-touchpad-off.svg
  icons-dark/status/22/mic-off.svg
  icons-dark/status/22/microphone-sensitivity-low.svg
  icons-dark/status/22/microphone-sensitivity-medium.svg
  icons-dark/status/22/microphone-sensitivity-muted.svg
  icons/status/16/audio-off.svg
  icons/status/16/audio-volume-low.svg
  icons/status/16/audio-volume-medium.svg
  icons/status/16/audio-volume-muted.svg
  icons/status/16/camera-off.svg
  icons/status/16/mic-off.svg
  icons/status/16/microphone-sensitivity-low.svg
  icons/status/16/microphone-sensitivity-medium.svg
  icons/status/16/microphone-sensitivity-muted.svg
  icons/status/22/audio-off.svg
  icons/status/22/audio-on.svg
  icons/status/22/audio-ready.svg
  icons/status/22/audio-volume-low.svg
  icons/status/22/audio-volume-medium.svg
  icons/status/22/audio-volume-muted.svg
  icons/status/22/camera-off.svg
  icons/status/22/input-touchpad-off.svg
  icons/status/22/mic-off.svg
  icons/status/22/microphone-sensitivity-low.svg
  icons/status/22/microphone-sensitivity-medium.svg
  icons/status/22/microphone-sensitivity-muted.svg

To: trickyricky26, #vdg, ndavis, ngraham
Cc: abetts, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17220: Improve symbolism for off and muted status icon

[Nathaniel Graham]

ngraham added a comment.


  I notice that there are bunch of action icons that now differ subtly from 
these. We can probably make them symlinks to the nice new status icons. But 
that's material for another patch. :) There's plenty of time anyway since this 
is going into Frameworks 5.54.

REPOSITORY
  R266 Breeze Icons

BRANCH
  streamline-muted-off (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17220

To: trickyricky26, #vdg, ndavis, ngraham
Cc: abetts, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17220: Improve symbolism for off and muted status icon

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  This looks great to me too! I'll land this manually since `arc` doesn't like 
patches that change symlinks to files.

REPOSITORY
  R266 Breeze Icons

BRANCH
  streamline-muted-off (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17220

To: trickyricky26, #vdg, ndavis, ngraham
Cc: abetts, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.9 - Build # 90 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.9/90/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 01 Dec 2018 22:59:31 +
 Build duration:
1 hr 15 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 46 test(s), Skipped: 0 test(s), Total: 46 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)92%
(235/255)92%
(235/255)85%
(26339/30851)53%
(10548/19744)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(42/42)100%
(42/42)99%
(12082/12157)50%
(6361/12625)autotests.server100%
(5/5)100%
(5/5)99%
(355/358)49%
(169/344)src.client99%
(71/72)99%
(71/72)85%
(6177/7259)65%
(1786/2756)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server100%
(115/115)100%
(115/115)87%
(7644/8804)66%
(2232/3390)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1287)0%
(0/313)

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.9 - Build # 46 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.9/46/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 01 Dec 2018 22:59:44 +
 Build duration:
1 hr 9 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.kwindowsystem-kwindowinfox11testFailed: TestSuite.kwindowsystem-netrootinfotestwm
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7115/9546)54%
(3482/6395)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)96%
(3009/3136)52%
(1265/2456)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)57%
(788/1391)45%
(304/670)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)71%
(3311/4662)59%
(1910/3217)tests0%
(0/5)0%
(0/5)0%
(0/277)0%
(0/46)

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.9 - Build # 72 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.9/72/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 01 Dec 2018 22:58:21 +
 Build duration:
1 hr 2 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)95%
(20/21)95%
(20/21)72%
(1565/2166)51%
(1076/2124)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)99%
(531/533)51%
(242/470)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(557/753)64%
(598/935)src.kpackage.private100%
(7/7)100%
(7/7)79%
(302/380)49%
(104/211)src.kpackagetool100%
(3/3)100%
(3/3)33%
(161/482)25%
(125/496)

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.9 - Build # 53 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.9/53/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 01 Dec 2018 22:55:38 +
 Build duration:
1 hr 3 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.ktabwidget_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report29%
(4/14)43%
(124/291)43%
(124/291)47%
(21750/45965)38%
(13183/34249)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault0%
(0/1)0%
(0/1)0%
(0/87)0%
(0/56)autotests98%
(44/45)98%
(44/45)98%
(11469/11759)50%
(7254/14375)src0%
(0/1)0%
(0/1)0%
(0/4)0%
(0/2)src.kdebugdialog0%
(0/7)0%
(0/7)0%
(0/256)0%
(0/73)src.kdecore76%
(65/86)76%
(65/86)53%
(9506/17866)49%
(5598/11459)src.kdeui19%
(13/68)19%
(13/68)8%
(765/9698)6%
(330/5364)src.kio7%
(2/27)7%
(2/27)0%
(10/2258)0%
(1/1238)src.kioslave.metainfo0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/4)src.kparts0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/12)src.kssl0%
(0/8)0%
(0/8)0%
(0/1807)0%
(0/853)src.kssl.kcm0%
(0/3)0%
(0/3)0%
(0/264)0%
(0/145)src.solid0%
(0/3)0%
(0/3)0%
(0/188)0%
(0/87)src.solid-networkstatus.kded0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/94)tests0%
(0/34)0%
(0/34)0%
(0/1537)0%
(0/487)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.9 - Build # 77 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.9/77/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 01 Dec 2018 22:55:08 +
 Build duration:
54 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kdirwatch_stat_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(70/82)85%
(70/82)75%
(6347/8463)43%
(10115/23354)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2697/2772)49%
(5766/11827)src.desktoptojson100%
(2/2)100%
(2/2)77%
(86/111)38%
(121/321)src.lib67%
(2/3)67%
(2/3)60%
(353/591)26%
(243/938)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(184/1044)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1043/2803)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(660/776)42%
(972/2301)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)48%
(377/787)45%
(863/1927)src.lib.util100%
(10/10)100%
(10/10)81%
(739/915)52%
(827/1581)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 505 - Successful!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/505/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 01 Dec 2018 22:55:36 +
 Build duration:
45 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 61 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report64%
(23/36)66%
(262/398)66%
(262/398)53%
(32085/60087)38%
(16568/44072)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(57/57)100%
(57/57)95%
(9100/9538)48%
(4283/8965)autotests.http100%
(5/5)100%
(5/5)99%
(581/582)68%
(113/166)autotests.kcookiejar100%
(1/1)100%
(1/1)91%
(179/197)72%
(49/68)src100%
(1/1)100%
(1/1)86%
(6/7)67%
(4/6)src.core86%
(100/116)86%
(100/116)58%
(8330/14309)50%
(4658/9245)src.core.kssl100%
(1/1)100%
(1/1)40%
(35/88)50%
(3/6)src.filewidgets76%
(28/37)76%
(28/37)49%
(3910/7971)34%
(1605/4743)src.gui100%
(2/2)100%
(2/2)94%
(102/108)74%
(49/66)src.ioslaves.file100%
(5/5)100%
(5/5)51%
(532/1036)37%
(319/868)src.ioslaves.file.kauth0%
(0/2)0%
(0/2)0%
(0/106)0%
(0/65)src.ioslaves.ftp0%
(0/1)0%
(0/1)0%
(0/1344)0%
(0/1416)src.ioslaves.help0%
(0/5)0%
(0/5)0%
(0/248)0%
(0/148)src.ioslaves.http88%
(7/8)88%
(7/8)41%
(1765/4288)35%
(1306/3692)src.ioslaves.http.kcookiejar33%
(2/6)33%
(2/6)47%
(630/1330)55%
(626/1135)src.ioslaves.remote100%
(2/2)100%
(2/2)27%
(73/267)8%
(14/184)src.ioslaves.remote.kdedmodule0%
(0/2)0%
(0/2)0%
(0/12)100%
(0/0)src.ioslaves.telnet0%
(0/1)0%
(0/1)0%
(0/43)0%
(0/32)src.ioslaves.trash56%
(5/9)56%
(5/9)52%
(703/1356)43%

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 276 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/276/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 01 Dec 2018 23:00:20 +
 Build duration:
38 min and counting
   BUILD ARTIFACTS
  compat_reports/KF5Plasma_compat_report.html
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3606/13324)18%
(1816/9848)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(610/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2248)7%
(96/1456)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1410/3491)28%
(787/2817)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(674/1574)29%
(300/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(582/2018)18%
(313/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
  

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 116 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/116/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 01 Dec 2018 22:59:31 +
 Build duration:
32 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 45 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: TestSuite.kwayland-testWindowmanagement
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)92%
(235/255)92%
(235/255)85%
(26329/30851)53%
(10542/19744)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(42/42)100%
(42/42)99%
(12070/12157)50%
(6353/12625)autotests.server100%
(5/5)100%
(5/5)99%
(355/358)49%
(169/344)src.client99%
(71/72)99%
(71/72)85%
(6179/7259)65%
(1788/2756)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server100%
(115/115)100%
(115/115)87%
(7644/8804)66%
(2232/3390)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1287)0%
(0/313)

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.10 - Build # 58 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.10/58/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 01 Dec 2018 22:59:44 +
 Build duration:
30 min and counting
   BUILD ARTIFACTS
  compat_reports/KF5WindowSystem_compat_report.html
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.kwindowsystem-kwindowinfox11testFailed: TestSuite.kwindowsystem-netrootinfotestwm
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)74%
(7110/9546)54%
(3481/6395)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)96%
(3001/3136)51%
(1259/2456)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)57%
(787/1391)45%
(302/670)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)71%
(3315/4662)60%
(1917/3217)tests0%
(0/5)0%
(0/5)0%
(0/277)0%
(0/46)

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 94 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/94/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 01 Dec 2018 22:58:21 +
 Build duration:
23 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)95%
(20/21)95%
(20/21)72%
(1565/2166)51%
(1076/2124)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)99%
(531/533)51%
(242/470)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(557/753)64%
(598/935)src.kpackage.private100%
(7/7)100%
(7/7)79%
(302/380)49%
(104/211)src.kpackagetool100%
(3/3)100%
(3/3)33%
(161/482)25%
(125/496)

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.10 - Build # 36 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.10/36/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 01 Dec 2018 22:57:05 +
 Build duration:
22 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.kimageformats-read-tgaFailed: TestSuite.kimageformats-write-tga
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(3/3)76%
(13/17)76%
(13/17)41%
(1493/3602)33%
(663/2021)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(3/3)100%
(3/3)70%
(263/375)50%
(72/144)src.imageformats82%
(9/11)82%
(9/11)40%
(1226/3095)32%
(589/1819)tests33%
(1/3)33%
(1/3)3%
(4/132)3%
(2/58)

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.10 - Build # 78 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.10/78/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 01 Dec 2018 22:55:38 +
 Build duration:
18 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.ktabwidget_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report29%
(4/14)43%
(124/291)43%
(124/291)47%
(21615/45963)38%
(13050/34249)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault0%
(0/1)0%
(0/1)0%
(0/87)0%
(0/56)autotests98%
(44/45)98%
(44/45)97%
(11364/11759)50%
(7174/14375)src0%
(0/1)0%
(0/1)0%
(0/4)0%
(0/2)src.kdebugdialog0%
(0/7)0%
(0/7)0%
(0/256)0%
(0/73)src.kdecore76%
(65/86)76%
(65/86)53%
(9476/17864)48%
(5545/11459)src.kdeui19%
(13/68)19%
(13/68)8%
(765/9698)6%
(330/5364)src.kio7%
(2/27)7%
(2/27)0%
(10/2258)0%
(1/1238)src.kioslave.metainfo0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/4)src.kparts0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/12)src.kssl0%
(0/8)0%
(0/8)0%
(0/1807)0%
(0/853)src.kssl.kcm0%
(0/3)0%
(0/3)0%
(0/264)0%
(0/145)src.solid0%
(0/3)0%
(0/3)0%
(0/188)0%
(0/87)src.solid-networkstatus.kded0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/94)tests0%
(0/34)0%
(0/34)0%
(0/1537)0%
(0/487)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 132 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/132/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 01 Dec 2018 22:55:08 +
 Build duration:
15 min and counting
   BUILD ARTIFACTS
  compat_reports/KF5CoreAddons_compat_report.html
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kdirwatch_stat_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(70/82)85%
(70/82)75%
(6346/8463)43%
(10115/23358)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2697/2772)49%
(5765/11825)src.desktoptojson100%
(2/2)100%
(2/2)77%
(86/111)38%
(122/325)src.lib67%
(2/3)67%
(2/3)60%
(352/591)26%
(243/942)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(184/1044)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1041/2797)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(660/776)42%
(972/2303)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)48%
(377/787)45%
(864/1927)src.lib.util100%
(10/10)100%
(10/10)81%
(739/915)52%
(828/1583)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

D16949: Support for TLS 1.3 (part of Qt 5.12)

[Albert Astals Cid]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:d48a506d83e1: Support for TLS 1.3 (part of Qt 5.12) 
(authored by aacid).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16949?vs=45637=46658

REVISION DETAIL
  https://phabricator.kde.org/D16949

AFFECTED FILES
  src/core/ktcpsocket.cpp
  src/core/ktcpsocket.h

To: aacid, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

Re: Increasing KF5 cmake requirement to 3.5?

[Albert Astals Cid]

El dissabte, 17 de novembre de 2018, a les 22:36:03 CET, Albert Astals Cid va 
escriure:
> El dissabte, 17 de novembre de 2018, a les 20:03:37 CET, Wolfgang Bauer va 
> escriure:
> > > -Original Message-
> > > I'm going to suggest it to increase it to 3.6, it would still most
> > probably be a lie
> > > since i don't think any of use uses such an old (2 years version) either
> > 
> > We currently do still build the latest KDE Frameworks, Plasma, and
> > Applications on/for openSUSE Leap 42.3 (plus latest Qt5) with cmake 3.5.2.
> 
> Ok, good, then maybe actually increase it to 3.5 only and it won't be a lie 
> because the openSUSE people are using it :)

Since noone complained I increased the required cmake version to 3.5 to all 
modules except e-c-m because it already had a different required version than 
the others so it seems a bit special in that regard?

@dfaure I pushed a new script to the release-tools repo that does the 
replacement.

Cheers,
  Albert

> 
> Cheers,
>   albert
> 
> >  
> > Only problem so far: discover started to use a new feature of cmake 3.6 in
> > the latest (bugfix) version, namely the IMPORTED_TARGET option to
> > pkg_checkmodule(), so the flatpak and fwupd backends are not built anymore
> > with cmake 3.5.2. (cmake says "No package 'IMPORTED_TARGET' found")
> > https://cgit.kde.org/discover.git/commit/?h=Plasma/5.14=d9ccf1d41fc3265ae
> > e9e01eebbc090b163fefe07
> > https://cgit.kde.org/discover.git/commit/?h=Plasma/5.14=2fe3d58fc652fc995
> > 7f063cbbd0722dc1cf45730
> > (we couldn't build the fwupd backend anyway though because fwupd is too old)
> > 
> > Kind Regards,
> > Wolfgang
> > 
> > 
> > 
> 
> 
> 
> 
> 

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 504 - Aborted!

[CI System]

BUILD ABORTED
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/504/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Thu, 29 Nov 2018 16:41:48 +
 Build duration:
2 days 6 hr and counting

D6877: Add Conan files

[gregormi]

Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D6877

To: gladhorn, dfaure
Cc: kde-frameworks-devel, gregormi, dfaure, apol, cfeck, michaelh, ngraham, 
bruns, #frameworks

D17220: Improve symbolism for off and muted status icon

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  I've checked it out and it looks good!

REPOSITORY
  R266 Breeze Icons

BRANCH
  streamline-muted-off (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17220

To: trickyricky26, #vdg, ndavis
Cc: abetts, ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D15999: Add icons with added background to system.svgz

[Noah Davis]

ndavis accepted this revision as: ndavis.
ndavis added a comment.


  Looks like you've addressed all of my concerns, so I'll accept this. @ngraham 
?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15999

To: pstefan, ngraham, #vdg, ndavis
Cc: ndavis, broulik, filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D16954: Add find module for Google's libphonenumber

[Christophe Giboudeaux]

cgiboudeaux added inline comments.

INLINE COMMENTS

> cgiboudeaux wrote in FindPhoneNumber.cmake:85
> phonenumber doesn't install a pkg-config file, this variable is empty

Note: this is harmless, but maybe just add

  set(PhoneNumber_VERSION 0)

to make it clear. AFAICS, none of the public headers contain the library version

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D16954

To: vkrause, #build_system, #frameworks
Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D16954: Add find module for Google's libphonenumber

[Christophe Giboudeaux]

cgiboudeaux added inline comments.

INLINE COMMENTS

> FindPhoneNumber.cmake:27
> +# will be defined.
> +
> +#=

Since 5.53

> FindPhoneNumber.cmake:85
> +VERSION_VAR
> +PhoneNumber_VERSION
> +HANDLE_COMPONENTS

phonenumber doesn't install a pkg-config file, this variable is empty

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D16954

To: vkrause, #build_system, #frameworks
Cc: cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15999: Add icons with added background to system.svgz

[Phil Stefan]

pstefan updated this revision to Diff 46655.
pstefan added a comment.


  - Fix transparency of home icon in go.svgz

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15999?vs=46626=46655

BRANCH
  arcpatch-D15999

REVISION DETAIL
  https://phabricator.kde.org/D15999

AFFECTED FILES
  src/desktoptheme/breeze/icons/go.svgz
  src/desktoptheme/breeze/icons/system.svgz

To: pstefan, ngraham, #vdg, ndavis
Cc: ndavis, broulik, filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

[gregormi]

gregormi retitled this revision from "File menu: Put Save, Print and Export in 
submenus" to "KTextEditor: File menu: Put Save, Print and Export in submenus".

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17137

To: gregormi, #kate, #kdevelop
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D15999: Add icons with added background to system.svgz

[Noah Davis]

ndavis added a comment.


  Is the home button in `go.svgz` meant to be partially transparent?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15999

To: pstefan, ngraham, #vdg, ndavis
Cc: ndavis, broulik, filipf, kde-frameworks-devel, michaelh, ngraham, bruns

D17256: [KUrlNavigator] Fix firstChildUrl when going back from archive

[Thomas Surrel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:84ff71997b30: [KUrlNavigator] Fix firstChildUrl when 
going back from archive (authored by thsurrel).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17256?vs=46552=46647

REVISION DETAIL
  https://phabricator.kde.org/D17256

AFFECTED FILES
  src/filewidgets/kurlnavigator.cpp

To: thsurrel, #frameworks, elvisangelaccio
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17285: Add plugin type for sharing URLs

[Nicolas Fella]

nicolasfella added a dependent revision: D17287: Enable sharing URLs via email.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D17285

To: nicolasfella, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17287: Enable sharing URLs via email

[Nicolas Fella]

nicolasfella edited the summary of this revision.
nicolasfella added a dependency: D17285: Add plugin type for sharing URLs.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D17287

To: nicolasfella, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17287: Enable sharing URLs via email

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: apol.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Share URLs via email. Add title to input data

TEST PLAN
  Send page via Email from Falkon

REPOSITORY
  R495 Purpose Library

BRANCH
  emailUrl

REVISION DETAIL
  https://phabricator.kde.org/D17287

AFFECTED FILES
  src/plugins/ShareUrlPluginType.json
  src/plugins/email/emailplugin.cpp
  src/plugins/email/emailplugin.json

To: nicolasfella, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17281: Add icon to KBuildSycocaProgressDialog cancel button

[Björn Feber]

GB_2 marked an inline comment as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17281

To: GB_2, ngraham, #frameworks, cfeck
Cc: elvisangelaccio, ngraham, kde-frameworks-devel, alexde, IohannesPetros, 
trickyricky26, michaelh, crozbo, ndavis, firef, bruns, skadinna, 
aaronhoneycutt, mbohlender

D17281: Add icon to KBuildSycocaProgressDialog cancel button

[Björn Feber]

GB_2 updated this revision to Diff 46637.
GB_2 edited the test plan for this revision.
GB_2 added a comment.


  Improved code.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17281?vs=46615=46637

REVISION DETAIL
  https://phabricator.kde.org/D17281

AFFECTED FILES
  src/widgets/kbuildsycocaprogressdialog.cpp

To: GB_2, ngraham, #frameworks, cfeck
Cc: elvisangelaccio, ngraham, kde-frameworks-devel, alexde, IohannesPetros, 
trickyricky26, michaelh, crozbo, ndavis, firef, bruns, skadinna, 
aaronhoneycutt, mbohlender

D16949: Support for TLS 1.3 (part of Qt 5.12)

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16949

To: aacid, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17285: Add plugin type for sharing URLs

[Nicolas Fella]

nicolasfella added a dependent revision: D17286: Enable page sharing.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D17285

To: nicolasfella, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17285: Add plugin type for sharing URLs

[Nicolas Fella]

nicolasfella edited the test plan for this revision.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D17285

To: nicolasfella, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17285: Add plugin type for sharing URLs

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: apol.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Add a plugin type for sharing URLs and adapt KDE Connect plugin to support it.
  Other possible plugins would be email, twitter, various messengers etc.

TEST PLAN
  Share page from Falkon

REPOSITORY
  R495 Purpose Library

BRANCH
  shareUrl

REVISION DETAIL
  https://phabricator.kde.org/D17285

AFFECTED FILES
  src/plugins/ShareUrlPluginType.json
  src/plugins/kdeconnect/kdeconnectplugin.json
  src/standard-plugin-types.qrc

To: nicolasfella, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16826: Treat uints and doubles the same as integers

[Stefan Brüns]

bruns added a comment.


  Yes, UInt should be fine (actually, all our current integral numeric 
properties **are** unsigned).

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D16826

To: astippich, bruns, #baloo
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams

D17241: Disable highlighting for lines longer than 1024 characters.

[Kåre Särs]

sars updated this revision to Diff 46633.
sars retitled this revision from "WIP: Disable highlighting for lines longer 
than 1024 characters." to "Disable highlighting for lines longer than 1024 
characters.".
sars edited the summary of this revision.
sars added a reviewer: dhaumann.
sars added a comment.


  (Remove the unrelated change in src/view/kateview.cpp)
  
  This version now disables the highlighting for lines longer than 1024 
characters also when the line is selected. The selection highlight is shown tho.
  
  What is the way forward? Do we apply this? Should we modify the line length 
limit?
  
  I have now tested with a file with 97000 columns and I can start to see some 
slowdown but it is still usable.
  
  I think we could raise the limit to 5, but also add a notification if the 
file contains lines longer than 1024.

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17241?vs=46632=46633

REVISION DETAIL
  https://phabricator.kde.org/D17241

AFFECTED FILES
  src/render/katerenderer.cpp

To: sars, cullmann, vkrause, dhaumann
Cc: brauch, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D16826: Treat uints and doubles the same as integers

[Alexander Stippich]

astippich added a comment.


  Okay, so there is more work to do for floats. What about then reducing this 
patch to uints for now, and doubles are added when everything else is in place?
  I have something in the pipeline for the Result class, which I added for 
figuring out how string lists are handled, I can probably post that tomorrow. I 
could then extend the test for floats

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D16826

To: astippich, bruns, #baloo
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams

D16826: Treat uints and doubles the same as integers

[Stefan Brüns]

bruns added a comment.


  I think support for non-integers is useful in general, but there are a few 
things we should consider:
  
  Currently, only integral numbers can be searched. For floats, we definitely 
want Less/Greater matches to work, exact matches for floats are not very useful.
  
  As you are referring to the TermGenerator, I suppose the (float) variant gets 
converted to something like "-5.73",  which is mangled by the TermGenerator to 
something like "X42-5.73", i.e. dropping the sign? (See D17284 
)
  
  Ideally, this were backed by some unit tests. The comparision test can be 
added to the postingdbtest, but AFAICS there are currently no tests covering 
`Baloo::Result`

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D16826

To: astippich, bruns, #baloo
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams

D17241: WIP: Disable highlighting for lines longer than 1024 characters.

[Kåre Särs]

sars updated this revision to Diff 46632.
sars added a comment.


  Also disable highlighting in selections for lines that are longe than 1024

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17241?vs=46499=46632

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17241

AFFECTED FILES
  src/render/katerenderer.cpp
  src/view/kateview.cpp

To: sars, cullmann, vkrause
Cc: brauch, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17284: RFC: Add unit test for splitting of numbers in TermGenerator

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, astippich.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Numbers are not handled as numbers, but literal strings. This is useful
  for e.g. serial numbers ("1234-5678-90"), but less so for "real" numbers.
  
  Integral numeric Properties are not fed through the term generator, so
  these are handled correctly.
  
  TODO: Determine expected behaviour for searching, i.e. is it ok do return
  a document containing "12" when searching for "-12" and vice versa.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17284

AFFECTED FILES
  autotests/unit/engine/termgeneratortest.cpp

To: bruns, #baloo, #frameworks, ngraham, astippich
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17282: Use escaped UTF-8 sequence instead of Latin1 characters, minor cleanups

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, ngraham, astippich.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

TEST PLAN
  ctest
  no functional changes

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17282

AFFECTED FILES
  autotests/unit/engine/termgeneratortest.cpp

To: bruns, #baloo, #frameworks, ngraham, astippich
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.9 - Build # 89 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.9/89/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 01 Dec 2018 16:01:03 +
 Build duration:
42 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 45 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: TestSuite.kwayland-testRemoteAccess
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)92%
(235/255)92%
(235/255)85%
(26324/30853)53%
(10531/19744)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(42/42)100%
(42/42)99%
(12055/12157)50%
(6337/12625)autotests.server100%
(5/5)100%
(5/5)99%
(355/358)49%
(169/344)src.client99%
(71/72)99%
(71/72)85%
(6188/7261)65%
(1792/2756)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server100%
(115/115)100%
(115/115)87%
(7645/8804)66%
(2233/3390)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1287)0%
(0/313)

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.9 - Build # 45 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.9/45/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 01 Dec 2018 16:03:27 +
 Build duration:
37 min and counting
   BUILD ARTIFACTS
  compat_reports/KF5WindowSystem_compat_report.html
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.kwindowsystem-kwindowinfox11testFailed: TestSuite.kwindowsystem-netrootinfotestwm
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)74%
(7111/9546)54%
(3482/6395)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)96%
(3003/3136)51%
(1261/2456)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)57%
(787/1391)45%
(302/670)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)71%
(3314/4662)60%
(1916/3217)tests0%
(0/5)0%
(0/5)0%
(0/277)0%
(0/46)

D17199: Add unittest to check if commiting the same change twice works

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:f0c68be03694: Add unittest to check if commiting the same 
change twice works (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17199?vs=46349=46627

REVISION DETAIL
  https://phabricator.kde.org/D17199

AFFECTED FILES
  autotests/integration/writetransactiontest.cpp

To: bruns, #baloo, #frameworks, ngraham, poboiko
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.9 - Build # 71 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.9/71/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 01 Dec 2018 15:53:44 +
 Build duration:
33 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)95%
(20/21)95%
(20/21)72%
(1565/2166)51%
(1076/2124)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)99%
(531/533)51%
(242/470)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(557/753)64%
(598/935)src.kpackage.private100%
(7/7)100%
(7/7)79%
(302/380)49%
(104/211)src.kpackagetool100%
(3/3)100%
(3/3)33%
(161/482)25%
(125/496)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.9 - Build # 76 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.9/76/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 01 Dec 2018 15:50:06 +
 Build duration:
37 min and counting
   BUILD ARTIFACTS
  compat_reports/KF5CoreAddons_compat_report.html
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kdirwatch_stat_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(70/82)85%
(70/82)75%
(6346/8463)43%
(10112/23354)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2696/2772)49%
(5763/11827)src.desktoptojson100%
(2/2)100%
(2/2)77%
(86/111)38%
(121/321)src.lib67%
(2/3)67%
(2/3)60%
(353/591)26%
(243/938)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(184/1044)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1043/2803)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(660/776)42%
(972/2301)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)48%
(377/787)45%
(863/1927)src.lib.util100%
(10/10)100%
(10/10)81%
(739/915)52%
(827/1581)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

KDE CI: Frameworks » kiconthemes » kf5-qt5 WindowsMSVCQt5.11 - Build # 26 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kiconthemes/job/kf5-qt5%20WindowsMSVCQt5.11/26/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sat, 01 Dec 2018 14:40:28 +
 Build duration:
1 hr 44 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 test(s)Failed: TestSuite.kiconloader_rcctest

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.9 - Build # 52 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.9/52/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 01 Dec 2018 15:45:54 +
 Build duration:
35 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.ktabwidget_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report29%
(4/14)43%
(124/291)43%
(124/291)47%
(21750/45965)38%
(13184/34249)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault0%
(0/1)0%
(0/1)0%
(0/87)0%
(0/56)autotests98%
(44/45)98%
(44/45)98%
(11469/11759)50%
(7254/14375)src0%
(0/1)0%
(0/1)0%
(0/4)0%
(0/2)src.kdebugdialog0%
(0/7)0%
(0/7)0%
(0/256)0%
(0/73)src.kdecore76%
(65/86)76%
(65/86)53%
(9506/17866)49%
(5599/11459)src.kdeui19%
(13/68)19%
(13/68)8%
(765/9698)6%
(330/5364)src.kio7%
(2/27)7%
(2/27)0%
(10/2258)0%
(1/1238)src.kioslave.metainfo0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/4)src.kparts0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/12)src.kssl0%
(0/8)0%
(0/8)0%
(0/1807)0%
(0/853)src.kssl.kcm0%
(0/3)0%
(0/3)0%
(0/264)0%
(0/145)src.solid0%
(0/3)0%
(0/3)0%
(0/188)0%
(0/87)src.solid-networkstatus.kded0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/94)tests0%
(0/34)0%
(0/34)0%
(0/1537)0%
(0/487)

D15999: Add icons with added background to system.svgz

[Phil Stefan]

pstefan updated this revision to Diff 46626.
pstefan added a comment.


  - Fix stylesheet in go.svgz

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15999?vs=46583=46626

BRANCH
  arcpatch-D15999

REVISION DETAIL
  https://phabricator.kde.org/D15999

AFFECTED FILES
  src/desktoptheme/breeze/icons/go.svgz
  src/desktoptheme/breeze/icons/system.svgz

To: pstefan, ngraham, #vdg, ndavis
Cc: ndavis, broulik, filipf, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.9 - Build # 109 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.9/109/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 01 Dec 2018 14:43:09 +
 Build duration:
1 hr 21 min and counting
   BUILD ARTIFACTS
  compat_reports/KF5Purpose_compat_report.html
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 3 test(s)Failed: TestSuite.alternativesmodeltestFailed: TestSuite.menutest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report22%
(5/23)26%
(14/53)26%
(14/53)21%
(458/2203)19%
(208/1118)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(2/2)100%
(2/2)87%
(135/155)46%
(49/106)src100%
(8/8)100%
(8/8)74%
(243/327)59%
(124/210)src.externalprocess0%
(0/2)0%
(0/2)0%
(0/137)0%
(0/98)src.fileitemactionplugin0%
(0/1)0%
(0/1)0%
(0/17)0%
(0/12)src.plugins.bluetooth0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/14)src.plugins.email0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/20)src.plugins.imgur0%
(0/2)0%
(0/2)0%
(0/184)0%
(0/69)src.plugins.kdeconnect0%
(0/1)0%
(0/1)0%
(0/31)0%
(0/12)src.plugins.ktp-sendfile0%
(0/1)0%
(0/1)0%
(0/28)0%
(0/12)src.plugins.nextcloud0%
(0/3)0%
(0/3)0%
(0/79)0%
(0/34)src.plugins.pastebin0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/29)src.plugins.phabricator0%
(0/3)0%
(0/3)0%
(0/220)0%
(0/82)src.plugins.phabricator.quick0%
(0/5)0%
(0/5)0%
(0/93)0%
(0/48)src.plugins.phabricator.tests0%
(0/1)0%
(0/1)0%
(0/59)0%
(0/28)src.plugins.reviewboard0%
(0/3)0%
(0/3)0%
(0/229)0%
(0/76)src.plugins.reviewboard.quick0%
(0/7)0%
(0/7)0%
(0/152)0%
(0/92)src.plugins.saveas100%
(1/1)100%
(1/1)57%
(29/51)68%
(30/44)src.plugins.telegram0%
(0/1)0%
   

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.9 - Build # 44 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.9/44/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 01 Dec 2018 14:42:37 +
 Build duration:
1 hr 20 min and counting
   BUILD ARTIFACTS
  compat_reports/KF5WindowSystem_compat_report.html
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.kwindowsystem-kwindowinfox11testFailed: TestSuite.kwindowsystem-netrootinfotestwm
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)74%
(7107/9546)54%
(3475/6395)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)96%
(3003/3136)51%
(1261/2456)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)57%
(787/1391)45%
(302/670)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)71%
(3310/4662)59%
(1909/3217)tests0%
(0/5)0%
(0/5)0%
(0/277)0%
(0/46)

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.9 - Build # 88 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.9/88/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 01 Dec 2018 14:42:26 +
 Build duration:
1 hr 18 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 46 test(s), Skipped: 0 test(s), Total: 46 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)92%
(235/255)92%
(235/255)85%
(26346/30852)53%
(10549/19744)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(42/42)100%
(42/42)99%
(12086/12158)50%
(6361/12625)autotests.server100%
(5/5)100%
(5/5)99%
(355/358)49%
(169/344)src.client99%
(71/72)99%
(71/72)85%
(6180/7259)65%
(1787/2756)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server100%
(115/115)100%
(115/115)87%
(7644/8804)66%
(2232/3390)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1287)0%
(0/313)

D16826: Treat uints and doubles the same as integers

[Nathaniel Graham]

ngraham added a reviewer: Baloo.
ngraham added a comment.


  Makes sense to me, but let's let @bruns have the final say.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D16826

To: astippich, bruns, #baloo
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams

D17270: [KUrlNavigator] List subdirs of a parent folder of an archive

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> gregormi wrote in kurlnavigatorbutton.cpp:414
> When I click a zip file I get this in the URL bar:
> 
>   krarc:/home/gregor/Downloads/kfk_10p.zip/
> 
> This could mean that "krarc" should be added to this if statement.

Or we could use mimetype detection like we do in 
`KUrlNavigator::Private::isCompressedPath()`.

> kurlnavigatorbutton.cpp:417
> +// or is a parent directory.
> +QDir test_dir(url.path());
> +if (test_dir.exists()) {

Coding sytle: variable names need to be camelCase.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17270

To: thsurrel, #frameworks
Cc: elvisangelaccio, gregormi, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.9 - Build # 70 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.9/70/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 01 Dec 2018 14:41:34 +
 Build duration:
1 hr 12 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)95%
(20/21)95%
(20/21)72%
(1565/2166)51%
(1076/2124)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)99%
(531/533)51%
(242/470)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(557/753)64%
(598/935)src.kpackage.private100%
(7/7)100%
(7/7)79%
(302/380)49%
(104/211)src.kpackagetool100%
(3/3)100%
(3/3)33%
(161/482)25%
(125/496)

D16826: Treat uints and doubles the same as integers

[Alexander Stippich]

astippich added a comment.


  @bruns do you consider this useful or shall I abandon?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D16826

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16826: Treat uints and doubles the same as integers

[Alexander Stippich]

astippich updated this revision to Diff 46625.
astippich added a comment.


  - rebase

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16826?vs=45314=46625

BRANCH
  uint_double

REVISION DETAIL
  https://phabricator.kde.org/D16826

AFFECTED FILES
  src/file/extractor/result.cpp

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.9 - Build # 75 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.9/75/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 01 Dec 2018 14:39:11 +
 Build duration:
1 hr 10 min and counting
   BUILD ARTIFACTS
  compat_reports/KF5CoreAddons_compat_report.html
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 22 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittestFailed: TestSuite.kdirwatch_stat_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(70/82)85%
(70/82)75%
(6347/8463)43%
(10115/23354)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2697/2772)49%
(5766/11827)src.desktoptojson100%
(2/2)100%
(2/2)77%
(86/111)38%
(121/321)src.lib67%
(2/3)67%
(2/3)60%
(353/591)26%
(243/938)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(184/1044)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1043/2803)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(660/776)42%
(972/2301)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)48%
(377/787)45%
(863/1927)src.lib.util100%
(10/10)100%
(10/10)81%
(739/915)52%
(827/1581)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.9 - Build # 51 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.9/51/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sat, 01 Dec 2018 14:39:32 +
 Build duration:
1 hr 6 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.ktabwidget_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report29%
(4/14)43%
(124/291)43%
(124/291)47%
(21750/45965)38%
(13184/34249)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault0%
(0/1)0%
(0/1)0%
(0/87)0%
(0/56)autotests98%
(44/45)98%
(44/45)98%
(11469/11759)50%
(7254/14375)src0%
(0/1)0%
(0/1)0%
(0/4)0%
(0/2)src.kdebugdialog0%
(0/7)0%
(0/7)0%
(0/256)0%
(0/73)src.kdecore76%
(65/86)76%
(65/86)53%
(9506/17866)49%
(5599/11459)src.kdeui19%
(13/68)19%
(13/68)8%
(765/9698)6%
(330/5364)src.kio7%
(2/27)7%
(2/27)0%
(10/2258)0%
(1/1238)src.kioslave.metainfo0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/4)src.kparts0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/12)src.kssl0%
(0/8)0%
(0/8)0%
(0/1807)0%
(0/853)src.kssl.kcm0%
(0/3)0%
(0/3)0%
(0/264)0%
(0/145)src.solid0%
(0/3)0%
(0/3)0%
(0/188)0%
(0/87)src.solid-networkstatus.kded0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/94)tests0%
(0/34)0%
(0/34)0%
(0/1537)0%
(0/487)

D16931: Extract more tags from exif metadata

[Alexander Stippich]

astippich added a reviewer: mgallien.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16931

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16931: Extract more tags from exif metadata

[Alexander Stippich]

astippich added a comment.


  ping

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16931

To: astippich, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D17256: [KUrlNavigator] Fix firstChildUrl when going back from archive

[Elvis Angelaccio]

elvisangelaccio accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  arc_archivefix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17256

To: thsurrel, #frameworks, elvisangelaccio
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16617: fix extraction of GPS altitude for exif data

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:ca8c11351fe7: fix extraction of GPS altitude for exif 
data (authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16617?vs=44723=46624

REVISION DETAIL
  https://phabricator.kde.org/D16617

AFFECTED FILES
  autotests/exiv2extractortest.cpp
  autotests/samplefiles/test.jpg
  src/extractors/exiv2extractor.cpp
  src/extractors/exiv2extractor.h

To: astippich, #frameworks, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D17253: Fix colors for vector image mimetypes

[Nathaniel Graham]

ngraham added a comment.


  I had never noticed any pattern for the mimetype icons colors. I'd just 
assumed it was random lol.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17253

To: ndavis, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17281: Add icon to KBuildSycocaProgressDialog cancel button

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> kbuildsycocaprogressdialog.cpp:71-73
> +QDialogButtonBox dialogButtonBox;
> +dialogButtonBox.setStandardButtons(QDialogButtonBox::Cancel);
> +setCancelButton(dialogButtonBox.button(QDialogButtonBox::Cancel));

I'm surprised this works. `setCancelButton()` take ownership of the button, but 
the button's parent is created on the stack.

I'd just create it on the heap to be sure. Better safe then sorry.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17281

To: GB_2, ngraham, #frameworks, cfeck
Cc: elvisangelaccio, ngraham, kde-frameworks-devel, alexde, IohannesPetros, 
trickyricky26, michaelh, crozbo, ndavis, firef, bruns, skadinna, 
aaronhoneycutt, mbohlender

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 275 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/275/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 01 Dec 2018 15:11:26 +
 Build duration:
15 min and counting
   BUILD ARTIFACTS
  compat_reports/KF5Plasma_compat_report.html
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3608/13324)18%
(1817/9848)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2248)7%
(96/1456)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1410/3491)28%
(787/2817)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(674/1574)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(582/2018)18%
(313/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
  

D17199: Add unittest to check if commiting the same change twice works

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Yep, it applies now that the other patch is in. Works great, looks good.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17199

To: bruns, #baloo, #frameworks, ngraham, poboiko
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.10 - Build # 57 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.10/57/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 01 Dec 2018 15:08:30 +
 Build duration:
16 min and counting
   BUILD ARTIFACTS
  compat_reports/KF5WindowSystem_compat_report.html
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.kwindowsystem-kwindowinfox11testFailed: TestSuite.kwindowsystem-netrootinfotestwm
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)74%
(7111/9546)54%
(3483/6395)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)96%
(3003/3136)51%
(1262/2456)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)57%
(787/1391)45%
(302/670)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)71%
(3314/4662)60%
(1916/3217)tests0%
(0/5)0%
(0/5)0%
(0/277)0%
(0/46)

D17281: Add icon to KBuildSycocaProgressDialog cancel button

[Gamer Brownie 2]

GB_2 added a comment.


  Ok, thanks for the info :-)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17281

To: GB_2, ngraham, #frameworks, cfeck
Cc: ngraham, kde-frameworks-devel, alexde, IohannesPetros, trickyricky26, 
michaelh, crozbo, ndavis, firef, bruns, skadinna, aaronhoneycutt, mbohlender

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 93 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/93/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 01 Dec 2018 15:04:29 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)95%
(20/21)95%
(20/21)72%
(1565/2166)51%
(1076/2124)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)99%
(531/533)51%
(242/470)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(557/753)64%
(598/935)src.kpackage.private100%
(7/7)100%
(7/7)79%
(302/380)49%
(104/211)src.kpackagetool100%
(3/3)100%
(3/3)33%
(161/482)25%
(125/496)

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.10 - Build # 35 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.10/35/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 01 Dec 2018 15:00:47 +
 Build duration:
19 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.kimageformats-read-tgaFailed: TestSuite.kimageformats-write-tga
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(3/3)76%
(13/17)76%
(13/17)41%
(1493/3602)33%
(663/2021)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(3/3)100%
(3/3)70%
(263/375)50%
(72/144)src.imageformats82%
(9/11)82%
(9/11)40%
(1226/3095)32%
(589/1819)tests33%
(1/3)33%
(1/3)3%
(4/132)3%
(2/58)

D17199: Add unittest to check if commiting the same change twice works

[Stefan Brüns]

bruns added a comment.


  Conceptually, its independent of D17198 , 
but there is a single line not matching in the context
  
  Try again with currennt master

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17199

To: bruns, #baloo, #frameworks, ngraham, poboiko
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17198: Add unit test for position DB

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:38925dd92f69: Add unit test for position DB (authored by 
bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17198?vs=46348=46622

REVISION DETAIL
  https://phabricator.kde.org/D17198

AFFECTED FILES
  autotests/integration/dbstate.h
  autotests/integration/writetransactiontest.cpp

To: bruns, #baloo, #frameworks, ngraham, poboiko
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 274 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/274/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 01 Dec 2018 14:43:01 +
 Build duration:
28 min and counting
   BUILD ARTIFACTS
  compat_reports/KF5Plasma_compat_report.html
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3606/13324)18%
(1816/9848)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(610/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2248)7%
(96/1456)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1410/3491)28%
(787/2817)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(674/1574)29%
(300/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(582/2018)18%
(313/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
  

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.10 - Build # 56 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.10/56/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 01 Dec 2018 14:42:36 +
 Build duration:
25 min and counting
   BUILD ARTIFACTS
  compat_reports/KF5WindowSystem_compat_report.html
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: TestSuite.kwindowsystem-kwindowinfox11testFailed: TestSuite.kwindowsystem-netrootinfotestwm
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7118/9546)55%
(3488/6395)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)96%
(3009/3136)52%
(1266/2456)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)57%
(787/1391)45%
(302/670)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)71%
(3315/4662)60%
(1917/3217)tests0%
(0/5)0%
(0/5)0%
(0/277)0%
(0/46)

KDE CI: Frameworks » kpackage » kf5-qt5 SUSEQt5.10 - Build # 92 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20SUSEQt5.10/92/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 01 Dec 2018 14:41:34 +
 Build duration:
22 min and counting
   JUnit Tests
  Name: (root) Failed: 3 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.testfallbackpackage-appstreamFailed: TestSuite.testpackage-appstreamFailed: TestSuite.testpackage-nodisplay-appstream
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(5/5)95%
(20/21)95%
(20/21)72%
(1565/2166)51%
(1076/2124)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(6/6)100%
(6/6)99%
(531/533)51%
(242/470)autotests.mockdepresolver100%
(1/1)100%
(1/1)78%
(14/18)58%
(7/12)src.kpackage75%
(3/4)75%
(3/4)74%
(557/753)64%
(598/935)src.kpackage.private100%
(7/7)100%
(7/7)79%
(302/380)49%
(104/211)src.kpackagetool100%
(3/3)100%
(3/3)33%
(161/482)25%
(125/496)

D17199: Add unittest to check if commiting the same change twice works

[Nathaniel Graham]

ngraham added a comment.


  Patch does not apply for me on top of current master:
  
Ignore these untracked files and continue? [y/N] y

 INFO  Base commit is not in local repository; trying to fetch.
Created and checked out branch arcpatch-D17199.


This diff is against commit 260e35e79a80eaf0003c5053f1c1ee9fe965b6bc, 
but
the commit is nowhere in the working copy. Try to apply it against the
current working copy state? (1ee2ccc824be8e8c223c7364d0d9e8f7eb2d1874)
[Y/n] y

Checking patch autotests/integration/writetransactiontest.cpp...
error: while searching for:
}
}

QTEST_MAIN(WriteTransactionTest)

#include "writetransactiontest.moc"

error: patch failed: autotests/integration/writetransactiontest.cpp:395
Applying patch autotests/integration/writetransactiontest.cpp with 1 
reject...
Hunk #1 applied cleanly.
Rejected hunk #2.

 Patch Failed! 
Usage Exception: Unable to apply patch!
  
  Is there some unmarked dependency?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17199

To: bruns, #baloo, #frameworks, ngraham, poboiko
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17198: Add unit test for position DB

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17198

To: bruns, #baloo, #frameworks, ngraham, poboiko
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.10 - Build # 34 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.10/34/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 01 Dec 2018 14:40:34 +
 Build duration:
20 min and counting
   JUnit Tests
  Name: (root) Failed: 2 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: TestSuite.kimageformats-read-tgaFailed: TestSuite.kimageformats-write-tga
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report100%
(3/3)76%
(13/17)76%
(13/17)41%
(1493/3602)33%
(663/2021)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(3/3)100%
(3/3)70%
(263/375)50%
(72/144)src.imageformats82%
(9/11)82%
(9/11)40%
(1226/3095)32%
(589/1819)tests33%
(1/3)33%
(1/3)3%
(4/132)3%
(2/58)

D17281: Add icon to KBuildSycocaProgressDialog cancel button

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added reviewers: Frameworks, cfeck.
ngraham added a comment.
This revision is now accepted and ready to land.


  Works and seems reasonable enough. Anyone else have any opinions on the 
matter?
  
  Also @gb_2, please provide your real name and email address so we can land 
this patch with correct authorship information. If you use `arc` for your next 
patch (https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist), we 
won't have to nag you like this. :)
  
  Also in the future, populating the Test Plan section can make life easier for 
your reviewer. In this case, something as simple as "open KMenuEdit, change 
something, and click save" would be nice.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17281

To: GB_2, ngraham, #frameworks, cfeck
Cc: ngraham, kde-frameworks-devel, alexde, IohannesPetros, trickyricky26, 
michaelh, crozbo, ndavis, firef, bruns, skadinna, aaronhoneycutt, mbohlender

KDE CI: Frameworks » kdelibs4support » kf5-qt5 SUSEQt5.10 - Build # 77 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20SUSEQt5.10/77/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 01 Dec 2018 14:39:32 +
 Build duration:
17 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 39 test(s), Skipped: 0 test(s), Total: 40 test(s)Failed: TestSuite.ktabwidget_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report29%
(4/14)43%
(124/291)43%
(124/291)47%
(21615/45963)38%
(13051/34249)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault0%
(0/1)0%
(0/1)0%
(0/87)0%
(0/56)autotests98%
(44/45)98%
(44/45)97%
(11364/11759)50%
(7174/14375)src0%
(0/1)0%
(0/1)0%
(0/4)0%
(0/2)src.kdebugdialog0%
(0/7)0%
(0/7)0%
(0/256)0%
(0/73)src.kdecore76%
(65/86)76%
(65/86)53%
(9476/17864)48%
(5546/11459)src.kdeui19%
(13/68)19%
(13/68)8%
(765/9698)6%
(330/5364)src.kio7%
(2/27)7%
(2/27)0%
(10/2258)0%
(1/1238)src.kioslave.metainfo0%
(0/1)0%
(0/1)0%
(0/32)0%
(0/4)src.kparts0%
(0/1)0%
(0/1)0%
(0/24)0%
(0/12)src.kssl0%
(0/8)0%
(0/8)0%
(0/1807)0%
(0/853)src.kssl.kcm0%
(0/3)0%
(0/3)0%
(0/264)0%
(0/145)src.solid0%
(0/3)0%
(0/3)0%
(0/188)0%
(0/87)src.solid-networkstatus.kded0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/94)tests0%
(0/34)0%
(0/34)0%
(0/1537)0%
(0/487)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.10 - Build # 131 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.10/131/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 01 Dec 2018 14:39:11 +
 Build duration:
13 min and counting
   BUILD ARTIFACTS
  compat_reports/KF5CoreAddons_compat_report.html
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 23 test(s), Skipped: 0 test(s), Total: 24 test(s)Failed: TestSuite.kdirwatch_qfswatch_unittest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)85%
(70/82)85%
(70/82)75%
(6345/8463)43%
(10112/23358)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests93%
(26/28)93%
(26/28)97%
(2696/2772)49%
(5762/11825)src.desktoptojson100%
(2/2)100%
(2/2)77%
(86/111)38%
(122/325)src.lib67%
(2/3)67%
(2/3)60%
(352/591)26%
(243/942)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(184/1044)src.lib.io82%
(9/11)82%
(9/11)68%
(854/1265)37%
(1041/2797)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)38%
(52/138)src.lib.plugin100%
(7/7)100%
(7/7)85%
(660/776)42%
(972/2303)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(44/76)src.lib.text63%
(5/8)63%
(5/8)48%
(377/787)45%
(864/1927)src.lib.util100%
(10/10)100%
(10/10)81%
(739/915)52%
(828/1583)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/398)

KDE CI: Frameworks » frameworkintegration » kf5-qt5 WindowsMSVCQt5.11 - Build # 17 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/frameworkintegration/job/kf5-qt5%20WindowsMSVCQt5.11/17/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sat, 01 Dec 2018 14:38:23 +
 Build duration:
13 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D16832: fix empty runner list after switching to new locale

[Nick Shaforostoff]

shaforostoff added inline comments.

INLINE COMMENTS

> davidedmundson wrote in runnermanager.cpp:274
> what does deadRunners have to do with this?

if deadRunners is empty then there is no sense rerunning this method, and it 
even could cause endless recursion

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D16832

To: shaforostoff, #plasma_workspaces, davidedmundson, #frameworks
Cc: kde-frameworks-devel, michaldybczak, sdepiets, michaelh, ngraham, bruns, 
skadinna, huftis

KDE CI: Frameworks » attica » kf5-qt5 WindowsMSVCQt5.11 - Build # 17 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/attica/job/kf5-qt5%20WindowsMSVCQt5.11/17/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Sat, 01 Dec 2018 14:38:03 +
 Build duration:
4 min 47 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 3 test(s)

D17281: Add icon to KBuildSycocaProgressDialog cancel button

[Gamer Brownie 2]

GB_2 created this revision.
GB_2 added a project: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  The cancel button in the KBuildSycocaProgressDialog (showing that the system 
configuration is updated) has no icon, so this fixes it.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17281

AFFECTED FILES
  src/widgets/kbuildsycocaprogressdialog.cpp

To: GB_2
Cc: kde-frameworks-devel, alexde, IohannesPetros, trickyricky26, michaelh, 
crozbo, ndavis, firef, ngraham, bruns, skadinna, aaronhoneycutt, mbohlender

D17273: Extend unit tests to check comparisons of multi-digit numeric properties

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:8a390e188be2: Extend unit tests to check comparisons of 
multi-digit numeric properties (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17273?vs=46592=46618

REVISION DETAIL
  https://phabricator.kde.org/D17273

AFFECTED FILES
  autotests/unit/engine/postingdbtest.cpp

To: bruns, #baloo, #frameworks, ngraham, poboiko, mgallien
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17274: Remove duplicated code for rating property

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:49d08db3b943: Remove duplicated code for rating property 
(authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17274?vs=46594=46619

REVISION DETAIL
  https://phabricator.kde.org/D17274

AFFECTED FILES
  src/lib/searchstore.cpp

To: bruns, #baloo, #frameworks, ngraham, poboiko
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17272: Fix searches for rating 10 (5 stars)

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:e1045c4f7891: Fix searches for rating 10 (5 stars) 
(authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17272?vs=46593=46617

REVISION DETAIL
  https://phabricator.kde.org/D17272

AFFECTED FILES
  autotests/unit/engine/postingdbtest.cpp
  src/engine/postingdb.cpp
  src/engine/postingdb.h
  src/engine/transaction.cpp
  src/engine/transaction.h
  src/lib/searchstore.cpp

To: bruns, #baloo, #frameworks, ngraham, poboiko, mgallien
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17160: Remove extra spaces from Debug output, insert delimiters between fields

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:619547cbfefe: Remove extra spaces from Debug output, 
insert delimiters between fields (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17160?vs=46223=46616

REVISION DETAIL
  https://phabricator.kde.org/D17160

AFFECTED FILES
  src/engine/enginequery.h

To: bruns, #baloo, #frameworks, ngraham, poboiko, astippich
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17252: ovs-patch and ovs-port setting

[Jan Grulich]

jgrulich added inline comments.

INLINE COMMENTS

> ovspatchsetting.cpp:73
> +}
> +
> +}

Remove this space.

> ovspatchsetting.h:29
> +
> +#if !NM_CHECK_VERSION(1, 10, 0)
> +#define NM_SETTING_OVS_PATCH_SETTING_NAME   "ovs-patch"

Move this please out of the header file and copy these defines to your test.

> ovsportsetting.h:28
> +#if NM_CHECK_VERSION(1, 10, 0)
> +#define NM_SETTING_OVS_PORT_SETTING_NAME"ovs-port"
> +

Same with these defines. Move them ouf of the header.

> setting.cpp:129
>  typeString = QLatin1String(NM_SETTING_USER_SETTING_NAME);
> +break;
>  case OvsInterface:

I already added this missing break when pushing one of your changes.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17252

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16949: Support for TLS 1.3 (part of Qt 5.12)

[Albert Astals Cid]

aacid added a comment.


  Ping?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16949

To: aacid
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16954: Add find module for Google's libphonenumber

[Volker Krause]

vkrause added a comment.


  ping?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D16954

To: vkrause, #build_system, #frameworks
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns