D17325: Fix leak in kemoticons

[Kevin Funk]

kfunk added a comment.


  Not entirely sure about whether this is the right fix for this. Can someone 
check why this was commented before?
  
  The leak is fixed with this patch. Unit tests still work, too.
  
  And it kind of makes sense to have the `KEmoticonsTheme` class own its 
provider.

REPOSITORY
  R301 KEmoticons

REVISION DETAIL
  https://phabricator.kde.org/D17325

To: kfunk
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17325: Fix leak in kemoticons

[Kevin Funk]

kfunk created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kfunk requested review of this revision.

REVISION SUMMARY
  ASAN trace:
  Indirect leak of 64 byte(s) in 2 object(s) allocated from:
  
#0 0x52a000 in operator new(unsigned long) 
(/home/kfunk/devel/install/kf5/bin/kmail+0x52a000)
#1 0x7fbac897e192 in 
QList::node_construct(QList::Node*,
 KEmoticonsProvider::Emoticon const&) 
/home/kfunk/devel/build/qt5.11/qtbase/include/QtCore/../../../../../src/qt5.11/qtbase/src/corelib/tools/qlist.h:435:65
#2 0x7fbac897d184 in 
QList::append(KEmoticonsProvider::Emoticon 
const&) 
/home/kfunk/devel/build/qt5.11/qtbase/include/QtCore/../../../../../src/qt5.11/qtbase/src/corelib/tools/qlist.h:584:13
#3 0x7fbac897c59c in KEmoticonsProvider::addIndexItem(QString const&, 
QStringList const&) 
/home/kfunk/devel/src/kf5/kemoticons/src/core/kemoticonsprovider.cpp:162:39
#4 0x7fba8a15f7b5 in KdeEmoticons::loadTheme(QString const&) 
/home/kfunk/devel/src/kf5/kemoticons/src/providers/kde/kde_emoticons.cpp:183:13
#5 0x7fbac896ceb7 in KEmoticonsPrivate::loadTheme(QString 
const&)::$_6::operator()(QString const&, QString const&, KEmoticonsProvider*) 
const /home/kfunk/devel/src/kf5/kemoticons/src/core/kemoticons.cpp:126:19
#6 0x7fbac896cca1 in KEmoticonsPrivate::loadTheme(QString const&) 
/home/kfunk/devel/src/kf5/kemoticons/src/core/kemoticons.cpp:151:24
#7 0x7fbac896d24f in KEmoticons::theme(QString const&) const 
/home/kfunk/devel/src/kf5/kemoticons/src/core/kemoticons.cpp:181:15
#8 0x7fbac896d1ab in KEmoticons::theme() const 
/home/kfunk/devel/src/kf5/kemoticons/src/core/kemoticons.cpp:171:12
#9 0x7fba8a2e25bb in KTextToHTMLEmoticons::parseEmoticons(QString const&, 
bool, QStringList const&) 
/home/kfunk/devel/src/kf5/kemoticons/src/integrationplugin/ktexttohtml.cpp:43:24
...

REPOSITORY
  R301 KEmoticons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17325

AFFECTED FILES
  src/core/kemoticonstheme.cpp

To: kfunk
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17317: match and tc setting

[Jan Grulich]

jgrulich added inline comments.

INLINE COMMENTS

> tcsettingtest.cpp:74
> +while (it != map.constEnd()) {
> +QCOMPARE(it.value(), map1.value(it.key()));
> +++it;

Something like:

  NMVariantMapList list = it.value();
  NMVariantMapList list1 = map1.value(it.key());
  QCOMPARE(list.count(), list1.count());
  
  int comparedMaps = 0;
  NMVariantMapList::const_iterator listIt = list.constBegin();
  while (listIt != list.constEnd() {
  NMVariantMapList::const_iterator list1It = list1.constBegin();
  while (list1it != list1.constEnd()) {
   QVariantMap listMap = listIt.value();
   QVariantMap1 listMap1 = list1It.value();
   // Test if keys do match, because the list can be in different order
   QStringList listMapKeys = listMap.keys();
   QStringList listMapKeys1 = listMap1.keys();
   listMapKeys.sort();
   listMapKeys1.sort();
   if (listMapKeys.join(QChar(' ')) ==  listMapKeys1.join(QChar(' '))) {
 // Here the maps should have same keys so compare QVariantMaps 
as we do now
 .
 ++comparedMaps;
   }
   ++list1it;  
   }
   ++listIt;
  }
  
  // Test if we compared all maps, if not, then probably they didn't match
  QCOMPARE(comparedMaps, list.count();

> pranavgade wrote in tcsettingtest.cpp:69
> So..how should I do it?

See below, it's ugly, but problem is that give it's a QList, the maps can be in 
different order so you first have to identify you compare correct QVariantMaps. 
I do that by comparing keys.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17317

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17309: Add flashlight action icons

[TrickyRicky]

trickyricky26 edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17309

To: trickyricky26, #vdg
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 277 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/277/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Mon, 03 Dec 2018 04:32:04 +
 Build duration:
5 min 32 sec and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 9 test(s), Skipped: 0 test(s), Total: 15 test(s)Failed: TestSuite.dialognativetestFailed: TestSuite.plasma-configmodeltestFailed: TestSuite.plasma-fallbackpackagetestFailed: TestSuite.plasma-iconitemtestFailed: TestSuite.plasma-packagestructuretestFailed: TestSuite.plasma-storagetest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(6/18)36%
(45/126)36%
(45/126)27%
(3608/13324)18%
(1817/9848)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests86%
(12/14)86%
(12/14)55%
(612/1117)29%
(315/1086)src.declarativeimports.calendar0%
(0/6)0%
(0/6)0%
(0/464)0%
(0/243)src.declarativeimports.core31%
(5/16)31%
(5/16)13%
(299/2248)7%
(96/1456)src.declarativeimports.plasmacomponents0%
(0/6)0%
(0/6)0%
(0/518)0%
(0/207)src.declarativeimports.plasmaextracomponents0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/22)src.declarativeimports.platformcomponents0%
(0/3)0%
(0/3)0%
(0/58)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/14)0%
(0/2)src.plasma64%
(14/22)64%
(14/22)40%
(1410/3491)28%
(787/2817)src.plasma.packagestructure0%
(0/7)0%
(0/7)0%
(0/134)0%
(0/12)src.plasma.private50%
(9/18)50%
(9/18)43%
(674/1574)29%
(301/1034)src.plasma.scripting0%
(0/3)0%
(0/3)0%
(0/162)0%
(0/128)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick33%
(4/12)33%
(4/12)29%
(582/2018)18%
(313/1721)src.plasmaquick.private50%
(1/2)50%
(1/2)29%
(31/106)36%
(5/14)src.scriptengines.qml.plasmoid0%
(0/6)0%
(0/6)0%
(0/1178)0%
(0/1028)tests.dpi0%
(0/2)0%
(0/2)0%
(0/21)0%
(0/2)tests.kplugins0%
(0/2)0%
 

D17317: match and tc setting

[Pranav Gade]

pranavgade added inline comments.

INLINE COMMENTS

> jgrulich wrote in tcsettingtest.cpp:69
> I think that you cannot compare NMVariantMaps this way, that's why probably 
> the test for IPv4 and IPv6 didn't fail when we swapped values for route-data 
> and address-data. You will need to compare values inside the maps separately.

So..how should I do it?

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17317

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17317: match and tc setting

[Pranav Gade]

pranavgade updated this revision to Diff 46761.
pranavgade marked 9 inline comments as done.

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17317?vs=46724&id=46761

REVISION DETAIL
  https://phabricator.kde.org/D17317

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/matchsettingtest.cpp
  autotests/settings/matchsettingtest.h
  autotests/settings/tcsettingtest.cpp
  autotests/settings/tcsettingtest.h
  src/CMakeLists.txt
  src/settings/matchsetting.cpp
  src/settings/matchsetting.h
  src/settings/matchsetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h
  src/settings/tcsetting.cpp
  src/settings/tcsetting.h
  src/settings/tcsetting_p.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17309: Add flashlight action icons

[Noah Davis]

ndavis added a comment.


  Reminds me of these: 
http://store.t-studious.com/wp-content/uploads/2016/12/Maglite-2D-LED-Torch-.jpg
  
  I like the 32px version, but it kind of just looks like a tube with the 16px 
`flashlight-off` icon. What if you turned the head of the flashlight to the 
right? Then you'd have a bit more space since our HIG allows icons to go past 
the left and right margins sometimes. The battery icon we use in the Breeze 
Plasma theme does this. If you put the button on the top, then you might even 
be able to show the button without the red slash cutting it off.
  
  F6452023: Screenshot_20181202_192941.png 

  F6452021: Screenshot_20181202_193110.png 


REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17309

To: trickyricky26, #vdg
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17281: Add icon to KBuildSycocaProgressDialog cancel button

[Björn Feber]

GB_2 added a comment.


  In D17281#370253 , @ngraham wrote:
  
  > @GB_2, can you provide an email address so we can land this for you? Thanks!
  
  
  How can I provide an email address in the Phabriactor webinterface?
  I already provided an email in my email settings on here...

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17281

To: GB_2, ngraham, #frameworks, cfeck, elvisangelaccio
Cc: elvisangelaccio, ngraham, kde-frameworks-devel, alexde, IohannesPetros, 
trickyricky26, michaelh, crozbo, ndavis, firef, bruns, skadinna, 
aaronhoneycutt, mbohlender

D17300: add result to baloo namespace

[Stefan Brüns]

bruns accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  result_namespace

REVISION DETAIL
  https://phabricator.kde.org/D17300

To: astippich, #baloo, bruns
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17245: Add string formatting function to property info

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> propertyinfotest.cpp:63
> +PropertyInfo sampleRate(Property::SampleRate);
> +QCOMPARE(sampleRate.formatAsDisplayString(QVariant(44100)), 
> QStringLiteral("44,1 kHz"));
> +PropertyInfo bitRate(Property::BitRate);

I think this should be "44.1 kHz". Insert the correct expected value and make 
it QEXPECT_FAIL?

> propertyinfotest.cpp:65
> +PropertyInfo bitRate(Property::BitRate);
> +QCOMPARE(bitRate.formatAsDisplayString(QVariant(128000)), 
> QStringLiteral("128 kB/s"));
> +PropertyInfo orientation(Property::ImageOrientation);

dito, "128 kb/s"

> formatstrings.cpp:80
> +case 2: string = i18nc("Description of image orientation", "Horizontally 
> flipped"); break;
> +case 3: string = i18nc("Description of image orientation", "180° rotated 
> CCW"); break;
> +case 4: string = i18nc("Description of image orientation", "Vertically 
> flipped"); break;

for 180°,  CCW is irrelevant.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D17245

To: astippich, broulik, bruns, mgallien
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams

D16249: Warn user before copy/move job if the file size exceeds the maximum possible file size in FAT32 filesystem(4 GB)

[Nathaniel Graham]

ngraham added a comment.


  This can land now!

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D16249

To: shubham, ngraham, #frameworks, bruns, dfaure
Cc: davidedmundson, elvisangelaccio, dfaure, cfeck, bruns, 
kde-frameworks-devel, michaelh, ngraham

D17324: Move internal helper from BasicIndexingJob to anonymous namespace

[Stefan Brüns]

bruns added a dependency: D17315: Avoid potential nullptr access for Document, 
use reference instead.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17324

To: bruns, #baloo, #frameworks, astippich, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17315: Avoid potential nullptr access for Document, use reference instead

[Stefan Brüns]

bruns added a dependent revision: D17324: Move internal helper from 
BasicIndexingJob to anonymous namespace.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17315

To: bruns, #baloo, #frameworks, astippich, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17324: Move internal helper from BasicIndexingJob to anonymous namespace

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, astippich, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Also remove the return value, as it not evaluated, and not even useful -
  we are not interested in the presence of tags, but if the tags where
  modified. The latter can only be determined from the write transaction
  (Read-modify-check-write).

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17324

AFFECTED FILES
  src/file/basicindexingjob.cpp
  src/file/basicindexingjob.h

To: bruns, #baloo, #frameworks, astippich, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.9 - Build # 92 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.9/92/
 Project:
kf5-qt5 SUSEQt5.9
 Date of build:
Sun, 02 Dec 2018 20:50:19 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 45 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: TestSuite.kwayland-testWaylandSeat
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)92%
(235/255)92%
(235/255)84%
(26170/30972)52%
(10427/19898)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(42/42)100%
(42/42)97%
(11931/12237)49%
(6245/12751)autotests.server100%
(5/5)100%
(5/5)99%
(355/358)49%
(169/344)src.client99%
(71/72)99%
(71/72)85%
(6159/7257)65%
(1778/2756)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server100%
(115/115)100%
(115/115)86%
(7644/8847)65%
(2235/3418)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1287)0%
(0/313)

D16931: Extract more tags from exif metadata

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:0b35de4243aa: Extract more tags from exif metadata 
(authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16931?vs=45608&id=46757

REVISION DETAIL
  https://phabricator.kde.org/D16931

AFFECTED FILES
  autotests/exiv2extractortest.cpp
  src/extractors/exiv2extractor.cpp

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D17315: Avoid potential nullptr access for Document, use reference instead

[Stefan Brüns]

bruns updated this revision to Diff 46755.
bruns retitled this revision from "Avoid potential nullptr access for Document 
use reference instead" to "Avoid potential nullptr access for Document, use 
reference instead".
bruns added a comment.


  reorder patches

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17315?vs=46721&id=46755

REVISION DETAIL
  https://phabricator.kde.org/D17315

AFFECTED FILES
  autotests/integration/querytest.cpp
  autotests/unit/engine/termgeneratortest.cpp
  src/engine/termgenerator.cpp
  src/engine/termgenerator.h
  src/file/basicindexingjob.cpp
  src/file/extractor/result.cpp

To: bruns, #baloo, #frameworks, astippich, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17284: RFC: Add unit test for splitting of numbers in TermGenerator

[Nathaniel Graham]

ngraham accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17284

To: bruns, #baloo, #frameworks, ngraham, astippich
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 118 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/118/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 02 Dec 2018 20:44:56 +
 Build duration:
4 min 44 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 45 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: TestSuite.kwayland-testWaylandSeat
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)92%
(235/255)92%
(235/255)85%
(26341/30976)53%
(10546/19898)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(42/42)100%
(42/42)99%
(12068/12238)50%
(6342/12751)autotests.server100%
(5/5)100%
(5/5)99%
(355/358)49%
(169/344)src.client99%
(71/72)99%
(71/72)85%
(6168/7258)65%
(1781/2756)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server100%
(115/115)100%
(115/115)87%
(7669/8849)66%
(2254/3418)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1287)0%
(0/313)

D15464: [server] Touch drag support

[Roman Gilg]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:09b5adee94ad: [server] Touch drag support (authored by 
romangg).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15464?vs=45164&id=46753

REVISION DETAIL
  https://phabricator.kde.org/D15464

AFFECTED FILES
  autotests/client/test_drag_drop.cpp
  src/server/datadevice_interface.cpp
  src/server/seat_interface.cpp
  src/server/seat_interface.h
  src/server/seat_interface_p.h
  src/server/touch_interface.cpp

To: romangg, #kwin, #frameworks, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.10 - Build # 117 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.10/117/
 Project:
kf5-qt5 SUSEQt5.10
 Date of build:
Sun, 02 Dec 2018 20:38:31 +
 Build duration:
5 min 34 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 45 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: TestSuite.kwayland-testDataDevice
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)92%
(235/255)92%
(235/255)85%
(26327/30851)53%
(10548/19728)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(42/42)100%
(42/42)99%
(12065/12157)50%
(6353/12625)autotests.server100%
(5/5)100%
(5/5)99%
(355/358)49%
(169/344)src.client99%
(71/72)99%
(71/72)85%
(6180/7259)65%
(1787/2756)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server100%
(115/115)100%
(115/115)87%
(7646/8804)66%
(2239/3374)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/120)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1287)0%
(0/313)

D15443: [server] Allow multiple touch interfaces per client

[Roman Gilg]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:7bb2a225521c: [server] Allow multiple touch interfaces 
per client (authored by romangg).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15443?vs=41916&id=46752

REVISION DETAIL
  https://phabricator.kde.org/D15443

AFFECTED FILES
  src/server/seat_interface.cpp
  src/server/seat_interface_p.h

To: romangg, #kwin, #frameworks, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, michaelh, ngraham, bruns

D17301: add documentation to result class

[Alexander Stippich]

astippich marked 3 inline comments as done.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17301

To: astippich, #baloo, bruns
Cc: yurchor, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D17301: add documentation to result class

[Alexander Stippich]

astippich updated this revision to Diff 46750.
astippich added a comment.


  - more adjustments

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17301?vs=46706&id=46750

BRANCH
  result_documentation

REVISION DETAIL
  https://phabricator.kde.org/D17301

AFFECTED FILES
  src/file/extractor/result.h

To: astippich, #baloo, bruns
Cc: yurchor, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D17315: Avoid potential nullptr access for Document use reference instead

[Alexander Stippich]

astippich added a comment.


  In D17315#370404 , @bruns wrote:
  
  > In D17315#370298 , @astippich 
wrote:
  >
  > > This one doesn't apply, looks like D17824 is a dependency?
  >
  >
  > D17312 
  
  
  Hmm no, still complains in termgeneratortest about
  
  error: while searching for:
  
QString str = QString::fromLatin1("1 5 10 -3 -12, 5.6, -13.4 -7e3");

Document doc;
TermGenerator termGen(&doc);
termGen.indexText(str);

QList words = allWords(doc);

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17315

To: bruns, #baloo, #frameworks, astippich, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D16931: Extract more tags from exif metadata

[Stefan Brüns]

bruns accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R286 KFileMetaData

BRANCH
  exif_image_description

REVISION DETAIL
  https://phabricator.kde.org/D16931

To: astippich, bruns, mgallien
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D17315: Avoid potential nullptr access for Document use reference instead

[Stefan Brüns]

bruns added a comment.


  In D17315#370298 , @astippich 
wrote:
  
  > This one doesn't apply, looks like D17824 is a dependency?
  
  
  D17312 

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17315

To: bruns, #baloo, #frameworks, astippich, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17313: Use Compact json formatting for storing document metadata

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:b891716d336a: Use Compact json formatting for storing 
document metadata (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17313?vs=46716&id=46745

REVISION DETAIL
  https://phabricator.kde.org/D17313

AFFECTED FILES
  src/file/extractor/result.cpp

To: bruns, #baloo, #frameworks, astippich, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17312: Remove unused map() getter from Result

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:f614d56285bf: Remove unused map() getter from Result 
(authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17312?vs=46715&id=46744

REVISION DETAIL
  https://phabricator.kde.org/D17312

AFFECTED FILES
  src/file/extractor/result.cpp
  src/file/extractor/result.h

To: bruns, #baloo, #frameworks, astippich, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17298: remove unused docId from result

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:647823d36592: remove unused docId from result (authored 
by astippich).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17298?vs=46680&id=46743

REVISION DETAIL
  https://phabricator.kde.org/D17298

AFFECTED FILES
  src/file/extractor/result.cpp
  src/file/extractor/result.h

To: astippich, #baloo, bruns, ngraham
Cc: ngraham, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
bruns, abrahams

D17309: Add flashlight action icons

[TrickyRicky]

trickyricky26 added a comment.


  The main issue is that the added lines are too much complexity for 16px 
icons. They are probably possible for 22px and up, at the expense of making the 
flashlight look a bit short.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17309

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17313: Use Compact json formatting for storing document metadata

[Stefan Brüns]

bruns added a comment.


  In D17313#370359 , @ngraham wrote:
  
  > Might this make the DB take up less space on disk?
  
  
  Yes, but not in a significant way - for me, the docData is less than 1% of 
the DB, this saves 10..50% of that.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17313

To: bruns, #baloo, #frameworks, astippich, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17313: Use Compact json formatting for storing document metadata

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Might this make the DB take up less space on disk?

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17313

To: bruns, #baloo, #frameworks, astippich, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17313: Use Compact json formatting for storing document metadata

[Stefan Brüns]

bruns added a comment.


  In D17313#370345 , @ngraham wrote:
  
  > This is backwards-compatible with the existing formal for retrieval, right?
  
  
  From the json standpoint, both are equivalent.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17313

To: bruns, #baloo, #frameworks, astippich, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17312: Remove unused map() getter from Result

[Nathaniel Graham]

ngraham accepted this revision.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17312

To: bruns, #baloo, #frameworks, astippich, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17298: remove unused docId from result

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Ah, of course, duh!

REPOSITORY
  R293 Baloo

BRANCH
  remove_result_id

REVISION DETAIL
  https://phabricator.kde.org/D17298

To: astippich, #baloo, bruns, ngraham
Cc: ngraham, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
bruns, abrahams

D17298: remove unused docId from result

[Stefan Brüns]

bruns accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  remove_result_id

REVISION DETAIL
  https://phabricator.kde.org/D17298

To: astippich, #baloo, bruns
Cc: ngraham, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
bruns, abrahams

D17298: remove unused docId from result

[Stefan Brüns]

bruns added a comment.


  libKF5BalooEngine is not exported to the outside world.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17298

To: astippich, #baloo, bruns
Cc: ngraham, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
bruns, abrahams

D17309: Add flashlight action icons

[Nathaniel Graham]

ngraham added a comment.


  Looks pretty nice to me! I find myself wanting some little lines coming out 
of the top of the "on" version though. I guess that means we would need to add 
them as well for the "off" versions too though, and maybe that would look weird?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17309

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17310: Improve Kile icon with LaTeX font

[Noah Davis]

ndavis added a comment.


  The original design was more consistent with the usual style for text 
characters used in Breeze icons, but I think using actual LaTeX fonts in this 
context works just as well or better for LaTeX users.
  
  +1

REPOSITORY
  R266 Breeze Icons

BRANCH
  improve-kile-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17310

To: trickyricky26, #vdg, ngraham, #kile
Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D17313: Use Compact json formatting for storing document metadata

[Nathaniel Graham]

ngraham added a comment.


  This is backwards-compatible with the existing formal for retrieval, right?

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17313

To: bruns, #baloo, #frameworks, astippich, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D16671: Refactor embedded image extractor for greater extensibility

[Alexander Stippich]

astippich added a comment.


  anyone? I would like to extend the support to the same file types as 
supported by the taglibextractor

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D16671

To: astippich, mgallien, bruns
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D17315: Avoid potential nullptr access for Document use reference instead

[Alexander Stippich]

astippich added a comment.


  This one doesn't apply, looks like D17824 is a dependency?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17315

To: bruns, #baloo, #frameworks, astippich, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17298: remove unused docId from result

[Nathaniel Graham]

ngraham added a comment.


  Some of these are public; wouldn't this break ABI compatibility?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17298

To: astippich, #baloo, bruns
Cc: ngraham, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
bruns, abrahams

D17310: Improve Kile icon with LaTeX font

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a reviewer: Kile.
ngraham added a comment.
This revision is now accepted and ready to land.


  Looks great to me! Let's make sure the Kile folks agree. :)

REPOSITORY
  R266 Breeze Icons

BRANCH
  improve-kile-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17310

To: trickyricky26, #vdg, ngraham, #kile
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17300: add result to baloo namespace

[Alexander Stippich]

astippich updated this revision to Diff 46733.
astippich added a comment.


  - rebase

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17300?vs=46683&id=46733

BRANCH
  result_namespace

REVISION DETAIL
  https://phabricator.kde.org/D17300

AFFECTED FILES
  src/file/extractor/result.cpp
  src/file/extractor/result.h

To: astippich, #baloo, bruns
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17281: Add icon to KBuildSycocaProgressDialog cancel button

[Nathaniel Graham]

ngraham added a comment.


  @GB_2, can you provide an email address so we can land this for you? Thanks!

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17281

To: GB_2, ngraham, #frameworks, cfeck, elvisangelaccio
Cc: elvisangelaccio, ngraham, kde-frameworks-devel, alexde, IohannesPetros, 
trickyricky26, michaelh, crozbo, ndavis, firef, bruns, skadinna, 
aaronhoneycutt, mbohlender

D17313: Use Compact json formatting for storing document metadata

[Alexander Stippich]

astippich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17313

To: bruns, #baloo, #frameworks, astippich, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17312: Remove unused map() getter from Result

[Alexander Stippich]

astippich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17312

To: bruns, #baloo, #frameworks, astippich, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17298: remove unused docId from result

[Alexander Stippich]

astippich removed a dependency: D16826: Treat uints the same as ints.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17298

To: astippich, #baloo, bruns
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D16826: Treat uints the same as ints

[Alexander Stippich]

astippich removed a dependent revision: D17298: remove unused docId from result.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D16826

To: astippich, bruns, #baloo
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams

D17299: move implementation of document get to cpp file

[Alexander Stippich]

astippich abandoned this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17299

To: astippich, #baloo, bruns
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17298: remove unused docId from result

[Alexander Stippich]

astippich retitled this revision from "remove unused doc_id from result" to 
"remove unused docId from result".
astippich edited the summary of this revision.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17298

To: astippich, #baloo, bruns
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17317: match and tc setting

[Jan Grulich]

jgrulich added inline comments.

INLINE COMMENTS

> matchsettingtest.cpp:43
> +
> +map.insert(QLatin1String(NM_SETTING_MATCH_INTERFACE_NAME), 
> interfaceName);
> +

This define won't exist for NM < 1.12.0

> tcsettingtest.cpp:58
> +
> +map.insert(QLatin1String(NM_SETTING_TC_CONFIG_TFILTERS), 
> QVariant::fromValue(tfilters));
> +map.insert(QLatin1String(NM_SETTING_TC_CONFIG_QDISCS), 
> QVariant::fromValue(qdiscs));

TC defines do not exist before NM 1.10.0

> tcsettingtest.cpp:69
> +while (it != map.constEnd()) {
> +QCOMPARE(it.value(), map1.value(it.key()));
> +++it;

I think that you cannot compare NMVariantMaps this way, that's why probably the 
test for IPv4 and IPv6 didn't fail when we swapped values for route-data and 
address-data. You will need to compare values inside the maps separately.

> matchsetting.h:27
> +
> +#include 
> +

I think you don't need to include 

> matchsetting.h:29
> +
> +#if !NM_CHECK_VERSION(1, 12, 0)
> +#define NM_SETTING_MATCH_SETTING_NAME  "match"

Move those defines out of the header file.

> tcsetting.cpp:115
> +dbg.nospace() << NM_SETTING_TC_CONFIG_QDISCS << ": " << '\n';
> +Q_FOREACH (const QVariantMap & qdiscs, setting.qdiscs()) {
> +QVariantMap::const_iterator i = qdiscs.constBegin();

const QVariantMap &qdisc

> tcsetting.cpp:118
> +while (i != qdiscs.constEnd()) {
> +dbg.nospace() << i.key() << ": " << i.value() << '\n';
> +}

Indent.

> tcsetting.cpp:122
> +dbg.nospace() << NM_SETTING_TC_CONFIG_TFILTERS << ": " << '\n';
> +Q_FOREACH (const QVariantMap & tfilters, setting.tfilters()) {
> +QVariantMap::const_iterator i = tfilters.constBegin();

const QVariantMap &tfilter

> tcsetting.h:30
> +
> +#if !NM_CHECK_VERSION(1, 12, 0)
> +#define NM_SETTING_TC_CONFIG_SETTING_NAME"tc"

TC defines are present since NM 1.10.0. Also move them out of the header file.

> tcsetting_p.h:25
> +#include 
> +#include "../ipconfig.h"
> +

This include shouldn't be needed.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17317

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16832: fix empty runner list after switching to new locale

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  Dead runners will surely be empty on the first load. You could still have had 
a locale change then.
  
  Also, now I'm re-reading it you're relying on locales to always have unique 
strings. It's perfectly plausible that spanish and italian could have 1 word 
matching. Or two locales having an untranslated value. As long as 1 value 
remains the same this workaround won't work.

REPOSITORY
  R308 KRunner

REVISION DETAIL
  https://phabricator.kde.org/D16832

To: shaforostoff, #plasma_workspaces, davidedmundson, #frameworks
Cc: kde-frameworks-devel, michaldybczak, sdepiets, michaelh, ngraham, bruns, 
skadinna, huftis

D17317: match and tc setting

[Jan Grulich]

jgrulich added a comment.


  Why did you add my test for tun setting?

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17317

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17299: move implementation of document get to cpp file

[Stefan Brüns]

bruns added a comment.


  yes, please.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17299

To: astippich, #baloo, bruns
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17317: match and tc setting

[Pranav Gade]

pranavgade created this revision.
pranavgade added a reviewer: jgrulich.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
pranavgade requested review of this revision.

REVISION SUMMARY
  Added match and tc setting according to:
  https://developer.gnome.org/NetworkManager/stable/settings-match.html 
https://developer.gnome.org/NetworkManager/stable/settings-tc.html

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17317

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/matchsettingtest.cpp
  autotests/settings/matchsettingtest.h
  autotests/settings/tcsettingtest.cpp
  autotests/settings/tcsettingtest.h
  src/CMakeLists.txt
  src/settings/matchsetting.cpp
  src/settings/matchsetting.h
  src/settings/matchsetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h
  src/settings/tcsetting.cpp
  src/settings/tcsetting.h
  src/settings/tcsetting_p.h
  src/settings/tunsettingtest.cpp

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17302: add simple test for string merging

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> astippich wrote in resulttest.cpp:40
> Actually it is. The TermGenerators are otherwise only initialized with 
> nullptr, and consequently will crash. That is something that should be fixed 
> (separately).

D17315 

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17302

To: astippich, #baloo, bruns
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17315: Avoid potential nullptr access for Document use reference instead

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, astippich, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Using a TermGenerator without backing document is pointless and can
  even crash when the document has been initialized with a nullptr.

TEST PLAN
  ctest

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17315

AFFECTED FILES
  autotests/integration/querytest.cpp
  autotests/unit/engine/termgeneratortest.cpp
  src/engine/termgenerator.cpp
  src/engine/termgenerator.h
  src/file/basicindexingjob.cpp
  src/file/extractor/result.cpp

To: bruns, #baloo, #frameworks, astippich, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17252: ovs-patch and ovs-port setting

[Jan Grulich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R282:15670b62146f: ovs-patch and ovs-port setting (authored by 
pranavgade, committed by jgrulich).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D17252?vs=46708&id=46719#toc

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17252?vs=46708&id=46719

REVISION DETAIL
  https://phabricator.kde.org/D17252

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/ovspatchsettingtest.cpp
  autotests/settings/ovspatchsettingtest.h
  autotests/settings/ovsportsettingtest.cpp
  autotests/settings/ovsportsettingtest.h
  src/CMakeLists.txt
  src/settings/ovspatchsetting.cpp
  src/settings/ovspatchsetting.h
  src/settings/ovspatchsetting_p.h
  src/settings/ovsportsetting.cpp
  src/settings/ovsportsetting.h
  src/settings/ovsportsetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17301: add documentation to result class

[Stefan Brüns]

bruns requested changes to this revision.
bruns added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> result.h:105
> +/**
> + * Contains all indexed data from the extractors
> + */

Only properties

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17301

To: astippich, #baloo, bruns
Cc: yurchor, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D17252: ovs-patch and ovs-port setting

[Jan Grulich]

jgrulich accepted this revision.
jgrulich added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> ovspatchsettingtest.cpp:30
> +#if !NM_CHECK_VERSION(1, 10, 0)
> +#define NM_SETTING_OVS_PATCH_SETTING_NAME   "ovs-patch"
> +#define NM_SETTING_OVS_PATCH_PEER   "peer"

This define is not necessary.

> ovsportsettingtest.cpp:30
> +#if !NM_CHECK_VERSION(1, 10, 0)
> +#define NM_SETTING_OVS_PORT_SETTING_NAME"ovs-port"
> +

This define is not necessary.

REPOSITORY
  R282 NetworkManagerQt

REVISION DETAIL
  https://phabricator.kde.org/D17252

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17312: Remove unused map() getter from Result

[Stefan Brüns]

bruns added a dependent revision: D17301: add documentation to result class.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17312

To: bruns, #baloo, #frameworks, astippich, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17301: add documentation to result class

[Stefan Brüns]

bruns added a dependency: D17312: Remove unused map() getter from Result.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17301

To: astippich, #baloo, bruns
Cc: yurchor, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D17301: add documentation to result class

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> result.h:83
> + */
>  void setDocument(const Baloo::Document& doc);
>  

The use case is missing here.
`Can be used to add extraction results to an existing Baloo::Document. Has to 
be called before passing the Result to KFileMetaData::Extractor::extract()`

> result.h:87
> + * Returns a QVariantMap containing all metadata fetched from the 
> extractors.
> + * The metadata is saved as 
> + */

Thats not correct, see implementation of `Result::add(...)`

`QString p = QString::number(propnum)`

But as m_map/map() is never used outside Result (only in Result::finish), it is 
best to remove the getter completely. D17312 


REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17301

To: astippich, #baloo, bruns
Cc: yurchor, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D17313: Use Compact json formatting for storing document metadata

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, astippich, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Document metadata is stored json encoded in the documentdatadb for fast
  retrieval. The default pretty-printed format adds useless whitespace:
  
  $> mdb_dump -p   -s documentdatadb  -n  ~/.local/share/baloo/index
  {\0a"26": 3648,\0a"27": 5472,\0a"30": "Canon",\0a
  
"31": "Canon EOS 70D",\0a"32": "2017-11-12T17:42:35.000Z",\0a
"33": 1,\0a"34": 9,\0a
"35": [\0a3648,\0a5472\0a],\0a
"37": "2017-11-11T16:54:57.000Z",\0a"38": 50,\0a
"40": 0.0166753590107,\0a"41": 3.20047683716,\0a
"42": 3.375,\0a"43": 0,\0a"44": 0,\0a"45": 5,\0a
"46": 800\0a}\0a
  
  Using the Compact encoding reduces the storage size significantly:
  {"26":3648,"27":5472,"30":"Canon","31":"Canon EOS 70D",
  "32":"2017-11-12T17:42:35.000Z","33":1,"34":9,"35":[3648,5472],
  "37":"2017-11-11T16:54:57.000Z","38":50,"40":0.0166753590107,
  "41":3.20047683716,"42":3.375,"43":0,"44":0,"45":5,"46":800}

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17313

AFFECTED FILES
  src/file/extractor/result.cpp

To: bruns, #baloo, #frameworks, astippich, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17298: remove unused doc_id from result

[Stefan Brüns]

bruns added a dependent revision: D17312: Remove unused map() getter from 
Result.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17298

To: astippich, #baloo, bruns
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17312: Remove unused map() getter from Result

[Stefan Brüns]

bruns created this revision.
bruns added reviewers: Baloo, Frameworks, astippich, ngraham.
Herald added projects: Frameworks, Baloo.
Herald added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.

REVISION SUMMARY
  The m_map is only used internally as a intermediate storage for metadata,
  it is never accessed from the outside.
  
  Depends on D17298 

TEST PLAN
  make

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17312

AFFECTED FILES
  src/file/extractor/result.cpp
  src/file/extractor/result.h

To: bruns, #baloo, #frameworks, astippich, ngraham
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17282: Use escaped UTF-8 sequence instead of Latin1 characters, minor cleanups

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:8efa39d4bbf1: Use escaped UTF-8 sequence instead of 
Latin1 characters, minor cleanups (authored by bruns).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17282?vs=46628&id=46712

REVISION DETAIL
  https://phabricator.kde.org/D17282

AFFECTED FILES
  autotests/unit/engine/termgeneratortest.cpp

To: bruns, #baloo, #frameworks, ngraham, astippich
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17298: remove unused doc_id from result

[Stefan Brüns]

bruns added a comment.


  Addition - the document id is also stored and can be retrieved from the 
Baloo::Document.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17298

To: astippich, #baloo, bruns
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17310: Improve Kile icon with LaTeX font

[TrickyRicky]

trickyricky26 edited the summary of this revision.
trickyricky26 edited the test plan for this revision.
trickyricky26 added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17310

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17310: Improve Kile icon with LaTeX font

[TrickyRicky]

trickyricky26 created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
trickyricky26 requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  improve-kile-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17310

AFFECTED FILES
  icons-dark/apps/48/kile.svg
  icons/apps/48/kile.svg

To: trickyricky26
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17302: add simple test for string merging

[Alexander Stippich]

astippich updated this revision to Diff 46710.
astippich marked 2 inline comments as done.
astippich added a comment.


  - small fixes

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17302?vs=46686&id=46710

BRANCH
  test_result

REVISION DETAIL
  https://phabricator.kde.org/D17302

AFFECTED FILES
  autotests/unit/file/CMakeLists.txt
  autotests/unit/file/resulttest.cpp

To: astippich, #baloo, bruns
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17302: add simple test for string merging

[Alexander Stippich]

astippich added inline comments.

INLINE COMMENTS

> bruns wrote in resulttest.cpp:40
> No need to reset the default constructed `Baloo::Document` with a default 
> constructed one.

Actually it is. The TermGenerators are otherwise only initialized with nullptr, 
and consequently will crash. That is something that should be fixed 
(separately).

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17302

To: astippich, #baloo, bruns
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D16826: Treat uints the same as ints

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R293:f6f9ecb2a17e: Treat uints the same as ints (authored by 
astippich).

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16826?vs=46679&id=46709

REVISION DETAIL
  https://phabricator.kde.org/D16826

AFFECTED FILES
  src/file/extractor/result.cpp

To: astippich, bruns, #baloo
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams

D17252: ovs-patch and ovs-port setting

[Pranav Gade]

pranavgade updated this revision to Diff 46708.
pranavgade marked 2 inline comments as done.

REPOSITORY
  R282 NetworkManagerQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17252?vs=46674&id=46708

REVISION DETAIL
  https://phabricator.kde.org/D17252

AFFECTED FILES
  autotests/settings/CMakeLists.txt
  autotests/settings/ovspatchsettingtest.cpp
  autotests/settings/ovspatchsettingtest.h
  autotests/settings/ovsportsettingtest.cpp
  autotests/settings/ovsportsettingtest.h
  src/CMakeLists.txt
  src/settings/ovspatchsetting.cpp
  src/settings/ovspatchsetting.h
  src/settings/ovspatchsetting_p.h
  src/settings/ovsportsetting.cpp
  src/settings/ovsportsetting.h
  src/settings/ovsportsetting_p.h
  src/settings/setting.cpp
  src/settings/setting.h

To: pranavgade, jgrulich
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17301: add documentation to result class

[Alexander Stippich]

astippich marked 4 inline comments as done.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17301

To: astippich, #baloo, bruns
Cc: yurchor, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D17301: add documentation to result class

[Alexander Stippich]

astippich updated this revision to Diff 46706.
astippich added a comment.


  - implement feedback

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17301?vs=46687&id=46706

BRANCH
  result_documentation

REVISION DETAIL
  https://phabricator.kde.org/D17301

AFFECTED FILES
  src/file/extractor/result.h

To: astippich, #baloo, bruns
Cc: yurchor, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D17299: move implementation of document get to cpp file

[Alexander Stippich]

astippich added a comment.


  Really just a cosmetic change for consistency, if you don't want it in, I'm 
fine with dropping it

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17299

To: astippich, #baloo, bruns
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17309: Add flashlight action icons

[TrickyRicky]

trickyricky26 edited the summary of this revision.
trickyricky26 edited the test plan for this revision.
trickyricky26 added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D17309

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17309: Add flashlight action icons

[TrickyRicky]

trickyricky26 created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
trickyricky26 requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  flashlight-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17309

AFFECTED FILES
  icons-dark/actions/16/flashlight-off.svg
  icons-dark/actions/16/flashlight-on.svg
  icons-dark/actions/22/flashlight-off.svg
  icons-dark/actions/22/flashlight-on.svg
  icons-dark/actions/24/flashlight-off.svg
  icons-dark/actions/24/flashlight-on.svg
  icons-dark/actions/32/flashlight-off.svg
  icons-dark/actions/32/flashlight-on.svg
  icons/actions/16/flashlight-off.svg
  icons/actions/16/flashlight-on.svg
  icons/actions/22/flashlight-off.svg
  icons/actions/22/flashlight-on.svg
  icons/actions/24/flashlight-off.svg
  icons/actions/24/flashlight-on.svg
  icons/actions/32/flashlight-off.svg
  icons/actions/32/flashlight-on.svg

To: trickyricky26
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17302: add simple test for string merging

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> resulttest.cpp:2
> +/*
> + * 
> + * Copyright (C) 2018 Alexander Stippich 

^_^

> resulttest.cpp:39
> +
> +Result 
> result(QStringLiteral("test"),QStringLiteral("audo/mpeg3"),KFileMetaData::ExtractionResult::ExtractEverything);
> +result.setDocument(doc);

Spaces and linebreaks ...

> resulttest.cpp:40
> +Result 
> result(QStringLiteral("test"),QStringLiteral("audo/mpeg3"),KFileMetaData::ExtractionResult::ExtractEverything);
> +result.setDocument(doc);
> +

No need to reset the default constructed `Baloo::Document` with a default 
constructed one.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17302

To: astippich, #baloo, bruns
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17299: move implementation of document get to cpp file

[Stefan Brüns]

bruns added a comment.


  Why?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17299

To: astippich, #baloo, bruns
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17301: add documentation to result class

[Stefan Brüns]

bruns added a comment.


  I think methods reimplemented from and documented in 
KFileMetaData::ExtractionResult should **not** be documented here.

INLINE COMMENTS

> result.h:38
> + * \brief The result class is where all the data extracted by
> + * the KFileMetaData extractors is saved to a Baloo::Document.
> + * It implements the KFileMetaData::ExtractionResult interface.

Remove the last part of the sentence - `... is saved to.`. Everything else is 
an implementation detail.

> result.h:40
> + * It implements the KFileMetaData::ExtractionResult interface.
> + * The resulting Baloo::Document can then be pushed into the
> + * database.

`The results can be retrieved as a Baloo::Document using \c document() and
stored in the database.`

> result.h:51
> +/**
> + * Overloaded function from KFileMetaData::ExtractionResult.
> + * Adds a key value pair which should be indexed.

This is no overload, but an override/reimplementation.

> result.h:54
> + *
> + * \param property This specifies a property name. It should be one of 
> the
> + * properties from the list of properties from KFileMetaData.

I think a `\sa KFileMetaData::Property` is sufficient here. Also, its not a 
property //name//, that would be something like a QString.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17301

To: astippich, #baloo, bruns
Cc: yurchor, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D16826: Treat uints the same as ints

[Stefan Brüns]

bruns accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  uint_double

REVISION DETAIL
  https://phabricator.kde.org/D16826

To: astippich, bruns, #baloo
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams

D17282: Use escaped UTF-8 sequence instead of Latin1 characters, minor cleanups

[Stefan Brüns]

bruns added a comment.


  Because the original file is latin1, thus not decodable as utf8, so it has to 
be binary ...
  Stupid arc/phabricator

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17282

To: bruns, #baloo, #frameworks, ngraham, astippich
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17305: Add KDE Connect SMS plugin

[Nicolas Fella]

nicolasfella edited the summary of this revision.
nicolasfella added a dependency: D17285: Add plugin type for sharing URLs.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D17305

To: nicolasfella, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17285: Add plugin type for sharing URLs

[Nicolas Fella]

nicolasfella added a dependent revision: D17305: Add KDE Connect SMS plugin.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D17285

To: nicolasfella, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17305: Add KDE Connect SMS plugin

[Nicolas Fella]

nicolasfella edited the summary of this revision.
nicolasfella added a dependency: D17292: [SMS App] Allow passing a message via 
args.

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D17305

To: nicolasfella, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17305: Add KDE Connect SMS plugin

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: apol.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Enable sharing links via KDE Connect SMS

TEST PLAN
  Send a page from Falkon via SMS

REPOSITORY
  R495 Purpose Library

BRANCH
  kdeconnectsms

REVISION DETAIL
  https://phabricator.kde.org/D17305

AFFECTED FILES
  src/plugins/CMakeLists.txt
  src/plugins/kdeconnect_sms/CMakeLists.txt
  src/plugins/kdeconnect_sms/Messages.sh
  src/plugins/kdeconnect_sms/kdeconnectsmsplugin.cpp
  src/plugins/kdeconnect_sms/kdeconnectsmsplugin.json

To: nicolasfella, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17295: BrightScript: Add function/sub folding

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R216:50a65cb06c37: BrightScript: Add function/sub folding 
(authored by dlevin, committed by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17295?vs=46667&id=46695

REVISION DETAIL
  https://phabricator.kde.org/D17295

AFFECTED FILES
  autotests/folding/brightscript.brs.fold
  data/syntax/brightscript.xml

To: dlevin, cullmann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17295: BrightScript: Add function/sub folding

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Ok, thanks!

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D17295

To: dlevin, cullmann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17282: Use escaped UTF-8 sequence instead of Latin1 characters, minor cleanups

[Alexander Stippich]

astippich accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

BRANCH
  submit

REVISION DETAIL
  https://phabricator.kde.org/D17282

To: bruns, #baloo, #frameworks, ngraham, astippich
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17282: Use escaped UTF-8 sequence instead of Latin1 characters, minor cleanups

[Alexander Stippich]

astippich added a comment.


  In D17282#369617 , @ngraham wrote:
  
  > Weird, why does Phabricator think `termgeneratortest.cpp` is a binary file?
  
  
  I'm wondering the same.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17282

To: bruns, #baloo, #frameworks, ngraham, astippich
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams

D17245: Add string formatting function to property info

[Alexander Stippich]

astippich updated this revision to Diff 46688.
astippich added a comment.


  - update strings for image orientation

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17245?vs=46509&id=46688

BRANCH
  display_value

REVISION DETAIL
  https://phabricator.kde.org/D17245

AFFECTED FILES
  CMakeLists.txt
  autotests/propertyinfotest.cpp
  autotests/propertyinfotest.h
  src/CMakeLists.txt
  src/formatstrings.cpp
  src/formatstrings.h
  src/propertyinfo.cpp
  src/propertyinfo.h

To: astippich, broulik, bruns, mgallien
Cc: ngraham, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, bruns, abrahams

D17301: add documentation to result class

[Alexander Stippich]

astippich marked 4 inline comments as done.
astippich added a comment.


  Thanks!

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17301

To: astippich, #baloo, bruns
Cc: yurchor, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D17301: add documentation to result class

[Alexander Stippich]

astippich updated this revision to Diff 46687.
astippich added a comment.


  - use param

REPOSITORY
  R293 Baloo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17301?vs=46684&id=46687

BRANCH
  result_documentation

REVISION DETAIL
  https://phabricator.kde.org/D17301

AFFECTED FILES
  src/file/extractor/result.h

To: astippich, #baloo, bruns
Cc: yurchor, kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D17302: add simple test for string merging

[Alexander Stippich]

astippich added a comment.


  Didn't found what I wanted to find, but since the code is there we can add it.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D17302

To: astippich, #baloo, bruns
Cc: kde-frameworks-devel, ashaposhnikov, michaelh, astippich, spoorun, ngraham, 
bruns, abrahams