D17949: ViewPrivate: Make applyWordWrap() more comfortable

[loh tar]

loh.tar added a comment.


  Interesting. Didn't know that such function exist. Well, it may help to read 
the handbook...
  Is there no GUI way to access such stuff? "Read the handbook" lala...
  
  Well, word/text wrapping is a field which has many room for improvements.
  
  - Adjust as block by inserting spaces at "smart" places to avoid ugly holes 
in the overall appearance
  - Wrap/split the word, not only text at a space. IIRC Is that somewhere done 
in Kate, or was there a function in Sonnet which offer that(?)
  - Your smart solution to allow in rare cases to extend the desired width
  - Probably some more I didn't know
  - Keep the indent: https://bugs.kde.org/show_bug.cgi?id=135737
  - Keep the indent and the "semantic", e.g. "Is comment" or "Is citation (like 
in e-mails)" https://bugs.kde.org/show_bug.cgi?id=369049
  
  As some of you know, I talk often about the latter two issues and I'm willing 
to fix that.
  The first three are really nice but more like the candy after the necessary 
lunch.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17949

To: loh.tar, #ktexteditor, mwolff
Cc: dhaumann, cullmann, mwolff, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, hase, michaelh, ngraham, bruns, demsking, sars

D18288: Make the clock svg's shadows more logically correct and visually appropriate

[Nathaniel Graham]

ngraham retitled this revision from "Give the clock svg's hour hand a shadow 
for the spindle" to "Make the clock svg's shadows more logically correct and 
visually appropriate".
ngraham edited the summary of this revision.
ngraham added a reviewer: Plasma.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18288

To: ngraham, #vdg, #plasma
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18288: Give the clock svg's hour hand a shadow for the spindle

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18288

To: ngraham, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18288: Give the clock svg's hour hand a shadow for the spindle

[Nathaniel Graham]

ngraham edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18288

To: ngraham, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18288: Give the clock svg's hour hand a shadow for the spindle

[Nathaniel Graham]

ngraham created this revision.
ngraham added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Give the clock's hour hand a shadow for the spindle too, since the shadow 
model we're using should logically have the spindle casting a shadow too.

TEST PLAN
  Before:
  
  After:
  
  There are no visual changes whatsoever because the hour hand shadow is not 
currently displayed (See D17751  for 
background)

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  clock-spindle-shadow (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18288

AFFECTED FILES
  src/desktoptheme/breeze/widgets/clock.svgz

To: ngraham, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18161: [WIP/RFC] [kioslave/file] Add a codec for legacy filenames

[Nerdopolis Turfwalker]

nerdopolist added a comment.


  I tried with my script that tried to reproduce that "kio skips files" issue
  https://raw.githubusercontent.com/n3rdopolis/otherstuff/master/kiocopy
  (changing the TEST_INVALID_UNICODE_CHARS=0 line to 
TEST_INVALID_UNICODE_CHARS=1 )
  and then letting it run.
  Unfortunately, I get "The file protocol died unexpectedly

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18161

To: cfeck, #frameworks, #dolphin, dfaure
Cc: nerdopolist, ngraham, kde-frameworks-devel, michaelh, bruns

D18282: document-new icon follow ColorScheme-Text

[Andreas Kainz]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:e3804e633e67: document-new icon follow ColorScheme-Text 
(authored by andreask).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18282?vs=49583=49585

REVISION DETAIL
  https://phabricator.kde.org/D18282

AFFECTED FILES
  icons-dark/actions/16/document-new.svg
  icons-dark/actions/22/document-new.svg
  icons-dark/actions/24/document-new.svg
  icons/actions/16/document-new.svg
  icons/actions/22/document-new.svg
  icons/actions/24/document-new.svg

To: andreask, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, andreaska, michaelh, bruns

D18282: document-new icon follow ColorScheme-Text

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Thanks, looks like this fixes it!

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18282

To: andreask, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, andreaska, michaelh, bruns

D18282: document-new icon follow ColorScheme-Text

[Andreas Kainz]

andreask created this revision.
andreask added a reviewer: VDG.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
andreask requested review of this revision.

REVISION SUMMARY
  icon follow now ColorScheme-Text color

TEST PLAN
  change to breeze-dark and open kwrite the new icon didn't use the text color

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18282

AFFECTED FILES
  icons-dark/actions/16/document-new.svg
  icons-dark/actions/22/document-new.svg
  icons-dark/actions/24/document-new.svg
  icons/actions/16/document-new.svg
  icons/actions/22/document-new.svg
  icons/actions/24/document-new.svg

To: andreask, #vdg
Cc: kde-frameworks-devel, andreaska, michaelh, ngraham, bruns

D18164: Review KateGotoBar

[Dominik Haumann]

dhaumann added a comment.


  Indeed I misread the screenshot - sorry for that :-) In that case, I have no 
objections. @cullmann your take?

REVISION DETAIL
  https://phabricator.kde.org/D18164

To: loh.tar, #ktexteditor
Cc: dhaumann, cullmann, anthonyfieroni, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, hase, michaelh, ngraham, bruns, demsking, sars

D18277: Add a new preferences-desktop-theme-global icon

[TrickyRicky]

trickyricky26 planned changes to this revision.
trickyricky26 added a comment.


  I will make a variant with a titlebar that is split between a light and dark 
variant (like `preferences-desktop-theme`) as well as the bottom panel in the 
same style.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18277

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18163: KateRenderer: when printing initially set the color scheme to Printing

[Ahmad Samir]

ahmadsamir added a comment.


  @dhaumann: in the screenshot that's "file -> print"; the issue here is with 
"file -> print preview", where the extra options tabs (including "Layout") 
aren't added by ktexteditor. :)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18163

To: ahmadsamir, cullmann, #ktexteditor, dhaumann, mwolff
Cc: mwolff, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D18277: Add a new preferences-desktop-theme-global icon

[TrickyRicky]

trickyricky26 retitled this revision from "Add a new preferences-desktop-theme 
icon, rename the old one" to "Add a new preferences-desktop-theme-global icon".
trickyricky26 edited the summary of this revision.
trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18277

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18277: Add a new preferences-desktop-theme icon, rename the old one

[TrickyRicky]

trickyricky26 updated this revision to Diff 49573.
trickyricky26 added a comment.


  - Change name to preferences-desktop-theme-global

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18277?vs=49565=49573

BRANCH
  new-pref-theme-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18277

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-theme-global.svg
  icons-dark/preferences/32/preferences-desktop-theme.svg
  icons/preferences/32/preferences-desktop-theme-global.svg
  icons/preferences/32/preferences-desktop-theme.svg

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18278: Add a preferences-system-splash icon for the Splash Screen KCM

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:fe8f60030d00: Add a preferences-system-splash icon for 
the Splash Screen KCM (authored by trickyricky26, committed by ngraham).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18278?vs=49566=49568

REVISION DETAIL
  https://phabricator.kde.org/D18278

AFFECTED FILES
  icons-dark/preferences/32/preferences-system-splash.svg
  icons/preferences/32/preferences-system-splash.svg

To: trickyricky26, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18278: Add a preferences-system-splash icon for the Splash Screen KCM

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Love it

REPOSITORY
  R266 Breeze Icons

BRANCH
  preferences-splash-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18278

To: trickyricky26, #vdg, ngraham
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18278: Add a preferences-system-splash icon for the Splash Screen KCM

[TrickyRicky]

trickyricky26 edited the summary of this revision.
trickyricky26 edited the test plan for this revision.
trickyricky26 added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18278

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18277: Add a new preferences-desktop-theme icon, rename the old one

[Nathaniel Graham]

ngraham added a comment.


  Actually now that I think about it, the name 
`preferences-desktop-theme-global` might be better because then if the icon 
doesn't exist, it will fall back to `preferences-desktop-theme` (which does 
exist) instead of `preferences-desktop-global` (which doesn't).

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18277

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18278: Add a preferences-system-splash icon for the Splash Screen KCM

[TrickyRicky]

trickyricky26 created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
trickyricky26 requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  preferences-splash-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18278

AFFECTED FILES
  icons-dark/preferences/32/preferences-system-splash.svg
  icons/preferences/32/preferences-system-splash.svg

To: trickyricky26
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18277: Add a new preferences-desktop-theme icon, rename the old one

[TrickyRicky]

trickyricky26 edited the summary of this revision.
trickyricky26 edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18277

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18277: Add a new preferences-desktop-theme icon, rename the old one

[TrickyRicky]

trickyricky26 updated this revision to Diff 49565.
trickyricky26 added a comment.


  - Revert renaming of old icon; name the new icon 
preferences-desktop-global-theme

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18277?vs=49561=49565

BRANCH
  new-pref-theme-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18277

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-global-theme.svg
  icons-dark/preferences/32/preferences-desktop-theme.svg
  icons/preferences/32/preferences-desktop-global-theme.svg
  icons/preferences/32/preferences-desktop-theme.svg

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18164: Review KateGotoBar

[loh tar]

loh.tar added a comment.


  > I have the feeling it adds more clutter than it helps by default:
  
  Code clutter or what? The functionality is lovely and I can't see in which 
way It may someone jar
  
  > I thinkis quite fast.
  
  For a keyboard-virtuoso for sure. I'm one of those who use often the mouse.
  
  > this leads to having "Gehe zu" twice in the ui, which is a bit confusing 
imho. Other opinions?
  
  Um, I think you misread my post. That's my comment to the current situation, 
without this patch(?) With patch is the pic in the test plan.
  
  Regarding code comments, will fix it when it got in general an "OK"

REVISION DETAIL
  https://phabricator.kde.org/D18164

To: loh.tar, #ktexteditor
Cc: dhaumann, cullmann, anthonyfieroni, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, hase, michaelh, ngraham, bruns, demsking, sars

D18163: KateRenderer: when printing initially set the color scheme to Printing

[Dominik Haumann]

dhaumann requested changes to this revision.
dhaumann added a comment.
This revision now requires changes to proceed.


  Looking at the printing pages, I can find the following, see screenshot. 
Please note the ComboBox where you can select a printing schema. In other 
words, this should not be hard-coded, I think it should be explicitly set 
somewhere to what's specified in this combobox. @ahmadsamir Can you have a look 
again?
  
  F6550687: image.png 

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18163

To: ahmadsamir, cullmann, #ktexteditor, dhaumann, mwolff
Cc: mwolff, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D18277: Add a new preferences-desktop-theme icon, rename the old one

[TrickyRicky]

trickyricky26 planned changes to this revision.
trickyricky26 added a comment.


  In D18277#393868 , @ngraham wrote:
  
  > Recommendation:
  >
  > - In this patch, just create a new LnF/Global theme icon with a new name. 
Maybe `preferences-desktop-global-theme`?
  > - I rename `preferences-desktop-theme` to 
`preferences-desktop-application-theme` and put a compatibility symlink in place
  > - Over time, we port all existing users of `preferences-desktop-theme` to 
use `preferences-desktop-application-theme` instead
  > - Once there are no more users, we delete the compatibility symlink for 
`preferences-desktop-theme`
  >
  >   Thoughts?
  
  
  Sure, I just chose the naming from a suggestion in the chat. I will update 
the diff with the new icon called `preferences-desktop-global-theme`.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18277

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17949: ViewPrivate: Make applyWordWrap() more comfortable

[Dominik Haumann]

dhaumann added a comment.


  @loh.tar Slightly related: You may want to also have a look at this: 
https://phabricator.kde.org/source/ktexteditor/browse/master/src/script/data/commands/utils.js$271
  In short, there is a command line command (F7) called 'rewrap' that rewraps 
the selection in a "smart" way. My idea when writing this once was:
  
  1. there is a target wrap column, say 80
  2. there is a soft violation wrap column, say 82
  3. there is a minimum wrap column, say 70
  
  Now, lets take the following example:
  
 1 2 3 4 5 6 7  
   8

1234567890123456789012345678901234567890123456789012345678901234567890123456789012345
the quick brown fox jumps of the lazy dog. The bla bla bla bla bla 
aRatherLongWord
  
  Now, usually, aRatherLongWord would wrap to the next line, since it is longer 
that column 80. However, it leaves a "big gap" starting at column <70 (cf. 3. 
soft wrap above) in the end of the line, which is visually not so appealing ;) 
So in this case, we allow violation of the hard-wrap at 80, and instead allow a 
violation up to column 82 (cf. 2. above).
  
  With this, you can for instance nicely rewrap a TeX document so that you can 
nicely read it without too big gaps at the end of a line.
  
  However, to be honest, I don't even know whether I ever finished the 
implementation, so maybe rewrap even does something different...

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17949

To: loh.tar, #ktexteditor, mwolff
Cc: dhaumann, cullmann, mwolff, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, hase, michaelh, ngraham, bruns, demsking, sars

D18277: Add a new preferences-desktop-theme icon, rename the old one

[Nathaniel Graham]

ngraham added a comment.


  Recommendation:
  
  - In this patch, just create a new LnF/Global theme icon with a new name. 
Maybe `preferences-desktop-global-theme`?
  - I rename `preferences-desktop-theme` to 
`preferences-desktop-application-theme` and put a compatibility symlink in place
  - Over time, we port all existing users of `preferences-desktop-theme` to use 
`preferences-desktop-application-theme` instead
  - Once there are no more users, we delete the compatibility symlink for 
`preferences-desktop-theme`
  
  Thoughts?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18277

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18277: Add a new preferences-desktop-theme icon, rename the old one

[Nathaniel Graham]

ngraham added a comment.


  Just so you know, there are a lot of users for `preferences-desktop-theme`: 
https://lxr.kde.org/search?_filestring=&_string=preferences-desktop-theme
  
  It's always good to do a search like this before you change the meaning of 
existing icons--even ones that are named poorly like this one.
  
  I wonder if might be a better idea to leave the existing icon alone and 
create a new one rather than changing the meaning of 
`preferences-desktop-theme`.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18277

To: trickyricky26, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D18277: Add a new preferences-desktop-theme icon, rename the old one

[Nathaniel Graham]

ngraham retitled this revision from "Add a new preference-desktop-theme icon, 
rename the old one" to "Add a new preferences-desktop-theme icon, rename the 
old one".
ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18277

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18277: Add a new preference-desktop-theme icon, rename the old one

[TrickyRicky]

trickyricky26 edited the summary of this revision.
trickyricky26 edited the test plan for this revision.
trickyricky26 added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18277

To: trickyricky26, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18277: Add a new preference-desktop-theme icon, rename the old one

[TrickyRicky]

trickyricky26 created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
trickyricky26 requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  new-pref-theme-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18277

AFFECTED FILES
  icons-dark/preferences/32/preferences-desktop-applicationtheme.svg
  icons-dark/preferences/32/preferences-desktop-theme.svg
  icons/preferences/32/preferences-desktop-applicationtheme.svg
  icons/preferences/32/preferences-desktop-theme.svg

To: trickyricky26
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17932: Improvements to completion

[Milian Wolff]

mwolff accepted this revision as: mwolff.
mwolff added a comment.


  @brauch, @kfunk what do you say?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17932

To: thomassc, #ktexteditor, #kdevelop, mwolff
Cc: apol, kfunk, brauch, mwolff, cullmann, kwrite-devel, kde-frameworks-devel, 
hase, michaelh, ngraham, bruns, demsking, head7, sars, dhaumann

D11236: [KCrash] Establish socket to allow change of ptrace scope

[Oswald Buddenhagen]

ossi added a comment.


  In D11236#393789 , @ossi wrote:
  
  > detaching via double fork() "protects" the child process,
  
  
  
  
  > but does *not* break the permission inheritance.
  
  ok, i take that back and claim the opposite - i misinterpreted the kernel's 
task_struct's real_parent member's purpose.
  
  that also means that the kernel doc is mildly misleading ("descendant" 
clearly refers to the current relationship after possible re-parenting, not the 
real ancestry at time of forking), but i suppose one is expected to know the 
exact definitions of the used terminology.

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D11236

To: croick, #frameworks, ossi
Cc: dfaure, lepagevalleeemmanuel, kde-frameworks-devel, sitter, michaelh, 
ngraham, bruns

D14631: Adds a new RenameDialog to KIO with more options for batch renaming

[Emirald Mateli]

emateli planned changes to this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D14631

To: emateli, #frameworks, dfaure, mlaurent
Cc: chinmoyr, mlaurent, asensi, rkflx, dfaure, aacid, ngraham, 
kde-frameworks-devel, michaelh, bruns

D18164: Review KateGotoBar

[Dominik Haumann]

dhaumann added a comment.


  I like the idea to go to next modified line up / down. I am undecided about 
the goto line in clipboard, since I have the feeling it adds more clutter than 
it helps by default: I thinkis quite fast. In 
addition, this leads to having "Gehe zu" twice in the ui, which is a bit 
confusing imho. Other opinions?

INLINE COMMENTS

> katedialogs.cpp:1099
> +btn->setIcon(QIcon::fromTheme(QStringLiteral("go-up-search")));
> +btn->setText(QStringLiteral(""));
> +btn->installEventFilter(this);

Please always use QString() in favor of QStringLiteral("")

> katedialogs.cpp:1156
> +message->setAutoHide(2000); // FIXME Timer is not started as I would 
> expect, only after some "unclear" event
> +message->setPosition(KTextEditor::Message::BottomInView);
> +m_view->document()->postMessage(message);

You should also call message->setView(m_view), otherwise the message appears in 
all views, in case you have multiple views of a document.

> katedialogs.h:103
> +QSpinBox *m_gotoRange = nullptr;
> +QToolButton *m_ModifiedUp = nullptr;
> +QToolButton *m_ModifiedDown = nullptr;

Could you use lowercase naming here? m_modifiedUp instead of m_ModifiedUp?

REVISION DETAIL
  https://phabricator.kde.org/D18164

To: loh.tar, #ktexteditor
Cc: dhaumann, cullmann, anthonyfieroni, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, hase, michaelh, ngraham, bruns, demsking, sars

D11236: [KCrash] Establish socket to allow change of ptrace scope

[Oswald Buddenhagen]

ossi added a comment.


  In D11236#393720 , @croick wrote:
  
  > Actually it's only the internal process that creates the backtraces, that 
is a descendant of DrKonqi. All debuggers that are launched via the "Debug" 
button are processes on their own (to remain alive, even if DrKonqi already 
quit).
  
  
  if by that you're implying that external debuggers are always launched via 
kdeinit, then please put that as the reason in the commit message.
  irrespective of that, the "to remain alive" argument is bogus, because 
detaching via double fork() (as qprocess does) "protects" the child process, 
but does *not* break the permission inheritance.

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D11236

To: croick, #frameworks, ossi
Cc: dfaure, lepagevalleeemmanuel, kde-frameworks-devel, sitter, michaelh, 
ngraham, bruns

D18274: Make notifications work on Android with API level < 23

[Volker Krause]

vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  At API level < 23 we cannot set a custom icon but have to use a static one
  from the Android resource system, so let's use the application icon for
  that (without setting an icon Android isn't showing the notification).

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18274

AFFECTED FILES
  src/android/org/kde/knotifications/NotifyByAndroid.java

To: vkrause
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.12 - Build # 16 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.12/16/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 15 Jan 2019 18:08:14 +
 Build duration:
6 min 26 sec and counting
   JUnit Tests
  Name: projectroot Failed: 4 test(s), Passed: 48 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_dropjobtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.src.ioslaves.trash.tests.testtrashName: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » knotifications » kf5-qt5 AndroidQt5.11 - Build # 11 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20AndroidQt5.11/11/
 Project:
kf5-qt5 AndroidQt5.11
 Date of build:
Tue, 15 Jan 2019 18:03:34 +
 Build duration:
46 sec and counting
   CONSOLE OUTPUT
  [...truncated 211 lines...] * Qt5TextToSpeech, Qt text to speech module   Required to build text to speech notification support * PkgConfig * Qt5Test (required version >= 5.10.0)-- The following REQUIRED packages have been found: * ECM (required version >= 5.54.0), Extra CMake Modules.,  * Qt5Gui (required version >= 5.11.3) * Qt5Widgets * Qt5AndroidExtras * Gradle * Qt5 (required version >= 5.10.0) * Qt5Core * KF5WindowSystem (required version >= 5.54.0) * KF5Config (required version >= 5.54.0) * KF5Codecs (required version >= 5.54.0) * KF5CoreAddons (required version >= 5.54.0)-- The following features have been disabled: * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- The following OPTIONAL packages have not been found: * X11 * Canberra, Library for generating event sounds,Needed to build audio notification support * Phonon4Qt5 (required version >= 4.6.60), Qt-based audio library   Needed to build audio notification support when Canberra isn't available * dbusmenu-qt5, DBusMenuQt,Support for notification area menus via the DBusMenu protocol-- Configuring done-- Generating done-- Build files have been written to: /home/user/workspace/Frameworks/knotifications/kf5-qt5 AndroidQt5.11/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh+ python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project knotifications --branchGroup kf5-qt5 --platform AndroidQt5.11 --usingInstall /home/user/install-prefix/Scanning dependencies of target gradleScanning dependencies of target KF5Notifications_autogen[ 10%] Automatic MOC for target KF5Notifications[ 10%] Generating gradle/gradlew[ 10%] Built target gradleScanning dependencies of target knotifications_aar[ 15%] Generating gradle_build/KF5Notifications/build/outputs/aar/KF5Notifications-debug.aar[ 15%] Built target KF5Notifications_autogen[ 20%] Automatic RCC for knotifications.qrcScanning dependencies of target KF5Notifications[ 25%] Building CXX object src/CMakeFiles/KF5Notifications.dir/knotification.cpp.o[ 30%] Building CXX object src/CMakeFiles/KF5Notifications.dir/knotificationmanager.cpp.o[ 35%] Building CXX object src/CMakeFiles/KF5Notifications.dir/kpassivepopup.cpp.o[ 40%] Building CXX object src/CMakeFiles/KF5Notifications.dir/knotifyconfig.cpp.o[ 45%] Building CXX object src/CMakeFiles/KF5Notifications.dir/knotificationplugin.cpp.o[ 50%] Building CXX object src/CMakeFiles/KF5Notifications.dir/notifybypopupgrowl.cpp.o[ 55%] Building CXX object src/CMakeFiles/KF5Notifications.dir/notifybyexecute.cpp.o[ 60%] Building CXX object src/CMakeFiles/KF5Notifications.dir/notifybylogfile.cpp.oStarting a Gradle Daemon, 1 incompatible and 1 stopped Daemons could not be reused, use --status for details[ 65%] Building CXX object src/CMakeFiles/KF5Notifications.dir/notifybytaskbar.cpp.o[ 70%] Building CXX object src/CMakeFiles/KF5Notifications.dir/ECMQmLoader-knotifications5_qt.cpp.o[ 75%] Building CXX object src/CMakeFiles/KF5Notifications.dir/notifybyandroid.cpp.o[ 80%] Building CXX object src/CMakeFiles/KF5Notifications.dir/debug_p.cpp.o[ 85%] Building CXX object src/CMakeFiles/KF5Notifications.dir/notifybytts.cpp.o[ 90%] Building CXX object src/CMakeFiles/KF5Notifications.dir/KF5Notifications_autogen/mocs_compilation.cpp.o[ 95%] Building CXX object src/CMakeFiles/KF5Notifications.dir/KF5Notifications_autogen/EWIEGA46WW/qrc_knotifications.cpp.oFAILURE: Build failed with an exception.* Where:Build file '/home/user/workspace/Frameworks/knotifications/kf5-qt5 AndroidQt5.11/build/src/android/gradle_build/KF5Notifications/build.gradle' line: 3* What went wrong:A problem occurred evaluating root project 'KF5Notifications'.> Could not find method google() for arguments [] on repository container of type org.gradle.api.internal.artifacts.dsl.DefaultRepositoryHandler.* Try:Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.BUILD FAILEDTotal time: 2.892 secs[100%] Linking CXX shared library ../bin/libKF5Notifications.so[100%] Built target KF5Notificationssrc/android/CMakeFiles/knotifications_aar.dir/build.make:65: recipe for target 'src/android/gradle_build/KF5Notifications/build/outputs/aar/KF5Notifications-debug.aar' failedmake[2]: *** [src/android/gradle_build/KF5Notifications/build/outputs/aar/KF5Notifications-debug.aar] Error 1CMakeFiles/Makefile2:276: recipe for target 'src/android/CMakeFiles/knotifications_aar.dir/all' failedmake[1]: *** [src/android/CMakeFiles/knotifications_aar.dir/all] Error 2Makefile:140: recipe for target 'all' failedmake: *** [all] Error 2[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit 

D18253: Move the Android API level checks to runtime

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R289:e9a35ccb2a60: Move the Android API level checks to 
runtime (authored by vkrause).

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18253?vs=49486=49550

REVISION DETAIL
  https://phabricator.kde.org/D18253

AFFECTED FILES
  src/CMakeLists.txt
  src/android/org/kde/knotifications/KNotification.java
  src/android/org/kde/knotifications/NotifyByAndroid.java
  src/knotificationmanager.cpp
  src/notifybyandroid.cpp

To: vkrause, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D18253: Move the Android API level checks to runtime

[Volker Krause]

vkrause added a comment.


  In D18253#393283 , @apol wrote:
  
  > Maybe we could print something for adb logcat that says that notifications 
won't be working?
  
  
  Android itself is already doing that. And support for older API levels is 
hopefully not too far away either :)

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18253

To: vkrause, apol
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.12 - Build # 15 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/15/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 15 Jan 2019 17:28:23 +
 Build duration:
4 min 56 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 60 test(s), Skipped: 0 test(s), Total: 61 test(s)Failed: projectroot.autotests.kateindenttest_testCppstyleName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

D17852: ViewInternal: Fix 'Go to matching bracket' in override mode

[Dominik Haumann]

dhaumann closed this revision.
dhaumann added a comment.


  Closed, see commit 1e0ace28c795cbe5e88bc1f31ea37a250cd110b0

REVISION DETAIL
  https://phabricator.kde.org/D17852

To: loh.tar, #ktexteditor, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, 
ngraham, bruns, demsking, cullmann, sars

D17852: ViewInternal: Fix 'Go to matching bracket' in override mode

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Good patch, and works for me.

REVISION DETAIL
  https://phabricator.kde.org/D17852

To: loh.tar, #ktexteditor, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, 
ngraham, bruns, demsking, cullmann, sars

D11236: [KCrash] Establish socket to allow change of ptrace scope

[Christoph Roick]

croick added a comment.


  In D11236#393063 , @ossi wrote:
  
  > yay, i finally have "some" time for this. ^^
  
  
  Great! :) And thanks for your input.
  
  > it took me a while to get a coherent picture of the problem and solution, 
because your description unnecessarily dwells on the irrelevant cases of ptrace 
restrictions, but omits the crucial fact that this is about tracers that are 
not descendant processes of drkonqi, specifically kdevelop launched via 
kdeinit. see also comment on DefaultDebuggerLauncher in the complementary 
change. please make sure to point that out in the commit messages.
  
  Actually it's only the internal process that creates the backtraces, that is 
a descendant of DrKonqi. All debuggers that are launched via the "Debug" button 
are processes on their own (to remain alive, even if DrKonqi already quit). But 
I will change the commit message to point that out.

INLINE COMMENTS

> ossi wrote in kcrash.cpp:655
> you need to cover that branch as well.

What an oversight :/ Will do of course.

REPOSITORY
  R285 KCrash

REVISION DETAIL
  https://phabricator.kde.org/D11236

To: croick, #frameworks, ossi
Cc: dfaure, lepagevalleeemmanuel, kde-frameworks-devel, sitter, michaelh, 
ngraham, bruns

D17938: Add support for passing cursor information to KRun.

[Gleb Popov]

arrowd abandoned this revision.
arrowd added a comment.


  Right.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17938

To: arrowd, #frameworks
Cc: aacid, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D17938: Add support for passing cursor information to KRun.

[Elvis Angelaccio]

elvisangelaccio added a comment.


  @arrowd I see you landed D18099 , so this 
can be discarded, right?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D17938

To: arrowd, #frameworks
Cc: aacid, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D17128: WIP DocumentPrivate: Remove all from next line which may annoying when joining lines

[loh tar]

loh.tar added a comment.


  > can you please rephrase the title of this review to make it understandable?
  
  Of course, if I could, I would have done it :-) "Remove all what is not nice 
text" ? It may help you to read all posts to get a hint of my intention.
  It turned out that this here ist still not working charming. Sometimes is 
still stuff removed which shouldn't.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17128

To: loh.tar, #ktexteditor, cullmann, mwolff
Cc: mwolff, dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, hase, michaelh, ngraham, bruns, demsking, head7, kfunk, sars

D18149: Share Plasma::Theme instances between multiple ColorScope

[Kai Uwe Broulik]

broulik updated this revision to Diff 49537.
broulik retitled this revision from "Share Plasma::Theme instances between 
multiple Svg and ColorScope" to "Share Plasma::Theme instances between multiple 
ColorScope".
broulik edited the test plan for this revision.
broulik added a comment.


  Focus on `ColorScope` for now, `Svg` is a tad more difficult.
  
  - Use `QSharedPointer`

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18149?vs=49139=49537

REVISION DETAIL
  https://phabricator.kde.org/D18149

AFFECTED FILES
  src/declarativeimports/core/colorscope.cpp
  src/declarativeimports/core/colorscope.h

To: broulik, #plasma
Cc: apol, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D17949: ViewPrivate: Make applyWordWrap() more comfortable

[loh tar]

loh.tar added subscribers: cullmann, dhaumann.
loh.tar added a comment.


  > please add proper tests for this functionality
  
  No idea how
  
  Because  there are a couple of bug reports where often the response was like 
"No, can't be done" need this a closer look from @dhaumann and @cullmann

INLINE COMMENTS

> mwolff wrote in kateview.cpp:2355
> store in a std::unique_ptr and remove the manual `delete` further down below

fine, will do it

> mwolff wrote in kateview.cpp:2359
> bool shouldWrap = true;

I dislike that. I hope someone else like my goto way

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17949

To: loh.tar, #ktexteditor, mwolff
Cc: dhaumann, cullmann, mwolff, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, hase, michaelh, ngraham, bruns, demsking, sars

D18263: [CopyJob] Provide more descriptive notification header

[Chinmoy Ranjan Pradhan]

chinmoyr added a comment.


  They emit a generic message. A descriptive message can only generated from 
within job.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18263

To: chinmoyr, dfaure, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14661: Force reevaluation of Predicates if interfaces are removed

[Alexander Volkov]

volkov added a comment.


  Looks like the bug is caused by removing the line "updateBackend(udi);"

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D14661

To: bruns, #frameworks, broulik, ngraham, apol
Cc: volkov, apol, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D18149: Share Plasma::Theme instances between multiple Svg and ColorScope

[Kai Uwe Broulik]

broulik added a comment.


  > And QSharedDataPointer?
  
  For that `Theme` would need to be `QSharedData`, no?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D18149

To: broulik, #plasma
Cc: apol, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D14661: Force reevaluation of Predicates if interfaces are removed

[Kai Uwe Broulik]

broulik added a comment.


  So, looks like adding the device causes us to probe it and that prompts 
UDisks to close the tray for examination? I lack a CD drive, so I cannot try 
this. Can you perhaps investigate this issue? :)
  
  Easiest could be to check for device type and then in doubt just don't do the 
remove-add-dance in case it's an optical drive.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D14661

To: bruns, #frameworks, broulik, ngraham, apol
Cc: volkov, apol, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D17852: ViewInternal: Fix 'Go to matching bracket' in override mode

[loh tar]

loh.tar updated this revision to Diff 49530.
loh.tar added a comment.


  Add autotest

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17852?vs=48340=49530

REVISION DETAIL
  https://phabricator.kde.org/D17852

AFFECTED FILES
  autotests/src/kateview_test.cpp
  autotests/src/kateview_test.h
  src/view/kateviewinternal.cpp

To: loh.tar, #ktexteditor
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, 
ngraham, bruns, demsking, cullmann, sars

D14661: Force reevaluation of Predicates if interfaces are removed

[Alexander Volkov]

volkov added a comment.


  This change causes a bug: when you eject a mounted CD from the applet, then 
CD-ROM tray closes immediately after ejecting.

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D14661

To: bruns, #frameworks, broulik, ngraham, apol
Cc: volkov, apol, anthonyfieroni, kde-frameworks-devel, michaelh, ngraham, bruns

D18163: KateRenderer: when printing initially set the color scheme to Printing

[Milian Wolff]

mwolff accepted this revision as: mwolff.
mwolff added a comment.
This revision is now accepted and ready to land.


  lgtm, @cullmann @dhaumann? could the schema name be translated (I hope not)?

REPOSITORY
  R39 KTextEditor

BRANCH
  print-preview-text-color

REVISION DETAIL
  https://phabricator.kde.org/D18163

To: ahmadsamir, cullmann, #ktexteditor, dhaumann, mwolff
Cc: mwolff, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D17949: ViewPrivate: Make applyWordWrap() more comfortable

[Milian Wolff]

mwolff requested changes to this revision.
mwolff added a comment.
This revision now requires changes to proceed.


  I like what I'm seeing in the screenshot, but please add proper tests for 
this functionality

INLINE COMMENTS

> kateview.cpp:2355
> +// Because we shrink and expand lines, we need a powerful "Moving Cursor"
> +KTextEditor::MovingCursor *curr = 
> doc()->newMovingCursor(KTextEditor::Cursor(selectionRange().start()));
> +

store in a std::unique_ptr and remove the manual `delete` further down below

> kateview.cpp:2359
> +for (int line = first; line <= selectionRange().end().line(); ++line) {
> +// Is our first line a somehow filled line?
> +while(doc()->plainKateTextLine(first)->firstChar() < 0) {

bool shouldWrap = true;

> kateview.cpp:2366
> +// C++ can only continue the inner loop, but we need here to 
> continue our "for" loop
> +goto NextLine;
> +}

shouldWrap = false;
break;

> kateview.cpp:2370
> +// Is our current line a somehow filled line? If not, wrap the 
> paragraph
> +if (doc()->plainKateTextLine(line)->firstChar() < 0) {
> +curr->setPosition(line, 0); // Set on empty line

if (!shouldWrap) {
  continue;
  }

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17949

To: loh.tar, #ktexteditor, mwolff
Cc: mwolff, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D18263: [CopyJob] Provide more descriptive notification header

[Kai Uwe Broulik]

broulik added a comment.


  Isn't that done by `emitCopying` et al?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18263

To: chinmoyr, dfaure, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18263: [CopyJob] Provide more descriptive notification header

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
chinmoyr added reviewers: dfaure, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
chinmoyr requested review of this revision.

REVISION SUMMARY
  A job can internally set a more descriptive title or a generic title will be 
provided for
  the notification applet.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18263

AFFECTED FILES
  src/core/copyjob.cpp
  src/core/job.cpp
  src/core/job_p.h

To: chinmoyr, dfaure, broulik
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17128: WIP DocumentPrivate: Remove all from next line which may annoying when joining lines

[Milian Wolff]

mwolff requested changes to this revision.
mwolff added a comment.
This revision now requires changes to proceed.


  can you please rephrase the title of this review to make it understandable? 
"Remove all" - what do you remove? All what?
  
  Also, can you please add tests for the feature you are adding, this also acts 
as documentation on what this patch actually does

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D17128

To: loh.tar, #ktexteditor, cullmann, mwolff
Cc: mwolff, dhaumann, cullmann, kwrite-devel, kde-frameworks-devel, 
#ktexteditor, hase, michaelh, ngraham, bruns, demsking, head7, kfunk, sars

D18174: Ruby: fix RegExp after ": " and fix/improve detection of HEREDOC

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  I am no Ruby expert, but your screenshots show a clear improvement, please 
push ;=)
  Thanks for the improvement + tests!

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix-ruby

REVISION DETAIL
  https://phabricator.kde.org/D18174

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » knotifications » kf5-qt5 WindowsMSVCQt5.11 - Build # 32 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/knotifications/job/kf5-qt5%20WindowsMSVCQt5.11/32/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Tue, 15 Jan 2019 09:31:54 +
 Build duration:
43 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.KNotificationTest